⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 28, 2010:

11:58 PM Changeset in webkit [70847] by morrita@google.com
  • 9 edits
    2 adds in trunk/WebCore

2010-10-26 MORITA Hajime <​morrita@google.com>

Reviewed by Kent Tamura.

Refactoring: Spellchecking related static functions could form a class
​https://bugs.webkit.org/show_bug.cgi?id=48287

Extracted spellcheck related static functions to TextCheckingHelper class,
which has EditorClient and Range as its member.

No new tests. Just a refactoring.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • editing/Editor.cpp: (WebCore::Editor::advanceToNextMisspelling): (WebCore::Editor::isSelectionUngrammatical): (WebCore::Editor::guessesForUngrammaticalSelection): (WebCore::Editor::guessesForMisspelledOrUngrammaticalSelection): (WebCore::Editor::markMisspellingsAfterTypingToPosition): (WebCore::Editor::markMisspellingsOrBadGrammar): (WebCore::Editor::markMisspellings): (WebCore::Editor::markBadGrammar): (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): (WebCore::Editor::changeBackToReplacedString):
  • editing/Editor.h:
  • editing/TextCheckingHelper.cpp: Added. (WebCore::TextCheckingHelper::TextCheckingHelper): (WebCore::TextCheckingHelper::~TextCheckingHelper): (WebCore::TextCheckingHelper::paragraphAlignedRange): (WebCore::TextCheckingHelper::findFirstMisspelling): (WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar): (WebCore::TextCheckingHelper::findFirstGrammarDetail): (WebCore::TextCheckingHelper::findFirstBadGrammar): (WebCore::TextCheckingHelper::isUngrammatical): (WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange): (WebCore::TextCheckingHelper::markAllMisspellings): (WebCore::TextCheckingHelper::markAllBadGrammar):
  • editing/TextCheckingHelper.h: Added.
11:55 PM Changeset in webkit [70846] by abarth@webkit.org
  • 13 edits
    1 add in trunk

2010-10-28 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel, Peter Kasting, and Darin Fisher.
(Eric reviewed the CoreGraphics interactions, Peter reviewed the image
decoder interaction, and Darin Fisher SGTMed the policy decision.)

[chromium] Chromium Mac should use WebKit's image decoders
​https://bugs.webkit.org/show_bug.cgi?id=47974

Enable WebKit's image decoders.

  • features.gypi:

2010-10-28 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel, Peter Kasting, and Darin Fisher.
(Eric reviewed the CoreGraphics interactions, Peter reviewed the image
decoder interaction, and Darin Fisher SGTMed the policy decision.)

[chromium] Chromium Mac should use WebKit's image decoders
​https://bugs.webkit.org/show_bug.cgi?id=47974

This patch teaches WebKit's image decoders how to talk to CoreGraphics.
This patch doesn't handle color profiles, but that will come in a
subsequent patch.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • loader/CachedImage.cpp: (WebCore::CachedImage::createImage):
  • platform/graphics/ImageSource.h:
  • platform/image-decoders/ImageDecoder.cpp: (WebCore::RGBA32Buffer::clear): (WebCore::RGBA32Buffer::zeroFill): (WebCore::RGBA32Buffer::copyBitmapData): (WebCore::RGBA32Buffer::setSize):
  • platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::getAddr):
  • platform/image-decoders/cg: Added.
  • platform/image-decoders/cg/ImageDecoderCG.cpp: Added. (WebCore::RGBA32Buffer::copyBitmapData): (WebCore::RGBA32Buffer::setSize): (WebCore::RGBA32Buffer::asNewNativeImage):
11:45 PM Changeset in webkit [70845] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
11:32 PM Changeset in webkit [70844] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-28 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Xan Lopez.

[GTK] GObject bindings generator issues
​https://bugs.webkit.org/show_bug.cgi?id=48135

GObject code generator must not generate conditional API's. This
patch also adds an alternative return value for non-void
conditional methods. With this change the conditionalMethods hack
is no longer needed.

  • bindings/scripts/CodeGeneratorGObject.pm:
11:30 PM Changeset in webkit [70843] by hyatt@apple.com
  • 17 edits
    12 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=48569

Reviewed by Dan Bernstein.

Box shadows on vertical inlines don't paint properly. Fix the paintBoxShadow method to treat the edges to include as
logical (so that top/bottom are used instead of left/right for vertical lines). In order to make my box-shadow tests
work I had to fix a bug in the transform code of InlineTextBox that was causing the baselines of vertical lines to
be wrong.

Added fast/blockflow/box-shadow-* tests

WebCore:

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintBoxShadow):

  • rendering/RenderBoxModelObject.h:

LayoutTests:

  • fast/blockflow/box-shadow-horizontal-bt.html: Added.
  • fast/blockflow/box-shadow-vertical-lr.html: Added.
  • fast/blockflow/box-shadow-vertical-rl.html: Added.
  • platform/mac/fast/blockflow/border-vertical-lr-expected.checksum:
  • platform/mac/fast/blockflow/border-vertical-lr-expected.png:
  • platform/mac/fast/blockflow/box-shadow-horizontal-bt-expected.checksum: Added.
  • platform/mac/fast/blockflow/box-shadow-horizontal-bt-expected.png: Added.
  • platform/mac/fast/blockflow/box-shadow-horizontal-bt-expected.txt: Added.
  • platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.checksum: Added.
  • platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.png: Added.
  • platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.txt: Added.
  • platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.checksum: Added.
  • platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.png: Added.
  • platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.txt: Added.
  • platform/mac/fast/blockflow/english-lr-text-expected.checksum:
  • platform/mac/fast/blockflow/english-lr-text-expected.png:
  • platform/mac/fast/blockflow/english-rl-text-expected.checksum:
  • platform/mac/fast/blockflow/english-rl-text-expected.png:
  • platform/mac/fast/blockflow/japanese-lr-text-expected.checksum:
  • platform/mac/fast/blockflow/japanese-lr-text-expected.png:
  • platform/mac/fast/blockflow/japanese-rl-text-expected.checksum:
  • platform/mac/fast/blockflow/japanese-rl-text-expected.png:
10:22 PM Changeset in webkit [70842] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, test expectations update.
Disable new test added in ​http://trac.webkit.org/changeset/70840.

  • platform/chromium/test_expectations.txt:
9:54 PM Changeset in webkit [70841] by dimich@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Chromium] Not reviewed, fix test expectations.

  • platform/chromium-win/fast/table/simple_paint-expected.checksum: Added.
  • platform/chromium-win/fast/table/simple_paint-expected.png: Added.
  • platform/chromium/test_expectations.txt:
9:48 PM Changeset in webkit [70840] by commit-queue@webkit.org
  • 3 edits
    5 adds in trunk

2010-10-28 James Robinson <​jamesr@chromium.org>

Reviewed by Simon Fraser.

iframes forced into slow scrolling mode by containing RenderLayer sometimes
​https://bugs.webkit.org/show_bug.cgi?id=48570

Adds a test that verifies that the repaint region for a scrolled iframe is not
larger than necessary.

  • fast/repaint/iframe-scroll-repaint.html: Added.
  • fast/repaint/resources/iframe-scroll-repaint-iframe.html: Added.
  • platform/mac/fast/repaint/iframe-scroll-repaint-expected.checksum: Added.
  • platform/mac/fast/repaint/iframe-scroll-repaint-expected.png: Added.
  • platform/mac/fast/repaint/iframe-scroll-repaint-expected.txt: Added.

2010-10-28 James Robinson <​jamesr@chromium.org>

Reviewed by Simon Fraser.

iframes forced into slow scrolling mode by containing RenderLayer sometimes
​https://bugs.webkit.org/show_bug.cgi?id=48570

Only performs the overlap test for RenderLayers that paint themselves. This
prevents marking RenderWidgets as being overlapped unnecessarily.

Test: fast/repaint/iframe-scroll-repaint.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer):
9:31 PM Changeset in webkit [70839] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Not reviewed, test_expectations fix.

  • platform/chromium/test_expectations.txt:
9:19 PM Changeset in webkit [70838] by mitz@apple.com
  • 4 edits in trunk

LLVM compiler build fix

WebKit/mac:

Reviewed by Mark Rowe.

  • Misc/WebDownload.mm:

(-[WebDownload initWithRequest:delegate:]): Changed the delegate type from id to
id<NSURLDownloadDelegate> to match the method signature in NSURLDownload.

WebKit2:

  • WebProcess/Downloads/mac/DownloadMac.mm:

(-[WKDownloadAsDelegate download:didReceiveResponse:]): Removed a stray semicolon.

8:50 PM Changeset in webkit [70837] by commit-queue@webkit.org
  • 12 edits
    2 deletes in trunk

2010-10-28 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r70814.
​http://trac.webkit.org/changeset/70814
​https://bugs.webkit.org/show_bug.cgi?id=48612

Caused media/controls-drag-timebar.html to fail on multiple
platforms (Requested by aroben on #webkit).

  • media/video-seek-by-small-increment-expected.txt: Removed.
  • media/video-seek-by-small-increment.html: Removed.

2010-10-28 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r70814.
​http://trac.webkit.org/changeset/70814
​https://bugs.webkit.org/show_bug.cgi?id=48612

Caused media/controls-drag-timebar.html to fail on multiple
platforms (Requested by aroben on #webkit).

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::seek):
  • platform/graphics/MediaPlayer.cpp:
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
  • platform/graphics/win/QTMovie.cpp:
  • platform/graphics/win/QTMovie.h:
8:20 PM Changeset in webkit [70836] by Adam Roben
  • 5 edits
    6 adds in trunk/WebKit2

Move some function definitions from WebEvent.h into new .cpp files

Someday maybe we'll split the classes into their own header files,
too.

Fixes <​http://webkit.org/b/48604>.

Reviewed by Anders Carlsson.

  • Shared/WebEvent.h: Moved code from here...
  • Shared/WebEvent.cpp: Added.
  • Shared/WebKeyboardEvent.cpp: Added.
  • Shared/WebMouseEvent.cpp: Added.
  • Shared/WebPlatformTouchPoint.cpp: Added.
  • Shared/WebTouchEvent.cpp: Added.
  • Shared/WebWheelEvent.cpp: Added.

...to here. Also changed WebTouchEvent::touchPoints not to copy the
Vector.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Added the new files.

7:56 PM Changeset in webkit [70835] by jamesr@google.com
  • 197 edits
    196 copies
    3 adds in trunk/LayoutTests

2010-10-28 James Robinson <​jamesr@chromium.org>

Update the pixel expectations for fast/tables for the Mac port.

For the tests that currently fail on Snow Leopard with --pixel-tests --tolerance 0,
this moves the current pixel results to mac-leopard and adds new Snow Leopard-specific
results to platform/mac.

List of files omitted due to length but composed entirely of moves from platform/mac to
platform/mac-leopard and newly added files in platform/mac.

7:35 PM Changeset in webkit [70834] by mitz@apple.com
  • 3 edits
    2 adds in trunk

<rdar://problem/8597430> Crash triggered by incremental layout of block truncated by line-clamp
​https://bugs.webkit.org/show_bug.cgi?id=48602

Reviewed by Simon Fraser.

WebCore:

Test: fast/flexbox/line-clamp-crash.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::applyLineClamp): Even if the child needs layout, call clearTruncation(),
since layout itself may be partial and not touch the truncated line (but touch its markup box).

LayoutTests:

  • fast/flexbox/line-clamp-crash-expected.txt: Added.
  • fast/flexbox/line-clamp-crash.html: Added.
6:29 PM Changeset in webkit [70833] by andersca@apple.com
  • 3 edits in trunk/WebKit2

Move code to dispatch a sync message out into a separate function
​https://bugs.webkit.org/show_bug.cgi?id=48605

Reviewed by Adam Roben.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::dispatchSyncMessage):
Factor code out from dispatchMessage. Handle receiving a message with an invalid reply ID.

(CoreIPC::Connection::dispatchMessages):
Call dispatchSyncMessage.

  • Platform/CoreIPC/Connection.h:
6:28 PM Changeset in webkit [70832] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Uneviewed, test_expectations fix.
Re-suppress few test from a bunch re-enabled by ​http://trac.webkit.org/changeset/70823.
They have some old issues still.

  • platform/chromium/test_expectations.txt:
6:28 PM Changeset in webkit [70831] by jianli@chromium.org
  • 1 edit in branches/chromium/552/WebCore/platform/UUID.cpp

Merge 70830 - [chromium] UUID generation does not work in Linux that has sandbox
turned on
​https://bugs.webkit.org/show_bug.cgi?id=48571

BUG=59680
TEST=none

Reviewed by Dmitry Titov.

This is because we cannot access /proc when sandbox is on. The fix is to
use random numbers to construct UUID.

  • platform/UUID.cpp:

(WebCore::createCanonicalUUIDString):

TBR=​jianli@chromium.org

6:12 PM Changeset in webkit [70830] by jianli@chromium.org
  • 2 edits in trunk/WebCore

[chromium] UUID generation does not work in Linux that has sandbox
turned on
​https://bugs.webkit.org/show_bug.cgi?id=48571

Reviewed by Dmitry Titov.

This is because we cannot access /proc when sandbox is on. The fix is to
use random numbers to construct UUID.

  • platform/UUID.cpp:

(WebCore::createCanonicalUUIDString):

5:43 PM Changeset in webkit [70829] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-10-28 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Darin Adler.

Include stddef.h unconditionally in Assertions.h
​https://bugs.webkit.org/show_bug.cgi?id=48573

There is no reason to have stddef.h include be MSVC-only.

  • wtf/Assertions.h:
5:23 PM WebKit Team edited by gyuyoung.kim@samsung.com
(diff)
5:21 PM Changeset in webkit [70828] by andersca@apple.com
  • 2 edits
    2 adds in trunk/WebKit2

Add NPObjectMessageReceiver class.
​https://bugs.webkit.org/show_bug.cgi?id=48599

Reviewed by Darin Adler.

  • Shared/Plugins/NPObjectMessageReceiver.cpp: Added.

(WebKit::NPObjectMessageReceiver::NPObjectMessageReceiver):
(WebKit::NPObjectMessageReceiver::~NPObjectMessageReceiver):

  • Shared/Plugins/NPObjectMessageReceiver.h: Added.
  • WebKit2.xcodeproj/project.pbxproj:
5:16 PM WebKit Team edited by gyuyoung.kim@samsung.com
Add new committer(Gyuyoung Kim) to list (diff)
5:15 PM Changeset in webkit [70827] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed fix for test_expectations.
Temporarily suppress new tests that fail in Chromium port.

  • platform/chromium/test_expectations.txt:
4:45 PM Changeset in webkit [70826] by commit-queue@webkit.org
  • 14 edits
    6 adds in trunk

2010-10-28 Jia Pu <​jpu@apple.com>

Reviewed by Dan Bernstein.

Editing a word with misspell or autocorrection underline should remove the underline when the editing changes the word.
​https://bugs.webkit.org/show_bug.cgi?id=48078
<rdar://problem/8579155>

  • platform/mac-leopard/Skipped: New tests don't apply to this platform.
  • platform/mac-snowleopard/Skipped: Ditto.
  • platform/mac-tiger/Skipped: Ditto.
  • platform/mac-wk2/Skipped: Ditto.
  • platform/mac/editing/spelling/autocorrection-delete-expected.checksum: Updated expected test result.
  • platform/mac/editing/spelling/autocorrection-delete-expected.png: Ditto.
  • platform/mac/editing/spelling/editing-multiple-words-with-markers-expected.txt: Added.
  • platform/mac/editing/spelling/editing-multiple-words-with-markers.html: Added.
  • platform/mac/editing/spelling/editing-word-with-marker-1-expected.txt: Added.
  • platform/mac/editing/spelling/editing-word-with-marker-1.html: Added.
  • platform/mac/editing/spelling/editing-word-with-marker-2-expected.txt: Added.
  • platform/mac/editing/spelling/editing-word-with-marker-2.html: Added.

2010-10-28 Jia Pu <​jpu@apple.com>

Reviewed by Dan Bernstein.

Editing a word with misspell or autocorrection underline should remove the underline when the editing changes the word.
​https://bugs.webkit.org/show_bug.cgi?id=48078
<rdar://problem/8579155>

Tests: platform/mac/editing/spelling/editing-multiple-words-with-markers.html

platform/mac/editing/spelling/editing-word-with-marker-1.html
platform/mac/editing/spelling/editing-word-with-marker-2.html

This patch is part of on-going improvement of autocorrection feature on Mac OS X. When an editing
occurs, if it affects words (by deleting/inserting characters, spliting word, merging words) that
have Spelling and/or CorrectionIndicator markers, we want to remove the markers. If subsequntial
spelling checking finds spelling error in newlly formed words, it will add the markers back in.

  • dom/DocumentMarker.h: Changed MarkerType to bit masks to make search multiple types easier.
  • dom/DocumentMarkerController.cpp: Refactored two removeMarkers() methods to support remove markers with specific type from a node. (WebCore::DocumentMarkerController::removeMarkers): Changed signature to remove marker with specific type. (WebCore::DocumentMarkerController::removeMarkersFromMarkerMapVectorPair): Refactoring. (WebCore::DocumentMarkerController::hasMarkers): Convenience method to search markers in range.
  • dom/DocumentMarkerController.h: Added new methods and matched new signature of removeMarkers().
  • editing/Editor.cpp: (WebCore::Editor::respondToChangedContents): Remove existing markers if the change formed new word. (WebCore::Editor::cut): Remove markers on words that will be modified by this editing. (WebCore::Editor::paste): Ditto. (WebCore::Editor::pasteAsPlainText): Ditto. (WebCore::Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited): Main logic for removing markers on words affected by editing.
  • editing/Editor.h: Added removeSpellAndCorrectionMarkersFromWordsToBeEdited(). Added REMOVE_MARKERS_UPON_EDITING and SUPPORT_AUTOCORRECTION_PANEL macro to improve readability.
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::insertText): Remove markers on words that will be modified by this editing. (WebCore::TypingCommand::deleteKeyPressed): Ditto. (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
4:43 PM Changeset in webkit [70825] by bweinstein@apple.com
  • 4 edits in trunk

Part of <​https://bugs.webkit.org/show_bug.cgi?id=45980>
userscripts/user-script-*-document.html tests are flaky on Windows

Reviewed by Brady Eidson.

WebCore:

In WebFrameLoaderClient::committedLoad on Windows, we call through to PluginStream::didRecieveData
if our manual loader is a plugin stream, and we can call didRecieveData with a 0 length.

We shouldn't ASSERT that length is 0, because code paths exists where we call it with a 0 length.

This is tested by re-enabling user-script-plugin-document.html on Windows.

  • plugins/PluginStream.cpp:

(WebCore::PluginStream::didReceiveData):

LayoutTests:

Unskip the user-script-plugin-document test because its issue is fixed.

  • platform/win/Skipped:
4:41 PM Changeset in webkit [70824] by commit-queue@webkit.org
  • 2 edits
    1 move
    2 adds
    2 deletes in trunk/WebKitSite

2010-10-28 Lucas Forschler <Lucas Forschler>

Reviewed by Geoffrey Garen.

Bug 46927 - Sunspider 0.9 web site should prominently link to Sunspider 0.9.1
Notes:

-Created a new sunspider "landing" page which lists current and previous versions of SunSpider.
-Edited the .htaccess file to redirect the old pages to the new landing page.
-This should keep our search engine page rankings effective.

Potentially breaking:

-This COULD potentially break the SunSpider benchmark.
-Local testing with relative links seems to function as expected.
-The .htaccess 301 redirects are UNTESTED.

  • .htaccess:
  • perf/sunspider: Added.
  • perf/sunspider-0.9.1/sunspider.html: Removed.
  • perf/sunspider-0.9.1/versions.html: Removed.
  • perf/sunspider-0.9/sunspider.html: Removed.
  • perf/sunspider/sunspider.css: Added.
  • perf/sunspider/sunspider.html: Added.
4:20 PM Changeset in webkit [70823] by mihaip@chromium.org
  • 8 edits in trunk

2010-10-28 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Darin Adler.

[Chromium] History related tests REGRESSED after r70723
​https://bugs.webkit.org/show_bug.cgi?id=48513

Remove test_expectations.txt lines for tests that now pass.

  • platform/chromium/test_expectations.txt:

2010-10-28 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Darin Adler.

[Chromium] History related tests REGRESSED after r70723
​https://bugs.webkit.org/show_bug.cgi?id=48513

Remove backItem(), forwardItem() and currentItem() from the Chromium
BackForwardList implementation, since they can use the base class
behavior now (which call itemAtIndex with -1, 1, and 0 respectively).

  • history/BackForwardList.h:
  • history/BackForwardListChromium.cpp:

2010-10-28 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Darin Adler.

[Chromium] History related tests REGRESSED after r70723
​https://bugs.webkit.org/show_bug.cgi?id=48513

Since r70723 made BackForwardList::currentItem no longer be virtual,
we were not reaching the implementation in Chromium's
BackForwardListClientImpl, and for Chromium currentItem is not the same
as itemAtIndex(0).

The fix is to make itemAtIndex(0) have the currentItem() behavior, which
lets us keep currentItem as non-virtual (and remove its implementation
from the Chromium side).

This also switches Chromium to use the default implementation of
backItem() and forwardItem() (vs. the old stubs that just had
ASSERT_NOT_REACHED) since they're actually reacheable with Chromium
code thanks to the calls in FrameLoader::checkDidPerformFirstNavigation.

  • src/BackForwardListClientImpl.cpp: (WebKit::BackForwardListClientImpl::itemAtIndex):
  • src/BackForwardListClientImpl.h:
4:19 PM Changeset in webkit [70822] by ojan@chromium.org
  • 5 edits in trunk/WebKitTools

2010-10-28 Ojan Vafai <​ojan@chromium.org>

Reviewed by Tony Chang.

[chromium] add a result-small.json file for the test dashboard
​https://bugs.webkit.org/show_bug.cgi?id=48547

Output both a results.json file and a results-small.json file.
The dashboard will load results-small.json by default so it loads faster.

  • TestResultServer/model/jsonresults.py:
  • TestResultServer/model/jsonresults_unittest.py: Added a bunch of sys.path hackery. Unforunately, this uses hardcoded paths. That obviously needs to be fixed, but at least this way it clearly documents what paths are necessary.
4:07 PM Changeset in webkit [70821] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

2010-10-28 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

chrome.dll!WebCore::Node::shadowAncestorNode ReadAV@NULL (98643190851b5662363449cc7303d8a5)
​https://bugs.webkit.org/show_bug.cgi?id=47888

The crash was caused by the while loop in ApplyStyleCommand::fixRangeAndApplyInlineStyle
not considering the case where startNode is the root editable element.
Fixed the bug by not entering the loop when startNode is the editable root.

Test: editing/style/fix-range-from-root-editable-crash.html

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::fixRangeAndApplyInlineStyle):

2010-10-28 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

chrome.dll!WebCore::Node::shadowAncestorNode ReadAV@NULL (98643190851b5662363449cc7303d8a5)
​https://bugs.webkit.org/show_bug.cgi?id=47888

Added a test to ensure ApplyStyleCommand::fixRangeAndApplyInlineStyle doesn't crash
when startNode is body and it is, therefore, the editable root.

Note that the test does not reproduce the crash when DOCTYPE is added.

  • editing/style/fix-range-from-root-editable-crash-expected.txt: Added.
  • editing/style/fix-range-from-root-editable-crash.html: Added.
4:01 PM Changeset in webkit [70820] by eric@webkit.org
  • 7 edits in trunk/WebKitTools

2010-10-28 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

webkit-patch upload calls changed_files more often than it should
​https://bugs.webkit.org/show_bug.cgi?id=48567

Passing changed_files around everywhere isn't a very elegant solution
but it's the one we have for the moment. I think keeping an explicit
cache on Checkout (or making StepState() a real class) is a better
long-term option.

Previously bug_id_for_this_commit was calling changed_files and the
result was never getting cached on the state. Now we're explicitly
caching the result on the state and passing that to the bug_id_for_this_commit call.

I looked into building unit tests for this. Doing so would require
using a real Checkout object with a MockSCM and overriding the appropriate
calls on SCM to count how often we're stating the file system.
That's a useful set of tests to build for a separate change.

  • Scripts/webkitpy/common/checkout/api.py:
  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/mocktool.py:
3:57 PM Changeset in webkit [70819] by noam.rosenthal@nokia.com
  • 8 edits in trunk

2010-10-28 Noam Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Ariya Hidayat.

[Texmap] [Qt] Texture mapper initial implementation
​https://bugs.webkit.org/show_bug.cgi?id=47070

Build fix, some wrong changes slipped into the previous patch.
No new tests: build fix.

  • platform/graphics/GraphicsLayer.h:
  • platform/graphics/opengl/TextureMapperGL.cpp: (WebCore::BitmapTextureGL::setContentsToImage):
  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp: (WebCore::TextureMapperNode::uploadTextureFromContent): (WebCore::TextureMapperNode::paintRecursive):
  • platform/qt/QWebPageClient.h: (QWebPageClient::setRootGraphicsLayer):

2010-10-28 Noam Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Ariya Hidayat.

[Texmap] [Qt] Texture mapper initial implementation
​https://bugs.webkit.org/show_bug.cgi?id=47070

Build fix,

  • WebCoreSupport/PageClientQt.cpp: (WebCore::PlatformLayerProxyQGraphicsObject::PlatformLayerProxyQGraphicsObject): (WebCore::PageClientQGraphicsWidget::~PageClientQGraphicsWidget): (WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
  • WebCoreSupport/PageClientQt.h:
3:27 PM Changeset in webkit [70818] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

2010-10-28 Adrienne Walker <​enne@google.com>

Reviewed by Kenneth Russell.

Missing expectation file changes from bug 47853.
​https://bugs.webkit.org/show_bug.cgi?id=48564

  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
3:17 PM Changeset in webkit [70817] by jamesr@google.com
  • 5 edits
    2 copies in branches/chromium/552

Merge 70748 - 2010-10-27 Andy Estes <​aestes@apple.com>

Reviewed by Adam Barth.

r66156 broke AtlasCT library, formerly affected ​http://map.d.co.il/
​https://bugs.webkit.org/show_bug.cgi?id=45679

This patch removes WebKit's map of classid values to MIME types. It also
changes the behavior of object elements to render fallback content when
a non-empty classid attribute is specified, which is the behavior HTML5
specifies when a UA encounters a classid it doesn't understand.

Test: fast/replaced/object-with-non-empty-classid-triggers-fallback.html

  • html/HTMLObjectElement.cpp: Remove serviceTypeForClassId(), createClassIdToTypeMap(), and the ClassIdToTypeMap typedef. (WebCore::HTMLObjectElement::updateWidget): Do not call serviceTypeForClassId() when there is no type attribute, and render fallback content if the classid attribute is non-empty.

2010-10-27 Andy Estes <​aestes@apple.com>

Reviewed by Adam Barth.

r66156 broke AtlasCT library, formerly affected ​http://map.d.co.il/
​https://bugs.webkit.org/show_bug.cgi?id=45679

  • fast/dom/object-embed-plugin-scripting.html: Changed classid attributes to type attributes.
  • fast/dom/object-plugin-hides-properties.html: Ditto.
  • fast/replaced/object-with-non-empty-classid-triggers-fallback-expected.txt: Added.
  • fast/replaced/object-with-non-empty-classid-triggers-fallback.html: Added.

TBR=​cpu@google.com
BUG=57986

3:12 PM Changeset in webkit [70816] by hyatt@apple.com
  • 3 edits
    12 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=48568

Reviewed by James Robinson.

WebCore:

Backgrounds don't work right with vertical RenderInlines. Make background painting
do the right thing for vertical strips.

Added fast/blockflow/background-* tests

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::paintFillLayer):

LayoutTests:

Backgrounds don't work right with vertical RenderInlines. Make background painting
do the right thing for vertical strips.

  • fast/blockflow/background-horizontal-bt.html: Added.
  • fast/blockflow/background-vertical-lr.html: Added.
  • fast/blockflow/background-vertical-rl.html: Added.
  • platform/mac/fast/blockflow/background-horizontal-bt-expected.checksum: Added.
  • platform/mac/fast/blockflow/background-horizontal-bt-expected.png: Added.
  • platform/mac/fast/blockflow/background-horizontal-bt-expected.txt: Added.
  • platform/mac/fast/blockflow/background-vertical-lr-expected.checksum: Added.
  • platform/mac/fast/blockflow/background-vertical-lr-expected.png: Added.
  • platform/mac/fast/blockflow/background-vertical-lr-expected.txt: Added.
  • platform/mac/fast/blockflow/background-vertical-rl-expected.checksum: Added.
  • platform/mac/fast/blockflow/background-vertical-rl-expected.png: Added.
  • platform/mac/fast/blockflow/background-vertical-rl-expected.txt: Added.
2:56 PM Changeset in webkit [70815] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-10-28 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Make suggest-reviewers slightly faster
​https://bugs.webkit.org/show_bug.cgi?id=48562

Add @memoized to one more common call.

  • Scripts/webkitpy/common/checkout/api.py:
2:46 PM Changeset in webkit [70814] by eric.carlson@apple.com
  • 12 edits
    2 adds in trunk

2010-10-28 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Adam Roben.

Seeking by very small increment doesn't generate 'seeked' event
​https://bugs.webkit.org/show_bug.cgi?id=48530

Test: media/video-seek-by-small-increment.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::seek): Ask the media engine for its closest time value so we can avoid asking it to seek to the current time.
  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::mediaTimeForTimeValue): New.
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::mediaTimeForTimeValue): Ditto.
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::mediaTimeForTimeValue): Return the closest value in the movie's time scale.
  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: (WebCore::MediaPlayerPrivateQuickTimeVisualContext::mediaTimeForTimeValue): Ditto
  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
  • platform/graphics/win/QTMovie.cpp: (QTMovie::timeScale): Return the movie's time scale.
  • platform/graphics/win/QTMovie.h:

2010-10-28 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Adam Roben.

Seeking by very small increment doesn't generate 'seeked' event
​https://bugs.webkit.org/show_bug.cgi?id=48530

  • media/video-seek-by-small-increment-expected.txt: Added.
  • media/video-seek-by-small-increment.html: Added.
2:44 PM Changeset in webkit [70813] by hyatt@apple.com
  • 3 edits
    12 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=48443

Reviewed by Beth Dakin.

Border images don't work right with vertical RenderInlines. Make border/mask/background painting
do the right thing for vertical strips.

WebCore:

Added fast/blockflow/border-image-* tests.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):

LayoutTests:

  • fast/blockflow/border-image-horizontal-bt.html: Added.
  • fast/blockflow/border-image-vertical-lr.html: Added.
  • fast/blockflow/border-image-vertical-rl.html: Added.
2:41 PM Changeset in webkit [70812] by Patrick Gansterer
  • 2 edits in trunk/WebCore

2010-10-28 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

Port ContextMenuItemWin.cpp to WinCE
​https://bugs.webkit.org/show_bug.cgi?id=48407

  • platform/win/ContextMenuItemWin.cpp:
2:38 PM Changeset in webkit [70811] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-10-28 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

webkit-patch suggest-reviewers -g 260550a6e30b7bf34f16bdb4a5396cf26264fc1c is still very slow
​https://bugs.webkit.org/show_bug.cgi?id=48536

This patch makes it about 40 seconds faster, but it still
takes 1:40. This will require more refinement.

The suggested reviewers list appears to be the same.

I think the next step may be to have it stop the search after
5 reviewers are found. We never want to suggest 30 people.

  • Scripts/webkitpy/common/checkout/scm.py:
    • Using --remove-empty to theoretically stop lookups past when a file is removed. I'm not entirely clear that the option does what it says it does. Example: git log --pretty=format:%H -5 --remove-empty -- /Projects/WebKit/WebCore/platform/wx/SearchPopupMenuWx.h returns only one commit vs. git log --pretty=format:%H -5 -- /Projects/WebKit/WebCore/platform/wx/SearchPopupMenuWx.h which returns 5. I was not aware that wx files were ever removed from the repository?
2:38 PM Changeset in webkit [70810] by rniwa@webkit.org
  • 5 edits in trunk

2010-10-28 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

queryCommandValue should fall back to queryCommandState
​https://bugs.webkit.org/show_bug.cgi?id=48479

Added a fallback to Command::value so that commands with a state function without a value function
returns the value returned by the state function as a string.

  • editing/EditorCommand.cpp: (WebCore::Editor::Command::value):

2010-10-28 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

queryCommandValue should fall back to queryCommandState
​https://bugs.webkit.org/show_bug.cgi?id=48479

Modified the existing tests to ensure queryCommandValue returns 'true' or 'false'
for commands that supports queryCommandState.

  • editing/execCommand/script-tests/query-command-state.js: (testQueryCommandState):
  • editing/execCommand/script-tests/query-text-alignment.js: (isEquivalentBoolean): (queryTextAlignment):
2:35 PM Changeset in webkit [70809] by andersca@apple.com
  • 2 edits
    2 adds in trunk/WebKit2

Add NPObjectProxy class
​https://bugs.webkit.org/show_bug.cgi?id=48558

Reviewed by Sam Weinig.

  • Shared/Plugins/NPObjectProxy.cpp: Added.

(WebKit::NPObjectProxy::NPObjectProxy):
(WebKit::NPObjectProxy::~NPObjectProxy):

  • Shared/Plugins/NPObjectProxy.h: Added.
  • WebKit2.xcodeproj/project.pbxproj:
2:23 PM Changeset in webkit [70808] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-10-28 Martin Robinson <​mrobinson@igalia.com>

Unskip some passing canvas tests on GTK+. These were
likely fixed by the recent shadow changes.

  • platform/gtk/Skipped: Unskip passing tests.
2:16 PM Changeset in webkit [70807] by aestes@apple.com
  • 3 edits
    6 deletes in trunk/LayoutTests

Remove test expectations obsoleted by r70619.

  • platform/chromium-linux/fast/block/float/tableshifting-expected.checksum: Removed.
  • platform/chromium-linux/fast/block/float/tableshifting-expected.png: Removed.
  • platform/chromium-win/fast/block/float/tableshifting-expected.checksum: Removed.
  • platform/chromium-win/fast/block/float/tableshifting-expected.png: Removed.
  • platform/chromium-win/fast/block/float/tableshifting-expected.txt: Removed.
  • platform/gtk/Skipped: Unskip fast/block/float/tableshifting.html
  • platform/qt/Skipped: Ditto.
  • platform/qt/fast/block/float/tableshifting-expected.txt: Removed.
2:15 PM UsingGitWithWebKit edited by Simon Fraser
(diff)
2:09 PM Changeset in webkit [70806] by kinuko@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-28 Kinuko Yasuda <​kinuko@chromium.org>

Unreviewed, updating drt_expectations.txt.

  • platform/chromium/drt_expectations.txt:
2:09 PM Changeset in webkit [70805] by pfeldman@chromium.org
  • 12 edits in trunk/WebCore

2010-10-28 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Rolling out r70800.

1:35 PM Changeset in webkit [70804] by ap@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=48551
HTMLDocument::isFrameSet() should not depend on renderer

No change in functionality, so no new tests.

  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::isFrameSet): Omit the check for renderer.
  • rendering/RenderLayer.h: Removed unneeded includes and forward declarations.
1:30 PM Changeset in webkit [70803] by mdelaney@apple.com
  • 3 edits
    52 adds in trunk/LayoutTests

2010-10-28 Matthew Delaney <​mdelaney@apple.com>

Reviewed by Oliver Hunt.

Unskip remaining canvas layout tests so that they can track progressions/regressions
​https://bugs.webkit.org/show_bug.cgi?id=46439

  • platform/mac-leopard/Skipped: Moving overall mac skipped tests down to specifically leopard skipped.
  • platform/mac-snowleopard/canvas/philip/tests: Added snowleopard specific expectation files for now unskipped tests.
  • platform/mac/Skipped: Unskipped all canvas tests that we want to track. Commented why the test that remain on the list are there.
1:23 PM Changeset in webkit [70802] by andersca@apple.com
  • 2 edits
    3 adds in trunk/WebKit2

Add NPRemoteObjectMap class
​https://bugs.webkit.org/show_bug.cgi?id=48553

Reviewed by Sam Weinig.

  • Shared/Plugins/NPRemoteObjectMap.cpp: Added.

(WebKit::NPRemoteObjectMap::NPRemoteObjectMap):

  • Shared/Plugins/NPRemoteObjectMap.h: Added.
  • WebKit2.xcodeproj/project.pbxproj:
1:23 PM Changeset in webkit [70801] by inferno@chromium.org
  • 6 edits
    4 copies in branches/chromium/552

Merge 70797

BUG=55215

1:22 PM Changeset in webkit [70800] by pfeldman@chromium.org
  • 12 edits in trunk/WebCore

2010-10-28 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: make legacy resource tracking optional in the native code,
make cookeis work against new resource manager.
​https://bugs.webkit.org/show_bug.cgi?id=48532

  • inspector/InspectorCSSStore.cpp: (WebCore::InspectorCSSStore::resourceStyleSheetText):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::releaseFrontendLifetimeAgents): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::unbindAllResources): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::frameDetachedFromParent): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::markResourceAsCached): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading): (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorController::scriptImported): (WebCore::InspectorController::setResourceTrackingEnabled): (WebCore::InspectorController::getCookies): (WebCore::InspectorController::deleteCookie): (WebCore::InspectorController::didCreateWebSocket): (WebCore::InspectorController::willSendWebSocketHandshakeRequest): (WebCore::InspectorController::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorController::didCloseWebSocket): (WebCore::InspectorController::breakpointsSettingKey): (WebCore::InspectorController::getResourceContent):
  • inspector/InspectorController.h:
  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::updateScriptObject): (WebCore::InspectorResource::markFailed):
  • inspector/InspectorResource.h:
  • inspector/InspectorResourceAgent.cpp: (WebCore::populateObjectWithFrameResources):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
  • inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager.prototype._updateResourceWithResponse): (WebInspector.ResourceManager.prototype.didFailLoading):
  • inspector/front-end/inspector.js: (WebInspector.updateResource):
1:13 PM Changeset in webkit [70799] by podivilov@chromium.org
  • 3 edits in trunk/WebCore

2010-10-28 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: fix pausing on next JavaScript statement
​https://bugs.webkit.org/show_bug.cgi?id=48534

  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent): (WebCore::InspectorDebuggerAgent::schedulePauseOnNextStatement): (WebCore::InspectorDebuggerAgent::cancelPauseOnNextStatement): (WebCore::InspectorDebuggerAgent::pause): (WebCore::InspectorDebuggerAgent::didPause):
  • inspector/InspectorDebuggerAgent.h:
1:01 PM QtWebKitTableOfFeatures46 edited by Ademar Reis
(diff)
12:48 PM QtWebKitPerformanceWork edited by Ademar Reis
(diff)
12:46 PM Changeset in webkit [70798] by kinuko@chromium.org
  • 24 edits
    3 copies in branches/chromium/552

Merge 70741 - 2010-10-27 Kinuko Yasuda <​kinuko@chromium.org>

DOMFileSystem's reference should be kept while there're any active Entries/callbacks
​https://bugs.webkit.org/show_bug.cgi?id=47535

Changed to keep DOMFileSystem's reference in each EntryBase, DirectoryReaderBase, EntryCallbacks and EntriesCallbacks.

BUG=61040
TEST=fast/filesystem/filesystem-reference.html

12:43 PM QtWebKitMirrorGuide edited by Ademar Reis
(diff)
12:30 PM Changeset in webkit [70797] by inferno@chromium.org
  • 8 edits
    4 adds in trunk

2010-10-28 Yuzo Fujishima <​yuzo@google.com>

Reviewed by David Hyatt.

Fix for Bug 14550 - Non-layout style change does not update nested first-letter
​https://bugs.webkit.org/show_bug.cgi?id=14550

If a render text fragment is accompanied by a first letter, update the
first letter's style when the fragment's style is changed.

Test: fast/css/first-letter-nested.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::styleDidChange): Stop calling updateFirstLetter from here.
  • rendering/RenderBlock.h: Make updateFirstLetter accessbile from RenderTextFragment.
  • rendering/RenderTextFragment.cpp: (WebCore::RenderTextFragment::styleDidChange): If appropriate, update first letter after removing stale cached pseudo style. (WebCore::RenderTextFragment::blockForAccompanyingFirstLetter): Helper to get the block for the first letter.
  • rendering/RenderTextFragment.h:
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::removeCachedPseudoStyle): Remove the specified pseudo style from cache.
  • rendering/style/RenderStyle.h:

2010-10-28 Yuzo Fujishima <​yuzo@google.com>

Reviewed by David Hyatt.

Fix for Bug 14550 - Non-layout style change does not update nested first-letter
​https://bugs.webkit.org/show_bug.cgi?id=14550

  • fast/css/first-letter-nested-expected.txt: Added.
  • fast/css/first-letter-nested.html: Added.
  • fast/css/first-letter-removed-added-expected.txt: Added.
  • fast/css/first-letter-removed-added.html: Added.
12:30 PM QtWebKitFeatures46 edited by Ademar Reis
(diff)
12:29 PM QtWebKitFeatures20 edited by Ademar Reis
(diff)
12:27 PM QtWebKitContrib edited by Ademar Reis
(diff)
12:21 PM QtWebKit edited by Ademar Reis
(diff)
12:17 PM Changeset in webkit [70796] by kinuko@chromium.org
  • 7 edits in trunk

2010-10-28 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by David Levin.

[Chromium] Support FileSystem in chromium DRT
​https://bugs.webkit.org/show_bug.cgi?id=47643
Update the chromium DEPS to pick up corresponding webkit_support change.
Also add a temporary glue implementation with FIXME comment to
WebFrameClient::openFileSystem.

  • DEPS:
  • public/WebFrameClient.h: (WebKit::WebFrameClient::openFileSystem):

2010-10-28 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by David Levin.

[Chromium] Support FileSystem in chromium DRT
​https://bugs.webkit.org/show_bug.cgi?id=47643

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::openFileSystem): Added.
  • DumpRenderTree/chromium/WebViewHost.h: (WebViewHost::openFileSystem): Added.
12:09 PM Changeset in webkit [70795] by weinig@apple.com
  • 5 edits in trunk

WKURLRefs should be allowed to be null
<rdar://problem/8575621>
​https://bugs.webkit.org/show_bug.cgi?id=48535

Reviewed by Anders Carlsson.

WebKit2:

  • Shared/API/c/WKSharedAPICast.h:

(WebKit::toURLRef):
(WebKit::toCopiedURLAPI):
Turn a null WTF::String into a null WKURLRef.

WebKitTools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:

(TestWebKitAPI::didStartProvisionalLoadForFrame):
(TestWebKitAPI::didCommitLoadForFrame):
(TestWebKitAPI::didFinishLoadForFrame):
Test that URLs are null pointers when unset.

12:05 PM Changeset in webkit [70794] by commit-queue@webkit.org
  • 5 edits in trunk/LayoutTests

2010-10-28 Adrienne Walker <​enne@google.com>

Reviewed by Kenneth Russell.

Add shouldBeDefined function to js-test-pre.js and update
context-attributes-etc test to use it.
​https://bugs.webkit.org/show_bug.cgi?id=47853

  • fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias-expected.txt:
  • fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/js/resources/js-test-pre.js: (shouldBeDefined):
12:04 PM Changeset in webkit [70793] by kbr@google.com
  • 2 edits in trunk/WebCore

2010-10-28 Benoit Jacob <​bjacob@mozilla.com>

Reviewed by Kenneth Russell.

Ensure that WebGL stencil buffers are correctly initialized
​https://bugs.webkit.org/show_bug.cgi?id=48351

  • html/canvas/WebGLFramebuffer.cpp: (WebCore::WebGLFramebuffer::initializeRenderbuffers):
11:54 AM Changeset in webkit [70792] by Chris Fleizach
  • 7 edits
    2 adds in trunk

AX: multi select group option does not handle setting of AXSelectedChildren correctly
​https://bugs.webkit.org/show_bug.cgi?id=48464

Reviewed by Adele Peterson.

WebCore:

Ensure that when selecting an item from a <select> element, it accounts for <optgroups>.

Test: platform/mac/accessibility/select-element-selection-with-optgroups.html

  • accessibility/AccessibilityListBoxOption.cpp:

(WebCore::AccessibilityListBoxOption::setSelected):

WebKitTools:

Add support for querying information about selected children to DRT, including:

selectedChildAtIndex
selectedChildrenCount
setSelectedChild

  • DumpRenderTree/AccessibilityUIElement.cpp:

(selectedChildAtIndexCallback):
(setSelectedChildCallback):
(selectedChildrenCountCallback):
(AccessibilityUIElement::setSelectedChild):
(AccessibilityUIElement::selectedChildrenCount):
(AccessibilityUIElement::selectedChildAtIndex):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::selectedChildAtIndex):
(AccessibilityUIElement::selectedChildrenCount):
(AccessibilityUIElement::setSelectedChild):

LayoutTests:

  • platform/mac/accessibility/select-element-selection-with-optgroups-expected.txt: Added.
  • platform/mac/accessibility/select-element-selection-with-optgroups.html: Added.
11:28 AM Changeset in webkit [70791] by mitz@apple.com
  • 4 edits in trunk/WebKitLibraries

Added UniCharProvider-based ways to create a CTTypeSetter and a CTLine, to be used in an
upcoming ComplexTextController patch.

Reviewed by John Sullivan.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
11:21 AM Changeset in webkit [70790] by weinig@apple.com
  • 13 edits in trunk

Add WebKit2 API for window feature getter/setters
<rdar://problem/8590373>
​https://bugs.webkit.org/show_bug.cgi?id=48496

Reviewed by Anders Carlsson.

WebKit2:

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setToolbarsAreVisible):
(WebKit::WebPageProxy::getToolbarsAreVisible):
(WebKit::WebPageProxy::setMenuBarIsVisible):
(WebKit::WebPageProxy::getMenuBarIsVisible):
(WebKit::WebPageProxy::setStatusBarIsVisible):
(WebKit::WebPageProxy::getStatusBarIsVisible):
(WebKit::WebPageProxy::setIsResizable):
(WebKit::WebPageProxy::getIsResizable):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::toolbarsAreVisible):
(WebKit::WebUIClient::setToolbarsAreVisible):
(WebKit::WebUIClient::menuBarIsVisible):
(WebKit::WebUIClient::setMenuBarIsVisible):
(WebKit::WebUIClient::statusBarIsVisible):
(WebKit::WebUIClient::setStatusBarIsVisible):
(WebKit::WebUIClient::isResizable):
(WebKit::WebUIClient::setIsResizable):

  • UIProcess/WebUIClient.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::setToolbarsVisible):
(WebKit::WebChromeClient::toolbarsVisible):
(WebKit::WebChromeClient::setStatusbarVisible):
(WebKit::WebChromeClient::statusbarVisible):
(WebKit::WebChromeClient::setMenubarVisible):
(WebKit::WebChromeClient::menubarVisible):
(WebKit::WebChromeClient::setResizable):
Plumb through the calls.

WebKitTools:

  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController awakeFromNib]):

  • MiniBrowser/win/BrowserView.cpp:

(BrowserView::create):

  • WebKitTestRunner/TestController.cpp:

(WTR::createOtherPage):
(WTR::TestController::initialize):

11:08 AM Changeset in webkit [70789] by commit-queue@webkit.org
  • 3 edits in trunk/WebKitTools

2010-10-28 Søren Gjesse <​sgjesse@chromium.org>

Reviewed by Tony Chang.

Added support for the DumpRenderTree flags --multiple-loads and --js-flags to the Python test runner.
​https://bugs.webkit.org/show_bug.cgi?id=48236

  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
10:37 AM Changeset in webkit [70788] by commit-queue@webkit.org
  • 6 edits in trunk

2010-10-28 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Martin Robinson.

[GTK] WebKitWebFrame's load-status is not properly notified to the tests
​https://bugs.webkit.org/show_bug.cgi?id=48048

  • platform/gtk/Skipped: unskipped a couple of tests

2010-10-28 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Martin Robinson.

[GTK] WebKitWebFrame's load-status is not properly notified to the tests
​https://bugs.webkit.org/show_bug.cgi?id=48048

"frame-created" signal must be issued before loading any data,
that way clients can correctly capture all the loading related
signals for that frame.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createFrame):

2010-10-28 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Martin Robinson.

[GTK] WebKitWebFrame's load-status is not properly notified to the tests
​https://bugs.webkit.org/show_bug.cgi?id=48048

DRT now listens to WebKitWebFrame load-status signals for each
created frame instead of the load-status signal of the
WebKitWebView that only notifies about changes in the main frame.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewLoadFinished): (webFrameLoadStatusNotified): (frameCreatedCallback): (createWebView): (main):
10:19 AM Changeset in webkit [70787] by mitz@apple.com
  • 2 edits in trunk/WebKit2

Build fix.

  • win/WebKit2Common.vsprops:
10:10 AM Changeset in webkit [70786] by tony@chromium.org
  • 4 edits in trunk

2010-10-28 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] fix textInputController.{selectedRange,markedRange}
​https://bugs.webkit.org/show_bug.cgi?id=48487

  • platform/chromium/test_expectations.txt: correct some comments about

firstRectForCharacterRange.

2010-10-28 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] fix textInputController.{selectedRange,markedRange}
​https://bugs.webkit.org/show_bug.cgi?id=48487

  • DumpRenderTree/chromium/TextInputController.cpp: (TextInputController::markedRange): Return arrays of ints, rather than a string (TextInputController::selectedRange): Ditto.
9:53 AM Changeset in webkit [70785] by mitz@apple.com
  • 6 edits in trunk

No longer soft-link zlib
​https://bugs.webkit.org/show_bug.cgi?id=48004

Reviewed by Adam Roben.

WebCore:

  • platform/graphics/WOFFFileFormat.cpp:

(WebCore::convertWOFFToSfnt): Removed Windows-speciific code to soft-link
zlib.

WebKit2:

  • win/WebKit2Common.vsprops: Added zlib.lib to AdditionalDependencies.

LayoutTests:

  • platform/win/Skipped: Enabled fast/css/font-face-woff.html.
9:51 AM Changeset in webkit [70784] by zmo@google.com
  • 6 edits in trunk

2010-10-27 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

Work around a Mac driver bug in generateMipmap
​https://bugs.webkit.org/show_bug.cgi?id=48489

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::generateMipmap): Make sure minFilter is set to NEAREST_MIPMAP_LINEAR before generateMipmap, and after the call, set it back to the original value.
  • html/canvas/WebGLTexture.h: (WebCore::WebGLTexture::getMinFilter): Return the cached minFilter value.

2010-10-27 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

Work around a Mac driver bug in generateMipmap
​https://bugs.webkit.org/show_bug.cgi?id=48489

  • fast/canvas/webgl/texture-npot-expected.txt: Add back the failing part due to the generateMipmap Mac driver bug.
  • fast/canvas/webgl/texture-npot.html: Ditto.
9:38 AM Changeset in webkit [70783] by mnaganov@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-28 Mikhail Naganov <​mnaganov@chromium.org>

[Chromium] Unreviewed fix for test_expectations.

  • platform/chromium/test_expectations.txt:
9:27 AM Changeset in webkit [70782] by ojan@chromium.org
  • 2 edits in trunk/WebKitTools

2010-10-27 Ojan Vafai <​ojan@chromium.org>

Reviewed by Tony Chang.

[chromium] add a master-name flag to new-run-webkit-tests
​https://bugs.webkit.org/show_bug.cgi?id=48488

The test results server now allows adding a master name to
the uploaded files. This lets us distinguish bots that have
the same name, but are on different masters.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
9:14 AM Changeset in webkit [70781] by Adam Roben
  • 5 edits in trunk

Make PluginView retain its HTMLPlugInElement

This matches WebKit/mac's WebBaseNetscapePluginView. WebCore didn't do
this, but had a very different mechanism for implementing NPRuntime
that didn't require it.

Fixes <​http://webkit.org/b/46672> <rdar://problem/8484208> Crash
(preceded by assertion) in Node::document when running
plugins/document-open.html in WebKit2 on Windows

Reviewed by Anders Carlsson.

LayoutTests:

Remove plugins/document-open.html from the win-wk2 Skipped file

It passes now that <​http://webkit.org/b/46672> is fixed.

  • platform/win-wk2/Skipped:

WebKit2:

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::create): Moved here from the header file so that
clients of the header file won't have to pull in HTMLPlugInElement.h.
Changed to take a PassRefPtr<HTMLPlugInElement>.
(WebKit::PluginView::PluginView): Changed to take a
PassRefPtr<HTMLPlugInElement> and to use m_pluginElement later (because
the parameter to the function will be nulled-out after assigning into
m_pluginElement).
(WebKit::PluginView::pluginElementNPObject): Updated for change to m_pluginElement.

  • WebProcess/Plugins/PluginView.h: Made m_pluginElement a RefPtr.
9:13 AM Changeset in webkit [70780] by Adam Roben
  • 2 edits in trunk/WebKitTools

Don't append a newline to the test output if the frame has no document element in WebKitTestRunner

Fixes <​http://webkit.org/b/48526> Extra trailing newline when running
plugins/document-open.html in WebKitTestRunner

Reviewed by Anders Carlsson.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::toJS): Added. Turns a UTF-8 C string into a JSStringRef.
(WTR::hasDocumentElement): Added. Uses the JSC API to figure out
whether the frame has a document element.
(WTR::dumpFrameText): Match DRT by bailing (rather than appending an
empty string and a newline) if the frame has no document element.

9:13 AM Changeset in webkit [70779] by Adam Roben
  • 3 edits in trunk/LayoutTests

Recategorize the failure of plugins/mouse-events.html for WebKit2

This should have been done in r70685.

  • platform/mac-wk2/Skipped: Moved plugins/mouse-events.html into the

"Need eventSender" category...

  • platform/win-wk2/Skipped: ...from here.
9:05 AM Changeset in webkit [70778] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/WebKit/qt

[Qt] QWebElement: Don't retrieve CSS rules through DOMWindow.
​https://bugs.webkit.org/show_bug.cgi?id=48519

Reviewed by Andreas Kling.

JavaScript is prevented from retrieving cross-domain CSS rules since r70335.
This patch allow QWebElement to retrive style without this limitation
by asking the Document directly instead of going through DOMWindow.

Fixes:

  • tst_QWebFrame::setHtmlWithResource()
  • tst_QWebElement::style()
  • Api/qwebelement.cpp:

(QWebElement::styleProperty):

8:49 AM Changeset in webkit [70777] by kenneth@webkit.org
  • 4 edits in trunk

2010-10-28 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Andreas Kling.

Make Qt viewportAttributesForSize not assert on (0, 0) size
​https://bugs.webkit.org/show_bug.cgi?id=48524

We now return an invalid (isValid() == false) ViewportAttributes
instance when the supplied size is (0, 0).

  • Api/qwebpage.cpp: (QWebPage::viewportAttributesForSize):

2010-10-28 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Andreas Kling.

Make Qt viewportAttributesForSize not assert on (0, 0) size
​https://bugs.webkit.org/show_bug.cgi?id=48524

We now return an invalid (isValid() == false) ViewportAttributes
instance when the supplied size is (0, 0).

  • UIProcess/API/qt/qwkpage.cpp: (QWKPage::viewportAttributesForSize):
7:52 AM Changeset in webkit [70776] by kbalazs@webkit.org
  • 2 edits in trunk/WebKit2

2010-10-28 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Andreas Kling.

[Qt][WK2] SharedMemory should be released by the receiving process
​https://bugs.webkit.org/show_bug.cgi?id=48520

  • Platform/qt/SharedMemoryQt.cpp: (WebKit::SharedMemory::~SharedMemory): (WebKit::SharedMemory::createHandle):
7:23 AM Changeset in webkit [70775] by mnaganov@chromium.org
  • 3 edits in trunk/WebCore

2010-10-28 Mikhail Naganov <​mnaganov@chromium.org>

[Chromium clang] Unreviewed. Fix forward declaration of 'struct FileMetadata'.

See ​http://build.chromium.org/p/chromium.fyi/builders/Chromium%20Linux%20Debug%20Clang/builds/753/steps/compile/logs/stdio

  • fileapi/FileSystemCallbacks.h:
  • platform/AsyncFileSystemCallbacks.h:
7:03 AM Changeset in webkit [70774] by mnaganov@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-28 Mikhail Naganov <​mnaganov@chromium.org>

[Chromium] Unreviewed test expectations update.

Remove rule for non-existent long-css-selector-matches test.

  • platform/chromium/test_expectations.txt:
6:50 AM Changeset in webkit [70773] by Adam Roben
  • 2 edits in trunk/WebKitTools

Skip npn-invalidate-rect-invalidates-window.html on headless XP machines

TestNetscapePlugIn never receives a WM_PAINT message on headless XP
machines, so this test times out. Fixing the test is covered by
<​http://webkit.org/b/48333>.

  • Scripts/old-run-webkit-tests: Skip

npn-invalidate-rect-invalidates-window.html on Windows if accelerated
compositing support is disabled, which likely means we're on a headless
XP machine.

6:27 AM Changeset in webkit [70772] by apavlov@chromium.org
  • 11 edits in trunk

2010-10-28 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Bring backend-frontend message format to follow the protocol specification
​https://bugs.webkit.org/show_bug.cgi?id=48406

WebCore:

  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getStyles): (WebCore::InspectorDOMAgent::applyStyleText): (WebCore::InspectorDOMAgent::buildObjectForStyle): (WebCore::InspectorDOMAgent::populateObjectWithStyleProperties): (WebCore::InspectorDOMAgent::buildObjectForStyleSheet): (WebCore::InspectorDOMAgent::buildObjectForRule):
  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.parseRuleArrayPayload): (WebInspector.CSSStyleModel.prototype.getStylesAsync): (WebInspector.CSSStyleModel.prototype.getComputedStyleAsync): (WebInspector.CSSStyleModel.prototype.getInlineStyleAsync): (WebInspector.CSSStyleModel.prototype.setCSSText):
  • inspector/front-end/DOMAgent.js: (WebInspector.CSSStyleDeclaration): (WebInspector.CSSStyleDeclaration.parsePayload): (WebInspector.CSSStyleDeclaration.prototype.get allProperties): (WebInspector.CSSStyleDeclaration.prototype.getLiveProperty): (WebInspector.CSSStyleDeclaration.prototype.getPropertyValue): (WebInspector.CSSStyleDeclaration.prototype.getPropertyPriority): (WebInspector.CSSStyleDeclaration.prototype.getPropertyShorthand): (WebInspector.CSSStyleDeclaration.prototype.isPropertyImplicit): (WebInspector.CSSStyleDeclaration.prototype.getShorthandValue): (WebInspector.CSSStyleDeclaration.prototype.getShorthandPriority): (WebInspector.CSSStyleDeclaration.prototype.appendProperty): (WebInspector.CSSStyleDeclaration.prototype.propertyAt): (WebInspector.CSSRule): (WebInspector.CSSRule.parsePayload): (WebInspector.CSSRule.prototype.get isUserAgent): (WebInspector.CSSRule.prototype.get isUser): (WebInspector.CSSRule.prototype.get isViaInspector): (WebInspector.CSSRule.prototype.get isRegular): (WebInspector.CSSProperty): (WebInspector.CSSProperty.parsePayload): (WebInspector.CSSProperty.prototype.get propertyText): (WebInspector.CSSProperty.prototype.get isLive): (WebInspector.CSSProperty.prototype.get active): (WebInspector.CSSProperty.prototype.get styleBased): (WebInspector.CSSProperty.prototype.get inactive): (WebInspector.CSSProperty.prototype.get disabled): (WebInspector.CSSProperty.prototype.setText): (WebInspector.CSSProperty.prototype.setValue): (WebInspector.CSSProperty.prototype.setDisabled.callback): (WebInspector.CSSProperty.prototype.setDisabled):
  • inspector/front-end/MetricsSidebarPane.js: (WebInspector.MetricsSidebarPane.prototype.update.callback): (WebInspector.MetricsSidebarPane.prototype.update.inlineStyleCallback): (WebInspector.MetricsSidebarPane.prototype.update): (WebInspector.MetricsSidebarPane.prototype._update): (WebInspector.MetricsSidebarPane.prototype.editingCommitted.callback): (WebInspector.MetricsSidebarPane.prototype.editingCommitted.setEnabledValueCallback): (WebInspector.MetricsSidebarPane.prototype.editingCommitted):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update): (WebInspector.StylesSidebarPane.prototype._rebuildUpdate): (WebInspector.StylesSidebarPane.prototype._refreshStyleRules): (WebInspector.StylesSidebarPane.prototype._rebuildStyleRules): (WebInspector.StylesSidebarPane.prototype._markUsedProperties): (WebInspector.StylesSidebarPane.prototype._containsInherited): (WebInspector.StylePropertiesSection): (WebInspector.StylePropertiesSection.prototype.isPropertyInherited): (WebInspector.StylePropertiesSection.prototype.isPropertyOverloaded): (WebInspector.StylePropertiesSection.prototype.onpopulate): (WebInspector.StylePropertiesSection.prototype.addNewBlankProperty): (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted.successCallback): (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted): (WebInspector.ComputedStylePropertiesSection.prototype._isPropertyInherited): (WebInspector.ComputedStylePropertiesSection.prototype.onpopulate): (WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace): (WebInspector.StylePropertyTreeElement): (WebInspector.StylePropertyTreeElement.prototype.get disabled): (WebInspector.StylePropertyTreeElement.prototype.get name): (WebInspector.StylePropertyTreeElement.prototype.get priority): (WebInspector.StylePropertyTreeElement.prototype.get value): (WebInspector.StylePropertyTreeElement.prototype.get parsedOk): (WebInspector.StylePropertyTreeElement.prototype): (WebInspector.StylePropertyTreeElement.prototype.):

LayoutTests:

  • http/tests/inspector/inspect-iframe-from-different-domain.html:
  • inspector/styles-source-offsets.html:
6:04 AM Changeset in webkit [70771] by pfeldman@chromium.org
  • 6 edits in branches/chromium/552

Merge 70682 - 2010-10-27 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: "Reload Page and Audit on Load" fails to run audits when resource tracking is disabled
​https://bugs.webkit.org/show_bug.cgi?id=48431

  • http/tests/inspector/inspector-test2.js: (initialize_InspectorTest.InspectorTest.enableResourceTracking): (initialize_InspectorTest.InspectorTest.disableResourceTracking):
  • http/tests/inspector/resource-parameters.html:
  • inspector/audits-panel-functional.html:
  • inspector/styles-source-offsets.html:

2010-10-27 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: "Reload Page and Audit on Load" fails to run audits when resource tracking is disabled
​https://bugs.webkit.org/show_bug.cgi?id=48431

  • inspector/front-end/AuditsPanel.js: (WebInspector.AuditsPanel.prototype._reloadResources):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._createPanelEnabler): (WebInspector.ResourcesPanel.prototype._enableResourceTracking):

TBR=​apavlov@chromium.org
BUG=60929

6:01 AM Changeset in webkit [70770] by mnaganov@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-28 Mikhail Naganov <​mnaganov@chromium.org>

[Chromium] Unreviewed test expectations update.

Update expectation for linux javascriptlink-frames.html

  • platform/chromium/test_expectations.txt:
5:56 AM Changeset in webkit [70769] by satish@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-10-28 Satish Sampath <​satish@chromium.org>

Reviewed by Steve Block.

Remove obsolete public/API methods in chromium port
​https://bugs.webkit.org/show_bug.cgi?id=48504

  • public/WebSpeechInputController.h: (WebKit::WebSpeechInputController::startRecognition):
5:37 AM Changeset in webkit [70768] by mnaganov@chromium.org
  • 3 edits
    1 add
    1 delete in trunk/LayoutTests

2010-10-28 Mikhail Naganov <​mnaganov@chromium.org>

[Chromium] Unreviewed test expectations update.

Rebaseline test results.

  • platform/chromium-mac/fast/blockflow/border-vertical-lr-expected.checksum: Added.
  • platform/chromium-mac/fast/borders/border-radius-split-inline-expected.checksum:
  • platform/chromium-mac/fast/borders/border-radius-split-inline-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
5:19 AM Changeset in webkit [70767] by mnaganov@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-28 Mikhail Naganov <​mnaganov@chromium.org>

[Chromium] Unreviewed test expectations update.

Mark regressed after r70723 history-related tests.

​https://bugs.webkit.org/show_bug.cgi?id=48513

  • platform/chromium/test_expectations.txt:
5:16 AM Changeset in webkit [70766] by zherczeg@webkit.org
  • 2 edits in trunk/JavaScriptCore

Try to fix interpreter build.

Rubber stamped by Csaba Osztrogonác.

Needed parentheses around assignment to avoid GCC warning after
​http://trac.webkit.org/changeset/70703

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

5:03 AM Changeset in webkit [70765] by ktkinnun@webkit.org
  • 2 edits in trunk/WebKitTools

2010-10-28 Kimmo Kinnunen <Kimmo Kinnunen>

Adding myself as a committer.

  • Scripts/webkitpy/common/config/committers.py:
4:17 AM Changeset in webkit [70764] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-10-28 Peter Varga <​pvarga@inf.u-szeged.hu>

Reviewed by Csaba Osztrogonác.

resetAssertionMatches() is an unused function in YARR Interpreter
​https://bugs.webkit.org/show_bug.cgi?id=48503

The resetAssertionMatches() function is removed from YARR Interpreter
because it's never called.

  • yarr/RegexInterpreter.cpp: (JSC::Yarr::Interpreter::resetMatches):
3:41 AM Changeset in webkit [70763] by morrita@google.com
  • 8 edits
    6 adds in trunk

2010-10-28 MORITA Hajime <​morrita@google.com>

Reviewed by Kent Tamura.

WebKit needs to expose an Element::spellcheck attribute to javascript.
​https://bugs.webkit.org/show_bug.cgi?id=25536

  • editing/spelling/script-tests/spelling-attribute-change.js: Added.
  • editing/spelling/spelling-attribute-change-expected.txt: Added.
  • editing/spelling/spelling-attribute-change.html: Added.
  • fast/dom/HTMLElement/script-tests/spellcheck.js: Added.
  • fast/dom/HTMLElement/spellcheck-expected.txt: Added.
  • fast/dom/HTMLElement/spellcheck.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:

2010-10-27 MORITA Hajime <​morrita@google.com>

Reviewed by Kent Tamura.

WebKit needs to expose an Element::spellcheck attribute to javascript.
​https://bugs.webkit.org/show_bug.cgi?id=25536

Published Element.spellcheck property on IDL, implemented it.

Tests: editing/spelling/spelling-attribute-change.html

fast/dom/HTMLElement/spellcheck.html

  • html/HTMLElement.cpp: (WebCore::HTMLElement::spellcheck): (WebCore::HTMLElement::setSpellcheck):
  • html/HTMLElement.h:
  • html/HTMLElement.idl:
3:22 AM Changeset in webkit [70762] by pfeldman@chromium.org
  • 15 edits in trunk

2010-10-27 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: make debugger work against new resource manager.
​https://bugs.webkit.org/show_bug.cgi?id=48376

  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::identifierForInitialRequest):
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::identifierForInitialRequest):
  • inspector/InspectorResourceAgent.h:
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onGetResourceContent):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype.set content):
  • inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager): (WebInspector.ResourceManager.prototype.identifierForInitialRequest): (WebInspector.ResourceManager.prototype._createResource): (WebInspector.ResourceManager.prototype.willSendRequest): (WebInspector.ResourceManager.prototype._updateResourceWithRequest): (WebInspector.ResourceManager.prototype.didFinishLoading): (WebInspector.ResourceManager.prototype.didFailLoading): (WebInspector.ResourceManager.prototype.setOverrideContent): (WebInspector.ResourceManager.prototype._processCachedResources): (WebInspector.ResourceManager.prototype._addFramesRecursively): (WebInspector.ResourceManager.prototype.resourceForURL): (WebInspector.ResourceManager.prototype.addConsoleMessage): (WebInspector.ResourceManager.prototype.clearConsoleMessages): (WebInspector.ResourceManager.prototype.forAllResources): (WebInspector.ResourceManager.prototype._bindResourceURL): (WebInspector.ResourceManager.prototype._unbindResourceURL): (WebInspector.ResourceManager.getContent): (WebInspector.ResourceTreeModel): (WebInspector.ResourceTreeModel.prototype.didCommitLoadForFrame): (WebInspector.ResourceTreeModel.prototype.addResourceToFrame): (WebInspector.ResourceTreeModel.prototype._clearResources):
  • inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.addOrUpdateFrame):
  • inspector/front-end/networkPanel.css: (.network.panel .resources-dividers):

2010-10-27 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: make debugger work against new resource manager.
​https://bugs.webkit.org/show_bug.cgi?id=48376

  • http/tests/inspector/inspector-test2.js: (initialize_InspectorTest.InspectorTest.reloadPageIfNeeded): (initialize_InspectorTest.InspectorTest.pageReloaded):
  • http/tests/inspector/resource-har-conversion.html:
  • http/tests/inspector/resource-parameters.html:
  • inspector/extensions-resources.html:
2:25 AM Changeset in webkit [70761] by pfeldman@chromium.org
  • 1 edit in branches/chromium/552/WebCore/inspector/front-end/inspector.css

Merge 69494 - 2010-10-11 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: fix event listener breakpoints sidebar pane style
​https://bugs.webkit.org/show_bug.cgi?id=47487

  • inspector/front-end/inspector.css: (.section .properties, .event-bar .event-properties): (.section.expanded .properties, .event-bar.expanded .event-properties): (.properties-tree): (.properties-tree li): (.properties-tree li.parent): (.properties-tree li.parent::before): (.properties-tree li.parent.expanded::before): (.properties-tree li .info): (.properties-tree ol, .stack-trace ol, ol.stack-trace): (.properties-tree ol.expanded, .stack-trace ol, ol.stack-trace): (ol.stack-trace): (.event-listener-breakpoints .event-category): (.event-listener-breakpoints.properties-tree .children li): (.event-listener-breakpoints .checkbox-elem): (.breakpoint-list .breakpoint-hit):

TBR=​podivilov@chromium.org
BUG=61066

2:02 AM Changeset in webkit [70760] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit2

2010-10-28 Kimmo Kinnunen <​kimmo.t.kinnunen@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Web process cannot be debugged if it crashes in initialization
​https://bugs.webkit.org/show_bug.cgi?id=47399

Wait 3 seconds for the debugger on debug mode if
WEBKIT2_PAUSE_WEB_PROCESS_ON_LAUNCH environment variable is set.

The debugging can be initiated for example in following way:

export WEBKIT2_PAUSE_WEB_PROCESS_ON_LAUNCH=1
./MiniBrowser & while [ -z pidof QtWebProcess ]; do sleep 1; done; \

gdb --pid=pidof QtWebProcess

  • WebProcess/qt/WebProcessMainQt.cpp: (WebKit::WebProcessMainQt):
1:33 AM Changeset in webkit [70759] by aestes@apple.com
  • 2 edits in trunk/WebCore

One more Qt fix due to r70754.

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::hasValidClassId):

1:21 AM Changeset in webkit [70758] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-28 Pascal Massimino <​pascal.massimino@gmail.com>

Reviewed by Adam Barth.

fix setSize() call flow: it was only called the first
time (when onlySize is true)
Bug URL: ​https://bugs.webkit.org/show_bug.cgi?id=48494

Testing: difficult to exercise the bug, as it requires
some manual flow (change tab, scroll,...)

  • platform/image-decoders/webp/WEBPImageDecoder.cpp: (WebCore::WEBPImageDecoder::decode):

fix: call setSize() even when onlySize is false

1:16 AM Changeset in webkit [70757] by aestes@apple.com
  • 3 edits in trunk/WebCore

Fix the Qt build after r70754.

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::hasValidClassId):
(WebCore::HTMLObjectElement::updateWidget):

  • html/HTMLObjectElement.h:
1:08 AM Changeset in webkit [70756] by mrowe@apple.com
  • 2 edits in trunk/WebKit2

32-bit build fix.

Qualify references to Rect to avoid ambiguity between WebCore::Rect and Carbon's Rect.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::platformPostInitialize):
(WebKit::NetscapePlugin::windowFrameChanged):

1:02 AM Changeset in webkit [70755] by abarth@webkit.org
  • 3 edits in trunk/LayoutTests

2010-10-28 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Fix test description
​https://bugs.webkit.org/show_bug.cgi?id=48501

I mistakenly copy/pasted this text from another test.

  • fast/dom/allowed-children-expected.txt:
  • fast/dom/allowed-children.html:
12:47 AM Changeset in webkit [70754] by aestes@apple.com
  • 2 edits in trunk/WebCore

2010-10-28 Andy Estes <​aestes@apple.com>

Reviewed by Adam Barth.

Fix a test failure introduced in r70748 by supporting Qt's non-standard
use of classid.
​https://bugs.webkit.org/show_bug.cgi?id=45679

  • html/HTMLObjectElement.cpp: (WebCore::objectHasSupportedClassId): Return true if the object's serviceType is 'application/x-qt-plugin'. (WebCore::HTMLObjectElement::updateWidget): Do not render fallback content if a non-empty classid is specified for a Qt plugin object.
12:47 AM Changeset in webkit [70753] by mrowe@apple.com
  • 2 edits in trunk/WebKit

Stop allowing deprecated methods to be used in NetscapePluginHostProxy.mm now
that deprecated methods are no longer used.

  • WebKit.xcodeproj/project.pbxproj:
12:22 AM Changeset in webkit [70752] by zherczeg@webkit.org
  • 2 edits in trunk/JavaScriptCore

Wrong instruction form for BKPT
​https://bugs.webkit.org/show_bug.cgi?id=48427

Reviewed by Andreas Kling.

One '0' is missing from BKPT instruction.
Thanks for Jacob Bramley for reporting this error.

  • assembler/ARMAssembler.h:
12:14 AM Changeset in webkit [70751] by commit-queue@webkit.org
  • 18 edits in trunk

2010-10-28 Ivan Krstić <​ike@apple.com>

Reviewed by Mark Rowe.

Remove unused experimental proxied panel interface.
<rdar://problem/7237059>

  • WebCore.exp.in:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

2010-10-28 Ivan Krstić <​ike@apple.com>

Reviewed by Mark Rowe.

Remove unused experimental proxied panel interface.
<rdar://problem/7237059>

  • Plugins/Hosted/NetscapePluginHostManager.h:
  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::hostForPlugin): (WebKit::NetscapePluginHostManager::spawnPluginHost): (WebKit::NetscapePluginHostManager::instantiatePlugin):
  • Plugins/Hosted/NetscapePluginHostProxy.mm:
  • Plugins/Hosted/WebKitPluginClient.defs:
  • Plugins/Hosted/WebKitPluginHost.defs:
  • WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface):
  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]):
  • WebView/WebPreferencesPrivate.h:

2010-10-28 Ivan Krstić <​ike@apple.com>

Reviewed by Mark Rowe.

Remove unused experimental proxied panel interface.
<rdar://problem/7237059>

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm: (InitWebCoreSystemInterface):

2010-10-28 Ivan Krstić <​ike@apple.com>

Reviewed by Mark Rowe.

Remove unused experimental proxied panel interface.
<rdar://problem/7237059>

  • WebKitSystemInterface.h:
12:11 AM Changeset in webkit [70750] by xan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-10-28 Xan Lopez <​xlopez@igalia.com>

Try to fix Snow Leopard build.

  • jit/JITPropertyAccess.cpp: (JSC::JIT::testPrototype):
12:00 AM Changeset in webkit [70749] by xan@webkit.org
  • 13 edits in trunk/JavaScriptCore

2010-10-28 Xan Lopez <​xlopez@igalia.com>

Reviewed by Oliver Hunt.

Do not have two different asCell APIs in JSValue
​https://bugs.webkit.org/show_bug.cgi?id=47979

Remove JSCell* asCell(JSValue) in favor of only using
JSValue::asCell().

  • API/APICast.h: (toRef):
  • jit/JITPropertyAccess32_64.cpp: (JSC::JIT::testPrototype):
  • jit/JITStubs.cpp: (JSC::JITThunks::tryCachePutByID): (JSC::JITThunks::tryCacheGetByID): (JSC::DEFINE_STUB_FUNCTION):
  • runtime/GetterSetter.h: (JSC::asGetterSetter):
  • runtime/JSByteArray.h: (JSC::asByteArray):
  • runtime/JSCell.h: (JSC::JSCell::getCallData): (JSC::JSCell::getConstructData):
  • runtime/JSString.h: (JSC::RopeBuilder::appendValueInConstructAndIncrementLength): (JSC::asString):
  • runtime/JSValue.h:
  • runtime/Operations.cpp: (JSC::jsIsObjectType):
  • runtime/Operations.h: (JSC::normalizePrototypeChain):
  • runtime/Protect.h: (JSC::gcProtect): (JSC::gcUnprotect):

Oct 27, 2010:

11:15 PM Changeset in webkit [70748] by aestes@apple.com
  • 5 edits
    2 adds in trunk

2010-10-27 Andy Estes <​aestes@apple.com>

Reviewed by Adam Barth.

r66156 broke AtlasCT library, formerly affected ​http://map.d.co.il/
​https://bugs.webkit.org/show_bug.cgi?id=45679

This patch removes WebKit's map of classid values to MIME types. It also
changes the behavior of object elements to render fallback content when
a non-empty classid attribute is specified, which is the behavior HTML5
specifies when a UA encounters a classid it doesn't understand.

Test: fast/replaced/object-with-non-empty-classid-triggers-fallback.html

  • html/HTMLObjectElement.cpp: Remove serviceTypeForClassId(), createClassIdToTypeMap(), and the ClassIdToTypeMap typedef. (WebCore::HTMLObjectElement::updateWidget): Do not call serviceTypeForClassId() when there is no type attribute, and render fallback content if the classid attribute is non-empty.

2010-10-27 Andy Estes <​aestes@apple.com>

Reviewed by Adam Barth.

r66156 broke AtlasCT library, formerly affected ​http://map.d.co.il/
​https://bugs.webkit.org/show_bug.cgi?id=45679

  • fast/dom/object-embed-plugin-scripting.html: Changed classid attributes to type attributes.
  • fast/dom/object-plugin-hides-properties.html: Ditto.
  • fast/replaced/object-with-non-empty-classid-triggers-fallback-expected.txt: Added.
  • fast/replaced/object-with-non-empty-classid-triggers-fallback.html: Added.
10:12 PM Changeset in webkit [70747] by eric@webkit.org
  • 2 edits
    2 adds in trunk/WebKitTools

2010-10-27 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

webkit-patch suggest-reviewers -g 260550a6e30b7bf34f16bdb4a5396cf26264fc1c is very slow
​https://bugs.webkit.org/show_bug.cgi?id=48500

This doesn't fix the problem, but it makes things slightly better.
Each git svn find-rev call takes about .25 seconds on my desktop.
This patch uses a new memoized class to avoid those calls when possible.

The real slowness is still git log on some files, like:
git log --pretty=format:%H -5 -- /Projects/WebKit/WebCore/platform/wx/SearchPopupMenuWx.h
I'm not yet sure how to make the pathological git logs better.

  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/memoized.py: Added.
  • Scripts/webkitpy/common/memoized_unittest.py: Added.
9:00 PM Changeset in webkit [70746] by kinuko@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-27 Kinuko Yasuda <​kinuko@chromium.org>

Unreviewed, updating drt_expectations.txt.

  • platform/chromium/drt_expectations.txt:
8:57 PM Changeset in webkit [70745] by commit-queue@webkit.org
  • 12 edits
    1 copy in trunk

2010-10-27 Eric Uhrhane <​ericu@chromium.org>

Reviewed by David Levin.

[Chromium] Metadata queries should return full file info, not just modification time
​https://bugs.webkit.org/show_bug.cgi?id=48098

LayoutTests that use this functionality via WorkerAsyncFileWriter are in review.

Build file changes to add FileMetadata.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

The rest of the changes here just pass the new FileMetadata object through calls that used to take a modification time.

  • platform/FileMetadata.h: Added. (WebCore::FileMetadata::FileMetadata):
  • fileapi/FileSystemCallbacks.cpp: (WebCore::FileSystemCallbacksBase::didReadMetadata): (WebCore::MetadataCallbacks::didReadMetadata):
  • fileapi/FileSystemCallbacks.h:
  • platform/AsyncFileSystemCallbacks.h:

2010-10-27 Eric Uhrhane <​ericu@chromium.org>

Reviewed by David Levin.

[Chromium] Metadata queries should return full file info, not just modification time
​https://bugs.webkit.org/show_bug.cgi?id=48098

  • src/AssertMatchingEnums.cpp: Ensure WebFileInfo and FileMetadata use the same values for file/directory indicators.
  • src/WebFileSystemCallbacksImpl.cpp: (WebKit::WebFileSystemCallbacksImpl::didReadMetadata): Pass through the new information.
8:48 PM Changeset in webkit [70744] by kinuko@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-27 Kinuko Yasuda <​kinuko@chromium.org>

Unreviewed, update drt_expectations.txt.

  • platform/chromium/drt_expectations.txt:
8:38 PM Changeset in webkit [70743] by crogers@google.com
  • 1 edit
    2 adds in trunk/WebCore

2010-10-27 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

Add VectorMath files
​https://bugs.webkit.org/show_bug.cgi?id=48467

No new tests since audio API is not yet implemented.

  • platform/audio/VectorMath.cpp: Added. (WebCore::VectorMath::vsmul): (WebCore::VectorMath::vadd):
  • platform/audio/VectorMath.h: Added.
8:21 PM Changeset in webkit [70742] by crogers@google.com
  • 15 edits in trunk/WebCore

2010-10-27 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

Fixup files affected by VectorMath and related API changes
​https://bugs.webkit.org/show_bug.cgi?id=48481

No new tests since audio API is not yet implemented.

  • platform/audio/AudioBus.cpp:
  • platform/audio/AudioChannel.cpp:
  • platform/audio/Biquad.cpp:
  • platform/audio/FFTConvolver.cpp:
  • platform/audio/FFTConvolver.h:
  • platform/audio/Panner.cpp: (WebCore::Panner::create):
  • platform/audio/Reverb.cpp: (WebCore::calculateNormalizationScale): (WebCore::Reverb::initialize): (WebCore::Reverb::process):
  • platform/audio/ReverbAccumulationBuffer.cpp:
  • platform/audio/ReverbAccumulationBuffer.h:
  • platform/audio/ReverbConvolver.cpp: (WebCore::ReverbConvolver::ReverbConvolver): (WebCore::ReverbConvolver::process):
  • platform/audio/ReverbConvolver.h:
  • platform/audio/ReverbConvolverStage.cpp: (WebCore::ReverbConvolverStage::ReverbConvolverStage):
  • platform/audio/ReverbConvolverStage.h:
  • platform/audio/ReverbInputBuffer.h:
8:18 PM Changeset in webkit [70741] by kinuko@chromium.org
  • 24 edits
    3 adds in trunk

2010-10-27 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Dumitru Daniliuc.

DOMFileSystem's reference should be kept while there're any active Entries/callbacks
​https://bugs.webkit.org/show_bug.cgi?id=47535

Changed to keep DOMFileSystem's reference in each EntryBase, DirectoryReaderBase, EntryCallbacks and EntriesCallbacks.

Test: fast/filesystem/filesystem-reference.html

  • fileapi/DOMFileSystemBase.cpp: (WebCore::DOMFileSystemBase::readDirectory): Changed to pass/take PassRefPtr but not a raw pointer.
  • fileapi/DOMFileSystemBase.h:
  • fileapi/DirectoryEntry.cpp: (WebCore::DirectoryEntry::DirectoryEntry): Ditto. (WebCore::DirectoryEntry::createReader):
  • fileapi/DirectoryEntry.h: (WebCore::DirectoryEntry::create): Ditto.
  • fileapi/DirectoryEntrySync.cpp: (WebCore::DirectoryEntrySync::DirectoryEntrySync): Ditto.
  • fileapi/DirectoryEntrySync.h: (WebCore::DirectoryEntrySync::create): Ditto.
  • fileapi/DirectoryReader.h: (WebCore::DirectoryReader::filesystem):
  • fileapi/DirectoryReaderBase.h: (WebCore::DirectoryReaderBase::filesystem):
  • fileapi/Entry.cpp: (WebCore::Entry::Entry): Ditto.
  • fileapi/Entry.h: (WebCore::Entry::filesystem):
  • fileapi/EntryBase.h: (WebCore::EntryBase::filesystem): (WebCore::EntryBase::EntryBase): Ditto.
  • fileapi/EntrySync.cpp: (WebCore::EntrySync::create): Ditto. (WebCore::EntrySync::getParent): (WebCore::EntrySync::EntrySync): Ditto.
  • fileapi/EntrySync.h: (WebCore::EntrySync::filesystem):
  • fileapi/FileEntry.cpp: (WebCore::FileEntry::FileEntry): Ditto.
  • fileapi/FileEntry.h: (WebCore::FileEntry::create): Ditto.
  • fileapi/FileEntrySync.cpp: (WebCore::FileEntrySync::FileEntrySync): Ditto.
  • fileapi/FileEntrySync.h: (WebCore::FileEntrySync::create): Ditto.
  • fileapi/FileSystemCallbacks.cpp: (WebCore::EntriesCallbacks::create): Ditto. (WebCore::EntriesCallbacks::EntriesCallbacks): Ditto.
  • fileapi/FileSystemCallbacks.h:

2010-10-27 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Dumitru Daniliuc.

DOMFileSystem's reference should be kept while there're any active Entries/callbacks
​https://bugs.webkit.org/show_bug.cgi?id=47535

  • fast/filesystem/filesystem-reference-expected.txt: Added.
  • fast/filesystem/filesystem-reference.html: Added.
  • fast/filesystem/script-tests/filesystem-reference.js: Added.
8:11 PM Changeset in webkit [70740] by yuzo@google.com
  • 4 edits
    2 adds in trunk

2010-10-27 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Eric Seidel.

Fix for Bug 48310 - SVG font-face-name without name attribute causes a crash
​https://bugs.webkit.org/show_bug.cgi?id=48310

  • svg/custom/font-face-name-without-name-attr-expected.txt: Added.
  • svg/custom/font-face-name-without-name-attr.svg: Added.

2010-10-27 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Eric Seidel.

Fix for Bug 48310 - SVG font-face-name without name attribute causes a crash
​https://bugs.webkit.org/show_bug.cgi?id=48310

Test: svg/custom/font-face-name-without-name-attr.svg

  • svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::rebuildFontFace): Don't create src property if the src value list is empty.
  • svg/SVGFontFaceSrcElement.cpp: (WebCore::SVGFontFaceSrcElement::srcValue): Don't add empty src values to the src value list.
8:02 PM Changeset in webkit [70739] by crogers@google.com
  • 2 edits in trunk/WebCore

2010-10-27 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

Allow AudioDSPKernel to function without an AudioDSPKernelProcessor
​https://bugs.webkit.org/show_bug.cgi?id=48472

No new tests since audio API is not yet implemented.

  • platform/audio/AudioDSPKernel.h: (WebCore::AudioDSPKernel::AudioDSPKernel): (WebCore::AudioDSPKernel::sampleRate):
7:37 PM Changeset in webkit [70738] by mrowe@apple.com
  • 2 edits in trunk/WebKit2

Build fix.

  • UIProcess/API/mac/PageClientImpl.mm: Reference the file using the correct case.
6:44 PM Changeset in webkit [70737] by andersca@apple.com
  • 7 edits in trunk

Find indicators do not bounce
​https://bugs.webkit.org/show_bug.cgi?id=48490
<rdar://problem/8564276>

Reviewed by Sam Weinig.

WebKit2:

  • UIProcess/API/mac/FindIndicatorWindow.h:
  • UIProcess/API/mac/FindIndicatorWindow.mm:

(-[WebFindIndicatorWindowAnimation _initWithFindIndicatorWindow:WebKit::animationDuration:animationProgressCallback:WebKit::FindIndicatorWindow::animationDidEndCallback:WebKit::FindIndicatorWindow::]):
Add an animationDuration parameter.

(WebKit::FindIndicatorWindow::FindIndicatorWindow):
Initialize m_bounceAnimationContext.

(WebKit::FindIndicatorWindow::setFindIndicator):
Create a bounce animation and start it.

(WebKit::FindIndicatorWindow::closeWindow):
Stop the bounce animation and destroy the bounce animation context.

(WebKit::FindIndicatorWindow::startFadeOutTimerFired):
pass the fade out duration.

(WebKit::FindIndicatorWindow::bounceAnimationCallback):
Set the bounce animation progress.

(WebKit::FindIndicatorWindow::bounceAnimationDidEnd):
Destroy the bounce animation context.

WebKitLibraries:

Add bounce animation context functions.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
6:30 PM Changeset in webkit [70736] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-10-27 Chao-ying Fu <​fu@mips.com>

Reviewed by Oliver Hunt.

Support emit_op_mod() for MIPS on JSVALUE32_64
​https://bugs.webkit.org/show_bug.cgi?id=46511

This patch uses MIPS div instructions for op_mod to improve performance.

  • jit/JITArithmetic32_64.cpp: (JSC::JIT::emit_op_mod):
6:07 PM Changeset in webkit [70735] by senorblanco@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

2010-10-27 Stephen White <​senorblanco@chromium.org>

Reviewed by Kenneth Russell.

[CHROMIUM] Unskip the failing tests in chromium-gpu, and adjust the
expectations to match reality.
​https://bugs.webkit.org/show_bug.cgi?id=48473


Some bugs were already fixed and the test lines could be removed, some
tests have started newly-failing. Rebaselined one test that had a bad
checksum.

  • platform/chromium-gpu-linux/compositing/iframes/composited-iframe-alignment-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/iframes/composited-iframe-alignment-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/iframes/composited-iframe-alignment-expected.txt: Added.
  • platform/chromium-gpu/test_expectations.txt:
5:55 PM Changeset in webkit [70734] by andreas.kling@nokia.com
  • 3 edits in trunk/WebKit2

2010-10-27 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Andreas Kling.

Remove the reference to the pageNamespace in the QWKPagePrivate.
Access it though the WebPageProxy instead which holds a strong
ref to it.

  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::QWKPagePrivate): (QWKPage::preferences):
  • UIProcess/API/qt/qwkpage_p.h:
5:48 PM Changeset in webkit [70733] by andersca@apple.com
  • 8 edits in trunk/WebKit2

More work on downloads
​https://bugs.webkit.org/show_bug.cgi?id=48480

Reviewed by Sam Weinig.

  • WebProcess/Downloads/Download.cpp:

(WebKit::Download::~Download):
Call platformInvalidate().

(WebKit::Download::didBegin):
(WebKit::Download::didReceiveData):
(WebKit::Download::didFinish):
Add empty stubs.

  • WebProcess/Downloads/DownloadManager.cpp:

(WebKit::DownloadManager::startDownload):
Create a Download object and insert it into the m_downloads map.

  • WebProcess/Downloads/cf/DownloadCFNet.cpp:

(WebKit::Download::platformInvalidate):
Add empty stub.

  • WebProcess/Downloads/mac/DownloadMac.mm:

(WebKit::Download::platformInvalidate):
Tell the WKDownloadAsDelegate object that we're being invalidated.

(-[WKDownloadAsDelegate downloadDidBegin:]):
Call Download::didBegin.

(-[WKDownloadAsDelegate download:didReceiveDataOfLength:]):
Call Download::didReceiveData.

(-[WKDownloadAsDelegate downloadDidFinish:]):
Call Download::didFinish.

  • WebProcess/Downloads/qt/DownloadQt.cpp:

(WebKit::Download::platformInvalidate):
Add empty stub.

5:42 PM Changeset in webkit [70732] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/mac

2010-10-27 Pratik Solanki <​psolanki@apple.com>

Reviewed by Darin Adler.

Improve memSize calculation in [WebView _setCacheModel]
​https://bugs.webkit.org/show_bug.cgi?id=48484

  • WebView/WebView.mm: (roundUpToPowerOf2): Added. Utility function to calculate the nearest power of 2. (+[WebView _setCacheModel:]): Update memSize calculation to set it to the next bigger power of 2. Also update WebCore cache settings.
5:05 PM Changeset in webkit [70731] by eric@webkit.org
  • 5 edits in trunk/WebKitTools

2010-10-27 Eric Seidel <​eric@webkit.org>

Reviewed by Ojan Vafai.

EWS bots should not use --quiet when running build-webkit
​https://bugs.webkit.org/show_bug.cgi?id=48482

--quiet is only correct when the sub-process does the error reporting.
In the case of _can_build() the parent process is reporting the error.
We'd like the full build log at queues.webkit.org so someone can look
at the log and understand why the EWS is failing to build trunk.

  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
5:04 PM Changeset in webkit [70730] by enrica@apple.com
  • 18 edits in trunk

WebCore: Support Appkit key bindings and custom key bindings in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=48271
<rdar://problem/7660723>

Reviewed by Alexey Proskuryakov.

  • dom/KeyboardEvent.h:

(WebCore::KeypressCommand::KeypressCommand): Added default constructor and modified assert for text
insertion command constructor to support WebKit2 scenarios.
The default constructor is needed to support the generated WebKit2 message processing code.

WebKit2: Support Appkit key bindings and custom key bindings in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=48271
<rdar://problem/7660723>

Reviewed by Alexey Proskuryakov.

We need to support AppKit key bindings and custom key bindings in WebKit2.
Every keyboard event is first sent to the WebProcess and we inform AppKit that
we don't need further processing. When the event is processed by the WebProcess and no handler consumes it,
we send a synchronous message back to the UI process to let AppKit perform the key bindings.
This operation can result in one or more editing commands to execute or a noop.
The WebProcess then replies back to the UI process to inform whether further processing is required, in
which case the event is sent back to the application to be mapped.
There is a potential for a race condition: in case the WebProcess is very slow to process the key events, the UI
process could be in a completely different state when the event is being resent (for example it might not have the
keyboard focus anymore) and the command could be lost. We should look out for user experience impact.

  • Scripts/webkit2/messages.py: Added header file in the generated file.
  • Shared/WebCoreArgumentCoders.h: Added encoder/decoder for KeypressCommand.
  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::interceptKeyEvent): Pass-through call to WKView.
(WebKit::PageClientImpl::didNotHandleKeyEvent): Added logic to resend the event to the application.

  • UIProcess/API/mac/WKView.mm:

(-[WKView validateUserInterfaceItem:]): Changed the default return value to YES, otherwise no menu shortcut is performed.
(-[WKView doCommandBySelector:]): Added.
(-[WKView insertText:]): Added.
(-[WKView _handleStyleKeyEquivalent:]): Added to handle command-B and command-I.
(-[WKView performKeyEquivalent:]): Added to intercept key binding sequences.
(-[WKView _setEventBeingResent:]):
(-[WKView _interceptKeyEvent:]):

  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::interpretKeyEvent):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:
  • WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:

(WebKit::WebEditorClient::handleKeyboardEvent):
(WebKit::WebEditorClient::handleInputMethodKeydown):

  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/mac/WebPageMac.mm: Moved handleKeyboardEvent and handleInputMethodKeydown

to the Mac specific implementation.
(WebKit::WebPage::interceptEditingKeyboardEvent): Added.

4:56 PM Changeset in webkit [70729] by jschuh@chromium.org
  • 1 edit
    2 copies in branches/chromium/552

Merge 70652 - 2010-10-27 Justin Schuh <​jschuh@chromium.org>

Reviewed by Dirk Schulze.

Ignore invalid blend modes
​https://bugs.webkit.org/show_bug.cgi?id=48371

Test: svg/filters/feBlend-invalid-mode.xhtml

  • platform/graphics/filters/FEBlend.cpp: (WebCore::FEBlend::apply):

2010-10-27 Justin Schuh <​jschuh@chromium.org>

Reviewed by Dirk Schulze.

Ignore invalid blend modes
​https://bugs.webkit.org/show_bug.cgi?id=48371

  • svg/filters/feBlend-invalid-mode-expected.txt: Added.
  • svg/filters/feBlend-invalid-mode.xhtml: Added.

BUG=60688
TBR=​jschuh@chromium.org

4:53 PM Changeset in webkit [70728] by bweinstein@apple.com
  • 4 edits in trunk

WebKit2: More Windows build fixage. Copy another new header into WebKitOutputDir.

  • win/WebKit2Generated.make:

WebKitTools: More Windows build fixage. Rename a variable that was named string.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::hasPrefix):

4:52 PM Changeset in webkit [70727] by jschuh@chromium.org
  • 1 edit
    2 copies in branches/chromium/517

Merge 70652 - 2010-10-27 Justin Schuh <​jschuh@chromium.org>

Reviewed by Dirk Schulze.

Ignore invalid blend modes
​https://bugs.webkit.org/show_bug.cgi?id=48371

Test: svg/filters/feBlend-invalid-mode.xhtml

  • platform/graphics/filters/FEBlend.cpp: (WebCore::FEBlend::apply):

2010-10-27 Justin Schuh <​jschuh@chromium.org>

Reviewed by Dirk Schulze.

Ignore invalid blend modes
​https://bugs.webkit.org/show_bug.cgi?id=48371

  • svg/filters/feBlend-invalid-mode-expected.txt: Added.
  • svg/filters/feBlend-invalid-mode.xhtml: Added.

BUG=60688
TBR=​jschuh@chromium.org
Review URL: ​http://codereview.chromium.org/4133004

4:40 PM Changeset in webkit [70726] by bfulgham@webkit.org
  • 2 edits in trunk/JavaScriptCore

Unreviewed build correction.

  • wtf/Platform.h: Make sure ACCELERATED_COMPOSITING is

turned off in the WinCairo port. This isn't supported (yet.)

4:39 PM Changeset in webkit [70725] by bweinstein@apple.com
  • 2 edits in trunk/WebKit2

Windows build fix. Copy a new header into WebKitOutputDir.

  • win/WebKit2Generated.make:
4:33 PM Changeset in webkit [70724] by ojan@chromium.org
  • 7 edits in trunk/WebKitTools

2010-10-27 Ojan Vafai <​ojan@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Make the test results server store which master the bot is on
​https://bugs.webkit.org/show_bug.cgi?id=48478

The chromium bots recently changed so that there are multiple slaves with
the same name on different masters. Up till now, the test results server
assumed slave names were unique. Adds a master field to the file in order
to distinguish.

Also, for files that currently lack a master or testtype, set them appropriately.

  • TestResultServer/handlers/testfilehandler.py:
  • TestResultServer/index.yaml:
  • TestResultServer/model/jsonresults.py:
  • TestResultServer/model/testfile.py:
  • TestResultServer/templates/showfilelist.html:
  • TestResultServer/templates/uploadform.html:
4:18 PM Changeset in webkit [70723] by Darin Adler
  • 61 edits
    8 copies in trunk

2010-10-26 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

WebKitTestRunner needs to support layoutTestController.dumpBackForwardList
​https://bugs.webkit.org/show_bug.cgi?id=42322
rdar://problem/8193631

WebKitTestRunner needs to support layoutTestController.clearBackForwardList
​https://bugs.webkit.org/show_bug.cgi?id=42333
rdar://problem/8193643

  • History/WebBackForwardList.mm: (core): Return BackForwardListImpl. (kit): Take BackForwardListImpl. (-[WebBackForwardList initWithBackForwardList:]): Use BackForwardListImpl. (-[WebBackForwardList dealloc]): Ditto. (-[WebBackForwardList finalize]): Ditto. (-[WebBackForwardList description]): Ditto. (-[WebBackForwardList setPageCacheSize:]): Ditto. (-[WebBackForwardList pageCacheSize]): Ditto.
  • History/WebBackForwardListInternal.h: Ditto.
  • WebView/WebFrameView.mm: (-[WebFrameView keyDown:]): Ditto.
  • WebView/WebView.mm: (-[WebView initWithCoder:]): Ditto. (-[WebView encodeWithCoder:]): Ditto. (-[WebView backForwardList]): Ditto. (-[WebView setMaintainsBackForwardList:]): Ditto.

2010-10-26 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

WebKitTestRunner needs to support layoutTestController.dumpBackForwardList
​https://bugs.webkit.org/show_bug.cgi?id=42322
rdar://problem/8193631

WebKitTestRunner needs to support layoutTestController.clearBackForwardList
​https://bugs.webkit.org/show_bug.cgi?id=42333
rdar://problem/8193643

  • WebCore.exp.in: Updated exports.
  • history/BackForwardList.h: Added comments about future refactoring. Moved functions that are not called inside WebCore into a separate section, to be removed later. Added an isActive function to replace the use of enabled() and entries().
  • history/BackForwardListImpl.h: Removed isBackForwardListImpl. Marked virtual function overrides virtual explicitly, except for the ones that will be non-virtual once we make the changes above. Added the isActive function.
  • history/PageCache.cpp: (WebCore::logCanCachePageDecision): Use isActive. (WebCore::PageCache::canCache): Ditto.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkDidPerformFirstNavigation): Check using currentItem, backItem, and forwardItem instead of using entries.
  • page/Settings.cpp: (WebCore::Settings::setUsesPageCache): Loop through the back/forward list entries using backListCount and forwardListCount instead of using entries.

2010-10-26 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

WebKitTestRunner needs to support layoutTestController.dumpBackForwardList
​https://bugs.webkit.org/show_bug.cgi?id=42322
rdar://problem/8193631

WebKitTestRunner needs to support layoutTestController.clearBackForwardList
​https://bugs.webkit.org/show_bug.cgi?id=42333
rdar://problem/8193643

  • platform/mac-wk2/Skipped: Resorted some test lists. Removed the section listing all the tests that were blocked by dumpBackForwardList.

2010-10-26 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

WebKitTestRunner needs to support layoutTestController.dumpBackForwardList
​https://bugs.webkit.org/show_bug.cgi?id=42322
rdar://problem/8193631

WebKitTestRunner needs to support layoutTestController.clearBackForwardList
​https://bugs.webkit.org/show_bug.cgi?id=42333
rdar://problem/8193643

  • WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Renamed the product to WebKitTestRunnerInjectedBundle to avoid name conflicts in the build directory.
  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added dumpBackForwardList and clearBackForwardList.
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::InjectedBundle): Removed initialization of m_mainPage. (WTR::InjectedBundle::didCreatePage): Removed unneeded underscore. (WTR::InjectedBundle::willDestroyPage): Ditto. (WTR::InjectedBundle::didReceiveMessage): Ditto. (WTR::InjectedBundle::initialize): Ditto. (WTR::InjectedBundle::didCreatePage): Changed code to use m_pages instead of m_mainPage and m_otherPages. (WTR::InjectedBundle::willDestroyPage): Ditto. (WTR::InjectedBundle::page): Ditto. (WTR::InjectedBundle::beginTesting): Ditto. (WTR::InjectedBundle::done): Ditto. (WTR::InjectedBundle::closeOtherPages): Ditto. (WTR::InjectedBundle::dumpBackForwardListsForAllPages): Added.
  • WebKitTestRunner/InjectedBundle/InjectedBundle.h: Changed page function to longer be inline, and pageCount function to use m_pages. Added dumpBackForwardListsForAllPages, and removed some underscores. Replaced m_mainPage and m_otherPageas with m_pages.
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::adoptWK): Added. (WTR::hasPrefix): Added. (WTR::InjectedBundlePage::reset): Added code to set up m_previousTestBackForwardListItem. (WTR::InjectedBundlePage::dump): Added code to call dumpBackForwardListsForAllPages. (WTR::compareByTargetName): Added. (WTR::dumpBackForwardListItem): Added. (WTR::InjectedBundlePage::dumpBackForwardList): Added.
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added dumpBackForwardList and m_previousTestBackForwardListItem.
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::LayoutTestController): Initialize m_shouldDumpBackForwardListsForAllWindows to false. (WTR::LayoutTestController::clearBackForwardList): Added.
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added dumpBackForwardList, clearBackForwardList, shouldDumpBackForwardListsForAllWindows, and m_shouldDumpBackForwardListsForAllWindows.
  • WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): Set up didReceiveSynchronousMessageFromInjectedBundle. (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle): Added.
  • WebKitTestRunner/TestController.h: Ditto.
  • WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): Added.
  • WebKitTestRunner/TestInvocation.h: Ditto.
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Renamed bundle to WebKitTestRunnerInjectedBundle (see above).
  • WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::initializeInjectedBundlePath): Ditto.

2010-10-26 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

WebKitTestRunner needs to support layoutTestController.dumpBackForwardList
​https://bugs.webkit.org/show_bug.cgi?id=42322
rdar://problem/8193631

WebKitTestRunner needs to support layoutTestController.clearBackForwardList
​https://bugs.webkit.org/show_bug.cgi?id=42333
rdar://problem/8193643

  • Shared/API/c/WKBase.h: Added WKBundleBackForwardListRef and WKBundleBackForwardListItemRef.
  • Shared/API/c/WKURL.cpp: (WKURLCopyString): Added.
  • Shared/API/c/WKURL.h: Added WKURLCopyString.
  • Shared/API/c/cf/WKURLCF.h: Fixed incorrect argument name.
  • Shared/APIObject.h: Added TypeBundleBackForwardList and TypeBundleBackForwardListItem.
  • Shared/ImmutableArray.h: Marked destructor virtual explicitly.
  • Shared/ImmutableDictionary.h: Ditto.
  • UIProcess/WebBackForwardListItem.h: Ditto.
  • UIProcess/WebContext.h: Ditto.
  • UIProcess/WebFrameProxy.h: Ditto.
  • UIProcess/WebNavigationData.h: Ditto.
  • UIProcess/WebPageNamespace.h: Ditto.
  • UIProcess/WebPreferences.h: Ditto.
  • WebProcess/InjectedBundle/InjectedBundleScriptWorld.h: Ditto.
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h: Ditto.
  • WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h: Ditto.
  • UIProcess/WebBackForwardList.cpp: Removed unneeded backListWithLimit and forwardListWithLimit functions. (WebKit::WebBackForwardList::clear): Added.
  • UIProcess/WebBackForwardList.h: Marked destructor virtual explicitly. Added clear, removed backListWithLimit and forwardListWithLimit functions.
  • UIProcess/WebPageProxy.cpp: Removed unneeded backForwardBackItem, backForwardCurrentItem, and backForwardForwardItem functions. (WebKit::WebPageProxy::backForwardClear): Added.
  • UIProcess/WebPageProxy.h: Ditto.
  • UIProcess/WebPageProxy.messages.in: Ditto.
  • WebKit2.pro: Added new files.
  • WebKit2.xcodeproj/project.pbxproj: Ditto.
  • win/WebKit2.vcproj: Ditto.
  • WebProcess/InjectedBundle/API/c/WKBundleAPICast.h: Added WKBundleBackForwardListRef and WKBundleBackForwardListItemRef.
  • WebProcess/InjectedBundle/API/c/WKBundleBackForwardList.cpp: Started with a copy of from WebKit2/UIProcess/API/C/WKBackForwardList.cpp.
  • WebProcess/InjectedBundle/API/c/WKBundleBackForwardList.h: Started with a copy of WebKit2/UIProcess/API/C/WKBackForwardList.h.
  • WebProcess/InjectedBundle/API/c/WKBundleBackForwardListItem.cpp: Started with a copy of WebKit2/UIProcess/API/C/WKBackForwardListItem.cpp.
  • WebProcess/InjectedBundle/API/c/WKBundleBackForwardListItem.h: Started with a copy of WebKit2/UIProcess/API/C/WKBackForwardListItem.h.
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePageGetBackForwardList): Added.
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h: Ditto.
  • WebProcess/InjectedBundle/InjectedBundleBackForwardList.cpp: Started with a copy of WebKit2/UIProcess/WebBackForwardList.cpp.
  • WebProcess/InjectedBundle/InjectedBundleBackForwardList.h: Started with a copy of WebKit2/UIProcess/WebBackForwardList.h.
  • WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.cpp: Started with a copy of WebKit2/UIProcess/WebBackForwardListItem.cpp.
  • WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.h: Started with a copy of WebKit2/UIProcess/WebBackForwardListItem.h.
  • WebProcess/WebPage/WebBackForwardListProxy.cpp: Removed many unneeded functions. (WebKit::WebBackForwardListProxy::WebBackForwardListProxy): Removed unneeded initialization of m_closed. (WebKit::WebBackForwardListProxy::addItem): Added a check for the case of a capacity of 0. (WebKit::WebBackForwardListProxy::goToItem): Added a check for when the proxy outlives its page. (WebKit::WebBackForwardListProxy::itemAtIndex): Ditto. (WebKit::WebBackForwardListProxy::backListCount): Ditto. (WebKit::WebBackForwardListProxy::forwardListCount): Ditto. (WebKit::WebBackForwardListProxy::close): Removed unneeded code setting m_closed. (WebKit::WebBackForwardListProxy::isActive): Added. (WebKit::WebBackForwardListProxy::clear): Added.
  • WebProcess/WebPage/WebBackForwardListProxy.h: Added clear, isActive, and detach functions. Removed many other unneeded function and data members.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::~WebPage): Added call to detach on the back/forward list. (WebKit::WebPage::backForwardList): Added.
  • WebProcess/WebPage/WebPage.h: Added backForwardList function and m_backForwardList data member.
3:44 PM Changeset in webkit [70722] by crogers@google.com
  • 9 edits in trunk

2010-10-27 Chris Rogers <​crogers@google.com>

Reviewed by Chris Marrin.

Add ENABLE_WEB_AUDIO feature enable flag (initially disabled) to build-webkit
​https://bugs.webkit.org/show_bug.cgi?id=48279

  • Configurations/FeatureDefines.xcconfig:

2010-10-27 Chris Rogers <​crogers@google.com>

Reviewed by Chris Marrin.

Add ENABLE_WEB_AUDIO feature enable flag (initially disabled) to build-webkit
​https://bugs.webkit.org/show_bug.cgi?id=48279

No new tests since flag is disabled.

  • Configurations/FeatureDefines.xcconfig:

2010-10-27 Chris Rogers <​crogers@google.com>

Reviewed by Chris Marrin.

Add ENABLE_WEB_AUDIO feature enable flag (initially disabled) to build-webkit
​https://bugs.webkit.org/show_bug.cgi?id=48279

  • Configurations/FeatureDefines.xcconfig:

2010-10-27 Chris Rogers <​crogers@google.com>

Reviewed by Chris Marrin.

Add ENABLE_WEB_AUDIO feature enable flag (initially disabled) to build-webkit
​https://bugs.webkit.org/show_bug.cgi?id=48279

  • Scripts/build-webkit:
3:38 PM Changeset in webkit [70721] by Martin Robinson
  • 8 edits in trunk/LayoutTests

2010-10-27 Martin Robinson <​mrobinson@igalia.com>

Rebaseline some GTK+ tests after r70688.

  • platform/gtk/fast/css/font-face-opentype-expected.txt:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
  • platform/gtk/fast/forms/select-writing-direction-natural-expected.txt:
  • platform/gtk/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/gtk/fast/text/backslash-to-yen-sign-euc-expected.txt:
  • platform/gtk/fast/text/backslash-to-yen-sign-expected.txt:
  • platform/gtk/fast/text/international/plane2-expected.txt:
3:37 PM Changeset in webkit [70720] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-10-27 Eric Seidel <​eric@webkit.org>

Unreviewed.

build-webkit should collect Visual Studio Express logs and display them
​https://bugs.webkit.org/show_bug.cgi?id=39199

It turns out my previous patch wasn't actually working on the win-ews
machine. So I've fixed my mistakes from before.

  • Scripts/build-webkit:
    • Windows VSE builds change the CWD while building. Why? Who knows.
  • Scripts/print-vse-failure-logs:
    • windows VSE builds don't use Debug/Release as I expected, so I've moved off of --configuration to --top-level and added the /obj optimization while I was there.
3:28 PM Changeset in webkit [70719] by crogers@google.com
  • 1 edit
    2 adds in trunk/WebCore

2010-10-27 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

Add AudioResamplerKernel files
​https://bugs.webkit.org/show_bug.cgi?id=47624

No new tests since audio API is not yet implemented.

  • platform/audio/AudioResamplerKernel.cpp: Added. (WebCore::AudioResamplerKernel::AudioResamplerKernel): (WebCore::AudioResamplerKernel::getSourcePointer): (WebCore::AudioResamplerKernel::process): (WebCore::AudioResamplerKernel::reset): (WebCore::AudioResamplerKernel::rate):
  • platform/audio/AudioResamplerKernel.h: Added.
2:57 PM Changeset in webkit [70718] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

2010-10-27 Adam Barth <​abarth@webkit.org>

Reviewed by Ojan Vafai.

REGRESSION(66511): CORDYS Process Factory doesn't work
​https://bugs.webkit.org/show_bug.cgi?id=48453

Test some appendChild cases that didn't have coverage before.

  • fast/dom/allowed-children-expected.txt: Added.
  • fast/dom/allowed-children.html: Added.

2010-10-27 Adam Barth <​abarth@webkit.org>

Reviewed by Ojan Vafai.

REGRESSION(66511): CORDYS Process Factory doesn't work
​https://bugs.webkit.org/show_bug.cgi?id=48453

When Ojan refactored this function in 66511, he missed an "else",
which causes us to generated HIERARCHY_REQUEST_ERR in some cases where
we're not supposed to. This patch restores the "else" behavior (using
an early return) and adds a test for the cases that caused problems in
the field.

Test: fast/dom/allowed-children.html

  • dom/Node.cpp: (WebCore::isChildTypeAllowed):
2:53 PM Changeset in webkit [70717] by kbr@google.com
  • 2 edits in trunk/WebKit/chromium

2010-10-27 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

[chromium] WebGL does not work with the compositor in test_shell
​https://bugs.webkit.org/show_bug.cgi?id=48470

  • src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::resolveMultisampledFramebuffer):
    • Properly restore the draw framebuffer after resolving.

(WebKit::WebGraphicsContext3DDefaultImpl::prepareTexture):

  • Make the context current before calling resolveMultisampledFramebuffer.
2:46 PM Changeset in webkit [70716] by Beth Dakin
  • 19 edits in trunk

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=48385 Add WebKit
SPI to scale a WebView
-and corresponding-
<rdar://problem/8107667>

Reviewed by Darin Adler.

WebCore:

This patch adds SPI to Mac WebKit that scales the page by the given
scale factor. The scale factor is factored into the RenderStyle's
transform.

Set the current pageScale for the document.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::styleForDocument):

Frame keeps track of the page scale factor. When
scalePage() is called, it modifies the RenderView's style to
include a transform of the appropriate scale and forces a style
recalc.

  • page/Frame.cpp:

(WebCore::Frame::Frame):
(WebCore::Frame::scalePage):

  • page/Frame.h:

(WebCore::Frame::pageScaleFactor):

  • WebCore.exp.in:

Add a scale to the transformation matrix.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::setPageScaleTransform):

  • rendering/style/RenderStyle.h:

WebKit/mac:

This patch adds SPI to Mac WebKit that scales the page by the given
scale factor.

  • WebView/WebView.mm:

(-[WebView _scaleWebView:]):
(-[WebView _viewScaleFactor]):

  • WebView/WebViewPrivate.h:

WebKit2:

This patch adds SPI to Mac WebKit that scales the page by the given
scale factor.

Implement scaleWebView(), which tells WebCore::Frame to scale, and
viewScaleFactor() which returns the current scale factor.

  • Shared/API/c/WKSharedAPICast.h:
  • UIProcess/API/C/WKPage.cpp:

(WKPageScaleWebView):
(WKPageGetViewScaleFactor):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::scaleWebView):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::viewScaleFactor):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::scaleWebView):
(WebKit::WebPage::viewScaleFactor):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
2:45 PM Changeset in webkit [70715] by Adam Roben
  • 1 edit
    3 adds in trunk/LayoutTests

Add Windows-specific results for test added in r70692

This test isn't rendering correctly. That's covered by
<​http://webkit.org/b/48459>.

  • platform/win/fast/blockflow/border-vertical-lr-expected.checksum: Added.
  • platform/win/fast/blockflow/border-vertical-lr-expected.png: Added.
  • platform/win/fast/blockflow/border-vertical-lr-expected.txt: Added.
2:38 PM Changeset in webkit [70714] by mitz@apple.com
  • 7 edits in trunk

REGRESSION (r70335): Incorrect article layout in Safari Reader
​https://bugs.webkit.org/show_bug.cgi?id=48436

Reviewed by Darin Adler.

WebCore:

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::getMatchedCSSRules): Return rules from all origins if the cross-origin
check is disabled.

  • page/Settings.cpp:

(WebCore::Settings::Settings): Initialize m_crossOriginCheckInGetMatchedCSSRulesDisabled.

  • page/Settings.h:

(WebCore::Settings::setCrossOriginCheckInGetMatchedCSSRulesDisabled): Added this accessor.
(WebCore::Settings::crossOriginCheckInGetMatchedCSSRulesDisabled): Ditto.

WebKit/mac:

  • Misc/WebKitVersionChecks.h: Added WEBKIT_FIRST_VERSION_WITH_GET_MATCHED_CSS_RULES_RESTRICTIONS.
  • WebView/WebView.mm:

(-[WebView _needsUnrestrictedGetMatchedCSSRules]): Added. Returns YES for Safari linked against
versions of WebKit that did not have the cross-origin restrictions in getMatchedCSSRules().
(-[WebView _preferencesChangedNotification:]): Call Settings::setCrossOriginCheckInGetMatchedCSSRulesDisabled()
based on the above.

2:38 PM Changeset in webkit [70713] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-10-27 Stuart Morgan <​stuartmorgan@chromium.org>

Reviewed by David Levin.

Include caps lock state when converting NSEvent modifiers to
WebInputEvent

​https://bugs.webkit.org/show_bug.cgi?id=47917

  • src/mac/WebInputEventFactory.mm: (WebKit::modifiersFromEvent):
2:35 PM Changeset in webkit [70712] by crogers@google.com
  • 2 edits in trunk/WebKit/chromium

2010-10-27 Chris Rogers <​crogers@google.com>

Reviewed by James Robinson.

Add ENABLE_WEB_AUDIO feature enable flag (initially disabled) for Chromium
​https://bugs.webkit.org/show_bug.cgi?id=48465

  • features.gypi:
2:33 PM Changeset in webkit [70711] by bweinstein@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix.

  • jit/JITStubs.cpp:

(JSC::jitThrow):

2:27 PM Changeset in webkit [70710] by Csaba Osztrogonác
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed. Add Qt specific expected results after r70657.

  • platform/qt/animations/missing-values-first-keyframe-expected.txt: Added.
  • platform/qt/animations/missing-values-last-keyframe-expected.txt: Added.
2:22 PM Changeset in webkit [70709] by Dimitri Glazkov
  • 2 edits
    6 adds in trunk/LayoutTests

2010-10-27 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Add expectations after r70692.

  • platform/chromium-linux/fast/borders/border-radius-inline-flow-expected.checksum: Added.
  • platform/chromium-linux/fast/borders/border-radius-inline-flow-expected.png: Added.
  • platform/chromium-mac/fast/borders/border-radius-inline-flow-expected.checksum: Added.
  • platform/chromium-win/fast/borders/border-radius-inline-flow-expected.checksum: Added.
  • platform/chromium-win/fast/borders/border-radius-inline-flow-expected.png: Added.
  • platform/chromium-win/fast/borders/border-radius-inline-flow-expected.txt: Added.
  • platform/chromium/test_expectations.txt: Tweaked.
2:21 PM Changeset in webkit [70708] by jer.noble@apple.com
  • 2 edits in trunk/WebKit/mac

2010-10-18 Jer Noble <​jer.noble@apple.com>

Reviewed by Eric Carlson.

Safari fullscreen media element tickles when it should not.


​https://bugs.webkit.org/show_bug.cgi?id=47861

  • WebView/WebVideoFullscreenController.mm: (-[WebVideoFullscreenController updatePowerAssertions]):
2:16 PM Changeset in webkit [70707] by Adam Roben
  • 1 edit
    3 deletes in trunk/LayoutTests

Remove som unnecessary Windows-specific results

These should have been removed back in r70630.

  • platform/win/fast/blockflow/english-lr-text-expected.checksum: Removed.
  • platform/win/fast/blockflow/english-lr-text-expected.png: Removed.
  • platform/win/fast/blockflow/english-lr-text-expected.txt: Removed.
2:10 PM UsingGitWithWebKit edited by Adam Roben
Clarified that you still need Cygwin's git even if you use msysgit … (diff)
2:09 PM Changeset in webkit [70706] by zmo@google.com
  • 4 edits in trunk/WebCore

2010-10-27 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

refactor the nested large switch statements in GraphicsContext3DCG.cpp:getImageData()
​https://bugs.webkit.org/show_bug.cgi?id=47027

  • platform/graphics/GraphicsContext3D.cpp: (WebCore::doPacking): ASSERT false if undefined format is passed in.
  • platform/graphics/GraphicsContext3D.h: Add kSourceFormatUndefined enum.
  • platform/graphics/cg/GraphicsContext3DCG.cpp: (WebCore::getSourceDataFormat): Decide source data format from componentsPerPixel, alpha format, bitsPerComponet, etc. (WebCore::GraphicsContext3D::getImageData): Refactor the code to use getSourceDataFormat and remove nested switches.
2:08 PM UsingGitWithWebKit edited by Adam Roben
Remove extraneous backticks (diff)
2:05 PM Changeset in webkit [70705] by Patrick Gansterer
  • 14 edits in trunk/WebCore

2010-10-27 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Use WTF::StringHasher::createBlobHash where possible
​https://bugs.webkit.org/show_bug.cgi?id=48228

Replace StringImpl::computeHash with StringHasher::createBlobHash.
This removes many duplicated code.

  • bindings/js/JSSVGPODTypeWrapper.h: (WebCore::PODTypeWrapperCacheInfoHash::hash):
  • page/SecurityOriginHash.h: (WebCore::SecurityOriginHash::hash):
  • platform/cf/SchedulePair.h: (WebCore::SchedulePairHash::hash):
  • platform/graphics/FontCache.cpp: (WebCore::computeHash):
  • platform/graphics/chromium/FontPlatformDataChromiumWin.h: (WebCore::FontPlatformData::RefCountedHFONT::hash):
  • platform/graphics/cocoa/FontPlatformData.h: (WebCore::FontPlatformData::hash):
  • platform/graphics/gtk/FontPlatformDataPango.h: (WebCore::FontPlatformData::hash):
  • platform/graphics/wince/FontPlatformData.cpp: (WebCore::FixedSizeFontDataKeyHash::hash):
  • platform/graphics/wx/FontPlatformDataWx.cpp: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::computeHash):
  • plugins/PluginPackage.cpp: (WebCore::PluginPackage::hash):
  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::hash):
  • svg/DeprecatedSVGAnimatedTemplate.h: (WebCore::DeprecatedSVGAnimatedTypeWrapperKeyHash::hash):
  • svg/properties/SVGAnimatedPropertyDescription.h: (WebCore::SVGAnimatedPropertyDescriptionHash::hash):
2:04 PM UsingGitWithWebKit edited by Adam Roben
Added instructions for maintaining good performance (diff)
2:00 PM UsingGitWithWebKit edited by Adam Roben
Make some instructions msysgit-compatible (diff)
1:58 PM UsingGitWithWebKit edited by Adam Roben
Add instructions for installing and setting up msysgit (diff)
1:48 PM Changeset in webkit [70704] by jianli@chromium.org
  • 2 edits
    2 copies in branches/chromium/552

Merge 70484 - Calling FileReader.abort during reading could cause crash
​https://bugs.webkit.org/show_bug.cgi?id=48163

BUG=60979

Reviewed by David Levin.

WebCore:

Test: fast/files/file-reader-abort.html

  • fileapi/FileReader.cpp:

(WebCore::delayedAbort):
(WebCore::FileReader::abort): Schedule to do the abort later to work
around the case that abort() could be called from event handler.
(WebCore::FileReader::doAbort):
(WebCore::FileReader::didFail): Do not go with normal error handling
when we are in the process of aborting.
(WebCore::FileReader::failed):
(WebCore::FileReader::readyState):

  • fileapi/FileReader.h:

LayoutTests:

  • fast/files/file-reader-abort-expected.txt: Added.
  • fast/files/file-reader-abort.html: Added.

TBR=​jianli@chromium.org

1:46 PM Changeset in webkit [70703] by barraclough@apple.com
  • 22 edits in trunk/JavaScriptCore

Bug 48365 - Remove output parameters from JITStackFrame

Reviewed by Oliver Hunt.

The JIT stub functions presently use the stackframe to provide a couple of additional return values.

  • In the case of uncaught exceptions the exception value is returned on the stackframe.exception property.
  • In the case of caught exceptions the updated value for the callFrame register is returned on the stackframe.callFrame property.

Change exception returns such that exceptions are always returned on JSGlobalData::exception.
Change op_catch such that the new CallFrame value is returned from op_throw / vm_throw in regT0.

(JSC::evaluateInGlobalCallFrame):

  • debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::evaluate):

  • interpreter/CachedCall.h:

(JSC::CachedCall::CachedCall):
(JSC::CachedCall::call):

  • interpreter/CallFrame.h:

(JSC::ExecState::exception):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::callEval):
(JSC::Interpreter::Interpreter):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):
(JSC::Interpreter::privateExecute):

  • interpreter/Interpreter.h:
  • jit/JITCode.h:

(JSC::JITCode::execute):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_catch):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_catch):

  • jit/JITStubs.cpp:

(JSC::ctiTrampoline):
(JSC::jitThrow):
(JSC::DEFINE_STUB_FUNCTION):

  • jit/JITStubs.h:
  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):
(JSC::arrayProtoFuncEvery):
(JSC::arrayProtoFuncForEach):
(JSC::arrayProtoFuncSome):
(JSC::arrayProtoFuncReduce):
(JSC::arrayProtoFuncReduceRight):

  • runtime/CallData.cpp:

(JSC::call):

  • runtime/Completion.cpp:

(JSC::evaluate):

  • runtime/ConstructData.cpp:

(JSC::construct):

  • runtime/ExceptionHelpers.cpp:

(JSC::createErrorForInvalidGlobalAssignment):
(JSC::throwOutOfMemoryError):
(JSC::throwStackOverflowError):

  • runtime/ExceptionHelpers.h:
  • runtime/JSArray.cpp:

(JSC::JSArray::sort):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncEval):

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncReplace):

1:38 PM Changeset in webkit [70702] by jberlin@webkit.org
  • 3 edits in trunk/WebKit2

Fix the WebKit2 API tests.
​https://bugs.webkit.org/show_bug.cgi?id=48461

Reviewed by Sam Weinig.

The API tests were failing because the tests expect to be able to send messages before the
WebProcess finishes launching.

Instead of dispatching the pending messages in processDidFinishLaunching, dispatch them in
ensureWebProcess but do not make messages pending if the process is launching.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::processDidFinishLaunching):
Move dispatching the pending messages back from here ...
(WebKit::WebContext::ensureWebProcess):
... to here.
(WebKit::WebContext::postMessageToInjectedBundle):
Check whether the process can send messages in order to determine if a message needs to be
sent later.

  • UIProcess/WebProcessProxy.h:

(WebKit::WebProcessProxy::canSendMessage):
The WebProcessProxy can send a message if it is valid or if it is launching.

1:34 PM Changeset in webkit [70701] by tony@chromium.org
  • 2 edits in trunk/WebCore

2010-10-27 Tony Chang <​tony@chromium.org>

Unreviewed, build fix after r70692.

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBorder):
1:32 PM Changeset in webkit [70700] by Simon Fraser
  • 1 edit
    2 deletes in trunk/LayoutTests

2010-10-27 Simon Fraser <Simon Fraser>

Remove Leopard-specific results that are no longer required.

  • platform/mac-leopard/fast/text/international/vertical-text-glyph-test-expected.txt: Removed.
  • platform/mac-leopard/fast/text/international/vertical-text-metrics-test-expected.txt: Removed.
1:32 PM Changeset in webkit [70699] by loki@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-10-27 Gabor Loki <​loki@webkit.org>

Reviewed by Oliver Hunt.

​https://bugs.webkit.org/show_bug.cgi?id=48060
Speed up op_jeq_null and op_jneq_null.

For both opcodes the NullTag and UndefinedTag are checked to control the
jump. These values can be simply checked by AboveOrEqual or Below
condition if they are the two highest unsigned integers from JSValue's
Tag field.

  • jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_jeq_null): (JSC::JIT::emit_op_jneq_null):
  • runtime/JSValue.h:
1:16 PM Changeset in webkit [70698] by Adam Roben
  • 1 edit
    6 adds in trunk/LayoutTests

Add Windows-specific results for tests added in r70664

These tests aren't rendering correctly. That's covered by
<​http://webkit.org/b/48459>.

  • platform/win/fast/blockflow/japanese-lr-text-expected.checksum: Added.
  • platform/win/fast/blockflow/japanese-lr-text-expected.png: Added.
  • platform/win/fast/blockflow/japanese-lr-text-expected.txt: Added.
  • platform/win/fast/blockflow/japanese-rl-text-expected.checksum: Added.
  • platform/win/fast/blockflow/japanese-rl-text-expected.png: Added.
  • platform/win/fast/blockflow/japanese-rl-text-expected.txt: Added.
1:15 PM Changeset in webkit [70697] by leandro@webkit.org
  • 2 edits in trunk/WebCore

2010-10-27 Leandro Pereira <​leandro@profusion.mobi>

Unreviewed. Build fix after r70651.

  • CMakeListsEfl.txt: Add SoupURIUtils.cpp.
1:10 PM Changeset in webkit [70696] by andersca@apple.com
  • 3 edits in trunk/WebKit2

WebPageProxy::isValid should return false if the page has been explicitly closed
​https://bugs.webkit.org/show_bug.cgi?id=48458

Reviewed by Sam Weinig.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::isValid):
(WebKit::WebPageProxy::relaunch):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::processDidCrash):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::isClosed):

12:58 PM CSS21Results edited by aestes@apple.com
(diff)
12:53 PM Changeset in webkit [70695] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-27 Crystal Zhang <​haizhang@rim.com>

Reviewed by Eric Carlson.

​https://bugs.webkit.org/show_bug.cgi?id=48446

Fix an issue where we were passing the wrong parameter
to MIMETypeRegistry::getMIMETypeForExtension().

  • platform/MIMETypeRegistry.cpp:
12:52 PM Changeset in webkit [70694] by inferno@chromium.org
  • 2 edits
    2 copies in branches/chromium/552

Merge 70681

BUG=60695

12:49 PM Changeset in webkit [70693] by inferno@chromium.org
  • 2 edits
    2 copies in branches/chromium/517

Merge 70681

BUG=60695
Review URL: ​http://codereview.chromium.org/4091006

12:48 PM Changeset in webkit [70692] by hyatt@apple.com
  • 4 edits
    8 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=48449

Reviewed by Beth Dakin.

Make border drawing work correctly with vertical inline flows. The top and bottom edge have to be omitted
rather than the left and right edges.

Also discovered that border-radius is broken with the new path-based-drawing code for all inline flows. This
is a regression from the old drawing code. I patched the code to be correct rather than clipping out stuff
that it shouldn't and applying border-radii on lines that don't even have them.

Added fast/blockflow/border-vertical-lr.html and fast/borders/border-radius-inline-flow.html

WebCore:

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintBorder):
(WebCore::RenderBoxModelObject::clipBorderSidePolygon):

  • rendering/RenderBoxModelObject.h:

LayoutTests:

  • fast/blockflow/border-vertical-lr.html: Added.
  • fast/borders/border-radius-inline-flow.html: Added.
  • platform/mac/fast/blockflow/border-vertical-lr-expected.checksum: Added.
  • platform/mac/fast/blockflow/border-vertical-lr-expected.png: Added.
  • platform/mac/fast/blockflow/border-vertical-lr-expected.txt: Added.
  • platform/mac/fast/borders/border-radius-inline-flow-expected.checksum: Added.
  • platform/mac/fast/borders/border-radius-inline-flow-expected.png: Added.
  • platform/mac/fast/borders/border-radius-inline-flow-expected.txt: Added.
12:43 PM Changeset in webkit [70691] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip some failing tests on Windows

The tests don't fail in a reliable way, so skipping them is our best
option for now.

  • platform/win/Skipped:
12:39 PM Changeset in webkit [70690] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/WebKit/qt

2010-10-27 Jocelyn Turcotte <​jocelyn.turcotte@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix tst_QWebFrame::popupFocus().
​https://bugs.webkit.org/show_bug.cgi?id=48432

  • Call setFocus() before show() to work around a but in Qt.
  • Remove the check on combo at the end since hidePopup() leads indirectly to its destruction and segfault.
  • tests/qwebframe/tst_qwebframe.cpp:
12:35 PM Changeset in webkit [70689] by Martin Robinson
  • 1 edit
    2 adds in trunk/LayoutTests

2010-10-27 Martin Robinson <​mrobinson@igalia.com>

Add GTK+-specific baselines for a couple tests.

  • platform/gtk/animations/missing-values-first-keyframe-expected.txt: Added.
  • platform/gtk/animations/missing-values-last-keyframe-expected.txt: Added.
12:31 PM Changeset in webkit [70688] by Martin Robinson
  • 4 edits
    5 adds in trunk

2010-10-27 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[Cairo] Font fallback determination is very ineffecient
​https://bugs.webkit.org/show_bug.cgi?id=42052

Added a test which verifies the correct result rendering with a custom
font that is missing many glyphs.

  • platform/gtk/fonts/custom-font-missing-glyphs-expected.checksum: Added.
  • platform/gtk/fonts/custom-font-missing-glyphs-expected.png: Added.
  • platform/gtk/fonts/custom-font-missing-glyphs-expected.txt: Added.
  • platform/gtk/fonts/custom-font-missing-glyphs.html: Added.
  • platform/gtk/fonts/resources/mostly-empty-font.ttf: Added. A font that I created in fotnforge which is composed of empty glyphs, except for 'A' which has a lonely polyhedron for a glyph.

2010-10-27 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[Cairo] Font fallback determination is very ineffecient
​https://bugs.webkit.org/show_bug.cgi?id=42052

When choosing a fallback font in FontCache::getFontDataForCharacters, use FontConfig's
mechanism for searching the fallback list directly, instead of scanning the list manually.
If the font is a custom font or any other font with no FontConfig pattern associated with
it, as FontConfig for a font that can supply the missing glyphs.

Test: platform/gtk/fonts/custom-font-missing-glyphs.html

  • platform/graphics/cairo/FontCacheFreeType.cpp: (WebCore::createFontConfigPatternForCharacters): Added this helper which turns a collection of unicode characters into a FontConfig pattern. (WebCore::findBestFontGivenFallbacks): Using a FontConfig pattern created with th above helper and a FcFontSet of fallback fonts, this helper will find a font in the set which fulfills the requirments. (WebCore::FontCache::getFontDataForCharacters): Given an existing font with missing glyphs, either find an appropriate fallback font from the list of FontConfig fallbacks or ask FontConfig directly for an appropriate font.
  • platform/graphics/cairo/FontPlatformDataFreeType.h: Made a member mutable, as it is initialized lazily.
12:21 PM Changeset in webkit [70687] by andersca@apple.com
  • 9 edits
    4 copies
    4 adds in trunk/WebKit2

Begin stubbing out the Download class
​https://bugs.webkit.org/show_bug.cgi?id=48447

Reviewed by Adam Roben.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

  • WebKit2Prefix.h:

Include WebCore/EmptyProtocolDefinitions.h

  • WebProcess/Downloads/Download.cpp: Added.
  • WebProcess/Downloads/Download.h: Added.
  • WebProcess/Downloads/DownloadManager.cpp:

(WebKit::DownloadManager::startDownload):
Create a Download object and start it.

  • WebProcess/Downloads/mac/DownloadMac.mm: Added.

(WebKit::Download::start):
Create an NSURLDownload.

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::startDownload):
Ask the download manager to start downloading.

  • win/WebKit2.vcproj:
  • win/WebKit2Common.vsprops:

Add new files.

12:09 PM Changeset in webkit [70686] by commit-queue@webkit.org
  • 9 edits in trunk/LayoutTests

2010-10-27 Renata Hodovan <​reni@inf.u-szeged.hu>

Reviewed by Dirk Schulze.

preserveAlpha attributes were misspeled in SVGFEConcolveMatrixElement tests.
​https://bugs.webkit.org/show_bug.cgi?id=48403

Since expecteds and pixel tests didn't change after correcting this attribute has no effect so it is removed.
For checking preserveAlpha attribute we have already a dom test which is not affected by this patch.

  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-bias-attr.js:
  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-divisor-attr.js:
  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-in-attr.js:
  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr.js:
  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr.js:
  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-order-attr.js:
  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-targetX-attr.js:
  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-targetY-attr.js:
12:05 PM Changeset in webkit [70685] by Adam Roben
  • 3 edits in trunk/WebKit2

Don't allow setting NetscapePlugin::m_isWindowed after NPP_New has completed

In Firefox, Chrome, and WebKit1 trying to set this value after NPP_New
does not actually affect whether the plugin is windowed.

Fixes <​http://webkit.org/b/46673> <rdar://problem/8484211> Assertion
failure in NetscapePlugin::platformDestroy when running
plugins/mouse-events.html in WebKit2 on Windows

Reviewed by Anders Carlsson.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::setIsWindowed): Moved here from the header.
Bail out if m_isStarted is true, indicating that NPP_New has already
finished.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h: Removed the

implementation of setIsWindowed.

12:02 PM Changeset in webkit [70684] by Dimitri Glazkov
  • 2 edits
    8 adds in trunk/LayoutTests

2010-10-27 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Update expectations after r70664.

  • platform/chromium-mac/fast/blockflow/japanese-lr-text-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/japanese-rl-text-expected.checksum: Added.
  • platform/chromium-win/fast/blockflow/japanese-lr-text-expected.checksum: Added.
  • platform/chromium-win/fast/blockflow/japanese-lr-text-expected.png: Added.
  • platform/chromium-win/fast/blockflow/japanese-lr-text-expected.txt: Added.
  • platform/chromium-win/fast/blockflow/japanese-rl-text-expected.checksum: Added.
  • platform/chromium-win/fast/blockflow/japanese-rl-text-expected.png: Added.
  • platform/chromium-win/fast/blockflow/japanese-rl-text-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
11:58 AM Changeset in webkit [70683] by Dimitri Glazkov
  • 3 edits in trunk/WebKitTools

2010-10-27 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, rolling out r70674.
​http://trac.webkit.org/changeset/70674
​https://bugs.webkit.org/show_bug.cgi?id=48053

Broke Chromium Windows build.

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
11:53 AM Changeset in webkit [70682] by apavlov@chromium.org
  • 8 edits in trunk

2010-10-27 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: "Reload Page and Audit on Load" fails to run audits when resource tracking is disabled
​https://bugs.webkit.org/show_bug.cgi?id=48431

  • http/tests/inspector/inspector-test2.js: (initialize_InspectorTest.InspectorTest.enableResourceTracking): (initialize_InspectorTest.InspectorTest.disableResourceTracking):
  • http/tests/inspector/resource-parameters.html:
  • inspector/audits-panel-functional.html:
  • inspector/styles-source-offsets.html:

2010-10-27 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: "Reload Page and Audit on Load" fails to run audits when resource tracking is disabled
​https://bugs.webkit.org/show_bug.cgi?id=48431

  • inspector/front-end/AuditsPanel.js: (WebInspector.AuditsPanel.prototype._reloadResources):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._createPanelEnabler): (WebInspector.ResourcesPanel.prototype._enableResourceTracking):
11:46 AM Changeset in webkit [70681] by inferno@chromium.org
  • 4 edits
    2 adds in trunk

2010-10-27 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dave Hyatt.

Add a function to make sure child is allowed before adding to a
render view.
​https://bugs.webkit.org/show_bug.cgi?id=48328

Test: fast/inline/inline-child-height-width-calc-crash.html

  • rendering/RenderView.cpp: (WebCore::RenderView::isChildAllowed):
  • rendering/RenderView.h:

2010-10-27 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dave Hyatt.

Tests that adding a br element to a new document does not result in crash.
​https://bugs.webkit.org/show_bug.cgi?id=48328

  • fast/inline/inline-child-height-width-calc-crash-expected.txt: Added.
  • fast/inline/inline-child-height-width-calc-crash.html: Added.
11:45 AM Changeset in webkit [70680] by timothy@apple.com
  • 8 edits in trunk/WebKit2

Add API for enabling the developer extras (Web Inspector).

​http://webkit.org/b/48439

Reviewed by John Sullivan.

  • Shared/WebPreferencesStore.cpp:

(WebKit::WebPreferencesStore::WebPreferencesStore):
(WebKit::WebPreferencesStore::encode):
(WebKit::WebPreferencesStore::decode):

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetDeveloperExtrasEnabled):
(WKPreferencesGetDeveloperExtrasEnabled):

  • UIProcess/API/C/WKPreferences.h:
  • UIProcess/WebPreferences.cpp:

(WebKit::WebPreferences::setDeveloperExtrasEnabled):
(WebKit::WebPreferences::developerExtrasEnabled):

  • UIProcess/WebPreferences.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

11:42 AM Changeset in webkit [70679] by tony@chromium.org
  • 6 edits in trunk

2010-10-25 Tony Chang <​tony@chromium.org>

Reviewed by Anders Carlsson.

compile TestNetscapePlugIn on chromium linux
​https://bugs.webkit.org/show_bug.cgi?id=48274

  • WebKit.gyp: Enable compilation of TestNetscapePlugIn on Linux.

2010-10-25 Tony Chang <​tony@chromium.org>

Reviewed by Anders Carlsson.

compile TestNetscapePlugIn on chromium linux
​https://bugs.webkit.org/show_bug.cgi?id=48274

  • DumpRenderTree/TestNetscapePlugIn/main.cpp: (NP_Initialize): On Linux, plugin funcs are set in initialize. (NPP_New): Mark the plugin as windowless. (NPP_GetValue): Handle mime type values. (NP_GetMIMEDescription): (NP_GetValue):
  • DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: define TRUE and FALSE, which are in webkit's npapi.h.
  • DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Pull in npapi.h to get TRUE/FALSE (matches webkit's npfunctions.h)
11:36 AM Changeset in webkit [70678] by Dimitri Glazkov
  • 2 edits
    16 adds in trunk/LayoutTests

2010-10-27 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Update expectations after r70664 and r70657.

  • platform/chromium-linux/fast/blockflow/japanese-lr-text-expected.checksum: Added.
  • platform/chromium-linux/fast/blockflow/japanese-lr-text-expected.png: Added.
  • platform/chromium-linux/fast/blockflow/japanese-lr-text-expected.txt: Added.
  • platform/chromium-linux/fast/blockflow/japanese-rl-text-expected.checksum: Added.
  • platform/chromium-linux/fast/blockflow/japanese-rl-text-expected.png: Added.
  • platform/chromium-linux/fast/blockflow/japanese-rl-text-expected.txt: Added.
  • platform/chromium-mac/animations/missing-values-first-keyframe-expected.checksum: Added.
  • platform/chromium-mac/animations/missing-values-first-keyframe-expected.png: Added.
  • platform/chromium-mac/animations/missing-values-last-keyframe-expected.checksum: Added.
  • platform/chromium-mac/animations/missing-values-last-keyframe-expected.png: Added.
  • platform/chromium-win/animations/missing-values-first-keyframe-expected.checksum: Added.
  • platform/chromium-win/animations/missing-values-first-keyframe-expected.png: Added.
  • platform/chromium-win/animations/missing-values-first-keyframe-expected.txt: Added.
  • platform/chromium-win/animations/missing-values-last-keyframe-expected.checksum: Added.
  • platform/chromium-win/animations/missing-values-last-keyframe-expected.png: Added.
  • platform/chromium-win/animations/missing-values-last-keyframe-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
11:36 AM Changeset in webkit [70677] by Martin Robinson
  • 4 edits in trunk/WebCore

2010-10-27 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] r69296 includes a cast from GdkWindow* to GtkWindow*
​https://bugs.webkit.org/show_bug.cgi?id=48445

Pass the pageClient GtkWidget* to gtk_xtbin_new instead of the
GdkWindow*. The pageClient is used to get the proper visual for the
plugin container widget.

No new tests. This patch should prevent plugins/null-npp-getvalue-pointer.html
from crashing.

  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::platformStart): Pass the widget instead of the window.
  • plugins/gtk/gtk2xtbin.c: Accept the widget instead of the window. (gtk_xtbin_new):
  • plugins/gtk/gtk2xtbin.h: Update the declaration.
11:19 AM Changeset in webkit [70676] by kenneth@webkit.org
  • 14 edits in trunk

2010-10-27 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Anders Carlsson.

Move contentsSizeChange from the UIClient into the PageClient and
and make it a private Qt-only API in the process.

Make WKPageContentsSizeChangedCallback be a private API
​https://bugs.webkit.org/show_bug.cgi?id=48409

  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::didChangeContentsSize): (QWKPage::QWKPage):
  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didChangeContentsSize):
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebUIClient.cpp:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::contentsSizeChanged):

2010-10-27 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Anders Carlsson.

Remove contentSizeChanged callbacks as it is no longer
part of the public UIClient.

Make WKPageContentsSizeChangedCallback be a private API
​https://bugs.webkit.org/show_bug.cgi?id=48409

  • MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController awakeFromNib]):
  • MiniBrowser/win/BrowserView.cpp: (BrowserView::create):
  • WebKitTestRunner/TestController.cpp: (WTR::createOtherPage): (WTR::TestController::initialize):
11:05 AM Changeset in webkit [70675] by commit-queue@webkit.org
  • 4 edits in trunk/WebCore

2010-10-27 Kwang Yul Seo <​skyul@company100.net>

Reviewed by James Robinson.

[BREWMP] Port graphics backend
​https://bugs.webkit.org/show_bug.cgi?id=40275

Add PLATFORM(BREWMP) guard to skia's FontCustomPlatformData
to share OS(LINUX) implementation.

  • loader/CachedFont.cpp:
  • platform/graphics/skia/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::~FontCustomPlatformData): (WebCore::FontCustomPlatformData::fontPlatformData): (WebCore::createFontCustomPlatformData):
  • platform/graphics/skia/FontCustomPlatformData.h:
11:02 AM Changeset in webkit [70674] by Csaba Osztrogonác
  • 3 edits in trunk/WebKitTools

Make http locking default in NRWT.
​https://bugs.webkit.org/show_bug.cgi?id=48053

Patch by Gabor Rapcsanyi <​rgabor@inf.u-szeged.hu> on 2010-10-27
Reviewed by Ojan Vafai.

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
10:59 AM Changeset in webkit [70673] by ggaren@apple.com
  • 5 edits
    3 adds in trunk

JavaScriptCore: ​https://bugs.webkit.org/show_bug.cgi?id=41948
REGRESSION(r60392): Registerfile can be unwound too far following an exception

Reviewed by Oliver Hunt.

SunSpider reports no change.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::throwException): Walk the stack to calculate the high
water mark currently in use. It's not safe to assume that the current
CallFrame's high water mark is the highest high water mark because
calls do not always set up at the end of a CallFrame. A large caller
CallFrame can encompass a small callee CallFrame.

  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTINativeCall):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTINativeCall): Make sure to set a 0 CodeBlock
in the CallFrame of a host call, like the Interpreter does, instead of
leaving the CodeBlock field uninitialized. The backtracing code requires
a valid CodeBlock field in each CallFrame.

LayoutTests: Added a test for:

Reviewed by Oliver Hunt.

​https://bugs.webkit.org/show_bug.cgi?id=41948
REGRESSION(r60392): Registerfile can be unwound too far following an exception

  • fast/js/exception-registerfile-shrink-expected.txt: Added.
  • fast/js/exception-registerfile-shrink.html: Added.
  • fast/js/script-tests/exception-registerfile-shrink.js: Added.
10:51 AM Changeset in webkit [70672] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-10-27 Gabor Rapcsanyi <​rgabor@inf.u-szeged.hu>

Reviewed by Tony Chang.

[NRWT] Fix http lock on Windows platform
​https://bugs.webkit.org/show_bug.cgi?id=48321

  • Scripts/webkitpy/layout_tests/port/http_lock.py:
10:50 AM Changeset in webkit [70671] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2010-10-27 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed; grouped editing test failures in one place.

  • platform/chromium/test_expectations.txt:
10:48 AM Changeset in webkit [70670] by Csaba Osztrogonác
  • 6 edits in trunk/LayoutTests

Unreviewed. Update Qt specific expected files after r70546.

  • platform/qt/fast/blockflow/floats-in-block-layout-expected.txt:
  • platform/qt/fast/blockflow/self-collapsing-block-expected.txt:
  • platform/qt/fast/multicol/nested-columns-expected.checksum:
  • platform/qt/fast/multicol/nested-columns-expected.png:
  • platform/qt/fast/multicol/nested-columns-expected.txt:
10:46 AM Changeset in webkit [70669] by satish@chromium.org
  • 30 edits
    2 deletes in trunk

2010-10-27 Satish Sampath <​satish@chromium.org>

Unreviewed, rolling out r70665.
​http://trac.webkit.org/changeset/70665
​https://bugs.webkit.org/show_bug.cgi?id=47089

Need to address Alexey's review comments.

  • fast/speech/input-text-language-tag-expected.txt: Removed.
  • fast/speech/input-text-language-tag.html: Removed.
  • fast/speech/input-text-speechbutton.html:
  • fast/speech/speech-button-ignore-generated-events.html:
  • platform/chromium/test_expectations.txt:

2010-10-27 Satish Sampath <​satish@chromium.org>

Unreviewed, rolling out r70665.
​http://trac.webkit.org/changeset/70665
​https://bugs.webkit.org/show_bug.cgi?id=47089

Need to address Alexey's review comments.

  • page/SpeechInput.cpp: (WebCore::SpeechInput::startRecognition):
  • page/SpeechInput.h:
  • page/SpeechInputClient.h:
  • platform/mock/SpeechInputClientMock.cpp: (WebCore::SpeechInputClientMock::startRecognition): (WebCore::SpeechInputClientMock::setRecognitionResult): (WebCore::SpeechInputClientMock::timerFired):
  • platform/mock/SpeechInputClientMock.h:
  • rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerElement::attachInnerElement): (WebCore::SearchFieldCancelButtonElement::detach): (WebCore::SpinButtonElement::defaultEventHandler): (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): (WebCore::InputFieldSpeechButtonElement::detach):

2010-10-27 Satish Sampath <​satish@chromium.org>

Unreviewed, rolling out r70665.
​http://trac.webkit.org/changeset/70665
​https://bugs.webkit.org/show_bug.cgi?id=47089

Need to address Alexey's review comments.

  • public/WebSpeechInputController.h: (WebKit::WebSpeechInputController::startRecognition):
  • public/WebSpeechInputControllerMock.h:
  • src/SpeechInputClientImpl.cpp: (WebKit::SpeechInputClientImpl::startRecognition):
  • src/SpeechInputClientImpl.h:
  • src/WebSpeechInputControllerMockImpl.cpp: (WebKit::WebSpeechInputControllerMockImpl::setMockRecognitionResult): (WebKit::WebSpeechInputControllerMockImpl::startRecognition):
  • src/WebSpeechInputControllerMockImpl.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl):
  • src/WebViewImpl.h:

2010-10-27 Satish Sampath <​satish@chromium.org>

Unreviewed, rolling out r70665.
​http://trac.webkit.org/changeset/70665
​https://bugs.webkit.org/show_bug.cgi?id=47089

Need to address Alexey's review comments.

  • DumpRenderTree/LayoutTestController.cpp: (setMockSpeechInputResultCallback):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setMockSpeechInputResult):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setMockSpeechInputResult):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setMockSpeechInputResult):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setMockSpeechInputResult):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setMockSpeechInputResult):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setMockSpeechInputResult):
10:26 AM Changeset in webkit [70668] by hyatt@apple.com
  • 8 edits in trunk/LayoutTests

Change the results to account for a typo in the Japanese text string.

10:25 AM Changeset in webkit [70667] by Dimitri Glazkov
  • 61 edits in trunk/LayoutTests

2010-10-27 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Update expectations after r70654.
​https://bugs.webkit.org/show_bug.cgi?id=48347

  • platform/chromium-*/svg/dynamic-updates/*: Updated.
10:24 AM Changeset in webkit [70666] by zmo@google.com
  • 4 edits in trunk

2010-10-27 ZHenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

Must enable GL_POINT_SPRITE in GraphicsContext3D implementations
​https://bugs.webkit.org/show_bug.cgi?id=45908

  • src/WebGraphicsContext3DDefaultImpl.cpp: Enable for chromium --in-process-webgl port. (WebKit::WebGraphicsContext3DDefaultImpl::initialize):

2010-10-27 ZHenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

Must enable GL_POINT_SPRITE in GraphicsContext3D implementations
​https://bugs.webkit.org/show_bug.cgi?id=45908

  • platform/graphics/mac/GraphicsContext3DMac.mm: Enable for Mac port. (WebCore::GraphicsContext3D::GraphicsContext3D):
10:19 AM Changeset in webkit [70665] by satish@chromium.org
  • 30 edits
    2 adds in trunk

2010-10-27 Leandro Gracia Gil <​leandrogracia@google.com>

Reviewed by Jeremy Orlow.

Added a layout test for the language tag in speech input. Updated
the speech button tests to include the new language parameter in the
mock result.
​https://bugs.webkit.org/show_bug.cgi?id=47089

  • fast/speech/input-text-language-tag-expected.txt: Added.
  • fast/speech/input-text-language-tag.html: Added.
  • fast/speech/input-text-speechbutton.html:
  • fast/speech/speech-button-ignore-generated-events.html:
  • platform/chromium/test_expectations.txt:

2010-10-27 Leandro Gracia Gil <​leandrogracia@google.com>

Reviewed by Jeremy Orlow.

Patch the current speech input implementation to use the nearest
language tag. The language is now passed to the startRecognition
methods so that language-specific recognition could be used. Also added
a second parameter to setMockSpeechInputResult for the language used in
speech recognition.
​https://bugs.webkit.org/show_bug.cgi?id=47089

This is the 2nd of a 4-sided patch in Chromium and WebKit. For more
details see ​http://codereview.chromium.org/3615005/show and
​http://codereview.chromium.org/3595018/show. The last of the 4 patches
depends also on the language tag validation provided by this patch:
​https://bugs.webkit.org/show_bug.cgi?id=48225.

Test: fast/speech/input-text-language-tag.html

  • page/SpeechInput.cpp: (WebCore::SpeechInput::startRecognition):
  • page/SpeechInput.h:
  • page/SpeechInputClient.h:
  • platform/mock/SpeechInputClientMock.cpp: (WebCore::SpeechInputClientMock::startRecognition): (WebCore::SpeechInputClientMock::setRecognitionResult): (WebCore::SpeechInputClientMock::timerFired):
  • platform/mock/SpeechInputClientMock.h:
  • rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerElement::attachInnerElement): (WebCore::SearchFieldCancelButtonElement::detach): (WebCore::SpinButtonElement::defaultEventHandler): (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): (WebCore::InputFieldSpeechButtonElement::detach):

2010-10-27 Leandro Gracia Gil <​leandrogracia@google.com>

Reviewed by Jeremy Orlow.

Patch the current speech input implementation to use the nearest
language tag. The language is now passed to the startRecognition
methods so that language-specific recognition could be used. Also added
a second parameter to setMockSpeechInputResult for the language used in
speech recognition.
​https://bugs.webkit.org/show_bug.cgi?id=47089

This is the 2nd of a 4-sided patch in Chromium and WebKit. For more
details see ​http://codereview.chromium.org/3615005/show and
​http://codereview.chromium.org/3595018/show. The last of the 4 patches
depends also on the language tag validation provided by this patch:
​https://bugs.webkit.org/show_bug.cgi?id=48225.

  • public/WebSpeechInputController.h: (WebKit::WebSpeechInputController::startRecognition):
  • public/WebSpeechInputControllerMock.h:
  • src/SpeechInputClientImpl.cpp: (WebKit::SpeechInputClientImpl::create): (WebKit::SpeechInputClientImpl::startRecognition):
  • src/SpeechInputClientImpl.h:
  • src/WebSpeechInputControllerMockImpl.cpp: (WebKit::WebSpeechInputControllerMockImpl::setMockRecognitionResult): (WebKit::WebSpeechInputControllerMockImpl::startRecognition):
  • src/WebSpeechInputControllerMockImpl.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl):
  • src/WebViewImpl.h:

2010-10-27 Leandro Gracia Gil <​leandrogracia@google.com>

Reviewed by Jeremy Orlow.

Added a second parameter to setMockSpeechInputResult for
the language used in speech input.
​https://bugs.webkit.org/show_bug.cgi?id=47089

  • DumpRenderTree/LayoutTestController.cpp: (setMockSpeechInputResultCallback):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setMockSpeechInputResult):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setMockSpeechInputResult):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setMockSpeechInputResult):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setMockSpeechInputResult):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setMockSpeechInputResult):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setMockSpeechInputResult): (LayoutTestController::pageSizeAndMarginsInPixels):
10:16 AM Changeset in webkit [70664] by hyatt@apple.com
  • 6 edits
    8 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=48381

Reviewed by Dan Bernstein.

Make basic layer positioning work with vertical-lr writing-mode.

WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintChildren):
(WebCore::RenderBlock::paintFloats):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::adjustForFlippedBlocksWritingMode):
(WebCore::RenderBox::locationOffsetIncludingFlipping):

  • rendering/RenderBox.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPosition):

LayoutTests:

  • fast/blockflow/japanese-lr-text.html: Added.
  • fast/blockflow/japanese-rl-text.html: Added.
10:14 AM Changeset in webkit [70663] by zmo@google.com
  • 2 edits in trunk/WebCore

2010-10-27 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

object-deletion-behaviour.html fails with mesa backend
​https://bugs.webkit.org/show_bug.cgi?id=46667

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): If object_type is 0, we return early because object_name should be always be 0.
10:13 AM Changeset in webkit [70662] by Adam Roben
  • 6 edits in trunk/WebKitTools

Reset TestNetscapePlugIn's NPP_GetValue pointer when NullNPPGetValuePointer finishes running

Fixes <​http://webkit.org/b/48435> REGRESSION (r70655): Many plugins
tests are failing on Qt

Reviewed by Anders Carlsson.

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:

(PluginTest::NPP_Destroy):

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.h:

Added a do-nothing NPP_Destroy implementation.

  • DumpRenderTree/TestNetscapePlugIn/Tests/NullNPPGetValuePointer.cpp:

(NullNPPGetValuePointer::NullNPPGetValuePointer): Save the original
NPP_GetValue pointer in m_originalNPPGetValuePointer so we can restore
it later.
(NullNPPGetValuePointer::NPP_Destroy): Added. Restores the original
NPP_GetValue pointer so it can be used in other tests.

  • DumpRenderTree/TestNetscapePlugIn/main.cpp:

(NPP_Destroy):

  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:

(webkit_test_plugin_destroy_instance):
Call through to the PluginTest when NPP_Destroy is called.

10:10 AM Changeset in webkit [70661] by zmo@google.com
  • 3 edits in trunk/WebCore

2010-10-27 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

If WebGL is running on top of a strict version of OpenGL ES it should make sure attribs have buffers assigned at all times
​https://bugs.webkit.org/show_bug.cgi?id=47964

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::validateRenderingState): Minimum checking: if input <= 0, only check if each enabled vertex attribute is bound to a buffer. (WebCore::WebGLRenderingContext::drawArrays): If underlying GL performs bounds checking, we still need to do the minimum checking using validateRenderingState. (WebCore::WebGLRenderingContext::drawElements): Ditto.
  • html/canvas/WebGLRenderingContext.h: Add a comment for input <= 0 in validateRenderingState.
10:04 AM Changeset in webkit [70660] by Dimitri Glazkov
  • 2 edits
    5 adds in trunk/LayoutTests

2010-10-27 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Update results after r70569.

  • platform/chromium-linux/fast/blockflow/english-lr-text-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/english-lr-text-expected.checksum: Added.
  • platform/chromium-win/fast/blockflow/english-lr-text-expected.checksum: Added.
  • platform/chromium-win/fast/blockflow/english-lr-text-expected.png: Added.
  • platform/chromium-win/fast/blockflow/english-lr-text-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
10:00 AM Changeset in webkit [70659] by andersca@apple.com
  • 5 edits
    3 adds in trunk/WebKit2

Add DownloadManager class
​https://bugs.webkit.org/show_bug.cgi?id=48388

Reviewed by Sam Weinig.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

  • WebProcess/Downloads/DownloadManager.cpp: Added.

(WebKit::DownloadManager::shared):
(WebKit::DownloadManager::DownloadManager):

  • WebProcess/Downloads/DownloadManager.h: Added.
  • win/WebKit2.vcproj:
  • win/WebKit2Common.vsprops:

Add new files.

9:56 AM Changeset in webkit [70658] by bweinstein@apple.com
  • 5 edits
    1 add in trunk

WebKit2 shouldn't try to send an empty user agent
​https://bugs.webkit.org/show_bug.cgi?id=48397

Reviewed by Adam Roben.

WebKit2:

Change the check of the custom user agent to an empty check instead of a null check. When the client application
sets a custom user agent and then resets it, the custom user agent is set to an empty string. If all we do
is check for a null string, then we will think we have a custom user agent (which is empty) and send an empty
user agent.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::userAgent):

WebKitTools:

Add a test that when we set our custom user agent to an empty string, we don't send
an empty user agent.

  • TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp: Added.

(TestWebKitAPI::didRunJavaScript): Make sure that the result of navigator.userAgent isn't empty.
(TestWebKitAPI::TEST): Set our custom user agent to the empty string, and run navigator.userAgent.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add the new file.
  • TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
9:47 AM Changeset in webkit [70657] by Simon Fraser
  • 3 edits
    8 adds in trunk

2010-10-27 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Accelerated animation with missing values in keyframes is broken
​https://bugs.webkit.org/show_bug.cgi?id=48395

r66339 changed the behavior of keyframe animations such that if a property
is missing from a keyframe, the property will be interpolated between those
keyframes that do have a value for the property. If a value is missing
from the first or last keyframes, the element's unanimated style supplies
that value.

However, accelerated animations had a bug where if a value was missing
from the first (and maybe subsequent) or last (and maybe preceding) keyframes,
the animation data given to the GraphicsLayer would be missing the style from the
first or final keyframe.

Tests: animations/missing-values-first-keyframe.html

animations/missing-values-last-keyframe.html

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::startAnimation):
9:37 AM Changeset in webkit [70656] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2010-10-27 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed.

Moved the tests with WONTFIX to the WONTFIX list.

  • platform/chromium/test_expectations.txt:
9:12 AM Changeset in webkit [70655] by Adam Roben
  • 2 edits in trunk/WebKitTools

Check in file I forgot in r70653

  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:

(NP_Initialize): Save the NPPluginFuncs struct the browser passed to us
so we can be naughty and modify it later.

9:10 AM Changeset in webkit [70654] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-27 Renata Hodovan <​reni@inf.u-szeged.hu>

Reviewed by Dirk Schulze.

Calling the super class of RenderSVGImage::updateFromElement is missing
​https://bugs.webkit.org/show_bug.cgi?id=48347

RenderSVGImage::updateFromElement is an inherited function of RenderSVGModelObject what needs calling its ancestor.
Lack of this call caused filters were not invalidated at SVGImage objects.

No new tests, because this modification is covered by SVGFEConvolveMatrixElement's dynamic update tests.

  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::updateFromElement):
9:08 AM Changeset in webkit [70653] by Adam Roben
  • 11 edits
    3 adds in trunk

Don't call NPP_GetValue if the plugin didn't provide an implementation

Fixes <​http://webkit.org/b/48433> Crash in
NetscapePlugin::shouldLoadSrcURL when using Shockwave Director 10.3 in
WebKit2 on Windows

Reviewed by Eric Carlson.

WebKit2:

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NPP_GetValue): Null-check the getvalue pointer
before using it to call NPP_GetValue.

WebKitTools:

Test that WebKit doesn't crash if the plugin passes 0 for its
NPP_GetValue pointer

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  • GNUmakefile.am:

Added NullNPPGetValuePointer.cpp.

  • DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
  • DumpRenderTree/TestNetscapePlugIn/PluginObject.h:

Set up a place to store the NPPluginFuncs struct the browser passed to us.

  • DumpRenderTree/TestNetscapePlugIn/Tests/NullNPPGetValuePointer.cpp: Added.

(NullNPPGetValuePointer::NullNPPGetValuePointer): Null out the
NPP_GetValue pointer we passed to the browser to simulate a plugin that
doesn't implement NPP_GetValue.
(NullNPPGetValuePointer::NPP_GetValue): Print an error message. If this
function is called, it means that WebKit has changed in a way that
makes this test invalid.

  • DumpRenderTree/TestNetscapePlugIn/main.cpp:

(NP_GetEntryPoints): Save the NPPluginFuncs struct the browser passed
to us so we can be naughty and modify it later.

LayoutTests:

Test that WebKit doesn't crash if the plugin passes 0 for its
NPP_GetValue pointer

  • plugins/null-npp-getvalue-pointer-expected.txt: Added.
  • plugins/null-npp-getvalue-pointer.html: Added.
9:02 AM Changeset in webkit [70652] by jschuh@chromium.org
  • 3 edits
    2 adds in trunk

2010-10-27 Justin Schuh <​jschuh@chromium.org>

Reviewed by Dirk Schulze.

Ignore invalid blend modes
​https://bugs.webkit.org/show_bug.cgi?id=48371

Test: svg/filters/feBlend-invalid-mode.xhtml

  • platform/graphics/filters/FEBlend.cpp: (WebCore::FEBlend::apply):

2010-10-27 Justin Schuh <​jschuh@chromium.org>

Reviewed by Dirk Schulze.

Ignore invalid blend modes
​https://bugs.webkit.org/show_bug.cgi?id=48371

  • svg/filters/feBlend-invalid-mode-expected.txt: Added.
  • svg/filters/feBlend-invalid-mode.xhtml: Added.
8:58 AM Changeset in webkit [70651] by Martin Robinson
  • 7 edits
    2 adds in trunk

2010-10-27 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Martin Robinson.

[Gtk] http/tests/xmlhttprequest/basic-auth-default.html fails
​https://bugs.webkit.org/show_bug.cgi?id=38956

  • platform/gtk/Skipped: removed test from skipped list

2010-10-27 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Martin Robinson.

[Gtk] http/tests/xmlhttprequest/basic-auth-default.html fails
​https://bugs.webkit.org/show_bug.cgi?id=38956

Added a new utility function that turns SoupURIs into
KURLs. That addresses some issues with SoupURIs like for example
soup_uri_to_string ignoring the URI password. Basic authentication
using URL credentials should work now.

  • GNUmakefile.am:
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::loadResourceSynchronously):
  • platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::updateFromSoupMessage):
  • platform/network/soup/ResourceResponseSoup.cpp: (WebCore::ResourceResponse::updateFromSoupMessage):
  • platform/network/soup/SoupURIUtils.cpp: Added. (WebCore::soupURIToKURL):
  • platform/network/soup/SoupURIUtils.h: Added.
8:56 AM Changeset in webkit [70650] by commit-queue@webkit.org
  • 6 edits in trunk

2010-10-27 Ademar de Souza Reis Jr <Ademar Reis>

Reviewed by Andreas Kling.

Remove references to ancient QGVLauncher and QtLauncher
​https://bugs.webkit.org/show_bug.cgi?id=48430

  • manual-tests/plugins/windowed.html: change to QtTestBrowser
  • manual-tests/plugins/windowless.html: ditto

2010-10-27 Ademar de Souza Reis Jr <Ademar Reis>

Reviewed by Andreas Kling.

Remove references to ancient QGVLauncher and QtLauncher
​https://bugs.webkit.org/show_bug.cgi?id=48430

QtTestBrowser substitutes both and has checks enabled.

  • Scripts/webkitpy/style/checker.py: remove references
  • Scripts/webkitpy/style/checker_unittest.py: ditto
8:51 AM Changeset in webkit [70649] by Martin Robinson
  • 3 edits in trunk/LayoutTests

2010-10-27 Martin Robinson <​mrobinson@igalia.com>

Rebaseline a couple tests after r70569.

  • platform/gtk/fast/blockflow/floats-in-block-layout-expected.txt:
  • platform/gtk/fast/blockflow/self-collapsing-block-expected.txt:
8:48 AM Changeset in webkit [70648] by Csaba Osztrogonác
  • 2 edits in trunk/WebKitTools

[NRWT] Don't use image hash when it's no need in single test mode.
​https://bugs.webkit.org/show_bug.cgi?id=48326

Patch by Gabor Rapcsanyi <​rgabor@inf.u-szeged.hu> on 2010-10-27
Reviewed by Ojan Vafai.

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
8:43 AM Changeset in webkit [70647] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

2010-10-27 David Kilzer <​ddkilzer@apple.com>

Fix leak of CFMutableDictionaryRef in createXMLStringFromWebArchiveData()

Reviewed by Adam Roben.

Follow-up fix for: <​https://bugs.webkit.org/show_bug.cgi?id=48278>

  • DumpRenderTree/cf/WebArchiveDumpSupport.cpp: (createXMLStringFromWebArchiveData): Use RetainPtr<> to fix a leak introduced in r70613.
8:30 AM Changeset in webkit [70646] by Patrick Gansterer
  • 1 edit
    1 add in trunk/WebCore

2010-10-27 Patrick Gansterer <Patrick Gansterer>

Reviewed by Csaba Osztrogonác.

[WINCE] Buildfix after r70400.
​https://bugs.webkit.org/show_bug.cgi?id=48419

  • platform/wince/TemporaryLinkStubs.cpp: Added. (WebCore::setCookieStoragePrivateBrowsingEnabled):
8:22 AM Changeset in webkit [70645] by kbalazs@webkit.org
  • 2 edits in trunk/WebKit2

[Qt] Assert due to multiple initialization of WebPlatformStrategies
​https://bugs.webkit.org/show_bug.cgi?id=48327

Reviewed by Andreas Kling.

We are using the LocalizationStrategy in the UI process
so the previous attempt to fix this (​http://trac.webkit.org/changeset/70620)
was wrong.

  • UIProcess/API/qt/qwkpage.cpp:

(initializePlatformStrategiesIfNeeded):
Call WebPlatformStrategies::initialize exactly once.
(QWKPagePrivate::QWKPagePrivate):

8:16 AM Changeset in webkit [70644] by satish@chromium.org
  • 2 edits in trunk/WebCore

2010-10-27 Satish Sampath <​satish@chromium.org>

Reviewed by Steve Block.

Add runtime flag check before enabling speech input in code.
​https://bugs.webkit.org/show_bug.cgi?id=48426

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::isSpeechEnabled): Added runtime flag check.
7:37 AM Changeset in webkit [70643] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-10-27 Gabor Rapcsanyi <​rgabor@inf.u-szeged.hu>

Reviewed by Csaba Osztrogonác.

[NRWT] Add platform specific baseline search paths for Qt port
​https://bugs.webkit.org/show_bug.cgi?id=48428

  • Scripts/webkitpy/layout_tests/port/qt.py:
7:05 AM WebKitGtkLayoutTests edited by nicolas.dufresne@collabora.co.uk
Add FreeType hinting note (diff)
6:48 AM Changeset in webkit [70642] by loki@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-10-27 Gabor Loki <​loki@webkit.org>

Reviewed by Csaba Osztrogonác.

Add cmn to branch32(reg, imm) on ARM
​https://bugs.webkit.org/show_bug.cgi?id=48062

The conditional comparison can be done with cmn if the imm value is
negative and can fit into the cmn instruction.

  • assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::branch32):
6:15 AM Changeset in webkit [70641] by Adam Roben
  • 2 edits in trunk/WebCore

Only decompress pixel buffers when needed (and fix a crash in the process)

Fixes <​http://webkit.org/b/48417> Crash when running
compositing/video/video-background-color.html on Windows

Reviewed by Anders Carlsson.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:

(WebCore::MediaPlayerPrivateQuickTimeVisualContext::paint): Only
decompress the pixel buffer when it has an incompatible format. This
also has the benefit of only decompressing the buffer when a
QTDecompressionSession has been created! (I assume this was just a typo
from when this code was added in r70252.)

6:13 AM Changeset in webkit [70640] by Adam Roben
  • 2 edits in trunk/WebKitTools

Catch exceptions when checking if we're inside a git working directory

Fixes <​http://webkit.org/b/48420> REGRESSION (r70562): test-webkitpy
fails on systems without git installed

Reviewed by Anders Carlsson.

  • Scripts/webkitpy/common/net/credentials.py:

(Credentials._credentials_from_git): Put the call to
Git.in_working_directory inside the try/except since it, too, attempts
to execute git and thus will throw on systems that don't have git
installed.

5:46 AM Changeset in webkit [70639] by mario@webkit.org
  • 1 edit in trunk/WebKit/gtk/tests/testatk.c

2010-10-27 Mario Sanchez Prada <​msanchez@igalia.com>

Unreviewed, added missing line in testatk.c to add an unit test.

This fixes a mistake that happened when landing reviewed patch for
bug 47365, while addressing a minor issue before committing it.

getTextAtOffset returns incorrect results if a link includes text and an image
​https://bugs.webkit.org/show_bug.cgi?id=47365

  • tests/testatk.c: (main):
5:35 AM Changeset in webkit [70638] by Adam Roben
  • 1 edit
    3 adds in trunk/LayoutTests

Check in new Windows results for svg/custom/use-on-symbol-inside-pattern.svg

Windows has slightly different rounding behavior from Mac on this test.

  • platform/win/svg/custom/use-on-symbol-inside-pattern-expected.checksum: Added.
  • platform/win/svg/custom/use-on-symbol-inside-pattern-expected.png: Added.
  • platform/win/svg/custom/use-on-symbol-inside-pattern-expected.txt: Added.
5:07 AM Changeset in webkit [70637] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit2

2010-10-27 Kimmo Kinnunen <​kimmo.t.kinnunen@nokia.com>

Reviewed by Andreas Kling.

[Qt] WebKit2 UI process crashes if web process crashes
​https://bugs.webkit.org/show_bug.cgi?id=48400

Check the success of socket write operations.
Avoids crashing the UI process if web process has crashed.
Qt socket code segfaults when write is called for a socket
that has had an error.

  • Platform/CoreIPC/qt/ConnectionQt.cpp: (CoreIPC::Connection::platformInvalidate): Reset m_socket after deletion.

(CoreIPC::Connection::sendOutgoingMessage):
Check error status of write operations and
invalidate socket if writes fail.

4:52 AM Changeset in webkit [70636] by mnaganov@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-27 Mikhail Naganov <​mnaganov@chromium.org>

[Chromium] Unreviewed, fix english-lr-text expectations that I've messed up.

  • platform/chromium/test_expectations.txt:
4:48 AM Changeset in webkit [70635] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit2

2010-10-27 Kimmo Kinnunen <​kimmo.t.kinnunen@nokia.com>

Reviewed by Andreas Kling.

[Qt] Type mismatch while serializing/deserializing message id size
​https://bugs.webkit.org/show_bug.cgi?id=48401

Use correct types when reading data from connection buffer.

The message id is written as uint32_t, thus the buffer size should be
calculated based on sizeof(uint32_t) and not sizeof(MessageID).

  • Platform/CoreIPC/qt/ConnectionQt.cpp: (CoreIPC::Connection::readyReadHandler):
4:15 AM Changeset in webkit [70634] by mario@webkit.org
  • 4 edits in trunk

2010-10-27 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Martin Robinson.

getTextAtOffset returns incorrect results if a link includes text and an image
​https://bugs.webkit.org/show_bug.cgi?id=47365

Properly consider text under a non-text renderer in textForObject.

We need to check all the children under a non-text renderer, if
any, to consider when current object is not a text object but some
of its children are, in order not to miss those portions of text
by not properly handling those situations.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (textForRenderer): New. Get the text for a RenderObject's children. (textForObject): Use the new textForRenderer function.

2010-10-27 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Martin Robinson.

getTextAtOffset returns incorrect results if a link includes text and an image
​https://bugs.webkit.org/show_bug.cgi?id=47365

New test to make sure this bug is actually fixed.

  • tests/testatk.c: (testWebkitAtkLinksWithInlineImages): New test. (main): Added new test.
4:14 AM Changeset in webkit [70633] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-27 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, build fix for r70622.

  • inspector/storage-panel-dom-storage.html:
3:29 AM Changeset in webkit [70632] by jorlow@chromium.org
  • 1 edit in trunk/LayoutTests/ChangeLog

2010-10-26 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Steve Block.

Add IndexedDB test/tutorial
​https://bugs.webkit.org/show_bug.cgi?id=48067

This document is useful in terms of demonstrating IndexedDB and
documenting what we do and don't support currently, since I'll be
maintaining it for at least some time.

  • storage/indexeddb/tutorial-expected.txt: Added.
  • storage/indexeddb/tutorial.html: Added.
3:26 AM Changeset in webkit [70631] by Nikolas Zimmermann
  • 31 edits
    4 adds in trunk

2010-10-26 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Rob Buis.

Convert SVGRect to the new SVGPropertyTearOff concept
​https://bugs.webkit.org/show_bug.cgi?id=48204

Convert the next SVG primitive type to use the SVGPropertyTearOff concept: SVGRect.
Added new test verifying that StrictTypeChecking is enabled for SVGRect. Refactor and share code between JSC/V8/ObjC generators.

Test: svg/dom/SVGRect.html

  • GNUmakefile.am: Add SVGAnimatedRect.h to build.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/scripts/CodeGenerator.pm: Refactor SVGPropertyTearOff handling, and share code between JSC/V8/ObjC generators.
  • bindings/scripts/CodeGeneratorJS.pm: Ditto.
  • bindings/scripts/CodeGeneratorObjC.pm: Ditto.
  • bindings/scripts/CodeGeneratorV8.pm: Ditto.
  • svg/DeprecatedSVGAnimatedPropertyTraits.h: Remove SVGAnimatedRect handling.
  • svg/DeprecatedSVGAnimatedTemplate.h: Ditto.
  • svg/SVGAngle.idl: Remove [SVGProperty] flag.
  • svg/SVGAnimatedAngle.idl: Remove [SVGAnimatedProperty] flag.
  • svg/SVGAnimatedLength.idl: Ditto.
  • svg/SVGAnimatedLengthList.idl: Ditto.
  • svg/SVGAnimatedRect.h: Added.
  • svg/SVGFitToViewBox.h: SVGRect now uses the new tear off concept, adapt code.
  • svg/SVGLength.idl: Remove [SVGProperty] flag.
  • svg/SVGMarkerElement.h:
  • svg/SVGPatternElement.h:
  • svg/SVGRect.idl: Remove [PODType] flag, add StrictTypeChecking to all attributes.
  • svg/SVGSVGElement.cpp: s/setViewBox/setViewBoxBaseValue/. (WebCore::SVGSVGElement::currentView): (WebCore::SVGSVGElement::inheritViewAttributes):
  • svg/SVGSVGElement.h:
  • svg/SVGSVGElement.idl: Remove [Immutable] flags for SVGRect types, no longer needed.
  • svg/SVGSymbolElement.h:
  • svg/SVGViewElement.h:
  • svg/SVGViewSpec.cpp: Take a SVGElement as context element. (WebCore::SVGViewSpec::SVGViewSpec):
  • svg/SVGViewSpec.h: Ditto. (WebCore::SVGViewSpec::contextElement):
  • svg/SVGZoomEvent.idl: Remove [Immutable] flags for SVGRect types, no longer needed.
  • svg/properties/SVGAnimatedPropertyMacros.h: Support declaring animated properties on non-SVGElement types (here: SVGViewSpec), just like the old macros handled it.

2010-10-26 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Rob Buis.

Convert SVGRect to the new SVGPropertyTearOff concept
​https://bugs.webkit.org/show_bug.cgi?id=48204

Added new test verifying that StrictTypeChecking is enabled for SVGRect.

  • svg/dom/SVGRect-expected.txt: Added.
  • svg/dom/SVGRect.html: Added.
  • svg/dom/script-tests/SVGRect.js: Added.
3:22 AM Changeset in webkit [70630] by Adam Roben
  • 5 edits
    3 deletes in trunk/LayoutTests

Update Windows results for vertical-text tests after r70569

  • platform/win/fast/blockflow/english-rl-text-expected.checksum: Removed.
  • platform/win/fast/blockflow/english-rl-text-expected.png: Removed.
  • platform/win/fast/blockflow/english-rl-text-expected.txt: Removed.
  • platform/win/fast/text/international/vertical-text-glyph-test-expected.checksum:
  • platform/win/fast/text/international/vertical-text-glyph-test-expected.png:
  • platform/win/fast/text/international/vertical-text-glyph-test-expected.txt:
  • platform/win/fast/text/international/vertical-text-metrics-test-expected.txt:
3:21 AM Changeset in webkit [70629] by Nikolas Zimmermann
  • 2 edits in trunk/WebKitTools

2010-10-27 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by David Kilzer.

Convert DumpRenderTree webarchive code to CoreFoundation
​https://bugs.webkit.org/show_bug.cgi?id=48278

CFPropertyListCreateWithData and CFPropertyListCreateData are only available in 10.6+.
Replace CFPropertyListCreateWithData by a combination of CFReadStreamCreateWithBytesNoCopy and CFPropertyListCreateFromStream.
Replace CFPropertyListCreateData by CFPropertyListCreateXMLData.

These changes are wrapped in BUILDING_ON_LEOPARD, as the methods are deprecated on 10.6+.

  • DumpRenderTree/cf/WebArchiveDumpSupport.cpp: (createXMLStringFromWebArchiveData):
3:05 AM Changeset in webkit [70628] by mnaganov@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

2010-10-27 Mikhail Naganov <​mnaganov@chromium.org>

[Chromium] Unreviewed test expectations update -- add test results for Mac after r70619.

  • platform/chromium-mac/fast/block/float/clear-element-too-wide-for-containing-block-expected.checksum: Added.
  • platform/chromium/test_expectations.txt:
2:28 AM Changeset in webkit [70627] by mnaganov@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

2010-10-27 Mikhail Naganov <​mnaganov@chromium.org>

[Chromium] Unreviewed test expectations update -- add test results after r70619.

  • platform/chromium-linux/fast/block/float/clear-element-too-wide-for-containing-block-expected.checksum: Added.
  • platform/chromium-win/fast/block/float/clear-element-too-wide-for-containing-block-expected.checksum: Added.
  • platform/chromium-win/fast/block/float/clear-element-too-wide-for-containing-block-expected.png: Added.
  • platform/chromium-win/fast/block/float/clear-element-too-wide-for-containing-block-expected.txt: Added.
2:22 AM Changeset in webkit [70626] by pfeldman@chromium.org
  • 1 edit in branches/chromium/552/WebCore/inspector/front-end/InjectedScript.js

Merge 70565 - 2010-10-26 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: console doesn't work in closures when window is overrode
​https://bugs.webkit.org/show_bug.cgi?id=48320

  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor.):

TBR=​podivilov@chromium.org
BUG=60540

2:13 AM Changeset in webkit [70625] by pfeldman@chromium.org
  • 2 edits
    2 copies in branches/chromium/552

Merge 69752 - 2010-10-08 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] Scripts panel: the bubble shows wrong values
​https://bugs.webkit.org/show_bug.cgi?id=47358

Test: inspector/debugger-eval-on-call-frame.html

  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor.): don't embrace expression evaluated in the local scope of a call frame into with(window) to avoid shadowing local variables by global ones.

2010-10-08 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] Scripts panel: the bubble shows wrong values
​https://bugs.webkit.org/show_bug.cgi?id=47358

  • inspector/debugger-eval-on-call-frame-expected.txt: Added.
  • inspector/debugger-eval-on-call-frame.html: Added.

TBR=​yurys@chromium.org

2:04 AM Changeset in webkit [70624] by podivilov@chromium.org
  • 1 edit in trunk/WebCore/ChangeLog
2:04 AM Changeset in webkit [70623] by podivilov@chromium.org
  • 1 edit in trunk/WebCore/inspector/InspectorState.h

2010-10-27 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, fix line endings in InspectorState.h

  • inspector/InspectorState.h:
1:52 AM Changeset in webkit [70622] by podivilov@chromium.org
  • 15 edits in trunk/WebCore

2010-10-27 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: move frontend settings to local storage
​https://bugs.webkit.org/show_bug.cgi?id=47715

  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::didCommitLoad):
  • inspector/InspectorController.h:
  • inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState):
  • inspector/InspectorState.h:
  • inspector/front-end/ConsoleView.js:
  • inspector/front-end/EventListenersSidebarPane.js:
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._createStatusbarButtons):
  • inspector/front-end/Panel.js: (WebInspector.Panel):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._createStatusbarButtons):
  • inspector/front-end/Settings.js: (WebInspector.Settings): (WebInspector.Settings.prototype.installApplicationSetting): (WebInspector.Settings.prototype.installProjectSetting): (WebInspector.Settings.prototype._get): (WebInspector.Settings.prototype._set): (WebInspector.Settings.prototype._getProjectSetting): (WebInspector.Settings.prototype._setProjectSetting): (WebInspector.Settings.prototype._formatProjectKey):
  • inspector/front-end/StylesSidebarPane.js:
  • inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSidebarPane): (WebInspector.WatchExpressionsSidebarPane.prototype.reset):
  • inspector/front-end/inspector.js: (WebInspector.reset):
1:52 AM Changeset in webkit [70621] by mnaganov@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-27 Mikhail Naganov <​mnaganov@chromium.org>

[Chromium] Unreviewed test expectations update.

  • platform/chromium/test_expectations.txt:
1:19 AM Changeset in webkit [70620] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit2

2010-10-27 Zalan Bujtas <​zbujtas@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

Multiple WebPlatformStrategy initialization triggers assert in WebCore/PlatformStrategies.
Remove the code for now, as it is not used at all.
​https://bugs.webkit.org/show_bug.cgi?id=48327

  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::QWKPagePrivate):
1:18 AM Changeset in webkit [70619] by aestes@apple.com
  • 3 edits
    1 move
    3 adds
    3 deletes in trunk

2010-10-27 Andy Estes <​aestes@apple.com>

Reviewed by David Hyatt.

Siblings of floated elements should be cleared below the float if they
are too wide to fit in the containing block.
​https://bugs.webkit.org/show_bug.cgi?id=48396

Test: fast/block/float/clear-element-too-wide-for-containing-block.html

WebKit did not clear elements adjacent to floats if they were wider than
the containing block, instead keeping them on the same line and allowing
them to spill out the right side of the containing block. We should
match the spec in this regard and clear the element below the float even
if it is too wide for the containing block. Doing this seems to also
match IE's and Firefox's behavior.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::getClearDelta): Continue to compute the clear delta even if the child's minimum preferred width is greater than the containing block's available width.

2010-10-27 Andy Estes <​aestes@apple.com>

Reviewed by David Hyatt.

Siblings of floated elements should be cleared below the float if they
are too wide to fit in the containing block.
​https://bugs.webkit.org/show_bug.cgi?id=48396

  • fast/block/float/clear-element-too-wide-for-containing-block.html: Copied from LayoutTests/fast/block/float/tableshifting.html.
  • fast/block/float/tableshifting.html: Removed.
  • platform/mac/fast/block/float/clear-element-too-wide-for-containing-block-expected.checksum: Added.
  • platform/mac/fast/block/float/clear-element-too-wide-for-containing-block-expected.png: Added.
  • platform/mac/fast/block/float/clear-element-too-wide-for-containing-block-expected.txt: Added.
  • platform/mac/fast/block/float/tableshifting-expected.checksum: Removed.
  • platform/mac/fast/block/float/tableshifting-expected.png: Removed.
  • platform/mac/fast/block/float/tableshifting-expected.txt: Removed.
12:21 AM Changeset in webkit [70618] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Add some tests to the Skipeed list, because of unimplemented
LayoutTestController and EventSender features.

  • platform/qt-wk2/Skipped:
Note: See TracTimeline for information about the timeline view.