Context Navigation

← Previous Period
Next Period →

Timeline

Oct 30, 2010:

11:43 PM Changeset in webkit [70989] by pfeldman@chromium.org

6 edits in trunk/WebCore

2010-10-30 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: new resources and network panel usability improvements.
https://bugs.webkit.org/show_bug.cgi?id=48680

By default, navigation clears network log, added 'preserve log' button,
that prevents log from being cleared.

Storing expanded state of all group items, restoring last selected item,
fall back to main frame's main resource by default.
Do not list XHRs and redirects in resources.

English.lproj/localizedStrings.js:
inspector/InspectorController.cpp: (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest):
inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.get statusBarItems): (WebInspector.NetworkPanel.prototype._positionSummaryBar): (WebInspector.NetworkPanel.prototype._updateFilter): (WebInspector.NetworkPanel.prototype._createStatusbarButtons): (WebInspector.NetworkPanel.prototype._onPreserveLogClicked): (WebInspector.NetworkPanel.prototype.reset): (WebInspector.NetworkPanel.prototype.refreshResource):
inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager.prototype.identifierForInitialRequest): (WebInspector.ResourceManager.prototype.willSendRequest): (WebInspector.ResourceManager.prototype.didLoadResourceFromMemoryCache): (WebInspector.ResourceManager.prototype.setOverrideContent): (WebInspector.ResourceManager.prototype.didCreateWebSocket):
inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel): (WebInspector.StoragePanel.prototype.show): (WebInspector.StoragePanel.prototype._initDefaultSelection): (WebInspector.StoragePanel.prototype.reset): (WebInspector.StoragePanel.prototype.addResourceToFrame): (WebInspector.StoragePanel.prototype.refreshResource): (WebInspector.StoragePanel.prototype.showDatabase): (WebInspector.BaseStorageTreeElement.prototype.onselect): (WebInspector.StorageCategoryTreeElement): (WebInspector.StorageCategoryTreeElement.prototype.get itemURL): (WebInspector.StorageCategoryTreeElement.prototype.onselect): (WebInspector.StorageCategoryTreeElement.prototype.onattach): (WebInspector.StorageCategoryTreeElement.prototype.onexpand): (WebInspector.StorageCategoryTreeElement.prototype.oncollapse): (WebInspector.FrameTreeElement.prototype.get itemURL): (WebInspector.FrameTreeElement.prototype.onselect): (WebInspector.FrameResourceTreeElement.prototype.get itemURL): (WebInspector.FrameResourceTreeElement.prototype.onselect): (WebInspector.DatabaseTreeElement.prototype.get itemURL): (WebInspector.DatabaseTreeElement.prototype.onselect): (WebInspector.DatabaseTableTreeElement.prototype.get itemURL): (WebInspector.DatabaseTableTreeElement.prototype.onselect): (WebInspector.DOMStorageTreeElement.prototype.get itemURL): (WebInspector.DOMStorageTreeElement.prototype.onselect): (WebInspector.CookieTreeElement.prototype.get itemURL): (WebInspector.CookieTreeElement.prototype.onselect): (WebInspector.ApplicationCacheTreeElement.prototype.get itemURL): (WebInspector.ApplicationCacheTreeElement.prototype.onselect):

4:08 PM Changeset in webkit [70988] by tonikitoo@webkit.org

1 edit in trunk/WebKit/win/Interfaces/WebKit.idl

2010-10-30 Antonio Gomes <agomes@rim.com>

Unreviewed Windows bots build fix (take I).

Touching WebKit.idl to try forcing a clean build.

Interfaces/WebKit.idl:

2:00 PM Changeset in webkit [70987] by wsiegrist@apple.com

1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/config.json

William Siegrist <wsiegrist@apple.com>

Change trigger name to match builder name change in r70871.

12:31 PM Changeset in webkit [70986] by Patrick Gansterer

4 edits in trunk

2010-10-30 Patrick Gansterer <Patrick Gansterer>

Unreviewed, build fix after r70846.

platform/graphics/wince/ImageWinCE.cpp: (WebCore::RGBA32Buffer::asNewNativeImage):

2010-10-30 Patrick Gansterer <Patrick Gansterer>

Unreviewed, build fix after r70574.

WebCoreSupport/FrameLoaderClientWinCE.cpp: (WebKit::FrameLoaderClientWinCE::transferLoadingResourceFromPage):

11:48 AM Changeset in webkit [70985] by Dimitri Glazkov

19 edits
4 deletes in trunk

2010-10-30 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, rolling out r70984.
http://trac.webkit.org/changeset/70984
https://bugs.webkit.org/show_bug.cgi?id=46015

Made media/audio-delete-while-slider-thumb-clicked.html crash.

fast/events/shadow-boundary-crossing.html:

2010-10-30 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, rolling out r70984.
http://trac.webkit.org/changeset/70984
https://bugs.webkit.org/show_bug.cgi?id=46015

Made media/audio-delete-while-slider-thumb-clicked.html crash.

Android.mk:
CMakeLists.txt:
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.xcodeproj/project.pbxproj:
dom/ContainerNode.cpp: (WebCore::notifyChildInserted):
dom/EventContext.cpp: Removed.
dom/EventContext.h: Removed.
dom/Node.cpp: (WebCore::Node::markAncestorsWithChildNeedsStyleRecalc): (WebCore::Node::createRendererIfNeeded): (WebCore::Node::eventParentNode): (WebCore::Node::enclosingLinkEventParentOrSelf): (WebCore::eventTargetAsSVGElementInstance): (WebCore::eventTargetRespectingSVGTargetRules): (WebCore::Node::eventAncestors): (WebCore::Node::dispatchGenericEvent):
dom/Node.h:
dom/Text.cpp: (WebCore::Text::createRenderer):
dom/WindowEventContext.cpp: Removed.
dom/WindowEventContext.h: Removed.
inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getEventListenersForNode):
inspector/InspectorInstrumentation.cpp: (WebCore::eventHasListeners): (WebCore::InspectorInstrumentation::willDispatchEventImpl):
inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::willDispatchEvent):
page/EventHandler.cpp: (WebCore::EventHandler::updateMouseEventTargetNode):
svg/SVGElement.cpp: (WebCore::SVGElement::eventParentNode):
svg/SVGElement.h:

10:32 AM Changeset in webkit [70984] by Dimitri Glazkov

19 edits
4 adds in trunk

2010-10-30 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Implement shadow DOM-aware event targeting and introduce EventContext to track the context of each event dispatch.
https://bugs.webkit.org/show_bug.cgi?id=46015

Tuned the test to better reflect its point: the event should indeed fire (it used to be swallowed),
but its target should be a non-shadow node.

fast/events/shadow-boundary-crossing.html: Modified the test.

2010-10-30 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Implement shadow DOM-aware event targeting and introduce EventContext to track the context of each event dispatch.
https://bugs.webkit.org/show_bug.cgi?id=46015

This patch adds the notion of EventContext (and a very similar-acting WindowEventContext, specifically
for DOMWindow), an abstraction that carries information around dispatching an event for any given Node.

This abstraction is necessary to ensure that events, fired from shadow DOM nodes are properly retargeted to
appear as if they are coming from their host, thus never exposing the shadow DOM nodes to the world outside.

Android.mk: Added EventContext, WindowEventContext files.
CMakeLists.txt: Ditto.
GNUmakefile.am: Ditto.
WebCore.gypi: Ditto.
WebCore.pro: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.
dom/ContainerNode.cpp: (WebCore::notifyChildInserted): Changed to be shadow DOM-aware.
dom/EventContext.cpp: Added.
dom/EventContext.h: Added.
dom/Node.cpp: (WebCore::Node::markAncestorsWithChildNeedsStyleRecalc): Changed to be shadow DOM-aware. (WebCore::Node::createRendererIfNeeded): Ditto. (WebCore::Node::parentOrHostNode): Added new helper method. (WebCore::Node::enclosingLinkEventParentOrSelf): Changed to be shadow DOM-aware. (WebCore::eventTargetRespectingSVGTargetRules): Collapsed two helper methods into one. (WebCore::Node::eventAncestors): Refactored to collect a vector of EventContexts. (WebCore::Node::topEventContext): Added. (WebCore::eventHasListeners): Changed to use EventContexts. (WebCore::Node::dispatchGenericEvent): Ditto.
dom/Node.h: Removed eventParentNode that's no longer needed, added parentOrHostNode decl,

and changed signature of eventAncestors to use EventContexts.

dom/Text.cpp: (WebCore::Text::createRenderer): Changed to be shadow DOM-aware.
inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getEventListenersForNode): Changed to use EventContexts.
page/EventHandler.cpp: (WebCore::EventHandler::updateMouseEventTargetNode): Removed code that's no longer necessary.
svg/SVGElement.cpp: Removed eventParentNode that's no longer needed.
svg/SVGElement.h: Ditto.
dom/WindowEventContext.cpp: Added.
dom/WindowEventContext.h: Added.

8:17 AM Changeset in webkit [70983] by xan@webkit.org

2 edits in trunk/WebKit/gtk

2010-10-30 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Use new width for height APIs in GTK+ 3.x
https://bugs.webkit.org/show_bug.cgi?id=48709

Use the new width for height APIs in GTK+ 3.x, since size-request
is deprecated.

For now we just return the same value for preferred and minimum
width/height, which should match the 2.x behavior. Probably we
could do something smarter for the minimum values.

webkit/webkitwebview.cpp: (webkit_web_view_get_preferred_width): return our preferred width. (webkit_web_view_get_preferred_height): return our preferred height. (webkit_web_view_class_init): hook the new default handlers.

7:51 AM Changeset in webkit [70982] by andreas.kling@nokia.com

2 edits in trunk/WebKit/qt

2010-10-30 Andreas Kling <kling@webkit.org>

Reviewed by Antonio Gomes.

[Qt] IM: Don't manipulate selection via RenderTextControl
https://bugs.webkit.org/show_bug.cgi?id=48700

Go directly through the Frame's SelectionController instead.

No new tests, this is covered by tst_QWebPage::inputMethods.

Api/qwebpage.cpp: (QWebPagePrivate::inputMethodEvent): (QWebPage::inputMethodQuery):

7:49 AM Changeset in webkit [70981] by andreas.kling@nokia.com

2 edits in trunk/WebKit2

2010-10-30 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt][WK2] Crash in drawUpdateChunkIntoBackingStore
https://bugs.webkit.org/show_bug.cgi?id=48707

UpdateChunk images have to be created using the QImage constructor
that takes a bytesPerLine (stride) value, or the data length won't
match UpdateChunk::size().

Shared/qt/UpdateChunk.cpp: (WebKit::UpdateChunk::createImage):

7:48 AM Changeset in webkit [70980] by andreas.kling@nokia.com

3 edits in trunk/WebKitTools

2010-10-30 Andreas Kling <kling@webkit.org>

Reviewed by Antonio Gomes.

[Qt] QtTestBrowser: Switching view type moves the embedded inspector
https://bugs.webkit.org/show_bug.cgi?id=48705

Reinsert the embedded inspector into the splitter after changing
between QWebView/QGraphicsWebView.

QtTestBrowser/launcherwindow.cpp: (LauncherWindow::init): (LauncherWindow::initializeView):
QtTestBrowser/webinspector.h: (WebInspector::WebInspector):

6:23 AM Changeset in webkit [70979] by Nikolas Zimmermann

50 edits
10 adds in trunk

2010-10-30 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Rob Buis.

Convert SVGAnimatedNumber/SVGAnimatedNumberList to the new SVGAnimatedPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=48686

Convert the next set of primitives to use the new SVG(Animated)PropertyTearOff concept.

Tests: svg/dom/SVGAnimatedNumber.html

svg/dom/SVGAnimatedNumberList.html
svg/dom/SVGNumber.html

GNUmakefile.am: Add SVGAnimatedNumber.h / SVGAnimatedNumberList.h to build.
WebCore.gypi: Ditto.
WebCore.pro: Ditto.
WebCore.vcproj/WebCore.vcproj: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.
bindings/scripts/CodeGenerator.pm: Recognize SVGAnimatedNumber/SVGAnimatedNumberList as new style SVG animated properties. Remove SVGNumber from PODType hash.
bindings/scripts/CodeGeneratorJS.pm: Remove special SVGNumber handing, it's obsolete now.
bindings/scripts/CodeGeneratorObjC.pm: Add special SVGNumber handling, as it's the first of the converted dynamic SVGAnimatedProperty types that's not in WebCore namespace.
bindings/scripts/CodeGeneratorV8.pm: Use AvoidInclusionOfType method from CodeGenerator.pm, remove special SVGNumber handling, that's obsolete now.
rendering/svg/SVGTextLayoutAttributesBuilder.cpp: (WebCore::extractFloatValuesFromSVGNumberList): Adapt to SVGNumberList change, which is a plain Vector<float> now.
svg/DeprecatedSVGAnimatedPropertyTraits.h: Remove SVGAnimatedNumber/SVGAnimatedNumberList handling.
svg/DeprecatedSVGAnimatedTemplate.h: Ditto.
svg/SVGAnimatedNumber.h: Added.
svg/SVGAnimatedNumber.idl: Enable StrictTypeChecking.
svg/SVGAnimatedNumberList.h: Added.
svg/SVGAnimatedNumberList.idl: Ditto.
svg/SVGComponentTransferFunctionElement.cpp: Switch animated float properties to the new SVGAnimatedNumber(List). (WebCore::SVGComponentTransferFunctionElement::SVGComponentTransferFunctionElement): (WebCore::SVGComponentTransferFunctionElement::parseMappedAttribute): (WebCore::SVGComponentTransferFunctionElement::transferFunction):
svg/SVGComponentTransferFunctionElement.h:
svg/SVGFEColorMatrixElement.cpp: Ditto. (WebCore::SVGFEColorMatrixElement::SVGFEColorMatrixElement): (WebCore::SVGFEColorMatrixElement::parseMappedAttribute): (WebCore::SVGFEColorMatrixElement::build):
svg/SVGFEColorMatrixElement.h:
svg/SVGFECompositeElement.h: Ditto.
svg/SVGFEConvolveMatrixElement.cpp: Ditto. (WebCore::SVGFEConvolveMatrixElement::SVGFEConvolveMatrixElement): (WebCore::SVGFEConvolveMatrixElement::kernelUnitLengthXIdentifier): Added, replacing char[] hack by a static atomic string. (WebCore::SVGFEConvolveMatrixElement::kernelUnitLengthYIdentifier): Ditto. (WebCore::SVGFEConvolveMatrixElement::parseMappedAttribute): (WebCore::SVGFEConvolveMatrixElement::build):
svg/SVGFEConvolveMatrixElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
svg/SVGFEDiffuseLightingElement.cpp: Ditto. (WebCore::SVGFEDiffuseLightingElement::kernelUnitLengthXIdentifier): Remove trailing whitespace. (WebCore::SVGFEDiffuseLightingElement::kernelUnitLengthYIdentifier): Ditto.
svg/SVGFEDiffuseLightingElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
svg/SVGFEDisplacementMapElement.h: Ditto.
svg/SVGFEGaussianBlurElement.cpp: Ditto. (WebCore::SVGFEGaussianBlurElement::stdDeviationXIdentifier): Remove trailing whitespace. (WebCore::SVGFEGaussianBlurElement::stdDeviationYIdentifier): Ditto.
svg/SVGFEGaussianBlurElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
svg/SVGFELightElement.h: Ditto.
svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::radiusXIdentifier): Added, replacing char[] hack by a static atomic string. (WebCore::SVGFEMorphologyElement::radiusYIdentifier): Ditto.
svg/SVGFEMorphologyElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
svg/SVGFEOffsetElement.h: Ditto.
svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::kernelUnitLengthXIdentifier): Remove trailing whitespace. (WebCore::SVGFESpecularLightingElement::kernelUnitLengthYIdentifier): Ditto.
svg/SVGFESpecularLightingElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::baseFrequencyXIdentifier): Remove trailing whitespace. (WebCore::SVGFETurbulenceElement::baseFrequencyYIdentifier): Ditto.
svg/SVGFETurbulenceElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::filterResXIdentifier): Remove trailing whitespace. (WebCore::SVGFilterElement::filterResYIdentifier): Ditto.
svg/SVGLengthList.idl: Remove leftover [SVGListProperty] marker.
svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::orientTypeIdentifier): Remove trailing whitespace. (WebCore::SVGMarkerElement::orientAngleIdentifier): Ditto.
svg/SVGNumber.idl: Remove [PODType] marker, add StrictTypeChecking.
svg/SVGNumberList.cpp: Convert from SVGPODList<RefPtr<SVGPODListItem<float> > > to plain Vector<float>, just like it has been done for SVGLengthList before. (WebCore::SVGNumberList::parse): (WebCore::SVGNumberList::valueAsString):
svg/SVGNumberList.h: (WebCore::SVGNumberList::SVGNumberList):
svg/SVGPathElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
svg/SVGStopElement.h: Ditto.
svg/SVGTextPositioningElement.cpp: Switch animated float properties to the new SVGAnimatedNumber(List). (WebCore::SVGTextPositioningElement::SVGTextPositioningElement): (WebCore::SVGTextPositioningElement::parseMappedAttribute):
svg/SVGTextPositioningElement.h: Ditto.
svg/properties/SVGPropertyTraits.h: Add SVGNumberList handling.

2010-10-30 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Rob Buis.

Convert SVGAnimatedNumber/SVGAnimatedNumberList to the new SVGAnimatedPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=48686

Fix invalid tests in svg/dynamic-updates, that relied on a bug in our SVGNumberList implementation. If an item was already
inserted in a list, and we tried to insert it somewhere else, we didn't remove it from the old list. Now that SVGNumberList
has been switched to SVGAnimatedListPropertyTearOff, the bug is fixed, and it behaves exactly like SVGLengthList.

Side effect: svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop.html now works as expected (dynamic update is executed)

platform/mac-leopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.checksum:
platform/mac-leopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png:
svg/dom/SVGAnimatedNumber-expected.txt: Added.
svg/dom/SVGAnimatedNumber.html: Added.
svg/dom/SVGAnimatedNumberList-expected.txt: Added.
svg/dom/SVGAnimatedNumberList.html: Added.
svg/dom/SVGNumber-expected.txt: Added.
svg/dom/SVGNumber.html: Added.
svg/dom/script-tests/SVGAnimatedNumber.js: Added.
svg/dom/script-tests/SVGAnimatedNumberList.js: Added.
svg/dom/script-tests/SVGNumber.js: Added.
svg/dynamic-updates/script-tests/SVGFEColorMatrixElement-svgdom-type-prop.js: Test now works in Firefox as well. (executeTest): SVGNumber.value only accepts numbers, not strings, now that StrictTypeChecking is enabled.
svg/dynamic-updates/script-tests/SVGFEColorMatrixElement-svgdom-values-prop.js: Test now works in Firefox as well. (executeTest): Don't call appendItem several times with the same SVGNumber, it will be removed if it was already inserted in a list.
svg/dynamic-updates/script-tests/SVGFETurbulenceElement-svgdom-baseFrequency-prop.js:

1:59 AM Changeset in webkit [70978] by Nikolas Zimmermann

5 edits in trunk/LayoutTests

2010-10-30 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Update SVGFEFloodElement mac-leopard baseline, which was forgotten.

platform/mac-leopard/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.checksum:
platform/mac-leopard/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png:
platform/mac-leopard/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.checksum:
platform/mac-leopard/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png:

Oct 29, 2010:

11:15 PM Changeset in webkit [70977] by abarth@webkit.org

1 edit
2 copies in branches/chromium/552

Merge 70718 - 2010-10-27 Adam Barth <abarth@webkit.org>

Reviewed by Ojan Vafai.

REGRESSION(66511): CORDYS Process Factory doesn't work
https://bugs.webkit.org/show_bug.cgi?id=48453

Test some appendChild cases that didn't have coverage before.

fast/dom/allowed-children-expected.txt: Added.
fast/dom/allowed-children.html: Added.

2010-10-27 Adam Barth <abarth@webkit.org>

Reviewed by Ojan Vafai.

REGRESSION(66511): CORDYS Process Factory doesn't work
https://bugs.webkit.org/show_bug.cgi?id=48453

When Ojan refactored this function in 66511, he missed an "else",
which causes us to generated HIERARCHY_REQUEST_ERR in some cases where
we're not supposed to. This patch restores the "else" behavior (using
an early return) and adds a test for the cases that caused problems in
the field.

Test: fast/dom/allowed-children.html

dom/Node.cpp: (WebCore::isChildTypeAllowed):

TBR=abarth@webkit.org

11:13 PM Changeset in webkit [70976] by dbates@webkit.org

28 edits
2 copies in trunk

2010-10-29 Daniel Bates <dbates@rim.com>

No review, rolling out 70971.
http://trac.webkit.org/changeset/70971
https://bugs.webkit.org/show_bug.cgi?id=6751

Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
it caused layout tests regressions on all bots. In particular, the
child count in a generated frame name differs after this patch. We need
to look into this further.

src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::name):

2010-10-29 Daniel Bates <dbates@rim.com>

No review, rolling out 70971.
http://trac.webkit.org/changeset/70971
https://bugs.webkit.org/show_bug.cgi?id=6751

Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
it caused layout tests regressions on all bots. In particular, the
child count in a generated frame name differs after this patch. We need
to look into this further.

Api/qwebframe.cpp: (QWebFrame::frameName):

2010-10-29 Daniel Bates <dbates@rim.com>

No review, rolling out 70971.
http://trac.webkit.org/changeset/70971
https://bugs.webkit.org/show_bug.cgi?id=6751

Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
it caused layout tests regressions on all bots. In particular, the
child count in a generated frame name differs after this patch. We need
to look into this further.

webkit/webkitwebframe.cpp: (webkit_web_frame_get_name):

2010-10-29 Daniel Bates <dbates@rim.com>

No review, rolling out 70971.
http://trac.webkit.org/changeset/70971
https://bugs.webkit.org/show_bug.cgi?id=6751

Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
it caused layout test failures on all bots. In particular, the
child count in a generated frame name differs after this patch. We need
to look into this further.

WebFrame.cpp: (WebFrame::name):

2010-10-29 Daniel Bates <dbates@rim.com>

No review, rolling out 70971.
http://trac.webkit.org/changeset/70971
https://bugs.webkit.org/show_bug.cgi?id=6751

Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
it caused layout test failures on all bots. In particular, the
child count in a generated frame name differs after this patch. We need
to look into this further.

WebView/WebFrame.mm: (-[WebFrame name]):

2010-10-29 Daniel Bates <dbates@rim.com>

No review, rolling out 70971.
http://trac.webkit.org/changeset/70971
https://bugs.webkit.org/show_bug.cgi?id=6751

Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
it caused layout test failures on all bots. In particular, the
child count in a generated frame name differs after this patch. We need
to look into this further.

ewk/ewk_frame.cpp: (ewk_frame_name_get):

2010-10-29 Daniel Bates <dbates@rim.com>

No review, rolling out 70971.
http://trac.webkit.org/changeset/70971
https://bugs.webkit.org/show_bug.cgi?id=6751

Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
it caused layout test failures on all bots. In particular, the
child count in a generated frame name differs after this patch. We need
to look into this further.

Test: fast/frames/iframe-set-inner-html.html

html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::openURL): (WebCore::HTMLFrameElementBase::setName):
html/HTMLFrameElementBase.h:
loader/DocumentLoader.cpp: (WebCore::DocumentLoader::mainResource):
loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURLIntoChildFrame): (WebCore::FrameLoader::commitProvisionalLoad):
loader/HistoryController.cpp: (WebCore::HistoryController::saveDocumentState): (WebCore::HistoryController::restoreDocumentState): (WebCore::HistoryController::createItem): (WebCore::HistoryController::currentFramesMatchItem):
loader/ProgressTracker.cpp: (WebCore::ProgressTracker::progressStarted): (WebCore::ProgressTracker::progressCompleted):
loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::create):
page/FrameTree.cpp: (WebCore::FrameTree::setName): (WebCore::FrameTree::clearName): (WebCore::FrameTree::uniqueChildName): (WebCore::FrameTree::child): (WebCore::FrameTree::find):
page/FrameTree.h: (WebCore::FrameTree::name):

2010-10-29 Daniel Bates <dbates@rim.com>

No review, rolling out 70971.
http://trac.webkit.org/changeset/70971
https://bugs.webkit.org/show_bug.cgi?id=6751

Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
it caused layout test failures on all bots. In particular, the
child count in a generated frame name differs after this patch. We need
to look into this further.

fast/frames/frame-element-name-expected.txt:
fast/frames/iframe-set-inner-html-expected.txt: Copied from LayoutTests/fast/frames/iframe-set-inner-html-expected.txt.
fast/frames/iframe-set-inner-html.html: Copied from LayoutTests/fast/frames/iframe-set-inner-html.html.
fast/frames/resources/frame-element-name-left.html:
fast/frames/resources/frame-element-name-right.html:

2010-10-29 Daniel Bates <dbates@rim.com>

No review, rolling out 70971.
http://trac.webkit.org/changeset/70971
https://bugs.webkit.org/show_bug.cgi?id=6751

Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
it caused layout test failures on all bots. In particular, the
child count in a generated frame name differs after this patch. We need
to look into this further.

WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::name):

10:38 PM Changeset in webkit [70975] by tonikitoo@webkit.org

21 edits in trunk

Needs a "LinuxEditingBehavior", perhaps with a better name
https://bugs.webkit.org/show_bug.cgi?id=36627

Reviewed by Ojan Vafai.
Patch by Antonio Gomes <agomes@rim.com>

WebCore:

Added EditingUnixBehavior editing type aim to cover the cases when
neither Mac or Windows behaviors are appropriated.

It was decided to name it Unix not Linux.

No new tests. The current editing tests that involve platform specific
bahaviors are coded so that they go through all editing behavior
types possible. There will be a follow up bug where all of them will
be updated to include the new editing behavior ("unix").

editing/EditingBehaviorTypes.h:
page/Settings.cpp:

(WebCore::editingBehaviorTypeForPlatform):
(WebCore::Settings::Settings):

WebKit/chromium:

Added the corresponding Chromium setting to WebCore's EditingUnixBehavior: EditingBehaviorUnix.

public/WebSettings.h:
src/AssertMatchingEnums.cpp:

WebKit/gtk:

Added the corresponding GTK+ setting to WebCore's EditingUnixBehavior: WEBKIT_EDITING_BEHAVIOR_UNIX.

webkit/webkitwebsettings.cpp:

(webkit_web_settings_class_init):

webkit/webkitwebsettings.h:

WebKit/mac:

Added the corresponding GTK+ setting to WebCore's EditingUnixBehavior: WebKitEditingUnixBehavior.

WebView/WebFrame.mm:

(core):

WebView/WebPreferencesPrivate.h:

WebKit/qt:

Adding support to Qt's DRTSupport class to test the newly introduced Unix editing behavior.

WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::setEditingBehavior):

WebKit/win:

Added the corresponding GTK+ setting to WebCore's EditingUnixBehavior: WebKitEditingUnixBehavior.

Interfaces/IWebPreferences.idl:

WebKitTools:

Adding support to Mac's, GTK+'s, Windows' and Chromium's LayoutTestController class to test the newly introduced Unix editing behavior.

DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::setEditingBehavior):

DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::setEditingBehavior):

DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::setEditingBehavior):

DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::setEditingBehavior):

9:07 PM Changeset in webkit [70974] by mrowe@apple.com

9 edits
2 deletes in tags/Safari-534.11.1/WebCore

Merge r70970.

9:07 PM Changeset in webkit [70973] by mrowe@apple.com

5 edits in tags/Safari-534.11.1

Versioning.

8:57 PM Changeset in webkit [70972] by mrowe@apple.com

1 copy in tags/Safari-534.11.1

New tag.

8:49 PM Changeset in webkit [70971] by dbates@webkit.org

28 edits
2 deletes in trunk

2010-10-29 Daniel Bates <dbates@rim.com>

Reviewed by Adam Barth.

For unnamed frames, window.name returns a generated name
https://bugs.webkit.org/show_bug.cgi?id=6751

Modified Chromium-port to use FrameTree::uniqueName().

src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::name):

2010-10-29 Daniel Bates <dbates@rim.com>

Reviewed by Adam Barth.

For unnamed frames, window.name returns a generated name
https://bugs.webkit.org/show_bug.cgi?id=6751

Modified Qt-port to use FrameTree::uniqueName().

Api/qwebframe.cpp: (QWebFrame::frameName):

2010-10-29 Daniel Bates <dbates@rim.com>

Reviewed by Adam Barth.

For unnamed frames, window.name returns a generated name
https://bugs.webkit.org/show_bug.cgi?id=6751

Modified GTK-port to use FrameTree::uniqueName().

webkit/webkitwebframe.cpp: (webkit_web_frame_get_name):

2010-10-29 Daniel Bates <dbates@rim.com>

Reviewed by Adam Barth.

For unnamed frames, window.name returns a generated name
https://bugs.webkit.org/show_bug.cgi?id=6751

Modified Apple Windows-port to use FrameTree::uniqueName().

WebFrame.cpp: (WebFrame::name):

2010-10-29 Daniel Bates <dbates@rim.com>

Reviewed by Adam Barth.

For unnamed frames, window.name returns a generated name
https://bugs.webkit.org/show_bug.cgi?id=6751

Modified Mac-port to use FrameTree::uniqueName().

WebView/WebFrame.mm: (-[WebFrame name]):

2010-10-29 Daniel Bates <dbates@rim.com>

Reviewed by Adam Barth.

For unnamed frames, window.name returns a generated name
https://bugs.webkit.org/show_bug.cgi?id=6751

Modified EFL-port to use FrameTree::uniqueName().

ewk/ewk_frame.cpp: (ewk_frame_name_get):

2010-10-29 Daniel Bates <dbates@rim.com>

Reviewed by Adam Barth.

For unnamed frames, window.name returns a generated name
https://bugs.webkit.org/show_bug.cgi?id=6751

Fixes an issue where the window.name of an unnamed frame returns
a unique generated name that is used internally to identify the
frame. Instead, we should return an empty string as implied by
section 5.1.6 of the HTML5 spec. (http://www.w3.org/TR/html5/browsers.html#browsing-context-names).
This section describes that a browsing context can have no name or be
the empty string.

html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::openURL): Removed ASSERT for empty frame name since this is valid as per the HTML5 spec. (WebCore::HTMLFrameElementBase::setName): Removed the call to FrameTree::uniqueChildName() since the loader code no longer depends on the frame name being unique.
html/HTMLFrameElementBase.h:
loader/DocumentLoader.cpp: (WebCore::DocumentLoader::mainResource): Use FrameTree::uniqueName().
loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURLIntoChildFrame): Ditto. (WebCore::FrameLoader::commitProvisionalLoad): Ditto.
loader/HistoryController.cpp: (WebCore::HistoryController::saveDocumentState): Ditto. (WebCore::HistoryController::restoreDocumentState): Ditto. (WebCore::HistoryController::createItem): (WebCore::HistoryController::currentFramesMatchItem): Ditto.
loader/ProgressTracker.cpp: (WebCore::ProgressTracker::progressStarted): Ditto. (WebCore::ProgressTracker::progressCompleted): Ditto.
loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::create): Ditto.
page/FrameTree.cpp: (WebCore::FrameTree::setName): Modified to store the DOM-specified name of the frame. (WebCore::FrameTree::clearName): (WebCore::FrameTree::uniqueChildName): Use FrameTree::uniqueName(). (WebCore::FrameTree::child): Ditto. (WebCore::FrameTree::find): Ditto.
page/FrameTree.h: (WebCore::FrameTree::uniqueName): Added.

2010-10-29 Daniel Bates <dbates@rim.com>

Reviewed by Adam Barth.

For unnamed frames, window.name returns a generated name
https://bugs.webkit.org/show_bug.cgi?id=6751

Updated test case fast/frames/frame-element-name.html to check
the value of window.name.

fast/frames/frame-element-name-expected.txt: Updated result.
fast/frames/iframe-set-inner-html-expected.txt: Removed; This test ensured that the generated name for an unnamed frames was unique by looking at the value of window.name. However, the generated name should not be exposed to web developers. Instead, window.name should return the empty string for an unnamed frame as implied by section 5.1.6 of the HTML5 spec. We should consider exposing a DRT method for obtaining the internal frame name (which may be generated) and re-implementing this test to use it.
fast/frames/iframe-set-inner-html.html: Removed.
fast/frames/resources/frame-element-name-left.html: Added test for window.name.
fast/frames/resources/frame-element-name-right.html: Ditto.

2010-10-29 Daniel Bates <dbates@rim.com>

Reviewed by Adam Barth.

For unnamed frames, window.name returns a generated name
https://bugs.webkit.org/show_bug.cgi?id=6751

Modified WebKit2 to use FrameTree::uniqueName().

WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::name):

8:42 PM Changeset in webkit [70970] by mrowe@apple.com

9 edits
2 deletes in trunk/WebCore

Roll out r70847 as it causes crashes when typing text in both Safari and Mail: <http://webkit.org/b/48708>.

8:37 PM Changeset in webkit [70969] by mitz@apple.com

2 edits in trunk/WebKitLibraries

Snow Leopard PowerPC build fix.

libWebKitSystemInterfaceSnowLeopard.a:

8:34 PM Changeset in webkit [70968] by mitz@apple.com

2 edits in trunk/WebKitLibraries

Leopard PowerPC build fix.

libWebKitSystemInterfaceLeopard.a:

6:40 PM Changeset in webkit [70967] by jamesr@google.com

495 edits
494 copies in trunk/LayoutTests

2010-10-29 James Robinson <jamesr@chromium.org>

Update pixel expectations for Snow Leopard for tests in tables/mozilla/bugs.

Moves the leopard-specific mac baselines to platform/mac-leopard/ and adds new Snow Leopard pixel
expectations for tests that need them. List of files omitted due to length.

6:28 PM Changeset in webkit [70966] by weinig@apple.com

2 edits in trunk/WebKit2

Implement WebProcess::platformSetCacheModel for windows
<rdar://problem/8605796>
https://bugs.webkit.org/show_bug.cgi?id=48703

Reviewed by Simon Fraser.

WebProcess/win/WebProcessWin.cpp:

(WebKit::memorySize):
(WebKit::volumeFreeSize):
(WebKit::WebProcess::platformSetCacheModel):
Add implemenation based on the version in WebKit/win/WebView.cpp.

6:23 PM Changeset in webkit [70965] by dimich@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectations update.
Enable a few tests that were fixed in revs 70891:70949.

platform/chromium/test_expectations.txt:

6:09 PM Changeset in webkit [70964] by andreas.kling@nokia.com

2 edits in trunk/WebKit2

2010-10-29 Andreas Kling <kling@webkit.org>

Reviewed by Anders Carlsson.

WK2: Unbreak compilation of WebPlatformTouchPoint::decode()

Shared/WebPlatformTouchPoint.cpp: (WebKit::WebPlatformTouchPoint::decode):

6:07 PM Changeset in webkit [70963] by Darin Adler

5 edits in trunk/WebCore

Try to fix build.

page/ContextMenuController.cpp: Added include of BackForwardController.h.
page/DOMWindow.cpp: Ditto.
page/History.cpp: Ditto.
platform/ContextMenu.cpp: Ditto.

5:58 PM Changeset in webkit [70962] by mrowe@apple.com

5 edits in trunk

Versioning.

5:55 PM Changeset in webkit [70961] by mrowe@apple.com

1 copy in tags/Safari-534.11

New tag.

5:44 PM Changeset in webkit [70960] by Darin Adler

33 edits
3 deletes in trunk

More back/forward refactoring

Reviewed by Sam Weinig.

WebCore:

WebCore.exp.in: Updated.

GNUmakefile.am: Removed BackForwardControllerClient.h.
WebCore.gypi: Ditto.
WebCore.pro: Ditto.
WebCore.vcproj/WebCore.vcproj: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.

history/BackForwardControllerClient.h: Removed.

history/BackForwardController.cpp:

(WebCore::BackForwardController::BackForwardController):
Set up just m_client.
(WebCore::BackForwardController::~BackForwardController):
Removed call to backForwardControllerDestroyed.
(WebCore::BackForwardController::canGoBackOrForward): Added.
(WebCore::BackForwardController::goBackOrForward): Added.
(WebCore::BackForwardController::goBack): Added.
(WebCore::BackForwardController::goForward): Added.
(WebCore::BackForwardController::addItem): Added.
(WebCore::BackForwardController::setCurrentItem): Added.
(WebCore::BackForwardController::count): Added.
(WebCore::BackForwardController::backCount): Added.
(WebCore::BackForwardController::forwardCount): Added.
(WebCore::BackForwardController::itemAtIndex): Added.
(WebCore::BackForwardController::isActive): Added.
(WebCore::BackForwardController::close): Added.

history/BackForwardController.h: Added functions from Page

and BackForwardList that should be called here instead.
Note that BackForwardList is to be renamed BackForwardClient soon.

history/BackForwardList.h: Removed many now-unneeded

virtual functions.

history/BackForwardListImpl.h: Moved BackForwardListClient

in here.

history/PageCache.cpp:

(WebCore::logCanCachePageDecision): Use backForward().
(WebCore::PageCache::canCache): Ditto.

loader/FrameLoader.cpp:

(WebCore::FrameLoader::transitionToCommitted): Removed unneeded
null check of backFowardList, which is never null.
(WebCore::FrameLoader::checkLoadCompleteForThisFrame): Use backForward.
(WebCore::FrameLoader::didFirstLayout): Ditto.
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Ditto.
(WebCore::FrameLoader::checkDidPerformFirstNavigation): Ditto.

loader/HistoryController.cpp:

(WebCore::HistoryController::goToItem): Ditto.
(WebCore::HistoryController::updateForStandardLoad): Ditto.
(WebCore::HistoryController::updateForRedirectWithLockedBackForwardList): Ditto.
(WebCore::HistoryController::updateBackForwardListClippedAtTarget): Ditto.
(WebCore::HistoryController::pushState): Ditto.

loader/NavigationScheduler.cpp:

(WebCore::ScheduledHistoryNavigation::fire): Ditto.
(WebCore::NavigationScheduler::scheduleHistoryNavigation): Ditto.

page/ContextMenuController.cpp:

(WebCore::ContextMenuController::contextMenuItemSelected): Ditto.

page/DOMWindow.cpp:

(WebCore::DOMWindow::close): Ditto.

page/History.cpp:

(WebCore::History::length): Ditto.

page/Page.cpp:

(WebCore::Page::Page): Use more adoptPtr. Use backForwardClient instead of
backForwardControllerClient.
(WebCore::Page::~Page): Use backForward.
(WebCore::Page::backForwardList): Ditto.
(WebCore::Page::goBack): Ditto.
(WebCore::Page::goForward): Ditto.
(WebCore::Page::canGoBackOrForward): Ditto.
(WebCore::Page::goBackOrForward): Ditto.
(WebCore::Page::getHistoryLength): Ditto.
(WebCore::Page::PageClients::PageClients): Made non-inline.
(WebCore::Page::PageClients::~PageClients): Ditto.

page/Page.h: Made PageClients constructor and destructor non-inline.

Added backForward function. Marked old functions as deprecated.

page/Settings.cpp:

(WebCore::Settings::setUsesPageCache): Use backForward.

platform/ContextMenu.cpp:

(WebCore::ContextMenu::populate): Ditto.
(WebCore::ContextMenu::checkOrEnableIfNeeded): Ditto.

wml/WMLDoElement.cpp:

(WebCore::WMLDoElement::defaultEventHandler): Ditto.

wml/WMLDocument.cpp:

(WebCore::WMLDocument::finishedParsing): Ditto.

wml/WMLPageState.cpp:

(WebCore::WMLPageState::reset): Ditto.
(WebCore::tryAccessHistoryURLs): Ditto.

wml/WMLPrevElement.cpp:

(WebCore::WMLPrevElement::executeTask): Ditto.

WebKit2:

WebKit2.pro: Removed WebBackForwardControllerClient.cpp and .h.
WebKit2.xcodeproj/project.pbxproj: Ditto.

WebProcess/WebCoreSupport/WebBackForwardControllerClient.cpp: Removed.
WebProcess/WebCoreSupport/WebBackForwardControllerClient.h: Removed.

WebProcess/InjectedBundle/InjectedBundleBackForwardList.cpp:

(WebKit::InjectedBundleBackForwardList::itemAtIndex): Use backForward.
(WebKit::InjectedBundleBackForwardList::backListCount): Ditto.
(WebKit::InjectedBundleBackForwardList::forwardListCount): Ditto.
(WebKit::InjectedBundleBackForwardList::clear): Ditto.

WebProcess/WebPage/WebBackForwardListProxy.h: Added newly-needed include.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage): Set up backForwardClient.

5:38 PM Changeset in webkit [70959] by hyatt@apple.com

25 edits
4 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=48663

Reviewed by Sam Weinig.

Make repaint invalidation work with vertical lines. Rewrite linesBoundingBox for RenderText and
RenderInline to give the correct rectangle back for vertical lines. Also patch linesVisibleOverflowBoundingBox
to give back the correct rectangle for vertical lines.

Fix bugs in the overflow accessors of InlineFlowBox when m_overflow was 0.

Added fast/repaint/inline-vertical-lr-overflow.html

WebCore:

rendering/InlineBox.cpp:

(WebCore::InlineBox::adjustForFlippedBlocksWritingMode):

rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::logicalLeftVisibleOverflow):
(WebCore::InlineFlowBox::logicalRightVisibleOverflow):
(WebCore::InlineFlowBox::bottomLayoutOverflow):
(WebCore::InlineFlowBox::rightLayoutOverflow):
(WebCore::InlineFlowBox::bottomVisualOverflow):
(WebCore::InlineFlowBox::rightVisualOverflow):

rendering/RenderBox.cpp:

(WebCore::RenderBox::adjustForFlippedBlocksWritingMode):

rendering/RenderBox.h:
rendering/RenderInline.cpp:

(WebCore::RenderInline::linesBoundingBox):
(WebCore::RenderInline::linesVisibleOverflowBoundingBox):
(WebCore::RenderInline::clippedOverflowRectForRepaint):

rendering/RenderText.cpp:

(WebCore::RenderText::linesBoundingBox):

LayoutTests:

fast/repaint/inline-vertical-rl-overflow.html: Added.
platform/mac/fast/blockflow/background-vertical-lr-expected.txt:
platform/mac/fast/blockflow/background-vertical-rl-expected.txt:
platform/mac/fast/blockflow/basic-vertical-line-expected.txt:
platform/mac/fast/blockflow/border-image-vertical-lr-expected.txt:
platform/mac/fast/blockflow/border-image-vertical-rl-expected.txt:
platform/mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.txt:
platform/mac/fast/blockflow/border-vertical-lr-expected.checksum:
platform/mac/fast/blockflow/border-vertical-lr-expected.png:
platform/mac/fast/blockflow/border-vertical-lr-expected.txt:
platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.txt:
platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.txt:
platform/mac/fast/blockflow/english-lr-text-expected.txt:
platform/mac/fast/blockflow/english-rl-text-expected.txt:
platform/mac/fast/blockflow/japanese-lr-text-expected.txt:
platform/mac/fast/blockflow/japanese-rl-text-expected.txt:
platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.checksum: Added.
platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.png: Added.
platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.txt: Added.
platform/mac/fast/text/international/vertical-text-glyph-test-expected.txt:

5:37 PM Changeset in webkit [70958] by jamesr@google.com

321 edits
320 copies in trunk/LayoutTests

2010-10-29 James Robinson <jamesr@chromium.org>

Update pixel expectations for Snow Leopard for tests in tables/mozilla/marvin.

Moves the leopard-specific mac baselines to platform/mac-leopard/ and adds new Snow Leopard pixel
expectations for tests that need them. List of files omitted due to length.

5:13 PM Changeset in webkit [70957] by commit-queue@webkit.org

5 edits
1 delete in trunk

2010-10-29 Mike Lawther <mikelawther@chromium.org>

Reviewed by James Robinson.

Fix canvas/philip/tests/2d.imageData.get.source.negative
https://bugs.webkit.org/show_bug.cgi?id=48277

Remove canvas/philip/tests/2d.imageData.get.source.negative from chromium skipped.
Also remove spurious trailing newlines from 2d.imageData.get.source.negative-expected.txt

canvas/philip/tests/2d.imageData.get.source.negative-expected.txt:
platform/chromium/test_expectations.txt:

2010-10-29 Mike Lawther <mikelawther@chromium.org>

Reviewed by James Robinson.

Fix canvas/philip/tests/2d.imageData.get.source.negative
https://bugs.webkit.org/show_bug.cgi?id=48277

Handle negative width/height.
See http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#pixel-manipulation

html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::getImageData):

4:57 PM Changeset in webkit [70956] by commit-queue@webkit.org

25 edits
3 adds in trunk

2010-10-29 Kavita Kanetkar <kkanetkar@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: FileSystem integration
https://bugs.webkit.org/show_bug.cgi?id=45982

Adding filesystem support for Inspector under storage tab. This fetches root paths for
temporary and persistent filesystems and allows "reveal folder in OS" option that
launches native file browser. Currently this feature is disabled for non-chromium platforms.

CMakeLists.txt:
English.lproj/localizedStrings.js:
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
inspector/CodeGeneratorInspector.pm:
inspector/Inspector.idl:
inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::releaseFrontendLifetimeAgents):
inspector/InspectorController.h: (WebCore::InspectorController::fileSystemAgent):
inspector/InspectorFileSystemAgent.cpp: Added.
inspector/InspectorFileSystemAgent.h: Added.
inspector/front-end/FileSystemView.js: Added.
inspector/front-end/Settings.js:
inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel): (WebInspector.StoragePanel.prototype.reset): (WebInspector.StoragePanel.prototype.addFileSystem): (WebInspector.StoragePanel.prototype.showFileSystem): (WebInspector.StoragePanel.prototype.updateFileSystemPath): (WebInspector.StoragePanel.prototype.updateFileSystemError): (WebInspector.FileSystemTreeElement): (WebInspector.FileSystemTreeElement.prototype.onselect):
inspector/front-end/WebKit.qrc:
inspector/front-end/inspector.css: (.file-system-storage-tree-item .icon):
inspector/front-end/inspector.html:
inspector/front-end/inspector.js: (WebInspector.updateResource): (WebInspector._addFileSystemOrigin): (WebInspector.didGetFileSystemPath): (WebInspector.didGetFileSystemError): (WebInspector.reset):
platform/AsyncFileSystem.h: (WebCore::AsyncFileSystem::root):
platform/FileSystem.h:
platform/chromium/ChromiumBridge.h:
platform/chromium/FileSystemChromium.cpp: (WebCore::revealFolderInOS):

2010-10-29 Kavita Kanetkar <kkanetkar@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: FileSystem integration
https://bugs.webkit.org/show_bug.cgi?id=45982

public/WebFileUtilities.h: (WebKit::WebFileUtilities::revealFolderInOS):
src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::revealFolderInOS):

4:53 PM Changeset in webkit [70955] by Martin Robinson

2 edits in trunk/WebKit/gtk

2010-10-29 Martin Robinson <mrobinson@igalia.com>

Build fix for GTK+ after BackForwardListImpl introduction.

webkit/webkitwebbackforwardlist.cpp: (webkit_web_back_forward_list_new_with_web_view):

4:45 PM Changeset in webkit [70954] by Adam Roben

8 edits in trunk/WebKit2

Stop using encode/decodeBytes for WebEvent subclasses

The use of encode/decodeBytes was making these classes sensitive to
differences in padding on different architectures (e.g., 32-bit vs.
64-bit). By encoding each data member explicitly we remove this
sensitivity, allowing these classes to be passed between processes
with different padding.

Fixes <http://webkit.org/b/48552> <rdar://problem/8606571> Mouse
events never reach Flash in WebKit2 on Mac (asserts in Debug builds)

Reviewed by Anders Carlsson.

Platform/CoreIPC/Arguments.h:

(CoreIPC::Arguments8::Arguments8):
(CoreIPC::Arguments8::encode):
(CoreIPC::Arguments8::decode):
(CoreIPC::In):
(CoreIPC::Out):
Added Arguments8, the biggest Arguments yet.

Shared/WebEvent.cpp:

(WebKit::WebEvent::encode):
(WebKit::WebEvent::decode):

Shared/WebKeyboardEvent.cpp:

(WebKit::WebKeyboardEvent::encode):
(WebKit::WebKeyboardEvent::decode):

Shared/WebMouseEvent.cpp:

(WebKit::WebMouseEvent::encode):
(WebKit::WebMouseEvent::decode):

Shared/WebPlatformTouchPoint.cpp:

(WebKit::WebPlatformTouchPoint::encode):
(WebKit::WebPlatformTouchPoint::decode):

Shared/WebTouchEvent.cpp:

(WebKit::WebTouchEvent::encode):
(WebKit::WebTouchEvent::decode):

Shared/WebWheelEvent.cpp:

(WebKit::WebWheelEvent::encode):
(WebKit::WebWheelEvent::decode):
Changed all encode/decode function to use CoreIPC::In/Out to
encode/decode data members individually.

4:44 PM Changeset in webkit [70953] by Adam Roben

2 edits in trunk/WebKit2

Use only CoreIPC-sanctioned types in WebEvent subclasses

Fixes <http://webkit.org//48694> WebEvent subclasses should not use
architecture-dependent types

Reviewed by Anders Carlsson.

Shared/WebEvent.h:

(WebKit::WebEvent::type):
(WebKit::WebMouseEvent::button):
(WebKit::WebMouseEvent::clickCount):
(WebKit::WebWheelEvent::granularity):
(WebKit::WebPlatformTouchPoint::id):
(WebKit::WebPlatformTouchPoint::state):
Replaced enums, ints, and unsigneds with uint32_ts, int32_ts, and
uint32_ts, respectively.

4:44 PM Changeset in webkit [70952] by andreas.kling@nokia.com

3 edits in trunk/LayoutTests

2010-10-29 Aaron Colwell <acolwell@chromium.org>

Reviewed by David Levin.

Disable media/video-canvas-alpha.html for Qt & GTK
https://bugs.webkit.org/show_bug.cgi?id=48688

platform/gtk/Skipped:
platform/qt/Skipped:

4:37 PM Changeset in webkit [70951] by andersca@apple.com

3 edits in trunk/WebKit2

Generate a DelayedReply struct for sync messages marked delayed
https://bugs.webkit.org/show_bug.cgi?id=48696

Reviewed by Adam Roben.

Scripts/webkit2/messages.py:

If we encounter a sync message marked delayed, generate a DelayedReply struct with a send member funciton
that can be used for sending the reply.

Scripts/webkit2/messages_unittest.py:

Update expected results.

4:34 PM Changeset in webkit [70950] by jamesr@google.com

89 edits
88 copies in trunk/LayoutTests

2010-10-29 James Robinson <jamesr@chromium.org>

Update Snow Leopard pixel baselines for tests in tables/mozilla pt 1

This updates the pixel baselines in platform/mac to be valid for Snow Leopard for tests
in tables/mozilla/collapsing_borders, /core, /dom, and /other. Old baselines moved to
platform/mac-leopard.

4:31 PM Changeset in webkit [70949] by dimich@chromium.org

3 edits in trunk/LayoutTests

[Chromium] Unreviewed, test expectations update.

platform/chromium-win/editing/deleting/5390681-2-expected.checksum:
platform/chromium-win/editing/deleting/5390681-2-expected.png:

4:24 PM Changeset in webkit [70948] by andreas.kling@nokia.com

2 edits in trunk/WebKit/qt

2010-10-29 Andreas Kling <kling@webkit.org>

Reviewed by Ariya Hidayat.

[Qt] QWebPage's InputMethod event handling calls ShortcutOverride handler too
https://bugs.webkit.org/show_bug.cgi?id=48692

Api/qwebpage.cpp: (QWebPage::event): Add missing break statement.

4:22 PM Changeset in webkit [70947] by andreas.kling@nokia.com

2 edits in trunk/WebKitTools

2010-10-29 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QtTestBrowser: Add keyboard shortcut to toggle full screen (F11)
https://bugs.webkit.org/show_bug.cgi?id=48695

QtTestBrowser/launcherwindow.cpp: (LauncherWindow::createChrome):

4:19 PM Changeset in webkit [70946] by andreas.kling@nokia.com

3 edits in trunk/WebKitTools

2010-10-29 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QtTestBrowser: Fix uninitialized read in FpsTimer
https://bugs.webkit.org/show_bug.cgi?id=48675

FpsTimer::m_timer was never initialized and passed to QObject::killTimer()
on startup with in -graphicsbased mode.

QtTestBrowser/fpstimer.cpp: (FpsTimer::FpsTimer): (FpsTimer::numFrames): (FpsTimer::stop): (FpsTimer::timerEvent):
QtTestBrowser/fpstimer.h:

4:15 PM Changeset in webkit [70945] by rniwa@webkit.org

8 edits in trunk

2010-10-29 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Remove RenderTextControl::setSelectionRange
https://bugs.webkit.org/show_bug.cgi?id=47870

Converted RenderTextControll::setSelectionRange to a global function.

Api/qwebpage.cpp: (QWebPagePrivate::inputMethodEvent): Calls setSelectionRange.

2010-10-29 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Remove RenderTextControl::setSelectionRange
https://bugs.webkit.org/show_bug.cgi?id=47870

Made RenderTextControl::setSelectionRange a global function.
Removed setSelectionStart, setSelectionEnd, and select from RenderTextControl.

No new tests are added since there is no behavioral change.

accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::setSelectedTextRange): Calls setSelectedTextRange.
dom/InputElement.cpp: (WebCore::InputElement::updateSelectionRange): Ditto.
html/HTMLFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::setSelectionStart): Ditto. (WebCore::HTMLTextFormControlElement::setSelectionEnd): Ditto. (WebCore::HTMLTextFormControlElement::select): Ditto. (WebCore::HTMLTextFormControlElement::setSelectionRange): Ditto.
rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::hasVisibleTextArea): Added. (WebCore::setSelectionRange): See above.
rendering/RenderTextControl.h:

3:48 PM Changeset in webkit [70944] by jamesr@google.com

191 edits
190 copies
1 add in trunk/LayoutTests

2010-10-29 James Robinson <jamesr@chromium.org>

Update pixel expectations for Snow Leopard for tests in tables/mozilla_expected_failures.

Moves the leopard-specific mac baselines to platform/mac-leopard/ and adds new Snow Leopard pixel
expectations for 96 tests that need them. List of files omitted due to length.

3:46 PM Changeset in webkit [70943] by dpranke@chromium.org

7 edits
1 copy
1 add in trunk/WebKitTools

2010-10-29 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

new-run-webkit-tests: change TestResults to be serializable

In preparation for changing new-run-webkit-tests from
multithreaded to multiprocess, we need to make sure the data
going between the threads is easily serialized over a socket.

This change adds serialization/pickling for the TestResults and
TestFailure objects (using cPickle).

The TestFailure objects included a "has_wdiff" flag for Text
results, but the flag wasn't being used, so I've removed it,
simplifying the state to basically a set of enum objects with
associated methods.

https://bugs.webkit.org/show_bug.cgi?id=48616

Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
Scripts/webkitpy/layout_tests/layout_package/test_results.py: Added.
Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:Added.
Scripts/webkitpy/layout_tests/run_webkit_tests.py:
Scripts/webkitpy/layout_tests/test_types/text_diff.py:

3:44 PM Changeset in webkit [70942] by dpranke@chromium.org

3 edits in trunk/WebKitTools

2010-10-29 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: need to provide separate dashboard results for GPU tests
https://bugs.webkit.org/show_bug.cgi?id=48687

Modify the steps to upload the JSON files to the dashboards so
that the GPU tests don't conflict with the regular tests on a
port. We do this by modifying the --builder-name parameter to
append " - GPU", which should cause the app to treat the results
as a completely new builder. This is a little non-obvious, but
keeps us from having to restructure the app.

Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
Scripts/webkitpy/layout_tests/run_webkit_tests.py:

3:39 PM Changeset in webkit [70941] by dimich@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectations update.

platform/chromium/test_expectations.txt:

3:36 PM Changeset in webkit [70940] by eric.carlson@apple.com

3 edits in trunk/LayoutTests

2010-10-29 Eric Carlson <eric.carlson@apple.com>

Reviewed by Adam Roben.

Results for media test controls-drag-timebar.html are needlessly platform specific
https://bugs.webkit.org/show_bug.cgi?id=48662

media/controls-drag-timebar-expected.txt:
media/controls-drag-timebar.html: Remove some of the logging to avoid timing differences on slower machines.

3:32 PM Changeset in webkit [70939] by Michael Nordman

4 edits in branches/chromium/552

Merge 70923 - 2010-10-28 Michael Nordman <Michael Nordman>

Reviewed by ap.

[Chrome] Fix an appcache regression introduced in r69226
https://bugs.webkit.org/show_bug.cgi?id=48592
Provide a noop method body ApplicationCacheHost::maybeLoadMainResourceForRedirect.

src/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::maybeLoadMainResourceForRedirect):

2010-10-28 Michael Nordman <Michael Nordman>

Reviewed by ap.

[Chrome] Fix an appcache regression introduced in r69226
https://bugs.webkit.org/show_bug.cgi?id=48592
Define a new ApplicationCacheHost method for the specific case of main resource redirect handling.

Tests: the existing layout test applies

loader/MainResourceLoader.cpp: use the newly introduced method (WebCore::MainResourceLoader::willSendRequest):
loader/appcache/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::maybeLoadMainResourceForRedirect):
loader/appcache/ApplicationCacheHost.h:

TBR=Michael Nordman

3:23 PM Changeset in webkit [70938] by Adam Roben

5 edits in trunk/LayoutTests

Update test results for the presence of HTMLMeterElement

platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
platform/win/fast/dom/prototype-inheritance-2-expected.txt:
platform/win/fast/dom/prototype-inheritance-expected.txt:
platform/win/fast/js/global-constructors-expected.txt:

3:23 PM Changeset in webkit [70937] by Adam Roben

2 edits
22 adds in trunk/LayoutTests

Stop skipping HTMLMeterElement tests on Windows and check in results for them

Fixes <http://webkit.org/b/48681>
fast/dom/HTMLMeterElement/meter-boundary-values.html fails on Windows

platform/win/Skipped: Removed HTMLMeterElement tests.

platform/win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum: Added.
platform/win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png: Added.
platform/win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt: Added.
platform/win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.checksum: Added.
platform/win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Added.
platform/win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt: Added.
platform/win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.checksum: Added.
platform/win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Added.
platform/win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt: Added.
platform/win/fast/dom/HTMLMeterElement/meter-element-expected.checksum: Added.
platform/win/fast/dom/HTMLMeterElement/meter-element-expected.png: Added.
platform/win/fast/dom/HTMLMeterElement/meter-element-expected.txt: Added.
platform/win/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum: Added.
platform/win/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Added.
platform/win/fast/dom/HTMLMeterElement/meter-optimums-expected.txt: Added.
platform/win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum: Added.
platform/win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png: Added.
platform/win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt: Added.
platform/win/fast/dom/HTMLMeterElement/meter-styles-expected.checksum: Added.
platform/win/fast/dom/HTMLMeterElement/meter-styles-expected.png: Added.
platform/win/fast/dom/HTMLMeterElement/meter-styles-expected.txt: Added.

3:16 PM Changeset in webkit [70936] by andersca@apple.com

8 edits in trunk/WebKit2

Use WebPage::send in a couple of more places.

Reviewed by Adam Roben.

WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::setWindowRect):
(WebKit::WebChromeClient::takeFocus):
(WebKit::WebChromeClient::setToolbarsVisible):
(WebKit::WebChromeClient::setStatusbarVisible):
(WebKit::WebChromeClient::setMenubarVisible):
(WebKit::WebChromeClient::setResizable):
(WebKit::WebChromeClient::setStatusbarText):
(WebKit::WebChromeClient::contentsSizeChanged):
(WebKit::WebChromeClient::mouseDidMoveOverElement):
(WebKit::WebChromeClient::setToolTip):
(WebKit::WebChromeClient::setCursor):
(WebKit::WebChromeClient::dispatchViewportDataDidChange):

WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::registerCommandForUndo):
(WebKit::WebEditorClient::clearUndoRedoOperations):

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::detachedFromParent2):
(WebKit::WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidReceiveTitle):
(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFailLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFinishLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFirstLayout):
(WebKit::WebFrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
(WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):
(WebKit::WebFrameLoaderClient::postProgressStartedNotification):
(WebKit::WebFrameLoaderClient::postProgressEstimateChangedNotification):
(WebKit::WebFrameLoaderClient::postProgressFinishedNotification):
(WebKit::WebFrameLoaderClient::didDisplayInsecureContent):
(WebKit::WebFrameLoaderClient::didRunInsecureContent):
(WebKit::WebFrameLoaderClient::dispatchDidBecomeFrameset):

WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::findString):
(WebKit::FindController::hideFindIndicator):

WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit::WebBackForwardListProxy::addItem):
(WebKit::WebBackForwardListProxy::goToItem):
(WebKit::WebBackForwardListProxy::clear):

WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::createMainFrame):
(WebKit::WebFrame::createSubframe):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::sendClose):
(WebKit::WebPage::pageDidScroll):
(WebKit::WebPage::mouseEvent):
(WebKit::WebPage::wheelEvent):
(WebKit::WebPage::keyEvent):
(WebKit::WebPage::validateMenuItem):
(WebKit::WebPage::touchEvent):
(WebKit::WebPage::show):
(WebKit::WebPage::runJavaScriptInMainFrame):
(WebKit::WebPage::getRenderTreeExternalRepresentation):
(WebKit::WebPage::getSourceForFrame):

3:15 PM Changeset in webkit [70935] by commit-queue@webkit.org

2 edits in trunk/WebCore

2010-10-29 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Andreas Kling.

[GTK] Crash in TextEncoding.cpp when using glib unicode
https://bugs.webkit.org/show_bug.cgi?id=48521

When the conversion to UTF-8 fails, try to encode the original string
without normalizing. Fixes tests cases:

fast/url/anchor.html
fast/url/query.html
fast/url/standard-url.html

platform/text/TextEncoding.cpp: (WebCore::TextEncoding::encode):

3:02 PM Changeset in webkit [70934] by andersca@apple.com

8 edits
1 add in trunk/WebKit2

Add a MessageSender class template
https://bugs.webkit.org/show_bug.cgi?id=48683

Reviewed by Adam Roben.

Platform/CoreIPC/MessageSender.h: Added.

(CoreIPC::MessageSender::send):
Add send overloads for simple message sending.

WebKit2.pro:
WebKit2.xcodeproj/project.pbxproj:

Add MessageSender.h

WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::countStringMatches):
(WebKit::FindController::findString):
(WebKit::FindController::updateFindIndicator):
Call send on the web page.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::connection):
Add connection(), used by the MessageSender.

WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::destinationID):
Add destinationID(), used by the MessageSender.

win/WebKit2.vcproj:

Add MessageSender.h

3:01 PM Changeset in webkit [70933] by benjamin.poulain@nokia.com

2 edits in trunk/WebCore

2010-10-29 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Antonio Gomes.

TextureMapperGL get the driver info log but do not use it
https://bugs.webkit.org/show_bug.cgi?id=48247

Remove the call to glGetProgramInfoLog().

platform/graphics/opengl/TextureMapperGL.cpp: (WebCore::TexmapShaderInfo::createShaderProgram):

2:47 PM Changeset in webkit [70932] by commit-queue@webkit.org

10 edits in trunk

2010-10-29 Benjamin Kalman <kalman@google.com>

Reviewed by Tony Chang.

Deleting contenteditable text to the left of a non-contenteditable span inserts unnecessary placeholder <br/>
https://bugs.webkit.org/show_bug.cgi?id=48658

editing/deleting/5390681-expected.txt: Update test for changed behaviour.
editing/deleting/5390681.html: Ditto (update comment).
editing/deleting/delete-mixed-editable-content-001-expected.txt: Ditto.
editing/pasteboard/copy-backslash-with-euc-expected.txt: Ditto.

2010-10-29 Benjamin Kalman <kalman@google.com>

Reviewed by Tony Chang.

Deleting contenteditable text to the left of a non-contenteditable span inserts unnecessary placeholder <br/>
https://bugs.webkit.org/show_bug.cgi?id=48658

WebCore.exp.in: Update is{Start,End}OfParagraph symbols.
editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::doApply): Cross editability boundaries when determining whether to insert placeholder.
editing/visible_units.cpp: Allow editability boundary to be crossed in {start,end,isStart,isEnd}OfParagraph. (WebCore::startOfParagraph): Also, avoid returning a position where renderer can't accept caret, like in endOfParagraph. (WebCore::endOfParagraph): (WebCore::isStartOfParagraph): (WebCore::isEndOfParagraph):
editing/visible_units.h: Ditto.

2:38 PM Changeset in webkit [70931] by Darin Adler

23 edits in trunk/WebKit