Timeline
Oct 31, 2010:
- 11:35 PM Changeset in webkit [71009] by
-
- 10 edits2 adds in trunk/WebCore
2010-10-26 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
Refactoring: Spellchecking related static functions could form a class
https://bugs.webkit.org/show_bug.cgi?id=48287
Extracted spellcheck related static functions to TextCheckingHelper class,
which has EditorClient and Range as its member.
No new tests. Just a refactoring.
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- editing/EditingAllInOne.cpp
- editing/Editor.cpp: (WebCore::Editor::advanceToNextMisspelling): (WebCore::Editor::isSelectionUngrammatical): (WebCore::Editor::guessesForUngrammaticalSelection): (WebCore::Editor::guessesForMisspelledOrUngrammaticalSelection): (WebCore::Editor::markMisspellingsAfterTypingToPosition): (WebCore::Editor::markMisspellingsOrBadGrammar): (WebCore::Editor::markMisspellings): (WebCore::Editor::markBadGrammar): (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): (WebCore::Editor::changeBackToReplacedString):
- editing/Editor.h:
- editing/TextCheckingHelper.cpp: Added. (WebCore::TextCheckingHelper::TextCheckingHelper): (WebCore::TextCheckingHelper::~TextCheckingHelper): (WebCore::TextCheckingHelper::paragraphAlignedRange): (WebCore::TextCheckingHelper::findFirstMisspelling): (WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar): (WebCore::TextCheckingHelper::findFirstGrammarDetail): (WebCore::TextCheckingHelper::findFirstBadGrammar): (WebCore::TextCheckingHelper::isUngrammatical): (WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange): (WebCore::TextCheckingHelper::markAllMisspellings): (WebCore::TextCheckingHelper::markAllBadGrammar):
- editing/TextCheckingHelper.h: Added.
- 9:21 PM Changeset in webkit [71008] by
-
- 2 edits in trunk/WebCore
2010-10-31 Xan Lopez <xlopez@igalia.com>
Try to fix the GTK+ build.
Do not use broken/deprecated functions that won't be available
with G_DISABLE_DEPRECATED (used in debug builds).
- plugins/gtk/PluginPackageGtk.cpp: (WebCore::PluginPackage::fetchInfo):
- 7:54 PM Changeset in webkit [71007] by
-
- 2 edits in trunk/WebCore
2010-10-31 Kenichi Ishibashi <bashi@google.com>
Reviewed by Adam Barth.
V8 binding for DOMSettableTokenList
https://bugs.webkit.org/show_bug.cgi?id=47812
Tests for this change will be included in the change for supporting
the <output> element.
See https://bugs.webkit.org/show_bug.cgi?id=29363.
- bindings/v8/custom/V8DOMSettableTokenListCustom.cpp: Implemented. (WebCore::V8DOMSettableTokenList::indexedPropertyGetter): Just calls DOMSettableTokenList::item(index).
- 7:48 PM Changeset in webkit [71006] by
-
- 5 edits in trunk
2010-10-31 Robert Hogan <robert@webkit.org>
Reviewed by Antonio Gomes.
[Qt] [Gtk] Plug-ins having upper case in mime type are failing to load
Qt and Gtk are case-sensitive when storing the declared mime-type
of plugins. Since plugin mime-types are lowercased prior to searching
for them in the plugin database, ensure they are loaded with the
mime-type in lower case too.
- plugins/gtk/PluginPackageGtk.cpp: (WebCore::PluginPackage::fetchInfo):
- plugins/qt/PluginPackageQt.cpp: (WebCore::PluginPackage::setMIMEDescription):
2010-10-31 Robert Hogan <robert@webkit.org>
Reviewed by Antonio Gomes.
[Qt] [Gtk] Plug-ins having upper case in mime type are failing to load
Qt and Gtk are case-sensitive when storing the declared mime-type
of plugins. Since plugin mime-types are lowercased prior to searching
for them in the plugin database, ensure they are loaded with the
mime-type in lower case too.
Change the test netscape plugin to declare its mimetype in sentence
case so that the correct behaviour is enforced.
- DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (NP_GetMIMEDescription):
- 7:37 PM Changeset in webkit [71005] by
-
- 1 edit4 adds in trunk/LayoutTests
2010-10-31 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Ojan Vafai.
Add layout test to make sure we don't regress truncation of an rtl block.
- fast/block/basic/truncation-rtl.html: Added.
- platform/mac/fast/block/basic/truncation-rtl-expected.checksum: Added.
- platform/mac/fast/block/basic/truncation-rtl-expected.png: Added.
- platform/mac/fast/block/basic/truncation-rtl-expected.txt: Added.
- 7:30 PM Changeset in webkit [71004] by
-
- 10 edits in trunk
2010-10-31 Robert Hogan <robert@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Support nodesFromRect in DRT
Unskip fast/dom/nodesFromRect-basic.html
- platform/qt/Skipped:
2010-10-31 Robert Hogan <robert@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Support nodesFromRect in DRT
Pass a Document object as a QWebElement.
- bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertValueToQVariant):
2010-10-31 Robert Hogan <robert@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Support nodesFromRect in DRT
- WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::nodesFromRect):
- WebCoreSupport/DumpRenderTreeSupportQt.h:
2010-10-31 Robert Hogan <robert@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Support nodesFromRect in DRT
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::nodesFromRect):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- 7:20 PM Changeset in webkit [71003] by
-
- 2 edits in trunk/LayoutTests
2010-10-31 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Antonio Gomes.
[GTK] Add bug ID for skipped <meter> tests
https://bugs.webkit.org/show_bug.cgi?id=48714
- platform/gtk/Skipped:
- 7:17 PM Changeset in webkit [71002] by
-
- 5 edits in trunk/LayoutTests
2010-10-31 Mike Lawther <mikelawther@chromium.org>
Reviewed by Andreas Kling.
unskip canvas/philip/tests/2d.imageData.get.source.negative on all ports
https://bugs.webkit.org/show_bug.cgi?id=48702
- platform/chromium-gpu/test_expectations.txt:
- platform/gtk/Skipped:
- platform/mac-leopard/Skipped:
- platform/qt/Skipped:
- 7:04 PM Changeset in webkit [71001] by
-
- 3 edits6 adds in trunk
2010-10-31 Peter Kasting <pkasting@google.com>
Reviewed by Adam Barth.
Treat GIFs with no loop count as "loop once".
https://bugs.webkit.org/show_bug.cgi?id=47302
- fast/images/gif-loop-count-expected.checksum: Added.
- fast/images/gif-loop-count-expected.png: Added.
- fast/images/gif-loop-count-expected.txt: Added.
- fast/images/gif-loop-count.html: Added.
- fast/images/resources/gif-loop-count.gif: Added.
- fast/images/resources/gif-loop-count.png: Added.
2010-10-31 Peter Kasting <pkasting@google.com>
Reviewed by Adam Barth.
Treat GIFs with no loop count as "loop once".
https://bugs.webkit.org/show_bug.cgi?id=47302
Test: fast/images/gif-loop-count.html
- platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::repetitionCount): (WebCore::GIFImageDecoder::gifComplete):
- 6:39 PM Changeset in webkit [71000] by
-
- 2 edits in trunk/WebCore
2010-10-31 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Andreas Kling.
[Texmap] [Qt] Texture mapper initial implementation
https://bugs.webkit.org/show_bug.cgi?id=47070
Build fix for X11.
No new tests; build fix.
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::invalidateRect): (WebCore::PluginView::platformStart):
- 1:42 PM Changeset in webkit [70999] by
-
- 2 edits in trunk/WebKit/qt
2010-10-31 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Short-circuit QWebPage::selectedText() if frame has no selection
https://bugs.webkit.org/show_bug.cgi?id=48736
Do an early return if the selection is empty.
No new tests, this is covered by tst_QWebPage::findText().
- Api/qwebpage.cpp: (QWebPage::selectedText):
- 1:33 PM Changeset in webkit [70998] by
-
- 2 edits1 add in trunk/LayoutTests
2010-10-31 James Simonsen <simonjam@chromium.org>
Reviewed by Andreas Kling.
Rebaseline a fast/dynamic LayoutTest for Chromium Linux
fast/dynamic/positioned-movement-with-positioned-children.html exposes
a change to the defult button style on Linux.
Prior to bug 26030, buttons were always drawn as #dddddd, regardless of
what the style said. The default style had been #c0c0c0. With the fix,
buttons now honor the style sheet, but in order to maintain
consistency, the default style for Linux was changed to #dddddd.
This patch updates the test to reflect the newer Linux button style.
- platform/chromium-linux/fast/dynamic/positioned-movement-with-positioned-children-expected.txt: Added.
- platform/chromium/test_expectations.txt: Removed rebaselined test.
- 1:20 PM Changeset in webkit [70997] by
-
- 4 edits in trunk/WebKit2
2010-10-31 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Visited links not populated correctly in new web processes after the first
https://bugs.webkit.org/show_bug.cgi?id=48735
rdar://problem/8442177
- UIProcess/VisitedLinkProvider.cpp: (WebKit::VisitedLinkProvider::VisitedLinkProvider): Initialize m_webProcessHasVisitedLinkState. (WebKit::VisitedLinkProvider::processDidFinishLaunching): Renamed from populateVisitedLinksIfNeeded. Set m_webProcessHasVisitedLinkState to false, since this is a new process, and also start the timer so the visited links messages will be sent. (WebKit::VisitedLinkProvider::processDidClose): Renamed from stopVisitedLinksTimer. (WebKit::VisitedLinkProvider::pendingVisitedLinksTimerFired): Added logic so we send SetVisitedLinkTable and AllVisitedLinkStateChanged once to each new process and to set m_webProcessHasVisitedLinkState to true once that is done.
- UIProcess/VisitedLinkProvider.h: Updated for above changes.
- UIProcess/WebContext.cpp: (WebKit::WebContext::processDidFinishLaunching): Called VisitedLinkProvider function under its new name. Also used ASSERT_UNUSED rather than ASSERT since the argument is used only for the assertion. (WebKit::WebContext::processDidClose): Ditto.
- 12:32 PM Changeset in webkit [70996] by
-
- 10 edits in trunk/WebCore
2010-10-31 Andreas Kling <kling@webkit.org>
Reviewed by Dirk Schulze.
Remove the unused GraphicsContext::clipOutEllipseInRect(IntRect)
https://bugs.webkit.org/show_bug.cgi?id=48727
This function was added in <http://trac.webkit.org/changeset/18654> for CSS3 box-shadows.
All use of the function was removed in <http://trac.webkit.org/changeset/21601>
- platform/graphics/GraphicsContext.h:
- platform/graphics/cairo/GraphicsContextCairo.cpp:
- platform/graphics/cg/GraphicsContextCG.cpp:
- platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::clipOut):
- platform/graphics/openvg/GraphicsContextOpenVG.cpp:
- platform/graphics/qt/GraphicsContextQt.cpp:
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::clipOut):
- platform/graphics/wince/GraphicsContextWinCE.cpp:
- platform/graphics/wx/GraphicsContextWx.cpp:
- 12:30 PM Changeset in webkit [70995] by
-
- 2 edits in trunk/WebCore
2010-10-31 Andreas Kling <kling@webkit.org>
Reviewed by Dirk Schulze.
[Qt] Respect the "antialiased" argument in clipConvexPolygon()
https://bugs.webkit.org/show_bug.cgi?id=48734
Set (or unset) the QPainter::Antialiased render hint for antialiased
clipping based on the "antialiased" argument.
No test since Qt doesn't have pixel tests yet.
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::clipConvexPolygon):
- 12:02 PM Changeset in webkit [70994] by
-
- 3 edits in trunk/WebCore
2010-10-31 Andreas Kling <kling@webkit.org>
Reviewed by Dirk Schulze.
Remove the unused GraphicsContext::strokeRect(FloatRect)
https://bugs.webkit.org/show_bug.cgi?id=48726
This function was only implemented by GraphicsContextOpenVG and not
called from anywhere.
- platform/graphics/GraphicsContext.h:
- platform/graphics/openvg/GraphicsContextOpenVG.cpp:
- 11:59 AM Changeset in webkit [70993] by
-
- 7 edits in trunk/WebCore
2010-10-31 Andreas Kling <kling@webkit.org>
Reviewed by Dirk Schulze.
Remove the unused GraphicsContext::origin()
https://bugs.webkit.org/show_bug.cgi?id=48732
This method was not called from anywhere.
- platform/graphics/GraphicsContext.h:
- platform/graphics/cairo/GraphicsContextCairo.cpp:
- platform/graphics/haiku/GraphicsContextHaiku.cpp:
- platform/graphics/openvg/GraphicsContextOpenVG.cpp:
- platform/graphics/qt/GraphicsContextQt.cpp:
- platform/graphics/wince/GraphicsContextWinCE.cpp:
- 11:57 AM Changeset in webkit [70992] by
-
- 4 edits in trunk/WebCore
2010-10-31 Andreas Kling <kling@webkit.org>
Reviewed by Dirk Schulze.
[Qt] Remove GraphicsContext::pen()
https://bugs.webkit.org/show_bug.cgi?id=48733
Have PathQt obtain the pen() through the platformContext() instead.
- platform/graphics/GraphicsContext.h:
- platform/graphics/qt/GraphicsContextQt.cpp:
- platform/graphics/qt/PathQt.cpp: (WebCore::Path::strokeContains): (WebCore::Path::strokeBoundingRect):
- 10:33 AM Changeset in webkit [70991] by
-
- 25 edits4 deletes in trunk
2010-10-31 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r70959.
http://trac.webkit.org/changeset/70959
https://bugs.webkit.org/show_bug.cgi?id=48731
It broke fast/events/spatial-navigation tests (Requested by
Ossy on #webkit).
- WebCore.xcodeproj/project.pbxproj:
- rendering/InlineBox.cpp: (WebCore::InlineBox::adjustForFlippedBlocksWritingMode):
- rendering/InlineFlowBox.h: (WebCore::InlineFlowBox::bottomLayoutOverflow): (WebCore::InlineFlowBox::rightLayoutOverflow): (WebCore::InlineFlowBox::bottomVisualOverflow): (WebCore::InlineFlowBox::rightVisualOverflow):
- rendering/RenderBox.cpp:
- rendering/RenderBox.h:
- rendering/RenderInline.cpp: (WebCore::RenderInline::linesBoundingBox): (WebCore::RenderInline::linesVisibleOverflowBoundingBox): (WebCore::RenderInline::clippedOverflowRectForRepaint):
- rendering/RenderText.cpp: (WebCore::RenderText::linesBoundingBox):
2010-10-31 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r70959.
http://trac.webkit.org/changeset/70959
https://bugs.webkit.org/show_bug.cgi?id=48731
It broke fast/events/spatial-navigation tests (Requested by
Ossy on #webkit).
- fast/repaint/inline-vertical-rl-overflow.html: Removed.
- platform/mac/fast/blockflow/background-vertical-lr-expected.txt:
- platform/mac/fast/blockflow/background-vertical-rl-expected.txt:
- platform/mac/fast/blockflow/basic-vertical-line-expected.txt:
- platform/mac/fast/blockflow/border-image-vertical-lr-expected.txt:
- platform/mac/fast/blockflow/border-image-vertical-rl-expected.txt:
- platform/mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.txt:
- platform/mac/fast/blockflow/border-vertical-lr-expected.checksum:
- platform/mac/fast/blockflow/border-vertical-lr-expected.png:
- platform/mac/fast/blockflow/border-vertical-lr-expected.txt:
- platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.txt:
- platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.txt:
- platform/mac/fast/blockflow/english-lr-text-expected.txt:
- platform/mac/fast/blockflow/english-rl-text-expected.txt:
- platform/mac/fast/blockflow/japanese-lr-text-expected.txt:
- platform/mac/fast/blockflow/japanese-rl-text-expected.txt:
- platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.checksum: Removed.
- platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.png: Removed.
- platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.txt: Removed.
- platform/mac/fast/text/international/vertical-text-glyph-test-expected.txt:
- 9:04 AM Changeset in webkit [70990] by
-
- 1 edit1 add in trunk/LayoutTests
2010-10-31 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed.
Convert SVGAnimatedNumber/SVGAnimatedNumberList to the new SVGAnimatedPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=48686
Forgot to land SVGAnimatedNumber.js, fails on all bots. Thanks Darin for noticing.
- svg/dom/script-tests/SVGAnimatedNumber.js: Added.
Oct 30, 2010:
- 11:43 PM Changeset in webkit [70989] by
-
- 6 edits in trunk/WebCore
2010-10-30 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: new resources and network panel usability improvements.
https://bugs.webkit.org/show_bug.cgi?id=48680
By default, navigation clears network log, added 'preserve log' button,
that prevents log from being cleared.
Storing expanded state of all group items, restoring last selected item,
fall back to main frame's main resource by default.
Do not list XHRs and redirects in resources.
- English.lproj/localizedStrings.js:
- inspector/InspectorController.cpp: (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest):
- inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.get statusBarItems): (WebInspector.NetworkPanel.prototype._positionSummaryBar): (WebInspector.NetworkPanel.prototype._updateFilter): (WebInspector.NetworkPanel.prototype._createStatusbarButtons): (WebInspector.NetworkPanel.prototype._onPreserveLogClicked): (WebInspector.NetworkPanel.prototype.reset): (WebInspector.NetworkPanel.prototype.refreshResource):
- inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager.prototype.identifierForInitialRequest): (WebInspector.ResourceManager.prototype.willSendRequest): (WebInspector.ResourceManager.prototype.didLoadResourceFromMemoryCache): (WebInspector.ResourceManager.prototype.setOverrideContent): (WebInspector.ResourceManager.prototype.didCreateWebSocket):
- inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel): (WebInspector.StoragePanel.prototype.show): (WebInspector.StoragePanel.prototype._initDefaultSelection): (WebInspector.StoragePanel.prototype.reset): (WebInspector.StoragePanel.prototype.addResourceToFrame): (WebInspector.StoragePanel.prototype.refreshResource): (WebInspector.StoragePanel.prototype.showDatabase): (WebInspector.BaseStorageTreeElement.prototype.onselect): (WebInspector.StorageCategoryTreeElement): (WebInspector.StorageCategoryTreeElement.prototype.get itemURL): (WebInspector.StorageCategoryTreeElement.prototype.onselect): (WebInspector.StorageCategoryTreeElement.prototype.onattach): (WebInspector.StorageCategoryTreeElement.prototype.onexpand): (WebInspector.StorageCategoryTreeElement.prototype.oncollapse): (WebInspector.FrameTreeElement.prototype.get itemURL): (WebInspector.FrameTreeElement.prototype.onselect): (WebInspector.FrameResourceTreeElement.prototype.get itemURL): (WebInspector.FrameResourceTreeElement.prototype.onselect): (WebInspector.DatabaseTreeElement.prototype.get itemURL): (WebInspector.DatabaseTreeElement.prototype.onselect): (WebInspector.DatabaseTableTreeElement.prototype.get itemURL): (WebInspector.DatabaseTableTreeElement.prototype.onselect): (WebInspector.DOMStorageTreeElement.prototype.get itemURL): (WebInspector.DOMStorageTreeElement.prototype.onselect): (WebInspector.CookieTreeElement.prototype.get itemURL): (WebInspector.CookieTreeElement.prototype.onselect): (WebInspector.ApplicationCacheTreeElement.prototype.get itemURL): (WebInspector.ApplicationCacheTreeElement.prototype.onselect):
- 4:08 PM Changeset in webkit [70988] by
-
- 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl
2010-10-30 Antonio Gomes <agomes@rim.com>
Unreviewed Windows bots build fix (take I).
Touching WebKit.idl to try forcing a clean build.
- Interfaces/WebKit.idl:
- 2:00 PM Changeset in webkit [70987] by
-
- 1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/config.json
William Siegrist <wsiegrist@apple.com>
Change trigger name to match builder name change in r70871.
- 12:31 PM Changeset in webkit [70986] by
-
- 4 edits in trunk
2010-10-30 Patrick Gansterer <Patrick Gansterer>
Unreviewed, build fix after r70846.
- platform/graphics/wince/ImageWinCE.cpp: (WebCore::RGBA32Buffer::asNewNativeImage):
2010-10-30 Patrick Gansterer <Patrick Gansterer>
Unreviewed, build fix after r70574.
- WebCoreSupport/FrameLoaderClientWinCE.cpp: (WebKit::FrameLoaderClientWinCE::transferLoadingResourceFromPage):
- 11:48 AM Changeset in webkit [70985] by
-
- 19 edits4 deletes in trunk
2010-10-30 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, rolling out r70984.
http://trac.webkit.org/changeset/70984
https://bugs.webkit.org/show_bug.cgi?id=46015
Made media/audio-delete-while-slider-thumb-clicked.html crash.
- fast/events/shadow-boundary-crossing.html:
2010-10-30 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, rolling out r70984.
http://trac.webkit.org/changeset/70984
https://bugs.webkit.org/show_bug.cgi?id=46015
Made media/audio-delete-while-slider-thumb-clicked.html crash.
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.xcodeproj/project.pbxproj:
- dom/ContainerNode.cpp: (WebCore::notifyChildInserted):
- dom/EventContext.cpp: Removed.
- dom/EventContext.h: Removed.
- dom/Node.cpp: (WebCore::Node::markAncestorsWithChildNeedsStyleRecalc): (WebCore::Node::createRendererIfNeeded): (WebCore::Node::eventParentNode): (WebCore::Node::enclosingLinkEventParentOrSelf): (WebCore::eventTargetAsSVGElementInstance): (WebCore::eventTargetRespectingSVGTargetRules): (WebCore::Node::eventAncestors): (WebCore::Node::dispatchGenericEvent):
- dom/Node.h:
- dom/Text.cpp: (WebCore::Text::createRenderer):
- dom/WindowEventContext.cpp: Removed.
- dom/WindowEventContext.h: Removed.
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getEventListenersForNode):
- inspector/InspectorInstrumentation.cpp: (WebCore::eventHasListeners): (WebCore::InspectorInstrumentation::willDispatchEventImpl):
- inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::willDispatchEvent):
- page/EventHandler.cpp: (WebCore::EventHandler::updateMouseEventTargetNode):
- svg/SVGElement.cpp: (WebCore::SVGElement::eventParentNode):
- svg/SVGElement.h:
- 10:32 AM Changeset in webkit [70984] by
-
- 19 edits4 adds in trunk
2010-10-30 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Adler.
Implement shadow DOM-aware event targeting and introduce EventContext to track the context of each event dispatch.
https://bugs.webkit.org/show_bug.cgi?id=46015
Tuned the test to better reflect its point: the event should indeed fire (it used to be swallowed),
but its target should be a non-shadow node.
- fast/events/shadow-boundary-crossing.html: Modified the test.
2010-10-30 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Adler.
Implement shadow DOM-aware event targeting and introduce EventContext to track the context of each event dispatch.
https://bugs.webkit.org/show_bug.cgi?id=46015
This patch adds the notion of EventContext (and a very similar-acting WindowEventContext, specifically
for DOMWindow), an abstraction that carries information around dispatching an event for any given Node.
This abstraction is necessary to ensure that events, fired from shadow DOM nodes are properly retargeted to
appear as if they are coming from their host, thus never exposing the shadow DOM nodes to the world outside.
- Android.mk: Added EventContext, WindowEventContext files.
- CMakeLists.txt: Ditto.
- GNUmakefile.am: Ditto.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- dom/ContainerNode.cpp: (WebCore::notifyChildInserted): Changed to be shadow DOM-aware.
- dom/EventContext.cpp: Added.
- dom/EventContext.h: Added.
- dom/Node.cpp: (WebCore::Node::markAncestorsWithChildNeedsStyleRecalc): Changed to be shadow DOM-aware. (WebCore::Node::createRendererIfNeeded): Ditto. (WebCore::Node::parentOrHostNode): Added new helper method. (WebCore::Node::enclosingLinkEventParentOrSelf): Changed to be shadow DOM-aware. (WebCore::eventTargetRespectingSVGTargetRules): Collapsed two helper methods into one. (WebCore::Node::eventAncestors): Refactored to collect a vector of EventContexts. (WebCore::Node::topEventContext): Added. (WebCore::eventHasListeners): Changed to use EventContexts. (WebCore::Node::dispatchGenericEvent): Ditto.
- dom/Node.h: Removed eventParentNode that's no longer needed, added parentOrHostNode decl,
and changed signature of eventAncestors to use EventContexts.
- dom/Text.cpp: (WebCore::Text::createRenderer): Changed to be shadow DOM-aware.
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getEventListenersForNode): Changed to use EventContexts.
- page/EventHandler.cpp: (WebCore::EventHandler::updateMouseEventTargetNode): Removed code that's no longer necessary.
- svg/SVGElement.cpp: Removed eventParentNode that's no longer needed.
- svg/SVGElement.h: Ditto.
- dom/WindowEventContext.cpp: Added.
- dom/WindowEventContext.h: Added.
- 8:17 AM Changeset in webkit [70983] by
-
- 2 edits in trunk/WebKit/gtk
2010-10-30 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Use new width for height APIs in GTK+ 3.x
https://bugs.webkit.org/show_bug.cgi?id=48709
Use the new width for height APIs in GTK+ 3.x, since size-request
is deprecated.
For now we just return the same value for preferred and minimum
width/height, which should match the 2.x behavior. Probably we
could do something smarter for the minimum values.
- webkit/webkitwebview.cpp: (webkit_web_view_get_preferred_width): return our preferred width. (webkit_web_view_get_preferred_height): return our preferred height. (webkit_web_view_class_init): hook the new default handlers.
- 7:51 AM Changeset in webkit [70982] by
-
- 2 edits in trunk/WebKit/qt
2010-10-30 Andreas Kling <kling@webkit.org>
Reviewed by Antonio Gomes.
[Qt] IM: Don't manipulate selection via RenderTextControl
https://bugs.webkit.org/show_bug.cgi?id=48700
Go directly through the Frame's SelectionController instead.
No new tests, this is covered by tst_QWebPage::inputMethods.
- Api/qwebpage.cpp: (QWebPagePrivate::inputMethodEvent): (QWebPage::inputMethodQuery):
- 7:49 AM Changeset in webkit [70981] by
-
- 2 edits in trunk/WebKit2
2010-10-30 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt][WK2] Crash in drawUpdateChunkIntoBackingStore
https://bugs.webkit.org/show_bug.cgi?id=48707
UpdateChunk images have to be created using the QImage constructor
that takes a bytesPerLine (stride) value, or the data length won't
match UpdateChunk::size().
- Shared/qt/UpdateChunk.cpp: (WebKit::UpdateChunk::createImage):
- 7:48 AM Changeset in webkit [70980] by
-
- 3 edits in trunk/WebKitTools
2010-10-30 Andreas Kling <kling@webkit.org>
Reviewed by Antonio Gomes.
[Qt] QtTestBrowser: Switching view type moves the embedded inspector
https://bugs.webkit.org/show_bug.cgi?id=48705
Reinsert the embedded inspector into the splitter after changing
between QWebView/QGraphicsWebView.
- QtTestBrowser/launcherwindow.cpp: (LauncherWindow::init): (LauncherWindow::initializeView):
- QtTestBrowser/webinspector.h: (WebInspector::WebInspector):
- 6:23 AM Changeset in webkit [70979] by
-
- 50 edits10 adds in trunk
2010-10-30 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Rob Buis.
Convert SVGAnimatedNumber/SVGAnimatedNumberList to the new SVGAnimatedPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=48686
Convert the next set of primitives to use the new SVG(Animated)PropertyTearOff concept.
Tests: svg/dom/SVGAnimatedNumber.html
svg/dom/SVGAnimatedNumberList.html
svg/dom/SVGNumber.html
- GNUmakefile.am: Add SVGAnimatedNumber.h / SVGAnimatedNumberList.h to build.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- bindings/scripts/CodeGenerator.pm: Recognize SVGAnimatedNumber/SVGAnimatedNumberList as new style SVG animated properties. Remove SVGNumber from PODType hash.
- bindings/scripts/CodeGeneratorJS.pm: Remove special SVGNumber handing, it's obsolete now.
- bindings/scripts/CodeGeneratorObjC.pm: Add special SVGNumber handling, as it's the first of the converted dynamic SVGAnimatedProperty types that's not in WebCore namespace.
- bindings/scripts/CodeGeneratorV8.pm: Use AvoidInclusionOfType method from CodeGenerator.pm, remove special SVGNumber handling, that's obsolete now.
- rendering/svg/SVGTextLayoutAttributesBuilder.cpp: (WebCore::extractFloatValuesFromSVGNumberList): Adapt to SVGNumberList change, which is a plain Vector<float> now.
- svg/DeprecatedSVGAnimatedPropertyTraits.h: Remove SVGAnimatedNumber/SVGAnimatedNumberList handling.
- svg/DeprecatedSVGAnimatedTemplate.h: Ditto.
- svg/SVGAnimatedNumber.h: Added.
- svg/SVGAnimatedNumber.idl: Enable StrictTypeChecking.
- svg/SVGAnimatedNumberList.h: Added.
- svg/SVGAnimatedNumberList.idl: Ditto.
- svg/SVGComponentTransferFunctionElement.cpp: Switch animated float properties to the new SVGAnimatedNumber(List). (WebCore::SVGComponentTransferFunctionElement::SVGComponentTransferFunctionElement): (WebCore::SVGComponentTransferFunctionElement::parseMappedAttribute): (WebCore::SVGComponentTransferFunctionElement::transferFunction):
- svg/SVGComponentTransferFunctionElement.h:
- svg/SVGFEColorMatrixElement.cpp: Ditto. (WebCore::SVGFEColorMatrixElement::SVGFEColorMatrixElement): (WebCore::SVGFEColorMatrixElement::parseMappedAttribute): (WebCore::SVGFEColorMatrixElement::build):
- svg/SVGFEColorMatrixElement.h:
- svg/SVGFECompositeElement.h: Ditto.
- svg/SVGFEConvolveMatrixElement.cpp: Ditto. (WebCore::SVGFEConvolveMatrixElement::SVGFEConvolveMatrixElement): (WebCore::SVGFEConvolveMatrixElement::kernelUnitLengthXIdentifier): Added, replacing char[] hack by a static atomic string. (WebCore::SVGFEConvolveMatrixElement::kernelUnitLengthYIdentifier): Ditto. (WebCore::SVGFEConvolveMatrixElement::parseMappedAttribute): (WebCore::SVGFEConvolveMatrixElement::build):
- svg/SVGFEConvolveMatrixElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
- svg/SVGFEDiffuseLightingElement.cpp: Ditto. (WebCore::SVGFEDiffuseLightingElement::kernelUnitLengthXIdentifier): Remove trailing whitespace. (WebCore::SVGFEDiffuseLightingElement::kernelUnitLengthYIdentifier): Ditto.
- svg/SVGFEDiffuseLightingElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
- svg/SVGFEDisplacementMapElement.h: Ditto.
- svg/SVGFEGaussianBlurElement.cpp: Ditto. (WebCore::SVGFEGaussianBlurElement::stdDeviationXIdentifier): Remove trailing whitespace. (WebCore::SVGFEGaussianBlurElement::stdDeviationYIdentifier): Ditto.
- svg/SVGFEGaussianBlurElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
- svg/SVGFELightElement.h: Ditto.
- svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::radiusXIdentifier): Added, replacing char[] hack by a static atomic string. (WebCore::SVGFEMorphologyElement::radiusYIdentifier): Ditto.
- svg/SVGFEMorphologyElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
- svg/SVGFEOffsetElement.h: Ditto.
- svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::kernelUnitLengthXIdentifier): Remove trailing whitespace. (WebCore::SVGFESpecularLightingElement::kernelUnitLengthYIdentifier): Ditto.
- svg/SVGFESpecularLightingElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
- svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::baseFrequencyXIdentifier): Remove trailing whitespace. (WebCore::SVGFETurbulenceElement::baseFrequencyYIdentifier): Ditto.
- svg/SVGFETurbulenceElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
- svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::filterResXIdentifier): Remove trailing whitespace. (WebCore::SVGFilterElement::filterResYIdentifier): Ditto.
- svg/SVGLengthList.idl: Remove leftover [SVGListProperty] marker.
- svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::orientTypeIdentifier): Remove trailing whitespace. (WebCore::SVGMarkerElement::orientAngleIdentifier): Ditto.
- svg/SVGNumber.idl: Remove [PODType] marker, add StrictTypeChecking.
- svg/SVGNumberList.cpp: Convert from SVGPODList<RefPtr<SVGPODListItem<float> > > to plain Vector<float>, just like it has been done for SVGLengthList before. (WebCore::SVGNumberList::parse): (WebCore::SVGNumberList::valueAsString):
- svg/SVGNumberList.h: (WebCore::SVGNumberList::SVGNumberList):
- svg/SVGPathElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
- svg/SVGStopElement.h: Ditto.
- svg/SVGTextPositioningElement.cpp: Switch animated float properties to the new SVGAnimatedNumber(List). (WebCore::SVGTextPositioningElement::SVGTextPositioningElement): (WebCore::SVGTextPositioningElement::parseMappedAttribute):
- svg/SVGTextPositioningElement.h: Ditto.
- svg/properties/SVGPropertyTraits.h: Add SVGNumberList handling.
2010-10-30 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Rob Buis.
Convert SVGAnimatedNumber/SVGAnimatedNumberList to the new SVGAnimatedPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=48686
Fix invalid tests in svg/dynamic-updates, that relied on a bug in our SVGNumberList implementation. If an item was already
inserted in a list, and we tried to insert it somewhere else, we didn't remove it from the old list. Now that SVGNumberList
has been switched to SVGAnimatedListPropertyTearOff, the bug is fixed, and it behaves exactly like SVGLengthList.
Side effect: svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop.html now works as expected (dynamic update is executed)
- platform/mac-leopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.checksum:
- platform/mac-leopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png:
- svg/dom/SVGAnimatedNumber-expected.txt: Added.
- svg/dom/SVGAnimatedNumber.html: Added.
- svg/dom/SVGAnimatedNumberList-expected.txt: Added.
- svg/dom/SVGAnimatedNumberList.html: Added.
- svg/dom/SVGNumber-expected.txt: Added.
- svg/dom/SVGNumber.html: Added.
- svg/dom/script-tests/SVGAnimatedNumber.js: Added.
- svg/dom/script-tests/SVGAnimatedNumberList.js: Added.
- svg/dom/script-tests/SVGNumber.js: Added.
- svg/dynamic-updates/script-tests/SVGFEColorMatrixElement-svgdom-type-prop.js: Test now works in Firefox as well. (executeTest): SVGNumber.value only accepts numbers, not strings, now that StrictTypeChecking is enabled.
- svg/dynamic-updates/script-tests/SVGFEColorMatrixElement-svgdom-values-prop.js: Test now works in Firefox as well. (executeTest): Don't call appendItem several times with the same SVGNumber, it will be removed if it was already inserted in a list.
- svg/dynamic-updates/script-tests/SVGFETurbulenceElement-svgdom-baseFrequency-prop.js:
- 1:59 AM Changeset in webkit [70978] by
-
- 5 edits in trunk/LayoutTests
2010-10-30 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed.
Update SVGFEFloodElement mac-leopard baseline, which was forgotten.
- platform/mac-leopard/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.checksum:
- platform/mac-leopard/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png:
- platform/mac-leopard/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.checksum:
- platform/mac-leopard/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png:
