Context Navigation

This change introduces three new functions;
validationMessageTypeMismatchFor*Text(). The implementation for each
platform is just a call to validationMessageTypeMismatchText().

Some validationMessage*() functions have new parameters. The parameters
are ignored in all platforms for now.

This change doesn't change any behavior. However a platform can add
additional information to validation messages. e.g. Changing "type
mismatch" to "Please specify an e-mail address" for <input type=email>.

html/EmailInputType.cpp: (WebCore::EmailInputType::typeMismatchText): Call validationMessageTypeMismatchForEmailText() or validationMessageTypeMismatchForMultipleEmailText().
html/EmailInputType.h:
html/HTMLFormControlElement.h: Add maxLength() and value() to access them from ValidityState.
html/HTMLInputElement.cpp: Add the following functions to pass extra information to validation message string functions. (WebCore::HTMLInputElement::minimumString): (WebCore::HTMLInputElement::maximumString): (WebCore::HTMLInputElement::stepBaseString): (WebCore::HTMLInputElement::stepString): (WebCore::HTMLInputElement::typeMismatchText):
html/HTMLInputElement.h:
html/HTMLTextAreaElement.h:
html/InputType.cpp: (WebCore::InputType::typeMismatchText): Call validationMessageTypeMismatchText().
html/InputType.h:
html/URLInputType.cpp: (WebCore::URLInputType::typeMismatchText): Call validationMessageTypeMismatchForURLText().
html/URLInputType.h:
html/ValidityState.cpp: (WebCore::ValidityState::validationMessage):
platform/LocalizedStrings.cpp: (WebCore::validationMessageTypeMismatchForEmailText): (WebCore::validationMessageTypeMismatchForMultipleEmailText): (WebCore::validationMessageTypeMismatchForURLText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageStepMismatchText):
platform/LocalizedStrings.h:
- Add validationMessageTypeMismatchForEmailText(), validationMessageTypeMismatchForMultipleEmailText() and validationMessageTypeMismatchForURLText()
- Add length parameters to validationMessageTooLongText().
- Add the minimum value parameter to validationMessageRangeUnderflowText()
- Add the maximum value parameter to validationMessageRangeOverflowText()
- Add parameters of the base value and the step value to validationMessageStepMismatchText()
platform/android/LocalizedStringsAndroid.cpp: (WebCore::validationMessageTypeMismatchForEmailText): (WebCore::validationMessageTypeMismatchForMultipleEmailText): (WebCore::validationMessageTypeMismatchForURLText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageStepMismatchText):
platform/brew/LocalizedStringsBrew.cpp: (WebCore::validationMessageTypeMismatchForEmailText): (WebCore::validationMessageTypeMismatchForMultipleEmailText): (WebCore::validationMessageTypeMismatchForURLText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageStepMismatchText):
platform/efl/LocalizedStringsEfl.cpp: (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageStepMismatchText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageTypeMismatchForEmailText): (WebCore::validationMessageTypeMismatchForMultipleEmailText): (WebCore::validationMessageTypeMismatchForURLText):
platform/gtk/LocalizedStringsGtk.cpp: (WebCore::validationMessageTypeMismatchForEmailText): (WebCore::validationMessageTypeMismatchForMultipleEmailText): (WebCore::validationMessageTypeMismatchForURLText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageStepMismatchText):
platform/haiku/LocalizedStringsHaiku.cpp: (WebCore::validationMessageTypeMismatchForEmailText): (WebCore::validationMessageTypeMismatchForMultipleEmailText): (WebCore::validationMessageTypeMismatchForURLText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageStepMismatchText):
platform/wx/LocalizedStringsWx.cpp: (WebCore::validationMessageTypeMismatchForEmailText): (WebCore::validationMessageTypeMismatchForMultipleEmailText): (WebCore::validationMessageTypeMismatchForURLText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageStepMismatchText):

2010-11-14 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Improve API for form validation message strings
https://bugs.webkit.org/show_bug.cgi?id=34945

public/WebLocalizedString.h:
src/LocalizedStrings.cpp: (WebCore::validationMessageTypeMismatchForEmailText): (WebCore::validationMessageTypeMismatchForMultipleEmailText): (WebCore::validationMessageTypeMismatchForURLText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageStepMismatchText):

9:19 PM Changeset in webkit [71995] by tkent@chromium.org

7 edits in trunk

KeyboardEvent::keyIdentifier() should return "const String&"
https://bugs.webkit.org/show_bug.cgi?id=49426

Reviewed by Andreas Kling.

WebCore:

No new tests. This shouldn't change the current behavior.

dom/KeyboardEvent.h:

(WebCore::KeyboardEvent::keyIdentifier): Change the return type; String -> const String&

dom/SelectElement.cpp:

(WebCore::SelectElement::menuListDefaultEventHandler):

Change the type of a variable to have keyIdentifier(); String -> const String&

(WebCore::SelectElement::listBoxDefaultEventHandler): ditto.

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::defaultEventHandler): ditto.
(WebCore::HTMLInputElement::handleKeyEventForRange): ditto.

page/EventHandler.cpp:

(WebCore::EventHandler::handleKeyboardSelectionMovement): ditto.

WebKit/mac:

WebCoreSupport/WebEditorClient.mm:

(selectorForKeyEvent):

Change the type of a variable to have keyIdentifier(); String -> const String&

8:57 PM Changeset in webkit [71994] by commit-queue@webkit.org

11 edits
12 adds in trunk

2010-11-14 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.

[HTML5] "form" attribute support for form control elements
https://bugs.webkit.org/show_bug.cgi?id=47813

Adds a test file for "form" attribute of form-associated elements.
The test might need to be revised because <label> and <object> don't
support "form" attribute for now, in spite of the HTML5 spec says that
they should support.

fast/forms/form-attribute-elements-expected.txt: Added.
fast/forms/form-attribute-elements-order-expected.txt: Added.
fast/forms/form-attribute-elements-order.html: Added.
fast/forms/form-attribute-elements-order2-expected.txt: Added.
fast/forms/form-attribute-elements-order2.html: Added.
fast/forms/form-attribute-elements.html: Added.
fast/forms/form-attribute-expected.txt: Added.
fast/forms/form-attribute.html: Added.
fast/forms/script-tests/form-attribute-elements-order.js: Added.
fast/forms/script-tests/form-attribute-elements-order2.js: Added.
fast/forms/script-tests/form-attribute-elements.js: Added.
fast/forms/script-tests/form-attribute.js: Added.

2010-11-14 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.

[HTML5] "form" attribute support for form control elements
https://bugs.webkit.org/show_bug.cgi?id=47813

Adds a list of form-associated elements with form attribute into
the Document class to support form attribute.
Adds a function to determine the right place to locate
form-associated elements with form attribute into
m_associatedElements of HTMLFormElement class.

Tests: fast/forms/form-attribute-elements-order.html

fast/forms/form-attribute-elements-order2.html
fast/forms/form-attribute-elements.html
fast/forms/form-attribute.html

dom/Document.cpp: (WebCore::Document::registerFormElementWithFormAttribute): Added. (WebCore::Document::unregisterFormElementWithFormAttribute): Added. (WebCore::Document::resetFormElementsOwner): Added.
dom/Document.h: Added the list for elements with form attribute.
html/HTMLAttributeNames.in: Added form attribute.
html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::insertedIntoTree): Modified to handle form attribute. (WebCore::HTMLFormControlElement::removedFromTree): Ditto. (WebCore::HTMLFormControlElement::resetFormOwner): Added. (WebCore::HTMLFormControlElement::attributeChanged): Added.
html/HTMLFormControlElement.h:
html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::HTMLFormElement): Modified to initialize newly-added variables. (WebCore::HTMLFormElement::insertedIntoDocument): Modified to reset form owner of form-associated elements. (WebCore::HTMLFormElement::removedFromDocument): Ditto. (WebCore::HTMLFormElement::formElementIndexWithFormAttribute): Added. (WebCore::HTMLFormElement::formElementIndex): Modified to treat form-associated elements with form attribute separately. (WebCore::HTMLFormElement::removeFormElement): Modified to handle form-associated elements with form attribute.
html/HTMLFormElement.h: Added three variables to handle form attribute.
html/HTMLOutputElement.cpp: Removed "FIXME" comment. (WebCore::HTMLOutputElement::parseMappedAttribute):
html/HTMLOutputElement.h: Removed setForm().

8:53 PM Changeset in webkit [71993] by hyatt@apple.com

2 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=49521

Reviewed by Dan Bernstein.

REGRESSION svg/W3C-SVG-1.1/fonts-desc-02-t.svg broken by r71979.

Refine the font selection function for @font-face to be smarter about what fonts it prefers. If
a font is labeled as only supporting small-caps, then prefer it to one that claims to support both
normal and small-caps. The specialized font is more likely to be true small-caps and to not rely
on synthesis.

Added the same logic for italic as well. Prefer the font that is specifically restricted to
italic to one that claims it can support anything.

css/CSSFontSelector.cpp:

(WebCore::compareFontFaces):

7:38 PM Changeset in webkit [71992] by mihaip@chromium.org

2 edits in trunk/LayoutTests

2010-11-14 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

Remove two tests that consistently pass on chromium-mac.

platform/chromium/test_expectations.txt:

6:14 PM Changeset in webkit [71991] by mihaip@chromium.org

1 edit
2 adds in trunk/LayoutTests

2010-11-14 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium rebaseline and expectations update.

platform/chromium-mac/fast/blockflow/vertical-font-fallback-expected.checksum: Added.
platform/chromium-mac/fast/blockflow/vertical-font-fallback-expected.png: Added.
platform/chromium/test_expectations.txt:

5:56 PM Changeset in webkit [71990] by mihaip@chromium.org

2 edits in trunk/LayoutTests

2010-11-14 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

Correct some expectations added by r71988.

platform/chromium/test_expectations.txt:

5:17 PM Changeset in webkit [71989] by levin@chromium.org

3 edits in trunk/WebKitTools

2010-11-14 David Levin <levin@chromium.org>

Reviewed by Daniel Bates.

check-webkit-style should detect PassRefPtr usage in functions.
https://bugs.webkit.org/show_bug.cgi?id=49513

Scripts/webkitpy/style/checkers/cpp.py: (check_for_function_lengths): Revert a comment change that I accidentally made in r71986. (check_pass_ptr_usage): Added the code to do the check. (process_line): Added the call to check_pass_ptr_usage. (CppChecker): Added the new error category.
Scripts/webkitpy/style/checkers/cpp_unittest.py: (CppStyleTestBase::perform_pass_ptr_check): Runs the new check for testing purposes. (PassPtrTest::*): The class/functions to unit test the new functionality.

5:15 PM Changeset in webkit [71988] by mihaip@chromium.org

8 edits
7 adds
1 delete in trunk/LayoutTests

2010-11-14 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium baseline and expectations update.

r71969 added a bunch of SVG tests without pixel baselines
r71969 also caused svg/W3C-SVG-1.1-SE/types-dom-06-f.svg to need a rebaseline for Linux and Windows (which now match the mac baseline, modulo font rendering)
r71970 added two tests that depend on vertical text support (which (doesn't work on Linux or Windows yet)
Similarly, r71979 added a test that depends on vertical text support
r71979 also caused a regression that should be fixed upstream
Add Chromium baselines for fast/repaint/ repaint-across-writing-mode-boundary.html (added by r71980).

Also rebaseline fast/table/colspanMinWidth-vertical.html for Linux and
Windows, to mirror the mac rebaseline done in r71876.

platform/chromium-linux/fast/repaint/repaint-across-writing-mode-boundary-expected.checksum: Added.
platform/chromium-linux/fast/repaint/repaint-across-writing-mode-boundary-expected.png: Added.
platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.checksum:
platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png:
platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Removed.
platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.checksum: Added.
platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png: Added.
platform/chromium-win/fast/repaint/repaint-across-writing-mode-boundary-expected.checksum: Added.
platform/chromium-win/fast/repaint/repaint-across-writing-mode-boundary-expected.png: Added.
platform/chromium-win/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Added.
platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.txt:
platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.checksum:
platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png:
platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:
platform/chromium/test_expectations.txt:

1:14 PM EFLWebKit edited by barbieri@profusion.mobi

document cmake flags we should use for production/development builds (diff)

12:14 PM Changeset in webkit [71987] by commit-queue@webkit.org

6 edits in trunk

2010-11-14 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Martin Robinson.

[EFL] add pango support
https://bugs.webkit.org/show_bug.cgi?id=46029

Add FONT_BACKEND option to switch between pango and freetype.

cmake/OptionsEfl.cmake:

2010-11-14 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Martin Robinson.

[EFL] add pango support
https://bugs.webkit.org/show_bug.cgi?id=46029

Include pango related files.
No new tests; functionality is unchanged.

CMakeListsEfl.txt:

2010-11-14 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Martin Robinson.

[EFL] add pango support
https://bugs.webkit.org/show_bug.cgi?id=46029

Add pango in include and libs.

CMakeListsEfl.txt:

11:59 AM Changeset in webkit [71986] by levin@chromium.org

3 edits in trunk/WebKitTools

2010-11-14 David Levin <levin@chromium.org>

Reviewed by Shinichiro Hamaji.

check-webkit-style function detection and the line count style checks should be separate.
https://bugs.webkit.org/show_bug.cgi?id=49512

Scripts/webkitpy/style/checkers/cpp.py: Do the separation.
Scripts/webkitpy/style/checkers/cpp_unittest.py: Adjust the test to call the detection function and fix line counts in two places now that the code really only counts the lines in the body of the function.

11:39 AM Changeset in webkit [71985] by andreas.kling@nokia.com

2 edits in trunk/WebKitTools

2010-11-14 Andreas Kling <kling@webkit.org>

Reviewed by Antonio Gomes.

http/tests/plugins tests print "Unhandled variable" to stderr under Qt
https://bugs.webkit.org/show_bug.cgi?id=33438

Stifle "Unhandled variable" warning to match what the other
TestNetscapePlugin does (NPP_GetValue in TestNetscapePlugIn/main.cpp
simply returns NPERR_GENERIC_ERROR for unhandled variables.)

DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_get_value):

11:11 AM Changeset in webkit [71984] by andreas.kling@nokia.com

2 edits in trunk/WebCore

2010-11-12 Tenghui Zhu <ztenghui@google.com>

Reviewed by Andreas Kling.

[V8] Code generation script error in generating the SVGStaticListPropertyTearOff
https://bugs.webkit.org/show_bug.cgi?id=49463

bindings/scripts/CodeGeneratorV8.pm: The svgNativeType is the one containing the SVGStaticListPropertyTearOff string, not the svgListPropertyType.

10:43 AM Changeset in webkit [71983] by andreas.kling@nokia.com

2 edits in trunk/WebKit/qt

2010-11-14 Andreas Kling <kling@webkit.org>

Reviewed by Antonio Gomes.

REGRESSION(r71895): API test javaScriptWindowObjectCleared fails
https://bugs.webkit.org/show_bug.cgi?id=49466

As of r71895 empty inline scripts are no longer executed and so
the javaScriptWindowObjectCleared() signal is no longer triggered
by <script></script>.

tests/qwebframe/tst_qwebframe.cpp:

9:18 AM Changeset in webkit [71982] by Patrick Gansterer

2 edits in trunk/WebCore

2010-11-14 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

Sort CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=49507

CMakeLists.txt:

Nov 13, 2010:

11:56 PM Changeset in webkit [71981] by Patrick Gansterer

6 edits in trunk/WebCore

2010-11-13 Patrick Gansterer <Patrick Gansterer>

Reviewed by Yury Semikhatsky.

Buildfix for !ENABLE(INSPECTOR)
https://bugs.webkit.org/show_bug.cgi?id=49500

Also unify the position of the condition in the cpp files.

inspector/ConsoleMessage.cpp:
inspector/InspectorResourceAgent.cpp:
inspector/InspectorState.cpp:
inspector/ScriptCallFrame.cpp:
inspector/ScriptCallStack.cpp:

10:14 PM Changeset in webkit [71980] by hyatt@apple.com

3 edits
4 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=49506

Reviewed by Anders Carlsson.

Repaint is broken across writing mode boundaries. It's not enough to add in flipped offsets. You have
to flip the rect itself.

WebCore:

Added fast/repaint/repaint-across-writing-mode-boundary.html

rendering/RenderBox.cpp:

(WebCore::RenderBox::computeRectForRepaint):

LayoutTests:

Added fast/repaint/repaint-across-writing-mode-boundary.html

fast/repaint/repaint-across-writing-mode-boundary.html: Added.
platform/mac/fast/repaint/repaint-across-writing-mode-boundary-expected.checksum: Added.
platform/mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png: Added.
platform/mac/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Added.

9:31 PM Changeset in webkit [71979] by hyatt@apple.com

7 edits
4 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=49505

Reviewed by Dan Bernstein.

REGRESSION: @font-face doesn't work with the small-caps variant. This was broken by the addition of SVG fonts
support long ago. This patch fixes the SVG code so that it doesn't break non-SVG fonts.

Added fast/blockflow/broken-ideograph-small-caps.html

WebCore:

css/CSSFontFace.cpp:

(WebCore::CSSFontFace::hasSVGFontFaceSource):

css/CSSFontFace.h:
css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData):

css/CSSFontFaceSource.h:
css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule):
(WebCore::CSSFontSelector::getFontData):

LayoutTests:

fast/blockflow/broken-ideograph-small-caps.html: Added.
platform/mac/fast/blockflow/broken-ideograph-small-caps-expected.checksum: Added.
platform/mac/fast/blockflow/broken-ideograph-small-caps-expected.png: Added.
platform/mac/fast/blockflow/broken-ideograph-small-caps-expected.txt: Added.

8:55 PM Changeset in webkit [71978] by levin@chromium.org

3 edits in trunk/WebKitTools

2010-11-13 David Levin <levin@chromium.org>

Reviewed by Eric Seidel.

check-webkit-style function detection crashes on functions in templates.
https://bugs.webkit.org/show_bug.cgi?id=49504

For example "template <bool shouldClose(const Element*)>".

Scripts/webkitpy/style/checkers/cpp.py: If not function is detected, bail out.
Scripts/webkitpy/style/checkers/cpp_unittest.py: Modified the complex function detection test to expose this issue.

8:35 PM Changeset in webkit [71977] by mitz@apple.com

2 edits in trunk/WebCore

fast/text/hyphen* tests have different results on Leopard
https://bugs.webkit.org/show_bug.cgi?id=43296

Reviewed by Dave Hyatt.

platform/text/mac/TextBreakIteratorInternalICUMac.mm:

(WebCore::topLanguagePreference): Changed to look up the value of the AppleLanguages default
through the normal NSUserDefaults search order rather than skipping the application domain.
This makes this function respect DumpRenderTree’s setting of the default in the application
domain.

8:11 PM Changeset in webkit [71976] by levin@chromium.org

3 edits in trunk/WebKitTools

check-webkit-style function detection doesn't detect indented functions declaractions.
https://bugs.webkit.org/show_bug.cgi?id=49446

Reviewed by Shinichiro Hamaji.

Indented function declarations occur inside class definitions, so
they are a pretty common (and worth detecting).

Scripts/webkitpy/style/checkers/cpp.py: Changed regex to allow indentation. Changed the function start detection to only happen when not in a function. Changed function end detection to work based on matching braces instead of finding a close brace at the beginning of the line. Fixed close_expression to do what it says when it doesn't find the close.
Scripts/webkitpy/style/checkers/cpp_unittest.py: Indented function test.

8:04 PM Changeset in webkit [71975] by hyatt@apple.com

13 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=49499

Reviewed by Dan Bernstein.

broken-ideographic-font.html causes layout test flakiness in release builds. The reason for this is
that the custom font data for m_brokenIdeographFontData was never getting pruned out of the tree.
The same problem exists for custom small caps fonts, so I made sure that the small caps fonts get
pruned as well. In addition, custom small caps fonts were never getting deleted either.

I also made allowsLigatures in FontPlatformData orientation-independent, and the callers check it
instead.

Unskip fast/blockflow/broken-ideographic-font.html

platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::~SimpleFontData):

platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:

(WebCore::SimpleFontData::platformDestroy):
(WebCore::SimpleFontData::smallCapsFontData):

platform/graphics/chromium/SimpleFontDataLinux.cpp:

(WebCore::SimpleFontData::platformDestroy):
(WebCore::SimpleFontData::smallCapsFontData):

platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::allowsLigatures):

platform/graphics/freetype/SimpleFontDataFreeType.cpp:

(WebCore::SimpleFontData::platformDestroy):
(WebCore::SimpleFontData::smallCapsFontData):

platform/graphics/haiku/SimpleFontDataHaiku.cpp:

(WebCore::SimpleFontData::platformDestroy):
(WebCore::SimpleFontData::smallCapsFontData):

platform/graphics/mac/ComplexTextControllerATSUI.cpp:

(WebCore::disableLigatures):

platform/graphics/mac/SimpleFontDataCoreText.cpp:

(WebCore::SimpleFontData::getCFStringAttributes):

platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformDestroy):

platform/graphics/win/SimpleFontDataWin.cpp:

(WebCore::SimpleFontData::platformDestroy):
(WebCore::SimpleFontData::smallCapsFontData):

platform/graphics/wx/SimpleFontDataWx.cpp:

(WebCore::SimpleFontData::platformDestroy):
(WebCore::SimpleFontData::smallCapsFontData):

2:48 PM Changeset in webkit [71974] by hyatt@apple.com

1 edit in trunk/LayoutTests/platform/mac/Skipped

Skip the broken ideograph test until I can figure out why it corrupts release builds.

12:46 PM Changeset in webkit [71973] by hyatt@apple.com

2 edits in trunk/WebCore/platform/graphics

Another attempt to fix layout tests.

12:00 PM Changeset in webkit [71972] by hyatt@apple.com

2 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=49496

Fix broken-ideographic-font.html. I had the font installed locally on my machine, and this covered up
the fact that CoreText was implicitly using it as fallback in the vertical case only. The bots don't have
the font installed locally, and so they showed the bug.

Make sure the GlyphPage is filled with horizontal glyphs for a broken ideograph font, so that CoreText is
willing to fill.

platform/graphics/mac/SimpleFontDataCoreText.cpp:

(WebCore::SimpleFontData::getCFStringAttributes):

11:29 AM Changeset in webkit [71971] by rwlbuis@webkit.org

2 edits in trunk/LayoutTests

2010-11-13 Rob Buis <rwlbuis@gmail.com>

Unreviewed test expectation rebaseline.

platform/qt/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:

10:45 AM Changeset in webkit [71970] by hyatt@apple.com

20 edits
9 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=49464

Reviewed by Dan Bernstein.

Fix bugs with the orientation of fonts when the font is brought in via fallback, when the font contains no
vertical tables, or when the font is loaded via font-face in both horizontal and vertical forms.

(1) Include orientation as part of the @font-face hashtables so that the fonts are treated as
distinct when used in horizontal and vertical forms.

(2) Let the orientation member of FontPlatformData represent the desired orientation rather than
the supported one. Add an orientation member to SimpleFontData that represents the actual
supported orientation of the font.

(3) For fonts with no vertical tables, add a brokenIdeographicsFont accessor that is invoked when
CJK ideographs are encountered. This is essentially identical to the small caps fallback mechanism
but invoked only for ideographs. The special ideograph font locks the orientation to vertical and
renders the glyphs upright even when the font has no vertical tables. Punctuation and such will
still look funny, and really this is a bug in the font, but at least this way it will be apparent
that the font is to blame.

Added fast/blockflow/broken-ideographic-font.html and fast/blockflow/vertical-font-fallback.html.

WebCore:

css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData):

css/CSSSegmentedFontFace.cpp:

(WebCore::CSSSegmentedFontFace::getFontData):

platform/graphics/Font.cpp:

(WebCore::Font::isCJKIdeograph):

platform/graphics/Font.h:
platform/graphics/FontFastPath.cpp:

(WebCore::Font::glyphDataForCharacter):

platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::SimpleFontData):
(WebCore::SimpleFontData::~SimpleFontData):
(WebCore::SimpleFontData::brokenIdeographFontData):

platform/graphics/SimpleFontData.h:

(WebCore::SimpleFontData::orientation):

platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::FontPlatformData):

platform/graphics/mac/FontMac.mm:

(WebCore::showGlyphsWithAdvances):

platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):

LayoutTests:

fast/blockflow/broken-ideographic-font.html: Added.
fast/blockflow/resources/MakibaFont13.ttf: Added.
fast/blockflow/vertical-font-fallback.html: Added.
platform/mac/fast/blockflow/broken-ideographic-font-expected.checksum: Added.
platform/mac/fast/blockflow/broken-ideographic-font-expected.png: Added.
platform/mac/fast/blockflow/broken-ideographic-font-expected.txt: Added.
platform/mac/fast/blockflow/vertical-font-fallback-expected.checksum: Added.
platform/mac/fast/blockflow/vertical-font-fallback-expected.png: Added.
platform/mac/fast/blockflow/vertical-font-fallback-expected.txt: Added.

9:16 AM Changeset in webkit [71969] by rwlbuis@webkit.org

20 edits
78 adds
2 deletes in trunk

2010-11-13 Rob Buis <rwlbuis@gmail.com>

Reviewed by Dirk Schulze.

requiredFeatures does not adapt to SVGStringList changes
https://bugs.webkit.org/show_bug.cgi?id=40887

Centralize logic of handling of SVGElement validity changes.
The logic is to detach the SVGElement when changing from valid
to invalid, and to attach when changing from invalid to valid.

Tests: svg/dynamic-updates/SVGCircleElement-dom-requiredFeatures.html

svg/dynamic-updates/SVGCircleElement-svgdom-requiredFeatures.html
svg/dynamic-updates/SVGEllipseElement-dom-requiredFeatures.html
svg/dynamic-updates/SVGEllipseElement-svgdom-requiredFeatures.html
svg/dynamic-updates/SVGForeignObjectElement-dom-requiredFeatures.html
svg/dynamic-updates/SVGForeignObjectElement-svgdom-requiredFeatures.html
svg/dynamic-updates/SVGGElement-dom-requiredFeatures.html
svg/dynamic-updates/SVGGElement-svgdom-requiredFeatures.html
svg/dynamic-updates/SVGImageElement-dom-requiredFeatures.html
svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures.html
svg/dynamic-updates/SVGLineElement-dom-requiredFeatures.html
svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures.html
svg/dynamic-updates/SVGPathElement-dom-requiredFeatures.html
svg/dynamic-updates/SVGPathElement-svgdom-requiredFeatures.html
svg/dynamic-updates/SVGPolygonElement-dom-requiredFeatures.html
svg/dynamic-updates/SVGPolygonElement-svgdom-requiredFeatures.html
svg/dynamic-updates/SVGPolylineElement-dom-requiredFeatures.html
svg/dynamic-updates/SVGPolylineElement-svgdom-requiredFeatures.html
svg/dynamic-updates/SVGRectElement-dom-requiredFeatures.html
svg/dynamic-updates/SVGRectElement-svgdom-requiredFeatures.html
svg/dynamic-updates/SVGSVGElement-dom-requiredFeatures.html
svg/dynamic-updates/SVGSVGElement-svgdom-requiredFeatures.html
svg/dynamic-updates/SVGTextElement-dom-requiredFeatures.html
svg/dynamic-updates/SVGTextElement-svgdom-requiredFeatures.html
svg/dynamic-updates/SVGUseElement-dom-requiredFeatures.html
svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures.html

8:39 AM Changeset in webkit [71968] by Patrick Gansterer

2 edits in trunk/WebKit/wince

2010-11-13 Patrick Gansterer <Patrick Gansterer>

Unreviewed, build fix after r71541.

WebCoreSupport/ChromeClientWinCE.h:

8:32 AM Changeset in webkit [71967] by caseq@chromium.org

6 edits in trunk/WebCore

2010-11-13 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [refactoring] support Views in TabbedPane and streamline tab selection in resource view
https://bugs.webkit.org/show_bug.cgi?id=49493

inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._showResource):
inspector/front-end/ResourceView.js: (WebInspector.ResourceView): (WebInspector.ResourceView.prototype.selectContentTab): (WebInspector.ResourceView.prototype._selectTab): (WebInspector.ResourceView.prototype._refreshCookies): (WebInspector.ResourceCookiesTab.prototype.show):
inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.showResource):
inspector/front-end/TabbedPane.js: (WebInspector.TabbedPane.prototype.appendTab): (WebInspector.TabbedPane.prototype.hasTab): (WebInspector.TabbedPane.prototype.selectTabById): (WebInspector.TabbedPane.prototype._hideTab): (WebInspector.TabbedPane.prototype._showTab):
inspector/front-end/inspector.css: (.resource-view-cookies): (.resource-view-cookies.visible):

6:50 AM Changeset in webkit [71966] by yurys@chromium.org

2 edits in trunk/WebCore

2010-11-13 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

REGRESSION(71515): Web Inspector: Safari crash calling console.log when Log JavaScript Exceptions to Console is checked
https://bugs.webkit.org/show_bug.cgi?id=49362

page/Console.cpp: (WebCore::Console::addMessage): avoid accessing ScriptArguments and ScriptCallStack after their ownership has been passed to the inspector.

3:04 AM Changeset in webkit [71965] by yurys@chromium.org

2 edits in trunk/WebCore

2010-11-13 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: DOM event listener name is cropped in Elements panel
https://bugs.webkit.org/show_bug.cgi?id=49387

inspector/front-end/inspector.css: (.event-bar): use margin-left instead of left to fit child node into its parent

3:02 AM Changeset in webkit [71964] by hamaji@chromium.org

4 edits in trunk

2010-11-13 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Kent Tamura.

[Chromium] print doesn't work on http://nodejs.org/api.html
https://bugs.webkit.org/show_bug.cgi?id=49304

platform/chromium/test_expectations.txt:

2010-11-13 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Kent Tamura.

[Chromium] print doesn't work on http://nodejs.org/api.html
https://bugs.webkit.org/show_bug.cgi?id=49304

src/WebFrameImpl.cpp: (WebKit::ChromePrintContext::begin): (WebKit::WebFrameImpl::printBegin):

1:47 AM Changeset in webkit [71963] by commit-queue@webkit.org

2 edits
1 add in trunk/WebCore

2010-11-13 Ilya Sherman <isherman@chromium.org>

Reviewed by Shinichiro Hamaji.

Fixes regression from previous patch -- computes y offsets for elements
that are scrolled out of the window.
https://bugs.webkit.org/show_bug.cgi?id=49306

manual-tests/select-scroll.html: Added.
platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::layout):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed