⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 16, 2010:

11:43 PM Changeset in webkit [72175] by Adam Roben
  • 3 edits in trunk/WebKitLibraries

Ignore files from libdispatch/zlib

Rubber-stamped by Eric Seidel.

  • win/include: Modified property svn:ignore.
  • win/lib: Modified property svn:ignore.
11:24 PM Changeset in webkit [72174] by Adam Roben
  • 2 edits
    1 add in trunk/WebCore

Move QTMovieWin's settings into a vsprops file

Fixes <​http://webkit.org/b/49644> QTMovieWin should use a vsprops file

Reviewed by Steve Falkenburg.

  • WebCore.vcproj/QTMovieWin.vcproj:
  • WebCore.vcproj/QTMovieWinCommon.vsprops: Added.
10:45 PM Changeset in webkit [72173] by aestes@apple.com
  • 282 edits
    4 adds in trunk

WebKit mishandles line boxes where the content height exceeds the
specified line-height.
​https://bugs.webkit.org/show_bug.cgi?id=49410

Reviewed by Dave Hyatt.

WebCore:

If a line height is explicitly specified on a text box and fallback
fonts are in use, only the primary font should be considered when
computing the box's ascent and descent. This prevents the inline box
from being sized larger than the specified line height.

This patch also fixes a math error when computing a used font's descent
in the case where line height isn't explicitly set. This change results
in a number of layout tests needing re-baselining.

Test: fast/css/line-height-determined-by-primary-font.html

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::computeLogicalBoxHeights):

LayoutTests:

  • fast/css/line-height-determined-by-primary-font.html: Added.
  • platform/mac/fast/css/line-height-determined-by-primary-font-expected.checksum: Added.
  • platform/mac/fast/css/line-height-determined-by-primary-font-expected.png: Added.
  • platform/mac/fast/css/line-height-determined-by-primary-font-expected.txt: Added.

The following test results were re-baselined:

  • platform/mac/css2.1/t0805-c5518-brdr-t-01-e-expected.checksum:
  • platform/mac/css2.1/t0805-c5518-brdr-t-01-e-expected.png:
  • platform/mac/css2.1/t0805-c5518-brdr-t-01-e-expected.txt:
  • platform/mac/css2.1/t0805-c5519-brdr-r-00-a-expected.checksum:
  • platform/mac/css2.1/t0805-c5519-brdr-r-00-a-expected.png:
  • platform/mac/css2.1/t0805-c5519-brdr-r-00-a-expected.txt:
  • platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.checksum:
  • platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.png:
  • platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
  • platform/mac/css2.1/t0805-c5521-brdr-l-00-a-expected.checksum:
  • platform/mac/css2.1/t0805-c5521-brdr-l-00-a-expected.png:
  • platform/mac/css2.1/t0805-c5521-brdr-l-00-a-expected.txt:
  • platform/mac/css2.1/t0805-c5521-brdr-l-01-e-expected.checksum:
  • platform/mac/css2.1/t0805-c5521-brdr-l-01-e-expected.png:
  • platform/mac/css2.1/t0805-c5521-brdr-l-01-e-expected.txt:
  • platform/mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.checksum:
  • platform/mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.png:
  • platform/mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt:
  • platform/mac/css2.1/t0905-c414-flt-02-c-expected.checksum:
  • platform/mac/css2.1/t0905-c414-flt-02-c-expected.png:
  • platform/mac/css2.1/t0905-c414-flt-02-c-expected.txt:
  • platform/mac/css2.1/t0905-c414-flt-03-c-expected.checksum:
  • platform/mac/css2.1/t0905-c414-flt-03-c-expected.png:
  • platform/mac/css2.1/t0905-c414-flt-03-c-expected.txt:
  • platform/mac/css2.1/t0905-c414-flt-04-c-expected.checksum:
  • platform/mac/css2.1/t0905-c414-flt-04-c-expected.png:
  • platform/mac/css2.1/t0905-c414-flt-04-c-expected.txt:
  • platform/mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.checksum:
  • platform/mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.png:
  • platform/mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltblck-01-d-expected.checksum:
  • platform/mac/css2.1/t0905-c5525-fltblck-01-d-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltblck-01-d-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum:
  • platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
  • platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltwidth-02-c-g-expected.checksum:
  • platform/mac/css2.1/t0905-c5525-fltwidth-02-c-g-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.checksum:
  • platform/mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltwrap-00-b-expected.checksum:
  • platform/mac/css2.1/t0905-c5525-fltwrap-00-b-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltwrap-00-b-expected.txt:
  • platform/mac/css2.1/t090501-c414-flt-01-b-expected.checksum:
  • platform/mac/css2.1/t090501-c414-flt-01-b-expected.png:
  • platform/mac/css2.1/t090501-c414-flt-01-b-expected.txt:
  • platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.checksum:
  • platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.png:
  • platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.txt:
  • platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.checksum:
  • platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.txt:
  • platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.checksum:
  • platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.txt:
  • platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.checksum:
  • platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.png:
  • platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.txt:
  • platform/mac/css2.1/t1202-counter-03-b-expected.checksum:
  • platform/mac/css2.1/t1202-counter-03-b-expected.png:
  • platform/mac/css2.1/t1202-counter-03-b-expected.txt:
  • platform/mac/css2.1/t1202-counter-04-b-expected.checksum:
  • platform/mac/css2.1/t1202-counter-04-b-expected.png:
  • platform/mac/css2.1/t1202-counter-04-b-expected.txt:
  • platform/mac/css2.1/t1202-counter-09-b-expected.checksum:
  • platform/mac/css2.1/t1202-counter-09-b-expected.png:
  • platform/mac/css2.1/t1202-counter-09-b-expected.txt:
  • platform/mac/css2.1/t1202-counters-03-b-expected.checksum:
  • platform/mac/css2.1/t1202-counters-03-b-expected.png:
  • platform/mac/css2.1/t1202-counters-03-b-expected.txt:
  • platform/mac/css2.1/t1202-counters-04-b-expected.checksum:
  • platform/mac/css2.1/t1202-counters-04-b-expected.png:
  • platform/mac/css2.1/t1202-counters-04-b-expected.txt:
  • platform/mac/css2.1/t1202-counters-09-b-expected.checksum:
  • platform/mac/css2.1/t1202-counters-09-b-expected.png:
  • platform/mac/css2.1/t1202-counters-09-b-expected.txt:
  • platform/mac/fast/blockflow/vertical-font-fallback-expected.checksum:
  • platform/mac/fast/blockflow/vertical-font-fallback-expected.png:
  • platform/mac/fast/blockflow/vertical-font-fallback-expected.txt:
  • platform/mac/fast/css/beforeSelectorOnCodeElement-expected.checksum:
  • platform/mac/fast/css/beforeSelectorOnCodeElement-expected.png:
  • platform/mac/fast/css/beforeSelectorOnCodeElement-expected.txt:
  • platform/mac/fast/css/font-face-opentype-expected.checksum:
  • platform/mac/fast/css/font-face-opentype-expected.png:
  • platform/mac/fast/css/font-face-opentype-expected.txt:
  • platform/mac/fast/css/rtl-ordering-expected.checksum:
  • platform/mac/fast/css/rtl-ordering-expected.png:
  • platform/mac/fast/css/rtl-ordering-expected.txt:
  • platform/mac/fast/css/text-overflow-ellipsis-bidi-expected.checksum:
  • platform/mac/fast/css/text-overflow-ellipsis-bidi-expected.png:
  • platform/mac/fast/css/text-overflow-ellipsis-bidi-expected.txt:
  • platform/mac/fast/css/text-overflow-ellipsis-expected.checksum:
  • platform/mac/fast/css/text-overflow-ellipsis-expected.png:
  • platform/mac/fast/css/text-overflow-ellipsis-expected.txt:
  • platform/mac/fast/css/text-overflow-ellipsis-strict-expected.checksum:
  • platform/mac/fast/css/text-overflow-ellipsis-strict-expected.png:
  • platform/mac/fast/css/text-overflow-ellipsis-strict-expected.txt:
  • platform/mac/fast/css/text-security-expected.checksum:
  • platform/mac/fast/css/text-security-expected.png:
  • platform/mac/fast/css/text-security-expected.txt:
  • platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.checksum:
  • platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.png:
  • platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.txt:
  • platform/mac/fast/encoding/invalid-UTF-8-expected.checksum:
  • platform/mac/fast/encoding/invalid-UTF-8-expected.png:
  • platform/mac/fast/encoding/invalid-UTF-8-expected.txt:
  • platform/mac/fast/events/updateLayoutForHitTest-expected.checksum:
  • platform/mac/fast/events/updateLayoutForHitTest-expected.png:
  • platform/mac/fast/events/updateLayoutForHitTest-expected.txt:
  • platform/mac/fast/forms/select-visual-hebrew-expected.checksum:
  • platform/mac/fast/forms/select-visual-hebrew-expected.png:
  • platform/mac/fast/forms/select-visual-hebrew-expected.txt:
  • platform/mac/fast/forms/select-writing-direction-natural-expected.checksum:
  • platform/mac/fast/forms/select-writing-direction-natural-expected.png:
  • platform/mac/fast/forms/select-writing-direction-natural-expected.txt:
  • platform/mac/fast/forms/visual-hebrew-text-field-expected.checksum:
  • platform/mac/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/mac/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/mac/fast/repaint/repaint-across-writing-mode-boundary-expected.checksum:
  • platform/mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
  • platform/mac/fast/repaint/repaint-across-writing-mode-boundary-expected.txt:
  • platform/mac/fast/text/atsui-multiple-renderers-expected.checksum:
  • platform/mac/fast/text/atsui-multiple-renderers-expected.png:
  • platform/mac/fast/text/atsui-multiple-renderers-expected.txt:
  • platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.checksum:
  • platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.png:
  • platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.txt:
  • platform/mac/fast/text/capitalize-boundaries-expected.checksum:
  • platform/mac/fast/text/capitalize-boundaries-expected.png:
  • platform/mac/fast/text/capitalize-boundaries-expected.txt:
  • platform/mac/fast/text/cg-fallback-bolding-expected.checksum:
  • platform/mac/fast/text/cg-fallback-bolding-expected.png:
  • platform/mac/fast/text/cg-fallback-bolding-expected.txt:
  • platform/mac/fast/text/complex-text-opacity-expected.checksum:
  • platform/mac/fast/text/complex-text-opacity-expected.png:
  • platform/mac/fast/text/complex-text-opacity-expected.txt:
  • platform/mac/fast/text/in-rendered-text-rtl-expected.checksum:
  • platform/mac/fast/text/in-rendered-text-rtl-expected.png:
  • platform/mac/fast/text/in-rendered-text-rtl-expected.txt:
  • platform/mac/fast/text/international/001-expected.checksum:
  • platform/mac/fast/text/international/001-expected.png:
  • platform/mac/fast/text/international/001-expected.txt:
  • platform/mac/fast/text/international/002-expected.checksum:
  • platform/mac/fast/text/international/002-expected.png:
  • platform/mac/fast/text/international/002-expected.txt:
  • platform/mac/fast/text/international/003-expected.checksum:
  • platform/mac/fast/text/international/003-expected.png:
  • platform/mac/fast/text/international/003-expected.txt:
  • platform/mac/fast/text/international/bidi-AN-after-L-expected.checksum:
  • platform/mac/fast/text/international/bidi-AN-after-L-expected.png:
  • platform/mac/fast/text/international/bidi-AN-after-L-expected.txt:
  • platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.checksum:
  • platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.png:
  • platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.txt:
  • platform/mac/fast/text/international/bidi-CS-after-AN-expected.checksum:
  • platform/mac/fast/text/international/bidi-CS-after-AN-expected.png:
  • platform/mac/fast/text/international/bidi-CS-after-AN-expected.txt:
  • platform/mac/fast/text/international/bidi-L2-run-reordering-expected.checksum:
  • platform/mac/fast/text/international/bidi-L2-run-reordering-expected.png:
  • platform/mac/fast/text/international/bidi-L2-run-reordering-expected.txt:
  • platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.checksum:
  • platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.png:
  • platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.txt:
  • platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.checksum:
  • platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.png:
  • platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.txt:
  • platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.checksum:
  • platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
  • platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
  • platform/mac/fast/text/international/bidi-european-terminators-expected.checksum:
  • platform/mac/fast/text/international/bidi-european-terminators-expected.png:
  • platform/mac/fast/text/international/bidi-european-terminators-expected.txt:
  • platform/mac/fast/text/international/bidi-fallback-font-weight-expected.checksum:
  • platform/mac/fast/text/international/bidi-fallback-font-weight-expected.png:
  • platform/mac/fast/text/international/bidi-fallback-font-weight-expected.txt:
  • platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.checksum:
  • platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
  • platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
  • platform/mac/fast/text/international/bidi-innertext-expected.checksum:
  • platform/mac/fast/text/international/bidi-innertext-expected.png:
  • platform/mac/fast/text/international/bidi-innertext-expected.txt:
  • platform/mac/fast/text/international/bidi-linebreak-001-expected.checksum:
  • platform/mac/fast/text/international/bidi-linebreak-001-expected.png:
  • platform/mac/fast/text/international/bidi-linebreak-001-expected.txt:
  • platform/mac/fast/text/international/bidi-linebreak-002-expected.checksum:
  • platform/mac/fast/text/international/bidi-linebreak-002-expected.png:
  • platform/mac/fast/text/international/bidi-linebreak-002-expected.txt:
  • platform/mac/fast/text/international/bidi-linebreak-003-expected.checksum:
  • platform/mac/fast/text/international/bidi-linebreak-003-expected.png:
  • platform/mac/fast/text/international/bidi-linebreak-003-expected.txt:
  • platform/mac/fast/text/international/bidi-listbox-atsui-expected.checksum:
  • platform/mac/fast/text/international/bidi-listbox-atsui-expected.png:
  • platform/mac/fast/text/international/bidi-listbox-atsui-expected.txt:
  • platform/mac/fast/text/international/bidi-listbox-expected.checksum:
  • platform/mac/fast/text/international/bidi-listbox-expected.png:
  • platform/mac/fast/text/international/bidi-listbox-expected.txt:
  • platform/mac/fast/text/international/bidi-menulist-expected.checksum:
  • platform/mac/fast/text/international/bidi-menulist-expected.png:
  • platform/mac/fast/text/international/bidi-menulist-expected.txt:
  • platform/mac/fast/text/international/bidi-mirror-he-ar-expected.checksum:
  • platform/mac/fast/text/international/bidi-mirror-he-ar-expected.png:
  • platform/mac/fast/text/international/bidi-mirror-he-ar-expected.txt:
  • platform/mac/fast/text/international/bidi-neutral-run-expected.checksum:
  • platform/mac/fast/text/international/bidi-neutral-run-expected.png:
  • platform/mac/fast/text/international/bidi-neutral-run-expected.txt:
  • platform/mac/fast/text/international/bidi-override-expected.checksum:
  • platform/mac/fast/text/international/bidi-override-expected.png:
  • platform/mac/fast/text/international/bidi-override-expected.txt:
  • platform/mac/fast/text/international/danda-space-expected.checksum:
  • platform/mac/fast/text/international/danda-space-expected.png:
  • platform/mac/fast/text/international/danda-space-expected.txt:
  • platform/mac/fast/text/international/hebrew-vowels-expected.checksum:
  • platform/mac/fast/text/international/hebrew-vowels-expected.png:
  • platform/mac/fast/text/international/hebrew-vowels-expected.txt:
  • platform/mac/fast/text/international/hindi-spacing-expected.checksum:
  • platform/mac/fast/text/international/hindi-spacing-expected.png:
  • platform/mac/fast/text/international/hindi-spacing-expected.txt:
  • platform/mac/fast/text/international/hindi-whitespace-expected.checksum:
  • platform/mac/fast/text/international/hindi-whitespace-expected.png:
  • platform/mac/fast/text/international/hindi-whitespace-expected.txt:
  • platform/mac/fast/text/international/plane2-expected.checksum:
  • platform/mac/fast/text/international/plane2-expected.png:
  • platform/mac/fast/text/international/plane2-expected.txt:
  • platform/mac/fast/text/international/rtl-caret-expected.checksum:
  • platform/mac/fast/text/international/rtl-caret-expected.png:
  • platform/mac/fast/text/international/rtl-caret-expected.txt:
  • platform/mac/fast/text/international/thai-baht-space-expected.checksum:
  • platform/mac/fast/text/international/thai-baht-space-expected.png:
  • platform/mac/fast/text/international/thai-baht-space-expected.txt:
  • platform/mac/fast/text/international/thai-line-breaks-expected.checksum:
  • platform/mac/fast/text/international/thai-line-breaks-expected.png:
  • platform/mac/fast/text/international/thai-line-breaks-expected.txt:
  • platform/mac/fast/text/international/wrap-CJK-001-expected.checksum:
  • platform/mac/fast/text/international/wrap-CJK-001-expected.png:
  • platform/mac/fast/text/international/wrap-CJK-001-expected.txt:
  • platform/mac/mathml/presentation/attributes-expected.checksum:
  • platform/mac/mathml/presentation/attributes-expected.png:
  • platform/mac/mathml/presentation/attributes-expected.txt:
  • platform/mac/mathml/presentation/fractions-expected.checksum:
  • platform/mac/mathml/presentation/fractions-expected.png:
  • platform/mac/mathml/presentation/fractions-expected.txt:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.checksum:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
  • platform/mac/mathml/presentation/mo-expected.checksum:
  • platform/mac/mathml/presentation/mo-expected.png:
  • platform/mac/mathml/presentation/mo-expected.txt:
  • platform/mac/mathml/presentation/over-expected.checksum:
  • platform/mac/mathml/presentation/over-expected.png:
  • platform/mac/mathml/presentation/over-expected.txt:
  • platform/mac/mathml/presentation/roots-expected.checksum:
  • platform/mac/mathml/presentation/roots-expected.png:
  • platform/mac/mathml/presentation/roots-expected.txt:
  • platform/mac/mathml/presentation/row-alignment-expected.checksum:
  • platform/mac/mathml/presentation/row-alignment-expected.png:
  • platform/mac/mathml/presentation/row-alignment-expected.txt:
  • platform/mac/mathml/presentation/row-expected.txt:
  • platform/mac/mathml/presentation/style-expected.txt:
  • platform/mac/mathml/presentation/sub-expected.txt:
  • platform/mac/mathml/presentation/subsup-expected.txt:
  • platform/mac/mathml/presentation/sup-expected.checksum:
  • platform/mac/mathml/presentation/sup-expected.png:
  • platform/mac/mathml/presentation/sup-expected.txt:
  • platform/mac/mathml/presentation/tables-expected.checksum:
  • platform/mac/mathml/presentation/tables-expected.png:
  • platform/mac/mathml/presentation/tables-expected.txt:
  • platform/mac/mathml/presentation/tokenElements-expected.txt:
  • platform/mac/mathml/presentation/under-expected.checksum:
  • platform/mac/mathml/presentation/under-expected.png:
  • platform/mac/mathml/presentation/under-expected.txt:
  • platform/mac/mathml/presentation/underover-expected.checksum:
  • platform/mac/mathml/presentation/underover-expected.png:
  • platform/mac/mathml/presentation/underover-expected.txt:
  • platform/mac/mathml/xHeight-expected.txt:
9:56 PM Changeset in webkit [72172] by rniwa@webkit.org
  • 5 edits in trunk/WebCore

2010-11-15 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

ScriptElementData should be a private member of ScriptElement
​https://bugs.webkit.org/show_bug.cgi?id=49578

Privatized m_data of ScriptElement. Added haveFiredLoadEvent, setHaveFiredLoadEvent, createdByParser,
and isEvaluated to ScriptElement to proxy calls from HTMLScriptElement and SVGScriptElement to ScriptElementData.

No tests are added since this is a cleanup.

  • dom/ScriptElement.h: (WebCore::ScriptElement::haveFiredLoadEvent): Added. (WebCore::ScriptElement::setHaveFiredLoadEvent): Added. (WebCore::ScriptElement::createdByParser): Added. (WebCore::ScriptElement::isEvaluated): Added.
  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::dispatchLoadEvent): Calls haveFiredLoadEvent and setHaveFiredLoadEvent. (WebCore::HTMLScriptElement::cloneElementWithoutAttributesAndChildren): Calls isEvaluated.
  • html/HTMLScriptElement.h: (WebCore::HTMLScriptElement::text): Calls scriptContent. (WebCore::HTMLScriptElement::haveFiredLoadEvent): Calls haveFiredLoadEvent.
  • svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::svgAttributeChanged): Calls haveFiredLoadEvent and createdByParser. (WebCore::SVGScriptElement::insertedIntoDocument): Calls createdByParser. (WebCore::SVGScriptElement::finishParsingChildren): Calls setHaveFiredLoadEvent. (WebCore::SVGScriptElement::haveLoadedRequiredResources): Ditto. (WebCore::SVGScriptElement::dispatchLoadEvent): Calls haveFiredLoadEvent. (WebCore::SVGScriptElement::cloneElementWithoutAttributesAndChildren): Calls createdByParser, haveFiredLoadEvent, and setHaveFiredLoadEvent.
8:52 PM Changeset in webkit [72171] by Antti Koivisto
  • 3 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=49320
Minor ResourceLoadScheduler cleanups

Reviewed by Darin Adler.

  • loader/ResourceLoadScheduler.cpp:

(WebCore::ResourceLoadScheduler::scheduleLoad):
(WebCore::ResourceLoadScheduler::servePendingRequests):
(WebCore::ResourceLoadScheduler::HostInformation::~HostInformation):
(WebCore::ResourceLoadScheduler::HostInformation::remove):
(WebCore::ResourceLoadScheduler::HostInformation::hasRequests):

  • loader/ResourceLoadScheduler.h:
8:27 PM Changeset in webkit [72170] by inferno@chromium.org
  • 4 edits in branches/chromium/552/LayoutTests

Merge 72166

BUG=63389

8:24 PM Changeset in webkit [72169] by inferno@chromium.org
  • 1 edit in branches/chromium/552/WebCore/css/CSSPrimitiveValue.cpp

Merge 72163

BUG=63389

8:13 PM Changeset in webkit [72168] by hyatt@apple.com
  • 5 edits in trunk/WebCore

Add a baselineType member to RootInlineBox that caches whether the default baseline behavior for that
line should be ideographic or alphabetic. Add a requiresIdeographicsBaseline recursive function to
InlineFlowBox that scans for the use of any vertical fonts.

Reviewed by Sam Weinig.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::requiresIdeographicBaseline):

  • rendering/InlineFlowBox.h:
  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::alignBoxesInBlockDirection):

  • rendering/RootInlineBox.h:

(WebCore::RootInlineBox::baselineType):

7:35 PM Changeset in webkit [72167] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Update WebKit2 skipped list.

Rubber-stamped by Jon Honeycutt.

  • platform/mac-wk2/Skipped:
7:24 PM Changeset in webkit [72166] by Antti Koivisto
  • 5 edits in trunk/LayoutTests

​https://bugs.webkit.org/show_bug.cgi?id=31223
Make primitive values immutable.

Patch by Antti Koivisto <​koivisto@iki.fi> on 2010-11-16
Reviewed by Adam Barth.

Update test cases for behavior change and test computed style too. Note that there are some
failures in the results demonstrating unrelated bugs in CSSPrimitiveValues.

  • fast/dom/script-tests/setPrimitiveValue-exceptions.js:

(checkThrows):

  • fast/dom/setPrimitiveValue.html:
  • fast/dom/setPrimitiveValue-exceptions-expected.txt
  • fast/dom/setPrimitiveValue-expected.txt
7:24 PM Changeset in webkit [72165] by hyatt@apple.com
  • 4 edits
    1 add in trunk/WebCore

Add FontBaseline.h and make ascent and descent take a baseline parameter so that both an
alphabetic and ideographic baseline can be requested.

Reviewed by Sam Weinig.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/Font.h:

(WebCore::Font::ascent):
(WebCore::Font::descent):

  • platform/graphics/FontBaseline.h: Added.
  • platform/graphics/SimpleFontData.h:

(WebCore::SimpleFontData::ascent):
(WebCore::SimpleFontData::descent):
(WebCore::SimpleFontData::height):

7:20 PM Changeset in webkit [72164] by hyatt@apple.com
  • 2 edits in trunk/WebKitTools

Make sure the pref for minimum font size is just explicitly set to 0 every time,
since the bots have 1 stuck in their plist otherwise.

Reviewed by Sam Weinig.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):

7:15 PM Changeset in webkit [72163] by Antti Koivisto
  • 2 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=31223
Make primitive values immutable.

Patch by Antti Koivisto <​koivisto@iki.fi> on 2010-11-16
Reviewed by Adam Barth.

Make CSSPrimitiveValue setFloatValue and setStringValue always throw NO_MODIFICATION_ALLOWED exception.

Reasoning:

  • these setters never worked correctly, style was not invalidated so changing values would have no effect on rendering
  • computed style is immutable in all cases, and it wasn't
  • no other engine seems to support mutable primitives, as a result there is no content using these APIs
  • mutable primitive values are pointless, the usual way to change the value of a propertly is to replace it with a new value
  • allowing mutation of primitive values makes optimizations harder
  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::setFloatValue):
(WebCore::CSSPrimitiveValue::setStringValue):

7:13 PM Changeset in webkit [72162] by weinig@apple.com
  • 12 edits
    1 delete in trunk/WebKit2

WebKit2: Support enabling site-specific quirks
<rdar://problem/8451371>
​https://bugs.webkit.org/show_bug.cgi?id=46076

Reviewed by Adam Roben.

  • Shared/WebPreferencesStore.cpp:

(WebKit::WebPreferencesStore::WebPreferencesStore):
(WebKit::WebPreferencesStore::encode):
(WebKit::WebPreferencesStore::decode):

  • Shared/WebPreferencesStore.h:

Add needsSiteSpecificQuirks;

  • UIProcess/API/C/WKAPICast.h:

(WebKit::toFontSmoothingLevel):
(WebKit::toAPI):
Move FontSmoothing conversion functions here.

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetFontSmoothingLevel):
(WKPreferencesGetFontSmoothingLevel):
(WKPreferencesSetAcceleratedCompositingEnabled):
(WKPreferencesGetAcceleratedCompositingEnabled):
(WKPreferencesSetCompositingBordersVisible):
(WKPreferencesGetCompositingBordersVisible):
(WKPreferencesSetCompositingRepaintCountersVisible):
(WKPreferencesGetCompositingRepaintCountersVisible):
(WKPreferencesSetNeedsSiteSpecificQuirks):
(WKPreferencesGetNeedsSiteSpecificQuirks):
Add WKPreferencesSetNeedsSiteSpecificQuirks/WKPreferencesGetNeedsSiteSpecificQuirks
and move implementations from WKPreferencesPrivate.cpp here.

  • UIProcess/API/C/WKPreferencesPrivate.cpp: Removed.
  • UIProcess/API/C/WKPreferencesPrivate.h:

Add Add WKPreferencesSetNeedsSiteSpecificQuirks/WKPreferencesGetNeedsSiteSpecificQuirks.

  • UIProcess/WebPreferences.cpp:

(WebKit::WebPreferences::setNeedsSiteSpecificQuirks):
(WebKit::WebPreferences::needsSiteSpecificQuirks):

  • UIProcess/WebPreferences.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):
Pipe through needsSiteSpecificQuirks.

  • WebKit2.xcodeproj/project.pbxproj:
  • WebKit2.pro:
  • win/WebKit2.vcproj:

Update for removed files.

7:11 PM Changeset in webkit [72161] by hyatt@apple.com
  • 3 edits in trunk/LayoutTests/platform/mac/svg/batik/text

Update SVG layout test.

7:03 PM Changeset in webkit [72160] by barraclough@apple.com
  • 21 edits in trunk/JavaScriptCore

Bug 49635 - Profiler implementation is fragile

Reviewed by Sam Weinig.

The profile presently requires the exception handling mechanism to explicitly
remove all stack frames that are exited during the exception unwind mechanism.
This is fragile in a number of ways:

  • We have to change bytecode register allocation when compiling code to run when profiling, to preserve the callee function (this is also required to call did_call after the call has returned).
  • In the JIT we have to maintain additional data structures (CodeBlock::RareData::m_functionRegisterInfos) to map back to the register containing the callee.
  • In the interpreter we use 'magic values' to offset into the instruction stream to rediscover the register containing the function.

Instead, move profiling into the head and tail of functions.

  • This correctly accounts the cost of the call itself to the caller.
  • This allows us to access the callee function object from the callframe.
  • This means that at the point a call is made we can track the stack depth on the ProfileNode.
  • When unwinding we can simply report the depth at which the exception is being handled - all call frames above this level are freed.

(JSC::CodeBlock::dump):
(JSC::CodeBlock::shrinkToFit):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::bytecodeOffset):
(JSC::CodeBlock::methodCallLinkInfo):

  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitCallVarargs):
(JSC::BytecodeGenerator::emitReturn):
(JSC::BytecodeGenerator::emitConstruct):

  • bytecompiler/BytecodeGenerator.h:

(JSC::CallArguments::count):

  • bytecompiler/NodesCodegen.cpp:

(JSC::CallArguments::CallArguments):

  • interpreter/Interpreter.cpp:

(JSC::ProfileHostCall::ProfileHostCall):
(JSC::ProfileHostCall::~ProfileHostCall):
(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::throwException):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::privateExecute):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

  • jit/JIT.h:
  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_profile_has_called):
(JSC::JIT::emit_op_profile_will_return):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_profile_has_called):
(JSC::JIT::emit_op_profile_will_return):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • jit/JITStubs.h:
  • profiler/Profile.cpp:

(JSC::Profile::Profile):

  • profiler/ProfileGenerator.cpp:

(JSC::ProfileGenerator::addParentForConsoleStart):
(JSC::ProfileGenerator::willExecute):
(JSC::ProfileGenerator::didExecute):
(JSC::ProfileGenerator::exceptionUnwind):
(JSC::ProfileGenerator::stopProfiling):

  • profiler/ProfileGenerator.h:
  • profiler/ProfileNode.cpp:

(JSC::ProfileNode::ProfileNode):
(JSC::ProfileNode::willExecute):

  • profiler/ProfileNode.h:

(JSC::ProfileNode::create):
(JSC::ProfileNode::operator==):
(JSC::ProfileNode::exec):

  • profiler/Profiler.cpp:

(JSC::dispatchFunctionToProfiles):
(JSC::Profiler::hasCalled):
(JSC::Profiler::willEvaluate):
(JSC::Profiler::willReturn):
(JSC::Profiler::didEvaluate):
(JSC::Profiler::exceptionUnwind):

  • profiler/Profiler.h:
6:58 PM Changeset in webkit [72159] by bweinstein@apple.com
  • 2 edits in trunk/JavaScriptCore

Touch Platform.h to force a rebuild for Windows.

Reviewed by Adam Roben and Steve Falkenburg.

  • wtf/Platform.h:
6:39 PM Changeset in webkit [72158] by sfalken@apple.com
  • 5 edits in trunk

Force a clean build for Windows projects using precompiled headers. Unreviewed.

6:37 PM Changeset in webkit [72157] by mihaip@chromium.org
  • 5 edits
    1 copy in trunk/WebKitTools

2010-11-16 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Tony Chang.

Rebaseline server: display test results
​https://bugs.webkit.org/show_bug.cgi?id=49626

Adds basic result display to the rebaseline server. On the Python side
this involves:

  • Parsing the unexpected_results.json into a dictionary.
  • Serving it as JSON under /results.json. (the JSON -> dict -> JSON transform isn't strictly necessary right now, but I'll need to have access to the parsed results on the Python side for follow-up changes).

On the web UI side this adds:

  • Markup for display image and text results (expected, actual, diff), and JS for populating it.
  • Markup for breaking down test results by failure type and directory, and JS for populating it.
  • Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
  • Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
  • Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
  • Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js: Added.
  • Scripts/webkitpy/tool/commands/rebaselineserver.py:
6:24 PM Changeset in webkit [72156] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-11-16 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Ojan Vafai.

See Chromium issue ​http://codereview.chromium.org/5133001/ - we
are modifying the build bots to pass in the builder name with
the "GPU" string appended instead of appending it in the code.

​https://bugs.webkit.org/show_bug.cgi?id=49636

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
6:21 PM Changeset in webkit [72155] by Adam Roben
  • 2 edits in trunk/WebKit2

Fix horizontal scrolling via the mousewheel/trackpad on Windows

Reviewed by Mark Rowe.

  • Shared/win/WebEventFactory.cpp: Fixed typo in the

WM_VISTA_MOUSEHWHEEL constant.

6:20 PM Changeset in webkit [72154] by mihaip@chromium.org
  • 245 edits
    244 copies
    5 adds in trunk/LayoutTests

2010-11-16 Mihai Parparita <​mihaip@chromium.org>

Update the pixel expectations for fast/reflections, fast/replaced, fast/ruby, fast/runin, and fast/text for the Mac port.

For the tests that currently fail on Snow Leopard with --pixel-tests
--tolerance 0, this moves the current pixel results to mac-leopard and
adds new Snow Leopard-specific results to platform/mac.

List of files omitted due to length but composed entirely of moves from
platform/mac to platform/mac-leopard and newly added files in
platform/mac.

5:49 PM Changeset in webkit [72153] by mihaip@chromium.org
  • 206 edits
    189 copies
    5 adds in trunk/LayoutTests

2010-11-16 Mihai Parparita <​mihaip@chromium.org>

Update the pixel expectations for fast/html, fast/images, fast/innerHTML, fast/inspector-support, fast/loader, fast/media, fast/multicol, and fast/parser for the Mac port.

For the tests that currently fail on Snow Leopard with --pixel-tests
--tolerance 0, this moves the current pixel results to mac-leopard and
adds new Snow Leopard-specific results to platform/mac.

List of files omitted due to length but composed entirely of moves from
platform/mac to platform/mac-leopard and newly added files in
platform/mac.

Also includes updated baselines for fast/forms after r72052 changed how
placeholders are rendered.

5:03 PM Changeset in webkit [72152] by sfalken@apple.com
  • 33 edits in trunk

2010-11-16 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam Roben.

Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
​https://bugs.webkit.org/show_bug.cgi?id=49632

2010-11-16 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam Roben.

Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
​https://bugs.webkit.org/show_bug.cgi?id=49632

  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/WebKit.make:
  • WebKit.vcproj/WebKit.sln:
  • WebKit.vcproj/WebKit.submit.sln:
  • WebKit.vcproj/WebKit.vcproj:
  • WebKit.vcproj/WebKitGUID.vcproj:

2010-11-16 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam Roben.

Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
​https://bugs.webkit.org/show_bug.cgi?id=49632

  • WebCore.vcproj/QTMovieWin.vcproj:
  • WebCore.vcproj/WebCore.make:
  • WebCore.vcproj/WebCore.sln:
  • WebCore.vcproj/WebCore.vcproj:

2010-11-16 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam Roben.

Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
​https://bugs.webkit.org/show_bug.cgi?id=49632

  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/ImageDiff.vcproj:
  • MiniBrowser/MiniBrowser.vcproj:
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:
  • WebKitLauncherWin/WebKitLauncherWin.vcproj:
  • WebKitTestRunner/win/InjectedBundle.vcproj:
  • WebKitTestRunner/win/WebKitTestRunner.vcproj:
  • WinLauncher/WinLauncher.vcproj:
  • record-memory-win/record-memory-win.vcproj:

2010-11-16 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam Roben.

Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
​https://bugs.webkit.org/show_bug.cgi?id=49632

  • win/WebKit2.make:
  • win/WebKit2.submit.sln:
  • win/WebKit2.vcproj:
  • win/WebKit2WebProcess.vcproj:
5:02 PM Changeset in webkit [72151] by mrowe@apple.com
  • 5 edits in trunk

Versioning.

4:49 PM Changeset in webkit [72150] by mrowe@apple.com
  • 1 copy in tags/Safari-534.12

New tag.

4:36 PM Changeset in webkit [72149] by dpranke@chromium.org
  • 4 edits in trunk/WebKitTools

2010-11-16 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: rename TestInfo to TestInput, move image hash to work thread

Rename the TestInfo class to TestInput to be clearer about its
function, and move the checksum-reading code into dump_render_tree_thread
to avoid cross-thread access.

​https://bugs.webkit.org/show_bug.cgi?id=49573

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
4:19 PM Changeset in webkit [72148] by andersca@apple.com
  • 10 edits in trunk/WebKit2

Handle converting a ResourceHandle to a download
​https://bugs.webkit.org/show_bug.cgi?id=49631

Reviewed by Sam Weinig.

  • WebProcess/Downloads/Download.h:

Add startWithHandle.

  • WebProcess/Downloads/DownloadManager.h:
  • WebProcess/Downloads/DownloadManager.cpp:

(WebKit::DownloadManager::convertHandleToDownload):
Create a new Download object and call startWithHandle on it.

  • WebProcess/Downloads/cf/DownloadCFNet.cpp:

(WebKit::Download::startWithHandle):
Add stub.

  • WebProcess/Downloads/mac/DownloadMac.mm:

(WebKit::Download::startWithHandle):
Create an NSURLDownload object from passed in ResourceHandle.

  • WebProcess/Downloads/qt/DownloadQt.cpp:

(WebKit::Download::startWithHandle):
Add stub.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::download):
Call WebFrame::convertHandleToDownload.

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::convertHandleToDownload):
Call DownloadManager::convertHandleToDownload.

4:18 PM Changeset in webkit [72147] by hyatt@apple.com
  • 2 edits in trunk/WebKitTools

Fix bustage. Remove the minimum font size pref setting in DumpRenderTree.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):

3:54 PM Changeset in webkit [72146] by Stephanie Lewis
  • 6 edits in trunk

<rdar://problem/8624267> Leak creating offscreen webview running fast/dom tests

Reviewed by Geoff Garen.

WebKit/mac:

Make a static provider for WebDeviceOrientationProviderMock. The old code allocated a new WebDeviceOrientationProviderMock for
every WebView, and the WebKit API doesn't support that ownership model.

  • WebView/WebDeviceOrientationProviderMock.h:
  • WebView/WebDeviceOrientationProviderMock.mm:

(+[WebDeviceOrientationProviderMock shared]):

WebKitTools:

Use shared DeviceOrientationProviderMock. The old allocation method created a new WebDeviceOrientationProviderMock
for every WebView, and the WebKit API doesn't support that ownership model.

I also fixed a leak in setMockDeviceOrientation by adding a missing release.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(createWebViewAndOffscreenWindow):

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::setMockDeviceOrientation):

3:52 PM Changeset in webkit [72145] by andersca@apple.com
  • 10 edits in trunk

Set the original URL for downloads
​https://bugs.webkit.org/show_bug.cgi?id=49628

Reviewed by John Sullivan.

WebCore:

Export symbols needed by WebKit2.

  • WebCore.exp.in:

WebKit2:

  • WebProcess/Downloads/DownloadManager.cpp:

(WebKit::DownloadManager::startDownload):

  • WebProcess/Downloads/DownloadManager.h:

startDownload now takes the originating web page.

  • WebProcess/Downloads/cf/DownloadCFNet.cpp:

(WebKit::Download::start):
start now takes the originating web page.

  • WebProcess/Downloads/mac/DownloadMac.mm:

(WebKit::originatingURL):
(WebKit::setOriginalURLForDownload):
Port code over from WebKit1 that sets the download URL.

(WebKit::Download::start):
Call setOriginalURLForDownload.

  • WebProcess/Downloads/qt/DownloadQt.cpp:

(WebKit::Download::start):
start now takes the originating web page.

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::startDownload):
Pass the web page to DownloadManager::startDownload.

3:44 PM Changeset in webkit [72144] by hamaji@chromium.org
  • 5 edits
    1 copy in branches/chromium/552/WebCore

Merge 71892 - 2010-11-11 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Darin Adler.

REGRESSION: window.print in onload doesn't fire if there's an img
​https://bugs.webkit.org/show_bug.cgi?id=48195

This issue was introduced in
​https://bugs.webkit.org/show_bug.cgi?id=43658
This happens because FrameLoader::isLoading() is false while an
image is still loading. Now, window.print() happens after all
resources are loaded.

Also changed the name of a member variable as Darin suggested in Bug 43658.

Added a manual test as DRT doesn't support window.print() yet.

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::updateLoading):
  • loader/DocumentLoader.h:
  • page/DOMWindow.cpp: (WebCore::DOMWindow::DOMWindow): (WebCore::DOMWindow::print): (WebCore::DOMWindow::finishedLoading):
  • page/DOMWindow.h:

TBR=​hamaji@chromium.org

3:32 PM Changeset in webkit [72143] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-11-16 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: log the process id in --verbose mode

As part of the switch to multi-process mode, we should log the
process id when running w/ --verbose.

​https://bugs.webkit.org/show_bug.cgi?id=49571

  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
3:29 PM Changeset in webkit [72142] by inferno@chromium.org
  • 3 edits in branches/chromium/552

Merge 72046

BUG=63268

3:28 PM Changeset in webkit [72141] by hyatt@apple.com
  • 26 edits
    4 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=11004

Reviewed by Dan Bernstein.

font-size:0 is ignored. Remove the minimum font size of 1 in CSSStyleSelector.
Change the pref value for minimum font size from 1 to 0. Make sure to never use the NSFont's size,
since it doesn't honor a size of 0. Instead pass the size in to the FontPlatformData(NSFont*) version
of the constructor rather than using [NSFont pointSize].

​https://bugs.webkit.org/show_bug.cgi?id=49582

Negative leading is not handled correctly. There are two bugs here. The first is that
maxAscent and maxDescent can be negative, so we need a notion of whether or not we have
set them before so that we can allow them to be < 0.

The second issue is that we should understand where fonts will end up relative to
our baseline (excluding line height), and only allow those boxes to impact ascent and
descent if the actual font box (without factoring in line height) is above or below the
root line box baseline.

Added fast/css/negative-leading.html

These two bug fixes have to land together to keep the Acid 3 test rendering correctly.

WebCore:

  • WebCore.exp.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):

  • platform/graphics/cocoa/FontPlatformData.h:
  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::FontPlatformData):

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::createFontPlatformData):

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::smallCapsFontData):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::computeLogicalBoxHeights):

  • rendering/InlineFlowBox.h:
  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::alignBoxesInBlockDirection):

WebKit/mac:

  • Misc/WebKitNSStringExtras.mm:

(-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
(-[NSString _web_widthWithFont:]):

  • Misc/WebStringTruncator.mm:

(fontFromNSFont):

  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

WebKit/win:

  • WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):

WebKit2:

  • Shared/WebPreferencesStore.cpp:

(WebKit::WebPreferencesStore::WebPreferencesStore):

LayoutTests:

  • fast/css/negative-leading.html: Added.
  • platform/mac/fast/compact/001-expected.checksum:
  • platform/mac/fast/compact/001-expected.png:
  • platform/mac/fast/compact/001-expected.txt:
  • platform/mac/fast/css/negative-leading-expected.checksum: Added.
  • platform/mac/fast/css/negative-leading-expected.png: Added.
  • platform/mac/fast/css/negative-leading-expected.txt: Added.
  • platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.checksum:
  • platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.png:
  • platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.txt:
  • platform/mac/fast/parser/style-script-head-test-expected.png:
3:27 PM Changeset in webkit [72140] by commit-queue@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-11-16 Peter Varga <​pvarga@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

The number of recursive match calls isn't limited in YARR Interpreter
​https://bugs.webkit.org/show_bug.cgi?id=47906

Check the number of the matchDisjunction recursive calls to avoid unbounded
recursion.
Now the matchDisjunction function returns JSRegExpResult instead of bool.
The JSRegExpResult enum contains the result of matching or the error code
of the failure (like HitLimit) which terminates the matching.
The error codes are based on pcre's jsRegExpExecute error codes.

  • yarr/RegexInterpreter.cpp: (JSC::Yarr::Interpreter::parenthesesDoBacktrack): (JSC::Yarr::Interpreter::matchParentheses): (JSC::Yarr::Interpreter::backtrackParentheses): (JSC::Yarr::Interpreter::matchDisjunction): (JSC::Yarr::Interpreter::matchNonZeroDisjunction): (JSC::Yarr::Interpreter::interpret): (JSC::Yarr::Interpreter::Interpreter):
  • yarr/RegexInterpreter.h:
3:23 PM Changeset in webkit [72139] by inferno@chromium.org
  • 3 edits
    2 copies in branches/chromium/552

Merge 72135

BUG=63031

2:55 PM Changeset in webkit [72138] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Removed lines for tests that are now passing after r72137.

  • platform/chromium/test_expectations.txt:
2:51 PM Changeset in webkit [72137] by Darin Adler
  • 2 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=49611
REGRESSION (r72115): 5 layout tests are broken

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadFrameRequest): Roll change from
​https://bugs.webkit.org/show_bug.cgi?id=48603 out. I'll roll
it back in after fixing the failing tests.

2:43 PM Changeset in webkit [72136] by sfalken@apple.com
  • 3 edits
    2 adds in trunk/WebKit/win

2010-11-16 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam Roben.

Use vsprops files for common settings in Windows WebKit
​https://bugs.webkit.org/show_bug.cgi?id=49622

  • WebKit.vcproj/WebKit.vcproj:
  • WebKit.vcproj/WebKitCommon.vsprops: Added.
2:08 PM Changeset in webkit [72135] by mitz@apple.com
  • 5 edits
    1 move
    2 adds in trunk

<rdar://problem/8672000> REGRESSION (r72040): Error image with alt text can cause style to be frozen in a subtree
​https://bugs.webkit.org/show_bug.cgi?id=49579

Reviewed by Simon Fraser.

WebCore:

r72040 introduced a call to setNeedsStyleRecalc() from RenderImage::imageChanged(). When imageChanged()
got called beneath recalcStyle() on some ancestor element, the result was that the ancestor’s
childNeedsStyleRecalc flag got cleared, but its descendants all the way down to the image did not.
Thereafter, setNeedsStyleRecalc() would fail to propagate from that subtree up to the root. The fix
is to avoid the newly-added setNeedsStyleRecalc() in most cases, including during reclacStyle(), and
just keep it for when it is needed.

Tests: fast/block/float/015.html

fast/images/style-access-during-imageChanged-style-freeze.html

  • dom/Document.cpp:

(WebCore::Document::isPendingStyleRecalc): Added.

  • dom/Document.h:
  • rendering/RenderImage.cpp:

(WebCore::RenderImage::imageChanged): Only defer intrinsic size compoutation if a style recalc
is coming (indicating that current style() is stale).

LayoutTests:

  • fast/block/float/015.html: Copied from LayoutTests/fast/block/float/015.html-disabled.
  • fast/block/float/015.html-disabled: Removed.
  • fast/images/style-access-during-imageChanged-style-freeze-expected.txt: Added.
  • fast/images/style-access-during-imageChanged-style-freeze.html: Added.
1:56 PM Changeset in webkit [72134] by bweinstein@apple.com
  • 2 edits in trunk/JavaScriptCore

Rest of the Windows build fix.

1:52 PM WinCE edited by Patrick Gansterer
(diff)
1:44 PM Changeset in webkit [72133] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed Chromium expectations update.

  • platform/chromium/test_expectations.txt: Added the failure expectations for 5 tests which are failing due to r72115 (and filed bug 49620 about the issue).
1:41 PM Changeset in webkit [72132] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix pt 1.

1:30 PM Changeset in webkit [72131] by andersca@apple.com
  • 3 edits in trunk/WebKit2

Fix clang++ build.

  • Scripts/webkit2/messages.py:
  • WebProcess/WebPage/WebInspector.h:
1:23 PM Changeset in webkit [72130] by zmo@google.com
  • 31 edits in trunk

2010-11-11 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

Implement UNPACK_COLORSPACE_CONVERSION_WEBGL
​https://bugs.webkit.org/show_bug.cgi?id=47196

  • src/WebImageDecoder.cpp: (WebKit::WebImageDecoder::init): Add ignoreGammaAndColorProfile parameter.

2010-11-11 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

Implement UNPACK_COLORSPACE_CONVERSION_WEBGL
​https://bugs.webkit.org/show_bug.cgi?id=47196

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::texImage2DImpl): Apply UNPACK_COLORSPACE_CONVERSION settings to image uploading. (WebCore::WebGLRenderingContext::texSubImage2DImpl): Ditto.
  • platform/graphics/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::extractImageData): Ditto.
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/ImageSource.cpp: (WebCore::ImageSource::ImageSource): Add ignoreGammaColorProfile parameter. (WebCore::ImageSource::setData): Ditto.
  • platform/graphics/ImageSource.h:
  • platform/graphics/cg/GraphicsContext3DCG.cpp: (WebCore::GraphicsContext3D::getImageData): Ditto.
  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::ImageSource): Ditto.
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::getImageData): Ditto.
  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoder::create): Ditto. (WebCore::ImageDecoderQt::ImageDecoderQt): Ditto.
  • platform/graphics/qt/ImageDecoderQt.h:
  • platform/graphics/skia/GraphicsContext3DSkia.cpp: (WebCore::GraphicsContext3D::getImageData): Ditto.
  • platform/image-decoders/ImageDecoder.cpp: (WebCore::ImageDecoder::create): Ditto.
  • platform/image-decoders/ImageDecoder.h: (WebCore::ImageDecoder::ImageDecoder): Ditto.
  • platform/image-decoders/bmp/BMPImageDecoder.cpp: (WebCore::BMPImageDecoder::BMPImageDecoder):
  • platform/image-decoders/bmp/BMPImageDecoder.h:
  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::GIFImageDecoder): Ditto.
  • platform/image-decoders/gif/GIFImageDecoder.h:
  • platform/image-decoders/ico/ICOImageDecoder.cpp: (WebCore::ICOImageDecoder::ICOImageDecoder): Ditto. (WebCore::ICOImageDecoder::decodeAtIndex): Ditto.
  • platform/image-decoders/ico/ICOImageDecoder.h:
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageDecoder::JPEGImageDecoder): Ditto.
  • platform/image-decoders/jpeg/JPEGImageDecoder.h:
  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::PNGImageDecoder): Ditto. (WebCore::PNGImageDecoder::headerAvailable): Ignore gamma settings if ignoreGammaAndColorProfile is true.
  • platform/image-decoders/png/PNGImageDecoder.h:
  • platform/image-decoders/webp/WEBPImageDecoder.cpp: (WebCore::WEBPImageDecoder::WEBPImageDecoder): Add ignoreGammaAndColorProfile parameter.
  • platform/image-decoders/webp/WEBPImageDecoder.h:

2010-11-11 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

Implement UNPACK_COLORSPACE_CONVERSION_WEBGL
​https://bugs.webkit.org/show_bug.cgi?id=47196

  • fast/canvas/webgl/gl-teximage-expected.txt:
  • fast/canvas/webgl/gl-teximage.html: Testing that if UNPACK_COLORSPACE_CONVERSION is NONE, gamma settings are not applied to images.
1:15 PM Changeset in webkit [72129] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Fix clang++ build.

  • WebCoreSupport/WebFrameLoaderClient.mm:
1:12 PM Changeset in webkit [72128] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2010-11-16 Eric Carlson <​eric.carlson@apple.com>

Unreviewed attempt to fix GTK build after ​http://trac.webkit.org/changeset/72117

  • platform/graphics/MediaPlayer.cpp: (WebCore::installedMediaEngines):
1:11 PM Changeset in webkit [72127] by barraclough@apple.com
  • 26 edits
    3 copies in trunk

JavaScriptCore: ​https://bugs.webkit.org/show_bug.cgi?id=49606

Reviewed by Oliver Hunt.

The bug here is that we read the prototype from the RHS argument using a regular
op_get_by_id before op_instanceof has checked that this is an object implementing
HasInstance. This incorrect behaviour gives rise to further unnecessary complexity
in the code base, since we have additional logic (implemented using the
GetByIdExceptionInfo data structures on CodeBlock) to convert not an object errors
from the get_by_id into invalid parameter errors. Having fixed this bug this code
is all redundant, since in these cases the get_by_id will never have been reached.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):
(JSC::CodeBlock::shrinkToFit):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::addExpressionInfo):

  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitCheckHasInstance):

  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp:

(JSC::InstanceOfNode::emitBytecode):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::throwException):
(JSC::Interpreter::privateExecute):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

  • jit/JIT.h:
  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_check_has_instance):
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emitSlow_op_check_has_instance):
(JSC::JIT::emitSlow_op_instanceof):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_check_has_instance):
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emitSlow_op_check_has_instance):
(JSC::JIT::emitSlow_op_instanceof):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • jit/JITStubs.h:
  • runtime/ExceptionHelpers.cpp:

(JSC::createInterruptedExecutionException):
(JSC::createTerminatedExecutionException):
(JSC::createUndefinedVariableError):
(JSC::createNotAFunctionError):
(JSC::createNotAnObjectError):

  • runtime/ExceptionHelpers.h:
  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:
  • runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::toPrimitive):
(JSC::JSNotAnObject::getPrimitiveNumber):
(JSC::JSNotAnObject::toBoolean):
(JSC::JSNotAnObject::toNumber):
(JSC::JSNotAnObject::toString):
(JSC::JSNotAnObject::toObject):
(JSC::JSNotAnObject::getOwnPropertySlot):
(JSC::JSNotAnObject::getOwnPropertyDescriptor):
(JSC::JSNotAnObject::put):
(JSC::JSNotAnObject::deleteProperty):
(JSC::JSNotAnObject::getOwnPropertyNames):

  • runtime/JSNotAnObject.h:

(JSC::JSNotAnObject::JSNotAnObject):

  • runtime/JSObject.h:

(JSC::JSObject::isActivationObject):

  • runtime/JSValue.cpp:

(JSC::JSValue::toObjectSlowCase):
(JSC::JSValue::synthesizeObject):
(JSC::JSValue::synthesizePrototype):

LayoutTests: Bug 49606 - instanceof should only get the prototype property if the RHS operand implements HasInstance

Reviewed by Oliver Hunt.

  • fast/js/instanceof-XMLHttpRequest-expected.txt: Copied from LayoutTests/fast/js/instanceof-operator-expected.txt.
  • fast/js/instanceof-XMLHttpRequest.html: Copied from LayoutTests/fast/js/instanceof-operator.html.
  • fast/js/script-tests/instanceof-XMLHttpRequest.js: Copied from LayoutTests/fast/js/script-tests/instanceof-operator.js.
    • renamed existing testcase; these really test XMLHttpRequest objects, rather than the instanceof operator.
  • fast/js/instanceof-operator-expected.txt:
  • fast/js/script-tests/instanceof-operator.js:
    • added test case for: javascript: ({} instanceof { get prototype(){ alert("Error!"); } })
12:49 PM Changeset in webkit [72126] by andersca@apple.com
  • 5 edits in trunk/WebKit2

Add WKPageCanShowMIMEType
​https://bugs.webkit.org/show_bug.cgi?id=49612

Reviewed by Sam Weinig.

  • UIProcess/API/C/WKPage.cpp:

(WKPageCanShowMIMEType):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::canShowMIMEType):

  • UIProcess/WebPageProxy.h:
11:39 AM Changeset in webkit [72125] by Csaba Osztrogonác
  • 5 edits in trunk/LayoutTests

Unreviewed. Update Qt specific expected results after r72116.

Remove CSS Variable support
​https://bugs.webkit.org/show_bug.cgi?id=49483

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
11:30 AM Changeset in webkit [72124] by zmo@google.com
  • 13 edits in trunk

2010-11-12 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

Refactor GL backend flags
​https://bugs.webkit.org/show_bug.cgi?id=49460

  • public/WebGraphicsContext3D.h: Remove GL flag queries at this level.
  • src/GraphicsContext3DChromium.cpp: Ditto.
  • src/GraphicsContext3DInternal.h: Ditto.
  • src/WebGraphicsContext3DDefaultImpl.cpp: Ditto.
  • src/WebGraphicsContext3DDefaultImpl.h: Ditto.

2010-11-12 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

Refactor GL backend flags
​https://bugs.webkit.org/show_bug.cgi?id=49460

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::WebGLRenderingContext): Call setupFlags(). (WebCore::WebGLRenderingContext::initializeNewContext): Remove flag initialization to setupFlags(). (WebCore::WebGLRenderingContext::setupFlags): Initialize GL flags. (WebCore::WebGLRenderingContext::getRenderbufferParameter): Use accessor function instead of member. (WebCore::WebGLRenderingContext::renderbufferStorage): Ditto.
  • html/canvas/WebGLRenderingContext.h: Use flags set in setupFlags instead of querying underlying GL implementation. (WebCore::WebGLRenderingContext::isGLES2Compliant): (WebCore::WebGLRenderingContext::isGLES2NPOTStrict): (WebCore::WebGLRenderingContext::isErrorGeneratedOnOutOfBoundsAccesses): (WebCore::WebGLRenderingContext::isResourceSafe): (WebCore::WebGLRenderingContext::isDepthStencilSupported):
  • platform/graphics/Extensions3D.h: Add NPOT extension.
  • platform/graphics/GraphicsContext3D.h: Remove GL flag queries at this level.
  • platform/graphics/chromium/Extensions3DChromium.h: Add resource_safe and strict_attribs extensions.
  • platform/graphics/mac/GraphicsContext3DMac.mm: Remove GL flag queries at this level.
11:19 AM Changeset in webkit [72123] by kbr@google.com
  • 29 edits
    2 adds in trunk

2010-11-16 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

WebIDL conversions from string to number and array to number should not generate TypeError
​https://bugs.webkit.org/show_bug.cgi?id=49218

Recent SVG-related changes to the StrictTypeChecking extended attribute in
CodeGeneratorJS.pm and CodeGeneratorV8.pm were not correct according to the Web IDL and
ECMA-262 specifications. In particular, when an attribute or function argument is specified
as a number type (floating-point or integer), passing in a String or object is not supposed
to raise an exception.

The original intent of the StrictTypeChecking extended attribute was to properly raise
TypeError when an interface type is required, but the supplied object does not implement the
interface type (​http://dev.w3.org/2006/webapi/WebIDL/#es-interface). Historically WebKit has
silently passed null to the C++ bindings in this case. The handling of strings in the
original StrictTypeChecking implementation was also incorrect, raising exceptions when it
should not.

The semantics of StrictTypeChecking have been changed to enforce only the restrictions on
interface types. The V8 custom bindings for WebGL have been updated to match the behavior of
the autogenerated code.

Test: fast/canvas/webgl/type-conversion-test.html

  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::getObjectParameter): (WebCore::V8WebGLRenderingContext::getFramebufferAttachmentParameterCallback): (WebCore::V8WebGLRenderingContext::getParameterCallback): (WebCore::V8WebGLRenderingContext::getProgramParameterCallback): (WebCore::V8WebGLRenderingContext::getShaderParameterCallback): (WebCore::vertexAttribAndUniformHelperf):

2010-11-16 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

WebIDL conversions from string to number and array to number should not generate TypeError
​https://bugs.webkit.org/show_bug.cgi?id=49218

Updated SVG tests which were incorrectly expecting exceptions to be raised when the Web IDL
and ECMA-262 specifications state that none should be. Incorporated WebGL test from Khronos
repository verifying the passing objects of various types to APIs.

Ran all layout tests in Safari on Mac OS X.

  • fast/canvas/webgl/type-conversion-test-expected.txt: Added.
  • fast/canvas/webgl/type-conversion-test.html: Added.
  • svg/dom/SVGAngle-expected.txt:
  • svg/dom/SVGAnimatedBoolean-expected.txt:
  • svg/dom/SVGAnimatedEnumeration-expected.txt:
  • svg/dom/SVGAnimatedInteger-expected.txt:
  • svg/dom/SVGAnimatedNumber-expected.txt:
  • svg/dom/SVGLength-expected.txt:
  • svg/dom/SVGMatrix-expected.txt:
  • svg/dom/SVGNumber-expected.txt:
  • svg/dom/SVGPoint-expected.txt:
  • svg/dom/SVGPreserveAspectRatio-expected.txt:
  • svg/dom/SVGRect-expected.txt:
  • svg/dom/SVGTransform-expected.txt:
  • svg/dom/script-tests/SVGAngle.js:
  • svg/dom/script-tests/SVGAnimatedBoolean.js:
  • svg/dom/script-tests/SVGAnimatedEnumeration.js:
  • svg/dom/script-tests/SVGAnimatedInteger.js:
  • svg/dom/script-tests/SVGAnimatedNumber.js:
  • svg/dom/script-tests/SVGLength.js:
  • svg/dom/script-tests/SVGMatrix.js:
  • svg/dom/script-tests/SVGNumber.js:
  • svg/dom/script-tests/SVGPoint.js:
  • svg/dom/script-tests/SVGPreserveAspectRatio.js:
  • svg/dom/script-tests/SVGRect.js:
  • svg/dom/script-tests/SVGTransform.js:
11:00 AM Changeset in webkit [72122] by andersca@apple.com
  • 6 edits in trunk/WebKit2

Make WebPageProxy::decidePolicyForMIMEType a tad synchronous
​https://bugs.webkit.org/show_bug.cgi?id=49605

Reviewed by Sam Weinig.

Change the DecidePolicyForMIMEType message to be synchronous, and if the policy listener is
invoked from within the decidePolicyForMIMEType callback return the policy information as out
parameters. This is needed in order to convert a loading connection to a download.

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::callMemberFunction):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::decidePolicyForMIMEType):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):

10:58 AM Changeset in webkit [72121] by ap@apple.com
  • 2 edits in trunk/WebCore

Windows build fix.

  • DerivedSources.cpp: Removing CSS Variables generated files.
10:50 AM Changeset in webkit [72120] by sfalken@apple.com
  • 2 edits
    1 delete in trunk/WebKit/win

Remove unnecessary def file, remove outdated def files from vcproj.

Rubber stamped by Adam Roben.

  • WebKit.vcproj/WebKit.vcproj:
  • WebKit.vcproj/WebKit_debug.def: Removed.
10:44 AM Changeset in webkit [72119] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2010-11-16 Eric Carlson <​eric.carlson@apple.com>

Reviewed by John Sullivan.

getMIMEType(s)ForExtension should consult system mapping
​https://bugs.webkit.org/show_bug.cgi?id=49497

No new tests possible.

  • platform/MIMETypeRegistry.cpp: (WebCore::MIMETypeRegistry::getMediaMIMETypeForExtension): Add the type returned by getMIMETypeForExtension. Put the result of mediaMIMETypeMap().get() in a local variable and test instead of calling constains() and then get(). (WebCore::MIMETypeRegistry::getMediaMIMETypesForExtension): Ditto.
10:35 AM Changeset in webkit [72118] by sfalken@apple.com
  • 4 edits
    1 add in trunk/LayoutTests

Unreviewed baseline update for Windows.
Update test expectations following r72052.

  • platform/win/fast/blockflow/vertical-font-fallback-expected.txt: Added.
  • platform/win/fast/forms/search-placeholder-value-changed-expected.txt:
  • platform/win/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/win/fast/forms/textarea-placeholder-set-attribute-expected.txt:
10:28 AM Changeset in webkit [72117] by eric.carlson@apple.com
  • 4 edits in trunk/WebCore

2010-11-16 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Darin Adler.

Rename QTKit based media engine class name
​https://bugs.webkit.org/show_bug.cgi?id=36663

No new tests as this just renames a class and restructures existing code.

  • platform/graphics/MediaPlayer.cpp: (WebCore::installedMediaEngines): Use a macro with the platform media player class name to reduce the number of #ifs in the code.
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h: Rename MediaPlayerPrivate to MediaPlayerPrivateQTKit.
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivateQTKit::create): (WebCore::MediaPlayerPrivateQTKit::registerMediaEngine): (WebCore::MediaPlayerPrivateQTKit::MediaPlayerPrivateQTKit): (WebCore::MediaPlayerPrivateQTKit::~MediaPlayerPrivateQTKit): (WebCore::MediaPlayerPrivateQTKit::createQTMovie): (WebCore::MediaPlayerPrivateQTKit::createQTMovieView): (WebCore::MediaPlayerPrivateQTKit::detachQTMovieView): (WebCore::MediaPlayerPrivateQTKit::createQTVideoRenderer): (WebCore::MediaPlayerPrivateQTKit::destroyQTVideoRenderer): (WebCore::MediaPlayerPrivateQTKit::createQTMovieLayer): (WebCore::MediaPlayerPrivateQTKit::destroyQTMovieLayer): (WebCore::MediaPlayerPrivateQTKit::currentRenderingMode): (WebCore::MediaPlayerPrivateQTKit::preferredRenderingMode): (WebCore::MediaPlayerPrivateQTKit::setUpVideoRendering): (WebCore::MediaPlayerPrivateQTKit::tearDownVideoRendering): (WebCore::MediaPlayerPrivateQTKit::hasSetUpVideoRendering): (WebCore::MediaPlayerPrivateQTKit::createQTTime): (WebCore::MediaPlayerPrivateQTKit::resumeLoad): (WebCore::MediaPlayerPrivateQTKit::load): (WebCore::MediaPlayerPrivateQTKit::loadInternal): (WebCore::MediaPlayerPrivateQTKit::prepareToPlay): (WebCore::MediaPlayerPrivateQTKit::platformMedia): (WebCore::MediaPlayerPrivateQTKit::platformLayer): (WebCore::MediaPlayerPrivateQTKit::play): (WebCore::MediaPlayerPrivateQTKit::pause): (WebCore::MediaPlayerPrivateQTKit::duration): (WebCore::MediaPlayerPrivateQTKit::currentTime): (WebCore::MediaPlayerPrivateQTKit::seek): (WebCore::MediaPlayerPrivateQTKit::doSeek): (WebCore::MediaPlayerPrivateQTKit::cancelSeek): (WebCore::MediaPlayerPrivateQTKit::seekTimerFired): (WebCore::MediaPlayerPrivateQTKit::paused): (WebCore::MediaPlayerPrivateQTKit::seeking): (WebCore::MediaPlayerPrivateQTKit::naturalSize): (WebCore::MediaPlayerPrivateQTKit::hasVideo): (WebCore::MediaPlayerPrivateQTKit::hasAudio): (WebCore::MediaPlayerPrivateQTKit::supportsFullscreen): (WebCore::MediaPlayerPrivateQTKit::setVolume): (WebCore::MediaPlayerPrivateQTKit::hasClosedCaptions): (WebCore::MediaPlayerPrivateQTKit::setClosedCaptionsVisible): (WebCore::MediaPlayerPrivateQTKit::setRate): (WebCore::MediaPlayerPrivateQTKit::setPreservesPitch): (WebCore::MediaPlayerPrivateQTKit::buffered): (WebCore::MediaPlayerPrivateQTKit::maxTimeSeekable): (WebCore::MediaPlayerPrivateQTKit::maxTimeLoaded): (WebCore::MediaPlayerPrivateQTKit::bytesLoaded): (WebCore::MediaPlayerPrivateQTKit::totalBytes): (WebCore::MediaPlayerPrivateQTKit::cancelLoad): (WebCore::MediaPlayerPrivateQTKit::cacheMovieScale): (WebCore::MediaPlayerPrivateQTKit::isReadyForVideoSetup): (WebCore::MediaPlayerPrivateQTKit::prepareForRendering): (WebCore::MediaPlayerPrivateQTKit::updateStates): (WebCore::MediaPlayerPrivateQTKit::loadStateChanged): (WebCore::MediaPlayerPrivateQTKit::rateChanged): (WebCore::MediaPlayerPrivateQTKit::sizeChanged): (WebCore::MediaPlayerPrivateQTKit::timeChanged): (WebCore::MediaPlayerPrivateQTKit::didEnd): (WebCore::MediaPlayerPrivateQTKit::setSize): (WebCore::MediaPlayerPrivateQTKit::setVisible): (WebCore::MediaPlayerPrivateQTKit::hasAvailableVideoFrame): (WebCore::MediaPlayerPrivateQTKit::repaint): (WebCore::MediaPlayerPrivateQTKit::paintCurrentFrameInContext): (WebCore::MediaPlayerPrivateQTKit::paint): (WebCore::MediaPlayerPrivateQTKit::getSupportedTypes): (WebCore::MediaPlayerPrivateQTKit::supportsType): (WebCore::MediaPlayerPrivateQTKit::isAvailable): (WebCore::MediaPlayerPrivateQTKit::disableUnsupportedTracks): (WebCore::MediaPlayerPrivateQTKit::sawUnsupportedTracks): (WebCore::MediaPlayerPrivateQTKit::supportsAcceleratedRendering): (WebCore::MediaPlayerPrivateQTKit::acceleratedRenderingStateChanged): (WebCore::MediaPlayerPrivateQTKit::hasSingleSecurityOrigin): (WebCore::MediaPlayerPrivateQTKit::movieLoadType): (WebCore::MediaPlayerPrivateQTKit::setPreload): (WebCore::MediaPlayerPrivateQTKit::mediaTimeForTimeValue): (-[WebCoreMovieObserver initWithCallback:]):
10:25 AM Changeset in webkit [72116] by ap@apple.com
  • 45 edits
    13 deletes in trunk

Reviewed by Dave Hyatt.

​https://bugs.webkit.org/show_bug.cgi?id=49483
Remove CSS Variable support

10:15 AM Changeset in webkit [72115] by Darin Adler
  • 2 edits in trunk/WebCore

2010-11-16 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=48603
Boolean logic mistake in local file check

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadFrameRequest): Fix logic so that both checks have to pass before accepting a local file load.
10:04 AM Changeset in webkit [72114] by Darin Adler
  • 7 edits in trunk

2010-11-15 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Harden additional string functions against large lengths
​https://bugs.webkit.org/show_bug.cgi?id=49574

  • wtf/text/CString.cpp: (WTF::CString::init): Check for length that is too large for CString. (WTF::CString::newUninitialized): Ditto. (WTF::CString::copyBufferIfNeeded): Fix types so the length stays in a size_t.
  • wtf/text/WTFString.cpp: (WTF::String::append): Check for length that is too large.

2010-11-15 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Harden additional string functions against large lengths
​https://bugs.webkit.org/show_bug.cgi?id=49574

  • platform/text/TextCodecUTF16.cpp: (WebCore::TextCodecUTF16::encode): Check for length that is too large for size_t.
  • platform/text/TextStream.cpp: (WebCore::TextStream::operator<<): Check for length that is too large for size_t.
9:56 AM Changeset in webkit [72113] by Martin Robinson
  • 2 edits in trunk/WebKit/gtk

2010-11-16 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Some key-press events can't be handled by WebView
​https://bugs.webkit.org/show_bug.cgi?id=48986

The problem is that "popup-menu" and "show-help" signals are
handled by GtkTextView, as they are added to the key bindings set
of every widget in gtk_widget_class_init(). For all other bindings
handled by GtkTextView we are stopping the signal emission in
their callbacks, so we only need to do the same for "popup-menu"
and "show-help" signals.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::toggleOverwriteCallback): (WebKit::popupMenuCallback): (WebKit::showHelpCallback): (WebKit::EditorClient::EditorClient):
9:50 AM Changeset in webkit [72112] by pfeldman@chromium.org
  • 2 edits
    3 moves
    1 add in trunk/WebKit/chromium

2010-11-16 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Chromium build fix.

  • WebKit.gyp:
  • scripts/concatenate_css_files.py: Renamed from WebKit/chromium/Build/concatenate_css_files.py.
  • scripts/concatenate_js_files.py: Renamed from WebKit/chromium/Build/concatenate_js_files.py.
  • scripts/generate_devtools_html.py: Renamed from WebKit/chromium/Build/generate_devtools_html.py.
9:41 AM Changeset in webkit [72111] by Adam Roben
  • 3 edits
    2 adds in trunk/WebKitTools

Only trigger Windows builds when files that we actually use on Windows are changed

A new Scheduler subclass, PlatformSpecificScheduler, has been added.
It uses the new webkitpy.common.config.build module to determine
whether a particular change should trigger a build on a particular
platform. The Windows builders have been switched to use a
PlatformSpecificScheduler.

The logic to determine whether or not a particular change should
trigger a build on a given platform has only been implemented/tested
for Windows. I tried to make it easy to add more platforms in the
future, but I don't have enough familiarity with all platforms to be
able to implement it for them.

Fixes <​http://webkit.org/b/49407> Windows builders kick off builds for
lots irrelevant changes (e.g., rebaselining Chromium test results)

Reviewed by Eric Seidel.

  • BuildSlaveSupport/build.webkit.org-config/config.json: Use a

PlatformSpecificScheduler for the Windows builders.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(PlatformSpecificScheduler.init): Added. Stores our platform, sets
up a ChangeFilter that filters to our branch and will call through to
our filter method, and calls up to our base class.
(PlatformSpecificScheduler.filter): Calls through to
build.should_build to find out whether we should trigger a build for
this change.

  • Scripts/webkitpy/common/net/build.py: Added.

(_should_file_trigger_build): Uses a set of directories and regexp
patterns to determine whether the given file should trigger a build on
the given platform. As mentioned earlier, this has only been
implemented for Windows, though I did try to make some guesses about
other platforms.
(should_build): Returns true if any of the files should trigger a
build on the given platform.

  • Scripts/webkitpy/common/net/build_unittest.py: Added.

(ShouldBuildTest.test_should_build): Does some basic testing to make
sure we're triggering builds for the right files. It only tests
Windows for now, though I tried to make some guesses about other
platforms.

9:32 AM Changeset in webkit [72110] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-11-16 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Touching inspector controller to make gtk / qt happier.

  • inspector/InspectorController.cpp:
9:31 AM Changeset in webkit [72109] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-11-16 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Show default context menu for the currently focused element when activated with keyboard
​https://bugs.webkit.org/show_bug.cgi?id=49376

  • webkit/webkitwebview.cpp: (webkit_web_view_popup_menu_handler):
9:19 AM Changeset in webkit [72108] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-16 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update.

A couple of SVG tests don't time out on the Mac.

  • platform/chromium/test_expectations.txt:
9:16 AM Changeset in webkit [72107] by mihaip@chromium.org
  • 2 edits
    6 adds in trunk/LayoutTests

2010-11-16 Mihai Parparita <​mihaip@chromium.org>

Unreviewed baseline update.

Add pixel baselines for fast/images/gray-scale-png-with-color-profile.html,
originally added by r71461.

  • platform/chromium-mac/fast/images/gray-scale-png-with-color-profile-expected.checksum: Added.
  • platform/chromium-mac/fast/images/gray-scale-png-with-color-profile-expected.png: Added.
  • platform/chromium-win/fast/images/gray-scale-png-with-color-profile-expected.checksum: Added.
  • platform/chromium-win/fast/images/gray-scale-png-with-color-profile-expected.png: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/images/gray-scale-png-with-color-profile-expected.checksum: Added.
  • platform/mac/fast/images/gray-scale-png-with-color-profile-expected.png: Added.
9:14 AM Changeset in webkit [72106] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-11-16 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Use gdk_pixbuf_get_from_surface() when available
​https://bugs.webkit.org/show_bug.cgi?id=49532

  • platform/graphics/gtk/GdkCairoUtilities.cpp: (cairoImageSurfaceToGdkPixbuf):
9:13 AM Changeset in webkit [72105] by bulach@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-16 Marcus Bulach <​bulach@chromium.org>

Not reviewed, chromium test expectation and baselines update.

Re-adds a couple of tests_expectations wrongly excluded by r72099
​https://bugs.webkit.org/show_bug.cgi?id=49599

  • platform/chromium/test_expectations.txt:
9:06 AM Changeset in webkit [72104] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-16 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update.

Remove expectations for tests that now pass:

  • r71993 made svg/W3C-SVG-1.1/fonts-desc-02-t.svg passes again (with the current baselines)
  • fast/forms/search-styled.html and fast/forms/search-placeholder-value-changed.html were rebaselined by r72073
  • platform/chromium/test_expectations.txt:
8:44 AM Changeset in webkit [72103] by pfeldman@chromium.org
  • 2 edits
    4 adds in trunk/WebKit/chromium

2010-11-16 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Chrome DevTools: concatenate CSS files, do not link
missing JS files in release mode.
​https://bugs.webkit.org/show_bug.cgi?id=49586

  • Build/concatenate_css_files.py: Added.
  • Build/concatenate_js_files.py: Added.
  • Build/generate_devtools_html.py: Added.
  • WebKit.gyp:
8:42 AM Changeset in webkit [72102] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-11-16 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: init front-end UI upon DOMContentLoaded, not load event.
​https://bugs.webkit.org/show_bug.cgi?id=49596

  • inspector/front-end/inspector.js: (windowLoaded):
8:28 AM Changeset in webkit [72101] by Simon Hausmann
  • 11 edits in trunk

[Qt] Remove synchronous QWebPage::checkPermissions signal
​https://bugs.webkit.org/show_bug.cgi?id=46810

Reviewed by Andreas Kling.

WebKit/qt:

As decided in the API review, we remove this signal and replace its only use currently
with cached credentials.

  • Api/qwebpage.cpp:

(QWebPage::setUserPermission): Pass the WebCore frame instead of the QWebFrame.

  • Api/qwebpage.h:
  • WebCoreSupport/NotificationPresenterClientQt.cpp:

(WebCore::NotificationPresenterClientQt::checkPermission): Replaced explicit
signal emission with hash lookup of previously granted permission (or not).
(WebCore::NotificationPresenterClientQt::cancelRequestsForPermission): Remove
any previously cached/granted permission for the given script execution context.
(WebCore::NotificationPresenterClientQt::allowNotificationForFrame): Do not
only serve pending permission requests but before calling the JS callbacks, remember
the permission for subsequent synchronous checkPermission() calls.

  • WebCoreSupport/NotificationPresenterClientQt.h: Add cache for permissions.

WebKitTools:

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::WebPage):

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::grantDesktopNotificationPermission): When granting
permission, grant it directly on the QWebPage/Frame, that will remember it.

  • QtTestBrowser/webpage.cpp:

(WebPage::WebPage):

  • QtTestBrowser/webpage.h:
8:14 AM Changeset in webkit [72100] by andreas.kling@nokia.com
  • 11 edits in trunk/WebKit2

2010-11-16 Kenneth Rohde Christiansen <​kenneth@webkit.org>, Zalan Bujtas <​zbujtas@gmail.com>

Reviewed by Andreas Kling.

[WK2][Qt] Add API for finding a zoomable area for a given point

This is useful for implementing e.g "double tap zoom"

Only enabled for Qt.

  • UIProcess/API/qt/qwkpage.cpp: (QWKPage::findZoomableAreaForPoint): (QWKPagePrivate::didFindZoomableArea):
  • UIProcess/API/qt/qwkpage.h:
  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didFindZoomableArea): (WebKit::WebPageProxy::findZoomableAreaForPoint):
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::findZoomableAreaForPoint):
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
8:03 AM Changeset in webkit [72099] by bulach@chromium.org
  • 2 edits
    110 adds in trunk/LayoutTests

2010-11-16 Marcus Bulach <​bulach@chromium.org>

Not reviewed, chromium test expectation and baselines update.

Update chromium baselines following r72092
​https://bugs.webkit.org/show_bug.cgi?id=49595

  • platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGGElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGGElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGGElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGGElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPathElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPathElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPathElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPathElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPolygonElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPolygonElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPolygonElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPolygonElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPolylineElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPolylineElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPolylineElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPolylineElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGSVGElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGSVGElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGSVGElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGSVGElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCircleElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCircleElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCircleElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCircleElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGGElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGGElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGGElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGGElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.txt: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.txt: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPathElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPathElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPathElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPathElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPolygonElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPolygonElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPolygonElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPolygonElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPolylineElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPolylineElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPolylineElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPolylineElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGSVGElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGSVGElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGSVGElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGSVGElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium/test_expectations.txt:
7:52 AM Changeset in webkit [72098] by abecsi@webkit.org
  • 5 edits
    4 adds in trunk

2010-11-16 Andras Becsi <​abecsi@inf.u-szeged.hu>

Reviewed by Csaba Osztrogonác.

[Qt] Add isPrinting and setPrinting methods to DRT's LayoutTestController.
Add previously removed expected file, png and checksum.

  • platform/qt/Skipped:
  • platform/qt/printing/page-rule-in-media-query-expected.checksum: Added.
  • platform/qt/printing/page-rule-in-media-query-expected.png: Added.
  • platform/qt/printing/page-rule-in-media-query-expected.txt: Added.

2010-11-16 Andras Becsi <​abecsi@inf.u-szeged.hu>

Reviewed by Csaba Osztrogonác.

[Qt] Add isPrinting and setPrinting methods to DRT's LayoutTestController.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset):
  • DumpRenderTree/qt/LayoutTestControllerQt.h: (LayoutTestController::isPrinting): (LayoutTestController::setPrinting):
7:45 AM Changeset in webkit [72097] by leandro@webkit.org
  • 2 edits in trunk/WebKit/efl

2010-11-16 Leandro Pereira <​leandro@profusion.mobi>

[EFL] Unreviewed. Build fix.

  • WebCoreSupport/FrameLoaderClientEfl.h: Also include ResourceError.h.
7:25 AM Changeset in webkit [72096] by apavlov@chromium.org
  • 10 edits
    3 adds in trunk

2010-11-15 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Migrate frontend to the new CSS editing/retrieval API
​https://bugs.webkit.org/show_bug.cgi?id=49492

Test: inspector/styles-new-API.html

WebCore:

  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.routine): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.styleSheetCallback): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.allStylesCallback): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.receivedImages):
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype.getStylesAsync): (WebInspector.CSSStyleModel.prototype.getComputedStyleAsync): (WebInspector.CSSStyleModel.prototype.getInlineStyleAsync): (WebInspector.CSSStyleModel.prototype.setRuleSelector): (WebInspector.CSSStyleModel.prototype.setRuleSelector.callback): (WebInspector.CSSStyleModel.prototype.addRule): (WebInspector.CSSStyleModel.prototype.addRule.callback): (WebInspector.CSSStyleDeclaration): (WebInspector.CSSStyleDeclaration.prototype.propertyAt): (WebInspector.CSSStyleDeclaration.prototype.pastLastSourcePropertyIndex): (WebInspector.CSSStyleDeclaration.prototype.newBlankProperty): (WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt): (WebInspector.CSSStyleDeclaration.prototype.appendProperty): (WebInspector.CSSRule): (WebInspector.CSSProperty.prototype.get propertyText): (WebInspector.CSSProperty.prototype.setText): (WebInspector.CSSProperty.prototype.setDisabled): (WebInspector.CSSStyleSheet): (WebInspector.CSSStyleSheet.createForId): (WebInspector.CSSStyleSheet.prototype.getText): (WebInspector.CSSStyleSheet.prototype.setText):
  • inspector/front-end/Settings.js:
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection.prototype.onpopulate): (WebInspector.StylePropertiesSection.prototype.addNewBlankProperty): (WebInspector.StylePropertiesSection.prototype._debugShowStyle.removeStyleBox): (WebInspector.StylePropertiesSection.prototype._debugShowStyle): (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted): (WebInspector.StylePropertyTreeElement.prototype): (WebInspector.StylePropertyTreeElement.prototype.):
  • inspector/front-end/inspector.css: (.styles-section .properties li.not-parsed-ok): (.styles-section .properties li.not-parsed-ok::before): (.styles-section .properties .inactive):

LayoutTests:

  • inspector/audits-panel-functional-expected.txt:
  • inspector/elements-panel-styles-expected.txt:
  • inspector/resources/styles-new-API.css: Added. (html): (body): (/* comment before selector */body.main1/* comment after selector */): (body.main2): (body::after): (h1):
  • inspector/styles-new-API-expected.txt: Added.
  • inspector/styles-new-API.html: Added.
6:40 AM Changeset in webkit [72095] by apavlov@chromium.org
  • 7 edits
    11 adds
    1 delete in trunk

2010-11-16 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r72082.
​http://trac.webkit.org/changeset/72082
​https://bugs.webkit.org/show_bug.cgi?id=49594

"broken SnowLeopard build" (Requested by apavlov on #webkit).

  • fast/css/CSSPrimitiveValue-exceptions-expected.txt:
  • fast/css/getFloatValueForUnit-expected.txt: Removed.
  • fast/css/getFloatValueForUnit.html:
  • fast/css/resources/CSSPrimitiveValue-exceptions.js:
  • platform/chromium-linux/fast/css/getFloatValueForUnit-expected.checksum: Added.
  • platform/chromium-linux/fast/css/getFloatValueForUnit-expected.png: Added.
  • platform/chromium-win/fast/css/getFloatValueForUnit-expected.checksum: Added.
  • platform/chromium-win/fast/css/getFloatValueForUnit-expected.png: Added.
  • platform/chromium-win/fast/css/getFloatValueForUnit-expected.txt: Added.
  • platform/mac-leopard/fast/css/getFloatValueForUnit-expected.checksum: Added.
  • platform/mac-leopard/fast/css/getFloatValueForUnit-expected.png: Added.
  • platform/mac/fast/css/getFloatValueForUnit-expected.checksum: Added.
  • platform/mac/fast/css/getFloatValueForUnit-expected.png: Added.
  • platform/mac/fast/css/getFloatValueForUnit-expected.txt: Added.
  • platform/qt/fast/css/getFloatValueForUnit-expected.txt: Added.

2010-11-16 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r72082.
​http://trac.webkit.org/changeset/72082
​https://bugs.webkit.org/show_bug.cgi?id=49594

"broken SnowLeopard build" (Requested by apavlov on #webkit).

  • css/CSSPrimitiveValue.cpp: (WebCore::scaleFactorForConversion): (WebCore::CSSPrimitiveValue::getDoubleValue): (WebCore::CSSPrimitiveValue::getIdent):
  • css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::getFloatValue): (WebCore::CSSPrimitiveValue::getIntValue):
6:23 AM Changeset in webkit [72094] by apavlov@chromium.org
  • 2 edits in trunk/WebCore

2010-11-16 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r72087.
​http://trac.webkit.org/changeset/72087
​https://bugs.webkit.org/show_bug.cgi?id=49593

"broken build" (Requested by apavlov on #webkit).

  • css/CSSPrimitiveValue.cpp: (WebCore::unitCategory):
6:23 AM Changeset in webkit [72093] by andreas.kling@nokia.com
  • 5 edits in trunk/WebKit2

2010-11-16 Andreas Kling <​kling@webkit.org>

Rubber-stamped by Simon Hausmann.

Revert !ENABLE(INSPECTOR) fix- we don't need it right now,
and it was less maintainable than I had though.

  • Shared/API/c/WKSharedAPICast.h: (WebKit::toAPI): (WebKit::toImpl):
  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:
  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
  • WebProcess/WebPage/WebInspector.cpp:
6:14 AM Changeset in webkit [72092] by Nikolas Zimmermann
  • 1 edit
    52 adds in trunk/LayoutTests

2010-11-16 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.


Add missing pixel test results that Rob forgot to add.

  • platform/mac/svg/dynamic-updates/SVGCircleElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGCircleElement-dom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGCircleElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGCircleElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-dom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGForeignObjectElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGForeignObjectElement-dom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGForeignObjectElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGForeignObjectElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGGElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGGElement-dom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGGElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGGElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGImageElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGImageElement-dom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGPathElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGPathElement-dom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGPathElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGPathElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGPolygonElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGPolygonElement-dom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGPolygonElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGPolygonElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGPolylineElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGPolylineElement-dom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGPolylineElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGPolylineElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGRectElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGRectElement-dom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGRectElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGRectElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGSVGElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGSVGElement-dom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGSVGElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGSVGElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGTextElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGTextElement-dom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.png: Added.
5:44 AM Changeset in webkit [72091] by andreas.kling@nokia.com
  • 5 edits in trunk/WebKit2

2010-11-16 Andreas Kling <​kling@webkit.org>

Reviewed by Simon Hausmann.

Fix compilation with !ENABLE(INSPECTOR)

  • Shared/API/c/WKSharedAPICast.h: (WebKit::toAPI): (WebKit::toImpl):
  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:
  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
  • WebProcess/WebPage/WebInspector.cpp:
5:42 AM Changeset in webkit [72090] by pfeldman@chromium.org
  • 12 edits
    1 move
    1 delete in trunk

2010-11-15 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: rename StoragePanel to ResourcesPanel.
​https://bugs.webkit.org/show_bug.cgi?id=49534

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/DatabaseQueryView.js: (WebInspector.DatabaseQueryView.prototype._queryFinished):
  • inspector/front-end/DatabaseTableView.js: (WebInspector.DatabaseTableView.prototype._queryFinished):
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onRevealAndSelectResource):
  • inspector/front-end/Images/storageIcon.png: Removed.
  • inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager.prototype.setOverrideContent): (WebInspector.ResourceTreeModel.prototype.addOrUpdateFrame): (WebInspector.ResourceTreeModel.prototype.didCommitLoadForFrame): (WebInspector.ResourceTreeModel.prototype.frameDetachedFromParent): (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources): (WebInspector.ResourceTreeModel.prototype.addResourceToFrame):
  • inspector/front-end/StoragePanel.js: Removed.
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css: (.resources.panel .sidebar): (.resources.panel .sidebar li): (.resources.panel .sidebar li.parent): (.resources.panel .sidebar li.selected): (.resources.panel .sidebar li.selected .selection): (.resources.panel .sidebar :focus li.selected .selection): (body.inactive .resources.panel .sidebar li.selected .selection): (.resources.panel .sidebar .icon): (.resources.panel .base-storage-tree-element-title): (.resources.panel .status): (.resources.panel li .status .bubble):
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector._createPanels): (WebInspector.openResource): (WebInspector.showPanel): (WebInspector.selectDatabase): (WebInspector.selectDOMStorage): (WebInspector.addDatabase): (WebInspector.addDOMStorage): (WebInspector.updateDOMStorage): (WebInspector.updateApplicationCacheStatus): (WebInspector.didGetFileSystemPath): (WebInspector.didGetFileSystemError): (WebInspector.didGetFileSystemDisabled): (WebInspector.updateNetworkState): (WebInspector._choosePanelToShowSourceLine):
5:23 AM Changeset in webkit [72089] by kbalazs@webkit.org
  • 6 edits in trunk/WebKitTools

2010-11-16 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Andreas Kling.

[Qt][WK2] Add a way to turn on tiled backing store in MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=49587

  • MiniBrowser/qt/BrowserView.cpp: (BrowserView::BrowserView): Added BackingStoreType argument to ctor. Propagating it to the QGraphicsWKView.
  • MiniBrowser/qt/BrowserView.h:
  • MiniBrowser/qt/BrowserWindow.cpp: (BrowserWindow::BrowserWindow): (BrowserWindow::newWindow): Create the new BrowserWindow with the same BackingStoreType that this instance has.
  • MiniBrowser/qt/BrowserWindow.h: Added BackingStoreType member.
  • MiniBrowser/qt/main.cpp: (main): Use tiled backing store if got -tiled command line argument. Avoid redundant copy of command line args.
5:10 AM Changeset in webkit [72088] by abecsi@webkit.org
  • 2 edits in trunk/WebKit2

2010-11-16 Andras Becsi <​abecsi@webkit.org>

Reviewed by Andreas Kling.

[Qt] Use SIGINT instead of SIGKILL to let the web process clean up after itself.

  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp: (WebKit::QtWebProcess::setupChildProcess):
5:06 AM Changeset in webkit [72087] by apavlov@chromium.org
  • 2 edits in trunk/WebCore

2010-11-16 Alexander Pavlov <​apavlov@chromium.org>

Unreviewed SnowLeopard build fix.

  • css/CSSPrimitiveValue.cpp: (WebCore::unitCategory):
4:55 AM Changeset in webkit [72086] by andreas.kling@nokia.com
  • 10 edits in trunk/WebKit2

2010-11-16 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Andreas Kling.

[WK2][Qt] Expose resizes-to-contents mode in WebKit2

Only available with ENABLE(TILED_BACKING_STORE)

Based on a patch by Antti Koivisto.

  • UIProcess/API/qt/qwkpage.cpp: (QWKPage::setResizesToContentsUsingLayoutSize):
  • UIProcess/API/qt/qwkpage.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setResizesToContentsUsingLayoutSize):
  • UIProcess/WebPageProxy.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::contentsSizeChanged):
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::setSize): (WebKit::WebPage::setResizesToContentsUsingLayoutSize): (WebKit::WebPage::resizeToContentsIfNeeded):
  • WebProcess/WebPage/WebPage.h: (WebKit::WebPage::resizesToContentsEnabled): (WebKit::WebPage::resizesToContentsLayoutSize):
  • WebProcess/WebPage/WebPage.messages.in:
4:46 AM Changeset in webkit [72085] by andreas.kling@nokia.com
  • 2 edits in trunk

2010-11-16 Andreas Kling <​kling@webkit.org>

Unreviewed typo fix for previous commit.

  • common.pri:
4:26 AM Changeset in webkit [72084] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-11-16 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Andreas Kling.

Viewport meta tag: Fix geometry computation

Available width and height should also be divided by the device pixel ratio.

  • dom/ViewportArguments.cpp: (WebCore::computeViewportAttributes):
  • platform/network/qt/DnsPrefetchHelper.cpp:
4:22 AM Changeset in webkit [72083] by Csaba Osztrogonác
  • 2 edits
    1 delete in trunk/LayoutTests

Unreviewed.

[Qt] Add printing/page-rule-in-media-query.html to the skipped
list because of missing layoutTestController.setPrinting().

And remove incorrect Qt specific expected result.

  • platform/qt/Skipped: printing/page-rule-in-media-query.html added until fix.
  • platform/qt/printing: Removed.
  • platform/qt/printing/page-rule-in-media-query-expected.checksum: Removed.
  • platform/qt/printing/page-rule-in-media-query-expected.png: Removed.
  • platform/qt/printing/page-rule-in-media-query-expected.txt: Removed.
4:12 AM Changeset in webkit [72082] by apavlov@chromium.org
  • 7 edits
    1 add
    11 deletes in trunk

2010-11-12 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Simon Fraser.

CSSPrimitiveValue.getFloatValue does not convert sizes

Extended getFloatValueForUnit and CSSPrimitiveValue tests. The former has been made text-only,
which allowed to get rid of a number of unnecessary baselines.
​https://bugs.webkit.org/show_bug.cgi?id=35770

  • fast/css/CSSPrimitiveValue-exceptions-expected.txt:
  • fast/css/getFloatValueForUnit-expected.txt: Added.
  • fast/css/getFloatValueForUnit.html:
  • fast/css/resources/CSSPrimitiveValue-exceptions.js:
  • platform/chromium-linux/fast/css/getFloatValueForUnit-expected.checksum: Removed.
  • platform/chromium-linux/fast/css/getFloatValueForUnit-expected.png: Removed.
  • platform/chromium-win/fast/css/getFloatValueForUnit-expected.checksum: Removed.
  • platform/chromium-win/fast/css/getFloatValueForUnit-expected.png: Removed.
  • platform/chromium-win/fast/css/getFloatValueForUnit-expected.txt: Removed.
  • platform/mac-leopard/fast/css/getFloatValueForUnit-expected.checksum: Removed.
  • platform/mac-leopard/fast/css/getFloatValueForUnit-expected.png: Removed.
  • platform/mac/fast/css/getFloatValueForUnit-expected.checksum: Removed.
  • platform/mac/fast/css/getFloatValueForUnit-expected.png: Removed.
  • platform/mac/fast/css/getFloatValueForUnit-expected.txt: Removed.
  • platform/qt/fast/css/getFloatValueForUnit-expected.txt: Removed.

2010-11-12 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Simon Fraser.

CSSPrimitiveValue.getFloatValue does not convert sizes
​https://bugs.webkit.org/show_bug.cgi?id=35770

Implemented all same-category unit conversions (length, angle, time, frequency) and retained
absolute-relative (cm, mm, in, pt, pc) length conversions intact.
Illegal unit conversion attempts will throw an INVALID_ACCESS_ERR DOMException.

  • css/CSSPrimitiveValue.cpp: (WebCore::unitCategory): (WebCore::scaleFactorForConversion): (WebCore::CSSPrimitiveValue::getDoubleValue): (WebCore::CSSPrimitiveValue::canonicalUnitTypeForCategory): (WebCore::CSSPrimitiveValue::getDoubleValueInternal):
  • css/CSSPrimitiveValue.h:
4:11 AM Changeset in webkit [72081] by andreas.kling@nokia.com
  • 2 edits in trunk

2010-11-16 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt][Scratchbox] Use gold linker explicitly when available

gold is faster at linking QtWebKit than binutils ld, but it cannot be
enabled by default on a system that compiles other Qt projects.
This is due to gold not supporting the --add-needed flag.

Original patch by Kimmo Kinnunen.

  • common.pri:
4:06 AM Changeset in webkit [72080] by andreas.kling@nokia.com
  • 2 edits in trunk/WebKit2

2010-11-16 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt][WK2] Get proxy settings from environment (http[s]_proxy)

If http_proxy and/or https_proxy are set in the environment,
pass those in to QNetworkAccessManager.

  • WebProcess/qt/WebProcessMainQt.cpp: (WebKit::EnvHttpProxyFactory::EnvHttpProxyFactory): (WebKit::EnvHttpProxyFactory::initializeFromEnvironment): (WebKit::EnvHttpProxyFactory::queryProxy): (WebKit::initializeProxy): (WebKit::WebProcessMainQt):
3:56 AM Changeset in webkit [72079] by andreas.kling@nokia.com
  • 2 edits in trunk

2010-11-16 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Add 'valgrind' build mode

Passing CONFIG+=valgrind to qmake will now build WebKit in a way
suitable for debugging with Valgrind.

Original patch by Christian Sejersen.

  • WebKit.pri:
3:53 AM Changeset in webkit [72078] by andreas.kling@nokia.com
  • 3 edits in trunk/WebKit2

2010-11-16 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt][WK2] Emit windowCloseRequested signal on window.close()

Original patch by Zalan Bujtas.

  • UIProcess/API/qt/ClientImpl.cpp: (qt_wk_close):
  • UIProcess/API/qt/qwkpage.h:
3:50 AM Changeset in webkit [72077] by andreas.kling@nokia.com
  • 2 edits in trunk/WebKit2

2010-11-15 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Kill the web process if the UI process dies

Connect UI (parent) process death signal to SIGKILL of the web
process (child). This ensures that there's no stale web processes
after the UI process has crashed.

Original patch by Kimmo Kinnunen.

  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp: (WebKit::QtWebProcess::QtWebProcess): (WebKit::QtWebProcess::setupChildProcess): (WebKit::ProcessLauncherHelper::launch):
3:45 AM Changeset in webkit [72076] by bulach@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2010-11-16 Marcus Bulach <​bulach@chromium.org>

Not reviewed, chromium test expectation update.

Update chromium baselines following r72063
​https://bugs.webkit.org/show_bug.cgi?id=49591

  • platform/chromium-mac/fast/js/function-prototype-descriptor-expected.txt: Added.
  • platform/chromium-win/fast/js/function-prototype-descriptor-expected.txt: Added.
3:34 AM Changeset in webkit [72075] by bulach@chromium.org
  • 5 edits in trunk/LayoutTests

2010-11-16 Marcus Bulach <​bulach@chromium.org>

Not reviewed, chromium test expectation update.

Update chromium baselines following r72050
​https://bugs.webkit.org/show_bug.cgi?id=49590

  • platform/chromium-mac/fast/css/font-face-descriptor-multiple-values-parsing-expected.txt:
  • platform/chromium-mac/fast/js/exception-thrown-from-new-expected.txt:
  • platform/chromium-win/fast/css/font-face-descriptor-multiple-values-parsing-expected.txt:
  • platform/chromium-win/fast/js/exception-thrown-from-new-expected.txt:
3:31 AM Changeset in webkit [72074] by Simon Hausmann
  • 2 edits in trunk/WebKit2

[Qt] Trivial build fix for building WebKit2 inside Qt Creator

Rubber-stamped by Andreas Kling.

Similar to WebCore.pro, define a fallback for OUTPUT_DIR.

  • WebKit2.pro:
3:10 AM Changeset in webkit [72073] by bulach@chromium.org
  • 30 edits
    1 copy
    17 adds
    2 deletes in trunk/LayoutTests

2010-11-16 Marcus Bulach <​bulach@chromium.org>

Not reviewed, chromium test expectation update.

Update chromium baselines following r72052
​https://bugs.webkit.org/show_bug.cgi?id=49588

  • platform/chromium-linux/fast/forms/placeholder-pseudo-style-expected.checksum:
  • platform/chromium-linux/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/chromium-linux/fast/forms/placeholder-stripped-expected.checksum:
  • platform/chromium-linux/fast/forms/placeholder-stripped-expected.png:
  • platform/chromium-linux/fast/forms/search-placeholder-value-changed-expected.checksum:
  • platform/chromium-linux/fast/forms/search-placeholder-value-changed-expected.png:
  • platform/chromium-linux/fast/forms/search-styled-expected.checksum: Added.
  • platform/chromium-linux/fast/forms/search-styled-expected.png: Added.
  • platform/chromium-linux/fast/forms/search-styled-expected.txt: Added.
  • platform/chromium-linux/fast/forms/textarea-placeholder-pseudo-style-expected.checksum:
  • platform/chromium-linux/fast/forms/textarea-placeholder-pseudo-style-expected.png:
  • platform/chromium-mac/fast/css/pseudo-cache-stale-expected.checksum: Added.
  • platform/chromium-mac/fast/css/pseudo-cache-stale-expected.png: Added.
  • platform/chromium-mac/fast/forms/isindex-placeholder-expected.checksum:
  • platform/chromium-mac/fast/forms/isindex-placeholder-expected.png:
  • platform/chromium-mac/fast/forms/password-placeholder-text-security-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/password-placeholder-text-security-expected.png: Added.
  • platform/chromium-mac/fast/forms/placeholder-pseudo-style-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/placeholder-pseudo-style-expected.png: Added.
  • platform/chromium-mac/fast/forms/placeholder-stripped-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/placeholder-stripped-expected.png: Added.
  • platform/chromium-mac/fast/forms/search-placeholder-value-changed-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/search-placeholder-value-changed-expected.png: Added.
  • platform/chromium-mac/fast/forms/search-styled-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/search-styled-expected.png: Added.
  • platform/chromium-mac/fast/forms/textarea-placeholder-pseudo-style-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/textarea-placeholder-pseudo-style-expected.png: Added.
  • platform/chromium-win-xp/fast/forms/search-styled-expected.checksum: Removed.
  • platform/chromium-win-xp/fast/forms/search-styled-expected.png: Removed.
  • platform/chromium-win-xp/fast/forms/search-styled-expected.txt:
  • platform/chromium-win/fast/css/pseudo-cache-stale-expected.txt:
  • platform/chromium-win/fast/forms/isindex-placeholder-expected.txt:
  • platform/chromium-win/fast/forms/password-placeholder-expected.txt:
  • platform/chromium-win/fast/forms/password-placeholder-text-security-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.checksum:
  • platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-set-attribute-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-stripped-expected.checksum:
  • platform/chromium-win/fast/forms/placeholder-stripped-expected.png:
  • platform/chromium-win/fast/forms/placeholder-stripped-expected.txt:
  • platform/chromium-win/fast/forms/search-placeholder-value-changed-expected.txt:
  • platform/chromium-win/fast/forms/search-styled-expected.checksum:
  • platform/chromium-win/fast/forms/search-styled-expected.png:
  • platform/chromium-win/fast/forms/search-styled-expected.txt: Copied from LayoutTests/platform/chromium-win-xp/fast/forms/search-styled-expected.txt.
  • platform/chromium-win/fast/forms/textarea-placeholder-pseudo-style-expected.checksum:
  • platform/chromium-win/fast/forms/textarea-placeholder-pseudo-style-expected.png:
  • platform/chromium-win/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/chromium-win/fast/forms/textarea-placeholder-set-attribute-expected.txt:
2:59 AM Changeset in webkit [72072] by pfeldman@chromium.org
  • 8 edits in trunk/WebCore

2010-11-15 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: extract HTML title setter in treeoutline.js.
​https://bugs.webkit.org/show_bug.cgi?id=49540

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.adjustCollapsedRange): (WebInspector.ElementsTreeElement.prototype.updateTitle):
  • inspector/front-end/treeoutline.js: (TreeElement.prototype.get titleHTML): (TreeElement.prototype.set titleHTML): (TreeElement.prototype._setListItemNodeContent):
2:54 AM Changeset in webkit [72071] by commit-queue@webkit.org
  • 7 edits in trunk

2010-11-16 John Knottenbelt <​jknotten@chromium.org>

Reviewed by Jeremy Orlow.

Assert that DeviceOrientationClientMock is used by only one controller.
​https://bugs.webkit.org/show_bug.cgi?id=48506

This is a design constraint of the DeviceOrientationClientMock because the
m_controller field can only store a pointer to a single instance of the
corresponding DeviceOrientationController.

  • platform/mock/DeviceOrientationClientMock.cpp: (WebCore::DeviceOrientationClientMock::setController):

2010-11-16 John Knottenbelt <​jknotten@chromium.org>

Reviewed by Jeremy Orlow.

Move DeviceOrientationClientMock from LayoutTestController to WebViewHost.
​https://bugs.webkit.org/show_bug.cgi?id=48506

This ensures that there is one mock per page WebView / WebViewHost. This is a
design constraint of the DeviceOrientationClientMock because the m_controller
field can only store a pointer to a single instance of the corresponding
DeviceOrientationController.

Test: fast/dom/DeviceOrientation/no-page-cache.html

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setMockDeviceOrientation): (LayoutTestController::deviceOrientationClientMock):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::deviceOrientationClientMock): (WebViewHost::deviceOrientationClient): (WebViewHost::reset):
  • DumpRenderTree/chromium/WebViewHost.h:
2:51 AM Changeset in webkit [72070] by Csaba Osztrogonác
  • 6 edits in trunk/LayoutTests

Unreviewed. Update Qt specific expected results after r72052.

  • platform/qt/fast/css/pseudo-cache-stale-expected.txt:
  • platform/qt/fast/forms/isindex-placeholder-expected.txt:
  • platform/qt/fast/forms/placeholder-stripped-expected.txt:
  • platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/qt/fast/forms/textarea-placeholder-set-attribute-expected.txt:
2:29 AM Changeset in webkit [72069] by Csaba Osztrogonác
  • 5 edits
    8 adds in trunk/LayoutTests

.

1:21 AM Changeset in webkit [72068] by alex
  • 12 edits in trunk/LayoutTests

2010-11-16 Alejandro G. Castro <​alex@igalia.com>

Unreviewed, updated test expectations for GTK and skip tests using
computedStyleIncludingVisitedInfo which is not currently supported
in GTK.

  • platform/gtk/Skipped:
  • platform/gtk/fast/forms/isindex-placeholder-expected.txt:
  • platform/gtk/fast/forms/password-placeholder-expected.txt:
  • platform/gtk/fast/forms/password-placeholder-text-security-expected.txt:
  • platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/gtk/fast/forms/placeholder-set-attribute-expected.txt:
  • platform/gtk/fast/forms/placeholder-stripped-expected.txt:
  • platform/gtk/fast/forms/search-placeholder-value-changed-expected.txt:
  • platform/gtk/fast/forms/search-styled-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-set-attribute-expected.txt:
1:01 AM Changeset in webkit [72067] by Patrick Gansterer
  • 4 edits in trunk/WebKit

2010-11-16 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[CMake] Remove platform dependent include directories
​https://bugs.webkit.org/show_bug.cgi?id=49553

  • CMakeLists.txt:

2010-11-16 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[CMake] Add platform dependent include directories
​https://bugs.webkit.org/show_bug.cgi?id=49553

  • CMakeListsEfl.txt:
12:44 AM Changeset in webkit [72066] by mihaip@chromium.org
  • 4 edits in trunk

2010-11-16 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Adam Barth.

fast/images/size-failure.html results in malloc of 2 Gb after switching to WebKit image decoders
​https://bugs.webkit.org/show_bug.cgi?id=48634

Re-enable fast/images/size-failure.html now that it passes and doesn't
affect subsequent tests.

  • platform/chromium/test_expectations.txt:

2010-11-16 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Adam Barth.

fast/images/size-failure.html results in malloc of 2 Gb after switching to WebKit image decoders
​https://bugs.webkit.org/show_bug.cgi?id=48634

Specify the capacity when calling CFDataCreateMutable, which can signal
malloc failures (by returning NULL), unlike CFDataSetLength.

  • platform/image-decoders/cg/ImageDecoderCG.cpp: (WebCore::RGBA32Buffer::setSize):
12:10 AM Changeset in webkit [72065] by rwlbuis@webkit.org
  • 15 edits in trunk/WebCore

2010-11-15 Rob Buis <​rwlbuis@gmail.com>

Reviewed by Dirk Schulze and Darin Adler.

requiredFeatures does not adapt to SVGStringList changes
​https://bugs.webkit.org/show_bug.cgi?id=40887

Centralize the const_cast handling and only do it if needed.
Remove the const_cast in all svgAttributeChanged functions and move
it to SVGTest::handleAttributeChange. Add an early return to
handleAttributeChange to avoid unnecessary const_casts.

No tests necessary as functionality has not changed.

  • svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::svgAttributeChanged):
  • svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::svgAttributeChanged):
  • svg/SVGForeignObjectElement.cpp: (WebCore::SVGForeignObjectElement::svgAttributeChanged):
  • svg/SVGGElement.cpp: (WebCore::SVGGElement::svgAttributeChanged):
  • svg/SVGImageElement.cpp: (WebCore::SVGImageElement::svgAttributeChanged):
  • svg/SVGLineElement.cpp: (WebCore::SVGLineElement::svgAttributeChanged):
  • svg/SVGPathElement.cpp: (WebCore::SVGPathElement::svgAttributeChanged):
  • svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::svgAttributeChanged):
  • svg/SVGRectElement.cpp: (WebCore::SVGRectElement::svgAttributeChanged):
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::svgAttributeChanged):
  • svg/SVGTests.cpp: (WebCore::SVGTests::handleAttributeChange):
  • svg/SVGTests.h:
  • svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::svgAttributeChanged):
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::svgAttributeChanged):

Nov 15, 2010:

11:16 PM Changeset in webkit [72064] by mitz@apple.com
  • 1 edit
    1 move in trunk/LayoutTests

Disabled a test that was failing intermittently due to ​https://bugs.webkit.org/show_bug.cgi?id=49579

Rubber-stamped by Mark Rowe.

  • fast/block/float/015.html: Removed.
  • fast/block/float/015.html-disabled: Copied from LayoutTests/fast/block/float/015.html.
10:05 PM Changeset in webkit [72063] by barraclough@apple.com
  • 5 edits
    3 adds in trunk

Bug 49577 - Function.prototype should be non-configurable

Reviewed by Sam Weinig.

JavaScriptCore:

JSC lazily allocates the prototype property of Function objects.

We check the prototype exists on 'get', but not on 'put'.
If you 'put' without having first done a 'get' you can end up with a configurable
prototype (prototype should only ever be non-configurable).

This is visible in a couple of ways:

  • 'delete' on the property may succeed. (the next access will result in a new, reset prototype object).
  • the prototype may be set to a getter.
  • runtime/JSFunction.cpp:

(JSC::JSFunction::getOwnPropertyNames):

Reify the prototype property before allowing an enumerate including don't enum properties.

(JSC::JSFunction::put):

Reify the prototype property before any put to it.

LayoutTests:

  • fast/js/script-tests/Object-getOwnPropertyNames.js:
  • fast/js/Object-getOwnPropertyNames-expected.txt:

Object.getOwnPropertyNames should enumerate the 'prototype' property on Functions.

  • fast/js/function-prototype-descriptor.html: Added.
  • fast/js/function-prototype-descriptor-expected.txt: Added.
  • fast/js/script-tests/function-prototype-descriptor.js: Added.

Test the attributes of Functions' prototype properties.

9:35 PM Changeset in webkit [72062] by Dimitri Glazkov
  • 3 edits
    2 adds in trunk

2010-11-15 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

REGRESSION(r71934): Removing an element with a shadow DOM from under a cursor causes a crash.
​https://bugs.webkit.org/show_bug.cgi?id=49569

  • fast/events/remove-shadow-host-crash-expected.txt: Added.
  • fast/events/remove-shadow-host-crash.html: Added.

2010-11-15 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

REGRESSION(r71934): Removing an element with a shadow DOM from under a cursor causes a crash.
​https://bugs.webkit.org/show_bug.cgi?id=49569

Test: fast/events/remove-shadow-host-crash.html

  • rendering/TextControlInnerElements.h: (WebCore::TextControlInnerElement::isShadowNode): (WebCore::TextControlInnerElement::shadowParentNode):
9:26 PM Changeset in webkit [72061] by barraclough@apple.com
  • 2 edits in trunk/WebKit/qt

Fix test broken by earlier patch.

Reviewed by NOBODY build fix.

  • tests/qwebframe/tst_qwebframe.cpp:
9:23 PM Changeset in webkit [72060] by rniwa@webkit.org
  • 7 edits in trunk/WebCore

2010-11-12 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

ScriptElement rather than HTMLScriptElement and SVGScriptElement should have ScriptElementData
​https://bugs.webkit.org/show_bug.cgi?id=49469

Moved m_data, scriptCharset, scriptContent, shouldExecuteAsJavaScript, and executeScript from
HTMLScriptElement and SVGScriptElement to ScriptElementData.

Also made insertedIntoDocument, removedFromDocument, childrenChanged, finishParsingChildren,
and handleSourceAttribute of ScriptElement non-static.

No new tests are added since this is a cleanup.

  • dom/ScriptElement.cpp: (WebCore::ScriptElement::scriptCharset): Added. (WebCore::ScriptElement::scriptContent): Added. (WebCore::ScriptElement::shouldExecuteAsJavaScript): Added. (WebCore::ScriptElement::executeScript): Added. (WebCore::ScriptElement::insertedIntoDocument): Made non-static. Accesses m_data. (WebCore::ScriptElement::removedFromDocument): Ditto. (WebCore::ScriptElement::childrenChanged): Ditto. (WebCore::ScriptElement::finishParsingChildren): Ditto. (WebCore::ScriptElement::handleSourceAttribute): Ditto.
  • dom/ScriptElement.h: Moved the declaration of ScriptElement after that of ScriptElementData because ScriptElement has to instantiate ScriptElementData. (WebCore::ScriptElement::ScriptElement): Initializes m_data.
  • html/HTMLScriptElement.cpp: Removed scriptCharset, scriptContent, shouldExecuteAsJavaScript, and executeScript. (WebCore::HTMLScriptElement::HTMLScriptElement): Initializes ScriptElement instead of ScriptElementData. (WebCore::HTMLScriptElement::childrenChanged): Calls ScriptElement::childrenChanged. (WebCore::HTMLScriptElement::parseMappedAttribute): Calls ScriptElement::handleSourceAttribute. (WebCore::HTMLScriptElement::finishParsingChildren): Calls ScriptElement::finishParsingChildren. (WebCore::HTMLScriptElement::insertedIntoDocument): Calls ScriptElement::insertedIntoDocument. (WebCore::HTMLScriptElement::removedFromDocument): Calls ScriptElement::removedFromDocument.
  • html/HTMLScriptElement.h:
  • svg/SVGScriptElement.cpp: Removed scriptCharset, scriptContent, shouldExecuteAsJavaScript, and executeScript. (WebCore::SVGScriptElement::SVGScriptElement): Initializes ScriptElement instead of ScriptElementData. (WebCore::SVGScriptElement::svgAttributeChanged): Calls ScriptElement::handleSourceAttribute. (WebCore::SVGScriptElement::insertedIntoDocument): Calls ScriptElement::insertedIntoDocument. (WebCore::SVGScriptElement::removedFromDocument): Calls ScriptElement::removedFromDocument. (WebCore::SVGScriptElement::childrenChanged): Calls ScriptElement::childrenChanged. (WebCore::SVGScriptElement::finishParsingChildren): Calls ScriptElement::finishParsingChildren.
  • svg/SVGScriptElement.h:
9:13 PM Changeset in webkit [72059] by tkent@chromium.org
  • 23 edits in trunk/WebCore

Refactor HTMLInputElement: Move a part of HTMLInputElement::
defaultEventHandler() to InputTypes.
​https://bugs.webkit.org/show_bug.cgi?id=48317

Reviewed by Darin Adler.

Move out the followings to InputTypes:

  • click event processing,
  • the first keydown event processing, and
  • DOMActivate event processing.

Move m_xPos and m_yPos from HTMLInputElement to ImageInputType as
m_clickLocation. It's ok to move them because they should be valid only
when HTMLInputElement::m_activeSubmit is true. For type=image,
m_activeSubmit is true only in DOMActivate event handling. So we reset
m_clickLocation in handleDOMActivateEvent() with Event::underlyingEvent().

No new tests because this is just a refactoring.

  • html/BaseDateAndTimeInputType.cpp:

(WebCore::BaseDateAndTimeInputType::handleKeydownEvent):

  • html/BaseDateAndTimeInputType.h:
  • html/FileInputType.cpp:

(WebCore::FileInputType::handleDOMActivateEvent):

  • html/FileInputType.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::HTMLInputElement):
(WebCore::HTMLInputElement::defaultEventHandler):

  • html/HTMLInputElement.h:
  • html/ImageInputType.cpp:

(WebCore::ImageInputType::appendFormData):
(WebCore::ImageInputType::handleDOMActivateEvent):

  • html/ImageInputType.h:
  • html/InputType.cpp:

(WebCore::InputType::handleClickEvent):
(WebCore::InputType::handleDOMActivateEvent):
(WebCore::InputType::handleKeydownEvent):

  • html/InputType.h:
  • html/NumberInputType.cpp:

(WebCore::NumberInputType::handleKeydownEvent):

  • html/NumberInputType.h:
  • html/RadioInputType.cpp:

(WebCore::RadioInputType::handleClickEvent):

  • html/RadioInputType.h:
  • html/RangeInputType.cpp:

(WebCore::RangeInputType::handleKeydownEvent):

  • html/RangeInputType.h:
  • html/ResetInputType.cpp:

(WebCore::ResetInputType::handleDOMActivateEvent):

  • html/ResetInputType.h:
  • html/SubmitInputType.cpp:

(WebCore::SubmitInputType::handleDOMActivateEvent):

  • html/SubmitInputType.h:
  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::handleKeydownEvent):
(WebCore::TextFieldInputType::handleKeydownEventForSpinButton):

  • html/TextFieldInputType.h:
9:12 PM Changeset in webkit [72058] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-11-15 Nat Duca <​nduca@chromium.org>

Reviewed by Darin Fisher.

[chromium] Make WebWidget actively notify client when compositing enables.
​https://bugs.webkit.org/show_bug.cgi?id=49396

  • public/WebWidgetClient.h: (WebKit::WebWidgetClient::didAcceleratedCompositingEnable):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::resize): (WebKit::WebViewImpl::paint): (WebKit::WebViewImpl::setRootLayerNeedsDisplay): (WebKit::WebViewImpl::scrollRootLayerRect): (WebKit::WebViewImpl::invalidateRootLayerRect): (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
8:53 PM Changeset in webkit [72057] by crogers@google.com
  • 2 edits
    2 adds in trunk/WebCore

2010-11-15 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

Add AudioNode custom bindings
​https://bugs.webkit.org/show_bug.cgi?id=49119

No new tests since audio API is not yet implemented.

  • bindings/js/JSAudioNodeCustom.cpp: Added. (WebCore::JSAudioNode::connect): (WebCore::JSAudioNode::disconnect):
  • bindings/v8/custom/V8AudioNodeCustom.cpp: Added. (WebCore::V8AudioNode::connectCallback): (WebCore::V8AudioNode::disconnectCallback):
  • webaudio/AudioNode.idl:
8:45 PM Changeset in webkit [72056] by hyatt@apple.com
  • 3 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=49570

Reviewed by Dan Bernstein.

Put italics specialization check back in CSSFontSelector. I had to back it out, since it broke
a layout test, and the issue was that local font fallback fonts should not be considered by the
specialization check (since you never want to pick a fallback over an actual @font-face rule if
the @font-face rule can handle it).

  • css/CSSFontFace.h:

(WebCore::CSSFontFace::create):
(WebCore::CSSFontFace::isLocalFallback):
(WebCore::CSSFontFace::CSSFontFace):

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule):
(WebCore::compareFontFaces):

8:13 PM Changeset in webkit [72055] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-11-15 Yi Shen <​yi.4.shen@nokia.com>

Reviewed by Andreas Kling.

[Qt] ZoomTextOnly doesn't work
​https://bugs.webkit.org/show_bug.cgi?id=49568

Check QWebSettings::ZoomTextOnly attribute before applying zoom

  • Api/qwebframe.cpp: (QWebFrame::textSizeMultiplier): (QWebFrame::setZoomFactor): (QWebFrame::zoomFactor):
  • Api/qwebframe_p.h: (QWebFramePrivate::QWebFramePrivate):
7:37 PM Changeset in webkit [72054] by Patrick Gansterer
  • 3 edits in trunk

2010-11-15 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[CMake] Add additional flags to cmakeconfig.h
​https://bugs.webkit.org/show_bug.cgi?id=49556

  • cmake/OptionsEfl.cmake:
  • cmakeconfig.h.cmake:
6:13 PM Changeset in webkit [72053] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-15 Kent Tamura <​tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/drt_expectations.txt: Fix duplicated entries added in r72045.
6:09 PM Changeset in webkit [72052] by adele@apple.com
  • 23 edits in trunk

WebCore: Fix for: ​https://bugs.webkit.org/show_bug.cgi?id=49452
Placeholder should not be swapped in and out of the text control's inner text element

Reviewed by Darin Adler.

There's no need to swap the placeholder text in and out of the inner text element. Instead, just paint the text.
This reduces complexity and makes it easier to make independent decisions about the placeholder text and the text control value.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setValueFromRenderer):

Since updatePlaceholderVisibility checks the value, set the value before calling updatePlaceholderVisibility.

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::updatePlaceholderVisibility): Remove code that set the inner text value with the placeholder text.
(WebCore::RenderTextControl::paintObject): Paint the placeholder text during the background phase.

  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlMultiLine.cpp:

(WebCore::RenderTextControlMultiLine::nodeAtPoint): Remove custom hit testing that tried to avoid hitting the placeholder text at the wrong time.
(WebCore::RenderTextControlMultiLine::updateFromElement): Remove code that set the inner text value with the placeholder text.
(WebCore::RenderTextControlMultiLine::createInnerTextStyle): Remove code that created the inner text style based on the placeholder pseudoelement.
(WebCore::RenderTextControlMultiLine::textBoxInsetLeft): Added.
(WebCore::RenderTextControlMultiLine::textBoxInsetRight): Added.

  • rendering/RenderTextControlMultiLine.h:
  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::updateFromElement): Remove code that set the inner text value with the placeholder text.
(WebCore::RenderTextControlSingleLine::createInnerTextStyle): Remove code that created the inner text style based on the placeholder pseudoelement.
(WebCore::RenderTextControlSingleLine::textBoxInsetLeft): Added.
(WebCore::RenderTextControlSingleLine::textBoxInsetRight): Added.

  • rendering/RenderTextControlSingleLine.h:
  • rendering/TextControlInnerElements.cpp: Removed custom hit testing that tried to avoid hitting the placeholder text at the wrong time.

LayoutTests: Test for: ​https://bugs.webkit.org/show_bug.cgi?id=49452
Placeholder should not be swapped in and out of the text control's inner text element

Reviewed by Darin Adler.

The only visual change that occurred is in pseudo-cache-stale.html. The placeholder text did not
use to paint over the spot where the cancel button will display. Since the cancel button is not
present when the placeholder is drawn, now the placeholder text can draw to the edge of the field.

  • platform/mac/fast/css/pseudo-cache-stale-expected.checksum:
  • platform/mac/fast/css/pseudo-cache-stale-expected.png:
  • platform/mac/fast/css/pseudo-cache-stale-expected.txt:
  • platform/mac/fast/forms/isindex-placeholder-expected.txt:
  • platform/mac/fast/forms/password-placeholder-expected.txt:
  • platform/mac/fast/forms/password-placeholder-text-security-expected.txt:
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/mac/fast/forms/placeholder-set-attribute-expected.txt:
  • platform/mac/fast/forms/placeholder-stripped-expected.txt:
  • platform/mac/fast/forms/search-placeholder-value-changed-expected.txt:
  • platform/mac/fast/forms/search-styled-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-set-attribute-expected.txt:
6:00 PM Changeset in webkit [72051] by hamaji@chromium.org
  • 3 edits in branches/chromium/552

Merge 71964 - 2010-11-13 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Kent Tamura.

[Chromium] print doesn't work on ​http://nodejs.org/api.html
​https://bugs.webkit.org/show_bug.cgi?id=49304

  • platform/chromium/test_expectations.txt:

2010-11-13 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Kent Tamura.

[Chromium] print doesn't work on ​http://nodejs.org/api.html
​https://bugs.webkit.org/show_bug.cgi?id=49304

  • src/WebFrameImpl.cpp: (WebKit::ChromePrintContext::begin): (WebKit::WebFrameImpl::printBegin):

TBR=​hamaji@chromium.org

5:30 PM Changeset in webkit [72050] by barraclough@apple.com
  • 93 edits in trunk

Bug 49488 - Only add source specific information to exceptions in Interpreter::throwException

Reviewed by Geoff Garen.

JavaScriptCore:

Three types of source location information are added to errors.

(1) Divot information.

This was added with the intention of using it to provide better source highlighting in the inspector.
We may still want to do so, but we probably should not be exposing these values in a manner visible to
user scripts – only through an internal C++ interface. The code adding divot properties to objects has
been removed.

(2) Line number information.

Line number information is presently sometimes added at the point the exception is created, and sometimes
added at the point the exception passes through throwException. Change this so that throwException has
the sole responsibility for adding line number and source file information.

(3) Source snippets in the message of certain type errors (e.g. 'doc' in Result of expression 'doc' [undefined] is not an object.).

These messages are currently created at the point the exceptions is raised. Instead reformat the message
such that the source snippet is located at the end (Result of expression 'b1' [undefined] is not an object.
becomes 'undefined' is not an object (evaluating 'b1.property')), and append these to the message at
the in throw Exception. This presents a number of advantages:

  • we no longer need to have source location information to create these TypeErrors.
  • we can chose to append source location information in other error messages, including those where passing source location to the point of construction would be inconvenient.
  • we can chose in future to omit to append source location information when running in a non-debug mode.

This also cleans up some error output, e.g. removing double brackets ('[[]]') around objects in output,
removing double periods (..) at end of lines, and adding slightly more context to some errors.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::expressionRangeForBytecodeOffset):

  • Separated called to access line and range information.
  • bytecode/CodeBlock.h:
    • Separated called to access line and range information.
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::resolve):
(JSC::Interpreter::resolveSkip):
(JSC::Interpreter::resolveGlobal):
(JSC::Interpreter::resolveGlobalDynamic):
(JSC::Interpreter::resolveBaseAndProperty):
(JSC::isInvalidParamForIn):
(JSC::isInvalidParamForInstanceOf):

  • Update parameters passed to error constructors.

(JSC::appendSourceToError):

  • Update message property to add location information (previously added in createErrorMessage, in ExceptionHelpers)

(JSC::Interpreter::throwException):

  • Updated to call appendSourceToError.

(JSC::Interpreter::privateExecute):

  • Update parameters passed to error constructors.
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • Update parameters passed to error constructors.
  • runtime/Error.cpp:

(JSC::addErrorInfo):
(JSC::hasErrorInfo):

  • Removed divot properties.
  • runtime/Error.h:
    • Removed divot properties.
  • runtime/ErrorInstance.cpp:

(JSC::ErrorInstance::ErrorInstance):

  • Initialize new property.
  • runtime/ErrorInstance.h:

(JSC::ErrorInstance::appendSourceToMessage):
(JSC::ErrorInstance::setAppendSourceToMessage):
(JSC::ErrorInstance::clearAppendSourceToMessage):

  • Added flag to check for errors needing location information appending.

(JSC::ErrorInstance::isErrorInstance):

  • Added virtual method to check for ErrorInstances.
  • runtime/ExceptionHelpers.cpp:

(JSC::createUndefinedVariableError):
(JSC::createInvalidParamError):
(JSC::createNotAConstructorError):
(JSC::createNotAFunctionError):
(JSC::createNotAnObjectError):

  • Update parameters passed to error constructors, stopped adding line number information early, changed TypeError messages.
  • runtime/ExceptionHelpers.h:
    • Updated function signatures.
  • runtime/JSFunction.cpp:

(JSC::callHostFunctionAsConstructor):

  • Update parameters passed to error constructors.
  • runtime/JSObject.h:

(JSC::JSObject::isErrorInstance):

  • Added virtual method to check for ErrorInstances.

LayoutTests:

Updated results to account for changes in TypeError messages.
(e.g. Result of expression 'b1' [undefined] is not an object. -> 'undefined' is not an object (evaluating 'b1.property')).

  • fast/css/font-face-descriptor-multiple-values-parsing-expected.txt:
  • fast/css/resources/font-face-descriptor-multiple-values-parsing.js:
  • fast/css/variables/color-hex-test-expected.txt:
  • fast/dom/HTMLSelectElement/named-options-expected.txt:
  • fast/dom/Range/getClientRects-expected.txt:
  • fast/dom/SelectorAPI/dumpNodeList-almost-strict-expected.txt:
  • fast/dom/SelectorAPI/dumpNodeList-expected.txt:
  • fast/forms/select-namedItem-expected.txt:
  • fast/js/basic-strict-mode-expected.txt:
  • fast/js/date-toisostring-expected.txt:
  • fast/js/delete-getters-setters-expected.txt:
  • fast/js/exception-expression-offset-expected.txt:
  • fast/js/exception-for-nonobject-expected.txt:
  • fast/js/exception-thrown-from-new-expected.txt:
  • fast/js/exception-thrown-from-new.html:
  • fast/js/instance-of-immediates-expected.txt:
  • fast/js/script-tests/exception-expression-offset.js:

(testException):

  • fast/js/sputnik/Conformance/08_Types/8.6_The_Object_Type/8.6.2_Internal_Properties_and_Methods/S8.6.2_A7-expected.txt:
  • fast/js/sputnik/Conformance/13_Function_Definition/S13_A17_T2-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/S15.1_A1_T1-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/S15.1_A1_T2-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/S15.1_A2_T1-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.2_Object/15.2.4/15.2.4.2_Object.prototype.toString/S15.2.4.2_A7-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.2_Object/15.2.4/15.2.4.3_Object.prototype.toLocaleString/S15.2.4.3_A7-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.2_Object/15.2.4/15.2.4.4_Object.prototype.valueOf/S15.2.4.4_A7-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.2_Object/15.2.4/15.2.4.5_Object.prototype.hasOwnProperty/S15.2.4.5_A7-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.2_Object/15.2.4/15.2.4.6_Object.prototype.isPrototypeOf/S15.2.4.6_A7-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.2_Object/15.2.4/15.2.4.7_Object.prototype.propertyIsEnumerable/S15.2.4.7_A7-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.2_Object/15.2.4/S15.2.4_A3-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.2_Object/15.2.4/S15.2.4_A4-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.3_Function/15.3.4/15.3.4.2_Function.prototype.toString/S15.3.4.2_A7-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.3_Function/15.3.4/S15.3.4_A5-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T4-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.12_String.prototype.search/S15.5.4.12_A7-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.13_String.prototype.slice/S15.5.4.13_A7-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.15_String.prototype.substring/S15.5.4.15_A7-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.17_String.prototype.toLocaleLowerCase/S15.5.4.17_A7-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.7_String.prototype.indexOf/S15.5.4.7_A7-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.8_String.prototype.lastIndexOf/S15.5.4.8_A7-expected.txt:
  • fast/xsl/transform-xhr-doc-expected.txt:
  • http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
  • http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
  • http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
  • java/lc3/ArrayMethods/byte-001-expected.txt:
  • java/lc3/CallStatic/object-001-expected.txt:
  • java/lc3/ConvertBoolean/boolean-007-n-expected.txt:
  • java/lc3/ConvertBoolean/boolean-008-n-expected.txt:
  • java/lc3/ConvertBoolean/boolean-009-n-expected.txt:
  • java/lc3/ConvertBoolean/boolean-010-n-expected.txt:
  • java/lc3/ConvertBoolean/boolean-011-n-expected.txt:
  • java/lc3/ConvertBoolean/boolean-012-n-expected.txt:
  • java/lc3/ConvertBoolean/boolean-013-n-expected.txt:
  • java/lc3/ConvertBoolean/boolean-014-expected.txt:
  • java/lc3/ConvertNull/null-001-expected.txt:
  • java/lc3/ConvertNumber/number-011-expected.txt:
  • java/lc3/ConvertString/string-006-expected.txt:
  • java/lc3/ConvertString/string-007-n-expected.txt:
  • java/lc3/ConvertUndefined/undefined-002-expected.txt:
  • java/lc3/ConvertUndefined/undefined-003-expected.txt:
  • java/lc3/JSBoolean/boolean-005-n-expected.txt:
  • java/lc3/JSNumber/ToDouble-002-expected.txt:
  • java/lc3/JSObject/ToJSObject-001-expected.txt:
  • java/lc3/JSObject/ToObject-001-expected.txt:
  • java/lc3/JavaObject/JavaObjectFieldOrMethod-001-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.imageData.create1.type-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.imageData.create2.type-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.imageData.get.type-expected.txt:
  • platform/mac/compositing/reflections/reflection-opacity-expected.txt:
  • platform/mac/fast/css/variables/remove-variable-test-expected.txt:
  • platform/mac/fast/css/variables/set-variable-test-expected.txt:
  • platform/mac/fast/css/variables/variable-iteration-test-expected.txt:
  • platform/mac/fast/events/updateLayoutForHitTest-expected.txt:
  • platform/mac/svg/custom/createelement-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug53690-1-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug92868_1-expected.txt:
  • plugins/npruntime/object-from-destroyed-plugin-expected.txt:
  • plugins/npruntime/plugin-scriptable-object-invoke-default-expected.txt:
  • svg/custom/use-nested-missing-target-removed-expected.txt:
  • svg/dom/svgpath-out-of-bounds-getPathSeg-expected.txt:
5:23 PM Changeset in webkit [72049] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-11-15 Andreas Kling <​kling@webkit.org>

Unreviewed buildfix (Qt WebKit2 minimal)

  • platform/qt/CookieJarQt.cpp: Add missing <QStringList> include.
5:22 PM Changeset in webkit [72048] by crogers@google.com
  • 10 edits in trunk/WebCore

2010-11-15 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

Add Event and EventListener hooks for JavaScriptAudioNode and AudioProcessingEvent
​https://bugs.webkit.org/show_bug.cgi?id=49357

No new tests since audio API is not yet implemented.

  • bindings/js/JSEventCustom.cpp: (WebCore::toJS):
  • bindings/js/JSEventTarget.cpp: (WebCore::toJS):
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
  • bindings/v8/custom/V8EventCustom.cpp: (WebCore::toV8):
  • dom/Event.cpp: (WebCore::Event::isAudioProcessingEvent):
  • dom/Event.h:
  • dom/EventNames.h:
  • dom/EventTarget.cpp: (WebCore::EventTarget::toJavaScriptAudioNode):
  • dom/EventTarget.h:
5:05 PM Changeset in webkit [72047] by ap@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

A minor style fix in StyledElement.cpp.

  • dom/StyledElement.cpp: (WebCore::StyledElement::addCSSProperty): (WebCore::StyledElement::addCSSImageProperty):
5:03 PM Changeset in webkit [72046] by ap@apple.com
  • 5 edits in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=49565
Remove Attr.style accessor

  • dom/Attr.idl: Only keep the accessor for Objective C API. Inspector doesn't seem to need it any more.
4:40 PM Changeset in webkit [72045] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-15 Kent Tamura <​tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/drt_expectations.txt: Update for the recent status of Chromium-Linux DRT.
3:30 PM Changeset in webkit [72044] by aestes@apple.com
  • 2 edits in trunk/LayoutTests

Unskip fast/forms/submit-form-attributes.html.

  • platform/mac-leopard/Skipped:
3:04 PM Changeset in webkit [72043] by inferno@chromium.org
  • 2 edits
    2 copies in branches/chromium/552

Merge 72040

BUG=63031

2:59 PM Changeset in webkit [72042] by Beth Dakin
  • 2 edits in trunk/WebCore

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=49555
Frame::scalePage() should treat the origin as an absolute
coordinate
-and corresponding-
<rdar://problem/8667138>

Reviewed by Darin Adler.

  • page/Frame.cpp:

(WebCore::Frame::scalePage):

2:30 PM Changeset in webkit [72041] by mitz@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fixed a weird typo

2:27 PM Changeset in webkit [72040] by mitz@apple.com
  • 4 edits
    2 adds in trunk

<rdar://problem/8662770> Error image has incorrect size when a custom font is used

Reviewed by Darin Adler.

WebCore:

Test: fast/images/style-access-during-imageChanged-crash.html

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::RenderImage): Added initialization of m_needsToSetSizeForAltText.
(WebCore::RenderImage::imageSizeForError): Factored the non-alt-text dependent size computation
out of setImageSizeForAltText() into this function.
(WebCore::RenderImage::setImageSizeForAltText): Changed to use imageSizeForError().
(WebCore::RenderImage::styleDidChange): Added. If m_needsToSetSizeForAltText is true, sets the
intrinsic size and calls imageDimensionsChanged() as needed to cause layout or invalidation.
(WebCore::RenderImage::imageChanged): Moved som comed from here...
(WebCore::RenderImage::imageDimensionsChanged): ...to here.

  • rendering/RenderImage.h:

LayoutTests:

  • fast/images/style-access-during-imageChanged-crash-expected.txt: Added.
  • fast/images/style-access-during-imageChanged-crash.html: Added.
2:16 PM Changeset in webkit [72039] by andreas.kling@nokia.com
  • 2 edits in trunk/WebKit2

2010-11-15 Andreas Kling <​kling@webkit.org>

Reviewed by Tor Arne Vestbø.

[Qt] Make sure qwkpage.h and qwkpreferences.h are copied into includes/WebKit2

  • UIProcess/API/qt/WKView.h:
2:08 PM Changeset in webkit [72038] by andersca@apple.com
  • 4 edits in trunk/WebCore

ASSERTION (r72003): Assertion failure when running layout tests
​https://bugs.webkit.org/show_bug.cgi?id=49561

Reviewed by Dimitri Glazkov.

r72003 added the 'formaction' URL attribute to HTMLButtonElement and HTMLInputElement,
but did not add the attribute to the isURLAttribute which lead to assertion failures
when running the layout tests with a debug build.

  • html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::isURLAttribute):

  • html/HTMLButtonElement.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::isURLAttribute):

2:07 PM Changeset in webkit [72037] by andreas.kling@nokia.com
  • 2 edits in trunk/WebKit2

2010-11-15 Andreas Kling <​kling@webkit.org>

Reviewed by Tor Arne Vestbø.

[Qt] Use $${PYTHON} rather than "python" to execute Python scripts

Fixes building with the old Python that currently ships with Scratchbox.

  • DerivedSources.pro:
1:52 PM Changeset in webkit [72036] by ap@apple.com
  • 2 edits in trunk/WebCore

2010-11-15 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=49559
DOMWindow.getComputedStyle pseudo element argument lacks ConvertUndefinedOrNullToNullString

No observable change in behavior, so no tests.

  • page/DOMWindow.idl: Added ConvertUndefinedOrNullToNullString.
1:50 PM Changeset in webkit [72035] by aestes@apple.com
  • 2 edits in trunk/LayoutTests

r72003 caused fast/forms/submit-form-attributes.html to crash
DumpRenderTree on the Leopard Intel Debug (Tests) bot. Skip this test
until the failure is resolved.
​https://bugs.webkit.org/show_bug.cgi?id=49562

  • platform/mac-leopard/Skipped:
1:46 PM Changeset in webkit [72034] by andreas.kling@nokia.com
  • 3 edits in trunk/WebCore

2010-11-15 Andreas Kling <​kling@webkit.org>

Reviewed by Tor Arne Vestbø.

[Qt] Make WTF_USE_MEEGOTOUCH available for WebKit2 as well

Move this into WebCore/features.pri which is used by both WebCore and WebKit2.

  • WebCore.pro:
  • features.pri:
1:42 PM Changeset in webkit [72033] by Martin Robinson
  • 2 edits in trunk/WebCore

2010-11-15 Martin Robinson <​mrobinson@igalia.com>

Build fix for GTK+.

  • GNUmakefile.am: Add some missing generated files to the source list.
1:38 PM Changeset in webkit [72032] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-11-15 Zhenyao Mo <​zmo@google.com>

Ubreviewed, remove an empty line that causes the test to fail.

  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-array-buffer-view-expected.txt:
1:33 PM Changeset in webkit [72031] by abecsi@webkit.org
  • 7 edits in trunk/WebKitTools

2010-11-15 Andras Becsi <​abecsi@webkit.org>

Reviewed by Andreas Kling.

[Qt][WK2] Avoid polling in WebKitTestRunner.
​https://bugs.webkit.org/show_bug.cgi?id=49542

Make the WK2 testing session about 10-15% faster and decrease random flakiness
resulting from timing skew by removing the millisecond polling from TestControllerQt.

  • WebKitTestRunner/TestController.cpp: (WTR::TestController::didFinishLoadForFrame):
  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
  • WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::notifyDone): Add method stub.
  • WebKitTestRunner/qt/TestControllerQt.cpp: (WTR::TestControllerRunLoop::instance): (WTR::TestControllerRunLoop::start): (WTR::TestControllerRunLoop::stop): (WTR::TestControllerRunLoop::TestControllerRunLoop): (WTR::TestControllerRunLoop::timerEvent): (WTR::TestController::notifyDone): (WTR::TestController::platformRunUntil):
  • WebKitTestRunner/win/TestControllerWin.cpp: (WTR::TestController::notifyDone): Add method stub.
1:29 PM Changeset in webkit [72030] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-11-15 Zhenyao Mo <​zmo@google.com>

Unreviewed, update gpu test expectations.

  • platform/chromium-gpu/test_expectations.txt:
1:27 PM Changeset in webkit [72029] by beidson@apple.com
  • 2 edits in trunk/WebKit2
  • win/WebKit2Generated.make:

Reviewed by a better attempt at a Windows build fix.

1:20 PM Changeset in webkit [72028] by Darin Adler
  • 2 edits in trunk/WebKitTools
  • Scripts/webkitpy/common/net/bugzilla: Added property svn:ignore.
1:17 PM Changeset in webkit [72027] by beidson@apple.com
  • 2 edits in trunk/WebKit2
  • win/WebKit2Generated.make: Add new API headers here.

Reviewed by my attempt to fix the Windows build

1:17 PM Changeset in webkit [72026] by kbr@google.com
  • 2 edits in trunk/WebCore

2010-11-15 Kenneth Russell <​kbr@google.com>

Reviewed by James Robinson.

[chromium] Avoid copying of SkBitmap in LayerRendererChromium
​https://bugs.webkit.org/show_bug.cgi?id=49560

Ran CSS 3D content to test. No other new tests.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updateRootLayerTextureRect):
1:04 PM Changeset in webkit [72025] by kbr@google.com
  • 3 edits in trunk/WebKit/chromium

2010-11-15 Kenneth Russell <​kbr@google.com>

Reviewed by James Robinson.

[chromium] Remove assumption that GL functions are function pointers
​https://bugs.webkit.org/show_bug.cgi?id=49486

Added appropriate extension queries and no longer assume that GL
function names are function pointers which can be tested.

  • src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::initialize): (WebKit::WebGraphicsContext3DDefaultImpl::validateAttributes): (WebKit::WebGraphicsContext3DDefaultImpl::resolveMultisampledFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::reshape): (WebKit::WebGraphicsContext3DDefaultImpl::generateMipmap): (WebKit::WebGraphicsContext3DDefaultImpl::getString):
  • src/WebGraphicsContext3DDefaultImpl.h:
12:47 PM Changeset in webkit [72024] by beidson@apple.com
  • 18 edits
    5 adds in trunk/WebKit2

Finish off <rdar://problem/8613727> and ​https://bugs.webkit.org/show_bug.cgi?id=48720
Customizable context menu support in WebKit2.

Reviewed by Sam Weinig.

  • Adds an API-level WKContextMenuItem.
  • Round trips through both the InjectedBundle client and the new PageContextMenuClient before actually displaying the menu.
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • Shared/API/c/WKBase.h:
  • Shared/API/c/WKContextMenuItem.cpp: Added.

(WKContextMenuItemGetTypeID):
(WKContextMenuItemCreateAsAction):
(WKContextMenuItemCreateAsCheckableAction):
(WKContextMenuItemCreateAsSubmenu):
(WKContextMenuItemSeparatorItem):
(WKContextMenuItemGetTag):
(WKContextMenuItemGetType):
(WKContextMenuItemCopyTitle):
(WKContextMenuItemGetEnabled):
(WKContextMenuItemGetChecked):
(WKContextMenuCopySubmenuItems):

  • Shared/API/c/WKContextMenuItem.h: Added.
  • Shared/API/c/WKContextMenuItemTypes.h: Added.
  • Shared/API/c/WKSharedAPICast.h:

(WebKit::toAPI):
(WebKit::toImpl):

  • Shared/WebContextMenuItem.cpp:

(WebKit::WebContextMenuItem::create):
(WebKit::WebContextMenuItem::separatorItem):
(WebKit::WebContextMenuItem::submenuItemsAsImmutableArray):

  • Shared/WebContextMenuItem.h:
  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageContextMenuClient):
(WKPageSetPageFindClient):
(WKPageSetPageLoaderClient):
(WKPageSetPagePolicyClient):
(WKPageSetPageUIClient):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageContextMenuClient.cpp: Added.

(WebKit::WebPageContextMenuClient::getContextMenuFromProposedMenu):

  • UIProcess/WebPageContextMenuClient.h: Added.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::initializeContextMenuClient):
(WebKit::WebPageProxy::showContextMenu):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.cpp:

(WebKit::InjectedBundlePageContextMenuClient::getCustomMenuFromDefaultItems):

  • WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.h:
  • WebProcess/WebCoreSupport/WebContextMenuClient.cpp:

(WebKit::WebContextMenuClient::getCustomMenuFromDefaultItems):

  • WebProcess/WebPage/WebContextMenu.cpp:

(WebKit::WebContextMenu::show):

12:46 PM Changeset in webkit [72023] by andersca@apple.com
  • 10 edits in trunk/WebKit2

Add shouldDecodeSourceDataOfMIMEType WKContextDownloadClient callback
​https://bugs.webkit.org/show_bug.cgi?id=49558

Reviewed by Sam Weinig.

  • UIProcess/API/C/WKContext.h:

Add shouldDecodeSourceDataOfMIMEType callback.

  • UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::shouldDecodeSourceDataOfMIMEType):
Call WebDownloadClient::shouldDecodeSourceDataOfMIMEType.

(WebKit::DownloadProxy::decideDestinationWithSuggestedFilename):
Add allowOverwrite out parameter.

  • UIProcess/Downloads/DownloadProxy.h:
  • UIProcess/Downloads/DownloadProxy.messages.in:

Add ShouldDecodeSourceDataOfMIMEType message.

  • UIProcess/WebDownloadClient.cpp:

(WebKit::WebDownloadClient::shouldDecodeSourceDataOfMIMEType):
Call the WKContextDownloadClient.

(WebKit::WebDownloadClient::decideDestinationWithSuggestedFilename):
Add allowOverwrite out parameter.

  • UIProcess/WebDownloadClient.h:
  • WebProcess/Downloads/Download.cpp:

(WebKit::Download::shouldDecodeSourceDataOfMIMEType):
Send the ShouldDecodeSourceDataOfMIMEType message.

(WebKit::Download::decideDestinationWithSuggestedFilename):
Add allowOverwrite reply parameter.

  • WebProcess/Downloads/mac/DownloadMac.mm:

(-[WKDownloadAsDelegate download:shouldDecodeSourceDataOfMIMEType:]):
Call Download::shouldDecodeSourceDataOfMIMEType.

(-[WKDownloadAsDelegate download:decideDestinationWithSuggestedFilename:]):
Add allowOverwrite parameter.

12:31 PM Changeset in webkit [72022] by inferno@chromium.org
  • 1 edit in branches/chromium/552/WebCore/page/EventHandler.cpp

Merge 72013

BUG=63051

12:25 PM Changeset in webkit [72021] by vangelis@chromium.org
  • 8 edits
    2 adds in trunk/WebCore

2010-11-15 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Fixes layer opacity implementation of composited layers
​https://bugs.webkit.org/show_bug.cgi?id=49233

This introduces a fairly drastic change in how LayerRendererChromium draws
composited layers. Layers that have non-zero opacity as well as layers that
clip their descendants (and have non-trivial transforms) are now first
rendered onto off-screen surfaces (RenderSurfaceChromium's). The compositing
operation now consists of two distinct phases: First a hierarchical traversal
of the layer tree to compute the layer transforms, determine what the necessary
RenderSurfaces are and sort layer that preserve-3d based on their z-value. A second
pass goes through all the RenderSurfaces discovered by the first pass and updates
their contents.
Additional significant side-effects of this change are:

  1. Depth buffer and depth testing is no longer used. Drawing relies on a painter's algorithm to render layers with the preserves-3d property from back to front using the Z coordinate of their center. This will further be improved in the future with the intoduction of a BSP tree to properly deal with intersecting layers.
  2. Compositor no longer uses the stencil buffer to do clipping. Clipping is now performed by rendering layer subtrees into an offscreen buffer and setting the appropriate scissor and viewport transformation.

Tests: abs-position-inside-opacity.html (for the opacity implementation)

and the rest of the compositing layout tests to verify that
everything still works.

  • WebCore.gypi:
  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::cleanupResources): (WebCore::ContentLayerChromium::requiresClippedUpdateRect): (WebCore::ContentLayerChromium::calculateClippedUpdateRect): (WebCore::ContentLayerChromium::updateContents):
  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::LayerChromium): (WebCore::LayerChromium::cleanupResources): (WebCore::LayerChromium::createRenderSurface): (WebCore::LayerChromium::descendantsDrawContent): (WebCore::LayerChromium::descendantsDrawContentRecursive):
  • platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::drawTransform): (WebCore::LayerChromium::layerRenderer):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::orthoMatrix): (WebCore::isScaleOrTranslation): (WebCore::LayerRendererChromium::compareLayerZ): (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::prepareToDrawLayers): (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::updateLayersRecursive): (WebCore::LayerRendererChromium::useRenderSurface): (WebCore::LayerRendererChromium::drawLayer): (WebCore::LayerRendererChromium::setScissorToRect): (WebCore::LayerRendererChromium::setDrawViewportRect): (WebCore::LayerRendererChromium::initializeSharedObjects): (WebCore::LayerRendererChromium::cleanupSharedObjects):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/RenderSurfaceChromium.cpp: Added. (WebCore::RenderSurfaceChromium::RenderSurfaceChromium): (WebCore::RenderSurfaceChromium::~RenderSurfaceChromium): (WebCore::RenderSurfaceChromium::cleanupResources): (WebCore::RenderSurfaceChromium::layerRenderer): (WebCore::RenderSurfaceChromium::prepareContentsTexture):
  • platform/graphics/chromium/RenderSurfaceChromium.h: Added. (WebCore::RenderSurfaceChromium::contentRectCenter): (WebCore::RenderSurfaceChromium::contentRect):
  • platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::cleanupResources):
12:16 PM Changeset in webkit [72020] by Martin Robinson
  • 2 edits in trunk/WebCore

2010-11-15 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Andreas Kling.

[GTK] gdk_pixbuf_get_from_surface from GtkVersioning.h is broken on GTK+ 2 builds
​https://bugs.webkit.org/show_bug.cgi?id=49549

No new tests. This can be verified by loading any existing vertical text test
in GtkLauncher and noticing the lack of CRITICAL GLib exceptions. There's currently
no automatic way of verifying custom cursors.

  • platform/gtk/GtkVersioning.c: (gdk_pixbuf_get_from_surface): Reverse a sanity check in this method to be correct.
11:59 AM Changeset in webkit [72019] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-11-15 Zhenyao Mo <​zmo@google.com>

Unreviewed, skip failing WebGL test.

  • platform/mac-snowleopard/Skipped:
11:48 AM Changeset in webkit [72018] by andersca@apple.com
  • 13 edits in trunk/WebKit2

Add decideDestinationWithSuggestedFilename WKContextDownloadClient callback
​https://bugs.webkit.org/show_bug.cgi?id=49554

Reviewed by Sam Weinig.

  • Platform/CoreIPC/MessageSender.h:

(CoreIPC::MessageSender::sendSync):
Add sendSync capabilities to Messagesender.

  • UIProcess/API/C/WKContext.h:

AdddecideDestinationWithSuggestedFilename callback.

  • UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::decideDestinationWithSuggestedFilename):
Call WebDownloadClient::decideDestinationWithSuggestedFilename.

  • UIProcess/Downloads/DownloadProxy.messages.in:

Add DecideDestinationWithSuggestedFilename.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::didReceiveSyncMessage):
Process MessageClassDownloadProxy messages.

  • UIProcess/WebDownloadClient.cpp:

(WebKit::WebDownloadClient::decideDestinationWithSuggestedFilename):
Ask the WKContextDownloadClient for the destination.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveSyncMessage):
MessageClassDownloadProxy messages should go to the WebContext.

  • WebProcess/Downloads/Download.cpp:

(WebKit::Download::decideDestinationWithSuggestedFilename):
Send the DecideDestinationWithSuggestedFilename message.

  • WebProcess/Downloads/Download.h:
  • WebProcess/Downloads/mac/DownloadMac.mm:

(-[WKDownloadAsDelegate download:decideDestinationWithSuggestedFilename:]):
call Download::decideDestinationWithSuggestedFilename and set the destination.

11:39 AM Changeset in webkit [72017] by jer.noble@apple.com
  • 2 edits in trunk/WebCore

2010-11-12 Jer Noble <​jer.noble@apple.com>

Reviewed by Brady Eidson.

Can't view HTML5 video when running Safari with an authenticated proxy server
<rdar://problem/8351926>


  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovie):
11:08 AM Changeset in webkit [72016] by andreas.kling@nokia.com
  • 9 edits in trunk/WebKit2

2010-11-15 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[WK2][Qt] Add "page snapshot" functionality to tiled backing store

Original patch by Antti Koivisto.

Add a way to take a snapshot of a specific part of the page, at a specific scale.
Only implemented for the tiled drawing area.

  • Shared/CoreIPCSupport/DrawingAreaMessageKinds.h: New message: TakeSnapshot.
  • Shared/CoreIPCSupport/DrawingAreaProxyMessageKinds.h: New message: SnapshotTaken.
  • UIProcess/API/qt/qgraphicswkview.h:
  • UIProcess/API/qt/qgraphicswkview.cpp: (QGraphicsWKView::takeSnapshot): Expose the snapshot functionality.
  • UIProcess/TiledDrawingAreaProxy.cpp: (WebKit::TiledDrawingAreaProxy::didReceiveMessage): (WebKit::TiledDrawingAreaProxy::takeSnapshot):
  • UIProcess/TiledDrawingAreaProxy.h:
  • UIProcess/qt/TiledDrawingAreaProxyQt.cpp: (WebKit::TiledDrawingAreaProxy::snapshotTaken):
  • WebProcess/WebPage/TiledDrawingArea.cpp: (WebKit::TiledDrawingArea::didReceiveMessage):
10:58 AM Changeset in webkit [72015] by Martin Robinson
  • 1 edit
    2 adds in trunk/LayoutTests

2010-11-15 Martin Robinson <​mrobinson@igalia.com>

[GTK] Navigation policy decision API needs to include the DOM node that the decision originated from
​https://bugs.webkit.org/show_bug.cgi?id=49551

Add GTK+-specific results for these tests which do policy delegate dumps,
until GTK+ can produce the "originating from" information.

  • platform/gtk/fast/forms/mailto/formenctype-attribute-button-html-expected.txt: Added.
  • platform/gtk/fast/forms/mailto/formenctype-attribute-input-html-expected.txt: Added.
10:45 AM Changeset in webkit [72014] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-11-15 Zhenyao Mo <​zmo@google.com>

Unreviewed, test expectation update.

  • platform/chromium/test_expectations.txt:
10:37 AM Changeset in webkit [72013] by inferno@chromium.org
  • 2 edits in trunk/WebCore

2010-11-14 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dimitri Glazkov.

Event dispatch call can blow away the node's renderer initialized
before the call in updateSelectionForMouseDrag function. We need
to initialize it after the call.
​https://bugs.webkit.org/show_bug.cgi?id=49524

  • page/EventHandler.cpp: (WebCore::EventHandler::updateSelectionForMouseDrag):
9:42 AM Changeset in webkit [72012] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-11-12 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

[Chromium] fast/canvas/webgl/tex-image-and-sub-image-2d-with-array-buffer-view.html is a flaky crash
​https://bugs.webkit.org/show_bug.cgi?id=48142

  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-array-buffer-view.html: Cleanup the test, hoping to stop flaky crashes on chromium bots.
9:35 AM Changeset in webkit [72011] by Martin Robinson
  • 2 edits
    95 adds in trunk/LayoutTests

2010-11-15 Martin Robinson <​mrobinson@igalia.com>

Add some baselines for new tests and skip a HTML5 meter test until
GTK+ supports rendering the meter element.

  • platform/gtk/Skipped: Skip meter test.
  • platform/gtk/fast/block/basic/truncation-rtl-expected.txt: Added.
  • platform/gtk/fast/blockflow/background-horizontal-bt-expected.txt: Added.
  • platform/gtk/fast/blockflow/background-vertical-lr-expected.txt: Added.
  • platform/gtk/fast/blockflow/background-vertical-rl-expected.txt: Added.
  • platform/gtk/fast/blockflow/basic-vertical-line-expected.txt: Added.
  • platform/gtk/fast/blockflow/body-direction-propagation-blocked-expected.txt: Added.
  • platform/gtk/fast/blockflow/body-direction-propagation-expected.txt: Added.
  • platform/gtk/fast/blockflow/body-writing-mode-propagation-blocked-expected.txt: Added.
  • platform/gtk/fast/blockflow/body-writing-mode-propagation-expected.txt: Added.
  • platform/gtk/fast/blockflow/border-image-horizontal-bt-expected.txt: Added.
  • platform/gtk/fast/blockflow/border-image-vertical-lr-expected.txt: Added.
  • platform/gtk/fast/blockflow/border-image-vertical-rl-expected.txt: Added.
  • platform/gtk/fast/blockflow/border-radius-clipping-vertical-lr-expected.txt: Added.
  • platform/gtk/fast/blockflow/border-vertical-lr-expected.txt: Added.
  • platform/gtk/fast/blockflow/box-shadow-horizontal-bt-expected.txt: Added.
  • platform/gtk/fast/blockflow/box-shadow-vertical-lr-expected.txt: Added.
  • platform/gtk/fast/blockflow/box-shadow-vertical-rl-expected.txt: Added.
  • platform/gtk/fast/blockflow/broken-ideograph-small-caps-expected.txt: Added.
  • platform/gtk/fast/blockflow/broken-ideographic-font-expected.txt: Added.
  • platform/gtk/fast/blockflow/english-bt-text-expected.txt: Added.
  • platform/gtk/fast/blockflow/english-lr-text-expected.txt: Added.
  • platform/gtk/fast/blockflow/english-rl-text-expected.txt: Added.
  • platform/gtk/fast/blockflow/horizontal-bt-replaced-selection-expected.txt: Added.
  • platform/gtk/fast/blockflow/japanese-lr-selection-expected.txt: Added.
  • platform/gtk/fast/blockflow/japanese-lr-text-expected.txt: Added.
  • platform/gtk/fast/blockflow/japanese-rl-selection-expected.txt: Added.
  • platform/gtk/fast/blockflow/japanese-rl-text-expected.txt: Added.
  • platform/gtk/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt: Added.
  • platform/gtk/fast/blockflow/japanese-ruby-vertical-lr-expected.txt: Added.
  • platform/gtk/fast/blockflow/japanese-ruby-vertical-rl-expected.txt: Added.
  • platform/gtk/fast/blockflow/vertical-font-fallback-expected.txt: Added.
  • platform/gtk/fast/blockflow/vertical-lr-replaced-selection-expected.txt: Added.
  • platform/gtk/fast/blockflow/vertical-rl-replaced-selection-expected.txt: Added.
  • platform/gtk/fast/borders/border-radius-inline-flow-expected.txt: Added.
  • platform/gtk/fast/images/gray-scale-png-with-color-profile-expected.txt: Added.
  • platform/gtk/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.txt: Added.
  • platform/gtk/fast/lists/001-vertical-expected.txt: Added.
  • platform/gtk/fast/lists/002-vertical-expected.txt: Added.
  • platform/gtk/fast/lists/003-vertical-expected.txt: Added.
  • platform/gtk/fast/lists/005-vertical-expected.txt: Added.
  • platform/gtk/fast/lists/006-vertical-expected.txt: Added.
  • platform/gtk/fast/lists/007-vertical-expected.txt: Added.
  • platform/gtk/fast/lists/008-vertical-expected.txt: Added.
  • platform/gtk/fast/lists/009-vertical-expected.txt: Added.
  • platform/gtk/fast/repaint/iframe-scroll-repaint-expected.txt: Added.
  • platform/gtk/fast/repaint/inline-horizontal-bt-overflow-expected.txt: Added.
  • platform/gtk/fast/repaint/inline-vertical-lr-overflow-expected.txt: Added.
  • platform/gtk/fast/repaint/inline-vertical-rl-overflow-expected.txt: Added.
  • platform/gtk/fast/repaint/japanese-rl-selection-clear-expected.txt: Added.
  • platform/gtk/fast/repaint/japanese-rl-selection-repaint-expected.txt: Added.
  • platform/gtk/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Added.
  • platform/gtk/fast/repaint/selection-rl-expected.txt: Added.
  • platform/gtk/fast/table/027-vertical-expected.txt: Added.
  • platform/gtk/fast/table/028-vertical-expected.txt: Added.
  • platform/gtk/fast/table/035-vertical-expected.txt: Added.
  • platform/gtk/fast/table/038-vertical-expected.txt: Added.
  • platform/gtk/fast/table/040-vertical-expected.txt: Added.
  • platform/gtk/fast/table/auto-with-percent-height-vertical-expected.txt: Added.
  • platform/gtk/fast/table/border-collapsing/001-vertical-expected.txt: Added.
  • platform/gtk/fast/table/border-collapsing/002-vertical-expected.txt: Added.
  • platform/gtk/fast/table/border-collapsing/003-vertical-expected.txt: Added.
  • platform/gtk/fast/table/border-collapsing/004-vertical-expected.txt: Added.
  • platform/gtk/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.txt: Added.
  • platform/gtk/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.txt: Added.
  • platform/gtk/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.txt: Added.
  • platform/gtk/fast/table/colspanMinWidth-vertical-expected.txt: Added.
  • platform/gtk/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt: Added.
  • platform/gtk/fast/table/growCellForImageQuirk-vertical-expected.txt: Added.
  • platform/gtk/fast/table/height-percent-test-vertical-expected.txt: Added.
  • platform/gtk/fast/table/percent-widths-stretch-vertical-expected.txt: Added.
  • platform/gtk/fast/table/rowspan-paint-order-vertical-expected.txt: Added.
  • platform/gtk/fast/table/table-display-types-vertical-expected.txt: Added.
  • platform/gtk/fast/text/international/vertical-text-glyph-test-expected.txt: Added.
  • platform/gtk/fast/text/international/vertical-text-metrics-test-expected.txt: Added.
  • platform/gtk/fast/transforms/rotated-transform-affects-scrolling-1-expected.txt: Added.
  • platform/gtk/fast/transforms/rotated-transform-affects-scrolling-2-expected.txt: Added.
  • platform/gtk/mathml/xHeight-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Added.
  • platform/gtk/svg/custom/repaint-on-constant-size-change-expected.txt: Added.
9:34 AM Changeset in webkit [72010] by andreas.kling@nokia.com
  • 8 edits
    8 adds in trunk/WebKit2

2010-11-15 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[WK2][Qt] WebKit2 implementation of tiled backing store
​https://bugs.webkit.org/show_bug.cgi?id=49526

Basic opt-in tiling implementation for WebKit2/Qt.

Original patch by Antti Koivisto.

  • Shared/CoreIPCSupport/DrawingAreaMessageKinds.h: New messages: RequestTileUpdate and CancelTileUpdate.
  • Shared/CoreIPCSupport/DrawingAreaProxyMessageKinds.h: New messages: Invalidate, TileUpdated, AllTileUpdatesProcessed.
  • Shared/DrawingAreaBase.h: New area type: TiledDrawingAreaType.
  • UIProcess/API/qt/qgraphicswkview.h:
  • UIProcess/API/qt/qgraphicswkview.cpp: (QGraphicsWKView::QGraphicsWKView): (QGraphicsWKView::setGeometry): (QGraphicsWKViewPrivate::QGraphicsWKViewPrivate): (QGraphicsWKView::prepareScaleChange): (QGraphicsWKView::commitScaleChange): (QGraphicsWKViewPrivate::onScaleChanged): (QGraphicsWKViewPrivate::commitScale): Support for tiled backing store.
  • UIProcess/TiledDrawingAreaProxy.cpp: Added. (WebKit::TiledDrawingAreaProxy::create): (WebKit::TiledDrawingAreaProxy::TiledDrawingAreaProxy): (WebKit::TiledDrawingAreaProxy::~TiledDrawingAreaProxy): (WebKit::TiledDrawingAreaProxy::setSize): (WebKit::TiledDrawingAreaProxy::setPageIsVisible): (WebKit::TiledDrawingAreaProxy::didSetSize): (WebKit::TiledDrawingAreaProxy::didReceiveMessage): (WebKit::TiledDrawingAreaProxy::didReceiveSyncMessage): (WebKit::TiledDrawingAreaProxy::requestTileUpdate): (WebKit::TiledDrawingAreaProxy::waitUntilUpdatesComplete): (WebKit::TiledDrawingAreaProxy::createTile): (WebKit::TiledDrawingAreaProxy::setTileSize): (WebKit::TiledDrawingAreaProxy::setTileCreationDelay): (WebKit::TiledDrawingAreaProxy::setKeepAndCoverAreaMultipliers): (WebKit::TiledDrawingAreaProxy::invalidate): (WebKit::TiledDrawingAreaProxy::updateTileBuffers): (WebKit::TiledDrawingAreaProxy::tileBufferUpdateComplete): (WebKit::TiledDrawingAreaProxy::paint): (WebKit::TiledDrawingAreaProxy::adjustVisibleRect): (WebKit::TiledDrawingAreaProxy::setContentsScale): (WebKit::TiledDrawingAreaProxy::removeAllTiles): (WebKit::TiledDrawingAreaProxy::tileDistance): (WebKit::TiledDrawingAreaProxy::calculateKeepRect): (WebKit::TiledDrawingAreaProxy::calculateCoverRect): (WebKit::TiledDrawingAreaProxy::createTiles): (WebKit::TiledDrawingAreaProxy::resizeEdgeTiles): (WebKit::TiledDrawingAreaProxy::dropTilesOutsideRect): (WebKit::TiledDrawingAreaProxy::tileAt): (WebKit::TiledDrawingAreaProxy::setTile): (WebKit::TiledDrawingAreaProxy::removeTile): (WebKit::TiledDrawingAreaProxy::mapToContents): (WebKit::TiledDrawingAreaProxy::mapFromContents): (WebKit::TiledDrawingAreaProxy::contentsRect): (WebKit::TiledDrawingAreaProxy::tileRectForCoordinate): (WebKit::TiledDrawingAreaProxy::tileCoordinateForPoint): (WebKit::TiledDrawingAreaProxy::startTileBufferUpdateTimer): (WebKit::TiledDrawingAreaProxy::tileBufferUpdateTimerFired): (WebKit::TiledDrawingAreaProxy::startTileCreationTimer): (WebKit::TiledDrawingAreaProxy::tileCreationTimerFired): (WebKit::TiledDrawingAreaProxy::hasPendingUpdates):
  • UIProcess/TiledDrawingAreaProxy.h: Added. (WebKit::TiledDrawingAreaProxy::contentsScale): (WebKit::TiledDrawingAreaProxy::attachCompositingContext): (WebKit::TiledDrawingAreaProxy::detachCompositingContext): (WebKit::TiledDrawingAreaProxy::tileSize): (WebKit::TiledDrawingAreaProxy::tileCreationDelay): (WebKit::TiledDrawingAreaProxy::getKeepAndCoverAreaMultipliers):
  • UIProcess/TiledDrawingAreaTile.h: Added. (WebKit::TiledDrawingAreaTile::create): (WebKit::TiledDrawingAreaTile::hasBackBufferUpdatePending): (WebKit::TiledDrawingAreaTile::coordinate): (WebKit::TiledDrawingAreaTile::rect): (WebKit::TiledDrawingAreaTile::ID):
  • WebProcess/WebPage/DrawingArea.cpp: (WebKit::DrawingArea::create):
  • WebProcess/WebPage/TiledDrawingArea.cpp: Added. (WebKit::TiledDrawingArea::TiledDrawingArea): (WebKit::TiledDrawingArea::~TiledDrawingArea): (WebKit::TiledDrawingArea::invalidateWindow): (WebKit::TiledDrawingArea::invalidateContentsAndWindow): (WebKit::TiledDrawingArea::invalidateContentsForSlowScroll): (WebKit::TiledDrawingArea::scroll): (WebKit::TiledDrawingArea::setNeedsDisplay): (WebKit::TiledDrawingArea::display): (WebKit::TiledDrawingArea::scheduleDisplay): (WebKit::TiledDrawingArea::setSize): (WebKit::TiledDrawingArea::suspendPainting): (WebKit::TiledDrawingArea::resumePainting): (WebKit::TiledDrawingArea::didUpdate): (WebKit::TiledDrawingArea::updateTile): (WebKit::TiledDrawingArea::tileUpdateTimerFired): (WebKit::TiledDrawingArea::didReceiveMessage):
  • WebProcess/WebPage/TiledDrawingArea.h: Added. (WebKit::TiledDrawingArea::attachCompositingContext): (WebKit::TiledDrawingArea::detachCompositingContext): (WebKit::TiledDrawingArea::setRootCompositingLayer): (WebKit::TiledDrawingArea::scheduleCompositingLayerSync): (WebKit::TiledDrawingArea::syncCompositingLayers):
  • WebProcess/WebPage/qt/TiledDrawingAreaQt.cpp: Added. (WebKit::TiledDrawingArea::paintIntoUpdateChunk):
  • WebKit2.pro:
  • UIProcess/qt/TiledDrawingAreaTileQt.cpp: Added. (WebKit::checkeredPixmap): (WebKit::TiledDrawingAreaTile::TiledDrawingAreaTile): (WebKit::TiledDrawingAreaTile::~TiledDrawingAreaTile): (WebKit::TiledDrawingAreaTile::isDirty): (WebKit::TiledDrawingAreaTile::isReadyToPaint): (WebKit::TiledDrawingAreaTile::hasReadyBackBuffer): (WebKit::TiledDrawingAreaTile::invalidate): (WebKit::TiledDrawingAreaTile::resize): (WebKit::TiledDrawingAreaTile::swapBackBufferToFront): (WebKit::TiledDrawingAreaTile::paint): (WebKit::TiledDrawingAreaTile::paintCheckerPattern): (WebKit::TiledDrawingAreaTile::updateFromChunk): (WebKit::TiledDrawingAreaTile::updateBackBuffer):
  • UIProcess/qt/TiledDrawingAreaProxyQt.cpp: Added. (WebKit::TiledDrawingAreaProxy::updateWebView): (WebKit::TiledDrawingAreaProxy::webViewVisibleRect): (WebKit::TiledDrawingAreaProxy::page):
9:29 AM Changeset in webkit [72009] by bulach@chromium.org
  • 1 edit
    12 adds in trunk/LayoutTests

2010-11-15 Marcus Bulach <​bulach@chromium.org>

Not reviewed, Chromium test expectation update.

Update chromium baselines for svg following r72006
​https://bugs.webkit.org/show_bug.cgi?id=49547

  • platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
8:56 AM Changeset in webkit [72008] by benjamin.poulain@nokia.com
  • 3 edits in trunk/WebKitTools

2010-11-15 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Andreas Kling.

[Qt] [WK2] Add Ctrl+L shortcut to Qt Minibrowser
​https://bugs.webkit.org/show_bug.cgi?id=49544

Add the shortcut to BrowserWindow.

  • MiniBrowser/qt/BrowserWindow.cpp: (BrowserWindow::BrowserWindow): (BrowserWindow::openLocation):
  • MiniBrowser/qt/BrowserWindow.h:
8:24 AM Changeset in webkit [72007] by Patrick Gansterer
  • 2 edits in trunk/WebCore

2010-11-15 Patrick Gansterer <Patrick Gansterer>

Reviewed by Martin Robinson.

Make ContextShadow compile on all platforms
​https://bugs.webkit.org/show_bug.cgi?id=49535

Add a void* typedef for PlatformImage and PlatformContext for unsupported platforms
and move them into the WebCore namespace like all other Platform* typedefs.

  • platform/graphics/ContextShadow.h:
8:10 AM Changeset in webkit [72006] by reni@webkit.org
  • 4 edits
    10 adds in trunk

WebCore: SVGFEImageElement doesn't support dynamic invalidation
​https://bugs.webkit.org/show_bug.cgi?id=49536

Patch by Renata Hodovan <​reni@webkit.org> on 2010-11-15
Reviewed by Andreas Kling.

The dynamic changes are captured by the svgAttributeChanged function. Invalidate the filter primitive if necessary.

Tests: svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr.html

svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop.html

  • svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::svgAttributeChanged):

  • svg/SVGFEImageElement.h:

LayoutTests: SVGFEImageElement doesn't support dynamic invalidation, when attributes change.
​https://bugs.webkit.org/show_bug.cgi?id=49536

Patch by Renata Hodovan <​reni@webkit.org> on 2010-11-15
Reviewed by Andreas Kling.

Adding layout tests for feImage dynamic changes.

  • platform/mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
  • svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr.html: Added.
  • svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop.html: Added.
  • svg/dynamic-updates/script-tests/SVGFEImageElement-dom-preserveAspectRatio-attr.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFEImageElement-svgdom-preserveAspectRatio-prop.js: Added.

(executeTest):

6:49 AM Changeset in webkit [72005] by Csaba Osztrogonác
  • 1 edit
    5 copies
    1 add in trunk/LayoutTests

Unreviewed. Add Qt specific expected results after r72003.

[Qt] Possible DRT bug revealed by r72003
​https://bugs.webkit.org/show_bug.cgi?id=49538

  • platform/qt/fast/forms/formaction-attribute-expected.txt: Copied from LayoutTests/fast/forms/formaction-attribute-expected.txt.
  • platform/qt/fast/forms/formmethod-attribute-button-html-expected.txt: Copied from LayoutTests/fast/forms/formmethod-attribute-button-html-expected.txt.
  • platform/qt/fast/forms/formtarget-attribute-button-html-expected.txt: Copied from LayoutTests/fast/forms/formtarget-attribute-button-html-expected.txt.
  • platform/qt/fast/forms/mailto: Added.
  • platform/qt/fast/forms/mailto/formenctype-attribute-button-html-expected.txt: Copied from LayoutTests/fast/forms/mailto/formenctype-attribute-button-html-expected.txt.
  • platform/qt/fast/forms/mailto/formenctype-attribute-input-html-expected.txt: Copied from LayoutTests/fast/forms/mailto/formenctype-attribute-input-html-expected.txt.
5:32 AM Changeset in webkit [72004] by yael.aharon@nokia.com
  • 3 edits
    3 adds in trunk

2010-11-15 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Antonio Gomes.

[Qt] Focus ring does not show on focused links.
​https://bugs.webkit.org/show_bug.cgi?id=49515

  • platform/qt/fast/inline/inline-focus-ring-expected.checksum: Added.
  • platform/qt/fast/inline/inline-focus-ring-expected.png: Added.
  • platform/qt/fast/inline/inline-focus-ring-expected.txt: Added.

2010-11-15 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Antonio Gomes.

[Qt] Focus ring does not show on focused links.
​https://bugs.webkit.org/show_bug.cgi?id=49515

After ​http://trac.webkit.org/changeset/69766 the focus ring on links is no longer
visible in Qt.
The reason is that Qt always returned true in RenderTheme::supportsFocusRing(),
but until r69766, we did not check that for links. Qt draws its own focus ring
for controls that it draws, but not for links.
Change the return value to false if the style's appearance is not something that Qt
draws by itself or does not support.
Added a Qt specific test result for the new test added in r69766.

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::supportsFocusRing):
4:43 AM Changeset in webkit [72003] by commit-queue@webkit.org
  • 7 edits
    17 adds in trunk

2010-11-15 Dai Mikurube <​dmikurube@google.com>

Reviewed by Kent Tamura.

Implement formaction, formenctype, formmethod and formtarget attributes for input and button tags
​https://bugs.webkit.org/show_bug.cgi?id=49240

  • fast/forms/formaction-attribute-expected.txt: Added.
  • fast/forms/formaction-attribute.html: Added.
  • fast/forms/formmethod-attribute-button-html-expected.txt: Added.
  • fast/forms/formmethod-attribute-button-html.html: Added.
  • fast/forms/formmethod-attribute-input-html-expected.txt: Added.
  • fast/forms/formmethod-attribute-input-html.html: Added.
  • fast/forms/formtarget-attribute-button-html-expected.txt: Added.
  • fast/forms/formtarget-attribute-button-html.html: Added.
  • fast/forms/formtarget-attribute-input-html-expected.txt: Added.
  • fast/forms/formtarget-attribute-input-html.html: Added.
  • fast/forms/mailto/formenctype-attribute-button-html-expected.txt: Added.
  • fast/forms/mailto/formenctype-attribute-button-html.html: Added.
  • fast/forms/mailto/formenctype-attribute-input-html-expected.txt: Added.
  • fast/forms/mailto/formenctype-attribute-input-html.html: Added.
  • fast/forms/script-tests/submit-form-attributes.js: Added.
  • fast/forms/submit-form-attributes-expected.txt: Added.
  • fast/forms/submit-form-attributes.html: Added.

2010-11-15 Dai Mikurube <​dmikurube@google.com>

Reviewed by Kent Tamura.

Implement formaction, formenctype, formmethod and formtarget attributes for input and button tags
​https://bugs.webkit.org/show_bug.cgi?id=49240

Tests: fast/forms/formaction-attribute.html

fast/forms/formmethod-attribute-button-html.html
fast/forms/formmethod-attribute-input-html.html
fast/forms/formtarget-attribute-button-html.html
fast/forms/formtarget-attribute-input-html.html
fast/forms/mailto/formenctype-attribute-button-html.html
fast/forms/mailto/formenctype-attribute-input-html.html
fast/forms/submit-form-attributes.html

  • html/HTMLAttributeNames.in: Added formaction, formmethod, formtarget and formenctype attributes
  • html/HTMLButtonElement.idl:
  • html/HTMLInputElement.idl:
  • loader/FormSubmission.cpp: Modified to check the pressed button and its attributes (WebCore::FormSubmission::Attributes::copyFrom): (WebCore::FormSubmission::create):
  • loader/FormSubmission.h:
4:09 AM Changeset in webkit [72002] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-11-15 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Do not hide default Ctrl+A behavior on non-Mac.
​https://bugs.webkit.org/show_bug.cgi?id=49527

  • inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype._onKeyDown):
3:37 AM Changeset in webkit [72001] by commit-queue@webkit.org
  • 9 edits in trunk

2010-11-15 Ilya Sherman <​isherman@chromium.org>

Reviewed by Kent Tamura.

Add capability for displaying warnings to autofill popup
Warnings are displayed in dark gray italic.
​https://bugs.webkit.org/show_bug.cgi?id=49291
​http://code.google.com/p/chromium/issues/detail?id=58509

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::getRowFont): Use item-specific font, not just the generic menu font. (WebCore::PopupListBox::selectIndex): Updated to clear the selection when hovering over a non-selectable item.
  • platform/chromium/PopupMenuChromium.h: Minor cleanup

2010-11-15 Ilya Sherman <​isherman@chromium.org>

Reviewed by Kent Tamura.

Add capability for displaying warnings to autofill popup
Warnings are displayed in dark gray italic.
​https://bugs.webkit.org/show_bug.cgi?id=49291
​http://code.google.com/p/chromium/issues/detail?id=58509

  • src/AutoFillPopupMenuClient.cpp: (WebKit::AutoFillPopupMenuClient::canRemoveSuggestionAtIndex): Updated logic -- can only remove Autocomplete suggestions, which have unique ID 0. (WebKit::AutoFillPopupMenuClient::itemIsEnabled): False for warnings. (WebKit::AutoFillPopupMenuClient::itemStyle): Dark gray italic for warnings. (WebKit::AutoFillPopupMenuClient::menuStyle): Variable name changed. (WebKit::AutoFillPopupMenuClient::itemIsWarning): True for unique ID < 0. (WebKit::AutoFillPopupMenuClient::initialize): Updated cached styles (see above).
  • src/AutoFillPopupMenuClient.h: Added itemIsEnabled(), variable to cache warning style.
  • src/WebViewImpl.cpp: Minor cleanup. (WebKit::WebViewImpl::applyAutoFillSuggestions):
2:39 AM Changeset in webkit [72000] by alex
  • 2 edits in trunk/LayoutTests

2010-11-15 Alejandro G. Castro <​alex@igalia.com>

Unreviewed.

Skipping SVG failing tests for GTK+ until we find the issue,
opened a bug:
[gtk] SVGLineElement-dom-requiredFeatures.html and
SVGLineElement-svgdom-requiredFeatures.html failing in the bots
​https://bugs.webkit.org/show_bug.cgi?id=49529

  • platform/gtk/Skipped:
Note: See TracTimeline for information about the timeline view.