⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 21, 2010:

7:03 PM Changeset in webkit [72503] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Update WebKit2 skipped list.

  • platform/mac-wk2/Skipped:
6:16 PM Changeset in webkit [72502] by weinig@apple.com
  • 2 edits in trunk/WebKitTools

Fix ~300 WebKit2 tests by enabling developer extras preference.

Rubber-stamped by Dan Bernstein.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

6:08 PM Changeset in webkit [72501] by weinig@apple.com
  • 12 edits
    1 add in trunk

Textareas should be resizable by default
​https://bugs.webkit.org/show_bug.cgi?id=49892

Reviewed by Dan Bernstein.

WebKit2:

Test: WebKit2/WKPreferences

  • Shared/WebPreferencesStore.cpp:

(WebKit::WebPreferencesStore::WebPreferencesStore):
(WebKit::WebPreferencesStore::encode):
(WebKit::WebPreferencesStore::decode):

  • Shared/WebPreferencesStore.h:

Add textAreasAreResizable bit.

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetJavaEnabled):
(WKPreferencesGetJavaEnabled):
Fix typo, WKPRe... -> WKPre...

(WKPreferencesSetMinimumFontSize):
(WKPreferencesGetMinimumFontSize):
Fix comment to correctly reflect that the default minimumFontSize is 0, not 1.

(WKPreferencesSetTextAreasAreResizable):
(WKPreferencesGetTextAreasAreResizable):

  • UIProcess/API/C/WKPreferences.h:

Add API.

  • UIProcess/API/C/WKPreferencesPrivate.h:

Don't use PLATFORM in API headers.

  • UIProcess/WebPreferences.cpp:

(WebKit::WebPreferences::setTextAreasAreResizable):
(WebKit::WebPreferences::textAreasAreResizable):

  • UIProcess/WebPreferences.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):
Pipe bit through to the WebProcess and onto WebCore::Settings.

WebKitTools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp: Added.
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:

Add preferences test.

4:10 PM Changeset in webkit [72500] by Patrick Gansterer
  • 25 edits in trunk/WebCore

2010-11-21 Patrick Gansterer <Patrick Gansterer>

Reviewed by Csaba Osztrogonác.

Use WTF_ARRAY_LENGTH in WebCore directory
​https://bugs.webkit.org/show_bug.cgi?id=49882

  • accessibility/AccessibilityObject.cpp: (WebCore::createARIARoleMap):
  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::JSDOMWindowBase):
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::ConfigureV8TestObjTemplate):
  • css/CSSComputedStyleDeclaration.cpp:
  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseAnimationShorthand): (WebCore::CSSParser::parseTransitionShorthand):
  • css/CSSPropertyLonghand.cpp: (WebCore::initShorthandMap):
  • dom/ExceptionCode.cpp: (WebCore::getExceptionCodeDescription):
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement):
  • editing/EditingStyle.cpp:
  • editing/Editor.cpp: (WebCore::triStateOfStyle):
  • editing/EditorCommand.cpp: (WebCore::createCommandMap):
  • editing/MarkupAccumulator.cpp: (WebCore::appendCharactersReplacingEntities):
  • html/canvas/WebGLBuffer.cpp: (WebCore::WebGLBuffer::getCachedMaxIndex): (WebCore::WebGLBuffer::setCachedMaxIndex):
  • loader/FTPDirectoryParser.cpp: (WebCore::parseOneFTPLine):
  • mathml/RenderMathMLOperator.cpp: (WebCore::RenderMathMLOperator::updateFromElement):
  • page/animation/AnimationBase.cpp: (WebCore::addShorthandProperties):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::hasValidAvgCharWidth):
  • rendering/break_lines.cpp:
  • svg/SVGTransformable.cpp: (WebCore::parseAndSkipType):
  • svg/SVGViewSpec.cpp: (WebCore::SVGViewSpec::parseViewSpec):
  • svg/SVGZoomAndPan.cpp: (WebCore::SVGZoomAndPan::parseZoomAndPan):
  • xml/XPathFunctions.cpp: (WebCore::XPath::createFunctionMap):
3:03 PM Changeset in webkit [72499] by mario@webkit.org
  • 8 edits in trunk

2010-11-21 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Chris Fleizach.

[GTK] Implement ROLE_COMBO_BOX
​https://bugs.webkit.org/show_bug.cgi?id=25678

Implement the remaining bits for combo boxes.

This patch finishes the implementation, from the point of view of
the Atk library, of those objects exposed to ATK as combo boxes,
and their related elements (menus and menu items). It therefore
implements the proper interfaces for each type of object related
to combo boxes (AtkSelection for the combo box, AtkText for every
menu item and AtkAction for the combo box, the menu and the menu
items), takes care of emitting the proper signals when focus or a
given a selection changes and adds a new unit test to check all
this new stuff.

Make possible to ask an AccessibleMenuListOption for a sensible
string representation, so far only available through the private
and MSAA related method nameForMSAA. Just moved the implementation
of that method to an overriden version of stringValue(), which is
platform independent, and called that from nameForMSAA().

  • accessibility/AccessibilityMenuListOption.h:
  • accessibility/AccessibilityMenuListOption.cpp: (WebCore::AccessibilityMenuListOption::nameForMSAA): Just call to stringValue(), which holds from now on that used to be here. (WebCore::AccessibilityMenuListOption::stringValue): New, override of AccessibilityObject::stringValue() to return a proper string.

Emit the missing signals when a selection is made.

  • accessibility/gtk/AXObjectCacheAtk.cpp: (WebCore::AXObjectCache::postPlatformNotification): Emit the usual 'focus' signals when a selection is made over the combo box.
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (setAtkStateSetFromCoreObject): Ensure the EXPANDABLE and EXPANDED Atk states are added to the state set when needed. (listObjectForSelection): New, returns the proper list object (the one holding the list of available options as its children) for an specific AtkObject implementing AtkSelection. This is needed because sometimes the selectable options are not directly children of the AtkSelection object (i.e. a combo box has a 'menu' object as its only child of it, holding the list of options as children). (optionFromList): Use listObjectForSelection() to get the actual object holding the list of children as the available options. (optionFromSelection): Add support for combo boxes. (webkit_accessible_selection_add_selection): Ditto. (webkit_accessible_selection_clear_selection): Ditto. (webkit_accessible_selection_get_selection_count): Ditto. (webkit_accessible_selection_is_child_selected): Ditto. (webkit_accessible_selection_remove_selection): Ditto. (webkit_accessible_text_get_text): Makes sure stringValue() is considered to get the result substring when it was already considered when checking the maximum text length for the object. (getInterfaceMaskFromObject): Make sure the AtkSelection interface is implemented for the combo boxes, that the AtkText is implemented for the menu items and that the AtkAction interface is now implemented for every object (WebCore will decide what to do).

Avoid a segfault crash when using this from unit tests.

  • platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenuGtk::show): Make sure we got a valid GdkWindow before calling gdk_window_get_origin() over it.

2010-11-21 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Chris Fleizach.

[GTK] Implement ROLE_COMBO_BOX
​https://bugs.webkit.org/show_bug.cgi?id=25678

New test to check the implementation of the combo boxes.

  • tests/testatk.c: (testWebkitAtkComboBox): New test, checking that the roles and the implemented interfaces for a combo box and its descendants work. (main): Added the new unit test.
9:09 AM Changeset in webkit [72498] by Patrick Gansterer
  • 19 edits in trunk/WebCore

2010-11-21 Patrick Gansterer <Patrick Gansterer>

Reviewed by Csaba Osztrogonác.

Use WTF_ARRAY_LENGTH in WebCore/platform directory
​https://bugs.webkit.org/show_bug.cgi?id=49881

  • platform/KURL.cpp: (WebCore::portAllowed):
  • platform/KURLGoogle.cpp: (WebCore::portAllowed):
  • platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedImageMIMETypes): (WebCore::initializeSupportedJavaScriptMIMETypes): (WebCore::initializeSupportedNonImageMimeTypes):
  • platform/UUID.cpp: (WebCore::createCanonicalUUIDString):
  • platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::applyEdjeStateFromForm):
  • platform/graphics/GraphicsTypes.cpp:
  • platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::FontCodepage::if):
  • platform/graphics/chromium/FontUtilsChromiumWin.cpp:
  • platform/graphics/mac/ComplexTextControllerCoreText.cpp: (WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::disableComponentsOnce):
  • platform/graphics/mac/SimpleFontDataATSUI.mm: (WebCore::SimpleFontData::checkShapesArabic):
  • platform/graphics/mac/SimpleFontDataCoreText.cpp: (WebCore::SimpleFontData::getCFStringAttributes):
  • platform/graphics/win/GraphicsContextCGWin.cpp: (WebCore::GraphicsContext::drawLineForTextChecking):
  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: (WebCore::disableComponentsOnce):
  • platform/graphics/win/QTMovie.cpp: (QTMovie::load):
  • platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::createStreams):
  • platform/text/TextEncodingRegistry.cpp: (WebCore::pruneBlacklistedCodecs):
  • platform/text/transcoder/FontTranscoder.cpp: (WebCore::FontTranscoder::FontTranscoder):
5:11 AM Changeset in webkit [72497] by Patrick Gansterer
  • 3 edits in trunk/LayoutTests

2010-11-21 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Add test for unicode plane 1 characters
​https://bugs.webkit.org/show_bug.cgi?id=49581

  • fast/encoding/xml-utf-8-default-expected.txt:
  • fast/encoding/xml-utf-8-default.xml:

Nov 20, 2010:

11:20 PM Changeset in webkit [72496] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-11-20 Andreas Kling <​kling@webkit.org>

Rubber-stamped by Antonio Gomes.

[Qt] Fix spelling error (isEmtpyValue -> isEmptyValue)

  • platform/graphics/qt/FontPlatformDataQt.cpp: (WebCore::isEmptyValue): (WebCore::FontPlatformData::FontPlatformData):
10:44 PM Changeset in webkit [72495] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-11-20 Andreas Kling <​kling@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Limit the size of image preview "cursor" when dragging
​https://bugs.webkit.org/show_bug.cgi?id=49872

Respect DragController::maxDragImageSize() (currently 400x400.)

  • platform/qt/DragImageQt.cpp: (WebCore::dragImageSize): (WebCore::scaleDragImage):
10:36 PM Changeset in webkit [72494] by andreas.kling@nokia.com
  • 5 edits in trunk

2010-11-20 Andreas Kling <​kling@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Dragging a selection should use a rendering of the selection as "cursor" for the drag
​https://bugs.webkit.org/show_bug.cgi?id=49870

  • WebCoreSupport/DragClientQt.cpp: (WebCore::DragClientQt::startDrag): Pass the DragImage to QDrag::setPixmap()

2010-11-20 Andreas Kling <​kling@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Dragging a selection should use a rendering of the selection as "cursor" for the drag
​https://bugs.webkit.org/show_bug.cgi?id=49870

Implement Frame::dragImageForSelection() and the necessary DragImage helpers for Qt.

  • page/qt/FrameQt.cpp: (WebCore::Frame::dragImageForSelection):
  • platform/qt/DragImageQt.cpp: (WebCore::deleteDragImage): (WebCore::createDragImageFromImage):
10:22 PM Changeset in webkit [72493] by xan@webkit.org
  • 3 edits in trunk/WebKit/gtk

2010-11-20 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

Remove leftover code in unit test.

  • GNUmakefile.am: remove unneeded utils file in dependency list.
  • tests/testdomdocument.c: (main): do not change to the directory of a non existing resource list.
10:11 PM Changeset in webkit [72492] by xan@webkit.org
  • 13 edits
    1 copy
    1 add in trunk

WebCore:

2010-11-20 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Memory managament for DOM GObject wrappers
​https://bugs.webkit.org/show_bug.cgi?id=40302

Initial attempt to have a kind of poor man's garbage collection
for GObject DOM objects. We tie the object's lifecycle to their
parent Frame and/or its document; that is, all objects will be
collected when their parent frame is destroyed or when that frame
transitions to a new document. Manual management (calling
g_object_unref on them) is also allowed, and is required for
objects that are not in the DOM tree (eg NodeLists).

  • GNUmakefile.am:
  • bindings/gobject/DOMObjectCache.cpp: Added.
  • bindings/gobject/DOMObjectCache.h: Copied from WebCore/bindings/gobject/WebKitDOMBinding.h.
  • bindings/gobject/WebKitDOMBinding.cpp: Remove the old cache code.
  • bindings/gobject/WebKitDOMBinding.h: ditto.
  • bindings/scripts/CodeGeneratorGObject.pm: include the new DOMObjectCache header.

WebKit/gtk:

2010-11-20 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Memory managament for DOM GObject wrappers
​https://bugs.webkit.org/show_bug.cgi?id=40302

Initial attempt to have a kind of poor man's garbage collection
for GObject DOM objects. We tie the object's lifecycle to their
parent Frame and/or its document; that is, all objects will be
collected when their parent frame is destroyed or when that frame
transitions to a new document. Manual management (calling
g_object_unref on them) is also allowed, and is required for
objects that are not in the DOM tree (eg NodeLists).

  • GNUmakefile.am: add testutils file to testdomdocument.c
  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::setMainFrameDocumentReady): collect DOM objects on document transition.
  • tests/testdomdocument.c: (dom_document_fixture_teardown): only destroy the view if it's not already destroyed, since the new test detroys it on its own. (test_dom_document_get_elements_by_tag_name): manually unref node list. (test_dom_document_get_elements_by_class_name): ditto. (test_dom_document_get_links): ditto. (test_dom_document_garbage_collection): test all possible scenarios for DOM object "garbage collection". (main): add new test.
  • tests/testdomnode.c: (test_dom_node_hierarchy_navigation): manually unref node list. (test_dom_node_insertion): ditto.
  • webkit/webkithittestresult.cpp: (webkit_hit_test_result_dispose): unref the inner node on dispose now that the memory management model is clarified. (webkit_hit_test_result_class_init): hook dispose.
  • webkit/webkitwebframe.cpp: (webkit_web_frame_core_frame_gone): clear DOM objects attached to this frame. (webkit_web_frame_finalize): ditto.
10:03 PM Changeset in webkit [72491] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-11-20 Sam Magnuson <​smagnuso@gmail.com>

Reviewed by Andreas Kling.

[Qt] crash when attempting to add a JS object
​https://bugs.webkit.org/show_bug.cgi?id=49287

  • Api/qwebframe.cpp: (QWebFrame::addToJavaScriptWindowObject):

Test: LayoutTests/fast/frames/sandboxed-iframe-plugins.html

8:19 PM Changeset in webkit [72490] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

2010-11-20 Helder Correia <​helder@sencha.com>

Reviewed by Andreas Kling.

[Qt] Path stroke lacks blur shadow support
​https://bugs.webkit.org/show_bug.cgi?id=49490

Add new test for checking path stroke blur shadow.

  • fast/canvas/canvas-strokePath-shadow-expected.txt: Added.
  • fast/canvas/canvas-strokePath-shadow.html: Added.
  • fast/canvas/script-tests/canvas-strokePath-shadow.js: Added.

2010-11-20 Helder Correia <​helder@sencha.com>

Reviewed by Andreas Kling.

[Qt] Path stroke lacks blur shadow support
​https://bugs.webkit.org/show_bug.cgi?id=49490

Add blur shadow support to strokePath().

Test: fast/canvas/canvas-strokePath-shadow.html

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::strokePath):
6:48 PM Changeset in webkit [72489] by barraclough@apple.com
  • 22 edits in trunk

YARR JIT should fallback to YARR Interpreter instead of PCRE.
​https://bugs.webkit.org/show_bug.cgi?id=46719

Patch by Peter Varga <​pvarga@inf.u-szeged.hu> on 2010-11-19
Reviewed by Gavin Barraclough.

Remove the ENABLE_YARR macro and the option of matching regular
expressions with PCRE from JavaScriptCore.

JavaScriptCore:

  • runtime/JSGlobalData.h:
  • runtime/RegExp.cpp:

(JSC::RegExp::compile):
(JSC::RegExp::match):

  • tests/mozilla/expected.html:
  • wtf/Platform.h:
  • yarr/RegexCompiler.cpp:
  • yarr/RegexCompiler.h:
  • yarr/RegexInterpreter.cpp:

(JSC::Yarr::byteCompileRegex):

  • yarr/RegexInterpreter.h:
  • yarr/RegexJIT.cpp:

(JSC::Yarr::jitCompileRegex):

  • yarr/RegexJIT.h:

(JSC::Yarr::RegexCodeBlock::RegexCodeBlock):
(JSC::Yarr::RegexCodeBlock::~RegexCodeBlock):
(JSC::Yarr::RegexCodeBlock::getFallback):
(JSC::Yarr::RegexCodeBlock::isFallback):
(JSC::Yarr::RegexCodeBlock::setFallback):
(JSC::Yarr::executeRegex):

  • yarr/RegexParser.h:
  • yarr/RegexPattern.h:

LayoutTests:

  • fast/js/regexp-look-ahead-empty-expected.txt:
  • fast/js/regexp-overflow-expected.txt:
  • fast/js/script-tests/regexp-overflow.js:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.2/15.10.2.5_Term/S15.10.2.5_A1_T4-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.2/15.10.2.8_Atom/S15.10.2.8_A2_T1-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.6/15.10.6.2_RegExp.prototype.exec/S15.10.6.2_A1_T6-expected.txt:
5:05 PM Changeset in webkit [72488] by rniwa@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

2010-11-20 Ryosuke Niwa <​rniwa@webkit.org>

Another unreviewed rebaseline for r72482.

  • editing/selection/extend-selection-home-end-expected.txt:
  • platform/chromium-win/editing/selection/extend-selection-home-end-expected.txt: Added.
4:27 PM Changeset in webkit [72487] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-11-20 Kwang Yul Seo <​skyul@company100.net>

Reviewed by David Kilzer.

[BREWMP] Replace HTONL, HTONS, NTOHL and NTOHS with byte order conversion functions from AEEstd.h
​https://bugs.webkit.org/show_bug.cgi?id=49518

HTONL, HTONS, NTOHL and NTOHS macros are prohibited in Mod1. Use byte order conversion functions provided by AEEstd.h.

  • platform/graphics/WOFFFileFormat.cpp:
4:16 PM Changeset in webkit [72486] by rniwa@webkit.org
  • 5 edits
    2 adds
    3 deletes in trunk/LayoutTests

2010-11-20 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed rebaselines for r72482.

Since Home/End behavior is different on Mac and GTK, move the expected result added by r72482
to platform/mac and platform/gtk, and add new expected result for other platforms.

See also: ​http://trac.webkit.org/changeset/54980 and ​https://webkit.org/b/35066.

  • editing/selection/extend-selection-home-end-expected.txt:
  • platform/chromium-win/editing/selection/extend-selection-expected.txt: Removed.
  • platform/chromium/test_expectations.txt: Removed extend-selection.html.
  • platform/gtk/Skipped: Ditto.
  • platform/gtk/editing/selection/extend-selection-expected.txt: Removed.
  • platform/gtk/editing/selection/extend-selection-home-end-expected.txt: Added.
  • platform/mac/editing/selection/extend-selection-home-end-expected.txt: Added.
  • platform/qt/Skipped: Removed extend-selection.html.
  • platform/win/editing/selection/extend-selection-expected.txt: Removed.
3:34 PM Changeset in webkit [72485] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-11-20 Kwang Yul Seo <​skyul@company100.net>

Reviewed by David Kilzer.

[BREWMP] Use std_wstrlen instead of WSTRLEN
​https://bugs.webkit.org/show_bug.cgi?id=49516

WSTRLEN is prohibited in Mod1. Use std_wstrlen from AEEstd.h instead.

  • platform/text/brew/StringBrew.cpp: (WTF::String::String):
3:32 PM Changeset in webkit [72484] by commit-queue@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-11-20 Kwang Yul Seo <​skyul@company100.net>

Reviewed by David Kilzer.

[BREWMP] Replace DBGPRINTF and DBGPRINTF_FATAL with dbg_Message
​https://bugs.webkit.org/show_bug.cgi?id=49520

DBGPRINTF and DBGPRINTF_FATAL macros are prohibited in Mod1. Use dbg_Message instead.

  • wtf/Assertions.cpp:
  • wtf/Assertions.h:
3:18 PM Changeset in webkit [72483] by Patrick Gansterer
  • 2 edits
    1 delete in trunk/WebCore

2010-11-20 Patrick Gansterer <Patrick Gansterer>

Reviewed by David Kilzer.

[WINCE] Implement textBreakLast and textBreakPrevious
​https://bugs.webkit.org/show_bug.cgi?id=49552

This allows us to use TextBoundaries.cpp and remove TextBoundariesWinCE.cpp.
Also unify the different TextBreakIterator::first() implementations.

  • platform/text/wince/TextBoundariesWinCE.cpp: Removed.
  • platform/text/wince/TextBreakIteratorWinCE.cpp: (WebCore::TextBreakIterator::first): (WebCore::TextBreakIterator::last): (WebCore::textBreakLast): (WebCore::textBreakPrevious):
2:51 PM Changeset in webkit [72482] by rniwa@webkit.org
  • 1 edit
    10 adds
    2 deletes in trunk/LayoutTests

2010-11-19 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Antonio Gomes.

/editing/selection/extend-selection.html should be split into smaller tests
​https://bugs.webkit.org/show_bug.cgi?id=49849

Divided the test into 4 pieces.

  • editing/selection/extend-selection-character-expected.txt: Added.
  • editing/selection/extend-selection-character.html: Added.
  • editing/selection/extend-selection-enclosing-block-expected.txt: Added.
  • editing/selection/extend-selection-enclosing-block.html: Added.
  • editing/selection/extend-selection-expected.txt: Removed.
  • editing/selection/extend-selection-home-end-expected.txt: Added.
  • editing/selection/extend-selection-home-end.html: Added.
  • editing/selection/extend-selection-word-expected.txt: Added.
  • editing/selection/extend-selection-word.html: Added.
  • editing/selection/extend-selection.html: Removed.
  • editing/selection/resources/extend-selection.css: Added. (div.test): (div.test:before): (div.test span): (div.test img): (div.test img + img): (div.test div):
  • editing/selection/resources/extend-selection.js: Added. (log): (positionsExtendingInDirectionForEnclosingBlock): (positionsExtendingInDirection): (fold): (logPositions): (checkReverseOrder): (checkSameOrder): (extendingSelection): (testExtendingSelection): (createTestNodes.window.onload): (createTestNodes):
2:02 PM Changeset in webkit [72481] by loki@webkit.org
  • 9 edits in trunk/JavaScriptCore

2010-11-20 Gabor Loki <​loki@webkit.org>

Reviewed by Gavin Barraclough.

Support JIT_OPTIMIZE_MOD on Thumb-2
​https://bugs.webkit.org/show_bug.cgi?id=49432

Rewrite the soft modulo operation into macroassembler form, and move it
to JSValue32_64 section.
Add support for soft modulo on Thumb-2 JIT also.

  • assembler/ARMv7Assembler.h: (JSC::ARMv7Assembler::clz):
  • assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::countLeadingZeros32): (JSC::MacroAssemblerARM::relativeTableJump):
  • assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::countLeadingZeros32): (JSC::MacroAssemblerARMv7::relativeTableJump):
  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_mod):
  • jit/JITOpcodes.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines):
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::softModulo):
  • jit/JITStubs.cpp: (JSC::JITThunks::JITThunks):
  • wtf/Platform.h:
1:25 PM Changeset in webkit [72480] by jparent@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Adding failing expectation for Win + Linux for new
fast/canvas/canvas-fillPath-shadow test.

  • platform/chromium/test_expectations.txt:
12:54 PM Changeset in webkit [72479] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-11-20 Andreas Kling <​kling@webkit.org>

Reviewed by David Kilzer.

Path: Remove unused method swap()
​https://bugs.webkit.org/show_bug.cgi?id=49853

  • platform/graphics/Path.h:
12:12 PM Changeset in webkit [72478] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

<​http://webkit.org/b/49867> MediaPlayerPrivateQTKit::setPreservesPitch(bool) leaks an NSDictionary

Reviewed by Dan Bernstein.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::setPreservesPitch): Use
RetainPtr<NSDictionary> for movieAttributes.

10:54 AM Changeset in webkit [72477] by ddkilzer@apple.com
  • 4 edits in trunk/JavaScriptCore

<​http://webkit.org/b/49848> Make it possible to display the last character of a secure text field unobscured

Reviewed by Darin Adler.

(WTF::StringImpl::secure): Added argument that controls whether
the last character is obscured or not. Implemented behavior.

  • wtf/text/StringImpl.h:

(WTF::StringImpl::LastCharacterBehavior): Added enum.
(WTF::StringImpl::secure): Updated method signature.

9:40 AM Changeset in webkit [72476] by Patrick Gansterer
  • 2 edits in trunk/WebCore

2010-11-20 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

Use String::fromUTF8 instead of UTF8Encoding().decode
in the libxml XMLDocumentParser
​https://bugs.webkit.org/show_bug.cgi?id=45488

  • dom/XMLDocumentParser.cpp: (WebCore::toString):
9:33 AM Changeset in webkit [72475] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-11-20 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r72471.
​http://trac.webkit.org/changeset/72471
​https://bugs.webkit.org/show_bug.cgi?id=49865

broke two IME tests on Qt (Requested by kling on #webkit).

  • Api/qwebpage.cpp: (QWebPagePrivate::inputMethodEvent):
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods):
6:21 AM Changeset in webkit [72474] by reni@webkit.org
  • 79 edits in trunk/WebCore

FilterPrimitives should have a pointer to its Filter object.
​https://bugs.webkit.org/show_bug.cgi?id=49863

Reviewed by Dirk Schulze.

FilterPrimitives should have a renderer, and they need a member pointer to their Filter objects for Layout() calls.
This patch adds this member to FilterEffect.

No new test is needed because these modifications are covered by all of SVG Filter tests.

  • platform/graphics/filters/FEBlend.cpp:

(WebCore::FEBlend::FEBlend):
(WebCore::FEBlend::create):
(WebCore::FEBlend::apply):

  • platform/graphics/filters/FEBlend.h:
  • platform/graphics/filters/FEColorMatrix.cpp:

(WebCore::FEColorMatrix::FEColorMatrix):
(WebCore::FEColorMatrix::create):
(WebCore::FEColorMatrix::apply):

  • platform/graphics/filters/FEColorMatrix.h:
  • platform/graphics/filters/FEComponentTransfer.cpp:

(WebCore::FEComponentTransfer::FEComponentTransfer):
(WebCore::FEComponentTransfer::create):
(WebCore::FEComponentTransfer::apply):

  • platform/graphics/filters/FEComponentTransfer.h:
  • platform/graphics/filters/FEComposite.cpp:

(WebCore::FEComposite::FEComposite):
(WebCore::FEComposite::create):
(WebCore::FEComposite::determineAbsolutePaintRect):
(WebCore::FEComposite::apply):

  • platform/graphics/filters/FEComposite.h:
  • platform/graphics/filters/FEConvolveMatrix.cpp:

(WebCore::FEConvolveMatrix::FEConvolveMatrix):
(WebCore::FEConvolveMatrix::create):
(WebCore::FEConvolveMatrix::apply):

  • platform/graphics/filters/FEConvolveMatrix.h:

(WebCore::FEConvolveMatrix::determineAbsolutePaintRect):

  • platform/graphics/filters/FEDiffuseLighting.cpp:

(WebCore::FEDiffuseLighting::FEDiffuseLighting):
(WebCore::FEDiffuseLighting::create):

  • platform/graphics/filters/FEDiffuseLighting.h:
  • platform/graphics/filters/FEDisplacementMap.cpp:

(WebCore::FEDisplacementMap::FEDisplacementMap):
(WebCore::FEDisplacementMap::create):
(WebCore::FEDisplacementMap::apply):

  • platform/graphics/filters/FEDisplacementMap.h:

(WebCore::FEDisplacementMap::determineAbsolutePaintRect):

  • platform/graphics/filters/FEFlood.cpp:

(WebCore::FEFlood::FEFlood):
(WebCore::FEFlood::create):
(WebCore::FEFlood::apply):

  • platform/graphics/filters/FEFlood.h:

(WebCore::FEFlood::determineAbsolutePaintRect):

  • platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::FEGaussianBlur):
(WebCore::FEGaussianBlur::create):
(WebCore::FEGaussianBlur::determineAbsolutePaintRect):
(WebCore::FEGaussianBlur::apply):

  • platform/graphics/filters/FEGaussianBlur.h:
  • platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::FELighting):
(WebCore::FELighting::apply):

  • platform/graphics/filters/FELighting.h:

(WebCore::FELighting::determineAbsolutePaintRect):

  • platform/graphics/filters/FEMerge.cpp:

(WebCore::FEMerge::FEMerge):
(WebCore::FEMerge::create):
(WebCore::FEMerge::apply):

  • platform/graphics/filters/FEMerge.h:
  • platform/graphics/filters/FEMorphology.cpp:

(WebCore::FEMorphology::FEMorphology):
(WebCore::FEMorphology::create):
(WebCore::FEMorphology::determineAbsolutePaintRect):
(WebCore::FEMorphology::apply):

  • platform/graphics/filters/FEMorphology.h:
  • platform/graphics/filters/FEOffset.cpp:

(WebCore::FEOffset::FEOffset):
(WebCore::FEOffset::create):
(WebCore::FEOffset::determineAbsolutePaintRect):
(WebCore::FEOffset::apply):

  • platform/graphics/filters/FEOffset.h:
  • platform/graphics/filters/FESpecularLighting.cpp:

(WebCore::FESpecularLighting::FESpecularLighting):
(WebCore::FESpecularLighting::create):

  • platform/graphics/filters/FESpecularLighting.h:
  • platform/graphics/filters/FETile.cpp:

(WebCore::FETile::FETile):
(WebCore::FETile::create):
(WebCore::FETile::apply):

  • platform/graphics/filters/FETile.h:

(WebCore::FETile::determineAbsolutePaintRect):

  • platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::FETurbulence):
(WebCore::FETurbulence::create):
(WebCore::FETurbulence::apply):

  • platform/graphics/filters/FETurbulence.h:

(WebCore::FETurbulence::determineAbsolutePaintRect):

  • platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::FilterEffect):
(WebCore::FilterEffect::determineAbsolutePaintRect):
(WebCore::FilterEffect::effectContext):

  • platform/graphics/filters/FilterEffect.h:

(WebCore::FilterEffect::filter):

  • platform/graphics/filters/SourceAlpha.cpp:

(WebCore::SourceAlpha::create):
(WebCore::SourceAlpha::determineAbsolutePaintRect):
(WebCore::SourceAlpha::apply):

  • platform/graphics/filters/SourceAlpha.h:

(WebCore::SourceAlpha::SourceAlpha):

  • platform/graphics/filters/SourceGraphic.cpp:

(WebCore::SourceGraphic::create):
(WebCore::SourceGraphic::determineAbsolutePaintRect):
(WebCore::SourceGraphic::apply):

  • platform/graphics/filters/SourceGraphic.h:

(WebCore::SourceGraphic::SourceGraphic):

  • rendering/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::buildPrimitives):
(WebCore::RenderSVGResourceFilter::applyResource):
(WebCore::RenderSVGResourceFilter::postApplyResource):

  • rendering/RenderSVGResourceFilter.h:
  • rendering/SVGRenderTreeAsText.cpp:

(WebCore::writeSVGResourceContainer):

  • svg/SVGFEBlendElement.cpp:

(WebCore::SVGFEBlendElement::build):

  • svg/SVGFEBlendElement.h:
  • svg/SVGFEColorMatrixElement.cpp:

(WebCore::SVGFEColorMatrixElement::build):

  • svg/SVGFEColorMatrixElement.h:
  • svg/SVGFEComponentTransferElement.cpp:

(WebCore::SVGFEComponentTransferElement::build):

  • svg/SVGFEComponentTransferElement.h:
  • svg/SVGFECompositeElement.cpp:

(WebCore::SVGFECompositeElement::build):

  • svg/SVGFECompositeElement.h:
  • svg/SVGFEConvolveMatrixElement.cpp:

(WebCore::SVGFEConvolveMatrixElement::build):

  • svg/SVGFEConvolveMatrixElement.h:
  • svg/SVGFEDiffuseLightingElement.cpp:

(WebCore::SVGFEDiffuseLightingElement::build):

  • svg/SVGFEDiffuseLightingElement.h:
  • svg/SVGFEDisplacementMapElement.cpp:

(WebCore::SVGFEDisplacementMapElement::build):

  • svg/SVGFEDisplacementMapElement.h:
  • svg/SVGFEFloodElement.cpp:

(WebCore::SVGFEFloodElement::build):

  • svg/SVGFEFloodElement.h:
  • svg/SVGFEGaussianBlurElement.cpp:

(WebCore::SVGFEGaussianBlurElement::build):

  • svg/SVGFEGaussianBlurElement.h:
  • svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::build):

  • svg/SVGFEImageElement.h:
  • svg/SVGFEMergeElement.cpp:

(WebCore::SVGFEMergeElement::build):

  • svg/SVGFEMergeElement.h:
  • svg/SVGFEMorphologyElement.cpp:

(WebCore::SVGFEMorphologyElement::build):

  • svg/SVGFEMorphologyElement.h:
  • svg/SVGFEOffsetElement.cpp:

(WebCore::SVGFEOffsetElement::build):

  • svg/SVGFEOffsetElement.h:
  • svg/SVGFESpecularLightingElement.cpp:

(WebCore::SVGFESpecularLightingElement::build):

  • svg/SVGFESpecularLightingElement.h:
  • svg/SVGFETileElement.cpp:

(WebCore::SVGFETileElement::build):

  • svg/SVGFETileElement.h:
  • svg/SVGFETurbulenceElement.cpp:

(WebCore::SVGFETurbulenceElement::build):

  • svg/SVGFETurbulenceElement.h:
  • svg/SVGFilterPrimitiveStandardAttributes.h:
  • svg/graphics/filters/SVGFEImage.cpp:

(WebCore::FEImage::FEImage):
(WebCore::FEImage::create):
(WebCore::FEImage::determineAbsolutePaintRect):
(WebCore::FEImage::apply):

  • svg/graphics/filters/SVGFEImage.h:
  • svg/graphics/filters/SVGFilterBuilder.cpp:

(WebCore::SVGFilterBuilder::SVGFilterBuilder):

  • svg/graphics/filters/SVGFilterBuilder.h:

(WebCore::SVGFilterBuilder::create):

2:25 AM Changeset in webkit [72473] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-11-20 Helder Correia <​helder@sencha.com>

Reviewed by Andreas Kling.

[Qt] GraphicsContext::strokeArc() is not necessary any more
​https://bugs.webkit.org/show_bug.cgi?id=49859

Remove strokeArc() from the Qt port.

No test is needed.

  • platform/graphics/qt/GraphicsContextQt.cpp:
2:09 AM Changeset in webkit [72472] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

2010-11-20 Helder Correia <​helder@sencha.com>

Reviewed by Andreas Kling.

[Qt] Path fill lacks blur shadow support
​https://bugs.webkit.org/show_bug.cgi?id=49491

Add new test for checking path fill blur shadow.

  • fast/canvas/canvas-fillPath-shadow-expected.txt: Added.
  • fast/canvas/canvas-fillPath-shadow.html: Added.
  • fast/canvas/script-tests/canvas-fillPath-shadow.js: Added.

2010-11-20 Helder Correia <​helder@sencha.com>

Reviewed by Andreas Kling.

[Qt] Path fill lacks blur shadow support
​https://bugs.webkit.org/show_bug.cgi?id=49491

Add blur shadow support to fillPath().

Test: fast/canvas/canvas-fillPath-shadow.html

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillPath):
12:15 AM Changeset in webkit [72471] by andreas.kling@nokia.com
  • 3 edits in trunk/WebKit/qt

2010-11-19 Kristian Amlie <​kristian.amlie@nokia.com>

Reviewed by Andreas Kling.

Fixed handling of QInputMethodEvents with nonzero replacementLength.

These types of events replace text that is already in the widget, but
WebKit did not check for replacementLength at all.

Also made sure that the preeditString is always respected, even if
there is committed text. This is how QLineEdit does it.

​https://bugs.webkit.org/show_bug.cgi?id=49787

  • Api/qwebpage.cpp: (QWebPagePrivate::inputMethodEvent):
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods):
Note: See TracTimeline for information about the timeline view.