Timeline

Nov 22, 2010:

11:44 PM Changeset in webkit [72587] by commit-queue@webkit.org

• 8 edits in trunk/WebKit/chromium

2010-11-22 Alexey Marinichev <​amarinichev@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Implement Extensions3DChromium::getGraphicsResetStatusARB
​https://bugs.webkit.org/show_bug.cgi?id=49946

• public/WebGraphicsContext3D.h: added isContextLost()
• src/Extensions3DChromium.cpp: (WebCore::Extensions3DChromium::getGraphicsResetStatusARB):
• src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DInternal::isContextLost):
• src/GraphicsContext3DInternal.h:
• src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::isContextLost):
• src/WebGraphicsContext3DDefaultImpl.h:
• src/WebViewImpl.cpp: (WebKit::WebViewImpl::reallocateRenderer): ensure root layer repaining

10:46 PM Changeset in webkit [72586] by jcivelli@chromium.org

• 2 edits in trunk/WebKit/chromium

2010-11-22 Jay Civelli <​jcivelli@chromium.org>

Reviewed by David Levin.

Don't create an external popup menu when there are no items to show.
​https://bugs.webkit.org/show_bug.cgi?id=49937

• src/ExternalPopupMenu.cpp: (WebKit::ExternalPopupMenu::show):

10:26 PM Changeset in webkit [72585] by Patrick Gansterer

• 3 edits in trunk/WebCore

2010-11-22 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

Port ContextMenuWin.cpp to WinCE
​https://bugs.webkit.org/show_bug.cgi?id=48408

• platform/ContextMenu.h:
• platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::ContextMenu): (WebCore::ContextMenu::itemCount): (WebCore::insertMenuItem): (WebCore::ContextMenu::insertItem): (WebCore::contextMenuItemByIdOrPosition): (WebCore::ContextMenu::setPlatformDescription): (WebCore::contextMenuItemVector): (WebCore::platformMenuDescription):

10:05 PM Changeset in webkit [72584] by commit-queue@webkit.org

• 2 edits in trunk/WebKit/chromium

2010-11-22 Nat Duca <​nduca@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Send didActivateAcceleratedCompositing when compositor
initializes but does not create the shared context3d.
​https://bugs.webkit.org/show_bug.cgi?id=49930

• src/WebViewImpl.cpp: (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

9:44 PM Changeset in webkit [72583] by hyatt@apple.com

• 3 edits in trunk/LayoutTests

Back out rebaselines from r72527.

• platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
• platform/mac/fast/lists/marker-before-empty-inline-expected.txt:

9:41 PM Changeset in webkit [72582] by hyatt@apple.com

• 67 edits
  4 deletes in trunk

Back out r72527 since it caused multiple rendering regressions. Details in bug.

WebCore:

• rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesInInlineDirection):

• rendering/RenderListItem.cpp:

(WebCore::RenderListItem::positionListMarker):

LayoutTests:

• fast/lists/outSideListMarkers-expected.txt: Removed.
• fast/lists/outSideListMarkers.html: Removed.
• platform/mac-leopard/css1/box_properties/margin_right-expected.checksum:
• platform/mac-leopard/css1/box_properties/margin_right-expected.png:
• platform/mac-leopard/css1/box_properties/padding_right-expected.checksum:
• platform/mac-leopard/css1/box_properties/padding_right-expected.png:
• platform/mac-leopard/editing/pasteboard/merge-end-list-expected.checksum:
• platform/mac-leopard/editing/pasteboard/merge-end-list-expected.png:
• platform/mac-leopard/fast/css/background-shorthand-invalid-url-expected.checksum:
• platform/mac-leopard/fast/css/background-shorthand-invalid-url-expected.png:
• platform/mac-leopard/fast/css/empty-pseudo-class-expected.checksum:
• platform/mac-leopard/fast/css/empty-pseudo-class-expected.png:
• platform/mac-leopard/fast/css/first-child-pseudo-class-expected.checksum:
• platform/mac-leopard/fast/css/first-child-pseudo-class-expected.png:
• platform/mac-leopard/fast/css/first-of-type-pseudo-class-expected.checksum:
• platform/mac-leopard/fast/css/first-of-type-pseudo-class-expected.png:
• platform/mac-leopard/fast/css/last-child-pseudo-class-expected.checksum:
• platform/mac-leopard/fast/css/last-child-pseudo-class-expected.png:
• platform/mac-leopard/fast/css/last-of-type-pseudo-class-expected.checksum:
• platform/mac-leopard/fast/css/last-of-type-pseudo-class-expected.png:
• platform/mac-leopard/fast/css/only-child-pseudo-class-expected.checksum:
• platform/mac-leopard/fast/css/only-child-pseudo-class-expected.png:
• platform/mac-leopard/fast/css/only-of-type-pseudo-class-expected.checksum:
• platform/mac-leopard/fast/css/only-of-type-pseudo-class-expected.png:
• platform/mac-leopard/fast/doctypes/002-expected.checksum:
• platform/mac-leopard/fast/doctypes/002-expected.png:
• platform/mac-leopard/fast/lists/001-expected.checksum:
• platform/mac-leopard/fast/lists/001-expected.png:
• platform/mac-leopard/fast/lists/002-expected.checksum:
• platform/mac-leopard/fast/lists/002-expected.png:
• platform/mac-leopard/fast/lists/003-expected.checksum:
• platform/mac-leopard/fast/lists/003-expected.png:
• platform/mac/css1/box_properties/margin_right-expected.txt:
• platform/mac/css1/box_properties/padding_right-expected.txt:
• platform/mac/editing/pasteboard/merge-end-list-expected.txt:
• platform/mac/editing/selection/extend-by-word-002-expected.checksum:
• platform/mac/editing/selection/extend-by-word-002-expected.png:
• platform/mac/editing/selection/extend-by-word-002-expected.txt:
• platform/mac/fast/css/background-shorthand-invalid-url-expected.txt:
• platform/mac/fast/css/empty-pseudo-class-expected.txt:
• platform/mac/fast/css/first-child-pseudo-class-expected.txt:
• platform/mac/fast/css/first-of-type-pseudo-class-expected.txt:
• platform/mac/fast/css/last-child-pseudo-class-expected.txt:
• platform/mac/fast/css/last-of-type-pseudo-class-expected.txt:
• platform/mac/fast/css/only-child-pseudo-class-expected.txt:
• platform/mac/fast/css/only-of-type-pseudo-class-expected.txt:
• platform/mac/fast/doctypes/002-expected.txt:
• platform/mac/fast/lists/001-expected.txt:
• platform/mac/fast/lists/001-vertical-expected.checksum:
• platform/mac/fast/lists/001-vertical-expected.png:
• platform/mac/fast/lists/001-vertical-expected.txt:
• platform/mac/fast/lists/002-expected.txt:
• platform/mac/fast/lists/002-vertical-expected.checksum:
• platform/mac/fast/lists/002-vertical-expected.png:
• platform/mac/fast/lists/002-vertical-expected.txt:
• platform/mac/fast/lists/003-expected.txt:
• platform/mac/fast/lists/003-vertical-expected.checksum:
• platform/mac/fast/lists/003-vertical-expected.png:
• platform/mac/fast/lists/003-vertical-expected.txt:
• platform/mac/fast/lists/007-vertical-expected.checksum:
• platform/mac/fast/lists/007-vertical-expected.png:
• platform/mac/fast/lists/007-vertical-expected.txt:
• platform/mac/fast/lists/008-vertical-expected.checksum:
• platform/mac/fast/lists/008-vertical-expected.png:
• platform/mac/fast/lists/008-vertical-expected.txt:
• platform/mac/fast/lists/outSideListMarkers-expected.checksum: Removed.
• platform/mac/fast/lists/outSideListMarkers-expected.png: Removed.

8:43 PM Changeset in webkit [72581] by commit-queue@webkit.org

• 8 edits
  2 adds in trunk/WebCore

2010-11-22 John Knottenbelt <​jknotten@chromium.org>

Reviewed by Steve Block.

Implement mocks for client-based Geolocation.
​https://bugs.webkit.org/show_bug.cgi?id=49258

• Android.mk:
• CMakeLists.txt:
• GNUmakefile.am:
• WebCore.gypi:
• WebCore.pro:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.xcodeproj/project.pbxproj:
• platform/mock/GeolocationClientMock.cpp: Added. (WebCore::GeolocationClientMock::GeolocationClientMock): (WebCore::GeolocationClientMock::~GeolocationClientMock): (WebCore::GeolocationClientMock::setController): (WebCore::GeolocationClientMock::setPosition): (WebCore::GeolocationClientMock::setError): (WebCore::GeolocationClientMock::geolocationDestroyed): (WebCore::GeolocationClientMock::startUpdating): (WebCore::GeolocationClientMock::stopUpdating): (WebCore::GeolocationClientMock::setEnableHighAccuracy): (WebCore::GeolocationClientMock::lastPosition): (WebCore::GeolocationClientMock::timerFired): (WebCore::GeolocationClientMock::makeGeolocationCallback):
• platform/mock/GeolocationClientMock.h: Added.

8:10 PM Changeset in webkit [72580] by commit-queue@webkit.org

• 2 edits in trunk/PlanetWebKit

2010-11-22 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Andreas Kling.

Add Leandro Pereira's blog to Planet WebKit
​https://bugs.webkit.org/show_bug.cgi?id=49910

• config.ini:

6:35 PM Changeset in webkit [72579] by commit-queue@webkit.org

• 4 edits
  8 adds in trunk/WebKit/efl

2010-11-22 Alex Grilo <​abgrilo@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Tiled Backing Store for Webkit-Efl
​https://bugs.webkit.org/show_bug.cgi?id=45397

This tile based backing store is a grid of tiles where each tile is
an Evas_Object showing a piece of the page content. The
new ewk_view_tiled.c is an implementation of some of the functions of
the original ewk_view, that makes calls to the Tiled Backing Store
specific functions.

The rendering occurs in the pixels stored in each tile (Evas_Object),
in the same way as the previous single backing store. Tiles not being
shown in the viewport are stored in a cache, and can be reused later
to avoid having to be rendered again.

Scrolling occurs as just moving the tiles, using Evas move operations,
and when more than one tile size is scrolled, a shift of rows or
columns needs to be done.

• CMakeListsEfl.txt:
• ewk/ewk_tiled_backing_store.c: Added. (_ewk_tiled_backing_store_updates_process): (_ewk_tiled_backing_store_flush): (_ewk_tiled_backing_store_tile_new): (_ewk_tiled_backing_store_item_move): (_ewk_tiled_backing_store_item_resize): (_ewk_tiled_backing_store_tile_associate): (_ewk_tiled_backing_store_tile_dissociate): (_ewk_tiled_backing_store_tile_dissociate_all): (_ewk_tiled_backing_store_pre_render_request_add): (_ewk_tiled_backing_store_pre_render_request_del): (_ewk_tiled_backing_store_pre_render_request_first): (_ewk_tiled_backing_store_pre_render_request_flush): (_ewk_tiled_backing_store_pre_render_request_remove_unassociated): (_ewk_tiled_backing_store_pre_render_request_remove_associated): (_ewk_tiled_backing_store_pre_render_request_process_single): (_ewk_tiled_backing_store_item_process_idler_cb): (_ewk_tiled_backing_store_item_process_idler_stop): (_ewk_tiled_backing_store_item_process_idler_start): (_ewk_tiled_backing_store_item_request_del): (_ewk_tiled_backing_store_item_request_add): (_ewk_tiled_backing_store_disable_render): (_ewk_tiled_backing_store_enable_render): (_ewk_tiled_backing_store_visible_tiles_rect): (_ewk_tiled_backing_store_tile_is_inside_viewport): (_ewk_tiled_backing_store_tile_is_adjacent_to_viewport): (_ewk_tiled_backing_store_item_fill): (_ewk_tiled_backing_store_item_add): (_ewk_tiled_backing_store_item_del): (_ewk_tiled_backing_store_item_smooth_scale_set): (_ewk_tiled_backing_store_changed): (_ewk_tiled_backing_store_view_cols_end_del): (_ewk_tiled_backing_store_view_cols_end_add): (_ewk_tiled_backing_store_view_row_del): (_ewk_tiled_backing_store_view_rows_range_del): (_ewk_tiled_backing_store_view_rows_all_del): (_ewk_tiled_backing_store_render): (_ewk_tiled_backing_store_model_matrix_create): (_ewk_tiled_backing_store_smart_member_del): (_ewk_tiled_backing_store_smart_member_add): (_ewk_tiled_backing_store_mem_dbg): (_ewk_tiled_backing_store_sig_usr): (_ewk_tiled_backing_store_smart_add): (_ewk_tiled_backing_store_smart_del): (_ewk_tiled_backing_store_smart_move): (_ewk_tiled_backing_store_smart_resize): (_ewk_tiled_backing_store_recalc_renderers): (_ewk_tiled_backing_store_smart_calculate_size): (_ewk_tiled_backing_store_view_dbg): (_ewk_tiled_backing_store_view_wrap_up): (_ewk_tiled_backing_store_view_wrap_down): (_ewk_tiled_backing_store_view_wrap_left): (_ewk_tiled_backing_store_view_wrap_right): (_ewk_tiled_backing_store_view_refill): (_ewk_tiled_backing_store_view_pos_apply): (_ewk_tiled_backing_store_smart_calculate_offset_force): (_ewk_tiled_backing_store_smart_calculate_offset): (_ewk_tiled_backing_store_smart_calculate_pos): (_ewk_tiled_backing_store_fill_renderers): (_ewk_tiled_backing_store_smart_calculate): (ewk_tiled_backing_store_add): (ewk_tiled_backing_store_render_cb_set): (ewk_tiled_backing_store_tile_unused_cache_get): (ewk_tiled_backing_store_tile_unused_cache_set): (_ewk_tiled_backing_store_scroll_full_offset_set_internal): (ewk_tiled_backing_store_scroll_full_offset_set): (ewk_tiled_backing_store_scroll_full_offset_add): (_ewk_tiled_backing_store_zoom_set_internal): (ewk_tiled_backing_store_zoom_set): (ewk_tiled_backing_store_zoom_weak_set): (ewk_tiled_backing_store_fix_offsets): (ewk_tiled_backing_store_zoom_weak_smooth_scale_set): (ewk_tiled_backing_store_update): (ewk_tiled_backing_store_updates_process_pre_set): (ewk_tiled_backing_store_updates_process_post_set): (ewk_tiled_backing_store_updates_process): (ewk_tiled_backing_store_updates_clear): (ewk_tiled_backing_store_contents_resize): (ewk_tiled_backing_store_disabled_update_set): (ewk_tiled_backing_store_flush): (ewk_tiled_backing_store_pre_render_region): (ewk_tiled_backing_store_pre_render_relative_radius): (ewk_tiled_backing_store_pre_render_cancel): (ewk_tiled_backing_store_disable_render): (ewk_tiled_backing_store_enable_render): (ewk_tiled_backing_store_process_entire_queue_set):
• ewk/ewk_tiled_backing_store.h: Added.
• ewk/ewk_tiled_matrix.c: Added. (_ewk_tile_matrix_cell_free): (_ewk_tile_matrix_tile_free): (ewk_tile_matrix_new): (ewk_tile_matrix_free): (ewk_tile_matrix_resize): (ewk_tile_matrix_unused_cache_get): (ewk_tile_matrix_tile_exact_get): (ewk_tile_matrix_tile_exact_exists): (ewk_tile_matrix_tile_nearest_get): (ewk_tile_matrix_tile_new): (ewk_tile_matrix_tile_put): (ewk_tile_matrix_tile_update): (ewk_tile_matrix_tile_update_full): (ewk_tile_matrix_tile_updates_clear): (_ewk_tile_matrix_slicer_setup): (ewk_tile_matrix_update): (ewk_tile_matrix_updates_process): (ewk_tile_matrix_updates_clear): (ewk_tile_matrix_dbg): (ewk_tile_matrix_freeze): (ewk_tile_matrix_thaw):
• ewk/ewk_tiled_matrix.h: Added.
• ewk/ewk_tiled_model.c: Added. (_ewk_tile_account_get): (_ewk_tile_account_allocated): (_ewk_tile_account_freed): (ewk_tile_accounting_dbg): (_ewk_tile_paint_rgb888): (_ewk_tile_paint_rgb565): (_ewk_tile_paint): (ewk_tile_new): (ewk_tile_free): (ewk_tile_show): (ewk_tile_hide): (ewk_tile_visible_get): (ewk_tile_update_full): (ewk_tile_update_area): (ewk_tile_updates_process): (ewk_tile_updates_clear): (ewk_tile_unused_cache_new): (ewk_tile_unused_cache_lock_area): (ewk_tile_unused_cache_unlock_area): (ewk_tile_unused_cache_free): (ewk_tile_unused_cache_clear): (ewk_tile_unused_cache_ref): (ewk_tile_unused_cache_unref): (ewk_tile_unused_cache_max_set): (ewk_tile_unused_cache_max_get): (ewk_tile_unused_cache_used_get): (ewk_tile_unused_cache_flush): (ewk_tile_unused_cache_auto_flush): (ewk_tile_unused_cache_dirty): (ewk_tile_unused_cache_freeze): (ewk_tile_unused_cache_thaw): (ewk_tile_unused_cache_tile_get): (ewk_tile_unused_cache_tile_put): (ewk_tile_unused_cache_dbg):
• ewk/ewk_tiled_model.h: Added.
• ewk/ewk_tiled_private.h: Added.
• ewk/ewk_view.cpp: (_ewk_view_smart_add): (_ewk_view_smart_calculate): (_ewk_view_smart_show): (_ewk_view_smart_hide): (_ewk_view_smart_pre_render_relative_radius): (_ewk_view_zoom_animator_cb): (_ewk_view_smart_disable_render): (_ewk_view_smart_enable_render): (ewk_view_base_smart_set): (ewk_view_pre_render_region): (ewk_view_pre_render_relative_radius): (ewk_view_enable_render): (ewk_view_disable_render): (ewk_view_scroll): (ewk_view_did_first_visually_nonempty_layout): (ewk_view_dispatch_did_finish_loading): (ewk_view_transition_to_commited_for_newpage):
• ewk/ewk_view.h:
• ewk/ewk_view_tiled.c: Added. (_ewk_view_tiled_render_cb): (_ewk_view_tiled_updates_process_pre): (_ewk_view_tiled_smart_backing_store_add): (_ewk_view_tiled_contents_size_changed_cb): (_ewk_view_tiled_smart_add): (_ewk_view_tiled_smart_scrolls_process): (_ewk_view_tiled_smart_repaints_process): (_ewk_view_tiled_smart_contents_resize): (_ewk_view_tiled_smart_zoom_set): (_ewk_view_tiled_smart_zoom_weak_set): (_ewk_view_tiled_smart_zoom_weak_smooth_scale_set): (_ewk_view_tiled_smart_flush): (_ewk_view_tiled_smart_pre_render_region): (_ewk_view_tiled_smart_pre_render_relative_radius): (_ewk_view_tiled_smart_pre_render_cancel): (_ewk_view_tiled_smart_disable_render): (_ewk_view_tiled_smart_enable_render): (ewk_view_tiled_smart_set): (_ewk_view_tiled_smart_class_new): (ewk_view_tiled_add): (ewk_view_tiled_unused_cache_get): (ewk_view_tiled_unused_cache_set): (ewk_view_tiled_process_entire_queue_set):

5:50 PM Changeset in webkit [72578] by tonyg@chromium.org

• 2 edits in trunk/WebCore

2010-11-22 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Adam Barth.

Fix bogus include guard.

• loader/NavigationScheduler.h:

5:47 PM Changeset in webkit [72577] by andreas.kling@nokia.com

• 3 edits
  3 adds in trunk

2010-11-22 Andreas Kling <​kling@webkit.org>

Reviewed by Ariya Hidayat.

[Qt] Canvas: strokeText() and fillText() produce same shadow
​https://bugs.webkit.org/show_bug.cgi?id=48845

Test: fast/canvas/canvas-strokeText-strokes-shadow.html

• platform/graphics/qt/FontQt.cpp: (WebCore::drawTextCommon): Stroke the shadow rather than filling it in the cTextStroke case.

2010-11-22 Andreas Kling <​kling@webkit.org>

Reviewed by Ariya Hidayat.

[Qt] Canvas: strokeText() and fillText() produce same shadow
​https://bugs.webkit.org/show_bug.cgi?id=48845

Add test to verify that strokeText() doesn't produce a fillText() shadow.

• fast/canvas/canvas-strokeText-strokes-shadow.html: Added.
• fast/canvas/canvas-strokeText-strokes-shadow-expected.txt: Added.
• fast/canvas/script-tests/canvas-strokeText-strokes-shadow.js: Added.

4:56 PM Changeset in webkit [72576] by dpranke@chromium.org

• 2 edits in trunk/WebKitTools

2010-11-22 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Tony Chang.

Fix some spacing issues with log messages with
new-run-webkit-tests --verbose.

​https://bugs.webkit.org/show_bug.cgi?id=49936

• Scripts/webkitpy/layout_tests/layout_package/printing.py:

4:56 PM Changeset in webkit [72575] by ojan@chromium.org

• 3 edits in trunk/WebKitTools

2010-11-22 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

update scm to work with different remote branches
​https://bugs.webkit.org/show_bug.cgi?id=49949

This works if there are multiple svn tracking branches
and/or if the tracking branch is refs/remots/origin/master
instead of refs/remotes/trunk which is the direction we're trying
to head since that makes fetches faster.

• Scripts/webkitpy/common/checkout/scm.py:
• Scripts/webkitpy/common/checkout/scm_unittest.py:

4:55 PM Changeset in webkit [72574] by Patrick Gansterer

• 4 edits in trunk

2010-11-22 Patrick Gansterer <Patrick Gansterer>

Reviewed by Sam Weinig.

Add WTF::FixedArray::size()
​https://bugs.webkit.org/show_bug.cgi?id=49891

Add a method to get the size of a FixedArray.

• wtf/FixedArray.h: (WTF::FixedArray::size):

2010-11-22 Patrick Gansterer <Patrick Gansterer>

Reviewed by Sam Weinig.

Use WTF::FixedArray::size()
​https://bugs.webkit.org/show_bug.cgi?id=49891

• dom/Document.cpp: (WebCore::Document::~Document):

4:25 PM Changeset in webkit [72573] by rniwa@webkit.org

• 10 edits in trunk

2010-11-22 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

SelectionController::typingStyle() should return EditingStyle*
​https://bugs.webkit.org/show_bug.cgi?id=49813

Changed the return value of SelectionController::typingStyle() to EditingStyle*.
Also added SelectionController::copyTypingStyle() to copy the typing style
as an instance of CSSMutableStyleDeclaration.

No tests are added since this is no behavioral change.

• WebView/WebFrame.mm: (-[WebFrame _typingStyle]): Calls SelectionController::copyTypingStyle()

2010-11-22 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

SelectionController::typingStyle() should return EditingStyle*
​https://bugs.webkit.org/show_bug.cgi?id=49813

Changed the return type of SelectionController::typingStyle to EditingStyle*.

Extracted textDirection from Editor::textDirectionForSelection to hide the underlying
CSSMutableStyleDeclaration.

Also extracted the code to preserve unicode-bidi and direction CSS properties in
InsertTextCommand::input, and moved into EditingStyle::prepareToApplyAt. ShouldPreserveWritingDirection,
which is added to the argument list of EditingStyle::prepareToApplyAt, decides whether or not
these two properties are preserved.

Also added SelectionController::copyTypingStyle() to copy the typing style as an instance of
CSSMutableStyleDeclaration.

No new tests are added since this is a refactoring.

• editing/EditingStyle.cpp: (WebCore::EditingStyle::textDirection): Extracted from Editor::textDirectionForSelection. (WebCore::EditingStyle::removeStyleConflictingWithStyleOfNode): Added a missing null check. (WebCore::EditingStyle::prepareToApplyAt): See above. (WebCore::editingStyleIncludingTypingStyle): Calls SelectionController::typingStyle.
• editing/EditingStyle.h: Moved WritingDirection from Editor.h
• editing/Editor.cpp: (WebCore::Editor::textDirectionForSelection): Calls EditingStyle::textDirection. (WebCore::Editor::computeAndSetTypingStyle): Calls SelectionController::typingStyle. (WebCore::Editor::selectionComputedStyle): Ditto. (WebCore::Editor::styleForSelectionStart): Ditto.
• editing/Editor.h:
• editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply): Ditto.
• editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input): Calls EditingStyle::prepareToApplyAt with PreserveWritingDirection.
• editing/SelectionController.h: (WebCore::SelectionController::typingStyle): Returns EditingStyle* rather than CSSMutableStyleDeclaration*. (WebCore::SelectionController::copyTypingStyle): Added.

4:18 PM Changeset in webkit [72572] by Patrick Gansterer

• 4 edits in trunk

2010-11-22 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

[WINCE] Set correct preprocessor definitions
​https://bugs.webkit.org/show_bug.cgi?id=49887

• wtf/Platform.h:

2010-11-22 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

[WINCE] Set correct preprocessor definitions
​https://bugs.webkit.org/show_bug.cgi?id=49887

• config.h:

3:57 PM Changeset in webkit [72571] by Adam Roben

• 5 edits
  2 adds in trunk/LayoutTests

Update Windows 7 results for two tests

Windows 7 uses different fonts from Windows XP on these tests (and even
has a font that can render the inverted nun in bidi-mirror-he-ar.html).

• platform/win/fast/text/international/bidi-mirror-he-ar-expected.checksum:
• platform/win/fast/text/international/bidi-mirror-he-ar-expected.png:
• platform/win/fast/text/international/bidi-mirror-he-ar-expected.txt:
• platform/win/fast/text/international/bold-bengali-expected.checksum: Added.
• platform/win/fast/text/international/bold-bengali-expected.png: Added.
• platform/win/fast/text/international/bold-bengali-expected.txt:

3:38 PM Changeset in webkit [72570] by Adam Roben

• 2 edits
  2 adds in trunk/LayoutTests

Update Windows 7 results for fast/text/international/complex-character-based-fallback.html

• platform/win/fast/text/international/complex-character-based-fallback-expected.checksum: Added.
• platform/win/fast/text/international/complex-character-based-fallback-expected.png: Added.
• platform/win/fast/text/international/complex-character-based-fallback-expected.txt:

3:27 PM Changeset in webkit [72569] by Adam Roben

• 2 edits
  2 adds
  2 deletes in trunk/LayoutTests

Update Windows XP results for fast/text/international/complex-character-based-fallback.html after r72173

The existing pixel results were XP-specific so I moved them into
LayoutTests/platform/win-xp.

• platform/win-xp/fast/text/international/complex-character-based-fallback-expected.checksum: Added.
• platform/win-xp/fast/text/international/complex-character-based-fallback-expected.png: Added.
• platform/win-xp/fast/text/international/complex-character-based-fallback-expected.txt:
• platform/win/fast/text/international/complex-character-based-fallback-expected.checksum: Removed.
• platform/win/fast/text/international/complex-character-based-fallback-expected.png: Removed.

3:21 PM Changeset in webkit [72568] by Adam Roben

• 3 edits in trunk/LayoutTests

Update Windows results after r72552

• platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
• platform/win/fast/dom/prototype-inheritance-expected.txt:

3:04 PM Changeset in webkit [72567] by jamesr@google.com

• 7 edits in trunk

2010-11-22 James Robinson <​jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] font-size:0 text runs should have zero width
​https://bugs.webkit.org/show_bug.cgi?id=49871

Expands test to check width in addition to height.

• fast/text/font-size-zero-expected.txt:
• fast/text/font-size-zero.html:
• fast/text/script-tests/font-size-zero.js:

2010-11-22 James Robinson <​jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] font-size:0 text runs should have zero width
​https://bugs.webkit.org/show_bug.cgi?id=49871

Returns 0 from platformWidthForGlyph if the specified font size is 0.

Test: fast/text/font-size-zero.html

• platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: (WebCore::SimpleFontData::platformWidthForGlyph):
• platform/graphics/chromium/SimpleFontDataLinux.cpp: (WebCore::SimpleFontData::platformWidthForGlyph):

3:01 PM Changeset in webkit [72566] by commit-queue@webkit.org

• 4 edits
  3 adds in trunk

2010-11-22 Charlie Reis <​creis@chromium.org>

Reviewed by Darin Fisher.

Update correct content state during back/forward navigations
​https://bugs.webkit.org/show_bug.cgi?id=48809

Test that we update content state when leaving a form in a subframe.

• fast/history/saves-state-after-frame-nav.html:
• fast/history/saves-state-after-frame-nav-expected.txt:
• fast/history/resources/subframe-with-form.html:

2010-11-22 Charlie Reis <​creis@chromium.org>

Reviewed by Darin Fisher.

Update correct content state during back/forward navigations
​https://bugs.webkit.org/show_bug.cgi?id=48809

Ensures that history's previousItem is non-null when clients try to
update content state (e.g., Chromium's UpdateSessionHistory). We now
track load completions with a boolean field rather than by clearing
previousItem.

Test: fast/history/saves-state-after-frame-nav.html

• loader/HistoryController.cpp:
• loader/HistoryController.h:

2:59 PM Changeset in webkit [72565] by jparent@chromium.org

• 2 edits in trunk/LayoutTests

Unreviewed. Add flaky crash expectation for fast/files/revoke-blob-url.html on mac debug.

• platform/chromium/test_expectations.txt:

2:52 PM Changeset in webkit [72564] by hayato@chromium.org

• 3 edits in trunk/WebKitTools

2010-11-22 Hayato Ito <​hayato@chromium.org>

Reviewed by Shinichiro Hamaji.

Ignore reference files which will be used by reftests when collecting
test cases.
​https://bugs.webkit.org/show_bug.cgi?id=49835

• Scripts/webkitpy/layout_tests/port/test_files.py:
• Scripts/webkitpy/layout_tests/port/test_files_unittest.py:

2:45 PM Changeset in webkit [72563] by Adam Roben

• 5 edits
  2 adds in trunk/LayoutTests

Update Windows results for transforms/2d/hindi-rotated.html after r72173

The existing pixel results were XP-specific so I moved them to
LayoutTests/platform/win-xp.

• platform/win-xp/transforms/2d/hindi-rotated-expected.checksum: Added.
• platform/win-xp/transforms/2d/hindi-rotated-expected.png: Added.
• platform/win-xp/transforms/2d/hindi-rotated-expected.txt:
• platform/win/transforms/2d/hindi-rotated-expected.checksum:
• platform/win/transforms/2d/hindi-rotated-expected.png:
• platform/win/transforms/2d/hindi-rotated-expected.txt:

2:40 PM Changeset in webkit [72562] by rniwa@webkit.org

• 2 edits
  1 delete in trunk/LayoutTests

2010-11-22 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed rebaseline for Chromium.

Removed the erroneous expected result for editing/deleting/5168598.html on chromium linux.

• platform/chromium-linux/editing/deleting/5168598-expected.txt: Removed.
• platform/chromium/test_expectations.txt: Removed editing/deleting/5168598.html.

2:33 PM QtWebKitFeatures21 edited by Ademar Reis

adding (partial) list of fixes (diff)

2:24 PM Changeset in webkit [72561] by Csaba Osztrogonác

• 5 edits in trunk/LayoutTests

Unreviewed. Update GTK and Mac specific expected results after r72552.

• fast/dom/Window/window-properties-expected.txt:
• fast/dom/prototype-inheritance-expected.txt:
• platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
• platform/gtk/fast/dom/prototype-inheritance-expected.txt:

2:15 PM Changeset in webkit [72560] by tony@chromium.org

• 2 edits in trunk/WebKit/chromium

2010-11-22 Tony Chang <​tony@chromium.org>

Unreviewed, roll Chromium DEPS to r67004.

• DEPS:

2:05 PM Changeset in webkit [72559] by weinig@apple.com

• 2 edits in trunk/LayoutTests

Update WebKit2 skipped list.

• platform/mac-wk2/Skipped:

2:01 PM Changeset in webkit [72558] by jamesr@google.com

• 3 edits in branches/chromium/552/WebCore

Revert code changes of WebKit r67261 on the 552 branch BUG=56150 TBR=pkasting

2:01 PM Changeset in webkit [72557] by luiz@webkit.org

• 2 edits in trunk/WebCore

2010-11-22 Luiz Agostini <​luiz.agostini@openbossa.org>

Unreviewed, Windows build fix.

Adding JSMediaQueryList to DerivedSources.cpp.

• DerivedSources.cpp:

1:53 PM Changeset in webkit [72556] by Csaba Osztrogonác

• 4 edits in trunk/LayoutTests

Unreviewed. Update Qt specific expected results after r72552.

• platform/qt/fast/dom/Window/window-properties-expected.txt:
• platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
• platform/qt/fast/dom/prototype-inheritance-expected.txt:

1:38 PM QtWebKitContrib edited by Ademar Reis

(diff)

1:21 PM Changeset in webkit [72555] by Adam Roben

• 36 edits in trunk

Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files

Apple's Windows build allows placing header files and import libraries for WebKit's
dependencies (CoreGraphics, CFNetwork, SQLite, etc.) outside the source tree via the
$WebKitLibrariesDir environment variable. This is both required for production builds and
convenient for Apple-internal developer builds. Apple's production builds also require that
WebKit's shared .vsprops files be accessed relative to $WebKitLibrariesDir. In production
builds, the files are copied into that directory tree by the
WebKitLibraries/win/tools/WinTools.make file. In Apple-internal developer builds, the
copying is done by
JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make.

This .vsprops copying is problematic in one very important case: when a developer updates
their source tree and then tries to build. Visual Studio only reads .vsprops files when a
project is first loaded. So, when Visual Studio is first opened after the .vsprops files are
updated, it reads in the old files that were already residing in $WebKitLibrariesDir. When a
build is started, JavaScriptCoreGenerated.make copies the new .vsprops files into
$WebKitLibrariesDir, but Visual Studio will not pick up the changes. The rest of the build
will proceed with out-of-date .vsprops files, which will likely result in a build failure.

To fix this, we now use normal relative paths to access the .vsprops files in the source
tree rather than in $WebKitLibrariesDir, but prefix those paths with a new environment
variable, $WebKitVSPropsRedirectionDir. In developer builds, this environment variable is
unset, so the normal relative paths are used to read the .vsprops files out of the source
tree directly. In production builds, this environment variable is set to a fake directory
that will cause the .vsprops files in $WebKitLibrariesDir to be found when the relative path
is resolved.

For example, JavaScriptCore.vcproj uses this path for FeatureDefines.vsprops:

$(WebKitVSPropsRedirectionDir)..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops

In developer builds, where $WebKitVSPropsRedirectionDir is unset, this will point to the
files in WebKitLibraries\win\tools\vsprops in the source tree. In production builds,
JavaScriptCore.make sets $WebKitVSPropsRedirectionDir to
"$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\", so the full path for
FeatureDefines.vsprops becomes:

$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops

which resolves to:

$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops

(We rely on the fact that Windows doesn't care whether the directories "1", "2", and "3"
actually exist since they are matched by an equal number of ".." path components.)

Note that Visual Studio still won't pick up changes made to .vsprops files while Visual
Studio is open, but that problem hasn't seemed to cause developers many headaches so far.

Fixes <​http://webkit.org/b/49181> Windows build fails mysteriously when .vsprops files are
updated

Reviewed by Dave Hyatt.

JavaScriptCore:

• JavaScriptCore.vcproj/JavaScriptCore.make: Set $WebKitVSPropsRedirectionDir so that

production builds can find the .vsprops files.

• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: Stopy copying the

.vsprops files. It isn't needed anymore.

• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
• JavaScriptCore.vcproj/WTF/WTF.vcproj:
• JavaScriptCore.vcproj/jsc/jsc.vcproj:
• JavaScriptCore.vcproj/testapi/testapi.vcproj:

Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
files.

WebCore:

• WebCore.vcproj/WebCore.make: Set $WebKitVSPropsRedirectionDir so that

production builds can find the .vsprops files.

• WebCore.vcproj/QTMovieWin.vcproj:
• WebCore.vcproj/WebCore.vcproj:

Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
files.

WebKit/win:

• WebKit.vcproj/WebKit.make: Set $WebKitVSPropsRedirectionDir so that production builds can

find the .vsprops files.

• WebKit.vcproj/WebKit.vcproj:
• WebKit.vcproj/Interfaces.vcproj:
• WebKit.vcproj/WebKitGUID.vcproj:

Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
files.

WebKit2:

• win/WebKit2.make: Set $WebKitVSPropsRedirectionDir so that production builds can

find the .vsprops files.

• win/WebKit2.vcproj:
• win/WebKit2WebProcess.vcproj:

Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
files.

WebKitLibraries:

• win/tools/WinTools.make: Copy the shared .vsprops files into a directory tree beneath

AppleInternal\tools\vsprops that matches the source directory tree. This allows production
builds to redirect the relative paths used to find the shared .vsprops files into
AppleInternal by setting $WebKitVSPropsRedirectionDir to the appropriate value.

WebKitTools:

• DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
• DumpRenderTree/win/DumpRenderTree.vcproj:
• DumpRenderTree/win/ImageDiff.vcproj:
• FindSafari/FindSafari.vcproj:
• MiniBrowser/MiniBrowser.vcproj:
• TestWebKitAPI/win/TestWebKitAPI.vcproj:
• TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
• WebKitAPITest/WebKitAPITest.vcproj:
• WebKitLauncherWin/WebKitLauncherWin.vcproj:
• WebKitTestRunner/win/InjectedBundle.vcproj:
• WebKitTestRunner/win/WebKitTestRunner.vcproj:
• WinLauncher/WinLauncher.vcproj:
• record-memory-win/record-memory-win.vcproj:

Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
files.

1:17 PM Changeset in webkit [72554] by Adam Roben

• 2 edits in trunk/WebKitTools

Make it possible to run tests on Windows without Visual Studio or VC++ Express installed

webkitdir.pm::setupCygwinEnv dies when Visual Studio and VC++ Express
are not installed. But this function doesn't need to be called when we
already have a build available and are just trying to run the tests.

Fixes <​http://webkit.org/b/49932> New Windows 7 bot can't run tests
because Visual Studio/VC++ Express aren't installed

Reviewed by Dave Hyatt.

• Scripts/webkitdirs.pm:

(determineConfigurationForVisualStudio): Don't call setupCygwinEnv, as
it is not needed by this function. Also added a FIXME.

(usingVisualStudioExpress): Call setupCygwinEnv directly rather than
relying on determineConfigurationForVisualStudio doing it.

1:16 PM Changeset in webkit [72553] by rniwa@webkit.org

• 3 edits
  1 delete in trunk/LayoutTests

2010-11-22 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed update of Windows's skipped list and Chromium's test expectation.

fast/text/international/thai-cursor-position.html erroneously had an expected result
on Windows even though textInputController hasn't been implemented on Windows (the bug 32021).

Removed the expected result and added the tests to Windows platform's skipped list.

• platform/chromium/test_expectations.txt: Removed fast/text/international/thai-cursor-position.html.
• platform/win/Skipped: Added fast/text/international/thai-cursor-position.html.
• platform/win/fast/text/international/thai-cursor-position-expected.txt: Removed.

1:02 PM Changeset in webkit [72552] by luiz@webkit.org

• 31 edits
  22 adds in trunk

2010-10-21 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Darin Adler.

Implement CSSOM View matchMedia interface
​https://bugs.webkit.org/show_bug.cgi?id=37205

New property matchMedia was added to window.

• fast/dom/Window/window-properties-expected.txt:
• fast/dom/Window/window-property-descriptors-expected.txt:

window.matchMedia and MediaQueryList tests.

• fast/media/media-query-list-01-expected.txt: Added.
• fast/media/media-query-list-01.html: Added.

The following tests depend on LayoutTestController::setViewModeMediaFeature() to work.
As it is only implemented by Qt and Gtk the tests needed to be skipped in all other platforms.

• fast/media/media-query-list-02-expected.txt: Added.
• fast/media/media-query-list-02.html: Added.
• fast/media/media-query-list-03-expected.txt: Added.
• fast/media/media-query-list-03.html: Added.
• fast/media/media-query-list-04-expected.txt: Added.
• fast/media/media-query-list-04.html: Added.
• fast/media/media-query-list-05-expected.txt: Added.
• fast/media/media-query-list-05.html: Added.
• fast/media/media-query-list-06-expected.txt: Added.
• fast/media/media-query-list-06.html: Added.
• fast/media/media-query-list-07-expected.txt: Added.
• fast/media/media-query-list-07.html: Added.
• platform/chromium/test_expectations.txt:
• platform/mac/Skipped:
• platform/win/Skipped:

2010-10-21 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Darin Adler.

Implement CSSOM View matchMedia interface
​https://bugs.webkit.org/show_bug.cgi?id=37205

New interfaces may be used to evaluate media queries and to associate listeners
to media queries. Those listeners are called whenever the associated query changes.
Specification may be found at ​http://dev.w3.org/csswg/cssom-view/#the-mediaquerylist-interface

operator== added to JS version of ScriptValue.
Method isFunction added to JS and V8 versions of ScriptValue.

• bindings/js/ScriptValue.cpp: (WebCore::ScriptValue::isFunction):
• bindings/js/ScriptValue.h: (WebCore::ScriptValue::operator==):
• bindings/v8/ScriptValue.h: (WebCore::ScriptValue::isFunction):

Some changes were needed to the code generators to handle type MediaQueryListListener.

• bindings/scripts/CodeGeneratorGObject.pm:
• bindings/scripts/CodeGeneratorJS.pm:
• bindings/scripts/CodeGeneratorV8.pm:

Some changes to the bindings test results that were previously added.

• bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
• bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.h:
• bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: (WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod):
• bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp: (WebCore::TestMediaQueryListListenerInternal::methodCallback): (WebCore::ConfigureV8TestMediaQueryListListenerTemplate):

New interfaces:

• css/MediaQueryList.cpp: Added.
• css/MediaQueryList.h: Added.
• css/MediaQueryList.idl: Added.

• css/MediaQueryListListener.cpp: Added.
• css/MediaQueryListListener.h: Added.
• css/MediaQueryListListener.idl: Added.

To avoid adding code to classes DOMWindow and Document a new class MediaQueryMatcher was created.

• css/MediaQueryMatcher.cpp: Added.
• css/MediaQueryMatcher.h: Added.

Document and DOMWindow have changed to support new features. DOMWindow is the class that
publishes methods matchMedia but for page cache to work properly the reference to the
MediaQueryMatcher must be in Document.

• dom/Document.cpp: (WebCore::Document::~Document): (WebCore::Document::mediaQueryMatcher): (WebCore::Document::styleSelectorChanged):
• dom/Document.h:
• page/DOMWindow.cpp: (WebCore::DOMWindow::matchMedia):
• page/DOMWindow.h:
• page/DOMWindow.idl:

Build systems

• CMakeLists.txt:
• DerivedSources.make:
• GNUmakefile.am:
• WebCore.gypi:
• WebCore.pri:
• WebCore.pro:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.xcodeproj/project.pbxproj:
• bindings/gobject/GNUmakefile.am:

Tests: fast/media/media-query-list-01.html

fast/media/media-query-list-02.html
fast/media/media-query-list-03.html
fast/media/media-query-list-04.html
fast/media/media-query-list-05.html
fast/media/media-query-list-06.html
fast/media/media-query-list-07.html

1:00 PM Changeset in webkit [72551] by hayato@chromium.org

• 10 edits
  1 delete in trunk/WebKitTools

2010-11-19 Hayato Ito <​hayato@chromium.org>

Reviewed by Shinichiro Hamaji.

Simplify Driver.run_test() so that it takes only one parameter, TestInput.

​https://bugs.webkit.org/show_bug.cgi?id=49812

• Scripts/webkitpy/layout_tests/driver_test.py:
• Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
• Scripts/webkitpy/layout_tests/port/base.py:
• Scripts/webkitpy/layout_tests/port/base_unittest.py:
• Scripts/webkitpy/layout_tests/port/chromium.py:
• Scripts/webkitpy/layout_tests/port/dryrun.py:
• Scripts/webkitpy/layout_tests/port/test.py:
• Scripts/webkitpy/layout_tests/port/webkit.py:
• Scripts/webkitpy/layout_tests/run_webkit_tests.py:
• Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

12:13 PM Changeset in webkit [72550] by rniwa@webkit.org

• 2 edits
  2 deletes in trunk/LayoutTests

2010-11-22 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed update of Windows Skipped list.

editing/selection/5825350-1.html and 5825350-2.html erroneously
had expectations with console error message even though textInputController
hasn't been implemented on Windows (the bug 32021),

Removed these expectations and added the tests to the skipped list.

• platform/win/Skipped:
• platform/win/editing/selection/5825350-1-expected.txt: Removed.
• platform/win/editing/selection/5825350-2-expected.txt: Removed.

12:08 PM Changeset in webkit [72549] by Adam Roben

• 1 edit
  3 adds in trunk/LayoutTests

Add Windows-specific results for fast/ruby/nested-ruby.html

• platform/win/fast/ruby/nested-ruby-expected.checksum: Added.
• platform/win/fast/ruby/nested-ruby-expected.png: Added.
• platform/win/fast/ruby/nested-ruby-expected.txt: Added.

12:07 PM Changeset in webkit [72548] by Adam Roben

• 3 edits
  1 delete in trunk/LayoutTests

Update Windows XP results for fast/text/international/bidi-control-chars-treated-as-ZWS.html

The render tree dump on XP now matches Mac. I updated the pixel results
to match the current rendering (the two test lines have moved down
slightly).

• platform/win-xp/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.checksum:
• platform/win-xp/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.png:
• platform/win-xp/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Removed.

11:58 AM Changeset in webkit [72547] by hayato@chromium.org

• 2 edits in trunk/WebKitTools

2010-11-22 Hayato Ito <​hayato@chromium.org>

Reviewed by Tony Chang.

[NRWT] Retry a few times in reading a png image to avoid a race condition.

​https://bugs.webkit.org/show_bug.cgi?id=49924

• Scripts/webkitpy/layout_tests/port/chromium.py:

11:09 AM Changeset in webkit [72546] by Adam Roben

• 1 edit
  1 delete in trunk/LayoutTests

Remove obsolete Windows-specific results for svg/dom/path-parser.html

r72381 made these unnecessary.

• platform/win/svg/dom/path-parser-expected.txt: Removed.

11:08 AM Changeset in webkit [72545] by Adam Roben

• 2 edits in trunk/LayoutTests

Update Windows results for fast/dom/prototype-inheritance-2.html

This is the Windows equivalent of r72353.

• platform/win/fast/dom/prototype-inheritance-2-expected.txt:

10:55 AM Changeset in webkit [72544] by andreas.kling@nokia.com

• 8 edits
  1 add in trunk/LayoutTests

2010-11-22 Andreas Kling <​kling@webkit.org>

Unreviewed, rebaseline GTK+ after r72527.

• platform/gtk/css1/box_properties/margin_right-expected.txt:
• platform/gtk/css1/box_properties/padding_right-expected.txt:
• platform/gtk/fast/lists/001-vertical-expected.txt:
• platform/gtk/fast/lists/002-vertical-expected.txt:
• platform/gtk/fast/lists/003-vertical-expected.txt:
• platform/gtk/fast/lists/007-vertical-expected.txt:
• platform/gtk/fast/lists/008-vertical-expected.txt:
• platform/gtk/fast/lists/outSideListMarkers-expected.txt: Added.

10:50 AM Changeset in webkit [72543] by Adam Roben

• 1 edit
  1 add in trunk/LayoutTests

Add Windows-specific results for editing/selection/extend-selection-home-end.html

These results are identical to the cross-platform results, but are
needed to override the Mac-specific results in platform/mac.

Fixes <​http://webkit.org/b/49874>.

• platform/win/editing/selection/extend-selection-home-end-expected.txt: Added.

10:44 AM Changeset in webkit [72542] by antonm@chromium.org

• 2 edits
  2 deletes in trunk/LayoutTests

Not reviewed. Test expectations arrangements and rebaselinings.

• platform/chromium-mac/fast/lists/001-vertical-expected.checksum: Removed.
• platform/chromium-mac/fast/lists/001-vertical-expected.png: Removed.
• platform/chromium/test_expectations.txt:

10:30 AM Changeset in webkit [72541] by antonm@chromium.org

• 4 edits
  23 adds in trunk/LayoutTests

Not reviewed. Fallback font rebaselines.

• platform/chromium-linux/fast/css/line-height-determined-by-primary-font-expected.checksum: Added.
• platform/chromium-linux/fast/css/line-height-determined-by-primary-font-expected.png: Added.
• platform/chromium-linux/fast/css/line-height-determined-by-primary-font-expected.txt: Added.
• platform/chromium-linux/fast/text/international/hebrew-vowels-expected.checksum: Added.
• platform/chromium-linux/fast/text/international/hebrew-vowels-expected.png: Added.
• platform/chromium-mac/css2.1/t1202-counters-04-b-expected.checksum: Added.
• platform/chromium-mac/css2.1/t1202-counters-04-b-expected.png: Added.
• platform/chromium-mac/editing/selection/caret-rtl-2-expected.checksum:
• platform/chromium-mac/editing/selection/caret-rtl-2-expected.png:
• platform/chromium-mac/fast/css/line-height-determined-by-primary-font-expected.checksum: Added.
• platform/chromium-mac/fast/css/line-height-determined-by-primary-font-expected.png: Added.
• platform/chromium-mac/fast/forms/select-visual-hebrew-expected.checksum: Added.
• platform/chromium-mac/fast/forms/select-visual-hebrew-expected.png: Added.
• platform/chromium-mac/fast/forms/visual-hebrew-text-field-expected.checksum: Added.
• platform/chromium-mac/fast/forms/visual-hebrew-text-field-expected.png: Added.
• platform/chromium-mac/fast/text/international/001-expected.checksum: Added.
• platform/chromium-mac/fast/text/international/001-expected.png: Added.
• platform/chromium-mac/fast/text/international/hebrew-vowels-expected.checksum: Added.
• platform/chromium-mac/fast/text/international/hebrew-vowels-expected.png: Added.
• platform/chromium-win/fast/css/line-height-determined-by-primary-font-expected.checksum: Added.
• platform/chromium-win/fast/css/line-height-determined-by-primary-font-expected.png: Added.
• platform/chromium-win/fast/css/line-height-determined-by-primary-font-expected.txt: Added.
• platform/chromium-win/fast/text/international/hebrew-vowels-expected.checksum: Added.
• platform/chromium-win/fast/text/international/hebrew-vowels-expected.png: Added.
• platform/chromium-win/fast/text/international/hebrew-vowels-expected.txt: Added.
• platform/chromium/test_expectations.txt:

10:26 AM Changeset in webkit [72540] by apavlov@chromium.org

• 8 edits
  1 add in trunk

2010-11-22 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] Contents of rules inside @media not displayed/editable
​https://bugs.webkit.org/show_bug.cgi?id=49804

WebCore:

• css/CSSImportRule.cpp: (WebCore::CSSImportRule::insertedIntoParent):
• inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::setStyleSheetText2):
• inspector/InspectorStyleSheet.cpp: (WebCore::asCSSRuleList): (WebCore::InspectorStyleSheet::reparseStyleSheet): (WebCore::InspectorStyleSheet::setText): (WebCore::InspectorStyleSheet::addRule): (WebCore::InspectorStyleSheet::ruleForId): (WebCore::InspectorStyleSheet::ruleIndexByStyle): (WebCore::InspectorStyleSheet::ensureText): (WebCore::InspectorStyleSheet::ensureSourceData): (WebCore::InspectorStyleSheet::ensureFlatRules): (WebCore::InspectorStyleSheet::revalidateStyle): (WebCore::InspectorStyleSheet::buildArrayForRuleList): (WebCore::InspectorStyleSheet::fixUnparsedPropertyRanges): (WebCore::InspectorStyleSheet::collectFlatRules):
• inspector/InspectorStyleSheet.h:

LayoutTests:

• inspector/resources/styles-new-API-1.css: Added. (@page): (@page :first): (#absent-id): (body):
• inspector/resources/styles-new-API.css:
• inspector/styles-new-API-expected.txt:

9:53 AM Changeset in webkit [72539] by antonm@chromium.org

• 2 edits in trunk/LayoutTests

Not reviewed. Amending expectations for Chromium.

• platform/chromium/test_expectations.txt:

9:50 AM Changeset in webkit [72538] by antonm@chromium.org

• 4 edits
  30 adds in trunk/LayoutTests

Not reviewed. Another portion of Chromium rebaselines for SVG.

• platform/chromium-linux/svg/dom/SVGPathSegList-appendItem-expected.checksum: Added.
• platform/chromium-linux/svg/dom/SVGPathSegList-appendItem-expected.png: Added.
• platform/chromium-linux/svg/dom/SVGPathSegList-clear-and-initialize-expected.checksum: Added.
• platform/chromium-linux/svg/dom/SVGPathSegList-clear-and-initialize-expected.png: Added.
• platform/chromium-linux/svg/dom/SVGPathSegList-insertItemBefore-expected.checksum: Added.
• platform/chromium-linux/svg/dom/SVGPathSegList-insertItemBefore-expected.png: Added.
• platform/chromium-linux/svg/dom/SVGPathSegList-removeItem-expected.checksum: Added.
• platform/chromium-linux/svg/dom/SVGPathSegList-removeItem-expected.png: Added.
• platform/chromium-linux/svg/dom/SVGPathSegList-replaceItem-expected.checksum: Added.
• platform/chromium-linux/svg/dom/SVGPathSegList-replaceItem-expected.png: Added.
• platform/chromium-mac/svg/dom/SVGPathSegList-appendItem-expected.checksum: Added.
• platform/chromium-mac/svg/dom/SVGPathSegList-appendItem-expected.png: Added.
• platform/chromium-mac/svg/dom/SVGPathSegList-clear-and-initialize-expected.checksum: Added.
• platform/chromium-mac/svg/dom/SVGPathSegList-clear-and-initialize-expected.png: Added.
• platform/chromium-mac/svg/dom/SVGPathSegList-insertItemBefore-expected.checksum: Added.
• platform/chromium-mac/svg/dom/SVGPathSegList-insertItemBefore-expected.png: Added.
• platform/chromium-mac/svg/dom/SVGPathSegList-removeItem-expected.checksum: Added.
• platform/chromium-mac/svg/dom/SVGPathSegList-removeItem-expected.png: Added.
• platform/chromium-mac/svg/dom/SVGPathSegList-replaceItem-expected.checksum: Added.
• platform/chromium-mac/svg/dom/SVGPathSegList-replaceItem-expected.png: Added.
• platform/chromium-mac/svg/dom/svgpath-out-of-bounds-getPathSeg-expected.txt:
• platform/chromium-win/svg/dom/SVGPathSegList-appendItem-expected.checksum: Added.
• platform/chromium-win/svg/dom/SVGPathSegList-appendItem-expected.png: Added.
• platform/chromium-win/svg/dom/SVGPathSegList-clear-and-initialize-expected.checksum: Added.
• platform/chromium-win/svg/dom/SVGPathSegList-clear-and-initialize-expected.png: Added.
• platform/chromium-win/svg/dom/SVGPathSegList-insertItemBefore-expected.checksum: Added.
• platform/chromium-win/svg/dom/SVGPathSegList-insertItemBefore-expected.png: Added.
• platform/chromium-win/svg/dom/SVGPathSegList-removeItem-expected.checksum: Added.
• platform/chromium-win/svg/dom/SVGPathSegList-removeItem-expected.png: Added.
• platform/chromium-win/svg/dom/SVGPathSegList-replaceItem-expected.checksum: Added.
• platform/chromium-win/svg/dom/SVGPathSegList-replaceItem-expected.png: Added.
• platform/chromium-win/svg/dom/svgpath-out-of-bounds-getPathSeg-expected.txt:
• platform/chromium/test_expectations.txt:

9:39 AM Changeset in webkit [72537] by antonm@chromium.org

• 17 edits in trunk/LayoutTests

Not reviewed. Another portion of Chromium rebaselines.

• platform/chromium-linux/fast/text/international/hindi-whitespace-expected.checksum:
• platform/chromium-linux/fast/text/international/hindi-whitespace-expected.png:
• platform/chromium-linux/fast/text/international/hindi-whitespace-expected.txt:
• platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-30-t-expected.checksum:
• platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
• platform/chromium-linux/svg/carto.net/selectionlist-expected.checksum:
• platform/chromium-linux/svg/carto.net/selectionlist-expected.png:
• platform/chromium-linux/svg/custom/image-small-width-height-expected.checksum:
• platform/chromium-linux/svg/custom/image-small-width-height-expected.png:
• platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-30-t-expected.checksum:
• platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
• platform/chromium-win/svg/carto.net/selectionlist-expected.checksum:
• platform/chromium-win/svg/carto.net/selectionlist-expected.png:
• platform/chromium-win/svg/custom/image-small-width-height-expected.checksum:
• platform/chromium-win/svg/custom/image-small-width-height-expected.png:
• platform/chromium/test_expectations.txt:

9:36 AM Changeset in webkit [72536] by tony@chromium.org

• 2 edits in trunk/LayoutTests

2010-11-22 Tony Chang <​tony@chromium.org>

Unreviewed, update Chromium Win plugin test expectations.

• platform/chromium/drt_expectations.txt:

9:33 AM Changeset in webkit [72535] by antonm@chromium.org

• 6 edits
  26 adds in trunk/LayoutTests

Not reviewed. Chromium rebaselines after ​http://trac.webkit.org/changeset/72518

• platform/chromium-linux/svg/dom/SVGLengthList-basics-expected.checksum:
• platform/chromium-linux/svg/dom/SVGLengthList-basics-expected.png:
• platform/chromium-linux/svg/dom/SVGNumberList-basics-expected.checksum: Added.
• platform/chromium-linux/svg/dom/SVGNumberList-basics-expected.png: Added.
• platform/chromium-linux/svg/dom/SVGPointList-basics-expected.checksum: Added.
• platform/chromium-linux/svg/dom/SVGPointList-basics-expected.png: Added.
• platform/chromium-linux/svg/dom/SVGStringList-basics-expected.checksum: Added.
• platform/chromium-linux/svg/dom/SVGStringList-basics-expected.png: Added.
• platform/chromium-linux/svg/dom/SVGTransformList-basics-expected.checksum: Added.
• platform/chromium-linux/svg/dom/SVGTransformList-basics-expected.png: Added.
• platform/chromium-mac/svg/dom/SVGLengthList-basics-expected.checksum: Added.
• platform/chromium-mac/svg/dom/SVGLengthList-basics-expected.png: Added.
• platform/chromium-mac/svg/dom/SVGNumberList-basics-expected.checksum: Added.
• platform/chromium-mac/svg/dom/SVGNumberList-basics-expected.png: Added.
• platform/chromium-mac/svg/dom/SVGPointList-basics-expected.checksum: Added.
• platform/chromium-mac/svg/dom/SVGPointList-basics-expected.png: Added.
• platform/chromium-mac/svg/dom/SVGStringList-basics-expected.checksum: Added.
• platform/chromium-mac/svg/dom/SVGStringList-basics-expected.png: Added.
• platform/chromium-mac/svg/dom/SVGTransformList-basics-expected.checksum: Added.
• platform/chromium-mac/svg/dom/SVGTransformList-basics-expected.png: Added.
• platform/chromium-win/svg/dom/SVGLengthList-basics-expected.checksum:
• platform/chromium-win/svg/dom/SVGLengthList-basics-expected.png:
• platform/chromium-win/svg/dom/SVGNumberList-basics-expected.checksum: Added.
• platform/chromium-win/svg/dom/SVGNumberList-basics-expected.png: Added.
• platform/chromium-win/svg/dom/SVGPointList-basics-expected.checksum: Added.
• platform/chromium-win/svg/dom/SVGPointList-basics-expected.png: Added.
• platform/chromium-win/svg/dom/SVGStringList-basics-expected.checksum: Added.
• platform/chromium-win/svg/dom/SVGStringList-basics-expected.png: Added.
• platform/chromium-win/svg/dom/SVGTransformList-basics-expected.checksum: Added.
• platform/chromium-win/svg/dom/SVGTransformList-basics-expected.png: Added.
• platform/chromium/test_expectations.txt:

9:23 AM Changeset in webkit [72534] by antonm@chromium.org

• 2 edits in trunk/LayoutTests

Not reviewed. Reorganizing suppressions.

• platform/chromium/test_expectations.txt:

9:16 AM Changeset in webkit [72533] by antonm@chromium.org

• 86 edits
  7 adds
  10 deletes in trunk/LayoutTests

Unreviewed. Tons of Chromium rebaselines after ​http://trac.webkit.org/changeset/72527

• platform/chromium-linux/css1/box_properties/margin_right-expected.checksum:
• platform/chromium-linux/css1/box_properties/margin_right-expected.png:
• platform/chromium-linux/css1/box_properties/padding_right-expected.checksum:
• platform/chromium-linux/css1/box_properties/padding_right-expected.png:
• platform/chromium-linux/css2.1/t0805-c5520-brdr-b-01-e-expected.checksum:
• platform/chromium-linux/css2.1/t0805-c5520-brdr-b-01-e-expected.png:
• platform/chromium-linux/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
• platform/chromium-linux/editing/pasteboard/merge-end-list-expected.checksum:
• platform/chromium-linux/editing/pasteboard/merge-end-list-expected.png:
• platform/chromium-linux/editing/selection/extend-by-word-002-expected.checksum:
• platform/chromium-linux/editing/selection/extend-by-word-002-expected.png:
• platform/chromium-linux/fast/css/background-shorthand-invalid-url-expected.checksum:
• platform/chromium-linux/fast/css/background-shorthand-invalid-url-expected.png:
• platform/chromium-linux/fast/doctypes/002-expected.checksum:
• platform/chromium-linux/fast/doctypes/002-expected.png:
• platform/chromium-linux/fast/lists/001-vertical-expected.checksum:
• platform/chromium-linux/fast/lists/001-vertical-expected.png:
• platform/chromium-linux/fast/lists/001-vertical-expected.txt: Removed.
• platform/chromium-linux/fast/lists/002-expected.checksum:
• platform/chromium-linux/fast/lists/002-expected.png:
• platform/chromium-linux/fast/lists/002-vertical-expected.checksum:
• platform/chromium-linux/fast/lists/002-vertical-expected.png:
• platform/chromium-linux/fast/lists/002-vertical-expected.txt: Removed.
• platform/chromium-linux/fast/lists/003-expected.checksum:
• platform/chromium-linux/fast/lists/003-expected.png:
• platform/chromium-linux/fast/lists/003-vertical-expected.checksum:
• platform/chromium-linux/fast/lists/003-vertical-expected.png:
• platform/chromium-linux/fast/lists/003-vertical-expected.txt: Removed.
• platform/chromium-linux/fast/lists/007-vertical-expected.checksum:
• platform/chromium-linux/fast/lists/007-vertical-expected.png:
• platform/chromium-linux/fast/lists/007-vertical-expected.txt: Removed.
• platform/chromium-linux/fast/lists/008-vertical-expected.checksum:
• platform/chromium-linux/fast/lists/008-vertical-expected.png:
• platform/chromium-linux/fast/lists/008-vertical-expected.txt: Removed.
• platform/chromium-linux/fast/lists/marker-before-empty-inline-expected.checksum:
• platform/chromium-linux/fast/lists/marker-before-empty-inline-expected.png:
• platform/chromium-linux/fast/lists/outSideListMarkers-expected.checksum: Added.
• platform/chromium-linux/fast/lists/outSideListMarkers-expected.png: Added.
• platform/chromium-mac/css1/box_properties/margin_right-expected.checksum:
• platform/chromium-mac/css1/box_properties/margin_right-expected.png:
• platform/chromium-mac/css1/box_properties/padding_right-expected.checksum:
• platform/chromium-mac/css1/box_properties/padding_right-expected.png:
• platform/chromium-mac/css2.1/t0805-c5520-brdr-b-01-e-expected.checksum:
• platform/chromium-mac/css2.1/t0805-c5520-brdr-b-01-e-expected.png:
• platform/chromium-mac/editing/pasteboard/merge-end-list-expected.checksum: Removed.
• platform/chromium-mac/editing/pasteboard/merge-end-list-expected.png: Removed.
• platform/chromium-mac/editing/selection/extend-by-word-002-expected.checksum: Removed.
• platform/chromium-mac/editing/selection/extend-by-word-002-expected.png: Removed.
• platform/chromium-mac/fast/css/background-shorthand-invalid-url-expected.checksum: Removed.
• platform/chromium-mac/fast/lists/008-vertical-expected.checksum:
• platform/chromium-mac/fast/lists/008-vertical-expected.png:
• platform/chromium-mac/fast/lists/marker-before-empty-inline-expected.checksum: Added.
• platform/chromium-mac/fast/lists/marker-before-empty-inline-expected.png: Added.
• platform/chromium-win/css1/box_properties/margin_right-expected.checksum:
• platform/chromium-win/css1/box_properties/margin_right-expected.png:
• platform/chromium-win/css1/box_properties/margin_right-expected.txt:
• platform/chromium-win/css1/box_properties/padding_right-expected.checksum:
• platform/chromium-win/css1/box_properties/padding_right-expected.png:
• platform/chromium-win/css1/box_properties/padding_right-expected.txt:
• platform/chromium-win/css2.1/t0805-c5520-brdr-b-01-e-expected.checksum:
• platform/chromium-win/css2.1/t0805-c5520-brdr-b-01-e-expected.png:
• platform/chromium-win/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
• platform/chromium-win/editing/pasteboard/merge-end-list-expected.checksum:
• platform/chromium-win/editing/pasteboard/merge-end-list-expected.png:
• platform/chromium-win/editing/pasteboard/merge-end-list-expected.txt:
• platform/chromium-win/editing/selection/extend-by-word-002-expected.checksum:
• platform/chromium-win/editing/selection/extend-by-word-002-expected.png:
• platform/chromium-win/editing/selection/extend-by-word-002-expected.txt:
• platform/chromium-win/fast/css/background-shorthand-invalid-url-expected.checksum:
• platform/chromium-win/fast/css/background-shorthand-invalid-url-expected.png:
• platform/chromium-win/fast/css/background-shorthand-invalid-url-expected.txt:
• platform/chromium-win/fast/doctypes/002-expected.checksum:
• platform/chromium-win/fast/doctypes/002-expected.png:
• platform/chromium-win/fast/doctypes/002-expected.txt:
• platform/chromium-win/fast/lists/001-vertical-expected.checksum:
• platform/chromium-win/fast/lists/001-vertical-expected.png:
• platform/chromium-win/fast/lists/001-vertical-expected.txt:
• platform/chromium-win/fast/lists/002-expected.checksum:
• platform/chromium-win/fast/lists/002-expected.png:
• platform/chromium-win/fast/lists/002-expected.txt:
• platform/chromium-win/fast/lists/002-vertical-expected.checksum:
• platform/chromium-win/fast/lists/002-vertical-expected.png:
• platform/chromium-win/fast/lists/002-vertical-expected.txt:
• platform/chromium-win/fast/lists/003-expected.checksum:
• platform/chromium-win/fast/lists/003-expected.png:
• platform/chromium-win/fast/lists/003-expected.txt:
• platform/chromium-win/fast/lists/003-vertical-expected.checksum:
• platform/chromium-win/fast/lists/003-vertical-expected.png:
• platform/chromium-win/fast/lists/003-vertical-expected.txt:
• platform/chromium-win/fast/lists/007-vertical-expected.checksum:
• platform/chromium-win/fast/lists/007-vertical-expected.png:
• platform/chromium-win/fast/lists/007-vertical-expected.txt:
• platform/chromium-win/fast/lists/008-vertical-expected.checksum:
• platform/chromium-win/fast/lists/008-vertical-expected.png:
• platform/chromium-win/fast/lists/008-vertical-expected.txt:
• platform/chromium-win/fast/lists/marker-before-empty-inline-expected.checksum:
• platform/chromium-win/fast/lists/marker-before-empty-inline-expected.png:
• platform/chromium-win/fast/lists/marker-before-empty-inline-expected.txt:
• platform/chromium-win/fast/lists/outSideListMarkers-expected.checksum: Added.
• platform/chromium-win/fast/lists/outSideListMarkers-expected.png: Added.
• platform/chromium-win/fast/lists/outSideListMarkers-expected.txt: Added.
• platform/chromium/test_expectations.txt:

8:57 AM Changeset in webkit [72532] by Csaba Osztrogonác

• 2 edits in trunk/WebKit2

Make WebKit2 compile with ENABLE_JAVASCRIPT_DEBUGGER=0

Patch by Kenneth Rohde Christiansen <​kenneth@webkit.org> on 2010-11-22
Reviewed by Andreas Kling.

• WebProcess/WebPage/WebInspector.cpp: Add missing ENABLE(JAVASCRIPT_DEBUGGER) guards.

(WebKit::WebInspector::startJavaScriptDebugging):
(WebKit::WebInspector::stopJavaScriptDebugging):
(WebKit::WebInspector::startJavaScriptProfiling):
(WebKit::WebInspector::stopJavaScriptProfiling):

8:46 AM Changeset in webkit [72531] by loislo@chromium.org

• 4 edits in trunk/WebCore

2010-11-22 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: dump inspector protocol messages into console.
Sometimes I need to dump inspector messages into console.
It'd be much simple to have this code in repository and
enable protocol dumping just by a flag.

​https://bugs.webkit.org/show_bug.cgi?id=49905

• inspector/CodeGeneratorInspector.pm:
• inspector/front-end/WorkersSidebarPane.js: (WebInspector.WorkersSidebarPane.prototype.reset):
• inspector/front-end/inspector.js: (WebInspector_syncDispatch):

8:43 AM Changeset in webkit [72530] by Csaba Osztrogonác

• 20 edits
  11 adds in trunk/LayoutTests

Unreviewed. Update Qt specific expected results after r72527.

• platform/qt/css1/box_properties/margin_right-expected.checksum: Added.
• platform/qt/css1/box_properties/margin_right-expected.png: Added.
• platform/qt/css1/box_properties/margin_right-expected.txt:
• platform/qt/css1/box_properties/padding_right-expected.checksum: Added.
• platform/qt/css1/box_properties/padding_right-expected.png: Added.
• platform/qt/css1/box_properties/padding_right-expected.txt:
• platform/qt/editing/pasteboard/merge-end-list-expected.checksum: Added.
• platform/qt/editing/pasteboard/merge-end-list-expected.png: Added.
• platform/qt/editing/pasteboard/merge-end-list-expected.txt:
• platform/qt/fast/doctypes/002-expected.checksum: Added.
• platform/qt/fast/doctypes/002-expected.png: Added.
• platform/qt/fast/doctypes/002-expected.txt:
• platform/qt/fast/lists/001-vertical-expected.checksum:
• platform/qt/fast/lists/001-vertical-expected.png:
• platform/qt/fast/lists/001-vertical-expected.txt:
• platform/qt/fast/lists/002-vertical-expected.checksum:
• platform/qt/fast/lists/002-vertical-expected.png:
• platform/qt/fast/lists/002-vertical-expected.txt:
• platform/qt/fast/lists/003-vertical-expected.checksum:
• platform/qt/fast/lists/003-vertical-expected.png:
• platform/qt/fast/lists/003-vertical-expected.txt:
• platform/qt/fast/lists/007-vertical-expected.checksum:
• platform/qt/fast/lists/007-vertical-expected.png:
• platform/qt/fast/lists/007-vertical-expected.txt:
• platform/qt/fast/lists/008-vertical-expected.checksum:
• platform/qt/fast/lists/008-vertical-expected.png:
• platform/qt/fast/lists/008-vertical-expected.txt:
• platform/qt/fast/lists/outSideListMarkers-expected.checksum: Added.
• platform/qt/fast/lists/outSideListMarkers-expected.png: Added.
• platform/qt/fast/lists/outSideListMarkers-expected.txt: Added.

8:18 AM Changeset in webkit [72529] by andreas.kling@nokia.com

• 3 edits in trunk/LayoutTests

2010-11-22 Andreas Kling <​kling@webkit.org>

Unreviewed, 2 missing rebaselines after r72527.

• platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
• platform/mac/fast/lists/marker-before-empty-inline-expected.txt:

7:52 AM Changeset in webkit [72528] by andreas.kling@nokia.com

• 12 edits in trunk/WebCore

2010-11-22 Andreas Kling <​kling@webkit.org>

Reviewed by Nikolas Zimmermann.

GraphicsContext: Make drawFocusRing() take a Path instead of a Vector<Path>
​https://bugs.webkit.org/show_bug.cgi?id=49840

This avoid copying a Path object when drawing focus rings.

• platform/graphics/GraphicsContext.h:
• platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawFocusRing):
• platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::drawFocusRing):
• platform/graphics/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawFocusRing):
• platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawFocusRing):
• platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::drawFocusRing):
• platform/graphics/win/GraphicsContextCGWin.cpp: (WebCore::GraphicsContext::drawFocusRing):
• platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::GraphicsContext::drawFocusRing):
• platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::drawFocusRing):
• rendering/RenderImage.h:
• rendering/RenderImage.cpp: (WebCore::RenderImage::paint): (WebCore::RenderImage::paintFocusRing): Renamed from paintFocusRings since it only paints one ring.

7:13 AM Changeset in webkit [72527] by reni@webkit.org

• 67 edits
  4 adds in trunk

Outside list bullets ignore text-align style.
​https://bugs.webkit.org/show-bug.cgi?id=15713

Patch by Renata Hodovan <​reni@webkit.org> on 2010-11-22
Reviewed by Andreas Kling.

WebCore:

Fix the position of outside markers by setting its logicalLeft member. Embedded markers need special treatment.
First, the total width of markers should be calculated. Subtracting it from logicalLeft we get the outermost bullet's
position. As for the others, this sum should be decremented with the previous marker's width.
In case of vertical markers the padding is unneeded.

Test: fast/lists/outSideListMarkers.html

• rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesInInlineDirection):

• rendering/RenderListItem.cpp:

(WebCore::RenderListItem::positionListMarker):

LayoutTests:

Add new test for checking outside marker's position and update the related expecteds of tests.

• fast/lists/outSideListMarkers-expected.txt: Added.
• fast/lists/outSideListMarkers.html: Added.
• platform/mac-leopard/css1/box_properties/margin_right-expected.checksum:
• platform/mac-leopard/css1/box_properties/margin_right-expected.png:
• platform/mac-leopard/css1/box_properties/padding_right-expected.checksum:
• platform/mac-leopard/css1/box_properties/padding_right-expected.png:
• platform/mac-leopard/editing/pasteboard/merge-end-list-expected.checksum:
• platform/mac-leopard/editing/pasteboard/merge-end-list-expected.png:
• platform/mac-leopard/fast/css/background-shorthand-invalid-url-expected.checksum:
• platform/mac-leopard/fast/css/background-shorthand-invalid-url-expected.png:
• platform/mac-leopard/fast/css/empty-pseudo-class-expected.checksum:
• platform/mac-leopard/fast/css/empty-pseudo-class-expected.png:
• platform/mac-leopard/fast/css/first-child-pseudo-class-expected.checksum:
• platform/mac-leopard/fast/css/first-child-pseudo-class-expected.png:
• platform/mac-leopard/fast/css/first-of-type-pseudo-class-expected.checksum:
• platform/mac-leopard/fast/css/first-of-type-pseudo-class-expected.png:
• platform/mac-leopard/fast/css/last-child-pseudo-class-expected.checksum:
• platform/mac-leopard/fast/css/last-child-pseudo-class-expected.png:
• platform/mac-leopard/fast/css/last-of-type-pseudo-class-expected.checksum:
• platform/mac-leopard/fast/css/last-of-type-pseudo-class-expected.png:
• platform/mac-leopard/fast/css/only-child-pseudo-class-expected.checksum:
• platform/mac-leopard/fast/css/only-child-pseudo-class-expected.png:
• platform/mac-leopard/fast/css/only-of-type-pseudo-class-expected.checksum:
• platform/mac-leopard/fast/css/only-of-type-pseudo-class-expected.png:
• platform/mac-leopard/fast/doctypes/002-expected.checksum:
• platform/mac-leopard/fast/doctypes/002-expected.png:
• platform/mac-leopard/fast/lists/001-expected.checksum:
• platform/mac-leopard/fast/lists/001-expected.png:
• platform/mac-leopard/fast/lists/002-expected.checksum:
• platform/mac-leopard/fast/lists/002-expected.png:
• platform/mac-leopard/fast/lists/003-expected.checksum:
• platform/mac-leopard/fast/lists/003-expected.png:
• platform/mac/css1/box_properties/margin_right-expected.txt:
• platform/mac/css1/box_properties/padding_right-expected.txt:
• platform/mac/editing/pasteboard/merge-end-list-expected.txt:
• platform/mac/editing/selection/extend-by-word-002-expected.checksum:
• platform/mac/editing/selection/extend-by-word-002-expected.png:
• platform/mac/editing/selection/extend-by-word-002-expected.txt:
• platform/mac/fast/css/background-shorthand-invalid-url-expected.txt:
• platform/mac/fast/css/empty-pseudo-class-expected.txt:
• platform/mac/fast/css/first-child-pseudo-class-expected.txt:
• platform/mac/fast/css/first-of-type-pseudo-class-expected.txt:
• platform/mac/fast/css/last-child-pseudo-class-expected.txt:
• platform/mac/fast/css/last-of-type-pseudo-class-expected.txt:
• platform/mac/fast/css/only-child-pseudo-class-expected.txt:
• platform/mac/fast/css/only-of-type-pseudo-class-expected.txt:
• platform/mac/fast/doctypes/002-expected.txt:
• platform/mac/fast/lists/001-expected.txt:
• platform/mac/fast/lists/001-vertical-expected.checksum:
• platform/mac/fast/lists/001-vertical-expected.png:
• platform/mac/fast/lists/001-vertical-expected.txt:
• platform/mac/fast/lists/002-expected.txt:
• platform/mac/fast/lists/002-vertical-expected.checksum:
• platform/mac/fast/lists/002-vertical-expected.png:
• platform/mac/fast/lists/002-vertical-expected.txt:
• platform/mac/fast/lists/003-expected.txt:
• platform/mac/fast/lists/003-vertical-expected.checksum:
• platform/mac/fast/lists/003-vertical-expected.png:
• platform/mac/fast/lists/003-vertical-expected.txt:
• platform/mac/fast/lists/007-vertical-expected.checksum:
• platform/mac/fast/lists/007-vertical-expected.png:
• platform/mac/fast/lists/007-vertical-expected.txt:
• platform/mac/fast/lists/008-vertical-expected.checksum:
• platform/mac/fast/lists/008-vertical-expected.png:
• platform/mac/fast/lists/008-vertical-expected.txt:
• platform/mac/fast/lists/outSideListMarkers-expected.checksum: Added.
• platform/mac/fast/lists/outSideListMarkers-expected.png: Added.

6:57 AM Changeset in webkit [72526] by yael.aharon@nokia.com

• 1 edit
  4 adds in trunk/LayoutTests

2010-11-22 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Antonio Gomes.

Spatial Navigation: Additional tests.
​https://bugs.webkit.org/show_bug.cgi?id=49604

• fast/events/spatial-navigation/snav-div-overflow-scrol-hidden-expected.txt: Added.
• fast/events/spatial-navigation/snav-div-overflow-scrol-hidden.html: Added.
• fast/events/spatial-navigation/snav-z-index-expected.txt: Added.
• fast/events/spatial-navigation/snav-z-index.html: Added.

6:40 AM Changeset in webkit [72525] by antonm@chromium.org

• 7 edits
  22 adds
  1 delete in trunk/LayoutTests

Not reviewed. Rebaselining various Win/Linux only deviations.

• platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum: Added.
• platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png: Added.
• platform/chromium-linux/svg/custom/baseval-animval-equality-expected.checksum:
• platform/chromium-linux/svg/custom/baseval-animval-equality-expected.png:
• platform/chromium-linux/svg/dom/SVGPathSegList-segment-modification-expected.checksum: Added.
• platform/chromium-linux/svg/dom/SVGPathSegList-segment-modification-expected.png: Added.
• platform/chromium-linux/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.checksum: Added.
• platform/chromium-linux/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.png: Added.
• platform/chromium-linux/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.checksum: Added.
• platform/chromium-linux/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.png: Added.
• platform/chromium-linux/svg/dom/path-parser-expected.txt: Removed.
• platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum: Added.
• platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png: Added.
• platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt: Added.
• platform/chromium-win/svg/custom/baseval-animval-equality-expected.checksum:
• platform/chromium-win/svg/custom/baseval-animval-equality-expected.png:
• platform/chromium-win/svg/custom/baseval-animval-equality-expected.txt:
• platform/chromium-win/svg/dom/SVGPathSegList-segment-modification-expected.checksum: Added.
• platform/chromium-win/svg/dom/SVGPathSegList-segment-modification-expected.png: Added.
• platform/chromium-win/svg/dom/SVGPathSegList-segment-modification-expected.txt: Added.
• platform/chromium-win/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.checksum: Added.
• platform/chromium-win/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.png: Added.
• platform/chromium-win/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.checksum: Added.
• platform/chromium-win/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.png: Added.
• platform/chromium-win/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.txt: Added.
• platform/chromium-win/svg/dom/path-parser-expected.txt: Added.
• platform/chromium-win/svg/filters/filter-rounding-issues-expected.checksum: Added.
• platform/chromium-win/svg/filters/filter-rounding-issues-expected.png: Added.
• platform/chromium/test_expectations.txt:

6:37 AM Changeset in webkit [72524] by Csaba Osztrogonác

• 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] fast/workers/storage/interrupt-database-sync.html fails intermittently
​https://bugs.webkit.org/show_bug.cgi?id=49906

• platform/qt/Skipped: fast/workers/storage/interrupt-database-sync.html added until fix.

6:12 AM Changeset in webkit [72523] by Csaba Osztrogonác

• 1 edit
  27 adds in trunk/LayoutTests

Unreviewed.

[Qt] Add platform specific expected results for new passing tests.
Compared to Mac png files and Mac expected files.

• platform/qt/fast/css/negative-leading-expected.checksum: Added.
• platform/qt/fast/css/negative-leading-expected.png: Added.
• platform/qt/fast/css/negative-leading-expected.txt: Added. (introduced in r72141)
• platform/qt/fast/images/imagemap-focus-ring-zoom-expected.checksum: Added.
• platform/qt/fast/images/imagemap-focus-ring-zoom-expected.png: Added.
• platform/qt/fast/images/imagemap-focus-ring-zoom-expected.txt: Added. (introduced in r72402)
• platform/qt/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum: Added.
• platform/qt/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Added.
• platform/qt/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Added. (introduced in r72381)
• platform/qt/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum: Added.
• platform/qt/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png: Added.
• platform/qt/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt: Added. (introduced in r72518)
• platform/qt/svg/custom/image-rescale-expected.checksum: Added.
• platform/qt/svg/custom/image-rescale-expected.png: Added.
• platform/qt/svg/custom/image-rescale-expected.txt: Added. (introduced in r72470)
• platform/qt/svg/custom/image-rescale-scroll-expected.checksum: Added.
• platform/qt/svg/custom/image-rescale-scroll-expected.png: Added.
• platform/qt/svg/custom/image-rescale-scroll-expected.txt: Added. (introduced in r72470)
• platform/qt/svg/dom/SVGPathSegList-cloning-expected.checksum: Added.
• platform/qt/svg/dom/SVGPathSegList-cloning-expected.png: Added.
• platform/qt/svg/dom/SVGPathSegList-cloning-expected.txt: Added. (introduced in r72381)
• platform/qt/svg/dom/SVGPathSegList-segment-modification-expected.checksum: Added.
• platform/qt/svg/dom/SVGPathSegList-segment-modification-expected.png: Added.
• platform/qt/svg/dom/SVGPathSegList-segment-modification-expected.txt: Added. (introduced in r72381)
• platform/qt/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.checksum: Added.
• platform/qt/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.png: Added.
• platform/qt/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.txt: Added. (introduced in r72381)

5:49 AM Changeset in webkit [72522] by yael.aharon@nokia.com

• 17 edits in trunk

Spatial Navigation: issues with the node selection algorithm.
​https://bugs.webkit.org/show_bug.cgi?id=49382

Patch by Yael Aharon <​yael.aharon@nokia.com>, Chang Shu <​chang.shu@nokia.com> on 2010-11-22
Reviewed by Antonio Gomes.

WebCore:

Modify the Spatial Navigation algorithm, to better handle initial focus and
navigation between frames.
The new algorithm takes the rect of the focused node as the startingRect,
instead of the node itself. That allows us to construct a virtual rect if
there is no focused node, or if it is off the screen.
The virtual rect is the edge of the container in the direction of the navigation.

With this patch, scrollable containers and frames will scroll regardless of weather
they have focusable content. Users will be able to use arrow keys to view all the
content of such a container. The only exception is if the container has style overflow:hidden.
We will not scroll in that case.

With this patch, we handle z-index and positioning so that if there are 2 overlapping focusable nodes,
we do a hit test and only the node on top can get focus.

hasOffScreenRect() was modified so that it can check if a node will be off-screen even after we scrolled
its parent container. We do not add the scrolling conditions for containers that have overflow:hidden
and cannot scroll.

calculateScrollbarModesForLayout is used to decide if a frame can scroll or not. We cannot rely on
the exsistance of the scrollbar, because it could be removed via the API, while the frame is still
allowed to scroll.

• page/FocusController.cpp:

(WebCore::updateFocusCandidateIfNeeded):
(WebCore::FocusController::findFocusCandidateInContainer):
(WebCore::FocusController::advanceFocusDirectionallyInContainer):
(WebCore::FocusController::advanceFocusDirectionally):

• page/FocusController.h:
• page/FrameView.h:
• page/SpatialNavigation.cpp:

(WebCore::FocusCandidate::FocusCandidate):
(WebCore::distanceDataForNode):
(WebCore::alignmentForRects):
(WebCore::areRectsMoreThanFullScreenApart):
(WebCore::isRectInDirection):
(WebCore::hasOffscreenRect):
(WebCore::scrollInDirection):
(WebCore::isScrollableContainerNode):
(WebCore::scrollableEnclosingBoxOrParentFrameForNodeInDirection):
(WebCore::canScrollInDirection):
(WebCore::rectToAbsoluteCoordinates):
(WebCore::nodeRectInAbsoluteCoordinates):
(WebCore::frameRectInAbsoluteCoordinates):
(WebCore::entryAndExitPointsForDirection):
(WebCore::canBeScrolledIntoView):
(WebCore::virtualRectForDirection):

• page/SpatialNavigation.h:

LayoutTests:

Replaced text in tests with images with fixed size to make them more cross platform and modified
test results to reflect that we can scroll container that do not include focusable content.

• fast/events/spatial-navigation/snav-clipped-overflowed-content-expected.txt:
• fast/events/spatial-navigation/snav-clipped-overflowed-content.html:
• fast/events/spatial-navigation/snav-div-scrollable-but-without-focusable-content-expected.txt:
• fast/events/spatial-navigation/snav-div-scrollable-but-without-focusable-content.html:
• fast/events/spatial-navigation/snav-iframe-no-focusable-content-expected.txt:
• fast/events/spatial-navigation/snav-iframe-no-focusable-content.html:
• fast/events/spatial-navigation/snav-iframe-no-scrollable-content-expected.txt:
• fast/events/spatial-navigation/snav-iframe-no-scrollable-content.html:
• fast/events/spatial-navigation/snav-iframe-with-offscreen-focusable-element-expected.txt:
• fast/events/spatial-navigation/snav-iframe-with-offscreen-focusable-element.html:

5:29 AM Changeset in webkit [72521] by antonm@chromium.org

• 2 edits in trunk/LayoutTests

Amending suppressions from previous commit.

• platform/chromium/test_expectations.txt:

5:25 AM Changeset in webkit [72520] by antonm@chromium.org

• 2 edits in trunk/LayoutTests

Not reviewed. Adding new suppressions after ​http://trac.webkit.org/changeset/72518

• platform/chromium/test_expectations.txt:

4:53 AM Changeset in webkit [72519] by antonm@chromium.org

• 3 edits
  10 adds in trunk/LayoutTests

Not reviewed. Next batch of SVG rebaselines.

• platform/chromium-linux/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum: Added.
• platform/chromium-linux/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Added.
• platform/chromium-linux/svg/dom/SVGPathSegList-cloning-expected.checksum: Added.
• platform/chromium-linux/svg/dom/SVGPathSegList-cloning-expected.png: Added.
• platform/chromium-win/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum: Added.
• platform/chromium-win/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Added.
• platform/chromium-win/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Added.
• platform/chromium-win/svg/custom/svg-curve-with-relative-cordinates-expected.txt:
• platform/chromium-win/svg/dom/SVGPathSegList-cloning-expected.checksum: Added.
• platform/chromium-win/svg/dom/SVGPathSegList-cloning-expected.png: Added.
• platform/chromium-win/svg/dom/SVGPathSegList-cloning-expected.txt: Added.
• platform/chromium/test_expectations.txt:

4:32 AM Changeset in webkit [72518] by commit-queue@webkit.org

• 56 edits
  20 adds in trunk

2010-11-22 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Fix various problems with the SVG*List code
​https://bugs.webkit.org/show_bug.cgi?id=49880

Add tests for all SVG*List types, that were missing.
Add SVG 1.1 2nd edition testcase, types-dom-07-f.svg, testing that all animVal values are readonly.

• platform/mac-leopard/svg/custom/baseval-animval-equality-expected.checksum:
• platform/mac-leopard/svg/custom/baseval-animval-equality-expected.png:
• platform/mac-leopard/svg/dom/SVGLengthList-basics-expected.checksum:
• platform/mac-leopard/svg/dom/SVGLengthList-basics-expected.png:
• platform/mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum: Added.
• platform/mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png: Added.
• platform/mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt: Added.
• platform/mac/svg/custom/baseval-animval-equality-expected.txt:
• platform/mac/svg/dom/SVGNumberList-basics-expected.checksum: Added.
• platform/mac/svg/dom/SVGNumberList-basics-expected.png: Added.
• platform/mac/svg/dom/SVGPointList-basics-expected.checksum: Added.
• platform/mac/svg/dom/SVGPointList-basics-expected.png: Added.
• platform/mac/svg/dom/SVGStringList-basics-expected.checksum: Added.
• platform/mac/svg/dom/SVGStringList-basics-expected.png: Added.
• platform/mac/svg/dom/SVGTransformList-basics-expected.checksum: Added.
• platform/mac/svg/dom/SVGTransformList-basics-expected.png: Added.
• svg/W3C-SVG-1.1-SE/types-dom-07-f.svg: Added.
• svg/custom/baseval-animval-equality.svg: Fix wrong test.
• svg/custom/polyline-points-crash-expected.txt:
• svg/dom/SVGLengthList-basics-expected.txt:
• svg/dom/SVGLengthList-basics.xhtml: Extended test, synchronized with the other SVG*List tests.
• svg/dom/SVGNumberList-basics-expected.txt: Added.
• svg/dom/SVGNumberList-basics.xhtml: Added.
• svg/dom/SVGPointList-basics-expected.txt: Added.
• svg/dom/SVGPointList-basics.xhtml: Added.
• svg/dom/SVGStringList-basics-expected.txt: Added.
• svg/dom/SVGStringList-basics.xhtml: Added.
• svg/dom/SVGTransformList-basics-expected.txt: Added.
• svg/dom/SVGTransformList-basics.xhtml: Added.
• svg/dom/svglist-exception-on-out-bounds-error-expected.txt:

2010-11-22 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Fix various problems with the SVG*List code
​https://bugs.webkit.org/show_bug.cgi?id=49880

Write tests for SVGNumberList/SVGPointList/SVGStringList/SVGTransformList and extend SVGLengthList tests.
SVG DOM <-> XML DOM synchronization is now tested for all these types, and works great. Unify the string format produced
by the various valueAsString() functions for maximum compatibility with Firefox / Opera.

• Build a real transform string for SVGTransformList, instead of dumping the elements of the concatted matrix.
• Add SVGStringList XML dom synchronization, only affects SVGTests requiredFeatures/requiredExtensions/systemLanguage.
• Make all animVal properties readonly, tested by types-dom-07-f.svg (from SVG 1.1 2nd edition).
• Enable StrictTypeChecking/RequiresAllArguments=Raise for all SVGList types.

Tests: svg/W3C-SVG-1.1-SE/types-dom-07-f.svg

svg/dom/SVGNumberList-basics.xhtml
svg/dom/SVGPointList-basics.xhtml
svg/dom/SVGStringList-basics.xhtml
svg/dom/SVGTransformList-basics.xhtml

• bindings/js/JSSVGLengthCustom.cpp: (WebCore::JSSVGLength::setValue): Throw NO_MODIFICATION_ALLOWED_ERR when the SVGPropertyTearOffs role is AnimValRole. (WebCore::JSSVGLength::convertToSpecifiedUnits): Ditto.
• bindings/scripts/CodeGeneratorJS.pm: Ditto.
• bindings/scripts/CodeGeneratorObjC.pm: Ditto.
• bindings/scripts/CodeGeneratorV8.pm: Ditto.
• bindings/v8/custom/V8SVGLengthCustom.cpp: (WebCore::V8SVGLength::valueAccessorSetter): Ditto. (WebCore::V8SVGLength::convertToSpecifiedUnitsCallback): Ditto.
• svg/SVGAElement.cpp: (WebCore::SVGAElement::synchronizeProperty): Also synchronize the SVGTests SVGStringLists.
• svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::synchronizeProperty): Ditto.
• svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::synchronizeProperty): Ditto.
• svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::synchronizeProperty): Ditto.
• svg/SVGCursorElement.cpp: (WebCore::SVGCursorElement::synchronizeProperty): Ditto.
• svg/SVGDefsElement.cpp: (WebCore::SVGDefsElement::synchronizeProperty): Ditto.
• svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::synchronizeProperty): Ditto.
• svg/SVGForeignObjectElement.cpp: (WebCore::SVGForeignObjectElement::synchronizeProperty): Ditto.
• svg/SVGGElement.cpp: (WebCore::SVGGElement::synchronizeProperty): Ditto.
• svg/SVGImageElement.cpp: (WebCore::SVGImageElement::synchronizeProperty): Ditto.
• svg/SVGLengthList.cpp: (WebCore::SVGLengthList::valueAsString): Use ' ' instead of ',' as seperator.
• svg/SVGLengthList.idl: Enable StrictTypeChecking, RequiresAllArguments=Raise.
• svg/SVGLineElement.cpp: (WebCore::SVGLineElement::synchronizeProperty): Also synchronize the SVGTests SVGStringLists.
• svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::synchronizeProperty): Ditto.
• svg/SVGNumberList.cpp: (WebCore::SVGNumberList::valueAsString): Use ' ' instead of ',' as seperator.
• svg/SVGNumberList.idl: Enable StrictTypeChecking, RequiresAllArguments=Raise.
• svg/SVGPathElement.cpp: (WebCore::SVGPathElement::synchronizeProperty): Also synchronize the SVGTests SVGStringLists.
• svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::synchronizeProperty): Ditto.
• svg/SVGPointList.idl: Enable StrictTypeChecking, RequiresAllArguments=Raise.
• svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::synchronizeProperty): Also synchronize the SVGTests SVGStringLists.
• svg/SVGRectElement.cpp: (WebCore::SVGRectElement::synchronizeProperty): Ditto.
• svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::synchronizeProperty): Ditto.
• svg/SVGStringList.cpp: (WebCore::SVGStringList::valueAsString): Add valueAsString() implementation, necessary for SVG DOM <-> XML DOM synchronization.
• svg/SVGStringList.h:
• svg/SVGStringList.idl: Enable StrictTypeChecking, RequiresAllArguments=Raise.
• svg/SVGSwitchElement.cpp: (WebCore::SVGSwitchElement::synchronizeProperty): Also synchronize the SVGTests SVGStringLists.
• svg/SVGTests.cpp: Rewrite, similar to SVGPolyElement, to synchronize the requiredFeatures/requiredExtension/systemLanguage SVGStringLists with their XML DOM attributes. (WebCore::SVGTests::SVGTests): (WebCore::SVGTests::isValid): (WebCore::SVGTests::parseMappedAttribute): (WebCore::SVGTests::isKnownAttribute): (WebCore::SVGTests::handleAttributeChange): (WebCore::SVGTests::synchronizeProperties): To be called by all classes inheriting from SVGTests, in their synchronizeProperty() methods. (WebCore::SVGTests::synchronizeRequiredFeatures): (WebCore::SVGTests::synchronizeRequiredExtensions): (WebCore::SVGTests::synchronizeSystemLanguage): (WebCore::SVGTests::requiredFeatures): (WebCore::SVGTests::requiredExtensions): (WebCore::SVGTests::systemLanguage):
• svg/SVGTests.h:
• svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::synchronizeProperty): Also synchronize the SVGTests SVGStringLists.
• svg/SVGTransform.cpp: (WebCore::SVGTransform::valueAsString): Added a proper way to serialize a SVGTransform into a String.
• svg/SVGTransform.h:
• svg/SVGTransformList.cpp: (WebCore::SVGTransformList::valueAsString): Rewrite, to build a real transform list string, instead of dumping the concatted matrix.
• svg/SVGUseElement.cpp: (WebCore::SVGUseElement::synchronizeProperty): Also synchronize the SVGTests SVGStringLists.
• svg/properties/SVGListProperty.h: s/TYPE_MISMATCH_ERR/SVGException::SVG_WRONG_TYPE_ERR/ for compatibility with Firefox. (WebCore::SVGListProperty::initializeValuesAndWrappers): (WebCore::SVGListProperty::insertItemBeforeValuesAndWrappers): (WebCore::SVGListProperty::replaceItemValues): (WebCore::SVGListProperty::replaceItemValuesAndWrappers): (WebCore::SVGListProperty::removeItemValuesAndWrappers): Handle corner case, the item passed to removeItem() was the only on in the list, list is empty now, nothing to replace. (WebCore::SVGListProperty::appendItemValuesAndWrappers): (WebCore::SVGListProperty::role): Expose the role of this list property.
• svg/properties/SVGPathSegListPropertyTearOff.h: s/TYPE_MISMATCH_ERR/SVGException::SVG_WRONG_TYPE_ERR/ for compatibility with Firefox. (WebCore::SVGPathSegListPropertyTearOff::initialize): (WebCore::SVGPathSegListPropertyTearOff::insertItemBefore): (WebCore::SVGPathSegListPropertyTearOff::replaceItem): (WebCore::SVGPathSegListPropertyTearOff::appendItem):
• svg/properties/SVGProperty.h: Add new virtual SVGPropertyRole role() accessor.
• svg/properties/SVGPropertyTearOff.h: (WebCore::SVGPropertyTearOff::create): Store the passed in SVGProperyRole, instead of ignoring it. (WebCore::SVGPropertyTearOff::role): (WebCore::SVGPropertyTearOff::SVGPropertyTearOff):
• svg/properties/SVGStaticPropertyTearOff.h: (WebCore::SVGStaticPropertyTearOff::SVGStaticPropertyTearOff): Pass UndefinedRole as default role to SVGPropertyTearOff.
• svg/properties/SVGStaticPropertyWithParentTearOff.h: Ditto. (WebCore::SVGStaticPropertyWithParentTearOff::SVGStaticPropertyWithParentTearOff):

4:11 AM Changeset in webkit [72517] by antonm@chromium.org

• 2 edits
  5 adds in trunk/LayoutTests

Not reviewed. Rebaselining fast/images/imagemap-focus-ring-zoom.html for Chromium on Win and Linux.

• platform/chromium-linux/fast/images/imagemap-focus-ring-zoom-expected.checksum: Added.
• platform/chromium-linux/fast/images/imagemap-focus-ring-zoom-expected.png: Added.
• platform/chromium-win/fast/images/imagemap-focus-ring-zoom-expected.checksum: Added.
• platform/chromium-win/fast/images/imagemap-focus-ring-zoom-expected.png: Added.
• platform/chromium-win/fast/images/imagemap-focus-ring-zoom-expected.txt: Added.
• platform/chromium/test_expectations.txt:

4:02 AM Changeset in webkit [72516] by antonm@chromium.org

• 2 edits
  2 adds in trunk/LayoutTests

Not reviewed. Rebaselining svg/custom/image-rescale.svg for Chromium on Mac.

• platform/chromium-mac/svg/custom/image-rescale-expected.checksum: Added.
• platform/chromium-mac/svg/custom/image-rescale-expected.png: Added.
• platform/chromium/test_expectations.txt:

3:57 AM Changeset in webkit [72515] by antonm@chromium.org

• 2 edits in trunk/LayoutTests

Not reviewed, removing suppression for now passing editing/selection/5354455-1.html (on Win)

• platform/chromium/test_expectations.txt:

2:53 AM Changeset in webkit [72514] by antonm@chromium.org

• 2 edits in trunk/LayoutTests

Not reviewed, proper platform for international test.

• platform/chromium/test_expectations.txt:

2:51 AM Changeset in webkit [72513] by antonm@chromium.org

• 2 edits in trunk/LayoutTests

Not reviewed, Chromium suppressions for a bunch of SVG tests and one international.

• platform/chromium/test_expectations.txt:

2:26 AM Changeset in webkit [72512] by antonm@chromium.org

• 2 edits in trunk/LayoutTests

Not reviewed, temporary suppressing fast/css/font-face-data-uri.html for Chromium.

• platform/chromium/test_expectations.txt:

2:22 AM Changeset in webkit [72511] by pfeldman@chromium.org

• 2 edits in trunk/WebKit/chromium

2010-11-22 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Partially roll out r72282.
It should not have modified devtools files.

• src/js/devTools.css:

1:59 AM Changeset in webkit [72510] by commit-queue@webkit.org

• 3 edits in trunk/WebKit/qt

2010-11-22 Jan Erik Hanssen <​jhanssen@sencha.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QWebElement::appendInside() doesn't work on head elements
​https://bugs.webkit.org/show_bug.cgi?id=49166

Make QWebElement::appendInside() call
Element::deprecatedCreateContextualFragment(), bypassing the check for
the HEAD tag in the HTMLElement implementation of this function.

• Api/qwebelement.cpp: (QWebElement::appendInside):
• tests/qwebelement/tst_qwebelement.cpp: (tst_QWebElement::addElementToHead):

1:58 AM Changeset in webkit [72509] by antonm@chromium.org

• 2 edits in trunk/LayoutTests

Not reviewed. Suppressing fast/canvas/canvas-fillPath-shadow.html for Chromium-gpu.

• platform/chromium-gpu/test_expectations.txt:

1:53 AM Changeset in webkit [72508] by antonm@chromium.org

• 2 edits in trunk/LayoutTests

Not reviewed, remove duplicate suppression.

• platform/chromium/test_expectations.txt:

1:30 AM Changeset in webkit [72507] by antonm@chromium.org

• 2 edits in trunk/LayoutTests

Not reviewed. Suppressing fast/canvas/canvas-fillPath-shadow.html for Chromium.

• platform/chromium/test_expectations.txt:

1:27 AM Changeset in webkit [72506] by commit-queue@webkit.org

• 2 edits in trunk/WebKitTools

2010-11-22 João Paulo Rechi Vita <​jprvita@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Fix EWebLauncher zoom discretization
​https://bugs.webkit.org/show_bug.cgi?id=49810

• EWebLauncher/main.c: (nearest_zoom_level_get): (zoom_level_set): (on_load_finished): (on_key_down):

1:26 AM Changeset in webkit [72505] by antonm@chromium.org

• 1 edit
  2 adds in trunk/LayoutTests

Not reviewed. Rebaselining fast/js/regexp-overflow.html expectations
for Chromium after ​http://trac.webkit.org/changeset/72489

• platform/chromium-mac/fast/js/regexp-overflow-expected.txt: Added.
• platform/chromium-win/fast/js/regexp-overflow-expected.txt: Added.

12:41 AM Changeset in webkit [72504] by yuzo@google.com

• 3 edits
  2 adds in trunk

2010-11-22 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Dan Bernstein.

Fix for Bug 49374 - Web Font specified with base64 data URI ending with EOT is not rendered.
​https://bugs.webkit.org/show_bug.cgi?id=49374

• fast/css/font-face-data-uri-expected.txt: Added.
• fast/css/font-face-data-uri.html: Added.

2010-11-22 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Dan Bernstein.

Fix for Bug 49374 - Web Font specified with base64 data URI ending with EOT is not rendered.
​https://bugs.webkit.org/show_bug.cgi?id=49374

Test: fast/css/font-face-data-uri.html

• css/CSSFontFaceSrcValue.cpp: (WebCore::CSSFontFaceSrcValue::isSupportedFormat): Do not check "file extension" for data URI. For other URI, check against ".eot" rather than "eot".

Nov 21, 2010:

7:03 PM Changeset in webkit [72503] by weinig@apple.com

• 2 edits in trunk/LayoutTests

Update WebKit2 skipped list.

• platform/mac-wk2/Skipped:

6:16 PM Changeset in webkit [72502] by weinig@apple.com

• 2 edits in trunk/WebKitTools

Fix ~300 WebKit2 tests by enabling developer extras preference.

Rubber-stamped by Dan Bernstein.

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

6:08 PM Changeset in webkit [72501] by weinig@apple.com

• 12 edits
  1 add in trunk

Textareas should be resizable by default
​https://bugs.webkit.org/show_bug.cgi?id=49892

Reviewed by Dan Bernstein.

WebKit2:

Test: WebKit2/WKPreferences

• Shared/WebPreferencesStore.cpp:

(WebKit::WebPreferencesStore::WebPreferencesStore):
(WebKit::WebPreferencesStore::encode):
(WebKit::WebPreferencesStore::decode):

• Shared/WebPreferencesStore.h:

Add textAreasAreResizable bit.

• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetJavaEnabled):
(WKPreferencesGetJavaEnabled):
Fix typo, WKPRe... -> WKPre...

(WKPreferencesSetMinimumFontSize):
(WKPreferencesGetMinimumFontSize):
Fix comment to correctly reflect that the default minimumFontSize is 0, not 1.

(WKPreferencesSetTextAreasAreResizable):
(WKPreferencesGetTextAreasAreResizable):

• UIProcess/API/C/WKPreferences.h:

Add API.

• UIProcess/API/C/WKPreferencesPrivate.h:

Don't use PLATFORM in API headers.

• UIProcess/WebPreferences.cpp:

(WebKit::WebPreferences::setTextAreasAreResizable):
(WebKit::WebPreferences::textAreasAreResizable):

• UIProcess/WebPreferences.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):
Pipe bit through to the WebProcess and onto WebCore::Settings.

WebKitTools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp: Added.
• TestWebKitAPI/win/TestWebKitAPI.vcproj:

Add preferences test.

4:10 PM Changeset in webkit [72500] by Patrick Gansterer

• 25 edits in trunk/WebCore

2010-11-21 Patrick Gansterer <Patrick Gansterer>

Reviewed by Csaba Osztrogonác.

Use WTF_ARRAY_LENGTH in WebCore directory
​https://bugs.webkit.org/show_bug.cgi?id=49882

• accessibility/AccessibilityObject.cpp: (WebCore::createARIARoleMap):
• bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::JSDOMWindowBase):
• bindings/scripts/CodeGeneratorV8.pm:
• bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::ConfigureV8TestObjTemplate):
• css/CSSComputedStyleDeclaration.cpp:
• css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
• css/CSSParser.cpp: (WebCore::CSSParser::parseAnimationShorthand): (WebCore::CSSParser::parseTransitionShorthand):
• css/CSSPropertyLonghand.cpp: (WebCore::initShorthandMap):
• dom/ExceptionCode.cpp: (WebCore::getExceptionCodeDescription):
• editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement):
• editing/EditingStyle.cpp:
• editing/Editor.cpp: (WebCore::triStateOfStyle):
• editing/EditorCommand.cpp: (WebCore::createCommandMap):
• editing/MarkupAccumulator.cpp: (WebCore::appendCharactersReplacingEntities):
• html/canvas/WebGLBuffer.cpp: (WebCore::WebGLBuffer::getCachedMaxIndex): (WebCore::WebGLBuffer::setCachedMaxIndex):
• loader/FTPDirectoryParser.cpp: (WebCore::parseOneFTPLine):
• mathml/RenderMathMLOperator.cpp: (WebCore::RenderMathMLOperator::updateFromElement):
• page/animation/AnimationBase.cpp: (WebCore::addShorthandProperties):
• rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::hasValidAvgCharWidth):
• rendering/break_lines.cpp:
• svg/SVGTransformable.cpp: (WebCore::parseAndSkipType):
• svg/SVGViewSpec.cpp: (WebCore::SVGViewSpec::parseViewSpec):
• svg/SVGZoomAndPan.cpp: (WebCore::SVGZoomAndPan::parseZoomAndPan):
• xml/XPathFunctions.cpp: (WebCore::XPath::createFunctionMap):

3:03 PM Changeset in webkit [72499] by mario@webkit.org

• 8 edits in trunk

2010-11-21 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Chris Fleizach.

[GTK] Implement ROLE_COMBO_BOX
​https://bugs.webkit.org/show_bug.cgi?id=25678

Implement the remaining bits for combo boxes.

This patch finishes the implementation, from the point of view of
the Atk library, of those objects exposed to ATK as combo boxes,
and their related elements (menus and menu items). It therefore
implements the proper interfaces for each type of object related
to combo boxes (AtkSelection for the combo box, AtkText for every
menu item and AtkAction for the combo box, the menu and the menu
items), takes care of emitting the proper signals when focus or a
given a selection changes and adds a new unit test to check all
this new stuff.

Make possible to ask an AccessibleMenuListOption for a sensible
string representation, so far only available through the private
and MSAA related method nameForMSAA. Just moved the implementation
of that method to an overriden version of stringValue(), which is
platform independent, and called that from nameForMSAA().

• accessibility/AccessibilityMenuListOption.h:
• accessibility/AccessibilityMenuListOption.cpp: (WebCore::AccessibilityMenuListOption::nameForMSAA): Just call to stringValue(), which holds from now on that used to be here. (WebCore::AccessibilityMenuListOption::stringValue): New, override of AccessibilityObject::stringValue() to return a proper string.

Emit the missing signals when a selection is made.

• accessibility/gtk/AXObjectCacheAtk.cpp: (WebCore::AXObjectCache::postPlatformNotification): Emit the usual 'focus' signals when a selection is made over the combo box.

• accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (setAtkStateSetFromCoreObject): Ensure the EXPANDABLE and EXPANDED Atk states are added to the state set when needed. (listObjectForSelection): New, returns the proper list object (the one holding the list of available options as its children) for an specific AtkObject implementing AtkSelection. This is needed because sometimes the selectable options are not directly children of the AtkSelection object (i.e. a combo box has a 'menu' object as its only child of it, holding the list of options as children). (optionFromList): Use listObjectForSelection() to get the actual object holding the list of children as the available options. (optionFromSelection): Add support for combo boxes. (webkit_accessible_selection_add_selection): Ditto. (webkit_accessible_selection_clear_selection): Ditto. (webkit_accessible_selection_get_selection_count): Ditto. (webkit_accessible_selection_is_child_selected): Ditto. (webkit_accessible_selection_remove_selection): Ditto. (webkit_accessible_text_get_text): Makes sure stringValue() is considered to get the result substring when it was already considered when checking the maximum text length for the object. (getInterfaceMaskFromObject): Make sure the AtkSelection interface is implemented for the combo boxes, that the AtkText is implemented for the menu items and that the AtkAction interface is now implemented for every object (WebCore will decide what to do).

Avoid a segfault crash when using this from unit tests.

• platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenuGtk::show): Make sure we got a valid GdkWindow before calling gdk_window_get_origin() over it.

2010-11-21 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Chris Fleizach.

[GTK] Implement ROLE_COMBO_BOX
​https://bugs.webkit.org/show_bug.cgi?id=25678

New test to check the implementation of the combo boxes.

• tests/testatk.c: (testWebkitAtkComboBox): New test, checking that the roles and the implemented interfaces for a combo box and its descendants work. (main): Added the new unit test.

9:09 AM Changeset in webkit [72498] by Patrick Gansterer

• 19 edits in trunk/WebCore

2010-11-21 Patrick Gansterer <Patrick Gansterer>

Reviewed by Csaba Osztrogonác.

Use WTF_ARRAY_LENGTH in WebCore/platform directory
​https://bugs.webkit.org/show_bug.cgi?id=49881

• platform/KURL.cpp: (WebCore::portAllowed):
• platform/KURLGoogle.cpp: (WebCore::portAllowed):
• platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedImageMIMETypes): (WebCore::initializeSupportedJavaScriptMIMETypes): (WebCore::initializeSupportedNonImageMimeTypes):
• platform/UUID.cpp: (WebCore::createCanonicalUUIDString):
• platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::applyEdjeStateFromForm):
• platform/graphics/GraphicsTypes.cpp:
• platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::FontCodepage::if):
• platform/graphics/chromium/FontUtilsChromiumWin.cpp:
• platform/graphics/mac/ComplexTextControllerCoreText.cpp: (WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):
• platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::disableComponentsOnce):
• platform/graphics/mac/SimpleFontDataATSUI.mm: (WebCore::SimpleFontData::checkShapesArabic):
• platform/graphics/mac/SimpleFontDataCoreText.cpp: (WebCore::SimpleFontData::getCFStringAttributes):
• platform/graphics/win/GraphicsContextCGWin.cpp: (WebCore::GraphicsContext::drawLineForTextChecking):
• platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: (WebCore::disableComponentsOnce):
• platform/graphics/win/QTMovie.cpp: (QTMovie::load):
• platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::createStreams):
• platform/text/TextEncodingRegistry.cpp: (WebCore::pruneBlacklistedCodecs):
• platform/text/transcoder/FontTranscoder.cpp: (WebCore::FontTranscoder::FontTranscoder):

5:11 AM Changeset in webkit [72497] by Patrick Gansterer

• 3 edits in trunk/LayoutTests

2010-11-21 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Add test for unicode plane 1 characters
​https://bugs.webkit.org/show_bug.cgi?id=49581

• fast/encoding/xml-utf-8-default-expected.txt:
• fast/encoding/xml-utf-8-default.xml: