Timeline
Nov 25, 2010:
- 10:47 PM Changeset in webkit [72752] by
-
- 2 edits in trunk/LayoutTests
2010-11-25 Yuzo Fujishima <yuzo@google.com>
Unreviewed Chromium test expectaion change.
fast/css/font-face-data-uri.html now passes for WIN and LINUX.
- platform/chromium/test_expectations.txt:
- 9:37 PM Changeset in webkit [72751] by
-
- 2 edits in trunk/LayoutTests
2010-11-25 Yuzo Fujishima <yuzo@google.com>
Unreviewed attempt to fix test falkiness.
- fast/css/font-face-data-uri.html:
- 8:54 PM Changeset in webkit [72750] by
-
- 3 edits3 adds in trunk
2010-11-25 Kenichi Ishibashi <bashi@google.com>
Reviewed by Kent Tamura.
Assertion failure by resetting <output> twice
https://bugs.webkit.org/show_bug.cgi?id=50095
Adds a test that ensures assertion failures don't occur when
updating the value of an output element.
- fast/forms/output-reset-assertion-failed-expected.txt: Added.
- fast/forms/output-reset-assertion-failed.html: Added.
- fast/forms/script-tests/output-reset-assertion-failed.js: Added.
2010-11-25 Kenichi Ishibashi <bashi@google.com>
Reviewed by Kent Tamura.
Assertion failure by resetting <output> twice
https://bugs.webkit.org/show_bug.cgi?id=50095
Don't call setTextContentInternal() when the value wouldn't
be changed.
Test: fast/forms/output-reset-assertion-failed.html
- html/HTMLOutputElement.cpp: (WebCore::HTMLOutputElement::HTMLOutputElement): Calls setTextContentInternal() if and only if needed. (WebCore::HTMLOutputElement::reset): Ditto. (WebCore::HTMLOutputElement::setValue): Ditto. (WebCore::HTMLOutputElement::setDefaultValue): Ditto.
- 7:52 PM Changeset in webkit [72749] by
-
- 2 edits in trunk/LayoutTests
2010-11-25 Yuzo Fujishima <yuzo@google.com>
Reviewed by Kent Tamura.
Fix for Bug 49898 - LayoutTests/fast/css/font-face-data-uri.html doesn't test what it claims to
https://bugs.webkit.org/show_bug.cgi?id=49898
- fast/css/font-face-data-uri.html: Use local font as reference. Use polling to ensure that the web font is loaded.
- 6:02 PM WinCE edited by
- (diff)
- 4:36 PM Changeset in webkit [72748] by
-
- 3 edits2 adds in trunk
2010-11-24 Ryosuke Niwa <rniwa@webkit.org>
Crash when moving caret around a word with a first-letter rule and whitespace is not collapsible.
https://bugs.webkit.org/show_bug.cgi?id=49652
Fixed the crash by giving the correct end offset to emitText in handleTextNode.
This patch does not fix a bug in TextIterator that incorrectly calculates
the end offset of a word with a first-letter rule as demonstrated in the layout test
because fixing the bug requires an overhaul of TextIterator and new behavior is consistent
with the case when whitespace is collapsible.
Test: editing/text-iterator/first-letter-word-boundary.html
- editing/TextIterator.cpp: (WebCore::TextIterator::handleTextNode):
2010-11-24 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
Added a test to ensure WebKit does not crash when moving carets around a word
with a first-letter rule. While WebKit no longer crashes, the test demonstrates a bug
that the position offset at the end of word is incorrect.
- editing/text-iterator/first-letter-word-boundary-expected.txt: Added.
- editing/text-iterator/first-letter-word-boundary.html: Added.
- 4:22 PM Changeset in webkit [72747] by
-
- 4 edits in trunk/WebCore
2010-11-25 Mike Lawther <mikelawther@chromium.org>
Reviewed by Kent Tamura.
Fix typos in CSS grammar (HERZ -> HERTZ)
https://bugs.webkit.org/show_bug.cgi?id=50094
- css/CSSGrammar.y:
- css/CSSParser.cpp: (WebCore::CSSParser::lex):
- css/tokenizer.flex:
- 12:40 PM Changeset in webkit [72746] by
-
- 4 edits in trunk
2010-11-25 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed. Enable test for Win Release chromuim.
- platform/chromium/test_expectations.txt: changed: BUGWK46940 WIN DEBUG : fast/dom/Window/window-screen-properties.html = TEXT
2010-11-25 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed. Roll chromium 67004:67404.
- DEPS:
- 12:33 PM Changeset in webkit [72745] by
-
- 2 edits in trunk/WebKit/gtk
2010-11-25 Antonio Gomes <agomes@rim.com>
Unreviewed build fix for GTK+ when --release and -no-video are passed to build-webkit
Build problem with --gtk --no-video
https://bugs.webkit.org/show_bug.cgi?id=50003
Patch suggested by Philippe Normand <pnormand@igalia.com>.
- WebCoreSupport/ChromeClientGtk.cpp:
- webkit/webkitprivate.cpp:
- 12:31 PM Changeset in webkit [72744] by
-
- 4 edits in trunk
Revertted accidentally committed code in r72742
- 12:29 PM Changeset in webkit [72743] by
-
- 6 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=50078
Simplify CachedResource error handling code by getting rid of the m_httpStatusCodeErrorOccurred boolean.
Reviewed by Dan Bernstein.
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::CachedImage):
- loader/cache/CachedImage.h:
(WebCore::CachedImage::shouldIgnoreHTTPStatusCodeErrors):
- loader/cache/CachedResource.h:
(WebCore::CachedResource::shouldIgnoreHTTPStatusCodeErrors):
(WebCore::CachedResource::httpStatusCodeErrorOccurred):
- loader/loader.cpp:
(WebCore::Loader::didReceiveData):
- 12:25 PM Changeset in webkit [72742] by
-
- 4 edits in trunk
martin
- 11:37 AM Changeset in webkit [72741] by
-
- 2 edits in trunk/WebCore
2010-11-25 Andreas Kling <kling@webkit.org>
Reviewed by Tor Arne Vestbø.
[Qt] Remove unnecessary save/restore in GraphicsContext::drawConvexPolygon()
https://bugs.webkit.org/show_bug.cgi?id=50085
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawConvexPolygon): Remember the previous antialiasing mode and reset it after we're done.
- 10:36 AM Changeset in webkit [72740] by
-
- 3 edits in trunk/WebCore
2010-11-25 Ben Murdoch <benm@google.com>
Reviewed by Steve Block.
Potential crash in JavaClassV8.cpp
https://bugs.webkit.org/show_bug.cgi?id=50016
It is possible that we attempt to free uninitialised
memory in the JavaClass destrctor when using V8 in the
case that the JVM could not find the class in the constructor.
It turns out that the troublesome m_name is not acutally
used anywhere, so we remove it in this patch.
No new tests, just removing dead code.
- bridge/jni/v8/JavaClassV8.cpp: Remove unused m_name.
- bridge/jni/v8/JavaClassV8.h: Ditto.
- 10:21 AM Changeset in webkit [72739] by
-
- 2 edits in trunk/WebKit/qt
2010-11-25 Norbert Leser <norbert.leser@nokia.com>
Reviewed by Laszlo Gombos.
Updated Symbian DEF file for ARM target due to API changes
via committs r72600-72603 (see bug# 46810)
- symbian/eabi/QtWebKitu.def:
- 10:18 AM Changeset in webkit [72738] by
-
- 8 edits in trunk
2010-11-25 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Better errors for not yet implemented features
https://bugs.webkit.org/show_bug.cgi?id=50075
Test that inserting a record where the key is a Date (either
explicitly, or via a key path) yields an error.
Test that calling createObjectStore with autoIncrement = true
raises an exception.
- storage/indexeddb/create-object-store-options-expected.txt:
- storage/indexeddb/create-object-store-options.html:
- storage/indexeddb/objectstore-basics-expected.txt:
- storage/indexeddb/objectstore-basics.html:
2010-11-25 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Better errors for not yet implemented features
https://bugs.webkit.org/show_bug.cgi?id=50075
Raise an exception if createObjectStore is called with autoIncrement
set to true.
Be a little bit more explicit in IDBBindingUtilities that we don't
allow using Date objects as keys yet.
- bindings/v8/IDBBindingUtilities.cpp: (WebCore::createIDBKeyFromValue):
- storage/IDBDatabase.cpp: (WebCore::IDBDatabase::createObjectStore):
- storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::putInternal):
- 10:01 AM Changeset in webkit [72737] by
-
- 7 edits in trunk/WebCore
2010-11-25 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: highlight diffs of revisions against base version.
https://bugs.webkit.org/show_bug.cgi?id=50088
- inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback): (WebInspector.CSSStyleModel.prototype._styleSheetChanged):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel): (WebInspector.ResourcesPanel.prototype.show): (WebInspector.ResourcesPanel.prototype._showResourceView.callback): (WebInspector.ResourcesPanel.prototype._showResourceView): (WebInspector.ResourcesPanel.prototype._applyDiffMarkup): (WebInspector.FrameResourceTreeElement.prototype._contentChanged):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.markDiff): (WebInspector.SourceFrame.prototype._createViewerIfNeeded): (WebInspector.SourceFrame.prototype._updateDiffDecorations.addDecorations): (WebInspector.SourceFrame.prototype._updateDiffDecorations): (WebInspector.SourceFrame.prototype._removeDiffDecorations):
- inspector/front-end/SourceView.js:
- inspector/front-end/textViewer.css: (.webkit-line-number): (.diff-container .webkit-added-line .webkit-line-content): (.diff-container .webkit-removed-line .webkit-line-content): (.diff-container .webkit-changed-line .webkit-line-content):
- inspector/front-end/utilities.js:
- 9:50 AM Changeset in webkit [72736] by
-
- 4 edits in trunk/WebCore
2010-11-25 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r72732.
http://trac.webkit.org/changeset/72732
https://bugs.webkit.org/show_bug.cgi?id=50089
Made Qt bot sad and crashy (Requested by Ossy on #webkit).
- platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
- platform/network/qt/QNetworkReplyHandler.h:
- platform/network/qt/ResourceHandleQt.cpp: (WebCore::WebCoreSynchronousLoader::didFinishLoading): (WebCore::WebCoreSynchronousLoader::didFail): (WebCore::ResourceHandle::loadResourceSynchronously):
- 9:17 AM Changeset in webkit [72735] by
-
- 2 edits in trunk/WebCore
2010-11-25 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r72734.
http://trac.webkit.org/changeset/72734
https://bugs.webkit.org/show_bug.cgi?id=50086
Backing out 72732 which made Qt sad and crashy (Requested by
kling on #webkit).
- platform/network/qt/ResourceHandleQt.cpp: (WebCore::ResourceHandle::loadResourceSynchronously):
- 8:51 AM Changeset in webkit [72734] by
-
- 2 edits in trunk/WebCore
2010-11-25 Andreas Kling <kling@webkit.org>
Unreviewed crash fix for Qt 4.6.x.
Check that QNetworkReplyHandler::reply() doesn't return null before
using it (this code needs to work for Qt 4.6 as well.)
- platform/network/qt/ResourceHandleQt.cpp: (WebCore::ResourceHandle::loadResourceSynchronously):
- 8:37 AM Changeset in webkit [72733] by
-
- 11 edits in trunk/WebCore
2010-11-25 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r72727.
http://trac.webkit.org/changeset/72727
https://bugs.webkit.org/show_bug.cgi?id=50084
Broke dom-breakpoints test on chromium win (Requested by
podivilov on #webkit).
- inspector/InspectorController.cpp: (WebCore::InspectorController::setNativeBreakpoint):
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::InspectorDOMAgent): (WebCore::InspectorDOMAgent::discardBindings): (WebCore::InspectorDOMAgent::setDOMBreakpoint): (WebCore::InspectorDOMAgent::removeDOMBreakpoint): (WebCore::InspectorDOMAgent::descriptionForDOMEvent): (WebCore::InspectorDOMAgent::removeBreakpointsForNode): (WebCore::InspectorDOMAgent::createBreakpointId):
- inspector/InspectorDOMAgent.h:
- inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.reset): (WebInspector.BreakpointManager.prototype.createDOMBreakpoint): (WebInspector.BreakpointManager.prototype._updateNativeBreakpointsInSettings): (WebInspector.BreakpointManager.prototype.restoreBreakpoints): (WebInspector.BreakpointManager.prototype.restoreDOMBreakpoints): (WebInspector.DOMBreakpoint): (WebInspector.DOMBreakpoint.prototype.populateLabelElement): (WebInspector.EventListenerBreakpoint): (WebInspector.XHRBreakpoint):
- inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane): (WebInspector.BreakpointsSidebarPane.prototype.reset): (WebInspector.EventListenerBreakpointsSidebarPane): (WebInspector.EventListenerBreakpointsSidebarPane.prototype.reset):
- inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent.prototype._setDocument):
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.reset):
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu.handlerFunction): (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.reset):
- inspector/front-end/inspector.js: (WebInspector.reset): (WebInspector.didCommitLoad):
- 8:19 AM Changeset in webkit [72732] by
-
- 4 edits in trunk/WebCore
2010-11-25 Peter Hartmann <peter.hartmann@nokia.com>
Reviewed by Andreas Kling.
[Qt] enable usage of synchronous HTTP feature in Qt
https://bugs.webkit.org/show_bug.cgi?id=37191
Currently, we spin an event loop when doing synchronous calls to
wait for completion. This patch uses synchronous requests in Qt,
if available, and spins the event loop as a fallback solution.
Patch by Simon Hausmann and Peter Hartmann.
- platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
- platform/network/qt/QNetworkReplyHandler.h:
- platform/network/qt/ResourceHandleQt.cpp: (WebCore::WebCoreSynchronousLoader::setReplyFinished): (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader): (WebCore::WebCoreSynchronousLoader::didFinishLoading): (WebCore::WebCoreSynchronousLoader::didFail): (WebCore::WebCoreSynchronousLoader::waitForCompletion): (WebCore::ResourceHandle::loadResourceSynchronously):
- 6:40 AM Changeset in webkit [72731] by
-
- 2 edits in trunk/WebCore
2010-11-25 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
V8 Bindings: remove faulty include in OptionsObject.h
https://bugs.webkit.org/show_bug.cgi?id=50073
There is no <wtf/NonCopyable.h>, and the code doesn't try to use it
either.
No new functionality, no new tests.
- bindings/v8/OptionsObject.h:
- 6:36 AM Changeset in webkit [72730] by
-
- 2 edits in trunk/WebCore
2010-11-25 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Simon Hausmann.
Actually handle targetDensityDpi in computeViewportAttributes
https://bugs.webkit.org/show_bug.cgi?id=50068
- dom/ViewportArguments.cpp: (WebCore::computeViewportAttributes):
- 6:11 AM Changeset in webkit [72729] by
-
- 2 edits in trunk/LayoutTests
2010-11-25 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed. Enable tests in chromium.
5109817.html was fixed upstream r72678.
validationMessage was fixed downstream r67382.
- platform/chromium/test_expectations.txt: removed: BUG10369 MAC : editing/selection/5109817.html = FAIL removed: BUG28264 : fast/forms/validationMessage.html = FAIL
- 6:05 AM Changeset in webkit [72728] by
-
- 24 edits1 copy4 adds in trunk
2010-11-25 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Add an OptionsObject class for IndexedDB (and later Geolocation)
https://bugs.webkit.org/show_bug.cgi?id=50030
- storage/indexeddb/create-object-store-options-expected.txt: Added.
- storage/indexeddb/create-object-store-options.html: Added.
- storage/indexeddb/tutorial.html:
2010-11-25 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Add an OptionsObject class for IndexedDB (and later Geolocation)
https://bugs.webkit.org/show_bug.cgi?id=50030
Geolocation and IndexedDB both have the concept of an optional
parameter that has various options supplied with it. In
Geolocation this was done with custom bindings, but I'm trying to
avoid that for IndexedDB.
This first patch implements it in V8 and makes createObjectStore use it.
The next patch will cover Geolocation and JSC.
Test: storage/indexeddb/create-object-store-options.html
- WebCore.gypi:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/scripts/test/CPP/WebDOMTestObj.cpp: (WebDOMTestObj::optionsObject):
- bindings/scripts/test/CPP/WebDOMTestObj.h:
- bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_options_object):
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::jsTestObjPrototypeFunctionOptionsObject):
- bindings/scripts/test/JS/JSTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj optionsObject:ooo:]):
- bindings/scripts/test/TestObj.idl:
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp: (WebCore::ConfigureV8TestMediaQueryListListenerTemplate):
- bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::optionsObjectCallback):
- bindings/v8/OptionsObject.cpp: Added. (WebCore::OptionsObject::OptionsObject): (WebCore::OptionsObject::~OptionsObject): (WebCore::OptionsObject::operator=): (WebCore::OptionsObject::undefinedOrNull): (WebCore::OptionsObject::getKeyBool): (WebCore::OptionsObject::getKeyString): (WebCore::OptionsObject::getKey):
- bindings/v8/OptionsObject.h:
- bindings/js/OptionsObject.h:
- storage/IDBDatabase.cpp: (WebCore::IDBDatabase::createObjectStore):
- storage/IDBDatabase.h: (WebCore::IDBDatabase::createObjectStore):
- storage/IDBDatabase.idl:
2010-11-25 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Add exception code to WebIDBTransaction::objectStore
https://bugs.webkit.org/show_bug.cgi?id=50030
- public/WebIDBTransaction.h: (WebKit::WebIDBTransaction::objectStore):
- 5:56 AM Changeset in webkit [72727] by
-
- 11 edits in trunk/WebCore
2010-11-24 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: set DOM breakpoints by path.
https://bugs.webkit.org/show_bug.cgi?id=50017
This change is needed to be able to push DOM breakpoints for all URL's to backend
at frontend load.
- inspector/InspectorController.cpp: (WebCore::InspectorController::setNativeBreakpoint):
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::InspectorDOMAgent): (WebCore::InspectorDOMAgent::discardBindings): (WebCore::InspectorDOMAgent::setDOMBreakpoint): (WebCore::InspectorDOMAgent::removeDOMBreakpoint): (WebCore::InspectorDOMAgent::descriptionForDOMEvent): (WebCore::InspectorDOMAgent::removeBreakpointsForNode):
- inspector/InspectorDOMAgent.h:
- inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.reset): (WebInspector.BreakpointManager.prototype.createDOMBreakpoint): (WebInspector.BreakpointManager.prototype._updateNativeBreakpointsInSettings): (WebInspector.BreakpointManager.prototype.restoreBreakpoints): (WebInspector.DOMBreakpoint): (WebInspector.DOMBreakpoint.prototype._setNodeId): (WebInspector.DOMBreakpoint.prototype.populateLabelElement): (WebInspector.EventListenerBreakpoint): (WebInspector.XHRBreakpoint):
- inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane): (WebInspector.BreakpointsSidebarPane.prototype._reset): (WebInspector.EventListenerBreakpointsSidebarPane): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._reset):
- inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent.prototype._setDocument):
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.reset):
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu.handlerFunction): (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.reset):
- inspector/front-end/inspector.js: (WebInspector.reset): (WebInspector.didCommitLoad):
- 5:40 AM Changeset in webkit [72726] by
-
- 4 edits in trunk/WebKit/qt
2010-11-25 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Andreas Kling and Simon Hausmann.
[Qt] Calculate the -webkit-pixel-radio using the device DPI.
http://webkit.org/b/50059
Also, update the documentation on what a DIP is and how to override
the device DPI in the case the system reports the wrong one (which
unfortunately is common on X11).
- Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate): (QWebPage::viewportAttributesForSize):
- Api/qwebpage_p.h:
- WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::scaleFactor):
- 5:21 AM Changeset in webkit [72725] by
-
- 5 edits in trunk/WebCore
2010-11-25 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: reuse code for recreating resource views.
https://bugs.webkit.org/show_bug.cgi?id=50066
- inspector/front-end/NetworkItemView.js: (WebInspector.NetworkItemView):
- inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.refreshResource):
- inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager.resourceViewTypeMatchesResource): (WebInspector.ResourceManager.resourceViewForResource): (WebInspector.ResourceManager.recreateResourceView):
- inspector/front-end/ResourcesPanel.js: (WebInspector.FrameResourceTreeElement.prototype._contentChanged):
- 2:09 AM Changeset in webkit [72724] by
-
- 2 edits in trunk/LayoutTests
2010-11-25 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed. Upstream chromium test expectations.
BUGCR64401 WIN : fast/filesystem/op-copy.html = TEXT
was added.
- platform/chromium/test_expectations.txt:
- 2:04 AM Changeset in webkit [72723] by
-
- 8 edits in trunk
2010-11-25 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Disallow inserting records with NULL keys
https://bugs.webkit.org/show_bug.cgi?id=50033
Test inserting records with NULL key and make sure it fails.
Update layout tests that previously inserted NULL keys.
- storage/indexeddb/index-cursor.html:
- storage/indexeddb/objectstore-basics-expected.txt:
- storage/indexeddb/objectstore-basics.html:
- storage/indexeddb/objectstore-cursor.html:
2010-11-25 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Disallow inserting records with NULL keys
https://bugs.webkit.org/show_bug.cgi?id=50033
Disallow inserting records with null keys into the object store.
- storage/IDBKey.h:
- storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::putInternal):
- 1:38 AM Changeset in webkit [72722] by
-
- 3 edits in trunk/WebCore
2010-11-25 Philippe Normand <pnormand@igalia.com>
Rubber-stamped by Xan Lopez.
g_signal_accumulator_first_wins was introduced in glib 2.27.1 so
no need to use our version if that version of glib is used during
the build.
- platform/gtk/GtkVersioning.c:
- platform/gtk/GtkVersioning.h:
Nov 24, 2010:
- 11:08 PM Changeset in webkit [72721] by
-
- 2 edits in trunk/WebKit/chromium
2010-11-24 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
[Chromium][Windows] TestShell flakily crashes with EventSender.contextClick()
https://bugs.webkit.org/show_bug.cgi?id=50052
makeStringArrayImpl() assumed wtf::StringImpl data is
null-terminated. But it is not.
Changed the code to pass the string length explicitly instead of
making it computed by v8::String::New().
- src/WebBindings.cpp: (WebKit::makeStringArrayImpl):
- 9:55 PM Changeset in webkit [72720] by
-
- 2 edits in trunk/LayoutTests
2010-11-24 Yuta Kitamura <yutak@chromium.org>
Reviewed by Kent Tamura.
[Chromium] Mark http/tests/websocket/tests/frame-lengths.html as SLOW
https://bugs.webkit.org/show_bug.cgi?id=50051
Chromium test expectation update: mark http/tests/websocket/tests/frame-lengths.html as SLOW.
This test takes a longer time to finish because it sends a lot of WebSocket messages.
- platform/chromium/test_expectations.txt:
- 8:35 PM Changeset in webkit [72719] by
-
- 2 edits in trunk/LayoutTests
2010-11-24 Martin Robinson <mrobinson@igalia.com>
[Qt] plugins/keyboard-events.html fails after r72717
https://bugs.webkit.org/show_bug.cgi?id=50050
- platform/qt/Skipped: Skip failing tests until a fix is made.
- 7:34 PM Changeset in webkit [72718] by
-
- 27 edits7 adds in trunk
Implement DataView interface from Typed Array specification
https://bugs.webkit.org/show_bug.cgi?id=46541
Reviewed by Kenneth Russell.
WebCore:
Test: fast/canvas/webgl/data-view-test.html
- CMakeLists.txt:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pri:
- WebCore.pro:
- WebCore.xcodeproj/project.pbxproj:
- bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::dataViewEnabled):
- bindings/js/JSArrayBufferViewHelper.h:
(WebCore::constructArrayBufferViewWithArrayBufferArgument):
(WebCore::constructArrayBufferView):
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::dataView):
- bindings/js/JSDataViewCustom.cpp: Added.
- bindings/js/JSFloat32ArrayCustom.cpp:
(WebCore::JSFloat32ArrayConstructor::constructJSFloat32Array):
- bindings/js/JSInt16ArrayCustom.cpp:
(WebCore::JSInt16ArrayConstructor::constructJSInt16Array):
- bindings/js/JSInt32ArrayCustom.cpp:
(WebCore::JSInt32ArrayConstructor::constructJSInt32Array):
- bindings/js/JSInt8ArrayCustom.cpp:
(WebCore::JSInt8ArrayConstructor::constructJSInt8Array):
- bindings/js/JSUint16ArrayCustom.cpp:
(WebCore::JSUint16ArrayConstructor::constructJSUint16Array):
- bindings/js/JSUint32ArrayCustom.cpp:
(WebCore::JSUint32ArrayConstructor::constructJSUint32Array):
- bindings/js/JSUint8ArrayCustom.cpp:
(WebCore::JSUint8ArrayConstructor::constructJSUint8Array):
- bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore::constructWebGLArrayWithArrayBufferArgument):
(WebCore::constructWebGLArray):
- bindings/v8/custom/V8DataViewCustom.cpp: Added.
- html/canvas/ArrayBufferView.h:
(WebCore::ArrayBufferView::isDataView):
- html/canvas/DataView.cpp: Added.
- html/canvas/DataView.h: Added.
- html/canvas/DataView.idl: Added.
- page/DOMWindow.idl:
LayoutTests:
Add a new test for testing DataView interface. Also update some tests
to exclude DataView property from being tested because it is not
exposed to all platforms.
- fast/canvas/webgl/data-view-test-expected.txt: Added.
- fast/canvas/webgl/data-view-test.html: Added.
- fast/dom/Window/script-tests/window-property-descriptors.js:
- fast/dom/Window/window-properties.html:
- fast/dom/script-tests/prototype-inheritance-2.js:
(constructorNamesForWindow):
- fast/dom/script-tests/prototype-inheritance.js:
- fast/js/script-tests/global-constructors.js:
- 7:18 PM Changeset in webkit [72717] by
-
- 4 edits in trunk
2010-11-24 Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>
Reviewed by Martin Robinson.
[GTK] Windowless plugins gets broken key input
https://bugs.webkit.org/show_bug.cgi?id=49927
When converting the GdkEvent to XEvent we need to send the
hardware_keycode as XEvent::keycode. Instead we where sending
the GdkEvent::keyval. This is already tested by
plugins/keyboard-events.html, but a bug in the test plugin was
resulting in false positive.
- plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::handleKeyboardEvent):
2010-11-24 Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>
Reviewed by Martin Robinson.
[GTK] Windowless plugins gets broken key input
https://bugs.webkit.org/show_bug.cgi?id=49927
Convert the XEvent::keycode to ASCII before printing it. Not
doing this was causing false positive in
plugins/keyboard-events.html.
- DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (keycode_to_char): (webkit_test_plugin_handle_event):
- 7:02 PM Changeset in webkit [72716] by
-
- 2 edits in trunk/LayoutTests
2010-11-24 Eric Uhrhane <ericu@chromium.org>
Reviewed by Tony Chang.
Fix file-writer-truncate-extend test.
https://bugs.webkit.org/show_bug.cgi?id=50047
- fast/filesystem/resources/file-writer-truncate-extend.js:
- 6:44 PM Changeset in webkit [72715] by
-
- 23 edits3 copies in trunk/WebCore
2010-11-24 Eric Uhrhane <ericu@chromium.org>
Reviewed by David Levin.
Implement FileWriterSync
https://bugs.webkit.org/show_bug.cgi?id=49939
Tests to follow in a separate CL, once the test framework in 47680 goes in.
Build file changes to add FileWriterBase and FileWriterBaseCallback.
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
FileWriterSync doesn't turn out to need to be an ActiveDOMObject.
- bindings/scripts/CodeGeneratorV8.pm:
Added new AsyncFileWriter::waitForOperationToComplete to enable
synchronous calls.
- fileapi/AsyncFileWriter.h:
Added a way to get a FileSystemSync.
- fileapi/DOMFileSystemSync.cpp:
- fileapi/FileEntrySync.cpp:
- fileapi/FileEntrySync.h:
- fileapi/FileEntrySync.idl:
Added an error code for OK, rather than just having 0 everywhere.
- fileapi/FileError.h:
Turned FileWriterCallback into FileWriterBaseCallback.
- fileapi/FileSystemCallbacks.cpp:
- fileapi/FileSystemCallbacks.h:
Refactored out a common base class, FileWriterBase, for FileWriter and
FileWriterSync.
- fileapi/FileWriter.cpp:
- fileapi/FileWriter.h:
- fileapi/FileWriterBase.cpp: Added.
- fileapi/FileWriterBase.h: Added.
- fileapi/FileWriterBaseCallback.h: Added.
- fileapi/FileWriterSync.cpp:
- fileapi/FileWriterSync.h:
Small tweaks to deal with the base class refactoring.
- fileapi/DOMFileSystem.cpp:
- fileapi/DOMFileSystemSync.h:
Removed "CallWith=ScriptExecutionContext", as FileWriterSync doesn't actually need it.
- fileapi/FileWriterSync.idl:
- 6:38 PM Changeset in webkit [72714] by
-
- 1891 edits137 copies176 adds126 deletes in branches/audio
audio branch: merge from trunk 71224:72704
- 6:26 PM Changeset in webkit [72713] by
-
- 2 edits in trunk/WebCore
2010-11-24 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
Build fix for GTK+. There were some typos in my last build fix
and the empty command (semicolon) seems to be necessary for wildcard
rule chains.
- GNUmakefile.am: Small build fixes.
- 6:11 PM Changeset in webkit [72712] by
-
- 2 edits in trunk/WebKitTools
2010-11-24 Jan Erik Hanssen <jhanssen@sencha.com>
Reviewed by Antonio Gomes.
[Qt] Html autofocus not working with QGraphicsWebView
https://bugs.webkit.org/show_bug.cgi?id=43169
Tell the scene to set the webview item as the currently
focused item. This makes the input field with autofocus get
focus as it should.
- QtTestBrowser/webview.cpp: (WebViewGraphicsBased::WebViewGraphicsBased):
- 5:55 PM Changeset in webkit [72711] by
-
- 5 edits in trunk/WebKit/chromium
2010-11-24 Eric Uhrhane <ericu@chromium.org>
Reviewed by David Levin.
[Chromium] Implement FileWriterSync
https://bugs.webkit.org/show_bug.cgi?id=49940
Added waitForOperationToComplete, delegating to the bridge.
- src/WorkerAsyncFileWriterChromium.cpp:
- src/WorkerAsyncFileWriterChromium.h:
Added waitForOperationToComplete and some debug-only code to make sure it's working properly.
- src/WorkerFileWriterCallbacksBridge.cpp: (WebKit::WorkerFileWriterCallbacksBridge::postWriteToMainThread): (WebKit::WorkerFileWriterCallbacksBridge::postTruncateToMainThread): (WebKit::WorkerFileWriterCallbacksBridge::postAbortToMainThread): (WebKit::WorkerFileWriterCallbacksBridge::WorkerFileWriterCallbacksBridge): (WebKit::WorkerFileWriterCallbacksBridge::didWriteOnWorkerThread): (WebKit::WorkerFileWriterCallbacksBridge::didFailOnWorkerThread): (WebKit::WorkerFileWriterCallbacksBridge::didTruncateOnWorkerThread): (WebKit::WorkerFileWriterCallbacksBridge::waitForOperationToComplete):
- src/WorkerFileWriterCallbacksBridge.h:
- 5:46 PM Changeset in webkit [72710] by
-
- 3 edits in trunk/LayoutTests
2010-11-24 Nico Weber <thakis@chromium.org>
Unreviewed.
Another new baseline after http://trac.webkit.org/changeset/72689
https://bugs.webkit.org/show_bug.cgi?id=50040
- platform/chromium-mac/http/tests/misc/slow-loading-image-in-pattern-expected.checksum:
- platform/chromium-mac/http/tests/misc/slow-loading-image-in-pattern-expected.png:
- 5:09 PM Changeset in webkit [72709] by
-
- 2 edits in trunk/WebKit2
Reviewed implicitly by John Sullivan.
https://bugs.webkit.org/show_bug.cgi?id=50042
- UIProcess/mac/WebContextMenuProxyMac.mm:
(-[WebUserDataWrapper initWithUserData:WebKit::]): Do the proper self = [super init] dance here.
- 4:56 PM Changeset in webkit [72708] by
-
- 14 edits in trunk/WebKitTools
2010-11-24 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
nrwt - clean up create_driver interface and print out the
command line used for DumpRenderTree/TestShell.
This patch adds a driver_cmd_line() call to the Port class in
order to retrive the command line to print it out (as part of
--print config).
In addition, this patch cleans up the Port.create_driver()
signature and the Driver constructor interface to take a worker
number and no longer require the image_path argument (Chromium's
drivers now synthesize the image_path from the worker number
internally).
- Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
- Scripts/webkitpy/layout_tests/layout_package/printing.py:
- Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/base_unittest.py:
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
- Scripts/webkitpy/layout_tests/port/dryrun.py:
- Scripts/webkitpy/layout_tests/port/port_testcase.py:
- Scripts/webkitpy/layout_tests/port/test.py:
- Scripts/webkitpy/layout_tests/port/webkit.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 4:53 PM Changeset in webkit [72707] by
-
- 12 edits in trunk/WebKit2
More of <rdar://problem/8613727> and https://bugs.webkit.org/show_bug.cgi?id=50042
WK2 Context Menu Items need a user data object and a client callback for selection.
Reviewed by Dan Bernstein.
- Shared/API/c/WKContextMenuItem.cpp:
(WKContextMenuItemGetUserData):
(WKContextMenuItemSetUserData):
- Shared/API/c/WKContextMenuItem.h:
- Shared/WebContextMenuItem.cpp:
(WebKit::WebContextMenuItem::userData):
(WebKit::WebContextMenuItem::setUserData):
- Shared/WebContextMenuItem.h:
- Shared/WebContextMenuItemData.cpp:
(WebKit::WebContextMenuItemData::userData):
(WebKit::WebContextMenuItemData::setUserData):
- Shared/WebContextMenuItemData.h:
- UIProcess/API/C/WKPage.h:
- UIProcess/WebPageContextMenuClient.cpp:
(WebKit::WebPageContextMenuClient::customContextMenuItemSelected): Added for WK2 apps to get a callback.
- UIProcess/WebPageContextMenuClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::contextMenuItemSelected):
- UIProcess/mac/WebContextMenuProxyMac.mm:
(-[WebUserDataWrapper initWithUserData:WebKit::]): Add an "APIObject" user data wrapper class to associate with the NSMenuItem.
(-[WebUserDataWrapper WebKit::]):
(-[WebMenuTarget forwardContextMenuAction:]): Include the user data object in the created ContextMenuItemData.
(WebKit::nsMenuItemVector):
- 4:39 PM Changeset in webkit [72706] by
-
- 43 edits2 copies2 adds2 deletes in trunk/LayoutTests
2010-11-24 Nico Weber <thakis@chromium.org>
Unreviewed.
More new baselines after http://trac.webkit.org/changeset/72689
https://bugs.webkit.org/show_bug.cgi?id=50040
- platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.checksum:
- platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-30-t-expected.checksum:
- platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.checksum:
- platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-39-t-expected.checksum:
- platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.checksum:
- platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.checksum:
- platform/chromium-mac/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.checksum:
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.checksum:
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.checksum:
- platform/chromium-mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-06-t-expected.checksum:
- platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-06-t-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-08-t-expected.checksum:
- platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-08-t-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-10-t-expected.checksum: Removed.
- platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-10-t-expected.png: Removed.
- platform/chromium-mac/svg/carto.net/scrollbar-expected.checksum:
- platform/chromium-mac/svg/carto.net/scrollbar-expected.png:
- platform/chromium-mac/svg/carto.net/selectionlist-expected.checksum:
- platform/chromium-mac/svg/carto.net/selectionlist-expected.png:
- platform/chromium-mac/svg/custom/convolution-crash-expected.checksum:
- platform/chromium-mac/svg/custom/convolution-crash-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/custom/createImageElement-expected.png.
- platform/chromium-mac/svg/custom/createImageElement-expected.checksum:
- platform/chromium-mac/svg/custom/createImageElement-expected.png:
- platform/chromium-mac/svg/custom/image-small-width-height-expected.checksum:
- platform/chromium-mac/svg/custom/image-small-width-height-expected.png:
- platform/chromium-mac/svg/custom/js-update-image-and-display-expected.checksum:
- platform/chromium-mac/svg/custom/js-update-image-and-display-expected.png:
- platform/chromium-mac/svg/custom/js-update-image-and-display2-expected.checksum:
- platform/chromium-mac/svg/custom/js-update-image-and-display2-expected.png:
- platform/chromium-mac/svg/custom/js-update-image-and-display3-expected.checksum:
- platform/chromium-mac/svg/custom/js-update-image-and-display3-expected.png:
- platform/chromium-mac/svg/custom/js-update-image-expected.checksum:
- platform/chromium-mac/svg/custom/js-update-image-expected.png:
- platform/chromium-mac/svg/custom/pointer-events-image-expected.checksum:
- platform/chromium-mac/svg/custom/pointer-events-image-expected.png:
- platform/chromium-mac/svg/custom/text-image-opacity-expected.checksum:
- platform/chromium-mac/svg/custom/text-image-opacity-expected.png:
- platform/chromium-mac/svg/filters/feDisplacementMap-expected.checksum:
- platform/chromium-mac/svg/filters/feDisplacementMap-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/custom/js-update-image-expected.png.
- 4:13 PM Changeset in webkit [72705] by
-
- 10 edits1 copy2 adds in branches/audio
audio branch: changes for landing in trunk
- AudioNode custom bindings last tweaks
- chromium WebKit API work: WebAudioBus...
- FFMPEG file reading compile fixes for chromium
- switch to 'webkit' prefix on AudioContext constructor
- 3:59 PM Changeset in webkit [72704] by
-
- 18 edits7 adds2 deletes in trunk/LayoutTests
2010-11-24 Eric Uhrhane <ericu@chromium.org>
Reviewed by David Levin.
Add FileWriter test utilities.
https://bugs.webkit.org/show_bug.cgi?id=47680
Cleaning up shared test utility files caused the includes and output of
a bunch of existing tests change slightly, so I've rebuilt the
expectation files.
This is the first test [in DOM and worker versions] to use the new utilities.
- fast/filesystem/file-writer-truncate-extend-expected.txt: Added.
- fast/filesystem/file-writer-truncate-extend.html: Added.
- fast/filesystem/resources/file-writer-truncate-extend.js: Added.
- fast/filesystem/workers/file-writer-truncate-extend-expected.txt: Added.
- fast/filesystem/workers/file-writer-truncate-extend.html: Added.
This is a new utility file for FileWriter tests.
- fast/filesystem/resources/file-writer-utils.js: Added.
Touched up a bit
- fast/filesystem/resources/fs-worker-common.js:
Removed
- fast/filesystem/resources/fs-worker-test-post.js:
- fast/filesystem/resources/fs-worker-test-pre.js: renamed to
- fast/filesystem/resources/fs-worker-test-util.js:
These tests and their expectations were tweaked slightly to use the new code more cleanly.
- fast/filesystem/workers/async-operations-expected.txt:
- fast/filesystem/workers/async-operations.html:
- fast/filesystem/workers/file-from-file-entry-expected.txt:
- fast/filesystem/workers/file-from-file-entry-sync-expected.txt:
- fast/filesystem/workers/file-from-file-entry-sync.html:
- fast/filesystem/workers/file-from-file-entry.html:
- fast/filesystem/workers/simple-persistent-expected.txt:
- fast/filesystem/workers/simple-persistent-sync-expected.txt:
- fast/filesystem/workers/simple-persistent-sync.html:
- fast/filesystem/workers/simple-persistent.html:
- fast/filesystem/workers/simple-temporary-expected.txt:
- fast/filesystem/workers/simple-temporary-sync-expected.txt:
- fast/filesystem/workers/simple-temporary-sync.html:
- fast/filesystem/workers/simple-temporary.html:
- fast/filesystem/workers/sync-operations-expected.txt:
- fast/filesystem/workers/sync-operations.html:
Removed suppression of FileWriter tests, as we now have support in TestShell.
- platform/chromium/test_expectations.txt:
- 3:22 PM Changeset in webkit [72703] by
-
- 2 edits in trunk/WebKit/chromium
2010-11-24 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
[chromium] Disable antialiasing for compositor
https://bugs.webkit.org/show_bug.cgi?id=50039
- src/WebViewImpl.cpp: (WebCore::getCompositorContextAttributes): (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit::WebViewImpl::graphicsContext3D):
- 3:11 PM Changeset in webkit [72702] by
-
- 100 edits13 deletes in trunk/LayoutTests
2010-11-24 Nico Weber <thakis@chromium.org>
Unreviewed.
New baselines after http://trac.webkit.org/changeset/72689
https://bugs.webkit.org/show_bug.cgi?id=50040
- platform/chromium-mac/css2.1/t0804-c5510-padn-00-b-ag-expected.checksum:
- platform/chromium-mac/css2.1/t0905-c414-flt-01-d-g-expected.checksum:
- platform/chromium-mac/css2.1/t100801-c544-valgn-02-d-agi-expected.checksum:
- platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.checksum:
- platform/chromium-mac/css2.1/t100801-c544-valgn-04-d-agi-expected.checksum:
- platform/chromium-mac/fast/backgrounds/size/backgroundSize01-expected.checksum: Removed.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize01-expected.png: Removed.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize05-expected.checksum: Removed.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize05-expected.png: Removed.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize06-expected.checksum: Removed.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize07-expected.checksum: Removed.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize08-expected.checksum: Removed.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize09-expected.checksum: Removed.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize10-expected.checksum: Removed.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize11-expected.checksum: Removed.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize12-expected.checksum: Removed.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize12-expected.png: Removed.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize16-expected.checksum:
- platform/chromium-mac/fast/backgrounds/size/backgroundSize16-expected.png:
- platform/chromium-mac/fast/backgrounds/size/backgroundSize17-expected.checksum:
- platform/chromium-mac/fast/backgrounds/size/backgroundSize17-expected.png:
- platform/chromium-mac/fast/backgrounds/size/backgroundSize18-expected.checksum:
- platform/chromium-mac/fast/backgrounds/size/backgroundSize18-expected.png:
- platform/chromium-mac/fast/backgrounds/size/backgroundSize19-expected.checksum:
- platform/chromium-mac/fast/backgrounds/size/backgroundSize19-expected.png:
- platform/chromium-mac/fast/backgrounds/size/backgroundSize20-expected.checksum:
- platform/chromium-mac/fast/backgrounds/size/backgroundSize20-expected.png:
- platform/chromium-mac/fast/backgrounds/size/backgroundSize21-expected.checksum:
- platform/chromium-mac/fast/backgrounds/size/backgroundSize21-expected.png:
- platform/chromium-mac/fast/backgrounds/size/backgroundSize22-expected.checksum:
- platform/chromium-mac/fast/backgrounds/size/backgroundSize22-expected.png:
- platform/chromium-mac/fast/backgrounds/size/zero-expected.checksum:
- platform/chromium-mac/fast/backgrounds/size/zero-expected.png:
- platform/chromium-mac/fast/css/value-list-out-of-bounds-crash-expected.checksum:
- platform/chromium-mac/fast/events/pointer-events-2-expected.checksum:
- platform/chromium-mac/fast/events/pointer-events-2-expected.png:
- platform/chromium-mac/fast/forms/input-type-change-expected.checksum:
- platform/chromium-mac/fast/repaint/block-layout-inline-children-replaced-expected.checksum:
- platform/chromium-mac/fast/repaint/block-layout-inline-children-replaced-expected.png:
- platform/chromium-mac/fast/replaced/image-sizing-expected.checksum:
- platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.checksum:
- platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.png:
- platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.checksum:
- platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.png:
- platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.checksum:
- platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.png:
- platform/chromium-mac/svg/custom/image-parent-translation-expected.checksum:
- platform/chromium-mac/svg/custom/image-parent-translation-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug11026-expected.checksum:
- platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.checksum:
- platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.checksum:
- platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.checksum:
- platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug14929-expected.checksum: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug2981-2-expected.checksum:
- platform/chromium-mac/tables/mozilla/bugs/bug4093-expected.checksum:
- platform/chromium-mac/tables/mozilla/bugs/bug4284-expected.checksum:
- platform/chromium-mac/tables/mozilla/bugs/bug4427-expected.checksum:
- platform/chromium-mac/tables/mozilla/bugs/bug4427-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug4523-expected.checksum:
- platform/chromium-mac/tables/mozilla/bugs/bug56563-expected.checksum:
- platform/chromium-mac/tables/mozilla/bugs/bug6404-expected.checksum:
- platform/chromium-mac/tables/mozilla/bugs/bug97383-expected.checksum:
- platform/chromium-mac/tables/mozilla/bugs/bug97383-expected.png:
- platform/chromium-mac/tables/mozilla/core/col_widths_auto_autoFix-expected.checksum:
- platform/chromium-mac/tables/mozilla/core/misc-expected.checksum:
- platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug6933-expected.checksum:
- 3:00 PM Changeset in webkit [72701] by
-
- 21 edits18 adds in trunk
2010-11-24 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Compositor needs to manage its VRAM use
https://bugs.webkit.org/show_bug.cgi?id=49629
This adds a basic texture manager to the Chromium compositor to limit the amount of VRAM
used by compositor textures and switches ContentLayerChromium, ImageLayerChromium, and
RenderSurfaceChromium to use managed LayerTexture. The other *LayerChromium classes (Canvas,
Video, and WebGL) and the root layer are still unmanaged.
The TextureManager works by providing tokens to callers that want to use a managed texture.
The token can be used to request a texture, see if the previously requested texture is still
available, and to protect/unprotect textures when they cannot be collected. Whenever a
texture is created the manager attempts to free up the least recently used textures until the
total memory use is below the provided threshhold. If the manager cannot satisfy the memory
limit it will not return any new textures until some old textures are released.
A LayerTexture wraps a TextureManager token, size, and format. A LayerChromium can check if a
previously requested texture is still available for use and reserve the LayerTexture's underlying
storage between the updateContentsIfDirty() and the draw() call.
Also changes LayerChromium from having separate contentsDirty()/updateContents() calls to a single
updateContentsIfDirty().
Tests: compositing/lots-of-img-layers-with-opacity.html
compositing/lots-of-img-layers.html
- WebCore.gypi:
- platform/graphics/chromium/Canvas2DLayerChromium.cpp: (WebCore::Canvas2DLayerChromium::updateContentsIfDirty):
- platform/graphics/chromium/Canvas2DLayerChromium.h:
- platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::cleanupResources): (WebCore::ContentLayerChromium::updateContentsIfDirty): (WebCore::ContentLayerChromium::updateTextureRect): (WebCore::ContentLayerChromium::draw):
- platform/graphics/chromium/ContentLayerChromium.h:
- platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateContentsIfDirty):
- platform/graphics/chromium/ImageLayerChromium.h:
- platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::updateContentsIfDirty): (WebCore::LayerChromium::draw):
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::prepareToDrawLayers): (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::updateLayersRecursive): (WebCore::LayerRendererChromium::useRenderSurface): (WebCore::LayerRendererChromium::drawLayer): (WebCore::LayerRendererChromium::initializeSharedObjects): (WebCore::LayerRendererChromium::cleanupSharedObjects):
- platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::renderSurfaceSharedValues): (WebCore::LayerRendererChromium::textureManager):
- platform/graphics/chromium/LayerTexture.cpp: Added. (WebCore::LayerTexture::LayerTexture): (WebCore::LayerTexture::~LayerTexture): (WebCore::LayerTexture::isValid): (WebCore::LayerTexture::reserve): (WebCore::LayerTexture::unreserve): (WebCore::LayerTexture::bindTexture): (WebCore::LayerTexture::framebufferTexture2D):
- platform/graphics/chromium/LayerTexture.h: Added. (WebCore::LayerTexture::create):
- platform/graphics/chromium/PluginLayerChromium.cpp: (WebCore::PluginLayerChromium::updateContentsIfDirty):
- platform/graphics/chromium/PluginLayerChromium.h:
- platform/graphics/chromium/RenderSurfaceChromium.cpp: (WebCore::RenderSurfaceChromium::SharedValues::SharedValues): (WebCore::RenderSurfaceChromium::SharedValues::~SharedValues): (WebCore::RenderSurfaceChromium::RenderSurfaceChromium): (WebCore::RenderSurfaceChromium::cleanupResources): (WebCore::RenderSurfaceChromium::prepareContentsTexture): (WebCore::RenderSurfaceChromium::draw):
- platform/graphics/chromium/RenderSurfaceChromium.h: (WebCore::RenderSurfaceChromium::SharedValues::shaderProgram): (WebCore::RenderSurfaceChromium::SharedValues::shaderSamplerLocation): (WebCore::RenderSurfaceChromium::SharedValues::shaderMatrixLocation): (WebCore::RenderSurfaceChromium::SharedValues::shaderAlphaLocation): (WebCore::RenderSurfaceChromium::SharedValues::initialized):
- platform/graphics/chromium/TextureManager.cpp: Added. (WebCore::memoryUseBytes): (WebCore::TextureManager::TextureManager): (WebCore::TextureManager::getToken): (WebCore::TextureManager::releaseToken): (WebCore::TextureManager::hasTexture): (WebCore::TextureManager::protectTexture): (WebCore::TextureManager::unprotectTexture): (WebCore::TextureManager::reduceMemoryToLimit): (WebCore::TextureManager::addTexture): (WebCore::TextureManager::removeTexture): (WebCore::TextureManager::requestTexture):
- platform/graphics/chromium/TextureManager.h: Added. (WebCore::TextureManager::create):
- platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::updateContentsIfDirty):
- platform/graphics/chromium/VideoLayerChromium.h:
- platform/graphics/chromium/WebGLLayerChromium.cpp: (WebCore::WebGLLayerChromium::updateContentsIfDirty):
- platform/graphics/chromium/WebGLLayerChromium.h:
2010-11-24 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Compositor needs to manage its VRAM use
https://bugs.webkit.org/show_bug.cgi?id=49629
Adds a few tests involving lots of visible image layers. The tests are designed
to require slightly more than 64MB of VRAM.
- compositing/lots-of-img-layers-with-opacity.html: Added.
- compositing/lots-of-img-layers.html: Added.
- platform/chromium-gpu-win/compositing/lots-of-img-layers-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/lots-of-img-layers-expected.png: Added.
- platform/chromium-gpu-win/compositing/lots-of-img-layers-expected.txt: Added.
- platform/chromium-gpu-win/compositing/lots-of-img-layers-with-opacity-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/lots-of-img-layers-with-opacity-expected.png: Added.
- platform/chromium-gpu-win/compositing/lots-of-img-layers-with-opacity-expected.txt: Added.
- platform/chromium-gpu/test_expectations.txt:
- platform/mac/compositing/lots-of-img-layers-expected.checksum: Added.
- platform/mac/compositing/lots-of-img-layers-expected.png: Added.
- platform/mac/compositing/lots-of-img-layers-expected.txt: Added.
- platform/mac/compositing/lots-of-img-layers-with-opacity-expected.checksum: Added.
- platform/mac/compositing/lots-of-img-layers-with-opacity-expected.png: Added.
- platform/mac/compositing/lots-of-img-layers-with-opacity-expected.txt: Added.
- 2:30 PM Changeset in webkit [72700] by
-
- 2 edits in trunk/LayoutTests
2010-11-24 Tony Chang <tony@chromium.org>
Unreviewed, updating plugin test expectations now that we've switched
to the upstream plugin!
- platform/chromium/test_expectations.txt:
- 2:28 PM Changeset in webkit [72699] by
-
- 5 edits in trunk/WebKitTools
2010-11-24 Ojan Vafai <ojan@chromium.org>
Reviewed by Tony Chang.
[chromium] improve memory usage for test results server and store fewer runs
https://bugs.webkit.org/show_bug.cgi?id=50035
Store fewer runs and don't pass full files around when we only need bools.
Greatly improves error rates on test-results.appspot.com.
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
- TestResultServer/handlers/testfilehandler.py:
- TestResultServer/model/dashboardfile.py:
- TestResultServer/model/jsonresults.py:
- 1:57 PM Changeset in webkit [72698] by
-
- 6 edits in trunk/WebKitTools
2010-11-24 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
This patch implements the first part of the manager side of the
Broker objects - it handles creating threads, waiting for them
to complete, and running a single-threaded loop as well.
- Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
- Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 1:29 PM Changeset in webkit [72697] by
-
- 3 edits in trunk/WebKit/qt
2010-11-24 Kristian Amlie <kristian.amlie@nokia.com>
Reviewed by Andreas Kling.
Fixed handling of QInputMethodEvents with nonzero replacementLength.
These types of events replace text that is already in the widget, but
WebKit did not check for replacementLength at all.
- Api/qwebpage.cpp: (QWebPagePrivate::inputMethodEvent):
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods):
- 12:20 PM Changeset in webkit [72696] by
-
- 2 edits in trunk/LayoutTests
2010-11-24 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed. Just assign a bug for compositing/plugin tests.
- platform/chromium-gpu/test_expectations.txt:
- 12:02 PM Changeset in webkit [72695] by
-
- 3 edits6 adds in trunk
2010-11-24 Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>
Reviewed by Martin Robinson.
[GTK] response.isNull() assert when using directory file URI
https://bugs.webkit.org/show_bug.cgi?id=49018
When using file:/// (or any directory), WebKitGTK use to abort on
assertion. This test ensure that loading a directory is possible.
- platform/gtk/fast/loader/crash-display-local-directory-expected.txt: Added.
- platform/gtk/fast/loader/crash-display-local-directory.html: Added.
- platform/gtk/fast/loader/resources/directory/keep-empty: Added.
2010-11-24 Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>
Reviewed by Martin Robinson.
[GTK] response.isNull() assert when using directory file URI
https://bugs.webkit.org/show_bug.cgi?id=49018
Do ensure that didReceiveResponse happens before any call to
didReceiveData. That was not true for file:// URIs pointing to
directories and thus was triggering an assertion.
Test: platform/gtk/fast/loader/crash-display-local-directory.html
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::gotHeadersCallback): (WebCore::contentSniffedCallback): (WebCore::parseDataUrl): (WebCore::sendRequestCallback): (WebCore::readCallback):
- 11:45 AM Changeset in webkit [72694] by
-
- 4 edits in trunk/WebKitTools
2010-11-24 Mihai Parparita <mihaip@chromium.org>
Reviewed by David Levin.
DRT should not generate pixel output for text/plain tests
https://bugs.webkit.org/show_bug.cgi?id=50002
Modify Mac, Windows and GTK DRT implementations to disable pixel output
when encountering a text/plain response (the Chromium one already does
this, and none of the other ports special-case text/plain output in
the first place).
- DumpRenderTree/gtk/DumpRenderTree.cpp: (dump):
- DumpRenderTree/mac/DumpRenderTree.mm: (dump):
- DumpRenderTree/win/DumpRenderTree.cpp: (dump):
- 11:23 AM Changeset in webkit [72693] by
-
- 2 edits in trunk/LayoutTests
2010-11-24 Andrey Kosyakov <caseq@chromium.org>
Unreviewed, update platform expectations following expectations change in r72683.
- platform/mac-leopard/inspector/extensions-resources-expected.txt:
- 11:23 AM Changeset in webkit [72692] by
-
- 2 edits in trunk/WebCore
2010-11-24 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
- bindings/gobject/WebKitDOMBinding.h: fix stlye nit.
- 11:15 AM Changeset in webkit [72691] by
-
- 8 edits in trunk
WebCore:
2010-11-24 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Make kit() methods return the proper type instead of gpointer
https://bugs.webkit.org/show_bug.cgi?id=50034
Change kit() methods to return proper type pointer.
- bindings/gobject/WebKitDOMBinding.cpp: change implementions of kit methods.
- bindings/gobject/WebKitDOMBinding.h: change their declarations.
- bindings/scripts/CodeGeneratorGObject.pm: change the generated kit() methods.
WebKit/gtk:
2010-11-24 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Make kit() methods return the proper type instead of gpointer
https://bugs.webkit.org/show_bug.cgi?id=50034
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::shouldDeleteRange): get rid of unneeded cast. (WebKit::EditorClient::shouldShowDeleteInterface): ditto. (WebKit::EditorClient::shouldBeginEditing): ditto. (WebKit::EditorClient::shouldEndEditing): ditto. (WebKit::EditorClient::shouldInsertText): ditto. (WebKit::EditorClient::shouldChangeSelectedRange): ditto. (WebKit::EditorClient::shouldApplyStyle): ditto. (WebKit::EditorClient::shouldInsertNode): ditto.
- webkit/webkitprivate.cpp: (WebKit::kit): ditto.
- webkit/webkitwebview.cpp: (webkit_web_view_get_dom_document): ditto.
- 11:08 AM Changeset in webkit [72690] by
-
- 2 edits in trunk/WebCore
2010-11-24 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] DerivedSources/WebCore/DocTypeStrings.cpp is generated for every build
https://bugs.webkit.org/show_bug.cgi?id=50032
Instead of listing two targets for rules that have two outputs, make
a dependency chain. This fixes the issue where some files are generated
unconditionally. Also remove all unnecessary semicolons from the file.
No new tests as this is just a build fix.
- GNUmakefile.am: Fix GNUmake dependency issue.
- 11:01 AM Changeset in webkit [72689] by
-
- 2 edits in trunk/WebCore
2010-11-24 Nico Weber <nicolasweber@gmx.de>
Reviewed by Adam Barth.
Chromium/Mac: Make scaled images un-ugly when using the webkit image decoders
https://bugs.webkit.org/show_bug.cgi?id=49965
Probably covered by existing tests whose expectations were overwritten
in http://trac.webkit.org/changeset/70858
- platform/image-decoders/cg/ImageDecoderCG.cpp: (WebCore::RGBA32Buffer::asNewNativeImage):
- 10:54 AM Changeset in webkit [72688] by
-
- 2 edits in trunk
2010-11-24 Hayato Ito <hayato@chromium.org>
Reviewed by David Levin.
Add files which Chromium port generates to .gitignore.
- .gitignore:
- 10:45 AM Changeset in webkit [72687] by
-
- 5 edits in trunk
2010-11-24 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Crash when inspecting http://alphaarnhem.nl/beta/
https://bugs.webkit.org/show_bug.cgi?id=50025
@font-face rules were improperly handled by source data extractor.
WebCore:
- css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::parseDeclaration): (WebCore::CSSParser::createStyleRule): (WebCore::CSSParser::markRuleBodyStart): (WebCore::CSSParser::markPropertyStart): (WebCore::CSSParser::markPropertyEnd):
- css/CSSParser.h:
LayoutTests:
- inspector/resources/styles-new-API-1.css: (@font-face):
- 10:31 AM Changeset in webkit [72686] by
-
- 3 edits in trunk/LayoutTests/platform/gtk
2010-11-24 Xan Lopez <xlopez@igalia.com>
Update results for some leftover tests now that we have editing
delegates.
- platform/gtk/editing/selection/5109817-expected.txt:
- platform/gtk/editing/selection/extend-by-character-002-expected.txt:
- platform/gtk/fast/forms/caret-rtl-expected.txt:
- 10:13 AM Changeset in webkit [72685] by
-
- 3 edits2 adds in trunk
2010-11-24 Cris Neckar <cdn@chromium.org>
Reviewed by Adam Barth.
Added check when parsing local fonts to ensure that a value's unit type is either string or ident.
https://bugs.webkit.org/show_bug.cgi?id=49883
Test: fast/css/local_font_invalid.html
- css/CSSParser.cpp: (WebCore::CSSParser::parseFontFaceSrc):
2010-11-24 Cris Neckar <cdn@chromium.org>
Reviewed by Adam Barth.
Test for crash with invalid local fonts.
https://bugs.webkit.org/show_bug.cgi?id=49883
- fast/css/local_font_invalid-expected.txt: Added.
- fast/css/local_font_invalid.html: Added.
- 10:06 AM Changeset in webkit [72684] by
-
- 14 edits in trunk/WebCore
2010-11-24 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: place local modifications to under original
resource nodes in the resource panel.
https://bugs.webkit.org/show_bug.cgi?id=50029
- English.lproj/localizedStrings.js:
- inspector/Inspector.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorController::scriptImported):
- inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::setInitialContent):
- inspector/InspectorResourceAgent.h:
- inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype.setRuleSelector): (WebInspector.CSSStyleModel.prototype.addRule): (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback): (WebInspector.CSSStyleModel.prototype._styleSheetChanged): (WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt): (WebInspector.CSSProperty.prototype.setText): (WebInspector.CSSProperty.prototype.setDisabled.callback): (WebInspector.CSSProperty.prototype.setDisabled): (WebInspector.CSSStyleSheet.prototype.setText):
- inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.refreshResource):
- inspector/front-end/Resource.js: (WebInspector.Resource.prototype.set content): (WebInspector.Resource.prototype.get contentTimestamp): (WebInspector.Resource.prototype.setInitialContent):
- inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager): (WebInspector.ResourceManager.prototype.setInitialContent):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel): (WebInspector.ResourcesPanel.prototype.reset): (WebInspector.ResourcesPanel.prototype._innerShowView): (WebInspector.FrameResourceTreeElement): (WebInspector.FrameResourceTreeElement.prototype._errorsWarningsUpdated): (WebInspector.FrameResourceTreeElement.prototype._contentChanged.else.finished): (WebInspector.FrameResourceTreeElement.prototype._contentChanged): (WebInspector.ResourceRevisionTreeElement):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.get scrollTop): (WebInspector.SourceFrame.prototype.set scrollTop):
- inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.get scrollTop): (WebInspector.SourceView.prototype.set scrollTop): (WebInspector.SourceView.prototype._editLine): (WebInspector.SourceView.prototype._editLineComplete):
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype):
- 10:03 AM Changeset in webkit [72683] by
-
- 24 edits in trunk
2010-11-24 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: extension API cleanup
https://bugs.webkit.org/show_bug.cgi?id=50019
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged): (WebInspector.ElementsPanel):
- inspector/front-end/ExtensionAPI.js: See bug for summary of extension API changes. (WebInspector.injectedExtensionAPI.Resources.resourceDispatch): (WebInspector.injectedExtensionAPI): (WebInspector.injectedExtensionAPI.Resources.prototype.getHAR): (WebInspector.injectedExtensionAPI.ResourceImpl.prototype.getContent): (WebInspector.injectedExtensionAPI.Panels.prototype.create): (WebInspector.injectedExtensionAPI.PanelImpl): (WebInspector.injectedExtensionAPI.PanelWithSidebarImpl): (WebInspector.injectedExtensionAPI.PanelWithSidebarImpl.prototype.createSidebarPane): (WebInspector.injectedExtensionAPI.PanelWithSidebarImpl.prototype.createWatchExpressionSidebarPane): (WebInspector.injectedExtensionAPI.ElementsPanel): (WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setHeight): (WebInspector.injectedExtensionAPI.Audits.prototype.addCategory): (WebInspector.injectedExtensionAPI.AuditCategoryImpl.auditResultDispatch): (WebInspector.injectedExtensionAPI.AuditCategoryImpl): (WebInspector.injectedExtensionAPI.AuditResultImpl.prototype.get Severity): (WebInspector.injectedExtensionAPI.InspectedWindow): (WebInspector.injectedExtensionAPI.InspectedWindow.prototype.eval):
- inspector/front-end/ExtensionCommon.js: (WebInspector.commonExtensionSymbols):
- inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer): (WebInspector.ExtensionServer.prototype.notifyObjectSelected): (WebInspector.ExtensionServer.prototype.notifyResourceFinished): (WebInspector.ExtensionServer.prototype.notifyPageLoaded): (WebInspector.ExtensionServer.prototype.notifyPageDOMContentLoaded): (WebInspector.ExtensionServer.prototype._onCreatePanel): (WebInspector.ExtensionServer.prototype._onReload): (WebInspector.ExtensionServer.prototype._onGetHAR): (WebInspector.ExtensionServer.prototype._onGetResourceContent): (WebInspector.ExtensionServer.prototype._onAddAuditCategory): (WebInspector.ExtensionServer.prototype._buildExtensionAPIInjectedScript):
- inspector/front-end/HAREntry.js: (WebInspector.HARLog): (WebInspector.HARLog.prototype.build): (WebInspector.HARLog.prototype._convertResource):
- inspector/front-end/inspector.js: (WebInspector.domContentEventFired): (WebInspector.loadEventFired): (WebInspector.didCommitLoad):
2010-11-24 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: extension API cleanup
Improve synchronization between different parts of the test to reduce flakiness.
https://bugs.webkit.org/show_bug.cgi?id=50019
- http/tests/inspector/inspector-test2.js: Clean inspected page test output before pushing output from front-end. (initialize_InspectorTest.InspectorTest.completeTest): Delay test completion until page's onload is completed after reload. (initialize_InspectorTest.InspectorTest.addResult.clearResults): (initialize_InspectorTest.InspectorTest.reloadPageIfNeeded): (output):
- inspector/extensions-api-expected.txt:
- inspector/extensions-audits-api-expected.txt:
- inspector/extensions-audits-expected.txt:
- inspector/extensions-audits-tests.js: (extension_runAudits): (initialize_ExtensionsAuditsTest.InspectorTest.startExtensionAudits.onAuditsDone): (initialize_ExtensionsAuditsTest.InspectorTest.startExtensionAudits): (initialize_ExtensionsAuditsTest): (test):
- inspector/extensions-eval-expected.txt:
- inspector/extensions-eval.html:
- inspector/extensions-events-expected.txt:
- inspector/extensions-events.html:
- inspector/extensions-resources-expected.txt:
- inspector/extensions-resources.html:
- inspector/extensions-test.js: (initialize_ExtensionsTest.InspectorTest.dispatchOnMessage): (initialize_ExtensionsTest.InspectorTest.runExtensionTests): (initialize_ExtensionsTest.extensionOutput): (initialize_ExtensionsTest.dumpSidebarContent): (initialize_ExtensionsTest.reloadPage):
- inspector/extensions.html:
- inspector/resources/extension-main.html:
- inspector/resources/extension-main.js: (fetchTests.callback): (fetchTests): (onTestsDone): (dispatchOnFrontend):
- 9:57 AM Changeset in webkit [72682] by
-
- 8 edits2 adds in trunk
2010-11-23 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Fix minor errors in IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=49970
- storage/indexeddb/constants-expected.txt:
- storage/indexeddb/constants.html:
- storage/indexeddb/createAndRemoveObjectStore-expected.txt: Added.
- storage/indexeddb/createAndRemoveObjectStore.html: Added.
2010-11-23 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Fix minor errors in IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=49970
- Remove SNAPSHOT_READ per spec.
- Assert that the transaction that changes the db is a setVersion transaction.
- When an objectStore already exists, throw a CONSTRAINT_ERR.
- When not in a setVersion transaction, throw a NOT_ALLOWED_ERR.
Test: storage/indexeddb/createAndRemoveObjectStore.html
- storage/IDBDatabase.cpp: (WebCore::IDBDatabase::createObjectStore):
- storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::createObjectStore):
- storage/IDBTransaction.h:
- storage/IDBTransaction.idl:
- 9:51 AM Changeset in webkit [72681] by
-
- 2 edits in trunk/WebKit/gtk
2010-11-24 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
Fix crashes in GTK+ bots. Use kit() instead of wrapFoo, otherwise
the DOM objects won't be in the cache and we'll ASSERT when
unreffing them.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::shouldDeleteRange): use kit to get the GObject wrapper for the DOM object. (WebKit::EditorClient::shouldShowDeleteInterface): ditto. (WebKit::EditorClient::shouldBeginEditing): ditto. (WebKit::EditorClient::shouldEndEditing): ditto. (WebKit::EditorClient::shouldInsertText): ditto. (WebKit::EditorClient::shouldChangeSelectedRange): ditto. (WebKit::EditorClient::shouldApplyStyle): ditto. (WebKit::EditorClient::shouldInsertNode): ditto.
- 9:49 AM Changeset in webkit [72680] by
-
- 3 edits in trunk/WebCore
2010-11-24 Philippe Normand <pnormand@igalia.com>
Reviewed by Xan Lopez.
[GStreamer] pause webkitvideosink during fullscreen video playback
https://bugs.webkit.org/show_bug.cgi?id=48824
Added an identity element before the webkitvideosink so that when
fullscreen video is active the element can drop the incoming
buffers so that webkitvideosink appears paused.
- platform/graphics/gstreamer/GStreamerGWorld.cpp: (WebCore::GStreamerGWorld::enterFullscreen): (WebCore::GStreamerGWorld::exitFullscreen):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
- 9:45 AM Changeset in webkit [72679] by
-
- 2 edits in trunk/LayoutTests
2010-11-24 Alejandro G. Castro <alex@igalia.com>
Unreviewed, skip mathml/presentation again, apparently the issue
is still happening in the bots.
- platform/gtk/Skipped:
- 9:31 AM QtWebKitTesting edited by
- (diff)
- 9:20 AM Changeset in webkit [72678] by
-
- 4 edits2 adds in trunk
2010-11-24 Avi Drissman <avi@google.com>
Reviewed by Antonio Gomes.
Add preference to not select when right-clicked
https://bugs.webkit.org/show_bug.cgi?id=23351
- editing/selection/context-menu-text-selection-expected.txt: Added.
- editing/selection/context-menu-text-selection.html: Added.
2010-11-24 Avi Drissman <avi@google.com>
Reviewed by Antonio Gomes.
Add preference to not select when right-clicked
https://bugs.webkit.org/show_bug.cgi?id=23351
Test: editing/selection/context-menu-text-selection.html
- editing/EditingBehavior.h: (WebCore::EditingBehavior::shouldSelectOnContextualMenuClick):
- page/EventHandler.cpp: (WebCore::EventHandler::sendContextMenuEvent):
- 9:18 AM Changeset in webkit [72677] by
-
- 2 edits in trunk/WebKitTools
2010-11-24 Andras Becsi <abecsi@inf.u-szeged.hu>
Unreviewed.
Add my other email address to committers.py.
- Scripts/webkitpy/common/config/committers.py:
- 9:07 AM Changeset in webkit [72676] by
-
- 4 edits in trunk
2010-11-24 Andras Becsi <abecsi@inf.u-szeged.hu>
Reviewed by Csaba Osztrogonác.
Make build-webkit --minimal build with ENABLE_INSPECTOR=0.
https://bugs.webkit.org/show_bug.cgi?id=49975
No new tests needed.
- features.pri: Make the Qt buildsystem aware that the inspector is enabled by default.
2010-11-24 Andras Becsi <abecsi@inf.u-szeged.hu>
Reviewed by Csaba Osztrogonác.
Make build-webkit --minimal build with ENABLE_INSPECTOR=0
https://bugs.webkit.org/show_bug.cgi?id=49975
- Scripts/build-webkit: Add ENABLE_INSPECTOR define to features, to enable the script to define it 0 in case of a minimal build.
- 8:43 AM Changeset in webkit [72675] by
-
- 149 edits34 adds1 delete in trunk
2010-11-24 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] The WebKitWebView should expose a set of signals encapsulating the behavior of the EditorClient
https://bugs.webkit.org/show_bug.cgi?id=49143
Unskip passing editing tests.
- platform/gtk/Skipped:
- platform/gtk/Skipped.rej: Added.
- platform/gtk/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
- platform/gtk/editing/deleting/delete-3608430-fix-expected.txt:
- platform/gtk/editing/deleting/delete-3608445-fix-expected.txt:
- platform/gtk/editing/deleting/delete-3608462-fix-expected.txt:
- platform/gtk/editing/deleting/delete-3775172-fix-expected.txt:
- platform/gtk/editing/deleting/delete-3800834-fix-expected.txt:
- platform/gtk/editing/deleting/delete-3959464-fix-expected.txt:
- platform/gtk/editing/deleting/delete-and-undo-expected.txt:
- platform/gtk/editing/deleting/delete-block-contents-001-expected.txt:
- platform/gtk/editing/deleting/delete-block-contents-002-expected.txt:
- platform/gtk/editing/deleting/delete-block-contents-003-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-010-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-012-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-013-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-014-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-015-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-016-expected.txt:
- platform/gtk/editing/deleting/delete-block-merge-contents-017-expected.txt:
- platform/gtk/editing/deleting/delete-br-001-expected.txt:
- platform/gtk/editing/deleting/delete-br-002-expected.txt:
- platform/gtk/editing/deleting/delete-br-003-expected.txt:
- platform/gtk/editing/deleting/delete-br-004-expected.txt:
- platform/gtk/editing/deleting/delete-br-005-expected.txt:
- platform/gtk/editing/deleting/delete-br-006-expected.txt:
- platform/gtk/editing/deleting/delete-br-007-expected.txt:
- platform/gtk/editing/deleting/delete-br-010-expected.txt:
- platform/gtk/editing/deleting/delete-contiguous-ws-001-expected.txt:
- platform/gtk/editing/deleting/delete-image-004-expected.txt:
- platform/gtk/editing/deleting/delete-leading-ws-001-expected.txt:
- platform/gtk/editing/deleting/delete-line-001-expected.txt:
- platform/gtk/editing/deleting/delete-line-002-expected.txt:
- platform/gtk/editing/deleting/delete-line-005-expected.txt:
- platform/gtk/editing/deleting/delete-line-006-expected.txt:
- platform/gtk/editing/deleting/delete-line-007-expected.txt:
- platform/gtk/editing/deleting/delete-line-008-expected.txt:
- platform/gtk/editing/deleting/delete-line-009-expected.txt:
- platform/gtk/editing/deleting/delete-line-010-expected.txt:
- platform/gtk/editing/deleting/delete-line-011-expected.txt:
- platform/gtk/editing/deleting/delete-line-012-expected.txt:
- platform/gtk/editing/deleting/delete-line-013-expected.txt:
- platform/gtk/editing/deleting/delete-line-014-expected.txt:
- platform/gtk/editing/deleting/delete-line-end-ws-001-expected.txt:
- platform/gtk/editing/deleting/delete-line-end-ws-002-expected.txt:
- platform/gtk/editing/deleting/delete-listitem-001-expected.txt:
- platform/gtk/editing/deleting/delete-listitem-002-expected.txt:
- platform/gtk/editing/deleting/delete-select-all-002-expected.txt:
- platform/gtk/editing/deleting/delete-tab-002-expected.txt:
- platform/gtk/editing/deleting/delete-tab-004-expected.txt:
- platform/gtk/editing/deleting/delete-to-end-of-paragraph-expected.txt:
- platform/gtk/editing/deleting/delete-to-select-table-expected.txt:
- platform/gtk/editing/deleting/delete-trailing-ws-002-expected.txt:
- platform/gtk/editing/deleting/delete-ws-fixup-001-expected.txt:
- platform/gtk/editing/deleting/delete-ws-fixup-002-expected.txt:
- platform/gtk/editing/deleting/forward-delete-expected.txt:
- platform/gtk/editing/deleting/smart-delete-003-expected.txt:
- platform/gtk/editing/deleting/smart-delete-004-expected.txt:
- platform/gtk/editing/execCommand/4641880-1-expected.txt: Added.
- platform/gtk/editing/execCommand/4641880-2-expected.txt: Added.
- platform/gtk/editing/execCommand/create-list-with-hr-expected.txt: Added.
- platform/gtk/editing/execCommand/find-after-replace-expected.txt: Added.
- platform/gtk/editing/execCommand/findString-2-expected.txt: Added.
- platform/gtk/editing/execCommand/findString-diacriticals-expected.txt: Added.
- platform/gtk/editing/execCommand/findString-expected.txt: Added.
- platform/gtk/editing/execCommand/format-block-with-trailing-br-expected.txt: Added.
- platform/gtk/editing/execCommand/indent-empty-root-expected.txt: Added.
- platform/gtk/editing/execCommand/indent-list-item-expected.txt: Added.
- platform/gtk/editing/execCommand/indent-paragraphs-expected.txt: Removed.
- platform/gtk/editing/execCommand/indent-selection-expected.txt: Added.
- platform/gtk/editing/execCommand/insert-list-and-stitch-expected.txt: Added.
- platform/gtk/editing/execCommand/insertHorizontalRule-expected.txt: Added.
- platform/gtk/editing/execCommand/insertImage-expected.txt: Added.
- platform/gtk/editing/execCommand/nsresponder-indent-expected.txt: Added.
- platform/gtk/editing/execCommand/nsresponder-outdent-expected.txt: Added.
- platform/gtk/editing/execCommand/outdent-blockquote-test1-expected.txt: Added.
- platform/gtk/editing/execCommand/outdent-blockquote-test2-expected.txt: Added.
- platform/gtk/editing/execCommand/outdent-blockquote-test3-expected.txt: Added.
- platform/gtk/editing/execCommand/outdent-blockquote-test4-expected.txt: Added.
- platform/gtk/editing/execCommand/outdent-selection-expected.txt: Added.
- platform/gtk/editing/execCommand/paste-1-expected.txt: Added.
- platform/gtk/editing/execCommand/paste-2-expected.txt: Added.
- platform/gtk/editing/execCommand/remove-list-from-range-selection-expected.txt: Added.
- platform/gtk/editing/execCommand/remove-list-item-1-expected.txt: Added.
- platform/gtk/editing/execCommand/selectAll-expected.txt: Added.
- platform/gtk/editing/inserting/insert-3654864-fix-expected.txt:
- platform/gtk/editing/inserting/insert-3775316-fix-expected.txt:
- platform/gtk/editing/inserting/insert-3800346-fix-expected.txt:
- platform/gtk/editing/inserting/insert-3851164-fix-expected.txt:
- platform/gtk/editing/inserting/insert-3907422-fix-expected.txt:
- platform/gtk/editing/inserting/insert-after-delete-001-expected.txt:
- platform/gtk/editing/inserting/insert-br-005-expected.txt:
- platform/gtk/editing/inserting/insert-div-001-expected.txt:
- platform/gtk/editing/inserting/insert-div-002-expected.txt:
- platform/gtk/editing/inserting/insert-div-003-expected.txt:
- platform/gtk/editing/inserting/insert-div-004-expected.txt:
- platform/gtk/editing/inserting/insert-div-005-expected.txt:
- platform/gtk/editing/inserting/insert-div-009-expected.txt:
- platform/gtk/editing/inserting/insert-div-024-expected.txt:
- platform/gtk/editing/inserting/insert-space-in-empty-doc-expected.txt:
- platform/gtk/editing/inserting/insert-text-with-newlines-expected.txt:
- platform/gtk/editing/inserting/redo-expected.txt:
- platform/gtk/editing/inserting/typing-001-expected.txt:
- platform/gtk/editing/inserting/typing-002-expected.txt:
- platform/gtk/editing/inserting/typing-003-expected.txt:
- platform/gtk/editing/inserting/typing-around-br-001-expected.txt:
- platform/gtk/editing/inserting/typing-around-image-001-expected.txt:
- platform/gtk/editing/pasteboard/4076267-2-expected.txt:
- platform/gtk/editing/pasteboard/4076267-3-expected.txt:
- platform/gtk/editing/pasteboard/4076267-expected.txt:
- platform/gtk/editing/pasteboard/5368833-expected.txt: Added.
- platform/gtk/editing/pasteboard/cut-text-001-expected.txt:
- platform/gtk/editing/pasteboard/drag-drop-dead-frame-expected.txt:
- platform/gtk/editing/pasteboard/drag-drop-modifies-page-expected.txt:
- platform/gtk/editing/pasteboard/drag-selected-image-to-contenteditable-expected.txt:
- platform/gtk/editing/pasteboard/drop-text-without-selection-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-001-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-002-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-003-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-004-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-005-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-006-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-007-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-008-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-009-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-010-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-013-expected.txt: Added.
- platform/gtk/editing/pasteboard/paste-text-015-expected.txt:
- platform/gtk/editing/pasteboard/paste-xml-expected.txt:
- platform/gtk/editing/pasteboard/subframe-dragndrop-1-expected.txt:
- platform/gtk/editing/selection/4889598-expected.txt:
- platform/gtk/editing/selection/4947387-expected.txt: Added.
- platform/gtk/editing/selection/5195166-2-expected.txt: Added.
- platform/gtk/editing/selection/extend-by-character-002-expected.txt:
- platform/gtk/editing/selection/extend-by-character-003-expected.txt:
- platform/gtk/editing/selection/extend-by-character-004-expected.txt:
- platform/gtk/editing/selection/extend-by-character-005-expected.txt:
- platform/gtk/editing/selection/extend-selection-bidi-expected.txt: Added.
- platform/gtk/editing/selection/fake-drag-expected.txt:
- platform/gtk/editing/selection/iframe-expected.txt:
- platform/gtk/editing/selection/inline-table-expected.txt:
- platform/gtk/editing/selection/move-backwords-by-word-001-expected.txt:
- platform/gtk/editing/selection/move-between-blocks-no-001-expected.txt:
- platform/gtk/editing/selection/move-between-blocks-yes-001-expected.txt:
- platform/gtk/editing/selection/move-by-character-001-expected.txt:
- platform/gtk/editing/selection/move-by-character-002-expected.txt:
- platform/gtk/editing/selection/move-by-character-003-expected.txt:
- platform/gtk/editing/selection/move-by-character-004-expected.txt:
- platform/gtk/editing/selection/move-by-character-005-expected.txt:
- platform/gtk/editing/selection/move-by-sentence-001-expected.txt:
- platform/gtk/editing/selection/move-past-trailing-space-expected.txt:
- platform/gtk/editing/selection/select-box-expected.txt:
- platform/gtk/editing/selection/selection-actions-expected.txt:
- platform/gtk/editing/spelling/spelling-expected.txt:
- platform/gtk/editing/style/block-style-003-expected.txt:
- platform/gtk/editing/style/relative-font-size-change-001-expected.txt:
- platform/gtk/editing/style/style-3681552-fix-001-expected.txt:
- platform/gtk/editing/style/style-3681552-fix-002-expected.txt:
- platform/gtk/editing/style/typing-style-001-expected.txt:
- platform/gtk/editing/style/typing-style-002-expected.txt:
- platform/gtk/editing/style/unbold-in-bold-expected.txt:
- platform/gtk/editing/undo/4063751-expected.txt:
- platform/gtk/editing/undo/redo-typing-001-expected.txt:
- platform/gtk/editing/undo/undo-combined-delete-boundary-expected.txt:
- platform/gtk/editing/undo/undo-combined-delete-expected.txt:
- platform/gtk/editing/undo/undo-delete-boundary-expected.txt:
- platform/gtk/editing/undo/undo-delete-expected.txt:
- platform/gtk/editing/undo/undo-forward-delete-boundary-expected.txt:
- platform/gtk/editing/undo/undo-forward-delete-expected.txt:
- platform/gtk/editing/undo/undo-misspellings-expected.txt:
2010-11-24 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] The WebKitWebView should expose a set of signals encapsulating the behavior of the EditorClient
https://bugs.webkit.org/show_bug.cgi?id=49143
- platform/gtk/GtkVersioning.c: (g_signal_accumulator_first_wins): Add g_signal_accumulator_first_wins for versions of GLib before 2.28.
- platform/gtk/GtkVersioning.h:
2010-11-24 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] The WebKitWebView should expose a set of signals encapsulating the behavior of the EditorClient
https://bugs.webkit.org/show_bug.cgi?id=49143
Add signals that encapsulate the functionality of the Mac EditingDelegate. These signals
are private for now, but DRT consumes them to produce proper output for editing tests.
After some time, these may be part of the public API.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::shouldDeleteRange): Fire the appropriate editing signal. (WebKit::EditorClient::shouldShowDeleteInterface): Ditto. (WebKit::EditorClient::shouldBeginEditing): Ditto. (WebKit::EditorClient::shouldEndEditing): Ditto. (WebKit::kit): Added helper function. (WebKit::EditorClient::shouldInsertText): Fire the appropriate editing signal. (WebKit::EditorClient::shouldChangeSelectedRange): Ditto. (WebKit::EditorClient::shouldApplyStyle): Ditto. (WebKit::EditorClient::didBeginEditing): Ditto. (WebKit::EditorClient::respondToChangedContents): Ditto. (WebKit::EditorClient::respondToChangedSelection): Ditto. (WebKit::EditorClient::didEndEditing): Ditto. (WebKit::EditorClient::shouldInsertNode): Ditto.
- webkit/webkitwebview.cpp: (webkit_web_view_real_should_allow_editing_action): Added this default signal callback which explicitly allows cancellable editing actions. (webkit_web_view_class_init): Add new editing signal declarations to the view.
- webkit/webkitwebview.h:
- webkitmarshal.list: Added some new marshaling definitions.
2010-11-24 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] The WebKitWebView should expose a set of signals encapsulating the behavior of the EditorClient
https://bugs.webkit.org/show_bug.cgi?id=49143
- DumpRenderTree/gtk/DumpRenderTree.cpp: (createWebView): Call the new connectEditingCallbacks function.
- DumpRenderTree/gtk/EditingCallbacks.cpp: Added. (dumpNodePath): (dumpRange): (insertActionString): (selectionAffinityString): (shouldBeginEditing): (shouldEndEditing): (shouldInsertNode): (shouldInsertText): (shouldDeleteRange): (shouldShowDeleteInterfaceForElement): (shouldChangeSelectedRange): (shouldApplyStyle): (editingBegan): (userChangedContents): (editingEnded): (selectionChanged): (connectEditingCallbacks):
- DumpRenderTree/gtk/EditingCallbacks.h: Added.
- GNUmakefile.am: Added EditingCallbacks.{h,cpp} to the source list.
- 8:21 AM Changeset in webkit [72674] by
-
- 19 edits in trunk/LayoutTests
2010-11-24 Alejandro G. Castro <alex@igalia.com>
Unreviewed, rebaselined mathml/presentation using bots results.
- platform/gtk/mathml/presentation/attributes-expected.txt:
- platform/gtk/mathml/presentation/fenced-expected.txt:
- platform/gtk/mathml/presentation/fenced-mi-expected.txt:
- platform/gtk/mathml/presentation/fractions-expected.txt:
- platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.txt:
- platform/gtk/mathml/presentation/mo-expected.txt:
- platform/gtk/mathml/presentation/over-expected.txt:
- platform/gtk/mathml/presentation/roots-expected.txt:
- platform/gtk/mathml/presentation/row-alignment-expected.txt:
- platform/gtk/mathml/presentation/row-expected.txt:
- platform/gtk/mathml/presentation/style-expected.txt:
- platform/gtk/mathml/presentation/sub-expected.txt:
- platform/gtk/mathml/presentation/subsup-expected.txt:
- platform/gtk/mathml/presentation/sup-expected.txt:
- platform/gtk/mathml/presentation/tables-expected.txt:
- platform/gtk/mathml/presentation/tokenElements-expected.txt:
- platform/gtk/mathml/presentation/under-expected.txt:
- platform/gtk/mathml/presentation/underover-expected.txt:
- 7:56 AM Changeset in webkit [72673] by
-
- 8 edits in trunk
2010-11-24 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r72499.
http://trac.webkit.org/changeset/72499
https://bugs.webkit.org/show_bug.cgi?id=50022
This change is causing crashes on the bots. (Requested by
mrobinson on #webkit).
- accessibility/AccessibilityMenuListOption.cpp: (WebCore::AccessibilityMenuListOption::nameForMSAA):
- accessibility/AccessibilityMenuListOption.h:
- accessibility/gtk/AXObjectCacheAtk.cpp: (WebCore::AXObjectCache::postPlatformNotification):
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (setAtkStateSetFromCoreObject): (optionFromList): (optionFromSelection): (webkit_accessible_selection_add_selection): (webkit_accessible_selection_clear_selection): (webkit_accessible_selection_get_selection_count): (webkit_accessible_selection_is_child_selected): (webkit_accessible_selection_remove_selection): (webkit_accessible_text_get_text): (getInterfaceMaskFromObject):
- platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenuGtk::show):
2010-11-24 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r72499.
http://trac.webkit.org/changeset/72499
https://bugs.webkit.org/show_bug.cgi?id=50022
This change is causing crashes on the bots. (Requested by
mrobinson on #webkit).
- tests/testatk.c: (main):
- 7:51 AM Changeset in webkit [72672] by
-
- 3 edits in trunk/WebCore
2010-11-24 Patrick Gansterer <Patrick Gansterer>
Reviewed by Csaba Osztrogonác.
Simplify makeprop.pl
https://bugs.webkit.org/show_bug.cgi?id=49925
Don't generate CSSPropertyNamesHash.h.
Instead generate CSSPropertyNames directly.
- GNUmakefile.am: Removed rule for CSSPropertyNamesHash.h.
- css/makeprop.pl:
- 7:49 AM Changeset in webkit [72671] by
-
- 2 edits in trunk/WebKitTools
2010-11-24 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Andreas Kling.
[Qt] Make QtTestBrowser remember the selected user agent
https://bugs.webkit.org/show_bug.cgi?id=50021
Set user agent for a new page by using the old page's
- QtTestBrowser/mainwindow.cpp: (MainWindow::setPage):
- 7:42 AM WikiStart edited by
- r72669 removed remaining Bakefile build system files (diff)
- 7:38 AM Changeset in webkit [72670] by
-
- 56 edits in trunk/LayoutTests
2010-11-24 Alejandro G. Castro <alex@igalia.com>
Unreviewed, unskipped and rebaselined mathml/presentation tests
after r72413
- platform/gtk/Skipped:
- platform/gtk/mathml/presentation/attributes-expected.checksum:
- platform/gtk/mathml/presentation/attributes-expected.png:
- platform/gtk/mathml/presentation/attributes-expected.txt:
- platform/gtk/mathml/presentation/fenced-expected.checksum:
- platform/gtk/mathml/presentation/fenced-expected.png:
- platform/gtk/mathml/presentation/fenced-expected.txt:
- platform/gtk/mathml/presentation/fenced-mi-expected.checksum:
- platform/gtk/mathml/presentation/fenced-mi-expected.png:
- platform/gtk/mathml/presentation/fenced-mi-expected.txt:
- platform/gtk/mathml/presentation/fractions-expected.checksum:
- platform/gtk/mathml/presentation/fractions-expected.png:
- platform/gtk/mathml/presentation/fractions-expected.txt:
- platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.checksum:
- platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.png:
- platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.txt:
- platform/gtk/mathml/presentation/mo-expected.checksum:
- platform/gtk/mathml/presentation/mo-expected.png:
- platform/gtk/mathml/presentation/mo-expected.txt:
- platform/gtk/mathml/presentation/over-expected.checksum:
- platform/gtk/mathml/presentation/over-expected.png:
- platform/gtk/mathml/presentation/over-expected.txt:
- platform/gtk/mathml/presentation/roots-expected.checksum:
- platform/gtk/mathml/presentation/roots-expected.png:
- platform/gtk/mathml/presentation/roots-expected.txt:
- platform/gtk/mathml/presentation/row-alignment-expected.checksum:
- platform/gtk/mathml/presentation/row-alignment-expected.png:
- platform/gtk/mathml/presentation/row-alignment-expected.txt:
- platform/gtk/mathml/presentation/row-expected.checksum:
- platform/gtk/mathml/presentation/row-expected.png:
- platform/gtk/mathml/presentation/row-expected.txt:
- platform/gtk/mathml/presentation/style-expected.checksum:
- platform/gtk/mathml/presentation/style-expected.png:
- platform/gtk/mathml/presentation/style-expected.txt:
- platform/gtk/mathml/presentation/sub-expected.checksum:
- platform/gtk/mathml/presentation/sub-expected.png:
- platform/gtk/mathml/presentation/sub-expected.txt:
- platform/gtk/mathml/presentation/subsup-expected.checksum:
- platform/gtk/mathml/presentation/subsup-expected.png:
- platform/gtk/mathml/presentation/subsup-expected.txt:
- platform/gtk/mathml/presentation/sup-expected.checksum:
- platform/gtk/mathml/presentation/sup-expected.png:
- platform/gtk/mathml/presentation/sup-expected.txt:
- platform/gtk/mathml/presentation/tables-expected.checksum:
- platform/gtk/mathml/presentation/tables-expected.png:
- platform/gtk/mathml/presentation/tables-expected.txt:
- platform/gtk/mathml/presentation/tokenElements-expected.checksum:
- platform/gtk/mathml/presentation/tokenElements-expected.png:
- platform/gtk/mathml/presentation/tokenElements-expected.txt:
- platform/gtk/mathml/presentation/under-expected.checksum:
- platform/gtk/mathml/presentation/under-expected.png:
- platform/gtk/mathml/presentation/under-expected.txt:
- platform/gtk/mathml/presentation/underover-expected.checksum:
- platform/gtk/mathml/presentation/underover-expected.png:
- platform/gtk/mathml/presentation/underover-expected.txt:
- 7:35 AM Changeset in webkit [72669] by
-
- 4 edits14 deletes in trunk
2010-11-24 Patrick Gansterer <Patrick Gansterer>
Reviewed by Csaba Osztrogonác.
Remove Bakefile build system files
https://bugs.webkit.org/show_bug.cgi?id=49983
r53757 only removed the content, but not the files.
This patch removes that empty files.
- 7:21 AM Changeset in webkit [72668] by
-
- 2 edits in trunk/WebCore
[Qt] GraphicsContext: Clean up Qt/WebCore type conversion functions
https://bugs.webkit.org/show_bug.cgi?id=49919
Reviewed by Andreas Kling.
Add ASSERT_NOT_REACHED() if the given WebCore type doesn't have an equivalent type in Qt.
Also change the return value of toQtLineJoin() from Qt::MiterJoin to the default Qt::SvgMiterJoin,
because the previous one doesn't work currently.
No new test is needed.
- platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::toQtCompositionMode):
(WebCore::toQtLineCap):
(WebCore::toQtLineJoin):
(WebCore::toQPenStyle):
(WebCore::toQtFillRule):
- 6:55 AM QtWebKitContrib edited by
- Adding reference to QtWebKitTesting and the testing VM (diff)
- 6:54 AM QtWebKitTesting created by
- 6:51 AM Changeset in webkit [72667] by
-
- 3 edits in trunk/WebCore
2010-11-24 Patrick Gansterer <Patrick Gansterer>
Reviewed by Csaba Osztrogonác.
Simplify makevalues.pl
https://bugs.webkit.org/show_bug.cgi?id=49926
Don't generate CSSValueKeywordsHash.h.
Instead generate CSSValueKeywords.cpp directly.
- GNUmakefile.am: Removed rule for CSSValueKeywordsHash.h.
- css/makevalues.pl:
- 6:38 AM Changeset in webkit [72666] by
-
- 37 edits in trunk
2010-11-24 Andras Becsi <abecsi@inf.u-szeged.hu>
Reviewed by Kenneth Rohde Christiansen.
Make WebKit2 compile with !ENABLE(INSPECTOR).
https://bugs.webkit.org/show_bug.cgi?id=49973
No new tests needed.
- bindings/js/ScriptHeapSnapshot.h:
- bindings/js/ScriptProfile.cpp:
- bindings/js/ScriptProfile.h:
- inspector/InspectorDebuggerAgent.cpp:
- inspector/InspectorDebuggerAgent.h:
- inspector/InspectorProfilerAgent.cpp:
- inspector/InspectorProfilerAgent.h:
- inspector/ScriptBreakpoint.h:
2010-11-24 Andras Becsi <abecsi@inf.u-szeged.hu>
Reviewed by Kenneth Rohde Christiansen.
Make WebKit2 compile with !ENABLE(INSPECTOR).
https://bugs.webkit.org/show_bug.cgi?id=49973
- WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::setJavaScriptProfilingEnabled):
2010-11-24 Andras Becsi <abecsi@inf.u-szeged.hu>
Reviewed by Kenneth Rohde Christiansen.
Make WebKit2 compile with !ENABLE(INSPECTOR).
https://bugs.webkit.org/show_bug.cgi?id=49973
- Shared/API/c/WKSharedAPICast.h: (WebKit::toAPI): (WebKit::toImpl):
- UIProcess/API/C/WKAPICast.h:
- UIProcess/API/C/WKInspector.cpp:
- UIProcess/API/C/WKInspector.h:
- UIProcess/API/C/WKPage.cpp:
- UIProcess/API/C/WKPage.h:
- UIProcess/WebInspectorProxy.cpp:
- UIProcess/WebInspectorProxy.h:
- UIProcess/WebInspectorProxy.messages.in:
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::close): (WebKit::WebPageProxy::didReceiveMessage): (WebKit::WebPageProxy::didReceiveSyncMessage): (WebKit::WebPageProxy::processDidCrash):
- UIProcess/WebPageProxy.h:
- UIProcess/mac/WebInspectorProxyMac.mm:
- UIProcess/qt/WebInspectorProxyQt.cpp:
- UIProcess/win/WebInspectorProxyWin.cpp:
- WebProcess/WebCoreSupport/WebInspectorClient.cpp:
- WebProcess/WebCoreSupport/WebInspectorClient.h:
- WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
- WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:
- WebProcess/WebPage/WebInspector.cpp:
- WebProcess/WebPage/WebInspector.h:
- WebProcess/WebPage/WebInspector.messages.in:
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage): (WebKit::WebPage::close): (WebKit::WebPage::windowIsFocused): (WebKit::WebPage::didReceiveMessage):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/qt/WebInspectorQt.cpp:
- WebProcess/WebPage/win/WebInspectorWin.cpp:
- 5:47 AM Changeset in webkit [72665] by
-
- 2 edits in trunk/WebKit2
2010-11-24 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt][WK2] Make deep copies of tile images
We need the tile images we get from UpdateChunk::createImage() to persist,
so we should take a copy() of them.
- UIProcess/qt/TiledDrawingAreaTileQt.cpp: (WebKit::TiledDrawingAreaTile::updateFromChunk):
- 5:26 AM Changeset in webkit [72664] by
-
- 4 edits1 add in trunk/WebCore
2010-11-24 Patrick Gansterer <Patrick Gansterer>
Reviewed by Csaba Osztrogonác.
Simplify make-hash-tools.pl
https://bugs.webkit.org/show_bug.cgi?id=49922
HashTools.h does not need to be generated, because it only contains static code.
- html/DocTypeStrings.gperf: Include findDoctypeEntry function.
- make-hash-tools.pl: Do not generate HashTools.h.
- platform/ColorData.gperf: Include findColor function.
- platform/HashTools.h: Added.
- 5:04 AM Changeset in webkit [72663] by
-
- 3 edits in trunk/JavaScriptCore
2010-11-24 Gabor Loki <loki@webkit.org>
Reviewed by Csaba Osztrogonác.
Merge the usage of jumps and calls at ARM-JIT
https://bugs.webkit.org/show_bug.cgi?id=50008
Those JmpSrc objects which represent jumps (not calls) should point to
after the jump instruction.
- assembler/ARMAssembler.h: (JSC::ARMAssembler::blx): (JSC::ARMAssembler::loadBranchTarget): (JSC::ARMAssembler::getAbsoluteJumpAddress): (JSC::ARMAssembler::linkJump): (JSC::ARMAssembler::relinkJump): (JSC::ARMAssembler::linkCall): (JSC::ARMAssembler::relinkCall): (JSC::ARMAssembler::getRelocatedAddress): (JSC::ARMAssembler::getDifferenceBetweenLabels): (JSC::ARMAssembler::getCallReturnOffset):
- assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::call):
- 4:51 AM Changeset in webkit [72662] by
-
- 2 edits in trunk/JavaScriptCore
2010-11-24 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Xan Lopez.
[GTK] Optimize foldCase, toLower and toUpper methods in glib unicode backend
https://bugs.webkit.org/show_bug.cgi?id=48625
GLib methods use UTF-8 strings, so we have to convert from UTF-16 to
UTF-8 to perform the case operations and then convert back the result to
UTF-16. GLib conversion methods return a new allocated string, so we
have to memcpy the result into the destination buffer too. Using our
own methods to convert between UTF-8 and UTF-16 from wtf/unicode/UTF8.h
we don't need such memcpy, since they take an already allocated buffer
rather than returning a new one. There's another optimization for the
case when the destination buffer is not large enough. In that case,
methods should return the expected destination buffer size and are
called again with a new buffer. We can avoid the conversion to UTF-16 by
pre-calculating the required size for the destination buffer.
- wtf/unicode/glib/UnicodeGLib.cpp: (WTF::Unicode::getUTF16LengthFromUTF8): (WTF::Unicode::convertCase): (WTF::Unicode::foldCase): (WTF::Unicode::toLower): (WTF::Unicode::toUpper):
- 4:29 AM Changeset in webkit [72661] by
-
- 4 edits in trunk
2010-11-24 Satish Sampath <satish@chromium.org>
Reviewed by Steve Block.
Re-enabled layout tests which were disabled during an API migration.
https://bugs.webkit.org/show_bug.cgi?id=50013
- platform/chromium/test_expectations.txt:
2010-11-24 Satish Sampath <satish@chromium.org>
Reviewed by Steve Block.
Remove API migration code which is no longer used.
https://bugs.webkit.org/show_bug.cgi?id=50013
- public/WebSpeechInputControllerMock.h:
- 4:04 AM Changeset in webkit [72660] by
-
- 2 edits in trunk/WebCore
2010-11-24 Andreas Kling <kling@webkit.org>
Reviewed by Simon Hausmann.
[Qt] Pass Qt::TextBypassShaping flag when calculating shadow layer rects
Without this, we could end up with a slightly too small shadow layer
for some string/font combinations.
- platform/graphics/qt/FontQt.cpp: (WebCore::drawTextCommon):
- 4:00 AM Changeset in webkit [72659] by
-
- 2 edits in trunk/LayoutTests
2010-11-24 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed. chromium expectation fix.
BUG49967 MAC : font-size-zero.html = TEXT
was restored.
- platform/chromium/test_expectations.txt:
- 3:42 AM Changeset in webkit [72658] by
-
- 2 edits in trunk/LayoutTests
2010-11-24 Steve block <steveblock@google.com>
Reviewed by Jeremy Orlow.
LayoutTest fast/dom/DeviceOrientation/event-after-navigation.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=49384
This is an asynchronous script test which navigates the main page but
relies on js-test-post.js calling LayoutTestController.waitUntilDone().
It's possible for the main page to be navigated and hence the load of
js-test-post.js to be cancelled before
LayoutTestController.waitUntilDone() is called, which causes the test to
fail.
- fast/dom/DeviceOrientation/script-tests/event-after-navigation.js:
- 3:04 AM Changeset in webkit [72657] by
-
- 12 edits1 add in trunk
2010-11-22 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: add timing tab to the network item view.
https://bugs.webkit.org/show_bug.cgi?id=49920
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/NetworkItemView.js: (WebInspector.NetworkItemView):
- inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._showPopover):
- inspector/front-end/Resource.js: (WebInspector.Resource.prototype.set timing):
- inspector/front-end/ResourceTimingView.js: Added. (WebInspector.ResourceTimingView): (WebInspector.ResourceTimingView.prototype.show): (WebInspector.ResourceTimingView.prototype._refresh): (WebInspector.ResourceTimingView.createTimingTable):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- inspector/front-end/networkPanel.css: (#network-views .network-item-view .tabbed-pane-header): (.resource-timing-view): (.resource-timing-view table): (.resource-timing-view .network-timing-bar): (.resource-timing-view .network-timing-bar.proxy): (.resource-timing-view .network-timing-bar.dns): (.resource-timing-view .network-timing-bar.connecting): (.resource-timing-view .network-timing-bar.ssl): (.resource-timing-view .network-timing-bar.sending): (.resource-timing-view .network-timing-bar.waiting): (.resource-timing-view .network-timing-bar.receiving): (.resource-timing-view.visible):
- 2:59 AM Changeset in webkit [72656] by
-
- 2 edits in trunk/WebCore
2010-11-24 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Follow up to r72652 (style id change in inspector).
- inspector/front-end/AuditRules.js: (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):
- 2:36 AM Changeset in webkit [72655] by
-
- 18 edits4 adds in trunk/WebCore
2010-11-22 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: refactor ResourceView hierarchy.
https://bugs.webkit.org/show_bug.cgi?id=49864
This refactoring splits ResourceView.js into:
NetworkItemView.js (tabbed pane)
ResourceHeadersView.js (header tab)
ResourceCookiesView.js (cookies tab)
ResourceView.js (base class for content tab).
CookiesTable was extracted from CookieItemsView and
brushed up. headersVisible flag has been removed.
- English.lproj/localizedStrings.js:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView): (WebInspector.CookieItemsView.prototype.get statusBarItems): (WebInspector.CookieItemsView.prototype.hide): (WebInspector.CookieItemsView.prototype.resize): (WebInspector.CookieItemsView.prototype._updateWithCookies): (WebInspector.CookieItemsView.prototype._filterCookiesForDomain): (WebInspector.CookieItemsView.prototype._deleteCookie): (WebInspector.CookieItemsView.prototype._deleteButtonClicked): (WebInspector.CookieItemsView.prototype._refreshButtonClicked): (WebInspector.SimpleCookiesTable): (WebInspector.SimpleCookiesTable.prototype.setCookies): (WebInspector.SimpleCookiesTable.prototype.resize):
- inspector/front-end/CookiesTable.js: Added. (WebInspector.CookiesTable): (WebInspector.CookiesTable.prototype.updateWidths): (WebInspector.CookiesTable.prototype.setCookies): (WebInspector.CookiesTable.prototype.addCookiesFolder): (WebInspector.CookiesTable.prototype.get selectedCookie): (WebInspector.CookiesTable.prototype._rebuildTable): (WebInspector.CookiesTable.prototype.reset): (WebInspector.CookiesTable.prototype._populateNode): (WebInspector.CookiesTable.prototype._totalSize): (WebInspector.CookiesTable.prototype._sortCookies.localeCompare): (WebInspector.CookiesTable.prototype._sortCookies.numberCompare): (WebInspector.CookiesTable.prototype._sortCookies.expiresCompare): (WebInspector.CookiesTable.prototype._sortCookies): (WebInspector.CookiesTable.prototype._createGridNode): (WebInspector.CookiesTable.prototype._onDeleteFromGrid):
- inspector/front-end/FileSystemView.js: (WebInspector.FileSystemView.prototype._selectFileSystemTab): (WebInspector.FileSystemView.prototype.selectTemporaryFileSystemTab):
- inspector/front-end/FontView.js: (WebInspector.FontView.prototype.hasContent): (WebInspector.FontView.prototype._createContentIfNeeded): (WebInspector.FontView.prototype.show): (WebInspector.FontView.prototype.updateFontPreviewSize):
- inspector/front-end/ImageView.js: (WebInspector.ImageView.prototype.hasContent): (WebInspector.ImageView.prototype.show):
- inspector/front-end/NetworkItemView.js: Added. (WebInspector.NetworkItemView): (WebInspector.NetworkItemView.prototype.show): (WebInspector.NetworkItemView.prototype._selectTab): (WebInspector.NetworkItemView.prototype._tabSelected): (WebInspector.NetworkItemView.prototype.resize): (WebInspector.NetworkItemView.prototype.selectContentTab):
- inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.show): (WebInspector.NetworkPanel.prototype.refreshResource): (WebInspector.NetworkPanel.prototype._showResource): (WebInspector.NetworkPanel.prototype._closeVisibleResource):
- inspector/front-end/ResourceCookiesView.js: Added. (WebInspector.ResourceCookiesView): (WebInspector.ResourceCookiesView.prototype.show):
- inspector/front-end/ResourceHeadersView.js: Added. (WebInspector.ResourceHeadersView): (WebInspector.ResourceHeadersView.prototype._refreshURL): (WebInspector.ResourceHeadersView.prototype._refreshQueryString): (WebInspector.ResourceHeadersView.prototype._refreshFormData): (WebInspector.ResourceHeadersView.prototype._refreshRequestPayload): (WebInspector.ResourceHeadersView.prototype._refreshParms): (WebInspector.ResourceHeadersView.prototype._toggleURLdecoding): (WebInspector.ResourceHeadersView.prototype._getHeaderValue): (WebInspector.ResourceHeadersView.prototype._refreshRequestHeaders): (WebInspector.ResourceHeadersView.prototype._refreshResponseHeaders): (WebInspector.ResourceHeadersView.prototype._refreshHTTPInformation): (WebInspector.ResourceHeadersView.prototype._refreshHeaders):
- inspector/front-end/ResourceView.js: (WebInspector.ResourceView): (WebInspector.ResourceView.prototype.hasContent):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.show): (WebInspector.ResourcesPanel.prototype.showResource): (WebInspector.ResourcesPanel.prototype._showResourceView):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.show): (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
- inspector/front-end/SourceView.js: (WebInspector.SourceView): (WebInspector.SourceView.prototype.show): (WebInspector.SourceView.prototype.hide): (WebInspector.SourceView.prototype.resize): (WebInspector.SourceView.prototype.setupSourceFrameIfNeeded): (WebInspector.SourceView.prototype.hasContent): (WebInspector.SourceView.prototype.updateLocalContent): (WebInspector.SourceView.prototype.selectLocalContentTab):
- inspector/front-end/StylesSidebarPane.js:
- inspector/front-end/TabbedPane.js: (WebInspector.TabbedPane): (WebInspector.TabbedPane.prototype.appendTab): (WebInspector.TabbedPane.prototype.selectTab): (WebInspector.TabbedPane.prototype._showTab): (WebInspector.TabbedPane.prototype._hideTab):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.css: (.webkit-line-gutter-backdrop): (.resource-view): (.resource-view.visible): (.resource-view.font): (.resource-view.image > .image): (.resource-view.image > .info): (.storage-view): (.storage-view .data-grid): (.storage-empty-view, .storage-view .storage-table-error): (.storage-view .storage-table-error):
- inspector/front-end/inspector.html:
- inspector/front-end/networkPanel.css: (.network-cell-subtitle): (.network-header-subtitle): (#network-views .network-item-view .tabbed-pane-header): (#network-views.small .network-item-view .tabbed-pane-header): (.network-item-view): (.network-item-view.visible): (.network-item-view .tabbed-pane-header): (.network-item-view .scope-bar li): (.resource-headers-view): (.resource-headers-view.visible): (.resource-headers-view .outline-disclosure .parent): (.resource-headers-view .outline-disclosure .children li): (.resource-headers-view .outline-disclosure li.expanded .header-count): (.resource-headers-view .outline-disclosure .header-name): (.resource-headers-view .outline-disclosure .header-value): (.resource-headers-view .outline-disclosure .raw-form-data): (.resource-cookies-view): (.resource-cookies-view.visible): (.resource-cookies-view .data-grid): (.resource-cookies-view .data-grid .row-group):
- 2:28 AM Changeset in webkit [72654] by
-
- 3 edits in trunk/WebCore
2010-11-24 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: add "Locally modified" group into the resource panel.
https://bugs.webkit.org/show_bug.cgi?id=50005
- English.lproj/localizedStrings.js:
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel): (WebInspector.ResourcesPanel.prototype.reset): (WebInspector.ResourcesPanel.prototype.addLocallyModifiedRevision): (WebInspector.ResourcesPanel.prototype._innerShowView): (WebInspector.BaseStorageTreeElement.prototype.set titleText): (WebInspector.LocallyModifiedResourceTreeElement): (WebInspector.LocallyModifiedResourceTreeElement.prototype.onselect): (WebInspector.LocallyModifiedResourceTreeElement.prototype.gcRevisions): (WebInspector.LocallyModifiedRevisionTreeElement): (WebInspector.LocallyModifiedRevisionTreeElement.prototype.onattach): (WebInspector.LocallyModifiedRevisionTreeElement.prototype.onselect): (WebInspector.LocallyModifiedRevisionTreeElement.prototype._ondragstart):
- 2:24 AM Changeset in webkit [72653] by
-
- 4 edits in trunk/WebKit/qt
2010-11-24 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r72650.
http://trac.webkit.org/changeset/72650
https://bugs.webkit.org/show_bug.cgi?id=50010
breaks focus in scenes focus item other than graphicswebiview
(Requested by tronical_ on #webkit).
- Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::QGraphicsWebViewPrivate): (QGraphicsWebView::QGraphicsWebView): (QGraphicsWebView::itemChange):
- Api/qgraphicswebview.h:
- tests/qgraphicswebview/tst_qgraphicswebview.cpp:
- 2:11 AM Changeset in webkit [72652] by
-
- 9 edits in trunk
2010-11-24 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: pass style id to front-end as Object, not string.
https://bugs.webkit.org/show_bug.cgi?id=49971
- inspector/Inspector.idl:
- inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::getStylesForNode2): (WebCore::InspectorCSSAgent::getStyleSheetText2): (WebCore::InspectorCSSAgent::setPropertyText2): (WebCore::InspectorCSSAgent::toggleProperty2): (WebCore::InspectorCSSAgent::setRuleSelector2):
- inspector/InspectorCSSAgent.h:
- inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyle::buildObjectForStyle): (WebCore::InspectorStyleSheet::finalURL): (WebCore::InspectorStyleSheet::ruleForId): (WebCore::InspectorStyleSheet::buildObjectForStyleSheet): (WebCore::InspectorStyleSheet::buildObjectForRule): (WebCore::InspectorStyleSheet::text): (WebCore::InspectorStyleSheet::ruleOrStyleId): (WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle): (WebCore::InspectorStyleSheetForInlineStyle::text):
- inspector/InspectorStyleSheet.h: (WebCore::InspectorCSSId::InspectorCSSId): (WebCore::InspectorCSSId::isEmpty): (WebCore::InspectorCSSId::styleSheetId): (WebCore::InspectorCSSId::ordinal): (WebCore::InspectorCSSId::asInspectorValue): (WebCore::InspectorStyleSheet::id): (WebCore::InspectorStyleSheetForInlineStyle::styleForId):
- inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype.setRuleSelector): (WebInspector.CSSStyleModel.prototype.addRule): (WebInspector.CSSStyleModel.prototype._styleSheetChanged): (WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt): (WebInspector.CSSProperty.prototype.setText): (WebInspector.CSSProperty.prototype.setDisabled.callback): (WebInspector.CSSProperty.prototype.setDisabled): (WebInspector.CSSStyleSheet.createForId): (WebInspector.CSSStyleSheet.prototype.setText):
2010-11-23 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: pass style id to front-end as Object, not string.
https://bugs.webkit.org/show_bug.cgi?id=49971
- inspector/styles-new-API.html:
- 1:47 AM Changeset in webkit [72651] by
-
- 2 edits in trunk/WebKit2
2010-11-24 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fix uninitialized variable in QGraphicsWKViewPrivate
Always initialize QGWKVP::m_isChangingScale in the constructor.
- UIProcess/API/qt/qgraphicswkview.cpp: (QGraphicsWKViewPrivate::QGraphicsWKViewPrivate):
- 1:34 AM Changeset in webkit [72650] by
-
- 4 edits in trunk/WebKit/qt
2010-11-24 Jan Erik Hanssen <jhanssen@sencha.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Html autofocus not working with QGraphicsWebView
https://bugs.webkit.org/show_bug.cgi?id=43169
QGraphicsScene does not propagate Qt::ActivateWindowFocusReason focus
events when there are no active items.
- Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::QGraphicsWebViewPrivate): (QGraphicsWebView::QGraphicsWebView): (QGraphicsWebView::eventFilter): (QGraphicsWebView::itemChange):
- Api/qgraphicswebview.h:
- tests/qgraphicswebview/tst_qgraphicswebview.cpp: (FocusPage::FocusPage): (FocusPage::event): (FocusPage::gotFocus): (tst_QGraphicsWebView::receivesFocusInOnShow):
- 1:25 AM Changeset in webkit [72649] by
-
- 2 edits in trunk/WebCore
2010-11-24 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r72647.
http://trac.webkit.org/changeset/72647
https://bugs.webkit.org/show_bug.cgi?id=50009
breaks the http layout tests (Requested by philn-tp on
#webkit).
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::sendRequestCallback): (WebCore::startHttp): (WebCore::ResourceHandle::platformSetDefersLoading):
- 1:01 AM BuildingQtOnWindows edited by
- Fix the MSVC instructions. (diff)
- 12:32 AM Changeset in webkit [72648] by
-
- 3 edits in trunk/LayoutTests
2010-11-23 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed. Fix for chromium expectations.
composited-plugin.html is crashing on MAC.
small-to-large-composited-plugin.html is crashing on MAC.
font-size-zero.html is passing.
- platform/chromium-gpu/test_expectations.txt:
- platform/chromium/test_expectations.txt:
- 12:24 AM Changeset in webkit [72647] by
-
- 2 edits in trunk/WebCore
2010-11-23 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
[soup] implement ResourceHandle::platformSetDefersLoading
https://bugs.webkit.org/show_bug.cgi?id=44158
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::platformSetDefersLoading): Implemented using the soup_session_{,un}pause_message APIs.
