⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 27, 2010:

6:54 PM Changeset in webkit [72777] by commit-queue@webkit.org
  • 13 edits
    1 add in trunk/WebCore

2010-11-27 Benjamin Kalman <​kalman@chromium.org>

Reviewed by Darin Adler.

Move Position::EditingBoundaryCrossingRule to a new header file
​https://bugs.webkit.org/show_bug.cgi?id=49630

  • GNUmakefile.am:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Position.cpp: (WebCore::downstreamIgnoringEditingBoundaries): (WebCore::upstreamIgnoringEditingBoundaries):
  • dom/Position.h:
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::doApply):
  • editing/EditingBoundary.h: Added.
  • editing/visible_units.cpp: (WebCore::startOfParagraph): (WebCore::endOfParagraph): (WebCore::isStartOfParagraph): (WebCore::isEndOfParagraph):
  • editing/visible_units.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::createVisiblePosition):
1:15 AM Changeset in webkit [72776] by rwlbuis@webkit.org
  • 4 edits
    3 adds in trunk

2010-11-26 Rob Buis <​rwlbuis@gmail.com>

Reviewed by Simon Fraser.

Percentage z offset in transform-origin should make the property invalid
​https://bugs.webkit.org/show_bug.cgi?id=48704

Discard transform-origin property when parsing invalid Z value.

Test: fast/css/transform-origin-parsing.html

  • css/CSSParser.cpp: (WebCore::CSSParser::parseTransformOriginShorthand): (WebCore::CSSParser::parseTransformOrigin):
  • css/CSSParser.h:

Nov 26, 2010:

12:40 PM Changeset in webkit [72775] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-26 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed fix for chromium test expectations.

  • platform/chromium-gpu/test_expectations.txt: added: BUGWK50112 WIN LINUX : fast/canvas/canvas-createPattern-fillRect-shadow.html = TEXT
12:18 PM Changeset in webkit [72774] by mitz@apple.com
  • 8 edits in trunk/WebCore

<rdar://problem/8681368> Avoid unnecessary calls to CTFontGetPlatformFont()
​https://bugs.webkit.org/show_bug.cgi?id=50096

Reviewed by Antti Koivisto.

No new test, since functionality is unchanged.

  • platform/graphics/chromium/CrossProcessFontLoading.mm:

(WebCore::FontPlatformData::loadFont): Removed the ATSUFontID argument.

  • platform/graphics/cocoa/FontPlatformData.h:

(WebCore::FontPlatformData::FontPlatformData): Ditto.
(WebCore::FontPlatformData::operator==): Removed comparison of font IDs.

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::loadFont): Removed the ATSUFontID argument.
(WebCore::FontPlatformData::FontPlatformData): Updated.
(WebCore::FontPlatformData::operator=): Removed copying of font ID.
(WebCore::FontPlatformData::setFont): Removed setting of font ID.

  • platform/graphics/mac/ComplexTextControllerATSUI.cpp:

(WebCore::initializeATSUStyle): Call CTFontGetPlatformFont() here if necessary.

  • platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData): Updated for FontPlatformData change.
(WebCore::createFontCustomPlatformData): Updated for FontCustomPlatformData change.

  • platform/graphics/mac/FontCustomPlatformData.h:

(WebCore::FontCustomPlatformData::FontCustomPlatformData): Removed ATSUFontID argument and
data member.

  • platform/graphics/mac/SimpleFontDataATSUI.mm:

(WebCore::SimpleFontData::checkShapesArabic): Call CTFontGetPlatformFont() here if necessary.

10:01 AM Changeset in webkit [72773] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-11-26 François Sausset <François Sausset>

Reviewed by Daniel Bates.

MathML: code cleaning needed in MathMLInlineContainerElement.cpp
​https://bugs.webkit.org/show_bug.cgi?id=50069

Unnecessary namespace was removed and style was adjusted.

  • mathml/MathMLInlineContainerElement.cpp: (WebCore::MathMLInlineContainerElement::createRenderer):
9:43 AM Changeset in webkit [72772] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/gtk

2010-11-26 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Xan Lopez.

[GTK] Inspector: add a way to inspect a WebKitDOMNode
​https://bugs.webkit.org/show_bug.cgi?id=49903

  • webkit/webkitwebinspector.cpp: (webkit_web_inspector_inspect_node):
  • webkit/webkitwebinspector.h:
8:58 AM Changeset in webkit [72771] by andreip@google.com
  • 32 edits in trunk

2010-11-26 Andrei Popescu <​andreip@google.com>

Reviewed by Jeremy Orlow.

IDBDatabase and IDBObjectStore remove* methods should be renamed to delete*
​https://bugs.webkit.org/show_bug.cgi?id=50113

  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/objectstore-removeobjectstore-expected.txt:
  • storage/indexeddb/objectstore-removeobjectstore.html:
  • storage/indexeddb/resources/shared.js: (deleteAllObjectStores):
  • storage/indexeddb/transaction-basics-expected.txt:
  • storage/indexeddb/transaction-basics.html:

2010-11-26 Andrei Popescu <​andreip@google.com>

Reviewed by Jeremy Orlow.

IDBDatabase and IDBObjectStore remove* methods should be renamed to delete*
​https://bugs.webkit.org/show_bug.cgi?id=50113

Modified exisiting layout tests to cover this change.

  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::deleteObjectStore):
  • storage/IDBDatabase.h:
  • storage/IDBDatabase.idl:
  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::deleteObjectStore): (WebCore::IDBDatabaseBackendImpl::deleteObjectStoreInternal):
  • storage/IDBDatabaseBackendImpl.h:
  • storage/IDBDatabaseBackendInterface.h:
  • storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::deleteFunction): (WebCore::IDBObjectStore::deleteIndex):
  • storage/IDBObjectStore.h:
  • storage/IDBObjectStore.idl:
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::deleteFunction): (WebCore::IDBObjectStoreBackendImpl::deleteInternal): (WebCore::IDBObjectStoreBackendImpl::deleteIndex): (WebCore::IDBObjectStoreBackendImpl::deleteIndexInternal):
  • storage/IDBObjectStoreBackendImpl.h:
  • storage/IDBObjectStoreBackendInterface.h:

2010-11-26 Andrei Popescu <​andreip@google.com>

Reviewed by Jeremy Orlow.

IDBDatabase and IDBObjectStore remove* methods should be renamed to delete*
​https://bugs.webkit.org/show_bug.cgi?id=50113

  • public/WebIDBDatabase.h: (WebKit::WebIDBDatabase::deleteObjectStore): (WebKit::WebIDBDatabase::removeObjectStore):
  • public/WebIDBObjectStore.h: (WebKit::WebIDBObjectStore::remove): (WebKit::WebIDBObjectStore::deleteFunction): (WebKit::WebIDBObjectStore::deleteIndex):
  • src/IDBDatabaseProxy.cpp: (WebCore::IDBDatabaseProxy::deleteObjectStore):
  • src/IDBDatabaseProxy.h:
  • src/IDBObjectStoreProxy.cpp: (WebCore::IDBObjectStoreProxy::deleteFunction): (WebCore::IDBObjectStoreProxy::deleteIndex):
  • src/IDBObjectStoreProxy.h:
  • src/WebIDBDatabaseImpl.cpp: (WebKit::WebIDBDatabaseImpl::deleteObjectStore):
  • src/WebIDBDatabaseImpl.h:
  • src/WebIDBObjectStoreImpl.cpp: (WebKit::WebIDBObjectStoreImpl::deleteFunction): (WebKit::WebIDBObjectStoreImpl::deleteIndex):
  • src/WebIDBObjectStoreImpl.h:
8:53 AM Changeset in webkit [72770] by commit-queue@webkit.org
  • 21 edits
    18 deletes in trunk

2010-11-26 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r72701.
​http://trac.webkit.org/changeset/72701
​https://bugs.webkit.org/show_bug.cgi?id=50114

REGRESSION: bad transform matrix on content layer (Requested
by backer on #webkit).

  • compositing/lots-of-img-layers-with-opacity.html: Removed.
  • compositing/lots-of-img-layers.html: Removed.
  • platform/chromium-gpu-win/compositing/lots-of-img-layers-expected.checksum: Removed.
  • platform/chromium-gpu-win/compositing/lots-of-img-layers-expected.png: Removed.
  • platform/chromium-gpu-win/compositing/lots-of-img-layers-expected.txt: Removed.
  • platform/chromium-gpu-win/compositing/lots-of-img-layers-with-opacity-expected.checksum: Removed.
  • platform/chromium-gpu-win/compositing/lots-of-img-layers-with-opacity-expected.png: Removed.
  • platform/chromium-gpu-win/compositing/lots-of-img-layers-with-opacity-expected.txt: Removed.
  • platform/chromium-gpu/test_expectations.txt:
  • platform/mac/compositing/lots-of-img-layers-expected.checksum: Removed.
  • platform/mac/compositing/lots-of-img-layers-expected.png: Removed.
  • platform/mac/compositing/lots-of-img-layers-expected.txt: Removed.
  • platform/mac/compositing/lots-of-img-layers-with-opacity-expected.checksum: Removed.
  • platform/mac/compositing/lots-of-img-layers-with-opacity-expected.png: Removed.
  • platform/mac/compositing/lots-of-img-layers-with-opacity-expected.txt: Removed.

2010-11-26 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r72701.
​http://trac.webkit.org/changeset/72701
​https://bugs.webkit.org/show_bug.cgi?id=50114

REGRESSION: bad transform matrix on content layer (Requested
by backer on #webkit).

  • WebCore.gypi:
  • platform/graphics/chromium/Canvas2DLayerChromium.cpp: (WebCore::Canvas2DLayerChromium::updateContents):
  • platform/graphics/chromium/Canvas2DLayerChromium.h:
  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::cleanupResources): (WebCore::ContentLayerChromium::updateContents): (WebCore::ContentLayerChromium::updateTextureRect): (WebCore::ContentLayerChromium::draw):
  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateContents):
  • platform/graphics/chromium/ImageLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::contentsDirty): (WebCore::LayerChromium::updateContents): (WebCore::LayerChromium::draw):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::prepareToDrawLayers): (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::updateLayersRecursive): (WebCore::LayerRendererChromium::useRenderSurface): (WebCore::LayerRendererChromium::drawLayer): (WebCore::LayerRendererChromium::initializeSharedObjects): (WebCore::LayerRendererChromium::cleanupSharedObjects):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/LayerTexture.cpp: Removed.
  • platform/graphics/chromium/LayerTexture.h: Removed.
  • platform/graphics/chromium/PluginLayerChromium.cpp: (WebCore::PluginLayerChromium::updateContents):
  • platform/graphics/chromium/PluginLayerChromium.h:
  • platform/graphics/chromium/RenderSurfaceChromium.cpp: (WebCore::RenderSurfaceChromium::RenderSurfaceChromium): (WebCore::RenderSurfaceChromium::cleanupResources): (WebCore::RenderSurfaceChromium::prepareContentsTexture):
  • platform/graphics/chromium/RenderSurfaceChromium.h:
  • platform/graphics/chromium/TextureManager.cpp: Removed.
  • platform/graphics/chromium/TextureManager.h: Removed.
  • platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::updateContents):
  • platform/graphics/chromium/VideoLayerChromium.h:
  • platform/graphics/chromium/WebGLLayerChromium.cpp: (WebCore::WebGLLayerChromium::updateContents):
  • platform/graphics/chromium/WebGLLayerChromium.h:
8:51 AM Changeset in webkit [72769] by jorlow@chromium.org
  • 3 edits in trunk/WebCore

2010-11-26 Jeremy Orlow <​jorlow@chromium.org>

Unreviewed build fix.

  • storage/IDBIndex.cpp: (WebCore::IDBIndex::openCursor): (WebCore::IDBIndex::openKeyCursor):
  • storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::openCursor):
8:44 AM Changeset in webkit [72768] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-11-26 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Xan Lopez.

[GTK] SoupCache should not ignore loader's conditional requests
​https://bugs.webkit.org/show_bug.cgi?id=50101

SoupCache must not handle WebKit loader conditional requests and
thus should never return its own cached response if any. This was
causing frequent resource load failures as WebCore was trying to
revalidate its own resources and was not getting any expected
result.

  • platform/network/soup/cache/webkit/soup-cache.c: (webkit_soup_cache_has_response): check the presence of conditional request headers when deciding whether the cache has a valid response for a given request.
8:37 AM Changeset in webkit [72767] by jorlow@chromium.org
  • 20 edits in trunk

2010-11-26 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Steve Block.

Make IDBKeyRange match the spec
​https://bugs.webkit.org/show_bug.cgi?id=50105

Remove flags and instead add two booleans for being open.
Change left to lower and right to upper everywhere.

  • storage/indexeddb/constants-expected.txt:
  • storage/indexeddb/constants.html:
  • storage/indexeddb/index-cursor.html:
  • storage/indexeddb/keyrange-expected.txt:
  • storage/indexeddb/keyrange.html:
  • storage/indexeddb/objectstore-cursor.html:
  • storage/indexeddb/open-cursor.html:
  • storage/indexeddb/tutorial.html:

2010-11-26 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Steve Block.

Make IDBKeyRange match the spec
​https://bugs.webkit.org/show_bug.cgi?id=50105

Remove flags and instead add two booleans for being open.
Change left to lower and right to upper everywhere.

  • storage/IDBIndexBackendImpl.cpp: (WebCore::IDBIndexBackendImpl::openCursorInternal):
  • storage/IDBKey.cpp: (WebCore::IDBKey::lowerCursorWhereFragment): (WebCore::IDBKey::upperCursorWhereFragment):
  • storage/IDBKey.h:
  • storage/IDBKeyRange.cpp: (WebCore::IDBKeyRange::IDBKeyRange): (WebCore::IDBKeyRange::only): (WebCore::IDBKeyRange::lowerBound): (WebCore::IDBKeyRange::upperBound): (WebCore::IDBKeyRange::bound): (WebCore::IDBKeyRange::lowerWhereClauseComparisonOperator): (WebCore::IDBKeyRange::upperWhereClauseComparisonOperator):
  • storage/IDBKeyRange.h: (WebCore::IDBKeyRange::create): (WebCore::IDBKeyRange::lower): (WebCore::IDBKeyRange::upper): (WebCore::IDBKeyRange::lowerOpen): (WebCore::IDBKeyRange::upperOpen):
  • storage/IDBKeyRange.idl:
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::openCursorInternal):

2010-11-26 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Steve Block.

Make IDBKeyRange match the spec
​https://bugs.webkit.org/show_bug.cgi?id=50105

Remove flags and instead add two booleans for being open.
Change left to lower and right to upper everywhere.

  • public/WebIDBKeyRange.h: (WebKit::WebIDBKeyRange::WebIDBKeyRange):
  • src/WebIDBKeyRange.cpp: (WebKit::WebIDBKeyRange::assign): (WebKit::WebIDBKeyRange::left): (WebKit::WebIDBKeyRange::right): (WebKit::WebIDBKeyRange::lower): (WebKit::WebIDBKeyRange::upper): (WebKit::WebIDBKeyRange::lowerOpen): (WebKit::WebIDBKeyRange::upperOpen): (WebKit::WebIDBKeyRange::flags):
8:33 AM Changeset in webkit [72766] by jorlow@chromium.org
  • 17 edits in trunk

2010-11-25 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Steve Block.

Convert open*Cursor and createIndex over to using OptionsObject
​https://bugs.webkit.org/show_bug.cgi?id=50093

  • storage/indexeddb/index-cursor.html:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/objectstore-cursor.html:
  • storage/indexeddb/open-cursor-expected.txt:
  • storage/indexeddb/open-cursor.html:
  • storage/indexeddb/tutorial.html:

2010-11-25 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Steve Block.

Convert open*Cursor and createIndex over to using OptionsObject
​https://bugs.webkit.org/show_bug.cgi?id=50093

Add IDBKeyRange to OptionsObject's parsing abilities. Switch
more APIs over to using it.

  • bindings/v8/OptionsObject.cpp: (WebCore::OptionsObject::getKeyDOMStringList): (WebCore::OptionsObject::getKeyKeyRange):
  • bindings/v8/OptionsObject.h:
  • storage/IDBIndex.cpp: (WebCore::IDBIndex::openCursor): (WebCore::IDBIndex::openKeyCursor):
  • storage/IDBIndex.h: (WebCore::IDBIndex::openCursor): (WebCore::IDBIndex::openKeyCursor):
  • storage/IDBIndex.idl:
  • storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::createIndex): (WebCore::IDBObjectStore::openCursor):
  • storage/IDBObjectStore.h: (WebCore::IDBObjectStore::createIndex): (WebCore::IDBObjectStore::openCursor):
  • storage/IDBObjectStore.idl:
8:30 AM Changeset in webkit [72765] by jorlow@chromium.org
  • 24 edits
    2 moves
    2 adds in trunk

2010-11-25 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Steve Block.

Clean up IDBDatabase.transaction and add checks to IDBTransaction.objectStore
​https://bugs.webkit.org/show_bug.cgi?id=50081

  • storage/indexeddb/create-and-remove-object-store-expected.txt: Renamed from LayoutTests/storage/indexeddb/createAndRemoveObjectStore-expected.txt.
  • storage/indexeddb/create-and-remove-object-store.html: Renamed from LayoutTests/storage/indexeddb/createAndRemoveObjectStore.html.
  • storage/indexeddb/create-object-store-options-expected.txt:
  • storage/indexeddb/create-object-store-options.html:
  • storage/indexeddb/resources/shared.js: (evalAndExpectException):
  • storage/indexeddb/transaction-and-objectstore-calls-expected.txt: Added.
  • storage/indexeddb/transaction-and-objectstore-calls.html: Added.
  • storage/indexeddb/tutorial.html:

2010-11-25 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Steve Block.

Clean up IDBDatabase.transaction and add checks to IDBTransaction.objectStore
​https://bugs.webkit.org/show_bug.cgi?id=50081

IDBDatabase.transaction should use the new optional OptionsObject way
of taking optional paramters. Modify that object to get numbers and
domStringLists from it. Verify that any requested resources exist and
return an exception if not.

When IDBTransaction.objectStore is called, verify that it's one of the
requested resources. Also verify that it still exists. Plumb the
exception code to make this work.

Tests: storage/indexeddb/create-and-remove-object-store.html

storage/indexeddb/transaction-and-objectstore-calls.html

  • bindings/v8/OptionsObject.cpp: (WebCore::OptionsObject::getKeyInteger): (WebCore::OptionsObject::getKeyString): (WebCore::OptionsObject::getKeyDOMStringList):
  • bindings/v8/OptionsObject.h:
  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::createObjectStore): (WebCore::IDBDatabase::transaction):
  • storage/IDBDatabase.h: (WebCore::IDBDatabase::transaction):
  • storage/IDBDatabase.idl:
  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::transaction):
  • storage/IDBTransaction.cpp: (WebCore::IDBTransaction::objectStore):
  • storage/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl): (WebCore::IDBTransactionBackendImpl::objectStore):
  • storage/IDBTransactionBackendImpl.h:
  • storage/IDBTransactionBackendInterface.h:

2010-11-25 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Steve Block.

Clean up IDBDatabase.transaction and add checks to IDBTransaction.objectStore
​https://bugs.webkit.org/show_bug.cgi?id=50081

Plumb IDBTransaction.objectStore's exception code.

  • public/WebIDBTransaction.h: (WebKit::WebIDBTransaction::objectStore):
  • src/IDBDatabaseProxy.cpp: (WebCore::IDBDatabaseProxy::transaction):
  • src/IDBTransactionBackendProxy.cpp: (WebCore::IDBTransactionBackendProxy::objectStore):
  • src/IDBTransactionBackendProxy.h:
  • src/WebIDBDatabaseImpl.cpp: (WebKit::WebIDBDatabaseImpl::createObjectStore): (WebKit::WebIDBDatabaseImpl::transaction):
  • src/WebIDBTransactionImpl.cpp: (WebKit::WebIDBTransactionImpl::objectStore):
  • src/WebIDBTransactionImpl.h:
8:18 AM Changeset in webkit [72764] by mario@webkit.org
  • 5 edits in trunk

2010-11-26 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Xan Lopez.

[GTK] events missing when a document is (re)loaded
​https://bugs.webkit.org/show_bug.cgi?id=25831

Make sure webArea returns a proper name and that a signal
'state-change::defunct' is emitted when detaching the wrapper.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_name): Returns the current document's title as fallback mechanism for webArea objects. (webkit_accessible_detach): Emit 'state-change::defunct' function as soon as the wrapper is detached from the related core object.

2010-11-26 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Xan Lopez.

[GTK] events missing when a document is (re)loaded
​https://bugs.webkit.org/show_bug.cgi?id=25831

Emit the right signals when reloading a document.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::notifyAccessibilityStatus): New function, to make sure the signals involved in reloading a document are properly emitted. (WebKit::notifyStatus): Also notify accessibility if enabled.

New unit test to check the signals are being actually emitted.

  • tests/testatk.c: (stateChangedCb): Callback for 'state-change' signal emitted by the accessible object associated to the webView. (documentReloadCb): Callback for 'reload' signal. (documentLoadCompleteCb): Callback for 'load-complete' signal. (webviewLoadStatusChangedCb): Callback for 'notify::load-status' signal, emitted by the WebKitWebView object (not the AtkObject). (testWebkitAtkDocumentReloadEvents): New unit test. (main): Added the new unit test.
8:01 AM Changeset in webkit [72763] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-26 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed fix for chromium test expectations.
fast/canvas/canvas-createPattern-fillRect-shadow.html was disabled
for Win and Linux.

  • platform/chromium/test_expectations.txt: added: BUGWK50112 WIN LINUX : fast/canvas/canvas-createPattern-fillRect-shadow.html = TEXT
7:52 AM Changeset in webkit [72762] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-11-26 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Xan Lopez.

[Gtk] ASSERT(d->m_response.isNull()) in contentSniffedCallback
​https://bugs.webkit.org/show_bug.cgi?id=50083

ResourceHandleSoup should not listen to content-sniffed signal
when content sniffing is not enabled. This will prevent us
reaching an assertion on content-sniffed callback

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::startHttp):
  • platform/network/soup/cache/soup-request-http.c: (conditional_get_ready_cb): added a comment with the possible fix for a pure libsoup HTTP cache. (send_async_cb): prevent an early object finalization adding a reference. (webkit_soup_request_http_send_async): Ditto.
7:36 AM Changeset in webkit [72761] by reni@webkit.org
  • 3 edits in trunk/WebCore

[Qt] Remove empty ScrollView::platformInit/platformDestroy
​https://bugs.webkit.org/show_bug.cgi?id=50079

Reviewed by Antonio Gomes.

No new test is needed.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):

  • platform/qt/ScrollViewQt.cpp:
6:59 AM Changeset in webkit [72760] by hans@chromium.org
  • 3 edits in trunk/LayoutTests

2010-11-26 Hans Wennborg <​hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Test inserting invalid values in object store
​https://bugs.webkit.org/show_bug.cgi?id=50110

Add tests to make sure we throw exceptions when a user tries
to insert invalid data in the object store.

  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
6:54 AM Changeset in webkit [72759] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-11-26 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Fixing inspector tests.

  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype.set timing):
4:51 AM Changeset in webkit [72758] by pfeldman@chromium.org
  • 7 edits in trunk/WebCore

2010-11-25 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: UI polish for Network and Resources panels.
​https://bugs.webkit.org/show_bug.cgi?id=50100

  • Fixed timing inconsistencies
  • Made grid user-selectable
  • Selection in network panel is made on name column only
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel): (WebInspector.NetworkPanel.prototype._toggleGridMode): (WebInspector.NetworkDataGridNode.prototype.createCells): (WebInspector.NetworkDataGridNode.prototype.select): (WebInspector.NetworkDataGridNode.prototype.get selectable): (WebInspector.NetworkDataGridNode.prototype._createTimelineCell): (WebInspector.NetworkDataGridNode.prototype.refreshGraph): (WebInspector.NetworkDataGridNode.prototype._refreshLabelPositions):
  • inspector/front-end/Popover.js: (WebInspector.PopoverHelper): (WebInspector.PopoverHelper.prototype.setTimeout): (WebInspector.PopoverHelper.prototype._mouseMove): (WebInspector.PopoverHelper.prototype._handleMouseAction):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype.get responseReceivedTime): (WebInspector.Resource.prototype.set endTime): (WebInspector.Resource.prototype.set timing):
  • inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager.prototype.didReceiveResponse): (WebInspector.ResourceManager.prototype.didFinishLoading):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.FrameResourceTreeElement.prototype._ondragstart):
  • inspector/front-end/networkPanel.css: (.network-sidebar .data-grid td:not(.network-summary)): (.network-sidebar .data-grid td.name-column): (.network.panel:not(.viewing-resource) .network-sidebar td.name-column:hover): (.network-timing-row): (.network-timing-bar): (.network-timing-bar-title): (.resource-timing-view):
3:52 AM Changeset in webkit [72757] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

2010-11-26 Helder Correia <​helder@sencha.com>

Reviewed by Ariya Hidayat.

[Qt] Blur shadow for rectangle fill
​https://bugs.webkit.org/show_bug.cgi?id=44488

New fast canvas test to ensure fillRect shadow (with and without blur).

  • fast/canvas/canvas-fillRect-shadow-expected.txt: Added.
  • fast/canvas/canvas-fillRect-shadow.html: Added.
  • fast/canvas/script-tests/canvas-fillRect-shadow.js: Added.

2010-11-26 Helder Correia <​helder@sencha.com>

Reviewed by Ariya Hidayat.

[Qt] Blur shadow for rectangle fill
​https://bugs.webkit.org/show_bug.cgi?id=44488

Shadow color opacity needs to be set when blurring shadow with
ContextShadow.

Test: fast/canvas/canvas-fillRect-shadow.html

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillRect):
3:25 AM Changeset in webkit [72756] by commit-queue@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2010-11-26 Helder Correia <​helder@sencha.com>

Reviewed by Kenneth Rohde Christiansen.

New fast canvas test: createPattern + fillRect with shadow
​https://bugs.webkit.org/show_bug.cgi?id=50104

Ensure that fillRect works correctly with an image pattern with
transparency set as the fillStyle.

  • fast/canvas/canvas-createPattern-fillRect-shadow-expected.txt: Added.
  • fast/canvas/canvas-createPattern-fillRect-shadow.html: Added.
  • fast/canvas/script-tests/canvas-createPattern-fillRect-shadow.js: Added.
3:21 AM Changeset in webkit [72755] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-25 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: LayoutTest/inspector/extnesions.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=50076

  • inspector/extensions-test.js: (initialize_ExtensionsTest.dumpSidebarContent):
3:03 AM Changeset in webkit [72754] by hans@chromium.org
  • 24 edits in trunk

2010-11-26 Hans Wennborg <​hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Rename IDBDatabase.objectStores to objectStoreNames
​https://bugs.webkit.org/show_bug.cgi?id=50102

Update layout tests to use the new name.

  • storage/indexeddb/database-basics-expected.txt:
  • storage/indexeddb/database-basics.html:
  • storage/indexeddb/database-quota-expected.txt:
  • storage/indexeddb/database-quota.html:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/resources/shared.js: (deleteAllObjectStores):
  • storage/indexeddb/transaction-basics-expected.txt:
  • storage/indexeddb/transaction-basics.html:
  • storage/indexeddb/tutorial.html:

2010-11-26 Hans Wennborg <​hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Rename IDBDatabase.objectStores to objectStoreNames
​https://bugs.webkit.org/show_bug.cgi?id=50102

Rename as per the spec: ​http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#database-interface

  • manual-tests/indexeddb-persists.html:
  • storage/IDBDatabase.h: (WebCore::IDBDatabase::objectStoreNames):
  • storage/IDBDatabase.idl:
  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::objectStoreNames): (WebCore::IDBDatabaseBackendImpl::setVersion): (WebCore::IDBDatabaseBackendImpl::transaction):
  • storage/IDBDatabaseBackendImpl.h:
  • storage/IDBDatabaseBackendInterface.h:

2010-11-26 Hans Wennborg <​hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Rename IDBDatabase.objectStores to objectStoreNames
​https://bugs.webkit.org/show_bug.cgi?id=50102

Rename as per the spec: ​http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#database-interface

  • public/WebIDBDatabase.h: (WebKit::WebIDBDatabase::objectStores): (WebKit::WebIDBDatabase::objectStoreNames):
  • src/IDBDatabaseProxy.cpp: (WebCore::IDBDatabaseProxy::objectStoreNames):
  • src/IDBDatabaseProxy.h:
  • src/WebIDBDatabaseImpl.cpp: (WebKit::WebIDBDatabaseImpl::objectStoreNames):
  • src/WebIDBDatabaseImpl.h:
2:52 AM Changeset in webkit [72753] by andreip@google.com
  • 48 edits in trunk

Remove description

Note: See TracTimeline for information about the timeline view.