⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 4, 2010:

10:22 PM Changeset in webkit [73340] by dbates@webkit.org
  • 2 edits in trunk/LayoutTests

2010-12-04 Daniel Bates <​dbates@rim.com>

​https://bugs.webkit.org/show_bug.cgi?id=49641

Inadvertently committed the wrong results for test case fast/lists/w3-css3-list-styles-fallback-style.html
in <​http://trac.webkit.org/changeset/73339>.

  • fast/lists/w3-css3-list-styles-fallback-style-expected.txt: Rebased results.
9:57 PM Changeset in webkit [73339] by dbates@webkit.org
  • 3 edits in trunk/LayoutTests

2010-12-04 Daniel Bates <​dbates@rim.com>

​https://bugs.webkit.org/show_bug.cgi?id=49641

Update test case and result for fast/lists/w3-css3-list-styles-fallback-style.html
since we now support list style types lower-armenian and upper-armenian.

  • fast/lists/w3-css3-list-styles-fallback-style-expected.txt:
  • fast/lists/w3-css3-list-styles-fallback-style.html:
9:12 PM Changeset in webkit [73338] by dbates@webkit.org
  • 7 edits
    4 adds in trunk

2010-12-04 Daniel Bates <​dbates@rim.com>

Reviewed by Darin Adler.

Add support for lower-armenian and upper-armenian
​https://bugs.webkit.org/show_bug.cgi?id=49641

Implement support for list-style-types lower-armenian and upper-armenian
for lowercase Armenian and uppercase Armenian numerals, respectively.

Tests: fast/lists/w3-css3-lower-armenian.html

fast/lists/w3-css3-upper-armenian.html

  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added enum values LowerArmenian and UpperArmenian.
  • css/CSSValueKeywords.in: Added "upper-armenian" and "lower-armenian".
  • inspector/front-end/SourceCSSTokenizer.re2js: Ditto.
  • rendering/RenderListMarker.cpp: (WebCore::effectiveListMarkerType): Added enum values LowerArmenian and UpperArmenian. (WebCore::listMarkerSuffix): Ditto. (WebCore::listMarkerText): Ditto. (WebCore::RenderListMarker::paint): Ditto. (WebCore::RenderListMarker::computePreferredLogicalWidths): Ditto. (WebCore::RenderListMarker::getRelativeMarkerRect): Ditto.
  • rendering/style/RenderStyleConstants.h: Ditto.

2010-12-04 Daniel Bates <​dbates@rim.com>

Reviewed by Darin Adler.

Add support for lower-armenian and upper-armenian
​https://bugs.webkit.org/show_bug.cgi?id=49641

Tests cases for lower-armenian and upper-armenian list-style-types
derived from the HTML+CSS Internationalization Tests "lower-armenian, up to 9,999",
and "armenian, up to 9,999", respectively.

See <​http://www.w3.org/International/tests/tests-html-css/list-lists>.

  • fast/lists/w3-css3-lower-armenian-expected.txt: Added.
  • fast/lists/w3-css3-lower-armenian.html: Added.
  • fast/lists/w3-css3-upper-armenian-expected.txt: Added.
  • fast/lists/w3-css3-upper-armenian.html: Added.
7:21 PM Changeset in webkit [73337] by mitz@apple.com
  • 10 edits in trunk

2010-12-04 Dan Bernstein <​mitz@apple.com>

Reviewed by Sam Weinig.

WebKit part of <rdar://problem/8145955> Add text search API for counting/marking/highlighting matches in a range
​https://bugs.webkit.org/show_bug.cgi?id=50530

  • WebView/WebDocumentInternal.h: Added a DOMRange parameter to -countMatchesForText:options:limit:markMatches:
  • WebView/WebHTMLView.mm: (-[WebHTMLView countMatchesForText:inDOMRange:options:limit:markMatches:]): Added DOMRange parameter, which is passed through to WebCore.
  • WebView/WebPDFView.mm: (isFrameInRange): Added this helper function. (-[WebPDFView countMatchesForText:inDOMRange:options:limit:markMatches:]): Added DOMRange parameter and a check if the frame is in the range.
  • WebView/WebView.mm: (-[WebView countMatchesForText:options:highlight:limit:markMatches:]): Now calls the inDOMRange: version. (-[WebView countMatchesForText:inDOMRange:options:highlight:limit:markMatches:]): Added DOMRange parameter, which is passed to document views' -countMatchesForText:inDOMRange:options:limit:markMatches:.
  • WebView/WebViewPrivate.h:

2010-12-04 Dan Bernstein <​mitz@apple.com>

Reviewed by Sam Weinig.

WebCore part of <rdar://problem/8145955> Add text search API for counting/marking/highlighting matches in a range
​https://bugs.webkit.org/show_bug.cgi?id=50530

  • WebCore.exp.in: Export Range version of countMatchesForText().
  • editing/Editor.cpp: (WebCore::isFrameInRange): Added this helper method. (WebCore::Editor::countMatchesForText): Added a Range parameter and restricted the result to matches that occur in the range.
  • editing/Editor.h:
1:51 PM Changeset in webkit [73336] by weinig@apple.com
  • 24 edits
    2 adds in trunk

WebKit2: Need client functions to notify app when the url changes due to a fragment navigation
​https://bugs.webkit.org/show_bug.cgi?id=50511

Reviewed by Jon Honeycutt.

WebKit2:

Pipe didChangeLocationWithinPageForFrame up through the UIProcess to the WKPageLoadClient,
updating the WebFrameProxy's URL on the way.

Test: PageLoadDidChangeLocationWithinPageForFrame

  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/qt/qwkpage.cpp:

(QWKPage::QWKPage):

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::didChangeURLWithoutNavigation):

  • UIProcess/WebFrameProxy.h:
  • UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::didChangeLocationWithinPageForFrame):

  • UIProcess/WebLoaderClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didChangeLocationWithinPageForFrame):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::didChangeLocationWithinPageForFrame):
(WebKit::InjectedBundlePageLoaderClient::didDisplayInsecureContentForFrame):
(WebKit::InjectedBundlePageLoaderClient::didRunInsecureContentForFrame):

  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidCancelClientRedirect): Fix typo.
(WebKit::WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):

WebKitTools:

Update tools for new didChangeLocationWithinPageForFrame client function (and changed bundle
signature) and added a test for the functionality (PageLoadDidChangeLocationWithinPageForFrame.cpp)

  • MiniBrowser/mac/BrowserWindowController.m:

(didChangeLocationWithinPageForFrame):
(-[BrowserWindowController awakeFromNib]):
(-[BrowserWindowController didChangeLocationWithinPageForFrame:]):

  • TestWebKitAPI/PlatformUtilities.cpp:

(TestWebKitAPI::Util::toWK):

  • TestWebKitAPI/PlatformUtilities.h:

(TestWebKitAPI::Util::adoptWK):

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp: Added.

(TestWebKitAPI::nullJavaScriptCallback):
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::didChangeLocationWithinPageForFrame):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/file-with-anchor.html: Added.
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:
  • TestWebKitAPI/win/copy-resources.cmd:
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):

12:40 PM Changeset in webkit [73335] by commit-queue@webkit.org
  • 12 edits
    4 adds in trunk

2010-12-04 Gavin Peters <​gavinp@chromium.org>

Reviewed by Adam Barth.

Implement onload events for <link rel=prefetch>
​https://bugs.webkit.org/show_bug.cgi?id=50187

  • fast/dom/HTMLLinkElement/link-and-subresource-test-expected.txt: Added.
  • fast/dom/HTMLLinkElement/link-and-subresource-test.html: Added.
  • fast/dom/HTMLLinkElement/prefetch-expected.txt:
  • fast/dom/HTMLLinkElement/prefetch-onload-expected.txt: Added.
  • fast/dom/HTMLLinkElement/prefetch-onload.html: Added.
  • fast/dom/HTMLLinkElement/prefetch.html:
  • http/tests/misc/prefetch-purpose.html:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2010-12-04 Gavin Peters <​gavinp@chromium.org>

Reviewed by Adam Barth.

Implement onload events for <link rel=prefetch>
​https://bugs.webkit.org/show_bug.cgi?id=50187

Tests: fast/dom/HTMLLinkElement/link-and-subresource-test.html

fast/dom/HTMLLinkElement/prefetch-onload.html

  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::HTMLLinkElement): (WebCore::HTMLLinkElement::~HTMLLinkElement): (WebCore::HTMLLinkElement::parseMappedAttribute): (WebCore::HTMLLinkElement::process): (WebCore::HTMLLinkElement::onloadTimerFired): (WebCore::HTMLLinkElement::notifyFinished):
  • html/HTMLLinkElement.h:
  • loader/cache/CachedResource.cpp: (WebCore::CachedResource::data):
11:53 AM Changeset in webkit [73334] by Patrick Gansterer
  • 2 edits in trunk/BugsSite

2010-12-04 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Increase size of status bubbles
​https://bugs.webkit.org/show_bug.cgi?id=50496

The current available space isn't enough to display all
pending results including position in the queue.

  • PrettyPatch/PrettyPatch.rb:
10:57 AM Changeset in webkit [73333] by Patrick Gansterer
  • 2 edits in trunk/JavaScriptCore

2010-12-04 Patrick Gansterer <Patrick Gansterer>

Unreviewed, build fix after r69132.

  • shell/CMakeLists.txt: Fix directory name (jsc -> shell).
7:19 AM Changeset in webkit [73332] by Patrick Gansterer
  • 2 edits in trunk

2010-12-04 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[CMake] Better detection of ARM platform
​https://bugs.webkit.org/show_bug.cgi?id=50452

  • CMakeLists.txt:
7:19 AM Changeset in webkit [73331] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-12-04 Martin Robinson <​mrobinson@igalia.com>

Fix a baseline which differs between my machine and the bots.

  • platform/gtk/fast/dom/vertical-scrollbar-in-rtl-expected.txt: Fix differing baseline.
6:37 AM Changeset in webkit [73330] by xan@webkit.org
  • 10 edits in trunk

WebCore:

2010-12-04 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Drop GdkDrawable usage, it's deprecated in GTK+3.x and we can use GdkWindow
​https://bugs.webkit.org/show_bug.cgi?id=50451

GdkDrawable has been removed in GTK+3.x. To cope with this we can
actually stop using it altogether, since GdkWindow is just a
typedef for it and that seems to be good enough for us.

  • platform/graphics/GraphicsContext.h: s/GdkDrawable/GdkWindow/.
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::gdkWindow): ditto.
  • platform/gtk/GtkVersioning.h: declare GDK_WINDOW_XWINDOW for GTK 3.x builds.
  • platform/gtk/PlatformScreenGtk.cpp: (WebCore::screenAvailableRect): s/GdkDrawable/GdkWindow/.
  • platform/gtk/WidgetGtk.cpp: (WebCore::gdkWindow): ditto. (WebCore::Widget::setCursor): ditto.
  • platform/gtk/WidgetRenderingContextGtk2.cpp: ditto.

JavaScriptCore:

2010-12-04 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Drop GdkDrawable usage, it's deprecated in GTK+3.x and we can use GdkWindow
​https://bugs.webkit.org/show_bug.cgi?id=50451

  • wtf/gobject/GTypedefs.h: add GdkWindow defines.
6:34 AM Changeset in webkit [73329] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2010-12-04 Philippe Normand <​pnormand@igalia.com>

Unreviewed, skipping failing media test.

  • platform/gtk/Skipped: Skip media/controls-without-preload.html
6:23 AM Changeset in webkit [73328] by Martin Robinson
  • 1 edit
    2 adds in trunk/LayoutTests

2010-12-04 Martin Robinson <​mrobinson@igalia.com>

Check in platform-specific results for failing RTL tests on GTK+. Comments
at ​https://bugs.webkit.org/show_bug.cgi?id=50352 suggest that these failing
results are fine for now.

  • platform/gtk/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Added.
  • platform/gtk/fast/dom/vertical-scrollbar-in-rtl-expected.txt: Added.
4:15 AM Changeset in webkit [73327] by jnd@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2010-12-04 Johnny Ding <​jnd@chromium.org>

Reviewed by Alexey Proskuryakov.

The JavaScript created (untrusted) event inside a user-initiated
(trusted) event should not cache the UserGesture status.

​https://bugs.webkit.org/show_bug.cgi?id=50508

  • fast/events/popup-blocked-from-untrusted-mouse-click-expected.txt: Added.
  • fast/events/popup-blocked-from-untrusted-mouse-click.html: Added.
2:04 AM Changeset in webkit [73326] by Patrick Gansterer
  • 4 edits in trunk/BugsSite

2010-12-04 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Increase size of status bubbles
​https://bugs.webkit.org/show_bug.cgi?id=50496

The current available space isn't enough to display all
pending results including position in the queue.

  • template/en/custom/attachment/edit.html.tmpl:
  • template/en/custom/attachment/list.html.tmpl:
  • template/en/custom/attachment/reviewform.html.tmpl:

Dec 3, 2010:

9:27 PM Changeset in webkit [73325] by tonikitoo@webkit.org
  • 9 edits in trunk

[GTK+] Populate DumpRenderTreeSupportGtk
​https://bugs.webkit.org/show_bug.cgi?id=48429

Reviewed by Martin Robinson.
Patch by Antonio Gomes <​agomes@rim.com>

WebKit/gtk:

Moved most of the webkit_web_frame* methods defined as private APIs in webkitprivate.h
to DumpRenderTreeSupportGtk, as static class methods. These methods had
not gone throught the formal API review process and were only being used by DRT for now.

The essence of each original method name were kept. For example
webkit_web_frame_get_children(...) was renamed to DumpRenderTreeSupportGtk::getFrameChildren(...),
and so on.

Also some of the method bodies were changed to return non-glib types (gchar* -> CString).

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::getFrameChildren):
(DumpRenderTreeSupportGtk::getInnerText):
(DumpRenderTreeSupportGtk::dumpRenderTree):
(DumpRenderTreeSupportGtk::counterValueForElementById):
(DumpRenderTreeSupportGtk::pageNumberForElementById):
(DumpRenderTreeSupportGtk::numberOfPagesForFrame):
(DumpRenderTreeSupportGtk::getPendingUnloadEventCount):
(DumpRenderTreeSupportGtk::pauseAnimation):
(DumpRenderTreeSupportGtk::pauseTransition):
(DumpRenderTreeSupportGtk::pauseSvgAnimation):
(DumpRenderTreeSupportGtk::markerTextForListItem):
(DumpRenderTreeSupportGtk::numberOfActiveAnimations):
(DumpRenderTreeSupportGtk::suspendAnimations):
(DumpRenderTreeSupportGtk::resumeAnimations):
(DumpRenderTreeSupportGtk::clearMainFrameName):
(DumpRenderTreeSupportGtk::getFocusedAccessibleElement):

  • WebCoreSupport/DumpRenderTreeSupportGtk.h:
  • webkit/webkitprivate.h:
  • webkit/webkitwebframe.cpp:

WebKitTools:

Made the previous calls to webkit_web_frame* functions defined as private
APIs in webkitprivate.h go through DRTSupportGtk.

  • DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:

(AccessibilityController::focusedElement):

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(dumpFramesAsText):
(resetDefaultsToConsistentValues):
(dump):
(webViewDocumentLoadFinished):

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::counterValueForElementById):
(LayoutTestController::pageNumberForElementById):
(LayoutTestController::numberOfPages):
(LayoutTestController::pauseAnimationAtTimeOnElementWithId):
(LayoutTestController::pauseTransitionAtTimeOnElementWithId):
(LayoutTestController::sampleSVGAnimationForElementAtTime):
(LayoutTestController::numberOfActiveAnimations):
(LayoutTestController::suspendAnimations):
(LayoutTestController::resumeAnimations):
(LayoutTestController::markerTextForListItem):

7:19 PM Changeset in webkit [73324] by timothy@apple.com
  • 12 edits in trunk/WebKit2

Make the Web Inspector window show and be usable on Mac.

​https://webkit.org/b/50490

Reviewed by Sam Weinig.

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::invalidate): Call platformClose.
(WebKit::WebInspectorProxy::didLoadInspectorPage): Call platformOpen.
(WebKit::WebInspectorProxy::didClose): Call platformClose.

  • UIProcess/WebInspectorProxy.h:
  • UIProcess/WebInspectorProxy.messages.in: Added DidClose.
  • UIProcess/mac/WebInspectorProxyMac.mm:

(-[WebInspectorProxyObjCAdapter initWithWebInspectorProxy:]): Added.
(-[WebInspectorProxyObjCAdapter windowWillClose:]): Added. Call WebInspectorProxy::close.
(WebKit::WebInspectorProxy::platformOpen): Added.
(WebKit::WebInspectorProxy::platformClose): Added.

  • UIProcess/qt/WebInspectorProxyQt.cpp:

(WebKit::WebInspectorProxy::platformOpen): Added stub.
(WebKit::WebInspectorProxy::platformClose): Added stub.

  • UIProcess/win/WebInspectorProxyWin.cpp:

(WebKit::WebInspectorProxy::platformOpen): Added stub.
(WebKit::WebInspectorProxy::platformClose): Added stub.

  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::sendMessageToFrontend): Added more null checks to avoid a crash.

  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:

(WebKit::WebInspectorFrontendClient::closeWindow): Call WebInspector::didClose.
(WebKit::WebInspectorFrontendClient::disconnectFromBackend): Ditto.
(WebKit::WebInspectorFrontendClient::sendMessageToBackend): Removed. This does not need to be
implemented by our subclass since we are in a single process.

  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.h: Removed sendMessageToBackend.
  • WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::didClose): Added. Send a DidClose message to the UI process.

  • WebProcess/WebPage/WebInspector.h:
6:46 PM Changeset in webkit [73323] by barraclough@apple.com
  • 8 edits in trunk/JavaScriptCore

Bug 50509 - set* methods on MacroAssembler are awfully named.

Rubber stamped by Oliver Hunt.

Methods set32 and setTest32 compare 32-bit operands, and set a 32-bit results based on the comparison.
set8 compares 32-bit operands, and sets an 8-bit result based on the comparison.
setTest8 compares 8-bit operands, and sets a 32-bit result based on the comparison.

Rename to clarify.

set32 -> set32Compare32
setTest32 -> set32Test32
set8 -> set8Compare32
setTest8 -> set32Test8

  • assembler/MacroAssembler.h:

(JSC::MacroAssembler::setPtr):

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::set32Compare32):
(JSC::MacroAssemblerARM::set8Compare32):
(JSC::MacroAssemblerARM::set32Test32):
(JSC::MacroAssemblerARM::set32Test8):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::set32Compare32):
(JSC::MacroAssemblerARMv7::set8Compare32):
(JSC::MacroAssemblerARMv7::set32Test32):
(JSC::MacroAssemblerARMv7::set32Test8):

  • assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::set8Compare32):
(JSC::MacroAssemblerMIPS::set32Compare32):
(JSC::MacroAssemblerMIPS::set32Test8):
(JSC::MacroAssemblerMIPS::set32Test32):

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::set8Compare32):
(JSC::MacroAssemblerX86Common::set32Compare32):
(JSC::MacroAssemblerX86Common::set32Test8):
(JSC::MacroAssemblerX86Common::set32Test32):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_eq):
(JSC::JIT::emit_op_neq):
(JSC::JIT::compileOpStrictEq):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_eq):
(JSC::JIT::emit_op_neq):
(JSC::JIT::compileOpStrictEq):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):

6:45 PM Changeset in webkit [73322] by Martin Robinson
  • 1 edit
    1 add in trunk/LayoutTests

2010-12-03 Martin Robinson <​mrobinson@igalia.com>

Add a platform-specific baseline for GTK+ after r73128. This test
just click at a predetermined location in the middle of the text field.
Since GTK+ font sizes differ from other ports, the text selected differs.

  • platform/gtk/fast/forms/onselect-textarea-expected.txt: Added.
6:05 PM Changeset in webkit [73321] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

2010-12-03 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoff Garen.

Incorrect logic for returning memory at the end of linking.
Reviewed by Geoff Garen.

At the end of linking we return any space at the end of the
allocated executable region that was saved due to branch
compaction. This is currently by done by subtracting the
different from the m_freePtr in the allocation pool. This
can be incorrect if your allocation was made from a new
page that was not selected for subsequent allocations.

This patch corrects this behaviour by verifying that the
memory being returned actually comes from the current
allocation pool.

  • assembler/LinkBuffer.h: (JSC::LinkBuffer::linkCode):
  • jit/ExecutableAllocator.h: (JSC::ExecutablePool::tryShrink):
5:46 PM Changeset in webkit [73320] by mihaip@chromium.org
  • 5 edits in trunk/WebKitTools

2010-12-03 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Tony Chang.

Rebaseline server: use pretty text diff output
​https://bugs.webkit.org/show_bug.cgi?id=50484

Serve *-pretty-diff.html for text diff output.

  • Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
  • Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
  • Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
  • Scripts/webkitpy/tool/commands/rebaselineserver.py:
4:11 PM Changeset in webkit [73319] by Dimitri Glazkov
  • 3 edits
    2 adds in trunk

2010-12-03 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

REGRESSION(r71934): input event fires twice when editing text inside a text input.
​https://bugs.webkit.org/show_bug.cgi?id=50477

  • fast/forms/text-input-event-expected.txt: Added.
  • fast/forms/text-input-event.html: Added.

2010-12-03 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

REGRESSION(r71934): input event fires twice when editing text inside a text input.
​https://bugs.webkit.org/show_bug.cgi?id=50477

Now that events escape the shadow DOM boundary, the input event is fired twice
for each input, once triggered by editing, once triggered by value change.

Test: fast/forms/text-input-event.html

  • dom/InputElement.cpp: (WebCore::InputElement::setValueFromRenderer): Added a check to ensure editable fields

don't fire an extra input event.

4:04 PM Changeset in webkit [73318] by andersca@apple.com
  • 5 edits in trunk/WebKit2

Clean up the BackingStore implementation
​https://bugs.webkit.org/show_bug.cgi?id=50498

Reviewed by Sam Weinig and Dan Bernstein.

  • Shared/BackingStore.cpp:

(WebKit::BackingStore::create):
(WebKit::BackingStore::createSharable):
(WebKit::BackingStore::resize):
Use new numBytesForSize helper function.

(WebKit::BackingStore::createFlippedGraphicsContext):
Make this function platform independent.

  • Shared/BackingStore.h:

(WebKit::BackingStore::numBytesForSize):
Given a size, return the number of bytes needed for it.

(WebKit::BackingStore::sizeInBytes):
Implement.

  • Shared/cg/BackingStoreCG.cpp:

(WebKit::BackingStore::paint):
Don't use CGBitmapContextCreateImage; it creates an extra copy of the image data.

  • Shared/qt/BackingStoreQt.cpp:

Remove createFlippedGraphicsContext.

4:01 PM Changeset in webkit [73317] by commit-queue@webkit.org
  • 14 edits in trunk

2010-12-03 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r73302.
​http://trac.webkit.org/changeset/73302
​https://bugs.webkit.org/show_bug.cgi?id=50499

Causes crashes in debug LayoutTests (Requested by xan_ on
#webkit).

  • platform/win/Skipped:

2010-12-03 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r73302.
​http://trac.webkit.org/changeset/73302
​https://bugs.webkit.org/show_bug.cgi?id=50499

Causes crashes in debug LayoutTests (Requested by xan_ on
#webkit).

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::renderParentObject): (WebCore::AccessibilityRenderObject::addChildren):
  • accessibility/AccessibilityRenderObject.h:
  • accessibility/chromium/AccessibilityObjectChromium.cpp: (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):

2010-12-03 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r73302.
​http://trac.webkit.org/changeset/73302
​https://bugs.webkit.org/show_bug.cgi?id=50499

Causes crashes in debug LayoutTests (Requested by xan_ on
#webkit).

  • public/WebAccessibilityObject.h:
  • src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::parentObject):

2010-12-03 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r73302.
​http://trac.webkit.org/changeset/73302
​https://bugs.webkit.org/show_bug.cgi?id=50499

Causes crashes in debug LayoutTests (Requested by xan_ on
#webkit).

  • DumpRenderTree/chromium/AccessibilityUIElement.cpp: (AccessibilityUIElement::AccessibilityUIElement): (AccessibilityUIElement::parentElementCallback):
  • DumpRenderTree/chromium/AccessibilityUIElement.h:
  • DumpRenderTree/chromium/CppBoundClass.cpp:
  • DumpRenderTree/chromium/CppBoundClass.h:
3:52 PM Changeset in webkit [73316] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/efl

2010-12-03 Alex Bredariol Grilo <​abgrilo@profusion.mobi>

Reviewed by Andreas Kling.

Update usage of Eina_Iterator due to EFL changes.
​https://bugs.webkit.org/show_bug.cgi?id=50457

  • ewk/ewk_tiled_model.c: (ewk_tile_updates_process):
3:40 PM Changeset in webkit [73315] by loislo@chromium.org
  • 13 edits in trunk

2010-12-01 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Inspector protocol cleanup task.

The patch has just small renames and adjustments for the protocol things.
'handler' keyword in idl file was replaced with 'domain'.
'domain' property was assigned for the each backend to frontend messages.
At the next step WebInspector wrapper functions will be removed and 'agents' will be called directly.

​https://bugs.webkit.org/show_bug.cgi?id=50337

  • inspector/CodeGeneratorInspector.pm:
  • inspector/Inspector.idl:
  • inspector/front-end/inspector.js: (WebInspector_syncDispatch):

2010-12-01 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Inspector protocol cleanup task.

The patch has just small renames and adjustments for the protocol things.
'handler' keyword in idl file was replaced with 'domain'.
'domain' property was assigned for the each backend to frontend messages.
At the next step WebInspector wrapper functions will be removed and 'agents' will be called directly.

​https://bugs.webkit.org/show_bug.cgi?id=50337

  • src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::dispatchOnInspectorFrontend):

2010-12-01 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Inspector protocol cleanup task.

The patch has just small renames and adjustments for the protocol things.
'handler' keyword in idl file was replaced with 'domain'.
'domain' property was assigned for the each backend to frontend messages.
At the next step WebInspector wrapper functions will be removed and 'agents' will be called directly.

​https://bugs.webkit.org/show_bug.cgi?id=50337

  • inspector/report-API-errors-expected.txt:
  • inspector/report-API-errors.html:
  • inspector/report-protocol-errors-expected.txt:
3:38 PM Changeset in webkit [73314] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Update WebKit2 skipped list.

  • platform/mac-wk2/Skipped:
3:34 PM Changeset in webkit [73313] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit2

2010-12-03 Siddharth Mathur <​siddharth.mathur@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] [WK2] Build system improvements for non-Unix targets
​https://bugs.webkit.org/show_bug.cgi?id=50257

  • DerivedSources.pro: Fix dir seperator errors on Windows build host. Thanks to Laszlo Gombos.
3:25 PM Changeset in webkit [73312] by weinig@apple.com
  • 10 edits in trunk

Enable <a ping> for Mac/Windows/WebKit2 builds
<rdar://problem/8504473>
​https://bugs.webkit.org/show_bug.cgi?id=50488

Reviewed by Maciej Stachowiak.

WebKit/mac:

  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]): Enable "HyperlinkAuditing" by default.

WebKit/win:

  • WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings): Enable "HyperlinkAuditing" by default.

WebKit2:

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetHyperlinkAuditingEnabled):
(WKPreferencesGetHyperlinkAuditingEnabled):

  • UIProcess/API/C/WKPreferences.h:

Add "HyperlinkAuditing" preference and enabled it by default.

WebKitTools:

  • TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:

(TestWebKitAPI::TEST): Test that the default value of
WKPreferencesGetHyperlinkAuditingEnabled is true.

3:18 PM Changeset in webkit [73311] by apavlov@chromium.org
  • 3 edits in trunk/WebCore

2010-12-03 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Duplicate "!important" for !important properties displayed in the Styles pane
​https://bugs.webkit.org/show_bug.cgi?id=50460

  • inspector/front-end/StylesSidebarPane.js:
  • inspector/front-end/inspector.css:
3:16 PM Changeset in webkit [73310] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Flip the destination context when painting a backing store into the destination
​https://bugs.webkit.org/show_bug.cgi?id=50491

Reviewed by Dan Bernstein.

  • Shared/cg/BackingStoreCG.cpp:

(WebKit::BackingStore::paint):

3:09 PM Changeset in webkit [73309] by xan@webkit.org
  • 4 edits in trunk

2010-12-03 Xan Lopez <​xlopez@igalia.com>

Unreviewed build fix for GTK+.

Add configure.ac-fu for WebAudio.

  • configure.ac:

WebCore:

2010-12-03 Xan Lopez <​xlopez@igalia.com>

Unreviewed build fix.

The JS code generator includes headers unconditionally, so we need
to generate them unconditionally and disable the feature. The
WebAudio files hadn't been added to our sources list.

  • GNUmakefile.am:
3:08 PM Changeset in webkit [73308] by victorw@chromium.org
  • 1 edit
    14 adds in trunk/LayoutTests

2010-12-03 Victor Wang <​victorw@chromium.org>

Unreviewed.

[Chromium] update chromium baselines for tests added by ​http://trac.webkit.org/changeset/73296

  • platform/chromium-linux/fast/multicol/span/anonymous-before-child-parent-crash-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/span/anonymous-before-child-parent-crash-expected.png: Added.
  • platform/chromium-linux/fast/multicol/span/anonymous-split-block-crash-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/span/anonymous-split-block-crash-expected.png: Added.
  • platform/chromium-mac/fast/multicol/span/anonymous-before-child-parent-crash-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/span/anonymous-before-child-parent-crash-expected.png: Added.
  • platform/chromium-mac/fast/multicol/span/anonymous-split-block-crash-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/span/anonymous-split-block-crash-expected.png: Added.
  • platform/chromium-win/fast/multicol/span/anonymous-before-child-parent-crash-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/span/anonymous-before-child-parent-crash-expected.png: Added.
  • platform/chromium-win/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt: Added.
  • platform/chromium-win/fast/multicol/span/anonymous-split-block-crash-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/span/anonymous-split-block-crash-expected.png: Added.
  • platform/chromium-win/fast/multicol/span/anonymous-split-block-crash-expected.txt: Added.
3:04 PM EFLWebKit edited by Patrick Gansterer
(diff)
2:48 PM Changeset in webkit [73307] by msaboff@apple.com
  • 12 edits
    3 adds in trunk

2010-12-03 Michael Saboff <​msaboff@apple.com>

Reviewed by Gavin Barraclough

Changes to significantly reduce branches to branches in JIT'ed
parentheses backtrack processing. The changes include the following:

  • Taking the backtracking processing out of line and adding it as code at the end of the JIT'ed routine.
  • Allow backtracks to be direct via an indirect branch for an address pushed onto the stack. If the use of an indirect branch is from a conditional jump, then we emit a trampoline at the end of the routine.
  • Propogate backtracks instead of adding trampolines. Backtracks are propogated to where they are used. This change also eliminated trampoline branch code that aren't used.
  • Added global expression state to keep track of parentheses tail code and indirect branches. Other changes made to support these changes.
  • Split invertOrCapture flag on Patterns to two separate flags. Added getters for these flags. Rippled these changes to both the JIT and interpreter code.
  • Split BacktrackDestination out off TermGenerationState struct. This is done to hold references to a backtrack for later code generation. ​https://bugs.webkit.org/show_bug.cgi?id=50295
  • assembler/ARMAssembler.h: (JSC::ARMAssembler::JmpDst::isSet):
  • assembler/ARMv7Assembler.h: (JSC::ARMv7Assembler::JmpDst::isSet):
  • assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::Label::isSet): (JSC::AbstractMacroAssembler::DataLabelPtr::isUsed): (JSC::AbstractMacroAssembler::DataLabelPtr::used): (JSC::AbstractMacroAssembler::JumpList::clear):
  • assembler/MIPSAssembler.h: (JSC::MIPSAssembler::JmpDst::isSet):
  • assembler/X86Assembler.h: (JSC::X86Assembler::JmpDst::isSet):
  • yarr/RegexCompiler.cpp: (JSC::Yarr::RegexPatternConstructor::atomParenthesesSubpatternBegin): (JSC::Yarr::RegexPatternConstructor::atomParentheticalAssertionBegin): (JSC::Yarr::RegexPatternConstructor::atomBackReference): (JSC::Yarr::RegexPatternConstructor::setupAlternativeBeginTerms):
  • yarr/RegexInterpreter.cpp: (JSC::Yarr::ByteCompiler::atomParenthesesOnceBegin): (JSC::Yarr::ByteCompiler::atomParenthesesTerminalBegin): (JSC::Yarr::ByteCompiler::atomParenthesesSubpatternBegin): (JSC::Yarr::ByteCompiler::atomParentheticalAssertionBegin): (JSC::Yarr::ByteCompiler::atomParentheticalAssertionEnd): (JSC::Yarr::ByteCompiler::atomParenthesesSubpatternEnd): (JSC::Yarr::ByteCompiler::atomParenthesesOnceEnd): (JSC::Yarr::ByteCompiler::atomParenthesesTerminalEnd): (JSC::Yarr::ByteCompiler::emitDisjunction):
  • yarr/RegexInterpreter.h: (JSC::Yarr::ByteTerm::ByteTerm): (JSC::Yarr::ByteTerm::BackReference): (JSC::Yarr::ByteTerm::invert): (JSC::Yarr::ByteTerm::capture):
  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::IndirectJumpEntry::IndirectJumpEntry): (JSC::Yarr::RegexGenerator::IndirectJumpEntry::addJump): (JSC::Yarr::RegexGenerator::GenerationState::GenerationState): (JSC::Yarr::RegexGenerator::GenerationState::addIndirectJumpEntry): (JSC::Yarr::RegexGenerator::GenerationState::emitIndirectJumpTable): (JSC::Yarr::RegexGenerator::GenerationState::addParenthesesTail): (JSC::Yarr::RegexGenerator::GenerationState::emitParenthesesTail): (JSC::Yarr::RegexGenerator::GenerationState::addJumpToNextInteration): (JSC::Yarr::RegexGenerator::GenerationState::addJumpsToNextInteration): (JSC::Yarr::RegexGenerator::GenerationState::addDataLabelToNextIteration): (JSC::Yarr::RegexGenerator::GenerationState::linkToNextIteration): (JSC::Yarr::RegexGenerator::BacktrackDestination::BacktrackDestination): (JSC::Yarr::RegexGenerator::BacktrackDestination::clear): (JSC::Yarr::RegexGenerator::BacktrackDestination::clearDataLabel): (JSC::Yarr::RegexGenerator::BacktrackDestination::haveDestination): (JSC::Yarr::RegexGenerator::BacktrackDestination::isStackOffset): (JSC::Yarr::RegexGenerator::BacktrackDestination::isLabel): (JSC::Yarr::RegexGenerator::BacktrackDestination::isJumpList): (JSC::Yarr::RegexGenerator::BacktrackDestination::haveDataLabel): (JSC::Yarr::RegexGenerator::BacktrackDestination::copyTarget): (JSC::Yarr::RegexGenerator::BacktrackDestination::copyTo): (JSC::Yarr::RegexGenerator::BacktrackDestination::addBacktrackJump): (JSC::Yarr::RegexGenerator::BacktrackDestination::setStackOffset): (JSC::Yarr::RegexGenerator::BacktrackDestination::setLabel): (JSC::Yarr::RegexGenerator::BacktrackDestination::setNextBacktrackLabel): (JSC::Yarr::RegexGenerator::BacktrackDestination::setBacktrackToLabel): (JSC::Yarr::RegexGenerator::BacktrackDestination::setBacktrackJumpList): (JSC::Yarr::RegexGenerator::BacktrackDestination::setBacktrackSourceLabel): (JSC::Yarr::RegexGenerator::BacktrackDestination::setDataLabel): (JSC::Yarr::RegexGenerator::BacktrackDestination::setSubDataLabelPtr): (JSC::Yarr::RegexGenerator::BacktrackDestination::linkToNextBacktrack): (JSC::Yarr::RegexGenerator::BacktrackDestination::getStackOffset): (JSC::Yarr::RegexGenerator::BacktrackDestination::getLabel): (JSC::Yarr::RegexGenerator::BacktrackDestination::getBacktrackJumps): (JSC::Yarr::RegexGenerator::BacktrackDestination::getDataLabel): (JSC::Yarr::RegexGenerator::BacktrackDestination::jumpToBacktrack): (JSC::Yarr::RegexGenerator::BacktrackDestination::linkDataLabelToHereIfExists): (JSC::Yarr::RegexGenerator::BacktrackDestination::plantJumpToBacktrackIfExists): (JSC::Yarr::RegexGenerator::BacktrackDestination::linkAlternativeBacktracks): (JSC::Yarr::RegexGenerator::BacktrackDestination::linkAlternativeBacktracksTo): (JSC::Yarr::RegexGenerator::TermGenerationState::TermGenerationState): (JSC::Yarr::RegexGenerator::TermGenerationState::resetAlternative): (JSC::Yarr::RegexGenerator::TermGenerationState::isLastAlternative): (JSC::Yarr::RegexGenerator::TermGenerationState::clearBacktrack): (JSC::Yarr::RegexGenerator::TermGenerationState::jumpToBacktrack): (JSC::Yarr::RegexGenerator::TermGenerationState::plantJumpToBacktrackIfExists): (JSC::Yarr::RegexGenerator::TermGenerationState::linkDataLabelToBacktrackIfExists): (JSC::Yarr::RegexGenerator::TermGenerationState::addBacktrackJump): (JSC::Yarr::RegexGenerator::TermGenerationState::setDataLabelPtr): (JSC::Yarr::RegexGenerator::TermGenerationState::setBackTrackStackOffset): (JSC::Yarr::RegexGenerator::TermGenerationState::setBacktrackLabel): (JSC::Yarr::RegexGenerator::TermGenerationState::linkAlternativeBacktracks): (JSC::Yarr::RegexGenerator::TermGenerationState::linkAlternativeBacktracksTo): (JSC::Yarr::RegexGenerator::TermGenerationState::setBacktrackLink): (JSC::Yarr::RegexGenerator::TermGenerationState::chainBacktracks): (JSC::Yarr::RegexGenerator::TermGenerationState::chainBacktrackJumps): (JSC::Yarr::RegexGenerator::TermGenerationState::getBacktrackDestination): (JSC::Yarr::RegexGenerator::TermGenerationState::propagateBacktrackingFrom): (JSC::Yarr::RegexGenerator::ParenthesesTail::ParenthesesTail): (JSC::Yarr::RegexGenerator::ParenthesesTail::processBacktracks): (JSC::Yarr::RegexGenerator::ParenthesesTail::setNextIteration): (JSC::Yarr::RegexGenerator::ParenthesesTail::generateCode): (JSC::Yarr::RegexGenerator::generateAssertionBOL): (JSC::Yarr::RegexGenerator::generateAssertionEOL): (JSC::Yarr::RegexGenerator::generateAssertionWordBoundary): (JSC::Yarr::RegexGenerator::generatePatternCharacterSingle): (JSC::Yarr::RegexGenerator::generatePatternCharacterPair): (JSC::Yarr::RegexGenerator::generatePatternCharacterFixed): (JSC::Yarr::RegexGenerator::generatePatternCharacterGreedy): (JSC::Yarr::RegexGenerator::generatePatternCharacterNonGreedy): (JSC::Yarr::RegexGenerator::generateCharacterClassSingle): (JSC::Yarr::RegexGenerator::generateCharacterClassFixed): (JSC::Yarr::RegexGenerator::generateCharacterClassGreedy): (JSC::Yarr::RegexGenerator::generateCharacterClassNonGreedy): (JSC::Yarr::RegexGenerator::generateParenthesesDisjunction): (JSC::Yarr::RegexGenerator::generateParenthesesSingle): (JSC::Yarr::RegexGenerator::generateParenthesesGreedyNoBacktrack): (JSC::Yarr::RegexGenerator::generateParentheticalAssertion): (JSC::Yarr::RegexGenerator::generateDisjunction): (JSC::Yarr::RegexGenerator::compile):
  • yarr/RegexPattern.h: (JSC::Yarr::PatternTerm::PatternTerm): (JSC::Yarr::PatternTerm::invert): (JSC::Yarr::PatternTerm::capture):

2010-12-03 Michael Saboff <​msaboff@apple.com>

Reviewed by Gavin Barraclough

Added new tests to support changes to Regexp JIT code handling
of parentheses. Tests focused on backtracking and nested
subexpressions.
​https://bugs.webkit.org/show_bug.cgi?id=50295

  • fast/regex/parentheses-expected.txt: Added.
  • fast/regex/parentheses.html: Added.
  • fast/regex/script-tests/parentheses.js: Added.
2:36 PM Changeset in webkit [73306] by inferno@chromium.org
  • 1 edit
    8 copies in branches/chromium/552

Merge 73296

BUG=63982

2:36 PM Changeset in webkit [73305] by bweinstein@apple.com
  • 2 edits in trunk/WebKit/win

WebContextMenuClient::fixMenuReceivedFromOldSafari is no longer needed on Windows
​https://bugs.webkit.org/show_bug.cgi?id=50486

Reviewed by Brady Eidson.

Remove the static fixMenuReceivedFromOldSafari and isPreInspectElementTagSafari methods
from WebContextMenuClient. There were there for when WebKit had the Inspect Element context menu
item, but Safari didn't support it. We don't support that old Safari, so that code can go.

  • WebCoreSupport/WebContextMenuClient.cpp:

(WebContextMenuClient::getCustomMenuFromDefaultItems):

2:32 PM Changeset in webkit [73304] by inferno@chromium.org
  • 1 edit
    8 copies in branches/chromium/597

Merge 73296

BUG=63982
Review URL: ​http://codereview.chromium.org/5643001

2:32 PM Changeset in webkit [73303] by Patrick Gansterer
  • 2 edits in trunk/WebCore

2010-12-03 Patrick Gansterer <Patrick Gansterer>

Unreviewed build fix.

Try to fix EFL build after r73273.

  • CMakeLists.txt:
2:27 PM Changeset in webkit [73302] by commit-queue@webkit.org
  • 14 edits in trunk

2010-12-03 Chris Guillory <​chris.guillory@google.com>

Reviewed by Chris Fleizach.

Include the FrameView widget of a RenderWidget in the accessibility tree.
​https://bugs.webkit.org/show_bug.cgi?id=49106

  • platform/win/Skipped:

2010-12-03 Chris Guillory <​chris.guillory@google.com>

Reviewed by Chris Fleizach.

Include the FrameView widget of a RenderWidget in the accessibility tree.
​https://bugs.webkit.org/show_bug.cgi?id=49106

Include render widget children in the accessibility tree for not mac webkit ports.

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::renderParentObject): (WebCore::AccessibilityRenderObject::addChildren): (WebCore::AccessibilityRenderObject::addRenderWidgetChildren):
  • accessibility/AccessibilityRenderObject.h:
  • accessibility/chromium/AccessibilityObjectChromium.cpp: (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):

2010-12-03 Chris Guillory <​chris.guillory@google.com>

Reviewed by Chris Fleizach.

Include the FrameView widget of a RenderWidget in the accessibility tree.
​https://bugs.webkit.org/show_bug.cgi?id=49106

  • public/WebAccessibilityObject.h:
  • src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::equals): (WebKit::WebAccessibilityObject::parentObject):

2010-12-03 Chris Guillory <​chris.guillory@google.com>

Reviewed by Chris Fleizach.

Include the FrameView widget of a RenderWidget in the accessibility tree.
​https://bugs.webkit.org/show_bug.cgi?id=49106

  • DumpRenderTree/chromium/AccessibilityUIElement.cpp: (AccessibilityUIElement::AccessibilityUIElement): (AccessibilityUIElement::parentElementCallback): (AccessibilityUIElement::isEqualCallback):
  • DumpRenderTree/chromium/AccessibilityUIElement.h:
  • DumpRenderTree/chromium/CppBoundClass.cpp: (CppBoundClass::getFromCppVariant):
  • DumpRenderTree/chromium/CppBoundClass.h:
2:10 PM Changeset in webkit [73301] by beidson@apple.com
  • 2 edits in trunk/WebKit2

Export the 4 new API headers I added today.

Reviewed by good sense in fixing builds.

  • WebKit2.xcodeproj/project.pbxproj:
2:08 PM Changeset in webkit [73300] by victorw@chromium.org
  • 1 edit
    2 deletes in trunk/LayoutTests

2010-12-03 Victor Wang <​victorw@chromium.org>

Unreviewed.

[Chromium] clean up chromium test expectations.

  • platform/chromium-mac/platform/mac/editing: Removed.
  • platform/chromium-mac/platform/mac/editing/spelling: Removed.
  • platform/chromium-mac/platform/mac/editing/spelling/delete-autocorrected-word-1-expected.checksum: Removed.
  • platform/chromium-mac/platform/mac/editing/spelling/delete-autocorrected-word-1-expected.png: Removed.
  • platform/chromium-win/platform/mac/editing/spelling: Removed.
  • platform/chromium-win/platform/mac/editing/spelling/delete-autocorrected-word-1-expected.checksum: Removed.
  • platform/chromium-win/platform/mac/editing/spelling/delete-autocorrected-word-1-expected.png: Removed.
2:06 PM Changeset in webkit [73299] by beidson@apple.com
  • 5 edits in trunk/WebKit2

<rdar://problem/8725679> and ​https://bugs.webkit.org/show_bug.cgi?id=50482
Crash trying to empty caches with no WebProcess.

Reviewed by Sam Weinig.

  • Shared/WebProcessCreationParameters.h: Add the "clear this cache" flags.
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::ensureWebProcess): If either of the clear cache flags are set when a new WebProcess is

created, include those flags in the parameters.

(WebKit::WebContext::clearResourceCaches): If the current process isn't valid, flag this action to be done later.
(WebKit::WebContext::clearApplicationCache): Ditto.

  • UIProcess/WebContext.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess): Clear the caches if told to.

2:02 PM Changeset in webkit [73298] by mihaip@chromium.org
  • 4 edits in trunk/WebKitTools

2010-12-03 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Tony Chang.

Rebaseline server: organize tests by state, add dry run mode
​https://bugs.webkit.org/show_bug.cgi?id=50473

Group tests in the menu by state, so that it's easier to see after
processing the queue which failed.

Add support for the --dry-run flag so that it's easier to test changes
such as this (stubs out filesystem and SCM operations).

  • Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
  • Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
  • Scripts/webkitpy/tool/commands/rebaselineserver.py:
1:51 PM Changeset in webkit [73297] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Fix failing API test. The default san serif font on the mac
should be Helvetica, not Courier.

Reviewed by Gavin Barraclough.

  • Shared/WebPreferencesStore.h:
1:44 PM Changeset in webkit [73296] by inferno@chromium.org
  • 3 edits
    8 adds in trunk

2010-11-30 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dave Hyatt.

Don't clone an anonymous block, instead create a new one in splitBlocks. Also,
when beforeChild is not in one of our children, then do the processing first
to get its anonymous container before calling splitBlocks.
​https://bugs.webkit.org/show_bug.cgi?id=49928

Tests: fast/multicol/span/anonymous-before-child-parent-crash.html

fast/multicol/span/anonymous-split-block-crash.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::splitBlocks): (WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):

2010-12-03 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dave Hyatt.

Test passes if we do not crash in splitBlocks while working with anonymous
blocks.
​https://bugs.webkit.org/show_bug.cgi?id=49928

  • fast/multicol/span/anonymous-before-child-parent-crash.html: Added.
  • fast/multicol/span/anonymous-split-block-crash.html: Added.
  • platform/mac/fast/multicol/span/anonymous-before-child-parent-crash-expected.checksum: Added.
  • platform/mac/fast/multicol/span/anonymous-before-child-parent-crash-expected.png: Added.
  • platform/mac/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt: Added.
  • platform/mac/fast/multicol/span/anonymous-split-block-crash-expected.checksum: Added.
  • platform/mac/fast/multicol/span/anonymous-split-block-crash-expected.png: Added.
  • platform/mac/fast/multicol/span/anonymous-split-block-crash-expected.txt: Added.
1:41 PM Changeset in webkit [73295] by mrowe@apple.com
  • 3 edits in trunk/WebCore

2010-12-03 Mark Rowe <​mrowe@apple.com>

Reviewed by Eric Seidel.

Animated GIF animates much more slowly in Safari than Firefox
<rdar://problem/7689300> / <​http://webkit.org/b/26455>

Adopt Firefox's behavior for frame duration clamping. Images that specify a frame duration
of <= 10ms are treated as having a frame duration of 100ms, while all other images use the
frame duration that they specify.

ImageIO currently implements its own clamping of frame durations (<rdar://problem/7689297>)
which will result in this change having no observable effect on platforms where it is used
until an updated version of ImageIO becomes available.

  • platform/graphics/ImageSource.cpp: (WebCore::ImageSource::frameDurationAtIndex): Update the formatting of the comment and style of the code to match that in ImageSourceCG.
  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::frameDurationAtIndex):
1:38 PM Changeset in webkit [73294] by crogers@google.com
  • 2 edits in trunk/WebCore

2010-12-03 Chris Rogers <​crogers@google.com>

Unreviewed build fix.

Fix M_E compile error on Chromium Win
​https://bugs.webkit.org/show_bug.cgi?id=50479

  • platform/audio/AudioUtilities.cpp: (WebCore::AudioUtilities::discreteTimeConstantForSampleRate):
1:17 PM Changeset in webkit [73293] by crogers@google.com
  • 2 edits in trunk/WebCore

2010-12-03 Chris Rogers <​crogers@google.com>

Unreviewed build fix.

Try to fix GTK build due to recent web audio makefile changes (disable ENABLE_WEB_AUDIO explicitly)
​https://bugs.webkit.org/show_bug.cgi?id=50478

  • GNUmakefile.am:
1:12 PM Changeset in webkit [73292] by Simon Fraser
  • 2 edits in trunk/WebCore

2010-12-03 Simon Fraser <Simon Fraser>

Reviewed by Dirk Schulze.

Clean up some text-related code on GraphicsContext
​https://bugs.webkit.org/show_bug.cgi?id=50464

Save 8 bytes in GraphicsContextState by rearranging the
data members to reduce padding.

  • platform/graphics/GraphicsContextPrivate.h: (WebCore::GraphicsContextState::GraphicsContextState):
1:09 PM Changeset in webkit [73291] by Simon Fraser
  • 2 edits in trunk/WebCore

2010-12-03 Simon Fraser <Simon Fraser>

Another Chromium build fix.

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformTextDrawingMode):
12:53 PM Changeset in webkit [73290] by Simon Fraser
  • 2 edits in trunk/WebCore

2010-12-03 Simon Fraser <Simon Fraser>

Fix Chromium build.

  • platform/graphics/skia/PlatformContextSkia.h:
12:53 PM Changeset in webkit [73289] by Patrick Gansterer
  • 2 edits in trunk/WebCore

2010-12-03 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[CMake] Remove WebCore_IDL_PURE_FILES
​https://bugs.webkit.org/show_bug.cgi?id=50445

  • CMakeLists.txt:
12:52 PM Changeset in webkit [73288] by jberlin@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

Update the Windows results for controls-without-preload.html to make the bots green. Unreviewed.

media/controls-without-preload.html failing on Windows
​https://bugs.webkit.org/show_bug.cgi?id=50471

  • platform/win/media/controls-without-preload-expected.txt: Added.
12:45 PM Changeset in webkit [73287] by commit-queue@webkit.org
  • 13 edits
    2 adds in trunk

2010-12-03 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

Need to move all code that applies correction into correction panel callback.
​https://bugs.webkit.org/show_bug.cgi?id=50426
<rdar://problem/8720832>

Added expected png file.

  • platform/mac/editing/spelling/delete-autocorrected-word-1-expected.checksum: Added.
  • platform/mac/editing/spelling/delete-autocorrected-word-1-expected.png: Added.

2010-12-03 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

Need to move all code that applies correction into correction panel callback.
​https://bugs.webkit.org/show_bug.cgi?id=50426
<rdar://problem/8720832>

No new test, since there's no behavioral change.

This patch is to prepare WebKit to work with upcoming AppKit changes. The main changes are:

  1. Moved all calls to applyCorrectionPanelInfo() into handleCorrectionPanelResult().
  2. Added more user dictionary learning code.
  3. Removed m_ prefix in all member variables of CorrectionPanelInfo.
  • editing/CorrectionPanelInfo.h: Remove m_ prefix on member variables. Added ReasonForDismissingCorrectionPanel enum type.
  • editing/Editor.cpp: Moved all calls to applyCorrectionPanelInfo() into handleCorrectionPanelResult(). Adopted new member variable naming in class CorrectionPanelInfo. (WebCore::Editor::respondToChangedSelection): (WebCore::Editor::~Editor): (WebCore::Editor::markMisspellingsAfterTypingToWord): (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): (WebCore::Editor::correctionPanelTimerFired): (WebCore::Editor::handleCorrectionPanelResult): (WebCore::Editor::startCorrectionPanelTimer): (WebCore::Editor::stopCorrectionPanelTimer): (WebCore::Editor::handleCancelOperation): (WebCore::Editor::dismissCorrectionPanel): (WebCore::Editor::applyCorrectionPanelInfo):
  • editing/Editor.h: Changed signature of dismissCorrectionPanel to use ReasonForDismissingCorrectionPanel.
  • loader/EmptyClients.h: Ditto. (WebCore::EmptyEditorClient::dismissCorrectionPanel):
  • page/EditorClient.h: Ditto.

2010-12-03 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

Need to move all code that applies correction into correction panel callback.
​https://bugs.webkit.org/show_bug.cgi?id=50426
<rdar://problem/8720832>

  • WebCoreSupport/WebEditorClient.h: Adopted new signature of dismissCorrectionPanel.
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::~WebEditorClient): Adopted new signature of dismissCorrectionPanel. (WebEditorClient::showCorrectionPanel): Added more user dictionary learning code. (WebEditorClient::dismissCorrectionPanel): Adopted new signature of dismissCorrectionPanel.

2010-12-03 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

Need to move all code that applies correction into correction panel callback.
​https://bugs.webkit.org/show_bug.cgi?id=50426
<rdar://problem/8720832>

Adopted new signature of dismissCorrectionPanel.

  • WebProcess/WebCoreSupport/WebEditorClient.h:
  • WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm: (WebKit::WebEditorClient::dismissCorrectionPanel):
12:35 PM Changeset in webkit [73286] by jberlin@webkit.org
  • 2 edits in trunk/WebKit2

Windows build fix. Unreviewed.

  • win/WebKit2Generated.make:

Add the new API files from ​http://trac.webkit.org/changeset/73281.

12:11 PM Changeset in webkit [73285] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2010-12-03 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: reveal in elements panel does not switch the panel itself.
​https://bugs.webkit.org/show_bug.cgi?id=50408

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired.focusElement): (WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired):
  • inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertyTreeElement.prototype._contextMenuEventFired):
12:08 PM Changeset in webkit [73284] by Simon Fraser
  • 22 edits in trunk/WebCore

2010-12-03 Simon Fraser <Simon Fraser>

Reviewed by Nikolas Zimmermann.

Clean up some text-related code on GraphicsContext
​https://bugs.webkit.org/show_bug.cgi?id=50464

Use defined types for textDrawingMode and it's associated flags.

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawTextInternal):
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::textDrawingMode): (WebCore::GraphicsContext::setTextDrawingMode): (WebCore::GraphicsContext::setPlatformTextDrawingMode):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/GraphicsContextPrivate.h: (WebCore::GraphicsContextState::GraphicsContextState):
  • platform/graphics/cairo/FontCairo.cpp: (WebCore::drawGlyphsShadow): (WebCore::Font::drawGlyphs):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setPlatformTextDrawingMode):
  • platform/graphics/chromium/FontLinux.cpp: (WebCore::Font::drawGlyphs): (WebCore::Font::drawComplexText):
  • platform/graphics/gtk/FontGtk.cpp: (WebCore::drawGlyphsShadow): (WebCore::Font::drawComplexText):
  • platform/graphics/mac/FontMac.mm: (WebCore::Font::drawGlyphs):
  • platform/graphics/openvg/PainterOpenVG.cpp: (WebCore::PlatformPainterState::PlatformPainterState): (WebCore::PainterOpenVG::textDrawingMode): (WebCore::PainterOpenVG::setTextDrawingMode): (WebCore::PainterOpenVG::drawText):
  • platform/graphics/qt/FontQt.cpp: (WebCore::drawTextCommon):
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::State::State): (WebCore::PlatformContextSkia::getTextDrawingMode): (WebCore::PlatformContextSkia::setTextDrawingMode):
  • platform/graphics/skia/SkiaFontWin.cpp: (WebCore::windowsCanHandleTextDrawing): (WebCore::paintSkiaText):
  • platform/graphics/texmap/TextureMapper.h: (WebCore::TextureMapper::setTextDrawingMode): (WebCore::TextureMapper::textDrawingMode): (WebCore::TextureMapper::TextureMapper):
  • platform/graphics/win/FontCGWin.cpp: (WebCore::drawGDIGlyphs): (WebCore::Font::drawGlyphs):
  • platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::GraphicsContext::drawText):
  • rendering/InlineTextBox.cpp: (WebCore::updateGraphicsContext):
  • rendering/RenderSVGResourceGradient.cpp: (WebCore::RenderSVGResourceGradient::applyResource):
  • rendering/RenderSVGResourcePattern.cpp: (WebCore::RenderSVGResourcePattern::applyResource):
  • rendering/RenderSVGResourceSolidColor.cpp: (WebCore::RenderSVGResourceSolidColor::applyResource):
  • svg/SVGFont.cpp: (WebCore::Font::drawTextUsingSVGFont):
12:05 PM Changeset in webkit [73283] by crogers@google.com
  • 14 edits
    1 add in trunk

2010-12-03 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

First steps to adding web audio files to build systems
​https://bugs.webkit.org/show_bug.cgi?id=49952

  • wtf/Complex.h:

2010-12-03 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

First steps to adding web audio files to build systems
​https://bugs.webkit.org/show_bug.cgi?id=49952

No new tests since audio API is not yet implemented.

  • CMakeLists.txt:
  • DerivedSources.make:
  • ForwardingHeaders/wtf/Complex.h: Added.
  • GNUmakefile.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::audioContext):
  • features.pri:
  • page/DOMWindow.idl:
  • platform/audio/HRTFElevation.cpp:
11:47 AM Changeset in webkit [73282] by Patrick Gansterer
  • 2 edits in trunk/WebCore

2010-12-03 Patrick Gansterer <Patrick Gansterer>

Reviewed by David Levin.

Use String::adopt in TextCodecWinCE::decode
​https://bugs.webkit.org/show_bug.cgi?id=50319

  • platform/text/wince/TextCodecWinCE.cpp: (WebCore::TextCodecWinCE::decode):
11:41 AM Changeset in webkit [73281] by beidson@apple.com
  • 29 edits
    21 adds in trunk

Groundwork for <rdar://problem/7660733> and ​https://bugs.webkit.org/show_bug.cgi?id=50191
WebKit2 Authentication Support

Reviewed by Anders Carlsson.

WebCore:

  • WebCore.exp.in:

Expose the AuthenticationClient for WK2 platforms (Windows already does this):

  • platform/network/mac/AuthenticationChallenge.h:
  • platform/network/mac/AuthenticationMac.mm:

(-[WebCoreAuthenticationClientAsChallengeSender client]):
(WebCore::AuthenticationChallenge::authenticationClient):

  • platform/network/qt/AuthenticationChallenge.h:

(WebCore::AuthenticationChallenge::authenticationClient):

WebKit2:

With this patch in place, authentication challenges are sent up from WebCore and shipped over the IPC layer.
Client apps can implement the related client methods to attempt to continue without credentials or cancel a
challenge.

There's not yet API to inspect a challenge or create a credential to use in reply - that will come later.

Build-system changes:

  • DerivedSources.make:
  • DerivedSources.pro:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • win/WebKit2Common.vsprops:

Messages and casts for IPC and APIs:

  • Platform/CoreIPC/MessageID.h:
  • Shared/API/c/WKBase.h:
  • Shared/APIObject.h:
  • Shared/WebCoreArgumentCoders.h:
  • UIProcess/API/C/WKAPICast.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::didReceiveMessage):

Stub out the AuthenticationChallenge class family:

  • UIProcess/API/C/WKAuthenticationChallenge.cpp: Added.

(WKAuthenticationChallengeGetTypeID):

  • UIProcess/API/C/WKAuthenticationChallenge.h: Added.
  • UIProcess/API/C/WKCredential.cpp: Added.

(WKCredentialGetTypeID):

  • UIProcess/API/C/WKCredential.h: Added.
  • UIProcess/API/C/WKProtectionSpace.cpp: Added.

(WKProtectionSpaceGetTypeID):

  • UIProcess/API/C/WKProtectionSpace.h: Added.

Add an Authentication listener for the client app to respond to:

  • UIProcess/API/C/WKAuthenticationDecisionListener.cpp: Added.

(WKAuthenticationDecisionListenerGetTypeID):
(WKAuthenticationDecisionListenerUseCredential):
(WKAuthenticationDecisionListenerCancel):

  • UIProcess/API/C/WKAuthenticationDecisionListener.h: Added.

Add Authentication related methods to the page loader client:

  • UIProcess/API/C/WKPage.h:

Add empty implementations of the new API objects:

  • UIProcess/Authentication: Added.
  • UIProcess/Authentication/AuthenticationChallengeProxy.cpp: Added.

(WebKit::AuthenticationChallengeProxy::AuthenticationChallengeProxy):
(WebKit::AuthenticationChallengeProxy::~AuthenticationChallengeProxy):
(WebKit::AuthenticationChallengeProxy::useCredential):
(WebKit::AuthenticationChallengeProxy::cancel):

  • UIProcess/Authentication/AuthenticationChallengeProxy.h: Added.

(WebKit::AuthenticationChallengeProxy::create):
(WebKit::AuthenticationChallengeProxy::listener):
(WebKit::AuthenticationChallengeProxy::type):

  • UIProcess/Authentication/WebCredential.cpp: Added.

(WebKit::WebCredential::core):

  • UIProcess/Authentication/WebCredential.h: Added.

(WebKit::WebCredential::create):
(WebKit::WebCredential::type):

  • UIProcess/Authentication/WebProtectionSpace.cpp: Added.

(WebKit::WebProtectionSpace::WebProtectionSpace):

  • UIProcess/Authentication/WebProtectionSpace.h: Added.

(WebKit::WebProtectionSpace::create):
(WebKit::WebProtectionSpace::type):

Add implementation of the Authentication decision listener:

  • UIProcess/Authentication/AuthenticationDecisionListener.cpp: Added.

(WebKit::AuthenticationDecisionListener::AuthenticationDecisionListener):
(WebKit::AuthenticationDecisionListener::useCredential):
(WebKit::AuthenticationDecisionListener::cancel):
(WebKit::AuthenticationDecisionListener::detachChallenge):

  • UIProcess/Authentication/AuthenticationDecisionListener.h: Added.

(WebKit::AuthenticationDecisionListener::create):
(WebKit::AuthenticationDecisionListener::type):

WebPage and PageLoaderClient glue:

  • UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::canAuthenticateAgainstProtectionSpaceInFrame):
(WebKit::WebLoaderClient::didReceiveAuthenticationChallengeInFrame):

  • UIProcess/WebLoaderClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::canAuthenticateAgainstProtectionSpaceInFrame):
(WebKit::WebPageProxy::didReceiveAuthenticationChallenge):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:

Add a manager to map the actual platform authentication challenges to a challenge ID,
as at least some platforms require the object identity to persist:

  • WebProcess/Authentication: Added.
  • WebProcess/Authentication/AuthenticationManager.cpp: Added.

(WebKit::generateAuthenticationChallengeID):
(WebKit::AuthenticationManager::shared):
(WebKit::AuthenticationManager::AuthenticationManager):
(WebKit::AuthenticationManager::didReceiveMessage):
(WebKit::AuthenticationManager::didReceiveAuthenticationChallenge):
(WebKit::AuthenticationManager::useCredentialForChallenge):
(WebKit::AuthenticationManager::continueWithoutCredentialForChallenge):
(WebKit::AuthenticationManager::cancelChallenge):

  • WebProcess/Authentication/AuthenticationManager.h: Added.
  • WebProcess/Authentication/AuthenticationManager.messages.in: Added.

Hand off Authentication challenges to the manager to be sent over IPC:

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
(WebKit::WebFrameLoaderClient::canAuthenticateAgainstProtectionSpace):

  • UIProcess/API/qt/qwkpage.cpp:

WebKitTools:

Keep these builds working:

  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController awakeFromNib]):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):

11:33 AM Changeset in webkit [73280] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Added fast/text/font-size-zero.html and svg/batik/text/smallFonts.svg to
the leopard skipped list.

Reviewed by Gavin Barraclough.

  • platform/mac-leopard/Skipped:
11:26 AM Changeset in webkit [73279] by rniwa@webkit.org
  • 5 edits
    8 adds in trunk

2010-12-03 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

REGRESSION: Crash when deleting text after textarea's value is modified on input event
​https://bugs.webkit.org/show_bug.cgi?id=49962

The crash was caused by TypingCommand::deleteKeyPressed's reusing a typing command for
textarea's shadow DOM after its input event handler rewrote the value set by the typing command.
Because the reused typing command's ending selection was pointing at a shadow node
that has been detached from the document when the event handler set the new value,
rootEditableElement of the ending selection was null and caused the crash.

Fixed the bug by updating the ending selection of the last typing command when it differsfrom
that of the current selection held by the SelectionController in TypingCommand::deleteKeyPressed.
Also fixed similar bugs in forwardDeleteKeyPressed and insertText, and insertTextRunWithoutNewlines.

Tests: editing/input/set-value-on-input-and-delete.html

editing/input/set-value-on-input-and-forward-delete.html
editing/input/set-value-on-input-and-type-input.html
editing/input/set-value-on-input-and-type-textarea.html

  • editing/InsertTextCommand.h: Added TypingCommand as a friend because it needs to update selection.
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): Updates the last typing command's selection as needed. (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto. (WebCore::TypingCommand::insertText): Ditto. (WebCore::TypingCommand::updateSelectionIfDifferentFromCurrentSelection): Added. (WebCore::TypingCommand::insertTextRunWithoutNewlines): Updates InsertTextCommand's selection as needed.
  • editing/TypingCommand.h:

2010-12-03 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

REGRESSION: Crash when deleting text after textarea's value is modified on input event
​https://bugs.webkit.org/show_bug.cgi?id=49962

Added tests to ensure inserting and deleting a character inside input or textarea
succeeds even if the value of those elements have been rewritten by its input event handler.

  • editing/input/set-value-on-input-and-delete-expected.txt: Added.
  • editing/input/set-value-on-input-and-delete.html: Added.
  • editing/input/set-value-on-input-and-forward-delete-expected.txt: Added.
  • editing/input/set-value-on-input-and-forward-delete.html: Added.
  • editing/input/set-value-on-input-and-type-input-expected.txt: Added.
  • editing/input/set-value-on-input-and-type-input.html: Added.
  • editing/input/set-value-on-input-and-type-textarea-expected.txt: Added.
  • editing/input/set-value-on-input-and-type-textarea.html: Added.
11:20 AM Changeset in webkit [73278] by weinig@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Add missing expected results.

  • media/controls-without-preload-expected.txt: Added.
11:18 AM Changeset in webkit [73277] by jberlin@webkit.org
  • 1 edit
    8 adds in trunk/LayoutTests

Updating the Windows 7 results for clip-path-referencing-use.svg to make the bots green. Unreviewed.

svg/custom/clip-path-referencing-use.svg fails when run with Aero enabled.
​https://bugs.webkit.org/show_bug.cgi?id=49945

Make sure that the XP results still match the Mac results.

  • platform/win-xp/svg: Added.
  • platform/win-xp/svg/custom: Added.
  • platform/win-xp/svg/custom/clip-path-referencing-use-expected.checksum: Added.
  • platform/win-xp/svg/custom/clip-path-referencing-use-expected.png: Added.
  • platform/win-xp/svg/custom/clip-path-referencing-use-expected.txt: Added.
  • platform/win/svg/custom/clip-path-referencing-use-expected.checksum: Added.
  • platform/win/svg/custom/clip-path-referencing-use-expected.png: Added.
  • platform/win/svg/custom/clip-path-referencing-use-expected.txt: Added.
11:18 AM Changeset in webkit [73276] by tony@chromium.org
  • 2 edits
    2 adds in trunk/WebCore

2010-12-03 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Tony Chang.

Dragging and dropping into an empty document crashes WebKit.
​https://bugs.webkit.org/show_bug.cgi?id=48793

Remove the assert and update callers to check for a null return value.

Test: manual-tests/drop-in-empty-doc.html

  • manual-tests/drop-in-empty-doc.html: Added.
  • manual-tests/resources/drop-in-empty-doc.xhtml: Added.
  • page/DragController.cpp: (WebCore::elementUnderMouse): (WebCore::DragController::tryDocumentDrag): (WebCore::DragController::concludeEditDrag):
11:11 AM Changeset in webkit [73275] by andersca@apple.com
  • 2 edits in trunk/WebKit2

The chunked update drawing area is flipped twice when drawing
​https://bugs.webkit.org/show_bug.cgi?id=50465
<rdar://problem/8726836>

Reviewed by Dan Bernstein.

  • UIProcess/mac/ChunkedUpdateDrawingAreaProxyMac.mm:

(WebKit::ChunkedUpdateDrawingAreaProxy::platformPaint):
(WebKit::ChunkedUpdateDrawingAreaProxy::drawUpdateChunkIntoBackingStore):
Flip the destination contexts, thus unflipping them. (Turns out two wrongs make a right here).

10:35 AM Changeset in webkit [73274] by mihaip@chromium.org
  • 4 edits in trunk/WebKitTools

2010-12-02 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Tony Chang.

Rebaseline server: move existing baselines
​https://bugs.webkit.org/show_bug.cgi?id=50421

Implement moving of existing baselines: move all files that are about
to be overwriten by update baselines.

Also fix a typo in the UI JS.

  • Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
  • Scripts/webkitpy/tool/commands/rebaselineserver.py:
  • Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
10:15 AM Changeset in webkit [73273] by Patrick Gansterer
  • 2 edits in trunk/WebCore

2010-12-03 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

Move Inspector generator logic into main CMakeLists.txt file
​https://bugs.webkit.org/show_bug.cgi?id=50445

  • CMakeLists.txt:
10:08 AM Changeset in webkit [73272] by Patrick Gansterer
  • 3 edits
    1 copy
    1 delete in trunk

2010-12-03 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

Move StringWx.cpp into wtf directory
​https://bugs.webkit.org/show_bug.cgi?id=50060

  • wtf/wx/StringWx.cpp: Renamed from WebCore/platform/text/wx/StringWx.cpp. (WTF::String::String):

2010-12-03 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

Move StringWx.cpp into wtf directory
​https://bugs.webkit.org/show_bug.cgi?id=50060

  • WebCore.gypi:
  • platform/text/wx/StringWx.cpp: Removed.
10:01 AM Changeset in webkit [73271] by Dimitri Glazkov
  • 9 edits in branches/chromium/597

Merge 73270 - 2010-12-03 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

REGRESSION(r72783): DOMActivate fires multiple times from input type=file
​https://bugs.webkit.org/show_bug.cgi?id=50396

  • fast/events/shadow-boundary-crossing-2-expected.txt: Changed expectations.
  • fast/events/shadow-boundary-crossing-2.html: Added the correct test for event

retargeting, renamed previous test to be more specific in what it tests.

2010-12-03 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

REGRESSION(r72783): DOMActivate fires multiple times from input type=file
​https://bugs.webkit.org/show_bug.cgi?id=50396

Test: fast/events/shadow-boundary-crossing-2.html

  • dom/EventContext.cpp: Reverted changes made in r72783.
  • dom/EventContext.h: Ditto.
  • dom/Node.cpp: (WebCore::Node::containsIncludingShadowDOM): Added. (WebCore::Node::dispatchGenericEvent): Reverted changes made in r72783.
  • dom/Node.h: Added decl.
  • html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::defaultEventHandler): Reverted changes made in r72783.

TBR=Dimitri Glazkov
Review URL: ​http://codereview.chromium.org/5605003

9:56 AM Changeset in webkit [73270] by Dimitri Glazkov
  • 9 edits in trunk

2010-12-03 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

REGRESSION(r72783): DOMActivate fires multiple times from input type=file
​https://bugs.webkit.org/show_bug.cgi?id=50396

  • fast/events/shadow-boundary-crossing-2-expected.txt: Changed expectations.
  • fast/events/shadow-boundary-crossing-2.html: Added the correct test for event

retargeting, renamed previous test to be more specific in what it tests.

2010-12-03 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

REGRESSION(r72783): DOMActivate fires multiple times from input type=file
​https://bugs.webkit.org/show_bug.cgi?id=50396

Test: fast/events/shadow-boundary-crossing-2.html

  • dom/EventContext.cpp: Reverted changes made in r72783.
  • dom/EventContext.h: Ditto.
  • dom/Node.cpp: (WebCore::Node::containsIncludingShadowDOM): Added. (WebCore::Node::dispatchGenericEvent): Reverted changes made in r72783.
  • dom/Node.h: Added decl.
  • html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::defaultEventHandler): Reverted changes made in r72783.
9:52 AM Changeset in webkit [73269] by Patrick Gansterer
  • 2 edits
    1 move in trunk

2010-12-03 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

Move StringBrew.cpp into wtf directory
​https://bugs.webkit.org/show_bug.cgi?id=50058

  • wtf/brew/StringBrew.cpp: Renamed from WebCore/platform/text/brew/StringBrew.cpp. (WTF::String::String):

2010-12-03 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

Move StringBrew.cpp into wtf directory
​https://bugs.webkit.org/show_bug.cgi?id=50058

  • platform/text/brew/StringBrew.cpp: Removed.
9:42 AM Changeset in webkit [73268] by Patrick Gansterer
  • 2 edits
    1 move in trunk

2010-12-03 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

Move StringHaiku.cpp into wtf directory
​https://bugs.webkit.org/show_bug.cgi?id=50057

  • wtf/haiku/StringHaiku.cpp: Renamed from WebCore/platform/text/haiku/StringHaiku.cpp. (WTF::String::String): (WTF::String::operator BString):

2010-12-03 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

Move StringHaiku.cpp into wtf directory
​https://bugs.webkit.org/show_bug.cgi?id=50057

  • platform/text/haiku/StringHaiku.cpp: Removed.
9:30 AM Changeset in webkit [73267] by jberlin@webkit.org
  • 10 edits
    3 adds in trunk

Need a WebKit2 Equivalent of WebSecurityOrigin
​https://bugs.webkit.org/show_bug.cgi?id=50170

Reviewed by Sam Weinig.

WebCore:

  • WebCore.exp.in:

Export the symbol for SecurityOrigin::createFromDatabaseIdentifier.

WebKit2:

  • Shared/API/c/WKBase.h:

Add the WKSecurityOriginRef typedef.

  • Shared/APIObject.h:

Add the SecurityOrigin type as a Shared type.

  • Shared/API/c/WKSharedAPICast.h::

Add the mapping between WKSecurityOriginRef and WebSecurityOrigin.

  • UIProcess/API/C/WKSecurityOrigin.cpp: Added.

(WKSecurityOriginGetTypeID):
(WKSecurityOriginCreate):
(WKSecurityOriginGetProtocol):
(WKSecurityOriginGetHost):
(WKSecurityOriginGetPort):

  • UIProcess/API/C/WKSecurityOrigin.h: Added.
  • UIProcess/WebSecurityOrigin.h: Added.

(WebKit::WebSecurityOrigin::create):
Create based on the database identifier, which contains the protocol, host and port.
(WebKit::WebSecurityOrigin::protocol):
(WebKit::WebSecurityOrigin::host):
(WebKit::WebSecurityOrigin::port):
(WebKit::WebSecurityOrigin::databaseIdentifier):
(WebKit::WebSecurityOrigin::WebSecurityOrigin):
(WebKit::WebSecurityOrigin::type):

  • WebKit2.pro:

Add WKSecurityOrigin.cpp/.h.

  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Add the WebSecurityOrigin.h and WKSecurityOrigin.cpp/.h.

  • win/WebKit2Generated.make:

Make sure WKSecurityOrigin.h file gets copied over to the WebKitBuild directory on Windows.

8:47 AM Changeset in webkit [73266] by abecsi@webkit.org
  • 2 edits in trunk/WebCore

2010-12-03 Andras Becsi <​abecsi@inf.u-szeged.hu>

Unreviewed build fix after r73254.

[Qt][V8] Add missing headers to $headerIncludes rather than $implIncludes
because headers are needed by the generated .h files.

No new tests needed.

  • bindings/scripts/CodeGeneratorV8.pm:
8:34 AM Changeset in webkit [73265] by inferno@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-03 Abhishek Arya <​inferno@chromium.org>

Unreviewed.

Skipping drag-drop-same-unique-origin.html for win platform. Drag and drop
does not work correctly in windows DRT. Skipping like other similar tests.
​https://bugs.webkit.org/show_bug.cgi?id=50438

  • platform/win/Skipped:
8:14 AM Changeset in webkit [73264] by jorlow@chromium.org
  • 8 edits in trunk/WebKit/chromium

2010-11-29 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Clean up IndexedDB 2 sided roll bits
​https://bugs.webkit.org/show_bug.cgi?id=50160

  • public/WebIDBDatabase.h: (WebKit::WebIDBDatabase::version): (WebKit::WebIDBDatabase::objectStoreNames): (WebKit::WebIDBDatabase::deleteObjectStore):
  • public/WebIDBFactory.h: (WebKit::WebIDBFactory::open):
  • public/WebIDBKeyRange.h:
  • public/WebIDBObjectStore.h: (WebKit::WebIDBObjectStore::deleteFunction):
  • src/IDBDatabaseProxy.cpp:
  • src/IDBDatabaseProxy.h:
  • src/WebIDBKeyRange.cpp:
6:28 AM Changeset in webkit [73263] by Csaba Osztrogonác
  • 1 edit
    3 adds in trunk/LayoutTests

Unreviewed. Add Qt specific expected result after r73246.

  • platform/qt/css2.1/t040105-import-10-b-expected.checksum: Added.
  • platform/qt/css2.1/t040105-import-10-b-expected.png: Added.
  • platform/qt/css2.1/t040105-import-10-b-expected.txt: Added.
5:07 AM Changeset in webkit [73262] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-03 Yuta Kitamura <​yutak@chromium.org>

Unreviewed.

Update Chromium test expectations.

  • platform/chromium/test_expectations.txt:
3:49 AM Changeset in webkit [73261] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-03 Yuta Kitamura <​yutak@chromium.org>

Unreviewed.

Update Chromium test expectations.

  • platform/chromium/test_expectations.txt:
3:34 AM Changeset in webkit [73260] by yutak@chromium.org
  • 2 edits in trunk/WebKitTools

2010-12-03 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r73211.
​http://trac.webkit.org/changeset/73211
​https://bugs.webkit.org/show_bug.cgi?id=50450

Broke Chromium's "Webkit Win (dbg)(2)" bot. (Requested by
yutak on #webkit).

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3:27 AM Changeset in webkit [73259] by yutak@chromium.org
  • 7 edits in trunk/WebKitTools

2010-12-03 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r73222.
​http://trac.webkit.org/changeset/73222
​https://bugs.webkit.org/show_bug.cgi?id=50449

r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
(Requested by yutak on #webkit).

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
  • Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3:14 AM Changeset in webkit [73258] by Nikolas Zimmermann
  • 41 edits in trunk/WebCore

2010-12-03 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

1336 files in WebCore rebuild when you touch SVGNames
​https://bugs.webkit.org/show_bug.cgi?id=42025

Remove global SVGNames.h dependency, as SVGAnimatedPropertyMacros.h included it.
This requires to add the SVGNames.h include to lots of cpp files.

No functional changes, thus no new tests.

  • css/CSSCursorImageValue.cpp:
  • css/CSSFontFaceSource.cpp:
  • dom/Node.cpp:
  • loader/cache/CachedFont.cpp:
  • rendering/RenderSVGResourceClipper.cpp:
  • rendering/RenderSVGResourceFilter.cpp:
  • rendering/RenderSVGTransformableContainer.cpp:
  • rendering/RenderSVGViewportContainer.cpp:
  • rendering/SVGRenderTreeAsText.cpp:
  • rendering/SVGResources.cpp:
  • rendering/svg/RenderSVGTextPath.cpp:
  • rendering/svg/SVGRootInlineBox.cpp:
  • svg/SVGAnimateElement.cpp:
  • svg/SVGAnimateMotionElement.cpp:
  • svg/SVGAnimateTransformElement.cpp:
  • svg/SVGDefsElement.cpp:
  • svg/SVGFEBlendElement.cpp:
  • svg/SVGFEDisplacementMapElement.cpp:
  • svg/SVGFEMergeElement.cpp:
  • svg/SVGFEMergeNodeElement.cpp:
  • svg/SVGFEOffsetElement.cpp:
  • svg/SVGFETileElement.cpp:
  • svg/SVGFETurbulenceElement.cpp:
  • svg/SVGFont.cpp:
  • svg/SVGGElement.cpp:
  • svg/SVGImageElement.cpp:
  • svg/SVGLength.cpp:
  • svg/SVGMPathElement.cpp:
  • svg/SVGPathElement.cpp:
  • svg/SVGPathSegList.cpp:
  • svg/SVGStyledTransformableElement.cpp:
  • svg/SVGSymbolElement.cpp:
  • svg/SVGTextContentElement.cpp:
  • svg/SVGTextElement.cpp:
  • svg/SVGTextPathElement.cpp:
  • svg/SVGUseElement.cpp:
  • svg/SVGViewSpec.cpp:
  • svg/animation/SMILTimeContainer.cpp:
  • svg/properties/SVGAnimatedPropertyMacros.h:
  • svg/properties/SVGPathSegListPropertyTearOff.cpp:
3:06 AM Changeset in webkit [73257] by Philippe Normand
  • 4 edits
    2 adds in trunk

2010-12-02 Philippe Normand <​pnormand@igalia.com>

Reviewed by Martin Robinson.

[GStreamer] hasVideo/Audio return false until the pipeline reaches PAUSED
​https://bugs.webkit.org/show_bug.cgi?id=50382

Go to PAUSED even if preload is deactivated. In that case don't
process the GStreamer state changes until commitLoad() has been
called. This patch also fixes hasVideo and hasAudio methods,
making them reactive to the playbin2 audio/video tags-changed
signals.

Test: media/controls-without-preload.html

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateMessageCallback): (WebCore::mediaPlayerPrivateVideoTagsChangedCallback): (WebCore::mediaPlayerPrivateAudioTagsChangedCallback): (WebCore::mediaPlayerPrivateAudioTagsChangeTimeoutCallback): (WebCore::mediaPlayerPrivateVideoTagsChangeTimeoutCallback): (WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer): (WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer): (WebCore::MediaPlayerPrivateGStreamer::load): (WebCore::MediaPlayerPrivateGStreamer::commitLoad): (WebCore::MediaPlayerPrivateGStreamer::videoTagsChanged): (WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVideoTags): (WebCore::MediaPlayerPrivateGStreamer::audioTagsChanged): (WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfAudioTags): (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: (WebCore::MediaPlayerPrivateGStreamer::hasVideo): (WebCore::MediaPlayerPrivateGStreamer::hasAudio): (WebCore::MediaPlayerPrivateGStreamer::loadDelayed):

LayoutTests:

Reviewed by Martin Robinson.

hasVideo/hasAudio reimplementations

[GStreamer] hasVideo/Audio return false until the pipeline reaches PAUSED
​https://bugs.webkit.org/show_bug.cgi?id=50382

  • media/controls-without-preload.html: Added.
  • platform/gtk/media/controls-without-preload-expected.txt: Added.
2:20 AM Changeset in webkit [73256] by commit-queue@webkit.org
  • 6 edits in trunk/WebKitTools

2010-12-03 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r73228.
​http://trac.webkit.org/changeset/73228
​https://bugs.webkit.org/show_bug.cgi?id=50448

r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
(Requested by yutak on #webkit).

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
  • Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2:03 AM Changeset in webkit [73255] by commit-queue@webkit.org
  • 5 edits in trunk/WebKitTools

2010-12-03 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r73231.
​http://trac.webkit.org/changeset/73231
​https://bugs.webkit.org/show_bug.cgi?id=50443

r73211 seemed to broke Chromium's "Webkit Win (dbg)(2)" bot.
(Requested by yutak on #webkit).

  • Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
  • Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1:44 AM Changeset in webkit [73254] by Nikolas Zimmermann
  • 75 edits in trunk/WebCore

2010-12-03 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Finish splitting DECLARE_ANIMATED_PROPERTY* in DECLARE/DEFINE parts for the remaining SVGAnimated* types
​https://bugs.webkit.org/show_bug.cgi?id=50440

Continuing the work on bug 42025: Introduce (DECLARE|DEFINE)_ANIMATED_(ANGLE|BOOLEAN|INTEGER|PRESERVEASPECTRATIO|RECT).
The animated property declaration lives in the header, the definition in the cpp file, to avoid the dependency on SVGNames.h in all headers.

No functional changes, thus no new tests.

  • svg/SVGAElement.cpp:
  • svg/SVGAElement.h:
  • svg/SVGAnimatedAngle.h:
  • svg/SVGAnimatedBoolean.h:
  • svg/SVGAnimatedInteger.h:
  • svg/SVGAnimatedPreserveAspectRatio.h:
  • svg/SVGAnimatedRect.h:
  • svg/SVGAnimationElement.cpp:
  • svg/SVGAnimationElement.h: (WebCore::SVGAnimationElement::calculateDistance): (WebCore::SVGAnimationElement::animationPath):
  • svg/SVGCircleElement.cpp:
  • svg/SVGCircleElement.h:
  • svg/SVGClipPathElement.cpp:
  • svg/SVGClipPathElement.h:
  • svg/SVGCursorElement.cpp:
  • svg/SVGCursorElement.h:
  • svg/SVGDefsElement.cpp:
  • svg/SVGDefsElement.h:
  • svg/SVGEllipseElement.cpp:
  • svg/SVGEllipseElement.h:
  • svg/SVGFEConvolveMatrixElement.cpp:
  • svg/SVGFEConvolveMatrixElement.h:
  • svg/SVGFEImageElement.cpp:
  • svg/SVGFEImageElement.h:
  • svg/SVGFETurbulenceElement.cpp:
  • svg/SVGFETurbulenceElement.h:
  • svg/SVGFilterElement.cpp:
  • svg/SVGFilterElement.h:
  • svg/SVGFilterPrimitiveStandardAttributes.h:
  • svg/SVGFontElement.cpp: (WebCore::SVGFontElement::firstMissingGlyphElement): (WebCore::SVGFontElement::ensureGlyphCache):
  • svg/SVGFontElement.h:
  • svg/SVGForeignObjectElement.cpp:
  • svg/SVGForeignObjectElement.h:
  • svg/SVGGElement.cpp:
  • svg/SVGGElement.h: (WebCore::SVGGElement::isShadowTreeContainerElement): (WebCore::SVGGElement::isValid):
  • svg/SVGGradientElement.cpp:
  • svg/SVGGradientElement.h:
  • svg/SVGImageElement.cpp:
  • svg/SVGImageElement.h:
  • svg/SVGLineElement.cpp:
  • svg/SVGLineElement.h:
  • svg/SVGLinearGradientElement.h:
  • svg/SVGMPathElement.cpp:
  • svg/SVGMPathElement.h:
  • svg/SVGMarkerElement.cpp:
  • svg/SVGMarkerElement.h:
  • svg/SVGMaskElement.cpp:
  • svg/SVGMaskElement.h:
  • svg/SVGPathElement.cpp:
  • svg/SVGPathElement.h:
  • svg/SVGPatternElement.cpp:
  • svg/SVGPatternElement.h:
  • svg/SVGPolyElement.cpp:
  • svg/SVGPolyElement.h:
  • svg/SVGRadialGradientElement.h:
  • svg/SVGRectElement.cpp:
  • svg/SVGRectElement.h:
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::contentScriptType): (WebCore::SVGSVGElement::contentStyleType): (WebCore::SVGSVGElement::parseMappedAttribute):
  • svg/SVGSVGElement.h:
  • svg/SVGScriptElement.cpp:
  • svg/SVGScriptElement.h:
  • svg/SVGSwitchElement.cpp:
  • svg/SVGSwitchElement.h: (WebCore::SVGSwitchElement::isValid):
  • svg/SVGSymbolElement.cpp:
  • svg/SVGSymbolElement.h: (WebCore::SVGSymbolElement::rendererIsNeeded):
  • svg/SVGTextContentElement.cpp:
  • svg/SVGTextContentElement.h:
  • svg/SVGUseElement.cpp:
  • svg/SVGUseElement.h:
  • svg/SVGViewElement.cpp:
  • svg/SVGViewElement.h: (WebCore::SVGViewElement::viewTarget): (WebCore::SVGViewElement::rendererIsNeeded):
  • svg/SVGViewSpec.cpp:
  • svg/SVGViewSpec.h: (WebCore::SVGViewSpec::transform): (WebCore::SVGViewSpec::viewTargetString): (WebCore::SVGViewSpec::contextElement):
  • svg/properties/SVGAnimatedPropertyMacros.h:
1:24 AM Changeset in webkit [73253] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-03 Yuta Kitamura <​yutak@chromium.org>

Unreviewed.

Update Chromium test expectations.

  • platform/chromium/test_expectations.txt:
1:11 AM Changeset in webkit [73252] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2010-12-03 Philippe Normand <​pnormand@igalia.com>

Unreviewed, skipping failing media test on GTK.

  • platform/gtk/Skipped: Skip media/controls-drag-timebar.html
1:07 AM Changeset in webkit [73251] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-03 Yuta Kitamura <​yutak@chromium.org>

Unreviewed.

Update Chromium test expectations.

  • platform/chromium/test_expectations.txt:
12:53 AM Changeset in webkit [73250] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-12-03 Noel Gordon <​noel.gordon@gmail.com>

Reviewed by Darin Fisher.

[chromium] PNG encoder leaks memory on png_write_row errors.
​https://bugs.webkit.org/show_bug.cgi?id=50439

Move the creation of needed C++ objects before the setjmp() point so
those objects have their destructors called if libpng errors invoke
the setjmp() return path.

Other minor cleanup: use the skia bitmap locker class, and remove the
PNGDestroyer class - instead directly call png_destroy_write_struct()
at each of the encodeImpl() return points.

No change in behaviour, so no new tests.

  • platform/image-encoders/skia/PNGImageEncoder.cpp: (WebCore::encodeImpl): (WebCore::PNGImageEncoder::encode):
12:39 AM Changeset in webkit [73249] by Philippe Normand
  • 5 edits in trunk/WebCore

2010-12-02 Philippe Normand <​pnormand@igalia.com>

Reviewed by Eric Carlson.

Theme not updated when MediaPlayer m_private engine changes
​https://bugs.webkit.org/show_bug.cgi?id=50228

Trigger a new rendering of the media element when the private
media-player backend is updated.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::mediaPlayerEngineUpdated):
  • html/HTMLMediaElement.h:
  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::MediaPlayer): (WebCore::MediaPlayer::load):
  • platform/graphics/MediaPlayer.h: (WebCore::MediaPlayerClient::mediaPlayerEngineUpdated):
12:32 AM Changeset in webkit [73248] by levin@chromium.org
  • 3 edits in trunk/WebKitTools

2010-12-03 David Levin <​levin@chromium.org>

Reviewed by Shinichiro Hamaji.

check-webkit-style: false positive reported for #if macro
​https://bugs.webkit.org/show_bug.cgi?id=48242

  • Scripts/webkitpy/style/checkers/cpp.py: Adjusted check to avoid all preprocessor commands.
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test.
12:12 AM Changeset in webkit [73247] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

2010-12-03 Yonathan Randolph <​yonathan@gmail.com>

Reviewed by Alexey Proskuryakov.

XPath lexer misinterprets expression starting with "div".
​https://bugs.webkit.org/show_bug.cgi?id=50366

  • fast/xpath/ambiguous-operators-expected.txt: Added.
  • fast/xpath/ambiguous-operators.html: Added.

2010-12-03 Yonathan Randolph <​yonathan@gmail.com>

Reviewed by Alexey Proskuryakov.

XPath lexer misinterprets expression starting with "div".
​https://bugs.webkit.org/show_bug.cgi?id=50366

  • xml/XPathParser.cpp:
  • xml/XPathParser.h: (WebCore::XPath::Parser::isOperatorContext): removed (renamed) (WebCore::XPath::Parser::isBinaryOperatorContext): added
12:08 AM Changeset in webkit [73246] by rwlbuis@webkit.org
  • 3 edits
    4 adds in trunk

2010-12-02 Rob Buis <​rwlbuis@gmail.com>

Reviewed by Alexey Proskuryakov.

CSS 2.1 failure: at-import-*
​https://bugs.webkit.org/show_bug.cgi?id=47153

Fix at-import-010.htm by only setting m_allowImportRules
to false when creating valid style or page rules.

Test: css2.1/t040105-import-10-b.html

  • css/CSSParser.cpp: (WebCore::CSSParser::createStyleRule):
Note: See TracTimeline for information about the timeline view.