Context Navigation

← Previous Period
Next Period →

Timeline

Dec 8, 2010:

10:43 PM Changeset in webkit [73595] by pfeldman@chromium.org

2 edits in trunk/LayoutTests

2010-12-08 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Updated Chromium expectations.

platform/chromium/test_expectations.txt:

9:40 PM Changeset in webkit [73594] by barraclough@apple.com

9 edits in trunk

Permit Character Class Escape in CharacterRange in Character Class.
https://bugs.webkit.org/show_bug.cgi?id=50483
https://bugs.webkit.org/show_bug.cgi?id=50538
https://bugs.webkit.org/show_bug.cgi?id=50654
https://bugs.webkit.org/show_bug.cgi?id=50646

Reviewed by Sam Weinig.

We recently tightened up our spec conformance in generating syntax
error in these cases, however testing in the wild has shown this
to be problematic. This reverts the previous change in allowing
class escapes (e.g. \d) in ranges in character classes ([]), but
does retain some closer conformance to the spec in only allowing
ranges that would be permitted per the grammar rules in the spec
(e.g. in /[\d-a-z]/ "a-z" cannot be considered as a range).

JavaScriptCore:

yarr/RegexParser.h:

(JSC::Yarr::Parser::CharacterClassParserDelegate::atomPatternCharacter):
(JSC::Yarr::Parser::CharacterClassParserDelegate::atomBuiltInCharacterClass):
(JSC::Yarr::Parser::parse):

LayoutTests:

fast/js/regexp-ranges-and-escaped-hyphens-expected.txt:
fast/js/script-tests/regexp-ranges-and-escaped-hyphens.js:
fast/regex/invalid-range-in-class-expected.txt:
fast/regex/pcre-test-1-expected.txt:
fast/regex/script-tests/invalid-range-in-class.js:
fast/regex/script-tests/pcre-test-1.js:

9:03 PM Changeset in webkit [73593] by yutak@chromium.org

2 edits in trunk/LayoutTests

2010-12-08 Yuta Kitamura <yutak@chromium.org>

Unreviewed.

Update Chromium test expectations.

platform/chromium/test_expectations.txt:

8:32 PM Changeset in webkit [73592] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Try to fix crash-on-launch seen on Windows builder.

Reviewed by Sam Weinig.

wtf/OSAllocatorWin.cpp:

(WTF::OSAllocator::release): Disabled an ASSERT, because it checks for
a bug that hasn't been fixed yet.

8:30 PM Changeset in webkit [73591] by weinig@apple.com

5 edits in trunk/WebKit2

Fix typo: Diplaying -> Displaying

Reviewed by Geoffrey "Error" Garen.

UIProcess/API/C/WKFrame.cpp:

(WKFrameIsDisplayingStandaloneImageDocument):
(WKFrameIsDisplayingMarkupDocument):

UIProcess/API/C/WKFrame.h:
UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::canProvideSource):
(WebKit::WebFrameProxy::isDisplayingStandaloneImageDocument):
(WebKit::WebFrameProxy::isDisplayingMarkupDocument):

UIProcess/WebFrameProxy.h:

8:22 PM Changeset in webkit [73590] by wsiegrist@apple.com

3 edits in trunk/WebKitTools

2010-12-08 William Siegrist <wsiegrist@apple.com>

Reviewed by Eric Seidel.

Migrate buildbot.py from xmlrpc to json.
https://bugs.webkit.org/show_bug.cgi?id=50647

Scripts/webkitpy/common/net/buildbot.py:

7:55 PM Changeset in webkit [73589] by arv@chromium.org

10 edits in trunk/WebCore

2010-12-08 Erik Arvidsson <arv@chromium.org>

Reviewed by Darin Adler.

Replace getAttribute().isNull() with fastHasAttribute()
https://bugs.webkit.org/show_bug.cgi?id=50719

Covered by existing tests.

dom/SelectElement.cpp: (WebCore::SelectElement::reset):
html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::rendererIsNeeded):
html/HTMLCollection.cpp: (WebCore::HTMLCollection::itemAfter):
html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::formNoValidate):
html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::noValidate):
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultChecked): (WebCore::HTMLInputElement::multiple): (WebCore::HTMLInputElement::webkitdirectory):
html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::defaultSelected):
html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::asyncAttributeValue): (WebCore::HTMLScriptElement::deferAttributeValue):
rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::allowsMultipleFiles): (WebCore::RenderFileUploadControl::allowsDirectoryUpload):

7:37 PM Changeset in webkit [73588] by rniwa@webkit.org

2 edits
2 adds
2 deletes in trunk/LayoutTests

2010-12-08 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed; Yet another Chromium rebaselines for r73548.

platform/chromium-mac-leopard/editing/selection/caret-rtl-2-expected.checksum: Removed.
platform/chromium-mac-leopard/editing/selection/caret-rtl-2-expected.png: Removed.
platform/chromium-mac/fast/text/international/khmer-selection-expected.checksum: Added.
platform/chromium-mac/fast/text/international/khmer-selection-expected.png: Added.
platform/chromium/test_expectations.txt:

7:33 PM Changeset in webkit [73587] by commit-queue@webkit.org

2 edits
1 add in trunk/WebCore

2010-12-08 Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>

Reviewed by Martin Robinson.

Full page size flash plugins do not show in all situations
https://bugs.webkit.org/show_bug.cgi?id=47742

This patch moves the plugin widget size allocation after the
NPP_SetWindow is called with the effect that the resize of Flash
content no longer result in grey flash. This seems logical since the
widget tree cannot be fully constructed before the plugin receives
the new container window.

Test: manual-tests/plugins/gtk-windowed-grey-glitch.html

plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::setNPWindowIfNeeded):

7:29 PM Changeset in webkit [73586] by hyatt@apple.com

2 edits in trunk/WebCore

Fix regression from xji's wheel scroll patch. The vertical case is looking at the horizontal
maximum position and not the vertical position.

Reviewed by Simon Fraser.

platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):

7:13 PM Changeset in webkit [73585] by aestes@apple.com

2 edits in trunk/WebKit/mac

2010-12-08 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

Enable pre-HTML5 parser quirks for Apple Mail.app
https://bugs.webkit.org/show_bug.cgi?id=50727

WebView/WebView.mm: (-[WebView _needsPreHTML5ParserQuirks]): Return true if the embedding application is Mail.app.

7:10 PM Changeset in webkit [73584] by commit-queue@webkit.org

4 edits in trunk/WebKit/qt

2010-12-08 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Support OrientationChange event
https://bugs.webkit.org/show_bug.cgi?id=50685

Get OrientationChange event from qtmobility then send to webkit.

Api/qwebframe.cpp: (QWebFrame::orientationChanged): (QWebFrame::QWebFrame):
Api/qwebframe.h:
Api/qwebframe_p.h:

6:25 PM Changeset in webkit [73583] by weinig@apple.com

2 edits in trunk/WebCore

Need a way to get a WKBundleFrameRef from JS HTMLIFrameElement
https://bugs.webkit.org/show_bug.cgi?id=50726

Reviewed by Darin Adler.

WebCore.xcodeproj/project.pbxproj: Expose HTMLIFrameElement.h.

6:20 PM Changeset in webkit [73582] by weinig@apple.com

7 edits in trunk/WebKit2

Add WebKit2 Preference for TabsToLinks behavior.
<rdar://problem/8664263>

Reviewed by Gavin Barraclough.

Shared/WebPreferencesStore.h:
UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetTabsToLinks):
(WKPreferencesGetTabsToLinks):

UIProcess/API/C/WKPreferences.h:
WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::tabsToLinks):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::updatePreferences):

WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::tabsToLinks):

6:15 PM Changeset in webkit [73581] by benjamin.poulain@nokia.com

2 edits in trunk/WebKit2

2010-12-08 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Andreas Kling.

WebTouchEvent::isTouchEventType() does not take into account the type TouchCancel
https://bugs.webkit.org/show_bug.cgi?id=50680

Add the missing type check to WebTouchEvent::isTouchEventType().

Shared/WebTouchEvent.cpp: (WebKit::WebTouchEvent::isTouchEventType):

6:03 PM Changeset in webkit [73580] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Try to fix Windows build.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Updated .def file.

6:02 PM Changeset in webkit [73579] by weinig@apple.com

5 edits in trunk/WebKit2

Need a way to get a WKBundleFrameRef from JS HTMLIFrameElement
https://bugs.webkit.org/show_bug.cgi?id=50726

Reviewed by Darin Adler.

Adds WKBundleNodeHandleCopyDocumentFrame, WKBundleNodeHandleCopyHTMLFrameElementContentFrame
and WKBundleNodeHandleCopyHTMLIFrameElementContentFrame, to handle the document, <frame>
and <iframe> cases.

WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:

(WKBundleNodeHandleCopyDocumentFrame):
(WKBundleNodeHandleCopyHTMLFrameElementContentFrame):
(WKBundleNodeHandleCopyHTMLIFrameElementContentFrame):

WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::copyDocumentFrame):
(WebKit::InjectedBundleNodeHandle::copyHTMLFrameElementContentFrame):
(WebKit::InjectedBundleNodeHandle::copyHTMLIFrameElementContentFrame):

WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:

5:54 PM Changeset in webkit [73578] by mdelaney@apple.com

7 edits in trunk/WebCore

2010-12-08 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Add getter and setters for acceleratesRendering flag on layers
https://bugs.webkit.org/show_bug.cgi?id=50717

platform/graphics/GraphicsLayer.cpp:
platform/graphics/ca/GraphicsLayerCA.cpp:
platform/graphics/ca/mac/PlatformCALayerMac.mm: Plumbed through acceleratedRendering flag.

5:50 PM Changeset in webkit [73577] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Try to fix Windows build.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Updated .def

file to remove a symbol -- the next build failure will say which symbol
to add back.

5:45 PM Changeset in webkit [73576] by tkent@chromium.org

2 edits
2 deletes in trunk/LayoutTests

2010-12-08 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

Update expectations for r73566.

platform/gtk/editing/selection/find-yensign-and-backslash-expected.txt:
platform/qt/editing/selection/find-yensign-and-backslash-expected.txt: Removed.
platform/win/editing/selection/find-yensign-and-backslash-expected.txt: Removed.

5:42 PM Changeset in webkit [73575] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Try to fix Windows build.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Updated .def file.

5:41 PM Changeset in webkit [73574] by weinig@apple.com

5 edits in trunk/WebKit2

Need a WebKit2 way to test whether a frame is displaying a standalone image
<rdar://problem/8443059>
WebKit2: Need a way to test whether a page or frame is showing HTML content
<rdar://problem/8642563>

Reviewed by Gavin Barraclough.

Add WKFrameIsDiplayingStandaloneImageDocument and WKFrameIsDiplayingMarkupDocument.

UIProcess/API/C/WKFrame.cpp:

(WKFrameIsDiplayingStandaloneImageDocument):
(WKFrameIsDiplayingMarkupDocument):

UIProcess/API/C/WKFrame.h:
UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::canProvideSource): This now just calls isDiplayingMarkupDocument.
(WebKit::WebFrameProxy::isDiplayingStandaloneImageDocument):
(WebKit::WebFrameProxy::isDiplayingMarkupDocument):

UIProcess/WebFrameProxy.h:

5:38 PM Changeset in webkit [73573] by zmo@google.com

9 edits in trunk

2010-12-07 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

WebGLUniformLocation objects must be invalidated during linkProgram
https://bugs.webkit.org/show_bug.cgi?id=37118

html/canvas/WebGLProgram.cpp: (WebCore::WebGLProgram::WebGLProgram): Initialize link count to 0. (WebCore::WebGLProgram::cacheActiveAttribLocations): Don't check link status through gl call; use the cached status instead.
html/canvas/WebGLProgram.h: (WebCore::WebGLProgram::getLinkCount): Get link count. (WebCore::WebGLProgram::increaseLinkCount): Increase link count by 1.
html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getUniform): Fix a bug where wrong error is generated. (WebCore::WebGLRenderingContext::linkProgram): call increaseLinkCount after linkProgram.
html/canvas/WebGLUniformLocation.cpp: (WebCore::WebGLUniformLocation::WebGLUniformLocation): Set program's link count upon creation. (WebCore::WebGLUniformLocation::program): Return null if count doesn't match the program's. (WebCore::WebGLUniformLocation::location): Return -1 if count doesn't match the program's.
html/canvas/WebGLUniformLocation.h:

2010-12-07 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

WebGLUniformLocation objects must be invalidated during linkProgram
https://bugs.webkit.org/show_bug.cgi?id=37118

fast/canvas/webgl/uniform-location-expected.txt:
fast/canvas/webgl/uniform-location.html: Check that after linkProgram, all previous uniform locations become invalid.

5:36 PM Changeset in webkit [73572] by adele@apple.com

8 edits
4 adds in trunk

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=50725
<rdar://problem/8694972> REGRESSION (r72052): "Search" placeholder in MobileMe mail is positioned too high

Reviewed by Darin Adler.

Test: fast/forms/placeholder-position.html

Since we center the inner text element for single line text controls,
we should ask the subclass to give us the y offset instead of trying to calculate it in the RenderTextControl class.

rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::paintPlaceholder):
rendering/RenderTextControl.h:
rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::textBlockInsetTop):
rendering/RenderTextControlMultiLine.h:
rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::textBlockInsetTop):
rendering/RenderTextControlSingleLine.h:

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=50725
<rdar://problem/8694972> REGRESSION (r72052): "Search" placeholder in MobileMe mail is positioned too high

Reviewed by Darin Adler.

fast/forms/placeholder-position.html: Added.
platform/mac/fast/forms/placeholder-position-expected.checksum: Added.
platform/mac/fast/forms/placeholder-position-expected.png: Added.
platform/mac/fast/forms/placeholder-position-expected.txt: Added.

5:35 PM Changeset in webkit [73571] by ggaren@apple.com

3 edits in trunk/JavaScriptCore

Try to fix GTK Linux build.

jit/ExecutableAllocator.cpp:

(JSC::ExecutablePool::systemAlloc):

runtime/AlignedMemoryAllocator.h:

(JSC::::AlignedMemoryAllocator): Updated for Usage enum moving to OSAllocator.

5:30 PM Changeset in webkit [73570] by ggaren@apple.com

12 edits in trunk/JavaScriptCore

Migrated OS-specific allocation code from PageReservation and PageAllocation to OSAllocator
https://bugs.webkit.org/show_bug.cgi?id=50653

Reviewed by Sam Weinig.

JavaScriptCore.exp: Updated for new function signature.

interpreter/RegisterFile.h:

(JSC::RegisterFile::RegisterFile):
(JSC::RegisterFile::grow):

jit/ExecutableAllocatorFixedVMPool.cpp:

(JSC::FixedVMPoolAllocator::reuse):
(JSC::FixedVMPoolAllocator::FixedVMPoolAllocator): Removed checkAllocatedOkay.
OSAllocator is now the central location for verifying that allocation succeeds.
This allowed me to remove some complicating cross-platform cruft.

runtime/AlignedMemoryAllocator.h:

(JSC::::allocate): Updated for code motion.

wtf/OSAllocator.h: Added Usage, writable, and executable parameters, to

support VM features required by clients of PageAllocation and PageReservation.

wtf/OSAllocatorPosix.cpp:

(WTF::OSAllocator::reserve):
(WTF::OSAllocator::reserveAndCommit):
(WTF::OSAllocator::commit): Moved PageAllocation support for randomizing
executable memory here.

wtf/OSAllocatorSymbian.cpp:

(WTF::OSAllocator::reserve):
(WTF::OSAllocator::reserveAndCommit):
(WTF::OSAllocator::commit): Updated for new function signatures.

wtf/OSAllocatorWin.cpp:

(WTF::protection):
(WTF::OSAllocator::reserve):
(WTF::OSAllocator::reserveAndCommit):
(WTF::OSAllocator::commit):
(WTF::OSAllocator::release): Updated for new function signatures. Moved
some protection-related and WINCE-related code from PageAllocation here.

wtf/PageAllocation.cpp: Nixed cross-platform lastError abstraction, since

it was only used by checkAllocatedOkay, which is now gone.

wtf/PageAllocation.h:

(WTF::PageAllocation::allocate):
(WTF::PageAllocation::allocateAligned):
(WTF::PageAllocation::deallocate):
(WTF::PageAllocation::isPowerOfTwo):
(WTF::PageAllocation::systemAllocateAligned): Removed system* functions,
and replaced calls to them with calls to OSAllocator.

wtf/PageReservation.h:

(WTF::PageReservation::commit):
(WTF::PageReservation::decommit):
(WTF::PageReservation::reserve):
(WTF::PageReservation::deallocate):
(WTF::PageReservation::PageReservation): Ditto. Added m_writable and
m_executable because these flags are now required when committing memory.

5:09 PM Changeset in webkit [73569] by andersca@apple.com

4 edits in trunk/WebKit2

WebFrameProxy::canShowMIMEType should return true for PDF MIME types in the main frame
https://bugs.webkit.org/show_bug.cgi?id=50724

Reviewed by Darin Adler.

UIProcess/WebContext.cpp:

(WebKit::WebContext::pdfAndPostScriptMIMETypes):

UIProcess/WebContext.h:
UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::canShowMIMEType):

5:03 PM Changeset in webkit [73568] by crogers@google.com

5 edits in trunk

2010-12-08 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add web audio files to mac port Xcode projects
https://bugs.webkit.org/show_bug.cgi?id=50721

JavaScriptCore.xcodeproj/project.pbxproj:

2010-12-08 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add web audio files to mac port Xcode projects
https://bugs.webkit.org/show_bug.cgi?id=50721

No new tests since audio API is not yet implemented.

WebCore.xcodeproj/project.pbxproj:
bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::webkitAudioContext):

5:03 PM Changeset in webkit [73567] by bweinstein@apple.com

2 edits in trunk/WebKit2

WebMenuTarget implemented in both WebKit and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=50665
<rdar://problem/8742640>

Reviewed by Brady Eidson.

Rename WebMenuTarget to WKMenuTarget to prevent this warning and stay consistent with
other WebKit2 namings.

UIProcess/mac/WebContextMenuProxyMac.mm:

(+[WKMenuTarget sharedMenuTarget]):
(WebKit::nsMenuItemVector):
(WebKit::WebContextMenuProxyMac::showContextMenu):

4:54 PM Changeset in webkit [73566] by tkent@chromium.org

8 edits in trunk

Yensign hack should work with Shift_JIS and ISO-2022-JP encodings.
https://bugs.webkit.org/show_bug.cgi?id=49714

Reviewed by Alexey Proskuryakov.

WebCore:

IE chooses a font which shows a yensign for 0x5c code point for a page
encoded in x-mac-japanese, ISO-2022-JP, EUC-JP, Shift_JIS, Shift_JIS_X0213-2000,
x-sjis, and Windows-31J.
We have emulated this behavior by replacing 0x5c with 0xa5 for EUC-JP and
Shift_JIS_X0213-2000. This change adds other encodings above.

Also, we move the HashSet initialization for isJapanese() and
backslashAsCurrencySymbol() to TextEncodingRegistry.cpp because of
ease of making them multi-thread safe.

platform/text/TextEncoding.cpp:

(WebCore::TextEncoding::isJapanese): Just calls isJapaneseEncoding().
(WebCore::TextEncoding::backslashAsCurrencySymbol): Uses shouldShowBackslashAsCurrencySymbolIn().

platform/text/TextEncodingRegistry.cpp:

(WebCore::addEncodingName): Moved from TextEncoding.cpp, and stop using atomicCanonicalTextEncodingName().
(WebCore::buildQuirksSets): Added. Initializes HashSets for isJapaneseEncoding() and shouldShowBackslashAsCurrencySymbolIn().
(WebCore::isJapaneseEncoding):
(WebCore::shouldShowBackslashAsCurrencySymbolIn):
(WebCore::extendTextCodecMaps): Add a call to buildQuirksSets().

platform/text/TextEncodingRegistry.h:

LayoutTests:

Use Shift_JIS instead of Shift_JIS_X0213-2000 because Shift_JIS_X0213-2000
encoding is available only on Mac.
Add a test for ISO-2022-JP.

editing/selection/find-yensign-and-backslash-expected.txt:
editing/selection/find-yensign-and-backslash.html:
platform/chromium/test_expectations.txt:

4:47 PM Changeset in webkit [73565] by andersca@apple.com

7 edits in trunk/WebKit2

Move canShowMIMEType to Frame
https://bugs.webkit.org/show_bug.cgi?id=50723

Reviewed by Sam Weinig.

UIProcess/API/C/WKFrame.cpp:

(WKFrameCanShowMIMEType):

UIProcess/API/C/WKFrame.h:
UIProcess/API/C/WKPage.cpp:
UIProcess/API/C/WKPage.h:
UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::canShowMIMEType):

UIProcess/WebFrameProxy.h:

4:37 PM Changeset in webkit [73564] by aestes@apple.com

15 edits in trunk

2010-12-08 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

Reflected unsigned attributes should be in the range [0, 2^{31).

https://bugs.webkit.org/show_bug.cgi?id=50472}

HTML5 says that unsigned reflected attributes should be in the range
[0, 2^{31). When a value isn't in this range, a default value (or 0)

should be returned instead. Update the JS bindings code generator to

ensure 0 is returned when a content attribute value falls outside of

this range.}

Tests: bindings/scripts/test/TestObj.idl

fast/html/marquee-element.html

bindings/scripts/CodeGeneratorJS.pm: Return the maximum of 0 and the content attribute as a 32-bit signed int when converting a native value to an unsigned JS value.
bindings/scripts/test/TestObj.idl: Add a reflected unsigned attribute to test code generation.
bindings/scripts/test/CPP/WebDOMTestObj.cpp: Update test results.
bindings/scripts/test/CPP/WebDOMTestObj.h: Ditto.
bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Ditto.
bindings/scripts/test/GObject/WebKitDOMTestObj.h: Ditto.
bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
bindings/scripts/test/JS/JSTestObj.h: Ditto.
bindings/scripts/test/ObjC/DOMTestObj.h: Ditto.
bindings/scripts/test/ObjC/DOMTestObj.mm: Ditto.
bindings/scripts/test/V8/V8TestObj.cpp: Ditto.

2010-12-08 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

Reflected unsigned attributes should be in the range [0, 2^{31).

https://bugs.webkit.org/show_bug.cgi?id=50472}

fast/html/marquee-element.html: Give hspace and vspace negative values and test what their corresponding IDL attributes reflect.
fast/html/marquee-element-expected.txt:

4:13 PM Changeset in webkit [73563] by tony@chromium.org

4 edits in trunk/WebKitTools

2010-12-08 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

make starting the websocket server more reliable on windows
https://bugs.webkit.org/show_bug.cgi?id=50712

Scripts/webkitpy/common/system/filesystem.py: (remove): Substitute method for os.remove to retry on error on Windows
Scripts/webkitpy/common/system/filesystem_unittest.py:
Scripts/webkitpy/layout_tests/port/http_server_base.py: Use FileSystem.remove

3:58 PM Changeset in webkit [73562] by rniwa@webkit.org

8 edits
3 deletes in trunk/LayoutTests

2010-12-08 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium rebaseline for r73548.

platform/chromium-linux/fast/text/international/khmer-selection-expected.checksum:
platform/chromium-linux/fast/text/international/khmer-selection-expected.png:
platform/chromium-linux/fast/text/international/khmer-selection-expected.txt:
platform/chromium-win-xp/fast/text/international/khmer-selection-expected.checksum: Removed.
platform/chromium-win-xp/fast/text/international/khmer-selection-expected.png: Removed.
platform/chromium-win-xp/fast/text/international/khmer-selection-expected.txt: Removed.
platform/chromium-win/fast/text/international/khmer-selection-expected.checksum:
platform/chromium-win/fast/text/international/khmer-selection-expected.png:
platform/chromium-win/fast/text/international/khmer-selection-expected.txt:
platform/chromium/test_expectations.txt:

3:50 PM Changeset in webkit [73561] by commit-queue@webkit.org

3 edits in trunk/WebCore

2010-12-08 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Use gtk_icon_set_render_icon() to render icons in RenderThemeGtk
https://bugs.webkit.org/show_bug.cgi?id=50623

We don't need to cache the icons since the will be cached by GTK+,
and they will be rendered using the state and text direction.

platform/gtk/RenderThemeGtk.cpp: (WebCore::paintStockIcon): (WebCore::getMediaButtonIconSize): (WebCore::RenderThemeGtk::initMediaColors): (WebCore::RenderThemeGtk::initMediaButtons): (WebCore::RenderThemeGtk::RenderThemeGtk): (WebCore::RenderThemeGtk::~RenderThemeGtk): (WebCore::RenderThemeGtk::gtkIconState): (WebCore::RenderThemeGtk::adjustSearchFieldResultsDecorationStyle): (WebCore::centerRectVerticallyInParentInputElement): (WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration): (WebCore::RenderThemeGtk::adjustSearchFieldCancelButtonStyle): (WebCore::RenderThemeGtk::paintSearchFieldCancelButton): (WebCore::RenderThemeGtk::platformColorsDidChange): (WebCore::RenderThemeGtk::paintMediaButton): (WebCore::RenderThemeGtk::paintMediaFullscreenButton): (WebCore::RenderThemeGtk::paintMediaMuteButton): (WebCore::RenderThemeGtk::paintMediaPlayButton): (WebCore::RenderThemeGtk::paintMediaSeekBackButton): (WebCore::RenderThemeGtk::paintMediaSeekForwardButton):
platform/gtk/RenderThemeGtk.h:

3:33 PM Changeset in webkit [73560] by bweinstein@apple.com

2 edits in trunk/WebKit/mac

REGRESSION: r73429-r73490: Some Contextual menu items non-functional, such as Open Link in New Tab
https://bugs.webkit.org/show_bug.cgi?id=50683

Reviewed by John Sullivan.

If our context menu item already has an action, don't overwrite the action with the context menu
forwarder.

WebView/WebHTMLView.mm:

(setMenuItemTarget):

3:31 PM Changeset in webkit [73559] by inferno@chromium.org

5 edits
2 adds in trunk

2010-12-08 Abhishek Arya <inferno@chromium.org>

Reviewed by Dimitri Glazkov.

Detach node iterator and move to new document when node gets moved.
https://bugs.webkit.org/show_bug.cgi?id=50697

Test: fast/dom/node-iterator-document-moved-crash.html

dom/Document.cpp: Method that takes a node and new document as argument. It detaches the node iterators belonging to the current document and attaches them to the new document. (WebCore::Document::moveNodeIteratorsToNewDocument):
dom/Document.h: Function definition.
dom/Node.cpp: When node is moved to another document, call the function to move the iterators appropriately. (WebCore::Node::setDocument):

2010-12-08 Abhishek Arya <inferno@chromium.org>

Reviewed by Dimitri Glazkov.

Tests that we do not crash when node iterator gets moved across documents.
https://bugs.webkit.org/show_bug.cgi?id=50697

fast/dom/node-iterator-document-moved-crash-expected.txt: Added.
fast/dom/node-iterator-document-moved-crash.html: Added.

3:27 PM Changeset in webkit [73558] by rniwa@webkit.org

12 edits
46 adds in trunk/LayoutTests

2010-12-08 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium rebaseline for r73548.

platform/chromium-linux/editing/selection/caret-ltr-2-expected.checksum: Added.
platform/chromium-linux/editing/selection/caret-ltr-2-expected.png: Added.
platform/chromium-linux/editing/selection/caret-ltr-2-left-expected.checksum: Added.
platform/chromium-linux/editing/selection/caret-ltr-2-left-expected.png: Added.
platform/chromium-linux/editing/selection/caret-ltr-expected.checksum: Added.
platform/chromium-linux/editing/selection/caret-ltr-expected.png: Added.
platform/chromium-linux/editing/selection/caret-ltr-right-expected.checksum: Added.
platform/chromium-linux/editing/selection/caret-ltr-right-expected.png: Added.
platform/chromium-linux/editing/selection/caret-rtl-2-expected.checksum: Added.
platform/chromium-linux/editing/selection/caret-rtl-2-expected.png: Added.
platform/chromium-linux/editing/selection/caret-rtl-2-left-expected.checksum: Added.
platform/chromium-linux/editing/selection/caret-rtl-2-left-expected.png: Added.
platform/chromium-linux/editing/selection/caret-rtl-expected.checksum:
platform/chromium-linux/editing/selection/caret-rtl-expected.png:
platform/chromium-linux/editing/selection/caret-rtl-right-expected.checksum: Added.
platform/chromium-linux/editing/selection/caret-rtl-right-expected.png: Added.
platform/chromium-mac/editing/selection/caret-ltr-2-expected.checksum: Added.
platform/chromium-mac/editing/selection/caret-ltr-2-expected.png: Added.
platform/chromium-mac/editing/selection/caret-ltr-2-left-expected.checksum: Added.
platform/chromium-mac/editing/selection/caret-ltr-2-left-expected.png: Added.
platform/chromium-mac/editing/selection/caret-ltr-expected.checksum: Added.
platform/chromium-mac/editing/selection/caret-ltr-expected.png: Added.
platform/chromium-mac/editing/selection/caret-ltr-right-expected.checksum: Added.
platform/chromium-mac/editing/selection/caret-ltr-right-expected.png: Added.
platform/chromium-mac/editing/selection/caret-rtl-2-expected.checksum: Added.
platform/chromium-mac/editing/selection/caret-rtl-2-expected.png: Added.
platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.checksum: Added.
platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.png: Added.
platform/chromium-mac/editing/selection/caret-rtl-expected.checksum:
platform/chromium-mac/editing/selection/caret-rtl-expected.png:
platform/chromium-mac/editing/selection/caret-rtl-right-expected.checksum: Added.
platform/chromium-mac/editing/selection/caret-rtl-right-expected.png: Added.
platform/chromium-win/editing/selection/caret-ltr-2-expected.checksum: Added.
platform/chromium-win/editing/selection/caret-ltr-2-expected.png: Added.
platform/chromium-win/editing/selection/caret-ltr-2-expected.txt: Added.
platform/chromium-win/editing/selection/caret-ltr-2-left-expected.checksum: Added.
platform/chromium-win/editing/selection/caret-ltr-2-left-expected.png: Added.
platform/chromium-win/editing/selection/caret-ltr-2-left-expected.txt: Added.
platform/chromium-win/editing/selection/caret-ltr-expected.checksum: Added.
platform/chromium-win/editing/selection/caret-ltr-expected.png: Added.
platform/chromium-win/editing/selection/caret-ltr-expected.txt: Added.
platform/chromium-win/editing/selection/caret-ltr-right-expected.checksum: Added.
platform/chromium-win/editing/selection/caret-ltr-right-expected.png: Added.
platform/chromium-win/editing/selection/caret-ltr-right-expected.txt: Added.
platform/chromium-win/editing/selection/caret-rtl-2-expected.checksum:
platform/chromium-win/editing/selection/caret-rtl-2-expected.png:
platform/chromium-win/editing/selection/caret-rtl-2-expected.txt:
platform/chromium-win/editing/selection/caret-rtl-2-left-expected.checksum: Added.
platform/chromium-win/editing/selection/caret-rtl-2-left-expected.png: Added.
platform/chromium-win/editing/selection/caret-rtl-2-left-expected.txt: Added.
platform/chromium-win/editing/selection/caret-rtl-expected.checksum:
platform/chromium-win/editing/selection/caret-rtl-expected.png:
platform/chromium-win/editing/selection/caret-rtl-expected.txt:
platform/chromium-win/editing/selection/caret-rtl-right-expected.checksum: Added.
platform/chromium-win/editing/selection/caret-rtl-right-expected.png: Added.
platform/chromium-win/editing/selection/caret-rtl-right-expected.txt: Added.
platform/chromium/test_expectations.txt:

3:24 PM Changeset in webkit [73557] by Martin Robinson

3 edits in trunk/LayoutTests

2010-12-08 Martin Robinson <mrobinson@igalia.com>

Replace some GTK+ test results after r73548.

platform/gtk/fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
platform/gtk/fast/dom/vertical-scrollbar-in-rtl-expected.txt:

3:11 PM Changeset in webkit [73556] by jamesr@google.com

3 edits
12 copies in branches/chromium/597

Merge 73531 - https://bugs.webkit.org/show_bug.cgi?id=50576

Reviewed by Anders Carlsson.

REGRESSION in position of autocomplete popup on RTL page.

RTL static position computation did not subtract out the width of the enclosing box if the
immediate parent was a RenderInline. This bug was exposed by properly changing the RenderView
to be RTL when the document was RTL.

Added three new tests in fast/block/positioning.

WebCore:

rendering/RenderBox.cpp:

(WebCore::RenderBox::computePositionedLogicalWidth):

LayoutTests:

fast/block/positioning/rtl-static-positioning-inline-block.html: Added.
fast/block/positioning/rtl-static-positioning.html: Added.
fast/block/positioning/table-cell-static-position.html: Added.
platform/mac/fast/block/positioning/rtl-static-positioning-expected.checksum: Added.
platform/mac/fast/block/positioning/rtl-static-positioning-expected.png: Added.
platform/mac/fast/block/positioning/rtl-static-positioning-expected.txt: Added.
platform/mac/fast/block/positioning/rtl-static-positioning-inline-block-expected.checksum: Added.
platform/mac/fast/block/positioning/rtl-static-positioning-inline-block-expected.png: Added.
platform/mac/fast/block/positioning/rtl-static-positioning-inline-block-expected.txt: Added.
platform/mac/fast/block/positioning/table-cell-static-position-expected.checksum: Added.
platform/mac/fast/block/positioning/table-cell-static-position-expected.png: Added.
platform/mac/fast/block/positioning/table-cell-static-position-expected.txt: Added.

TBR=jamesr@chromium.org
BUG=62451
Review URL: http://codereview.chromium.org/5670003

2:48 PM Changeset in webkit [73555] by rniwa@webkit.org

1 edit
4 deletes in trunk/LayoutTests

2010-12-08 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed; Removed old expected results for caret-rtl.html and caret-rtl-2.html on Mac Leopard.

platform/mac-leopard/editing/selection/caret-rtl-2-expected.checksum: Removed.
platform/mac-leopard/editing/selection/caret-rtl-2-expected.png: Removed.
platform/mac-leopard/editing/selection/caret-rtl-expected.checksum: Removed.
platform/mac-leopard/editing/selection/caret-rtl-expected.png: Removed.

2:35 PM Changeset in webkit [73554] by pkasting@chromium.org

2 edits in trunk/LayoutTests

Unreviewed Chromium test expectations update.

Mark some Mac tests as timing out after r73518 and r73522.

platform/chromium/test_expectations.txt:

2:34 PM Changeset in webkit [73553] by rniwa@webkit.org

1 edit in trunk/WebCore/ChangeLog

Fixed the change log entry for r73548.

2:25 PM Changeset in webkit [73552] by andersca@apple.com

2 edits in trunk/WebKit/mac

Remove an unused variable.

WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView setScrollOrigin:updatePosition:]):

2:19 PM Changeset in webkit [73551] by Adam Roben

1 edit
4 deletes in trunk/LayoutTests

Update Windows test results after r73538

We don't need Windows-specific results for this test anymore.

platform/win-xp/svg/custom/clip-path-referencing-use-expected.checksum: Removed.
platform/win-xp/svg/custom/clip-path-referencing-use-expected.png: Removed.
platform/win-xp/svg/custom/clip-path-referencing-use-expected.txt: Removed.
platform/win/svg/custom/clip-path-referencing-use-expected.checksum: Removed.
platform/win/svg/custom/clip-path-referencing-use-expected.png: Removed.
platform/win/svg/custom/clip-path-referencing-use-expected.txt: Removed.

2:09 PM Changeset in webkit [73550] by kov@webkit.org

3 edits in trunk/WebKit/gtk

2010-12-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Build fix. Take webView{Enter,Exit}Fullscreen back out of the
WebKit namespace, and remove a function signature that got in by
mistake because of a bad merge.

webkit/webkitprivate.h:
webkit/webkitwebview.cpp: (WebKit::core): (WebKit::kit):

1:58 PM Changeset in webkit [73549] by jamesr@google.com

4 edits
7 adds in trunk

2010-12-08 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Text is blurry on a large composited layer with an odd center x/y coordinate
https://bugs.webkit.org/show_bug.cgi?id=50702

Tests that text rendered on a large layer is crisp even when the layer's center point
has an odd x and/or y coordinate.

compositing/text-on-large-layer.html: Added.
platform/chromium-gpu-linux/compositing/text-on-large-layer-expected.checksum: Added.
platform/chromium-gpu-linux/compositing/text-on-large-layer-expected.png: Added.
platform/chromium-gpu-linux/compositing/text-on-large-layer-expected.txt: Added.
platform/chromium-gpu/test_expectations.txt:
platform/mac/compositing/text-on-large-layer-expected.checksum: Added.
platform/mac/compositing/text-on-large-layer-expected.png: Added.
platform/mac/compositing/text-on-large-layer-expected.txt: Added.

2010-12-08 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Text is blurry on a large composited layer with an odd center x/y coordinate
https://bugs.webkit.org/show_bug.cgi?id=50702

Compute the center of a large layer using floats instead of ints to avoid roundoff errors.

Test: compositing/text-on-large-layer.html

platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::draw):

1:55 PM Changeset in webkit [73548] by rniwa@webkit.org

11 edits
25 adds in trunk

2010-12-08 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Dan Bernstein.

REGRESSION: LayoutTests/editing/selection/caret-rtl-2.html fails
https://bugs.webkit.org/show_bug.cgi?id=33503

The bug was caused by Font::offsetForPosition's not taking into account the containing block's text direction.
When RTL text appears in a LTR block, the offset at the beginning of RTL text is on the left of RTL text,
adn the offset at the end of RTL text is on the right of RTL text. For example, if we had RTL text CBA,
then the correspondance between letters and offsets in logical order are: A -> 0, B -> 1, and C -> 2.

Case 1. CBA appears in a RTL block:

In this case, clicking on the visual left of CBA puts the caret naturally at Position("CBA", 2).
Clicking on the visual right of CBA puts the caret at Position("CBA", 0) as expected.

Case 2. CBA appears in a LTR block:

Because the containing block flows from left to right, by covention, Position("CBA", 2") coresponds
to the visual right of CBA, and Position("CBA", 0) corresponds to the visual left of CBA.
Therefore, clicking on the visual left of CBA should put the caret at Positoin("CBA", 0),
and clicking on the visual right should put it at Position("CBA", 2).

The bug was caused by WebKit's not considering case 2. The same bug also existe for LTR text in a RTL block.
Fixed the bug by taking care of the case 2 in InlineTextBox::offsetForPosition.

Tests: editing/selection/caret-ltr-2-left.html

editing/selection/caret-ltr-2.html
editing/selection/caret-ltr-right.html
editing/selection/caret-ltr.html
editing/selection/caret-rtl-2-left.html
editing/selection/caret-rtl-right.html

rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::offsetForPosition):

2010-12-08 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Dan Bernstein.

REGRESSION: LayoutTests/editing/selection/caret-rtl-2.html fails
https://bugs.webkit.org/show_bug.cgi?id=33503

Added tests to ensure WebKit places the caret at a right place for LTR text in a LTR block,
LTR text in a RTL block, RTL text in a RTL block, and RTL text in a LTR block.

Because we need to verify both rendering of the caret and (node, offset) pair of the caret,
these tests cannot be combined or done without pixel results.

editing/selection/caret-ltr-2-left.html: Added.
editing/selection/caret-ltr-2.html: Added.
editing/selection/caret-ltr-right.html: Added.
editing/selection/caret-ltr.html: Added.
editing/selection/caret-rtl-2-left.html: Added.
editing/selection/caret-rtl-2.html:
editing/selection/caret-rtl-right.html: Added.
editing/selection/caret-rtl.html:
editing/selection/resources/caret-edge-shared.js: Added. (runTest): (verify): (log):
platform/mac/editing/selection/caret-ltr-2-expected.checksum: Added.
platform/mac/editing/selection/caret-ltr-2-expected.png: Added.
platform/mac/editing/selection/caret-ltr-2-expected.txt: Added.
platform/mac/editing/selection/caret-ltr-2-left-expected.checksum: Added.
platform/mac/editing/selection/caret-ltr-2-left-expected.png: Added.
platform/mac/editing/selection/caret-ltr-2-left-expected.txt: Added.
platform/mac/editing/selection/caret-ltr-expected.checksum: Added.
platform/mac/editing/selection/caret-ltr-expected.png: Added.
platform/mac/editing/selection/caret-ltr-expected.txt: Added.
platform/mac/editing/selection/caret-ltr-right-expected.checksum: Added.
platform/mac/editing/selection/caret-ltr-right-expected.png: Added.
platform/mac/editing/selection/caret-ltr-right-expected.txt: Added.
platform/mac/editing/selection/caret-rtl-2-expected.checksum:
platform/mac/editing/selection/caret-rtl-2-expected.png:
platform/mac/editing/selection/caret-rtl-2-expected.txt:
platform/mac/editing/selection/caret-rtl-2-left-expected.checksum: Added.
platform/mac/editing/selection/caret-rtl-2-left-expected.png: Added.
platform/mac/editing/selection/caret-rtl-2-left-expected.txt: Added.
platform/mac/editing/selection/caret-rtl-expected.checksum:
platform/mac/editing/selection/caret-rtl-expected.png:
platform/mac/editing/selection/caret-rtl-expected.txt:
platform/mac/editing/selection/caret-rtl-right-expected.checksum: Added.
platform/mac/editing/selection/caret-rtl-right-expected.png: Added.
platform/mac/editing/selection/caret-rtl-right-expected.txt: Added.

1:48 PM Changeset in webkit [73547] by ap@apple.com

2 edits in trunk/LayoutTests

Touch a file that's sporadically giving 207 Multi-Status error on svn update, hoping that
it will magically fix it.

fast/xpath/4XPath/Core/test.js: Removed properties svn:mime-type and svn:eol-style, added a newline.

1:48 PM Changeset in webkit [73546] by weinig@apple.com

3 edits in trunk/WebKit2

Rename WKPreferencesGetFTPDirectoryTemplatePath to WKPreferencesCopyFTPDirectoryTemplatePath
since it copies the value.

Reviewed by Oliver Hunt.

UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesCopyFTPDirectoryTemplatePath):

UIProcess/API/C/WKPreferencesPrivate.h:

1:44 PM Changeset in webkit [73545] by oliver@apple.com

4 edits in trunk/JavaScriptCore

2010-12-08 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Marking the active global object re-enters through markConservatively
https://bugs.webkit.org/show_bug.cgi?id=50711

draining of the MarkStack is not allowed to be re-entrant, we got away
with this simply due to the logic in MarkStack::drain implicitly handling
changes that could be triggered by the re-entry.

Just to be safe this patch removes the re-entry through markConservatively
so we don't accidentally introduce such an issue in future. I've also
added an assertion to catch such errors.

runtime/Collector.cpp: (JSC::Heap::markConservatively): (JSC::Heap::markCurrentThreadConservativelyInternal): (JSC::Heap::markOtherThreadConservatively):
runtime/JSArray.h: (JSC::MarkStack::drain):
runtime/MarkStack.h: (JSC::MarkStack::MarkStack):

1:41 PM Changeset in webkit [73544] by pkasting@chromium.org

3 edits in trunk/LayoutTests

Unreviewed Chromium test expectations update.

Mark some tests as passing or slow, and update the comment on the
compositing tests to indicate more accurately why we skip them in the
main test run.

platform/chromium-gpu/test_expectations.txt:
platform/chromium/test_expectations.txt:

1:29 PM Changeset in webkit [73543] by andersca@apple.com

4 edits in trunk/WebCore

Fix some clang++ warnings (one of which was an actual bug)
https://bugs.webkit.org/show_bug.cgi?id=50700

Reviewed by Darin Adler.

page/mac/DragControllerMac.mm:

(WebCore::DragController::dragOperation):
Add parentheses to silent a clang warning.

page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::needsKeyboardEventDisambiguationQuirks):

Fix

vs && precedence bug uncovered by clang.

platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::reshape):
Use an early return to avoid a warning.

1:27 PM Changeset in webkit [73542] by weinig@apple.com

5 edits in trunk/WebKit2

WebKit2: Can't open ftp directory
<rdar://problem/8489321>

Reviewed by Brady Eidson.

Shared/WebPreferencesStore.h:
UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetForceFTPDirectoryListings):
(WKPreferencesGetForceFTPDirectoryListings):
(WKPreferencesSetFTPDirectoryTemplatePath):
(WKPreferencesGetFTPDirectoryTemplatePath):

UIProcess/API/C/WKPreferencesPrivate.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):
Pipe through the FTP directory listing preferences.

12:43 PM Changeset in webkit [73541] by rniwa@webkit.org

2 edits in trunk/LayoutTests

2010-12-08 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium test expectations update.
fast/dom/HTMLMeterElement/meter-element.html has been rebaselined for Windows.

platform/chromium/test_expectations.txt:

12:43 PM Changeset in webkit [73540] by cmarrin@apple.com

11 edits
1 copy in trunk

2010-12-08 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
https://bugs.webkit.org/show_bug.cgi?id=49388

Added copy constructors and casting operators to go between
TransformationMatrix and CATransform3D. Also added a copy
constructor to go from CGAffineTransform to TransformationMatrix.
Used these new methods to clean up platform CA code. This will
make it easier to port to Windows.

I also fixed a couple of build issues found when trying out a
Windows build.

This is a resubmission of changesets r73477 and r73483 with a
fix for the SL build. The failure was because TransformationMatrix
included QuartzCore/CATransform3D.h which brought in some system
libraries, including Quickdraw, which has a definition for
'Cursor' which clashed with WebCore's 'Cursor' class. So I had
to qualify its use in WebChromeClient.cpp in WebKit2.

12:29 PM Changeset in webkit [73539] by kov@webkit.org

15 edits
1 add in trunk/WebKit/gtk

2010-12-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Split webkitprivate.{cpp,h} in more manageable chunks
https://bugs.webkit.org/show_bug.cgi?id=50698

Split private bits of WebKitWebView to its own private header, and
to its implementation file. Take the opportunity to fix includes
sorting to comply with the style guide.

WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::enterFullscreenForNode): (WebKit::ChromeClient::exitFullscreenForNode):
WebCoreSupport/ContextMenuClientGtk.cpp:
WebCoreSupport/DragClientGtk.cpp:
WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
WebCoreSupport/EditorClientGtk.cpp:
WebCoreSupport/FrameLoaderClientGtk.cpp:
WebCoreSupport/InspectorClientGtk.cpp:
WebCoreSupport/PasteboardHelperGtk.cpp:
webkit/webkitprivate.cpp: (webkit_init):
webkit/webkitprivate.h:
webkit/webkitwebbackforwardlist.cpp:
webkit/webkitwebdatasource.cpp:
webkit/webkitwebframe.cpp:
webkit/webkitwebview.cpp: (WebKit::core): (WebKit::kit): (WebKit::webViewEnterFullscreen): (WebKit::webViewExitFullscreen):
webkit/webkitwebviewprivate.h: Added.

12:25 PM Changeset in webkit [73538] by Adam Roben

2 edits in trunk/LayoutTests

Skip svg/custom/clip-path-referencing-use2.svg, not svg/custom/clip-path-referencing-use.svg

The former is the real problem. The latter was just the victim!

platform/win/Skipped:

12:18 PM Changeset in webkit [73537] by rniwa@webkit.org

2 edits in trunk/LayoutTests

2010-12-08 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium test expectations update.
fast/text/decomposed-after-stacked-diacritics.html crashes on Chromium Linux.

platform/chromium/test_expectations.txt:

11:59 AM Changeset in webkit [73536] by rniwa@webkit.org

1 edit
21 adds in trunk/LayoutTests

2010-12-08 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium rebaseline for r73531.

platform/chromium-linux/fast/block/positioning/rtl-static-positioning-expected.checksum: Added.
platform/chromium-linux/fast/block/positioning/rtl-static-positioning-expected.png: Added.
platform/chromium-linux/fast/block/positioning/rtl-static-positioning-inline-block-expected.checksum: Added.
platform/chromium-linux/fast/block/positioning/rtl-static-positioning-inline-block-expected.png: Added.
platform/chromium-linux/fast/block/positioning/table-cell-static-position-expected.checksum: Added.
platform/chromium-linux/fast/block/positioning/table-cell-static-position-expected.png: Added.
platform/chromium-mac/fast/block/positioning/rtl-static-positioning-expected.checksum: Added.
platform/chromium-mac/fast/block/positioning/rtl-static-positioning-expected.png: Added.
platform/chromium-mac/fast/block/positioning/rtl-static-positioning-inline-block-expected.checksum: Added.
platform/chromium-mac/fast/block/positioning/rtl-static-positioning-inline-block-expected.png: Added.
platform/chromium-mac/fast/block/positioning/table-cell-static-position-expected.checksum: Added.
platform/chromium-mac/fast/block/positioning/table-cell-static-position-expected.png: Added.
platform/chromium-win/fast/block/positioning/rtl-static-positioning-expected.checksum: Added.
platform/chromium-win/fast/block/positioning/rtl-static-positioning-expected.png: Added.
platform/chromium-win/fast/block/positioning/rtl-static-positioning-expected.txt: Added.
platform/chromium-win/fast/block/positioning/rtl-static-positioning-inline-block-expected.checksum: Added.
platform/chromium-win/fast/block/positioning/rtl-static-positioning-inline-block-expected.png: Added.
platform/chromium-win/fast/block/positioning/rtl-static-positioning-inline-block-expected.txt: Added.
platform/chromium-win/fast/block/positioning/table-cell-static-position-expected.checksum: Added.
platform/chromium-win/fast/block/positioning/table-cell-static-position-expected.png: Added.
platform/chromium-win/fast/block/positioning/table-cell-static-position-expected.txt: Added.
platform/chromium/test_expectations.txt:

11:26 AM Changeset in webkit [73535] by bweinstein@apple.com

40 edits
1 delete in trunk

Layering Violation in ContextMenu - member variable of type HitTestResult
https://bugs.webkit.org/show_bug.cgi?id=50586

Reviewed by John Sullivan.

WebCore:

ContextMenu had a layering violation by having a member variable of type HitTestResult, because
classes in WebCore/platform can't know about classes in WebCore.

This patch moves the HitTestResult and all functions that use it out of ContextMenu into ContextMenuController.
All of the functions that dealt with populating the ContextMenu are now in ContextMenuController, and this
allowed us to delete the ContextMenu file, putting all of the cross-platform code that used to be it
in ContextMenuController, and the rest of the code is in the platform-specific files.

No change in behavior, no new tests.

Android.mk: Removed ContextMenu.cpp.
CMakeLists.txt: Ditto.
GNUmakefile.am: Ditto.
WebCore.gypi: Ditto.
WebCore.pro: Ditto.
WebCore.vcproj/WebCore.vcproj: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.

page/ContextMenuController.cpp:

(WebCore::ContextMenuController::ContextMenuController): Initialized m_hitTestResult to an empty HitTestResult.
(WebCore::ContextMenuController::handleContextMenuEvent): Call populate on the ContextMenuController instead

of the ContextMenu.

(WebCore::ContextMenuController::createContextMenu): Fix some indination, and store the HitTestResult in a member

variable.

(WebCore::ContextMenuController::showContextMenu): Call addInspectElementItem on the ContextMenuController.
(WebCore::ContextMenuController::contextMenuItemSelected): Use m_hitTestResult whenever we need a HitTestResult.
(WebCore::ContextMenuController::appendItem): Validates the item for its state, and then appends it to the parent menu.

This allowed us to move checkOrEnableIfNeeded from ContextMenu.

These functions were all moved from ContextMenu, and changed slightly to fit in ContextMenuController.
All calls to ContextMenu::appendItem were changed to ContextMenuController::appendItem, which takes care
of validating the menu.
(WebCore::separatorItem): Moved from ContextMenu.
(WebCore::ContextMenuController::createAndAppendFontSubMenu): Ditto.
(WebCore::ContextMenuController::createAndAppendSpellingAndGrammarSubMenu): Ditto.
(WebCore::ContextMenuController::createAndAppendSpeechSubMenu): Ditto.
(WebCore::ContextMenuController::createAndAppendWritingDirectionSubMenu): Ditto.
(WebCore::ContextMenuController::createAndAppendTextDirectionSubMenu): Ditto.
(WebCore::ContextMenuController::createAndAppendSubstitutionsSubMenu): Ditto.
(WebCore::ContextMenuController::createAndAppendTransformationsSubMenu): Ditto.
(WebCore::selectionContainsPossibleWord): Ditto.
(WebCore::ContextMenuController::populate): Ditto.
(WebCore::ContextMenuController::addInspectElementItem): Ditto.
(WebCore::ContextMenuController::checkOrEnableIfNeeded): Ditto.

page/ContextMenuController.h:

(WebCore::ContextMenuController::hitTestResult): Returns the HitTestResult of the current ContextMenu.

platform/ContextMenu.cpp: Removed.
platform/ContextMenu.h:
platform/efl/ContextMenuEfl.cpp:

(WebCore::ContextMenu::ContextMenu): Removed m_hitTestResult from the constructor.
(WebCore::ContextMenu::appendItem): Removed the call to checkOrEnableIfNeeded.

platform/gtk/ContextMenuGtk.cpp:

(WebCore::ContextMenu::ContextMenu): Removed m_hitTestResult from the constructor.
(WebCore::ContextMenu::appendItem): Ditto.

platform/haiku/ContextMenuHaiku.cpp:

(WebCore::ContextMenu::ContextMenu): Removed m_hitTestResult from the constructor.
(WebCore::ContextMenu::appendItem): Ditto.
(WebCore::ContextMenu::insertItem): Ditto.

platform/mac/ContextMenuMac.mm:

(-[WebCoreMenuTarget validateMenuItem:]): Calls checkOrEnableIfNeeded on the controller instead of

the context menu.

(WebCore::ContextMenu::ContextMenu): Removed m_hitTestResult from the constructor.
(WebCore::ContextMenu::appendItem): Removed the call to checkOrEnableIfNeeded.
(WebCore::ContextMenu::insertItem): Ditto.

platform/win/ContextMenuWin.cpp:

(WebCore::ContextMenu::ContextMenu): Removed m_hitTestResult from the constructor.
(WebCore::ContextMenu::insertItem): Removed the call to checkOrEnableIfNeeded.

platform/wx/ContextMenuWx.cpp:

(WebCore::ContextMenu::ContextMenu): Removed m_hitTestResult from the constructor.
(ContextMenu::appendItem): Ditto.

WebKit/chromium:

Update users of ContextMenu and ContextMenuController to match where the new functions
are located.

src/ContextMenuClientImpl.cpp:

(WebKit::selectMisspelledWord):
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

WebKit/gtk:

Update users of ContextMenu and ContextMenuController to match where the new functions
are located.

WebCoreSupport/ContextMenuClientGtk.cpp:

(WebKit::ContextMenuClient::getCustomMenuFromDefaultItems):

WebKit/mac:

Update users of ContextMenu and ContextMenuController to match where the new functions
are located.

WebCoreSupport/WebContextMenuClient.mm:

(WebContextMenuClient::getCustomMenuFromDefaultItems):
(WebContextMenuClient::contextMenuItemSelected):

WebView/WebHTMLView.mm:

(-[WebMenuTarget validateMenuItem:]):

WebKit/qt:

Update users of ContextMenu and ContextMenuController to match where the new functions
are located.

Api/qwebpage.cpp:

(QWebPagePrivate::createContextMenu):
(QWebPage::updatePositionDependentActions):

WebKit/win:

Update users of ContextMenu and ContextMenuController to match where the new functions
are located.

WebCoreSupport/WebContextMenuClient.cpp:

(WebContextMenuClient::getCustomMenuFromDefaultItems): Get the HitTestResult and ContextMenu from the

ContextMenuController (from the page).

(WebContextMenuClient::contextMenuItemSelected): Get the HitTestResult from the ContextMenuController.

WebView.cpp:

(WebView::handleContextMenuEvent): Ditto.

WebKit2:

Update users of ContextMenu and ContextMenuController to match where the new functions
are located.

Shared/WebContextMenuItemData.cpp:

(WebKit::WebContextMenuItemData::WebContextMenuItemData): Remove the call to checkOrEnableItem, that call will be made when

the ContextMenuItem is added to the ContextMenu through the ContextMenuController.

WebProcess/WebPage/WebContextMenu.cpp:

(WebKit::WebContextMenu::show):

11:17 AM Changeset in webkit [73534] by Martin Robinson

4 edits in trunk

2010-12-08 Martin Robinson <mrobinson@igalia.com>

Reviewed by John Sullivan.

[GTK] Layering violation in ContextMenuGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=50676

ContextMenuGtk accesses the page's ContextMenuController, which is a layering
violation. This was fixed for Mac with change r73469. We make a similar fix here
by moving the "activated" signal connection to the WebKit layer.

platform/gtk/ContextMenuGtk.cpp: (WebCore::ContextMenu::appendItem): Remove access of ContextMenuController. This is a layering violation.

2010-12-08 Martin Robinson <mrobinson@igalia.com>

Reviewed by John Sullivan.

[GTK] Layering violation in ContextMenuGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=50676

ContextMenuGtk accesses the page's ContextMenuController, which is a layering
violation. This was fixed for Mac with change r73469. We make a similar fix here
by moving the "activated" signal connection to the WebKit layer.

webkit/webkitwebview.cpp: (popupMenuItemActivated): Have ContextMenuController handle this signal. (webkit_web_view_forward_context_menu_event): For all items in the untouched context menu, connect their "activated" signal to the new popupMenuItemActivated handler.

11:06 AM Changeset in webkit [73533] by jberlin@webkit.org

16 edits in trunk

WebKit2: Implement WebChromeClient::exceededDatabaseQuota
https://bugs.webkit.org/show_bug.cgi?id=50656

Reviewed by Adam Roben.

WebCore:

WebCore.exp.in:

Export the symbol for SecurityOrigin::databaseIdentifier.

WebKit2:

The exceededDatabaseQuota call from the WebProcess to the UIProcess needs to be synchronous
because the new quota is checked directly after exceededDatabaseQuota returns in order to
determine if the new Database can be created.

Pass all of the details from the WebProcess to the UIProcess in order to inform the
decision in the UIProcess about the new quota. In WebKit1, these details were
fetched through an additional call to the API detailsForDatabase (which is infeasible in
WebKit2 since exceededDatabaseQuota is a synchronous call).

Platform/CoreIPC/HandleMessage.h:

(CoreIPC::callMemberFunction):
Add a version that takes 7 parameters.

UIProcess/API/C/WKPage.h:

UIProcess/API/qt/qwkpage.cpp:

(QWKPage::QWKPage):
Indicate that exceededDatabaseQuota is not implemented.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::exceededDatabaseQuota):
Call the UIClient's exceededDatabaseQuota

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:

UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::exceededDatabaseQuota):
If the client does not implement exceededDatabaseQuota, return a the current quota.

UIProcess/WebUIClient.h:

WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::exceededDatabaseQuota):
Send a synchronous message to the UIProcess to ask for the new quota for the origin for the
given frame.

WebKitTools:

MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController awakeFromNib]):
Indicate that exceededDatabaseQuota is not implemented.

MiniBrowser/win/BrowserView.cpp:

(BrowserView::create):
Ditto.

WebKitTestRunner/TestController.cpp:

(WTR::createOtherPage):
Ditto.
(WTR::TestController::initialize):
Ditto.

11:02 AM Changeset in webkit [73532] by Csaba Osztrogonác

6 edits in trunk/WebCore

2010-12-08 Csaba Osztrogonác <Csaba Osztrogonác>

Unreviewed, rolling out r73521.
http://trac.webkit.org/changeset/73521
https://bugs.webkit.org/show_bug.cgi?id=50640

It broke 90 layout tests

bindings/js/JSDOMBinding.cpp: (WebCore::printErrorMessageForFrame):
bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::crossDomainAccessErrorMessage):
bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation):
page/DOMWindow.cpp:
page/DOMWindow.h:

10:31 AM Changeset in webkit [73531] by hyatt@apple.com

3 edits
12 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=50576

Reviewed by Anders Carlsson.

REGRESSION in position of autocomplete popup on RTL page.

Added three new tests in fast/block/positioning.

WebCore:

rendering/RenderBox.cpp:

(WebCore::RenderBox::computePositionedLogicalWidth):

LayoutTests:

fast/block/positioning/rtl-static-positioning-inline-block.html: Added.
fast/block/positioning/rtl-static-positioning.html: Added.
fast/block/positioning/table-cell-static-position.html: Added.
platform/mac/fast/block/positioning/rtl-static-positioning-expected.checksum: Added.
platform/mac/fast/block/positioning/rtl-static-positioning-expected.png: Added.
platform/mac/fast/block/positioning/rtl-static-positioning-expected.txt: Added.
platform/mac/fast/block/positioning/rtl-static-positioning-inline-block-expected.checksum: Added.
platform/mac/fast/block/positioning/rtl-static-positioning-inline-block-expected.png: Added.
platform/mac/fast/block/positioning/rtl-static-positioning-inline-block-expected.txt: Added.
platform/mac/fast/block/positioning/table-cell-static-position-expected.checksum: Added.
platform/mac/fast/block/positioning/table-cell-static-position-expected.png: Added.
platform/mac/fast/block/positioning/table-cell-static-position-expected.txt: Added.

10:29 AM Changeset in webkit [73530] by xji@chromium.org

10 edits
6 copies in branches/chromium/597

Merge 73529 - 2010-12-08 Xiaomei Ji <xji@chromium.org>

Reviewed by David Hyatt.

Fix backward mouse wheeling not working when scroll position is below 0.
https://bugs.webkit.org/show_bug.cgi?id=50370

Tests: fast/events/wheelevent-in-horizontal-scrollbar-in-rtl.html

fast/events/wheelevent-in-vertical-scrollbar-in-rtl.html

platform/ScrollView.cpp: (WebCore::ScrollView::wheelEvent):

2010-12-08 Xiaomei Ji <xji@chromium.org>

Reviewed by David Hyatt.

Fix backward mouse wheeling not working when scroll position is below 0.
https://bugs.webkit.org/show_bug.cgi?id=50370

fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
fast/dom/horizontal-scrollbar-in-rtl.html:
fast/dom/vertical-scrollbar-in-rtl-expected.txt:
fast/dom/vertical-scrollbar-in-rtl.html:
fast/events/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt: Added.
fast/events/wheelevent-in-horizontal-scrollbar-in-rtl.html: Added.
fast/events/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt: Added.
fast/events/wheelevent-in-vertical-scrollbar-in-rtl.html: Added.
platform/chromium/fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
platform/chromium/fast/dom/vertical-scrollbar-in-rtl-expected.txt:
platform/chromium/fast/events/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt: Added.
platform/chromium/fast/events/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt: Added.
platform/gtk/Skipped:
platform/mac-tiger/Skipped:
platform/mac-wk2/Skipped:
platform/qt-wk2/Skipped:
platform/qt/fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
platform/qt/fast/dom/vertical-scrollbar-in-rtl-expected.txt:
platform/win/Skipped:
platform/win/fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
platform/win/fast/dom/vertical-scrollbar-in-rtl-expected.txt:

TBR=xji@chromium.org

10:14 AM Changeset in webkit [73529] by xji@chromium.org

18 edits
6 adds in trunk

2010-12-08 Xiaomei Ji <xji@chromium.org>

Reviewed by David Hyatt.

Fix backward mouse wheeling not working when scroll position is below 0.
https://bugs.webkit.org/show_bug.cgi?id=50370

Tests: fast/events/wheelevent-in-horizontal-scrollbar-in-rtl.html

fast/events/wheelevent-in-vertical-scrollbar-in-rtl.html

platform/ScrollView.cpp: (WebCore::ScrollView::wheelEvent):

2010-12-08 Xiaomei Ji <xji@chromium.org>

Reviewed by David Hyatt.

Fix backward mouse wheeling not working when scroll position is below 0.
https://bugs.webkit.org/show_bug.cgi?id=50370

fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
fast/dom/horizontal-scrollbar-in-rtl.html:
fast/dom/vertical-scrollbar-in-rtl-expected.txt:
fast/dom/vertical-scrollbar-in-rtl.html:
fast/events/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt: Added.
fast/events/wheelevent-in-horizontal-scrollbar-in-rtl.html: Added.
fast/events/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt: Added.
fast/events/wheelevent-in-vertical-scrollbar-in-rtl.html: Added.
platform/chromium/fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
platform/chromium/fast/dom/vertical-scrollbar-in-rtl-expected.txt:
platform/chromium/fast/events/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt: Added.
platform/chromium/fast/events/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt: Added.
platform/gtk/Skipped:
platform/mac-tiger/Skipped:
platform/mac-wk2/Skipped:
platform/qt-wk2/Skipped:
platform/qt/fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
platform/qt/fast/dom/vertical-scrollbar-in-rtl-expected.txt:
platform/win/Skipped:
platform/win/fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
platform/win/fast/dom/vertical-scrollbar-in-rtl-expected.txt:

10:01 AM Changeset in webkit [73528] by antonm@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, cleaning up test expectations after r7349.

platform/chromium/test_expectations.txt:

9:47 AM Changeset in webkit [73527] by tonikitoo@webkit.org

8 edits in trunk

2010-12-08 Antonio Gomes <agomes@rim.com>

Reviewed by Martin Robinson.

[Gtk] Populate DumpRenderTreeSupportGtk (part III)
https://bugs.webkit.org/show_bug.cgi?id=48429

WebKit/gtk:

Adjusted some call sites of previously internal API declared
webkitprivate.h that have moved to DumpRenderTreeSupportGtk.

WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::gcCollectJavascriptObjects): (DumpRenderTreeSupportGtk::gcCollectJavascriptObjectsOnAlternateThread): (DumpRenderTreeSupportGtk::gcCountJavascriptObjects): (DumpRenderTreeSupportGtk::layoutFrame):
WebCoreSupport/DumpRenderTreeSupportGtk.h:
webkit/webkitprivate.h:
webkit/webkitwebframe.cpp:

WebKitTools:

Moved the following methods from webkitprivate.h to DumpRenderTreeSupportGtk.cpp|h:

webkit_gc_collect_javascript_objects;
webkit_gc_collect_javascript_objects_on_alternate_thread;
webkit_gc_count_javascript_objects;
webkit_web_frame_layout.

These were all only used by GTK+ DRT.

DumpRenderTree/gtk/EventSender.cpp: (dispatchEvent):
DumpRenderTree/gtk/GCControllerGtk.cpp: (GCController::collect): (GCController::collectOnAlternateThread): (GCController::getJSObjectCount):

9:37 AM Changeset in webkit [73526] by Simon Fraser

9 edits in trunk

2010-12-08 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Fix pauseAnimation API to work with shorthand properties
https://bugs.webkit.org/show_bug.cgi?id=50639

The pause API is always called with a long-hand property, but that
property may be animating via a shorthand. Detect this, and pause
such shorthand animations.

page/animation/AnimationBase.cpp: (WebCore::ShorthandPropertyWrapper::propertyWrappers): Expose the vector of wrappers used by a shorthand wrapper.

(WebCore::gatherEnclosingShorthandProperties): Utility function that walks
through the shorthand wrappers, keeping track of which can affect the given
property.
(WebCore::AnimationBase::animatableShorthandsAffectingProperty): Return a set
of shorthand properties that can affect the given property.

page/animation/AnimationBase.h: New method.
page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::pauseTransitionAtTime): If we don't find the property itself, check whether it's being animated via shorthands.

8:55 AM Changeset in webkit [73525] by hyatt@apple.com

2 edits in trunk/WebCore

<rdar://problem/8740920> Gestures: Frame::scalePage() broken by r73885

Reviewed by Beth Dakin.

Make sure the transform applied to the RenderView for page scaling is incorporated into the
docTop/Bottom/Left/Right accessors.

rendering/RenderView.cpp:

(WebCore::RenderView::docTop):
(WebCore::RenderView::docBottom):
(WebCore::RenderView::docLeft):
(WebCore::RenderView::docRight):

8:54 AM Changeset in webkit [73524] by loislo@chromium.org

4 edits in trunk/WebCore

2010-12-08 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Protocol cleanup task. Remove WebInspector wrappers
for TimelineAgent functions.

https://bugs.webkit.org/show_bug.cgi?id=50690

inspector/Inspector.idl:
inspector/front-end/TimelineAgent.js:
inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype.timelineProfilerWasStarted): (WebInspector.TimelinePanel.prototype.timelineProfilerWasStopped):

8:49 AM Changeset in webkit [73523] by Philippe Normand

4 edits in trunk

2010-12-08 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] media/fullscreen* failing on 64-bits Debug
https://bugs.webkit.org/show_bug.cgi?id=50394

Avoid emiting durationchanged in the case where the previous
duration was 0 because that case is already handled by the
HTMLMediaElement.

Test: media/media-fullscreen*.html

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::durationChanged):

LayoutTests:

Reviewed by Gustavo Noronha Silva.

[GTK] media/fullscreen* failing on 64-bits Debug
https://bugs.webkit.org/show_bug.cgi?id=50394

platform/gtk/Skipped: Unskip now passing tests.

8:22 AM Changeset in webkit [73522] by loislo@chromium.org

2 edits in trunk/LayoutTests

2010-12-08 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed. Remove WIN prefix for inspector's tests expectations.
DumpRenderTree related patch.

platform/chromium/test_expectations.txt:

8:22 AM Changeset in webkit [73521] by Darin Adler

6 edits in trunk/WebCore

2010-12-07 Darin Adler <Darin Adler>

Reviewed by Geoffrey Garen.

Move DOMWindow::setLocation logic into DOMWindow class and out of JavaScript binding
https://bugs.webkit.org/show_bug.cgi?id=50640

bindings/js/JSDOMBinding.cpp: (WebCore::printErrorMessageForFrame): Removed body; just call through to DOMWindow::printErrorMessage.

bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::crossDomainAccessErrorMessage): Removed body; just call through to DOMWindow::crossDomainAccessErrorMessage.

bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation): Changed terminology to use activeFrame and firstFrame, rather than the older lexicalFrame and dynamicFrame. Removed most of the body and moved it into DOMWindow::setLocation.

page/DOMWindow.cpp: (WebCore::DOMWindow::setLocation): Added. Does all the same work that JSDOMWindow::setLocation used to do, but in a way that's not specific to JavaScript. (WebCore::DOMWindow::printErrorMessage): Added. (WebCore::DOMWindow::crossDomainAccessErrorMessage): Added.

page/DOMWindow.h: Added setLocation, printErrorMessage, and crossDomainAccessErrorMessage.

8:07 AM Changeset in webkit [73520] by Adam Roben

2 edits in trunk/LayoutTests

Skip svg/custom/clip-path-referencing-use.svg on Windows

The test fails when run under Aero. It seems that one of our Windows 7
bots has this turned on while the other doesn't.

platform/win/Skipped:

8:02 AM Changeset in webkit [73519] by alex

20 edits
5 deletes in trunk

2010-12-08 Alejandro G. Castro <alex@igalia.com>

Unreviewed, rolling out r73494.
http://trac.webkit.org/changeset/73494
https://bugs.webkit.org/show_bug.cgi?id=50380

The tests added are crashing in the debug bots (macn and gtk)

html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::deselectItems): (WebCore::HTMLSelectElement::setSelectedIndex): (WebCore::HTMLSelectElement::setSelectedIndexByUser): (WebCore::HTMLSelectElement::listBoxSelectItem): (WebCore::HTMLSelectElement::add): (WebCore::HTMLSelectElement::remove): (WebCore::HTMLSelectElement::restoreFormControlState): (WebCore::HTMLSelectElement::parseMappedAttribute): (WebCore::HTMLSelectElement::selectAll): (WebCore::HTMLSelectElement::reset): (WebCore::HTMLSelectElement::updateListBoxSelection): (WebCore::HTMLSelectElement::setLength):
html/HTMLSelectElement.h: (WebCore::HTMLSelectElement::isOptionalFormControl):
html/HTMLSelectElement.idl:
html/ValidityState.cpp: (WebCore::ValidityState::valueMissing):

2010-12-08 Alejandro G. Castro <alex@igalia.com>

Unreviewed, rolling out r73494.
http://trac.webkit.org/changeset/73494
https://bugs.webkit.org/show_bug.cgi?id=50380

The tests added are crashing in the debug bots (macn and gtk)

fast/forms/ValidityState-valueMissing-001-expected.txt:
fast/forms/ValidityState-valueMissing-001.html:
fast/forms/ValidityState-valueMissing-002-expected.txt:
fast/forms/ValidityState-valueMissing-002.html:
fast/forms/ValidityState-valueMissing-003-expected.txt:
fast/forms/ValidityState-valueMissing-003.html:
fast/forms/checkValidity-002-expected.txt:
fast/forms/checkValidity-002.html:
fast/forms/required-attribute-001-expected.txt:
fast/forms/required-attribute-001.html:
fast/forms/required-attribute-002-expected.txt:
fast/forms/required-attribute-002.html:
fast/forms/resources/select-live-pseudo-selectors.js: Removed.
fast/forms/script-tests/validationMessage.js:
fast/forms/select-live-pseudo-selectors-expected.txt: Removed.
fast/forms/select-live-pseudo-selectors.html: Removed.
fast/forms/validationMessage-expected.txt:
platform/mac/fast/objc/dom-html-select-live-pseudo-selectors-expected.txt: Removed.
platform/mac/fast/objc/dom-html-select-live-pseudo-selectors.html: Removed.

7:34 AM Changeset in webkit [73518] by loislo@chromium.org

2 edits in trunk/LayoutTests

2010-12-08 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed. Just enable inspector's tests for chromium linux.
This change is related to switching to DumpRenderTree.

platform/chromium/test_expectations.txt:

7:29 AM Changeset in webkit [73517] by Adam Roben

1 edit
3 adds in trunk/LayoutTests

Land Windows results for test added in 73423

platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum: Added.
platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.png: Added.
platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.txt: Added.

7:28 AM Changeset in webkit [73516] by Adam Roben

8 edits in trunk/LayoutTests

Update Windows results after r73488

platform/win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
platform/win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
platform/win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
platform/win/fast/dom/HTMLMeterElement/meter-element-expected.txt:
platform/win/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
platform/win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
platform/win/fast/dom/HTMLMeterElement/meter-styles-expected.txt:

7:25 AM Changeset in webkit [73515] by Philippe Normand

2 edits in trunk/LayoutTests

2010-12-08 Philippe Normand <pnormand@igalia.com>

Unreviewed, skipping failing test.

[GTK] r73488 broke fast/dom/HTMLProgressElement/progress-element.html
https://bugs.webkit.org/show_bug.cgi?id=50687

platform/gtk/Skipped:

6:24 AM Changeset in webkit [73514] by yutak@chromium.org

2 edits in trunk/LayoutTests

2010-12-08 Yuta Kitamura <yutak@chromium.org>

Unreviewed.

Update Chromium test expectations. Remove some tests that are now consistently
passing, assign bug numbers, and add one new expectation.

platform/chromium/test_expectations.txt:

6:17 AM Changeset in webkit [73513] by Philippe Normand

2 edits in trunk/LayoutTests

2010-12-08 Philippe Normand <pnormand@igalia.com>

Unreviewed, unskipping media/video-buffered.html on GTK because
the bots are now running with latest GStreamer.

platform/gtk/Skipped:

5:52 AM Changeset in webkit [73512] by Philippe Normand

5 edits in trunk/LayoutTests

2010-12-08 Philippe Normand <pnormand@igalia.com>

Unreviewed, unskipped some more media tests.

They are not crashing anymore, they also needed a rebaseline since
the font tiling changes that happened while they were skipped.

platform/gtk/Skipped:
platform/gtk/media/controls-styling-expected.txt:
platform/gtk/media/video-layer-crash-expected.txt:
platform/gtk/media/video-transformed-expected.txt:

5:27 AM Changeset in webkit [73511] by loislo@chromium.org

4 edits in trunk/WebCore

2010-12-07 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Inspector protocol cleanup task. Remove
WebInspector wrappers for DOMAgent functions.

There were a lot of wrappers in WebInspector namespace
for different WebInspector agents functions. As far as we have a
generic mechanic for such functions we can remove these
wrappers and register domAgent instance as a handler for
DOM domain notifications.

https://bugs.webkit.org/show_bug.cgi?id=50626

inspector/Inspector.idl:
inspector/front-end/DOMAgent.js: (WebInspector.DOMNode): (WebInspector.DOMAgent): (WebInspector.DOMAgent.prototype.attributesUpdated): (WebInspector.DOMAgent.prototype.characterDataModified): (WebInspector.DOMAgent.prototype.setDocument): (WebInspector.DOMAgent.prototype.setDetachedRoot): (WebInspector.DOMAgent.prototype.setChildNodes): (WebInspector.DOMAgent.prototype.childNodeCountUpdated): (WebInspector.DOMAgent.prototype.childNodeInserted): (WebInspector.DOMAgent.prototype.childNodeRemoved): (WebInspector.EventListeners.getEventListenersForNodeAsync):
inspector/front-end/inspector.js: (WebInspector.didCommitLoad):

4:52 AM Changeset in webkit [73510] by yurys@chromium.org

3 edits in trunk/LayoutTests

2010-12-08 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update test expectations after r73504.

http/tests/inspector/console-resource-errors-expected.txt:
platform/chromium/test_expectations.txt:

4:31 AM Changeset in webkit [73509] by yutak@chromium.org

2 edits in trunk/LayoutTests

2010-12-08 Yuta Kitamura <yutak@chromium.org>

Unreviewed.

Update Chromium test expectations. Add two test flakinesses which was
introduced at r73504.

platform/chromium/test_expectations.txt:

4:14 AM Changeset in webkit [73508] by yutak@chromium.org

2 edits in trunk/LayoutTests

2010-12-08 Yuta Kitamura <yutak@chromium.org>

Unreviewed.

Update Chromium test expectations. Added a few failures which was found
in Chromium main waterfall.

platform/chromium/test_expectations.txt:

4:12 AM Changeset in webkit [73507] by kov@webkit.org

2 edits in trunk/WebKit/gtk

2010-12-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

The storage for the subresources is a GHashTable which does not
guarantee order, so we need to make our checking more resilient.

tests/testwebresource.c: (test_web_resource_sub_resource_loading):

3:52 AM Changeset in webkit [73506] by kov@webkit.org

2 edits in trunk/LayoutTests

2010-12-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

[GTK] Fails back to POST tests
https://bugs.webkit.org/show_bug.cgi?id=50678

Skip new tests that we are failing.

platform/gtk/Skipped:

3:42 AM Changeset in webkit [73505] by kov@webkit.org

1 edit
1 move in trunk/WebKit/gtk/po

2010-12-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Fix name of the Korean translation file.

kr.po -> ko.po: renamed to correct name.

3:28 AM Changeset in webkit [73504] by yurys@chromium.org

11 edits in trunk

2010-12-08 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove groupLevel counter from console messages
https://bugs.webkit.org/show_bug.cgi?id=50672

inspector/console-tests-expected.txt:

2010-12-08 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove groupLevel counter from console messages
https://bugs.webkit.org/show_bug.cgi?id=50672

inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::ConsoleMessage): (WebCore::ConsoleMessage::addToFrontend): (WebCore::ConsoleMessage::isEqual):
inspector/ConsoleMessage.h:
inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::addMessageToConsole): (WebCore::InspectorController::clearConsoleMessages): (WebCore::InspectorController::startGroup): (WebCore::InspectorController::endGroup):
inspector/InspectorController.h:
inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.createFilterElement): (WebInspector.ConsoleView): (WebInspector.ConsoleView.prototype.filter): (WebInspector.ConsoleView.prototype.afterShow): (WebInspector.ConsoleView.prototype.addMessage): (WebInspector.ConsoleView.prototype.updateMessageRepeatCount): (WebInspector.ConsoleView.prototype.clearMessages): (WebInspector.ConsoleMessage): (WebInspector.ConsoleMessage.createTextMessage): (WebInspector.ConsoleMessage.prototype.toMessageElement): (WebInspector.ConsoleMessage.prototype._addMessageHeader): (WebInspector.ConsoleMessage.prototype._updateRepeatCount): (WebInspector.ConsoleMessage.prototype.toString): (WebInspector.ConsoleMessage.prototype.isEqual): (WebInspector.ConsoleGroup):
inspector/front-end/Resource.js: (WebInspector.Resource.prototype._checkWarning):
inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._addMessageToSource):
inspector/front-end/inspector.js: (WebInspector.addConsoleMessage): (WebInspector.log.logMessage): (WebInspector.log):

3:23 AM Changeset in webkit [73503] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

Unreviewed. Add new tests introduced in r73484 to the Skipped list,
because layoutTestController.testRepaint() is unimplemented in Qt DRT.

platform/qt/Skipped:
- fast/repaint/table-writing-modes-h.html added
- fast/repaint/table-writing-modes-v.html added

3:17 AM Changeset in webkit [73502] by Csaba Osztrogonác

13 edits in trunk/LayoutTests

Unreviewed. Update Qt specific expected results after r73488.
Compared to Mac png files and Mac expected files.

platform/qt/fast/dom/HTMLMeterElement/meter-boundary-values-expected.checksum:
platform/qt/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
platform/qt/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
platform/qt/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum:
platform/qt/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
platform/qt/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
platform/qt/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum:
platform/qt/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png:
platform/qt/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
platform/qt/fast/dom/HTMLMeterElement/meter-styles-expected.checksum:
platform/qt/fast/dom/HTMLMeterElement/meter-styles-expected.png:
platform/qt/fast/dom/HTMLMeterElement/meter-styles-expected.txt:

3:17 AM Changeset in webkit [73501] by podivilov@chromium.org

11 edits
2 adds in trunk/WebCore

2010-12-07 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: introduce DebuggerModel class representing InspectorDebuggerAgent state.
https://bugs.webkit.org/show_bug.cgi?id=50567

Moved debugging-related code from BreakpointManager to DebuggerModel. Moved Breakpoint class to a separate file.

English.lproj/localizedStrings.js:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
inspector/front-end/Breakpoint.js: Added. (WebInspector.Breakpoint): Moved from BreakpointManager.js.
inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager): Remove debugger-related methods.
inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane): (WebInspector.CallStackSidebarPane.prototype._nativeBreakpointHit): (WebInspector.CallStackSidebarPane.prototype._scriptBreakpointHit):
inspector/front-end/DebuggerModel.js: Added. (WebInspector.DebuggerModel): Moved debugger-related methods from BreakpointManager.
inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.continueToLine): (WebInspector.ScriptsPanel.prototype.editScriptSource.mycallback): (WebInspector.ScriptsPanel.prototype.editScriptSource): (WebInspector.ScriptsPanel.prototype._debuggerPaused): (WebInspector.ScriptsPanel.prototype._debuggerResumed): (WebInspector.ScriptsPanel.prototype.reset):
inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._createViewerIfNeeded): (WebInspector.SourceFrameDelegate.prototype.addBreakpoint): (WebInspector.SourceFrameDelegate.prototype.breakpoints): (WebInspector.SourceFrameDelegate.prototype.findBreakpoint):
inspector/front-end/WebKit.qrc:
inspector/front-end/inspector.html:
inspector/front-end/inspector.js: (WebInspector.createJSBreakpointsSidebarPane): (WebInspector.restoredBreakpoint): (WebInspector.pausedScript): (WebInspector.resumedScript): (WebInspector.reset):

3:07 AM Changeset in webkit [73500] by Philippe Normand

2 edits in trunk/LayoutTests

2010-12-08 Philippe Normand <pnormand@igalia.com>

Unreviewed, updated baselines of
media/video-controls-rendering.html.

platform/gtk/media/video-controls-rendering-expected.txt:

2:44 AM Changeset in webkit [73499] by podivilov@chromium.org

10 edits in trunk

2010-12-08 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: SourceFrame refactoring.
https://bugs.webkit.org/show_bug.cgi?id=50223

inspector/debugger-breakpoints-not-activated-on-reload.html:
inspector/debugger-pause-on-breakpoint.html:

2010-12-08 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: SourceFrame refactoring.
https://bugs.webkit.org/show_bug.cgi?id=50223

SourceFrame should ask BreakpointManager about existing breakpoints instead of maintaining
it's own storages. Move common code from ScriptView and SourceView to SourceFrame.

inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.findBreakpoints): (WebInspector.BreakpointManager.prototype.findBreakpoint):
inspector/front-end/Script.js: (WebInspector.Script): (WebInspector.Script.prototype.get linesCount): (WebInspector.Script.prototype.get source): (WebInspector.Script.prototype.set source):
inspector/front-end/ScriptView.js: (WebInspector.ScriptView): (WebInspector.ScriptView.prototype._scriptSourceChanged): (WebInspector.ScriptFrameDelegateImpl): (WebInspector.ScriptFrameDelegateImpl.prototype.canEditScripts): (WebInspector.ScriptFrameDelegateImpl.prototype.editLineComplete): (WebInspector.ScriptFrameDelegateImpl.prototype.scripts):
inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel):
inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame): Add common methods of ScriptView and SourceView. (WebInspector.SourceFrameDelegate): (WebInspector.SourceFrameDelegate.prototype.canEditScripts): (WebInspector.SourceFrameDelegate.prototype.editLineComplete): (WebInspector.SourceFrameDelegate.prototype.scripts):
inspector/front-end/SourceView.js: (WebInspector.SourceView): (WebInspector.SourceView.prototype._contentLoaded): (WebInspector.ResourceFrameDelegateImpl): (WebInspector.ResourceFrameDelegateImpl.prototype.canEditScripts): (WebInspector.ResourceFrameDelegateImpl.prototype.editLineComplete): (WebInspector.ResourceFrameDelegateImpl.prototype.scripts):

2:25 AM Changeset in webkit [73498] by Philippe Normand

2 edits in trunk/LayoutTests

2010-12-08 Philippe Normand <pnormand@igalia.com>

Unreviewed, unskipping media/video-controls-rendering.html on GTK.

It should now not crash anymore because the GTK bots have been
upgraded to latest GStreamer releases.

platform/gtk/Skipped:

2:22 AM Changeset in webkit [73497] by alex

2 edits in trunk/WebKit/gtk

2010-12-08 Alejandro G. Castro <alex@igalia.com>

Reviewed by Gustavo Noronha Silva.

Fix assertion in the API test, we are requesting the favicon and
the subresource so we have to make sure we are assigning just the
first subresource.

tests/testwebresource.c: (resource_request_starting_sub_cb):

1:35 AM Changeset in webkit [73496] by yutak@chromium.org

14 edits
1 add in trunk/WebCore

2010-12-08 Yuta Kitamura <yutak@chromium.org>

Unreviewed, rolling out r73492.
http://trac.webkit.org/changeset/73492
https://bugs.webkit.org/show_bug.cgi?id=49914

Caused a lot of pixel test failures and broke Windows build.

WebCore.xcodeproj/project.pbxproj:
platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::createGraphicsContextPrivate): (WebCore::GraphicsContext::destroyGraphicsContextPrivate): (WebCore::GraphicsContext::save): (WebCore::GraphicsContext::restore): (WebCore::GraphicsContext::setStrokeThickness): (WebCore::GraphicsContext::setStrokeStyle): (WebCore::GraphicsContext::setStrokeColor): (WebCore::GraphicsContext::setShadow): (WebCore::GraphicsContext::clearShadow): (WebCore::GraphicsContext::getShadow): (WebCore::GraphicsContext::strokeThickness): (WebCore::GraphicsContext::strokeStyle): (WebCore::GraphicsContext::strokeColor): (WebCore::GraphicsContext::strokeColorSpace): (WebCore::GraphicsContext::fillRule): (WebCore::GraphicsContext::setFillRule): (WebCore::GraphicsContext::setFillColor): (WebCore::GraphicsContext::fillColor): (WebCore::GraphicsContext::fillColorSpace): (WebCore::GraphicsContext::setShouldAntialias): (WebCore::GraphicsContext::shouldAntialias): (WebCore::GraphicsContext::setStrokePattern): (WebCore::GraphicsContext::setFillPattern): (WebCore::GraphicsContext::setStrokeGradient): (WebCore::GraphicsContext::setFillGradient): (WebCore::GraphicsContext::fillGradient): (WebCore::GraphicsContext::strokeGradient): (WebCore::GraphicsContext::fillPattern): (WebCore::GraphicsContext::strokePattern): (WebCore::GraphicsContext::setShadowsIgnoreTransforms): (WebCore::GraphicsContext::updatingControlTints): (WebCore::GraphicsContext::setUpdatingControlTints): (WebCore::GraphicsContext::setPaintingDisabled): (WebCore::GraphicsContext::paintingDisabled): (WebCore::GraphicsContext::textDrawingMode): (WebCore::GraphicsContext::setTextDrawingMode):
platform/graphics/GraphicsContext.h:
platform/graphics/GraphicsContextPrivate.h: Added. (WebCore::GraphicsContextState::GraphicsContextState): (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::setPlatformFill): (WebCore::setPlatformStroke): (WebCore::drawPathShadow): (WebCore::fillCurrentCairoPath): (WebCore::strokeCurrentCairoPath): (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::setPlatformShadow): (WebCore::GraphicsContext::strokeRect): (WebCore::GraphicsContext::setAlpha): (WebCore::GraphicsContext::getAlpha):
platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext): (WebCore::GraphicsContext::applyStrokePattern): (WebCore::GraphicsContext::applyFillPattern): (WebCore::GraphicsContext::drawPath): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::setPlatformShadow): (WebCore::GraphicsContext::strokeRect):
platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext):
platform/graphics/openvg/GraphicsContextOpenVG.cpp: (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::clipOut): (WebCore::GraphicsContext::addInnerRoundedRectClip):
platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::setPlatformShadow):
platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::setPlatformShadow):
platform/graphics/win/GraphicsContextCGWin.cpp: (WebCore::GraphicsContext::GraphicsContext):
platform/graphics/win/GraphicsContextCairoWin.cpp: (WebCore::GraphicsContext::GraphicsContext):
platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::fillRect):
platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext):

1:34 AM Changeset in webkit [73495] by yurys@chromium.org

1 edit in branches/chromium/597/WebCore/bindings/v8/ScriptDebugServer.cpp

Merge 73441 - 2010-12-07 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: avoid initializing Context on when creating attaching listener to ScriptDebugServer
https://bugs.webkit.org/show_bug.cgi?id=50627

bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::addListener): don't try to collect already parsed scripts if context has not been initialized yet.

TBR=yurys@chromium.org
Review URL: http://codereview.chromium.org/5664002

12:43 AM Changeset in webkit [73494] by commit-queue@webkit.org

20 edits
5 adds in trunk

2010-12-08 Dai Mikurube <dmikurube@google.com>

Reviewed by Kent Tamura.

Implement "required" attribute for select tags
https://bugs.webkit.org/show_bug.cgi?id=50380

Added tests for require attributes, valueMissing and vadility check for select elements.

fast/forms/ValidityState-valueMissing-001-expected.txt:
fast/forms/ValidityState-valueMissing-001.html:
fast/forms/ValidityState-valueMissing-002-expected.txt:
fast/forms/ValidityState-valueMissing-002.html:
fast/forms/ValidityState-valueMissing-003-expected.txt:
fast/forms/ValidityState-valueMissing-003.html:
fast/forms/checkValidity-002-expected.txt:
fast/forms/checkValidity-002.html:
fast/forms/required-attribute-001-expected.txt:
fast/forms/required-attribute-001.html:
fast/forms/required-attribute-002-expected.txt:
fast/forms/required-attribute-002.html:
fast/forms/resources/select-live-pseudo-selectors.js: Added. (makeInvalid): (appendOption): (backgroundOf):
fast/forms/script-tests/validationMessage.js:
fast/forms/select-live-pseudo-selectors-expected.txt: Added.
fast/forms/select-live-pseudo-selectors.html: Added.
fast/forms/validationMessage-expected.txt:
platform/mac/fast/objc/dom-html-select-live-pseudo-selectors.html: Added.
platform/mac/fast/objc/dom-html-select-live-pseudo-selectors-expected.txt: Added.

2010-12-08 Dai Mikurube <dmikurube@google.com>

Reviewed by Kent Tamura.

Implement "required" attribute for select tags
https://bugs.webkit.org/show_bug.cgi?id=50380

Test: fast/forms/select-live-pseudo-selectors.html

platform/mac/fast/objc/dom-html-select-live-pseudo-selectors.html

html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::deselectItems): Added calling setNeedsValidityCheck() to enable validity check after changing. No tests for this change since this function is not exposed to JavaScript or any web interface. (WebCore::HTMLSelectElement::setSelectedIndex): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::setSelectedIndexByUser): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::valueMissing): Added valueMissing() to check if selecting an invalid or placeholder label option when a valid required attribute is specified. (WebCore::HTMLSelectElement::listBoxSelectItem): Added calling setNeedsValidityCheck(). No tests for this change since it is not called yet. Look at the bug 36177 and the changeset 56180. (WebCore::HTMLSelectElement::add): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::remove): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::restoreFormControlState): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::parseMappedAttribute): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::selectAll): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::reset): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::updateListBoxSelection): Added calling setNeedsValidityCheck(). Skipped adding tests for this change as too complicated.. (WebCore::HTMLSelectElement::setLength): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::isRequiredFormControl): Check if required or not. (WebCore::HTMLSelectElement::hasPlaceholderLabelOption): Added.
html/HTMLSelectElement.h: (WebCore::HTMLSelectElement::isOptionalFormControl): Check if not required.
html/HTMLSelectElement.idl: Added a required attribute to select elements..
html/ValidityState.cpp: (WebCore::ValidityState::valueMissing): Added valueMissing check for select elements into the global checker, ValidityState::valueMissing().

12:08 AM Changeset in webkit [73493] by yutak@chromium.org

2 edits in trunk/LayoutTests

2010-12-08 Yuta Kitamura <yutak@chromium.org>

Unreviewed.

Update Chromium test expectations.

platform/chromium/test_expectations.txt:

12:05 AM Changeset in webkit [73492] by reni@webkit.org

14 edits
1 delete in trunk/WebCore

2010-12-08 Renata Hodovan <reni@webkit.org>

Reviewed by Andreas Kling.

GraphicsContext: Merge m_common and m_data
https://bugs.webkit.org/show_bug.cgi?id=49914

Move data members from GraphicsContextPrivate into GraphicsContext. So GraphicsContextPlatform.h
and m_common became unnecessary. They are removed.
Add two methods to GraphicsContext: platformInit() and platformDestroy(), which
make the constructor of GraphicsContext clearer.
Besides add a getter to the private GraphicsContext::m_state member, because some inline
functions in cairo need it.

No new test is needed, because this is a refactoring.

WebCore.xcodeproj/project.pbxproj:
platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext): (WebCore::GraphicsContext::save): (WebCore::GraphicsContext::restore): (WebCore::GraphicsContext::setStrokeThickness): (WebCore::GraphicsContext::setStrokeStyle): (WebCore::GraphicsContext::setStrokeColor): (WebCore::GraphicsContext::setShadow): (WebCore::GraphicsContext::clearShadow): (WebCore::GraphicsContext::getShadow): (WebCore::GraphicsContext::strokeThickness): (WebCore::GraphicsContext::strokeStyle): (WebCore::GraphicsContext::strokeColor): (WebCore::GraphicsContext::strokeColorSpace): (WebCore::GraphicsContext::fillRule): (WebCore::GraphicsContext::setFillRule): (WebCore::GraphicsContext::setFillColor): (WebCore::GraphicsContext::fillColor): (WebCore::GraphicsContext::fillColorSpace): (WebCore::GraphicsContext::setShouldAntialias): (WebCore::GraphicsContext::shouldAntialias): (WebCore::GraphicsContext::state): (WebCore::GraphicsContext::setStrokePattern): (WebCore::GraphicsContext::setFillPattern): (WebCore::GraphicsContext::setStrokeGradient): (WebCore::GraphicsContext::setFillGradient): (WebCore::GraphicsContext::fillGradient): (WebCore::GraphicsContext::strokeGradient): (WebCore::GraphicsContext::fillPattern): (WebCore::GraphicsContext::strokePattern): (WebCore::GraphicsContext::setShadowsIgnoreTransforms): (WebCore::GraphicsContext::updatingControlTints): (WebCore::GraphicsContext::setUpdatingControlTints): (WebCore::GraphicsContext::setPaintingDisabled): (WebCore::GraphicsContext::paintingDisabled): (WebCore::GraphicsContext::textDrawingMode): (WebCore::GraphicsContext::setTextDrawingMode):
platform/graphics/GraphicsContext.h: (WebCore::GraphicsContextState::GraphicsContextState):
platform/graphics/GraphicsContextPrivate.h: Removed.
platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::setPlatformFill): (WebCore::setPlatformStroke): (WebCore::drawPathShadow): (WebCore::fillCurrentCairoPath): (WebCore::strokeCurrentCairoPath): (WebCore::GraphicsContext::platformInit): (WebCore::GraphicsContext::platformDestroy): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::setPlatformShadow): (WebCore::GraphicsContext::strokeRect): (WebCore::GraphicsContext::setAlpha): (WebCore::GraphicsContext::getAlpha):
platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::platformInit): (WebCore::GraphicsContext::platformDestroy): (WebCore::GraphicsContext::applyStrokePattern): (WebCore::GraphicsContext::applyFillPattern): (WebCore::GraphicsContext::drawPath): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::setPlatformShadow): (WebCore::GraphicsContext::strokeRect):
platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::platformInit): (WebCore::GraphicsContext::platformDestroy):
platform/graphics/openvg/GraphicsContextOpenVG.cpp: (WebCore::GraphicsContext::platformInit): (WebCore::GraphicsContext::platformDestroy): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::clipOut): (WebCore::GraphicsContext::addInnerRoundedRectClip):
platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::platformInit): (WebCore::GraphicsContext::platformDestroy): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::setPlatformShadow):
platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::platformInit): (WebCore::GraphicsContext::platformDestroy): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::setPlatformShadow):
platform/graphics/win/GraphicsContextCGWin.cpp: (WebCore::GraphicsContext::platformInit):
platform/graphics/win/GraphicsContextCairoWin.cpp: (WebCore::GraphicsContext::platformInit):
platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::GraphicsContext::platformInit): (WebCore::GraphicsContext::platformDestroy): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::fillRect):
platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::platformInit): (WebCore::GraphicsContext::platformDestroy):

Dec 7, 2010:

10:45 PM Changeset in webkit [73491] by antonm@chromium.org

3 edits in trunk/WebCore

2010-12-07 Anton Muhin <antonm@chromium.org>

Reviewed by Nate Chapin.

Port http://trac.webkit.org/changeset/72819/ to v8-backed ports.
https://bugs.webkit.org/show_bug.cgi?id=50246

bindings/v8/V8DOMMap.h: (WebCore::AbstractWeakReferenceMap::Visitor::startMap): (WebCore::AbstractWeakReferenceMap::Visitor::endMap): (WebCore::WeakReferenceMap::visit):
bindings/v8/V8GCController.cpp: (WebCore::GrouperItem::GrouperItem): (WebCore::GrouperItem::groupId): (WebCore::makeV8ObjectGroups): (WebCore::NodeGrouperVisitor::NodeGrouperVisitor): (WebCore::NodeGrouperVisitor::visitDOMWrapper): (WebCore::NodeGrouperVisitor::applyGrouping): (WebCore::DOMObjectGrouperVisitor::ObjectGrouperVisitor): (WebCore::DOMObjectGrouperVisitor::startMap): (WebCore::DOMObjectGrouperVisitor::endMap): (WebCore::DOMObjectGrouperVisitor::visitDOMWrapper): (WebCore::V8GCController::gcPrologue):

8:49 PM Changeset in webkit [73490] by dbates@webkit.org

5 edits
20 adds in trunk

2010-12-07 Daniel Bates <dbates@rim.com>

Reviewed by Martin Robinson.

Implement focus ring support for image maps
https://bugs.webkit.org/show_bug.cgi?id=50371

Implement GraphicsContext::drawFocusRing(const Path&, ...) so as to support
drawing a focus ring for image maps.

Tests: fast/images/imagemap-circle-focus-ring.html

fast/images/imagemap-polygon-focus-ring.html

platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::adjustFocusRingColor): Added. (WebCore::adjustFocusRingLineWidth): Added. (WebCore::focusRingStrokeStyle): Added. (WebCore::GraphicsContext::drawFocusRing): Moved code for determining focus ring- color, line width and stroke style into functions adjustFocusRingColor(), adjustFocusRingLineWidth(), and focusRingStrokeStyle(), respectively. Implemented GraphicsContext::drawFocusRing(const Path&, ...).

2010-12-07 Daniel Bates <dbates@rim.com>

Reviewed by Martin Robinson.

Implement focus ring support for image maps
https://bugs.webkit.org/show_bug.cgi?id=50371

Tests to ensure that we support drawing a focus ring for an image map.
In particular, that the GTK port can draw a focus ring for an image map.

fast/images/imagemap-circle-focus-ring.html: Added.
fast/images/imagemap-polygon-focus-ring.html: Added.
platform/gtk/fast/images/imagemap-circle-focus-ring-expected.checksum: Added.
platform/gtk/fast/images/imagemap-circle-focus-ring-expected.png: Added.
platform/gtk/fast/images/imagemap-circle-focus-ring-expected.txt: Added.
platform/gtk/fast/images/imagemap-focus-ring-expected.checksum: Rebase result since we now support drawing a focus ring for imagemaps.
platform/gtk/fast/images/imagemap-focus-ring-expected.png: Ditto.
platform/gtk/fast/images/imagemap-focus-ring-outline-color-expected.checksum: Added.
platform/gtk/fast/images/imagemap-focus-ring-outline-color-expected.png: Added.
platform/gtk/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.checksum: Added.
platform/gtk/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.png: Added.
platform/gtk/fast/images/imagemap-focus-ring-zoom-expected.checksum: Added.
platform/gtk/fast/images/imagemap-focus-ring-zoom-expected.png: Added.
platform/gtk/fast/images/imagemap-polygon-focus-ring-expected.checksum: Added.
platform/gtk/fast/images/imagemap-polygon-focus-ring-expected.png: Added.
platform/gtk/fast/images/imagemap-polygon-focus-ring-expected.txt: Added.
platform/mac/fast/images/imagemap-circle-focus-ring-expected.checksum: Added.
platform/mac/fast/images/imagemap-circle-focus-ring-expected.png: Added.
platform/mac/fast/images/imagemap-circle-focus-ring-expected.txt: Added.
platform/mac/fast/images/imagemap-polygon-focus-ring-expected.checksum: Added.
platform/mac/fast/images/imagemap-polygon-focus-ring-expected.png: Added.
platform/mac/fast/images/imagemap-polygon-focus-ring-expected.txt: Added.

8:33 PM Changeset in webkit [73489] by commit-queue@webkit.org

2 edits in trunk/WebCore

2010-12-07 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Xan Lopez.

[GTK] WebKitSoupCache fails to load resources when cache contents are externally removed
https://bugs.webkit.org/show_bug.cgi?id=50577

Try to download cached resources again if they are no longer
accesible by the cache.

platform/network/soup/cache/soup-request-http.c: (send_async_cb): (webkit_soup_request_http_send_async):

8:21 PM Changeset in webkit [73488] by morrita@google.com

21 edits
2 adds in trunk

2010-12-05 MORITA Hajime <morrita@google.com>

Reviewed by Dimitri Glazkov.

Added a test case
Updated expectations to follow the change on the shadow structure.

RenderIndicator subclasses should not change the render tree during layout.
https://bugs.webkit.org/show_bug.cgi?id=50026

fast/dom/HTMLMeterElement/meter-element-crash-expected.txt: Added.
fast/dom/HTMLMeterElement/meter-element-crash.html: Added.
platform/mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
platform/mac/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
platform/mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.txt:
platform/mac/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt:

2010-12-06 MORITA Hajime <morrita@google.com>

Reviewed by Dimitri Glazkov.

RenderIndicator subclasses should not change the render tree during layout.
https://bugs.webkit.org/show_bug.cgi?id=50026

The old code created shadow elements during a layout computation,
that makes the layout state inconsisntent and cause an assertion failure.
This change created shadow elements before the layout to avoid
state inconsistencies.

Instead of creating shadows on demand, RenderMeter and
RenderProgress now create all necessary shadows before layouts,
and change its visibilities during the layout: Changing
visibilities doesn't trigger relayout and keep the state
consistent.

RenderMeter uses new HidablePartElement for shadow elements,
which can toggle visibiliby between hidden and original value.

Test: fast/dom/HTMLMeterElement/meter-element-crash.html

html/HTMLMeterElement.cpp: (WebCore::HTMLMeterElement::attach): Calling updateFromElement()
html/HTMLMeterElement.h:
html/HTMLProgressElement.cpp: (WebCore::HTMLProgressElement::attach): Calling updateFromElement()
html/HTMLProgressElement.h:
rendering/RenderIndicator.cpp:
rendering/RenderIndicator.h:
rendering/RenderMeter.cpp: (WebCore::MeterPartElement::MeterPartElement): Added to hold a restorable visibility. (WebCore::MeterPartElement::createForPart): (WebCore::MeterPartElement::hide): (WebCore::MeterPartElement::restoreVisibility): (WebCore::MeterPartElement::updateStyleForPart): (WebCore::MeterPartElement::saveVisibility): (WebCore::RenderMeter::~RenderMeter): (WebCore::RenderMeter::createPart): Extracted (WebCore::RenderMeter::updateFromElement): Had a shadow generation. (WebCore::RenderMeter::layoutParts): Removed shadow generation code. (WebCore::RenderMeter::shouldHaveParts): (WebCore::RenderMeter::valuePartRect): Adopted orientation. (WebCore::RenderMeter::orientation): Morphed from isHorizontal() (WebCore::RenderMeter::valuePseudoId): Adoptedn orientation (WebCore::RenderMeter::barPseudoId): Adopted orientation.
rendering/RenderMeter.h: (WebCore::RenderMeter::shadowAttached):
rendering/RenderProgress.cpp: (WebCore::RenderProgress::updateFromElement): Had a shadow generation. (WebCore::RenderProgress::layoutParts):
rendering/RenderProgress.h:
rendering/ShadowElement.cpp: (WebCore::ShadowBlockElement::createForPart): Extracted initAsPart(). (WebCore::ShadowBlockElement::initAsPart): Extracted from createForPart().
rendering/ShadowElement.h:

6:44 PM Changeset in webkit [73487] by Simon Fraser

2 edits in trunk/LayoutTests

2010-12-07 Simon Fraser <Simon Fraser>

Relax the matching tolerance to reduce flakiness.

transitions/border-radius-transition.html:

6:32 PM Changeset in webkit [73486] by mihaip@chromium.org

6 edits
10 adds
2 deletes in trunk

2010-11-29 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

returning to a POST result within a frame does a GET instead of a POST
https://bugs.webkit.org/show_bug.cgi?id=10199

Re-enable postredirect-frames-goback1.html and post-frames-goback1.html
now that the big that made them be checked in disabled was fixed.

The tests were also re-written to not be pixel tests, since that just
adds extra per-platform baseline pain.

Add fast/history/history-back-initial-vs-final-url.html since there did
not appear to be any tests for whether we used the initial or final URL
of a frame's history item (and this patch changes it from the former to
the latter).

fast/history/history-back-initial-vs-final-url-expected.txt: Added.
fast/history/history-back-initial-vs-final-url.html: Added.
fast/history/resources/frame-final-url.html: Added.
fast/history/resources/frame-initial-url.html: Added.
http/tests/navigation/post-frames-goback1-expected.txt: Added.
http/tests/navigation/post-frames-goback1.html: Added.
http/tests/navigation/post-frames-goback1.html-disabled: Removed.
http/tests/navigation/post-frames.html:
http/tests/navigation/postredirect-frames-goback1-expected.txt: Added.
http/tests/navigation/postredirect-frames-goback1.html: Added.
http/tests/navigation/postredirect-frames-goback1.html-disabled: Removed.
http/tests/navigation/resources/form-target.pl:
http/tests/navigation/resources/redirect-to-go-back.pl: Added.
http/tests/navigation/resources/top-go-back.html: Added.

2010-11-29 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

returning to a POST result within a frame does a GET instead of a POST
https://bugs.webkit.org/show_bug.cgi?id=10199

FrameLoader::loadURLIntoChildFrame had a check for whether a frame
had a HistoryItem, and if so used that item's URL. However, that did
not handle the case where the HistoryItem had FormData and thus was the
result of a POST request. FrameLoader::navigateToDifferentDocument (now
renamed to loadDifferentDocumentItem) does all that, so just switch to
using it instead.

Besides the bug fix, the only difference in behavior is that we use the
HistoryItem's URL instead of original URL when restoring it in a child
frame. This seems desirable too (for consistency with other browsers, and
so that we can avoid form double-submits for forms that that do
POST-then-redirect), and is tested by
fast/history/history-back-initial-vs-final-url.html.

Tests: fast/history/history-back-initial-vs-final-url.html

http/tests/navigation/post-frames-goback1.html
http/tests/navigation/postredirect-frames-goback1.html

loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURLIntoChildFrame): Switch to using

loadDifferentDocumentItem. Also cleaned up ordering slightly (if
on the archive path, there's no need to do any of the other checks).

(WebCore::FrameLoader::loadDifferentDocumentItem): Renamed from

navigateToDifferentDocument so that calling it from loadItem and
loadURLIntoChildFrame flows more easily.

(WebCore::FrameLoader::loadSameDocumentItem): Similarly, renamed from

navigateWithinDocument.

(WebCore::FrameLoader::loadItem): Update callsites to the above methods.

loader/FrameLoader.h:

6:27 PM Changeset in webkit [73485] by mrowe@apple.com

9 edits
1 delete in trunk

Roll out r73477 and r73483 since they broke the Mac SnowLeopard build.

5:37 PM Changeset in webkit [73484] by mitz@apple.com

3 edits
8 adds in trunk

WebCore: Made tables repaint correctly in all writing modes
Part of: Make tables work with vertical text
https://bugs.webkit.org/show_bug.cgi?id=46417

Reviewed by Darin Adler.

Tests: fast/repaint/table-writing-modes-h.html

fast/repaint/table-writing-modes-v.html

rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::paintObject): Compute the ranges of rows and
columns to repaint based on the logical extent of the repaint rect.

LayoutTests: Test that tables repaint correctly in all writing modes
Part of: Make tables work with vertical text
https://bugs.webkit.org/show_bug.cgi?id=46417

Reviewed by Darin Adler.

fast/repaint/table-writing-modes-h-expected.checksum: Added.
fast/repaint/table-writing-modes-h-expected.png: Added.
fast/repaint/table-writing-modes-h-expected.txt: Added.
fast/repaint/table-writing-modes-h.html: Added.
fast/repaint/table-writing-modes-v-expected.checksum: Added.
fast/repaint/table-writing-modes-v-expected.png: Added.
fast/repaint/table-writing-modes-v-expected.txt: Added.
fast/repaint/table-writing-modes-v.html: Added.

5:17 PM Changeset in webkit [73483] by cmarrin@apple.com

2 edits in trunk/WebCore

2010-12-07 Chris Marrin <cmarrin@apple.com>

Unreviewed.

Fix build problem from http://trac.webkit.org/changeset/73477

platform/graphics/transforms/TransformationMatrix.h:

5:03 PM Changeset in webkit [73482] by jamesr@google.com

2 edits in branches/chromium/597/WebCore

Merge 73479 - 2010-12-07 Alexey Marinichev <amarinichev@chromium.org>

Reviewed by James Robinson.

[chromium] compositor lost context recovery fix
https://bugs.webkit.org/show_bug.cgi?id=50614

To test, load a page that triggers the compositor, kill the GPU
process and hover over a link to redraw and thus restart the GPU
process. Without this patch it will assert in
ContentLayerChromium::updateTextureRect; with this patch it will not.

platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::setNeedsDisplay):

TBR=amarinichev@chromium.org
BUG=65194

Review URL: http://codereview.chromium.org/5639006

5:02 PM Changeset in webkit [73481] by jschuh@chromium.org

7 edits
2 copies in branches/chromium/552

2010-12-07 Justin Schuh <jschuh@chromium.org>

Reviewed by Nikolas Zimmermann.

Clear old SVG cursor entry before adding a new one
https://bugs.webkit.org/show_bug.cgi?id=50549

Test: svg/css/cursor-replace.svg

css/CSSCursorImageValue.cpp: (WebCore::CSSCursorImageValue::~CSSCursorImageValue):
svg/SVGCursorElement.cpp: (WebCore::SVGCursorElement::~SVGCursorElement): (WebCore::SVGCursorElement::removeClient): (WebCore::SVGCursorElement::removeReferencedElement):
svg/SVGCursorElement.h:
svg/SVGElement.cpp: (WebCore::SVGElement::setCursorElement): (WebCore::SVGElement::cursorElementRemoved): (WebCore::SVGElement::setCursorImageValue): (WebCore::SVGElement::cursorImageElementRemoved):
svg/SVGElement.h:

2010-12-07 Justin Schuh <jschuh@chromium.org>

Reviewed by Nikolas Zimmermann.

Clear old SVG cursor entry before adding a new one
https://bugs.webkit.org/show_bug.cgi?id=50549

svg/css/cursor-replace-expected.txt: Added.
svg/css/cursor-replace.svg: Added.

BUG=64959
TBR=jschuh@chromium.org

4:58 PM Changeset in webkit [73480] by jamesr@google.com

3 edits in branches/chromium/597/WebCore

Merge 73424 - 2010-12-06 Alexey Marinichev <amarinichev@chromium.org>

Reviewed by Kenneth Russell.

Throw webglcontextlost and webglcontextrestored events when a WebGL context is lost and restored.
https://bugs.webkit.org/show_bug.cgi?id=50364

No new tests since there is currently no way to force a context lost event.

html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::WebGLRenderingContextRestoreTimer::fired): (WebCore::WebGLRenderingContext::create): (WebCore::WebGLRenderingContext::WebGLRenderingContext): (WebCore::WebGLRenderingContext::isContextLost): (WebCore::WebGLRenderingContext::loseContext): (WebCore::WebGLRenderingContext::restoreContext):
html/canvas/WebGLRenderingContext.h: (WebCore::WebGLRenderingContext::WebGLRenderingContextRestoreTimer::WebGLRenderingContextRestoreTimer):

TBR=amarinichev@chromium.org
BUG=57176

Review URL: http://codereview.chromium.org/5511013

4:53 PM Changeset in webkit [73479] by jamesr@google.com

2 edits in trunk/WebCore

2010-12-07 Alexey Marinichev <amarinichev@chromium.org>

Reviewed by James Robinson.

[chromium] compositor lost context recovery fix
https://bugs.webkit.org/show_bug.cgi?id=50614

To test, load a page that triggers the compositor, kill the GPU
process and hover over a link to redraw and thus restart the GPU
process. Without this patch it will assert in
ContentLayerChromium::updateTextureRect; with this patch it will not.

platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::setNeedsDisplay):

4:41 PM Changeset in webkit [73478] by tony@chromium.org

2 edits in trunk/LayoutTests

2010-12-07 Tony Chang <tony@chromium.org>

Unreviewed, mark a test as flaky on chromium drt linux.

platform/chromium/test_expectations.txt:

4:31 PM Changeset in webkit [73477] by cmarrin@apple.com

9 edits
1 add in trunk

2010-12-07 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
https://bugs.webkit.org/show_bug.cgi?id=49388

Added copy constructors and casting operators to go between
TransformationMatrix and CATransform3D. Also added a copy
constructor to go from CGAffineTransform to TransformationMatrix.
Used these new methods to clean up platform CA code. This will
make it easier to port to Windows.

I also fixed a couple of build issues found when trying out a
Windows build.

4:31 PM Changeset in webkit [73476] by tony@chromium.org

5 edits
2 adds in trunk/LayoutTests

2010-12-07 Tony Chang <tony@chromium.org>

Unreviewed, adding chromium pixel results for
fast/forms/caret-rtl.html after http://trac.webkit.org/changeset/73459

platform/chromium-linux/fast/forms/caret-rtl-expected.checksum:
platform/chromium-linux/fast/forms/caret-rtl-expected.png:
platform/chromium-mac/fast/forms/caret-rtl-expected.checksum: Added.
platform/chromium-mac/fast/forms/caret-rtl-expected.png: Added.
platform/chromium-win/fast/forms/caret-rtl-expected.checksum:
platform/chromium-win/fast/forms/caret-rtl-expected.png:

4:26 PM Changeset in webkit [73475] by andersca@apple.com

2 edits in trunk/WebCore

Fix the last clang++ build error.

platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayer::animationForKey):
Cast the returned animation to the correct type.

3:55 PM Changeset in webkit [73474] by andersca@apple.com

4 edits in trunk/WebCore

Fix some clang++ build errors.

platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
Remove unused variable.

platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
platform/graphics/ca/mac/PlatformCALayerMac.mm:

Fix constness of pointers.

3:54 PM Changeset in webkit [73473] by jschuh@chromium.org

5 edits
2 copies in branches/chromium/597

Merge 73432 - 2010-12-07 Justin Schuh <jschuh@chromium.org>

Reviewed by Nikolas Zimmermann.

Clear old SVG cursor entry before adding a new one
https://bugs.webkit.org/show_bug.cgi?id=50549

Test: svg/css/cursor-replace.svg

css/CSSCursorImageValue.cpp: (WebCore::CSSCursorImageValue::~CSSCursorImageValue):
svg/SVGCursorElement.cpp: (WebCore::SVGCursorElement::~SVGCursorElement): (WebCore::SVGCursorElement::removeClient): (WebCore::SVGCursorElement::removeReferencedElement):
svg/SVGCursorElement.h:
svg/SVGElement.cpp: (WebCore::SVGElement::setCursorElement): (WebCore::SVGElement::cursorElementRemoved): (WebCore::SVGElement::setCursorImageValue): (WebCore::SVGElement::cursorImageElementRemoved):
svg/SVGElement.h:

2010-12-07 Justin Schuh <jschuh@chromium.org>

Reviewed by Nikolas Zimmermann.

Clear old SVG cursor entry before adding a new one
https://bugs.webkit.org/show_bug.cgi?id=50549

svg/css/cursor-replace-expected.txt: Added.
svg/css/cursor-replace.svg: Added.

BUG=64959
TBR=jschuh@chromium.org
Review URL: http://codereview.chromium.org/5545007

3:37 PM Changeset in webkit [73472] by Simon Fraser

2 edits in trunk/WebCore

2010-12-07 Simon Fraser <Simon Fraser>

Reviewed by Chris Marrin.

Fix the Color -> CGColorRef conversions for the debug colors
used for compositing layers.

platform/graphics/ca/mac/PlatformCALayerMac.mm: (PlatformCALayer::setBackgroundColor): (PlatformCALayer::setBorderColor):

3:31 PM Changeset in webkit [73471] by tony@chromium.org

2 edits in trunk/LayoutTests

2010-12-07 Tony Chang <tony@chromium.org>

Unreviewed, remove more passing tests (mac) from test_expecatations.txt
after DRT switch. Also remove a test that is passing because of
crankshaft.

platform/chromium/test_expectations.txt:

3:13 PM Changeset in webkit [73470] by tony@chromium.org

2 edits in trunk/LayoutTests

2010-12-07 Tony Chang <tony@chromium.org>

Unreviewed, remove more passing tests (win) from test_expectations.txt
after DRT switch.

platform/chromium/test_expectations.txt:

2:47 PM Changeset in webkit [73469] by bweinstein@apple.com

5 edits in trunk

Part of Layering Violation in ContextMenu
https://bugs.webkit.org/show_bug.cgi?id=50586

Reviewed by John Sullivan.

WebCore:

ContextMenuMac.mm had a WebCoreMenuTarget class, which was responsible for wrapping
a ContextMenuItem, and calling through to the ContextMenuController to validate it
and call a function when it was selected.

It was a layering violation to have this class here, because ContextMenu can't know
about ContextMenuController.

This patch moves the class that wraps the ContextMenuItems to WebKit/mac/WebHTMLView.mm,
and sets up the menu targets there.

No change in behavior, no new tests.

WebCore.exp.in: Added function that needs to be exported.
platform/mac/ContextMenuMac.mm:

(WebCore::ContextMenu::ContextMenu): Don't set the sharedMenuTarget anymore.
(WebCore::ContextMenu::appendItem): Don't call setMenuItemTarget (this is done in WebKit now).
(WebCore::ContextMenu::insertItem): Ditto.

WebKit/mac:

Move WebMenuTarget from ContextMenuMac to here, because having it in ContextMenuMac
was a layering violation. Also, make sure we set the menu item targets for all menu
items before showing them, because the ContextMenu constructor doesn't do that anymore.

WebView/WebHTMLView.mm:

(+[WebMenuTarget sharedMenuTarget]): Moved from ContextMenuMac.mm.
(-[WebMenuTarget WebCore::]): Ditto.
(-[WebMenuTarget setMenuController:WebCore::]): Ditto.
(-[WebMenuTarget forwardContextMenuAction:]): Ditto.
(-[WebMenuTarget validateMenuItem:]): Ditto.

(setMenuItemTarget): Sets the target of the NSMenuItem to the shared WebMenuTarget.
(setMenuTargets): Recursively iterates over all NSMenuItems in an NSMenu (including

submenus), and calls setMenuItemTarget on them.

(-[WebHTMLView menuForEvent:]): Call setMenuTarget on all the menu items before adding

them to the menu.

2:45 PM Changeset in webkit [73468] by tony@chromium.org

2 edits in trunk/LayoutTests

2010-12-07 Tony Chang <tony@chromium.org>

Unreviewed, remove passing tests (linux) from test_expectations
after DRT switch.

platform/chromium/test_expectations.txt:

2:31 PM Changeset in webkit [73467] by andersca@apple.com

2 edits in trunk/JavaScriptCore

Build fix follow up build fix.

pcre/pcre_ucp_searchfuncs.cpp:

(jsc_pcre_ucp_othercase):

2:22 PM Changeset in webkit [73466] by tony@chromium.org

2 edits in trunk/LayoutTests

2010-12-07 Tony Chang <tony@chromium.org>

Unreviewed, update chromium test_expectations for DRT based
on Linux bot cycles and debug try bot.

platform/chromium/test_expectations.txt:

2:21 PM Changeset in webkit [73465] by andersca@apple.com

2 edits in trunk/JavaScriptCore

Fix clang++ build
https://bugs.webkit.org/show_bug.cgi?id=50645

Reviewed by Darin Adler.

Explicitly cast offset to int.

pcre/pcre_ucp_searchfuncs.cpp:

(jsc_pcre_ucp_othercase):

2:07 PM Changeset in webkit [73464] by tonikitoo@webkit.org

2 edits in trunk/LayoutTests

2010-12-06 Antonio Gomes <agomes@rim.com>

Reviewed by Martin Robinson.

Clean up fast/events/multiline-link-arrow-navigation.html
https://bugs.webkit.org/show_bug.cgi?id=50616

fast/events/multiline-link-arrow-navigation.html is setting both
WebKitEnableCaretBrowsing and -webkit-user-modify CSS property. Since
both work similarly for the purposes of this test, and the former is
not support by Mac and Windows DRTs, lets stick with using the later
only.

fast/events/multiline-link-arrow-navigation.html:

2:05 PM Changeset in webkit [73463] by andersca@apple.com

2 edits in trunk/WebKit2

fast/loader/empty-embed-src-attribute.html asserts in debug builds
https://bugs.webkit.org/show_bug.cgi?id=50643

Reviewed by Sam Weinig.

Just always ignore attempts to load requests with empty URLs.

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

2:03 PM Changeset in webkit [73462] by Simon Fraser

3 edits
2 adds in trunk

2010-12-07 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

-webkit-transition Fails on Multiple text-shadow Shadows
https://bugs.webkit.org/show_bug.cgi?id=42281

When transitioning multiple shadows, the blend function for
ShadowData dropped all but the first and last shadow because
of a failure to append to the end of the list. Fixed.

Test: transitions/multiple-text-shadow-transition.html

page/animation/AnimationBase.cpp: (WebCore::PropertyWrapperShadow::blend):

2:03 PM Changeset in webkit [73461] by Simon Fraser

3 edits
2 adds in trunk

2010-12-07 Simon Fraser <Simon Fraser>

Reviewed by Beth Dakin.

CSS animation doesn't work for border-radius
https://bugs.webkit.org/show_bug.cgi?id=48340

Include CSSPropertyBorderRadius in the list of shorthand
properties, so that the individual border-radius properties
get animated.

Test: transitions/border-radius-transition.html

page/animation/AnimationBase.cpp: (WebCore::addShorthandProperties):

2:02 PM Changeset in webkit [73460] by Simon Fraser

4 edits in trunk/LayoutTests

2010-12-07 Simon Fraser <Simon Fraser>

Reviewed by Chris Marrin.

Make use of pause API more explicit before landing fix for borer-radius animation.
https://bugs.webkit.org/show_bug.cgi?id=48340

transitions/transition-test-helpers.js: Add some constants that we can use to make the tests more readable. Handle an extra value in the expected values arrays, to tell us if we should expect a property to be animated, and therefore whether we should try to pause it.
transitions/color-transition-all.html:
transitions/zero-duration-in-list.html: Adjust to make use of the above changes.

2:01 PM Changeset in webkit [73459] by mjs@apple.com

4 edits
2 adds in trunk

2010-12-07 Maciej Stachowiak <mjs@apple.com>

Reviewed by Kent Tamura.

Implement HTML5 hidden attribute
https://bugs.webkit.org/show_bug.cgi?id=40511

fast/forms/caret-rtl.html: Fixed a non-closed comment which added an "hidden" attribute.
fast/html/hidden-attr-expected.txt: Added.
fast/html/hidden-attr.html: Added. Test static and dynamic cases of hidden attribute.

2010-12-07 Maciej Stachowiak <mjs@apple.com>

Reviewed by Kent Tamura.

Implement HTML5 hidden attribute
https://bugs.webkit.org/show_bug.cgi?id=40511

Test: fast/html/hidden-attr.html

html/HTMLElement.cpp: (WebCore::HTMLElement::mapToEntry): Pick up hidden as a global mapped attribute. (WebCore::HTMLElement::parseMappedAttribute): Map hidden attribute to display: none.

1:45 PM Changeset in webkit [73458] by kbr@google.com

15 edits
1 add in trunk

2010-12-07 Kenneth Russell <kbr@google.com>

Reviewed by David Levin.

Fix compilation of core web audio files on Windows
https://bugs.webkit.org/show_bug.cgi?id=50603

Added log2 definition to MathExtras.h on Windows platform.

wtf/MathExtras.h: (log2):

2010-12-07 Kenneth Russell <kbr@google.com>

Reviewed by David Levin.

Fix compilation of core web audio files on Windows
https://bugs.webkit.org/show_bug.cgi?id=50603

Changed a few constructs using C99 features of math.h to use
wtf/MathExtras.h instead. Changed inline definitions of a couple of
const static doubles in classes to out-of-line. Built Chrome with
web audio enabled on Windows and Mac OS X to test these changes.

No new tests since audio API is not yet implemented.

WebCore.gypi:
platform/audio/AudioResampler.cpp:
platform/audio/Biquad.cpp: (WebCore::Biquad::setLowpassParams): (WebCore::Biquad::setHighpassParams): (WebCore::Biquad::setLowShelfParams):
platform/audio/Cone.cpp: (WebCore::ConeEffect::gain):
platform/audio/EqualPowerPanner.cpp: (WebCore::EqualPowerPanner::pan):
platform/audio/FFTFrame.cpp: (WebCore::FFTFrame::interpolateFrequencyComponents): (WebCore::FFTFrame::extractAverageGroupDelay): (WebCore::FFTFrame::addConstantGroupDelay):
platform/audio/HRTFKernel.cpp:
platform/audio/HRTFPanner.cpp:
webaudio/AudioBufferSourceNode.cpp: (WebCore::AudioBufferSourceNode::readFromBufferWithGrainEnvelope):
webaudio/AudioPannerNode.cpp: (WebCore::AudioPannerNode::getAzimuthElevation):
webaudio/AudioParam.cpp: Added. (AudioParam::setValue): (AudioParam::smooth):
webaudio/AudioParam.h:
webaudio/RealtimeAnalyser.cpp:

1:39 PM Changeset in webkit [73457] by Philippe Normand

3 edits in trunk/WebCore

2010-11-25 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

[GStreamer] faster elements linking
https://bugs.webkit.org/show_bug.cgi?id=50067

Perform less checks during GStreamer elements linking if building
against GStreamer >= 0.10.30.

platform/graphics/gstreamer/GStreamerGWorld.cpp: (WebCore::GStreamerGWorld::enterFullscreen):
platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):

1:05 PM Changeset in webkit [73456] by tony@chromium.org

2 edits in trunk/WebKitTools

2010-12-07 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

[chromium] force NRWT to use DRT
https://bugs.webkit.org/show_bug.cgi?id=50359

Scripts/webkitpy/layout_tests/run_webkit_tests.py:

1:00 PM Changeset in webkit [73455] by kov@webkit.org

5 edits in trunk/WebKit/gtk

2010-12-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] clears the subresources prematurely
https://bugs.webkit.org/show_bug.cgi?id=50634

Make adding the main resource explicit, and only clear
subresources when the new load is committed, avoid clearing them
prematurely.

WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::assignIdentifierToInitialRequest): (WebKit::FrameLoaderClient::provisionalLoadStarted): (WebKit::FrameLoaderClient::prepareForDataSourceReplacement): (WebKit::postCommitFrameViewSetup):
tests/testwebdatasource.c: (notify_load_status_lifetime_cb): (test_webkit_web_data_source_lifetime): (main):
webkit/webkitprivate.h:
webkit/webkitwebview.cpp: (webkit_web_view_add_main_resource): (webkit_web_view_add_resource): (webkit_web_view_clear_resources):

12:47 PM Changeset in webkit [73454] by Philippe Normand

18 edits
3 adds in trunk

2010-12-07 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GStreamer] ::buffered() should return multiple ranges in some cases
https://bugs.webkit.org/show_bug.cgi?id=45101

Improved the ::buffered() method thanks to the new buffering query
support that landed in GStreamer 0.10.31. The method now
queries the media buffered-ranges on the pipeline and queue2
handles it if it's buffering the media to disk.

The webkitwebsrc element also gained BYTES duration query
support. This is needed in the rare cases where uridecodebin
configures its queue before the HTTP server returns the media
Content-Length.

Test: http/tests/media/video-buffered.html

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::buffered):
platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: (webkit_web_src_init): (webKitWebSrcQuery): Make webkitwebsrc handle the duration queries if it's aware of the media content-length.
platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::paintMediaSliderTrack): Fix position of the second and next buffered ranges.

LayoutTests:

Reviewed by Gustavo Noronha Silva.

[GStreamer] ::buffered() should return multiple ranges in some cases
https://bugs.webkit.org/show_bug.cgi?id=45101

New test for video.buffered attribute. The test is skipped for
ports not returning multiple timeranges for video.buffered.

http/tests/media/video-buffered-expected.txt: Added.
http/tests/media/video-buffered.html: Added.
http/tests/resources/counting-captioned.mov: Added.
http/tests/media/video-throttled-load.cgi: added Range requests/responses support.
platform/chromium/test_expectations.txt:
platform/mac-leopard/Skipped:
platform/mac-snowleopard/Skipped:
platform/mac-tiger/Skipped:
platform/mac-wk2/Skipped:
platform/mac/Skipped:
platform/qt-mac/Skipped:
platform/qt-win/Skipped:
platform/qt-wk2/Skipped:
platform/qt/Skipped:
platform/win-wk2/Skipped:
platform/win/Skipped:

11:56 AM Changeset in webkit [73453] by Simon Fraser

2 edits in trunk/WebKit

2010-12-07 Simon Fraser <Simon Fraser>

Update Xcode project for newer Xcode.

WebKit.xcodeproj/project.pbxproj:

11:04 AM Changeset in webkit [73452] by yael.aharon@nokia.com

5 edits
8 adds in trunk

Spatial navigation not Working for Map and Area Tags
https://bugs.webkit.org/show_bug.cgi?id=47142

Reviewed by Antonio Gomes.

WebCore:

Give area elements special treatment in spatial navigation algorithm by getting the
rect of the area from the associated image. Since area elements are likely to overlap
if they are not rects, or if authors are not careful, we flatten the rect of area elements.

Tests: fast/spatial-navigation/snav-imagemap-area-not-focusable.html

fast/spatial-navigation/snav-imagemap-area-without-image.html
fast/spatial-navigation/snav-imagemap-overlapped-areas.html
fast/spatial-navigation/snav-imagemap-simple.html

page/FocusController.cpp:

(WebCore::FocusController::findFocusCandidateInContainer):
(WebCore::FocusController::advanceFocusDirectionallyInContainer):
(WebCore::FocusController::advanceFocusDirectionally):

page/SpatialNavigation.cpp:

(WebCore::FocusCandidate::FocusCandidate):
(WebCore::virtualRectForDirection):
(WebCore::virtualRectForAreaElementAndDirection):

page/SpatialNavigation.h:

(WebCore::FocusCandidate::FocusCandidate):

LayoutTests:

fast/spatial-navigation/snav-imagemap-area-not-focusable-expected.txt: Added.
fast/spatial-navigation/snav-imagemap-area-not-focusable.html: Added.
fast/spatial-navigation/snav-imagemap-area-without-image-expected.txt: Added.
fast/spatial-navigation/snav-imagemap-area-without-image.html: Added.
fast/spatial-navigation/snav-imagemap-overlapped-areas-expected.txt: Added.
fast/spatial-navigation/snav-imagemap-overlapped-areas.html: Added.
fast/spatial-navigation/snav-imagemap-simple-expected.txt: Added.
fast/spatial-navigation/snav-imagemap-simple.html: Added.

10:04 AM Changeset in webkit [73451] by jberlin@webkit.org

2 edits
1 add in trunk/WebKit2

Build fix. Unreviewed.

WebKit2.pro:

Added WebDatabaseManagerQt.cpp.

WebProcess/WebCoreSupport/qt/WebDatabaseManagerQt.cpp: Added.

(WebKit::WebDatabaseManager::databaseDirectory):
Added a FIXME to implement and return an empty string.

9:52 AM Changeset in webkit [73450] by Darin Adler

4 edits in trunk

WebCore: Try to fix V8 build.

bindings/generic/BindingDOMWindow.h:

(WebCore::BindingDOMWindow::createWindow): Pass security origin.

WebKit2: Get a bit closer to making Qt WebKit2 compile again.

WebKit2.pro: Add the WebDatabaseManager source files.

Still missing: The Qt version of the databaseDirectory function.

9:27 AM Changeset in webkit [73449] by jberlin@webkit.org

4 edits
4 adds in trunk/WebKit2

WebKit2: Need to set the location of the Databases directory when the WebProcess is initialized
https://bugs.webkit.org/show_bug.cgi?id=50604

Reviewed by Darin Adler.

WebProcess/WebCoreSupport/WebDatabaseManager.cpp: Added.

(WebKit::WebDatabaseManager::shared):
(WebKit::WebDatabaseManager::WebDatabaseManager):
Initialize the DatabaseTracker with the Database directory.

WebProcess/WebCoreSupport/WebDatabaseManager.h: Added.
WebProcess/WebCoreSupport/mac/WebDatabaseManagerMac.mm: Added.

(WebKit::WebDatabaseManager::databaseDirectory):
Copied from WebKitInitializeDatabasesIfNecessary in WebKit/mac/Storage/WebDatabaseManager.mm.

WebProcess/WebCoreSupport/win/WebDatabaseManagerWin.cpp: Added.

(WebKit::WebDatabaseManager::databaseDirectory):
Copied from WebKitInitializeWebDatabasesIfNecessary in WebKit/win/WebDatabaseManager.cpp.

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):
Make sure that the Databases directory has been set by calling WebDatabaseManager::shared().

WebKit2.xcodeproj/project.pbxproj:

Add WebDatabaseManager.cpp/.h/Mac.cpp

win/WebKit2.vcproj:

Add WebDatabaseManager.cpp/.h/Win.cpp

9:14 AM Changeset in webkit [73448] by jberlin@webkit.org

2 edits in trunk/WebKit/win

Build fix. Unreviewed.

WebCoreSupport/WebContextMenuClient.cpp:

(WebContextMenuClient::searchWithGoogle):
FrameLoader::urlSelected does not take a SecurityOrigin as a parameter.

8:40 AM Changeset in webkit [73447] by Darin Adler

2 edits in trunk/WebCore

Another build fix.

loader/CrossOriginAccessControl.cpp: Added a missing include.

8:33 AM Changeset in webkit [73446] by Darin Adler

4 edits in trunk/WebCore

Try to fix build.

plugins/PluginView.cpp:

(WebCore::PluginView::start): Pass security origin.
(WebCore::PluginView::getURLNotify): Ditto.
(WebCore::PluginView::getURL): Ditto.
(WebCore::PluginView::handlePost): Ditto.

8:30 AM Changeset in webkit [73445] by Darin Adler

2 edits in trunk/WebKit/qt

Try to fix build.

Api/qwebpage.cpp:

(frameLoadRequest): Added missing parentheses.

8:23 AM Changeset in webkit [73444] by Darin Adler

29 edits in trunk

2010-12-06 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Pass security origin to make local file decision correctly
https://bugs.webkit.org/show_bug.cgi?id=48603

src/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::selectCacheWithManifest): Pass security origin.
src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchCreatePage): Ditto. (WebKit::FrameLoaderClientImpl::createFrame): Ditto.
src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::loadFrameRequest): Ditto.

2010-12-06 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Pass security origin to make local file decision correctly
https://bugs.webkit.org/show_bug.cgi?id=48603

Api/qwebpage.cpp: (frameLoadRequest): Pass security origin.

2010-12-06 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Pass security origin to make local file decision correctly
https://bugs.webkit.org/show_bug.cgi?id=48603

WebCoreSupport/WebContextMenuClient.cpp: (WebContextMenuClient::searchWithGoogle): Pass security origin.

2010-12-06 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Pass security origin to make local file decision correctly
https://bugs.webkit.org/show_bug.cgi?id=48603

WebView/WebPDFView.mm: (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Pass security origin.

2010-12-06 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Pass security origin to make local file decision correctly
https://bugs.webkit.org/show_bug.cgi?id=48603

bindings/generic/BindingDOMWindow.h: (WebCore::BindingDOMWindow::createWindow): Pass security origin. (WebCore::BindingDOMWindow::open): Ditto.
bindings/generic/BindingFrame.h: (WebCore::BindingFrame::navigateIfAllowed): Ditto.

bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation): Pass security origin. (WebCore::createWindow): Ditto. (WebCore::JSDOMWindow::open): Ditto.

bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::setLocation): Pass security origin.

dom/Document.cpp: (WebCore::Document::processHttpEquiv): Pass security origin.

inspector/InspectorController.cpp: (WebCore::InspectorController::openInInspectedWindow): Pass security origin.

loader/FrameLoader.cpp: (WebCore::FrameLoader::changeLocation): Added a security origin argument, passed through to urlSelected. (WebCore::FrameLoader::urlSelected): Replaced the resource request and frame name arguments with a frame load request arguments in one overload, and changed the other overload to pass in the current frame's document for the security origin. (WebCore::FrameLoader::loadFrameRequest): Moved the canDisplay check before the referrer computation because it no longer needs to look at the referrer. Replaced the call to canDisplay that used the target frame's security origin and the call to deprecatedCanDisplay with a single call to canDisplay that uses the requester security origin.

loader/FrameLoader.h: Updated for argument changes above.

loader/NavigationScheduler.cpp: (WebCore::ScheduledURLNavigation::ScheduledURLNavigation): Added a security origin. (WebCore::ScheduledURLNavigation::fire): Pass the security origin in to FrameLoader::changeLocation. (WebCore::ScheduledURLNavigation::securityOrigin): Added. (WebCore::ScheduledRedirect::ScheduledRedirect): Added a security origin argument. (WebCore::ScheduledLocationChange::ScheduledLocationChange): Ditto. (WebCore::ScheduledRefresh::ScheduledRefresh): Ditto. (WebCore::ScheduledRefresh::fire): Pass the security origin in to FrameLoader::changeLocation. (WebCore::ScheduledFormSubmission::fire): Include the security origin when constructing form submission. (WebCore::NavigationScheduler::scheduleRedirect): Include the security origin when creating the scheduled navigation object. (WebCore::NavigationScheduler::scheduleLocationChange): Ditto. (WebCore::NavigationScheduler::scheduleRefresh): Ditto.

loader/NavigationScheduler.h: Added the security origin argument to scheduleLocationChange.

loader/SubframeLoader.cpp: (WebCore::SubframeLoader::loadOrRedirectSubframe): Pass in the security origin when calling scheduleLocationChange.
loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::selectCache): Ditto.

page/ContextMenuController.cpp: (WebCore::openNewWindow): Pass in the security origin. (WebCore::ContextMenuController::contextMenuItemSelected): Ditto.

page/FrameLoadRequest.h: Added a security origin called the requester to all FrameLoadRequest objects.

page/XSSAuditor.cpp: (WebCore::XSSAuditor::findInRequest): Added the security origin.

2010-12-06 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Pass security origin to make local file decision correctly
https://bugs.webkit.org/show_bug.cgi?id=48603

WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::loadURL): Pass security origin.
WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchCreatePage): Ditto.

8:13 AM Changeset in webkit [73443] by kov@webkit.org

1 edit
1 add in trunk/WebKit/gtk/po

2010-12-07 Chyangwoo Ryu <cwryu@debian.org>

Reviewed by Gustavo Noronha.

Korean message translation
https://bugs.webkit.org/show_bug.cgi?id=42465

kr.po: Added.

7:54 AM Changeset in webkit [73442] by kov@webkit.org

2 edits in trunk/WebKit/gtk

2010-12-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] testwebdatasource - unreachable test is broken
https://bugs.webkit.org/show_bug.cgi?id=50629

Fix, and disable testwebdatasource's unreachable test (it is not
passing now that it actually tests what it should). This also
fixes the wait timer to actually work as expected.

tests/testwebdatasource.c: (notify_load_status_unreachable_cb): (notify_load_status_cb): (test_webkit_web_data_source):

7:20 AM Changeset in webkit [73441] by yurys@chromium.org

2 edits in trunk/WebCore

2010-12-07 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: avoid initializing Context on when creating attaching listener to ScriptDebugServer
https://bugs.webkit.org/show_bug.cgi?id=50627

bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::addListener): don't try to collect already parsed scripts if context has not been initialized yet.

6:24 AM Changeset in webkit [73440] by yurys@chromium.org

4 edits in trunk/LayoutTests

2010-12-07 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: switch http/tests/inspector/console-resource-errors.html to inspector-tests2
https://bugs.webkit.org/show_bug.cgi?id=50551

We need to be sure that front-end has already opened by the time the messages are
recorded in console because the data we collect for errors may differ depending
on whether the front-end is open.

http/tests/inspector/console-resource-errors-expected.txt:
http/tests/inspector/console-resource-errors.html:
http/tests/inspector/console-tests2.js: (initialize_ConsoleTest.InspectorTest.dumpConsoleMessagesWithClasses):

5:58 AM Changeset in webkit [73439] by Csaba Osztrogonác

1 edit
6 adds in trunk/LayoutTests

Unreviewed.

Add Qt specific expected results for tests introduced in r73385 and r73398.
Compared to Mac png files and Mac expected files.

platform/qt/fast/html/marquee-scrollamount-expected.checksum: Added.
platform/qt/fast/html/marquee-scrollamount-expected.png: Added.
platform/qt/fast/html/marquee-scrollamount-expected.txt: Added.
platform/qt/fast/overflow/overflow-rtl-vertical-expected.checksum: Added.
platform/qt/fast/overflow/overflow-rtl-vertical-expected.png: Added.
platform/qt/fast/overflow/overflow-rtl-vertical-expected.txt: Added.

5:29 AM Changeset in webkit [73438] by Csaba Osztrogonác

6 edits
2 deletes in trunk

Unreviewed. Rolling out r73421, because it made transitions/color-transition-all.html flakey.

WebCore:

page/animation/AnimationBase.cpp:

(WebCore::addShorthandProperties):

LayoutTests:

transitions/border-radius-transition-expected.txt: Removed.
transitions/border-radius-transition.html: Removed.
transitions/color-transition-all.html:
transitions/transition-test-helpers.js:

(expected):

transitions/zero-duration-in-list.html:

5:19 AM Changeset in webkit [73437] by pfeldman@chromium.org

1 edit in branches/chromium/597/WebCore/inspector/InspectorStyleSheet.cpp

Merge 72811 - 2010-11-29 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: crash upon inspecting user style sheet.
https://bugs.webkit.org/show_bug.cgi?id=50109

inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::resourceStyleSheetText):

BUG=64483
TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/5575009

4:40 AM Changeset in webkit [73436] by Martin Robinson

37 edits in trunk

2010-12-07 Martin Robinson <mrobinson@igalia.com>

Unreviewed, rolling out r73392.
http://trac.webkit.org/changeset/73392
https://bugs.webkit.org/show_bug.cgi?id=50489

This commit caused crashes on the GTK+ bots

bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):
dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::close): (WebCore::Document::lastModified): (WebCore::Document::finishedParsing): (WebCore::Document::initSecurityContext): (WebCore::Document::updateURLForPushOrReplaceState):
dom/Document.h:
dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet):
dom/ScriptElement.cpp: (WebCore::ScriptElement::scriptCharset):
html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
html/MediaDocument.cpp: (WebCore::MediaDocument::replaceMediaElementTimerFired):
html/PluginDocument.cpp: (WebCore::PluginDocumentParser::createDocumentStructure):
loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::finishedLoading): (WebCore::DocumentLoader::commitData): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::setFrame):
loader/DocumentLoader.h:
loader/DocumentWriter.cpp: (WebCore::DocumentWriter::begin):
loader/DocumentWriter.h:
loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::init): (WebCore::FrameLoader::clear): (WebCore::FrameLoader::receivedFirstData): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::open): (WebCore::FrameLoader::finishedLoadingDocument): (WebCore::FrameLoader::addExtraFieldsToRequest):
loader/FrameLoader.h: (WebCore::FrameLoader::writer):
loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::requestPreload):
platform/network/FormDataBuilder.cpp: (WebCore::FormDataBuilder::encodingFromAcceptCharset):
svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):

2010-12-07 Martin Robinson <mrobinson@igalia.com>

Unreviewed, rolling out r73392.
http://trac.webkit.org/changeset/73392
https://bugs.webkit.org/show_bug.cgi?id=50489

This commit caused crashes on the GTK+ bots

src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::finishedLoading):
src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::encoding): (WebKit::WebFrameImpl::loadJavaScriptURL):
src/WebPageSerializerImpl.cpp: (WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag): (WebKit::WebPageSerializerImpl::serialize):
src/WebSearchableFormData.cpp: (WebCore::GetFormEncoding):
src/WebViewImpl.cpp: (WebKit::WebViewImpl::pageEncoding):

2010-12-07 Martin Robinson <mrobinson@igalia.com>

Unreviewed, rolling out r73392.
http://trac.webkit.org/changeset/73392
https://bugs.webkit.org/show_bug.cgi?id=50489

This commit caused crashes on the GTK+ bots

WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::finishedLoading):
webkit/webkitwebview.cpp: (webkit_web_view_get_encoding):

2010-12-07 Martin Robinson <mrobinson@igalia.com>

Unreviewed, rolling out r73392.
http://trac.webkit.org/changeset/73392
https://bugs.webkit.org/show_bug.cgi?id=50489

This commit caused crashes on the GTK+ bots

WebView/WebFrame.mm: (-[WebFrame _canProvideDocumentSource]):

2010-12-07 Martin Robinson <mrobinson@igalia.com>

Unreviewed, rolling out r73392.
http://trac.webkit.org/changeset/73392
https://bugs.webkit.org/show_bug.cgi?id=50489

This commit caused crashes on the GTK+ bots

Api/qwebframe.cpp: (QWebFrame::setUrl):
WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::finishedLoading):

2010-12-07 Martin Robinson <mrobinson@igalia.com>

Unreviewed, rolling out r73392.
http://trac.webkit.org/changeset/73392
https://bugs.webkit.org/show_bug.cgi?id=50489

This commit caused crashes on the GTK+ bots

WebCoreSupport/FrameLoaderClientWinCE.cpp: (WebKit::FrameLoaderClientWinCE::finishedLoading):

2010-12-07 Martin Robinson <mrobinson@igalia.com>

Unreviewed, rolling out r73392.
http://trac.webkit.org/changeset/73392
https://bugs.webkit.org/show_bug.cgi?id=50489

This commit caused crashes on the GTK+ bots

WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::finishedLoading):

4:11 AM Changeset in webkit [73435] by Martin Robinson

53 edits in trunk/LayoutTests

2010-12-07 Martin Robinson <mrobinson@igalia.com>

Rebaseline GTK+ results after r73385.

platform/gtk/css1/box_properties/margin-expected.txt:
platform/gtk/css1/box_properties/margin_right-expected.txt:
platform/gtk/css1/classification/white_space-expected.txt:
platform/gtk/css1/color_and_background/background_attachment-expected.txt:
platform/gtk/css1/color_and_background/background_repeat-expected.txt:
platform/gtk/editing/deleting/delete-line-end-ws-001-expected.txt:
platform/gtk/editing/deleting/delete-line-end-ws-002-expected.txt:
platform/gtk/fast/backgrounds/repeat/negative-offset-repeat-expected.txt:
platform/gtk/fast/backgrounds/size/backgroundSize15-expected.txt:
platform/gtk/fast/block/margin-collapse/block-inside-inline/004-expected.txt:
platform/gtk/fast/block/margin-collapse/block-inside-inline/005-expected.txt:
platform/gtk/fast/blockflow/block-level-images-expected.txt:
platform/gtk/fast/blockflow/border-radius-clipping-vertical-lr-expected.txt:
platform/gtk/fast/blockflow/box-shadow-vertical-lr-expected.txt:
platform/gtk/fast/blockflow/box-shadow-vertical-rl-expected.txt:
platform/gtk/fast/blockflow/floats-in-block-layout-expected.txt:
platform/gtk/fast/borders/fieldsetBorderRadius-expected.txt:
platform/gtk/fast/box-shadow/basic-shadows-expected.txt:
platform/gtk/fast/css/negative-leading-expected.txt:
platform/gtk/fast/forms/basic-textareas-expected.txt:
platform/gtk/fast/forms/file-input-direction-expected.txt:
platform/gtk/fast/forms/floating-textfield-relayout-expected.txt:
platform/gtk/fast/frames/flattening/frameset-flattening-advanced-expected.txt:
platform/gtk/fast/frames/flattening/frameset-flattening-grid-expected.txt:
platform/gtk/fast/frames/flattening/frameset-flattening-simple-expected.txt:
platform/gtk/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt:
platform/gtk/fast/frames/flattening/frameset-flattening-subframesets-expected.txt:
platform/gtk/fast/frames/frame-scrolling-attribute-expected.txt:
platform/gtk/fast/frames/iframe-scrolling-attribute-expected.txt:
platform/gtk/fast/frames/inline-object-inside-frameset-expected.txt:
platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
platform/gtk/fast/images/gif-large-checkerboard-expected.txt:
platform/gtk/fast/lists/001-vertical-expected.txt:
platform/gtk/fast/lists/003-vertical-expected.txt:
platform/gtk/fast/multicol/float-multicol-expected.txt:
platform/gtk/fast/multicol/float-paginate-complex-expected.txt:
platform/gtk/fast/multicol/float-paginate-expected.txt:
platform/gtk/fast/multicol/layers-in-multicol-expected.txt:
platform/gtk/fast/multicol/paginate-block-replaced-expected.txt:
platform/gtk/fast/multicol/positioned-with-constrained-height-expected.txt:
platform/gtk/fast/multicol/span/anonymous-style-inheritance-expected.txt:
platform/gtk/fast/multicol/table-vertical-align-expected.txt:
platform/gtk/fast/table/border-collapsing/004-vertical-expected.txt:
platform/gtk/fast/table/colspanMinWidth-vertical-expected.txt:
platform/gtk/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt:
platform/gtk/fast/table/height-percent-test-vertical-expected.txt:
platform/gtk/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt:
platform/gtk/svg/custom/text-xy-updates-SVGList-expected.txt:
platform/gtk/svg/custom/text-zoom-expected.txt:
platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.txt:
platform/gtk/svg/text/foreignObject-text-clipping-bug-expected.txt:
platform/gtk/transforms/svg-vs-css-expected.txt:

3:11 AM Changeset in webkit [73434] by Patrick Gansterer

4 edits
1 delete in trunk

2010-12-07 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[CMake] Remove WebKitGenerators
https://bugs.webkit.org/show_bug.cgi?id=50445

CMakeLists.txt:
cmake/WebKitGenerators.cmake: Removed.

2010-12-07 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[CMake] Remove WebKitGenerators
https://bugs.webkit.org/show_bug.cgi?id=50445

Move remaining logic into main CMakeLists.txt.

CMakeLists.txt:

3:11 AM Changeset in webkit [73433] by Antti Koivisto

4 edits in trunk/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=50412
http://www.wunderground.com/US/CA/Hayward.html causes big memory spike during page loading

Reviewed by Gavin Barraclough.

Creating a substring caused the original string be flattened if it was in the rope form. This could use
significant amount of memory by reducing buffer sharing between strings.

Add a rope specific substring function that constructs the substring by reusing the rope fibers
instead of flattening the rope.

No change observed in SunSpider.

runtime/JSString.cpp:

(JSC::JSString::substringFromRope):

runtime/JSString.h:

(JSC::jsSubstring):

runtime/StringPrototype.cpp:

(JSC::stringProtoFuncSubstr):
(JSC::stringProtoFuncSubstring):

2:44 AM Changeset in webkit [73432] by jschuh@chromium.org

7 edits
2 adds in trunk

2010-12-07 Justin Schuh <jschuh@chromium.org>

Reviewed by Nikolas Zimmermann.

Clear old SVG cursor entry before adding a new one
https://bugs.webkit.org/show_bug.cgi?id=50549

Test: svg/css/cursor-replace.svg

css/CSSCursorImageValue.cpp: (WebCore::CSSCursorImageValue::~CSSCursorImageValue):
svg/SVGCursorElement.cpp: (WebCore::SVGCursorElement::~SVGCursorElement): (WebCore::SVGCursorElement::removeClient): (WebCore::SVGCursorElement::removeReferencedElement):
svg/SVGCursorElement.h:
svg/SVGElement.cpp: (WebCore::SVGElement::setCursorElement): (WebCore::SVGElement::cursorElementRemoved): (WebCore::SVGElement::setCursorImageValue): (WebCore::SVGElement::cursorImageElementRemoved):
svg/SVGElement.h:

2010-12-07 Justin Schuh <jschuh@chromium.org>

Reviewed by Nikolas Zimmermann.

Clear old SVG cursor entry before adding a new one
https://bugs.webkit.org/show_bug.cgi?id=50549

svg/css/cursor-replace-expected.txt: Added.
svg/css/cursor-replace.svg: Added.

2:15 AM Changeset in webkit [73431] by yutak@chromium.org

2 edits
13 adds in trunk/LayoutTests

2010-12-07 Yuta Kitamura <yutak@chromium.org>

Unreviewed.

Add Chromium-specific expected results for two tests.

platform/chromium-linux/css2.1/t040105-import-10-b-expected.checksum: Added.
platform/chromium-linux/css2.1/t040105-import-10-b-expected.png: Added.
platform/chromium-linux/media/controls-without-preload-expected.checksum: Added.
platform/chromium-linux/media/controls-without-preload-expected.png: Added.
platform/chromium-mac/media/controls-without-preload-expected.checksum: Added.
platform/chromium-mac/media/controls-without-preload-expected.png: Added.
platform/chromium-mac/media/controls-without-preload-expected.txt: Added.
platform/chromium-win/css2.1/t040105-import-10-b-expected.checksum: Added.
platform/chromium-win/css2.1/t040105-import-10-b-expected.png: Added.
platform/chromium-win/css2.1/t040105-import-10-b-expected.txt: Added.
platform/chromium-win/media/controls-without-preload-expected.checksum: Added.
platform/chromium-win/media/controls-without-preload-expected.png: Added.
platform/chromium-win/media/controls-without-preload-expected.txt: Added.
platform/chromium/test_expectations.txt:

1:40 AM Changeset in webkit [73430] by tkent@chromium.org

41 edits
2 copies
3 adds in trunk

2010-12-07 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.

Let HTMLObjectElement be a form associated element
https://bugs.webkit.org/show_bug.cgi?id=48821

Introduces FormAssociatedElement class which would be a super class
of form assocated elements. Some of member functions and variables of
HTMLFormControlElement are migrated into this class.
Following the HTML5 spec, HTMLFormControlElement class and
HTMLObjectElement class are subclasses of it for now.

Test: fast/forms/form-collection-elements-order.html

Android.mk: Added FormAssociatedElement.cpp
CMakeLists.txt: Ditto.
GNUmakefile.am: Added FormAssociatedElement.{cpp,h}
WebCore.exp.in: Added the symbol for toHTMLElement(FormAssociatedElement*)
WebCore.gypi: Added FormAssociatedElement.{cpp,h}
WebCore.pro: Ditto.
WebCore.vcproj/WebCore.vcproj: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.
dom/CheckedRadioButtons.h: Fixed class forward declaration order.
dom/Document.cpp: (WebCore::Document::registerFormElementWithFormAttribute): Modified to use FormAssociatedElement instead of HTMLFormControlElement (WebCore::Document::unregisterFormElementWithFormAttribute): Ditto. (WebCore::Document::resetFormElementsOwner):
dom/Document.h: Ditto.
html/DOMFormData.cpp: Ditto. (WebCore::DOMFormData::DOMFormData):
html/FormAssociatedElement.cpp: Copied and renamed from WebCore/html/HTMLFormControlElement.cpp. (WebCore::FormAssociatedElement::FormAssociatedElement): (WebCore::FormAssociatedElement::~FormAssociatedElement): (WebCore::FormAssociatedElement::validity): (WebCore::FormAssociatedElement::insertedIntoTree): (WebCore::FormAssociatedElement::removedFromTree): (WebCore::FormAssociatedElement::removeFromForm): (WebCore::FormAssociatedElement::resetFormOwner): (WebCore::FormAssociatedElement::formAttributeChanged): (WebCore::toHTMLElement):
html/FormAssociatedElement.h: Ditto. (WebCore::FormAssociatedElement::ref): (WebCore::FormAssociatedElement::deref): (WebCore::FormAssociatedElement::formDestroyed): (WebCore::FormAssociatedElement::setForm):
html/HTMLElement.h: Changed the access level of findFormAncestor().
html/HTMLFormCollection.cpp: (WebCore::HTMLFormCollection::item): Modified to use FormAssociatedElement instead of HTMLFormControlElement. (WebCore::HTMLFormCollection::getNamedFormItem): Ditto. (WebCore::HTMLFormCollection::updateNameCache): Ditto.
html/HTMLFormControlElement.cpp: Modified regarding with the change of class hierarchy. (WebCore::HTMLFormControlElement::HTMLFormControlElement): (WebCore::HTMLFormControlElement::~HTMLFormControlElement): (WebCore::HTMLFormControlElement::insertedIntoTree): (WebCore::HTMLFormControlElement::removedFromTree): (WebCore::HTMLFormControlElement::supportsFocus): (WebCore::HTMLFormControlElement::checkValidity): (WebCore::HTMLFormControlElement::virtualForm): (WebCore::HTMLFormControlElement::isDefaultButtonForForm): (WebCore::HTMLFormControlElement::attributeChanged):
html/HTMLFormControlElement.h: Ditto. (WebCore::HTMLFormControlElement::form): (WebCore::HTMLFormControlElement::disabled): (WebCore::HTMLFormControlElement::type): (WebCore::HTMLFormControlElement::refFormAssociatedElement): (WebCore::HTMLFormControlElement::derefFormAssociatedElement):
html/HTMLFormElement.cpp: Modified to use FormAssociatedElement instead of HTMLFormControlElement. (WebCore::HTMLFormElement::submitImplicitly): (WebCore::HTMLFormElement::validateInteractively): (WebCore::HTMLFormElement::submit): (WebCore::HTMLFormElement::reset): (WebCore::HTMLFormElement::formElementIndexWithFormAttribute): (WebCore::HTMLFormElement::formElementIndex): (WebCore::HTMLFormElement::registerFormElement): (WebCore::HTMLFormElement::removeFormElement): (WebCore::HTMLFormElement::defaultButton): (WebCore::HTMLFormElement::checkValidity): (WebCore::HTMLFormElement::collectUnhandledInvalidControls): (WebCore::HTMLFormElement::documentDidBecomeActive):
html/HTMLFormElement.h: Ditto. (WebCore::HTMLFormElement::associatedElements):
html/HTMLInputElement.cpp: Ditto. (WebCore::HTMLInputElement::updateCheckedRadioButtons):
html/HTMLObjectElement.cpp: Modified regarding with the change of class hierarchy. (WebCore::HTMLObjectElement::HTMLObjectElement): (WebCore::HTMLObjectElement::~HTMLObjectElement): (WebCore::HTMLObjectElement::create): (WebCore::HTMLObjectElement::attributeChanged): (WebCore::HTMLObjectElement::insertedIntoTree): (WebCore::HTMLObjectElement::removedFromTree): (WebCore::HTMLObjectElement::appendFormData): (WebCore::HTMLObjectElement::formControlName):
html/HTMLObjectElement.h: Ditto. (WebCore::HTMLObjectElement::form): (WebCore::HTMLObjectElement::isFormControlElement): (WebCore::HTMLObjectElement::isEnumeratable): (WebCore::HTMLObjectElement::refFormAssociatedElement): (WebCore::HTMLObjectElement::derefFormAssociatedElement):
html/HTMLTagNames.in: Added constructorNeedsFormElement to object tag.
html/ValidationMessage.cpp: Modified to use FormAssociatedElement instead of HTMLFormControlElement. (WebCore::ValidationMessage::ValidationMessage): (WebCore::ValidationMessage::create):
html/ValidationMessage.h: Ditto.
html/ValidityState.cpp: Ditto. (WebCore::ValidityState::validationMessage): (WebCore::ValidityState::setCustomErrorMessage): (WebCore::ValidityState::valueMissing): (WebCore::ValidityState::typeMismatch): (WebCore::ValidityState::patternMismatch): (WebCore::ValidityState::tooLong): (WebCore::ValidityState::rangeUnderflow): (WebCore::ValidityState::rangeOverflow): (WebCore::ValidityState::stepMismatch):
html/ValidityState.h: Ditto. (WebCore::ValidityState::create): (WebCore::ValidityState::ValidityState):
loader/FormSubmission.cpp: Ditto. (WebCore::FormSubmission::create):

2010-12-07 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.

Let HTMLObjectElement be a form associated element
https://bugs.webkit.org/show_bug.cgi?id=48821

Modified to use FormAssociatedElement instead of HTMLFormControlElement.

src/WebFormElement.cpp: (WebKit::WebFormElement::getFormControlElements): Modified to use FormAssociatedElement instead of HTMLFormControlElement.
src/WebPasswordFormUtils.cpp: (WebKit::findPasswordFormFields): Ditto.
src/WebSearchableFormData.cpp: (WebCore::GetButtonToActivate): Ditto. (WebCore::HasSuitableTextElement): Ditto.

2010-12-07 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.

Let HTMLObjectElement be a form associated element
https://bugs.webkit.org/show_bug.cgi?id=48821

Modified to use FormAssociatedElement instead of HTMLFormControlElement.

WebFrame.cpp: (WebFrame::elementWithName): Modified to use FormAssociatedElement instead of HTMLFormControlElement. (WebFrame::controlsInForm): Ditto.

2010-12-07 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.

Let HTMLObjectElement be a form associated element
https://bugs.webkit.org/show_bug.cgi?id=48821

Modified to use FormAssociatedElement instead of HTMLFormControlElement.

WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation elementWithName:inForm:]): Modified to use FormAssociatedElement instead of HTMLFormControlElement. (-[WebHTMLRepresentation controlsInForm:]): Ditto.

2010-12-07 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.

Let HTMLObjectElement be a form associated element
https://bugs.webkit.org/show_bug.cgi?id=48821

Adds a test to ensure the order of form.elements attribute.
Updates two tests to check whether object elements are handled
correctly in form.elements attribute.

fast/forms/form-attribute-expected.txt: Updated.
fast/forms/form-collection-elements-order-expected.txt: Added.
fast/forms/form-collection-elements-order.html: Added.
fast/forms/script-tests/form-attribute.js: Updated.
fast/forms/script-tests/form-collection-elements-order.js: Added. (checkOrder):
fast/forms/script-tests/form-collection-elements.js: Updated.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed