Timeline
Dec 9, 2010:
- 11:48 PM Changeset in webkit [73690] by
-
- 16 edits5 copies in trunk
2010-12-09 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Ojan Vafai.
Make DOM Mutation Events Asynchronous
https://bugs.webkit.org/show_bug.cgi?id=46936
Implemented DOM mutations events as scoped events. A scoped event is an event whose
dispatch is done via ScopedEventQueue. The behavior of the queue is controlled by
EventQueueScope objects (RAII idiom), which increments and decrements the scoping level
on its constructor and destructor respectively.
When the scoping level is 0 (initial level), scoped events are dispatched as soon as
they are enqueued and act like synchronous events. When the scoping level is greater than 0,
however, events are queued in ScopedEventQueue and their dispatches are delayed until
the scoping level goes back to 0 (by the destruction of EventQueueScope).
DOMSubtreeModified, DOMNodeInserted, DOMNodeRemoved, DOMNodeRemovedFromDocument,
DOMNodeInsertedIntoDocument, DOMFocusIn, DOMFocusOut, focusin, and focusout are treated as
scoped events, and a scope object is instantiated in EditCommand::apply to delay dispatches
of the events until the completion of each call of EditCommand::doApply.
Test: fast/events/mutation/execCommands.html
- Android.mk: Added ScopedEventQueue.cpp.
- CMakeLists.txt: Ditto.
- WebCore.pro: Ditto.
- GNUmakefile.am: Added ScopedEventQueue.cpp and ScopedEventQueue.h.
- WebCore.gypi: Ditto.
- WebCore.vcproj/project.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- dom/ContainerNode.cpp: (WebCore::dispatchChildInsertionEvents): Calls dispatchScopedEvent. (WebCore::dispatchChildRemovalEvents): Ditto.
- dom/DOMAllInOne.cpp: Added ScopedEventQueue.cpp.
- dom/Element.cpp: (WebCore::Element::dispatchAttrRemovalEvent): Ditto. (WebCore::Element::dispatchAttrAdditionEvent): Ditto.
- dom/Node.cpp: (WebCore::Node::dispatchScopedEvent): Added. (WebCore::Node::dispatchSubtreeModifiedEvent): Calls dispatchScopedEvent.
- dom/Node.h:
- dom/ScopedEventQueue.cpp: Added. (WebCore::ScopedEventQueue::initialize): Added. (WebCore::ScopedEventQueue::enqueueEvent): Added. (WebCore::ScopedEventQueue::dispatchAllEvents): Added. (WebCore::ScopedEventQueue::dispatchEvent): Added. (WebCore::ScopedEventQueue::instance): Added. (WebCore::ScopedEventQueue::incrementScopingLevel): Added. (WebCore::ScopedEventQueue::decrementScopingLevel): Added.
- dom/ScopedEventQueue.h: Added. (WebCore::ScopedEventQueue::~ScopedEventQueue): Added. (WebCore::ScopedEventQueue::ScopedEventQueue): Added. (WebCore::EventQueueScope::EventQueueScope): Added. (WebCore::EventQueueScope::~EventQueueScope): Added.
- editing/EditCommand.cpp: (WebCore::EditCommand::apply): Instantiates EventQueueScope.
2010-12-09 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Ojan Vafai.
Make DOM Mutation Events Asynchronous
https://bugs.webkit.org/show_bug.cgi?id=46936
Added a test to ensure no DOM mutation events are fired while execCommand is in progress.
- fast/events/crash-on-mutate-during-drop.html: DOMNodeInserted is fired after BR is detached from the document, and can't be observed. Modify the DOM when text node is inserted.
- fast/events/scoped: Added.
- fast/events/scoped/editing-commands-expected.txt: Added.
- fast/events/scoped/editing-commands.html: Added.
- 11:15 PM Changeset in webkit [73689] by
-
- 16 edits3 deletes in trunk
2010-12-09 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r73684.
http://trac.webkit.org/changeset/73684
https://bugs.webkit.org/show_bug.cgi?id=50801
"missing bug number" (Requested by rniwa on #webkit).
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/ContainerNode.cpp: (WebCore::dispatchChildInsertionEvents): (WebCore::dispatchChildRemovalEvents):
- dom/DOMAllInOne.cpp:
- dom/Element.cpp: (WebCore::Element::dispatchAttrRemovalEvent): (WebCore::Element::dispatchAttrAdditionEvent):
- dom/Node.cpp: (WebCore::Node::dispatchSubtreeModifiedEvent): (WebCore::Node::dispatchUIEvent):
- dom/Node.h:
- dom/ScopedEventQueue.cpp: Removed.
- dom/ScopedEventQueue.h: Removed.
- editing/EditCommand.cpp: (WebCore::EditCommand::apply):
2010-12-09 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r73684.
http://trac.webkit.org/changeset/73684
https://bugs.webkit.org/show_bug.cgi?id=50801
"missing bug number" (Requested by rniwa on #webkit).
- fast/events/crash-on-mutate-during-drop.html:
- fast/events/scoped/editing-commands-expected.txt: Removed.
- fast/events/scoped/editing-commands.html: Removed.
- 10:45 PM Changeset in webkit [73688] by
-
- 4 edits1 add in trunk/WebKitTools
2010-12-09 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Teach webkit-patch how to search bugzilla
https://bugs.webkit.org/show_bug.cgi?id=50500
This is a step towards teaching webkitpy how to file
new bugs for flaky tests and update them when new flakes occur.
- Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
- Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
- Scripts/webkitpy/tool/commands/init.py:
- Scripts/webkitpy/tool/commands/bugsearch.py: Added.
- 10:21 PM Changeset in webkit [73687] by
-
- 2 edits in trunk/WebCore
2010-12-09 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] enable orientation flag when QtMobility available
https://bugs.webkit.org/show_bug.cgi?id=50781
When QtMobility available, enable orientation flag by default.
- features.pri:
- 9:59 PM Changeset in webkit [73686] by
-
- 14 edits3 adds in trunk
2010-12-09 Kenichi Ishibashi <bashi@google.com>
Reviewed by Kent Tamura.
Improve validation API support of <object> and <keygen>
https://bugs.webkit.org/show_bug.cgi?id=50663
Adds tests for validation API for <object>.
Tests for <output> and <keygen> are also added.
- fast/dom/plugin-attributes-enumeration-expected.txt: Updated.
- fast/forms/ValidityState-001-expected.txt: Updated.
- fast/forms/ValidityState-001.html: Updated.
- fast/forms/checkValidity-001-expected.txt: Updated.
- fast/forms/checkValidity-001.html: Updated.
- fast/forms/script-tests/setCustomValidity-existence.js: Added.
- fast/forms/script-tests/validationMessage.js: Updated.
- fast/forms/script-tests/willvalidate.js: Updated.
- fast/forms/setCustomValidity-existence-expected.txt: Added.
- fast/forms/setCustomValidity-existence.html: Added.
- fast/forms/validationMessage-expected.txt: Updated.
- fast/forms/willvalidate-expected.txt: Updated.
2010-12-09 Kenichi Ishibashi <bashi@google.com>
Reviewed by Kent Tamura.
Improve validation API support of <object> and <keygen>
https://bugs.webkit.org/show_bug.cgi?id=50663
Adds validation API to HTMLObjectElement class.
Makes HTMLKeygenElement::willValidate() return false.
Test: fast/forms/setCustomValidity-existence.html
- html/HTMLKeygenElement.h: (WebCore::HTMLKeygenElement::willValidate): Added.
- html/HTMLObjectElement.h: (WebCore::HTMLObjectElement::validationMessage): Added. (WebCore::HTMLObjectElement::checkValidity): Added. (WebCore::HTMLObjectElement::setCustomValidity): Added.
- html/HTMLObjectElement.idl: Added validation API properties.
- 9:44 PM Changeset in webkit [73685] by
-
- 3 edits2 adds in trunk
2010-12-09 Sadrul Habib Chowdhury <sadrul@chromium.org>
Reviewed by Kent Tamura.
Make sure a non-zero value is used for tile-width to avoid a crash
https://bugs.webkit.org/show_bug.cgi?id=50341
The scaled tile width can be very small at times (e.g. with 'style: font 1
required'). So use a minimum width of 1 instead of using 0 (which leads to a
crash).
- fast/dom/HTMLProgressElement/progress-element-with-style-crash.html: Added.
- fast/dom/HTMLProgressElement/progress-element-with-style-crash-expected.txt: Added.
2010-12-09 Sadrul Habib Chowdhury <sadrul@chromium.org>
Reviewed by Kent Tamura.
Make sure a non-zero value is used for tile-width to avoid a crash
https://bugs.webkit.org/show_bug.cgi?id=50341
The scaled tile width can be very small at times (e.g. with 'style: font 1
required'). So use a minimum width of 1 instead of using 0 (which leads to a
crash).
Tests: fast/dom/HTMLProgressElement/progress-element-with-style-crash.html
- rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::paintProgressBar):
- 9:08 PM Changeset in webkit [73684] by
-
- 16 edits5 adds in trunk
2010-12-09 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Ojan Vafai.
Implemented DOM mutations events as scoped events. A scoped event is an event whose
dispatch is done via ScopedEventQueue. The behavior of the queue is controlled by
EventQueueScope objects (RAII idiom), which increments and decrements the scoping level
on its constructor and destructor respectively.
When the scoping level is 0 (initial level), scoped events are dispatched as soon as
they are enqueued and act like synchronous events. When the scoping level is greater than 0,
however, events are queued in ScopedEventQueue and their dispatches are delayed until
the scoping level goes back to 0 (by the destruction of EventQueueScope).
DOMSubtreeModified, DOMNodeInserted, DOMNodeRemoved, DOMNodeRemovedFromDocument,
DOMNodeInsertedIntoDocument, DOMFocusIn, DOMFocusOut, focusin, and focusout are treated as
scoped events, and a scope object is instantiated in EditCommand::apply to delay dispatches
of the events until the completion of each call of EditCommand::doApply.
Test: fast/events/mutation/execCommands.html
- Android.mk: Added ScopedEventQueue.cpp.
- CMakeLists.txt: Ditto.
- WebCore.pro: Ditto.
- GNUmakefile.am: Added ScopedEventQueue.cpp and ScopedEventQueue.h.
- WebCore.gypi: Ditto.
- WebCore.vcproj/project.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- dom/ContainerNode.cpp: (WebCore::dispatchChildInsertionEvents): Calls dispatchScopedEvent. (WebCore::dispatchChildRemovalEvents): Ditto.
- dom/DOMAllInOne.cpp: Added ScopedEventQueue.cpp.
- dom/Element.cpp: (WebCore::Element::dispatchAttrRemovalEvent): Ditto. (WebCore::Element::dispatchAttrAdditionEvent): Ditto.
- dom/Node.cpp: (WebCore::Node::dispatchScopedEvent): Added. (WebCore::Node::dispatchSubtreeModifiedEvent): Calls dispatchScopedEvent.
- dom/Node.h:
- dom/ScopedEventQueue.cpp: Added. (WebCore::ScopedEventQueue::initialize): Added. (WebCore::ScopedEventQueue::enqueueEvent): Added. (WebCore::ScopedEventQueue::dispatchAllEvents): Added. (WebCore::ScopedEventQueue::dispatchEvent): Added. (WebCore::ScopedEventQueue::instance): Added. (WebCore::ScopedEventQueue::incrementScopingLevel): Added. (WebCore::ScopedEventQueue::decrementScopingLevel): Added.
- dom/ScopedEventQueue.h: Added. (WebCore::ScopedEventQueue::~ScopedEventQueue): Added. (WebCore::ScopedEventQueue::ScopedEventQueue): Added. (WebCore::EventQueueScope::EventQueueScope): Added. (WebCore::EventQueueScope::~EventQueueScope): Added.
- editing/EditCommand.cpp: (WebCore::EditCommand::apply): Instantiates EventQueueScope.
2010-12-09 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Ojan Vafai.
Added a test to ensure no DOM mutation events are fired while execCommand is in progress.
- fast/events/crash-on-mutate-during-drop.html: DOMNodeInserted is fired after BR is detached from the document, and can't be observed. Modify the DOM when text node is inserted.
- fast/events/mutation: Added.
- fast/events/mutation/execCommands.html: Added.
- 8:54 PM Changeset in webkit [73683] by
-
- 2 edits in trunk/WebCore
Fix scrolling with mouse wheel in WebKit2 views. Once
we coalesce wheel events, we can re-enable this.
Reviewed by Gavin Barraclough.
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::scroll):
- 8:53 PM Changeset in webkit [73682] by
-
- 4 edits in trunk/WebKitTools
2010-12-09 Adam Barth <abarth@webkit.org>
Reviewed by Ojan Vafai.
commit-queue errors out due to local commits
https://bugs.webkit.org/show_bug.cgi?id=50766
We seem to be tripping over having local commits in the working copy a
lot recently. I don't quite fully understand what the issue is, but
this patch attempts to solve the problem by adding an explicit clean
step before processing a patch. Previously, we did the cleaning as
part of the apply-attachment step, so this might not actually fix the
problem.
- Scripts/webkitpy/tool/bot/commitqueuetask.py:
- Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- 8:43 PM Changeset in webkit [73681] by
-
- 4 edits2 adds in trunk
2010-12-09 Abhishek Arya <inferno@chromium.org>
Reviewed by James Robinson.
For details element, ensure that if we ended up being inline that we set out replaced
flag so that we are treated like an inline block.
https://bugs.webkit.org/show_bug.cgi?id=50671
Test: fast/html/details-element-render-inline-crash.html
- rendering/RenderDetails.cpp: (WebCore::RenderDetails::styleDidChange): setReplaced to true if we are set as inline.
- rendering/RenderDetails.h: function definition.
2010-12-09 Abhishek Arya <inferno@chromium.org>
Reviewed by James Robinson.
Tests that we do not crash when we set details element with children to show as inline.
https://bugs.webkit.org/show_bug.cgi?id=50671
- fast/html/details-element-render-inline-crash-expected.txt: Added.
- fast/html/details-element-render-inline-crash.html: Added.
- 8:29 PM Changeset in webkit [73680] by
-
- 2 edits in trunk/LayoutTests
2010-12-09 James Robinson <jamesr@chromium.org>
Unreviewed. Update Chromium GPU test expecations for canvas/philip.
- platform/chromium-gpu/test_expectations.txt:
- 8:06 PM Changeset in webkit [73679] by
-
- 3 edits3 adds in trunk
2010-12-09 Jasmin Lapalme <jlapalme@druide.com>
Reviewed by Alexey Proskuryakov.
Test for a faulty conversion from UTF-8 to UTF-16 in WebCore during an XSLT transformation.
https://bugs.webkit.org/show_bug.cgi?id=50708
- fast/xsl/utf8-chunks-expected.txt: Added.
- fast/xsl/utf8-chunks.xml: Added.
- fast/xsl/utf8-chunks.xsl: Added.
2010-12-09 Jasmin Lapalme <jlapalme@druide.com>
Reviewed by Alexey Proskuryakov.
Fix a faulty conversion from UTF-8 to UTF-16 in WebCore during an XSLT transformation.
https://bugs.webkit.org/show_bug.cgi?id=50708
Test: fast/xsl/utf8-chunks.xml
- xml/XSLTProcessorLibxslt.cpp: (WebCore::writeToVector): now converts and returns the correct byte count when the end of the chunk is in the middle of a multibyte UTF-8 character.
- 7:56 PM Changeset in webkit [73678] by
-
- 3 edits2 adds in trunk
2010-12-09 Vincent Scheib <scheib@chromium.org>
Reviewed by James Robinson.
Clip update rectangle for Texture::updateSubRect to texture size
https://bugs.webkit.org/show_bug.cgi?id=49929
Test: fast/canvas/canvas-largedraws.html
- platform/graphics/gpu/Texture.cpp: (WebCore::Texture::updateSubRect):
2010-12-09 Vincent Scheib <scheib@chromium.org>
Reviewed by James Robinson.
Clip update rectangle for Texture::updateSubRect to texture size
https://bugs.webkit.org/show_bug.cgi?id=49929
- fast/canvas/canvas-largedraws-expected.txt: Added.
- fast/canvas/canvas-largedraws.html: Added.
- 7:36 PM Changeset in webkit [73677] by
-
- 8 edits in trunk/WebKit2
2010-12-09 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt][WK2] Use a single QNetworkAccessManager per web process.
https://bugs.webkit.org/show_bug.cgi?id=50757
This allows a better management of network resources and the use
of global cookie jar and disk cache across all frames.
- WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.cpp: (WebCore::WebFrameNetworkingContext::WebFrameNetworkingContext): (WebCore::WebFrameNetworkingContext::networkAccessManager):
- WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.h:
- WebProcess/WebProcess.cpp: (WebKit::WebProcess::WebProcess): (WebKit::WebProcess::initializeWebProcess): (WebKit::WebProcess::shutdownIfPossible):
- WebProcess/WebProcess.h: (WebKit::WebProcess::networkAccessManager):
- WebProcess/mac/WebProcessMac.mm: (WebKit::WebProcess::platformInitializeWebProcess): (WebKit::WebProcess::platformShutdown):
- WebProcess/qt/WebProcessQt.cpp: (WebKit::WebProcess::platformInitializeWebProcess): (WebKit::WebProcess::platformShutdown):
- WebProcess/win/WebProcessWin.cpp: (WebKit::WebProcess::platformInitializeWebProcess): (WebKit::WebProcess::platformShutdown):
- 6:53 PM Changeset in webkit [73676] by
-
- 2 edits in trunk/WebKit2
Fix the 32-bit build.
- Shared/cf/ArgumentCodersCF.cpp:
(CoreIPC::sizeForNumberType):
- 6:45 PM Changeset in webkit [73675] by
-
- 2 edits in trunk/WebKit2
2010-12-09 Maciej Stachowiak <mjs@apple.com>
Reviewed by Brady Eidson.
WebKit2: Control-click doesn't invoke context menu
https://bugs.webkit.org/show_bug.cgi?id=50793
<rdar://problem/8664800>
- WebProcess/WebPage/WebPage.cpp: (WebKit::isContextClick): New helper function - on Mac, not only right clicks but also control-left-clicks are context clicks. (WebKit::handleMouseEvent): Use above.
- 6:45 PM Changeset in webkit [73674] by
-
- 2 edits in trunk/WebCore
2010-12-09 Kenneth Russell <kbr@google.com>
Unreviewed. Another speculative Gtk build fix after r73669. Add
needed derived sources to GNUmakefile.am.
- GNUmakefile.am:
- 6:43 PM Changeset in webkit [73673] by
-
- 2 edits in trunk/LayoutTests
2010-12-09 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium test expectations update.
Group canvas/philip failures together, fix some expectations (many tests
that were marked as flaky actually fail consistently).
- platform/chromium/test_expectations.txt:
- 6:33 PM Changeset in webkit [73672] by
-
- 2 edits in trunk/WebCore
2010-12-09 Kenneth Russell <kbr@google.com>
Unreviewed. Speculative Gtk build fix after
https://bugs.webkit.org/show_bug.cgi?id=36512 / r73669. Process
all of the WebGL classes' IDL files.
- CMakeLists.txt:
- 6:00 PM Changeset in webkit [73671] by
-
- 4 edits in trunk/WebKit2
Fix clang++ build.
- Scripts/webkit2/messages.py:
DrawingAreaInfo is a struct.
- Shared/WebPreferencesStore.cpp:
(WebKit::valueForKey):
Move valueForKey above code that uses it.
- UIProcess/mac/WebInspectorProxyMac.mm:
(-[WebInspectorProxyObjCAdapter windowWillClose:]):
Remove trailing semicolon.
- 5:59 PM Changeset in webkit [73670] by
-
- 2 edits in trunk/LayoutTests
2010-12-09 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium test expectations update.
Was overly aggressive with r73661, canvas/philip/tests/
toDataURL.jpeg.alpha.html still fails.
- platform/chromium/test_expectations.txt:
- 5:58 PM Changeset in webkit [73669] by
-
- 17 edits2 adds in trunk
2010-12-09 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Expose constructor functions for instanceof checks of WebGL objects
https://bugs.webkit.org/show_bug.cgi?id=36512
Test: fast/canvas/webgl/instanceof-test.html
- bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::webGLActiveInfoEnabled): (WebCore::RuntimeEnabledFeatures::webGLBufferEnabled): (WebCore::RuntimeEnabledFeatures::webGLFramebufferEnabled): (WebCore::RuntimeEnabledFeatures::webGLProgramEnabled): (WebCore::RuntimeEnabledFeatures::webGLRenderbufferEnabled): (WebCore::RuntimeEnabledFeatures::webGLShaderEnabled): (WebCore::RuntimeEnabledFeatures::webGLTextureEnabled): (WebCore::RuntimeEnabledFeatures::webGLUniformLocationEnabled):
- html/canvas/WebGLActiveInfo.idl: Remove OmitConstructor.
- html/canvas/WebGLBuffer.idl: Ditto.
- html/canvas/WebGLFramebuffer.idl: Ditto.
- html/canvas/WebGLProgram.idl: Ditto.
- html/canvas/WebGLRenderbuffer.idl: Ditto.
- html/canvas/WebGLShader.idl: Ditto.
- html/canvas/WebGLTexture.idl: Ditto.
- html/canvas/WebGLUniformLocation.idl: Ditto.
- page/DOMWindow.idl: Expose constructors for WebGL objects in DOMWindow.
2010-12-09 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Expose constructor functions for instanceof checks of WebGL objects
https://bugs.webkit.org/show_bug.cgi?id=36512
- fast/canvas/webgl/instanceof-test-expected.txt: Added.
- fast/canvas/webgl/instanceof-test.html: Added.
- fast/dom/Window/script-tests/window-property-descriptors.js: Register newly added WebGL objects.
- fast/dom/Window/window-properties.html: Ditto.
- fast/dom/script-tests/prototype-inheritance-2.js: Ditto. (constructorNamesForWindow):
- fast/dom/script-tests/prototype-inheritance.js: Ditto.
- fast/js/script-tests/global-constructors.js: Ditto.
- 5:54 PM Changeset in webkit [73668] by
-
- 6 edits in trunk
Cannot use NSKeyedArchiver in WK2 for ResourceResponses
https://bugs.webkit.org/show_bug.cgi?id=50792
<rdar://problem/8741799>
Reviewed by Sam Weinig.
WebKit2:
When encoding, first convert the requests and responses to the serializable dictionary representation
and use the newly added CF CoreIPC encoders. When decoding, do the opposite.
- Shared/mac/WebCoreArgumentCodersMac.mm:
(CoreIPC::encodeResourceRequest):
(CoreIPC::decodeResourceRequest):
(CoreIPC::encodeResourceResponse):
(CoreIPC::decodeResourceResponse):
WebKitLibraries:
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- 5:53 PM Changeset in webkit [73667] by
-
- 2 edits in trunk/WebKit/mac
Fix a bug uncovered by clang++.
- WebView/WebHTMLView.mm:
(-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
- 5:51 PM Changeset in webkit [73666] by
-
- 14 edits in trunk
WebCore: Export Color::white and Color::transparent.
Reviewed by Anders Carlsson.
- WebCore.exp.in:
WebKit2: Add support for transparent WebKit2 WKViews.
Reviewed by Anders Carlsson.
- Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode): Encode drawsBackground and drawsTransparentBackground.
(WebKit::WebPageCreationParameters::decode): Decode drawsBackground and drawsTransparentBackground.
- Shared/WebPageCreationParameters.h:
- UIProcess/API/mac/WKView.h:
- UIProcess/API/mac/WKView.mm:
(-[WKView setDrawsBackground:]): Added.
(-[WKView drawsBackground]): Added.
(-[WKView setDrawsTransparentBackground:]): Added.
(-[WKView drawsTransparentBackground]): Added.
(-[WKView drawRect:]): Only fill the background if the WebProcess isn't valid and drawsBackground.
Use white or clear based on setDrawsTransparentBackground.
(-[WKView isOpaque]): Return drawsBackground.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy): Initialize m_drawsBackground and m_drawsTransparentBackground.
(WebKit::WebPageProxy::setDrawsBackground): Added. Send a SetDrawsBackground message.
(WebKit::WebPageProxy::setDrawsTransparentBackground): Added. Send a SetDrawsTransparentBackground message.
(WebKit::WebPageProxy::creationParameters): Set drawsBackground and drawsTransparentBackground.
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::drawsBackground): Added. Return m_drawsBackground.
(WebKit::WebPageProxy::drawsTransparentBackground): Added. Return m_drawsTransparentBackground.
- UIProcess/mac/ChunkedUpdateDrawingAreaProxyMac.mm:
(WebKit::ChunkedUpdateDrawingAreaProxy::platformPaint): Use the copy blend mode when drawing a background.
(WebKit::ChunkedUpdateDrawingAreaProxy::drawUpdateChunkIntoBackingStore): Use the copy blend mode to replace existing content.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage): Setup the new view's background color and transparent flag.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage): Initialize m_drawsBackground and m_drawsTransparentBackground.
(WebKit::WebPage::setDrawsBackground): Added. Propagate the flag to the FrameViews.
(WebKit::WebPage::setDrawsTransparentBackground): Added. Propagate the background color to the FrameViews.
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::drawsBackground): Added. Return m_drawsBackground.
(WebKit::WebPage::drawsTransparentBackground): Added. Return m_drawsTransparentBackground.
- WebProcess/WebPage/WebPage.messages.in: Added SetDrawsBackground and SetDrawsTransparentBackground.
- 5:49 PM Changeset in webkit [73665] by
-
- 2 edits in trunk/WebCore
Fix failing Mac tests.
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::scroll): Don't smooth scroll if the default
AppleScrollAnimationEnabled is false.
- 5:49 PM Changeset in webkit [73664] by
-
- 3 edits in trunk/WebKit/mac
Clang++ build fixes.
Silence a couple of warnings.
- WebView/WebFrame.mm:
(-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
(-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
- WebView/WebTextCompletionController.mm:
(-[WebTextCompletionController filterKeyDown:]):
- 5:45 PM Changeset in webkit [73663] by
-
- 22 edits13 adds in trunk
2010-12-09 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Compositor needs to manage its VRAM use
https://bugs.webkit.org/show_bug.cgi?id=49629
Adds a few tests involving lots of visible image layers. The tests are designed
to require slightly more than 64MB of VRAM.
- platform/chromium-gpu-win/compositing/lots-of-img-layers-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/lots-of-img-layers-expected.png: Added.
- platform/chromium-gpu-win/compositing/lots-of-img-layers-expected.txt: Added.
- platform/chromium-gpu-win/compositing/lots-of-img-layers-with-opacity-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/lots-of-img-layers-with-opacity-expected.png: Added.
- platform/chromium-gpu-win/compositing/lots-of-img-layers-with-opacity-expected.txt: Added.
- platform/chromium-gpu/test_expectations.txt:
- platform/chromium/compositing/lots-of-img-layers-with-opacity.html: Added.
- platform/chromium/compositing/lots-of-img-layers.html: Added.
- platform/chromium/test_expectations.txt:
2010-12-09 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Compositor needs to manage its VRAM use
https://bugs.webkit.org/show_bug.cgi?id=49629
This adds a basic texture manager to the Chromium compositor to limit the amount of VRAM
used by compositor textures and switches ContentLayerChromium, ImageLayerChromium, and
RenderSurfaceChromium to use managed LayerTexture. The other *LayerChromium classes (Canvas,
Video, and WebGL) and the root layer are still unmanaged.
The TextureManager works by providing tokens to callers that want to use a managed texture.
The token can be used to request a texture, see if the previously requested texture is still
available, and to protect/unprotect textures when they cannot be collected. Whenever a
texture is created the manager attempts to free up the least recently used textures until the
total memory use is below the provided threshhold. If the manager cannot satisfy the memory
limit it will not return any new textures until some old textures are released.
A LayerTexture wraps a TextureManager token, size, and format. A LayerChromium can check if a
previously requested texture is still available for use and reserve the LayerTexture's underlying
storage between the updateContentsIfDirty() and the draw() call.
Also changes LayerChromium from having separate contentsDirty()/updateContents() calls to a single
updateContentsIfDirty().
Tests: platform/chromium/compositing/lots-of-img-layers-with-opacity.html
platform/chromium/compositing/lots-of-img-layers.html
- WebCore.gypi:
- platform/graphics/chromium/Canvas2DLayerChromium.cpp: (WebCore::Canvas2DLayerChromium::updateContentsIfDirty):
- platform/graphics/chromium/Canvas2DLayerChromium.h:
- platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::cleanupResources): (WebCore::ContentLayerChromium::updateContentsIfDirty): (WebCore::ContentLayerChromium::updateTextureRect): (WebCore::ContentLayerChromium::draw):
- platform/graphics/chromium/ContentLayerChromium.h:
- platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateContentsIfDirty):
- platform/graphics/chromium/ImageLayerChromium.h:
- platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::updateContentsIfDirty): (WebCore::LayerChromium::draw):
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::useShader): (WebCore::LayerRendererChromium::prepareToDrawLayers): (WebCore::LayerRendererChromium::updateRootLayerTextureRect): (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::getFramebufferPixels): (WebCore::LayerRendererChromium::createLayerTexture): (WebCore::LayerRendererChromium::deleteLayerTexture): (WebCore::LayerRendererChromium::updateLayersRecursive): (WebCore::LayerRendererChromium::useRenderSurface): (WebCore::LayerRendererChromium::drawLayer): (WebCore::LayerRendererChromium::setScissorToRect): (WebCore::LayerRendererChromium::setDrawViewportRect): (WebCore::LayerRendererChromium::initializeSharedObjects): (WebCore::LayerRendererChromium::cleanupSharedObjects):
- platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::renderSurfaceSharedValues): (WebCore::LayerRendererChromium::textureManager):
- platform/graphics/chromium/LayerTexture.cpp: Added. (WebCore::LayerTexture::LayerTexture): (WebCore::LayerTexture::~LayerTexture): (WebCore::LayerTexture::isValid): (WebCore::LayerTexture::reserve): (WebCore::LayerTexture::unreserve): (WebCore::LayerTexture::bindTexture): (WebCore::LayerTexture::framebufferTexture2D):
- platform/graphics/chromium/LayerTexture.h: Added. (WebCore::LayerTexture::create):
- platform/graphics/chromium/PluginLayerChromium.cpp: (WebCore::PluginLayerChromium::updateContentsIfDirty):
- platform/graphics/chromium/PluginLayerChromium.h:
- platform/graphics/chromium/RenderSurfaceChromium.cpp: (WebCore::RenderSurfaceChromium::SharedValues::SharedValues): (WebCore::RenderSurfaceChromium::SharedValues::~SharedValues): (WebCore::RenderSurfaceChromium::RenderSurfaceChromium): (WebCore::RenderSurfaceChromium::cleanupResources): (WebCore::RenderSurfaceChromium::prepareContentsTexture): (WebCore::RenderSurfaceChromium::draw):
- platform/graphics/chromium/RenderSurfaceChromium.h: (WebCore::RenderSurfaceChromium::SharedValues::shaderProgram): (WebCore::RenderSurfaceChromium::SharedValues::shaderSamplerLocation): (WebCore::RenderSurfaceChromium::SharedValues::shaderMatrixLocation): (WebCore::RenderSurfaceChromium::SharedValues::shaderAlphaLocation): (WebCore::RenderSurfaceChromium::SharedValues::initialized):
- platform/graphics/chromium/TextureManager.cpp: Added. (WebCore::memoryUseBytes): (WebCore::TextureManager::TextureManager): (WebCore::TextureManager::getToken): (WebCore::TextureManager::releaseToken): (WebCore::TextureManager::hasTexture): (WebCore::TextureManager::protectTexture): (WebCore::TextureManager::unprotectTexture): (WebCore::TextureManager::reduceMemoryToLimit): (WebCore::TextureManager::addTexture): (WebCore::TextureManager::removeTexture): (WebCore::TextureManager::requestTexture):
- platform/graphics/chromium/TextureManager.h: Added. (WebCore::TextureManager::create):
- platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::updateContentsIfDirty):
- platform/graphics/chromium/VideoLayerChromium.h:
- platform/graphics/chromium/WebGLLayerChromium.cpp: (WebCore::WebGLLayerChromium::updateContentsIfDirty):
- platform/graphics/chromium/WebGLLayerChromium.h:
- 5:31 PM Changeset in webkit [73662] by
-
- 4 edits3 adds in trunk/WebKit2
[GTK] Support the Mozilla-style Fullscreen Javascript API
https://bugs.webkit.org/show_bug.cgi?id=50572
Patch by Philippe Normand <pnormand@igalia.com> on 2010-12-06
Reviewed by Martin Robinson.
- configure.ac: new configure flag to disable the new Javascript
Fullscreen API build. It is enabled by default.
- 5:29 PM Changeset in webkit [73661] by
-
- 2 edits15 deletes in trunk/LayoutTests
2010-12-09 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium test expectations update.
Delete a bunch of chromium-win specific baselines that were added by
r68608. That was done because r68568 checked in failing expectations,
but since Chromium was passing the tests with Skia, we wanted to keep
passing them. However, the failing expectations were rolled out by
r68737, so we no longer needed Chromium-specific expectations.
Later, with r71481 we updated to a new version of the Philip test suite,
which has a different output format, and the Chromium-specific
expectations were out of date. Since they're not needed (we should pass
with the base ones), they can just be deleted.
- platform/chromium-mac/canvas/philip/tests/2d.drawImage.null-expected.txt: Removed.
- platform/chromium-mac/canvas/philip/tests/2d.pattern.image.null-expected.txt: Removed.
- platform/chromium-win/canvas/philip/tests/2d.drawImage.null-expected.txt: Removed.
- platform/chromium-win/canvas/philip/tests/2d.gradient.radial.cone.front-expected.txt: Removed.
- platform/chromium-win/canvas/philip/tests/2d.gradient.radial.inside2-expected.txt: Removed.
- platform/chromium-win/canvas/philip/tests/2d.gradient.radial.inside3-expected.txt: Removed.
- platform/chromium-win/canvas/philip/tests/2d.gradient.radial.outside1-expected.txt: Removed.
- platform/chromium-win/canvas/philip/tests/2d.line.cap.closed-expected.txt: Removed.
- platform/chromium-win/canvas/philip/tests/2d.line.join.parallel-expected.txt: Removed.
- platform/chromium-win/canvas/philip/tests/2d.line.miter.lineedge-expected.txt: Removed.
- platform/chromium-win/canvas/philip/tests/2d.pattern.image.null-expected.txt: Removed.
- platform/chromium-win/canvas/philip/tests/2d.shadow.enable.x-expected.txt: Removed.
- platform/chromium-win/canvas/philip/tests/2d.shadow.enable.y-expected.txt: Removed.
- platform/chromium-win/canvas/philip/tests/2d.strokeRect.zero.4-expected.txt: Removed.
- platform/chromium-win/canvas/philip/tests/toDataURL.jpeg.alpha-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- 5:06 PM Changeset in webkit [73660] by
-
- 5 edits in trunk/WebCore
Rework my recent setLocation refactoring to use DOMWindow instead of Frame.
It's difficult to make correct security decisions based on Frame since a
Frame can navigate to a new document.
Reviewed by Sam Weinig.
Fixes some test failures that I somehow missed before the last check-in.
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::crossDomainAccessErrorMessage): Call to the
shell DOMWindow; not sure this one matters, but it's closer to the old
code before my last patch. Also pass the DOMWindow rather than the
frame to crossDomainAccessErrorMessage.
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::setLocation): Pass DOMWindow rather than Frame
to the DOMWindow::setLocation function.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::setLocation): Take DOMWindow rather than Frame.
(WebCore::DOMWindow::crossDomainAccessErrorMessage): Ditto.
- page/DOMWindow.h: Update new functions to take DOMWindow rather
than Frame.
- 4:56 PM Changeset in webkit [73659] by
-
- 2 edits in trunk/LayoutTests
2010-12-09 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium test expectations update.
Remove test_expectations.txt entries for 4 Philip suite canvas tests
that pass consistently on all bots. 2d.drawImage.incomplete.html was
fixed by r71292, the rest have been passing for as long as we have
history in the Chromium test dashboard.
- platform/chromium/test_expectations.txt:
- 4:28 PM Changeset in webkit [73658] by
-
- 5 edits in trunk
Versioning.
- 4:26 PM Changeset in webkit [73657] by
-
- 1 copy in tags/Safari-534.14
New tag.
- 3:47 PM Changeset in webkit [73656] by
-
- 2 edits in trunk/WebCore
Try and fix the mac build.
- WebCore.exp.in:
- 3:24 PM Changeset in webkit [73655] by
-
- 2 edits in trunk/LayoutTests
Unreviewed Chromium test expectations update.
Mark a test as timing out on Win Debug.
- platform/chromium/test_expectations.txt:
- 3:22 PM Changeset in webkit [73654] by
-
- 7 edits in trunk/WebKitTools
2010-12-09 Dirk Pranke <dpranke@chromium.org>
Reviewed by Ojan Vafai.
Make new-run-webkit-tests --lint-test-files log slightly better
messages and return -1 if lint fails. Remove the
'suppress_errors' keyword param to the TestExpectationsFile
class, and clean up logging and exception raising for error
handling. Also add more unit tests and clean up the unit test code a bit.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- Scripts/webkitpy/layout_tests/layout_package/test_expectations.py
- Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/style/checkers/test_expectations.py:
- Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
- 3:02 PM Changeset in webkit [73653] by
-
- 2 edits in trunk/WebCore
Removed an unused variable.
Reviewed by Dave Hyatt.
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::computeLogicalBoxHeights): Removed parentLineHeight.
- 2:35 PM Changeset in webkit [73652] by
-
- 2 edits in trunk/WebKit2
<rdar://problem/8749750> and https://bugs.webkit.org/show_bug.cgi?id=50786
WK2 authentication never consults WebCore session credential storage.
Reviewed by Sam Weinig.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::shouldUseCredentialStorage): Since we don't need to expose this as
API at this time, always return true.
- 2:32 PM Changeset in webkit [73651] by
-
- 4 edits in trunk/LayoutTests
Unreviewed Chromium test expectations update.
Rebaseline a Linux test.
- platform/chromium-linux/svg/custom/use-referencing-nonexisting-symbol-expected.checksum:
- platform/chromium-linux/svg/custom/use-referencing-nonexisting-symbol-expected.png:
- platform/chromium/test_expectations.txt:
- 2:31 PM Changeset in webkit [73650] by
-
- 2 edits in trunk/WebKit2
WebKit2: Add support for access keys
https://bugs.webkit.org/show_bug.cgi?id=49832
Reviewed by Alexey Proskuryakov.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::handleKeyEvent): Match windows WebKit and call
the event handler's for handleAccessKey function for
system keys. This will never be hit on the Mac.
- 2:30 PM Changeset in webkit [73649] by
-
- 2 edits in trunk/WebKit2
Qt build fix.
- WebProcess/WebCoreSupport/qt/WebContextMenuClientQt.cpp: Include "NotImplemented.h".
- 2:29 PM Changeset in webkit [73648] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix date.
- 2:24 PM Changeset in webkit [73647] by
-
- 6 edits in trunk/WebCore
2010-12-08 Darin Adler <Darin Adler>
Reviewed by Geoffrey Garen.
Move DOMWindow::setLocation logic into DOMWindow class and out of JavaScript binding
https://bugs.webkit.org/show_bug.cgi?id=50640
- bindings/js/JSDOMBinding.cpp: (WebCore::printErrorMessageForFrame): Removed body; just call through to DOMWindow::printErrorMessage.
- bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::crossDomainAccessErrorMessage): Removed body; just call through to DOMWindow::crossDomainAccessErrorMessage.
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation): Changed terminology to use activeFrame and firstFrame, rather than the older lexicalFrame and dynamicFrame. Removed most of the body and moved it into DOMWindow::setLocation.
- page/DOMWindow.cpp: (WebCore::DOMWindow::setLocation): Added. Does all the same work that JSDOMWindow::setLocation used to do, but in a way that's not specific to JavaScript. (WebCore::DOMWindow::printErrorMessage): Added. (WebCore::DOMWindow::crossDomainAccessErrorMessage): Added.
- page/DOMWindow.h: Added setLocation, printErrorMessage, and crossDomainAccessErrorMessage.
- 2:17 PM Changeset in webkit [73646] by
-
- 2 edits in trunk/WebKit2
Windows build fix.
- WebProcess/WebCoreSupport/win/WebContextMenuClientWin.cpp:
- 1:49 PM Changeset in webkit [73645] by
-
- 2 edits in trunk/WebKit/mac
https://bugs.webkit.org/show_bug.cgi?id=48545, Home/End, PgUp, PgDown should respect
writing-mode. This first part of the patch just patches Mac WebKit 1 views.
Reviewed by Dan Bernstein.
- WebView/WebFrameView.mm:
(-[WebFrameView _isVerticalDocument]):
(-[WebFrameView _isFlippedDocument]):
(-[WebFrameView _scrollToEndOfDocument]):
(-[WebFrameView _pageInBlockProgressionDirection:]):
(-[WebFrameView scrollPageUp:]):
(-[WebFrameView scrollPageDown:]):
- 1:47 PM Changeset in webkit [73644] by
-
- 3 edits1 move in trunk/WebCore
WebKit2 needs smooth scrolling support on the mac
<rdar://problem/8219402>
Reviewed by Dan Bernstein.
- WebCore.xcodeproj/project.pbxproj: Change ScrollAnimatorMac.cpp to ScrollAnimatorMac.mm.
- platform/mac/ScrollAnimatorMac.cpp: Removed.
- platform/mac/ScrollAnimatorMac.h:
- platform/mac/ScrollAnimatorMac.mm: Copied from platform/mac/ScrollAnimatorMac.cpp.
(-[ScrollAnimationHelperDelegate initWithScrollAnimator:WebCore::]):
(-[ScrollAnimationHelperDelegate bounds]):
(-[ScrollAnimationHelperDelegate _immediateScrollToPoint:]):
(-[ScrollAnimationHelperDelegate convertSizeToBase:]):
(-[ScrollAnimationHelperDelegate convertSizeFromBase:]):
(-[ScrollAnimationHelperDelegate superview]):
(-[ScrollAnimationHelperDelegate documentView]):
(-[ScrollAnimationHelperDelegate window]):
(-[ScrollAnimationHelperDelegate _recursiveRecomputeToolTips]):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::scroll):
(WebCore::ScrollAnimatorMac::setScrollPositionAndStopAnimation):
(WebCore::ScrollAnimatorMac::currentPosition):
(WebCore::ScrollAnimatorMac::immediateScrollToPoint):
Add implementation of ScrollAnimator for the Mac.
- 1:12 PM Changeset in webkit [73643] by
-
- 8 edits3 adds in trunk
<rdar://problem/8613779> and https://bugs.webkit.org/show_bug.cgi?id=50777
WebKit2 ContextMenuClient support
Reviewed by Anders Carlsson.
WebCore:
Export some symbols and headers needed by WebKit2 Mac:
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
WebKit2:
Implement google search in a cross platform manner, and add a FIXME for download support:
- WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
(WebKit::WebContextMenuClient::downloadURL):
(WebKit::WebContextMenuClient::searchWithGoogle):
Mac implementations for speaking and searching:
- WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm: Added.
(WebKit::WebContextMenuClient::lookUpInDictionary): Add a FIXME for now.
(WebKit::WebContextMenuClient::isSpeaking):
(WebKit::WebContextMenuClient::speak):
(WebKit::WebContextMenuClient::stopSpeaking):
(WebKit::WebContextMenuClient::searchWithSpotlight):
Stubs for Win and Qt:
- WebProcess/WebCoreSupport/qt/WebContextMenuClientQt.cpp: Added.
(WebKit::WebContextMenuClient::lookUpInDictionary):
(WebKit::WebContextMenuClient::isSpeaking):
(WebKit::WebContextMenuClient::speak):
(WebKit::WebContextMenuClient::stopSpeaking):
- WebProcess/WebCoreSupport/win/WebContextMenuClientWin.cpp: Added.
(WebKit::WebContextMenuClient::lookUpInDictionary):
(WebKit::WebContextMenuClient::isSpeaking):
(WebKit::WebContextMenuClient::speak):
(WebKit::WebContextMenuClient::stopSpeaking):
Project file stuffs:
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
- 1:10 PM Changeset in webkit [73642] by
-
- 9 edits in trunk
2010-12-09 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r73635.
http://trac.webkit.org/changeset/73635
https://bugs.webkit.org/show_bug.cgi?id=50778
'Side-effects on 3 css tests needs closer review' (Requested
by mwenge on #webkit).
- platform/qt/Skipped:
2010-12-09 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r73635.
http://trac.webkit.org/changeset/73635
https://bugs.webkit.org/show_bug.cgi?id=50778
'Side-effects on 3 css tests needs closer review' (Requested
by mwenge on #webkit).
- platform/graphics/qt/ImageQt.cpp: (loadResourcePixmap):
- platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::computeSizeBasedOnStyle): (WebCore::RenderThemeQt::paintSearchField): (WebCore::RenderThemeQt::adjustSearchFieldStyle): (WebCore::RenderThemeQt::adjustSearchFieldCancelButtonStyle): (WebCore::RenderThemeQt::paintSearchFieldCancelButton):
- platform/qt/RenderThemeQt.h:
2010-12-09 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r73635.
http://trac.webkit.org/changeset/73635
https://bugs.webkit.org/show_bug.cgi?id=50778
'Side-effects on 3 css tests needs closer review' (Requested
by mwenge on #webkit).
- Api/qwebsettings.cpp: (graphics):
- Api/qwebsettings.h:
- 1:06 PM Changeset in webkit [73641] by
-
- 2 edits in trunk/WebKit/efl
2010-12-09 Alex Bredariol Grilo <abgrilo@profusion.mobi>
Reviewed by Antonio Gomes.
[EFL] Add missing function in WebKit-EFL API
Add ewk_tiled_backing_store_zoom_weak_smooth_scale_set function in
WebKit-EFL API. This function was already implemented but missing in
header file.
- ewk/ewk_tiled_backing_store.h:
- 1:06 PM Changeset in webkit [73640] by
-
- 5 edits in trunk
2010-12-09 Michael Saboff <msaboff@apple.com>
Reviewed by Gavin Barraclough.
REGRESSION (r73065?): A regex no longer works
https://bugs.webkit.org/show_bug.cgi?id=50570
Changed the handling of adjacent parentheses backtracks in two ways.
First, only outer most paren backtracks default to back tracking
to the "next character" looping code. Second, added a jump around
backtracks that fall through to the next backtrack where the
second backtrack has some greedy processing before the backtracking
from outside the parentheses code.
Also cleaned up extraneous white spce, removing white space at the
end of or that makes up a whole line.
- yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::GenerationState::GenerationState): (JSC::Yarr::RegexGenerator::GenerationState::incrementParenNestingLevel): (JSC::Yarr::RegexGenerator::GenerationState::decrementParenNestingLevel): (JSC::Yarr::RegexGenerator::GenerationState::addParenthesesTail): (JSC::Yarr::RegexGenerator::GenerationState::emitParenthesesTail): (JSC::Yarr::RegexGenerator::ParenthesesTail::ParenthesesTail): (JSC::Yarr::RegexGenerator::ParenthesesTail::setNextIteration): (JSC::Yarr::RegexGenerator::ParenthesesTail::generateCode): (JSC::Yarr::RegexGenerator::generateParenthesesSingle):
2010-12-09 Michael Saboff <msaboff@apple.com>
Reviewed by Gavin Barraclough.
REGRESSION (r73065?): A regex no longer works
https://bugs.webkit.org/show_bug.cgi?id=50570
Added tests that came from submitter to validate change.
- fast/regex/parentheses-expected.txt:
- fast/regex/script-tests/parentheses.js:
- 12:57 PM Changeset in webkit [73639] by
-
- 2 edits in trunk/LayoutTests
Unreviewed Chromium test expectations update.
- platform/chromium/test_expectations.txt:
- 12:56 PM Changeset in webkit [73638] by
-
- 2 edits in trunk/WebKitTools
2010-12-09 Tony Chang <tony@chromium.org>
Unreviewed, fix for windows code. We were catching the wrong
exception in Windows.
- Scripts/webkitpy/common/system/filesystem.py:
- 12:51 PM Changeset in webkit [73637] by
-
- 4 edits3 adds in trunk/LayoutTests
2010-12-09 Cosmin Truta <ctruta@chromium.org>
Reviewed by Adam Barth.
Rebaseline svg/custom/text-linking.svg
https://bugs.webkit.org/show_bug.cgi?id=50310
- platform/chromium/test_expectations.txt:
- platform/chromium-win/svg/custom/text-linking-expected.checksum: Added.
- platform/chromium-win/svg/custom/text-linking-expected.png: Added.
- platform/chromium-win/svg/custom/text-linking-expected.txt: Added.
- platform/mac-leopard/svg/custom/text-linking-expected.checksum: Updated.
- platform/mac-leopard/svg/custom/text-linking-expected.png: Updated.
- 12:09 PM Changeset in webkit [73636] by
-
- 3 edits in trunk/LayoutTests
Unreviewed Chromium test expectations update.
- platform/chromium-gpu/test_expectations.txt:
- platform/chromium/test_expectations.txt:
- 11:54 AM Changeset in webkit [73635] by
-
- 9 edits in trunk
2010-12-09 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] Search input field doesn't have cancel button
Add a cancel button to the search field and make it customizable
by the client. For now, use the close dialog button associated
with the application's style as the default.
Unskip a bunch of search field related tests that pass now:
fast/forms/search-cancel-button-mouseup.html
fast/forms/search-rtl.html
fast/forms/search-abs-pos-cancel-button.html
fast/forms/search-styled.html
fast/forms/search-transformed.html
fast/forms/search-zoomed.html
fast/forms/search-cancel-button-style-sharing.html
fast/forms/search-display-none-cancel-button.html
fast/forms/search-placeholder-value-changed.html
fast/repaint/search-field-cancel.html
fast/forms/search-cancel-button-events.html
- platform/qt/Skipped:
2010-12-09 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] Search input field doesn't have cancel button
Add a cancel button to the search field and make it customizable
by the client. For now, use the close dialog button associated
with the application's style as the default.
- platform/graphics/qt/ImageQt.cpp: (loadResourcePixmap):
- platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::computeSizeBasedOnStyle): (WebCore::RenderThemeQt::paintSearchField): (WebCore::RenderThemeQt::adjustSearchFieldStyle): (WebCore::RenderThemeQt::adjustSearchFieldCancelButtonStyle): (WebCore::RenderThemeQt::convertToPaintingRect): (WebCore::RenderThemeQt::paintSearchFieldCancelButton):
- platform/qt/RenderThemeQt.h:
2010-12-09 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] Search input field doesn't have cancel button
Add a cancel button to the search field and make it customizable
by the client. For now, use the close dialog button associated
with the application's style as the default.
- Api/qwebsettings.cpp: (graphics):
- Api/qwebsettings.h:
- 11:45 AM QtWebKitFeatures21 edited by
- (diff)
- 11:36 AM Changeset in webkit [73634] by
-
- 3 edits2 adds in trunk
2010-12-09 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Antonio Gomes.
Spatial Navigation: Crash when handling iframe of size 0.
https://bugs.webkit.org/show_bug.cgi?id=50730
- fast/spatial-navigation/snav-hidden-iframe-zero-size-expected.txt: Added.
- fast/spatial-navigation/snav-hidden-iframe-zero-size.html: Added.
2010-12-09 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Antonio Gomes.
Spatial Navigation: Crash when handling iframe of size 0.
https://bugs.webkit.org/show_bug.cgi?id=50730
if we have a frame of size 0, we would get into infinite loop and eventually crash. The reason is
that when the algorithm sees a starting rect of size 0, it assumes that there is no focused node,
thus restarts itself. The solution is to avoid considering iframes with size 0 for the spatial
navigation algorithm.
Test: fast/spatial-navigation/snav-hidden-iframe-zero-size.html
- page/FocusController.cpp: (WebCore::updateFocusCandidateIfNeeded):
- 11:35 AM Changeset in webkit [73633] by
-
- 16 edits in trunk
2010-12-09 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r73616.
http://trac.webkit.org/changeset/73616
https://bugs.webkit.org/show_bug.cgi?id=50772
Breaks chromium win build (Requested by hwennborg on #webkit).
- public/WebIDBKey.h: (WebKit::WebIDBKey::WebIDBKey):
- src/WebIDBKey.cpp: (WebKit::WebIDBKey::assign): (WebKit::WebIDBKey::number):
2010-12-09 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r73616.
http://trac.webkit.org/changeset/73616
https://bugs.webkit.org/show_bug.cgi?id=50772
Breaks chromium win build (Requested by hwennborg on #webkit).
- bindings/v8/IDBBindingUtilities.cpp: (WebCore::createIDBKeyFromValue):
- bindings/v8/custom/V8IDBKeyCustom.cpp: (WebCore::toV8):
- storage/IDBFactoryBackendImpl.cpp: (WebCore::createTables): (WebCore::IDBFactoryBackendImpl::open):
- storage/IDBKey.cpp: (WebCore::IDBKey::IDBKey): (WebCore::IDBKey::fromQuery): (WebCore::IDBKey::bind): (WebCore::IDBKey::bindWithNulls):
- storage/IDBKey.h: (WebCore::IDBKey::create): (WebCore::IDBKey::number):
2010-12-09 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r73616.
http://trac.webkit.org/changeset/73616
https://bugs.webkit.org/show_bug.cgi?id=50772
Breaks chromium win build (Requested by hwennborg on #webkit).
- storage/indexeddb/index-basics-expected.txt:
- storage/indexeddb/index-basics.html:
- storage/indexeddb/index-cursor.html:
- storage/indexeddb/keyrange-expected.txt:
- storage/indexeddb/keyrange.html:
- storage/indexeddb/objectstore-cursor.html:
- 11:28 AM Changeset in webkit [73632] by
-
- 1 edit3 adds in trunk/LayoutTests
Land failing expected results for editing tests that have been failing since they were
added in r73548.
Fixing the failures is being tracked by: https://bugs.webkit.org/show_bug.cgi?id=50731.
- platform/win/editing/selection/caret-ltr-right-expected.txt: Added.
- platform/win/editing/selection/caret-rtl-2-left-expected.txt: Added.
- platform/win/editing/selection/caret-rtl-right-expected.txt: Added.
- 11:17 AM Changeset in webkit [73631] by
-
- 2 edits in trunk/WebKit2
Don't leak the PDFDocument
https://bugs.webkit.org/show_bug.cgi?id=50771
Reviewed by Sam Weinig.
- UIProcess/API/mac/PDFViewController.mm:
(WebKit::PDFViewController::setPDFDocumentData):
- 10:58 AM Changeset in webkit [73630] by
-
- 5 edits1 copy1 add in trunk/WebKit2
Add a basic implementation of PDF support on Mac
https://bugs.webkit.org/show_bug.cgi?id=50768
Reviewed by Sam Weinig.
- UIProcess/API/mac/PDFViewController.h:
- UIProcess/API/mac/PDFViewController.mm: Added.
(-[WKPDFView initWithFrame:PDFViewController:WebKit::]):
Setup the view hierarchy.
(-[WKPDFView invalidate]):
Set the controller to null.
(-[WKPDFView pdfView]):
Return the PDF view.
(WebKit::PDFViewController::create):
(WebKit::PDFViewController::PDFViewController):
Create a WKPDFView and insert it as a subview of the WKView.
(WebKit::PDFViewController::~PDFViewController):
Remove the WKPDFView from the view hierarchy and invalidate it.
(WebKit::convertPostScriptDataSourceToPDF):
Convert the data in the data reference to PDF and return it as a CFDataRef.
(WebKit::PDFViewController::setPDFDocumentData):
Create a PDFDocument and set it on the PDF view.
(WebKit::PDFViewController::pdfDocumentClass):
(WebKit::PDFViewController::pdfPreviewViewClass):
(WebKit::PDFViewController::pdfKitBundle):
Add soft-linking helper functions.
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::didCommitLoadForMainFrame):
(WebKit::PageClientImpl::didFinishLoadingDataForCustomRepresentation):
Call the WKView methods.
- UIProcess/API/mac/WKView.mm:
(-[WKView _setPageHasCustomRepresentation:]):
Create a PDF view controller if necessary.
(-[WKView _didFinishLoadingDataForCustomRepresentation:CoreIPC::]):
Pass the data along to the PDF view controller.
- WebKit2.xcodeproj/project.pbxproj:
Add new files.
- 10:54 AM Changeset in webkit [73629] by
-
- 2 edits in trunk/WebCore
2010-12-09 Antonio Gomes <agomes@rim.com>
Rubber stamped by Gustavo Noronha.
Buildfix for GTK+ with building with -no-video.
paintStockIcon static function was implemented under the ENABLE(VIDEO) guard
but used from outside the guard. See RenderThemeGtk::paintSearchFieldResultsDecoration()
and RenderThemeGtk::paintSearchFieldCancelButton() methods.
- platform/gtk/RenderThemeGtk.cpp: (WebCore::getMediaElementFromRenderObject):
- 10:54 AM Changeset in webkit [73628] by
-
- 7 edits1 delete in trunk
2010-12-09 Antonio Gomes <agomes@rim.com>
Reviewed by Martin Robinson.
[Gtk] Populate DumpRenderTreeSupportGtk (part IV)
https://bugs.webkit.org/show_bug.cgi?id=48429
WebKit/gtk:
Moved also webkit_worker_thread_count() to DumpRenderTreeSupportGtk,
since it was only used by DRT for now.
Since this method was the only one in webkitworker.cpp, the file was
also removed.
- GNUmakefile.am:
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::workerThreadCount):
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
- webkit/webkitprivate.h:
- webkit/webkitworkers.cpp: Removed.
WebKitTools/DumpRenderTree/gtk:
Adjust call sites of webkit_thread_count to use the DumpRenderTreeSupportGtk version now.
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::workerThreadCount):
- 10:53 AM Changeset in webkit [73627] by
-
- 3 edits in trunk/WebCore
2010-12-07 Antonio Gomes <agomes@rim.com>
Reviewed by Daniel Bates.
Spatial Navigation: code clean up
https://bugs.webkit.org/show_bug.cgi?id=50666
Patch unifies two FocusCandidate constructors, making caller sites
simpler. Now the special handling HTMLAreaElement gets is done within
the non default constructor (i.e. FocusCanditate(Node*, FocusDirection)).
No new tests needed.
- page/FocusController.cpp: (WebCore::FocusController::findFocusCandidateInContainer):
- page/SpatialNavigation.cpp: (WebCore::FocusCandidate::FocusCandidate):
- 10:49 AM Changeset in webkit [73626] by
-
- 2 edits in trunk/WebCore
2010-12-09 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Carlson.
[GStreamer] disable fullscreen on MacOS Tiger and Leopard
https://bugs.webkit.org/show_bug.cgi?id=50748
Don't support fullscreen video on Tiger and Leopard, just like the
QTKit player.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::supportsFullscreen):
- 10:37 AM Changeset in webkit [73625] by
-
- 20 edits in trunk/WebKit2
Add support for custom representation
https://bugs.webkit.org/show_bug.cgi?id=50767
Reviewed by Sam Weinig.
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h:
Add mimeTypesWithCustomRepresentation and encode and decode accordingly.
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::didCommitLoadForMainFrame):
(WebKit::PageClientImpl::didFinishLoadingDataForCustomRepresentation):
Add empty stubs for now.
- UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::didCommitLoadForMainFrame):
(QWKPagePrivate::didFinishLoadingDataForCustomRepresentation):
- UIProcess/API/qt/qwkpage_p.h:
Add empty stubs.
- UIProcess/PageClient.h:
Add new functions for custom representations.
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::canShowMIMEType):
Check that the mime type is not null.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didCommitLoadForFrame):
This now takes an additional frameHasCustomRepresentation parameter.
Call the page client function.
(WebKit::WebPageProxy::didFinishLoadingDataForCustomRepresentation):
Call the page client function.
- UIProcess/WebPageProxy.messages.in:
Change DidCommitLoadForFrame message, add DidFinishLoadingDataForCustomRepresentation message.
- UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformInitializeWebProcess):
We want to use custom representations for PDF and PostScript MIME types.
- UIProcess/win/WebView.cpp:
(WebKit::WebView::didCommitLoadForMainFrame):
(WebKit::WebView::didFinishLoadingDataForCustomRepresentation):
- UIProcess/win/WebView.h:
Add stubs.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::WebFrameLoaderClient):
Initialize m_frameHasCustomRepresentation.
(WebKit::WebFrameLoaderClient::hasHTMLView):
The frame has a HTML view unless it has a custom representation.
(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
Pass along whether the frame has a custom representation.
(WebKit::WebFrameLoaderClient::committedLoad):
Don't send data back to WebCore if the frame has a custom representation.
(WebKit::WebFrameLoaderClient::finishedLoading):
Send all the data to the UI process.
(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
Update the m_frameHasCustomRepresentation state based on the MIME type.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
(WebKit::WebFrameLoaderClient::frameHasCustomRepresentation):
Add getter.
- WebProcess/WebPage/mac/ChunkedUpdateDrawingAreaMac.cpp:
(WebKit::ChunkedUpdateDrawingArea::paintIntoUpdateChunk):
Don't do any painting if the main frame has a custom representation.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
Add all the MIME types with custom representations.
- WebProcess/WebProcess.h:
(WebKit::WebProcess::shouldUseCustomRepresentationForMIMEType):
Add getter.
- 10:31 AM Changeset in webkit [73624] by
-
- 15 edits in trunk
2010-12-06 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
[GTK] Support the Mozilla-style Fullscreen Javascript API
https://bugs.webkit.org/show_bug.cgi?id=50572
- configure.ac: new configure flag to disable the new Javascript Fullscreen API build. It is enabled by default.
WebCore:
Reviewed by Martin Robinson.
[GTK] Support the Mozilla-style Fullscreen Javascript API
https://bugs.webkit.org/show_bug.cgi?id=50572
- GNUmakefile.am: enable the Javascript Fullscreen API feature if it's been requested at configure time.
WebKit/gtk:
Reviewed by Martin Robinson.
[GTK] Support the Mozilla-style Fullscreen Javascript API
https://bugs.webkit.org/show_bug.cgi?id=50572
Fullscreen API support. It is controlled at runtime using a new
setting called enable-fullscreen, set to FALSE by default.
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::supportsFullScreenForElement): (WebKit::ChromeClient::enterFullScreenForElement): (WebKit::ChromeClient::exitFullScreenForElement):
- WebCoreSupport/ChromeClientGtk.h:
- webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
- webkit/webkitwebview.cpp: (webkit_web_view_update_settings):
WebKitTools:
Reviewed by Martin Robinson.
[GTK] Support the Mozilla-style Fullscreen Javascript API
https://bugs.webkit.org/show_bug.cgi?id=50572
Enable the Javascript Fullscreen support in the GtkLauncher. Also
make DRT update the Chrome when the WebView settings have been
reset to consistent values.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
- GtkLauncher/main.c: (create_window):
- Scripts/build-webkit:
LayoutTests:
Reviewed by Martin Robinson.
[GTK] Support the Mozilla-style Fullscreen Javascript API
https://bugs.webkit.org/show_bug.cgi?id=50572
- platform/gtk/Skipped: Unskip now passing fullscreen tests.
- 10:27 AM Changeset in webkit [73623] by
-
- 6 edits3 adds in trunk
2010-12-09 Michael Saboff <msaboff@apple.com>
Reviewed by Geoffrey Garen.
Addressed the "FIXME" issues in array sort for toString() methods that
mutate the array in either size or contents. The change is to mark
the temporary array contents so that they are not garbage collected
and to make sure the array is large enough to hold the contents
of the sorted temporary vector.
https://bugs.webkit.org/show_bug.cgi?id=50718
- runtime/Collector.cpp: (JSC::Heap::addTempSortVector): (JSC::Heap::removeTempSortVector): (JSC::Heap::markTempSortVectors): (JSC::Heap::markRoots):
- runtime/Collector.h:
- runtime/JSArray.cpp: (JSC::JSArray::sort):
- runtime/JSValue.h:
2010-12-09 Michael Saboff <msaboff@apple.com>
Reviewed by Geoffrey Garen.
New test to verify that arrays sort per the standard even it
there is an override for toString() that modifies the array.
https://bugs.webkit.org/show_bug.cgi?id=50718
- fast/js/array-sort-modifying-tostring-expected.txt: Added.
- fast/js/array-sort-modifying-tostring.html: Added.
- fast/js/script-tests/array-sort-modifying-tostring.js: Added. (do_gc): (Item): (toString_Mutate): (test):
- 10:26 AM Changeset in webkit [73622] by
-
- 2 edits in trunk/WebCore
2010-12-09 Yong Li <yoli@rim.com>
Reviewed by Darin Adler.
Check the return value of ImageBuffer::create()
to avoid crash when ImageBuffer::create() fails.
https://bugs.webkit.org/show_bug.cgi?id=50631
No new test because it relies on the platform implementation
of ImageBuffer. It is hard to make ImageBuffer::create() fail
in most ports.
- platform/graphics/GeneratedImage.cpp: (WebCore::GeneratedImage::drawPattern):
- 10:07 AM Changeset in webkit [73621] by
-
- 6 edits in trunk
2010-12-09 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
Implement "Use Selection for Find" in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=50737
<rdar://problem/8564881>
Implement a TakeFindStringFromSelection editor command. This is
used solely to implement the "Use Selection for Find" menu command
on Mac, and is not made available to script. On WebKit2, it is
very convenient to reuse the editing machinery since this command
is very similar to Copy.
- editing/Editor.h:
- editing/EditorCommand.cpp: (WebCore::executeTakeFindStringFromSelection): Call to a mac-only Editor function. (WebCore::enabledTakeFindStringFromSelection): Check using Editor::canCopyExcludingStandaloneImage (WebCore::createCommandMap): Add "TakeFindStringFromSelection" command.
- editing/mac/EditorMac.mm: (WebCore::Editor::canCopyExcludingStandaloneImages): Helper function; we can't use Editor::canCopy since it would make no sense to enable "Use Selection for Find" when viewing a standalone image document. (WebCore::Editor::takeFindStringFromSelection): Implement by copying the selected text to the special Find pasteboard.
2010-12-09 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
Implement "Use Selection for Find" in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=50737
<rdar://problem/8564881>
- UIProcess/API/mac/WKView.mm: Add support for the takeFindStringFromSelection: selector as a command.
- 9:51 AM Changeset in webkit [73620] by
-
- 3 edits2 adds in trunk
2010-12-09 Abhishek Arya <inferno@chromium.org>
Reviewed by Dimitri Glazkov.
As part of r73559, I added the referenceNode check to validate whether the root
node of the iterator matches the node which is getting moved to other document.
referenceNode is initialized to root, however can get moved using previousNode
and nextNode methods, so it is required to use root directly.
https://bugs.webkit.org/show_bug.cgi?id=50764
Test: fast/dom/node-iterator-reference-node-moved-crash.html
- dom/Document.cpp: (WebCore::Document::moveNodeIteratorsToNewDocument): change referenceNode to root.
2010-12-09 Abhishek Arya <inferno@chromium.org>
Reviewed by Dimitri Glazkov.
Tests that we do not crash when we move the referenceNode using node iterator
methods previousNode and nextNode.
https://bugs.webkit.org/show_bug.cgi?id=50764
- fast/dom/node-iterator-reference-node-moved-crash-expected.txt: Added.
- fast/dom/node-iterator-reference-node-moved-crash.html: Added.
- 9:40 AM Changeset in webkit [73619] by
-
- 2 edits in branches/chromium/597/WebCore
Merge 73586 - Fix regression from xji's wheel scroll patch. The vertical case is looking at the horizontal
maximum position and not the vertical position.
Reviewed by Simon Fraser.
- platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
TBR=hyatt@apple.com
- 9:31 AM QtWebKitRelease21 edited by
- (diff)
- 9:23 AM QtWebKitFeatures21 edited by
- (diff)
- 9:23 AM Changeset in webkit [73618] by
-
- 22 edits in trunk/WebCore
2010-12-08 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Adler.
Provide a generic way to store shadowParent on a Node.
https://bugs.webkit.org/show_bug.cgi?id=50184
This patch makes TreeShared::m_parent act as either parentNode() or
shadowHost() for Node. The distinction is controlled by IsShadowRootFlag.
Refactoring, so no new tests. See performance result testing in bug.
- dom/Element.cpp: (WebCore::Element::recalcStyle): Changed to use parentOrHostNode().
- dom/Node.cpp: (WebCore::Node::shadowHost): Added. (WebCore::Node::setShadowHost): Added. (WebCore::Node::isContentEditable): Changed to use parentOrHostNode(). (WebCore::Node::isContentRichlyEditable): Ditto. (WebCore::Node::nextRenderer): Ditto. (WebCore::Node::virtualComputedStyle): Ditto. (WebCore::Node::canStartSelection): Ditto. (WebCore::Node::shadowTreeRootNode): Changed to use parentNodeGuaranteedHostFree(). (WebCore::Node::getEventAncestors): Ditto. (WebCore::Node::defaultEventHandler): Changed to use parentOrHostNode().
- dom/Node.h: Added an extra flag and adjusted bit counts. (WebCore::Node::isShadowNode): Made non-virtual, switched to use flag. (WebCore::Node::parentNode): Made to recognize flag. (WebCore::Node::parentOrHostNode): Changed to use straight parent() and made const. (WebCore::Node::parentNodeGuaranteedHostFree): Added. (WebCore::Node::shadowParentNode): Made non-virtual and const.
- editing/TextIterator.cpp: (WebCore::depthCrossingShadowBoundaries): Changed to use parentOrHostNode(); (WebCore::nextInPreOrderCrossingShadowBoundaries): Ditto. (WebCore::previousInPostOrderCrossingShadowBoundaries): Ditto. (WebCore::setUpFullyClippedStack): Ditto. (WebCore::TextIterator::advance): Ditto. (WebCore::SimplifiedBackwardsTextIterator::advance): Ditto.
- page/DOMSelection.cpp: (WebCore::DOMSelection::anchorNode): Changed to use parentNodeGuaranteedHostFree(). (WebCore::DOMSelection::focusNode): Ditto. (WebCore::DOMSelection::baseNode): Ditto. (WebCore::DOMSelection::extentNode): Ditto. (WebCore::DOMSelection::getRangeAt): Ditto.
- rendering/MediaControlElements.cpp: (WebCore::MediaControlShadowRootElement::MediaControlShadowRootElement):
Changed to setShadowHost().
(WebCore::MediaControlShadowRootElement::updateStyle): Changed to use shadowHost().
(WebCore::MediaControlShadowRootElement::detach): Added an override to
explicitly set shadowHost to 0. Otherwise, the element will leak.
- rendering/MediaControlElements.h: Added detach def, removed members that are
no longer needed.
- rendering/RenderSVGShadowTreeRootContainer.cpp: (WebCore::RenderSVGShadowTreeRootContainer::~RenderSVGShadowTreeRootContainer):
Added explicit clearing of shadowHost to avoid leaking and crashes,
because SVG shadow DOM can be dynamically attached/detached, producing
stale nodes in over/out event handling.
- rendering/RenderSlider.cpp: (WebCore::SliderThumbElement::defaultEventHandler): Changed to use shadowHost().
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):
Added explicit clearing of shadowHost and explicit destruction to
avoid out-of-order removal of children.
- rendering/RenderTreeAsText.cpp: (WebCore::nodePosition): Simplified code.
- rendering/SVGShadowTreeElements.cpp: (WebCore::SVGShadowTreeRootElement::SVGShadowTreeRootElement): Added
setting of shadowHost.
(WebCore::SVGShadowTreeRootElement::attachElement): Changed to use shadowHost().
(WebCore::SVGShadowTreeRootElement::clearShadowHost): Added.
- rendering/SVGShadowTreeElements.h: Added def, removed members that are
no longer needed.
- rendering/ShadowElement.cpp: (WebCore::ShadowBlockElement::initAsPart): Changed to use shadowHost().
- rendering/ShadowElement.h: Removed members that are no longer needed. (WebCore::ShadowElement::ShadowElement): Added setting of shadowHost. (WebCore::ShadowElement::detach): Added.
- rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerElement::TextControlInnerElement): Added setting
of shadowHost.
(WebCore::TextControlInnerElement::attachInnerElement): Changed to use
isShadowNode().
(WebCore::TextControlInnerElement::detach): Added.
- rendering/TextControlInnerElements.h: Removed members that are no
longer needed.
- svg/SVGElement.cpp: (WebCore::SVGElement::ownerSVGElement): Simplified code. (WebCore::SVGElement::viewportElement): Ditto.
- svg/SVGLocatable.cpp: (WebCore::SVGLocatable::computeCTM): Ditto.
- svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::title): Ditto.
- svg/SVGUseElement.cpp: (WebCore::ShadowTreeUpdateBlocker::while): Ditto.
- 9:18 AM Changeset in webkit [73617] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
2010-12-09 Michael Saboff <msaboff@apple.com>
Reviewed by Darin Adler.
Changed setting of backtrack labels to not overwrite a prior
label. Where losing prior labe which then reverted back to
next character label.
https://bugs.webkit.org/show_bug.cgi?id=50579
- yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::BacktrackDestination::setBacktrackToLabel):
- 9:18 AM Changeset in webkit [73616] by
-
- 16 edits in trunk
2010-12-09 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Numeric keys are floats.
https://bugs.webkit.org/show_bug.cgi?id=50674
Update layout tests to use floating-point values for keys.
- storage/indexeddb/keyrange-expected.txt:
- storage/indexeddb/keyrange.html: Make sure creating the keys works.
- storage/indexeddb/objectstore-cursor-expected.txt:
- storage/indexeddb/objectstore-cursor.html: Make sure retrieving the keys from the DB objectstore works.
2010-12-09 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Numeric keys are floats.
https://bugs.webkit.org/show_bug.cgi?id=50674
Use floating point to represent numeric keys,
add version meta data to the SQLite db,
and migrate object stores that use integers.
- bindings/v8/IDBBindingUtilities.cpp: (WebCore::createIDBKeyFromValue):
- bindings/v8/custom/V8IDBKeyCustom.cpp: (WebCore::toV8):
- storage/IDBFactoryBackendImpl.cpp: (WebCore::createTables): (WebCore::migrateDatabase): (WebCore::IDBFactoryBackendImpl::open):
- storage/IDBKey.cpp: (WebCore::IDBKey::IDBKey): (WebCore::IDBKey::fromQuery): (WebCore::IDBKey::bind): (WebCore::IDBKey::bindWithNulls):
- storage/IDBKey.h: (WebCore::IDBKey::create): (WebCore::IDBKey::number):
2010-12-09 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Numeric keys are floats.
https://bugs.webkit.org/show_bug.cgi?id=50674
Represent numeric keys as floating point values.
- public/WebIDBKey.h: (WebKit::WebIDBKey::WebIDBKey):
- src/WebIDBKey.cpp: (WebKit::WebIDBKey::assign): (WebKit::WebIDBKey::number):
- 9:14 AM Changeset in webkit [73615] by
-
- 5 edits in trunk
2010-06-28 Michael Saboff <msaboff@apple.com>
Reviewed by Darin Adler.
Bug 41238 - RegExp performance slow on Dromaeo benchmark
Other javascript engines appear to cache prior results of regular
expression operations.
Suggest adding some sort of caching mechanism to regular expression
processing.
Added a single entry cache of match() results to RegExp class.
Also added performance improvements to UString == operator.
First check the impls for equality. Then get the length of
each of the non-null impls. Next check the sizes for equality.
Then check the data for the case of different impls that point
to the same data (most likely due to substrings from the beginning of
another string). Lastly we check the underlying data for equality.
Refactored Vector<>::operator=() method into a separate copy() method
that it calls. The copy() method is explicitly used for deep copying.
- runtime/RegExp.cpp: (JSC::RegExp::RegExp): (JSC::RegExp::match):
- runtime/RegExp.h:
- runtime/UString.h: (JSC::operator==):
- wtf/Vector.h: (WTF::::operator): (WTF::::copy):
2010-12-09 Michael Saboff <msaboff@apple.com>
Reviewed by Darin Adler.
Added test to verify proper operation of backtrack labels.
https://bugs.webkit.org/show_bug.cgi?id=50579
- fast/regex/parentheses-expected.txt:
- fast/regex/script-tests/parentheses.js:
- 8:55 AM Changeset in webkit [73614] by
-
- 26 edits2 adds in trunk
<rdar://problem/7660733> and https://bugs.webkit.org/show_bug.cgi?id=50191
WebKit2 Authentication Support
Reviewed by Maciej Stachowiak.
WebCore:
- WebCore.exp.in:
WebKit2:
Implement authentication-related coders:
- Shared/WebCoreArgumentCoders.h:
Allow the ResourceResponse coders to handle null responses:
- Shared/mac/WebCoreArgumentCodersMac.mm:
(CoreIPC::encodeResourceResponse):
(CoreIPC::decodeResourceResponse):
Add new API and Impl casts for ProtectionSpace and Credential enums:
- UIProcess/API/C/WKAPICast.h:
(WebKit::toAPI):
(WebKit::toCredentialPersistence):
Move the DecisionListener to be accessed off the challenge itself, and fill in other
necessary API:
- UIProcess/API/C/WKAuthenticationChallenge.cpp:
(WKAuthenticationChallengeGetDecisionListener):
(WKAuthenticationChallengeGetProtectionSpace):
(WKAuthenticationChallengeGetProposedCredential):
(WKAuthenticationChallengeGetPreviousFailureCount):
- UIProcess/API/C/WKAuthenticationChallenge.h:
- UIProcess/Authentication/AuthenticationChallengeProxy.cpp:
(WebKit::AuthenticationChallengeProxy::~AuthenticationChallengeProxy):
(WebKit::AuthenticationChallengeProxy::proposedCredential):
(WebKit::AuthenticationChallengeProxy::protectionSpace):
- UIProcess/Authentication/AuthenticationChallengeProxy.h:
(WebKit::AuthenticationChallengeProxy::previousFailureCount):
Fill in some credential API:
- UIProcess/API/C/WKCredential.cpp:
(WKCredentialCreate):
(WKCredentialCopyUser):
- UIProcess/API/C/WKCredential.h:
- UIProcess/API/C/WKCredentialTypes.h: Added.
- UIProcess/Authentication/WebCredential.cpp:
(WebKit::WebCredential::WebCredential):
(WebKit::WebCredential::user):
- UIProcess/Authentication/WebCredential.h:
(WebKit::WebCredential::create):
Fill in some protection space API:
- UIProcess/API/C/WKProtectionSpace.cpp:
(WKProtectionSpaceCopyHost):
(WKProtectionSpaceGetPort):
(WKProtectionSpaceCopyRealm):
(WKProtectionSpaceGetIsProxy):
(WKProtectionSpaceGetServerType):
(WKProtectionSpaceGetReceivesCredentialSecurely):
(WKProtectionSpaceGetAuthenticationScheme):
- UIProcess/API/C/WKProtectionSpace.h:
- UIProcess/API/C/WKProtectionSpaceTypes.h: Added.
- UIProcess/Authentication/WebProtectionSpace.cpp:
(WebKit::WebProtectionSpace::WebProtectionSpace):
(WebKit::WebProtectionSpace::host):
(WebKit::WebProtectionSpace::port):
(WebKit::WebProtectionSpace::realm):
(WebKit::WebProtectionSpace::isProxy):
(WebKit::WebProtectionSpace::serverType):
(WebKit::WebProtectionSpace::receivesCredentialSecurely):
(WebKit::WebProtectionSpace::authenticationScheme):
- UIProcess/Authentication/WebProtectionSpace.h:
Change the authentication challenge callback to reflect the new ownership of
the DecisionListener:
- UIProcess/API/C/WKPage.h:
- UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::didReceiveAuthenticationChallengeInFrame):
- UIProcess/WebLoaderClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveAuthenticationChallenge):
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
- win/WebKit2Generated.make:
- 8:40 AM Changeset in webkit [73613] by
-
- 3 edits6 adds in trunk
2010-12-09 Peter Beverloo <peter@lvp-media.com>
Reviewed by Maciej Stachowiak.
Default CSS definitions for the figure and figcaption elements.
- fast/html/figcaption-element-expected.txt: Added.
- fast/html/figcaption-element.html: Added.
- fast/html/figure-element-expected.txt: Added.
- fast/html/figure-element.html: Added.
- fast/html/script-tests/figcaption-element.js: Added.
- fast/html/script-tests/figure-element.js: Added.
2010-12-09 Peter Beverloo <peter@lvp-media.com>
Reviewed by Maciej Stachowiak.
Default CSS definitions for the figure and figcaption elements.
Tests: fast/html/figcaption-element.html
fast/html/figure-element.html
- css/html.css: (figure): The default figure-style equals a blockquote (figcaption): A non-sectioning block-level element
- 8:22 AM Changeset in webkit [73612] by
-
- 1 edit4 adds in trunk/LayoutTests
2010-12-09 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Antonio Gomes.
Spatial Navigation: more tests.
https://bugs.webkit.org/show_bug.cgi?id=50728
- fast/spatial-navigation/snav-hidden-focusable-element-expected.txt: Added.
- fast/spatial-navigation/snav-hidden-focusable-element.html: Added.
- fast/spatial-navigation/snav-hidden-iframe-expected.txt: Added.
- fast/spatial-navigation/snav-hidden-iframe.html: Added.
- 8:06 AM Changeset in webkit [73611] by
-
- 2 edits in trunk/WebKitTools
2010-12-09 Koan-Sin Tan <koansin.tan@gmail.com>
Reviewed by Tor Arne Vestbø
[Qt] run-launcher doesn't start the browser on Mac OS X 10.6
https://bugs.webkit.org/show_bug.cgi?id=50742
check not only QtWebKit.framework/QtWebKit but also libQtWebKit.dylib
- Scripts/webkitdirs.pm:
- 8:06 AM Changeset in webkit [73610] by
-
- 2 edits in trunk/WebKit/efl
2010-12-09 Alex Bredariol Grilo <abgrilo@profusion.mobi>
Reviewed by Antonio Gomes.
[EFL] Fix scroll operation in WebKit-EFL
https://bugs.webkit.org/show_bug.cgi?id=50752
Add the _ewk_view_scroll_add call in WebKit-EFL scroll function. This
call was wrongly removed in previous commit and performs the scroll
operation on the page.
- ewk/ewk_view.cpp: (ewk_view_scroll):
- 8:00 AM Changeset in webkit [73609] by
-
- 1 edit18 adds in trunk/LayoutTests
Unreviewed.
Add Qt specific expected results for tests introduced in r73548.
Compared to Mac png files and Mac expected files.
- platform/qt/editing/selection/caret-ltr-2-expected.checksum: Added.
- platform/qt/editing/selection/caret-ltr-2-expected.png: Added.
- platform/qt/editing/selection/caret-ltr-2-expected.txt: Added.
- platform/qt/editing/selection/caret-ltr-2-left-expected.checksum: Added.
- platform/qt/editing/selection/caret-ltr-2-left-expected.png: Added.
- platform/qt/editing/selection/caret-ltr-2-left-expected.txt: Added.
- platform/qt/editing/selection/caret-ltr-expected.checksum: Added.
- platform/qt/editing/selection/caret-ltr-expected.png: Added.
- platform/qt/editing/selection/caret-ltr-expected.txt: Added.
- platform/qt/editing/selection/caret-ltr-right-expected.checksum: Added.
- platform/qt/editing/selection/caret-ltr-right-expected.png: Added.
- platform/qt/editing/selection/caret-ltr-right-expected.txt: Added.
- platform/qt/editing/selection/caret-rtl-2-left-expected.checksum: Added.
- platform/qt/editing/selection/caret-rtl-2-left-expected.png: Added.
- platform/qt/editing/selection/caret-rtl-2-left-expected.txt: Added.
- platform/qt/editing/selection/caret-rtl-right-expected.checksum: Added.
- platform/qt/editing/selection/caret-rtl-right-expected.png: Added.
- platform/qt/editing/selection/caret-rtl-right-expected.txt: Added.
- 6:56 AM Changeset in webkit [73608] by
-
- 22 edits2 adds in trunk
2010-12-09 Joone Hur <joone@kldp.org>
Reviewed by Martin Robinson.
[GTK] Support for viewport meta tag
https://bugs.webkit.org/show_bug.cgi?id=45443
Included viewport test cases for WebKitGtk
- platform/gtk/Skipped: Unskip fast/viewport except viewport-45.html.
2010-12-09 Joone Hur <joone@kldp.org>
Reviewed by Martin Robinson.
[GTK] Support for viewport meta tag
https://bugs.webkit.org/show_bug.cgi?id=45443
This patch adds a new gobject to offer the viewport properties to user agents.
It is WebKitViewportAttributes that contains the viewport size, initial scale with limits,
and information about whether a user is able to scale the contents in the viewport.
This feature was introduced by Safari on the iPhone. For more information on
the viewport properties, refer to the Safari reference library at
http://developer.apple.com/safari/library/documentation/appleapplications/reference/safarihtmlref/articles/metatags.html
- GNUmakefile.am: Added webkitviewportattributes.h webkitviewportattributes.cpp.
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::dispatchViewportDataDidChange): Added this callback to know whether the viewport arguments is available.
- WebCoreSupport/ChromeClientGtk.h:
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::dumpConfigurationForViewport): Added this function to compute the viewport attributes with the given availableWidth and availableHeight.
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::postCommitFrameViewSetup): Invalidate the viewport attributes.
- webkit/webkit.h:
- webkit/webkitdefines.h:
- webkit/webkitprivate.h: Added webkitViewportAttributesRecompute as a private function.
- webkit/webkitviewportattributes.cpp: Added. (webkit_viewport_attributes_class_init): (webkit_viewport_attributes_init): (webkit_viewport_attributes_get_property): (webkit_viewport_attributes_set_property): (webkitViewportAttributesRecompute): Recompute the optimal viewport attributes and emit the viewport-attributes-changed signal. (webkit_viewport_attributes_recompute): a public API for calling webkitViewportAttributesRecompute.
- webkit/webkitviewportattributes.h: Added.
- webkit/webkitwebview.cpp: (webkit_web_view_get_property): Added PROP_VIEWPORT_ATTRIBUTES. (webkit_web_view_dispose): Deallocate the WebKitViewportAttributes instance. (webkit_web_view_class_init): Added the viewport-attributes-recompute-requested and viewport-attributes-changed signals. (webkit_web_view_init): Set the WebKitViewportAttributes instance. (webkit_web_view_get_viewport_attributes): Added a getter to obtain the WebKitViewportAttributes instance held by the given WebKitWebView.
- webkit/webkitwebview.h:
- webkit/webkitwebviewprivate.h: Added WebKitViewportAttributes as a private variable.
2010-12-09 Joone Hur <joone@kldp.org>
Reviewed by Martin Robinson.
[GTK] Support for viewport meta tag
https://bugs.webkit.org/show_bug.cgi?id=45443
Add support for testing the viewport properties for WebKitGtk.
- DumpRenderTree/LayoutTestController.cpp: (dumpConfigurationForViewportCallback): Added this JS callback to set the size of the visible viewport. (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::dumpConfigurationForViewport): Added this function to test the viewport properties.
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::dumpConfigurationForViewport): Ditto.
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::dumpConfigurationForViewport): Ditto.
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::dumpConfigurationForViewport): Ditto.
- DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::dumpConfigurationForViewport): Ditto.
- 5:57 AM QtWebKitFeatures21 edited by
- (diff)
- 5:34 AM Changeset in webkit [73607] by
-
- 14 edits1 copy1 add in trunk
2010-12-09 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Console records for failed XHRs should contain call stack and request method
https://bugs.webkit.org/show_bug.cgi?id=50390
The expectations needed update ue to log format changes.
- http/tests/inspector-enabled/console-log-before-frame-navigation-expected.txt:
- http/tests/inspector/console-resource-errors-expected.txt:
- http/tests/inspector/console-xhr-logging-expected.txt:
- platform/chromium/http/tests/inspector/console-resource-errors-expected.txt: Added.
- platform/chromium/http/tests/inspector/console-xhr-logging-expected.txt: Copied from LayoutTests/http/tests/inspector/console-xhr-logging-expected.txt.
2010-12-09 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Console records for failed XHRs should contain call stack and request method
https://bugs.webkit.org/show_bug.cgi?id=50390
When inspector front-end is open we capture call stack at the place where request is sent and
pass the stack along with other request data. There is a new type of console messages which
is NetworkErrorMessageType, all messages of that type will have requestId field initialized
with the corresponding network request identifier so that later on when we need to display
that message in the front-end we could pull request data from the Network panel using
this identifier. If there are no data for given requestId message formatting falls back to
the old implementation which lacks such things as call stack, request method and exact
source location.
- inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::ConsoleMessage): (WebCore::ConsoleMessage::addToFrontend): (WebCore::ConsoleMessage::isEqual):
- inspector/ConsoleMessage.h:
- inspector/Inspector.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didFailLoading):
- inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::identifierForInitialRequest):
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.updateMessageRepeatCount): (WebInspector.ConsoleMessage): (WebInspector.ConsoleMessage.prototype._formatMessage): (WebInspector.ConsoleMessage.prototype.toMessageElement): (WebInspector.ConsoleMessage.prototype.toString): (WebInspector.ConsoleMessage.prototype.isEqual):
- inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager.prototype.identifierForInitialRequest):
- inspector/front-end/inspector.js: (WebInspector.addConsoleMessage):
- page/Console.h:
- 5:07 AM Changeset in webkit [73606] by
-
- 23 edits5 adds in trunk
2010-12-09 Dai Mikurube <dmikurube@google.com>
Reviewed by Kent Tamura.
Implement "required" attribute for select tags
https://bugs.webkit.org/show_bug.cgi?id=50380
Added tests for require attributes, valueMissing and vadility check for select elements.
- fast/forms/ValidityState-valueMissing-001-expected.txt:
- fast/forms/ValidityState-valueMissing-001.html:
- fast/forms/ValidityState-valueMissing-002-expected.txt:
- fast/forms/ValidityState-valueMissing-002.html:
- fast/forms/ValidityState-valueMissing-003-expected.txt:
- fast/forms/ValidityState-valueMissing-003.html:
- fast/forms/checkValidity-002-expected.txt:
- fast/forms/checkValidity-002.html:
- fast/forms/required-attribute-001-expected.txt:
- fast/forms/required-attribute-001.html:
- fast/forms/required-attribute-002-expected.txt:
- fast/forms/required-attribute-002.html:
- fast/forms/resources/select-live-pseudo-selectors.js: Added. (makeInvalid): (appendOption): (backgroundOf):
- fast/forms/script-tests/validationMessage.js:
- fast/forms/select-live-pseudo-selectors-expected.txt: Added.
- fast/forms/select-live-pseudo-selectors.html: Added.
- fast/forms/validationMessage-expected.txt:
- platform/mac/fast/objc/dom-html-select-live-pseudo-selectors.html: Added.
- platform/mac/fast/objc/dom-html-select-live-pseudo-selectors-expected.txt: Added.
2010-12-09 Dai Mikurube <dmikurube@google.com>
Reviewed by Kent Tamura.
Implement "required" attribute for select tags
https://bugs.webkit.org/show_bug.cgi?id=50380
Test: fast/forms/select-live-pseudo-selectors.html
platform/mac/fast/objc/dom-html-select-live-pseudo-selectors.html
- dom/SelectElement.cpp: (WebCore::SelectElement::updateValidity): Added. It's a pure virtual function which is prepared so that HTMLSelectElement::updateValidity() calls HTMLSelectElement::setNeedsValidityCheck(). (WebCore::SelectElement::parseMultipleAttribute): Added calling updateValidity().
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::deselectItems): Added calling setNeedsValidityCheck() to enable validity check after changing. No tests for this change since this function is not exposed to JavaScript or any web interface. (WebCore::HTMLSelectElement::setSelectedIndex): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::setSelectedIndexByUser): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::valueMissing): Added valueMissing() to check if selecting an invalid or placeholder label option when a valid required attribute is specified. (WebCore::HTMLSelectElement::listBoxSelectItem): Added calling setNeedsValidityCheck(). No tests for this change since it is not called yet. Look at the bug 36177 and the changeset 56180. (WebCore::HTMLSelectElement::add): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::remove): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::restoreFormControlState): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::parseMappedAttribute): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::selectAll): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::reset): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::updateListBoxSelection): Added calling setNeedsValidityCheck(). Skipped adding tests for this change as too complicated.. (WebCore::HTMLSelectElement::setLength): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::isRequiredFormControl): Check if required or not. (WebCore::HTMLSelectElement::hasPlaceholderLabelOption): Added. (WebCore::HTMLSelectElement::updateValidity): Added. It calls setNeedsValidityCheck().
- html/HTMLSelectElement.h: (WebCore::HTMLSelectElement::isOptionalFormControl): Check if not required.
- html/HTMLSelectElement.idl: Added a required attribute to select elements..
- html/ValidityState.cpp: (WebCore::ValidityState::valueMissing): Added valueMissing check for select elements into the global checker, ValidityState::valueMissing().
- wml/WMLSelectElement.h: (WebCore::WMLSelectElement::updateValidity): Added. It does nothing.
- 4:29 AM Changeset in webkit [73605] by
-
- 13 edits in trunk
2010-12-07 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
IndexedDB returns the wrong exceptions
https://bugs.webkit.org/show_bug.cgi?id=50632
- storage/indexeddb/constants-expected.txt:
- storage/indexeddb/constants.html:
- storage/indexeddb/objectstore-removeobjectstore-expected.txt:
- storage/indexeddb/objectstore-removeobjectstore.html:
2010-12-07 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
IndexedDB returns the wrong exceptions
https://bugs.webkit.org/show_bug.cgi?id=50632
IndexedDB exceptions need to have an offset so they can
be distinguished from DOM exceptions. We also need to
add strings for the various exceptions. Lastly, make
IDBDatabaseException use the common exception base class.
- bindings/js/JSDOMBinding.cpp: (WebCore::setDOMException):
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::setDOMException):
- dom/ExceptionCode.cpp: (WebCore::getExceptionCodeDescription):
- dom/ExceptionCode.h:
- storage/IDBDatabaseError.h: (WebCore::IDBDatabaseError::code):
- storage/IDBDatabaseException.h: (WebCore::IDBDatabaseException::create): (WebCore::IDBDatabaseException::ErrorCodeToExceptionCode): (WebCore::IDBDatabaseException::IDBDatabaseException):
- storage/IDBDatabaseException.idl:
- 4:15 AM BuildingGtk edited by
- (diff)
- 4:09 AM Changeset in webkit [73604] by
-
- 2 edits in trunk/WebKit/gtk
2010-12-09 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
Fix 'make install' woes with some versions of automake.
- GNUmakefile.am: use $(top_builddir) instead of $(builddir), since we actually want a valid path for the file regardless of the place from where the script is called.
- 3:18 AM Changeset in webkit [73603] by
-
- 2 edits in trunk/WebCore
2010-12-09 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Build fix for GTK+3. Use functions added for GTK+ 2.24 to get the
GDK window size.
- plugins/gtk/gtk2xtbin.c: (gtk_xtbin_realize):
- 3:12 AM Changeset in webkit [73602] by
-
- 4 edits in trunk
2010-12-09 Siddharth Mathur <siddharth.mathur@nokia.com>
Reviewed by Laszlo Gombos.
Use BUILDING_WEBKIT like other ports
https://bugs.webkit.org/show_bug.cgi?id=50713
- WebCore.pro: Change BUILD_WEBKIT to BUILDING_WEBKIT
2010-12-09 Siddharth Mathur <siddharth.mathur@nokia.com>
Reviewed by Laszlo Gombos.
Use BUILDING_WEBKIT like other ports
https://bugs.webkit.org/show_bug.cgi?id=50713
- Api/qwebkitglobal.h: change BUILD_WEBKIT to BUILDING_WEBKIT
- 3:12 AM Changeset in webkit [73601] by
-
- 2 edits7 adds in trunk/LayoutTests
2010-12-09 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Rebaselined Chromium expectations.
Reverts r73518 and r73522.
- platform/chromium-linux/fast/forms/placeholder-position-expected.checksum: Added.
- platform/chromium-linux/fast/forms/placeholder-position-expected.png: Added.
- platform/chromium-mac/fast/forms/placeholder-position-expected.checksum: Added.
- platform/chromium-mac/fast/forms/placeholder-position-expected.png: Added.
- platform/chromium-win/fast/forms/placeholder-position-expected.checksum: Added.
- platform/chromium-win/fast/forms/placeholder-position-expected.png: Added.
- platform/chromium-win/fast/forms/placeholder-position-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 3:07 AM Changeset in webkit [73600] by
-
- 2 edits in trunk
2010-12-09 Philippe Normand <pnormand@igalia.com>
Reviewed by Xan Lopez.
[GTK] configure: error out if video is enabled and gstreamer pkg-config check fails
https://bugs.webkit.org/show_bug.cgi?id=50741
- configure.ac:
- 2:41 AM Changeset in webkit [73599] by
-
- 1 edit2 adds in trunk/LayoutTests
Unreviewed. Add Qt specific expected results for tests introduced in r73529.
- platform/qt/fast/events/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt: Added.
- platform/qt/fast/events/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt: Added.
- 2:03 AM Changeset in webkit [73598] by
-
- 16 edits in trunk/LayoutTests
2010-12-09 Martin Robinson <mrobinson@igalia.com>
Update GTK+ baselines after r73561.
- platform/gtk/fast/css/input-search-padding-expected.txt:
- platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt:
- platform/gtk/fast/forms/box-shadow-override-expected.txt:
- platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
- platform/gtk/fast/forms/input-appearance-height-expected.txt:
- platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
- platform/gtk/fast/forms/placeholder-set-value-expected.txt:
- platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.txt:
- platform/gtk/fast/forms/search-placeholder-value-changed-expected.txt:
- platform/gtk/fast/forms/search-rtl-expected.txt:
- platform/gtk/fast/forms/search-styled-expected.txt:
- platform/gtk/fast/forms/search-transformed-expected.txt:
- platform/gtk/fast/forms/search-vertical-alignment-expected.txt:
- platform/gtk/fast/forms/search-zoomed-expected.txt:
- platform/gtk/fast/forms/searchfield-heights-expected.txt:
- 1:37 AM Changeset in webkit [73597] by
-
- 3 edits in trunk/LayoutTests
2010-12-09 Philippe Normand <pnormand@igalia.com>
Unreviewed, update test baselines as asked by MORITA Hajime.
[GTK] r73488 broke fast/dom/HTMLProgressElement/progress-element.html
https://bugs.webkit.org/show_bug.cgi?id=50687
- platform/gtk/fast/dom/HTMLProgressElement/progress-element-expected.txt:
- platform/gtk/Skipped:
- 12:09 AM Changeset in webkit [73596] by
-
- 10 edits in trunk/LayoutTests
2010-12-09 Yuta Kitamura <yutak@chromium.org>
Unreviewed.
Chromium rebaselines for r73488.
- platform/chromium-mac/fast/dom/HTMLProgressElement/progress-element-expected.txt:
- platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
- platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
- platform/chromium-win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
- platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
- platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
- platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
- platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.txt:
- platform/chromium/test_expectations.txt:
Dec 8, 2010:
- 10:43 PM Changeset in webkit [73595] by
-
- 2 edits in trunk/LayoutTests
2010-12-08 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Updated Chromium expectations.
- platform/chromium/test_expectations.txt:
- 9:40 PM Changeset in webkit [73594] by
-
- 9 edits in trunk
Permit Character Class Escape in CharacterRange in Character Class.
https://bugs.webkit.org/show_bug.cgi?id=50483
https://bugs.webkit.org/show_bug.cgi?id=50538
https://bugs.webkit.org/show_bug.cgi?id=50654
https://bugs.webkit.org/show_bug.cgi?id=50646
Reviewed by Sam Weinig.
We recently tightened up our spec conformance in generating syntax
error in these cases, however testing in the wild has shown this
to be problematic. This reverts the previous change in allowing
class escapes (e.g. \d) in ranges in character classes ([]), but
does retain some closer conformance to the spec in only allowing
ranges that would be permitted per the grammar rules in the spec
(e.g. in /[\d-a-z]/ "a-z" cannot be considered as a range).
- yarr/RegexParser.h:
(JSC::Yarr::Parser::CharacterClassParserDelegate::atomPatternCharacter):
(JSC::Yarr::Parser::CharacterClassParserDelegate::atomBuiltInCharacterClass):
(JSC::Yarr::Parser::parse):
LayoutTests:
- fast/js/regexp-ranges-and-escaped-hyphens-expected.txt:
- fast/js/script-tests/regexp-ranges-and-escaped-hyphens.js:
- fast/regex/invalid-range-in-class-expected.txt:
- fast/regex/pcre-test-1-expected.txt:
- fast/regex/script-tests/invalid-range-in-class.js:
- fast/regex/script-tests/pcre-test-1.js:
- 9:03 PM Changeset in webkit [73593] by
-
- 2 edits in trunk/LayoutTests
2010-12-08 Yuta Kitamura <yutak@chromium.org>
Unreviewed.
Update Chromium test expectations.
- platform/chromium/test_expectations.txt:
- 8:32 PM Changeset in webkit [73592] by
-
- 2 edits in trunk/JavaScriptCore
Try to fix crash-on-launch seen on Windows builder.
Reviewed by Sam Weinig.
- wtf/OSAllocatorWin.cpp:
(WTF::OSAllocator::release): Disabled an ASSERT, because it checks for
a bug that hasn't been fixed yet.
- 8:30 PM Changeset in webkit [73591] by
-
- 5 edits in trunk/WebKit2
Fix typo: Diplaying -> Displaying
Reviewed by Geoffrey "Error" Garen.
- UIProcess/API/C/WKFrame.cpp:
(WKFrameIsDisplayingStandaloneImageDocument):
(WKFrameIsDisplayingMarkupDocument):
- UIProcess/API/C/WKFrame.h:
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::canProvideSource):
(WebKit::WebFrameProxy::isDisplayingStandaloneImageDocument):
(WebKit::WebFrameProxy::isDisplayingMarkupDocument):
- UIProcess/WebFrameProxy.h:
- 8:22 PM Changeset in webkit [73590] by
-
- 3 edits in trunk/WebKitTools
2010-12-08 William Siegrist <wsiegrist@apple.com>
Reviewed by Eric Seidel.
Migrate buildbot.py from xmlrpc to json.
https://bugs.webkit.org/show_bug.cgi?id=50647
- Scripts/webkitpy/common/net/buildbot.py:
- 7:55 PM Changeset in webkit [73589] by
-
- 10 edits in trunk/WebCore
2010-12-08 Erik Arvidsson <arv@chromium.org>
Reviewed by Darin Adler.
Replace getAttribute().isNull() with fastHasAttribute()
https://bugs.webkit.org/show_bug.cgi?id=50719
Covered by existing tests.
- dom/SelectElement.cpp: (WebCore::SelectElement::reset):
- html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::rendererIsNeeded):
- html/HTMLCollection.cpp: (WebCore::HTMLCollection::itemAfter):
- html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::formNoValidate):
- html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::noValidate):
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultChecked): (WebCore::HTMLInputElement::multiple): (WebCore::HTMLInputElement::webkitdirectory):
- html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::defaultSelected):
- html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::asyncAttributeValue): (WebCore::HTMLScriptElement::deferAttributeValue):
- rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::allowsMultipleFiles): (WebCore::RenderFileUploadControl::allowsDirectoryUpload):
- 7:37 PM Changeset in webkit [73588] by
-
- 2 edits2 adds2 deletes in trunk/LayoutTests
2010-12-08 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed; Yet another Chromium rebaselines for r73548.
- platform/chromium-mac-leopard/editing/selection/caret-rtl-2-expected.checksum: Removed.
- platform/chromium-mac-leopard/editing/selection/caret-rtl-2-expected.png: Removed.
- platform/chromium-mac/fast/text/international/khmer-selection-expected.checksum: Added.
- platform/chromium-mac/fast/text/international/khmer-selection-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 7:33 PM Changeset in webkit [73587] by
-
- 2 edits1 add in trunk/WebCore
2010-12-08 Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>
Reviewed by Martin Robinson.
Full page size flash plugins do not show in all situations
https://bugs.webkit.org/show_bug.cgi?id=47742
This patch moves the plugin widget size allocation after the
NPP_SetWindow is called with the effect that the resize of Flash
content no longer result in grey flash. This seems logical since the
widget tree cannot be fully constructed before the plugin receives
the new container window.
Test: manual-tests/plugins/gtk-windowed-grey-glitch.html
- plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::setNPWindowIfNeeded):
- 7:29 PM Changeset in webkit [73586] by
-
- 2 edits in trunk/WebCore
Fix regression from xji's wheel scroll patch. The vertical case is looking at the horizontal
maximum position and not the vertical position.
Reviewed by Simon Fraser.
- platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
- 7:13 PM Changeset in webkit [73585] by
-
- 2 edits in trunk/WebKit/mac
2010-12-08 Andy Estes <aestes@apple.com>
Reviewed by Darin Adler.
Enable pre-HTML5 parser quirks for Apple Mail.app
https://bugs.webkit.org/show_bug.cgi?id=50727
- WebView/WebView.mm: (-[WebView _needsPreHTML5ParserQuirks]): Return true if the embedding application is Mail.app.
- 7:10 PM Changeset in webkit [73584] by
-
- 4 edits in trunk/WebKit/qt
2010-12-08 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Support OrientationChange event
https://bugs.webkit.org/show_bug.cgi?id=50685
Get OrientationChange event from qtmobility then send to webkit.
- Api/qwebframe.cpp: (QWebFrame::orientationChanged): (QWebFrame::QWebFrame):
- Api/qwebframe.h:
- Api/qwebframe_p.h:
- 6:25 PM Changeset in webkit [73583] by
-
- 2 edits in trunk/WebCore
Need a way to get a WKBundleFrameRef from JS HTMLIFrameElement
https://bugs.webkit.org/show_bug.cgi?id=50726
Reviewed by Darin Adler.
- WebCore.xcodeproj/project.pbxproj: Expose HTMLIFrameElement.h.
- 6:20 PM Changeset in webkit [73582] by
-
- 7 edits in trunk/WebKit2
Add WebKit2 Preference for TabsToLinks behavior.
<rdar://problem/8664263>
Reviewed by Gavin Barraclough.
- Shared/WebPreferencesStore.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetTabsToLinks):
(WKPreferencesGetTabsToLinks):
- UIProcess/API/C/WKPreferences.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::tabsToLinks):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::updatePreferences):
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::tabsToLinks):
- 6:15 PM Changeset in webkit [73581] by
-
- 2 edits in trunk/WebKit2
2010-12-08 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Andreas Kling.
WebTouchEvent::isTouchEventType() does not take into account the type TouchCancel
https://bugs.webkit.org/show_bug.cgi?id=50680
Add the missing type check to WebTouchEvent::isTouchEventType().
- Shared/WebTouchEvent.cpp: (WebKit::WebTouchEvent::isTouchEventType):
- 6:03 PM Changeset in webkit [73580] by
-
- 2 edits in trunk/JavaScriptCore
Try to fix Windows build.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Updated .def file.
- 6:02 PM Changeset in webkit [73579] by
-
- 5 edits in trunk/WebKit2
Need a way to get a WKBundleFrameRef from JS HTMLIFrameElement
https://bugs.webkit.org/show_bug.cgi?id=50726
Reviewed by Darin Adler.
Adds WKBundleNodeHandleCopyDocumentFrame, WKBundleNodeHandleCopyHTMLFrameElementContentFrame
and WKBundleNodeHandleCopyHTMLIFrameElementContentFrame, to handle the document, <frame>
and <iframe> cases.
- WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:
(WKBundleNodeHandleCopyDocumentFrame):
(WKBundleNodeHandleCopyHTMLFrameElementContentFrame):
(WKBundleNodeHandleCopyHTMLIFrameElementContentFrame):
- WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::InjectedBundleNodeHandle::copyDocumentFrame):
(WebKit::InjectedBundleNodeHandle::copyHTMLFrameElementContentFrame):
(WebKit::InjectedBundleNodeHandle::copyHTMLIFrameElementContentFrame):
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
- 5:54 PM Changeset in webkit [73578] by
-
- 7 edits in trunk/WebCore
2010-12-08 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Add getter and setters for acceleratesRendering flag on layers
https://bugs.webkit.org/show_bug.cgi?id=50717
- platform/graphics/GraphicsLayer.cpp:
- platform/graphics/ca/GraphicsLayerCA.cpp:
- platform/graphics/ca/mac/PlatformCALayerMac.mm: Plumbed through acceleratedRendering flag.
- 5:50 PM Changeset in webkit [73577] by
-
- 2 edits in trunk/JavaScriptCore
Try to fix Windows build.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Updated .def
file to remove a symbol -- the next build failure will say which symbol
to add back.
- 5:45 PM Changeset in webkit [73576] by
-
- 2 edits2 deletes in trunk/LayoutTests
2010-12-08 Kent Tamura <tkent@chromium.org>
Unreviewed, test expectation update.
Update expectations for r73566.
- platform/gtk/editing/selection/find-yensign-and-backslash-expected.txt:
- platform/qt/editing/selection/find-yensign-and-backslash-expected.txt: Removed.
- platform/win/editing/selection/find-yensign-and-backslash-expected.txt: Removed.
- 5:42 PM Changeset in webkit [73575] by
-
- 2 edits in trunk/JavaScriptCore
Try to fix Windows build.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Updated .def file.
- 5:41 PM Changeset in webkit [73574] by
-
- 5 edits in trunk/WebKit2
Need a WebKit2 way to test whether a frame is displaying a standalone image
<rdar://problem/8443059>
WebKit2: Need a way to test whether a page or frame is showing HTML content
<rdar://problem/8642563>
Reviewed by Gavin Barraclough.
Add WKFrameIsDiplayingStandaloneImageDocument and WKFrameIsDiplayingMarkupDocument.
- UIProcess/API/C/WKFrame.cpp:
(WKFrameIsDiplayingStandaloneImageDocument):
(WKFrameIsDiplayingMarkupDocument):
- UIProcess/API/C/WKFrame.h:
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::canProvideSource): This now just calls isDiplayingMarkupDocument.
(WebKit::WebFrameProxy::isDiplayingStandaloneImageDocument):
(WebKit::WebFrameProxy::isDiplayingMarkupDocument):
- UIProcess/WebFrameProxy.h:
- 5:38 PM Changeset in webkit [73573] by
-
- 9 edits in trunk
2010-12-07 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
WebGLUniformLocation objects must be invalidated during linkProgram
https://bugs.webkit.org/show_bug.cgi?id=37118
- html/canvas/WebGLProgram.cpp: (WebCore::WebGLProgram::WebGLProgram): Initialize link count to 0. (WebCore::WebGLProgram::cacheActiveAttribLocations): Don't check link status through gl call; use the cached status instead.
- html/canvas/WebGLProgram.h: (WebCore::WebGLProgram::getLinkCount): Get link count. (WebCore::WebGLProgram::increaseLinkCount): Increase link count by 1.
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getUniform): Fix a bug where wrong error is generated. (WebCore::WebGLRenderingContext::linkProgram): call increaseLinkCount after linkProgram.
- html/canvas/WebGLUniformLocation.cpp: (WebCore::WebGLUniformLocation::WebGLUniformLocation): Set program's link count upon creation. (WebCore::WebGLUniformLocation::program): Return null if count doesn't match the program's. (WebCore::WebGLUniformLocation::location): Return -1 if count doesn't match the program's.
- html/canvas/WebGLUniformLocation.h:
2010-12-07 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
WebGLUniformLocation objects must be invalidated during linkProgram
https://bugs.webkit.org/show_bug.cgi?id=37118
- fast/canvas/webgl/uniform-location-expected.txt:
- fast/canvas/webgl/uniform-location.html: Check that after linkProgram, all previous uniform locations become invalid.
- 5:36 PM Changeset in webkit [73572] by
-
- 8 edits4 adds in trunk
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=50725
<rdar://problem/8694972> REGRESSION (r72052): "Search" placeholder in MobileMe mail is positioned too high
Reviewed by Darin Adler.
Test: fast/forms/placeholder-position.html
Since we center the inner text element for single line text controls,
we should ask the subclass to give us the y offset instead of trying to calculate it in the RenderTextControl class.
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::paintPlaceholder):
- rendering/RenderTextControl.h:
- rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::textBlockInsetTop):
- rendering/RenderTextControlMultiLine.h:
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::textBlockInsetTop):
- rendering/RenderTextControlSingleLine.h:
LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=50725
<rdar://problem/8694972> REGRESSION (r72052): "Search" placeholder in MobileMe mail is positioned too high
Reviewed by Darin Adler.
- fast/forms/placeholder-position.html: Added.
- platform/mac/fast/forms/placeholder-position-expected.checksum: Added.
- platform/mac/fast/forms/placeholder-position-expected.png: Added.
- platform/mac/fast/forms/placeholder-position-expected.txt: Added.
- 5:35 PM Changeset in webkit [73571] by
-
- 3 edits in trunk/JavaScriptCore
Try to fix GTK Linux build.
- jit/ExecutableAllocator.cpp:
(JSC::ExecutablePool::systemAlloc):
- runtime/AlignedMemoryAllocator.h:
(JSC::::AlignedMemoryAllocator): Updated for Usage enum moving to OSAllocator.
- 5:30 PM Changeset in webkit [73570] by
-
- 12 edits in trunk/JavaScriptCore
Migrated OS-specific allocation code from PageReservation and PageAllocation to OSAllocator
https://bugs.webkit.org/show_bug.cgi?id=50653
Reviewed by Sam Weinig.
- JavaScriptCore.exp: Updated for new function signature.
- interpreter/RegisterFile.h:
(JSC::RegisterFile::RegisterFile):
(JSC::RegisterFile::grow):
- jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::FixedVMPoolAllocator::reuse):
(JSC::FixedVMPoolAllocator::FixedVMPoolAllocator): Removed checkAllocatedOkay.
OSAllocator is now the central location for verifying that allocation succeeds.
This allowed me to remove some complicating cross-platform cruft.
- runtime/AlignedMemoryAllocator.h:
(JSC::::allocate): Updated for code motion.
- wtf/OSAllocator.h: Added Usage, writable, and executable parameters, to
support VM features required by clients of PageAllocation and PageReservation.
- wtf/OSAllocatorPosix.cpp:
(WTF::OSAllocator::reserve):
(WTF::OSAllocator::reserveAndCommit):
(WTF::OSAllocator::commit): Moved PageAllocation support for randomizing
executable memory here.
- wtf/OSAllocatorSymbian.cpp:
(WTF::OSAllocator::reserve):
(WTF::OSAllocator::reserveAndCommit):
(WTF::OSAllocator::commit): Updated for new function signatures.
- wtf/OSAllocatorWin.cpp:
(WTF::protection):
(WTF::OSAllocator::reserve):
(WTF::OSAllocator::reserveAndCommit):
(WTF::OSAllocator::commit):
(WTF::OSAllocator::release): Updated for new function signatures. Moved
some protection-related and WINCE-related code from PageAllocation here.
- wtf/PageAllocation.cpp: Nixed cross-platform lastError abstraction, since
it was only used by checkAllocatedOkay, which is now gone.
- wtf/PageAllocation.h:
(WTF::PageAllocation::allocate):
(WTF::PageAllocation::allocateAligned):
(WTF::PageAllocation::deallocate):
(WTF::PageAllocation::isPowerOfTwo):
(WTF::PageAllocation::systemAllocateAligned): Removed system* functions,
and replaced calls to them with calls to OSAllocator.
- wtf/PageReservation.h:
(WTF::PageReservation::commit):
(WTF::PageReservation::decommit):
(WTF::PageReservation::reserve):
(WTF::PageReservation::deallocate):
(WTF::PageReservation::PageReservation): Ditto. Added m_writable and
m_executable because these flags are now required when committing memory.
- 5:09 PM Changeset in webkit [73569] by
-
- 4 edits in trunk/WebKit2
WebFrameProxy::canShowMIMEType should return true for PDF MIME types in the main frame
https://bugs.webkit.org/show_bug.cgi?id=50724
Reviewed by Darin Adler.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::pdfAndPostScriptMIMETypes):
- UIProcess/WebContext.h:
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::canShowMIMEType):
- 5:03 PM Changeset in webkit [73568] by
-
- 5 edits in trunk
2010-12-08 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Add web audio files to mac port Xcode projects
https://bugs.webkit.org/show_bug.cgi?id=50721
- JavaScriptCore.xcodeproj/project.pbxproj:
2010-12-08 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Add web audio files to mac port Xcode projects
https://bugs.webkit.org/show_bug.cgi?id=50721
No new tests since audio API is not yet implemented.
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::webkitAudioContext):
- 5:03 PM Changeset in webkit [73567] by
-
- 2 edits in trunk/WebKit2
WebMenuTarget implemented in both WebKit and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=50665
<rdar://problem/8742640>
Reviewed by Brady Eidson.
Rename WebMenuTarget to WKMenuTarget to prevent this warning and stay consistent with
other WebKit2 namings.
- UIProcess/mac/WebContextMenuProxyMac.mm:
(+[WKMenuTarget sharedMenuTarget]):
(WebKit::nsMenuItemVector):
(WebKit::WebContextMenuProxyMac::showContextMenu):
- 4:54 PM Changeset in webkit [73566] by
-
- 8 edits in trunk
Yensign hack should work with Shift_JIS and ISO-2022-JP encodings.
https://bugs.webkit.org/show_bug.cgi?id=49714
Reviewed by Alexey Proskuryakov.
WebCore:
IE chooses a font which shows a yensign for 0x5c code point for a page
encoded in x-mac-japanese, ISO-2022-JP, EUC-JP, Shift_JIS, Shift_JIS_X0213-2000,
x-sjis, and Windows-31J.
We have emulated this behavior by replacing 0x5c with 0xa5 for EUC-JP and
Shift_JIS_X0213-2000. This change adds other encodings above.
Also, we move the HashSet initialization for isJapanese() and
backslashAsCurrencySymbol() to TextEncodingRegistry.cpp because of
ease of making them multi-thread safe.
- platform/text/TextEncoding.cpp:
(WebCore::TextEncoding::isJapanese): Just calls isJapaneseEncoding().
(WebCore::TextEncoding::backslashAsCurrencySymbol): Uses shouldShowBackslashAsCurrencySymbolIn().
- platform/text/TextEncodingRegistry.cpp:
(WebCore::addEncodingName): Moved from TextEncoding.cpp, and stop using atomicCanonicalTextEncodingName().
(WebCore::buildQuirksSets): Added. Initializes HashSets for isJapaneseEncoding() and shouldShowBackslashAsCurrencySymbolIn().
(WebCore::isJapaneseEncoding):
(WebCore::shouldShowBackslashAsCurrencySymbolIn):
(WebCore::extendTextCodecMaps): Add a call to buildQuirksSets().
- platform/text/TextEncodingRegistry.h:
LayoutTests:
Use Shift_JIS instead of Shift_JIS_X0213-2000 because Shift_JIS_X0213-2000
encoding is available only on Mac.
Add a test for ISO-2022-JP.
- editing/selection/find-yensign-and-backslash-expected.txt:
- editing/selection/find-yensign-and-backslash.html:
- platform/chromium/test_expectations.txt:
- 4:47 PM Changeset in webkit [73565] by
-
- 7 edits in trunk/WebKit2
Move canShowMIMEType to Frame
https://bugs.webkit.org/show_bug.cgi?id=50723
Reviewed by Sam Weinig.
- UIProcess/API/C/WKFrame.cpp:
(WKFrameCanShowMIMEType):
- UIProcess/API/C/WKFrame.h:
- UIProcess/API/C/WKPage.cpp:
- UIProcess/API/C/WKPage.h:
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::canShowMIMEType):
- UIProcess/WebFrameProxy.h:
- 4:37 PM Changeset in webkit [73564] by
-
- 15 edits in trunk
2010-12-08 Andy Estes <aestes@apple.com>
Reviewed by Darin Adler.
Reflected unsigned attributes should be in the range [0, 231).
https://bugs.webkit.org/show_bug.cgi?id=50472
HTML5 says that unsigned reflected attributes should be in the range
[0, 231). When a value isn't in this range, a default value (or 0)
should be returned instead. Update the JS bindings code generator to
ensure 0 is returned when a content attribute value falls outside of
this range.
Tests: bindings/scripts/test/TestObj.idl
fast/html/marquee-element.html
- bindings/scripts/CodeGeneratorJS.pm: Return the maximum of 0 and the content attribute as a 32-bit signed int when converting a native value to an unsigned JS value.
- bindings/scripts/test/TestObj.idl: Add a reflected unsigned attribute to test code generation.
- bindings/scripts/test/CPP/WebDOMTestObj.cpp: Update test results.
- bindings/scripts/test/CPP/WebDOMTestObj.h: Ditto.
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Ditto.
- bindings/scripts/test/GObject/WebKitDOMTestObj.h: Ditto.
- bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
- bindings/scripts/test/JS/JSTestObj.h: Ditto.
- bindings/scripts/test/ObjC/DOMTestObj.h: Ditto.
- bindings/scripts/test/ObjC/DOMTestObj.mm: Ditto.
- bindings/scripts/test/V8/V8TestObj.cpp: Ditto.
2010-12-08 Andy Estes <aestes@apple.com>
Reviewed by Darin Adler.
Reflected unsigned attributes should be in the range [0, 231).
https://bugs.webkit.org/show_bug.cgi?id=50472
- fast/html/marquee-element.html: Give hspace and vspace negative values and test what their corresponding IDL attributes reflect.
- fast/html/marquee-element-expected.txt:
- 4:13 PM Changeset in webkit [73563] by
-
- 4 edits in trunk/WebKitTools
2010-12-08 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
make starting the websocket server more reliable on windows
https://bugs.webkit.org/show_bug.cgi?id=50712
- Scripts/webkitpy/common/system/filesystem.py: (remove): Substitute method for os.remove to retry on error on Windows
- Scripts/webkitpy/common/system/filesystem_unittest.py:
- Scripts/webkitpy/layout_tests/port/http_server_base.py: Use FileSystem.remove
- 3:58 PM Changeset in webkit [73562] by
-
- 8 edits3 deletes in trunk/LayoutTests
2010-12-08 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed Chromium rebaseline for r73548.
- platform/chromium-linux/fast/text/international/khmer-selection-expected.checksum:
- platform/chromium-linux/fast/text/international/khmer-selection-expected.png:
- platform/chromium-linux/fast/text/international/khmer-selection-expected.txt:
- platform/chromium-win-xp/fast/text/international/khmer-selection-expected.checksum: Removed.
- platform/chromium-win-xp/fast/text/international/khmer-selection-expected.png: Removed.
- platform/chromium-win-xp/fast/text/international/khmer-selection-expected.txt: Removed.
- platform/chromium-win/fast/text/international/khmer-selection-expected.checksum:
- platform/chromium-win/fast/text/international/khmer-selection-expected.png:
- platform/chromium-win/fast/text/international/khmer-selection-expected.txt:
- platform/chromium/test_expectations.txt:
- 3:50 PM Changeset in webkit [73561] by
-
- 3 edits in trunk/WebCore
2010-12-08 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Use gtk_icon_set_render_icon() to render icons in RenderThemeGtk
https://bugs.webkit.org/show_bug.cgi?id=50623
We don't need to cache the icons since the will be cached by GTK+,
and they will be rendered using the state and text direction.
- platform/gtk/RenderThemeGtk.cpp: (WebCore::paintStockIcon): (WebCore::getMediaButtonIconSize): (WebCore::RenderThemeGtk::initMediaColors): (WebCore::RenderThemeGtk::initMediaButtons): (WebCore::RenderThemeGtk::RenderThemeGtk): (WebCore::RenderThemeGtk::~RenderThemeGtk): (WebCore::RenderThemeGtk::gtkIconState): (WebCore::RenderThemeGtk::adjustSearchFieldResultsDecorationStyle): (WebCore::centerRectVerticallyInParentInputElement): (WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration): (WebCore::RenderThemeGtk::adjustSearchFieldCancelButtonStyle): (WebCore::RenderThemeGtk::paintSearchFieldCancelButton): (WebCore::RenderThemeGtk::platformColorsDidChange): (WebCore::RenderThemeGtk::paintMediaButton): (WebCore::RenderThemeGtk::paintMediaFullscreenButton): (WebCore::RenderThemeGtk::paintMediaMuteButton): (WebCore::RenderThemeGtk::paintMediaPlayButton): (WebCore::RenderThemeGtk::paintMediaSeekBackButton): (WebCore::RenderThemeGtk::paintMediaSeekForwardButton):
- platform/gtk/RenderThemeGtk.h:
- 3:33 PM Changeset in webkit [73560] by
-
- 2 edits in trunk/WebKit/mac
REGRESSION: r73429-r73490: Some Contextual menu items non-functional, such as Open Link in New Tab
https://bugs.webkit.org/show_bug.cgi?id=50683
Reviewed by John Sullivan.
If our context menu item already has an action, don't overwrite the action with the context menu
forwarder.
- WebView/WebHTMLView.mm:
(setMenuItemTarget):
- 3:31 PM Changeset in webkit [73559] by
-
- 5 edits2 adds in trunk
2010-12-08 Abhishek Arya <inferno@chromium.org>
Reviewed by Dimitri Glazkov.
Detach node iterator and move to new document when node gets moved.
https://bugs.webkit.org/show_bug.cgi?id=50697
Test: fast/dom/node-iterator-document-moved-crash.html
- dom/Document.cpp: Method that takes a node and new document as argument. It detaches the node iterators belonging to the current document and attaches them to the new document. (WebCore::Document::moveNodeIteratorsToNewDocument):
- dom/Document.h: Function definition.
- dom/Node.cpp: When node is moved to another document, call the function to move the iterators appropriately. (WebCore::Node::setDocument):
2010-12-08 Abhishek Arya <inferno@chromium.org>
Reviewed by Dimitri Glazkov.
Tests that we do not crash when node iterator gets moved across documents.
https://bugs.webkit.org/show_bug.cgi?id=50697
- fast/dom/node-iterator-document-moved-crash-expected.txt: Added.
- fast/dom/node-iterator-document-moved-crash.html: Added.
- 3:27 PM Changeset in webkit [73558] by
-
- 12 edits46 adds in trunk/LayoutTests
2010-12-08 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed Chromium rebaseline for r73548.
- platform/chromium-linux/editing/selection/caret-ltr-2-expected.checksum: Added.
- platform/chromium-linux/editing/selection/caret-ltr-2-expected.png: Added.
- platform/chromium-linux/editing/selection/caret-ltr-2-left-expected.checksum: Added.
- platform/chromium-linux/editing/selection/caret-ltr-2-left-expected.png: Added.
- platform/chromium-linux/editing/selection/caret-ltr-expected.checksum: Added.
- platform/chromium-linux/editing/selection/caret-ltr-expected.png: Added.
- platform/chromium-linux/editing/selection/caret-ltr-right-expected.checksum: Added.
- platform/chromium-linux/editing/selection/caret-ltr-right-expected.png: Added.
- platform/chromium-linux/editing/selection/caret-rtl-2-expected.checksum: Added.
- platform/chromium-linux/editing/selection/caret-rtl-2-expected.png: Added.
- platform/chromium-linux/editing/selection/caret-rtl-2-left-expected.checksum: Added.
- platform/chromium-linux/editing/selection/caret-rtl-2-left-expected.png: Added.
- platform/chromium-linux/editing/selection/caret-rtl-expected.checksum:
- platform/chromium-linux/editing/selection/caret-rtl-expected.png:
- platform/chromium-linux/editing/selection/caret-rtl-right-expected.checksum: Added.
- platform/chromium-linux/editing/selection/caret-rtl-right-expected.png: Added.
- platform/chromium-mac/editing/selection/caret-ltr-2-expected.checksum: Added.
- platform/chromium-mac/editing/selection/caret-ltr-2-expected.png: Added.
- platform/chromium-mac/editing/selection/caret-ltr-2-left-expected.checksum: Added.
- platform/chromium-mac/editing/selection/caret-ltr-2-left-expected.png: Added.
- platform/chromium-mac/editing/selection/caret-ltr-expected.checksum: Added.
- platform/chromium-mac/editing/selection/caret-ltr-expected.png: Added.
- platform/chromium-mac/editing/selection/caret-ltr-right-expected.checksum: Added.
- platform/chromium-mac/editing/selection/caret-ltr-right-expected.png: Added.
- platform/chromium-mac/editing/selection/caret-rtl-2-expected.checksum: Added.
- platform/chromium-mac/editing/selection/caret-rtl-2-expected.png: Added.
- platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.checksum: Added.
- platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.png: Added.
- platform/chromium-mac/editing/selection/caret-rtl-expected.checksum:
- platform/chromium-mac/editing/selection/caret-rtl-expected.png:
- platform/chromium-mac/editing/selection/caret-rtl-right-expected.checksum: Added.
- platform/chromium-mac/editing/selection/caret-rtl-right-expected.png: Added.
- platform/chromium-win/editing/selection/caret-ltr-2-expected.checksum: Added.
- platform/chromium-win/editing/selection/caret-ltr-2-expected.png: Added.
- platform/chromium-win/editing/selection/caret-ltr-2-expected.txt: Added.
- platform/chromium-win/editing/selection/caret-ltr-2-left-expected.checksum: Added.
- platform/chromium-win/editing/selection/caret-ltr-2-left-expected.png: Added.
- platform/chromium-win/editing/selection/caret-ltr-2-left-expected.txt: Added.
- platform/chromium-win/editing/selection/caret-ltr-expected.checksum: Added.
- platform/chromium-win/editing/selection/caret-ltr-expected.png: Added.
- platform/chromium-win/editing/selection/caret-ltr-expected.txt: Added.
- platform/chromium-win/editing/selection/caret-ltr-right-expected.checksum: Added.
- platform/chromium-win/editing/selection/caret-ltr-right-expected.png: Added.
- platform/chromium-win/editing/selection/caret-ltr-right-expected.txt: Added.
- platform/chromium-win/editing/selection/caret-rtl-2-expected.checksum:
- platform/chromium-win/editing/selection/caret-rtl-2-expected.png:
- platform/chromium-win/editing/selection/caret-rtl-2-expected.txt:
- platform/chromium-win/editing/selection/caret-rtl-2-left-expected.checksum: Added.
- platform/chromium-win/editing/selection/caret-rtl-2-left-expected.png: Added.
- platform/chromium-win/editing/selection/caret-rtl-2-left-expected.txt: Added.
- platform/chromium-win/editing/selection/caret-rtl-expected.checksum:
- platform/chromium-win/editing/selection/caret-rtl-expected.png:
- platform/chromium-win/editing/selection/caret-rtl-expected.txt:
- platform/chromium-win/editing/selection/caret-rtl-right-expected.checksum: Added.
- platform/chromium-win/editing/selection/caret-rtl-right-expected.png: Added.
- platform/chromium-win/editing/selection/caret-rtl-right-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 3:24 PM Changeset in webkit [73557] by
-
- 3 edits in trunk/LayoutTests
2010-12-08 Martin Robinson <mrobinson@igalia.com>
Replace some GTK+ test results after r73548.
- platform/gtk/fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
- platform/gtk/fast/dom/vertical-scrollbar-in-rtl-expected.txt:
- 3:11 PM Changeset in webkit [73556] by
-
- 3 edits12 copies in branches/chromium/597
Merge 73531 - https://bugs.webkit.org/show_bug.cgi?id=50576
Reviewed by Anders Carlsson.
REGRESSION in position of autocomplete popup on RTL page.
RTL static position computation did not subtract out the width of the enclosing box if the
immediate parent was a RenderInline. This bug was exposed by properly changing the RenderView
to be RTL when the document was RTL.
Added three new tests in fast/block/positioning.
WebCore:
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computePositionedLogicalWidth):
LayoutTests:
- fast/block/positioning/rtl-static-positioning-inline-block.html: Added.
- fast/block/positioning/rtl-static-positioning.html: Added.
- fast/block/positioning/table-cell-static-position.html: Added.
- platform/mac/fast/block/positioning/rtl-static-positioning-expected.checksum: Added.
- platform/mac/fast/block/positioning/rtl-static-positioning-expected.png: Added.
- platform/mac/fast/block/positioning/rtl-static-positioning-expected.txt: Added.
- platform/mac/fast/block/positioning/rtl-static-positioning-inline-block-expected.checksum: Added.
- platform/mac/fast/block/positioning/rtl-static-positioning-inline-block-expected.png: Added.
- platform/mac/fast/block/positioning/rtl-static-positioning-inline-block-expected.txt: Added.
- platform/mac/fast/block/positioning/table-cell-static-position-expected.checksum: Added.
- platform/mac/fast/block/positioning/table-cell-static-position-expected.png: Added.
- platform/mac/fast/block/positioning/table-cell-static-position-expected.txt: Added.
TBR=jamesr@chromium.org
BUG=62451
Review URL: http://codereview.chromium.org/5670003
- 2:48 PM Changeset in webkit [73555] by
-
- 1 edit4 deletes in trunk/LayoutTests
2010-12-08 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed; Removed old expected results for caret-rtl.html and caret-rtl-2.html on Mac Leopard.
- platform/mac-leopard/editing/selection/caret-rtl-2-expected.checksum: Removed.
- platform/mac-leopard/editing/selection/caret-rtl-2-expected.png: Removed.
- platform/mac-leopard/editing/selection/caret-rtl-expected.checksum: Removed.
- platform/mac-leopard/editing/selection/caret-rtl-expected.png: Removed.
- 2:35 PM Changeset in webkit [73554] by
-
- 2 edits in trunk/LayoutTests
Unreviewed Chromium test expectations update.
Mark some Mac tests as timing out after r73518 and r73522.
- platform/chromium/test_expectations.txt:
- 2:34 PM Changeset in webkit [73553] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fixed the change log entry for r73548.
- 2:25 PM Changeset in webkit [73552] by
-
- 2 edits in trunk/WebKit/mac
Remove an unused variable.
- WebView/WebDynamicScrollBarsView.mm:
(-[WebDynamicScrollBarsView setScrollOrigin:updatePosition:]):
- 2:19 PM Changeset in webkit [73551] by
-
- 1 edit4 deletes in trunk/LayoutTests
Update Windows test results after r73538
We don't need Windows-specific results for this test anymore.
- platform/win-xp/svg/custom/clip-path-referencing-use-expected.checksum: Removed.
- platform/win-xp/svg/custom/clip-path-referencing-use-expected.png: Removed.
- platform/win-xp/svg/custom/clip-path-referencing-use-expected.txt: Removed.
- platform/win/svg/custom/clip-path-referencing-use-expected.checksum: Removed.
- platform/win/svg/custom/clip-path-referencing-use-expected.png: Removed.
- platform/win/svg/custom/clip-path-referencing-use-expected.txt: Removed.
- 2:09 PM Changeset in webkit [73550] by
-
- 3 edits in trunk/WebKit/gtk
2010-12-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Build fix. Take webView{Enter,Exit}Fullscreen back out of the
WebKit namespace, and remove a function signature that got in by
mistake because of a bad merge.
- webkit/webkitprivate.h:
- webkit/webkitwebview.cpp: (WebKit::core): (WebKit::kit):
- 1:58 PM Changeset in webkit [73549] by
-
- 4 edits7 adds in trunk
2010-12-08 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Text is blurry on a large composited layer with an odd center x/y coordinate
https://bugs.webkit.org/show_bug.cgi?id=50702
Tests that text rendered on a large layer is crisp even when the layer's center point
has an odd x and/or y coordinate.
- compositing/text-on-large-layer.html: Added.
- platform/chromium-gpu-linux/compositing/text-on-large-layer-expected.checksum: Added.
- platform/chromium-gpu-linux/compositing/text-on-large-layer-expected.png: Added.
- platform/chromium-gpu-linux/compositing/text-on-large-layer-expected.txt: Added.
- platform/chromium-gpu/test_expectations.txt:
- platform/mac/compositing/text-on-large-layer-expected.checksum: Added.
- platform/mac/compositing/text-on-large-layer-expected.png: Added.
- platform/mac/compositing/text-on-large-layer-expected.txt: Added.
2010-12-08 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Text is blurry on a large composited layer with an odd center x/y coordinate
https://bugs.webkit.org/show_bug.cgi?id=50702
Compute the center of a large layer using floats instead of ints to avoid roundoff errors.
Test: compositing/text-on-large-layer.html
- platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::draw):
- 1:55 PM Changeset in webkit [73548] by
-
- 11 edits25 adds in trunk
2010-12-08 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Dan Bernstein.
REGRESSION: LayoutTests/editing/selection/caret-rtl-2.html fails
https://bugs.webkit.org/show_bug.cgi?id=33503
The bug was caused by Font::offsetForPosition's not taking into account the containing block's text direction.
When RTL text appears in a LTR block, the offset at the beginning of RTL text is on the left of RTL text,
adn the offset at the end of RTL text is on the right of RTL text. For example, if we had RTL text CBA,
then the correspondance between letters and offsets in logical order are: A -> 0, B -> 1, and C -> 2.
Case 1. CBA appears in a RTL block:
In this case, clicking on the visual left of CBA puts the caret naturally at Position("CBA", 2).
Clicking on the visual right of CBA puts the caret at Position("CBA", 0) as expected.
Case 2. CBA appears in a LTR block:
Because the containing block flows from left to right, by covention, Position("CBA", 2") coresponds
to the visual right of CBA, and Position("CBA", 0) corresponds to the visual left of CBA.
Therefore, clicking on the visual left of CBA should put the caret at Positoin("CBA", 0),
and clicking on the visual right should put it at Position("CBA", 2).
The bug was caused by WebKit's not considering case 2. The same bug also existe for LTR text in a RTL block.
Fixed the bug by taking care of the case 2 in InlineTextBox::offsetForPosition.
Tests: editing/selection/caret-ltr-2-left.html
editing/selection/caret-ltr-2.html
editing/selection/caret-ltr-right.html
editing/selection/caret-ltr.html
editing/selection/caret-rtl-2-left.html
editing/selection/caret-rtl-right.html
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::offsetForPosition):
2010-12-08 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Dan Bernstein.
REGRESSION: LayoutTests/editing/selection/caret-rtl-2.html fails
https://bugs.webkit.org/show_bug.cgi?id=33503
Added tests to ensure WebKit places the caret at a right place for LTR text in a LTR block,
LTR text in a RTL block, RTL text in a RTL block, and RTL text in a LTR block.
Because we need to verify both rendering of the caret and (node, offset) pair of the caret,
these tests cannot be combined or done without pixel results.
- editing/selection/caret-ltr-2-left.html: Added.
- editing/selection/caret-ltr-2.html: Added.
- editing/selection/caret-ltr-right.html: Added.
- editing/selection/caret-ltr.html: Added.
- editing/selection/caret-rtl-2-left.html: Added.
- editing/selection/caret-rtl-2.html:
- editing/selection/caret-rtl-right.html: Added.
- editing/selection/caret-rtl.html:
- editing/selection/resources/caret-edge-shared.js: Added. (runTest): (verify): (log):
- platform/mac/editing/selection/caret-ltr-2-expected.checksum: Added.
- platform/mac/editing/selection/caret-ltr-2-expected.png: Added.
- platform/mac/editing/selection/caret-ltr-2-expected.txt: Added.
- platform/mac/editing/selection/caret-ltr-2-left-expected.checksum: Added.
- platform/mac/editing/selection/caret-ltr-2-left-expected.png: Added.
- platform/mac/editing/selection/caret-ltr-2-left-expected.txt: Added.
- platform/mac/editing/selection/caret-ltr-expected.checksum: Added.
- platform/mac/editing/selection/caret-ltr-expected.png: Added.
- platform/mac/editing/selection/caret-ltr-expected.txt: Added.
- platform/mac/editing/selection/caret-ltr-right-expected.checksum: Added.
- platform/mac/editing/selection/caret-ltr-right-expected.png: Added.
- platform/mac/editing/selection/caret-ltr-right-expected.txt: Added.
- platform/mac/editing/selection/caret-rtl-2-expected.checksum:
- platform/mac/editing/selection/caret-rtl-2-expected.png:
- platform/mac/editing/selection/caret-rtl-2-expected.txt:
- platform/mac/editing/selection/caret-rtl-2-left-expected.checksum: Added.
- platform/mac/editing/selection/caret-rtl-2-left-expected.png: Added.
- platform/mac/editing/selection/caret-rtl-2-left-expected.txt: Added.
- platform/mac/editing/selection/caret-rtl-expected.checksum:
- platform/mac/editing/selection/caret-rtl-expected.png:
- platform/mac/editing/selection/caret-rtl-expected.txt:
- platform/mac/editing/selection/caret-rtl-right-expected.checksum: Added.
- platform/mac/editing/selection/caret-rtl-right-expected.png: Added.
- platform/mac/editing/selection/caret-rtl-right-expected.txt: Added.
- 1:48 PM Changeset in webkit [73547] by
-
- 2 edits in trunk/LayoutTests
Touch a file that's sporadically giving 207 Multi-Status error on svn update, hoping that
it will magically fix it.
- fast/xpath/4XPath/Core/test.js: Removed properties svn:mime-type and svn:eol-style, added a newline.
- 1:48 PM Changeset in webkit [73546] by
-
- 3 edits in trunk/WebKit2
Rename WKPreferencesGetFTPDirectoryTemplatePath to WKPreferencesCopyFTPDirectoryTemplatePath
since it copies the value.
Reviewed by Oliver Hunt.
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesCopyFTPDirectoryTemplatePath):
- UIProcess/API/C/WKPreferencesPrivate.h:
- 1:44 PM Changeset in webkit [73545] by
-
- 4 edits in trunk/JavaScriptCore
2010-12-08 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Marking the active global object re-enters through markConservatively
https://bugs.webkit.org/show_bug.cgi?id=50711
draining of the MarkStack is not allowed to be re-entrant, we got away
with this simply due to the logic in MarkStack::drain implicitly handling
changes that could be triggered by the re-entry.
Just to be safe this patch removes the re-entry through markConservatively
so we don't accidentally introduce such an issue in future. I've also
added an assertion to catch such errors.
- runtime/Collector.cpp: (JSC::Heap::markConservatively): (JSC::Heap::markCurrentThreadConservativelyInternal): (JSC::Heap::markOtherThreadConservatively):
- runtime/JSArray.h: (JSC::MarkStack::drain):
- runtime/MarkStack.h: (JSC::MarkStack::MarkStack):
- 1:41 PM Changeset in webkit [73544] by
-
- 3 edits in trunk/LayoutTests
Unreviewed Chromium test expectations update.
Mark some tests as passing or slow, and update the comment on the
compositing tests to indicate more accurately why we skip them in the
main test run.
- platform/chromium-gpu/test_expectations.txt:
- platform/chromium/test_expectations.txt:
- 1:29 PM Changeset in webkit [73543] by
-
- 4 edits in trunk/WebCore
Fix some clang++ warnings (one of which was an actual bug)
https://bugs.webkit.org/show_bug.cgi?id=50700
Reviewed by Darin Adler.
- page/mac/DragControllerMac.mm:
(WebCore::DragController::dragOperation):
Add parentheses to silent a clang warning.
- page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::needsKeyboardEventDisambiguationQuirks):
Fix vs && precedence bug uncovered by clang. - platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::reshape):
Use an early return to avoid a warning.
- 1:27 PM Changeset in webkit [73542] by
-
- 5 edits in trunk/WebKit2
WebKit2: Can't open ftp directory
<rdar://problem/8489321>
Reviewed by Brady Eidson.
- Shared/WebPreferencesStore.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetForceFTPDirectoryListings):
(WKPreferencesGetForceFTPDirectoryListings):
(WKPreferencesSetFTPDirectoryTemplatePath):
(WKPreferencesGetFTPDirectoryTemplatePath):
- UIProcess/API/C/WKPreferencesPrivate.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Pipe through the FTP directory listing preferences.
- 12:43 PM Changeset in webkit [73541] by
-
- 2 edits in trunk/LayoutTests
2010-12-08 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed Chromium test expectations update.
fast/dom/HTMLMeterElement/meter-element.html has been rebaselined for Windows.
- platform/chromium/test_expectations.txt:
- 12:43 PM Changeset in webkit [73540] by
-
- 11 edits1 copy in trunk
2010-12-08 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
https://bugs.webkit.org/show_bug.cgi?id=49388
Added copy constructors and casting operators to go between
TransformationMatrix and CATransform3D. Also added a copy
constructor to go from CGAffineTransform to TransformationMatrix.
Used these new methods to clean up platform CA code. This will
make it easier to port to Windows.
I also fixed a couple of build issues found when trying out a
Windows build.
This is a resubmission of changesets r73477 and r73483 with a
fix for the SL build. The failure was because TransformationMatrix
included QuartzCore/CATransform3D.h which brought in some system
libraries, including Quickdraw, which has a definition for
'Cursor' which clashed with WebCore's 'Cursor' class. So I had
to qualify its use in WebChromeClient.cpp in WebKit2.
- 12:29 PM Changeset in webkit [73539] by
-
- 15 edits1 add in trunk/WebKit/gtk
2010-12-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Martin Robinson.
[GTK] Split webkitprivate.{cpp,h} in more manageable chunks
https://bugs.webkit.org/show_bug.cgi?id=50698
Split private bits of WebKitWebView to its own private header, and
to its implementation file. Take the opportunity to fix includes
sorting to comply with the style guide.
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::enterFullscreenForNode): (WebKit::ChromeClient::exitFullscreenForNode):
- WebCoreSupport/ContextMenuClientGtk.cpp:
- WebCoreSupport/DragClientGtk.cpp:
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
- WebCoreSupport/EditorClientGtk.cpp:
- WebCoreSupport/FrameLoaderClientGtk.cpp:
- WebCoreSupport/InspectorClientGtk.cpp:
- WebCoreSupport/PasteboardHelperGtk.cpp:
- webkit/webkitprivate.cpp: (webkit_init):
- webkit/webkitprivate.h:
- webkit/webkitwebbackforwardlist.cpp:
- webkit/webkitwebdatasource.cpp:
- webkit/webkitwebframe.cpp:
- webkit/webkitwebview.cpp: (WebKit::core): (WebKit::kit): (WebKit::webViewEnterFullscreen): (WebKit::webViewExitFullscreen):
- webkit/webkitwebviewprivate.h: Added.
- 12:25 PM Changeset in webkit [73538] by
-
- 2 edits in trunk/LayoutTests
Skip svg/custom/clip-path-referencing-use2.svg, not svg/custom/clip-path-referencing-use.svg
The former is the real problem. The latter was just the victim!
- platform/win/Skipped:
- 12:18 PM Changeset in webkit [73537] by
-
- 2 edits in trunk/LayoutTests
2010-12-08 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed Chromium test expectations update.
fast/text/decomposed-after-stacked-diacritics.html crashes on Chromium Linux.
- platform/chromium/test_expectations.txt:
- 11:59 AM Changeset in webkit [73536] by
-
- 1 edit21 adds in trunk/LayoutTests
2010-12-08 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed Chromium rebaseline for r73531.
- platform/chromium-linux/fast/block/positioning/rtl-static-positioning-expected.checksum: Added.
- platform/chromium-linux/fast/block/positioning/rtl-static-positioning-expected.png: Added.
- platform/chromium-linux/fast/block/positioning/rtl-static-positioning-inline-block-expected.checksum: Added.
- platform/chromium-linux/fast/block/positioning/rtl-static-positioning-inline-block-expected.png: Added.
- platform/chromium-linux/fast/block/positioning/table-cell-static-position-expected.checksum: Added.
- platform/chromium-linux/fast/block/positioning/table-cell-static-position-expected.png: Added.
- platform/chromium-mac/fast/block/positioning/rtl-static-positioning-expected.checksum: Added.
- platform/chromium-mac/fast/block/positioning/rtl-static-positioning-expected.png: Added.
- platform/chromium-mac/fast/block/positioning/rtl-static-positioning-inline-block-expected.checksum: Added.
- platform/chromium-mac/fast/block/positioning/rtl-static-positioning-inline-block-expected.png: Added.
- platform/chromium-mac/fast/block/positioning/table-cell-static-position-expected.checksum: Added.
- platform/chromium-mac/fast/block/positioning/table-cell-static-position-expected.png: Added.
- platform/chromium-win/fast/block/positioning/rtl-static-positioning-expected.checksum: Added.
- platform/chromium-win/fast/block/positioning/rtl-static-positioning-expected.png: Added.
- platform/chromium-win/fast/block/positioning/rtl-static-positioning-expected.txt: Added.
- platform/chromium-win/fast/block/positioning/rtl-static-positioning-inline-block-expected.checksum: Added.
- platform/chromium-win/fast/block/positioning/rtl-static-positioning-inline-block-expected.png: Added.
- platform/chromium-win/fast/block/positioning/rtl-static-positioning-inline-block-expected.txt: Added.
- platform/chromium-win/fast/block/positioning/table-cell-static-position-expected.checksum: Added.
- platform/chromium-win/fast/block/positioning/table-cell-static-position-expected.png: Added.
- platform/chromium-win/fast/block/positioning/table-cell-static-position-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 11:26 AM Changeset in webkit [73535] by
-
- 40 edits1 delete in trunk
Layering Violation in ContextMenu - member variable of type HitTestResult
https://bugs.webkit.org/show_bug.cgi?id=50586
Reviewed by John Sullivan.
WebCore:
ContextMenu had a layering violation by having a member variable of type HitTestResult, because
classes in WebCore/platform can't know about classes in WebCore.
This patch moves the HitTestResult and all functions that use it out of ContextMenu into ContextMenuController.
All of the functions that dealt with populating the ContextMenu are now in ContextMenuController, and this
allowed us to delete the ContextMenu file, putting all of the cross-platform code that used to be it
in ContextMenuController, and the rest of the code is in the platform-specific files.
No change in behavior, no new tests.
- Android.mk: Removed ContextMenu.cpp.
- CMakeLists.txt: Ditto.
- GNUmakefile.am: Ditto.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::ContextMenuController): Initialized m_hitTestResult to an empty HitTestResult.
(WebCore::ContextMenuController::handleContextMenuEvent): Call populate on the ContextMenuController instead
of the ContextMenu.
(WebCore::ContextMenuController::createContextMenu): Fix some indination, and store the HitTestResult in a member
variable.
(WebCore::ContextMenuController::showContextMenu): Call addInspectElementItem on the ContextMenuController.
(WebCore::ContextMenuController::contextMenuItemSelected): Use m_hitTestResult whenever we need a HitTestResult.
(WebCore::ContextMenuController::appendItem): Validates the item for its state, and then appends it to the parent menu.
This allowed us to move checkOrEnableIfNeeded from ContextMenu.
These functions were all moved from ContextMenu, and changed slightly to fit in ContextMenuController.
All calls to ContextMenu::appendItem were changed to ContextMenuController::appendItem, which takes care
of validating the menu.
(WebCore::separatorItem): Moved from ContextMenu.
(WebCore::ContextMenuController::createAndAppendFontSubMenu): Ditto.
(WebCore::ContextMenuController::createAndAppendSpellingAndGrammarSubMenu): Ditto.
(WebCore::ContextMenuController::createAndAppendSpeechSubMenu): Ditto.
(WebCore::ContextMenuController::createAndAppendWritingDirectionSubMenu): Ditto.
(WebCore::ContextMenuController::createAndAppendTextDirectionSubMenu): Ditto.
(WebCore::ContextMenuController::createAndAppendSubstitutionsSubMenu): Ditto.
(WebCore::ContextMenuController::createAndAppendTransformationsSubMenu): Ditto.
(WebCore::selectionContainsPossibleWord): Ditto.
(WebCore::ContextMenuController::populate): Ditto.
(WebCore::ContextMenuController::addInspectElementItem): Ditto.
(WebCore::ContextMenuController::checkOrEnableIfNeeded): Ditto.
- page/ContextMenuController.h:
(WebCore::ContextMenuController::hitTestResult): Returns the HitTestResult of the current ContextMenu.
- platform/ContextMenu.cpp: Removed.
- platform/ContextMenu.h:
- platform/efl/ContextMenuEfl.cpp:
(WebCore::ContextMenu::ContextMenu): Removed m_hitTestResult from the constructor.
(WebCore::ContextMenu::appendItem): Removed the call to checkOrEnableIfNeeded.
- platform/gtk/ContextMenuGtk.cpp:
(WebCore::ContextMenu::ContextMenu): Removed m_hitTestResult from the constructor.
(WebCore::ContextMenu::appendItem): Ditto.
- platform/haiku/ContextMenuHaiku.cpp:
(WebCore::ContextMenu::ContextMenu): Removed m_hitTestResult from the constructor.
(WebCore::ContextMenu::appendItem): Ditto.
(WebCore::ContextMenu::insertItem): Ditto.
- platform/mac/ContextMenuMac.mm:
(-[WebCoreMenuTarget validateMenuItem:]): Calls checkOrEnableIfNeeded on the controller instead of
the context menu.
(WebCore::ContextMenu::ContextMenu): Removed m_hitTestResult from the constructor.
(WebCore::ContextMenu::appendItem): Removed the call to checkOrEnableIfNeeded.
(WebCore::ContextMenu::insertItem): Ditto.
- platform/win/ContextMenuWin.cpp:
(WebCore::ContextMenu::ContextMenu): Removed m_hitTestResult from the constructor.
(WebCore::ContextMenu::insertItem): Removed the call to checkOrEnableIfNeeded.
- platform/wx/ContextMenuWx.cpp:
(WebCore::ContextMenu::ContextMenu): Removed m_hitTestResult from the constructor.
(ContextMenu::appendItem): Ditto.
WebKit/chromium:
Update users of ContextMenu and ContextMenuController to match where the new functions
are located.
- src/ContextMenuClientImpl.cpp:
(WebKit::selectMisspelledWord):
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
WebKit/gtk:
Update users of ContextMenu and ContextMenuController to match where the new functions
are located.
- WebCoreSupport/ContextMenuClientGtk.cpp:
(WebKit::ContextMenuClient::getCustomMenuFromDefaultItems):
WebKit/mac:
Update users of ContextMenu and ContextMenuController to match where the new functions
are located.
- WebCoreSupport/WebContextMenuClient.mm:
(WebContextMenuClient::getCustomMenuFromDefaultItems):
(WebContextMenuClient::contextMenuItemSelected):
- WebView/WebHTMLView.mm:
(-[WebMenuTarget validateMenuItem:]):
WebKit/qt:
Update users of ContextMenu and ContextMenuController to match where the new functions
are located.
- Api/qwebpage.cpp:
(QWebPagePrivate::createContextMenu):
(QWebPage::updatePositionDependentActions):
WebKit/win:
Update users of ContextMenu and ContextMenuController to match where the new functions
are located.
- WebCoreSupport/WebContextMenuClient.cpp:
(WebContextMenuClient::getCustomMenuFromDefaultItems): Get the HitTestResult and ContextMenu from the
ContextMenuController (from the page).
(WebContextMenuClient::contextMenuItemSelected): Get the HitTestResult from the ContextMenuController.
- WebView.cpp:
(WebView::handleContextMenuEvent): Ditto.
WebKit2:
Update users of ContextMenu and ContextMenuController to match where the new functions
are located.
- Shared/WebContextMenuItemData.cpp:
(WebKit::WebContextMenuItemData::WebContextMenuItemData): Remove the call to checkOrEnableItem, that call will be made when
the ContextMenuItem is added to the ContextMenu through the ContextMenuController.
- WebProcess/WebPage/WebContextMenu.cpp:
(WebKit::WebContextMenu::show):
- 11:17 AM Changeset in webkit [73534] by
-
- 4 edits in trunk
2010-12-08 Martin Robinson <mrobinson@igalia.com>
Reviewed by John Sullivan.
[GTK] Layering violation in ContextMenuGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=50676
ContextMenuGtk accesses the page's ContextMenuController, which is a layering
violation. This was fixed for Mac with change r73469. We make a similar fix here
by moving the "activated" signal connection to the WebKit layer.
- platform/gtk/ContextMenuGtk.cpp: (WebCore::ContextMenu::appendItem): Remove access of ContextMenuController. This is a layering violation.
2010-12-08 Martin Robinson <mrobinson@igalia.com>
Reviewed by John Sullivan.
[GTK] Layering violation in ContextMenuGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=50676
ContextMenuGtk accesses the page's ContextMenuController, which is a layering
violation. This was fixed for Mac with change r73469. We make a similar fix here
by moving the "activated" signal connection to the WebKit layer.
- webkit/webkitwebview.cpp: (popupMenuItemActivated): Have ContextMenuController handle this signal. (webkit_web_view_forward_context_menu_event): For all items in the untouched context menu, connect their "activated" signal to the new popupMenuItemActivated handler.
- 11:06 AM Changeset in webkit [73533] by
-
- 16 edits in trunk
WebKit2: Implement WebChromeClient::exceededDatabaseQuota
https://bugs.webkit.org/show_bug.cgi?id=50656
Reviewed by Adam Roben.
WebCore:
- WebCore.exp.in:
Export the symbol for SecurityOrigin::databaseIdentifier.
WebKit2:
The exceededDatabaseQuota call from the WebProcess to the UIProcess needs to be synchronous
because the new quota is checked directly after exceededDatabaseQuota returns in order to
determine if the new Database can be created.
Pass all of the details from the WebProcess to the UIProcess in order to inform the
decision in the UIProcess about the new quota. In WebKit1, these details were
fetched through an additional call to the API detailsForDatabase (which is infeasible in
WebKit2 since exceededDatabaseQuota is a synchronous call).
- Platform/CoreIPC/HandleMessage.h:
(CoreIPC::callMemberFunction):
Add a version that takes 7 parameters.
- UIProcess/API/C/WKPage.h:
- UIProcess/API/qt/qwkpage.cpp:
(QWKPage::QWKPage):
Indicate that exceededDatabaseQuota is not implemented.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::exceededDatabaseQuota):
Call the UIClient's exceededDatabaseQuota
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::exceededDatabaseQuota):
If the client does not implement exceededDatabaseQuota, return a the current quota.
- UIProcess/WebUIClient.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::exceededDatabaseQuota):
Send a synchronous message to the UIProcess to ask for the new quota for the origin for the
given frame.
WebKitTools:
- MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController awakeFromNib]):
Indicate that exceededDatabaseQuota is not implemented.
- MiniBrowser/win/BrowserView.cpp:
(BrowserView::create):
Ditto.
- WebKitTestRunner/TestController.cpp:
(WTR::createOtherPage):
Ditto.
(WTR::TestController::initialize):
Ditto.
- 11:02 AM Changeset in webkit [73532] by
-
- 6 edits in trunk/WebCore
2010-12-08 Csaba Osztrogonác <Csaba Osztrogonác>
Unreviewed, rolling out r73521.
http://trac.webkit.org/changeset/73521
https://bugs.webkit.org/show_bug.cgi?id=50640
It broke 90 layout tests
- bindings/js/JSDOMBinding.cpp: (WebCore::printErrorMessageForFrame):
- bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::crossDomainAccessErrorMessage):
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation):
- page/DOMWindow.cpp:
- page/DOMWindow.h:
- 10:31 AM Changeset in webkit [73531] by
-
- 3 edits12 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=50576
Reviewed by Anders Carlsson.
REGRESSION in position of autocomplete popup on RTL page.
RTL static position computation did not subtract out the width of the enclosing box if the
immediate parent was a RenderInline. This bug was exposed by properly changing the RenderView
to be RTL when the document was RTL.
Added three new tests in fast/block/positioning.
WebCore:
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computePositionedLogicalWidth):
LayoutTests:
- fast/block/positioning/rtl-static-positioning-inline-block.html: Added.
- fast/block/positioning/rtl-static-positioning.html: Added.
- fast/block/positioning/table-cell-static-position.html: Added.
- platform/mac/fast/block/positioning/rtl-static-positioning-expected.checksum: Added.
- platform/mac/fast/block/positioning/rtl-static-positioning-expected.png: Added.
- platform/mac/fast/block/positioning/rtl-static-positioning-expected.txt: Added.
- platform/mac/fast/block/positioning/rtl-static-positioning-inline-block-expected.checksum: Added.
- platform/mac/fast/block/positioning/rtl-static-positioning-inline-block-expected.png: Added.
- platform/mac/fast/block/positioning/rtl-static-positioning-inline-block-expected.txt: Added.
- platform/mac/fast/block/positioning/table-cell-static-position-expected.checksum: Added.
- platform/mac/fast/block/positioning/table-cell-static-position-expected.png: Added.
- platform/mac/fast/block/positioning/table-cell-static-position-expected.txt: Added.
- 10:29 AM Changeset in webkit [73530] by
-
- 10 edits6 copies in branches/chromium/597
Merge 73529 - 2010-12-08 Xiaomei Ji <xji@chromium.org>
Reviewed by David Hyatt.
Fix backward mouse wheeling not working when scroll position is below 0.
https://bugs.webkit.org/show_bug.cgi?id=50370
Tests: fast/events/wheelevent-in-horizontal-scrollbar-in-rtl.html
fast/events/wheelevent-in-vertical-scrollbar-in-rtl.html
- platform/ScrollView.cpp: (WebCore::ScrollView::wheelEvent):
2010-12-08 Xiaomei Ji <xji@chromium.org>
Reviewed by David Hyatt.
Fix backward mouse wheeling not working when scroll position is below 0.
https://bugs.webkit.org/show_bug.cgi?id=50370
- fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
- fast/dom/horizontal-scrollbar-in-rtl.html:
- fast/dom/vertical-scrollbar-in-rtl-expected.txt:
- fast/dom/vertical-scrollbar-in-rtl.html:
- fast/events/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt: Added.
- fast/events/wheelevent-in-horizontal-scrollbar-in-rtl.html: Added.
- fast/events/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt: Added.
- fast/events/wheelevent-in-vertical-scrollbar-in-rtl.html: Added.
- platform/chromium/fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
- platform/chromium/fast/dom/vertical-scrollbar-in-rtl-expected.txt:
- platform/chromium/fast/events/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt: Added.
- platform/chromium/fast/events/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt: Added.
- platform/gtk/Skipped:
- platform/mac-tiger/Skipped:
- platform/mac-wk2/Skipped:
- platform/qt-wk2/Skipped:
- platform/qt/fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
- platform/qt/fast/dom/vertical-scrollbar-in-rtl-expected.txt:
- platform/win/Skipped:
- platform/win/fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
- platform/win/fast/dom/vertical-scrollbar-in-rtl-expected.txt:
- 10:14 AM Changeset in webkit [73529] by
-
- 18 edits6 adds in trunk
2010-12-08 Xiaomei Ji <xji@chromium.org>
Reviewed by David Hyatt.
Fix backward mouse wheeling not working when scroll position is below 0.
https://bugs.webkit.org/show_bug.cgi?id=50370
Tests: fast/events/wheelevent-in-horizontal-scrollbar-in-rtl.html
fast/events/wheelevent-in-vertical-scrollbar-in-rtl.html
- platform/ScrollView.cpp: (WebCore::ScrollView::wheelEvent):
2010-12-08 Xiaomei Ji <xji@chromium.org>
Reviewed by David Hyatt.
Fix backward mouse wheeling not working when scroll position is below 0.
https://bugs.webkit.org/show_bug.cgi?id=50370
- fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
- fast/dom/horizontal-scrollbar-in-rtl.html:
- fast/dom/vertical-scrollbar-in-rtl-expected.txt:
- fast/dom/vertical-scrollbar-in-rtl.html:
- fast/events/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt: Added.
- fast/events/wheelevent-in-horizontal-scrollbar-in-rtl.html: Added.
- fast/events/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt: Added.
- fast/events/wheelevent-in-vertical-scrollbar-in-rtl.html: Added.
- platform/chromium/fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
- platform/chromium/fast/dom/vertical-scrollbar-in-rtl-expected.txt:
- platform/chromium/fast/events/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt: Added.
- platform/chromium/fast/events/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt: Added.
- platform/gtk/Skipped:
- platform/mac-tiger/Skipped:
- platform/mac-wk2/Skipped:
- platform/qt-wk2/Skipped:
- platform/qt/fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
- platform/qt/fast/dom/vertical-scrollbar-in-rtl-expected.txt:
- platform/win/Skipped:
- platform/win/fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
- platform/win/fast/dom/vertical-scrollbar-in-rtl-expected.txt:
- 10:01 AM Changeset in webkit [73528] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, cleaning up test expectations after r7349.
- platform/chromium/test_expectations.txt:
- 9:47 AM Changeset in webkit [73527] by
-
- 8 edits in trunk
2010-12-08 Antonio Gomes <agomes@rim.com>
Reviewed by Martin Robinson.
[Gtk] Populate DumpRenderTreeSupportGtk (part III)
https://bugs.webkit.org/show_bug.cgi?id=48429
WebKit/gtk:
Adjusted some call sites of previously internal API declared
webkitprivate.h that have moved to DumpRenderTreeSupportGtk.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::gcCollectJavascriptObjects): (DumpRenderTreeSupportGtk::gcCollectJavascriptObjectsOnAlternateThread): (DumpRenderTreeSupportGtk::gcCountJavascriptObjects): (DumpRenderTreeSupportGtk::layoutFrame):
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
- webkit/webkitprivate.h:
- webkit/webkitwebframe.cpp:
WebKitTools:
Moved the following methods from webkitprivate.h to DumpRenderTreeSupportGtk.cpp|h:
- webkit_gc_collect_javascript_objects;
- webkit_gc_collect_javascript_objects_on_alternate_thread;
- webkit_gc_count_javascript_objects;
- webkit_web_frame_layout.
These were all only used by GTK+ DRT.
- DumpRenderTree/gtk/EventSender.cpp: (dispatchEvent):
- DumpRenderTree/gtk/GCControllerGtk.cpp: (GCController::collect): (GCController::collectOnAlternateThread): (GCController::getJSObjectCount):
- 9:37 AM Changeset in webkit [73526] by
-
- 9 edits in trunk
2010-12-08 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Fix pauseAnimation API to work with shorthand properties
https://bugs.webkit.org/show_bug.cgi?id=50639
The pause API is always called with a long-hand property, but that
property may be animating via a shorthand. Detect this, and pause
such shorthand animations.
- page/animation/AnimationBase.cpp: (WebCore::ShorthandPropertyWrapper::propertyWrappers): Expose the vector of wrappers used by a shorthand wrapper.
(WebCore::gatherEnclosingShorthandProperties): Utility function that walks
through the shorthand wrappers, keeping track of which can affect the given
property.
(WebCore::AnimationBase::animatableShorthandsAffectingProperty): Return a set
of shorthand properties that can affect the given property.
- page/animation/AnimationBase.h: New method.
- page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::pauseTransitionAtTime): If we don't find the property itself, check whether it's being animated via shorthands.
- 8:55 AM Changeset in webkit [73525] by
-
- 2 edits in trunk/WebCore
<rdar://problem/8740920> Gestures: Frame::scalePage() broken by r73885
Reviewed by Beth Dakin.
Make sure the transform applied to the RenderView for page scaling is incorporated into the
docTop/Bottom/Left/Right accessors.
- rendering/RenderView.cpp:
(WebCore::RenderView::docTop):
(WebCore::RenderView::docBottom):
(WebCore::RenderView::docLeft):
(WebCore::RenderView::docRight):
- 8:54 AM Changeset in webkit [73524] by
-
- 4 edits in trunk/WebCore
2010-12-08 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Protocol cleanup task. Remove WebInspector wrappers
for TimelineAgent functions.
- inspector/Inspector.idl:
- inspector/front-end/TimelineAgent.js:
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype.timelineProfilerWasStarted): (WebInspector.TimelinePanel.prototype.timelineProfilerWasStopped):
- 8:49 AM Changeset in webkit [73523] by
-
- 4 edits in trunk
2010-12-08 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] media/fullscreen* failing on 64-bits Debug
https://bugs.webkit.org/show_bug.cgi?id=50394
Avoid emiting durationchanged in the case where the previous
duration was 0 because that case is already handled by the
HTMLMediaElement.
Test: media/media-fullscreen*.html
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::durationChanged):
LayoutTests:
Reviewed by Gustavo Noronha Silva.
[GTK] media/fullscreen* failing on 64-bits Debug
https://bugs.webkit.org/show_bug.cgi?id=50394
- platform/gtk/Skipped: Unskip now passing tests.
- 8:22 AM Changeset in webkit [73522] by
-
- 2 edits in trunk/LayoutTests
2010-12-08 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed. Remove WIN prefix for inspector's tests expectations.
DumpRenderTree related patch.
- platform/chromium/test_expectations.txt:
- 8:22 AM Changeset in webkit [73521] by
-
- 6 edits in trunk/WebCore
2010-12-07 Darin Adler <Darin Adler>
Reviewed by Geoffrey Garen.
Move DOMWindow::setLocation logic into DOMWindow class and out of JavaScript binding
https://bugs.webkit.org/show_bug.cgi?id=50640
- bindings/js/JSDOMBinding.cpp: (WebCore::printErrorMessageForFrame): Removed body; just call through to DOMWindow::printErrorMessage.
- bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::crossDomainAccessErrorMessage): Removed body; just call through to DOMWindow::crossDomainAccessErrorMessage.
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation): Changed terminology to use activeFrame and firstFrame, rather than the older lexicalFrame and dynamicFrame. Removed most of the body and moved it into DOMWindow::setLocation.
- page/DOMWindow.cpp: (WebCore::DOMWindow::setLocation): Added. Does all the same work that JSDOMWindow::setLocation used to do, but in a way that's not specific to JavaScript. (WebCore::DOMWindow::printErrorMessage): Added. (WebCore::DOMWindow::crossDomainAccessErrorMessage): Added.
- page/DOMWindow.h: Added setLocation, printErrorMessage, and crossDomainAccessErrorMessage.
- 8:07 AM Changeset in webkit [73520] by
-
- 2 edits in trunk/LayoutTests
Skip svg/custom/clip-path-referencing-use.svg on Windows
The test fails when run under Aero. It seems that one of our Windows 7
bots has this turned on while the other doesn't.
- platform/win/Skipped:
- 8:02 AM Changeset in webkit [73519] by
-
- 20 edits5 deletes in trunk
2010-12-08 Alejandro G. Castro <alex@igalia.com>
Unreviewed, rolling out r73494.
http://trac.webkit.org/changeset/73494
https://bugs.webkit.org/show_bug.cgi?id=50380
The tests added are crashing in the debug bots (macn and gtk)
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::deselectItems): (WebCore::HTMLSelectElement::setSelectedIndex): (WebCore::HTMLSelectElement::setSelectedIndexByUser): (WebCore::HTMLSelectElement::listBoxSelectItem): (WebCore::HTMLSelectElement::add): (WebCore::HTMLSelectElement::remove): (WebCore::HTMLSelectElement::restoreFormControlState): (WebCore::HTMLSelectElement::parseMappedAttribute): (WebCore::HTMLSelectElement::selectAll): (WebCore::HTMLSelectElement::reset): (WebCore::HTMLSelectElement::updateListBoxSelection): (WebCore::HTMLSelectElement::setLength):
- html/HTMLSelectElement.h: (WebCore::HTMLSelectElement::isOptionalFormControl):
- html/HTMLSelectElement.idl:
- html/ValidityState.cpp: (WebCore::ValidityState::valueMissing):
2010-12-08 Alejandro G. Castro <alex@igalia.com>
Unreviewed, rolling out r73494.
http://trac.webkit.org/changeset/73494
https://bugs.webkit.org/show_bug.cgi?id=50380
The tests added are crashing in the debug bots (macn and gtk)
- fast/forms/ValidityState-valueMissing-001-expected.txt:
- fast/forms/ValidityState-valueMissing-001.html:
- fast/forms/ValidityState-valueMissing-002-expected.txt:
- fast/forms/ValidityState-valueMissing-002.html:
- fast/forms/ValidityState-valueMissing-003-expected.txt:
- fast/forms/ValidityState-valueMissing-003.html:
- fast/forms/checkValidity-002-expected.txt:
- fast/forms/checkValidity-002.html:
- fast/forms/required-attribute-001-expected.txt:
- fast/forms/required-attribute-001.html:
- fast/forms/required-attribute-002-expected.txt:
- fast/forms/required-attribute-002.html:
- fast/forms/resources/select-live-pseudo-selectors.js: Removed.
- fast/forms/script-tests/validationMessage.js:
- fast/forms/select-live-pseudo-selectors-expected.txt: Removed.
- fast/forms/select-live-pseudo-selectors.html: Removed.
- fast/forms/validationMessage-expected.txt:
- platform/mac/fast/objc/dom-html-select-live-pseudo-selectors-expected.txt: Removed.
- platform/mac/fast/objc/dom-html-select-live-pseudo-selectors.html: Removed.
- 7:34 AM Changeset in webkit [73518] by
-
- 2 edits in trunk/LayoutTests
2010-12-08 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed. Just enable inspector's tests for chromium linux.
This change is related to switching to DumpRenderTree.
- platform/chromium/test_expectations.txt:
- 7:29 AM Changeset in webkit [73517] by
-
- 1 edit3 adds in trunk/LayoutTests
Land Windows results for test added in 73423
- platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum: Added.
- platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.png: Added.
- platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.txt: Added.
- 7:28 AM Changeset in webkit [73516] by
-
- 8 edits in trunk/LayoutTests
Update Windows results after r73488
- platform/win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
- platform/win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
- platform/win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
- platform/win/fast/dom/HTMLMeterElement/meter-element-expected.txt:
- platform/win/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
- platform/win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
- platform/win/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
- 7:25 AM Changeset in webkit [73515] by
-
- 2 edits in trunk/LayoutTests
2010-12-08 Philippe Normand <pnormand@igalia.com>
Unreviewed, skipping failing test.
[GTK] r73488 broke fast/dom/HTMLProgressElement/progress-element.html
https://bugs.webkit.org/show_bug.cgi?id=50687
- platform/gtk/Skipped:
- 6:24 AM Changeset in webkit [73514] by
-
- 2 edits in trunk/LayoutTests
2010-12-08 Yuta Kitamura <yutak@chromium.org>
Unreviewed.
Update Chromium test expectations. Remove some tests that are now consistently
passing, assign bug numbers, and add one new expectation.
- platform/chromium/test_expectations.txt:
- 6:17 AM Changeset in webkit [73513] by
-
- 2 edits in trunk/LayoutTests
2010-12-08 Philippe Normand <pnormand@igalia.com>
Unreviewed, unskipping media/video-buffered.html on GTK because
the bots are now running with latest GStreamer.
- platform/gtk/Skipped:
- 5:52 AM Changeset in webkit [73512] by
-
- 5 edits in trunk/LayoutTests
2010-12-08 Philippe Normand <pnormand@igalia.com>
Unreviewed, unskipped some more media tests.
They are not crashing anymore, they also needed a rebaseline since
the font tiling changes that happened while they were skipped.
- platform/gtk/Skipped:
- platform/gtk/media/controls-styling-expected.txt:
- platform/gtk/media/video-layer-crash-expected.txt:
- platform/gtk/media/video-transformed-expected.txt:
- 5:27 AM Changeset in webkit [73511] by
-
- 4 edits in trunk/WebCore
2010-12-07 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Inspector protocol cleanup task. Remove
WebInspector wrappers for DOMAgent functions.
There were a lot of wrappers in WebInspector namespace
for different WebInspector agents functions. As far as we have a
generic mechanic for such functions we can remove these
wrappers and register domAgent instance as a handler for
DOM domain notifications.
- inspector/Inspector.idl:
- inspector/front-end/DOMAgent.js: (WebInspector.DOMNode): (WebInspector.DOMAgent): (WebInspector.DOMAgent.prototype.attributesUpdated): (WebInspector.DOMAgent.prototype.characterDataModified): (WebInspector.DOMAgent.prototype.setDocument): (WebInspector.DOMAgent.prototype.setDetachedRoot): (WebInspector.DOMAgent.prototype.setChildNodes): (WebInspector.DOMAgent.prototype.childNodeCountUpdated): (WebInspector.DOMAgent.prototype.childNodeInserted): (WebInspector.DOMAgent.prototype.childNodeRemoved): (WebInspector.EventListeners.getEventListenersForNodeAsync):
- inspector/front-end/inspector.js: (WebInspector.didCommitLoad):
- 4:52 AM Changeset in webkit [73510] by
-
- 3 edits in trunk/LayoutTests
2010-12-08 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Update test expectations after r73504.
- http/tests/inspector/console-resource-errors-expected.txt:
- platform/chromium/test_expectations.txt:
- 4:31 AM Changeset in webkit [73509] by
-
- 2 edits in trunk/LayoutTests
2010-12-08 Yuta Kitamura <yutak@chromium.org>
Unreviewed.
Update Chromium test expectations. Add two test flakinesses which was
introduced at r73504.
- platform/chromium/test_expectations.txt:
- 4:14 AM Changeset in webkit [73508] by
-
- 2 edits in trunk/LayoutTests
2010-12-08 Yuta Kitamura <yutak@chromium.org>
Unreviewed.
Update Chromium test expectations. Added a few failures which was found
in Chromium main waterfall.
- platform/chromium/test_expectations.txt:
- 4:12 AM Changeset in webkit [73507] by
-
- 2 edits in trunk/WebKit/gtk
2010-12-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
The storage for the subresources is a GHashTable which does not
guarantee order, so we need to make our checking more resilient.
- tests/testwebresource.c: (test_web_resource_sub_resource_loading):
- 3:52 AM Changeset in webkit [73506] by
-
- 2 edits in trunk/LayoutTests
2010-12-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
[GTK] Fails back to POST tests
https://bugs.webkit.org/show_bug.cgi?id=50678
Skip new tests that we are failing.
- platform/gtk/Skipped:
- 3:42 AM Changeset in webkit [73505] by
-
- 1 edit1 move in trunk/WebKit/gtk/po
2010-12-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Fix name of the Korean translation file.
- kr.po -> ko.po: renamed to correct name.
- 3:28 AM Changeset in webkit [73504] by
-
- 11 edits in trunk
2010-12-08 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove groupLevel counter from console messages
https://bugs.webkit.org/show_bug.cgi?id=50672
- inspector/console-tests-expected.txt:
2010-12-08 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove groupLevel counter from console messages
https://bugs.webkit.org/show_bug.cgi?id=50672
- inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::ConsoleMessage): (WebCore::ConsoleMessage::addToFrontend): (WebCore::ConsoleMessage::isEqual):
- inspector/ConsoleMessage.h:
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::addMessageToConsole): (WebCore::InspectorController::clearConsoleMessages): (WebCore::InspectorController::startGroup): (WebCore::InspectorController::endGroup):
- inspector/InspectorController.h:
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.createFilterElement): (WebInspector.ConsoleView): (WebInspector.ConsoleView.prototype.filter): (WebInspector.ConsoleView.prototype.afterShow): (WebInspector.ConsoleView.prototype.addMessage): (WebInspector.ConsoleView.prototype.updateMessageRepeatCount): (WebInspector.ConsoleView.prototype.clearMessages): (WebInspector.ConsoleMessage): (WebInspector.ConsoleMessage.createTextMessage): (WebInspector.ConsoleMessage.prototype.toMessageElement): (WebInspector.ConsoleMessage.prototype._addMessageHeader): (WebInspector.ConsoleMessage.prototype._updateRepeatCount): (WebInspector.ConsoleMessage.prototype.toString): (WebInspector.ConsoleMessage.prototype.isEqual): (WebInspector.ConsoleGroup):
- inspector/front-end/Resource.js: (WebInspector.Resource.prototype._checkWarning):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._addMessageToSource):
- inspector/front-end/inspector.js: (WebInspector.addConsoleMessage): (WebInspector.log.logMessage): (WebInspector.log):
- 3:23 AM Changeset in webkit [73503] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Add new tests introduced in r73484 to the Skipped list,
because layoutTestController.testRepaint() is unimplemented in Qt DRT.
- platform/qt/Skipped:
- fast/repaint/table-writing-modes-h.html added
- fast/repaint/table-writing-modes-v.html added
- 3:17 AM Changeset in webkit [73502] by
-
- 13 edits in trunk/LayoutTests
Unreviewed. Update Qt specific expected results after r73488.
Compared to Mac png files and Mac expected files.
- platform/qt/fast/dom/HTMLMeterElement/meter-boundary-values-expected.checksum:
- platform/qt/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
- platform/qt/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
- platform/qt/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum:
- platform/qt/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
- platform/qt/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
- platform/qt/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum:
- platform/qt/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png:
- platform/qt/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
- platform/qt/fast/dom/HTMLMeterElement/meter-styles-expected.checksum:
- platform/qt/fast/dom/HTMLMeterElement/meter-styles-expected.png:
- platform/qt/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
- 3:17 AM Changeset in webkit [73501] by
-
- 11 edits2 adds in trunk/WebCore
2010-12-07 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: introduce DebuggerModel class representing InspectorDebuggerAgent state.
https://bugs.webkit.org/show_bug.cgi?id=50567
Moved debugging-related code from BreakpointManager to DebuggerModel. Moved Breakpoint class to a separate file.
- English.lproj/localizedStrings.js:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/Breakpoint.js: Added. (WebInspector.Breakpoint): Moved from BreakpointManager.js.
- inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager): Remove debugger-related methods.
- inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane): (WebInspector.CallStackSidebarPane.prototype._nativeBreakpointHit): (WebInspector.CallStackSidebarPane.prototype._scriptBreakpointHit):
- inspector/front-end/DebuggerModel.js: Added. (WebInspector.DebuggerModel): Moved debugger-related methods from BreakpointManager.
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.continueToLine): (WebInspector.ScriptsPanel.prototype.editScriptSource.mycallback): (WebInspector.ScriptsPanel.prototype.editScriptSource): (WebInspector.ScriptsPanel.prototype._debuggerPaused): (WebInspector.ScriptsPanel.prototype._debuggerResumed): (WebInspector.ScriptsPanel.prototype.reset):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._createViewerIfNeeded): (WebInspector.SourceFrameDelegate.prototype.addBreakpoint): (WebInspector.SourceFrameDelegate.prototype.breakpoints): (WebInspector.SourceFrameDelegate.prototype.findBreakpoint):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js: (WebInspector.createJSBreakpointsSidebarPane): (WebInspector.restoredBreakpoint): (WebInspector.pausedScript): (WebInspector.resumedScript): (WebInspector.reset):
- 3:07 AM Changeset in webkit [73500] by
-
- 2 edits in trunk/LayoutTests
2010-12-08 Philippe Normand <pnormand@igalia.com>
Unreviewed, updated baselines of
media/video-controls-rendering.html.
- platform/gtk/media/video-controls-rendering-expected.txt:
- 2:44 AM Changeset in webkit [73499] by
-
- 10 edits in trunk
2010-12-08 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: SourceFrame refactoring.
https://bugs.webkit.org/show_bug.cgi?id=50223
- inspector/debugger-breakpoints-not-activated-on-reload.html:
- inspector/debugger-pause-on-breakpoint.html:
2010-12-08 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: SourceFrame refactoring.
https://bugs.webkit.org/show_bug.cgi?id=50223
SourceFrame should ask BreakpointManager about existing breakpoints instead of maintaining
it's own storages. Move common code from ScriptView and SourceView to SourceFrame.
- inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.findBreakpoints): (WebInspector.BreakpointManager.prototype.findBreakpoint):
- inspector/front-end/Script.js: (WebInspector.Script): (WebInspector.Script.prototype.get linesCount): (WebInspector.Script.prototype.get source): (WebInspector.Script.prototype.set source):
- inspector/front-end/ScriptView.js: (WebInspector.ScriptView): (WebInspector.ScriptView.prototype._scriptSourceChanged): (WebInspector.ScriptFrameDelegateImpl): (WebInspector.ScriptFrameDelegateImpl.prototype.canEditScripts): (WebInspector.ScriptFrameDelegateImpl.prototype.editLineComplete): (WebInspector.ScriptFrameDelegateImpl.prototype.scripts):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame): Add common methods of ScriptView and SourceView. (WebInspector.SourceFrameDelegate): (WebInspector.SourceFrameDelegate.prototype.canEditScripts): (WebInspector.SourceFrameDelegate.prototype.editLineComplete): (WebInspector.SourceFrameDelegate.prototype.scripts):
- inspector/front-end/SourceView.js: (WebInspector.SourceView): (WebInspector.SourceView.prototype._contentLoaded): (WebInspector.ResourceFrameDelegateImpl): (WebInspector.ResourceFrameDelegateImpl.prototype.canEditScripts): (WebInspector.ResourceFrameDelegateImpl.prototype.editLineComplete): (WebInspector.ResourceFrameDelegateImpl.prototype.scripts):
- 2:25 AM Changeset in webkit [73498] by
-
- 2 edits in trunk/LayoutTests
2010-12-08 Philippe Normand <pnormand@igalia.com>
Unreviewed, unskipping media/video-controls-rendering.html on GTK.
It should now not crash anymore because the GTK bots have been
upgraded to latest GStreamer releases.
- platform/gtk/Skipped:
- 2:22 AM Changeset in webkit [73497] by
-
- 2 edits in trunk/WebKit/gtk
2010-12-08 Alejandro G. Castro <alex@igalia.com>
Reviewed by Gustavo Noronha Silva.
Fix assertion in the API test, we are requesting the favicon and
the subresource so we have to make sure we are assigning just the
first subresource.
- tests/testwebresource.c: (resource_request_starting_sub_cb):
- 1:35 AM Changeset in webkit [73496] by
-
- 14 edits1 add in trunk/WebCore
2010-12-08 Yuta Kitamura <yutak@chromium.org>
Unreviewed, rolling out r73492.
http://trac.webkit.org/changeset/73492
https://bugs.webkit.org/show_bug.cgi?id=49914
Caused a lot of pixel test failures and broke Windows build.
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::createGraphicsContextPrivate): (WebCore::GraphicsContext::destroyGraphicsContextPrivate): (WebCore::GraphicsContext::save): (WebCore::GraphicsContext::restore): (WebCore::GraphicsContext::setStrokeThickness): (WebCore::GraphicsContext::setStrokeStyle): (WebCore::GraphicsContext::setStrokeColor): (WebCore::GraphicsContext::setShadow): (WebCore::GraphicsContext::clearShadow): (WebCore::GraphicsContext::getShadow): (WebCore::GraphicsContext::strokeThickness): (WebCore::GraphicsContext::strokeStyle): (WebCore::GraphicsContext::strokeColor): (WebCore::GraphicsContext::strokeColorSpace): (WebCore::GraphicsContext::fillRule): (WebCore::GraphicsContext::setFillRule): (WebCore::GraphicsContext::setFillColor): (WebCore::GraphicsContext::fillColor): (WebCore::GraphicsContext::fillColorSpace): (WebCore::GraphicsContext::setShouldAntialias): (WebCore::GraphicsContext::shouldAntialias): (WebCore::GraphicsContext::setStrokePattern): (WebCore::GraphicsContext::setFillPattern): (WebCore::GraphicsContext::setStrokeGradient): (WebCore::GraphicsContext::setFillGradient): (WebCore::GraphicsContext::fillGradient): (WebCore::GraphicsContext::strokeGradient): (WebCore::GraphicsContext::fillPattern): (WebCore::GraphicsContext::strokePattern): (WebCore::GraphicsContext::setShadowsIgnoreTransforms): (WebCore::GraphicsContext::updatingControlTints): (WebCore::GraphicsContext::setUpdatingControlTints): (WebCore::GraphicsContext::setPaintingDisabled): (WebCore::GraphicsContext::paintingDisabled): (WebCore::GraphicsContext::textDrawingMode): (WebCore::GraphicsContext::setTextDrawingMode):
- platform/graphics/GraphicsContext.h:
- platform/graphics/GraphicsContextPrivate.h: Added. (WebCore::GraphicsContextState::GraphicsContextState): (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::setPlatformFill): (WebCore::setPlatformStroke): (WebCore::drawPathShadow): (WebCore::fillCurrentCairoPath): (WebCore::strokeCurrentCairoPath): (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::setPlatformShadow): (WebCore::GraphicsContext::strokeRect): (WebCore::GraphicsContext::setAlpha): (WebCore::GraphicsContext::getAlpha):
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext): (WebCore::GraphicsContext::applyStrokePattern): (WebCore::GraphicsContext::applyFillPattern): (WebCore::GraphicsContext::drawPath): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::setPlatformShadow): (WebCore::GraphicsContext::strokeRect):
- platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext):
- platform/graphics/openvg/GraphicsContextOpenVG.cpp: (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::clipOut): (WebCore::GraphicsContext::addInnerRoundedRectClip):
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::setPlatformShadow):
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::setPlatformShadow):
- platform/graphics/win/GraphicsContextCGWin.cpp: (WebCore::GraphicsContext::GraphicsContext):
- platform/graphics/win/GraphicsContextCairoWin.cpp: (WebCore::GraphicsContext::GraphicsContext):
- platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::fillRect):
- platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext):
- 1:34 AM Changeset in webkit [73495] by
-
- 1 edit in branches/chromium/597/WebCore/bindings/v8/ScriptDebugServer.cpp
Merge 73441 - 2010-12-07 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: avoid initializing Context on when creating attaching listener to ScriptDebugServer
https://bugs.webkit.org/show_bug.cgi?id=50627
- bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::addListener): don't try to collect already parsed scripts if context has not been initialized yet.
TBR=yurys@chromium.org
Review URL: http://codereview.chromium.org/5664002
- 12:43 AM Changeset in webkit [73494] by
-
- 20 edits5 adds in trunk
2010-12-08 Dai Mikurube <dmikurube@google.com>
Reviewed by Kent Tamura.
Implement "required" attribute for select tags
https://bugs.webkit.org/show_bug.cgi?id=50380
Added tests for require attributes, valueMissing and vadility check for select elements.
- fast/forms/ValidityState-valueMissing-001-expected.txt:
- fast/forms/ValidityState-valueMissing-001.html:
- fast/forms/ValidityState-valueMissing-002-expected.txt:
- fast/forms/ValidityState-valueMissing-002.html:
- fast/forms/ValidityState-valueMissing-003-expected.txt:
- fast/forms/ValidityState-valueMissing-003.html:
- fast/forms/checkValidity-002-expected.txt:
- fast/forms/checkValidity-002.html:
- fast/forms/required-attribute-001-expected.txt:
- fast/forms/required-attribute-001.html:
- fast/forms/required-attribute-002-expected.txt:
- fast/forms/required-attribute-002.html:
- fast/forms/resources/select-live-pseudo-selectors.js: Added. (makeInvalid): (appendOption): (backgroundOf):
- fast/forms/script-tests/validationMessage.js:
- fast/forms/select-live-pseudo-selectors-expected.txt: Added.
- fast/forms/select-live-pseudo-selectors.html: Added.
- fast/forms/validationMessage-expected.txt:
- platform/mac/fast/objc/dom-html-select-live-pseudo-selectors.html: Added.
- platform/mac/fast/objc/dom-html-select-live-pseudo-selectors-expected.txt: Added.
2010-12-08 Dai Mikurube <dmikurube@google.com>
Reviewed by Kent Tamura.
Implement "required" attribute for select tags
https://bugs.webkit.org/show_bug.cgi?id=50380
Test: fast/forms/select-live-pseudo-selectors.html
platform/mac/fast/objc/dom-html-select-live-pseudo-selectors.html
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::deselectItems): Added calling setNeedsValidityCheck() to enable validity check after changing. No tests for this change since this function is not exposed to JavaScript or any web interface. (WebCore::HTMLSelectElement::setSelectedIndex): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::setSelectedIndexByUser): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::valueMissing): Added valueMissing() to check if selecting an invalid or placeholder label option when a valid required attribute is specified. (WebCore::HTMLSelectElement::listBoxSelectItem): Added calling setNeedsValidityCheck(). No tests for this change since it is not called yet. Look at the bug 36177 and the changeset 56180. (WebCore::HTMLSelectElement::add): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::remove): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::restoreFormControlState): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::parseMappedAttribute): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::selectAll): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::reset): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::updateListBoxSelection): Added calling setNeedsValidityCheck(). Skipped adding tests for this change as too complicated.. (WebCore::HTMLSelectElement::setLength): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::isRequiredFormControl): Check if required or not. (WebCore::HTMLSelectElement::hasPlaceholderLabelOption): Added.
- html/HTMLSelectElement.h: (WebCore::HTMLSelectElement::isOptionalFormControl): Check if not required.
- html/HTMLSelectElement.idl: Added a required attribute to select elements..
- html/ValidityState.cpp: (WebCore::ValidityState::valueMissing): Added valueMissing check for select elements into the global checker, ValidityState::valueMissing().
- 12:08 AM Changeset in webkit [73493] by
-
- 2 edits in trunk/LayoutTests
2010-12-08 Yuta Kitamura <yutak@chromium.org>
Unreviewed.
Update Chromium test expectations.
- platform/chromium/test_expectations.txt:
- 12:05 AM Changeset in webkit [73492] by
-
- 14 edits1 delete in trunk/WebCore
2010-12-08 Renata Hodovan <reni@webkit.org>
Reviewed by Andreas Kling.
GraphicsContext: Merge m_common and m_data
https://bugs.webkit.org/show_bug.cgi?id=49914
Move data members from GraphicsContextPrivate into GraphicsContext. So GraphicsContextPlatform.h
and m_common became unnecessary. They are removed.
Add two methods to GraphicsContext: platformInit() and platformDestroy(), which
make the constructor of GraphicsContext clearer.
Besides add a getter to the private GraphicsContext::m_state member, because some inline
functions in cairo need it.
No new test is needed, because this is a refactoring.
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext): (WebCore::GraphicsContext::save): (WebCore::GraphicsContext::restore): (WebCore::GraphicsContext::setStrokeThickness): (WebCore::GraphicsContext::setStrokeStyle): (WebCore::GraphicsContext::setStrokeColor): (WebCore::GraphicsContext::setShadow): (WebCore::GraphicsContext::clearShadow): (WebCore::GraphicsContext::getShadow): (WebCore::GraphicsContext::strokeThickness): (WebCore::GraphicsContext::strokeStyle): (WebCore::GraphicsContext::strokeColor): (WebCore::GraphicsContext::strokeColorSpace): (WebCore::GraphicsContext::fillRule): (WebCore::GraphicsContext::setFillRule): (WebCore::GraphicsContext::setFillColor): (WebCore::GraphicsContext::fillColor): (WebCore::GraphicsContext::fillColorSpace): (WebCore::GraphicsContext::setShouldAntialias): (WebCore::GraphicsContext::shouldAntialias): (WebCore::GraphicsContext::state): (WebCore::GraphicsContext::setStrokePattern): (WebCore::GraphicsContext::setFillPattern): (WebCore::GraphicsContext::setStrokeGradient): (WebCore::GraphicsContext::setFillGradient): (WebCore::GraphicsContext::fillGradient): (WebCore::GraphicsContext::strokeGradient): (WebCore::GraphicsContext::fillPattern): (WebCore::GraphicsContext::strokePattern): (WebCore::GraphicsContext::setShadowsIgnoreTransforms): (WebCore::GraphicsContext::updatingControlTints): (WebCore::GraphicsContext::setUpdatingControlTints): (WebCore::GraphicsContext::setPaintingDisabled): (WebCore::GraphicsContext::paintingDisabled): (WebCore::GraphicsContext::textDrawingMode): (WebCore::GraphicsContext::setTextDrawingMode):
- platform/graphics/GraphicsContext.h: (WebCore::GraphicsContextState::GraphicsContextState):
- platform/graphics/GraphicsContextPrivate.h: Removed.
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::setPlatformFill): (WebCore::setPlatformStroke): (WebCore::drawPathShadow): (WebCore::fillCurrentCairoPath): (WebCore::strokeCurrentCairoPath): (WebCore::GraphicsContext::platformInit): (WebCore::GraphicsContext::platformDestroy): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::setPlatformShadow): (WebCore::GraphicsContext::strokeRect): (WebCore::GraphicsContext::setAlpha): (WebCore::GraphicsContext::getAlpha):
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::platformInit): (WebCore::GraphicsContext::platformDestroy): (WebCore::GraphicsContext::applyStrokePattern): (WebCore::GraphicsContext::applyFillPattern): (WebCore::GraphicsContext::drawPath): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::setPlatformShadow): (WebCore::GraphicsContext::strokeRect):
- platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::platformInit): (WebCore::GraphicsContext::platformDestroy):
- platform/graphics/openvg/GraphicsContextOpenVG.cpp: (WebCore::GraphicsContext::platformInit): (WebCore::GraphicsContext::platformDestroy): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::clipOut): (WebCore::GraphicsContext::addInnerRoundedRectClip):
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::platformInit): (WebCore::GraphicsContext::platformDestroy): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::setPlatformShadow):
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::platformInit): (WebCore::GraphicsContext::platformDestroy): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::setPlatformShadow):
- platform/graphics/win/GraphicsContextCGWin.cpp: (WebCore::GraphicsContext::platformInit):
- platform/graphics/win/GraphicsContextCairoWin.cpp: (WebCore::GraphicsContext::platformInit):
- platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::GraphicsContext::platformInit): (WebCore::GraphicsContext::platformDestroy): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::fillRect):
- platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::platformInit): (WebCore::GraphicsContext::platformDestroy):
