Context Navigation

← Previous Period
Next Period →

Timeline

Dec 12, 2010:

11:18 PM Changeset in webkit [73888] by jhoneycutt@apple.com

2 edits in trunk/WebCore

Unreviewed build fix.

editing/EditingAllInOne.cpp:

Add new file to the all-in-one.

10:31 PM Changeset in webkit [73887] by jhoneycutt@apple.com

2 edits in trunk/WebCore

Unreviewed build fix.

WebCore.vcproj/WebCore.vcproj:

Remove accidentally-committed conflict marker.

10:06 PM Changeset in webkit [73886] by morrita@google.com

64 edits
5 adds in trunk

2010-10-28 MORITA Hajime <morrita@google.com>

Reviewed by Ojan Vafai.

spellcheck does not check pasted text
https://bugs.webkit.org/show_bug.cgi?id=40092

editing/spelling/script-tests/spellcheck-paste.js: Added.
editing/spelling/spellcheck-paste.html: Added.
editing/spelling/spellcheck-paste-expected.txt: Added.
platform/chromium/test_expectations.txt:
platform/gtk/Skipped:
platform/mac-leopard/Skipped:
platform/mac-tiger/Skipped:
platform/mac-wk2/Skipped:
platform/qt/Skipped:
platform/win/Skipped:

2010-10-28 MORITA Hajime <morrita@google.com>

Reviewed by Ojan Vafai.

spellcheck does not check pasted text
https://bugs.webkit.org/show_bug.cgi?id=40092

Introduced SpellChecker class to encapsulate asynchronous spell checker state: sequence id, requesting text and target node. This is also the first step to decompose spell-check related code to a separate class.
Added EditorClient::isAsynchronousSpellCheckingEnabled() to use async spellcheck API on the platform. These APIs are touched by SpellChecker.
Used SpellChecker to check a pasted test. Text to check is collected from the subtree under the editingRoot.
Added Setting::m_asynchronousSpellCheckingEnabled to control async spell checking.

Test: editing/spelling/spellcheck-paste.html

CMakeLists.txt:
GNUmakefile.am:
WebCore.exp.in:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
dom/DocumentMarkerController.cpp: (WebCore::DocumentMarkerController::showMarkers): (showDocumentMarkers):
dom/DocumentMarkerController.h:
dom/PositionIterator.cpp: (WebCore::PositionIterator::setOffsetInLeafNode):
dom/PositionIterator.h:
editing/Editor.cpp: (WebCore::Editor::replaceSelectionWithFragment): (WebCore::Editor::Editor): (WebCore::findFirstMarkable): (WebCore::Editor::selectionStartHasSpellingMarkerFor):
editing/Editor.h: (WebCore::Editor::spellChecker):
editing/SpellChecker.cpp: Added. (WebCore::SpellChecker::SpellChecker): (WebCore::SpellChecker::~SpellChecker): (WebCore::SpellChecker::initRequest): (WebCore::SpellChecker::clearRequest): (WebCore::SpellChecker::isAsynchronousEnabled): (WebCore::SpellChecker::canCheckAsynchronously): (WebCore::SpellChecker::isBusy): (WebCore::SpellChecker::isValid): (WebCore::SpellChecker::isCheckable): (WebCore::SpellChecker::requestCheckingFor): (WebCore::forwardIterator): (WebCore::SpellChecker::didCheck):
editing/SpellChecker.h: Added. (WebCore::SpellCheckingResult::SpellCheckingResult): (WebCore::SpellCheckingResult::type): (WebCore::SpellCheckingResult::location): (WebCore::SpellCheckingResult::length):
loader/EmptyClients.h: (WebCore::EmptyEditorClient::requestCheckingOfString):
page/EditorClient.h:
page/Settings.cpp: (WebCore::Settings::Settings):
page/Settings.h: (WebCore::Settings::setAsynchronousSpellCheckingEnabled): (WebCore::Settings::asynchronousSpellCheckingEnabled):

2010-10-28 MORITA Hajime <morrita@google.com>

Reviewed by Ojan Vafai.

spellcheck does not check pasted text
https://bugs.webkit.org/show_bug.cgi?id=40092

Added a stub implememntation.

src/EditorClientImpl.h: (WebKit::EditorClientImpl::requestCheckingOfString):

2010-10-28 MORITA Hajime <morrita@google.com>

Reviewed by Ojan Vafai.

spellcheck does not check pasted text
https://bugs.webkit.org/show_bug.cgi?id=40092

Added a stub implememntation.

WebCoreSupport/EditorClientEfl.h: (WebCore::EditorClientEfl::requestCheckingOfString):

2010-10-28 MORITA Hajime <morrita@google.com>

Reviewed by Ojan Vafai.

spellcheck does not check pasted text
https://bugs.webkit.org/show_bug.cgi?id=40092

Added a stub implememntation.

WebCoreSupport/EditorClientGtk.h: (WebKit::EditorClient::requestCheckingOfString):

2010-10-28 MORITA Hajime <morrita@google.com>

Reviewed by Ojan Vafai.

spellcheck does not check pasted text
https://bugs.webkit.org/show_bug.cgi?id=40092

Added a stub implememntation.

WebCoreSupport/EditorClientHaiku.h: (WebCore::EditorClientHaiku::requestCheckingOfString):

2010-10-28 MORITA Hajime <morrita@google.com>

Reviewed by Ojan Vafai.

spellcheck does not check pasted text
https://bugs.webkit.org/show_bug.cgi?id=40092

Added asynchronous spell checking API to WebEditorClient using
-[NSSpellChecker requestCheckingOfString].
Note that WebEditorSpellCheckResponder is a small class to receive
requested spell-checking result. Note that this feature is
disabled at default.

Also added [WebPreferences setAsynchronousSpellCheckingEnabled:] to
enable the feature from LayoutTestController.

WebCoreSupport/WebEditorClient.h:
WebCoreSupport/WebEditorClient.mm: (-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:results:]): (-[WebEditorSpellCheckResponder perform]): (toCoreSpellingResult): (-[WebEditorSpellCheckResponder WTF::WebCore::]): (WebEditorClient::requestCheckingOfString):
WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences setAsynchronousSpellCheckingEnabled:]): (-[WebPreferences asynchronousSpellCheckingEnabled]):
WebView/WebPreferencesPrivate.h:
WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):

2010-10-28 MORITA Hajime <morrita@google.com>

Reviewed by Ojan Vafai.

spellcheck does not check pasted text
https://bugs.webkit.org/show_bug.cgi?id=40092

Added a stub implememntation.

WebCoreSupport/EditorClientQt.h: (WebCore::EditorClientQt::requestCheckingOfString):

2010-10-28 MORITA Hajime <morrita@google.com>

Reviewed by Ojan Vafai.

spellcheck does not check pasted text
https://bugs.webkit.org/show_bug.cgi?id=40092

Added a stub implememntation.

WebCoreSupport/WebEditorClient.h: (WebEditorClient::requestCheckingOfString):

2010-10-28 MORITA Hajime <morrita@google.com>

Reviewed by Ojan Vafai.

spellcheck does not check pasted text
https://bugs.webkit.org/show_bug.cgi?id=40092

Added a stub implememntation.

WebCoreSupport/EditorClientWinCE.h: (WebKit::EditorClient::requestCheckingOfString):

2010-10-28 MORITA Hajime <morrita@google.com>

Reviewed by Ojan Vafai.

spellcheck does not check pasted text
https://bugs.webkit.org/show_bug.cgi?id=40092

Added a stub implememntation.

WebKitSupport/EditorClientWx.h: (WebCore::EditorClientWx::requestCheckingOfString):

2010-10-28 MORITA Hajime <morrita@google.com>

Reviewed by Ojan Vafai.

spellcheck does not check pasted text
https://bugs.webkit.org/show_bug.cgi?id=40092

Added a stub implememntation.

WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::requestCheckingOfString):
WebProcess/WebCoreSupport/WebEditorClient.h:

2010-10-28 MORITA Hajime <morrita@google.com>

Reviewed by Ojan Vafai.

spellcheck does not check pasted text
https://bugs.webkit.org/show_bug.cgi?id=40092

Added LayoutTestController::setAsynchronousSpellCheckingEnabled()
to control the setting.

DumpRenderTree/LayoutTestController.cpp: (setAsynchronousSpellCheckingEnabledCallback): (LayoutTestController::staticFunctions):
DumpRenderTree/LayoutTestController.h:
DumpRenderTree/chromium/LayoutTestController.h:
DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setAsynchronousSpellCheckingEnabled):
DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setAsynchronousSpellCheckingEnabled):
DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setAsynchronousSpellCheckingEnabled):
DumpRenderTree/qt/LayoutTestControllerQt.h:
DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setAsynchronousSpellCheckingEnabled):
DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setAsynchronousSpellCheckingEnabled):
DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setAsynchronousSpellCheckingEnabled):

9:52 PM Changeset in webkit [73885] by tonikitoo@webkit.org

4 edits in trunk/WebCore

2010-12-09 Antonio Gomes <agomes@rim.com>

Reviewed by Daniel Bates.

Spatial Navigation: code clean up (part II)
https://bugs.webkit.org/show_bug.cgi?id=50666

No new tests needed.

page/FocusController.cpp: Removed static declaration of updateFocusCandidateIfNeeded() from the top of FocusController.cpp, and added the 'static' keyword where the function is implemented;
page/SpatialNavigation.cpp: In FocusCandidate constructor, renamed 'n' to 'node', and added an assert to it; (WebCore::FocusCandidate::FocusCandidate): (WebCore::virtualRectForAreaElementAndDirection): Added an assert to 'node';
page/SpatialNavigation.h:I reordered the declaration of some methods in order to group related ones; Removed isScrollableContainerNode() function declaration since it is not used outside SpatialNavigation.cpp; And removed the declaration of isNodeDeepDescendantOfDocument() since it does not exist anymore.

8:41 PM Changeset in webkit [73884] by bweinstein@apple.com

2 edits in trunk/WebKit2

WebKit2: Implement WebInspector::localizedStringsURL on Windows
https://bugs.webkit.org/show_bug.cgi?id=50896

Reviewed by Tim Hatcher.

Find the localized strings file using CFBundleCopyResourceURL.

WebProcess/WebPage/win/WebInspectorWin.cpp:

(WebKit::WebInspector::localizedStringsURL):

4:49 PM Changeset in webkit [73883] by weinig@apple.com

2 edits in trunk/LayoutTests

Update WebKit2 skipped list.

platform/mac-wk2/Skipped:

4:30 PM Changeset in webkit [73882] by weinig@apple.com

2 edits in trunk/WebKit2

Give LogTextInput a sensible flag value.

Reviewed by Anders Carlsson.

Platform/Logging.cpp:

4:25 PM Changeset in webkit [73881] by weinig@apple.com

1 edit in trunk/WebKit2/ChangeLog

Add missing bugzilla URL.

4:14 PM Changeset in webkit [73880] by weinig@apple.com

2 edits in trunk/WebKitTools

Fix failing API test. It turns out that a pop-state event
is sent before every fragment navigation, so we have to test
for it in addition in PageLoadDidChangeLocationWithinPageForFrame.

Reviewed by Anders Carlsson.

TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:

(TestWebKitAPI::didSameDocumentNavigationForFrame):

4:02 PM Changeset in webkit [73879] by weinig@apple.com

2 edits in trunk/WebKit2

Remove incorrect assertion that has been firing in the API tester.

Reviewed by Anders Carlsson.

UIProcess/WebDatabaseManagerProxy.cpp:

(WebKit::WebDatabaseManagerProxy::~WebDatabaseManagerProxy):

4:00 PM Changeset in webkit [73878] by weinig@apple.com

2 edits in trunk/WebKit2

Disable WebKit2 logging by default.

Reviewed by Anders Carlsson.

Platform/Logging.cpp:

(initializeLogChannelsIfNecessary):

12:15 PM Changeset in webkit [73877] by bweinstein@apple.com

4 edits in trunk/WebKit2

Web Inspector: Make inspector on Windows show and be usable in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=50877

Reviewed by Sam Weinig.

Hook up the unimplemented methods in WebInspectorProxyWin to get the web inspector
showing and usable in WebKit2 on Windows.

UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::WebInspectorProxy): Initialize Windows-specific variables to 0.

UIProcess/WebInspectorProxy.h:
UIProcess/win/WebInspectorProxyWin.cpp:

(WebKit::WebInspectorProxy::registerInspectorViewWindowClass): Sets up the inspector view class.
(WebKit::WebInspectorProxy::InspectorViewWndProc): Calls through to the WebInspectorProxy's non-static

WndProc.

(WebKit::WebInspectorProxy::wndProc): Handles WM_SIZE, WM_CLOSE, and WM_GETMINMAXINFO, the rest go to

::DefWindowProc.

(WebKit::WebInspectorProxy::onSizeEvent): Resize the WKView that has the inspector page to match the

outer window that was just resized.

(WebKit::WebInspectorProxy::onMinMaxInfoEvent): Set the minimum size the window can be resized to.
(WebKit::WebInspectorProxy::onCloseEvent): Hide the window, and call WebInspectorProxy::close.
(WebKit::WebInspectorProxy::platformCreateInspectorPage): Create a WKView and return its page.
(WebKit::WebInspectorProxy::platformOpen): Create an HWND for the inspector, put the inspector's WKView

inside of it, and show the window.

(WebKit::WebInspectorProxy::platformClose): Destroy the inspector's window (which destroys the child WKView),

and 0 out instance variables.

(WebKit::WebInspectorProxy::inspectorPageURL): Finds inspector/inspector.html in the WebKit bundle.

8:25 AM Changeset in webkit [73876] by kbalazs@webkit.org

2 edits in trunk/WebKit2

[Qt][WK2] Crash in WebPage constructor.
https://bugs.webkit.org/show_bug.cgi?id=50892

Reviewed by Andreas Kling.

WebProcess/qt/WebProcessQt.cpp:

(WebKit::WebProcess::platformInitializeWebProcess):
Disable runtime enabled features that have no WebKit2 implementation yet.

4:00 AM Changeset in webkit [73875] by xan@webkit.org

2 edits in trunk/WebKit/gtk

2010-12-12 Xan Lopez <xlopez@igalia.com>

Rubber-stamped by Martin Robinson.

webkit/webkitwebplugin.h: add a note about the extension list being a NULL-terminated array.

4:00 AM Changeset in webkit [73874] by xan@webkit.org

20 edits in trunk/WebKit/gtk

2010-12-12 Xan Lopez <xlopez@igalia.com>

Rubber-stamped by Gustavo Noronha.

Stop checking for glib >= 2.16, we have dependend on a newer
version for a long time now.

tests/testatk.c: Stop checking for glib >= 2.16.
tests/testatkroles.c: ditto.
tests/testdomdocument.c: ditto.
tests/testdomdomwindow.c: ditto.
tests/testdomnode.c: ditto.
tests/testglobals.c: ditto.
tests/testhttpbackend.c: ditto.
tests/testloading.c: ditto.
tests/testmimehandling.c: ditto.
tests/testnetworkrequest.c: ditto.
tests/testnetworkresponse.c: ditto.
tests/testwebbackforwardlist.c: ditto.
tests/testwebdatasource.c: ditto.
tests/testwebframe.c: ditto.
tests/testwebhistoryitem.c: ditto.
tests/testwebresource.c: ditto.
tests/testwebsettings.c: ditto.
tests/testwebview.c: ditto.
tests/testwindow.c: ditto.

3:46 AM Changeset in webkit [73873] by commit-queue@webkit.org

2 edits in trunk/WebKitTools

2010-12-12 Alejandro G. Castro <alex@igalia.com>

Reviewed by Eric Seidel.

[GTK] Add new-run-webkit-tests support to gtk
https://bugs.webkit.org/show_bug.cgi?id=50681

Adding the basic support to run the new-run-webkit-tests.

Scripts/webkitpy/layout_tests/port/gtk.py:

3:30 AM Changeset in webkit [73872] by Philippe Normand

2 edits in trunk/WebCore

2010-12-12 Philippe Normand <pnormand@igalia.com>

Reviewed by Xan Lopez.

build-webkit --gtk --minimal fails
https://bugs.webkit.org/show_bug.cgi?id=46267

No new tests, build fix only.

GNUmakefile.am: Include some JS bindings generated headers in the build even if their corresponding feature is disabled. They are needed to make the DOM bindings build.

3:02 AM Changeset in webkit [73871] by alex

2 edits in trunk/LayoutTests

2010-12-12 Alejandro G. Castro <alex@igalia.com>

Unreviewed, skipping failing tests in the bots.

platform/gtk/Skipped:

3:00 AM Changeset in webkit [73870] by commit-queue@webkit.org

2 edits in trunk/WebCore

2010-12-12 Sam Magnuson <smagnuso@gmail.com>

Reviewed by Eric Seidel.

[Qt] Compile with QT_NO_QUUID_STRING.
https://bugs.webkit.org/show_bug.cgi?id=49745

platform/UUID.cpp: (WebCore::createCanonicalUUIDString):

2:58 AM Changeset in webkit [73869] by commit-queue@webkit.org

2 edits in trunk/WebCore

2010-12-12 Ragner Magalhaes <ragner.magalhaes@openbossa.org>

Reviewed by Eric Seidel.

[Qt] Missing style for date pickers on Qt Mobile theme
https://bugs.webkit.org/show_bug.cgi?id=50628

css/themeQtMobile.css:

Dec 11, 2010:

11:42 PM Changeset in webkit [73868] by alice.liu@apple.com

2 edits in trunk/WebCore

Mac build fix.

platform/network/mac/ResourceResponseMac.mm:

(WebCore::ResourceResponse::platformLazyInit):
Resolve string[0] ambiguity by passing 0U.

7:42 PM Changeset in webkit [73867] by commit-queue@webkit.org

8 edits in trunk/WebKit/qt

2010-12-11 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Memory leaks for QWebPageClient
https://bugs.webkit.org/show_bug.cgi?id=50267

Use OwnPtr to solve this memory leak issue.

Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::overlay): (QGraphicsWebViewPrivate::QWebViewPrivate::pageClient): (QGraphicsWebViewPrivate::syncLayers): (QGraphicsWebViewPrivate::updateResizesToContentsForPage): (QGraphicsWebViewPrivate::_q_scaleChanged): (QGraphicsWebViewPrivate::detachCurrentPage):
Api/qwebpage_p.h:
Api/qwebview.cpp: (QWebViewPrivate::detachCurrentPage):
WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::platformPageClient):
WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::setInputMethodState):
WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createPlugin):

7:24 PM Changeset in webkit [73866] by msaboff@apple.com

5 edits in trunk

2010-12-10 Michael Saboff <msaboff@apple.com>

Reviewed by Gavin Barraclough.

REGRESSION Hang inside Yarr::RegexCodeBlock::execute when visiting
bugs.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=50816

First nested parentheses of the second or greater alternative
where backtracking to the prior parentheses. Changed the default
handling of initial parentheses for all alternatives to go back
to the immediate outer paren.

yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::GenerationState::addParenthesesTail): (JSC::Yarr::RegexGenerator::TermGenerationState::TermGenerationState): (JSC::Yarr::RegexGenerator::TermGenerationState::isLastTerm): (JSC::Yarr::RegexGenerator::TermGenerationState::getTermIndex): (JSC::Yarr::RegexGenerator::TermGenerationState::setParenthesesTail): (JSC::Yarr::RegexGenerator::TermGenerationState::getParenthesesTail): (JSC::Yarr::RegexGenerator::ParenthesesTail::ParenthesesTail): (JSC::Yarr::RegexGenerator::ParenthesesTail::processBacktracks): (JSC::Yarr::RegexGenerator::ParenthesesTail::generateCode): (JSC::Yarr::RegexGenerator::generateParenthesesSingle):

2010-12-10 Michael Saboff <msaboff@apple.com>

Reviewed by Gavin Barraclough.

REGRESSION Hang inside Yarr::RegexCodeBlock::execute when visiting
bugs.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=50816

New test to verify proper backtracking of alternative nested parens.

fast/regex/parentheses-expected.txt:
fast/regex/script-tests/parentheses.js:

7:21 PM Changeset in webkit [73865] by commit-queue@webkit.org

3 edits in trunk/WebKit/qt

2010-12-11 Jan Erik Hanssen <jhanssen@sencha.com>

Reviewed by Andreas Kling.

[Qt] QWebFrame does not support QNetworkRequest::CacheLoadControl
https://bugs.webkit.org/show_bug.cgi?id=35671

Make QWebFrame respect the QNetworkRequest::CacheLoadControl attribute
set on the request, if any.

Api/qwebframe.cpp: (cacheLoadControlToCachePolicy): (QWebFrame::load):
tests/qwebframe/tst_qwebframe.cpp:

4:35 PM Changeset in webkit [73864] by abarth@webkit.org

4 edits in trunk/WebCore

2010-12-11 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

[V8] Move to DOMWindow::setLocation
https://bugs.webkit.org/show_bug.cgi?id=50876

Recently, JavaScriptCore moved to implementing setLocation in WebCore.
This patch change V8 to use that common code path. I haven't removed
the old code path because it's still used for other things (like
assigning window.location.href), but I'll move the rest over in a
future patch.

bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::locationAccessorSetter):
bindings/v8/specialization/V8BindingState.cpp: (WebCore::::getFirstWindow):
bindings/v8/specialization/V8BindingState.h:

12:55 PM Changeset in webkit [73863] by pfeldman@chromium.org

2 edits in trunk/LayoutTests

2010-12-11 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Updated chromium test expectations.

platform/chromium/test_expectations.txt:

12:44 PM XBL2UseCases edited by Dimitri Glazkov

(diff)

11:52 AM XBL2UseCases edited by Dimitri Glazkov

(diff)

10:49 AM Changeset in webkit [73862] by diegohcg@webkit.org

13 edits
2 adds in trunk

[Qt] Mock DeviceOrientation client for DRT
https://bugs.webkit.org/show_bug.cgi?id=47490

Reviewed by Kenneth Rohde Christiansen.

WebCore:

WebCore.pro:

WebKit/qt:

WebCoreSupport/DeviceOrientationClientMockQt.cpp: Added.

(WebCore::DeviceOrientationClientMockQt::client):
(WebCore::DeviceOrientationClientMockQt::DeviceOrientationClientMockQt):
(WebCore::DeviceOrientationClientMockQt::~DeviceOrientationClientMockQt):
(WebCore::DeviceOrientationClientMockQt::setController):
(WebCore::DeviceOrientationClientMockQt::startUpdating):
(WebCore::DeviceOrientationClientMockQt::stopUpdating):
(WebCore::DeviceOrientationClientMockQt::lastOrientation):
(WebCore::DeviceOrientationClientMockQt::deviceOrientationControllerDestroyed):
(WebCore::DeviceOrientationClientMockQt::setOrientation):

WebCoreSupport/DeviceOrientationClientMockQt.h: Added.
WebCoreSupport/DeviceOrientationClientQt.cpp:
WebCoreSupport/DeviceOrientationProviderQt.cpp:

(WebCore::DeviceOrientationProviderQt::DeviceOrientationProviderQt):
(WebCore::DeviceOrientationProviderQt::~DeviceOrientationProviderQt):
(WebCore::DeviceOrientationProviderQt::changeDeviceOrientation):

WebCoreSupport/DeviceOrientationProviderQt.h:
WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::activeMockDeviceOrientationClient):
(DumpRenderTreeSupportQt::removeMockDeviceOrientation):
(DumpRenderTreeSupportQt::setMockDeviceOrientation):

WebCoreSupport/DumpRenderTreeSupportQt.h:

WebKitTools:

DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::DumpRenderTree):
(WebCore::DumpRenderTree::~DumpRenderTree):

DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::setMockDeviceOrientation):

LayoutTests:

platform/qt/Skipped:

10:45 AM Changeset in webkit [73861] by pfeldman@chromium.org

2 edits in trunk/LayoutTests

2010-12-11 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Update chromium test expectations.

platform/chromium/test_expectations.txt:

10:20 AM Changeset in webkit [73860] by commit-queue@webkit.org

2 edits in trunk/WebCore

2010-12-11 Joone Hur <joone@kldp.org>

Reviewed by Alexey Proskuryakov.

enumeration value ‘ResponseTypeArrayBuffer’ not handled in switch
https://bugs.webkit.org/show_bug.cgi?id=50871

Fix the warning which occurs when enumeration value is not handled in switch.

No new tests, no change in behavior.

bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::response):

9:14 AM Changeset in webkit [73859] by Philippe Normand

2 edits in trunk/WebKitTools

2010-12-11 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] launcher: disable the Mozilla-style fullscreen API
https://bugs.webkit.org/show_bug.cgi?id=50874

Disabling the fullscreen API until its implementation for GTK is
mature enough. The webview setting for it is already FALSE by
default.

GtkLauncher/main.c: (createWindow):

8:25 AM Changeset in webkit [73858] by xan@webkit.org

6 edits
7 adds in trunk/WebKit/gtk

2010-12-11 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Add APIs for plugin management
https://bugs.webkit.org/show_bug.cgi?id=50827

Add WebKitWebPluginDatabase and WebKitWebPlugin classes for basic
plugin management at the client level. For now they provide
"read-only" access to the plugin list.

GNUmakefile.am: add new files to the build.
tests/testwebplugindatabase.c: Test that the database contains the test plugin, which should always be loaded.
webkit/webkit.h: add new headers.
webkit/webkitdefines.h: add new defines.
webkit/webkitwebplugin.cpp: An new class representing a plugin object.
webkit/webkitwebplugin.h: ditto.
webkit/webkitwebplugindatabase.cpp: A new class that contains the list of active plugins.
webkit/webkitwebplugindatabase.h: ditto.
webkit/webkitwebplugindatabaseprivate.h: Private header.
webkit/webkitwebpluginprivate.h: Private header.
webkit/webkitwebview.cpp: (webkit_get_web_plugin_database): returns the WebKitWebPluginDatabase for this session.
webkit/webkitwebview.h: add method to header.

7:44 AM Changeset in webkit [73857] by alex

2 edits in trunk/LayoutTests

2010-12-11 Alejandro G. Castro <alex@igalia.com>

Unreviewed, skipping failing tests in the bots.

platform/gtk/Skipped:

7:38 AM Changeset in webkit [73856] by xan@webkit.org

2 edits in trunk/LayoutTests

2010-12-11 Xan Lopez <xlopez@igalia.com>

Skip failing http test.

platform/gtk/Skipped:

5:05 AM Changeset in webkit [73855] by kov@webkit.org

21 edits
11 adds in trunk/WebKit/gtk

2010-12-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Split webkitprivate.{cpp,h} in more manageable chunks
https://bugs.webkit.org/show_bug.cgi?id=50698

Split private bits of several objects to their own private
headers, and to their implementation files.

GNUmakefile.am:
WebCoreSupport/ChromeClientGtk.cpp:
WebCoreSupport/EditorClientGtk.cpp:
WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchWillSendRequest):
webkit/webkitdownload.cpp: (webkit_download_set_response):
webkit/webkitdownloadprivate.h: Added.
webkit/webkithittestresult.cpp: (WebKit::kit):
webkit/webkithittestresultprivate.h: Added.
webkit/webkitnetworkresponse.cpp: (WebKit::core): (WebKit::kitNew):
webkit/webkitnetworkresponseprivate.h: Added.
webkit/webkitprivate.cpp:
webkit/webkitprivate.h:
webkit/webkitsecurityorigin.cpp: (webkit_security_origin_get_web_database): (WebKit::core): (WebKit::kit):
webkit/webkitsecurityoriginprivate.h: Added.
webkit/webkitviewportattributes.cpp:
webkit/webkitviewportattributesprivate.h: Added.
webkit/webkitwebbackforwardlist.cpp:
webkit/webkitwebbackforwardlistprivate.h: Added.
webkit/webkitwebdatabase.cpp:
webkit/webkitwebframe.cpp: (webkit_web_frame_get_network_response):
webkit/webkitwebhistoryitem.cpp:
webkit/webkitwebhistoryitemprivate.h: Added.
webkit/webkitwebnavigationaction.cpp: (WebKit::kit): (WebKit::core):
webkit/webkitwebnavigationactionprivate.h: Added.
webkit/webkitwebpolicydecision.cpp:
webkit/webkitwebpolicydecisionprivate.h: Added.
webkit/webkitwebresource.cpp:
webkit/webkitwebresourceprivate.h: Added.
webkit/webkitwebsettings.cpp:
webkit/webkitwebsettingsprivate.h: Added.
webkit/webkitwebview.cpp:

4:51 AM Changeset in webkit [73854] by xan@webkit.org

2 edits in trunk/LayoutTests

2010-12-11 Xan Lopez <xlopez@igalia.com>

Another crashing inspector test.

platform/gtk/Skipped:

4:48 AM Changeset in webkit [73853] by Patrick Gansterer

7 edits in trunk

2010-12-11 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Add an overload to makeString for Vector<char>
https://bugs.webkit.org/show_bug.cgi?id=50123

Also cleanup StringTypeAdapter.

wtf/text/StringConcatenate.h:

2010-12-11 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Add an overload to makeString for Vector<char>
https://bugs.webkit.org/show_bug.cgi?id=50123

This also contains a segfault fix for ImageBuffer::toDataURL of the Haiku port.

platform/graphics/cg/ImageBufferCG.cpp: (WebCore::ImageBuffer::toDataURL):
platform/graphics/gtk/ImageBufferGtk.cpp: (WebCore::ImageBuffer::toDataURL):
platform/graphics/haiku/ImageBufferHaiku.cpp: (WebCore::ImageBuffer::toDataURL):
platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::toDataURL):

4:36 AM Changeset in webkit [73852] by jhoneycutt@apple.com

7 edits in trunk/WebKit2

Select menus with short option titles do not paint properly
https://bugs.webkit.org/show_bug.cgi?id=50860
<rdar://problem/8660807>

The backing stores used for painting the popup menu items were only as
wide as the widest option title, but the popup window that we create is
at least as wide as the <select> element. This adjusts the backing
stores to be at least as wide as the <select>, as well.

Reviewed by Sam Weinig.

UIProcess/win/WebPopupMenuProxyWin.cpp:

(WebKit::WebPopupMenuProxyWin::paint):
Paint using the width of the backing store.

WebProcess/WebCoreSupport/WebPopupMenu.cpp:

(WebKit::WebPopupMenu::show):
Pass the page coordinates of the <select> element to
setUpPlatformData().

WebProcess/WebCoreSupport/WebPopupMenu.h:

Added new parameter to setUpPlatformData().

WebProcess/WebCoreSupport/mac/WebPopupMenuMac.mm:

(WebKit::WebPopupMenu::setUpPlatformData):
Ditto.

WebProcess/WebCoreSupport/qt/WebPopupMenuQt.cpp:

(WebKit::WebPopupMenu::setUpPlatformData):
Ditto.

WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp:

(WebKit::WebPopupMenu::setUpPlatformData):
Fixed a typo in a comment. Adjust the backing store size to be at least
as wide as the <select> element, and use that width when painting the
items to the backing store.

3:37 AM Changeset in webkit [73851] by xan@webkit.org