⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 13, 2010:

11:17 PM Changeset in webkit [74006] by tonikitoo@webkit.org
  • 3 edits in trunk/WebCore

2010-12-13 Antonio Gomes <agomes@rim.com>

Rubber stamped by Daniel Bates.

Spatial Navigation: code clean up (part V)
https://bugs.webkit.org/show_bug.cgi?id=50666

No new tests needed.

  • page/SpatialNavigation.cpp: (WebCore::distanceDataForNode): Made 'FocusCandidate current' const since it is not supposed to change within this function.
  • page/SpatialNavigation.h: Ditto.
10:58 PM Changeset in webkit [74005] by commit-queue@webkit.org
  • 5 edits in trunk/WebCore

2010-12-13 takano takumi <takano@apple.com>

Reviewed by Dan Bernstein.

GlyphPage::fill() is slow on vertical writing (Mac)
https://bugs.webkit.org/show_bug.cgi?id=50865

No test. Just a performance improvement.

  • platform/graphics/Font.cpp: (WebCore::Font::isCJKIdeograph): Now this only checks pure ideographs (Hanji). (WebCore::Font::isCJKIdeographOrSymbol): Added this for Hanji and Hanji related symbols.
  • platform/graphics/Font.h:
  • platform/graphics/FontFastPath.cpp: (WebCore::Font::glyphDataForCharacter): Changed to call isCJKIdeographOrSymbol() instead of isCJKIdeograph().
  • platform/graphics/mac/GlyphPageTreeNodeMac.cpp: (WebCore::shouldUseCoreText): This tests if GlyphPage::fill() should use CoreText or not. For vertical writing, if the current page contains only ideographs, we go CG path. (WebCore::GlyphPage::fill): Made to call shouldUseCoreText() and switch code path.
10:51 PM Changeset in webkit [74004] by tonikitoo@webkit.org
  • 3 edits in trunk/WebCore

2010-12-13 Antonio Gomes <agomes@rim.com>

Reviewed by Daniel Bates.

Spatial Navigation: code clean up (part IV)
https://bugs.webkit.org/show_bug.cgi?id=50666

Avoid calling canScrollInDirection more than necessary.

No new tests needed.

  • page/FocusController.cpp: (WebCore::FocusController::advanceFocusDirectionallyInContainer): Moved the call to canScrollInDirection() to within the scrollInDirection().
  • page/SpatialNavigation.cpp: Removed the assertion to canScrollingDirection function. (WebCore::scrollInDirection):
10:51 PM Changeset in webkit [74003] by tonikitoo@webkit.org
  • 4 edits in trunk/WebCore

2010-12-13 Antonio Gomes <agomes@rim.com>

Reviewed by Daniel Bates.

Spatial Navigation: code clean up (part III)
https://bugs.webkit.org/show_bug.cgi?id=50666

No new tests needed.

  • page/SpatialNavigation.h: Added FocusCandidate::isFrameOwnerElement and WebCore::frameOwnerElement helper functions. (WebCore::FocusCandidate::isFrameOwnerElement): Returns true if the Node pointer wrapped by FocusCandidate is an instance of HTMLFrameOwnerElement. Returns false otherwise.
  • page/SpatialNavigation.cpp: (WebCore::frameOwnerElement): Returns the HTMLFrameOwnerElement associated with the FocusCandidate if appropriate.
  • page/FocusController.cpp: (WebCore::updateFocusCandidateIfNeeded): Make use of newly added frameOwnerElement() helper. (WebCore::FocusController::adva
10:03 PM Changeset in webkit [74002] by mitz@apple.com
  • 12 edits in trunk/LayoutTests

Updated Leopard-specific results after r73993.

  • platform/mac-leopard/css2.1/t1202-counter-04-b-expected.txt:
  • platform/mac-leopard/css2.1/t1202-counters-04-b-expected.txt:
  • platform/mac-leopard/fast/text/complex-text-opacity-expected.txt:
  • platform/mac-leopard/fast/text/international/bidi-AN-after-L-expected.txt:
  • platform/mac-leopard/fast/text/international/bidi-AN-after-empty-run-expected.txt:
  • platform/mac-leopard/fast/text/international/bidi-CS-after-AN-expected.txt:
  • platform/mac-leopard/fast/text/international/bidi-mirror-he-ar-expected.txt:
  • platform/mac-leopard/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt:
  • platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.txt:
  • platform/mac-leopard/fast/text/international/thai-baht-space-expected.txt:
  • platform/mac-leopard/platform/mac/editing/input/devanagari-ligature-expected.txt:
9:53 PM Changeset in webkit [74001] by commit-queue@webkit.org
  • 3 edits in trunk

2010-12-13 Mike Lawther <mikelawther@chromium.org>

Reviewed by Daniel Bates.

[skia] ignore transform for canvas shadows
https://bugs.webkit.org/show_bug.cgi?id=50437

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformShadow):
9:49 PM Changeset in webkit [74000] by weinig@apple.com
  • 13 edits
    3 adds in trunk/WebKit2

WebKit2: Need to be able to set the application name for the user agent for a WKPage
https://bugs.webkit.org/show_bug.cgi?id=51011

Reviewed by Anders Carlsson.

Fixes:

WebKit2: Need to be able to set the application name for the user agent for a WKPage
<rdar://problem/8564532>
WebKit2: Need to be able to get the computed user agent for a WKPage
<rdar://problem/8637285>

Moves user agent computation to the UIProcess and just passes it to the WebProcess
when it has changed.

  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

  • Shared/WebPageCreationParameters.h:

Add a user agent to the creation parameters.

  • UIProcess/API/C/WKPage.cpp:

(WKPageCopyUserAgent):
(WKPageCopyApplicationNameForUserAgent):
(WKPageSetApplicationNameForUserAgent):
(WKPageSetCustomUserAgent):

  • UIProcess/API/C/WKPage.h:

Add new API to set the application name and access the computed user agent.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::setUserAgent):
(WebKit::WebPageProxy::setApplicationNameForUserAgent):
(WebKit::WebPageProxy::setCustomUserAgent):
(WebKit::WebPageProxy::processDidCrash):
(WebKit::WebPageProxy::creationParameters):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::userAgent):
(WebKit::WebPageProxy::applicationNameForUserAgent):

  • UIProcess/mac/WebPageProxyMac.mm: Added.
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::setUserAgent):

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::userAgent):

  • WebProcess/WebPage/WebPage.messages.in:

Pipe through user agent.

(WebKit::callGestalt):
(WebKit::macOSXVersionString):
(WebKit::userVisibleWebKitVersionString):
(WebKit::WebPageProxy::standardUserAgent):

  • UIProcess/win/WebPageProxyWin.cpp: Added.

(WebKit::windowsVersion):
(WebKit::userVisibleWebKitVersionString):
(WebKit::WebPageProxy::standardUserAgent):
Port standardUserAgent computation from WebKit1.

  • UIProcess/qt/WebPageProxyQt.cpp: Added.

(WebKit::WebPageProxy::standardUserAgent):
Stub out the user agent so there is no change in behavior.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Add new file.

9:19 PM Changeset in webkit [73999] by commit-queue@webkit.org
  • 48 edits in trunk

2010-12-13 Dai Mikurube <dmikurube@google.com>

Reviewed by Kent Tamura.

ValidityState's exposed functions should check if willValidate() is true before all
https://bugs.webkit.org/show_bug.cgi?id=50617

  • fast/css/pseudo-required-optional-005-expected.txt:
  • fast/css/pseudo-required-optional-005.html:
  • fast/css/pseudo-valid-001-expected.txt:
  • fast/css/pseudo-valid-001.html:
  • fast/css/pseudo-valid-unapplied-expected.txt:
  • fast/css/pseudo-valid-unapplied.html:
  • fast/forms/ValidityState-customError.html:
  • fast/forms/ValidityState-customError-expected.txt:
  • fast/forms/ValidityState-customError.html:
  • fast/forms/ValidityState-patternMismatch-expected.txt:
  • fast/forms/ValidityState-patternMismatch.html:
  • fast/forms/ValidityState-rangeOverflow-expected.txt:
  • fast/forms/ValidityState-rangeUnderflow-expected.txt:
  • fast/forms/ValidityState-stepMismatch-expected.txt:
  • fast/forms/ValidityState-tooLong-input-expected.txt:
  • fast/forms/ValidityState-tooLong-textarea-expected.txt:
  • fast/forms/ValidityState-typeMismatch-color-expected.txt:
  • fast/forms/ValidityState-typeMismatch-date-expected.txt:
  • fast/forms/ValidityState-typeMismatch-datetime-expected.txt:
  • fast/forms/ValidityState-typeMismatch-datetimelocal-expected.txt:
  • fast/forms/ValidityState-typeMismatch-month-expected.txt:
  • fast/forms/ValidityState-typeMismatch-number-expected.txt:
  • fast/forms/ValidityState-typeMismatch-time-expected.txt:
  • fast/forms/ValidityState-typeMismatch-url-expected.txt:
  • fast/forms/ValidityState-typeMismatch-week-expected.txt:
  • fast/forms/script-tests/ValidityState-rangeOverflow.js: (checkOverflow): (checkNotOverflow):
  • fast/forms/script-tests/ValidityState-rangeUnderflow.js: (checkUnderflow): (checkNotUnderflow):
  • fast/forms/script-tests/ValidityState-stepMismatch.js: (stepMismatchFor):
  • fast/forms/script-tests/ValidityState-tooLong-input.js:
  • fast/forms/script-tests/ValidityState-tooLong-textarea.js:
  • fast/forms/script-tests/ValidityState-typeMismatch-color.js: ():
  • fast/forms/script-tests/ValidityState-typeMismatch-date.js: (): (shouldBeValid): (shouldBeInvalid):
  • fast/forms/script-tests/ValidityState-typeMismatch-datetime.js: (): (shouldBeValid): (shouldBeInvalid):
  • fast/forms/script-tests/ValidityState-typeMismatch-datetimelocal.js: (): (shouldBeValid): (shouldBeInvalid):
  • fast/forms/script-tests/ValidityState-typeMismatch-month.js: (): (shouldBeValid): (shouldBeInvalid):
  • fast/forms/script-tests/ValidityState-typeMismatch-number.js: ():
  • fast/forms/script-tests/ValidityState-typeMismatch-time.js: (): (shouldBeValid): (shouldBeInvalid):
  • fast/forms/script-tests/ValidityState-typeMismatch-url.js: (check): (expectValid): (expectInvalid):
  • fast/forms/script-tests/ValidityState-typeMismatch-week.js: (): (shouldBeValid): (shouldBeInvalid):
  • fast/forms/script-tests/willvalidate.js:
  • fast/forms/willvalidate-expected.txt:

2010-12-13 Dai Mikurube <dmikurube@google.com>

Reviewed by Kent Tamura.

ValidityState's exposed functions should check if willValidate() is true before all
https://bugs.webkit.org/show_bug.cgi?id=50617

Added checking willValidate() to exposed functions. And modified willValidate() behavior
for <button type="submit"> and <input type="submit"> to return true if not disabled and
not readonly.

  • html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::parseMappedAttribute): Added calling setNeedsWillValidateCheck() to refresh willValidate() after changing its type. (WebCore::HTMLButtonElement::recalcWillValidate): Added to return true if not disabled and not readonly when type="submit". It's to be compliant to the spec.
  • html/HTMLButtonElement.h:
  • html/SubmitInputType.cpp: (WebCore::SubmitInputType::supportsValidation): Removed it to enable willValidate() for <input> when type="submit". It's to be compliant to the spec. (WebCore::SubmitInputType::supportsRequired): Added it to reject required attributes though validation is available.
  • html/SubmitInputType.h:
  • html/ValidityState.cpp: Added checking willValidate(). (WebCore::ValidityState::typeMismatch): (WebCore::ValidityState::patternMismatch): (WebCore::ValidityState::tooLong): (WebCore::ValidityState::rangeUnderflow): (WebCore::ValidityState::rangeOverflow): (WebCore::ValidityState::stepMismatch): (WebCore::ValidityState::customError):
  • html/ValidityState.h:
9:08 PM Changeset in webkit [73998] by bweinstein@apple.com
  • 8 edits
    6 adds in trunk/LayoutTests

Rebaseline Windows test results after r73993. All of these results were updated on the Mac with this
change, and this rebaselines Windows results to pass.

  • platform/win/css2.1/t0805-c5519-brdr-r-01-e-expected.txt: Added.
  • platform/win/css2.1/t0805-c5521-brdr-l-01-e-expected.txt: Added.
  • platform/win/css2.1/t0905-c5525-fltblck-00-d-ag-expected.txt: Added.
  • platform/win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt: Added.
  • platform/win/css2.1/t0905-c5525-fltwrap-00-b-expected.txt: Added.
  • platform/win/css2.1/t1202-counter-04-b-expected.txt:
  • platform/win/css2.1/t1202-counters-04-b-expected.txt:
  • platform/win/editing/deleting/5144139-2-expected.txt: Added.
  • platform/win/fast/text/international/bidi-mirror-he-ar-expected.txt:
  • platform/win/fast/text/international/bold-bengali-expected.txt:
  • platform/win/fast/text/international/complex-character-based-fallback-expected.txt:
  • platform/win/fast/text/international/hebrew-vowels-expected.txt:
  • platform/win/transforms/2d/hindi-rotated-expected.txt:
8:47 PM Changeset in webkit [73997] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-12-13 Noel Gordon <noel.gordon@gmail.com>

Reviewed by David Levin.

[chromium] Upstream skia/ImageBuffer.cpp routine mulDiv255Ceil()
https://bugs.webkit.org/show_bug.cgi?id=50545

Skia has rolled, replace uses of mulDiv255Ceil with SkMulDiv255Ceiling.

No new tests, no change in behaviour.

  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::putImageData):
7:21 PM Changeset in webkit [73996] by commit-queue@webkit.org
  • 4 edits in trunk

2010-12-13 Gavin Peters <gavinp@chromium.org>

Reviewed by Adam Barth.

Re land Purpose after bad merge
https://bugs.webkit.org/show_bug.cgi?id=51000

  • http/tests/misc/resources/prefetch-purpose.php:

2010-12-13 Gavin Peters <gavinp@chromium.org>

Reviewed by Adam Barth.

Re land Purpose after bad merge
https://bugs.webkit.org/show_bug.cgi?id=51000

  • loader/loader.cpp: (WebCore::Loader::load):
7:04 PM Changeset in webkit [73995] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-12-13 Mike Lawther <mikelawther@chromium.org>

Reviewed by James Robinson.

Update chromium DEPS to pull in latest Skia
https://bugs.webkit.org/show_bug.cgi?id=50984

Roll to revision that pulled in Skia r632 (http://src.chromium.org/viewvc/chrome?view=rev&revision=68558)

  • DEPS:
6:16 PM Changeset in webkit [73994] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-13 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium test expectations update.

Now that we've switched Chromium to the DRT (and the switch seems to
have stuck), remove the BUG_AWESOME lines about tests that only pass
with the DRT (but not test_shell).

  • platform/chromium/test_expectations.txt:
6:14 PM Changeset in webkit [73993] by mitz@apple.com
  • 279 edits in trunk

<rdar://problem/8763696> REGRESSION (r72173): Fallback fonts’ vertical metrics aren’t accounted for even when line-height is unspecified
https://bugs.webkit.org/show_bug.cgi?id=50979

Reviewed by Simon Fraser.

WebCore:

Many test results updated.

  • rendering/InlineFlowBox.cpp: Reinstated the code that updates affectsAscent and

affectsDescent in the used-fonts code path. Renamed variables for clarity. Added
a check whether usedFonts is empty (which it might be if there is glyph overflow
but no fallback) as an optimization.

LayoutTests:

  • editing/selection/extend-selection-bidi-expected.txt:
  • platform/mac/css2.1/t0805-c5518-brdr-t-01-e-expected.checksum:
  • platform/mac/css2.1/t0805-c5518-brdr-t-01-e-expected.png:
  • platform/mac/css2.1/t0805-c5518-brdr-t-01-e-expected.txt:
  • platform/mac/css2.1/t0805-c5519-brdr-r-00-a-expected.checksum:
  • platform/mac/css2.1/t0805-c5519-brdr-r-00-a-expected.png:
  • platform/mac/css2.1/t0805-c5519-brdr-r-00-a-expected.txt:
  • platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.checksum:
  • platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.png:
  • platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
  • platform/mac/css2.1/t0805-c5521-brdr-l-00-a-expected.checksum:
  • platform/mac/css2.1/t0805-c5521-brdr-l-00-a-expected.png:
  • platform/mac/css2.1/t0805-c5521-brdr-l-00-a-expected.txt:
  • platform/mac/css2.1/t0805-c5521-brdr-l-01-e-expected.checksum:
  • platform/mac/css2.1/t0805-c5521-brdr-l-01-e-expected.png:
  • platform/mac/css2.1/t0805-c5521-brdr-l-01-e-expected.txt:
  • platform/mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.checksum:
  • platform/mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.png:
  • platform/mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt:
  • platform/mac/css2.1/t0905-c414-flt-02-c-expected.checksum:
  • platform/mac/css2.1/t0905-c414-flt-02-c-expected.png:
  • platform/mac/css2.1/t0905-c414-flt-02-c-expected.txt:
  • platform/mac/css2.1/t0905-c414-flt-03-c-expected.checksum:
  • platform/mac/css2.1/t0905-c414-flt-03-c-expected.png:
  • platform/mac/css2.1/t0905-c414-flt-03-c-expected.txt:
  • platform/mac/css2.1/t0905-c414-flt-04-c-expected.checksum:
  • platform/mac/css2.1/t0905-c414-flt-04-c-expected.png:
  • platform/mac/css2.1/t0905-c414-flt-04-c-expected.txt:
  • platform/mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.checksum:
  • platform/mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.png:
  • platform/mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltblck-01-d-expected.checksum:
  • platform/mac/css2.1/t0905-c5525-fltblck-01-d-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltblck-01-d-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum:
  • platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
  • platform/mac/css2.1/t0905-c5525-flthw-00-c-g-expected.checksum:
  • platform/mac/css2.1/t0905-c5525-flthw-00-c-g-expected.png:
  • platform/mac/css2.1/t0905-c5525-flthw-00-c-g-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
  • platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltwidth-02-c-g-expected.checksum:
  • platform/mac/css2.1/t0905-c5525-fltwidth-02-c-g-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.checksum:
  • platform/mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltwrap-00-b-expected.checksum:
  • platform/mac/css2.1/t0905-c5525-fltwrap-00-b-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltwrap-00-b-expected.txt:
  • platform/mac/css2.1/t0905-c5526-flthw-00-c-g-expected.checksum:
  • platform/mac/css2.1/t0905-c5526-flthw-00-c-g-expected.png:
  • platform/mac/css2.1/t0905-c5526-flthw-00-c-g-expected.txt:
  • platform/mac/css2.1/t090501-c414-flt-01-b-expected.checksum:
  • platform/mac/css2.1/t090501-c414-flt-01-b-expected.png:
  • platform/mac/css2.1/t090501-c414-flt-01-b-expected.txt:
  • platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.checksum:
  • platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.png:
  • platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.txt:
  • platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.checksum:
  • platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.txt:
  • platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.checksum:
  • platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.txt:
  • platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.checksum:
  • platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.png:
  • platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.txt:
  • platform/mac/css2.1/t1202-counter-03-b-expected.checksum:
  • platform/mac/css2.1/t1202-counter-03-b-expected.png:
  • platform/mac/css2.1/t1202-counter-03-b-expected.txt:
  • platform/mac/css2.1/t1202-counter-04-b-expected.checksum:
  • platform/mac/css2.1/t1202-counter-04-b-expected.png:
  • platform/mac/css2.1/t1202-counter-04-b-expected.txt:
  • platform/mac/css2.1/t1202-counter-09-b-expected.checksum:
  • platform/mac/css2.1/t1202-counter-09-b-expected.png:
  • platform/mac/css2.1/t1202-counter-09-b-expected.txt:
  • platform/mac/css2.1/t1202-counters-03-b-expected.checksum:
  • platform/mac/css2.1/t1202-counters-03-b-expected.png:
  • platform/mac/css2.1/t1202-counters-03-b-expected.txt:
  • platform/mac/css2.1/t1202-counters-04-b-expected.checksum:
  • platform/mac/css2.1/t1202-counters-04-b-expected.png:
  • platform/mac/css2.1/t1202-counters-04-b-expected.txt:
  • platform/mac/css2.1/t1202-counters-09-b-expected.checksum:
  • platform/mac/css2.1/t1202-counters-09-b-expected.png:
  • platform/mac/css2.1/t1202-counters-09-b-expected.txt:
  • platform/mac/editing/deleting/5144139-2-expected.checksum:
  • platform/mac/editing/deleting/5144139-2-expected.png:
  • platform/mac/editing/deleting/5144139-2-expected.txt:
  • platform/mac/editing/selection/caret-rtl-2-expected.checksum:
  • platform/mac/editing/selection/caret-rtl-2-expected.png:
  • platform/mac/editing/selection/caret-rtl-2-expected.txt:
  • platform/mac/editing/selection/caret-rtl-2-left-expected.checksum:
  • platform/mac/editing/selection/caret-rtl-2-left-expected.png:
  • platform/mac/editing/selection/caret-rtl-2-left-expected.txt:
  • platform/mac/editing/selection/caret-rtl-expected.checksum:
  • platform/mac/editing/selection/caret-rtl-expected.png:
  • platform/mac/editing/selection/caret-rtl-expected.txt:
  • platform/mac/editing/selection/caret-rtl-right-expected.checksum:
  • platform/mac/editing/selection/caret-rtl-right-expected.png:
  • platform/mac/editing/selection/caret-rtl-right-expected.txt:
  • platform/mac/editing/selection/extend-selection-bidi-expected.checksum:
  • platform/mac/editing/selection/extend-selection-bidi-expected.png:
  • platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum:
  • platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
  • platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:
  • platform/mac/fast/css/beforeSelectorOnCodeElement-expected.checksum:
  • platform/mac/fast/css/beforeSelectorOnCodeElement-expected.png:
  • platform/mac/fast/css/beforeSelectorOnCodeElement-expected.txt:
  • platform/mac/fast/css/font-face-opentype-expected.checksum:
  • platform/mac/fast/css/font-face-opentype-expected.png:
  • platform/mac/fast/css/font-face-opentype-expected.txt:
  • platform/mac/fast/css/rtl-ordering-expected.checksum:
  • platform/mac/fast/css/rtl-ordering-expected.png:
  • platform/mac/fast/css/rtl-ordering-expected.txt:
  • platform/mac/fast/css/text-overflow-ellipsis-bidi-expected.checksum:
  • platform/mac/fast/css/text-overflow-ellipsis-bidi-expected.png:
  • platform/mac/fast/css/text-overflow-ellipsis-bidi-expected.txt:
  • platform/mac/fast/css/text-overflow-ellipsis-expected.checksum:
  • platform/mac/fast/css/text-overflow-ellipsis-expected.png:
  • platform/mac/fast/css/text-overflow-ellipsis-expected.txt:
  • platform/mac/fast/css/text-overflow-ellipsis-strict-expected.checksum:
  • platform/mac/fast/css/text-overflow-ellipsis-strict-expected.png:
  • platform/mac/fast/css/text-overflow-ellipsis-strict-expected.txt:
  • platform/mac/fast/css/text-security-expected.checksum:
  • platform/mac/fast/css/text-security-expected.png:
  • platform/mac/fast/css/text-security-expected.txt:
  • platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.checksum:
  • platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.png:
  • platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.txt:
  • platform/mac/fast/encoding/invalid-UTF-8-expected.checksum:
  • platform/mac/fast/encoding/invalid-UTF-8-expected.png:
  • platform/mac/fast/encoding/invalid-UTF-8-expected.txt:
  • platform/mac/fast/events/updateLayoutForHitTest-expected.checksum:
  • platform/mac/fast/events/updateLayoutForHitTest-expected.png:
  • platform/mac/fast/events/updateLayoutForHitTest-expected.txt:
  • platform/mac/fast/forms/select-visual-hebrew-expected.checksum:
  • platform/mac/fast/forms/select-visual-hebrew-expected.png:
  • platform/mac/fast/forms/select-visual-hebrew-expected.txt:
  • platform/mac/fast/forms/select-writing-direction-natural-expected.checksum:
  • platform/mac/fast/forms/select-writing-direction-natural-expected.png:
  • platform/mac/fast/forms/select-writing-direction-natural-expected.txt:
  • platform/mac/fast/forms/visual-hebrew-text-field-expected.checksum:
  • platform/mac/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/mac/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/mac/fast/ruby/nested-ruby-expected.txt:
  • platform/mac/fast/text/atsui-multiple-renderers-expected.checksum:
  • platform/mac/fast/text/atsui-multiple-renderers-expected.png:
  • platform/mac/fast/text/atsui-multiple-renderers-expected.txt:
  • platform/mac/fast/text/backslash-to-yen-sign-euc-expected.checksum:
  • platform/mac/fast/text/backslash-to-yen-sign-euc-expected.png:
  • platform/mac/fast/text/backslash-to-yen-sign-euc-expected.txt:
  • platform/mac/fast/text/backslash-to-yen-sign-expected.checksum:
  • platform/mac/fast/text/backslash-to-yen-sign-expected.png:
  • platform/mac/fast/text/backslash-to-yen-sign-expected.txt:
  • platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.checksum:
  • platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.png:
  • platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.txt:
  • platform/mac/fast/text/capitalize-boundaries-expected.checksum:
  • platform/mac/fast/text/capitalize-boundaries-expected.png:
  • platform/mac/fast/text/capitalize-boundaries-expected.txt:
  • platform/mac/fast/text/cg-fallback-bolding-expected.checksum:
  • platform/mac/fast/text/cg-fallback-bolding-expected.png:
  • platform/mac/fast/text/cg-fallback-bolding-expected.txt:
  • platform/mac/fast/text/complex-text-opacity-expected.checksum:
  • platform/mac/fast/text/complex-text-opacity-expected.png:
  • platform/mac/fast/text/complex-text-opacity-expected.txt:
  • platform/mac/fast/text/in-rendered-text-rtl-expected.checksum:
  • platform/mac/fast/text/in-rendered-text-rtl-expected.png:
  • platform/mac/fast/text/in-rendered-text-rtl-expected.txt:
  • platform/mac/fast/text/international/001-expected.checksum:
  • platform/mac/fast/text/international/001-expected.png:
  • platform/mac/fast/text/international/001-expected.txt:
  • platform/mac/fast/text/international/002-expected.checksum:
  • platform/mac/fast/text/international/002-expected.png:
  • platform/mac/fast/text/international/002-expected.txt:
  • platform/mac/fast/text/international/003-expected.checksum:
  • platform/mac/fast/text/international/003-expected.png:
  • platform/mac/fast/text/international/003-expected.txt:
  • platform/mac/fast/text/international/bidi-AN-after-L-expected.checksum:
  • platform/mac/fast/text/international/bidi-AN-after-L-expected.png:
  • platform/mac/fast/text/international/bidi-AN-after-L-expected.txt:
  • platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.checksum:
  • platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.png:
  • platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.txt:
  • platform/mac/fast/text/international/bidi-CS-after-AN-expected.checksum:
  • platform/mac/fast/text/international/bidi-CS-after-AN-expected.png:
  • platform/mac/fast/text/international/bidi-CS-after-AN-expected.txt:
  • platform/mac/fast/text/international/bidi-L2-run-reordering-expected.checksum:
  • platform/mac/fast/text/international/bidi-L2-run-reordering-expected.png:
  • platform/mac/fast/text/international/bidi-L2-run-reordering-expected.txt:
  • platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.checksum:
  • platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.png:
  • platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.txt:
  • platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.checksum:
  • platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.png:
  • platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.txt:
  • platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.checksum:
  • platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
  • platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
  • platform/mac/fast/text/international/bidi-european-terminators-expected.checksum:
  • platform/mac/fast/text/international/bidi-european-terminators-expected.png:
  • platform/mac/fast/text/international/bidi-european-terminators-expected.txt:
  • platform/mac/fast/text/international/bidi-fallback-font-weight-expected.checksum:
  • platform/mac/fast/text/international/bidi-fallback-font-weight-expected.png:
  • platform/mac/fast/text/international/bidi-fallback-font-weight-expected.txt:
  • platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.checksum:
  • platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
  • platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
  • platform/mac/fast/text/international/bidi-innertext-expected.checksum:
  • platform/mac/fast/text/international/bidi-innertext-expected.png:
  • platform/mac/fast/text/international/bidi-innertext-expected.txt:
  • platform/mac/fast/text/international/bidi-linebreak-001-expected.checksum:
  • platform/mac/fast/text/international/bidi-linebreak-001-expected.png:
  • platform/mac/fast/text/international/bidi-linebreak-001-expected.txt:
  • platform/mac/fast/text/international/bidi-linebreak-002-expected.checksum:
  • platform/mac/fast/text/international/bidi-linebreak-002-expected.png:
  • platform/mac/fast/text/international/bidi-linebreak-002-expected.txt:
  • platform/mac/fast/text/international/bidi-linebreak-003-expected.checksum:
  • platform/mac/fast/text/international/bidi-linebreak-003-expected.png:
  • platform/mac/fast/text/international/bidi-linebreak-003-expected.txt:
  • platform/mac/fast/text/international/bidi-listbox-atsui-expected.checksum:
  • platform/mac/fast/text/international/bidi-listbox-atsui-expected.png:
  • platform/mac/fast/text/international/bidi-listbox-atsui-expected.txt:
  • platform/mac/fast/text/international/bidi-listbox-expected.checksum:
  • platform/mac/fast/text/international/bidi-listbox-expected.png:
  • platform/mac/fast/text/international/bidi-listbox-expected.txt:
  • platform/mac/fast/text/international/bidi-menulist-expected.checksum:
  • platform/mac/fast/text/international/bidi-menulist-expected.png:
  • platform/mac/fast/text/international/bidi-menulist-expected.txt:
  • platform/mac/fast/text/international/bidi-mirror-he-ar-expected.checksum:
  • platform/mac/fast/text/international/bidi-mirror-he-ar-expected.png:
  • platform/mac/fast/text/international/bidi-mirror-he-ar-expected.txt:
  • platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.checksum:
  • platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png:
  • platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt:
  • platform/mac/fast/text/international/bidi-neutral-run-expected.checksum:
  • platform/mac/fast/text/international/bidi-neutral-run-expected.png:
  • platform/mac/fast/text/international/bidi-neutral-run-expected.txt:
  • platform/mac/fast/text/international/bidi-override-expected.checksum:
  • platform/mac/fast/text/international/bidi-override-expected.png:
  • platform/mac/fast/text/international/bidi-override-expected.txt:
  • platform/mac/fast/text/international/complex-character-based-fallback-expected.checksum:
  • platform/mac/fast/text/international/complex-character-based-fallback-expected.png:
  • platform/mac/fast/text/international/complex-character-based-fallback-expected.txt:
  • platform/mac/fast/text/international/danda-space-expected.checksum:
  • platform/mac/fast/text/international/danda-space-expected.png:
  • platform/mac/fast/text/international/danda-space-expected.txt:
  • platform/mac/fast/text/international/hebrew-vowels-expected.checksum:
  • platform/mac/fast/text/international/hebrew-vowels-expected.png:
  • platform/mac/fast/text/international/hebrew-vowels-expected.txt:
  • platform/mac/fast/text/international/hindi-spacing-expected.checksum:
  • platform/mac/fast/text/international/hindi-spacing-expected.png:
  • platform/mac/fast/text/international/hindi-spacing-expected.txt:
  • platform/mac/fast/text/international/hindi-whitespace-expected.checksum:
  • platform/mac/fast/text/international/hindi-whitespace-expected.png:
  • platform/mac/fast/text/international/hindi-whitespace-expected.txt:
  • platform/mac/fast/text/international/plane2-expected.checksum:
  • platform/mac/fast/text/international/plane2-expected.png:
  • platform/mac/fast/text/international/plane2-expected.txt:
  • platform/mac/fast/text/international/rtl-caret-expected.checksum:
  • platform/mac/fast/text/international/rtl-caret-expected.png:
  • platform/mac/fast/text/international/rtl-caret-expected.txt:
  • platform/mac/fast/text/international/thai-baht-space-expected.checksum:
  • platform/mac/fast/text/international/thai-baht-space-expected.png:
  • platform/mac/fast/text/international/thai-baht-space-expected.txt:
  • platform/mac/fast/text/international/thai-line-breaks-expected.checksum:
  • platform/mac/fast/text/international/thai-line-breaks-expected.png:
  • platform/mac/fast/text/international/thai-line-breaks-expected.txt:
  • platform/mac/fast/text/international/wrap-CJK-001-expected.checksum:
  • platform/mac/fast/text/international/wrap-CJK-001-expected.png:
  • platform/mac/fast/text/international/wrap-CJK-001-expected.txt:
  • platform/mac/transforms/2d/hindi-rotated-expected.checksum:
  • platform/mac/transforms/2d/hindi-rotated-expected.png:
  • platform/mac/transforms/2d/hindi-rotated-expected.txt:
5:59 PM Changeset in webkit [73992] by beidson@apple.com
  • 5 edits in trunk/WebKit2

<rdar://problem/8752202> and https://bugs.webkit.org/show_bug.cgi?id=50997
Expose "link title" and "link label" to InjectedBundleHitTestResult API

Reviewed by Jon Honeycutt (and Brian Weinstein in heart).

  • WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:

(WKBundleHitTestResultCopyLinkLabel):
(WKBundleHitTestResultCopyLinkTitle):

  • WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.h:
  • WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:

(WebKit::InjectedBundleHitTestResult::linkLabel):
(WebKit::InjectedBundleHitTestResult::linkTitle):

  • WebProcess/InjectedBundle/InjectedBundleHitTestResult.h:
5:42 PM Changeset in webkit [73991] by eric@webkit.org
  • 6 edits
    1 add in trunk/WebKitTools

2010-12-13 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

FlakyTestReporter doesn't understand bots running from multiple email addresses
https://bugs.webkit.org/show_bug.cgi?id=50960

This explains at least one of the dupes of:
https://bugs.webkit.org/show_bug.cgi?id=50863
that we saw filed by the commit-queue this morning.
I think the other one was explained by my previous fix to result counting code.

Since this is really hard to test with a unit test, instead I
create a new (possibly useful in the future) command
which given a layout test path will return you
the one bug which our tools would assume it the flaky test bug.
If some other script wants to use bug-for-test we'll
need to extend it with some options like --create-if-missing or similar.

  • Scripts/webkitpy/common/net/bugzilla/bug.py:
  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  • Scripts/webkitpy/tool/bot/flakytestreporter.py:
  • Scripts/webkitpy/tool/commands/init.py:
  • Scripts/webkitpy/tool/commands/bugfortest.py: Added.
5:28 PM Changeset in webkit [73990] by demarchi@webkit.org
  • 2 edits in trunk/WebKit/efl

2010-12-13 Alex Bredariol Grilo <abgrilo@profusion.mobi>

Reviewed by Andreas Kling.

Remove adjacent tiles rendering queue.
https://bugs.webkit.org/show_bug.cgi?id=50023

In the current implementation of the tiled backing store, one extra row
and column of tiles are needed to render the entire viewport. These
extra row/col proved to be expensive when being rendered, and were
postponed to a queue that would render them after rendering the other
tiles of the viewport first. This approach complicated unnecessarily
the logics with no gain for keeping the extra row and column. This
change removes this rendering queue, for later removing the extra row
and column of tiles.

  • ewk/ewk_tiled_backing_store.c: (_ewk_tiled_backing_store_pre_render_request_add): (_ewk_tiled_backing_store_pre_render_request_flush): (_ewk_tiled_backing_store_pre_render_request_clear): (_ewk_tiled_backing_store_pre_render_request_process_single): (_ewk_tiled_backing_store_item_fill): (_ewk_tiled_backing_store_item_add): (_ewk_tiled_backing_store_item_del): (_ewk_tiled_backing_store_recalc_renderers): (ewk_tiled_backing_store_pre_render_region): (ewk_tiled_backing_store_pre_render_relative_radius): (ewk_tiled_backing_store_pre_render_cancel):
5:08 PM Changeset in webkit [73989] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Remove unnecessary include of Switch module.

Rubber-stamped by Jon Honeycutt.

There are no switch statements in this file.

  • dom/make_names.pl:
5:08 PM Changeset in webkit [73988] by bweinstein@apple.com
  • 2 edits in trunk/WebKit2

Windows Build Fix. Add a needed include.

  • UIProcess/win/WebView.cpp:
4:59 PM Changeset in webkit [73987] by jhoneycutt@apple.com
  • 2 edits in trunk/LayoutTests

Add a failing test to the Windows skipped list.

Rubber-stamped by Steve Falkenburg.

  • platform/win/Skipped:

Added fast/loader/user-stylesheet-fast-path.html.

4:55 PM Changeset in webkit [73986] by weinig@apple.com
  • 20 edits
    2 deletes in trunk/WebKit2

Remove associated page concept from WKView constructor
https://bugs.webkit.org/show_bug.cgi?id=50983

Reviewed by Anders Carlsson.

Step 2: Remove WebPageNamespace. It no longer does anything.

  • Shared/APIObject.h:
  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:contextRef:pageGroupRef:]):

  • UIProcess/API/qt/qgraphicswkview.cpp:
  • UIProcess/API/qt/qwkcontext.cpp:

(QWKContext::QWKContext):

  • UIProcess/API/qt/qwkcontext_p.h:
  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::QWKPagePrivate):

  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
(WebKit::WebContext::createWebPage):

  • UIProcess/WebContext.h:
  • UIProcess/WebPageNamespace.cpp: Removed.
  • UIProcess/WebPageNamespace.h: Removed.
  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::context):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::createWebPage):

  • UIProcess/WebProcessProxy.h:
  • UIProcess/win/WebView.cpp:

(WebKit::WebView::WebView):

  • UIProcess/win/WebView.h:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
4:55 PM Changeset in webkit [73985] by mihaip@chromium.org
  • 2 edits in trunk/WebKitTools

2010-12-13 Mihai Parparita <mihaip@chromium.org>

Reviewed by James Robinson.

Add option to build-webkit to not build WebKit2
https://bugs.webkit.org/show_bug.cgi?id=50988

Add support for a --no-webkit2 option to build-webkit. It seems to save
~1 minute from clean builds and ~10 seconds from no-op builds.

  • Scripts/build-webkit:
4:24 PM Changeset in webkit [73984] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-12-13 Emil Eklund <eae@chromium.org>

Reviewed by Dimitri Glazkov.

Change SelectionController::setFocusedNodeIfNeeded to traverse the DOM
tree instead of the render tree.
https://bugs.webkit.org/show_bug.cgi?id=50989

  • editing/SelectionController.cpp: (WebCore::SelectionController::setFocusedNodeIfNeeded): Walk up DOM/hosted tree rather than render tree and remove FIXME comment that does't apply (SelectionController and EventHandler needs different checks).
4:16 PM Changeset in webkit [73983] by Chris Fleizach
  • 11 edits
    2 adds in trunk

AX: aria-invalid should be supported.
https://bugs.webkit.org/show_bug.cgi?id=50573

Reviewed by Beth Dakin.

WebCore:

Test: platform/mac/accessibility/aria-invalid.html

  • accessibility/AXObjectCache.h:
  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::invalidStatus):

  • accessibility/AccessibilityObject.h:
  • accessibility/chromium/AXObjectCacheChromium.cpp

(WebCore::AXObjectCache::postPlatformNotification):

  • accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::postPlatformNotification):

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

  • dom/Element.cpp:

(WebCore::Element::updateAfterAttributeChanged):

  • html/HTMLAttributeNames.in:

LayoutTests:

  • platform/mac/accessibility/aria-invalid-expected.txt: Added.
  • platform/mac/accessibility/aria-invalid.html: Added.
  • platform/mac/accessibility/radio-button-group-members-expected.txt:
4:15 PM Changeset in webkit [73982] by Stephanie Lewis
  • 1 edit
    13 copies
    3 moves
    96 adds in trunk/WebKitTools

Update iexploder from 1.3.2 to 1.7.2
Move 1.3.2 into its own subdir
Add 1.7.2 into its own subdir
update scripts to point to new 1.3.2 location (avoid breaking existing scripts)

Reviewed by Dave Kilzer.

  • Scripts/run-iexploder-tests:
  • Scripts/update-iexploder-cssproperties:
  • iExploder/CHANGELOG.txt: Removed.
  • iExploder/LICENSE.txt: Removed.
  • iExploder/README.txt: Removed.
  • iExploder/htdocs: Removed.
  • iExploder/iexploder-1.3.2: Added.
  • iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
  • iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
  • iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
  • iExploder/iexploder-1.3.2/htdocs: Added.
  • iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
  • iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
  • iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
  • iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
  • iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
  • iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
  • iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
  • iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
  • iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
  • iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
  • iExploder/iexploder-1.3.2/tools: Added.
  • iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
  • iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
  • iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
  • iExploder/iexploder-1.7.2: Added.
  • iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
  • iExploder/iexploder-1.7.2/LICENSE.txt: Added.
  • iExploder/iexploder-1.7.2/README.txt: Added.
  • iExploder/iexploder-1.7.2/output: Added.
  • iExploder/iexploder-1.7.2/src: Added.
  • iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
  • iExploder/iexploder-1.7.2/src/config.yaml: Added.
  • iExploder/iexploder-1.7.2/src/css-atrules: Added.
  • iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
  • iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
  • iExploder/iexploder-1.7.2/src/css-properties: Added.
  • iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
  • iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
  • iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
  • iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
  • iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
  • iExploder/iexploder-1.7.2/src/css-pseudo: Added.
  • iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
  • iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
  • iExploder/iexploder-1.7.2/src/css-values: Added.
  • iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
  • iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
  • iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
  • iExploder/iexploder-1.7.2/src/css-values/other: Added.
  • iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
  • iExploder/iexploder-1.7.2/src/headers: Added.
  • iExploder/iexploder-1.7.2/src/headers/dillo: Added.
  • iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
  • iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
  • iExploder/iexploder-1.7.2/src/headers/webkit: Added.
  • iExploder/iexploder-1.7.2/src/html-attrs: Added.
  • iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
  • iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
  • iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
  • iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
  • iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
  • iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
  • iExploder/iexploder-1.7.2/src/html-tags: Added.
  • iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
  • iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
  • iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
  • iExploder/iexploder-1.7.2/src/html-tags/other: Added.
  • iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
  • iExploder/iexploder-1.7.2/src/html-values: Added.
  • iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
  • iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
  • iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
  • iExploder/iexploder-1.7.2/src/html-values/other: Added.
  • iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
  • iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
  • iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
  • iExploder/iexploder-1.7.2/src/index.html: Added.
  • iExploder/iexploder-1.7.2/src/media: Added.
  • iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
  • iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
  • iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
  • iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
  • iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
  • iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
  • iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
  • iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
  • iExploder/iexploder-1.7.2/src/media/bug.png: Added.
  • iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
  • iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
  • iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
  • iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
  • iExploder/iexploder-1.7.2/src/mime-types: Added.
  • iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
  • iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
  • iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
  • iExploder/iexploder-1.7.2/src/protocols: Added.
  • iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
  • iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
  • iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
  • iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
  • iExploder/iexploder-1.7.2/src/scanner.rb: Added.
  • iExploder/iexploder-1.7.2/src/version.rb: Added.
  • iExploder/iexploder-1.7.2/src/webserver.rb: Added.
  • iExploder/iexploder-1.7.2/testcases: Added.
  • iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
  • iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
  • iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added.
  • iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added.
  • iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added.
  • iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added.
  • iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added.
  • iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added.
  • iExploder/iexploder-1.7.2/tools: Added.
  • iExploder/iexploder-1.7.2/tools/lasthit.rb: Added.
  • iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added.
  • iExploder/iexploder-1.7.2/tools/release_src.sh: Added.
  • iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added.
  • iExploder/tools: Removed.
4:02 PM Changeset in webkit [73981] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

Reviewed by Gavin Barraclough.

JavaScriptCore should not use "asm volatile" outside of a function
https://bugs.webkit.org/show_bug.cgi?id=50991

  • jit/JITStubs.cpp: Remove the volatile keyword from asm statements.
4:01 PM Changeset in webkit [73980] by sfalken@apple.com
  • 2 edits in tags/Safari-534.14.3/JavaScriptCore

Merge r73967.

3:58 PM Changeset in webkit [73979] by sfalken@apple.com
  • 5 edits in tags/Safari-534.14.3

Versioning.

3:39 PM Changeset in webkit [73978] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Fix windows build.

  • UIProcess/win/WebView.h:
3:39 PM Changeset in webkit [73977] by weinig@apple.com
  • 3 edits in trunk/WebKit2

Fix windows build.

  • UIProcess/win/WebInspectorProxyWin.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

  • UIProcess/win/WebView.h:

(WebKit::WebView::create):

3:23 PM Changeset in webkit [73976] by weinig@apple.com
  • 19 edits in trunk

Remove associated page concept from WKView constructor
https://bugs.webkit.org/show_bug.cgi?id=50983

Reviewed by Anders Carlsson.

Step 1: Remove associate page constructors from WKView and make
all views use the shared namespace for the context.

WebKit2:

  • UIProcess/API/C/win/WKView.cpp:
  • UIProcess/API/C/win/WKView.h:
  • UIProcess/API/mac/WKView.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:contextRef:pageGroupRef:]):

  • UIProcess/API/qt/qwkcontext.cpp:
  • UIProcess/API/qt/qwkcontext.h:
  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::WebView):

  • UIProcess/win/WebView.h:

(WebKit::WebView::create):

WebKitTools:

  • TestWebKitAPI/PlatformWebView.h:
  • TestWebKitAPI/mac/PlatformWebViewMac.mm:
  • TestWebKitAPI/win/PlatformWebViewWin.cpp:
  • WebKitTestRunner/PlatformWebView.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::createOtherPage):

  • WebKitTestRunner/mac/PlatformWebViewMac.mm:
  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  • WebKitTestRunner/win/PlatformWebViewWin.cpp:
3:20 PM Changeset in webkit [73975] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-12-13 Joone Hur <joone@kldp.org>

Reviewed by Eric Seidel.

WebKit fails to compile when building with WML support enabled
https://bugs.webkit.org/show_bug.cgi?id=42943

Use TextPosition instead of lineNumber() and columNumber().

No new tests are added, because this is just a build fix.

  • dom/XMLDocumentParser.h: Make lineNumber() private.
  • wml/WMLErrorHandling.cpp: (WebCore::reportWMLError): Use TextPosition instead of lineNumber() and columnNumber().
3:19 PM Changeset in webkit [73974] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Fix build.

  • UIProcess/WebPageProxy.h:
3:06 PM Changeset in webkit [73973] by Chris Fleizach
  • 2 edits in trunk

AX: lists and list boxes need different attributes
https://bugs.webkit.org/show_bug.cgi?id=50978

Reviewed by Beth Dakin.

WebCore:

Separate out the attributes being returned for lists (<ul>) and listboxes (<select multiple>).

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityAttributeNames]):

LayoutTests:

  • platform/mac/accessibility/lists-expected.txt:
3:05 PM Changeset in webkit [73972] by hyatt@apple.com
  • 3 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=50963

Reviewed by Sam Weinig.

REGRESSION: Scrolling nested iframes is messed up on platforms that use the cross-platform ScrollView.

The selfClipRect and childrenClipRect methods of RenderLayer were incorrectly relying on the bounding box
of the root layer. This bounding box was only coincidentally incorporating overflow as part of the
RenderLayer's bounds. Since I fixed the RenderLayer bounds to not include layout overflow any longer,
this check is now exposed as incorrect. Use the entire document size when computing layer clip
rects.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::childrenClipRect):
(WebCore::RenderLayer::selfClipRect):

  • rendering/RenderView.h:

(WebCore::RenderView::documentRect):

3:05 PM Changeset in webkit [73971] by Chris Fleizach
  • 2 edits in trunk

2010-12-13 Chris Fleizach <Chris Fleizach>

Reviewed by Beth Dakin.

AX: lists and list boxes need different attributes
https://bugs.webkit.org/show_bug.cgi?id=50978

Separate out the attributes being returned for lists (<ul>) and listboxes (<select multiple>).

  • accessibility/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
3:02 PM Changeset in webkit [73970] by bweinstein@apple.com
  • 4 edits in trunk/WebKit2

WebKit2: Leaks a WebView when opening/closing Web Inspector on Windows
https://bugs.webkit.org/show_bug.cgi?id=50975
<rdar://problem/8763501>

Reviewed by Adam Roben.

Make m_inspectorView be a RefPtr<WebView>, instead of a WebView*.

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::WebInspectorProxy): If we are on Windows, include WebView.h.

  • UIProcess/WebInspectorProxy.h: Change the type of m_inspectorView to a RefPtr<WebView>.
  • UIProcess/win/WebInspectorProxyWin.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage): Remove the call to leakRef when creating the WebView.

3:02 PM Changeset in webkit [73969] by sfalken@apple.com
  • 1 copy in tags/Safari-534.14.3

New tag.

3:01 PM Changeset in webkit [73968] by andersca@apple.com
  • 12 edits in trunk/WebKit2

Pass the complex text input state all the way to the UI process
https://bugs.webkit.org/show_bug.cgi?id=50980

Reviewed by Darin Adler.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::setComplexTextInputEnabled):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setComplexTextInputEnabled):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::pluginComplexTextInputIdentifier):

  • WebProcess/Plugins/Plugin.h:
  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::pluginComplexTextInputIdentifier):
(WebKit::PluginProxy::setComplexTextInputEnabled):

  • WebProcess/Plugins/PluginProxy.h:
  • WebProcess/Plugins/PluginProxy.messages.in:
  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::setComplexTextInputEnabled):

3:01 PM Changeset in webkit [73967] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows production build fix.
Try copying ICU 4.6 in addition to 4.4 and 4.2.

2:50 PM Changeset in webkit [73966] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Updated chromium test expectations.

  • platform/chromium/test_expectations.txt:
2:38 PM Changeset in webkit [73965] by weinig@apple.com
  • 54 edits
    2 deletes in trunk

Change the WebKit2 public API so there is no explicit WKPageNamespace object
https://bugs.webkit.org/show_bug.cgi?id=50898

Reviewed by Anders Carlsson.

WebKit2:

  • Shared/API/c/WKBase.h: Remove definition of WKPageNamespaceRef.
  • UIProcess/API/C/WKAPICast.h: Remove toAPI/toImpl for WKPageNamespaceRef.
  • UIProcess/API/C/WKPage.cpp:
  • UIProcess/API/C/WKPage.h:

Replace WKPageGetPageNamespace with WKPageGetContext.

  • UIProcess/API/C/WKPageNamespace.cpp: Removed.
  • UIProcess/API/C/WKPageNamespace.h: Removed.
  • UIProcess/API/C/WebKit2.h: Remove #include of WKPageNamespace.h.
  • UIProcess/API/C/win/WKView.cpp:

(WKViewCreate): Changed to take a WKContextRef instead of a WKPageNamespaceRef.
(WKViewCreateUsingSharedProcess): Added. Similar to WKViewCreate except that
all callers of it will have their views end up in the same shared process, whereas
with WKViewCreate, a new internal page namespace will be created and could place
the view's WebPage into a new process.
(WKViewCreateForAssociatedPage): Added. Creates a view that is forced to use the
same process as the passed in page.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::WebView):
(WebKit::WebView::initialize):

  • UIProcess/win/WebView.h:

(WebKit::WebView::create):
(WebKit::WebView::createUsingSharedProcess):
(WebKit::WebView::createForAssociatedPage):
Implementation of the WKView create functions.

  • UIProcess/API/C/win/WKView.h:
  • UIProcess/API/mac/WKView.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:]):
(-[WKView initWithFrame:contextRef:]):
(-[WKView initWithFrame:contextRef:pageGroupRef:]):
(-[WKView initWithFrame:contextRef:usingSharedProcess:]):
(-[WKView initWithFrame:contextRef:pageGroupRef:usingSharedProcess:]):
(-[WKView initWithFrame:forAssociatedPageRef:]):
(-[WKView initWithFrame:forAssociatedPageRef:pageGroupRef:]):
(-[WKView initWithFrame:pageNamespace:pageGroup:]):
Add new initializers for the objective-c WKView. It follows the same
pattern as WKViewRef.

  • UIProcess/API/qt/qwkcontext.cpp:

(QWKContext::QWKContext):

  • UIProcess/API/qt/qwkcontext.h:

Remove uses of WKPageNamespaceRef.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::sharedPageNamespace): Returns a shared
page namespace used by the view's createUsingSharedProcess constructions.
(WebKit::WebContext::createPageNamespace): Change to return
a PassRefPtr to make things clearer.
(WebKit::WebContext::pageNamespaceWasDestroyed): Clear the shared
namespace if it is cleared.

  • UIProcess/WebContext.h:
  • UIProcess/WebPageNamespace.h: Remove unused "struct WKContextStatistics".
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::context):

  • UIProcess/WebPageProxy.h:

Add context getter.

  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

  • UIProcess/win/WebInspectorProxyWin.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):
Use forAssociatedPageRef constructor for the WebInspector view.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:

Remove WKPageNamespace.h/cpp.

WebKitTools:

  • MiniBrowser/mac/AppDelegate.h:
  • MiniBrowser/mac/AppDelegate.m:
  • MiniBrowser/mac/BrowserWindowController.h:
  • MiniBrowser/mac/BrowserWindowController.m:
  • MiniBrowser/win/BrowserView.cpp:

Convert MiniBrowser to not use PageNamespaces.

  • TestWebKitAPI/PlatformWebView.h:
  • TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
  • TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
  • TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
  • TestWebKitAPI/Tests/WebKit2/Find.cpp:
  • TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
  • TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
  • TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
  • TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
  • TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
  • TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
  • TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
  • TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
  • TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
  • TestWebKitAPI/mac/PlatformWebViewMac.mm:
  • TestWebKitAPI/win/PlatformWebViewWin.cpp:

Convert TestWebKitAPI to not use PageNamespaces.

  • WebKitTestRunner/PlatformWebView.h:
  • WebKitTestRunner/TestController.cpp:
  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/mac/PlatformWebViewMac.mm:
  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  • WebKitTestRunner/win/PlatformWebViewWin.cpp:

Convert WebKitTestRunner to not use PageNamespaces.

2:34 PM Changeset in webkit [73964] by Simon Fraser
  • 2 edits in trunk/WebCore

2010-12-13 Simon Fraser <Simon Fraser>

GraphicsContextPrivate.h was removed. Nuke it from the project.

  • WebCore.xcodeproj/project.pbxproj:
2:32 PM DetectingWebKit edited by arthur5005@gmail.com
http://developer.apple.com/internet/safari/uamatrix.html no longer … (diff)
2:29 PM Changeset in webkit [73963] by bfulgham@webkit.org
  • 2 edits in trunk/WebKit2

Unreviewed build fix.

  • UIProcess/win/WebInspectorProxyWin.cpp: Non-Apple builds

need to include <wtf/RetainPtr.h>.

2:19 PM Changeset in webkit [73962] by msaboff@apple.com
  • 5 edits in trunk

2010-12-13 Michael Saboff <msaboff@apple.com>

Reviewed by Oliver Hunt.

REGRESSION: mobileme mail viewing is broken
https://bugs.webkit.org/show_bug.cgi?id=50884

Fixed problem where simple parenthesis (those without capture and
with a fixed count) where not propagating backtrack to labels for
nested parentheses. Also added the nesting level for the parentheses
state created in that case as well.

  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::BacktrackDestination::copyBacktrackToLabel): (JSC::Yarr::RegexGenerator::TermGenerationState::isLastTerm): (JSC::Yarr::RegexGenerator::ParenthesesTail::generateCode): (JSC::Yarr::RegexGenerator::generateParenthesesSingle):

2010-12-13 Michael Saboff <msaboff@apple.com>

Reviewed by Oliver Hunt.

REGRESSION: mobileme mail viewing is broken
https://bugs.webkit.org/show_bug.cgi?id=50884

Added a test to check parentheses nesting within parentheses that
don't capture and that are fixed count. There is special handling
for this case in the RegExp JIT code.

  • fast/regex/parentheses-expected.txt:
  • fast/regex/script-tests/parentheses.js:
2:15 PM Changeset in webkit [73961] by Chris Fleizach
  • 3 edits in trunk/LayoutTests

2010-12-13 Chris Fleizach <Chris Fleizach>

Reviewed by Beth Dakin.

Fix legend.htm accessibility test so it doesn't dump all attributes
https://bugs.webkit.org/show_bug.cgi?id=50957

  • accessibility/legend.html:
  • platform/mac/accessibility/legend-expected.txt:
2:08 PM Changeset in webkit [73960] by commit-queue@webkit.org
  • 10 edits
    1 copy in trunk/LayoutTests

2010-12-13 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r73922.
http://trac.webkit.org/changeset/73922
https://bugs.webkit.org/show_bug.cgi?id=50964

Remove rebaseline results due to that 73914 has been rolled
out (Requested by jianli on #webkit).

  • platform/chromium-linux/http/tests/security/xss-DENIED-frame-name-expected.txt: Copied from LayoutTests/platform/chromium-win/http/tests/security/xss-DENIED-frame-name-expected.txt.
  • platform/chromium-mac/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
  • platform/chromium-mac/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
  • platform/chromium-mac/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
  • platform/chromium-mac/http/tests/security/xss-DENIED-frame-name-expected.txt:
  • platform/chromium-win/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
  • platform/chromium-win/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
  • platform/chromium-win/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
  • platform/chromium-win/http/tests/security/xss-DENIED-frame-name-expected.txt:
  • platform/chromium/test_expectations.txt:
2:03 PM Changeset in webkit [73959] by jhoneycutt@apple.com
  • 1 edit
    2 deletes in trunk/LayoutTests

Remove some empty files that should've been removed as part of r73942.

Reviewed by Ojan Vafai.

  • editing/selection/extend-to-line-boundary-expected.txt: Removed.
  • editing/selection/extend-to-line-boundary.html: Removed.
2:00 PM Changeset in webkit [73958] by bfulgham@webkit.org
  • 2 edits
    2 adds in trunk/WebKit2

Unreviewed build fix after r73807.

Added stub implementation of Download object.

  • WebProcess/Downloads/curl: Added.
  • WebProcess/Downloads/curl/DownloadCurl.cpp: Added.

(WebKit::Download::start):
(WebKit::Download::startWithHandle):
(WebKit::Download::cancel):
(WebKit::Download::platformInvalidate):

  • win/WebKit2.vcproj: Exclude DownloadCFNet for Cairo builds,

added DownloadCurl (excluded for regular Apple builds.)

1:57 PM Changeset in webkit [73957] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2010-12-13 Eric Carlson <eric.carlson@apple.com>

Reviewed by Antti Koivisto.

HTMLMediaElement::endedPlayback should not return true if duration is zero
https://bugs.webkit.org/show_bug.cgi?id=50962

(WebCore::HTMLMediaElement::endedPlayback): Don't return true when duration is zero because a
media file can't play if it has no duration, therefore it can't have ended playback.

1:53 PM Changeset in webkit [73956] by andersca@apple.com
  • 9 edits in trunk/WebKit2

Add the ability for plug-ins to toggle complex text input
https://bugs.webkit.org/show_bug.cgi?id=50966

Reviewed by Sam Weinig.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::PluginControllerProxy):
Initialize m_isComplexTextInputEnabled.

(WebKit::PluginControllerProxy::setComplexTextInputEnabled):
Update m_isComplexTextInputEnabled.

  • PluginProcess/PluginControllerProxy.h:
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NetscapePlugin):
Initialize m_pluginHasFocus and m_windowHasFocus.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

(WebKit::NetscapePlugin::isWindowActive):
Return m_windowHasFocus.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::platformSetFocus):
Update m_pluginHasFocus and call setComplexTextInputEnabled.

(WebKit::NetscapePlugin::windowFocusChanged):
Update m_windowHasFocus and call setComplexTextInputEnabled.

  • WebProcess/Plugins/PluginController.h:

Add setComplexTextInputEnabled.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::setComplexTextInputEnabled):

  • WebProcess/Plugins/PluginView.h:

Add setComplexTextInputEnabled

1:25 PM Changeset in webkit [73955] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

Unreviewed build fix after r73840.

  • WebCore.vcproj/WebCoreGeneratedCairo.vsprops: Update property file

to pass three arguments to build-generated-files.sh, just like
the official Apple port.

1:21 PM Changeset in webkit [73954] by Antti Koivisto
  • 2 edits in trunk/LayoutTests

Unreviewed.

Adding

http/tests/local/link-stylesheet-load-order.html
http/tests/local/link-stylesheet-load-order-preload.html

to the Gtk skip list.

  • platform/gtk/Skipped:
1:11 PM Changeset in webkit [73953] by mthole@apple.com
  • 3 edits in trunk/WebKit/mac

https://bugs.webkit.org/show_bug.cgi?id=50956
WebAuthenticationPanel.nib appears to have a cut-off sentence

Rubber-stamped by John Sullivan.

Replace the sentence fragment in the sheet layout with "<-- do not localize -->" style text.
The contents of this text field are updated dynamically before the sheet is displayed.

  • Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
  • Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:
12:54 PM Changeset in webkit [73952] by hyatt@apple.com
  • 4 edits in trunk

WebCore: Make sure the defaultSpaceEventHandler does logical scrolling.

Reviewed by Adam Roben.

  • page/EventHandler.cpp:

(WebCore::EventHandler::defaultSpaceEventHandler):

WebKit2: Remove the space behavior that I added. It's covered in EventHandler in WebCore
already for Windows.

Reviewed by Adam Roben.

  • WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::WebPage::performDefaultBehaviorForKeyEvent):

12:41 PM Changeset in webkit [73951] by commit-queue@webkit.org
  • 10 edits in trunk/WebKitTools

2010-12-13 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu>

Reviewed by Eric Seidel.

webkit-patch rollout should be able to do multi-revision rollouts
https://bugs.webkit.org/show_bug.cgi?id=33336

Make it possible to pass more than one revision to webkit-patch.

  • Scripts/webkitpy/common/checkout/api.py:
  • Scripts/webkitpy/common/checkout/changelog.py:
  • Scripts/webkitpy/common/checkout/changelog_unittest.py:
  • Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
  • Scripts/webkitpy/tool/steps/revertrevision.py:
12:36 PM Changeset in webkit [73950] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-12-13 Eric Seidel <eric@webkit.org>

Unreviewed.

Teach webkit-patch how to search bugzilla
https://bugs.webkit.org/show_bug.cgi?id=50500

webkit-patch bug-search fails when there is only one result.
Turns out we needed a bit more logic in our result count parsing code.

  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  • Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
12:35 PM Changeset in webkit [73949] by mdelaney@apple.com
  • 11 edits in trunk/WebCore

2010-12-13 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=50591 Adopt new CG API for canvas

No new tests necessary.

  • Configurations/WebCore.xcconfig: Added IOSurface framework link.
  • html/canvas/CanvasRenderingContext2D.cpp: Used IOSurface def. instead.
  • platform/graphics/ImageBuffer.h: Pushed renderingMode down into ctor.
  • platform/graphics/cairo/ImageBufferCairo.cpp:
  • platform/graphics/cg/ImageBufferCG.cpp:
  • platform/graphics/haiku/ImageBufferHaiku.cpp:
  • platform/graphics/qt/ImageBufferQt.cpp:
  • platform/graphics/skia/ImageBufferSkia.cpp:
  • platform/graphics/wince/ImageBufferWinCE.cpp:
  • platform/graphics/wx/ImageBufferWx.cpp:
12:30 PM Changeset in webkit [73948] by timothy@apple.com
  • 1 copy in releases/Apple/Safari 3.0/WebKit

WebKit release tag for Safari 3.0.

12:30 PM Changeset in webkit [73947] by Antti Koivisto
  • 3 edits in trunk/LayoutTests

Unreviewed.

Adding

http/tests/local/link-stylesheet-load-order.html
http/tests/local/link-stylesheet-load-order-preload.html

to Mac WebKit2 and Qt skip lists.

  • platform/mac-wk2/Skipped:
  • platform/qt/Skipped:
12:30 PM Changeset in webkit [73946] by timothy@apple.com
  • 1 copy in releases/Apple/Safari 3.0/WebCore

WebCore release tag for Safari 3.0.

12:30 PM Changeset in webkit [73945] by timothy@apple.com
  • 1 copy in releases/Apple/Safari 3.0/JavaScriptGlue

JavaScriptGlue release tag for Safari 3.0.

12:29 PM Changeset in webkit [73944] by timothy@apple.com
  • 1 copy in releases/Apple/Safari 3.0/JavaScriptCore

JavaScriptCore release tag for Safari 3.0.

12:29 PM Changeset in webkit [73943] by timothy@apple.com
  • 1 add in releases/Apple/Safari 3.0

Safari 3.0 release tag.

12:20 PM Changeset in webkit [73942] by jianli@chromium.org
  • 5 edits in trunk

Unreviewed, rolling out r73923.
http://trac.webkit.org/changeset/73923
https://bugs.webkit.org/show_bug.cgi?id=50944

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2010-12-13
Broke editing/selection/extend-selection-home-end.html on non-
mac platforms. Looks like a real bug. (Requested by ojan on

WebCore:

  • editing/SelectionController.cpp:

(WebCore::SelectionController::positionForPlatform):
(WebCore::SelectionController::modifyExtendingForward):

LayoutTests:

  • editing/selection/extend-to-line-boundary-expected.txt: Removed.
  • editing/selection/extend-to-line-boundary.html: Removed.
12:14 PM Changeset in webkit [73941] by hyatt@apple.com
  • 20 edits in trunk

WebCore: https://bugs.webkit.org/show_bug.cgi?id=48545, Home/End, PageUp/PageDwn should respect writing-mode.

Reviewed by Sam Weinig.

Add logical scrolling to WebCore. It basically mirrors physical scrolling but works in abstract logical
directions and only converts to physical when it's time to attempt the scroll.

Also fixed bugs in scrollRecursively and logicalScrollRecursively where overflow sections in containing
frames got skipped over.

Made the resetting of the inline axis scroll position on Home/End Mac-specific for overflow sections.

  • WebCore.exp.in:
  • page/EventHandler.cpp:

(WebCore::EventHandler::logicalScrollOverflow):
(WebCore::EventHandler::scrollRecursively):
(WebCore::EventHandler::logicalScrollRecursively):

  • page/EventHandler.h:
  • page/FrameView.cpp:

(WebCore::FrameView::isVerticalDocument):
(WebCore::FrameView::isFlippedDocument):

  • page/FrameView.h:
  • platform/ScrollTypes.h:

(WebCore::logicalToPhysical):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::scroll):
(WebCore::ScrollView::logicalScroll):

  • platform/ScrollView.h:

(WebCore::ScrollView::isVerticalDocument):
(WebCore::ScrollView::isFlippedDocument):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::logicalScroll):

  • rendering/RenderBox.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scroll):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::logicalScroll):

  • rendering/RenderListBox.h:
  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::logicalScroll):

  • rendering/RenderTextControlSingleLine.h:

WebKit2: https://bugs.webkit.org/show_bug.cgi?id=48545, Home/End, PageUp/PageDwn should respect writing-mode. Use
logical scrolling instead of physical scrolling for those keys in WebKit2.

Reviewed by Sam Weinig.

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::logicalScroll):
(WebKit::WebPage::performDefaultBehaviorForKeyEvent):

  • WebProcess/WebPage/qt/WebPageQt.cpp:

(WebKit::logicalScroll):
(WebKit::WebPage::performDefaultBehaviorForKeyEvent):

  • WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::logicalScroll):
(WebKit::WebPage::performDefaultBehaviorForKeyEvent):

11:56 AM Changeset in webkit [73940] by commit-queue@webkit.org
  • 6 edits in trunk/WebKit/chromium

2010-12-13 David Holloway <dhollowa@chromium.org>

Reviewed by Eric Seidel.

[chromium] Removes deprecated logic following the consolidation of AutoFill and
Autocomplete popup menu handling (https://bugs.webkit.org/show_bug.cgi?id=41236).
Filling of the form fields is now handled completely on the Chromium side, for
both AutoFill and Autocomplete.

https://bugs.webkit.org/show_bug.cgi?id=41822

  • public/WebView.h:
  • src/AutoFillPopupMenuClient.cpp: (WebKit::AutoFillPopupMenuClient::AutoFillPopupMenuClient): (WebKit::AutoFillPopupMenuClient::valueChanged):
  • src/AutoFillPopupMenuClient.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::applyAutoFillSuggestions):
  • src/WebViewImpl.h:
11:54 AM Changeset in webkit [73939] by yurys@chromium.org
  • 39 edits
    2 moves
    46 deletes in trunk

2010-12-13 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Rollout 73914, 73915, 73917, 73920 and 73921.

REGRESSION(r73914): "Chromium page_cycler_morejs fails" (Requested by yurys on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=50950

  • fast/events/resources/window-onerror.js: Removed.
  • fast/events/window-onerror1-expected.txt: Removed.
  • fast/events/window-onerror1.html: Removed.
  • fast/events/window-onerror10-expected.txt: Removed.
  • fast/events/window-onerror10.html: Removed.
  • fast/events/window-onerror11-expected.txt: Removed.
  • fast/events/window-onerror11.html: Removed.
  • fast/events/window-onerror2-expected.txt: Removed.
  • fast/events/window-onerror2.html: Removed.
  • fast/events/window-onerror3-expected.txt: Removed.
  • fast/events/window-onerror3.html: Removed.
  • fast/events/window-onerror4-expected.txt: Removed.
  • fast/events/window-onerror4.html: Removed.
  • fast/events/window-onerror5-expected.txt: Removed.
  • fast/events/window-onerror5.html: Removed.
  • fast/events/window-onerror6-expected.txt: Removed.
  • fast/events/window-onerror6.html: Removed.
  • fast/events/window-onerror7-expected.txt: Removed.
  • fast/events/window-onerror7.html: Removed.
  • fast/events/window-onerror8-expected.txt: Removed.
  • fast/events/window-onerror8.html: Removed.
  • fast/events/window-onerror9-expected.txt: Removed.
  • fast/events/window-onerror9.html: Removed.
  • fast/workers/worker-script-error-expected.txt:
  • http/tests/security/resources/onerror-iframe.html: Removed.
  • http/tests/security/window-onerror-exception-in-iframe-expected.txt: Removed.
  • http/tests/security/window-onerror-exception-in-iframe.html: Removed.
  • platform/chromium-win/fast/workers/worker-script-error-expected.txt:
  • platform/chromium/fast/events/window-onerror1-expected.txt: Removed.
  • platform/chromium/fast/events/window-onerror10-expected.txt: Removed.
  • platform/chromium/fast/events/window-onerror11-expected.txt: Removed.
  • platform/chromium/fast/events/window-onerror2-expected.txt: Removed.
  • platform/chromium/fast/events/window-onerror3-expected.txt: Removed.
  • platform/chromium/fast/events/window-onerror4-expected.txt: Removed.
  • platform/chromium/fast/events/window-onerror5-expected.txt: Removed.
  • platform/chromium/fast/events/window-onerror6-expected.txt: Removed.
  • platform/chromium/fast/events/window-onerror7-expected.txt: Removed.
  • platform/chromium/fast/events/window-onerror8-expected.txt: Removed.
  • platform/chromium/fast/events/window-onerror9-expected.txt: Removed.
  • platform/chromium/http/tests/security/window-onerror-exception-in-iframe-expected.txt: Removed.
  • platform/chromium/userscripts/window-onerror-for-isolated-world-1-expected.txt: Removed.
  • platform/chromium/userscripts/window-onerror-for-isolated-world-2-expected.txt: Removed.
  • platform/gtk/Skipped:
  • userscripts/window-onerror-for-isolated-world-1-expected.txt: Removed.
  • userscripts/window-onerror-for-isolated-world-1.html: Removed.
  • userscripts/window-onerror-for-isolated-world-2-expected.txt: Removed.
  • userscripts/window-onerror-for-isolated-world-2.html: Removed.

2010-12-13 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Rollout 73914, 73915, 73917, 73920 and 73921.

REGRESSION(r73914): "Chromium page_cycler_morejs fails" (Requested by yurys on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=50950

  • Android.jscbindings.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.order:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSDOMBinding.cpp: (WebCore::reportException):
  • bindings/js/JSWorkerContextErrorHandler.cpp: Renamed from WebCore/bindings/js/JSErrorHandler.cpp. (WebCore::JSWorkerContextErrorHandler::JSWorkerContextErrorHandler): (WebCore::JSWorkerContextErrorHandler::~JSWorkerContextErrorHandler): (WebCore::JSWorkerContextErrorHandler::handleEvent):
  • bindings/js/JSWorkerContextErrorHandler.h: Renamed from WebCore/bindings/js/JSErrorHandler.h. (WebCore::JSWorkerContextErrorHandler::create): (WebCore::createJSWorkerContextErrorHandler):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8ConsoleMessage.cpp: (WebCore::V8ConsoleMessage::dispatchNow): (WebCore::V8ConsoleMessage::handler):
  • bindings/v8/V8ConsoleMessage.h:
  • bindings/v8/V8WindowErrorHandler.cpp: Removed.
  • bindings/v8/V8WindowErrorHandler.h: Removed.
  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::v8MessageHandler):
  • bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate):
  • dom/Document.cpp: (WebCore::Document::reportException): (WebCore::Document::addMessage):
  • dom/Document.h:
  • dom/ErrorEvent.cpp:
  • dom/ErrorEvent.h:
  • dom/Event.cpp:
  • dom/Event.h:
  • dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::ScriptExecutionContext):
  • dom/ScriptExecutionContext.h:
  • websockets/WebSocket.cpp: (WebCore::WebSocket::connect):
  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::didOpen): (WebCore::WebSocketChannel::appendToBuffer):
  • websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::readServerHandshake): (WebCore::WebSocketHandshake::readStatusLine): (WebCore::WebSocketHandshake::readHTTPHeaders): (WebCore::WebSocketHandshake::checkResponseHeaders):
  • workers/DefaultSharedWorkerRepository.cpp: (WebCore::postExceptionTask): (WebCore::postConsoleMessageTask):
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::WorkerContext): (WebCore::WorkerContext::reportException): (WebCore::WorkerContext::addMessage):
  • workers/WorkerContext.h:
  • workers/WorkerMessagingProxy.cpp: (WebCore::WorkerExceptionTask::performTask): (WebCore::postConsoleMessageTask):
  • xml/XMLHttpRequest.cpp: (WebCore::reportUnsafeUsage):

2010-12-13 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Rollout 73914, 73915, 73917, 73920 and 73921.

REGRESSION(r73914): "Chromium page_cycler_morejs fails" (Requested by yurys on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=50950

  • src/WebWorkerClientImpl.cpp: (WebKit::WebWorkerClientImpl::postExceptionToWorkerObject): (WebKit::WebWorkerClientImpl::postConsoleMessageToWorkerObject): (WebKit::WebWorkerClientImpl::postExceptionToWorkerObjectTask): (WebKit::WebWorkerClientImpl::postConsoleMessageToWorkerObjectTask):
11:49 AM Changeset in webkit [73938] by Antti Koivisto
  • 31 edits
    5 adds in trunk

WebCore: https://bugs.webkit.org/show_bug.cgi?id=50758
<rdar://problem/8722094>
Defer loading print stylesheets

Reviewed by Alexey Proskuryakov.

  • Make preload scanner skip stylesheets with non-screen media types.
  • Make it possible to specify non-default load priority from the client.
  • Use this mechanism to load print stylesheets using very low priority so they get loaded after everything else.
  • Move default priority code from Loader to CachedResource.
  • Move ResourceLoadScheduler::Priority enum to a separate file (as ResourceLoadPriority).
  • Add a way to make ResourceLoadScheduler load resources one at the time so the above functionality can be tested reliably.

Tests: http/tests/local/link-stylesheet-load-order-preload.html

http/tests/local/link-stylesheet-load-order.html

  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSImageValue.cpp:

(WebCore::CSSImageValue::cachedImage):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::process):

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::HTMLNames::PreloadTask::PreloadTask):
(WebCore::HTMLNames::PreloadTask::processAttributes):
(WebCore::HTMLNames::PreloadTask::relAttributeIsStyleSheet):
(WebCore::HTMLNames::PreloadTask::linkMediaAttributeIsScreen):
(WebCore::HTMLNames::PreloadTask::preload):

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::loadRequest):

  • loader/ResourceLoadPriority.h: Added.
  • loader/ResourceLoadScheduler.cpp:

(WebCore::ResourceLoadScheduler::ResourceLoadScheduler):
(WebCore::ResourceLoadScheduler::scheduleSubresourceLoad):
(WebCore::ResourceLoadScheduler::schedulePluginStreamLoad):
(WebCore::ResourceLoadScheduler::scheduleLoad):
(WebCore::ResourceLoadScheduler::servePendingRequests):
(WebCore::ResourceLoadScheduler::HostInformation::~HostInformation):
(WebCore::ResourceLoadScheduler::HostInformation::schedule):
(WebCore::ResourceLoadScheduler::HostInformation::remove):
(WebCore::ResourceLoadScheduler::HostInformation::hasRequests):
(WebCore::ResourceLoadScheduler::HostInformation::limitRequests):

  • loader/ResourceLoadScheduler.h:

(WebCore::ResourceLoadScheduler::isSerialLoadingEnabled):
(WebCore::ResourceLoadScheduler::setSerialLoadingEnabled):
(WebCore::ResourceLoadScheduler::HostInformation::requestsPending):

  • loader/cache/CachedResource.cpp:

(WebCore::defaultPriorityForResourceType):
(WebCore::CachedResource::CachedResource):

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::loadPriority):
(WebCore::CachedResource::setLoadPriority):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestCSSStyleSheet):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::requestPreload):

  • loader/cache/CachedResourceLoader.h:
  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::requestResource):

  • loader/cache/MemoryCache.h:
  • loader/loader.cpp:

(WebCore::Loader::load):

WebKit/mac: https://bugs.webkit.org/show_bug.cgi?id=50758
<rdar://problem/8722094>
Defer loading print stylesheets

Reviewed by Alexey Proskuryakov.

Expose SPI for DRT for making resources load serially. This is useful for testing resource load order.

  • WebView/WebView.mm:

(+[WebView _setLoadResourcesSerially:forHost:]):

  • WebView/WebViewPrivate.h:

WebKitTools: Add setSerializeHTTPLoads function to allow testing resource load order on OS X.
https://bugs.webkit.org/show_bug.cgi?id=50758

Reviewed by Alexey Proskuryakov.

  • DumpRenderTree/LayoutTestController.cpp:

(setSerializeHTTPLoadsCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::setSerializeHTTPLoads):

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::setSerializeHTTPLoads):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::setSerializeHTTPLoads):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=50758
<rdar://problem/8722094>
Defer loading print stylesheets

Reviewed by Alexey Proskuryakov.

Test load ordering.

  • http/tests/local/link-stylesheet-load-order-expected.txt: Added.
  • http/tests/local/link-stylesheet-load-order-preload-expected.txt: Added.
  • http/tests/local/link-stylesheet-load-order-preload.html: Added.
  • http/tests/local/link-stylesheet-load-order.html: Added.
11:34 AM Changeset in webkit [73937] by jschuh@chromium.org
  • 2 edits in trunk/WebCore

2010-12-13 Justin Schuh <jschuh@chromium.org>

Reviewed by Dimitri Glazkov.

Build fix for r73927
https://bugs.webkit.org/show_bug.cgi?id=50946

Reverting CSSCanvasValue::canvasDestroyed to its code before r73927
because it's breaking the build and I changed it only because it
appeared redunudant after r73927.

No behavior changed so no new tests needed.

  • css/CSSCanvasValue.cpp: (WebCore::CSSCanvasValue::canvasDestroyed):
11:29 AM Changeset in webkit [73936] by xan@webkit.org
  • 4 edits in trunk/WebKit/gtk

2010-12-13 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Add API to enable/disable plugins at runtime
https://bugs.webkit.org/show_bug.cgi?id=50891

  • tests/testwebplugindatabase.c: (test_webkit_web_plugin_database_get_plugins): test that disabling a plugin works.
  • webkit/webkitwebplugin.cpp: (webkit_web_plugin_get_property): hook 'enabled' property. (webkit_web_plugin_set_property): ditto. (webkit_web_plugin_class_init): define 'enabled' property. (webkit_web_plugin_set_enabled): setter for the property. (webkit_web_plugin_get_enabled): getter for the property.
  • webkit/webkitwebplugin.h: add the APIs to the header.
11:27 AM Changeset in webkit [73935] by bweinstein@apple.com
  • 3 edits in trunk/WebKit2

WebKit2: Focusing Web Inspector window doesn't focus contents on Windows
https://bugs.webkit.org/show_bug.cgi?id=50947
<rdar://problem/8762468>

Reviewed by Darin Adler.

When we get the notification that the inspector window has focused, focus the inner inspector view.

  • UIProcess/WebInspectorProxy.h:
  • UIProcess/win/WebInspectorProxyWin.cpp:

(WebKit::WebInspectorProxy::onSetFocusEvent): Set the focus of the inspector view, because that is what

needs to be focused in the inspector window.

11:11 AM Changeset in webkit [73934] by rniwa@webkit.org
  • 3 edits
    8 copies in branches/chromium/597

Merge 73279 - 2010-12-03 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

REGRESSION: Crash when deleting text after textarea's value is modified on input event
https://bugs.webkit.org/show_bug.cgi?id=49962

The crash was caused by TypingCommand::deleteKeyPressed's reusing a typing command for
textarea's shadow DOM after its input event handler rewrote the value set by the typing command.
Because the reused typing command's ending selection was pointing at a shadow node
that has been detached from the document when the event handler set the new value,
rootEditableElement of the ending selection was null and caused the crash.

Fixed the bug by updating the ending selection of the last typing command when it differsfrom
that of the current selection held by the SelectionController in TypingCommand::deleteKeyPressed.
Also fixed similar bugs in forwardDeleteKeyPressed and insertText, and insertTextRunWithoutNewlines.

Tests: editing/input/set-value-on-input-and-delete.html

editing/input/set-value-on-input-and-forward-delete.html
editing/input/set-value-on-input-and-type-input.html
editing/input/set-value-on-input-and-type-textarea.html

  • editing/InsertTextCommand.h: Added TypingCommand as a friend because it needs to update selection.
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): Updates the last typing command's selection as needed. (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto. (WebCore::TypingCommand::insertText): Ditto. (WebCore::TypingCommand::updateSelectionIfDifferentFromCurrentSelection): Added. (WebCore::TypingCommand::insertTextRunWithoutNewlines): Updates InsertTextCommand's selection as needed.
  • editing/TypingCommand.h:

2010-12-03 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

REGRESSION: Crash when deleting text after textarea's value is modified on input event
https://bugs.webkit.org/show_bug.cgi?id=49962

Added tests to ensure inserting and deleting a character inside input or textarea
succeeds even if the value of those elements have been rewritten by its input event handler.

  • editing/input/set-value-on-input-and-delete-expected.txt: Added.
  • editing/input/set-value-on-input-and-delete.html: Added.
  • editing/input/set-value-on-input-and-forward-delete-expected.txt: Added.
  • editing/input/set-value-on-input-and-forward-delete.html: Added.
  • editing/input/set-value-on-input-and-type-input-expected.txt: Added.
  • editing/input/set-value-on-input-and-type-input.html: Added.
  • editing/input/set-value-on-input-and-type-textarea-expected.txt: Added.
  • editing/input/set-value-on-input-and-type-textarea.html: Added.

BUG=62608
TBR=rniwa@webkit.org
Review URL: http://codereview.chromium.org/5812003

11:00 AM Changeset in webkit [73933] by mdelaney@apple.com
  • 2 edits in trunk/WebCore

2010-12-13 Matthew Delaney <mdelaney@apple.com>

Reviewed by nobody, build fix.

Unlinking IOSurface framework from xcodeproj.

  • WebCore.xcodeproj/project.pbxproj:
10:41 AM Changeset in webkit [73932] by mitz@apple.com
  • 2 edits in trunk/WebKit2

Coding style fix.

  • WebProcess/Downloads/mac/DownloadMac.mm:

(WebKit::originatingURLFromBackForwardList):

10:38 AM Changeset in webkit [73931] by timothy@apple.com
  • 1 copy in releases/Apple/Safari 3.0.4

Safari 3.0.4 release tag.

10:35 AM Changeset in webkit [73930] by kbalazs@webkit.org
  • 2 edits in trunk/WebKit2

Unreviewed trivial build fix (linux, 64 bit, gcc-4.5.1)

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::exceededDatabaseQuota):
Don't use unsigned long long as alias for uint64_t.

10:27 AM Changeset in webkit [73929] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Crash when clicking a download link that targets a new tab
https://bugs.webkit.org/show_bug.cgi?id=50935
<rdar://problem/8760572>

Reviewed by John Sullivan.

Check for a null history item.

  • WebProcess/Downloads/mac/DownloadMac.mm:

(WebKit::originatingURLFromBackForwardList):

10:22 AM Changeset in webkit [73928] by Dimitri Glazkov
  • 2 edits in trunk/WebKitTools

2010-12-13 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Ojan Vafai.

Remove "use-drt" option from test step command line, since the option was removed in r73748.
https://bugs.webkit.org/show_bug.cgi?id=50936

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed the option.
10:21 AM Changeset in webkit [73927] by jschuh@chromium.org
  • 5 edits
    2 adds in trunk

2010-12-13 Justin Schuh <jschuh@chromium.org>

Reviewed by Dimitri Glazkov.

HTMLCanvasElement should handle multiple observers.
https://bugs.webkit.org/show_bug.cgi?id=50899

Test: fast/canvas/canvas-bg-multiple-removal.html

  • css/CSSCanvasValue.cpp: (WebCore::CSSCanvasValue::~CSSCanvasValue): (WebCore::CSSCanvasValue::canvasDestroyed): (WebCore::CSSCanvasValue::element):
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::HTMLCanvasElement): (WebCore::HTMLCanvasElement::~HTMLCanvasElement): (WebCore::HTMLCanvasElement::addObserver): (WebCore::HTMLCanvasElement::removeObserver): (WebCore::HTMLCanvasElement::didDraw): (WebCore::HTMLCanvasElement::reset):
  • html/HTMLCanvasElement.h:

2010-12-13 Justin Schuh <jschuh@chromium.org>

Reviewed by Dimitri Glazkov.

HTMLCanvasElement should handle multiple observers.
https://bugs.webkit.org/show_bug.cgi?id=50899

  • fast/canvas/canvas-bg-multiple-removal-expected.txt: Added.
  • fast/canvas/canvas-bg-multiple-removal.html: Added.
10:15 AM Changeset in webkit [73926] by mihaip@chromium.org
  • 3 edits
    2 adds in trunk

2010-12-13 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

[Chromium] canvas/philip/tests/2d.missingargs.html hangs on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=50841

Add test that calls strokeText() (i.e. with no arguments).

  • fast/canvas/strokeText-missing-args-expected.txt: Added.
  • fast/canvas/strokeText-missing-args.html: Added.

2010-12-13 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

[Chromium] canvas/philip/tests/2d.missingargs.html hangs on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=50841

Test: fast/canvas/strokeText-missing-args.html

We didn't have isfinite checks for the x and y coordinates that are
passed to strokeText/drawTextInternal (unlike all the other methods,
which got checks in r50910 and r59447).

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawTextInternal):
10:13 AM Changeset in webkit [73925] by mdelaney@apple.com
  • 20 edits in trunk

2010-12-09 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Adopt new CG API for canvas
https://bugs.webkit.org/show_bug.cgi?id=50591

  • WebCoreSupport/WebSystemInterface.mm:

2010-12-09 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Adopt new CG API for canvas
https://bugs.webkit.org/show_bug.cgi?id=50591

No new tests. All current layout tests are sufficient.

  • html/HTMLCanvasElement.cpp: Add in accelerateRendering flag for imagebuffer creation.
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::isAccelerated): Always return true if using CA on new platforms. (WebCore::CanvasRenderingContext2D::drawTextInternal): Use accelerateRendering for imagebuffer.
  • platform/graphics/ImageBuffer.h: (WebCore::ImageBuffer::create): Plumb through new flag.
  • platform/graphics/cairo/ImageBufferCairo.cpp: Update method sig.
  • platform/graphics/cg/ImageBufferCG.cpp: Switch off of accelerateRendering flag for new accelerated paths.
  • platform/graphics/cg/ImageBufferData.h: Add in surface ref
  • platform/graphics/haiku/ImageBufferHaiku.cpp: Update method sig.
  • platform/graphics/qt/ImageBufferQt.cpp:
  • platform/graphics/skia/ImageBufferSkia.cpp:
  • platform/graphics/wince/ImageBufferWinCE.cpp:
  • platform/graphics/wx/ImageBufferWx.cpp:
  • platform/mac/WebCoreSystemInterface.h: Add new method sigs
  • platform/mac/WebCoreSystemInterface.mm:
  • rendering/RenderLayerBacking.cpp:
  • rendering/RenderLayerCompositor.cpp: Set acceleratesDrawing for canvas backings.
9:56 AM Changeset in webkit [73924] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/efl

2010-12-13 Alex Bredariol Grilo <abgrilo@profusion.mobi>

Reviewed by Andreas Kling.

Remove one row/column of renderers.
https://bugs.webkit.org/show_bug.cgi?id=50456

This changes the algorithm in a way that it will require one less column
and row of renderers to fill the viewport. The direct result of this is
that now less tiles need to be rendered at once when displaying the
viewport.

  • ewk/ewk_tiled_backing_store.c: (_ewk_tiled_backing_store_smart_add): (_ewk_tiled_backing_store_recalc_renderers): (_ewk_tiled_backing_store_view_wrap_up): (_ewk_tiled_backing_store_view_wrap_down): (_ewk_tiled_backing_store_view_wrap_left): (_ewk_tiled_backing_store_view_wrap_right): (_ewk_tiled_backing_store_smart_calculate_offset_force): (_ewk_tiled_backing_store_smart_calculate_offset): (_ewk_tiled_backing_store_smart_calculate): (_ewk_tiled_backing_store_zoom_set_internal): (ewk_tiled_backing_store_zoom_weak_set): (ewk_tiled_backing_store_fix_offsets): (ewk_tiled_backing_store_flush):
9:27 AM Changeset in webkit [73923] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2010-12-13 Benjamin Kalman <kalman@chromium.org>

Reviewed by Ojan Vafai.

Shift-End does not select to the end of the line
https://bugs.webkit.org/show_bug.cgi?id=50610

  • editing/selection/extend-to-line-boundary-expected.txt: Added.
  • editing/selection/extend-to-line-boundary.html: Added.

2010-12-13 Benjamin Kalman <kalman@chromium.org>

Reviewed by Ojan Vafai.

Shift-End does not select to the end of the line
https://bugs.webkit.org/show_bug.cgi?id=50610

Test: editing/selection/extend-to-line-boundary.html

  • editing/SelectionController.cpp: (WebCore::SelectionController::positionForPlatform): Use visibleStart/visibleEnd rather than start/end. (WebCore::SelectionController::modifyExtendingForward):
9:05 AM Changeset in webkit [73922] by pfeldman@chromium.org
  • 10 edits
    1 delete in trunk/LayoutTests

2010-12-13 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: rebaseline chromium xss tests for window.onerror.

  • platform/chromium-linux/http/tests/security/xss-DENIED-frame-name-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
  • platform/chromium-mac/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
  • platform/chromium-mac/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
  • platform/chromium-mac/http/tests/security/xss-DENIED-frame-name-expected.txt:
  • platform/chromium-win/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
  • platform/chromium-win/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
  • platform/chromium-win/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
  • platform/chromium-win/http/tests/security/xss-DENIED-frame-name-expected.txt:
  • platform/chromium/test_expectations.txt:
8:39 AM Changeset in webkit [73921] by Adam Roben
  • 2 edits in trunk/WebCore

Windows build fix after r73914

  • WebCore.vcproj/WebCore.vcproj: Fix malformed XML.
8:04 AM Changeset in webkit [73920] by yurys@chromium.org
  • 3 edits in trunk/WebCore

2010-12-13 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Qt build fix.

  • dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::ScriptExecutionContext):
  • dom/ScriptExecutionContext.h:
7:54 AM Changeset in webkit [73919] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2010-12-13 John Knottenbelt <jknotten@chromium.org>

Reviewed by Steve Block.

Fix layout test dom/fast/Geolocation/permission-denied-already-error.html for client-based Geolocation
https://bugs.webkit.org/show_bug.cgi?id=50920

  • fast/dom/Geolocation/script-tests/permission-denied-already-error.js:
7:53 AM Changeset in webkit [73918] by mario@webkit.org
  • 3 edits
    2 adds in trunk

2010-12-13 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Additional support is needed for caret browsing
https://bugs.webkit.org/show_bug.cgi?id=25526

New layout test to check the "MoveTo{Beginninng|End}OfDocument"
commands when caret browsing is enabled.

  • platform/gtk/editing/selection/caret-mode-document-begin-end-expected.txt: Added.
  • platform/gtk/editing/selection/caret-mode-document-begin-end.html: Added.

2010-12-13 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Additional support is needed for caret browsing
https://bugs.webkit.org/show_bug.cgi?id=25526

Enable "MoveTo{Beginninng|End}OfDocument" commands when caret
browsing is enabled.

This change impacts the GTK-port only as caret browsing is a
feature only used in that platform so far.

Test: platform/gtk/editing/selection/caret-mode-document-begin-end.html

  • editing/EditorCommand.cpp: (WebCore::createCommandMap): Enable the commads when in caret browsing.
7:46 AM QtWebKitRelease22 created by Ademar Reis
7:45 AM Changeset in webkit [73917] by yurys@chromium.org
  • 3 edits in trunk/WebCore

2010-12-13 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Qt build fix.

  • dom/Event.cpp: (WebCore::Event::isErrorEvent):
  • dom/Event.h: remove ENABLE(WORKERS) guard since ErrorEvent is now used not only in workers.
7:35 AM Changeset in webkit [73916] by loislo@chromium.org
  • 15 edits in trunk

2010-12-13 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Protocol cleanup task. Assign domain attribute to Resources and Debugger specific functions.

Debugger and Resources related notification functions of Inspector.idl were
marked as such with help of "domain" attribute. The other changes in js files
are reflecting this change. Some wrappers in WebInspector namespace were dropped,
the others were moved to DebuggerModel class.

https://bugs.webkit.org/show_bug.cgi?id=50906

  • inspector/Inspector.idl:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::didParseSource):
  • inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::resetState):
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent.prototype.didCommitLoad):
  • inspector/front-end/Database.js:
  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel): (WebInspector.DebuggerModel.prototype.pausedScript): (WebInspector.DebuggerModel.prototype.resumedScript): (WebInspector.DebuggerModel.prototype.attachDebuggerWhenShown): (WebInspector.DebuggerModel.prototype.debuggerWasEnabled): (WebInspector.DebuggerModel.prototype.debuggerWasDisabled): (WebInspector.DebuggerModel.prototype.parsedScriptSource): (WebInspector.DebuggerModel.prototype.failedToParseScriptSource): (WebInspector.DebuggerModel.prototype.didCreateWorker): (WebInspector.DebuggerModel.prototype.didDestroyWorker):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel): (WebInspector.ProfilesPanel.prototype.updateMainViewWidth): (WebInspector.ProfilesPanel.prototype.setRecordingProfile):
  • inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager): (WebInspector.ResourceManager.prototype._unbindResourceURL): (WebInspector.ResourceManager.prototype.updateDOMStorage): (WebInspector.ResourceManager.prototype.updateApplicationCacheStatus): (WebInspector.ResourceManager.prototype.didGetFileSystemPath): (WebInspector.ResourceManager.prototype.didGetFileSystemError): (WebInspector.ResourceManager.prototype.didGetFileSystemDisabled): (WebInspector.ResourceManager.prototype.updateNetworkState): (WebInspector.ResourceManager.prototype.addDOMStorage): (WebInspector.ResourceManager.prototype.selectDOMStorage): (WebInspector.ResourceManager.prototype.addDatabase): (WebInspector.ResourceManager.prototype.selectDatabase): (WebInspector.ResourceManager.prototype.sqlTransactionSucceeded): (WebInspector.ResourceManager.prototype.sqlTransactionFailed):
  • inspector/front-end/WorkersSidebarPane.js: (WebInspector.Worker):
  • inspector/front-end/inspector.js:

2010-12-13 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Protocol cleanup task. Assign domain attribute to Resources and Debugger specific functions.

Debugger and Resources related notification functions of Inspector.idl were
marked as such with help of "domain" attribute. The other changes in js files
are reflecting this change. Some wrappers in WebInspector namespace were dropped,
the others were moved to DebuggerModel class.

https://bugs.webkit.org/show_bug.cgi?id=50906

  • src/js/Tests.js: (.TestSuite.prototype._waitForScriptPause): (.TestSuite.prototype._waitUntilScriptsAreParsed.waitForAllScripts): (.TestSuite.prototype._waitUntilScriptsAreParsed):

2010-12-13 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Protocol cleanup task. Assign domain attribute to Resources and Debugger specific functions.

Debugger and Resources related notification functions of Inspector.idl were
marked as such with help of "domain" attribute. The other changes in js files
are reflecting this change. Some wrappers in WebInspector namespace were dropped,
the others were moved to DebuggerModel class.

https://bugs.webkit.org/show_bug.cgi?id=50906

  • http/tests/inspector/debugger-test2.js: (initialize_DebuggerTest.InspectorTest.startDebuggerTest.startTest): (initialize_DebuggerTest.InspectorTest.startDebuggerTest): (initialize_DebuggerTest.InspectorTest.completeDebuggerTest.disableDebugger): (initialize_DebuggerTest.InspectorTest.showScriptSource):
7:33 AM Changeset in webkit [73915] by yurys@chromium.org
  • 3 edits in trunk/WebCore

2010-12-13 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Qt build fix.

  • dom/ErrorEvent.cpp:
  • dom/ErrorEvent.h: remove ENABLE(WORKERS) guard since ErrorEvent is now used not only in workers.
7:16 AM Changeset in webkit [73914] by yurys@chromium.org
  • 35 edits
    2 copies
    2 moves
    45 adds in trunk

2010-12-13 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Adam Barth.

WebCore doesn't fire window.onerror event when uncaught JavaScript exceptions are thrown
https://bugs.webkit.org/show_bug.cgi?id=8519

Uncaught exceptions are propagated to window.onerror hander if one is present.
The handler is expected to be a function accepting three arguments: error message,
resource url and line number where the exception occured.

  • fast/events/resources/window-onerror.js: Added. (throwException):
  • fast/events/window-onerror1-expected.txt: Added.
  • fast/events/window-onerror1.html: Added.
  • fast/events/window-onerror10-expected.txt: Added.
  • fast/events/window-onerror10.html: Added.
  • fast/events/window-onerror11-expected.txt: Added.
  • fast/events/window-onerror11.html: Added.
  • fast/events/window-onerror2-expected.txt: Added.
  • fast/events/window-onerror2.html: Added.
  • fast/events/window-onerror3-expected.txt: Added.
  • fast/events/window-onerror3.html: Added.
  • fast/events/window-onerror4-expected.txt: Added.
  • fast/events/window-onerror4.html: Added.
  • fast/events/window-onerror5-expected.txt: Added.
  • fast/events/window-onerror5.html: Added.
  • fast/events/window-onerror6-expected.txt: Added.
  • fast/events/window-onerror6.html: Added.
  • fast/events/window-onerror7-expected.txt: Added.
  • fast/events/window-onerror7.html: Added.
  • fast/events/window-onerror8-expected.txt: Added.
  • fast/events/window-onerror8.html: Added.
  • fast/events/window-onerror9-expected.txt: Added.
  • fast/events/window-onerror9.html: Added.
  • fast/workers/worker-script-error-expected.txt:
  • http/tests/security/resources/onerror-iframe.html: Added.
  • http/tests/security/window-onerror-exception-in-iframe-expected.txt: Added.
  • http/tests/security/window-onerror-exception-in-iframe.html: Added.
  • platform/chromium-win/fast/workers/worker-script-error-expected.txt:
  • platform/chromium/fast/events/window-onerror1-expected.txt: Added.
  • platform/chromium/fast/events/window-onerror10-expected.txt: Added.
  • platform/chromium/fast/events/window-onerror11-expected.txt: Added.
  • platform/chromium/fast/events/window-onerror2-expected.txt: Added.
  • platform/chromium/fast/events/window-onerror3-expected.txt: Added.
  • platform/chromium/fast/events/window-onerror4-expected.txt: Added.
  • platform/chromium/fast/events/window-onerror5-expected.txt: Added.
  • platform/chromium/fast/events/window-onerror6-expected.txt: Added.
  • platform/chromium/fast/events/window-onerror7-expected.txt: Added.
  • platform/chromium/fast/events/window-onerror8-expected.txt: Added.
  • platform/chromium/fast/events/window-onerror9-expected.txt: Added.
  • platform/chromium/http/tests/security/window-onerror-exception-in-iframe-expected.txt: Added.
  • platform/chromium/userscripts/window-onerror-for-isolated-world-1-expected.txt: Added.
  • platform/chromium/userscripts/window-onerror-for-isolated-world-2-expected.txt: Added.
  • userscripts/window-onerror-for-isolated-world-1-expected.txt: Added.
  • userscripts/window-onerror-for-isolated-world-1.html: Added.
  • userscripts/window-onerror-for-isolated-world-2-expected.txt: Added.
  • userscripts/window-onerror-for-isolated-world-2.html: Added.

2010-12-13 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Adam Barth.

WebCore doesn't fire window.onerror event when uncaught JavaScript exceptions are thrown
https://bugs.webkit.org/show_bug.cgi?id=8519

Uncaught exceptions are propagated to window.onerror hander if one is present.
The handler is expected to be a function accepting three arguments: error message,
resource url and line number where the exception occured.

It was decided to dispatch ErrorEvent to all listeners/handlers no matter if they
were created in the same isolated world where the exception occured or not.

Tests: fast/events/window-onerror1.html

fast/events/window-onerror10.html
fast/events/window-onerror11.html
fast/events/window-onerror2.html
fast/events/window-onerror3.html
fast/events/window-onerror4.html
fast/events/window-onerror5.html
fast/events/window-onerror6.html
fast/events/window-onerror7.html
fast/events/window-onerror8.html
fast/events/window-onerror9.html
http/tests/security/window-onerror-exception-in-iframe.html
userscripts/window-onerror-for-isolated-world-1.html
userscripts/window-onerror-for-isolated-world-2.html

  • Android.jscbindings.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.order:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSDOMBinding.cpp: (WebCore::reportException):
  • bindings/js/JSErrorHandler.cpp: Renamed from WebCore/bindings/js/JSWorkerContextErrorHandler.cpp. (WebCore::JSErrorHandler::JSErrorHandler): (WebCore::JSErrorHandler::~JSErrorHandler): (WebCore::JSErrorHandler::handleEvent):
  • bindings/js/JSErrorHandler.h: Copied from WebCore/bindings/js/JSWorkerContextErrorHandler.h. (WebCore::JSErrorHandler::create): (WebCore::createJSErrorHandler):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8ConsoleMessage.cpp: (WebCore::V8ConsoleMessage::dispatchNow): (WebCore::V8ConsoleMessage::handler): the method was changed to use generic WebCore exception reporting mechanism which is also used by JSC bindings.
  • bindings/v8/V8ConsoleMessage.h:
  • bindings/v8/V8WindowErrorHandler.cpp: Copied from WebCore/bindings/js/JSWorkerContextErrorHandler.h. (WebCore::V8WindowErrorHandler::V8WindowErrorHandler): (WebCore::V8WindowErrorHandler::callListenerFunction):
  • bindings/v8/V8WindowErrorHandler.h: Renamed from WebCore/bindings/js/JSWorkerContextErrorHandler.h. (WebCore::V8WindowErrorHandler::create):
  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::v8MessageHandler):
  • bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate):
  • dom/Document.cpp: (WebCore::Document::errorEventTarget): (WebCore::Document::logExceptionToConsole):
  • dom/Document.h:
  • dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::PendingException::PendingException): (WebCore::ScriptExecutionContext::ScriptExecutionContext): (WebCore::ScriptExecutionContext::reportException): this method is not virtual anymore to ensure that error event dispatching algorithm is the same in WorkerContext and in Document. (WebCore::ScriptExecutionContext::dispatchErrorEvent):
  • dom/ScriptExecutionContext.h:
  • workers/DefaultSharedWorkerRepository.cpp: (WebCore::postExceptionTask):
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::WorkerContext): (WebCore::WorkerContext::errorEventTarget): (WebCore::WorkerContext::logExceptionToConsole):
  • workers/WorkerContext.h:
  • workers/WorkerMessagingProxy.cpp: (WebCore::WorkerExceptionTask::performTask):

2010-12-13 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Adam Barth.

WebCore doesn't fire window.onerror event when uncaught JavaScript exceptions are thrown
https://bugs.webkit.org/show_bug.cgi?id=8519

Uncaught exceptions are propagated to window.onerror hander if one is present.
The handler is expected to be a function accepting three arguments: error message,
resource url and line number where the exception occured.

  • src/WebWorkerClientImpl.cpp: (WebKit::WebWorkerClientImpl::postExceptionToWorkerObject): (WebKit::WebWorkerClientImpl::postExceptionToWorkerObjectTask):
7:06 AM Changeset in webkit [73913] by apavlov@chromium.org
  • 17 edits in trunk

2010-12-08 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: Enable CSS property editing name/value-wise (like Firebug does)
https://bugs.webkit.org/show_bug.cgi?id=50565

For CSS property editing, the property name and value have become two fields separated
by a colon (rather than one field containing the full property text.) A user can tab
between the name and value fields forward and backward. A colon typed in the name field
and a semicolon in the value field (unless found inside a string) act as a Tab and focus
the next editable field (while applying the entire property value.)

Now a user can tab through all editable styles for an element, even across rule boundaries.

WebCore:

  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.XHRBreakpointsSidebarPane.prototype._startEditingBreakpoint):
  • inspector/front-end/DataGrid.js: (WebInspector.DataGrid.prototype._startEditingColumnOfDataGridNode): (WebInspector.DataGrid.prototype._startEditing):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._startEditingAttribute): (WebInspector.ElementsTreeElement.prototype._startEditingTextNode): (WebInspector.ElementsTreeElement.prototype._startEditingTagName): (WebInspector.ElementsTreeElement.prototype._startEditingAsHTML):
  • inspector/front-end/MetricsSidebarPane.js: (WebInspector.MetricsSidebarPane.prototype.startEditing):
  • inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertyTreeElement.prototype.startEditing):
  • inspector/front-end/Section.js: (WebInspector.Section): (WebInspector.Section.prototype.get subtitleAsTextForTest): (WebInspector.Section.prototype.get nextSibling): (WebInspector.Section.prototype.get previousSibling):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._editBreakpointCondition):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection.prototype.nextEditableSibling): (WebInspector.StylePropertiesSection.prototype.previousEditableSibling): (WebInspector.StylePropertiesSection.prototype.addNewBlankProperty): (WebInspector.StylePropertiesSection.prototype.startEditingSelector): (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted): (WebInspector.StylePropertyTreeElement.prototype.): (WebInspector.StylePropertyTreeElement.prototype):
  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._handleDoubleClick):
  • inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionTreeElement.prototype.startEditing):
  • inspector/front-end/inspector.css: (.child-editing):
  • inspector/front-end/inspector.js: (WebInspector.startEditing.defaultFinishHandler): (WebInspector.startEditing):
  • inspector/front-end/treeoutline.js: (TreeElement.prototype.select):

LayoutTests:

  • inspector/console-dir.html:
  • inspector/styles-add-blank-property.html:
6:25 AM Changeset in webkit [73912] by yael.aharon@nokia.com
  • 2 edits in trunk/WebCore

Unreviewed.

Added svn propery eol-style. Patches to this file fail to apply on Windows EWS bot.

  • accessibility/AccessibilityAllInOne.cpp: Added property svn:eol-style.
6:20 AM Changeset in webkit [73911] by commit-queue@webkit.org
  • 1 edit
    10 deletes in trunk/LayoutTests

2010-12-13 W. James MacLean <wjmaclean@chromium.org>

Reviewed by Csaba Osztrogonác.

Remove unnecessary pixel results, use platform-independent text results, re Changeset 72802
https://bugs.webkit.org/show_bug.cgi?id=50233

Remove redundant, platform-specific test results.

  • platform/chromium-linux/svg/custom/svg-parse-overflow-1-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/svg-parse-overflow-2-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/svg-parse-overflow-3-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/svg-parse-overflow-4-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/svg-parse-overflow-5-expected.txt: Removed.
  • platform/mac/svg/custom/svg-parse-overflow-1-expected.txt: Removed.
  • platform/mac/svg/custom/svg-parse-overflow-2-expected.txt: Removed.
  • platform/mac/svg/custom/svg-parse-overflow-3-expected.txt: Removed.
  • platform/mac/svg/custom/svg-parse-overflow-4-expected.txt: Removed.
  • platform/mac/svg/custom/svg-parse-overflow-5-expected.txt: Removed.
5:50 AM Changeset in webkit [73910] by hans@chromium.org
  • 13 edits in branches/chromium/597

Merge 73605 - 2010-12-07 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

IndexedDB returns the wrong exceptions
https://bugs.webkit.org/show_bug.cgi?id=50632

  • storage/indexeddb/constants-expected.txt:
  • storage/indexeddb/constants.html:
  • storage/indexeddb/objectstore-removeobjectstore-expected.txt:
  • storage/indexeddb/objectstore-removeobjectstore.html:

2010-12-07 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

IndexedDB returns the wrong exceptions
https://bugs.webkit.org/show_bug.cgi?id=50632

IndexedDB exceptions need to have an offset so they can
be distinguished from DOM exceptions. We also need to
add strings for the various exceptions. Lastly, make
IDBDatabaseException use the common exception base class.

  • bindings/js/JSDOMBinding.cpp: (WebCore::setDOMException):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::setDOMException):
  • dom/ExceptionCode.cpp: (WebCore::getExceptionCodeDescription):
  • dom/ExceptionCode.h:
  • storage/IDBDatabaseError.h: (WebCore::IDBDatabaseError::code):
  • storage/IDBDatabaseException.h: (WebCore::IDBDatabaseException::create): (WebCore::IDBDatabaseException::ErrorCodeToExceptionCode): (WebCore::IDBDatabaseException::IDBDatabaseException):
  • storage/IDBDatabaseException.idl:

TBR=jorlow@chromium.org
Review URL: http://codereview.chromium.org/5722007

5:50 AM Changeset in webkit [73909] by loislo@chromium.org
  • 13 edits in trunk

2010-12-13 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r73898.
http://trac.webkit.org/changeset/73898
https://bugs.webkit.org/show_bug.cgi?id=50919

FileSystem and Database API's were broken (Requested by loislo
on #webkit).

  • http/tests/inspector/debugger-test2.js: (initialize_DebuggerTest.InspectorTest.startDebuggerTest.startTest): (initialize_DebuggerTest.InspectorTest.startDebuggerTest): (initialize_DebuggerTest.InspectorTest.completeDebuggerTest.disableDebugger): (initialize_DebuggerTest.InspectorTest.showScriptSource):

2010-12-13 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r73898.
http://trac.webkit.org/changeset/73898
https://bugs.webkit.org/show_bug.cgi?id=50919

FileSystem and Database API's were broken (Requested by loislo
on #webkit).

2010-12-13 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r73898.
http://trac.webkit.org/changeset/73898
https://bugs.webkit.org/show_bug.cgi?id=50919

FileSystem and Database API's were broken (Requested by loislo
on #webkit).

  • src/js/Tests.js: (.TestSuite.prototype._waitForScriptPause):
5:46 AM Changeset in webkit [73908] by Patrick Gansterer
  • 2 edits in trunk/WebKitTools

2010-12-13 Patrick Gansterer <Patrick Gansterer>

Reviewed by Csaba Osztrogonác.

Add revlink to BuildBot status
https://bugs.webkit.org/show_bug.cgi?id=50914

This adds a hyperlink to trac changeset on the revision numbers.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
5:34 AM Changeset in webkit [73907] by antonm@chromium.org
  • 6 edits in trunk/WebCore

2010-12-13 Anton Muhin <antonm@chromium.org>

Reviewed by Pavel Feldman.

[v8] More CSS wrappers GC work: keep document's style sheets, style sheet and css rule lists' items in proper object groups
https://bugs.webkit.org/show_bug.cgi?id=50828

  • bindings/v8/DOMData.h: (WebCore::DOMData::WrapperMapObjectRemover::visitDOMWrapper): (WebCore::DOMData::removeObjectsFromWrapperMap):
  • bindings/v8/DOMDataStore.h: (WebCore::ChunkedTable::visit): (WebCore::ChunkedTable::visitEntries): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::visit): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::ChunkedTableTraits::visit):
  • bindings/v8/V8DOMMap.cpp: (WebCore::removeAllDOMObjectsInCurrentThread): (WebCore::visitDOMNodesInCurrentThread): (WebCore::visitDOMObjectsInCurrentThread): (WebCore::visitActiveDOMObjectsInCurrentThread): (WebCore::visitDOMSVGElementInstancesInCurrentThread):
  • bindings/v8/V8DOMMap.h: (WebCore::WeakReferenceMap::visit):
  • bindings/v8/V8GCController.cpp: (WebCore::DOMObjectVisitor::visitDOMWrapper): (WebCore::EnsureWeakDOMNodeVisitor::visitDOMWrapper): (WebCore::GCPrologueVisitor::visitDOMWrapper): (WebCore::NodeGrouperVisitor::visitDOMWrapper): (WebCore::NodeGrouperVisitor::applyGrouping): (WebCore::DOMObjectGrouperVisitor::visitDOMWrapper): (WebCore::GCEpilogueVisitor::visitDOMWrapper):
5:27 AM Changeset in webkit [73906] by commit-queue@webkit.org
  • 28 edits in trunk/WebKit/gtk

2010-12-13 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Xan Lopez.

[GTK] Do not use GET_PRIVATE macros
https://bugs.webkit.org/show_bug.cgi?id=50915

GET_PRIVATE macros are slow and should only be used in the object
init() method.

  • WebCoreSupport/ContextMenuClientGtk.cpp: (WebKit::inputMethodsMenuItem):
  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::postProgressFinishedNotification): (WebKit::FrameLoaderClient::setTitle): (WebKit::FrameLoaderClient::dispatchCreatePage): (WebKit::postCommitFrameViewSetup):
  • webkit/webkitdownload.cpp: (webkit_download_init):
  • webkit/webkitgeolocationpolicydecision.cpp: (webkit_geolocation_policy_decision_init):
  • webkit/webkithittestresult.cpp: (webkit_hit_test_result_init):
  • webkit/webkitnetworkrequest.cpp: (webkit_network_request_init):
  • webkit/webkitsecurityorigin.cpp: (webkit_security_origin_init):
  • webkit/webkitsecurityoriginprivate.h:
  • webkit/webkitviewportattributes.cpp: (webkit_viewport_attributes_init):
  • webkit/webkitwebbackforwardlist.cpp: (webkit_web_back_forward_list_init):
  • webkit/webkitwebdatabase.cpp: (webkit_web_database_init):
  • webkit/webkitwebdatasource.cpp: (webkit_web_data_source_init):
  • webkit/webkitwebframe.cpp: (webkit_web_frame_init): (webkit_web_frame_new):
  • webkit/webkitwebframeprivate.h:
  • webkit/webkitwebhistoryitem.cpp: (webkit_web_history_item_init):
  • webkit/webkitwebinspector.cpp: (webkit_web_inspector_init):
  • webkit/webkitwebnavigationaction.cpp: (webkit_web_navigation_action_init):
  • webkit/webkitwebplugin.cpp: (webkit_web_plugin_init):
  • webkit/webkitwebplugindatabase.cpp: (webkit_web_plugin_database_init):
  • webkit/webkitwebplugindatabaseprivate.h:
  • webkit/webkitwebpluginprivate.h:
  • webkit/webkitwebpolicydecision.cpp: (webkit_web_policy_decision_init):
  • webkit/webkitwebresource.cpp: (webkit_web_resource_init):
  • webkit/webkitwebresourceprivate.h:
  • webkit/webkitwebsettings.cpp: (webkit_web_settings_init):
  • webkit/webkitwebview.cpp: (PopupMenuPositionFunc): (webkit_web_view_forward_context_menu_event): (webkit_web_view_drag_end): (webkit_web_view_drag_data_get): (webkit_web_view_query_tooltip): (webkit_web_view_init):
  • webkit/webkitwebwindowfeatures.cpp: (webkit_web_window_features_init):
5:16 AM Changeset in webkit [73905] by abecsi@webkit.org
  • 8 edits
    1 move
    1 add in trunk

2010-12-13 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt][WK2] Fix build if WebKitTools are not available
https://bugs.webkit.org/show_bug.cgi?id=50242

  • DerivedSources.pro: add new DerivedSources.pro to SUBDIRS.

2010-12-13 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt][WK2] Fix build if WebKitTools are not available
https://bugs.webkit.org/show_bug.cgi?id=50242

  • DerivedSources.pro: Remove dependency to WebKitTools.
  • Scripts/generate-forwarding-headers.pl: Moved from WebKitTools/Scripts/generate-forwarding-headers.pl.

2010-12-13 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt][WK2] Fix build if WebKitTools are not available
https://bugs.webkit.org/show_bug.cgi?id=50242

  • MiniBrowser/qt/MiniBrowser.pro: Correct the comment.
  • Scripts/webkitdirs.pm: Added WebKitTools/MiniBrowser to $subdirs.
  • MiniBrowser/DerivedSources.pro: Added.
5:13 AM Changeset in webkit [73904] by zherczeg@webkit.org
  • 2 edits in trunk/WebCore

Unreviewed build fix for r73894.

SVGFEImage should also check its hasResult() in its apply().

  • svg/graphics/filters/SVGFEImage.cpp:

(WebCore::FEImage::apply):

4:55 AM Changeset in webkit [73903] by abecsi@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-12-13 Peter Varga <pvarga@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

Reduce the size of the RegexStackSpaceForBackTrackInfoParentheses in YARR
https://bugs.webkit.org/show_bug.cgi?id=49385

Remove the BackTrackInfoParentheses struct prevBegin and prevEnd members.

  • yarr/RegexInterpreter.cpp: (JSC::Yarr::Interpreter::matchParentheses): (JSC::Yarr::Interpreter::backtrackParentheses):
  • yarr/RegexPattern.h:
4:25 AM Changeset in webkit [73902] by hans@chromium.org
  • 16 edits in branches/chromium/597

Merge 73697 - 2010-12-10 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Numeric keys are floats.
https://bugs.webkit.org/show_bug.cgi?id=50674

Update layout tests to use floating-point values for keys.

  • storage/indexeddb/keyrange-expected.txt:
  • storage/indexeddb/keyrange.html: Make sure creating the keys works.
  • storage/indexeddb/objectstore-cursor-expected.txt:
  • storage/indexeddb/objectstore-cursor.html: Make sure retrieving the keys from the DB objectstore works.

2010-12-10 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Numeric keys are floats.
https://bugs.webkit.org/show_bug.cgi?id=50674

Use floating point to represent numeric keys,
add version meta data to the SQLite db,
and migrate object stores that use integers.

  • bindings/v8/IDBBindingUtilities.cpp: (WebCore::createIDBKeyFromValue):
  • bindings/v8/custom/V8IDBKeyCustom.cpp: (WebCore::toV8):
  • storage/IDBFactoryBackendImpl.cpp: (WebCore::createTables): (WebCore::migrateDatabase): (WebCore::IDBFactoryBackendImpl::open):
  • storage/IDBKey.cpp: (WebCore::IDBKey::IDBKey): (WebCore::IDBKey::fromQuery): (WebCore::IDBKey::bind): (WebCore::IDBKey::bindWithNulls):
  • storage/IDBKey.h: (WebCore::IDBKey::create): (WebCore::IDBKey::number):

2010-12-10 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Numeric keys are floats.
https://bugs.webkit.org/show_bug.cgi?id=50674

Represent numeric keys as floating point values.

  • public/WebIDBKey.h: (WebKit::WebIDBKey::WebIDBKey):
  • src/WebIDBKey.cpp: (WebKit::WebIDBKey::assign): (WebKit::WebIDBKey::number):

TBR=hans@chromium.org
Review URL: http://codereview.chromium.org/5800002

4:11 AM Changeset in webkit [73901] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] fast/loader/user-stylesheet-fast-path.html fails
https://bugs.webkit.org/show_bug.cgi?id=50911

  • platform/qt/Skipped: Add the failing test until fix.
3:54 AM Changeset in webkit [73900] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-13 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Updated chromium gpu test expectations.

  • platform/chromium-gpu/test_expectations.txt:
3:38 AM Changeset in webkit [73899] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-13 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Updated chromium test expectations.

  • platform/chromium/test_expectations.txt:
3:21 AM Changeset in webkit [73898] by loislo@chromium.org
  • 13 edits in trunk

2010-12-13 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Protocol cleanup task. Assign domain attribute to Resources and Debugger specific functions.

Debugger and Resources related notification functions of Inspector.idl were
marked as such with help of "domain" attribute. The other changes in js files
are reflecting this change. Some wrappers in WebInspector namespace were dropped,
the others were moved to DebuggerModel class.

https://bugs.webkit.org/show_bug.cgi?id=50906

  • inspector/Inspector.idl:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::didParseSource):
  • inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::resetState):
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent.prototype.didCommitLoad):
  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel): (WebInspector.DebuggerModel.prototype.pausedScript): (WebInspector.DebuggerModel.prototype.resumedScript): (WebInspector.DebuggerModel.prototype.attachDebuggerWhenShown): (WebInspector.DebuggerModel.prototype.debuggerWasEnabled): (WebInspector.DebuggerModel.prototype.debuggerWasDisabled): (WebInspector.DebuggerModel.prototype.parsedScriptSource): (WebInspector.DebuggerModel.prototype.failedToParseScriptSource):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel): (WebInspector.ProfilesPanel.prototype.addHeapSnapshots): (WebInspector.ProfilesPanel.prototype.updateMainViewWidth): (WebInspector.ProfilesPanel.prototype.setRecordingProfile):
  • inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager): (WebInspector.ResourceManager.prototype._unbindResourceURL): (WebInspector.ResourceManager.prototype.updateDOMStorage): (WebInspector.ResourceManager.prototype.updateApplicationCacheStatus): (WebInspector.ResourceManager.prototype.didGetFileSystemPath): (WebInspector.ResourceManager.prototype.didGetFileSystemError): (WebInspector.ResourceManager.prototype.didGetFileSystemDisabled): (WebInspector.ResourceManager.prototype.updateNetworkState): (WebInspector.ResourceManager.prototype.addDatabase): (WebInspector.ResourceManager.prototype.addDOMStorage):
  • inspector/front-end/inspector.js:

2010-12-13 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Protocol cleanup task. Assign domain attribute to Resources and Debugger specific functions.

Debugger and Resources related notification functions of Inspector.idl were
marked as such with help of "domain" attribute. The other changes in js files
are reflecting this change. Some wrappers in WebInspector namespace were dropped,
the others were moved to DebuggerModel class.

https://bugs.webkit.org/show_bug.cgi?id=50906

  • src/js/Tests.js: (.TestSuite.prototype._waitForScriptPause):

2010-12-13 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Protocol cleanup task. Assign domain attribute to Resources and Debugger specific functions.

Debugger and Resources related notification functions of Inspector.idl were
marked as such with help of "domain" attribute. The other changes in js files
are reflecting this change. Some wrappers in WebInspector namespace were dropped,
the others were moved to DebuggerModel class.

https://bugs.webkit.org/show_bug.cgi?id=50906

  • http/tests/inspector/debugger-test2.js: (initialize_DebuggerTest.InspectorTest.startDebuggerTest.startTest): (initialize_DebuggerTest.InspectorTest.startDebuggerTest): (initialize_DebuggerTest.InspectorTest.completeDebuggerTest.disableDebugger): (initialize_DebuggerTest.InspectorTest.showScriptSource):
  • platform/chromium/test_expectations.txt:
3:14 AM Changeset in webkit [73897] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-13 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Updated chromium test expectations.

  • platform/chromium/test_expectations.txt:
2:59 AM Changeset in webkit [73896] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-13 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Updated chromium test expectations.

  • platform/chromium/test_expectations.txt:
2:19 AM Changeset in webkit [73895] by eric@webkit.org
  • 2 edits
    1 delete in trunk/WebKitTools

2010-12-13 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

EWS Queues should remove orpahned pyc files before starting
https://bugs.webkit.org/show_bug.cgi?id=50904

A previous check added a platform.py which caused
EWS bots on some platforms to hit an import exception.
The platform.py file was removed in a subsequent commit, but
the EWS bots in question stayed stuck. This change will
fix those bots once restarted (and prevent this in the future).

I also went ahead and unified start-queue and start-commit-queue
since they were nearly identical. I also added bot_id support
to both force all EWSes to have bot ids as well as get rid of the one
remaining reason why I had my own copies of these scripts.
Hopefully this will be enough to get all the other bot admins
(ahem, Adam, ahem) to move to using these checked in copies as well.

  • EWSTools/start-commit-queue.sh: Removed.
  • EWSTools/start-queue.sh:
2:15 AM Changeset in webkit [73894] by zherczeg@webkit.org
  • 23 edits
    1 add in trunk/WebCore

Better result passing in filter primitives
https://bugs.webkit.org/show_bug.cgi?id=49907

Reviewed by Dirk Schulze.

SVG filter primitives can use the output of other filters. The
input and output format of a filter can be a premultiplied or
unmultiplied RGBA array, or an image buffer. All filter
primitive results were converted to image buffers before, which
could be an unecessary (and really costly) operation, if
a filter expects its input in the same format as the output
of the input filter primitive. This overhead is removed by
this patch. All apply() methods are updated according to this
new filter primitive interface.

Filters do not generate their results twice (or more) anymore,
when their apply() called multiple times.

The existing tests cover this feature.

  • manual-tests/svg-filter-animation.svg: Added.
  • platform/graphics/filters/FEBlend.cpp:

(WebCore::FEBlend::apply):

  • platform/graphics/filters/FEColorMatrix.cpp:

(WebCore::FEColorMatrix::apply):

  • platform/graphics/filters/FEComponentTransfer.cpp:

(WebCore::FEComponentTransfer::apply):

  • platform/graphics/filters/FEComposite.cpp:

(WebCore::FEComposite::apply):

  • platform/graphics/filters/FEConvolveMatrix.cpp:

(WebCore::FEConvolveMatrix::apply):

  • platform/graphics/filters/FEDisplacementMap.cpp:

(WebCore::FEDisplacementMap::apply):

  • platform/graphics/filters/FEFlood.cpp:

(WebCore::FEFlood::apply):

  • platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::apply):

  • platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::apply):

  • platform/graphics/filters/FEMerge.cpp:

(WebCore::FEMerge::apply):

  • platform/graphics/filters/FEMerge.h:
  • platform/graphics/filters/FEMorphology.cpp:

(WebCore::FEMorphology::apply):

  • platform/graphics/filters/FEOffset.cpp:

(WebCore::FEOffset::apply):

  • platform/graphics/filters/FETile.cpp:

(WebCore::FETile::apply):

  • platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::apply):

  • platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::requestedRegionOfInputImageData):
(WebCore::FilterEffect::asImageBuffer):
(WebCore::FilterEffect::asUnmultipliedImage):
(WebCore::FilterEffect::asPremultipliedImage):
(WebCore::FilterEffect::copyImageBytes):
(WebCore::FilterEffect::copyUnmultipliedImage):
(WebCore::FilterEffect::copyPremultipliedImage):
(WebCore::FilterEffect::createImageBufferResult):
(WebCore::FilterEffect::createUnmultipliedImageResult):
(WebCore::FilterEffect::createPremultipliedImageResult):

  • platform/graphics/filters/FilterEffect.h:

(WebCore::FilterEffect::hasResult):

  • platform/graphics/filters/SourceAlpha.cpp:

(WebCore::SourceAlpha::apply):

  • platform/graphics/filters/SourceGraphic.cpp:

(WebCore::SourceGraphic::apply):

  • platform/graphics/filters/SourceGraphic.h:
  • rendering/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::postApplyResource):

  • svg/graphics/filters/SVGFEImage.cpp:

(WebCore::FEImage::apply):

2:00 AM Changeset in webkit [73893] by Patrick Gansterer
  • 1 edit
    2 moves in trunk/LayoutTests

2010-12-13 Patrick Gansterer <Patrick Gansterer>

Reviewed by Eric Seidel.

Move user stylesheet test into platform independent directory
https://bugs.webkit.org/show_bug.cgi?id=47335

There is nothing platform specific in the test, so move it out of the mac directory.

  • fast/loader/user-stylesheet-fast-path-expected.txt: Copied from LayoutTests/platform/mac/fast/loader/user-stylesheet-fast-path-expected.txt.
  • fast/loader/user-stylesheet-fast-path.html: Copied from LayoutTests/platform/mac/fast/loader/user-stylesheet-fast-path.html.
  • platform/mac/fast/loader/user-stylesheet-fast-path-expected.txt: Removed.
  • platform/mac/fast/loader/user-stylesheet-fast-path.html: Removed.
1:50 AM Changeset in webkit [73892] by Csaba Osztrogonác
  • 4 edits in trunk

Unreviewed.

WebCore:

  • WebCore.pro: Remove non-existant loader/Request.h from build system.

WebKit2:

  • WebKit2.pro: Remove non-existant Shared/DrawingAreaBase.h from build system.
1:39 AM Changeset in webkit [73891] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2010-12-13 MORITA Hajime <morrita@google.com>

Unreviewed expectation update.

  • platform/chromium/test_expectations.txt:
1:11 AM Changeset in webkit [73890] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-12-13 Noel Gordon <noel.gordon@gmail.com>

Reviewed by Eric Seidel.

[chromium] Reduce canvas.toDataURL("image/jpeg") run-time cost by 10%
https://bugs.webkit.org/show_bug.cgi?id=50804

Follow on from r73173, unroll the SkUnPreMultiply::PMColorToColor() call
viz., compute the unpremultiplatcion in-place. This reduces the run-time
cost of jpeg encoding by 10-15% for my image test set.

No new tests: canvas.toDataURL() is covered by existing tests.

  • platform/image-encoders/skia/JPEGImageEncoder.cpp: (WebCore::preMultipliedBGRAtoRGB):
12:56 AM Changeset in webkit [73889] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

2010-12-13 Helder Correia <helder@sencha.com>

Reviewed by Eric Seidel.

[Qt] StillImage::draw() should use ContextShadow
https://bugs.webkit.org/show_bug.cgi?id=50849

The branch that checks for a shadow requirement in StillImage::draw()
is executed when drawing a canvas onto a canvas with
ctx1.drawImage(canvas2, x, y). The current implementation supports
solid shadows only. And if transformations are present, the offset gets
transformed as well. Thus, ContextShadow must be used instead in order
to support blur and correct offset transformations.

  • fast/canvas/canvas-draw-canvas-on-canvas-shadow-expected.txt: Added.
  • fast/canvas/canvas-draw-canvas-on-canvas-shadow.html: Added.
  • fast/canvas/script-tests/canvas-draw-canvas-on-canvas-shadow.js: Added.

2010-12-13 Helder Correia <helder@sencha.com>

Reviewed by Eric Seidel.

[Qt] StillImage::draw() should use ContextShadow
https://bugs.webkit.org/show_bug.cgi?id=50849

The branch that checks for a shadow requirement in StillImage::draw()
is executed when drawing a canvas onto a canvas with
ctx1.drawImage(canvas2, x, y). The current implementation supports
solid shadows only. And if transformations are present, the offset gets
transformed as well. Thus, ContextShadow must be used instead in order
to support blur and correct offset transformations.

Test: fast/canvas/canvas-draw-canvas-on-canvas-shadow.html

  • platform/graphics/qt/StillImageQt.cpp: (WebCore::StillImage::draw):

Dec 12, 2010:

11:18 PM Changeset in webkit [73888] by jhoneycutt@apple.com
  • 2 edits in trunk/WebCore

Unreviewed build fix.

  • editing/EditingAllInOne.cpp:

Add new file to the all-in-one.

10:31 PM Changeset in webkit [73887] by jhoneycutt@apple.com
  • 2 edits in trunk/WebCore

Unreviewed build fix.

  • WebCore.vcproj/WebCore.vcproj:

Remove accidentally-committed conflict marker.

10:06 PM Changeset in webkit [73886] by morrita@google.com
  • 64 edits
    5 adds in trunk

2010-10-28 MORITA Hajime <morrita@google.com>

Reviewed by Ojan Vafai.

spellcheck does not check pasted text
https://bugs.webkit.org/show_bug.cgi?id=40092

  • editing/spelling/script-tests/spellcheck-paste.js: Added.
  • editing/spelling/spellcheck-paste.html: Added.
  • editing/spelling/spellcheck-paste-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac-leopard/Skipped:
  • platform/mac-tiger/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2010-10-28 MORITA Hajime <morrita@google.com>

Reviewed by Ojan Vafai.

spellcheck does not check pasted text
https://bugs.webkit.org/show_bug.cgi?id=40092

  • Introduced SpellChecker class to encapsulate asynchronous spell checker state: sequence id, requesting text and target node. This is also the first step to decompose spell-check related code to a separate class.
  • Added EditorClient::isAsynchronousSpellCheckingEnabled() to use async spellcheck API on the platform. These APIs are touched by SpellChecker.
  • Used SpellChecker to check a pasted test. Text to check is collected from the subtree under the editingRoot.
  • Added Setting::m_asynchronousSpellCheckingEnabled to control async spell checking.

Test: editing/spelling/spellcheck-paste.html

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DocumentMarkerController.cpp: (WebCore::DocumentMarkerController::showMarkers): (showDocumentMarkers):
  • dom/DocumentMarkerController.h:
  • dom/PositionIterator.cpp: (WebCore::PositionIterator::setOffsetInLeafNode):
  • dom/PositionIterator.h:
  • editing/Editor.cpp: (WebCore::Editor::replaceSelectionWithFragment): (WebCore::Editor::Editor): (WebCore::findFirstMarkable): (WebCore::Editor::selectionStartHasSpellingMarkerFor):
  • editing/Editor.h: (WebCore::Editor::spellChecker):
  • editing/SpellChecker.cpp: Added. (WebCore::SpellChecker::SpellChecker): (WebCore::SpellChecker::~SpellChecker): (WebCore::SpellChecker::initRequest): (WebCore::SpellChecker::clearRequest): (WebCore::SpellChecker::isAsynchronousEnabled): (WebCore::SpellChecker::canCheckAsynchronously): (WebCore::SpellChecker::isBusy): (WebCore::SpellChecker::isValid): (WebCore::SpellChecker::isCheckable): (WebCore::SpellChecker::requestCheckingFor): (WebCore::forwardIterator): (WebCore::SpellChecker::didCheck):
  • editing/SpellChecker.h: Added. (WebCore::SpellCheckingResult::SpellCheckingResult): (WebCore::SpellCheckingResult::type): (WebCore::SpellCheckingResult::location): (WebCore::SpellCheckingResult::length):
  • loader/EmptyClients.h: (WebCore::EmptyEditorClient::requestCheckingOfString):
  • page/EditorClient.h:
  • page/Settings.cpp: (WebCore::Settings::Settings):
  • page/Settings.h: (WebCore::Settings::setAsynchronousSpellCheckingEnabled): (WebCore::Settings::asynchronousSpellCheckingEnabled):

2010-10-28 MORITA Hajime <morrita@google.com>

Reviewed by Ojan Vafai.

spellcheck does not check pasted text
https://bugs.webkit.org/show_bug.cgi?id=40092

Added a stub implememntation.

  • src/EditorClientImpl.h: (WebKit::EditorClientImpl::requestCheckingOfString):

2010-10-28 MORITA Hajime <morrita@google.com>

Reviewed by Ojan Vafai.

spellcheck does not check pasted text
https://bugs.webkit.org/show_bug.cgi?id=40092

Added a stub implememntation.

  • WebCoreSupport/EditorClientEfl.h: (WebCore::EditorClientEfl::requestCheckingOfString):

2010-10-28 MORITA Hajime <morrita@google.com>

Reviewed by Ojan Vafai.

spellcheck does not check pasted text
https://bugs.webkit.org/show_bug.cgi?id=40092

Added a stub implememntation.

  • WebCoreSupport/EditorClientGtk.h: (WebKit::EditorClient::requestCheckingOfString):

2010-10-28 MORITA Hajime <morrita@google.com>

Reviewed by Ojan Vafai.

spellcheck does not check pasted text
https://bugs.webkit.org/show_bug.cgi?id=40092

Added a stub implememntation.

  • WebCoreSupport/EditorClientHaiku.h: (WebCore::EditorClientHaiku::requestCheckingOfString):

2010-10-28 MORITA Hajime <morrita@google.com>

Reviewed by Ojan Vafai.

spellcheck does not check pasted text
https://bugs.webkit.org/show_bug.cgi?id=40092

Added asynchronous spell checking API to WebEditorClient using
-[NSSpellChecker requestCheckingOfString].
Note that WebEditorSpellCheckResponder is a small class to receive
requested spell-checking result. Note that this feature is
disabled at default.

Also added [WebPreferences setAsynchronousSpellCheckingEnabled:] to
enable the feature from LayoutTestController.

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: (-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:results:]): (-[WebEditorSpellCheckResponder perform]): (toCoreSpellingResult): (-[WebEditorSpellCheckResponder WTF::WebCore::]): (WebEditorClient::requestCheckingOfString):
  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences setAsynchronousSpellCheckingEnabled:]): (-[WebPreferences asynchronousSpellCheckingEnabled]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):

2010-10-28 MORITA Hajime <morrita@google.com>

Reviewed by Ojan Vafai.

spellcheck does not check pasted text
https://bugs.webkit.org/show_bug.cgi?id=40092

Added a stub implememntation.

  • WebCoreSupport/EditorClientQt.h: (WebCore::EditorClientQt::requestCheckingOfString):

2010-10-28 MORITA Hajime <morrita@google.com>

Reviewed by Ojan Vafai.

spellcheck does not check pasted text
https://bugs.webkit.org/show_bug.cgi?id=40092

Added a stub implememntation.

  • WebCoreSupport/WebEditorClient.h: (WebEditorClient::requestCheckingOfString):

2010-10-28 MORITA Hajime <morrita@google.com>

Reviewed by Ojan Vafai.

spellcheck does not check pasted text
https://bugs.webkit.org/show_bug.cgi?id=40092

Added a stub implememntation.

  • WebCoreSupport/EditorClientWinCE.h: (WebKit::EditorClient::requestCheckingOfString):

2010-10-28 MORITA Hajime <morrita@google.com>

Reviewed by Ojan Vafai.

spellcheck does not check pasted text
https://bugs.webkit.org/show_bug.cgi?id=40092

Added a stub implememntation.

  • WebKitSupport/EditorClientWx.h: (WebCore::EditorClientWx::requestCheckingOfString):

2010-10-28 MORITA Hajime <morrita@google.com>

Reviewed by Ojan Vafai.

spellcheck does not check pasted text
https://bugs.webkit.org/show_bug.cgi?id=40092

Added a stub implememntation.

  • WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::requestCheckingOfString):
  • WebProcess/WebCoreSupport/WebEditorClient.h:

2010-10-28 MORITA Hajime <morrita@google.com>

Reviewed by Ojan Vafai.

spellcheck does not check pasted text
https://bugs.webkit.org/show_bug.cgi?id=40092

Added LayoutTestController::setAsynchronousSpellCheckingEnabled()
to control the setting.

  • DumpRenderTree/LayoutTestController.cpp: (setAsynchronousSpellCheckingEnabledCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setAsynchronousSpellCheckingEnabled):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setAsynchronousSpellCheckingEnabled):
  • DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setAsynchronousSpellCheckingEnabled):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setAsynchronousSpellCheckingEnabled):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setAsynchronousSpellCheckingEnabled):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setAsynchronousSpellCheckingEnabled):
9:52 PM Changeset in webkit [73885] by tonikitoo@webkit.org
  • 4 edits in trunk/WebCore

2010-12-09 Antonio Gomes <agomes@rim.com>

Reviewed by Daniel Bates.

Spatial Navigation: code clean up (part II)
https://bugs.webkit.org/show_bug.cgi?id=50666

No new tests needed.

  • page/FocusController.cpp: Removed static declaration of updateFocusCandidateIfNeeded() from the top of FocusController.cpp, and added the 'static' keyword where the function is implemented;
  • page/SpatialNavigation.cpp: In FocusCandidate constructor, renamed 'n' to 'node', and added an assert to it; (WebCore::FocusCandidate::FocusCandidate): (WebCore::virtualRectForAreaElementAndDirection): Added an assert to 'node';
  • page/SpatialNavigation.h:I reordered the declaration of some methods in order to group related ones; Removed isScrollableContainerNode() function declaration since it is not used outside SpatialNavigation.cpp; And removed the declaration of isNodeDeepDescendantOfDocument() since it does not exist anymore.
8:41 PM Changeset in webkit [73884] by bweinstein@apple.com
  • 2 edits in trunk/WebKit2

WebKit2: Implement WebInspector::localizedStringsURL on Windows
https://bugs.webkit.org/show_bug.cgi?id=50896

Reviewed by Tim Hatcher.

Find the localized strings file using CFBundleCopyResourceURL.

  • WebProcess/WebPage/win/WebInspectorWin.cpp:

(WebKit::WebInspector::localizedStringsURL):

4:49 PM Changeset in webkit [73883] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Update WebKit2 skipped list.

  • platform/mac-wk2/Skipped:
4:30 PM Changeset in webkit [73882] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Give LogTextInput a sensible flag value.

Reviewed by Anders Carlsson.

  • Platform/Logging.cpp:
4:25 PM Changeset in webkit [73881] by weinig@apple.com
  • 1 edit in trunk/WebKit2/ChangeLog

Add missing bugzilla URL.

4:14 PM Changeset in webkit [73880] by weinig@apple.com
  • 2 edits in trunk/WebKitTools

Fix failing API test. It turns out that a pop-state event
is sent before every fragment navigation, so we have to test
for it in addition in PageLoadDidChangeLocationWithinPageForFrame.

Reviewed by Anders Carlsson.

  • TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:

(TestWebKitAPI::didSameDocumentNavigationForFrame):

4:02 PM Changeset in webkit [73879] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Remove incorrect assertion that has been firing in the API tester.

Reviewed by Anders Carlsson.

  • UIProcess/WebDatabaseManagerProxy.cpp:

(WebKit::WebDatabaseManagerProxy::~WebDatabaseManagerProxy):

4:00 PM Changeset in webkit [73878] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Disable WebKit2 logging by default.

Reviewed by Anders Carlsson.

  • Platform/Logging.cpp:

(initializeLogChannelsIfNecessary):

12:15 PM Changeset in webkit [73877] by bweinstein@apple.com
  • 4 edits in trunk/WebKit2

Web Inspector: Make inspector on Windows show and be usable in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=50877

Reviewed by Sam Weinig.

Hook up the unimplemented methods in WebInspectorProxyWin to get the web inspector
showing and usable in WebKit2 on Windows.

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::WebInspectorProxy): Initialize Windows-specific variables to 0.

  • UIProcess/WebInspectorProxy.h:
  • UIProcess/win/WebInspectorProxyWin.cpp:

(WebKit::WebInspectorProxy::registerInspectorViewWindowClass): Sets up the inspector view class.
(WebKit::WebInspectorProxy::InspectorViewWndProc): Calls through to the WebInspectorProxy's non-static

WndProc.

(WebKit::WebInspectorProxy::wndProc): Handles WM_SIZE, WM_CLOSE, and WM_GETMINMAXINFO, the rest go to

::DefWindowProc.

(WebKit::WebInspectorProxy::onSizeEvent): Resize the WKView that has the inspector page to match the

outer window that was just resized.

(WebKit::WebInspectorProxy::onMinMaxInfoEvent): Set the minimum size the window can be resized to.
(WebKit::WebInspectorProxy::onCloseEvent): Hide the window, and call WebInspectorProxy::close.
(WebKit::WebInspectorProxy::platformCreateInspectorPage): Create a WKView and return its page.
(WebKit::WebInspectorProxy::platformOpen): Create an HWND for the inspector, put the inspector's WKView

inside of it, and show the window.

(WebKit::WebInspectorProxy::platformClose): Destroy the inspector's window (which destroys the child WKView),

and 0 out instance variables.

(WebKit::WebInspectorProxy::inspectorPageURL): Finds inspector/inspector.html in the WebKit bundle.

8:25 AM Changeset in webkit [73876] by kbalazs@webkit.org
  • 2 edits in trunk/WebKit2

[Qt][WK2] Crash in WebPage constructor.
https://bugs.webkit.org/show_bug.cgi?id=50892

Reviewed by Andreas Kling.

  • WebProcess/qt/WebProcessQt.cpp:

(WebKit::WebProcess::platformInitializeWebProcess):
Disable runtime enabled features that have no WebKit2 implementation yet.

4:00 AM Changeset in webkit [73875] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-12-12 Xan Lopez <xlopez@igalia.com>

Rubber-stamped by Martin Robinson.

  • webkit/webkitwebplugin.h: add a note about the extension list being a NULL-terminated array.
4:00 AM Changeset in webkit [73874] by xan@webkit.org
  • 20 edits in trunk/WebKit/gtk

2010-12-12 Xan Lopez <xlopez@igalia.com>

Rubber-stamped by Gustavo Noronha.

Stop checking for glib >= 2.16, we have dependend on a newer
version for a long time now.

  • tests/testatk.c: Stop checking for glib >= 2.16.
  • tests/testatkroles.c: ditto.
  • tests/testdomdocument.c: ditto.
  • tests/testdomdomwindow.c: ditto.
  • tests/testdomnode.c: ditto.
  • tests/testglobals.c: ditto.
  • tests/testhttpbackend.c: ditto.
  • tests/testloading.c: ditto.
  • tests/testmimehandling.c: ditto.
  • tests/testnetworkrequest.c: ditto.
  • tests/testnetworkresponse.c: ditto.
  • tests/testwebbackforwardlist.c: ditto.
  • tests/testwebdatasource.c: ditto.
  • tests/testwebframe.c: ditto.
  • tests/testwebhistoryitem.c: ditto.
  • tests/testwebresource.c: ditto.
  • tests/testwebsettings.c: ditto.
  • tests/testwebview.c: ditto.
  • tests/testwindow.c: ditto.
3:46 AM Changeset in webkit [73873] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-12-12 Alejandro G. Castro <alex@igalia.com>

Reviewed by Eric Seidel.

[GTK] Add new-run-webkit-tests support to gtk
https://bugs.webkit.org/show_bug.cgi?id=50681

Adding the basic support to run the new-run-webkit-tests.

  • Scripts/webkitpy/layout_tests/port/gtk.py:
3:30 AM Changeset in webkit [73872] by Philippe Normand
  • 2 edits in trunk/WebCore

2010-12-12 Philippe Normand <pnormand@igalia.com>

Reviewed by Xan Lopez.

build-webkit --gtk --minimal fails
https://bugs.webkit.org/show_bug.cgi?id=46267

No new tests, build fix only.

  • GNUmakefile.am: Include some JS bindings generated headers in the build even if their corresponding feature is disabled. They are needed to make the DOM bindings build.
3:02 AM Changeset in webkit [73871] by alex
  • 2 edits in trunk/LayoutTests

2010-12-12 Alejandro G. Castro <alex@igalia.com>

Unreviewed, skipping failing tests in the bots.

  • platform/gtk/Skipped:
3:00 AM Changeset in webkit [73870] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-12-12 Sam Magnuson <smagnuso@gmail.com>

Reviewed by Eric Seidel.

[Qt] Compile with QT_NO_QUUID_STRING.
https://bugs.webkit.org/show_bug.cgi?id=49745

  • platform/UUID.cpp: (WebCore::createCanonicalUUIDString):
2:58 AM Changeset in webkit [73869] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-12-12 Ragner Magalhaes <ragner.magalhaes@openbossa.org>

Reviewed by Eric Seidel.

[Qt] Missing style for date pickers on Qt Mobile theme
https://bugs.webkit.org/show_bug.cgi?id=50628

  • css/themeQtMobile.css:
Note: See TracTimeline for information about the timeline view.