Context Navigation

Remove PNGEncoderState class - it was a proxy for the encoder output, and
that is a Vector<>, so just write into it directly using append() to make
use of Vector<>'s resize() smarts. Simplify the preMultipliedBGRAtoRGBA()
and encode() routines, replace the OwnArrayPtr<> with a Vector<>.

canvas.toDataURL("image/png") is covered by existing tests.

platform/image-encoders/skia/PNGImageEncoder.cpp: (WebCore::writeOutput): Use a Vector<>, append() the encoded data to it. (WebCore::preMultipliedBGRAtoRGBA): simplified. (WebCore::PNGImageEncoder::encode): ditto.

3:32 PM Changeset in webkit [74319] by mitz@apple.com

5 edits in trunk

Text emphasis marks are not always included in the selection highlight
https://bugs.webkit.org/show_bug.cgi?id=51299

Reviewed by Cameron Zwarich.

WebCore:

Affects pixel results of fast/text/emphasis.html

Account for annotations in selectionTop() and selectionBottom().

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::selectionTop):
(WebCore::RootInlineBox::selectionBottom):

LayoutTests:

platform/mac/fast/text/emphasis-expected.checksum:
platform/mac/fast/text/emphasis-expected.png:

2:49 PM Changeset in webkit [74318] by mitz@apple.com

3 edits
4 adds in trunk

In flipped writing modes, opposite text emphasis marks from adjacent lines overlap
https://bugs.webkit.org/show_bug.cgi?id=51298

Reviewed by Cameron Zwarich.

WebCore:

Test: fast/text/emphasis-overlap.html

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::beforeAnnotationsAdjustment): Changed + to -.

LayoutTests:

fast/text/emphasis-overlap-expected.checksum: Added.
fast/text/emphasis-overlap-expected.png: Added.
fast/text/emphasis-overlap-expected.txt: Added.
fast/text/emphasis-overlap.html: Added.

10:44 AM Changeset in webkit [74317] by Martin Robinson

16 edits
1 copy
1 move
1 add
2 deletes in trunk

2010-12-18 Helder Correia <helder@sencha.com> and Martin Robinson <mrobinson@igalia.com>

Reviewed by Ariya Hidayat.

[Qt] Canvas shadow offset should not be affected by any transformation
https://bugs.webkit.org/show_bug.cgi?id=50422

On a canvas context, shadows are currently affected by all
transformations except scaling. According to the spec:
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#shadows

"The shadowOffsetX and shadowOffsetY attributes specify the distance
that the shadow will be offset in the positive horizontal and positive
vertical distance respectively. Their values are in coordinate space
units. They are not affected by the current transformation matrix."

NOTE: this applies only to canvas, not to box shadows.

Add new test to ensure that shadows are correctly transformed keeping
the relative offset to the shape.

fast/canvas/canvas-scale-strokePath-shadow-expected.txt: See strokePath below.
fast/canvas/canvas-transforms-fillRect-shadow-expected.txt: Added.
fast/canvas/canvas-transforms-fillRect-shadow.html: Added.
fast/canvas/script-tests/canvas-scale-fillPath-shadow.js:
fast/canvas/script-tests/canvas-scale-fillRect-shadow.js:
fast/canvas/script-tests/canvas-scale-strokePath-shadow.js: Now using a lineWidth > 1 to make it easier to test and more fair among all ports, since there can be different transformation smoothness or aliasing settings.
fast/canvas/script-tests/canvas-transforms-fillRect-shadow.js: Added.
platform/gtk/Skipped: GTK port needs to implement this feature.
platform/gtk/fast/canvas/canvas-scale-fillPath-shadow-expected.txt: Removed.
platform/gtk/fast/canvas/canvas-scale-fillRect-shadow-expected.txt: Removed.
platform/gtk/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Removed.

2010-12-18 Helder Correia <helder@sencha.com> and Martin Robinson <mrobinson@igalia.com>

Reviewed by Ariya Hidayat.

[Qt] Canvas shadow offset should not be affected by any transformation
https://bugs.webkit.org/show_bug.cgi?id=50422

On a canvas context, shadows are currently affected by all
transformations except scaling. According to the spec:
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#shadows

"The shadowOffsetX and shadowOffsetY attributes specify the distance
that the shadow will be offset in the positive horizontal and positive
vertical distance respectively. Their values are in coordinate space
units. They are not affected by the current transformation matrix."

NOTE: this applies only to canvas, not to box shadows.

Test: fast/canvas/canvas-transforms-fillRect-shadow.html

platform/graphics/ContextShadow.cpp: (WebCore::ContextShadow::ContextShadow): (WebCore::ContextShadow::calculateLayerBoundingRect):
platform/graphics/ContextShadow.h: (WebCore::ContextShadow::setShadowsIgnoreTransforms): (WebCore::ContextShadow::shadowsIgnoreTransforms): (WebCore::ContextShadow::offset):
platform/graphics/qt/ContextShadowQt.cpp: (WebCore::ContextShadow::beginShadowLayer): (WebCore::ContextShadow::endShadowLayer):
platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::mustUseContextShadow): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::setPlatformShadow):

9:41 AM Changeset in webkit [74316] by ariya@webkit.org

2 edits in trunk/WebCore

2010-12-18 Ariya Hidayat <ariya@sencha.com>

Reviewed by Andreas Kling.

[Qt] TransparencyLayer should inherit its container render hints
https://bugs.webkit.org/show_bug.cgi?id=51283

platform/graphics/qt/TransparencyLayer.h: (WebCore::TransparencyLayer::TransparencyLayer):

1:23 AM Changeset in webkit [74315] by tonyg@chromium.org

15 edits in trunk

2010-12-18 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Laszlo Gombos.

[Web Timing] Rename domContentLoaded{Start,End}->domContentLoadedEvent{Start,End}
https://bugs.webkit.org/show_bug.cgi?id=50943

fast/dom/Window/window-properties-performance-expected.txt:
fast/dom/script-tests/webtiming.js: (checkTimingBeforeLoad): (checkTimingWhileDeferred): (checkWebTimingOnDOMContentLoaded): (checkWebTimingWhileAsync): (checkWebTimingOnLoad): (checkWebTimingAfterLoad):
fast/dom/webtiming-document-open-expected.txt:
fast/dom/webtiming-expected.txt:
fast/dom/webtiming-navigate-within-document-expected.txt:

2010-12-18 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Laszlo Gombos.

[Web Timing] Rename domContentLoaded{Start,End}->domContentLoadedEvent{Start,End}
https://bugs.webkit.org/show_bug.cgi?id=50943

See: http://test.w3.org/webperf/specs/NavigationTiming/#nt-dom-content-event-start

dom/Document.cpp: (WebCore::Document::finishedParsing):
dom/DocumentTiming.h: (WebCore::DocumentTiming::DocumentTiming):
page/PerformanceTiming.cpp: (WebCore::PerformanceTiming::domContentLoadedEventStart): (WebCore::PerformanceTiming::domContentLoadedEventEnd):
page/PerformanceTiming.h:
page/PerformanceTiming.idl:

2010-12-18 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Laszlo Gombos.

[Web Timing] Rename domContentLoaded{Start,End}->domContentLoadedEvent{Start,End}
https://bugs.webkit.org/show_bug.cgi?id=50943

Exposes all dom* times to the chromium port. I'm particularly interested in
domContentLoadedEventEnd as it compares to the FinishDoc metric.

public/WebPerformance.h:
src/WebPerformance.cpp: (WebKit::WebPerformance::domLoading): (WebKit::WebPerformance::domInteractive): (WebKit::WebPerformance::domContentLoadedEventStart): (WebKit::WebPerformance::domContentLoadedEventEnd): (WebKit::WebPerformance::domComplete):

Dec 17, 2010:

10:20 PM Changeset in webkit [74314] by tonyg@chromium.org

2 edits in trunk/LayoutTests

2010-12-17 Tony Gentilcore <tonyg@chromium.org>

Unreviewed.

[chromium] Mark fast/text/emphasis* failing
https://bugs.webkit.org/show_bug.cgi?id=51288

They have square characters that appear broken.

platform/chromium/test_expectations.txt:

9:20 PM Changeset in webkit [74313] by tonyg@chromium.org

2 edits in trunk/LayoutTests

2010-12-17 Tony Gentilcore <tonyg@chromium.org>

Unreviewed fix.

Fix JS syntax to avoid V8 error message
https://bugs.webkit.org/show_bug.cgi?id=51287

transitions/interrupted-accelerated-transition.html:

8:22 PM Changeset in webkit [74312] by jschuh@chromium.org

2 edits in trunk/WebCore

2010-12-17 Justin Schuh <jschuh@chromium.org>

Reviewed by Andreas Kling.

Style fix for r73927
https://bugs.webkit.org/show_bug.cgi?id=51194

No functionality change. No new tests needed.

html/HTMLCanvasElement.h:

6:37 PM Changeset in webkit [74311] by commit-queue@webkit.org

2 edits in trunk/WebCore

2010-12-17 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Buttons rendering was broken in r74129
https://bugs.webkit.org/show_bug.cgi?id=51173

platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::paintRenderObject):

6:32 PM Changeset in webkit [74310] by zherczeg@webkit.org

2 edits in trunk/WebCore

2010-12-17 Zoltan Herczeg <zherczeg@webkit.org>

Reviewed by Dirk Schulze.

Improve 'arithmetic' operator on feComposite
https://bugs.webkit.org/show_bug.cgi?id=51105

Fixing style errors and bug description for r74177.

platform/graphics/filters/FEComposite.cpp: (WebCore::arithmetic):

6:01 PM Changeset in webkit [74309] by msaboff@apple.com

5 edits in trunk

2010-12-17 Michael Saboff <msaboff@apple.com>

Reviewed by Oliver Hunt.

RegExp Jit'ed expression crashes clicking link on yelp.com
https://bugs.webkit.org/show_bug.cgi?id=51284

When transitioning between an non-repeating beginning of line
anchored expression and the remaining refactored repeating
expression, we should not clear any residual datalabel in
state's m_backtrack. It will be resolved and cleared in subsequent
code when linkAlternativeBacktracks() is called for the repeating
alternative(s).

yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::BacktrackDestination::clear): (JSC::Yarr::RegexGenerator::TermGenerationState::clearBacktrack):

2010-12-17 Michael Saboff <msaboff@apple.com>

Reviewed by Oliver Hunt.

RegExp Jit'ed expression crashes clicking link on yelp.com
https://bugs.webkit.org/show_bug.cgi?id=51284

New tests to validate changes made in regex JIT.

fast/regex/parentheses-expected.txt:
fast/regex/script-tests/parentheses.js:

5:57 PM Changeset in webkit [74308] by mitz@apple.com

5 edits in trunk

Updated for the renaming of WebKitTools to Tools

Rubber-stamped by Mark Rowe.

JavaScriptCore:

JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh:

WebCore:

WebCore.vcproj/build-generated-files.sh:
WebCore.vcproj/migrate-scripts.sh:

5:56 PM Changeset in webkit [74307] by tonyg@chromium.org

2 edits in trunk/WebKit/chromium

2010-12-17 Tony Gentilcore <tonyg@chromium.org>

Unreviewed, build fix.

Add WebKitTools -> Tools rename that got missed.

WebKit.gyp:

5:43 PM UsingGitWithWebKit edited by rniwa@webkit.org

Replaced WebKitTools by Tools (diff)

5:42 PM Changeset in webkit [74306] by Darin Adler

2 edits in trunk/WebKit2

2010-12-17 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Window title for image documents shows corrupted characters instead of multiplication sign when using WebKit2
https://bugs.webkit.org/show_bug.cgi?id=43505

WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: Changed UI_STRING macros to return WebCore::String objects instead of C strings. (WebKit::formatLocalizedString): Added. Uses the Core Foundation string formatting function for reasons explained in the comment. (WebKit::WebPlatformStrategies::multipleFileUploadText): Use formatLocalizedString instead of String::format. (WebKit::WebPlatformStrategies::imageTitle): Ditto. (WebKit::WebPlatformStrategies::localizedMediaTimeDescription): Ditto.

5:24 PM Changeset in webkit [74305] by jberlin@webkit.org

1 edit
2 adds in trunk/LayoutTests

Add expected results for Windows XP to get the bot green for
http://trac.webkit.org/changeset/74281.
Unreviewed.

platform/win-xp/fast/text/emphasis-expected.txt: Added.
platform/win-xp/fast/text/emphasis-vertical-expected.txt: Added.

5:14 PM Changeset in webkit [74304] by dpranke@chromium.org

2 edits in trunk/WebKit/chromium

2010-12-17 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.

Add WebKitTools -> Tools rename that got missed.

WebKit.gyp:

5:07 PM Changeset in webkit [74303] by andersca@apple.com

2 edits in trunk/WebKit2

2010-12-17 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Resizing a WKView while loading a page can leave the page at a size that doesn't match the window
https://bugs.webkit.org/show_bug.cgi?id=51282
<rdar://problem/8133142>

Fix a race condition in waitForMessage. If we time out on the wait condition, we would keep the
m_waitForMessageMutex mutex unlocked for a brief period of time before taking the lock again and
then removing the messageID/destinationID pair from the hash map. Under some circumstances, the
connection queue would update the hash map right before we removed it, leading to a lost message.

Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::waitForMessage):

4:30 PM Changeset in webkit [74302] by Csaba Osztrogonác

3 edits in trunk/Tools

Unreviewed Qt buildfix after r74301.

Rename WebKitTools to Tools
https://bugs.webkit.org/show_bug.cgi?id=49861

MiniBrowser/DerivedSources.pro:
MiniBrowser/qt/MiniBrowser.pro:

4:02 PM Changeset in webkit [74301] by mitz@apple.com

64 edits
1 move in trunk

Rename WebKitTools to Tools
https://bugs.webkit.org/show_bug.cgi?id=49861

Reviewed by Simon Fraser.

DerivedSources.pro:
GNUmakefile.am:
MakeFile:
MakeFile.shared:
Tools: Renamed from WebKitTools.
WebKit.pro:
cmake/WebKitPackaging.cmake:
wscript:

BugsSite:

PrettyPatch/PrettyPatch.rb:
committers-autocomplete.js:

Tools:

BuildSlaveSupport/build.webkit.org-config/master.cfg:
CodeCoverage/README:
DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::initializeFonts):

EWSTools/start-commit-queue.sh:
EWSTools/start-queue.sh:
GNUmakefile.am:
MIDLWrapper/MIDLWrapper.cpp:

(wmain):

MiniBrowser/qt/MiniBrowser.pro:
Scripts/build-api-tests:
Scripts/build-dumprendertree:
Scripts/build-webkit:
Scripts/build-webkittestrunner:
Scripts/generate-coverage-data:
Scripts/old-run-webkit-tests:
Scripts/run-api-tests:
Scripts/run-iexploder-tests:
Scripts/run-javascriptcore-tests:
Scripts/run-mangleme-tests:
Scripts/run-sunspider:
Scripts/run-webkit-websocketserver:
Scripts/sunspider-compare-results:
Scripts/test-webkitperl:
Scripts/test-webkitpy:
Scripts/update-iexploder-cssproperties:
Scripts/update-webkit:
Scripts/update-webkit-localizable-strings:
Scripts/webkitdirs.pm:
Scripts/webkitpy/common/checkout/scm.py:
Scripts/webkitpy/common/checkout/scm_unittest.py:
Scripts/webkitpy/common/config/committervalidator.py:
Scripts/webkitpy/common/config/committervalidator_unittest.py:
Scripts/webkitpy/common/config/ports.py:
Scripts/webkitpy/common/config/ports_unittest.py:
Scripts/webkitpy/common/system/logutils_unittest.py:
Scripts/webkitpy/common/system/ospath_unittest.py:
Scripts/webkitpy/layout_tests/port/chromium.py:
Scripts/webkitpy/layout_tests/port/config.py:
Scripts/webkitpy/layout_tests/port/config_unittest.py:
Scripts/webkitpy/layout_tests/port/http_server.py:
Scripts/webkitpy/layout_tests/port/test.py:
Scripts/webkitpy/style/checker.py:
Scripts/webkitpy/style/checker_unittest.py:
Scripts/webkitpy/tool/bot/feeders_unittest.py:
Scripts/webkitpy/tool/commands/queues_unittest.py:
Scripts/webkitpy/tool/steps/steps_unittest.py:
WebKitTestRunner/DerivedSources.pro:
WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:

(WTR::activateFonts):

WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
wx/build/build_utils.py:

WebKitSite:

asking_questions.html:
building/tools.html:
coding/scripts.html:

3:35 PM Changeset in webkit [74300] by andersca@apple.com

4 edits in trunk/WebKit2

Clean up ChunkedUpdateDrawingAreaProxy
https://bugs.webkit.org/show_bug.cgi?id=51277

Reviewed by Simon Fraser.

Get rid of m_lastSetViewSize since it was always equal to m_size.

UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:

(WebKit::ChunkedUpdateDrawingAreaProxy::sizeDidChange):
Call sendSetSize().

(WebKit::ChunkedUpdateDrawingAreaProxy::didSetSize):
Call sendSetSize if the size differs.

(WebKit::ChunkedUpdateDrawingAreaProxy::sendSetSize):
Move code from sizeDidChange over here.

UIProcess/ChunkedUpdateDrawingAreaProxy.h:
UIProcess/DrawingAreaProxy.cpp:

(WebKit::DrawingAreaProxy::setSize):
Add back the early return if the sizes are equal.

3:28 PM Changeset in webkit [74299] by ariya@webkit.org

2 edits in trunk/JavaScriptCore

2010-12-17 Ariya Hidayat <ariya@sencha.com>

Reviewed by Oliver Hunt.

[JSC] parseAssignmentExpression should use TreeBuilder::CreatesAST
https://bugs.webkit.org/show_bug.cgi?id=51268

parser/JSParser.cpp: (JSC::JSParser::parseAssignmentExpression):

3:03 PM Changeset in webkit [74298] by bfulgham@webkit.org

2 edits in trunk/WebKit2

Unreviewed build fix.

WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::WebPage::canHandleRequest): Provide alternative for
non-CFNetwork implementation.

2:48 PM Changeset in webkit [74297] by ggaren@apple.com

3 edits in trunk/JavaScriptCore

2010-12-17 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Removed RChunk from PageAllocation/PageReservation, since it's now unused.
https://bugs.webkit.org/show_bug.cgi?id=51276

wtf/PageAllocation.h: (WTF::PageAllocation::PageAllocation):
wtf/PageReservation.h: (WTF::PageReservation::PageReservation):

2:43 PM Changeset in webkit [74296] by adachan@apple.com

10 edits in trunk/WebKit2

Reviewed by Anders Carlsson.

Implement WKView::setInitialFocus().
https://bugs.webkit.org/show_bug.cgi?id=51274

UIProcess/API/C/win/WKView.cpp: (WKViewSetInitialFocus):
UIProcess/API/C/win/WKView.h:
UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setInitialFocus): Send message to the Web Process to set initial focus.
UIProcess/WebPageProxy.h:
UIProcess/win/WebView.cpp: (WebKit::WebView::setInitialFocus):
UIProcess/win/WebView.h:
WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::setInitialFocus): Set the focused node to null initially. Then ask FocusController to set the initial focus based on the focus direction.
WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in: Add a new message for SetInitialFocus.

2:24 PM Changeset in webkit [74295] by andersca@apple.com

2 edits in trunk/WebKit2

Remove a check that probably uncovered a resizing bug.

Reviewed by Sam Weinig.

UIProcess/DrawingAreaProxy.cpp:

(WebKit::DrawingAreaProxy::setSize):

2:11 PM Changeset in webkit [74294] by andersca@apple.com

9 edits in trunk/WebKit2

2010-12-17 Brian Weinstein <bweinstein@apple.com>

Qt build fix.

UIProcess/qt/WebPopupMenuProxyQt.h:

1:54 PM Changeset in webkit [74293] by Simon Fraser

3 edits in trunk/LayoutTests

2010-12-17 Simon Fraser <Simon Fraser>

Change this test to use the pause API by testing the individual properties,
rather than the compound property.

transitions/mask-transitions-expected.txt: Removed.
transitions/mask-transitions.html:

1:50 PM BuildBot edited by Dimitri Glazkov

(diff)

1:39 PM Changeset in webkit [74292] by carol.szabo@nokia.com

4 edits in trunk/WebCore

2010-12-17 Carol Szabo <carol.szabo@nokia.com>

Reviewed by Darin Adler.

A corrupted counter tree is created when renderers are added to the
tree bypassing RenderObject::addChild
https://bugs.webkit.org/show_bug.cgi?id=51270

This patch replaces the hack introduced for fixing bug 43812
with code that addresses the underlying problem for that bug.
No new layout tests provided as there is no identified scenario when
visible behavior would be different, the internal datastructures
are maintained properly through this fix so the previous hack
introduced for bug 43812 is now removed. The fact that the
layout test introduced for 43812 continues to pass is proof that the
code works.

rendering/RenderCounter.cpp: (WebCore::findPlaceForCounter): Removed hack.
rendering/RenderObject.cpp: (WebCore::RenderObject::addChild): Moved call to counter nodes updater to lower level functions to avoid bypass.
rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::appendChildNode): (WebCore::RenderObjectChildList::insertChildNode): Changed to update the values of the counters that may be inserted in the tree.

1:38 PM Changeset in webkit [74291] by oliver@apple.com

3 edits
3 adds in trunk

2010-12-17 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Incorrect encoding of some constants in ARMv7 JIT
https://bugs.webkit.org/show_bug.cgi?id=51273
<rdar://problem/8650210>

When using immediate encoding 3 we need to write the byte
that holds a duplicated value.

assembler/ARMv7Assembler.h: (JSC::ARMThumbImmediate::makeEncodedImm):

2010-12-17 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Incorrect encoding of some constants in ARMv7 JIT
https://bugs.webkit.org/show_bug.cgi?id=51273

Add a few tests for different byte patterns in immediates.

fast/js/constant-encoding-expected.txt: Added.
fast/js/constant-encoding.html: Added.
fast/js/script-tests/constant-encoding.js: Added.

1:37 PM Changeset in webkit [74290] by jberlin@webkit.org

1 edit
6 adds in trunk/LayoutTests

Add Windows-specific expected results for the the tests added in
http://trac.webkit.org/changeset/74281.

Rubber-stamped by Dan Bernstein.

platform/win/fast/text/emphasis-expected.checksum: Added.
platform/win/fast/text/emphasis-expected.png: Added.
platform/win/fast/text/emphasis-expected.txt: Added.
platform/win/fast/text/emphasis-vertical-expected.checksum: Added.
platform/win/fast/text/emphasis-vertical-expected.png: Added.
platform/win/fast/text/emphasis-vertical-expected.txt: Added.

1:29 PM Changeset in webkit [74289] by bweinstein@apple.com

2 edits in trunk/WebKit2

Qt build fix.

UIProcess/qt/WebPopupMenuProxyQt.h:

1:24 PM Changeset in webkit [74288] by commit-queue@webkit.org

2 edits in trunk/WebCore

2010-12-17 Shimeng (Simon) Wang <swang@google.com>

Reviewed by Steve Block.

Fix V8 JNI binding.
https://bugs.webkit.org/show_bug.cgi?id=51156

There're LayoutTests in:
http://trac.webkit.org/browser/trunk/LayoutTests/java/lc3/JSNumber
to exercise these code paths.
Though Chromium don't run them.
Tested on Android fast/events/touch tests.

bridge/jni/v8/JNIUtilityPrivate.cpp: (JSC::Bindings::convertNPVariantToJValue):

1:22 PM Changeset in webkit [74287] by Simon Fraser

3 edits
3 adds in trunk

2010-12-17 Simon Fraser <Simon Fraser>

Reviewed by Chris Marrin.

Interrupted accelerated animation can break later transitions
<rdar://problem/8767714>
https://bugs.webkit.org/show_bug.cgi?id=51264

If we're still waiting for the 'animationDidStart' callback when renderers
get destroyed, then the m_waitingForStartTimeResponse flag could be left
set to 'true', which causes later transitions to never start.

Fix by clearing the m_waitingForStartTimeResponse flag when the m_startTimeResponseWaiters
becomes empty.

Test: transitions/interrupted-accelerated-transition.html

page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::removeFromStartTimeResponseWaitList):

1:22 PM Changeset in webkit [74286] by Simon Fraser

3 edits in trunk/WebCore

2010-12-17 Simon Fraser <Simon Fraser>

Reviewed by Chris Marrin.

Interrupted accelerated animation can break later transitions
https://bugs.webkit.org/show_bug.cgi?id=51264

Step 1: code cleanup.
Rename "responseWait" variables to "startTimeResponseWait", to make it clear
the kind of response that is being waited for.

Make a couple of methods private.

No behavioral changes, so no tests.

page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::AnimationControllerPrivate): (WebCore::AnimationControllerPrivate::endAnimationUpdate): (WebCore::AnimationControllerPrivate::receivedStartTimeResponse): (WebCore::AnimationControllerPrivate::addToStartTimeResponseWaitList): (WebCore::AnimationControllerPrivate::removeFromStartTimeResponseWaitList): (WebCore::AnimationControllerPrivate::startTimeResponse):
page/animation/AnimationControllerPrivate.h:

1:08 PM Changeset in webkit [74285] by bweinstein@apple.com

21 edits in trunk/WebKit2

Text area does not update when you arrow through a <select> in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=51269
<rdar://problem/8612853>

Reviewed by Anders Carlsson.

Patch by Sam Weinig.

Insteaed of keeping track of the selected index of a <select> just in the UI process, we
need to pass this information along to the web process so that the web process can draw
the correct text in the text field at the top of the select, when the selection changes (via
the arrows or other typing while the select is opened).

When the selected item in a popup changes, the UI process sends a message to the web process, telling
it about the new selected index. The web process gets this message, and then sets the text that
is visible in the select element.

UIProcess/API/mac/PageClientImpl.h: CreatePopupMenuProxy now takes a WebPageProxy.
UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::createPopupMenuProxy): Pass the WebPageProxy to create.

UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::createPopupMenuProxy):

UIProcess/API/qt/qwkpage_p.h: CreatePopupMenuProxy now takes a WebPageProxy.
UIProcess/PageClient.h: CreatePopupMenuProxy now takes a WebPageProxy.
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::valueChangedForPopupMenu): Send that the selected index changed to the

web process.selected

(WebKit::WebPageProxy::setTextFromItemForPopupMenu): Send that we should update the text for the

active popup menu (with the index of the item to show).

(WebKit::WebPageProxy::showPopupMenu): Pass the WebPageProxy to createPopupMenuProxy.

UIProcess/WebPageProxy.h:
UIProcess/WebPopupMenuProxy.h: Add a client who has virtual functions for the state changing of the

popup menu. ShowPopupMenu doesn't take a new selected index anymore, that is handled by the client,
and calling down to the web process.

(WebKit::WebPopupMenuProxy::Client::~Client):
(WebKit::WebPopupMenuProxy::WebPopupMenuProxy): Initialize the client.

UIProcess/mac/WebPopupMenuProxyMac.h:

(WebKit::WebPopupMenuProxyMac::create): Takes a WebPopupMenuProxy::Client, and passes it to the constructor.

UIProcess/mac/WebPopupMenuProxyMac.mm:

(WebKit::WebPopupMenuProxyMac::WebPopupMenuProxyMac): Update what's initialized by the constructor.
(WebKit::WebPopupMenuProxyMac::showPopupMenu): Call through to the web process that the value changed.

UIProcess/qt/WebPopupMenuProxyQt.cpp:

(WebKit::WebPopupMenuProxyQt::WebPopupMenuProxyQt): Update what's initialized by the constructor.

UIProcess/win/WebPopupMenuProxyWin.cpp:

(WebKit::WebPopupMenuProxyWin::WebPopupMenuProxyWin): Ditto.
(WebKit::WebPopupMenuProxyWin::showPopupMenu): Call through to the web process that the value changed.
(WebKit::WebPopupMenuProxyWin::setFocusedIndex): Resolve a FIXME to set the text of the popup menu.

UIProcess/win/WebPopupMenuProxyWin.h:

(WebKit::WebPopupMenuProxyWin::create): Take in a WebPopupMenuProxy::client, and pass it to the constructor.

UIProcess/win/WebView.cpp:

(WebKit::WebView::createPopupMenuProxy): Pass the WebPageProxy to create.

UIProcess/win/WebView.h:
WebProcess/WebCoreSupport/WebPopupMenu.cpp:

(WebKit::WebPopupMenu::setTextForIndex): Call through to setTextFromItem to set the select text.

WebProcess/WebCoreSupport/WebPopupMenu.h:
WebProcess/WebPage/WebPage.cpp: Call through to setTextForIndex on the active popup menu.

(WebKit::WebPage::setTextForActivePopupMenu):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in: Add a new message.

1:06 PM Changeset in webkit [74284] by andersca@apple.com

12 edits in trunk/WebKit2

Add a WebPageProxy parameter to the DrawingAreaProxy constructor
https://bugs.webkit.org/show_bug.cgi?id=51271

Reviewed by Sam Weinig.

UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:contextRef:pageGroupRef:]):
(-[WKView _switchToDrawingAreaTypeIfNecessary:DrawingAreaInfo::]):

UIProcess/API/qt/qgraphicswkview.cpp:

(QGraphicsWKView::QGraphicsWKView):

UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:

(WebKit::ChunkedUpdateDrawingAreaProxy::create):
(WebKit::ChunkedUpdateDrawingAreaProxy::ChunkedUpdateDrawingAreaProxy):

UIProcess/ChunkedUpdateDrawingAreaProxy.h:
UIProcess/DrawingAreaProxy.cpp:

(WebKit::DrawingAreaProxy::DrawingAreaProxy):

UIProcess/DrawingAreaProxy.h:
UIProcess/LayerBackedDrawingAreaProxy.cpp:

(WebKit::LayerBackedDrawingAreaProxy::create):
(WebKit::LayerBackedDrawingAreaProxy::LayerBackedDrawingAreaProxy):

UIProcess/LayerBackedDrawingAreaProxy.h:
UIProcess/TiledDrawingAreaProxy.cpp:

(WebKit::TiledDrawingAreaProxy::create):
(WebKit::TiledDrawingAreaProxy::TiledDrawingAreaProxy):

UIProcess/TiledDrawingAreaProxy.h:
UIProcess/win/WebView.cpp:

(WebKit::WebView::WebView):
(WebKit::WebView::switchToDrawingAreaTypeIfNecessary):

11:45 AM Changeset in webkit [74283] by mitz@apple.com

10 edits in trunk/WebKit2

Add API for "Always Use the Complex Text Code Path"
https://bugs.webkit.org/show_bug.cgi?id=51265

Reviewed by Darin Adler.

Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::WebProcessCreationParameters): Initialize shouldAlwaysUseComplexTextCodePath.
(WebKit::WebProcessCreationParameters::encode): Encode shouldAlwaysUseComplexTextCodePath.
(WebKit::WebProcessCreationParameters::decode): Decode shouldAlwaysUseComplexTextCodePath.

Shared/WebProcessCreationParameters.h:
UIProcess/API/C/WKContext.cpp:

(_WKContextSetAlwaysUsesComplexTextCodePath): Added.

UIProcess/API/C/WKContextPrivate.h:
UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext): Initialize m_alwaysUsesComplexTextCodePath.
(WebKit::WebContext::ensureWebProcess): Set shouldAlwaysUseComplexTextCodePath in the creation parameters.
(WebKit::WebContext::setAlwaysUsesComplexTextCodePath): Added. Sets m_alwaysUsesComplexTextCodePath and
sends a message to the WebProcess.

UIProcess/WebContext.h:
WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess): Call setAlwaysUsesComplexTextCodePath() based on the creation
parameters.
(WebKit::WebProcess::setAlwaysUsesComplexTextCodePath): Added.

WebProcess/WebProcess.h:
WebProcess/WebProcess.messages.in: Added SetAlwaysUsesComplexTextCodePath.

11:35 AM Changeset in webkit [74282] by weinig@apple.com

7 edits in trunk/WebKit2

WebKit2: Implement a title attribute per frame
https://bugs.webkit.org/show_bug.cgi?id=51266

Reviewed by Darin Adler.

Cache the title of each frame on the WebFrameProxy. Removes
the WebPageProxy's cache of the main frame title to just
access the main frame.

We clear the cached title on new committed loads and on failures
to load.

UIProcess/API/C/WKFrame.cpp:

(WKFrameCopyTitle):

UIProcess/API/C/WKFrame.h:
UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::didCommitLoad):
(WebKit::WebFrameProxy::didFailLoad):
(WebKit::WebFrameProxy::didChangeTitle):

UIProcess/WebFrameProxy.h:

(WebKit::WebFrameProxy::title):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::pageTitle):
(WebKit::WebPageProxy::didReceiveTitleForFrame):
(WebKit::WebPageProxy::processDidCrash):

UIProcess/WebPageProxy.h:

11:31 AM Changeset in webkit [74281] by mitz@apple.com

10 edits
8 adds in trunk

WebCore: Layout and rendering of CSS text-emphasis
Final part of <rdar://problem/7720300> Support the CSS3 text-emphasis property
https://bugs.webkit.org/show_bug.cgi?id=48539

Reviewed by Dave Hyatt.

Tests: fast/text/emphasis-vertical.html

fast/text/emphasis.html

Emphasis marks behave like they are stuck just above the ascender (or just below the
descender). They occupy space in the leading and in padding, and only grow the line space
if they cannot fit.

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesInBlockDirection): Renamed the containsRuby parameter to
hasAnnotationsBefore, and added hasAnnotationsAfter. Line annotations include ruby and text emphasis
marks.
(WebCore::InlineFlowBox::addTextBoxVisualOverflow): Added overflow from emphasis marks.
(WebCore::InlineFlowBox::computeOverAnnotationAdjustment): Remaned computeBlockDirectionRubyAdjustment()
to this and added adjustment for text emphasis marks.
(WebCore::InlineFlowBox::computeUnderAnnotationAdjustment): Added. Similar to the previous function,
but for annotations under the glyphs. These can only be text emphasis marks.

rendering/InlineFlowBox.h:
rendering/InlineTextBox.cpp:

(WebCore::paintTextWithShadows): Paint emphasis marks.
(WebCore::InlineTextBox::paint): Ditto.

rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren): Generalized the code that adjusts the last line for
ruby in flipped writing mode to also adjust the last line for emphasis marks under the line in non-
flipped writing mode.

rendering/RenderObject.cpp:

(WebCore::RenderObject::selectionColor): Added this helper method which generalizes selectionForegroundColor().
(WebCore::RenderObject::selectionForegroundColor): Moved most of the code to selectionColor().
(WebCore::RenderObject::selectionEmphasisMarkColor): Added.

rendering/RenderObject.h:
rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::RootInlineBox): Updated initialization for new members.
(WebCore::RootInlineBox::alignBoxesInBlockDirection): Update new members.
(WebCore::RootInlineBox::beforeAnnotationsAdjustment): Renamed blockDirectionRubyAdjustment() to this
and extended to deal with annotations over and under the line and the previous line. If both lines have
annotations into the space between the lines, maintain separation so that the annotations do not overlap.

rendering/RootInlineBox.h:

(WebCore::RootInlineBox::hasAnnotationsBefore): Added this accessor.
(WebCore::RootInlineBox::hasAnnotationsAfter): Ditto.

LayoutTests: <rdar://problem/7720300> Support the CSS3 text-emphasis property
https://bugs.webkit.org/show_bug.cgi?id=48539

Reviewed by Dave Hyatt.

fast/text/emphasis-vertical.html: Added.
fast/text/emphasis.html: Added.
platform/mac/fast/text/emphasis-expected.checksum: Added.
platform/mac/fast/text/emphasis-expected.png: Added.
platform/mac/fast/text/emphasis-expected.txt: Added.
platform/mac/fast/text/emphasis-vertical-expected.checksum: Added.
platform/mac/fast/text/emphasis-vertical-expected.png: Added.
platform/mac/fast/text/emphasis-vertical-expected.txt: Added.

11:12 AM Changeset in webkit [74280] by tonikitoo@webkit.org

1 edit
1 add in trunk/LayoutTests

2010-12-17 Antonio Gomes <agomes@rim.com>

Unreviewed fix for Windows bots.

r74270 removed the windows specific result for extend-selection-home-end.html
since it was matching the cross platform expectation result. However, when there is
no win specific test result but there is a mac one for the same test, the later
is picked before the cross platform one.

platform/win/editing/selection/extend-selection-home-end-expected.txt: Added.

10:58 AM Changeset in webkit [74279] by rniwa@webkit.org

2 edits
1 add
4 deletes in trunk/LayoutTests

2010-12-17 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Antonio Gomes.

editing/execCommand/toggle-compound-styles-expected should use LayoutTestController::setEditingBehavior
https://bugs.webkit.org/show_bug.cgi?id=51261

Modified the test to run each test case using each editing behavior, eliminating the need for
platform-specific expected results.

editing/execCommand/script-tests/toggle-compound-styles.js: (testSingleToggle):
platform/gtk/editing/execCommand/toggle-compound-styles-expected.txt: Removed.
platform/mac/editing/execCommand/toggle-compound-styles-expected.txt: Removed.
platform/qt/editing/execCommand/toggle-compound-styles-expected.txt: Removed.
platform/win/editing/execCommand/toggle-compound-styles-expected.txt: Removed.

10:56 AM Changeset in webkit [74278] by commit-queue@webkit.org

3 edits in trunk/WebCore

2010-12-17 W. James MacLean <wjmaclean@chromium.org>

Reviewed by James Robinson.

[chromium] Add support to compositor to composite to offscreen texture.
https://bugs.webkit.org/show_bug.cgi?id=50833

A patch to extend compositor to be able to composite into an offscreen texture instead
of just directly to the display buffer. Builds on RenderSurfaceChromium support.

External behaviour not changed, so no tests.

platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::prepareToDrawLayers): (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::setCompositeOffscreen): (WebCore::LayerRendererChromium::useRenderSurface): (WebCore::LayerRendererChromium::setScissorToRect):
platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::isCompositingOffscreen): (WebCore::LayerRendererChromium::getOffscreenLayerTexture):

10:37 AM Changeset in webkit [74277] by ojan@chromium.org

2 edits in trunk/BugsSite

2010-12-17 Ojan Vafai <ojan@chromium.org>

Increment psuedo-version number to avoid pulling cached version.

PrettyPatch/PrettyPatch.rb:

10:33 AM Changeset in webkit [74276] by ojan@chromium.org

3 edits in trunk/BugsSite

2010-12-17 Ojan Vafai <ojan@chromium.org>

Speculative fix for the code review tool in Firefox.
Fixes a JS error and makes the status bubble mostly work
if postMessage is not supported.

PrettyPatch/PrettyPatch.rb:
code-review.js:

9:57 AM Changeset in webkit [74275] by Darin Adler

9 edits in trunk/WebKit2

2010-12-16 Darin Adler <Darin Adler>

Reviewed by Maciej Stachowiak.

Add text encoding menu API for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=51226

UIProcess/API/C/WKPage.cpp: (WKPageSupportsTextEncoding): Added. (WKPageCopyCustomTextEncodingName): Added. (WKPageSetCustomTextEncodingName): Added.
UIProcess/API/C/WKPage.h: Added the functions above.

UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::WebPageProxy): Initialize m_mainFrameHasCustomRepresentation to false. (WebKit::WebPageProxy::supportsTextEncoding): Added. (WebKit::WebPageProxy::setCustomTextEncodingName): Added. (WebKit::WebPageProxy::didCommitLoadForFrame): Set m_mainFrameHasCustomRepresentation.

UIProcess/WebPageProxy.h: Added supportsTextEncoding, setCustomTextEncodingName, customTextEncodingName, and m_mainFrameHasCustomRepresentation.

UIProcess/WebPageProxy.messages.in: Tweaked formatting (added a blank line).

WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::setCustomTextEncodingName): Added.
WebProcess/WebPage/WebPage.h: Added setCustomTextEncodingName.

WebProcess/WebPage/WebPage.messages.in: Added the SetCustomTextEncodingName message. Tweaked formatting of the dummy message.

9:37 AM Changeset in webkit [74274] by commit-queue@webkit.org

2 edits in trunk/WebKit/chromium

2010-12-17 John Knottenbelt <jknotten@chromium.org>

Reviewed by Jeremy Orlow.

Fix test failures where NULL GeolocationClient is provided
https://bugs.webkit.org/show_bug.cgi?id=51256

src/GeolocationClientProxy.cpp: (WebKit::GeolocationClientProxy::geolocationDestroyed):

9:12 AM Changeset in webkit [74273] by tonikitoo@webkit.org

2 edits in trunk/LayoutTests

2010-12-17 Antonio Gomes <agomes@rim.com>

Unreviewed expectation result update.

editing/execCommand/toggle-compound-styles.html needs new expected results after r74269.

Default editing behavior of GTK+ DRT was changed from Mac to Unix, and this test is wrongly
going through platform specific editing behavior code path without making calls to
LayoutTestController::setEditingBehavior. Filed bug 51261 for the proper fix.

platform/gtk/editing/execCommand/toggle-compound-styles-expected.txt:

8:43 AM Changeset in webkit [74272] by ariya@webkit.org

2 edits in trunk/WebCore

2010-12-17 Ariya Hidayat <ariya@sencha.com>

Reviewed by Andreas Kling.

[Qt] Default image interpolation should reset the render hint
https://bugs.webkit.org/show_bug.cgi?id=51233

Save initial SmoothPixmapTransform render hint so that it can be used
with default image interpolation quality to reset back the render hints.

platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::setImageInterpolationQuality):

8:26 AM Changeset in webkit [74271] by ariya@webkit.org

2 edits in trunk/WebKit/qt

2010-12-17 Ariya Hidayat <ariya@sencha.com>

Reviewed by Antonio Gomes.

[Qt] GraphicsContext should respect QWebView render hints
https://bugs.webkit.org/show_bug.cgi?id=51208

Adjust the test since SmoothPixmapTransform is set by default.

tests/qwebview/tst_qwebview.cpp: (tst_QWebView::renderHints):

8:16 AM Changeset in webkit [74270] by tonikitoo@webkit.org

5 edits
2 moves in trunk

2010-12-05 Antonio Gomes <agomes@rim.com>

Reviewed by Ariya Hidayat.

[Qt] Fix caret browsing navigation mode
https://bugs.webkit.org/show_bug.cgi?id=50536

WebKit/qt:

Caret browsing can consume editing commands even when the start
of current selection is not a editable content. r69582 missed this
case because caret browsing feature testing is very poor today.

This commit reintroduces part of the removed code in r69582 but
guarded by a isCaretBrowsingEnabled() check. No regression found.

WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleKeyboardEvent):

LayoutTests:

/platform/gtk/editing/selection/caret-mode-paragraph-keys-navigation.html
is one of the few tests actually tests the caret browsing feature.
Patch makes the test not Gtk+ specific, and Qt now passes on it.

editing/selection/caret-mode-paragraph-keys-navigation-expected.txt: Renamed from LayoutTests/platform/gtk/editing/selection/caret-mode-paragraph-keys-navigation-expected.tx t.
editing/selection/caret-mode-paragraph-keys-navigation.html: Renamed from LayoutTests/platform/gtk/editing/selection/caret-mode-paragraph-keys-navigation.html.
fast/events/multiline-link-arrow-navigation.html:

8:15 AM Changeset in webkit [74269] by tonikitoo@webkit.org

3 edits
2 deletes in trunk

2010-12-16 Antonio Gomes <agomes@rim.com>

Reviewed by Martin Robinson.

Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
https://bugs.webkit.org/show_bug.cgi?id=51163

WebKitTools:
Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
GTK+'s DRT should also reset to UNIX after each test execution.

DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):

LayoutTests:
Removed platform specific expected result files for gtk and windows
for editing/selection/extend-selection-home-end.html, since they all match
the cross platform result file.

Note: chromium-win and mac still have their own expected file each.

platform/gtk/editing/selection/extend-selection-home-end-expected.txt: Removed.
platform/win/editing/selection/extend-selection-home-end-expected.txt: Removed.

7:54 AM Changeset in webkit [74268] by commit-queue@webkit.org

2 edits in trunk/WebKit2

2010-12-17 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r74201.
http://trac.webkit.org/changeset/74201
https://bugs.webkit.org/show_bug.cgi?id=51248

It broke ~6000 layout tests (Requested by Ossy_ on #webkit).

UIProcess/API/qt/qgraphicswkview.cpp: (QGraphicsWKView::setGeometry): (QGraphicsWKView::itemChange):

7:48 AM BuildingOnWindows edited by Adam Roben

Update the rebase instructions (diff)

7:11 AM Changeset in webkit [74267] by yurys@chromium.org

2 edits in trunk/LayoutTests

2010-12-17 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Remove custom expectations for fast/js/regexp-ranges-and-escaped-hyphens.html

platform/chromium/test_expectations.txt:

7:10 AM Changeset in webkit [74266] by hans@chromium.org

12 edits in trunk

2010-12-17 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Support Date objects as keys.
https://bugs.webkit.org/show_bug.cgi?id=51193

Update layout tests to check that having Date objects as keys work.

storage/indexeddb/objectstore-basics-expected.txt:
storage/indexeddb/objectstore-basics.html:

2010-12-17 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Support Date objects as keys.
https://bugs.webkit.org/show_bug.cgi?id=51193

bindings/v8/IDBBindingUtilities.cpp: (WebCore::createIDBKeyFromValue): Use the new IDBKey factory functions, and support Date objects.
bindings/v8/custom/V8IDBKeyCustom.cpp: (WebCore::toV8): Create Date objects from DateType keys.
storage/IDBKey.cpp: (WebCore::IDBKey::fromQuery): (WebCore::IDBKey::isEqual): (WebCore::IDBKey::whereSyntax): (WebCore::IDBKey::lowerCursorWhereFragment): (WebCore::IDBKey::upperCursorWhereFragment): (WebCore::IDBKey::bind): (WebCore::IDBKey::bindWithNulls): Update all SQL related functions to handle Date keys.
storage/IDBKey.h: (WebCore::IDBKey::createNull): (WebCore::IDBKey::createNumber): (WebCore::IDBKey::createString): (WebCore::IDBKey::createDate): Rename the create factories; since both number and date is just a double, function overloading can't be used to discriminate between the factories. (WebCore::IDBKey::date): Add getter for the date value.

2010-12-17 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Support Date objects as keys.
https://bugs.webkit.org/show_bug.cgi?id=51193

Update to match the underlying WebCore IDBKey class:
add the DateType, add create() functions for each type,
deprecate the public constructors (will be removed once
Chromium side is updated).

public/WebIDBKey.h: (WebKit::WebIDBKey::WebIDBKey):
src/AssertMatchingEnums.cpp:
src/WebIDBKey.cpp: (WebKit::WebIDBKey::createString): (WebKit::WebIDBKey::createDate): (WebKit::WebIDBKey::createNumber): (WebKit::WebIDBKey::assignNull): (WebKit::WebIDBKey::assignString): (WebKit::WebIDBKey::assignDate): (WebKit::WebIDBKey::assignNumber): (WebKit::WebIDBKey::date):

7:05 AM Changeset in webkit [74265] by pfeldman@chromium.org

2 edits in branches/chromium/597/WebCore/inspector/front-end

Merge 74261 - 2010-12-17 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add scripts parsed after resource load to SourceFrame.
https://bugs.webkit.org/show_bug.cgi?id=51243

inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._addScript):
inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.addScript):

TBR=podivilov@chromium.org
BUG=74261

Review URL: http://codereview.chromium.org/5997002

6:58 AM Changeset in webkit [74264] by pfeldman@chromium.org

2 edits in branches/chromium/597/WebCore/inspector/front-end

Merge 74253 - 2010-12-17 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [REGRESSION] Cmd (Ctrl) + G does not search next in Scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=50893

Now Mac shortcuts are:

Cmd F/G = find / next
Cmd L = go to line

Win/Linux:

Ctrl+G = go to line

inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._registerShortcuts):
inspector/front-end/inspector.js: (WebInspector._registerShortcuts):

TBR=pfeldman@chromium.org
BUG=67282

Review URL: http://codereview.chromium.org/6006001

6:55 AM Changeset in webkit [74263] by sergio@webkit.org

2 edits in trunk/LayoutTests

2010-12-17 Sergio Villar Senin <svillar@igalia.com>

Unreviewed, tests were skipped due to a bug in libsoup
https://bugzilla.gnome.org/show_bug.cgi?id=631679. Now that it was
fixed we can safely unskip them again.

[GTK] Failing http/tests/xmlhttprequest tests
https://bugs.webkit.org/show_bug.cgi?id=30582

platform/gtk/Skipped:

6:51 AM Changeset in webkit [74262] by pfeldman@chromium.org

1 edit in branches/chromium/597/WebCore/inspector/front-end/ResourceManager.js

Merge 74259 - 2010-12-17 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] scripts in scripts panel are not updated on reload.
https://bugs.webkit.org/show_bug.cgi?id=51101

inspector/front-end/ResourceManager.js: (WebInspector.ResourceTreeModel.prototype.didCommitLoadForFrame):

TBR=podivilov@chromium.org
BUG=67313

Review URL: http://codereview.chromium.org/6005001

6:47 AM Changeset in webkit [74261] by podivilov@chromium.org

3 edits in trunk/WebCore

2010-12-17 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add scripts parsed after resource load to SourceFrame.
https://bugs.webkit.org/show_bug.cgi?id=51243

inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._addScript):
inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.addScript):

6:39 AM Changeset in webkit [74260] by antonm@chromium.org

2 edits in trunk/WebCore

2010-12-17 Anton Muhin <antonm@chromium.org>

Reviewed by Yury Semikhatsky.

[v8] The last portion of CSS GC work: fixing fast/dom/StyleSheet/gc-stylesheet-wrapper.html
https://bugs.webkit.org/show_bug.cgi?id=51121

Properly group style elements of HTML links, style elements and processing instructions.

bindings/v8/V8GCController.cpp: (WebCore::NodeGrouperVisitor::visitDOMWrapper): (WebCore::NodeGrouperVisitor::addDOMObjectToGroup):

6:37 AM Changeset in webkit [74259] by podivilov@chromium.org

2 edits in trunk/WebCore

2010-12-17 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] scripts in scripts panel are not updated on reload.
https://bugs.webkit.org/show_bug.cgi?id=51101

inspector/front-end/ResourceManager.js: (WebInspector.ResourceTreeModel.prototype.didCommitLoadForFrame):

6:33 AM Changeset in webkit [74258] by tkent@chromium.org

2 edits in trunk/LayoutTests

2010-12-17 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

platform/chromium/test_expectations.txt: Collect and correct failures about vertical writing.

6:15 AM Changeset in webkit [74257] by benjamin.poulain@nokia.com

2 edits in trunk/WebCore

2010-12-17 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Laszlo Gombos.

The inspector does not compile without JAVASCRIPT_DEBUGGER
https://bugs.webkit.org/show_bug.cgi?id=51246

Fix the build, m_extraHeaders does not depend on JAVASCRIPT_DEBUGGER.

inspector/InspectorController.h:

5:52 AM Changeset in webkit [74256] by caseq@chromium.org

2 edits in trunk/WebCore

2010-12-17 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: clear extra/override headers when front-end is closed
https://bugs.webkit.org/show_bug.cgi?id=51244

inspector/InspectorController.cpp: (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::willSendRequest):

5:15 AM Changeset in webkit [74255] by levin@chromium.org

3 edits in trunk/WebKitTools

2010-12-17 David Levin <levin@chromium.org>

Reviewed by Eric Seidel.

check-webkit-style should understand WTF #include guards
https://bugs.webkit.org/show_bug.cgi?id=44911

Scripts/webkitpy/style/checkers/cpp.py: (get_header_guard_cpp_variable): modify to suggest the WTF style of header guard when appropriate. (check_for_header_guard): handle multiple return values from get_header_guard_cpp_variable
Scripts/webkitpy/style/checkers/cpp_unittest.py: (CppStyleTest.test_build_header_guard): Added tests for the WTF header style.

5:07 AM Changeset in webkit [74254] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

Unreviewed.

[Qt] Web Timing related bugs
https://bugs.webkit.org/show_bug.cgi?id=51245

platform/qt/Skipped: http/tests/misc/webtiming-ssl.php added until fix.

4:52 AM Changeset in webkit [74253] by pfeldman@chromium.org

3 edits in trunk/WebCore

2010-12-17 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [REGRESSION] Cmd (Ctrl) + G does not search next in Scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=50893

Now Mac shortcuts are:

Cmd F/G = find / next
Cmd L = go to line

Win/Linux:

Ctrl+G = go to line

inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._registerShortcuts):
inspector/front-end/inspector.js: (WebInspector._registerShortcuts):

4:50 AM Changeset in webkit [74252] by yurys@chromium.org

2 edits in trunk/LayoutTests

2010-12-17 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

platform/chromium/test_expectations.txt:

4:46 AM Changeset in webkit [74251] by sergio@webkit.org

2 edits in trunk/WebCore

2010-12-16 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Martin Robinson.

Wrong check in ResourceHandleSoup in error cases
https://bugs.webkit.org/show_bug.cgi?id=51171

Calling didReceiveData with no data causes a crash in debug
builds. Checking for soupMsg->response_body->data is not correct as libsoup
always creates a buffer for that. Instead we should check for
soupMsg->response_body->length

platform/network/soup/ResourceHandleSoup.cpp: (WebCore::sendRequestCallback):

4:27 AM Changeset in webkit [74250] by sergio@webkit.org

2 edits in trunk/LayoutTests

2010-12-17 Sergio Villar Senin <svillar@igalia.com>

Unreviewed, skipping a failing test in the bots.

[GTK] fast/dom/global-constructors.html failing on bots
https://bugs.webkit.org/show_bug.cgi?id=51242

platform/gtk/Skipped:

4:19 AM Changeset in webkit [74249] by yurys@chromium.org

2 edits in trunk/LayoutTests

2010-12-17 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Fix typo in Chromium test expectations.

platform/chromium/test_expectations.txt:

4:05 AM Changeset in webkit [74248] by andreas.kling@nokia.com

2 edits in trunk/WebCore

2010-12-17 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Avoid unnecessary calls to GraphicsContextPlatformPrivate::p()
https://bugs.webkit.org/show_bug.cgi?id=49954

platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::pushTransparencyLayerInternal): (WebCore::GraphicsContext::beginTransparencyLayer):

3:24 AM Changeset in webkit [74247] by mrowe@apple.com

20 edits in tags/Safari-534.15

Revert some changes to work around <rdar://problem/8771085>.

3:13 AM Changeset in webkit [74246] by xan@webkit.org

2 edits in trunk/WebCore

2010-12-17 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Compile warning introduced in r74129
https://bugs.webkit.org/show_bug.cgi?id=51181

platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::gtkContainer):

3:05 AM Changeset in webkit [74245] by mrowe@apple.com

5 edits in trunk

Versioning.

3:04 AM Changeset in webkit [74244] by mrowe@apple.com

1 copy in tags/Safari-534.15

New tag.

2:51 AM Changeset in webkit [74243] by commit-queue@webkit.org

4 edits in trunk/WebKit/qt

2010-12-17 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QWebPage sends out a RequestSoftwareInputPanel event
incorrectly in particular case
https://bugs.webkit.org/show_bug.cgi?id=50419

Add HitTestResult check before firing RequestSoftwareInputPanel event.

Api/qwebpage.cpp: (QWebPagePrivate::mouseReleaseEvent): (QWebPagePrivate::handleSoftwareInputPanel):
Api/qwebpage_p.h:
tests/qwebpage/tst_qwebpage.cpp: (clickOnPage): (tst_QWebPage::inputMethods):

2:37 AM Changeset in webkit [74242] by commit-queue@webkit.org

13 edits
3 adds in trunk

2010-12-17 James Simonsen <simonjam@chromium.org>

Reviewed by Darin Fisher.

[Web Timing] Add sslHandshakeStart to interface

https://bugs.webkit.org/show_bug.cgi?id=50400

fast/dom/Window/window-properties-performance-expected.txt: Added sslHandshakeStart.
fast/dom/script-tests/webtiming.js: Ditto. (checkTimingBeforeLoad): (checkTimingWhileDeferred): (checkWebTimingOnDOMContentLoaded): (checkWebTimingWhileAsync): (checkWebTimingOnLoad): (checkWebTimingAfterLoad):
fast/dom/webtiming-document-open-expected.txt: Ditto.
fast/dom/webtiming-expected.txt: Ditto.
fast/dom/webtiming-navigate-within-document-expected.txt: Ditto.
http/tests/misc/resources/webtiming-ssl.html: Added.
http/tests/misc/webtiming-ssl-expected.txt: Added.
http/tests/misc/webtiming-ssl.php: Added.
platform/gtk/Skipped: WebTiming disabled here.
platform/mac/Skipped: Ditto.
platform/win/Skipped: Ditto.

2010-12-17 James Simonsen <simonjam@chromium.org>

Reviewed by Darin Fisher.

[Web Timing] Add sslHandshakeStart to interface

https://bugs.webkit.org/show_bug.cgi?id=50400

Test: http/tests/misc/webtiming-ssl.php

page/PerformanceTiming.cpp: (WebCore::PerformanceTiming::connectStart): Update comment. (WebCore::PerformanceTiming::connectEnd): Remove SSL time. (WebCore::PerformanceTiming::sslHandshakeStart): Added.
page/PerformanceTiming.h: Added sslHandshakeStart.
page/PerformanceTiming.idl: Ditto.

2:19 AM Changeset in webkit [74241] by commit-queue@webkit.org

8 edits in trunk

2010-12-17 James Simonsen <simonjam@chromium.org>

Reviewed by Darin Fisher.

[Web Timing] Navigation type enums should begin with TYPE_
https://bugs.webkit.org/show_bug.cgi?id=51200

fast/dom/Window/window-properties-performance-expected.txt: Added TYPE_ to navigation types and added TYPE_RESERVED.

2010-12-17 James Simonsen <simonjam@chromium.org>

Reviewed by Darin Fisher.

[Web Timing] Navigation type enums should begin with TYPE_
https://bugs.webkit.org/show_bug.cgi?id=51200

page/PerformanceNavigation.cpp: (WebCore::PerformanceNavigation::type): Added TYPE_ to navigation types.
page/PerformanceNavigation.h: Ditto and added TYPE_RESERVED.
page/PerformanceNavigation.idl: Ditto.

2010-12-17 James Simonsen <simonjam@chromium.org>

Reviewed by Darin Fisher.

[Web Timing] Navigation type enums should begin with TYPE_
https://bugs.webkit.org/show_bug.cgi?id=51200

src/WebPerformance.cpp: (WebKit::WebPerformance::navigationType): Added TYPE_ to navigation types.

2:05 AM Changeset in webkit [74240] by steveblock@google.com

2 edits in trunk/WebCore

Fix build with Geolocation disabled.

1:48 AM Changeset in webkit [74239] by caseq@chromium.org

3 edits in trunk/LayoutTests

2010-12-17 Andrey Kosyakov <caseq@chromium.org>

Unreviewed test fix: removed real user agent from test expectations.

http/tests/inspector/extensions-headers-expected.txt:
http/tests/inspector/extensions-headers.html:

1:17 AM Changeset in webkit [74238] by Patrick Gansterer

2 edits in trunk/WebCore

2010-12-17 Patrick Gansterer <Patrick Gansterer>

Unreviewed. WinCE build fix.

platform/graphics/GraphicsContext.h:

1:13 AM Changeset in webkit [74237] by caseq@chromium.org

3 edits in trunk/LayoutTests

2010-12-17 Andrey Kosyakov <caseq@chromium.org>

Unreviewed. Clean up extra headers set in test to avoid side effects on other tests.

http/tests/inspector/extensions-headers-expected.txt:
http/tests/inspector/extensions-headers.html:

12:29 AM Changeset in webkit [74236] by loislo@chromium.org

5 edits
1 delete in trunk/WebCore

2010-12-17 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: remove unnecessary dependencies from InspectorBackendStub.

InspectorBackendStub is a transport-only thing but it has dependencies with
Callback.js and WebInspector namespace. Callback can be integrated into
InspectorBackendStub because it is the only client.
Without these dependencies InspectorBackendStub can be used as an API
wrapper for Inspector Protocol.

https://bugs.webkit.org/show_bug.cgi?id=51184

WebCore.gypi:
inspector/CodeGeneratorInspector.pm:
inspector/front-end/Callback.js: Removed.
inspector/front-end/WebKit.qrc:
inspector/front-end/inspector.html:

12:23 AM Changeset in webkit [74235] by eric@webkit.org

5 edits
2 moves in trunk

2010-12-17 Eric Seidel <eric@webkit.org>

Unreviewed, rolling out r74229.
http://trac.webkit.org/changeset/74229
https://bugs.webkit.org/show_bug.cgi?id=50536

Broken on Snow Leopard and possibly other platforms

platform/gtk/editing/selection/caret-mode-paragraph-keys-navigation-expected.txt: Renamed from LayoutTests/editing/selection/caret-mode-paragraph-keys-navigation-expected.txt.
platform/gtk/editing/selection/caret-mode-paragraph-keys-navigation.html: Renamed from LayoutTests/editing/selection/caret-mode-paragraph-keys-navigation.html.
platform/mac/Skipped:
platform/win/Skipped:

2010-12-17 Eric Seidel <eric@webkit.org>

Unreviewed, rolling out r74229.
http://trac.webkit.org/changeset/74229
https://bugs.webkit.org/show_bug.cgi?id=50536

Broken on Snow Leopard and possibly other platforms

WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleKeyboardEvent):

12:22 AM Changeset in webkit [74234] by caseq@chromium.org

17 edits
5 moves
3 adds in trunk

2010-12-15 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Extension API] add support for adding/overriding HTTP request headers
https://bugs.webkit.org/show_bug.cgi?id=50493

Test: http/tests/inspector/extensions-headers.html

inspector/Inspector.idl:
inspector/InspectorController.cpp: (WebCore::InspectorController::willSendRequest): Apply extra headers. (WebCore::InspectorController::setExtraHeaders):
inspector/InspectorController.h:
inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI.Resources.prototype.getHAR): (WebInspector.injectedExtensionAPI.Resources.prototype.addRequestHeaders):
inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer): (WebInspector.ExtensionServer.prototype._onAddRequestHeaders):

2010-12-15 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Extension API] add support for adding/overriding HTTP request headers
Moved extensions test frameworks under http/tests/inspector, so HTTP tests may reuse it.
https://bugs.webkit.org/show_bug.cgi?id=50493

http/tests/inspector/extensions-headers-expected.txt: Added.
http/tests/inspector/extensions-headers.html: Added.
http/tests/inspector/extensions-test.js: Renamed from LayoutTests/inspector/extensions-test.js. (log): (extensionFunctions): (initialize_ExtensionsTest.InspectorTest.dispatchOnMessage): (initialize_ExtensionsTest.InspectorTest.runExtensionTests): (initialize_ExtensionsTest.extensionOutput): (initialize_ExtensionsTest.dumpSidebarContent): (initialize_ExtensionsTest.reloadPage): (test):
http/tests/inspector/resources/echo-headers.php: Added.
http/tests/inspector/resources/extension-main.html: Renamed from LayoutTests/inspector/resources/extension-main.html.
http/tests/inspector/resources/extension-main.js: Renamed from LayoutTests/inspector/resources/extension-main.js. (fetchTests.callback): (fetchTests): (runTests): (onTestsDone): (dispatchOnFrontend.callbackWrapper): (dispatchOnFrontend): (callbackAndNextTest.callbackWrapper): (callbackAndNextTest):
http/tests/inspector/resources/extension-panel.html: Renamed from LayoutTests/inspector/resources/extension-panel.html.
http/tests/inspector/resources/extension-sidebar.html: Renamed from LayoutTests/inspector/resources/extension-sidebar.html.
inspector/extensions-api-expected.txt:
inspector/extensions-api.html:
inspector/extensions-audits-api.html:
inspector/extensions-audits.html:
inspector/extensions-eval.html:
inspector/extensions-events.html:
inspector/extensions-resources-expected.txt:
inspector/extensions-resources.html:
inspector/extensions.html:
platform/chromium/test_expectations.txt:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed