Timeline
Dec 19, 2010:
- 10:44 PM Changeset in webkit [74332] by
-
- 6 edits1 move in trunk
Move WebKitExamplePlugins to Examples
https://bugs.webkit.org/show_bug.cgi?id=51291
Reviewed by Sam Weinig.
.:
- Examples: Copied from WebKitExamplePlugins.
- WebKitExamplePlugins: Removed.
- WebKitExamplePlugins/NetscapeCocoaPlugin: Removed.
- WebKitExamplePlugins/NetscapeCocoaPlugin/English.lproj: Removed.
- WebKitExamplePlugins/NetscapeCocoaPlugin/English.lproj/InfoPlist.strings: Removed.
- WebKitExamplePlugins/NetscapeCocoaPlugin/Info.plist: Removed.
- WebKitExamplePlugins/NetscapeCocoaPlugin/MenuHandler.h: Removed.
- WebKitExamplePlugins/NetscapeCocoaPlugin/MenuHandler.m: Removed.
- WebKitExamplePlugins/NetscapeCocoaPlugin/NetscapeCocoaPlugin.xcodeproj: Removed.
- WebKitExamplePlugins/NetscapeCocoaPlugin/NetscapeCocoaPlugin.xcodeproj/project.pbxproj: Removed.
- WebKitExamplePlugins/NetscapeCocoaPlugin/main.m: Removed.
- WebKitExamplePlugins/NetscapeCocoaPlugin/test.html: Removed.
- WebKitExamplePlugins/NetscapeCoreAnimationMoviePlugin: Removed.
- WebKitExamplePlugins/NetscapeCoreAnimationMoviePlugin/English.lproj: Removed.
- WebKitExamplePlugins/NetscapeCoreAnimationMoviePlugin/English.lproj/InfoPlist.strings: Removed.
- WebKitExamplePlugins/NetscapeCoreAnimationMoviePlugin/Info.plist: Removed.
- WebKitExamplePlugins/NetscapeCoreAnimationMoviePlugin/MovieControllerLayer.h: Removed.
- WebKitExamplePlugins/NetscapeCoreAnimationMoviePlugin/MovieControllerLayer.m: Removed.
- WebKitExamplePlugins/NetscapeCoreAnimationMoviePlugin/NetscapeCoreAnimationMoviePlugin.xcodeproj: Removed.
- WebKitExamplePlugins/NetscapeCoreAnimationMoviePlugin/NetscapeCoreAnimationMoviePlugin.xcodeproj/project.pbxproj: Removed.
- WebKitExamplePlugins/NetscapeCoreAnimationMoviePlugin/Pause.tiff: Removed.
- WebKitExamplePlugins/NetscapeCoreAnimationMoviePlugin/Play.tiff: Removed.
- WebKitExamplePlugins/NetscapeCoreAnimationMoviePlugin/SliderTrackCenter.tiff: Removed.
- WebKitExamplePlugins/NetscapeCoreAnimationMoviePlugin/SliderTrackLeft.tiff: Removed.
- WebKitExamplePlugins/NetscapeCoreAnimationMoviePlugin/SliderTrackRight.tiff: Removed.
- WebKitExamplePlugins/NetscapeCoreAnimationMoviePlugin/Thumb.tiff: Removed.
- WebKitExamplePlugins/NetscapeCoreAnimationMoviePlugin/main.m: Removed.
- WebKitExamplePlugins/NetscapeCoreAnimationMoviePlugin/test.html: Removed.
- WebKitExamplePlugins/NetscapeCoreAnimationPlugin: Removed.
- WebKitExamplePlugins/NetscapeCoreAnimationPlugin/Composition.qtz: Removed.
- WebKitExamplePlugins/NetscapeCoreAnimationPlugin/English.lproj: Removed.
- WebKitExamplePlugins/NetscapeCoreAnimationPlugin/English.lproj/InfoPlist.strings: Removed.
- WebKitExamplePlugins/NetscapeCoreAnimationPlugin/Info.plist: Removed.
- WebKitExamplePlugins/NetscapeCoreAnimationPlugin/NetscapeCoreAnimationPlugin.xcodeproj: Removed.
- WebKitExamplePlugins/NetscapeCoreAnimationPlugin/NetscapeCoreAnimationPlugin.xcodeproj/project.pbxproj: Removed.
- WebKitExamplePlugins/NetscapeCoreAnimationPlugin/main.m: Removed.
- WebKitExamplePlugins/NetscapeCoreAnimationPlugin/test.html: Removed.
- WebKitExamplePlugins/NetscapeInputMethodPlugin: Removed.
- WebKitExamplePlugins/NetscapeInputMethodPlugin/English.lproj: Removed.
- WebKitExamplePlugins/NetscapeInputMethodPlugin/English.lproj/InfoPlist.strings: Removed.
- WebKitExamplePlugins/NetscapeInputMethodPlugin/Info.plist: Removed.
- WebKitExamplePlugins/NetscapeInputMethodPlugin/NetscapeInputMethodPlugin.xcodeproj: Removed.
- WebKitExamplePlugins/NetscapeInputMethodPlugin/NetscapeInputMethodPlugin.xcodeproj/project.pbxproj: Removed.
- WebKitExamplePlugins/NetscapeInputMethodPlugin/main.m: Removed.
- WebKitExamplePlugins/NetscapeInputMethodPlugin/test.html: Removed.
- cmake/WebKitPackaging.cmake:
BugsSite:
- PrettyPatch/PrettyPatch.rb:
Tools:
- Scripts/webkitpy/common/config/build.py:
- 9:24 PM Changeset in webkit [74331] by
-
- 2 edits1 delete in trunk/LayoutTests
2010-12-19 Benjamin Kalman <kalman@chromium.org>
Reviewed by Antonio Gomes.
[chromium] editing/selection/extend-selection-home-end.html should have one expected result
https://bugs.webkit.org/show_bug.cgi?id=49873
Change 100px to 5em in editing/selection/extend-selection-home-end.html so that chromium
results are the same as the non-chromium results.
- editing/selection/resources/extend-selection.js: Change 100px to 5em.
- platform/chromium-win/editing/selection/extend-selection-home-end-expected.txt: Removed.
- 7:05 PM Changeset in webkit [74330] by
-
- 2 edits in trunk/WebKit2
Improve the fix for <rdar://problem/8769525>.
Reviewed by Sam Weinig.
- UIProcess/API/mac/WKView.mm:
(-[WKView performKeyEquivalent:]): Do not retain the view. Doing so is necessary in
-[WebHTMLView performKeyEquivalent:], which this method was based upon, but not here, because
there is no way for the web process to cause the WKView to be released while it is handling
the event.
- 6:42 PM Changeset in webkit [74329] by
-
- 2 edits in trunk/WebKit2
<rdar://problem/8769525> WKView leak when performing key equivalents
https://bugs.webkit.org/show_bug.cgi?id=51315
Reviewed by Sam Weinig.
- UIProcess/API/mac/WKView.mm:
(-[WKView performKeyEquivalent:]): Use a RetainPtr to ensure that the view is released in the
early return code path.
- 5:02 PM Changeset in webkit [74328] by
-
- 8 edits3 adds in trunk
2010-12-19 Helder Correia <helder@sencha.com>
Reviewed by Ariya Hidayat.
[Qt] Blur distance should not be affected by transformations
https://bugs.webkit.org/show_bug.cgi?id=51161
From the spec at http://dev.w3.org/html5/2dcontext/#dom-context-2d-shadowblur:
"The shadowBlur attribute specifies the level of the blurring effect.
(The units do not map to coordinate space units, and are not affected
by the current transformation matrix.)"
Add test to ensure that the blur radius is not affected by the CTM.
- fast/canvas/canvas-scale-shadowBlur-expected.txt: Added.
- fast/canvas/canvas-scale-shadowBlur.html: Added.
- fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Increase shadowBlur and test tolerance to ease testing and support the different blurring algorithms.
- fast/canvas/script-tests/canvas-scale-shadowBlur.js: Added.
- fast/canvas/script-tests/canvas-scale-strokePath-shadow.js:
2010-12-19 Helder Correia <helder@sencha.com>
Reviewed by Ariya Hidayat.
[Qt] Blur distance should not be affected by transformations
https://bugs.webkit.org/show_bug.cgi?id=51161
From the spec at http://dev.w3.org/html5/2dcontext/#dom-context-2d-shadowblur:
"The shadowBlur attribute specifies the level of the blurring effect.
(The units do not map to coordinate space units, and are not affected
by the current transformation matrix.)"
Test: fast/canvas/canvas-scale-shadowBlur.html
- platform/graphics/ContextShadow.cpp: (WebCore::ContextShadow::adjustBlurDistance):
- platform/graphics/ContextShadow.h:
- platform/graphics/cairo/ContextShadowCairo.cpp: (WebCore::ContextShadow::beginShadowLayer):
- platform/graphics/qt/ContextShadowQt.cpp: (WebCore::ContextShadow::beginShadowLayer):
- 1:34 PM Changeset in webkit [74327] by
-
- 2 edits in trunk/WebKit2
2010-12-19 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] [WK2] QWKPagePrivate::paint() does not need to save the graphics context
https://bugs.webkit.org/show_bug.cgi?id=51300
Remove the unnecessary save() and restore() on the QPainter.
- UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::paint):
- 1:29 PM Changeset in webkit [74326] by
-
- 3 edits8 adds in trunk
Text emphasis marks are not repainted correctly in flipped writing modes
https://bugs.webkit.org/show_bug.cgi?id=51307
Reviewed by Cameron Zwarich.
WebCore:
Tests: fast/repaint/text-emphasis-h.html
fast/repaint/text-emphasis-v.html
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::addTextBoxVisualOverflow): Added flippedness check.
LayoutTests:
- fast/repaint/text-emphasis-h-expected.checksum: Added.
- fast/repaint/text-emphasis-h-expected.png: Added.
- fast/repaint/text-emphasis-h-expected.txt: Added.
- fast/repaint/text-emphasis-h.html: Added.
- fast/repaint/text-emphasis-v-expected.checksum: Added.
- fast/repaint/text-emphasis-v-expected.png: Added.
- fast/repaint/text-emphasis-v-expected.txt: Added.
- fast/repaint/text-emphasis-v.html: Added.
- 10:44 AM Changeset in webkit [74325] by
-
- 6 edits in trunk/WebCore
2010-12-19 Rob Buis <rwlbuis@gmail.com>
Reviewed by Andreas Kling.
Remove m_drawsContents from RenderSVGContainer.h
https://bugs.webkit.org/show_bug.cgi?id=51305
Remove m_drawsContents, its getter and setter and the call
sites, since it has no effect anymore.
- WebCore.order:
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::RenderSVGContainer): (WebCore::RenderSVGContainer::paint):
- rendering/RenderSVGContainer.h:
- rendering/RenderSVGResourceContainer.h:
- rendering/SVGImageBufferTools.cpp: (WebCore::SVGImageBufferTools::renderSubtreeToImageBuffer):
- 9:24 AM Changeset in webkit [74324] by
-
- 4 edits in trunk/WebKit2
2010-12-19 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Andreas Kling.
[Qt] [WK2] Client are expected to render their own background for WebPages
https://bugs.webkit.org/show_bug.cgi?id=51296
Remove the rendering of the checkerboard from the tiled DrawingAreaProxy
- UIProcess/TiledDrawingAreaProxy.cpp: (WebKit::TiledDrawingAreaProxy::paint):
- UIProcess/TiledDrawingAreaTile.h:
- UIProcess/qt/TiledDrawingAreaTileQt.cpp:
- 7:57 AM Changeset in webkit [74323] by
-
- 2 edits in trunk/WebCore
2010-12-19 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
WebKit does not build with worker but without the javascript debugger
https://bugs.webkit.org/show_bug.cgi?id=51293
Add missing guard for calls depending on the debugger.
- inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::postWorkerNotificationToFrontend):
- 7:28 AM Changeset in webkit [74322] by
-
- 2 edits in trunk/WebKit2
2010-12-19 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] [WK2] Client are expected to render their own background for WebPages
https://bugs.webkit.org/show_bug.cgi?id=51296
Do not render a white background before rendering the page with DrawingAreaProxy.
- UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::paint):
Dec 18, 2010:
- 10:51 PM Changeset in webkit [74321] by
-
- 3 edits3 adds in trunk
2010-12-18 Tom Sepez <tsepez@chromium.org>
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=51055
Fix a null de-reference when an XML file contains a malformed entity
of the form "&:;".
- fast/parser/resources/xml-colon-entity.xml: Added.
- fast/parser/xml-colon-entity-expected.txt: Added.
- fast/parser/xml-colon-entity.html: Added.
2010-12-18 Tom Sepez <tsepez@chromium.org>
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=51055
Fix a null de-reference when an XML file contains a malformed entity
of the form "&:;".
Test: fast/parser/xml-colon-entity.html
- html/parser/HTMLEntitySearch.cpp: (WebCore::HTMLEntitySearch::advance):
- 10:50 PM BuildingQtOnOSX edited by
- WebKitTools -> Tools (diff)
- 10:48 PM BuildingQtOnLinux edited by
- WebKitTools -> Tools (diff)
- 10:48 PM BuildingQtOnSymbian edited by
- WebKitTools -> Tools (diff)
- 10:47 PM BuildingQtOnWindows edited by
- WebKitTools -> Tools (diff)
- 10:46 PM QtWebKitContrib edited by
- WebKitTools -> Tools (diff)
- 6:55 PM Changeset in webkit [74320] by
-
- 2 edits in trunk/WebCore
2010-12-18 Noel Gordon <noel.gordon@gmail.com>
Reviewed by David Levin.
[chromium] Simplify the PNG encoder.
https://bugs.webkit.org/show_bug.cgi?id=50905
Remove PNGEncoderState class - it was a proxy for the encoder output, and
that is a Vector<>, so just write into it directly using append() to make
use of Vector<>'s resize() smarts. Simplify the preMultipliedBGRAtoRGBA()
and encode() routines, replace the OwnArrayPtr<> with a Vector<>.
canvas.toDataURL("image/png") is covered by existing tests.
- platform/image-encoders/skia/PNGImageEncoder.cpp: (WebCore::writeOutput): Use a Vector<>, append() the encoded data to it. (WebCore::preMultipliedBGRAtoRGBA): simplified. (WebCore::PNGImageEncoder::encode): ditto.
- 3:32 PM Changeset in webkit [74319] by
-
- 5 edits in trunk
Text emphasis marks are not always included in the selection highlight
https://bugs.webkit.org/show_bug.cgi?id=51299
Reviewed by Cameron Zwarich.
WebCore:
Affects pixel results of fast/text/emphasis.html
Account for annotations in selectionTop() and selectionBottom().
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::selectionTop):
(WebCore::RootInlineBox::selectionBottom):
LayoutTests:
- platform/mac/fast/text/emphasis-expected.checksum:
- platform/mac/fast/text/emphasis-expected.png:
- 2:49 PM Changeset in webkit [74318] by
-
- 3 edits4 adds in trunk
In flipped writing modes, opposite text emphasis marks from adjacent lines overlap
https://bugs.webkit.org/show_bug.cgi?id=51298
Reviewed by Cameron Zwarich.
WebCore:
Test: fast/text/emphasis-overlap.html
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::beforeAnnotationsAdjustment): Changed + to -.
LayoutTests:
- fast/text/emphasis-overlap-expected.checksum: Added.
- fast/text/emphasis-overlap-expected.png: Added.
- fast/text/emphasis-overlap-expected.txt: Added.
- fast/text/emphasis-overlap.html: Added.
- 10:44 AM Changeset in webkit [74317] by
-
- 16 edits1 copy1 move1 add2 deletes in trunk
2010-12-18 Helder Correia <helder@sencha.com> and Martin Robinson <mrobinson@igalia.com>
Reviewed by Ariya Hidayat.
[Qt] Canvas shadow offset should not be affected by any transformation
https://bugs.webkit.org/show_bug.cgi?id=50422
On a canvas context, shadows are currently affected by all
transformations except scaling. According to the spec:
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#shadows
"The shadowOffsetX and shadowOffsetY attributes specify the distance
that the shadow will be offset in the positive horizontal and positive
vertical distance respectively. Their values are in coordinate space
units. They are not affected by the current transformation matrix."
NOTE: this applies only to canvas, not to box shadows.
Add new test to ensure that shadows are correctly transformed keeping
the relative offset to the shape.
- fast/canvas/canvas-scale-strokePath-shadow-expected.txt: See strokePath below.
- fast/canvas/canvas-transforms-fillRect-shadow-expected.txt: Added.
- fast/canvas/canvas-transforms-fillRect-shadow.html: Added.
- fast/canvas/script-tests/canvas-scale-fillPath-shadow.js:
- fast/canvas/script-tests/canvas-scale-fillRect-shadow.js:
- fast/canvas/script-tests/canvas-scale-strokePath-shadow.js: Now using a lineWidth > 1 to make it easier to test and more fair among all ports, since there can be different transformation smoothness or aliasing settings.
- fast/canvas/script-tests/canvas-transforms-fillRect-shadow.js: Added.
- platform/gtk/Skipped: GTK port needs to implement this feature.
- platform/gtk/fast/canvas/canvas-scale-fillPath-shadow-expected.txt: Removed.
- platform/gtk/fast/canvas/canvas-scale-fillRect-shadow-expected.txt: Removed.
- platform/gtk/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Removed.
2010-12-18 Helder Correia <helder@sencha.com> and Martin Robinson <mrobinson@igalia.com>
Reviewed by Ariya Hidayat.
[Qt] Canvas shadow offset should not be affected by any transformation
https://bugs.webkit.org/show_bug.cgi?id=50422
On a canvas context, shadows are currently affected by all
transformations except scaling. According to the spec:
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#shadows
"The shadowOffsetX and shadowOffsetY attributes specify the distance
that the shadow will be offset in the positive horizontal and positive
vertical distance respectively. Their values are in coordinate space
units. They are not affected by the current transformation matrix."
NOTE: this applies only to canvas, not to box shadows.
Test: fast/canvas/canvas-transforms-fillRect-shadow.html
- platform/graphics/ContextShadow.cpp: (WebCore::ContextShadow::ContextShadow): (WebCore::ContextShadow::calculateLayerBoundingRect):
- platform/graphics/ContextShadow.h: (WebCore::ContextShadow::setShadowsIgnoreTransforms): (WebCore::ContextShadow::shadowsIgnoreTransforms): (WebCore::ContextShadow::offset):
- platform/graphics/qt/ContextShadowQt.cpp: (WebCore::ContextShadow::beginShadowLayer): (WebCore::ContextShadow::endShadowLayer):
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::mustUseContextShadow): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::setPlatformShadow):
- 9:41 AM Changeset in webkit [74316] by
-
- 2 edits in trunk/WebCore
2010-12-18 Ariya Hidayat <ariya@sencha.com>
Reviewed by Andreas Kling.
[Qt] TransparencyLayer should inherit its container render hints
https://bugs.webkit.org/show_bug.cgi?id=51283
- platform/graphics/qt/TransparencyLayer.h: (WebCore::TransparencyLayer::TransparencyLayer):
- 1:23 AM Changeset in webkit [74315] by
-
- 15 edits in trunk
2010-12-18 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Laszlo Gombos.
[Web Timing] Rename domContentLoaded{Start,End}->domContentLoadedEvent{Start,End}
https://bugs.webkit.org/show_bug.cgi?id=50943
- fast/dom/Window/window-properties-performance-expected.txt:
- fast/dom/script-tests/webtiming.js: (checkTimingBeforeLoad): (checkTimingWhileDeferred): (checkWebTimingOnDOMContentLoaded): (checkWebTimingWhileAsync): (checkWebTimingOnLoad): (checkWebTimingAfterLoad):
- fast/dom/webtiming-document-open-expected.txt:
- fast/dom/webtiming-expected.txt:
- fast/dom/webtiming-navigate-within-document-expected.txt:
2010-12-18 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Laszlo Gombos.
[Web Timing] Rename domContentLoaded{Start,End}->domContentLoadedEvent{Start,End}
https://bugs.webkit.org/show_bug.cgi?id=50943
See: http://test.w3.org/webperf/specs/NavigationTiming/#nt-dom-content-event-start
- dom/Document.cpp: (WebCore::Document::finishedParsing):
- dom/DocumentTiming.h: (WebCore::DocumentTiming::DocumentTiming):
- page/PerformanceTiming.cpp: (WebCore::PerformanceTiming::domContentLoadedEventStart): (WebCore::PerformanceTiming::domContentLoadedEventEnd):
- page/PerformanceTiming.h:
- page/PerformanceTiming.idl:
2010-12-18 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Laszlo Gombos.
[Web Timing] Rename domContentLoaded{Start,End}->domContentLoadedEvent{Start,End}
https://bugs.webkit.org/show_bug.cgi?id=50943
Exposes all dom* times to the chromium port. I'm particularly interested in
domContentLoadedEventEnd as it compares to the FinishDoc metric.
- public/WebPerformance.h:
- src/WebPerformance.cpp: (WebKit::WebPerformance::domLoading): (WebKit::WebPerformance::domInteractive): (WebKit::WebPerformance::domContentLoadedEventStart): (WebKit::WebPerformance::domContentLoadedEventEnd): (WebKit::WebPerformance::domComplete):
