Context Navigation

← Previous Period
Next Period →

Timeline

Dec 25, 2010:

9:05 PM Changeset in webkit [74664] by kbr@google.com

3 edits in trunk/LayoutTests

2010-12-25 Kenneth Russell <kbr@google.com>

Unreviewed, Chromium test expectations update.

platform/chromium-gpu/test_expectations.txt: Win Debug: Marked compositing/tiling/huge-layer-img.html as TIMEOUT. Marked fast/canvas/webgl/gl-object-get-calls.html as a flaky crash.
platform/chromium/test_expectations.txt: Adjusted expectations for the following tests: fast/canvas/shadow-offset-7.html svg/batik/paints/gradientLimit.svg fast/events/touch/touch-target.html canvas/philip/tests/2d.gradient.radial.cone.top.html fast/css/box-shadow.html

5:49 PM Changeset in webkit [74663] by commit-queue@webkit.org

8 edits in trunk/WebCore

2010-12-25 Peter Rybin <peter.rybin@gmail.com>

Reviewed by Adam Barth.

Adds currentColumn (and currentLine) to SegmentedString. Switches
HTMLTreeBuilder to HTMLDocumentParser::textPosition when it
needs position for a <script> tag.

SegmentedString should provide column position
https://bugs.webkit.org/show_bug.cgi?id=51311

html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::HTMLDocumentParser): (WebCore::HTMLDocumentParser::textPosition):
html/parser/HTMLInputStream.h: (WebCore::HTMLInputStream::current): (WebCore::InsertionPointRecord::InsertionPointRecord): (WebCore::InsertionPointRecord::~InsertionPointRecord):
html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): (WebCore::HTMLTreeBuilder::processScriptStartTag):
html/parser/HTMLTreeBuilder.h: (WebCore::HTMLTreeBuilder::create):
platform/text/SegmentedString.cpp: (WebCore::SegmentedString::operator=): (WebCore::SegmentedString::numberOfCharactersConsumedSlow): (WebCore::SegmentedString::advanceSlowCase): (WebCore::SegmentedString::currentLine): (WebCore::SegmentedString::currentColumn): (WebCore::SegmentedString::setCurrentPosition):
platform/text/SegmentedString.h: (WebCore::SegmentedString::SegmentedString): (WebCore::SegmentedString::advancePastNewline): (WebCore::SegmentedString::advance): (WebCore::SegmentedString::numberOfCharactersConsumed):

4:38 PM Changeset in webkit [74662] by commit-queue@webkit.org

10 edits in trunk/WebCore

2010-12-25 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

GraphicsContext: Don't pass StrokeStyle (enum) as const reference
https://bugs.webkit.org/show_bug.cgi?id=51608

platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setStrokeStyle): (WebCore::GraphicsContext::setPlatformStrokeStyle): (WebCore::GraphicsContext::adjustLineToPixelBoundaries):
platform/graphics/GraphicsContext.h:
platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::setPlatformStrokeStyle):
platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::setPlatformStrokeStyle):
platform/graphics/openvg/GraphicsContextOpenVG.cpp: (WebCore::GraphicsContext::setPlatformStrokeStyle):
platform/graphics/openvg/PainterOpenVG.cpp: (WebCore::PainterOpenVG::setStrokeStyle):
platform/graphics/openvg/PainterOpenVG.h:
platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::setPlatformStrokeStyle):
platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformStrokeStyle):

12:53 PM Changeset in webkit [74661] by weinig@apple.com

6 edits in trunk/WebKit2

Fill in some more preferences for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=51610

Reviewed by Dan Bernstein.

Shared/WebPreferencesStore.h:
UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetAuthorAndUserStylesEnabled):
(WKPreferencesGetAuthorAndUserStylesEnabled):
(WKPreferencesSetWebArchiveDebugModeEnabled):
(WKPreferencesGetWebArchiveDebugModeEnabled):
(WKPreferencesSetLocalFileContentSniffingEnabled):
(WKPreferencesGetLocalFileContentSniffingEnabled):
(WKPreferencesSetPageCacheEnabled):
(WKPreferencesGetPageCacheEnabled):
(WKPreferencesSetPaginateDuringLayoutEnabled):
(WKPreferencesGetPaginateDuringLayoutEnabled):
(WKPreferencesSetDOMPasteAllowedEnabled):
(WKPreferencesGetDOMPasteAllowedEnabled):

UIProcess/API/C/WKPreferences.h:
UIProcess/API/C/WKPreferencesPrivate.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):
Pipe through some more preferences.

12:21 PM Changeset in webkit [74660] by Patrick Gansterer

2 edits in trunk/Tools

2010-12-25 Patrick Gansterer <Patrick Gansterer>

Unreviewed WinCE buildfix after r74334.

CMakeListsWinCE.txt:

1:52 AM Changeset in webkit [74659] by Philippe Normand

2 edits in trunk/LayoutTests

2010-12-25 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip another GTK media test reporting wrong duration,
see bug 50518.

platform/gtk/Skipped:

Dec 24, 2010:

10:00 PM Changeset in webkit [74658] by kbr@google.com

2 edits in trunk/LayoutTests

2010-12-24 Kenneth Russell <kbr@google.com>

Unreviewed, Chromium test expectations update.
svg/batik/paints/gradientLimit.svg fails on Linux Debug as well.

platform/chromium/test_expectations.txt:

5:52 PM Changeset in webkit [74657] by mitz@apple.com

6 edits in trunk

REGRESSION (r74648): XHR layout test failures
https://bugs.webkit.org/show_bug.cgi?id=51603

Reviewed by Alexey Proskuryakov.

Reverted r74648.

WebCore:

WebCore.exp.in:

WebKit2:

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveAuthenticationChallenge):

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::shouldUseCredentialStorage):

WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain):

2:33 PM Changeset in webkit [74656] by Philippe Normand

2 edits in trunk/LayoutTests

2010-12-24 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip failing media test on GTK.

platform/gtk/Skipped: Skip media/controls-after-reload.html.

1:43 PM Changeset in webkit [74655] by Philippe Normand

3 edits in trunk/Tools

2010-12-24 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r74632.
http://trac.webkit.org/changeset/74632
https://bugs.webkit.org/show_bug.cgi?id=51600

makes test-webkitpy hang forever on GTK (Requested by philn-tp
on #webkit).

Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:

1:26 PM Changeset in webkit [74654] by Simon Fraser

2 edits in trunk/WebKit2

2010-12-24 Simon Fraser <Simon Fraser>

Fix the Qt build after r74650.

WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

1:24 PM Changeset in webkit [74653] by andreip@google.com

1 edit
2 adds in trunk/LayoutTests

2010-12-24 Andrei Popescu <andreip@google.com>

Unreviewed, build fix.

[Chromium] http/tests/xmlhttprequest/basic-auth-nopassword.html needs Mac, Windows and Linux specific test expectations
https://bugs.webkit.org/show_bug.cgi?id=51589

platform/chromium-win/http/tests/xmlhttprequest/basic-auth-nopassword-expected.txt: Added.
platform/chromium-win/http/tests/xmlhttprequest/basic-auth-nouser-expected.txt: Added.

1:13 PM Changeset in webkit [74652] by mitz@apple.com

3 edits
1 add in trunk/WebCore

Try to fix the Qt build after r74648.

WebCore.gypi:
WebCore.pro:
platform/network/qt/CredentialStorageQt.cpp: Added.

(WebCore::CredentialStorage::getFromPersistentStorage):

12:57 PM Changeset in webkit [74651] by Philippe Normand

9 edits in trunk/LayoutTests

2010-12-24 Philippe Normand <pnormand@igalia.com>

Unreviewed, updated GTK media tests baselines after r74643.

platform/gtk/media/audio-controls-rendering-expected.txt:
platform/gtk/media/controls-after-reload-expected.txt:
platform/gtk/media/controls-strict-expected.txt:
platform/gtk/media/controls-styling-expected.txt:
platform/gtk/media/video-controls-rendering-expected.txt:
platform/gtk/media/video-display-toggle-expected.txt:
platform/gtk/media/video-empty-source-expected.txt:
platform/gtk/media/video-no-audio-expected.txt:

12:55 PM Changeset in webkit [74650] by commit-queue@webkit.org

2 edits in trunk/WebKit2

2010-12-24 Benjamin Poulain <ikipou@gmail.com>

Reviewed by Darin Adler.

[Qt] [WK2] WebKit 2 does not build on mac, missing reference to RetainPtr
https://bugs.webkit.org/show_bug.cgi?id=51598

Fix the build, add the missing header.

WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

12:46 PM Changeset in webkit [74649] by Simon Fraser

3 edits in trunk/WebCore

2010-12-24 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

CSSStyleSelector cleanup
https://bugs.webkit.org/show_bug.cgi?id=51597

Make some methods const. Add assertion to checkOneSelector, with the
intention of later removing the if (!e) check (this is hot code).

css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::locateCousinList): (WebCore::CSSStyleSelector::canShareStyleWithElement): (WebCore::CSSStyleSelector::locateSharedStyle): (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): (WebCore::CSSStyleSelector::mmLength): (WebCore::CSSStyleSelector::inchLength): (WebCore::CSSStyleSelector::getColorFromPrimitiveValue): (WebCore::CSSStyleSelector::hasSelectorForAttribute):
css/CSSStyleSelector.h: (WebCore::CSSStyleSelector::fontSelector):

12:24 PM Changeset in webkit [74648] by mitz@apple.com

6 edits in trunk

<rdar://problem/8758386> The web process uses its own credential storage
https://bugs.webkit.org/show_bug.cgi?id=51599

Reviewed by Anders Carlsson.

WebCore:

WebCore.exp.in: Export CredentialStorage::getFromPersistentStorage(), Credential::hasPassword(),

and Credential::isEmpty().

WebKit2:

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveAuthenticationChallenge): Try to answer the challenge using
the UI process’s credential storage first.

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::shouldUseCredentialStorage): Prevent the web process from using
its own credential storage.

WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain): Ditto.

11:36 AM Changeset in webkit [74647] by Darin Adler

1 edit
1 copy in trunk/LayoutTests

Rebased Leopard to expect the same kind of stack failure
as Windows, rather than the success expected on Snow Leopard
and many other platforms.

platform/mac-leopard/fast/js/large-expressions-expected.txt:

Copied from platform/win/fast/js/large-expressions-expected.txt.

11:36 AM Changeset in webkit [74646] by yurys@chromium.org

9 edits
2 moves in trunk/WebCore

2010-12-24 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Darin Adler.

[V8] Rename V8CustomEventListener.{h,cpp} to V8EventListener.{h,cpp}
https://bugs.webkit.org/show_bug.cgi?id=51595

WebCore.gypi:
bindings/v8/V8DOMWrapper.cpp:
bindings/v8/V8EventListener.cpp: Renamed from WebCore/bindings/v8/custom/V8CustomEventListener.cpp. (WebCore::V8EventListener::V8EventListener): (WebCore::V8EventListener::getListenerFunction): (WebCore::V8EventListener::callListenerFunction):
bindings/v8/V8EventListener.h: Renamed from WebCore/bindings/v8/custom/V8CustomEventListener.h. (WebCore::V8EventListener::create):
bindings/v8/V8EventListenerList.h:
bindings/v8/V8WorkerContextEventListener.h:
bindings/v8/custom/V8DOMWindowCustom.cpp:
bindings/v8/custom/V8LocationCustom.cpp:
bindings/v8/custom/V8NodeCustom.cpp:
bindings/v8/custom/V8NotificationCenterCustom.cpp:

11:26 AM Changeset in webkit [74645] by jberlin@webkit.org

1 edit
2 adds in trunk/LayoutTests

Add Windows-specific (failing) expected results for
http/tests/xmlhttprequest/basic-auth-nouser.html and basic-auth-nopassword.html in order to
get the Windows 7 Release test bot green again. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=51596

platform/win/http/tests/xmlhttprequest/basic-auth-nopassword-expected.txt: Added.
platform/win/http/tests/xmlhttprequest/basic-auth-nouser-expected.txt: Added.

11:26 AM Changeset in webkit [74644] by Darin Adler

2 edits
1 add in trunk

Updated makefiles used by Apple engineers to fix build with the
new JavaScriptGlue location.

Makefile: Told this to build JavaScriptGlue. Some day we might

want it to descend into Sources instead and use the Makefile there,
but there are problems with sequencing the project builds, so that
can wait.

Sources/Makefile.shared: Added.

11:02 AM Changeset in webkit [74643] by commit-queue@webkit.org

4 edits in trunk/WebCore

2010-12-24 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Xan Lopez.

[GTK] Show current time / total in media player
https://bugs.webkit.org/show_bug.cgi?id=51535

css/mediaControlsGtk.css: (audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::formatMediaControlsCurrentTime): (WebCore::RenderThemeGtk::paintMediaCurrentTime):
platform/gtk/RenderThemeGtk.h:

10:55 AM Changeset in webkit [74642] by commit-queue@webkit.org

3 edits in trunk/WebCore

2010-12-24 Jan Erik Hanssen <jhanssen@sencha.com>

Reviewed by Eric Seidel.

Clean up CSSRuleData in CSSStyleSelector.h
https://bugs.webkit.org/show_bug.cgi?id=27753

Move CSSRuleData and CSSRuleDataList from CSSStyleSelector.h to the .cpp file.

css/CSSStyleSelector.cpp: (WebCore::CSSRuleData::CSSRuleData): (WebCore::CSSRuleData::~CSSRuleData): (WebCore::CSSRuleData::position): (WebCore::CSSRuleData::rule): (WebCore::CSSRuleData::selector): (WebCore::CSSRuleData::next): (WebCore::CSSRuleDataList::CSSRuleDataList): (WebCore::CSSRuleDataList::~CSSRuleDataList): (WebCore::CSSRuleDataList::first): (WebCore::CSSRuleDataList::last): (WebCore::CSSRuleDataList::append):
css/CSSStyleSelector.h:

10:54 AM Changeset in webkit [74641] by jberlin@webkit.org

2 edits in trunk/LayoutTests

Skip the new editing/input/ime-composition-clearpreedit.html test since textInputController
is unimplemented in the DRT for Windows. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=32021

platform/win/Skipped:

10:43 AM Changeset in webkit [74640] by commit-queue@webkit.org

2 edits in trunk/Tools

2010-12-24 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Screen doesn't be rendered when changing size of EWebLauncher
https://bugs.webkit.org/show_bug.cgi?id=43528

Remove on_resize because ewk_view_fixed_layout_size_set should not be
called on callback of EVAS_CALLBACK_RESIZE. As it change size of
FrameView, rendering was ignored when _ewk_view_smart_calculate was
called.

EWebLauncher/main.c: (browserCreate):

10:21 AM Changeset in webkit [74639] by eric@webkit.org

12 edits
2 copies in trunk/Tools

2010-12-24 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
https://bugs.webkit.org/show_bug.cgi?id=28291

This is a start. At least now webkit-patch will prompt when your ChangeLog looks questionable.
We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
to strings with find in the diff.
Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.

Scripts/webkitpy/common/checkout/api.py:
Scripts/webkitpy/common/checkout/diff_parser.py:
Scripts/webkitpy/tool/steps/abstractstep.py:
Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
Scripts/webkitpy/tool/steps/validatereviewer.py:

10:20 AM Changeset in webkit [74638] by yurys@chromium.org

3 edits in trunk/WebCore

2010-12-24 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Fix compilation on Windows.

inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyle::~InspectorStyle): added explicit empty destructor
inspector/InspectorStyleSheet.h:

9:51 AM Changeset in webkit [74637] by yurys@chromium.org

4 edits in trunk/WebCore

2010-12-24 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Darin Adler.

inspector/debugger-step-out.html crashing intermittently in the bots
https://bugs.webkit.org/show_bug.cgi?id=50868

Use RefPtr rather instead of raw pointers when keeping references
to refcounted objects.

inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::getStylesForNode2): (WebCore::InspectorCSSAgent::getComputedStyleForNode2):
inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyle::create): (WebCore::InspectorStyle::InspectorStyle): (WebCore::InspectorStyle::buildObjectForStyle): (WebCore::InspectorStyle::setPropertyText): (WebCore::InspectorStyle::toggleProperty): (WebCore::InspectorStyle::styleText): (WebCore::InspectorStyle::populateAllProperties): (WebCore::InspectorStyle::replacePropertyInStyleText): (WebCore::InspectorStyleSheet::create): (WebCore::InspectorStyleSheet::InspectorStyleSheet): (WebCore::InspectorStyleSheetForInlineStyle::create): (WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle): (WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):
inspector/InspectorStyleSheet.h: (WebCore::InspectorStyle::cssStyle): (WebCore::InspectorStyleSheet::pageStyleSheet):

9:31 AM Changeset in webkit [74636] by jschuh@chromium.org

6 edits
2 adds in trunk

2010-12-24 Justin Schuh <jschuh@chromium.org>

Reviewed by Nikolas Zimmermann.

SVGElementInstance::m_useElement should be cleared when use element is removed from document
https://bugs.webkit.org/show_bug.cgi?id=51486

Test: svg/custom/use-instanceRoot-with-use-removed.svg

svg/SVGElementInstance.cpp: (WebCore::SVGElementInstance::invalidateAllInstancesOfElement):
svg/SVGElementInstance.h: (WebCore::SVGElementInstance::clearUseElement):
svg/SVGUseElement.cpp: (WebCore::SVGUseElement::removedFromDocument): (WebCore::ShadowTreeUpdateBlocker::if): (WebCore::SVGUseElement::detachInstance): (WebCore::SVGUseElement::detach):
svg/SVGUseElement.h:

2010-12-24 Justin Schuh <jschuh@chromium.org>

Reviewed by Nikolas Zimmermann.

SVGElementInstance::m_useElement should be cleared when use element is removed from document
https://bugs.webkit.org/show_bug.cgi?id=51486

svg/custom/use-instanceRoot-with-use-removed-expected.txt: Added.
svg/custom/use-instanceRoot-with-use-removed.svg: Added.

9:01 AM Changeset in webkit [74635] by yurys@chromium.org

2 edits in trunk/WebCore

2010-12-23 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Yury Semikhatsky.

Web Inspector: Missing Localized Strings
https://bugs.webkit.org/show_bug.cgi?id=51542

Added missing strings: "WebSocket", "Frames", "Text", "Transfer",
"Preserve Log upon Navigation", and "Go to Line".

English.lproj/localizedStrings.js:

8:39 AM Changeset in webkit [74634] by apavlov@chromium.org

11 edits
3 adds in trunk

2010-12-24 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Inline HTML style property out of sync with element.style in Sidebar
https://bugs.webkit.org/show_bug.cgi?id=51478

Now the element attribute modifications (including "style") are tracked, which results in the
source offsets update (in the backend) and Styles/Metrics pane updates (in the frontend)
on the "style" attribute modification through the Elements tree. Also, it appears that
a complete "style" attribute removal destroys the inline style declaration
(StyledElement::m_inlineStyleDecl), while the code used to rely on it being immutable (hence a crash).

Test: inspector/elements-delete-inline-style.html

WebCore:

inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::didModifyDOMAttr):
inspector/InspectorCSSAgent.h:
inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::didModifyDOMAttr):
inspector/InspectorDOMAgent.h:
inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle): (WebCore::InspectorStyleSheetForInlineStyle::didModifyElementAttribute): (WebCore::InspectorStyleSheetForInlineStyle::text): (WebCore::InspectorStyleSheetForInlineStyle::setStyleText): (WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):
inspector/InspectorStyleSheet.h:
inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):

LayoutTests:

http/tests/inspector/inspector-test2.js: (initialize_InspectorTest.InspectorTest.addResults): (initialize_InspectorTest.InspectorTest.createKeyEvent):
inspector/elements-delete-inline-style-expected.txt: Added.
inspector/elements-delete-inline-style.html: Added.
inspector/elements-tests2.js: Added. (initialize_ElementTest.InspectorTest.expandDOMSubtree.processChildren): (initialize_ElementTest.InspectorTest.expandDOMSubtree): (initialize_ElementTest.InspectorTest.expandDOMSubtreeAndRun): (initialize_ElementTest.InspectorTest.nodeForId): (initialize_ElementTest.InspectorTest.selectElementAndRun): (initialize_ElementTest.InspectorTest.dumpSelectedElementStyles): (initialize_ElementTest.InspectorTest.getSelectedElementStyles): (initialize_ElementTest.InspectorTest.getElementStylePropertyTreeItem): (initialize_ElementTest.InspectorTest.dumpStyleTreeOutline): (initialize_ElementTest.InspectorTest.dumpStyleTreeItem): (initialize_ElementTest):
inspector/styles-add-blank-property.html: Remove unnecessary function.

4:18 AM Changeset in webkit [74633] by commit-queue@webkit.org

1 edit
18 adds in trunk/LayoutTests

2010-12-24 Benjamin Kalman <kalman@chromium.org>

Reviewed by Ryosuke Niwa.

editing/selection/caret-* tests need rebaseline for gtk
https://bugs.webkit.org/show_bug.cgi?id=51578

Rebaseline editing/selection/caret-* tests for gtk.

platform/gtk/editing/selection/caret-ltr-2-expected.checksum: Added.
platform/gtk/editing/selection/caret-ltr-2-expected.png: Added.
platform/gtk/editing/selection/caret-ltr-2-expected.txt: Added.
platform/gtk/editing/selection/caret-ltr-2-left-expected.checksum: Added.
platform/gtk/editing/selection/caret-ltr-2-left-expected.png: Added.
platform/gtk/editing/selection/caret-ltr-2-left-expected.txt: Added.
platform/gtk/editing/selection/caret-ltr-expected.checksum: Added.
platform/gtk/editing/selection/caret-ltr-expected.png: Added.
platform/gtk/editing/selection/caret-ltr-expected.txt: Added.
platform/gtk/editing/selection/caret-ltr-right-expected.checksum: Added.
platform/gtk/editing/selection/caret-ltr-right-expected.png: Added.
platform/gtk/editing/selection/caret-ltr-right-expected.txt: Added.
platform/gtk/editing/selection/caret-rtl-2-left-expected.checksum: Added.
platform/gtk/editing/selection/caret-rtl-2-left-expected.png: Added.
platform/gtk/editing/selection/caret-rtl-2-left-expected.txt: Added.
platform/gtk/editing/selection/caret-rtl-right-expected.checksum: Added.
platform/gtk/editing/selection/caret-rtl-right-expected.png: Added.
platform/gtk/editing/selection/caret-rtl-right-expected.txt: Added.

4:12 AM Changeset in webkit [74632] by dpranke@chromium.org

3 edits in trunk/Tools

2010-12-24 Dirk Pranke <dpranke@chromium.org>

Reviewed by Kenneth Russell.

Modify new-run-webkit-tests to shut up and exit when all the threads
are wedged so that test runs complete faster and we don't end up
w/ enormous log files.

https://bugs.webkit.org/show_bug.cgi?id=51572

Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:

4:05 AM Changeset in webkit [74631] by commit-queue@webkit.org

2 edits in trunk/WebCore

2010-12-24 Noel Gordon <noel.gordon@gmail.com>

Reviewed by Andreas Kling.

[chromium] Fix a style nit in the JPEG encoder
https://bugs.webkit.org/show_bug.cgi?id=51574

platform/image-encoders/skia/JPEGImageEncoder.cpp: nit begone.

4:02 AM Changeset in webkit [74630] by apavlov@chromium.org

5 edits in trunk

2010-12-23 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Maciej Stachowiak.

Web Inspector: CSS shorthand properties expand unnecessarily
https://bugs.webkit.org/show_bug.cgi?id=36304

"border-radius" is a shorthand property that has a "non-standard" format and longhands, see
http://www.w3.org/TR/css3-background/#border-radius for reference. CSSParser does not use the
standard parseShorthand() or parse4Values() methods but instead a custom parseBorderRadius() method.
This method didn't use to create a ShorthandScope instance and set the m_implicitShorthand value
appropriately when adding implicit longhands, thus they were added as normal properties
found in the CSS (neither implicit, nor longhands). This is now fixed.

WebCore:

css/CSSParser.cpp: (WebCore::CSSParser::parseBorderRadius):

LayoutTests:

inspector/elements-panel-styles-expected.txt:
inspector/resources/elements-panel-styles.css: (.foo):

3:54 AM Changeset in webkit [74629] by jschuh@chromium.org

3 edits
2 adds in trunk

2010-12-24 Justin Schuh <jschuh@chromium.org>

Reviewed by Darin Adler.

setTargetAttributeAnimatedValue should check for a null shadowTreeElement.
https://bugs.webkit.org/show_bug.cgi?id=51576

svg/custom/animate-disallowed-use-element-expected.txt: Added.
svg/custom/animate-disallowed-use-element.svg: Added.

2010-12-24 Justin Schuh <jschuh@chromium.org>

Reviewed by Darin Adler.

setTargetAttributeAnimatedValue should check for a null shadowTreeElement.
https://bugs.webkit.org/show_bug.cgi?id=51576

Disallowed elements may be pruned from the shadow tree, leaving a null
shadowTreeElement. We should check for that before setting attributes.

Test: svg/custom/animate-disallowed-use-element.svg

svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue):

3:50 AM Changeset in webkit [74628] by evan@chromium.org

2 edits in trunk/WebCore

2010-12-24 Evan Martin <evan@chromium.org>

Reviewed by Darin Adler.

TextMetrics::width is an integer, but the member is a float
https://bugs.webkit.org/show_bug.cgi?id=51566

Change the return type to a float.

No tests, fixing a compiler warning.
(I was unable to produce a difference in the values exposed to pages
with a float versus the previous conversion to an integer.)

html/TextMetrics.h: (WebCore::TextMetrics::width):

3:47 AM Changeset in webkit [74627] by andreip@google.com

1 edit
1 add in trunk/LayoutTests

2010-12-24 Andrei Popescu <andreip@google.com>

Unreviewed build fix.

Add Chromium-mac test expectation for the layout test below.
[Chromium] http/tests/xmlhttprequest/basic-auth-nopassword.html needs Mac specific test expectations
https://bugs.webkit.org/show_bug.cgi?id=51589

platform/chromium-mac/http/tests/xmlhttprequest/basic-auth-nopassword-expected.txt: Added.

3:27 AM Changeset in webkit [74626] by commit-queue@webkit.org

12 edits
2 adds in trunk

2010-12-24 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Add option to enable Touch Events.
https://bugs.webkit.org/show_bug.cgi?id=49125

Add ENABLE_TOUCH_EVENTS option.

cmake/OptionsEfl.cmake:
cmakeconfig.h.cmake:

2010-12-24 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Add option to enable Touch Events.
https://bugs.webkit.org/show_bug.cgi?id=49125

Add files for EFL to support TOUCH_EVENTS.

CMakeLists.txt:
CMakeListsEfl.txt:
platform/PlatformTouchEvent.h: Add EFL related constructor.
platform/PlatformTouchPoint.h: ditto.
platform/efl/PlatformTouchEventEfl.cpp: Added. (WebCore::PlatformTouchEvent::PlatformTouchEvent):
platform/efl/PlatformTouchPointEfl.cpp: Added. (WebCore::PlatformTouchPoint::PlatformTouchPoint):

2010-12-24 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Add option to enable Touch Events.
https://bugs.webkit.org/show_bug.cgi?id=49125

Implement ewk_frame_feed_touch_event to feed touch events. Because EFL
doesn't have touch events, Application should generate and pass it.

WebCoreSupport/ChromeClientEfl.h: (WebCore::ChromeClientEfl::needTouchEvents):
ewk/ewk_frame.cpp: (ewk_frame_feed_touch_event):
ewk/ewk_frame.h:

3:23 AM Changeset in webkit [74625] by gyuyoung.kim@samsung.com

2 edits in trunk/WebCore

2010-12-24 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Return an empty string instead of 'application/octet-stream' in getMIMETypeForExtension()
https://bugs.webkit.org/show_bug.cgi?id=51457

WebKit EFL can't play html5 audio because of wrong mime type checking.
So, 'application/octet-stream' is changed with an empty string.

platform/efl/MIMETypeRegistryEfl.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension): Returns an empty string instead of application/octet-stream when it can't find proper mime type.

3:09 AM Changeset in webkit [74624] by andreip@google.com

2 edits in trunk/LayoutTests

2010-12-24 Andrei Popescu <andreip@google.com>

Unreviewed. Update Chromium test expectations.

Mark editing/input/ime-composition-clearpreedit.html.html as TEXT.
This test was added in http://trac.webkit.org/changeset/74605 and
fails in Chromium.

platform/chromium/test_expectations.txt:

3:05 AM Changeset in webkit [74623] by eric@webkit.org

3 edits in trunk/Tools

2010-12-24 Eric Seidel <eric@webkit.org>

Reviewed by David Levin.

commit-queue should better explain how it will re-open bugs and follow duplicate chains
https://bugs.webkit.org/show_bug.cgi?id=51549

I've had multiple people ask me about the commit-queue's behavior
regarding reporting flaky tests. I figured it would be best to just
have the queue explain itself in the bugs it files.

Scripts/webkitpy/tool/bot/flakytestreporter.py:
Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:

2:38 AM Changeset in webkit [74622] by jschuh@chromium.org

3 edits
2 adds in trunk

2010-12-24 Justin Schuh <jschuh@chromium.org>

Reviewed by Darin Adler.

SVGFontFaceElement::rebuildFontFace() should exit when not in document
https://bugs.webkit.org/show_bug.cgi?id=51571

svg/custom/use-invalid-font-face-expected.txt: Added.
svg/custom/use-invalid-font-face.svg: Added.

2010-12-24 Justin Schuh <jschuh@chromium.org>

Reviewed by Darin Adler.

SVGFontFaceElement::rebuildFontFace() should exit when not in document
https://bugs.webkit.org/show_bug.cgi?id=51571

We were hitting a NULL deref crash. Since most of the callers checked
inDocument() anyway, I moved it into the start of rebuildFontFace.

Test: svg/custom/use-invalid-font-face.svg

svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::parseMappedAttribute): (WebCore::SVGFontFaceElement::rebuildFontFace): (WebCore::SVGFontFaceElement::childrenChanged):

2:19 AM Changeset in webkit [74621] by hamaji@chromium.org