Context Navigation

On paintBoxShadow(), the spread value accidentally accumulated accidentally
during the loop, which should be applied individually for radius of each shadow.
This change makes the radii for rects computed for each shadow.

Test: fast/box-shadow/spread-multiple-normal.html

rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBoxShadow):

2:13 PM Changeset in webkit [74672] by commit-queue@webkit.org

2 edits in trunk/JavaScriptCore

2010-12-26 Xan Lopez <xlopez@igalia.com>

Reviewed by Eric Seidel.

[GTK] Add standalone target for JSC
https://bugs.webkit.org/show_bug.cgi?id=51607

GNUmakefile.am: add convenience target to only build jsc and its dependencies.

2:00 PM Changeset in webkit [74671] by Patrick Gansterer

2 edits in trunk/WebCore

2010-12-26 Patrick Gansterer <Patrick Gansterer>

Reviewed by Eric Seidel.

Improve output of HTML parser benchmark
https://bugs.webkit.org/show_bug.cgi?id=51611

Calculate and show median, min and max values.

benchmarks/parser/html-parser.html:

12:27 PM Changeset in webkit [74670] by levin@chromium.org

3 edits in trunk/Tools

2010-12-26 David Levin <levin@chromium.org>

Reviewed by Eric Seidel.

check-webkit-style should be able to parse function declaration parameters.
https://bugs.webkit.org/show_bug.cgi?id=51451

Scripts/webkitpy/style/checkers/cpp.py: (Position.init): Holds simple position information (row, column). (Parameter.init): Holds information about a parameter. (SingleLineView.init): Converts multiple lines into a single line for simpler searches. (SingleLineView.convert_column_to_row): Returns the original row given a column. (create_skeleton_parameters): Simplifies a parameter list for easier searching. (find_parameter_name_index): Finds where the parameter name is. (parameter_list): Generates the list of parameters for a function. (_FunctionState.begin): Added information to allow determining the parameters on demand. (_FunctionState.get_parameter_list): Returns a tuple of function parameters. (detect_functions): Improve function detection for operator functions and determine where the parameters end and pass that to _FunctionState.begin.
Scripts/webkitpy/style/checkers/cpp_unittest.py: (CppFunctionsTest.test_parameter): Verifies Parameter functionality. (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality. (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters. (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index. (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list. Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list. (FunctionDetectionTest.perform_function_detection): Added support for verifying the parameters found. (FunctionDetectionTest.test_function_declaration_detection): Added more function detection test to verify that we catch the operator functions. (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros. (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing. (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed because the error. The test is about the bad function name. Fixing the name makes the test exactly like test_function_length_check_definition_severity1_for_test.

11:41 AM Changeset in webkit [74669] by andersca@apple.com

13 edits in trunk/WebKit2

Rename DrawingAreaMessage and DrawingAreaLegacyMessage and
DrawingAreaProxyMessage to DrawingAreaProxyLegacyMessage.

Reviewed by Dan Bernstein.

Platform/CoreIPC/MessageID.h:
Shared/CoreIPCSupport/DrawingAreaMessageKinds.h:
Shared/CoreIPCSupport/DrawingAreaProxyMessageKinds.h:
UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:

(WebKit::ChunkedUpdateDrawingAreaProxy::paint):
(WebKit::ChunkedUpdateDrawingAreaProxy::setPageIsVisible):
(WebKit::ChunkedUpdateDrawingAreaProxy::update):
(WebKit::ChunkedUpdateDrawingAreaProxy::sendSetSize):
(WebKit::ChunkedUpdateDrawingAreaProxy::didReceiveMessage):

UIProcess/LayerBackedDrawingAreaProxy.cpp:

(WebKit::LayerBackedDrawingAreaProxy::sizeDidChange):
(WebKit::LayerBackedDrawingAreaProxy::setPageIsVisible):
(WebKit::LayerBackedDrawingAreaProxy::update):
(WebKit::LayerBackedDrawingAreaProxy::didReceiveMessage):
(WebKit::LayerBackedDrawingAreaProxy::didReceiveSyncMessage):

UIProcess/TiledDrawingAreaProxy.cpp:

(WebKit::TiledDrawingAreaProxy::sizeDidChange):
(WebKit::TiledDrawingAreaProxy::setPageIsVisible):
(WebKit::TiledDrawingAreaProxy::didReceiveMessage):
(WebKit::TiledDrawingAreaProxy::requestTileUpdate):
(WebKit::TiledDrawingAreaProxy::waitUntilUpdatesComplete):
(WebKit::TiledDrawingAreaProxy::takeSnapshot):
(WebKit::TiledDrawingAreaProxy::removeTile):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didReceiveSyncMessage):

WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:

(WebKit::ChunkedUpdateDrawingArea::display):
(WebKit::ChunkedUpdateDrawingArea::setSize):
(WebKit::ChunkedUpdateDrawingArea::didReceiveMessage):

WebProcess/WebPage/LayerBackedDrawingArea.cpp:

(WebKit::LayerBackedDrawingArea::setSize):
(WebKit::LayerBackedDrawingArea::didReceiveMessage):

WebProcess/WebPage/TiledDrawingArea.cpp:

(WebKit::TiledDrawingArea::display):
(WebKit::TiledDrawingArea::setSize):
(WebKit::TiledDrawingArea::updateTile):
(WebKit::TiledDrawingArea::tileUpdateTimerFired):
(WebKit::TiledDrawingArea::didReceiveMessage):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didReceiveMessage):

WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm:

(WebKit::LayerBackedDrawingArea::attachCompositingContext):

11:26 AM Changeset in webkit [74668] by andersca@apple.com

10 edits in trunk/WebKit2

Drawing area cleanup. Remove a bunch of redundant functions that just ended
up calling setNeedsDisplay.

Reviewed by Sam Weinig.

UIProcess/DrawingAreaProxy.h:
WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::invalidateWindow):
(WebKit::WebChromeClient::invalidateContentsAndWindow):
(WebKit::WebChromeClient::invalidateContentsForSlowScroll):

WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:
WebProcess/WebPage/ChunkedUpdateDrawingArea.h:
WebProcess/WebPage/DrawingArea.h:
WebProcess/WebPage/LayerBackedDrawingArea.cpp:
WebProcess/WebPage/LayerBackedDrawingArea.h:
WebProcess/WebPage/TiledDrawingArea.cpp:
WebProcess/WebPage/TiledDrawingArea.h:

8:57 AM Changeset in webkit [74667] by kbr@google.com

2 edits in trunk/LayoutTests

2010-12-26 Kenneth Russell <kbr@google.com>

Unreviewed, Chromium expectations fix. Fix broken (duplicate)
expectations for
canvas/philip/tests/2d.gradient.radial.cone.top.html.

platform/chromium/test_expectations.txt:

8:04 AM Changeset in webkit [74666] by inferno@chromium.org

3 edits
2 adds in trunk

2010-12-26 Abhishek Arya <inferno@chromium.org>

Reviewed by Simon Fraser.

Remove the bad assert in paintPaginatedChildLayer, hitTestPaginatedChildLayer.
https://bugs.webkit.org/show_bug.cgi?id=48772

Test: fast/multicol/renderer-positioned-assert-crash.html

rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintPaginatedChildLayer): (WebCore::RenderLayer::hitTestPaginatedChildLayer):

2010-12-26 Abhishek Arya <inferno@chromium.org>

Reviewed by Simon Fraser.

Tests passes if it does not crash.
https://bugs.webkit.org/show_bug.cgi?id=48772

fast/multicol/renderer-positioned-assert-crash-expected.txt: Added.
fast/multicol/renderer-positioned-assert-crash.html: Added.

2:04 AM Changeset in webkit [74665] by Patrick Gansterer

2 edits in trunk

2010-12-26 Patrick Gansterer <Patrick Gansterer>

Unreviewed WinCE buildfix after r74626.

cmake/OptionsWinCE.cmake:

Dec 25, 2010:

9:05 PM Changeset in webkit [74664] by kbr@google.com

3 edits in trunk/LayoutTests

2010-12-25 Kenneth Russell <kbr@google.com>

Unreviewed, Chromium test expectations update.

platform/chromium-gpu/test_expectations.txt: Win Debug: Marked compositing/tiling/huge-layer-img.html as TIMEOUT. Marked fast/canvas/webgl/gl-object-get-calls.html as a flaky crash.
platform/chromium/test_expectations.txt: Adjusted expectations for the following tests: fast/canvas/shadow-offset-7.html svg/batik/paints/gradientLimit.svg fast/events/touch/touch-target.html canvas/philip/tests/2d.gradient.radial.cone.top.html fast/css/box-shadow.html

5:49 PM Changeset in webkit [74663] by commit-queue@webkit.org

8 edits in trunk/WebCore

2010-12-25 Peter Rybin <peter.rybin@gmail.com>

Reviewed by Adam Barth.

Adds currentColumn (and currentLine) to SegmentedString. Switches
HTMLTreeBuilder to HTMLDocumentParser::textPosition when it
needs position for a <script> tag.

SegmentedString should provide column position
https://bugs.webkit.org/show_bug.cgi?id=51311

html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::HTMLDocumentParser): (WebCore::HTMLDocumentParser::textPosition):
html/parser/HTMLInputStream.h: (WebCore::HTMLInputStream::current): (WebCore::InsertionPointRecord::InsertionPointRecord): (WebCore::InsertionPointRecord::~InsertionPointRecord):
html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): (WebCore::HTMLTreeBuilder::processScriptStartTag):
html/parser/HTMLTreeBuilder.h: (WebCore::HTMLTreeBuilder::create):
platform/text/SegmentedString.cpp: (WebCore::SegmentedString::operator=): (WebCore::SegmentedString::numberOfCharactersConsumedSlow): (WebCore::SegmentedString::advanceSlowCase): (WebCore::SegmentedString::currentLine): (WebCore::SegmentedString::currentColumn): (WebCore::SegmentedString::setCurrentPosition):
platform/text/SegmentedString.h: (WebCore::SegmentedString::SegmentedString): (WebCore::SegmentedString::advancePastNewline): (WebCore::SegmentedString::advance): (WebCore::SegmentedString::numberOfCharactersConsumed):

4:38 PM Changeset in webkit [74662] by commit-queue@webkit.org

10 edits in trunk/WebCore

2010-12-25 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

GraphicsContext: Don't pass StrokeStyle (enum) as const reference
https://bugs.webkit.org/show_bug.cgi?id=51608

platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setStrokeStyle): (WebCore::GraphicsContext::setPlatformStrokeStyle): (WebCore::GraphicsContext::adjustLineToPixelBoundaries):
platform/graphics/GraphicsContext.h:
platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::setPlatformStrokeStyle):
platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::setPlatformStrokeStyle):
platform/graphics/openvg/GraphicsContextOpenVG.cpp: (WebCore::GraphicsContext::setPlatformStrokeStyle):
platform/graphics/openvg/PainterOpenVG.cpp: (WebCore::PainterOpenVG::setStrokeStyle):
platform/graphics/openvg/PainterOpenVG.h:
platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::setPlatformStrokeStyle):
platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformStrokeStyle):

12:53 PM Changeset in webkit [74661] by weinig@apple.com

6 edits in trunk/WebKit2

Fill in some more preferences for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=51610

Reviewed by Dan Bernstein.

Shared/WebPreferencesStore.h:
UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetAuthorAndUserStylesEnabled):
(WKPreferencesGetAuthorAndUserStylesEnabled):
(WKPreferencesSetWebArchiveDebugModeEnabled):
(WKPreferencesGetWebArchiveDebugModeEnabled):
(WKPreferencesSetLocalFileContentSniffingEnabled):
(WKPreferencesGetLocalFileContentSniffingEnabled):
(WKPreferencesSetPageCacheEnabled):
(WKPreferencesGetPageCacheEnabled):
(WKPreferencesSetPaginateDuringLayoutEnabled):
(WKPreferencesGetPaginateDuringLayoutEnabled):
(WKPreferencesSetDOMPasteAllowedEnabled):
(WKPreferencesGetDOMPasteAllowedEnabled):

UIProcess/API/C/WKPreferences.h:
UIProcess/API/C/WKPreferencesPrivate.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):
Pipe through some more preferences.

12:21 PM Changeset in webkit [74660] by Patrick Gansterer

2 edits in trunk/Tools

2010-12-25 Patrick Gansterer <Patrick Gansterer>

Unreviewed WinCE buildfix after r74334.

CMakeListsWinCE.txt:

1:52 AM Changeset in webkit [74659] by Philippe Normand

2 edits in trunk/LayoutTests

2010-12-25 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip another GTK media test reporting wrong duration,
see bug 50518.

platform/gtk/Skipped:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed