Timeline
Dec 28, 2010:
- 11:45 PM Changeset in webkit [74734] by
-
- 12 edits in trunk/WebCore
2010-12-28 Pratik Solanki <psolanki@apple.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=51522
Use deviceRGBColorSpaceRef() instead of calling CGColorSpaceCreateDeviceRGB()
- page/win/FrameCGWin.cpp: (WebCore::imageFromRect):
- platform/graphics/cg/GradientCG.cpp: (WebCore::Gradient::platformGradient):
- platform/graphics/cg/GraphicsContext3DCG.cpp: (WebCore::GraphicsContext3D::paintToCanvas):
- platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::checkForSolidColor):
- platform/graphics/gstreamer/ImageGStreamerCG.mm: (ImageGStreamer::ImageGStreamer):
- platform/graphics/win/GraphicsContextCGWin.cpp: (WebCore::CGContextWithHDC): (WebCore::GraphicsContext::releaseWindowsContext): (WebCore::GraphicsContext::drawWindowsBitmap):
- platform/graphics/win/ImageCGWin.cpp: (WebCore::BitmapImage::create): (WebCore::BitmapImage::getHBITMAPOfSize):
- platform/image-decoders/cg/ImageDecoderCG.cpp: (WebCore::createColorSpace):
- platform/win/DragImageCGWin.cpp: (WebCore::allocImage): (WebCore::createCgContextFromBitmap):
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMenuListButtonGradients): (WebCore::RenderThemeMac::paintSliderTrack):
- rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintMenuListButtonGradients): (WebCore::RenderThemeSafari::paintSliderTrack):
- 4:59 PM Changeset in webkit [74733] by
-
- 19 edits in trunk
2010-12-28 Daniel Bates <dbates@rim.com>
Reviewed by Sam Weinig.
Substitute MARK: for compiler-specific #pragma mark
https://bugs.webkit.org/show_bug.cgi?id=51657
For consistency, we should substitute " MARK:" for compiler-
specific "#pragma mark" in the source files for the Mac port.
- History/WebHistory.mm:
- Plugins/WebBaseNetscapePluginView.mm:
- Plugins/WebNetscapePluginView.mm:
- WebCoreSupport/WebInspectorClient.mm:
- WebCoreSupport/WebSecurityOrigin.mm:
- WebView/WebPDFView.mm:
- WebView/WebVideoFullscreenController.mm:
- WebView/WebVideoFullscreenHUDWindowController.mm:
2010-12-28 Daniel Bates <dbates@rim.com>
Reviewed by Sam Weinig.
Substitute MARK: for compiler-specific #pragma mark
https://bugs.webkit.org/show_bug.cgi?id=51657
Fix compilation warnings about "#pragma mark" on GTK+ bots by
substituting " MARK:" for "#pragma mark", which provides
analogous code-bookmarking functionality under Xcode.
- platform/graphics/cg/PathCG.cpp:
- platform/graphics/mac/WebLayer.mm:
2010-12-28 Daniel Bates <dbates@rim.com>
Reviewed by Sam Weinig.
Substitute MARK: for compiler-specific #pragma mark
https://bugs.webkit.org/show_bug.cgi?id=51657
Fix future compilation warnings about "#pragma mark" on GTK+ bots by
substituting " MARK:" for "#pragma mark", which provides
analogous code-bookmarking functionality under Xcode.
Also, for consistency, we should substitute " MARK:" for compiler-
specific "#pragma mark" in the source files for the Mac port.
- DumpRenderTree/AccessibilityTextMarker.cpp:
- DumpRenderTree/cf/WebArchiveDumpSupport.h:
- DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
- DumpRenderTree/mac/ObjCController.m:
- MiniBrowser/mac/AppDelegate.m:
- MiniBrowser/mac/BrowserWindowController.m:
- 4:56 PM Changeset in webkit [74732] by
-
- 2 edits in trunk/LayoutTests
2010-12-28 Daniel Bates <dbates@rim.com>
Reviewed by Antonio Gomes.
Add comment to test case fast/repaint/no-caret-repaint-in-non-content-editable-element.html
to clarify caret browsing disabled
https://bugs.webkit.org/show_bug.cgi?id=51633
Add a comment to test case fast/repaint/no-caret-repaint-in-non-content-editable-element.html
that explains that this test is only applicable when caret browsing is disabled.
- fast/repaint/no-caret-repaint-in-non-content-editable-element.html:
- 4:39 PM Changeset in webkit [74731] by
-
- 3 edits in trunk/WebKit/gtk
2010-12-28 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Closing a window during an onload event can trigger serious GLib warnings
https://bugs.webkit.org/show_bug.cgi?id=51686
Don't emit the close-web-view signal immediately during execution of closeWindowSoon.
The signal handler may choose to destroy the web view while handling that signal,
which may remove the last reference to the web view. FrameLoaderClient depends on the
view still existing though. Instead, let the caller finish executing and emit the signal
after a 0 length timeout. This matches the behavior on the Windows and Mac ports.
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::ChromeClient): Initialize the timer id. (WebKit::emitCloseWebViewSignalLater): Callback for the timer. (WebKit::ChromeClient::closeWindowSoon): Do the actual signal invocation after the caller finishes its tasks.
- WebCoreSupport/ChromeClientGtk.h: Add a new member for the timer id. We can use this to prevent emitting the close-web-view signal twice.
- 3:39 PM Changeset in webkit [74730] by
-
- 2 edits in trunk/WebKit/gtk
2010-12-28 Martin Robinson <mrobinson@igalia.com>
Reviewed by Eric Seidel.
[GTK] Clean up usage of NULL in webkitwebframe.cpp
https://bugs.webkit.org/show_bug.cgi?id=51685
Replace occurrences of NULL with 0, in webkitwebframe.cpp. Not all
uses of NULL have been changed, as certain GLib functions require
an explicit NULL as a sentinel.
- webkit/webkitwebframe.cpp: (webkit_web_frame_get_data_source_from_core_loader): (webkit_web_frame_class_init): (webkit_web_frame_new): (webkit_web_frame_get_title): (webkit_web_frame_get_uri): (webkit_web_frame_get_web_view): (webkit_web_frame_get_name): (webkit_web_frame_get_parent): (webkit_web_frame_load_string): (webkit_web_frame_load_alternate_string): (webkit_web_frame_find_frame): (webkit_web_frame_get_global_context): (webkit_web_frame_get_data_source): (webkit_web_frame_get_provisional_data_source): (webkit_web_frame_print_full): (webkit_web_frame_get_security_origin): (webkit_web_frame_get_network_response):
- 3:16 PM Changeset in webkit [74729] by
-
- 3 edits in trunk/LayoutTests
2010-12-28 Kenneth Russell <kbr@google.com>
Reviewed by Eric Seidel.
Make fast/canvas/canvas-save-restore-with-path.js more robust
https://bugs.webkit.org/show_bug.cgi?id=51665
- fast/canvas/canvas-save-restore-with-path-expected.txt:
- fast/canvas/canvas-save-restore-with-path.js:
- 2:56 PM Changeset in webkit [74728] by
-
- 2 edits in trunk/WebCore
2010-12-28 Jan Erik Hanssen <jhanssen@sencha.com>
Reviewed by Eric Seidel.
[Qt] GraphicsContext::getCTM() does not need to make a copy of QPainter::combinedTransform()
https://bugs.webkit.org/show_bug.cgi?id=51687
Use a const reference instead of a copy of QPainter::combinedTransform()
in GraphicsContext::getCTM()
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::getCTM):
- 2:45 PM Changeset in webkit [74727] by
-
- 4 edits in trunk
2010-12-28 Helder Correia <helder@sencha.com>
Reviewed by Eric Seidel.
JSON.stringify must exist as a function taking 3 parameters
https://bugs.webkit.org/show_bug.cgi?id=51667
The reported function length is 1 instead.
Test: ietestcenter/Javascript/15.12.3-0-2.html
- runtime/JSONObject.cpp:
2010-12-28 Helder Correia <helder@sencha.com>
Reviewed by Eric Seidel.
JSON.stringify must exist as a function taking 3 parameters
https://bugs.webkit.org/show_bug.cgi?id=51667
The reported function length is 1 instead.
- ietestcenter/Javascript/15.12.3-0-2-expected.txt:
- 2:20 PM Changeset in webkit [74726] by
-
- 2 edits in trunk/Tools
2010-12-28 Xan Lopez <xlopez@igalia.com>
Reviewed by Eric Seidel.
Add --no-build option to run-sunspider
https://bugs.webkit.org/show_bug.cgi?id=51658
- Scripts/run-sunspider: add --no-build flag to skip building phase.
- 2:16 PM Fingerprinting edited by
- (diff)
- 2:14 PM Changeset in webkit [74725] by
-
- 3 edits in trunk/WebCore
2010-12-28 Takashi Toyoshima <toyoshim@google.com>
Reviewed by Eric Seidel.
gcc detected 'control reaches end of non-void function' with
-finstrument-functions option.
https://bugs.webkit.org/show_bug.cgi?id=51669
No new tests. These fixes are trivial.
- dom/Element.cpp: (WebCore::Element::childTypeAllowed):
- inspector/InspectorResourceAgent.cpp: (WebCore::cachedResourceTypeString):
- 2:11 PM Fingerprinting created by
- 1:57 PM Changeset in webkit [74724] by
-
- 4 edits in trunk/WebCore
2010-12-28 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Eric Seidel.
Remove unused member of PendingScript
https://bugs.webkit.org/show_bug.cgi?id=51684
This was used when HTMLScriptRunner::runScript created a PendingScript
for inline scripts. But now it just calls executeScript() directly.
External scripts always have the minimum starting line number.
No new tests because no changed functionality.
- dom/PendingScript.cpp: (WebCore::PendingScript::releaseElementAndClear):
- dom/PendingScript.h: (WebCore::PendingScript::PendingScript): (WebCore::PendingScript::operator=):
- html/parser/HTMLScriptRunner.cpp: (WebCore::HTMLScriptRunner::sourceFromPendingScript):
- 1:57 PM Changeset in webkit [74723] by
-
- 4 edits in trunk/WebCore
2010-12-20 Antonio Gomes <agomes@rim.com>
Reviewed by Daniel Bates.
Spatial Navigation: code clean up (Part VI)
https://bugs.webkit.org/show_bug.cgi?id=50666
No new tests needed.
- page/FocusController.cpp: (WebCore::updatFocusCandidateIfNeeded): Assert renderer() and isElementNode() now that we are bailing out earlier in both the FocusCandidate constructor and FocusController::findFocusCandidateInContainer().
- page/SpatialNavigation.h: Swapped the parameters order in canScrollInDirection and virtualRectForAreaElementAndDirection functions. (WebCore::FocusController::findFocusCandidateInContainer): (WebCore::FocusController::advanceFocusDirectionallyInContainer): Adjusted call sites of canScrollInDirection(), and added an early return if !isElementNode(). (WebCore::FocusController::advanceFocusDirectionally): Adjusted call site of virtualRectForAreaElementAndDirection().
- page/SpatialNavigation.cpp: (WebCore::FocusCandidate::FocusCandidate): Assert if node is not an Element node. (WebCore::isScrollableNode): Renamed from isScrollableContainerNode. (WebCore::scrollInDirection): Adjusted call site after function name change; (WebCore::scrollableEnclosingBoxOrParentFrameForNodeInDi:rection): Assert if node is a Document node. (WebCore::canScrollInDirection): Signature changed. (WebCore::canBeScrolledIntoView): Ditto. (WebCore::virtualRectForAreaElementAndDirection): Ditto.
- 1:53 PM Changeset in webkit [74722] by
-
- 2 edits in trunk/WebCore
2010-12-28 Adrienne Walker <enne@google.com>
Reviewed by Kenneth Russell.
[chromium] Fix tiled compositor assertion after GPU process recovery.
https://bugs.webkit.org/show_bug.cgi?id=51682
After the GPU process recovers, the layer size is set to IntSize(),
but IntRect::unite() has a special case for empty rects. This
behavior was causing the layer size to be too small, causing an
out-of-bounds array access elsewhere.
No new tests.
- platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::growLayerToContain):
- 1:36 PM Changeset in webkit [74721] by
-
- 4 edits in trunk
2010-12-28 Helder Correia <helder@sencha.com>
Reviewed by Sam Weinig.
JSON.parse must exist as a function taking 2 parameters
https://bugs.webkit.org/show_bug.cgi?id=51666
Support for revivers was introduced in bug 26591, but the function
length has since remained unchanged.
Test: ietestcenter/Javascript/15.12.2-0-2.html
- runtime/JSONObject.cpp:
2010-12-28 Helder Correia <helder@sencha.com>
Reviewed by Sam Weinig.
JSON.parse must exist as a function taking 2 parameters
https://bugs.webkit.org/show_bug.cgi?id=51666
Support for revivers was introduced in bug 26591, but the function
length has since remained unchanged.
- ietestcenter/Javascript/15.12.2-0-2-expected.txt: Change expected result to success.
- 1:35 PM Changeset in webkit [74720] by
-
- 16 edits in trunk
2010-12-23 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Initialize to 0 for undefined values in CopyTexImage2D
https://bugs.webkit.org/show_bug.cgi?id=51421
- src/GraphicsContext3DChromium.cpp: Implement getInternalFramebufferSize(). (WebCore::GraphicsContext3DInternal::getInternalFramebufferSize):
- src/GraphicsContext3DInternal.h:
2010-12-23 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Initialize to 0 for undefined values in CopyTexImage2D
https://bugs.webkit.org/show_bug.cgi?id=51421
- html/canvas/WebGLFramebuffer.cpp: Track width/height/internalFormat of color buffer. (WebCore::WebGLFramebuffer::WebGLFramebuffer): (WebCore::WebGLFramebuffer::setAttachment): (WebCore::WebGLFramebuffer::getWidth): (WebCore::WebGLFramebuffer::getHeight): (WebCore::WebGLFramebuffer::getColorBufferFormat):
- html/canvas/WebGLFramebuffer.h:
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::copyTexImage2D): Initialize undefined pixels to 0. (WebCore::WebGLRenderingContext::copyTexSubImage2D): (WebCore::WebGLRenderingContext::framebufferTexture2D): (WebCore::WebGLRenderingContext::renderbufferStorage): (WebCore::WebGLRenderingContext::getBoundFramebufferWidth): (WebCore::WebGLRenderingContext::getBoundFramebufferHeight):
- html/canvas/WebGLRenderingContext.h:
- html/canvas/WebGLTexture.cpp: Track width/height/internalFormat of a texture by target/level. (WebCore::WebGLTexture::getInternalFormat): (WebCore::WebGLTexture::getWidth): (WebCore::WebGLTexture::getHeight): (WebCore::WebGLTexture::mapTargetToIndex): (WebCore::WebGLTexture::getLevelInfo):
- html/canvas/WebGLTexture.h: (WebCore::WebGLTexture::isTexture):
- platform/graphics/GraphicsContext3D.h: Add getInternalFramebufferSize() function.
- platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: (WebCore::GraphicsContext3D::getInternalFramebufferSize):
- platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::getInternalFramebufferSize):
2010-12-23 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Initialize to 0 for undefined values in CopyTexImage2D
https://bugs.webkit.org/show_bug.cgi?id=51421
- fast/canvas/webgl/uninitialized-test-expected.txt: Add test cases for copyTexImage2D.
- fast/canvas/webgl/uninitialized-test.html: Ditto.
- 1:26 PM Changeset in webkit [74719] by
-
- 7 edits in trunk
2010-12-23 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Map GLsizei to long instead of unsigned long in WebGLRenderingContext and GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=39855
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::copyTexImage2D): Map GLsizei to long. (WebCore::WebGLRenderingContext::copyTexSubImage2D): Ditto. (WebCore::WebGLRenderingContext::renderbufferStorage): Ditto. (WebCore::WebGLRenderingContext::scissor): Ditto. (WebCore::WebGLRenderingContext::texImage2DBase): Ditto. (WebCore::WebGLRenderingContext::texImage2D): Ditto. (WebCore::WebGLRenderingContext::texSubImage2DBase): Ditto. (WebCore::WebGLRenderingContext::texSubImage2DImpl): Ditto. (WebCore::WebGLRenderingContext::texSubImage2D): Ditto. (WebCore::WebGLRenderingContext::viewport): Ditto. (WebCore::WebGLRenderingContext::validateSize): Check the sizes are non-negative.
- html/canvas/WebGLRenderingContext.h:
- html/canvas/WebGLRenderingContext.idl:
2010-12-28 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Map GLsizei to long instead of unsigned long in WebGLRenderingContext and GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=39855
- fast/canvas/webgl/invalid-passed-params-expected.txt: Add test cases for negative offset/width/height.
- fast/canvas/webgl/invalid-passed-params.html: Ditto.
- 12:01 PM Changeset in webkit [74718] by
-
- 2 edits in trunk/LayoutTests
2010-12-28 Kenneth Russell <kbr@google.com>
Unreviewed, Chromium test expectations update. Mark
fast/forms/input-text-paste-maxlength.html as a flaky crash on
Linux Release as well as Debug.
- platform/chromium/test_expectations.txt:
- 11:36 AM Changeset in webkit [74717] by
-
- 2 edits in trunk/LayoutTests
2010-12-28 Kenneth Russell <kbr@google.com>
Unreviewed, Chromium test expectations update.
Marked inspector/styles-source-lines.html as a flaky failure on
Win Debug and
http/tests/inspector/extensions-resources-redirect.html as a flaky
timeout on Win Release.
- platform/chromium/test_expectations.txt:
- 11:18 AM Changeset in webkit [74716] by
-
- 5 edits2 adds in trunk
2010-12-28 Abhishek Arya <inferno@chromium.org>
Reviewed by Kenneth Russell.
Fix crash with invalid font in m_fontList by not drawing text when a custom font is in the
process of loading.
https://bugs.webkit.org/show_bug.cgi?id=51681
Test: canvas/philip/tests/2d.text-custom-font-load-crash.html
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawTextInternal): bail out if a custom font is loading.
- platform/graphics/Font.cpp: (WebCore::Font::operator==): Replace condition with new function loadingCustomFonts() (WebCore::Font::drawText): Replace condition with new function loadingCustomFonts() (WebCore::Font::drawEmphasisMarks): Replace condition with new function loadingCustomFonts()
- platform/graphics/Font.h: (WebCore::Font::loadingCustomFonts): new function that returns if a custom font is loading.
2010-12-28 Abhishek Arya <inferno@chromium.org>
Reviewed by Kenneth Russell.
Tests that we do not crash when drawing text during custom font load.
https://bugs.webkit.org/show_bug.cgi?id=51681
- canvas/philip/tests/2d.text-custom-font-load-crash-expected.txt: Added.
- canvas/philip/tests/2d.text-custom-font-load-crash.html: Added.
- 10:55 AM Changeset in webkit [74715] by
-
- 4 edits in trunk/WebCore
2010-12-28 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
Combine setShadowRoot and clearShadowRoot into a simpler API
https://bugs.webkit.org/show_bug.cgi?id=50971
No change in behavior, and API is not used yet.
- dom/Element.cpp: (WebCore::Element::setShadowRoot): Combined clearing and setting of
the shadowRoot, also hooked up with setting and clearing of the
corresponding shadowHost values.
- dom/Element.h: renamed clearShadowRoot to removeShadowRoot and made it
private.
- dom/Node.h: Made shadow host-related functions public so that
Element::setShadowRoot can access setShadowHost. It seems logical
to make shadowHost public as well to keep the defs together.
- 10:11 AM Changeset in webkit [74714] by
-
- 6 edits3 adds in trunk
2010-12-28 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Expose extension API to select a node in WebInspector
Do not request content for resources with non-numeric identifiers.
https://bugs.webkit.org/show_bug.cgi?id=49727
Test: http/tests/inspector/extensions-resources-redirect.html
- inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager.prototype._appendRedirect):
2010-12-28 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Expose extension API to select a node in WebInspector
Do not request content for resources with non-numeric identifiers.
https://bugs.webkit.org/show_bug.cgi?id=49727
- http/tests/inspector/extensions-resources-redirect-expected.txt: Added.
- http/tests/inspector/extensions-resources-redirect.html: Added.
- http/tests/inspector/extensions-resources-test.js: Added. (extension_getResourceByUrl.onHAR): (extension_getResourceByUrl):
- inspector/extensions-resources-expected.txt:
- inspector/extensions-resources.html:
- platform/mac-leopard/inspector/extensions-resources-expected.txt:
- 9:58 AM Changeset in webkit [74713] by
-
- 2 edits in trunk/WebCore
2010-12-28 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed build fix for Qt.
ResourceTreeModel.js was added.
- inspector/front-end/WebKit.qrc:
- 9:24 AM Changeset in webkit [74712] by
-
- 2 edits in trunk/WebCore
2010-12-28 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
[Chromium] Fix memory leak in Profiles tab concerned with heap profiles views.
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype._reset):
- 7:55 AM Changeset in webkit [74711] by
-
- 2 edits in trunk/LayoutTests
2010-12-28 Kenneth Russell <kbr@google.com>
Unreviewed, Chromium test expectations update. Coalesce WebGL
expectations for chromium-gpu platform and fix duplicate
expectation for gl-object-get-calls.html accidentally introduced
on Windows Debug.
- platform/chromium-gpu/test_expectations.txt:
- 7:32 AM Changeset in webkit [74710] by
-
- 4 edits4 adds in trunk
2010-12-28 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: REGRESSION: Clicking image resource in style sidebar doesn't actually go to resource anymore
https://bugs.webkit.org/show_bug.cgi?id=51663
- inspector/elements-tests2.js: (initialize_ElementTest.InspectorTest.dumpSelectedElementStyles): Drive-by: remove bad test exit code.
- inspector/resources/styles-url-linkify-iframe.html: Added.
- inspector/resources/styles-url-linkify.css: Added. (#local):
- inspector/styles-url-linkify-expected.txt: Added.
- inspector/styles-url-linkify.html: Added.
2010-12-28 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: REGRESSION: Clicking image resource in style sidebar doesn't actually go to resource anymore
https://bugs.webkit.org/show_bug.cgi?id=51663
The base URI is now computed correctly for links from CSS property uri(...) values. Additionally,
optional quotes/apostrophes and spaces are now allowed inside uri(...).
Test: inspector/styles-url-linkify.html
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL): (WebInspector.StylePropertyTreeElement.prototype.updateTitle):
- 7:11 AM Changeset in webkit [74709] by
-
- 21 edits2 adds1 delete in trunk/WebCore
2010-12-21 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Protocol cleanup task. Introduce Network, DOMStorage and Database domains.
Domain was changed for Resources, FileSystem etc. related methods.
ResourcesManager was renamed to NetworkManager.
ResourceTreeModel was extracted as separate file.
FileSystem, Database, DOMStorage and ApplicationCache methods were
removed from NetworkManager and added to corresponding classes.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/CodeGeneratorInspector.pm:
- inspector/Inspector.idl:
- inspector/front-end/AuditRules.js: (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):
- inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback): (WebInspector.CSSStyleModel.prototype._styleSheetChanged):
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.addMessage): (WebInspector.ConsoleView.prototype.clearMessages):
- inspector/front-end/DOMAgent.js: (WebInspector.ApplicationCache.updateApplicationCacheStatus): (WebInspector.ApplicationCache.updateNetworkState):
- inspector/front-end/DOMStorage.js: (WebInspector.DOMStorage.addDOMStorage): (WebInspector.DOMStorage.selectDOMStorage): (WebInspector.DOMStorage.updateDOMStorage):
- inspector/front-end/Database.js: (WebInspector.Database.prototype.executeSql): (WebInspector.Database.addDatabase): (WebInspector.Database.selectDatabase): (WebInspector.Database.sqlTransactionSucceeded): (WebInspector.Database.sqlTransactionFailed):
- inspector/front-end/FileSystemView.js: (WebInspector.FileSystem.didGetFileSystemPath): (WebInspector.FileSystem.didGetFileSystemError): (WebInspector.FileSystem.didGetFileSystemDisabled):
- inspector/front-end/NetworkItemView.js: (WebInspector.NetworkItemView):
- inspector/front-end/NetworkManager.js: Added. (WebInspector.NetworkManager): (WebInspector.NetworkManager.prototype._createResource): (WebInspector.NetworkManager.prototype.identifierForInitialRequest): (WebInspector.NetworkManager.prototype.willSendRequest): (WebInspector.NetworkManager.prototype._updateResourceWithRequest): (WebInspector.NetworkManager.prototype._appendRedirect): (WebInspector.NetworkManager.prototype.markResourceAsCached): (WebInspector.NetworkManager.prototype.didReceiveResponse): (WebInspector.NetworkManager.prototype._updateResourceWithResponse): (WebInspector.NetworkManager.prototype.didReceiveContentLength): (WebInspector.NetworkManager.prototype.didFinishLoading): (WebInspector.NetworkManager.prototype.didFailLoading): (WebInspector.NetworkManager.prototype.didLoadResourceFromMemoryCache): (WebInspector.NetworkManager.prototype._updateResourceWithCachedResource): (WebInspector.NetworkManager.prototype.setInitialContent): (WebInspector.NetworkManager.prototype.didCommitLoadForFrame): (WebInspector.NetworkManager.prototype.frameDetachedFromParent): (WebInspector.NetworkManager.prototype.didCreateWebSocket): (WebInspector.NetworkManager.prototype.willSendWebSocketHandshakeRequest): (WebInspector.NetworkManager.prototype.didReceiveWebSocketHandshakeResponse): (WebInspector.NetworkManager.prototype.didCloseWebSocket): (WebInspector.NetworkManager.prototype._processCachedResources): (WebInspector.NetworkManager.prototype._addFramesRecursively): (WebInspector.NetworkManager.requestContent):
- inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.refreshResource):
- inspector/front-end/Resource.js: (WebInspector.Resource.prototype._innerRequestContent):
- inspector/front-end/ResourceManager.js: Removed.
- inspector/front-end/ResourceTreeModel.js: Added. (WebInspector.ResourceTreeModel): (WebInspector.ResourceTreeModel.prototype.addOrUpdateFrame): (WebInspector.ResourceTreeModel.prototype.didCommitLoadForFrame): (WebInspector.ResourceTreeModel.prototype.frameDetachedFromParent): (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources): (WebInspector.ResourceTreeModel.prototype.addResourceToFrame): (WebInspector.ResourceTreeModel.prototype._clearResources): (WebInspector.ResourceTreeModel.prototype.forAllResources): (WebInspector.ResourceTreeModel.prototype.addConsoleMessage): (WebInspector.ResourceTreeModel.prototype.clearConsoleMessages): (WebInspector.ResourceTreeModel.prototype._callForFrameResources): (WebInspector.ResourceTreeModel.prototype.resourceForURL): (WebInspector.ResourceTreeModel.prototype.bindResourceURL): (WebInspector.ResourceTreeModel.prototype._unbindResourceURL): (WebInspector.ResourceTreeModel.createResource):
- inspector/front-end/ResourceView.js: (WebInspector.ResourceView.createResourceView): (WebInspector.ResourceView.resourceViewTypeMatchesResource): (WebInspector.ResourceView.resourceViewForResource): (WebInspector.ResourceView.recreateResourceView): (WebInspector.ResourceView.existingResourceViewForResource):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.canShowSourceLine): (WebInspector.ResourcesPanel.prototype.showSourceLine): (WebInspector.ResourcesPanel.prototype.showResource): (WebInspector.ResourcesPanel.prototype.get searchableViews.callback): (WebInspector.ResourcesPanel.prototype.get searchableViews): (WebInspector.FrameResourceTreeElement.prototype._errorsWarningsUpdated): (WebInspector.FrameResourceTreeElement.prototype._contentChanged):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._addScript): (WebInspector.ScriptsPanel.prototype.reset): (WebInspector.ScriptsPanel.prototype._sourceFrameForResource): (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js: (WebInspector.forAllResources): (WebInspector.resourceForURL):
Dec 27, 2010:
- 9:33 PM Changeset in webkit [74708] by
-
- 5 edits in trunk/WebCore
2010-12-27 Helder Correia <helder@sencha.com>
Reviewed by Ariya Hidayat.
ContextShadow should use AffineTransform instead of TransformationMatrix
https://bugs.webkit.org/show_bug.cgi?id=51661
ContextShadow needs the CTM to make sure shadows are not affected by
transformations when drawing on a canvas. AffineTransform is sufficient
in this case.
Existing tests: fast/canvas/canvas*shadow*html
- platform/graphics/ContextShadow.cpp: (WebCore::ContextShadow::mustUseContextShadow): (WebCore::ContextShadow::adjustBlurDistance): (WebCore::ContextShadow::calculateLayerBoundingRect):
- platform/graphics/ContextShadow.h:
- platform/graphics/cairo/ContextShadowCairo.cpp: (WebCore::ContextShadow::getTransformationMatrixFromContext):
- platform/graphics/qt/ContextShadowQt.cpp: (WebCore::ContextShadow::getTransformationMatrixFromContext):
- 9:15 PM Changeset in webkit [74707] by
-
- 2 edits in trunk
2010-12-27 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by David Levin.
[EFL] Change path of eflsymbols.filter
https://bugs.webkit.org/show_bug.cgi?id=51659
- Sources/cmake/OptionsEfl.cmake:
- 6:05 PM Changeset in webkit [74706] by
-
- 2 edits in trunk/Tools
2010-12-27 Daniel Bates <dbates@rim.com>
Rubber-stamped by Martin Robinson.
Append the directory Tools/DumpRenderTree to the list of directories that
do-webcore-rename should search so that it can rename DRT files and
source code.
- Scripts/do-webcore-rename:
- 5:40 PM Changeset in webkit [74705] by
-
- 2 edits in trunk/LayoutTests
2010-12-27 Martin Robinson <mrobinson@igalia.com>
Reviewed by Daniel Bates.
Try to fix my previous commit for Mac by stepping up the precision of pi even more
using Math.PI.
- fast/canvas/canvas-save-restore-with-path.js: Use Math.PI instead of a hard-coded estimation.
- 5:39 PM Changeset in webkit [74704] by
-
- 2 edits in trunk/WebKit2
WebKit2 snapshots should contain accelerated content
<rdar://problem/8807393>
https://bugs.webkit.org/show_bug.cgi?id=51660
Reviewed by Anders Carlsson.
When creating a snapshot, flatten the layer tree for painting so that
accelerated content is included in the snapshot.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::snapshotInViewCoordinates):
(WebKit::WebPage::snapshotInDocumentCoordinates):
- 5:03 PM Changeset in webkit [74703] by
-
- 2 edits in trunk/WebKit2
2010-12-27 Daniel Bates <dbates@rim.com>
Attempt to fix the WebKit2 Windows build after changeset 74698
<http://trac.webkit.org/changeset/74698> (bug #51656).
Add "..\Shared\API\c\WKImage.h" to WebKit2Generated.make.
- win/WebKit2Generated.make:
- 4:50 PM Changeset in webkit [74702] by
-
- 2 edits in trunk/LayoutTests
2010-12-27 Kenneth Russell <kbr@google.com>
Unreviewed, Chromium test expectations update. Generalize
suppressions for Chromium bugs 67732 and 67139 to cover Linux
Debug.
- platform/chromium/test_expectations.txt:
- 4:44 PM Changeset in webkit [74701] by
-
- 1 edit in trunk/WebCore/ChangeLog
2010-12-27 Daniel Bates <dbates@rim.com>
Fix the first sentence of the change log message for changeset 74700
<http://trac.webkit.org/changeset/74700> (bug #51634).
As pointed out by Dan Bernstein, it should read: "Rename HTMLFrameElementBase::getMarginWidth()
and HTMLFrameElementBase::getMarginHeight() to HTMLFrameElementBase::marginWidth() and
HTMLFrameElementBase::marginHeight(), respectively."
- 4:21 PM Changeset in webkit [74700] by
-
- 7 edits in trunk/WebCore
2010-12-27 Daniel Bates <dbates@rim.com>
Reviewed by Antonio Gomes.
Clean up: Rename HTMLFrameElementBase::getMarginWidth() and HTMLFrameElementBase::getMarginHeight()
https://bugs.webkit.org/show_bug.cgi?id=51634
Rename HTMLFrameElementBase::getMarginWidth() and HTMLFrameElementBase::getMarginHeight()
to HTMLFrameElementBase::marginHeight() and HTMLFrameElementBase::marginHeight(), respectively.
This will make the names of these getters consistent with the naming convention we use for
getters.
- html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::insertedIntoDocument):
- html/HTMLFrameElementBase.h: (WebCore::HTMLFrameElementBase::marginWidth): Renamed; Formerly getMarginWidth(). (WebCore::HTMLFrameElementBase::marginHeight): Renamed; Formerly getMarginHeight().
- loader/SubframeLoader.cpp: (WebCore::SubframeLoader::loadSubframe):
- page/FrameView.cpp: (WebCore::FrameView::init):
- rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::viewCleared): Also renamed variables marginw and marginh to marginWidth and marginHeight, respectively. This makes the names of these variables consistent with the names of similar variables in SubframeLoader::loadSubframe() and FrameView::init().
- rendering/RenderFrame.cpp: (WebCore::RenderFrame::viewCleared): Ditto.
- 4:17 PM Changeset in webkit [74699] by
-
- 2 edits in trunk/LayoutTests
2010-12-27 Martin Robinson <mrobinson@igalia.com>
Reviewed by Daniel Bates.
[Cairo] fast/canvas/canvas-save-restore-with-path.html fails with some versions of Cairo
https://bugs.webkit.org/show_bug.cgi?id=51655
Increase the precision of pi used in this test case. It appears that
some Cairo versions or processors are sensitive to rounding errors here.
- fast/canvas/canvas-save-restore-with-path.js: Increase pi precision.
- 4:01 PM Changeset in webkit [74698] by
-
- 16 edits8 adds in trunk/WebKit2
WebKit2: Add API for getting snapshots
https://bugs.webkit.org/show_bug.cgi?id=51656
Reviewed by Anders Carlsson.
- Shared/API/c/WKBase.h:
- Shared/API/c/WKImage.cpp: Added.
(WKImageGetTypeID):
(WKImageCreate):
(WKImageGetSize):
- Shared/API/c/WKImage.h: Added.
- Shared/WebImage.cpp: Added.
(WebKit::WebImage::create):
(WebKit::WebImage::size):
- Shared/WebImage.h: Added.
(WebKit::WebImage::backingStore):
(WebKit::WebImage::WebImage):
(WebKit::WebImage::type):
Add a general purpose API image class.
- Shared/API/c/cg: Added.
- Shared/API/c/cg/WKImageCG.cpp: Added.
(WKImageCreateCGImage):
- Shared/API/c/cg/WKImageCG.h: Added.
Add function to convert a WKImageRef to a CGImageRef for platforms that use CG.
- Shared/API/c/WKSharedAPICast.h:
(WebKit::toFloatRect):
(WebKit::toIntSize):
(WebKit::toIntPoint):
(WebKit::toIntRect):
(WebKit::toImageOptions):
Make conversion functions that are ambiguous more explicit.
- Shared/APIObject.h:
- Shared/BackingStore.h:
(WebKit::BackingStore::isBackedBySharedMemory):
- Shared/ImageOptions.h: Added.
- Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
Allow a WKImageRef to be passed in user messages. Right now, it only
works if the image is sharable.
- UIProcess/API/C/WKPage.cpp:
(WKPageScaleWebView):
- UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::windowFrame):
Use the more explicit conversion function name.
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageCreateSnapshotInViewCoordinates):
(WKBundlePageCreateSnapshotInDocumentCoordinates):
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:
(WKBundlePageOverlaySetNeedsDisplay):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::snapshotInViewCoordinates):
(WebKit::WebPage::snapshotInDocumentCoordinates):
Add function to take the snapshot.
- WebProcess/WebPage/WebPage.h:
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
Add new files.
- 2:48 PM Changeset in webkit [74697] by
-
- 2 edits in trunk/WebKit/gtk
2010-12-27 Martin Robinson <mrobinson@igalia.com>
Reviewed by Ryosuke Niwa.
[GTK] EditorClient::generateEditorCommands queues up "null string" commands
https://bugs.webkit.org/show_bug.cgi?id=51569
Prevent adding "null string" editor commands by first checking whether or not
the command string is null in generateEditorCommands before appending it to the
list of pending editor command strings.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::generateEditorCommands): Check for the null string (no command for this key combination) before appending a command string to the list of pending editor commands. (WebKit::EditorClient::executePendingEditorCommands): Add an ASSERT which detects null command strings.
- 2:37 PM Changeset in webkit [74696] by
-
- 2 edits in trunk/WebCore
2010-12-27 Martin Robinson <mrobinson@igalia.com>
Reviewed by Daniel Bates.
[GTK] RenderThemeGtk::m_HScale and RenderThemeGtk::m_VScale are not initialized
https://bugs.webkit.org/show_bug.cgi?id=51654
Properly initialize slider members of RenderThemeGtk. This can lead to test crashes
on some debug configurations.
No new tests. This is already covered by current slider tests. It isn't crashing on
the bots, but it does crash locally.
- platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::RenderThemeGtk): Properly initialize members.
- 1:41 PM Changeset in webkit [74695] by
-
- 9 edits in trunk/JavaScriptCore
2010-12-27 Jake Helfert <jake@jakeonthenet.com>
Reviewed and reworked by Darin Adler.
Building WebKit with Visual Studio 2010 fails due
to ambiguous assignment operator errors.
https://bugs.webkit.org/show_bug.cgi?id=51116
- wtf/NullPtr.h: Added a HAVE(NULLPTR) definition for use with Platform.h HAVE macro, and included the Visual Studio 2010 compiler as one of the ones that has nullptr.
- wtf/NullPtr.cpp: Updated condition to match.
- wtf/PassOwnArrayPtr.h: Don't include the operator=(nullptr_t) overload if we are compiling in loose mode and the compiler has nullptr, because assignment of 0 will otherwise encounter ambiguitity with this overload and the overload for loose mode that takes a raw pointer. The conditional can be removed when we get rid of loose mode.
- wtf/PassOwnPtr.h: Ditto.
- wtf/PassRefPtr.h: Don't include the operator=(nullptr_t) overload if the compiler has nullptr, because assignment of 0 would be ambiguous with the overload that takes a raw pointer. The conditional can be removed if we ever decide we no longer need to support assigning 0, but might need a way to catch that usage on older compilers.
- wtf/RefPtr.h: Ditto.
- wtf/RetainPtr.h: Ditto
- JavaScriptCore.xcodeproj/project.pbxproj: Added NullPtr.cpp, accidentally omitted when the file was first added.
- 1:13 PM Changeset in webkit [74694] by
-
- 2 edits in trunk/Tools
2010-12-27 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
build-webkit should detect missing Java SDK and explain how to install it
https://bugs.webkit.org/show_bug.cgi?id=51651
- Scripts/build-webkit:
- 1:04 PM Changeset in webkit [74693] by
-
- 11 edits2 adds in trunk/WebKit2
WebKit2: Add additional API for managing databases
https://bugs.webkit.org/show_bug.cgi?id=51629
Reviewed by Anders Carlsson.
- Adds client for the database manager to get notifications of changes to databases.
- UIProcess/API/C/WKDatabaseManager.cpp:
(WKDatabaseManagerSetClient):
- UIProcess/API/C/WKDatabaseManager.h:
- UIProcess/WebDatabaseManagerProxy.cpp:
(WebKit::WebDatabaseManagerProxy::initializeClient):
(WebKit::WebDatabaseManagerProxy::didModifyOrigin):
(WebKit::WebDatabaseManagerProxy::didModifyDatabase):
- UIProcess/WebDatabaseManagerProxy.h:
- UIProcess/WebDatabaseManagerProxy.messages.in:
- UIProcess/WebDatabaseManagerProxyClient.cpp: Added.
(WebKit::WebDatabaseManagerProxyClient::didModifyOrigin):
(WebKit::WebDatabaseManagerProxyClient::didModifyDatabase):
- UIProcess/WebDatabaseManagerProxyClient.h: Added.
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebCoreSupport/WebDatabaseManager.cpp:
(WebKit::WebDatabaseManager::WebDatabaseManager):
(WebKit::WebDatabaseManager::~WebDatabaseManager):
(WebKit::WebDatabaseManager::dispatchDidModifyOrigin):
(WebKit::WebDatabaseManager::dispatchDidModifyDatabase):
- WebProcess/WebCoreSupport/WebDatabaseManager.h:
- win/WebKit2.vcproj:
- 11:41 AM Changeset in webkit [74692] by
-
- 1 edit2 adds in trunk/Sources
Fix Makefile based build.
- 11:21 AM Changeset in webkit [74691] by
-
- 4 edits in trunk/WebKit/gtk
2010-12-27 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
Remove unneeded includes from our headers.
- WebCoreSupport/PasteboardHelperGtk.h: ditto.
- webkit/webkitprivate.h: ditto.
- webkit/webkitsoupauthdialog.h: ditto.
- 11:17 AM Changeset in webkit [74690] by
-
- 13 edits2 adds in trunk/WebKit2
WebKit2: Add additional API for managing databases
https://bugs.webkit.org/show_bug.cgi?id=51629
Reviewed by Anders Carlsson.
- Adds WKDatabaseManagerGetDatabasesByOrigin, which asynchronously returns an array of dictionaries containing details about each origin using databases and details about each database. Keys were added for accessing the data in the dictionaries.
- Adds WKDatabaseManagerDeleteDatabasesWithNameForOrigin to delete a database with a specific identifier.
- Adds WKDatabaseManagerSetQuotaForOrigin to set the quota for an origin.
- Shared/OriginAndDatabases.cpp: Added.
(WebKit::OriginAndDatabases::encode):
(WebKit::OriginAndDatabases::decode):
- Shared/OriginAndDatabases.h: Added.
- Shared/WebCoreArgumentCoders.h:
- UIProcess/API/C/WKDatabaseManager.cpp:
(WKDatabaseManagerGetOriginKey):
(WKDatabaseManagerGetOriginQuotaKey):
(WKDatabaseManagerGetOriginUsageKey):
(WKDatabaseManagerGetDatabaseDetailsKey):
(WKDatabaseManagerGetDatabaseDetailsNameKey):
(WKDatabaseManagerGetDatabaseDetailsDisplayNameKey):
(WKDatabaseManagerGetDatabaseDetailsExpectedUsageKey):
(WKDatabaseManagerGetDatabaseDetailsCurrentUsageKey):
(WKDatabaseManagerGetDatabasesByOrigin):
(callGetDatabasesByOriginBlockAndDispose):
(WKDatabaseManagerGetDatabasesByOrigin_b):
(WKDatabaseManagerGetDatabaseOrigins):
(callGetDatabaseOriginsBlockBlockAndDispose):
(WKDatabaseManagerGetDatabaseOrigins_b):
(WKDatabaseManagerDeleteDatabasesWithNameForOrigin):
(WKDatabaseManagerDeleteDatabasesForOrigin):
(WKDatabaseManagerDeleteAllDatabases):
(WKDatabaseManagerSetQuotaForOrigin):
- UIProcess/API/C/WKDatabaseManager.h:
- UIProcess/WebDatabaseManagerProxy.cpp:
(WebKit::WebDatabaseManagerProxy::originKey):
(WebKit::WebDatabaseManagerProxy::originQuotaKey):
(WebKit::WebDatabaseManagerProxy::originUsageKey):
(WebKit::WebDatabaseManagerProxy::databaseDetailsKey):
(WebKit::WebDatabaseManagerProxy::databaseDetailsNameKey):
(WebKit::WebDatabaseManagerProxy::databaseDetailsDisplayNameKey):
(WebKit::WebDatabaseManagerProxy::databaseDetailsExpectedUsageKey):
(WebKit::WebDatabaseManagerProxy::databaseDetailsCurrentUsageKey):
(WebKit::WebDatabaseManagerProxy::invalidate):
(WebKit::WebDatabaseManagerProxy::getDatabasesByOrigin):
(WebKit::WebDatabaseManagerProxy::didGetDatabasesByOrigin):
(WebKit::WebDatabaseManagerProxy::getDatabaseOrigins):
(WebKit::WebDatabaseManagerProxy::didGetDatabaseOrigins):
(WebKit::WebDatabaseManagerProxy::deleteDatabaseWithNameForOrigin):
(WebKit::WebDatabaseManagerProxy::deleteDatabasesForOrigin):
(WebKit::WebDatabaseManagerProxy::setQuotaForOrigin):
- UIProcess/WebDatabaseManagerProxy.h:
- UIProcess/WebDatabaseManagerProxy.messages.in:
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebCoreSupport/WebDatabaseManager.cpp:
(WebKit::WebDatabaseManager::getDatabasesByOrigin):
(WebKit::WebDatabaseManager::deleteDatabaseWithNameForOrigin):
(WebKit::WebDatabaseManager::setQuotaForOrigin):
- WebProcess/WebCoreSupport/WebDatabaseManager.h:
- WebProcess/WebCoreSupport/WebDatabaseManager.messages.in:
- win/WebKit2.vcproj:
- 11:07 AM Changeset in webkit [74689] by
-
- 4 edits in trunk/Tools
2010-12-26 Martin Robinson <mrobinson@igalia.com>
Reviewed by Daniel Bates.
[GTK] Add support for build-jsc
https://bugs.webkit.org/show_bug.cgi?id=51625
Add GTK+ support to build-jsc now that building the jsc executable as
a standalone target is easy.
- Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
- Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
- Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject and pass it along to buildAutotoolsProject.
- 10:50 AM Changeset in webkit [74688] by
-
- 4 edits in trunk/Tools
check-webkit-style check for meaningless variable names in function declarations.
https://bugs.webkit.org/show_bug.cgi?id=51523
Reviewed by Eric Seidel.
- Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
from the new check and whitespace/parens because the syntax is unusual and
produced a fair number of positives for these checks.
- Scripts/webkitpy/style/checkers/cpp.py:
(_convert_to_lower_with_underscores): Used as a canonical form for type names
and parameter names when determining if the parameter name is useless.
(_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
(Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
format.
(_check_parameter_name_against_text): Checks to see if the parameter name is in the
text or an acronym of it.
(check_function_definition): Checks function definitions for meaningless variable names.
(process_line): Added call to check_function_definition.
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
(CppFunctionsTest.test_create_acronym): Test for _create_acronym.
(CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
(CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
because when only checking a snippet, there are a lot of bogus functions.
(CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
that I put there previously and just noticed.
(WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
check_function_definition and process_line.
- 10:46 AM Changeset in webkit [74687] by
-
- 2 edits in trunk/LayoutTests
2010-12-27 Kenji Imasaki <imasaki@chromium.org>
Reviewed by David Levin.
remove entries for media related non-flaky tests.
https://bugs.webkit.org/show_bug.cgi?id=51225
- platform/chromium/test_expectations.txt:
- 9:41 AM Changeset in webkit [74686] by
-
- 5 edits in trunk/WebCore
2010-12-27 Anton Muhin <antonm@chromium.org>
Reviewed by David Levin.
[v8] Remove unused methods to protect/unprotect wrappers during garbage collection
https://bugs.webkit.org/show_bug.cgi?id=51648
- bindings/v8/ScriptController.cpp:
- bindings/v8/ScriptController.h:
- bindings/v8/V8GCController.cpp: (WebCore::V8GCController::gcEpilogue):
- bindings/v8/V8GCController.h:
- 9:37 AM Changeset in webkit [74685] by
-
- 2 edits in trunk/Tools
2010-12-27 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Disable flash plugin in GtkLauncher when using gtk3
https://bugs.webkit.org/show_bug.cgi?id=51591
Flash plugin uses gtk2 that is incompatible with gtk3 making
webkit crash when it's built with gtk3.
- GtkLauncher/main.c: (main):
- 9:10 AM Changeset in webkit [74684] by
-
- 2 edits in trunk/WebKit/efl
2010-12-27 Rafael Antognolli <antognolli@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Set the frame smart object base clipper to non-static.
https://bugs.webkit.org/show_bug.cgi?id=51552
The base clipper of the clipped smart object, which is the parent
class of the ewk_frame class is a static clipper. It's normally only
used for showing/hiding the object, but in the case of the ewk_frame,
it needs to clip the object to its dimension, in order to clip
scrollbars of inner frames.
Setting it to non-static makes the clipper to be automatically moved
by the parent class, thus staying on the correct position when the
frame is moved.
This change needed to be done after the adoption of the static clipper
on the clipped smart base class.
- ewk/ewk_frame.cpp: (_ewk_frame_smart_add):
- 6:51 AM Changeset in webkit [74683] by
-
- 2 edits in trunk/WebCore
2010-12-27 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Removed trailing spaces from a localized
string to make it the same as the one used in the code.
- English.lproj/localizedStrings.js:
- 6:36 AM Changeset in webkit [74682] by
-
- 2 edits in trunk/LayoutTests
2010-12-27 Philippe Normand <pnormand@igalia.com>
Unreviewed, skip another GTK media test reporting wrong duration,
see bug 51602.
- platform/gtk/Skipped:
- 6:10 AM Changeset in webkit [74681] by
-
- 6 edits in trunk
2010-12-27 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Eric Seidel.
Browser is failing 16 baseline test from Selector API Test Suite
https://bugs.webkit.org/show_bug.cgi?id=42968
Update the expected result for the test.
- fast/dom/SelectorAPI/resig-SelectorsAPI-test-expected.txt:
2010-12-27 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Eric Seidel.
Browser is failing 16 baseline test from Selector API Test Suite
https://bugs.webkit.org/show_bug.cgi?id=42968
Throw an exception if there is no argument to querySelector or
querySelectorAll. This replaces the current behavior of passing the string
"undefined" as the argument.
No new tests, just updating the existing results for
fast/dom/SelectorAPI/resig-SelectorAPI-test.xhtml.
- dom/Document.idl:
- dom/DocumentFragment.idl:
- dom/Element.idl:
- 3:32 AM Changeset in webkit [74680] by
-
- 2 edits in trunk/LayoutTests
2010-12-27 Shinichiro Hamaji <shinichiro.hamaji@gmail.com>
Chromium expectation update.
Suppress fast/canvas/webgl/tex-image-with-format-and-type on linux debug
- platform/chromium/test_expectations.txt:
- 12:06 AM Changeset in webkit [74679] by
-
- 1 edit4 adds in trunk/LayoutTests
2010-12-27 MORITA Hajime <morrita@google.com>
Unreviewed expectation updates.
- platform/chromium-linux/fast/box-shadow/spread-multiple-normal-expected.checksum: Added.
- platform/chromium-linux/fast/box-shadow/spread-multiple-normal-expected.png: Added.
- platform/chromium-win/fast/box-shadow/spread-multiple-normal-expected.checksum: Added.
- platform/chromium-win/fast/box-shadow/spread-multiple-normal-expected.png: Added.
