⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 29, 2010:

11:55 PM Changeset in webkit [74786] by inferno@chromium.org
  • 4 edits in trunk/LayoutTests

2010-12-29 Abhishek Arya <​inferno@chromium.org>

Unreviewed.

Add 'PASS' to layout test since test failing on chromium due to empty expectations.
Filed webkit bug 51734 to track gtk test failure and skipping test for now.

  • fast/multicol/span/double-merge-anonymous-block-crash-expected.txt:
  • fast/multicol/span/double-merge-anonymous-block-crash.html:
  • platform/gtk/Skipped:
11:41 PM Changeset in webkit [74785] by pfeldman@chromium.org
  • 15 edits
    1 copy
    2 moves
    1 add
    2 deletes in trunk

2010-12-29 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: extract Database & DOM Storage agents; remove InspectorBackend.
​https://bugs.webkit.org/show_bug.cgi?id=51707

This change brushes up storage agents + removes redundant InspectorBackend class.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/CodeGeneratorInspector.pm:
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::databaseForId): (WebCore::InjectedScriptHost::selectDatabase): (WebCore::InjectedScriptHost::selectDOMStorage): (WebCore::InjectedScriptHost::inspectorDOMAgent):
  • inspector/Inspector.idl:
  • inspector/InspectorBackend.cpp: Removed.
  • inspector/InspectorBackend.h: Removed.
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::releaseFrontendLifetimeAgents): (WebCore::InspectorController::didUseDOMStorage): (WebCore::InspectorController::setInjectedScriptSource): (WebCore::InspectorController::dispatchOnInjectedScript): (WebCore::InspectorController::releaseWrapperObjectGroup):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMStorageAgent.cpp: Added. (WebCore::InspectorDOMStorageAgent::~InspectorDOMStorageAgent): (WebCore::InspectorDOMStorageAgent::getDOMStorageEntries): (WebCore::InspectorDOMStorageAgent::setDOMStorageItem): (WebCore::InspectorDOMStorageAgent::removeDOMStorageItem): (WebCore::InspectorDOMStorageAgent::selectDOMStorage): (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent): (WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
  • inspector/InspectorDOMStorageAgent.h: Copied from WebCore/inspector/InspectorStorageAgent.h. (WebCore::InspectorDOMStorageAgent::create): (WebCore::InspectorDOMStorageAgent::frontend):
  • inspector/InspectorDatabaseAgent.cpp: Renamed from WebCore/inspector/InspectorStorageAgent.cpp. (WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent): (WebCore::InspectorDatabaseAgent::getDatabaseTableNames): (WebCore::InspectorDatabaseAgent::executeSQL): (WebCore::InspectorDatabaseAgent::databaseForId): (WebCore::InspectorDatabaseAgent::selectDatabase): (WebCore::InspectorDatabaseAgent::clearFrontend): (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
  • inspector/InspectorDatabaseAgent.h: Renamed from WebCore/inspector/InspectorStorageAgent.h. (WebCore::InspectorDatabaseAgent::create): (WebCore::InspectorDatabaseAgent::frontend):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.show): (WebInspector.ScriptsPanel.prototype.attachDebuggerWhenShown): (WebInspector.ScriptsPanel.prototype._toggleDebugging):
11:20 PM Changeset in webkit [74784] by Patrick Gansterer
  • 2 edits in trunk/Tools

2010-12-29 Patrick Gansterer <Patrick Gansterer>

Unreviewed WinCE buildfix.

  • WinCELauncher/main.cpp: Add missing include.
11:00 PM Changeset in webkit [74783] by krit@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

2010-12-29 Dirk Schulze <​krit@webkit.org>

Unreviewed fix of the misspelled email address in commit 74782.

10:49 PM Changeset in webkit [74782] by krit@webkit.org
  • 32 edits in trunk/WebCore

2010-12-29 Dirk Schulze <​krit@wbekit.org>

Reviewed by Darin Adler.

Cleanup SVG code according to the webkit style rules 3
​https://bugs.webkit.org/show_bug.cgi?id=51490

Last patch to fix indention and other style issues according to the WebKit style rules in the SVG code.
Just one file can't be fixed for check-webkit-style.

  • SVGAllInOne.cpp: check-webkit-style wants a config.h at the beginning

No changes of functionality, so no new tests.

  • svg/SVGAllInOne.cpp:
  • svg/SVGImage.cpp:
  • svg/SVGLength.cpp: (WebCore::SVGLength::setValue):
  • svg/SVGPolygonElement.h:
  • svg/SVGPolylineElement.h:
  • svg/SVGPreserveAspectRatio.cpp: (WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio): (WebCore::SVGPreserveAspectRatio::transformRect):
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::viewport):
  • svg/SVGSetElement.h:
  • svg/SVGStylable.h: (WebCore::SVGStylable::~SVGStylable):
  • svg/SVGStyledLocatableElement.h: (WebCore::SVGStyledLocatableElement::localCoordinateSpaceTransform): (WebCore::SVGStyledLocatableElement::isStyledLocatable):
  • svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::isKnownAttribute):
  • svg/SVGSwitchElement.cpp: (WebCore::SVGSwitchElement::childShouldCreateRenderer):
  • svg/SVGTests.cpp: (WebCore::SVGTests::parseMappedAttribute):
  • svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::isKnownAttribute):
  • svg/SVGTextPathElement.cpp:
  • svg/SVGTextPathElement.h:
  • svg/SVGTitleElement.h: (WebCore::SVGTitleElement::rendererIsNeeded):
  • svg/SVGTransformDistance.cpp: (WebCore::SVGTransformDistance::SVGTransformDistance): (WebCore::SVGTransformDistance::scaledDistance): (WebCore::SVGTransformDistance::addSVGTransforms): (WebCore::SVGTransformDistance::addSVGTransform): (WebCore::SVGTransformDistance::addToSVGTransform): (WebCore::SVGTransformDistance::isZero):
  • svg/SVGTransformList.cpp:
  • svg/SVGURIReference.cpp: (WebCore::SVGURIReference::getTarget):
  • svg/SVGVKernElement.h:
  • svg/SVGViewSpec.cpp: (WebCore::SVGViewSpec::parseViewSpec):
  • svg/SVGZoomAndPan.h: (WebCore::SVGZoomAndPan::SVGZoomAndPan): (WebCore::SVGZoomAndPan::~SVGZoomAndPan): (WebCore::SVGZoomAndPan::zoomAndPan):
  • svg/SVGZoomEvent.h: (WebCore::SVGZoomEvent::create):
  • svg/animation/SMILTime.cpp: (WebCore::operator*):
  • svg/animation/SMILTime.h: (WebCore::SMILTime::SMILTime): (WebCore::SMILTime::unresolved): (WebCore::SMILTime::indefinite): (WebCore::SMILTime::operator=): (WebCore::SMILTime::value): (WebCore::SMILTime::isFinite): (WebCore::SMILTime::isIndefinite): (WebCore::SMILTime::isUnresolved): (WebCore::operator==): (WebCore::operator!): new operator checks for 0 or infinite values. (WebCore::operator!=): (WebCore::operator>): (WebCore::operator<): (WebCore::operator>=): (WebCore::operator<=):
  • svg/animation/SMILTimeContainer.h: (WebCore::SMILTimeContainer::create): (WebCore::SMILTimeContainer::setDocumentOrderIndexesDirty):
  • svg/animation/SVGSMILElement.cpp: (WebCore::ConditionEventListener::operator==): (WebCore::SVGSMILElement::repeatingDuration): (WebCore::SVGSMILElement::resolveInterval): (WebCore::SVGSMILElement::calculateAnimationPercentAndRepeat):
  • svg/animation/SVGSMILElement.h: (WebCore::SVGSMILElement::timeContainer): (WebCore::SVGSMILElement::intervalBegin): (WebCore::SVGSMILElement::intervalEnd): (WebCore::SVGSMILElement::previousIntervalBegin): (WebCore::SVGSMILElement::documentOrderIndex): (WebCore::SVGSMILElement::setDocumentOrderIndex):
  • svg/graphics/SVGImage.h: (WebCore::SVGImage::create): (WebCore::SVGImage::destroyDecodedData): (WebCore::SVGImage::decodedSize): (WebCore::SVGImage::frameAtIndex):
  • svg/graphics/filters/SVGFilterBuilder.h: (WebCore::SVGFilterBuilder::create): (WebCore::SVGFilterBuilder::lastEffect): (WebCore::SVGFilterBuilder::getEffectReferences): (WebCore::SVGFilterBuilder::addBuiltinEffects):
10:36 PM Changeset in webkit [74781] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2010-12-29 Abhishek Arya <​inferno@chromium.org>

Reviewed by Darin Adler.

ASSERT(oldchild->parent() == owner) fails.
​https://bugs.webkit.org/show_bug.cgi?id=50480

In RenderBlock removeChild function, when the inlineChildrenBlock(equal to prev or next)
is reparented to blockChildrenBlock, it is no longer a child of "this". This causes the
assertion failure when removeChildNode executes on the child(equal to prev or next).
Fix a typo in canMergeContiguousAnonymousBlocks.

Test: fast/multicol/span/double-merge-anonymous-block-crash.html

  • rendering/RenderBlock.cpp: (WebCore::canMergeContiguousAnonymousBlocks): fix typo, change prev to next. (WebCore::RenderBlock::removeChild): if prev or not is reparented, then set it to zero.

2010-12-29 Abhishek Arya <​inferno@chromium.org>

Reviewed by Darin Adler.

Tests that we do not crash when merging anonymous blocks.
​https://bugs.webkit.org/show_bug.cgi?id=50480

  • fast/multicol/span/double-merge-anonymous-block-crash-expected.txt: Added.
  • fast/multicol/span/double-merge-anonymous-block-crash.html: Added.
10:03 PM Changeset in webkit [74780] by dbates@webkit.org
  • 3 edits
    1 add in trunk/Tools

2010-12-29 Daniel Bates <​dbates@rim.com>

Reviewed by Darin Adler.

svn-apply updates date of wrong change log entry for a change log diff that
contains two consecutive entries with the same author and date
​https://bugs.webkit.org/show_bug.cgi?id=46061

Fixes an issue where the date of the wrong change log entry may be modified.
Moreover, changes fixChangeLogPatch() to move entries inserted earlier
in a ChangeLog file to the top of the file.

Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
diff when it detects that the diff inserts a change log entry earlier in a
ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
change. With the advent of the commit-queue this functionality of bailing out
and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
Instead, we should always move the change log entry to the top of the ChangeLog file.

A side-effect of this change is that setChangeLogDateAndReviewer() now updates
the date line of the correct change log entry in a ChangeLog diff.

  • Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
  • Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl: Updated the following unit tests now that we move entries inserted earlier to the top:
    • "fixChangeLogPatch: New entry inserted in middle." (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
  • "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date." (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
  • Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
9:43 PM Changeset in webkit [74779] by jschuh@chromium.org
  • 3 edits
    2 adds in trunk

2010-12-29 Justin Schuh <​jschuh@chromium.org>

Reviewed by Darin Adler.

Check SVG element type in FrameView::scrollToAnchor
​https://bugs.webkit.org/show_bug.cgi?id=51718

Test: svg/custom/scroll-to-anchor-in-symbol.svg

  • page/FrameView.cpp: (WebCore::FrameView::scrollToAnchor):

2010-12-29 Justin Schuh <​jschuh@chromium.org>

Reviewed by Darin Adler.

Check SVG element type in FrameView::scrollToAnchor
​https://bugs.webkit.org/show_bug.cgi?id=51718

  • svg/custom/scroll-to-anchor-in-symbol-expected.txt: Added.
  • svg/custom/scroll-to-anchor-in-symbol.svg: Added.
8:07 PM Changeset in webkit [74778] by antonm@chromium.org
  • 3 edits in trunk/WebCore

2010-12-29 Anton Muhin <​antonm@chromium.org>

Reviewed by Eric Seidel.

[v8] Minor cleanup: remove unused method (the only method which can mutate context of V8DOMWindowShell)
​https://bugs.webkit.org/show_bug.cgi?id=51704

  • bindings/v8/V8DOMWindowShell.cpp:
  • bindings/v8/V8DOMWindowShell.h:
7:54 PM Changeset in webkit [74777] by zmo@google.com
  • 3 edits in trunk/LayoutTests

2010-12-29 Zhenyao Mo <​zmo@google.com>

Reviewed by Eric Seidel.

drawElements should raise INVALID_OPERATION if offset is not a multiple of the type size
​https://bugs.webkit.org/show_bug.cgi?id=51726

  • fast/canvas/webgl/draw-elements-out-of-bounds-expected.txt:
  • fast/canvas/webgl/draw-elements-out-of-bounds.html: Add test cases to verify the behavior.
7:16 PM Changeset in webkit [74776] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2010-12-29 Konstantin Tokarev <Konstantin Tokarev>

Reviewed by Eric Seidel.

[Qt] Fixed compatibility with gold linker on X11 platforms
​https://bugs.webkit.org/show_bug.cgi?id=51700

  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Linked TestNetscapePlugin with libX11 on Unix platforms
7:16 PM Changeset in webkit [74775] by commit-queue@webkit.org
  • 7 edits in trunk/WebCore

2010-12-29 Kenichi Ishibashi <​bashi@google.com>

Reviewed by Darin Adler.

Use a HashMap for m_continuation to save memory
​https://bugs.webkit.org/show_bug.cgi?id=43716

Saving memory consumption by applying a HashMap convention to
continuation pointers of RenderInline and RenderBlock classes.

  • rendering/RenderBlock.cpp: Removed m_continuation. (WebCore::RenderBlock::RenderBlock): (WebCore::RenderBlock::destroy): (WebCore::RenderBlock::inlineElementContinuation): (WebCore::RenderBlock::blockElementContinuation):
  • rendering/RenderBlock.h: Removed m_continuation.
  • rendering/RenderBoxModelObject.cpp: Added a hash map for continuations. (WebCore::RenderBoxModelObject::destroy): Added an assertion. (WebCore::RenderBoxModelObject::continuation): Added. (WebCore::RenderBoxModelObject::setContinuation): Added.
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderInline.cpp: Removed m_continuation. (WebCore::RenderInline::RenderInline): (WebCore::RenderInline::destroy): (WebCore::RenderInline::inlineElementContinuation):
  • rendering/RenderInline.h: Removed m_continuation.
6:08 PM Changeset in webkit [74774] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2010-12-29 Ademar de Souza Reis Jr <Ademar Reis>

Reviewed by Darin Adler.

Circular dependency in webkitpy.common.checkout.changelog module
​https://bugs.webkit.org/show_bug.cgi?id=50475

Remove automatic import of api.Checkout module when any checkout/
submodule is imported (e.g.: when checkout.scm.Git is imported).

  • Scripts/webkitpy/common/checkout/init.py:
5:16 PM Changeset in webkit [74773] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-29 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update.

Remove failing expectations for three Mac tests that no longer fail.
Remove failing expectations for two canvas tests that no longer crash
(r74561, which caused the failing assert, was rolled out with r74587).

  • platform/chromium/test_expectations.txt:
5:05 PM Changeset in webkit [74772] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-29 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update.
fast/js/numeric-escapes-in-string-literals.html fails because V8 does
not support ECMAScript strict mode.

  • platform/chromium/test_expectations.txt:
5:00 PM Changeset in webkit [74771] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-29 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update. Mark two more inspector tests
as flaky.

  • platform/chromium/test_expectations.txt:
4:44 PM Changeset in webkit [74770] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-29 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update. Mark a few more tests as flaky.

  • platform/chromium/test_expectations.txt:
4:14 PM Changeset in webkit [74769] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-29 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update.

fast/canvas/shadow-offset-* are flaky when run in the GPU suite too.

  • platform/chromium-gpu/test_expectations.txt:
4:11 PM Changeset in webkit [74768] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-29 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update.

Make expectation for http/tests/media/reload-after-dialog.html not
trigger a duplication error for the debug Linux builder.

Remove expectation for platform/gtk/fast/text/emphasis-overlap.html, it
was removed in r74346.

  • platform/chromium/test_expectations.txt:
4:00 PM Changeset in webkit [74767] by barraclough@apple.com
  • 3 edits
    3 adds in trunk

Bug 51724 - In strict mode string literals should allow \0, but disallow \8 and \9.

Reviewed by Sam Weinig.

JavaScriptCore:

  • parser/Lexer.cpp:

(JSC::Lexer::parseString):

LayoutTests:

  • fast/js/numeric-escapes-in-string-literals-expected.txt: Added.
  • fast/js/numeric-escapes-in-string-literals.html: Added.
  • fast/js/script-tests/numeric-escapes-in-string-literals.js: Added.

(test):

3:46 PM Changeset in webkit [74766] by Martin Robinson
  • 8 edits
    2 adds in trunk

2010-12-27 Amruth Raj <​amruthraj@motorola.com> and Ravi Kasibhatla <​ravi.kasibhatla@motorola.com>

Reviewed by Martin Robinson.

[GTK] Enable building whatever already exists of WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=37369

No new functionality added or deleted. Only makefile change. Hence, no tests added.

  • GNUmakefile.am: Removed bindings/gobject from webcore_sources & webcore_cppflags and added them to WebKit/gtk/GNUmakefile.am
  • platform/network/soup/cache/webkit/soup-cache.h: Remove include <webkit/webkitdefines.h> and declare WEBKIT_API directly

2010-12-15 Amruth Raj <​amruthraj@motorola.com> and Ravi Kasibhatla <​ravi.kasibhatla@motorola.com>

Reviewed by Martin Robinson.

[GTK] Enable building whatever already exists of WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=37369

  • GNUmakefile.am: Added.
  • WebKit2Prefix.h: Included WebCore/config.h for GTK port as the first header file for WebKit2 sources files.
  • gtk: Added.
  • gtk/webkit2.pc.in: Added.
2:58 PM Changeset in webkit [74765] by Martin Robinson
  • 2 edits in trunk/WebKit/gtk

2010-12-29 Martin Robinson <​mrobinson@igalia.com>

Build fix for GTK+.

  • webkit/webkitwebinspector.cpp: Add missing DumpRenderTreeSupportGtk include.
2:57 PM Changeset in webkit [74764] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-12-29 Eric Seidel <​eric@webkit.org>

Unreviewed.

Simplify make-hash-tools.pl
​https://bugs.webkit.org/show_bug.cgi?id=49922

Added HashTools.h to the project file now that its not autogenerated.
I also sorted the project file using sort-xcode-project-file

  • WebCore.xcodeproj/project.pbxproj:
2:56 PM Changeset in webkit [74763] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-29 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update. Mark another test as flaky.

  • platform/chromium/test_expectations.txt:
2:34 PM Changeset in webkit [74762] by Martin Robinson
  • 2 edits in trunk/WebKit/gtk

2010-12-29 Martin Robinson <​mrobinson@igalia.com>

[GTK] GSettings warning is concealing real warnings on the build bots
​https://bugs.webkit.org/show_bug.cgi?id=51691

Reviewed by Xan Lopez.

Do not print the GSettings warning message when running in DumpRenderTree.

  • webkit/webkitwebinspector.cpp: (inspectorGSettings): Do not print the GSettings warning if we are running in DumpRenderTree. This should clean up the test results page a great deal.
2:22 PM Changeset in webkit [74761] by pfeldman@chromium.org
  • 15 edits
    1 copy
    2 moves
    1 add
    2 deletes in trunk

2010-12-29 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: revert r74755 and 74757.

2:20 PM Changeset in webkit [74760] by Martin Robinson
  • 2 edits in trunk/WebCore

2010-12-29 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Sam Weinig.

JSDataViewCustom.cpp gives the fastcall calling convention to functions called via C++
​https://bugs.webkit.org/show_bug.cgi?id=51722

Remove the JSC_HOST_CALL from methods that are called from C++. JSC_HOST_CALL gives
methods the fastcall calling convention, which leads to runtime errors when they are
called from C++. Also remove a bit of unnecessary code duplication.

No new tests. This is covered by fast/canvas/webgl/data-view-test.html.

  • bindings/js/JSDataViewCustom.cpp: (WebCore::getDataViewMember): Remove duplicated code. (WebCore::JSDataView::getInt8): Remove JSC_HOST_CALL. (WebCore::JSDataView::getUint8): Ditto. (WebCore::JSDataView::getFloat32): Ditto. (WebCore::JSDataView::getFloat64): Ditto. (WebCore::setDataViewMember): Remove duplicated code. (WebCore::JSDataView::setInt8): Remove JSC_HOST_CALL. (WebCore::JSDataView::setUint8): Ditto.
2:18 PM Changeset in webkit [74759] by mitz@apple.com
  • 5 edits in trunk/WebCore

A more robust fix for ​https://bugs.webkit.org/show_bug.cgi?id=51681

Reviewed by Kenneth Russel.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::attach): Added. Like recalcStyle(), calls
CanvasRenderingContext2D::updateFont() if necessary. This covers the case of a detach/
attach-type style recalc.

  • html/HTMLCanvasElement.h:
  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawTextInternal): Removed the early return added in
r74716. A font that is loading custom fonts is okay to use, as long as it is valid.
(WebCore::CanvasRenderingContext2D::accessFont): Added a call to
Document::updateStyleIfNeeded(). This ensures that any pending style recalc will take place
and update the font if it is invalid.

  • platform/graphics/Font.h:

(WebCore::Font::loadingCustomFonts): Made this private.

1:43 PM Changeset in webkit [74758] by mihaip@chromium.org
  • 3 edits in trunk/LayoutTests

2010-12-29 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update.

fast/canvas/webgl/tex-image-with-format-and-type.html is flaky in
the GPU suite too.

  • platform/chromium/test_expectations.txt:
  • platform/chromium-gpu/test_expectations.txt:
1:39 PM Changeset in webkit [74757] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-12-29 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: Qt build fix.

  • inspector/InspectorController.cpp:
1:38 PM Changeset in webkit [74756] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-29 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update.

Remove failure expectations for tests that no longer fail:

  • fast/images/svg-as-background.html has not timed out for as long as the flakiness dashboard has history
  • svg/W3C-SVG-1.1/animate-elem-03-t.svg has not failed for as long as the flakiness dashboard has history
  • platform/chromium/test_expectations.txt:
1:30 PM Changeset in webkit [74755] by pfeldman@chromium.org
  • 15 edits
    1 copy
    2 moves
    1 add
    2 deletes in trunk

2010-12-29 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: extract Database & DOM Storage
agents; remove InspectorBackend.
​https://bugs.webkit.org/show_bug.cgi?id=51707

This change brushes up storage agents + removes redundant
InspectorBackend class.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/CodeGeneratorInspector.pm:
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::databaseForId): (WebCore::InjectedScriptHost::selectDatabase): (WebCore::InjectedScriptHost::selectDOMStorage): (WebCore::InjectedScriptHost::inspectorDOMAgent):
  • inspector/Inspector.idl:
  • inspector/InspectorBackend.cpp: Removed.
  • inspector/InspectorBackend.h: Removed.
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::releaseFrontendLifetimeAgents): (WebCore::InspectorController::didUseDOMStorage): (WebCore::InspectorController::setInjectedScriptSource): (WebCore::InspectorController::dispatchOnInjectedScript): (WebCore::InspectorController::releaseWrapperObjectGroup):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMStorageAgent.cpp: Added. (WebCore::InspectorDOMStorageAgent::~InspectorDOMStorageAgent): (WebCore::InspectorDOMStorageAgent::getDOMStorageEntries): (WebCore::InspectorDOMStorageAgent::setDOMStorageItem): (WebCore::InspectorDOMStorageAgent::removeDOMStorageItem): (WebCore::InspectorDOMStorageAgent::selectDOMStorage): (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent): (WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
  • inspector/InspectorDOMStorageAgent.h: Copied from WebCore/inspector/InspectorStorageAgent.h. (WebCore::InspectorDOMStorageAgent::create): (WebCore::InspectorDOMStorageAgent::frontend):
  • inspector/InspectorDatabaseAgent.cpp: Renamed from WebCore/inspector/InspectorStorageAgent.cpp. (WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent): (WebCore::InspectorDatabaseAgent::getDatabaseTableNames): (WebCore::InspectorDatabaseAgent::executeSQL): (WebCore::InspectorDatabaseAgent::databaseForId): (WebCore::InspectorDatabaseAgent::selectDatabase): (WebCore::InspectorDatabaseAgent::clearFrontend): (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
  • inspector/InspectorDatabaseAgent.h: Renamed from WebCore/inspector/InspectorStorageAgent.h. (WebCore::InspectorDatabaseAgent::create): (WebCore::InspectorDatabaseAgent::frontend):
  • inspector/InspectorFrontendClientLocal.cpp:
  • inspector/InspectorFrontendClientLocal.h:
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.show):
1:24 PM Changeset in webkit [74754] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-29 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update.
Add recent upstream expectations Chromium changes.

  • platform/chromium/test_expectations.txt:
12:49 PM Changeset in webkit [74753] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-29 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update.
Mark http/tests/incremental/split-hex-entities.pl as flaky.

  • platform/chromium/test_expectations.txt:
12:39 PM Changeset in webkit [74752] by tonyg@chromium.org
  • 3 edits
    5 adds in trunk

2010-12-29 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Eric Seidel.

Assertion failure: element->inDocument() in AsyncScriptRunner::executeScriptSoon()
​https://bugs.webkit.org/show_bug.cgi?id=51067

  • fast/dom/HTMLScriptElement/move-in-beforeload-expected.txt: Added.
  • fast/dom/HTMLScriptElement/move-in-beforeload.html: Added.
  • fast/dom/HTMLScriptElement/remove-in-beforeload-expected.txt: Added.
  • fast/dom/HTMLScriptElement/remove-in-beforeload.html: Added.

2010-12-29 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Eric Seidel.

Assertion failure: element->inDocument() in AsyncScriptRunner::executeScriptSoon()
​https://bugs.webkit.org/show_bug.cgi?id=51067

Typically when a script element is removed from the document, the cached script
client is removed. However, during the before load event, the cached script client
hasn't been created yet so it can't be removed.

This patch handles that case by explicitly checking if the script element was
removed during the beforeload event. Also, it avoids caching the Document references
over the arbitrary script execution in the before load event.

Test: fast/dom/HTMLScriptElement/move-in-beforeload.html

fast/dom/HTMLScriptElement/remove-in-beforeload.html

  • dom/ScriptElement.cpp: (WebCore::ScriptElement::requestScript):
12:02 PM Changeset in webkit [74751] by mitz@apple.com
  • 4 edits in trunk/WebKit/mac

<rdar://problem/8758191> REGRESSION (r72887): Mail crashes when doing searches in a message due to method name conflict
​https://bugs.webkit.org/show_bug.cgi?id=51717

Reviewed by Ada Chan.

Renamed -findString:options: to -_findString:options: in the WebDocumentOptionsSearching
protocol to avoid conflict with -[WebHTMLView(MailExtras) findString:options:] which Mail defines.

  • WebView/WebDocumentInternal.h:
  • WebView/WebHTMLView.mm:

(-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]):
(-[WebHTMLView _findString:options:]):

  • WebView/WebView.mm:

(findString):

11:20 AM Changeset in webkit [74750] by mihaip@chromium.org
  • 1 edit
    2 adds
    1 delete in trunk/LayoutTests

2010-12-29 Mihai Parparita <​mihaip@chromium.org>

Unreviewed, rolling out r74748.
​http://trac.webkit.org/changeset/74748

r74735 was rolled out with r74749, the expectations update
should be rolled out too

  • platform/chromium-mac/fast/events/ime-composition-events-001-expected.txt: Added.
  • platform/chromium-win/fast/events/ime-composition-events-001-expected.txt: Added.
  • platform/chromium/fast/events/ime-composition-events-001-expected.txt: Removed.
11:13 AM Changeset in webkit [74749] by commit-queue@webkit.org
  • 4 edits in trunk

2010-12-29 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r74735.
​http://trac.webkit.org/changeset/74735
​https://bugs.webkit.org/show_bug.cgi?id=51715

assert failures on fast/forms/input-maxlength-ime-
completed.html (Requested by mihaip on #webkit).

  • platform/chromium/test_expectations.txt:

2010-12-29 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r74735.
​http://trac.webkit.org/changeset/74735
​https://bugs.webkit.org/show_bug.cgi?id=51715

assert failures on fast/forms/input-maxlength-ime-
completed.html (Requested by mihaip on #webkit).

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::setMarkedText):
10:17 AM Changeset in webkit [74748] by mihaip@chromium.org
  • 1 edit
    1 add
    2 deletes in trunk/LayoutTests

2010-12-29 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium baselines. Update Chromium baselines for
fast/events/ime-composition-events-001.html after r74735 (the
new baselines are closer to the upstream Mac ones).

  • platform/chromium-mac/fast/events/ime-composition-events-001-expected.txt: Removed.
  • platform/chromium-win/fast/events/ime-composition-events-001-expected.txt: Removed.
  • platform/chromium/fast/events/ime-composition-events-001-expected.txt: Added.
10:12 AM Changeset in webkit [74747] by mihaip@chromium.org
  • 1 edit
    7 adds in trunk/LayoutTests

2010-12-29 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium baselines. Add Chromium baselines for the
layout test added by r74743.

  • platform/chromium-linux/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png: Added.
  • platform/chromium-mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png: Added.
  • platform/chromium-win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png: Added.
  • platform/chromium-win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Added.
10:03 AM Changeset in webkit [74746] by Martin Robinson
  • 2 edits in trunk/Tools

2010-12-29 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Ojan Vafai.

prepare-ChangeLog should support the -g option for specifying the git-commit
​https://bugs.webkit.org/show_bug.cgi?id=51708

Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
webkit-patch, though the exact meaning of the two options remain different.

  • Scripts/prepare-ChangeLog: Add -g.
10:01 AM Changeset in webkit [74745] by apavlov@chromium.org
  • 2 edits in trunk/WebCore

2010-12-29 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Element highlight tooltip displays wrong element size when zoomed in
​https://bugs.webkit.org/show_bug.cgi?id=51703

  • inspector/InspectorController.cpp: (WebCore::InspectorController::drawElementTitle):
8:00 AM Changeset in webkit [74744] by yael.aharon@nokia.com
  • 16 edits
    9 adds in trunk

[HTML5][Forms] Support for :in-range and :out-of-range CSS selectors
​https://bugs.webkit.org/show_bug.cgi?id=29071

Reviewed by Kent Tamura.

WebCore:

Use InputType::rangeUnderflow() and InputType::rangeOverflow()
to determine if a control is in-range or out-of-range.

Tests: fast/css/pseudo-in-range-invalid-value.html

fast/css/pseudo-in-range.html
fast/css/pseudo-out-of-range.html

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::pseudoId):
(WebCore::nameToPseudoTypeMap):
(WebCore::CSSSelector::extractPseudoType):

  • css/CSSSelector.h:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):

  • dom/Element.h:

(WebCore::Element::isInRange):
(WebCore::Element::isOutOfRange):

  • html/BaseDateAndTimeInputType.cpp:

(WebCore::BaseDateAndTimeInputType::supportsRangeLimitation):

  • html/BaseDateAndTimeInputType.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::isInRange):
(WebCore::HTMLInputElement::isOutOfRange):

  • html/HTMLInputElement.h:
  • html/InputType.cpp:

(WebCore::InputType::supportsRangeLimitation):

  • html/InputType.h:
  • html/NumberInputType.cpp:

(WebCore::NumberInputType::supportsRangeLimitation):

  • html/NumberInputType.h:
  • html/RangeInputType.cpp:

(WebCore::RangeInputType::supportsRangeLimitation):

  • html/RangeInputType.h:

LayoutTests:

  • fast/css/pseudo-in-range-expected.txt: Added.
  • fast/css/pseudo-in-range-invalid-value-expected.txt: Added.
  • fast/css/pseudo-in-range-invalid-value.html: Added.
  • fast/css/pseudo-in-range.html: Added.
  • fast/css/pseudo-out-of-range-expected.txt: Added.
  • fast/css/pseudo-out-of-range.html: Added.
  • fast/css/script-tests/pseudo-in-range-invalid-value.js: Added.
  • fast/css/script-tests/pseudo-in-range.js: Added.
  • fast/css/script-tests/pseudo-out-of-range.js: Added.
7:50 AM Changeset in webkit [74743] by inferno@chromium.org
  • 3 edits
    4 adds in trunk

2010-12-29 Abhishek Arya <​inferno@chromium.org>

Reviewed by Eric Seidel.

When cloning an anonymous block, make sure to set the childrenInline flag based
on the state of the block to be cloned.
​https://bugs.webkit.org/show_bug.cgi?id=51489

Test: fast/multicol/span/clone-anonymous-block-non-inline-child-crash.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::clone): add code to handle cloning of anonymous blocks. (WebCore::RenderBlock::splitBlocks): remove anonymous block creation calls since it is now handled by clone().

2010-12-29 Abhishek Arya <​inferno@chromium.org>

Reviewed by Eric Seidel.

Tests that cloning an anonymous block with non inline children does not crash.
​https://bugs.webkit.org/show_bug.cgi?id=51489

  • fast/multicol/span/clone-anonymous-block-non-inline-child-crash.html: Added.
  • platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.checksum: Added.
  • platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png: Added.
  • platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Added.
7:38 AM Changeset in webkit [74742] by Patrick Gansterer
  • 6 edits in trunk

2010-12-29 Patrick Gansterer <Patrick Gansterer>

Unreviewed build fix for WinCE after r73802.

Reapply parts from r72585:
Port ContextMenuWin.cpp to WinCE
​https://bugs.webkit.org/show_bug.cgi?id=48408

  • CMakeLists.txt:
  • platform/ContextMenu.h:
  • platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::getContextMenuItems): (WebCore::ContextMenu::createNativeMenuFromItems):

2010-12-29 Patrick Gansterer <Patrick Gansterer>

Unreviewed build fix for WinCE after r73802.

  • WebCoreSupport/ContextMenuClientWinCE.cpp: (WebKit::ContextMenuClientWinCE::customizeMenu):
  • WebCoreSupport/ContextMenuClientWinCE.h:
5:39 AM Changeset in webkit [74741] by kent.hansen@nokia.com
  • 12 edits in trunk

2010-12-29 Kent Hansen <​kent.hansen@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Fix compilation with Qt in namespace
​https://bugs.webkit.org/show_bug.cgi?id=51701

  • QtTestBrowser/webview.h:

2010-12-29 Kent Hansen <​kent.hansen@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Fix compilation with Qt in namespace
​https://bugs.webkit.org/show_bug.cgi?id=51701

  • platform/graphics/ContextShadow.h:
  • platform/graphics/GraphicsContext3D.h:
  • platform/network/NetworkingContext.h:
  • platform/network/qt/QtNAMThreadSafeProxy.h:
  • plugins/PluginView.h:

2010-12-29 Kent Hansen <​kent.hansen@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Fix compilation with Qt in namespace
​https://bugs.webkit.org/show_bug.cgi?id=51701

  • Api/qwebkitplatformplugin.h:
  • WebCoreSupport/InspectorServerQt.h:
  • tests/hybridPixmap/widget.h:
4:41 AM Fingerprinting edited by robert@roberthogan.net
(diff)
3:53 AM Changeset in webkit [74740] by apavlov@chromium.org
  • 3 edits
    2 adds in trunk

2010-12-28 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: A disabled style property should get enabled when edited
​https://bugs.webkit.org/show_bug.cgi?id=51679

  • inspector/styles-disable-then-change-expected.txt: Added.
  • inspector/styles-disable-then-change.html: Added.

2010-12-28 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: A disabled style property should get enabled when edited
​https://bugs.webkit.org/show_bug.cgi?id=51679

Test: inspector/styles-disable-then-change.html

  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSProperty.prototype.setText): (WebInspector.CSSProperty.prototype.setText.callback):
3:35 AM Changeset in webkit [74739] by Patrick Gansterer
  • 4 edits in trunk

2010-12-29 Patrick Gansterer <Patrick Gansterer>

Unreviewed. Use gcc as default preprocessor.

  • Sources/cmake/OptionsCommon.cmake:

2010-12-29 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[CMake] Remove WebKitGenerators
​https://bugs.webkit.org/show_bug.cgi?id=50445

  • CMakeLists.txt: Pass preprocessor to generate-bindings.pl.
3:22 AM Changeset in webkit [74738] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit2

2010-12-29 Juha Savolainen <​juha.savolainen@weego.fi>

Reviewed by Kenneth Rohde Christiansen.

[Qt] [WK2] Added more webattributes to the qwkpreferences
​https://bugs.webkit.org/show_bug.cgi?id=51697

Added PrivateBrowsingEnabled, DeveloperExtrasEnabled, DnsPrefetchEnabled attributes

  • UIProcess/API/qt/qwkpreferences.cpp: (QWKPreferences::testAttribute): (QWKPreferences::setAttribute):
  • UIProcess/API/qt/qwkpreferences.h:
1:32 AM Changeset in webkit [74737] by commit-queue@webkit.org
  • 5 edits in trunk

2010-12-29 Helder Correia <​helder@sencha.com>

Reviewed by Eric Seidel.

<VT> and <FF> are not valid JSON whitespace characters
​https://bugs.webkit.org/show_bug.cgi?id=51671

Vertical Tab and Form Feed are not allowed white spaces by the JSON
RFC 4627: ​http://www.ietf.org/rfc/rfc4627.txt (2. JSON Grammar).

Tests: ietestcenter/Javascript/15.12.1.1-0-2.html

ietestcenter/Javascript/15.12.1.1-0-3.html

  • runtime/LiteralParser.cpp: (JSC::isJSONWhiteSpace): (JSC::LiteralParser::Lexer::lex):

2010-12-29 Helder Correia <​helder@sencha.com>

Reviewed by Eric Seidel.

<VT> and <FF> are not valid JSON whitespace characters
​https://bugs.webkit.org/show_bug.cgi?id=51671

Vertical Tab and Form Feed are not allowed white spaces by the JSON
RFC 4627: ​http://www.ietf.org/rfc/rfc4627.txt (2. JSON Grammar).

  • ietestcenter/Javascript/15.12.1.1-0-2-expected.txt:
  • ietestcenter/Javascript/15.12.1.1-0-3-expected.txt:
1:30 AM Changeset in webkit [74736] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2010-12-29 Philippe Normand <​pnormand@igalia.com>

Unreviewed, skip flaky test on GTK.

[GTK] editing/selection/extend-by-character-004.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=51699

  • platform/gtk/Skipped:
1:22 AM Changeset in webkit [74735] by commit-queue@webkit.org
  • 4 edits in trunk

2010-12-29 Zhe Su <​suzhe@chromium.org>

Reviewed by Eric Seidel.

Remove entry for editing/input/ime-composition-clearpreedit.html test.
​https://bugs.webkit.org/show_bug.cgi?id=51693

  • platform/chromium/test_expectations.txt:

2010-12-29 Zhe Su <​suzhe@chromium.org>

Reviewed by Eric Seidel.

Fix editing/input/ime-composition-clearpreedit.html test in chromium
by removing the line "editor->confirmComposition(text);" from
WebFrameImpl::setMarkedText() method, because that line will insert the
text into the focused node, which is apparently wrong.

​https://bugs.webkit.org/show_bug.cgi?id=51693

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::setMarkedText):

Dec 28, 2010:

11:45 PM Changeset in webkit [74734] by commit-queue@webkit.org
  • 12 edits in trunk/WebCore

2010-12-28 Pratik Solanki <​psolanki@apple.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=51522
Use deviceRGBColorSpaceRef() instead of calling CGColorSpaceCreateDeviceRGB()

  • page/win/FrameCGWin.cpp: (WebCore::imageFromRect):
  • platform/graphics/cg/GradientCG.cpp: (WebCore::Gradient::platformGradient):
  • platform/graphics/cg/GraphicsContext3DCG.cpp: (WebCore::GraphicsContext3D::paintToCanvas):
  • platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::checkForSolidColor):
  • platform/graphics/gstreamer/ImageGStreamerCG.mm: (ImageGStreamer::ImageGStreamer):
  • platform/graphics/win/GraphicsContextCGWin.cpp: (WebCore::CGContextWithHDC): (WebCore::GraphicsContext::releaseWindowsContext): (WebCore::GraphicsContext::drawWindowsBitmap):
  • platform/graphics/win/ImageCGWin.cpp: (WebCore::BitmapImage::create): (WebCore::BitmapImage::getHBITMAPOfSize):
  • platform/image-decoders/cg/ImageDecoderCG.cpp: (WebCore::createColorSpace):
  • platform/win/DragImageCGWin.cpp: (WebCore::allocImage): (WebCore::createCgContextFromBitmap):
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMenuListButtonGradients): (WebCore::RenderThemeMac::paintSliderTrack):
  • rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintMenuListButtonGradients): (WebCore::RenderThemeSafari::paintSliderTrack):
4:59 PM Changeset in webkit [74733] by dbates@webkit.org
  • 19 edits in trunk

2010-12-28 Daniel Bates <​dbates@rim.com>

Reviewed by Sam Weinig.

Substitute MARK: for compiler-specific #pragma mark
​https://bugs.webkit.org/show_bug.cgi?id=51657

For consistency, we should substitute " MARK:" for compiler-
specific "#pragma mark" in the source files for the Mac port.

  • History/WebHistory.mm:
  • Plugins/WebBaseNetscapePluginView.mm:
  • Plugins/WebNetscapePluginView.mm:
  • WebCoreSupport/WebInspectorClient.mm:
  • WebCoreSupport/WebSecurityOrigin.mm:
  • WebView/WebPDFView.mm:
  • WebView/WebVideoFullscreenController.mm:
  • WebView/WebVideoFullscreenHUDWindowController.mm:

2010-12-28 Daniel Bates <​dbates@rim.com>

Reviewed by Sam Weinig.

Substitute MARK: for compiler-specific #pragma mark
​https://bugs.webkit.org/show_bug.cgi?id=51657

Fix compilation warnings about "#pragma mark" on GTK+ bots by
substituting " MARK:" for "#pragma mark", which provides
analogous code-bookmarking functionality under Xcode.

  • platform/graphics/cg/PathCG.cpp:
  • platform/graphics/mac/WebLayer.mm:

2010-12-28 Daniel Bates <​dbates@rim.com>

Reviewed by Sam Weinig.

Substitute MARK: for compiler-specific #pragma mark
​https://bugs.webkit.org/show_bug.cgi?id=51657

Fix future compilation warnings about "#pragma mark" on GTK+ bots by
substituting " MARK:" for "#pragma mark", which provides
analogous code-bookmarking functionality under Xcode.

Also, for consistency, we should substitute " MARK:" for compiler-
specific "#pragma mark" in the source files for the Mac port.

  • DumpRenderTree/AccessibilityTextMarker.cpp:
  • DumpRenderTree/cf/WebArchiveDumpSupport.h:
  • DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
  • DumpRenderTree/mac/ObjCController.m:
  • MiniBrowser/mac/AppDelegate.m:
  • MiniBrowser/mac/BrowserWindowController.m:
4:56 PM Changeset in webkit [74732] by dbates@webkit.org
  • 2 edits in trunk/LayoutTests

2010-12-28 Daniel Bates <​dbates@rim.com>

Reviewed by Antonio Gomes.

Add comment to test case fast/repaint/no-caret-repaint-in-non-content-editable-element.html
to clarify caret browsing disabled
​https://bugs.webkit.org/show_bug.cgi?id=51633

Add a comment to test case fast/repaint/no-caret-repaint-in-non-content-editable-element.html
that explains that this test is only applicable when caret browsing is disabled.

  • fast/repaint/no-caret-repaint-in-non-content-editable-element.html:
4:39 PM Changeset in webkit [74731] by Martin Robinson
  • 3 edits in trunk/WebKit/gtk

2010-12-28 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Closing a window during an onload event can trigger serious GLib warnings
​https://bugs.webkit.org/show_bug.cgi?id=51686

Don't emit the close-web-view signal immediately during execution of closeWindowSoon.
The signal handler may choose to destroy the web view while handling that signal,
which may remove the last reference to the web view. FrameLoaderClient depends on the
view still existing though. Instead, let the caller finish executing and emit the signal
after a 0 length timeout. This matches the behavior on the Windows and Mac ports.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::ChromeClient): Initialize the timer id. (WebKit::emitCloseWebViewSignalLater): Callback for the timer. (WebKit::ChromeClient::closeWindowSoon): Do the actual signal invocation after the caller finishes its tasks.
  • WebCoreSupport/ChromeClientGtk.h: Add a new member for the timer id. We can use this to prevent emitting the close-web-view signal twice.
3:39 PM Changeset in webkit [74730] by Martin Robinson
  • 2 edits in trunk/WebKit/gtk

2010-12-28 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] Clean up usage of NULL in webkitwebframe.cpp
​https://bugs.webkit.org/show_bug.cgi?id=51685

Replace occurrences of NULL with 0, in webkitwebframe.cpp. Not all
uses of NULL have been changed, as certain GLib functions require
an explicit NULL as a sentinel.

  • webkit/webkitwebframe.cpp: (webkit_web_frame_get_data_source_from_core_loader): (webkit_web_frame_class_init): (webkit_web_frame_new): (webkit_web_frame_get_title): (webkit_web_frame_get_uri): (webkit_web_frame_get_web_view): (webkit_web_frame_get_name): (webkit_web_frame_get_parent): (webkit_web_frame_load_string): (webkit_web_frame_load_alternate_string): (webkit_web_frame_find_frame): (webkit_web_frame_get_global_context): (webkit_web_frame_get_data_source): (webkit_web_frame_get_provisional_data_source): (webkit_web_frame_print_full): (webkit_web_frame_get_security_origin): (webkit_web_frame_get_network_response):
3:16 PM Changeset in webkit [74729] by kbr@google.com
  • 3 edits in trunk/LayoutTests

2010-12-28 Kenneth Russell <​kbr@google.com>

Reviewed by Eric Seidel.

Make fast/canvas/canvas-save-restore-with-path.js more robust
​https://bugs.webkit.org/show_bug.cgi?id=51665

  • fast/canvas/canvas-save-restore-with-path-expected.txt:
  • fast/canvas/canvas-save-restore-with-path.js:
2:56 PM Changeset in webkit [74728] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-12-28 Jan Erik Hanssen <​jhanssen@sencha.com>

Reviewed by Eric Seidel.

[Qt] GraphicsContext::getCTM() does not need to make a copy of QPainter::combinedTransform()
​https://bugs.webkit.org/show_bug.cgi?id=51687

Use a const reference instead of a copy of QPainter::combinedTransform()
in GraphicsContext::getCTM()

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::getCTM):
2:45 PM Changeset in webkit [74727] by commit-queue@webkit.org
  • 4 edits in trunk

2010-12-28 Helder Correia <​helder@sencha.com>

Reviewed by Eric Seidel.

JSON.stringify must exist as a function taking 3 parameters
​https://bugs.webkit.org/show_bug.cgi?id=51667

The reported function length is 1 instead.

Test: ietestcenter/Javascript/15.12.3-0-2.html

  • runtime/JSONObject.cpp:

2010-12-28 Helder Correia <​helder@sencha.com>

Reviewed by Eric Seidel.

JSON.stringify must exist as a function taking 3 parameters
​https://bugs.webkit.org/show_bug.cgi?id=51667

The reported function length is 1 instead.

  • ietestcenter/Javascript/15.12.3-0-2-expected.txt:
2:20 PM Changeset in webkit [74726] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2010-12-28 Xan Lopez <​xlopez@igalia.com>

Reviewed by Eric Seidel.

Add --no-build option to run-sunspider
​https://bugs.webkit.org/show_bug.cgi?id=51658

  • Scripts/run-sunspider: add --no-build flag to skip building phase.
2:16 PM Fingerprinting edited by robert@roberthogan.net
(diff)
2:14 PM Changeset in webkit [74725] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-12-28 Takashi Toyoshima <​toyoshim@google.com>

Reviewed by Eric Seidel.

gcc detected 'control reaches end of non-void function' with
-finstrument-functions option.
​https://bugs.webkit.org/show_bug.cgi?id=51669

No new tests. These fixes are trivial.

  • dom/Element.cpp: (WebCore::Element::childTypeAllowed):
  • inspector/InspectorResourceAgent.cpp: (WebCore::cachedResourceTypeString):
2:11 PM Fingerprinting created by robert@roberthogan.net
1:57 PM Changeset in webkit [74724] by tonyg@chromium.org
  • 4 edits in trunk/WebCore

2010-12-28 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Eric Seidel.

Remove unused member of PendingScript
​https://bugs.webkit.org/show_bug.cgi?id=51684

This was used when HTMLScriptRunner::runScript created a PendingScript
for inline scripts. But now it just calls executeScript() directly.
External scripts always have the minimum starting line number.

No new tests because no changed functionality.

  • dom/PendingScript.cpp: (WebCore::PendingScript::releaseElementAndClear):
  • dom/PendingScript.h: (WebCore::PendingScript::PendingScript): (WebCore::PendingScript::operator=):
  • html/parser/HTMLScriptRunner.cpp: (WebCore::HTMLScriptRunner::sourceFromPendingScript):
1:57 PM Changeset in webkit [74723] by tonikitoo@webkit.org
  • 4 edits in trunk/WebCore

2010-12-20 Antonio Gomes <​agomes@rim.com>

Reviewed by Daniel Bates.

Spatial Navigation: code clean up (Part VI)
​https://bugs.webkit.org/show_bug.cgi?id=50666

No new tests needed.

  • page/FocusController.cpp: (WebCore::updatFocusCandidateIfNeeded): Assert renderer() and isElementNode() now that we are bailing out earlier in both the FocusCandidate constructor and FocusController::findFocusCandidateInContainer().
  • page/SpatialNavigation.h: Swapped the parameters order in canScrollInDirection and virtualRectForAreaElementAndDirection functions. (WebCore::FocusController::findFocusCandidateInContainer): (WebCore::FocusController::advanceFocusDirectionallyInContainer): Adjusted call sites of canScrollInDirection(), and added an early return if !isElementNode(). (WebCore::FocusController::advanceFocusDirectionally): Adjusted call site of virtualRectForAreaElementAndDirection().
  • page/SpatialNavigation.cpp: (WebCore::FocusCandidate::FocusCandidate): Assert if node is not an Element node. (WebCore::isScrollableNode): Renamed from isScrollableContainerNode. (WebCore::scrollInDirection): Adjusted call site after function name change; (WebCore::scrollableEnclosingBoxOrParentFrameForNodeInDi:rection): Assert if node is a Document node. (WebCore::canScrollInDirection): Signature changed. (WebCore::canBeScrolledIntoView): Ditto. (WebCore::virtualRectForAreaElementAndDirection): Ditto.
1:53 PM Changeset in webkit [74722] by enne@google.com
  • 2 edits in trunk/WebCore

2010-12-28 Adrienne Walker <​enne@google.com>

Reviewed by Kenneth Russell.

[chromium] Fix tiled compositor assertion after GPU process recovery.
​https://bugs.webkit.org/show_bug.cgi?id=51682

After the GPU process recovers, the layer size is set to IntSize(),
but IntRect::unite() has a special case for empty rects. This
behavior was causing the layer size to be too small, causing an
out-of-bounds array access elsewhere.

No new tests.

  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::growLayerToContain):
1:36 PM Changeset in webkit [74721] by commit-queue@webkit.org
  • 4 edits in trunk

2010-12-28 Helder Correia <​helder@sencha.com>

Reviewed by Sam Weinig.

JSON.parse must exist as a function taking 2 parameters
​https://bugs.webkit.org/show_bug.cgi?id=51666

Support for revivers was introduced in bug 26591, but the function
length has since remained unchanged.

Test: ietestcenter/Javascript/15.12.2-0-2.html

  • runtime/JSONObject.cpp:

2010-12-28 Helder Correia <​helder@sencha.com>

Reviewed by Sam Weinig.

JSON.parse must exist as a function taking 2 parameters
​https://bugs.webkit.org/show_bug.cgi?id=51666

Support for revivers was introduced in bug 26591, but the function
length has since remained unchanged.

  • ietestcenter/Javascript/15.12.2-0-2-expected.txt: Change expected result to success.
1:35 PM Changeset in webkit [74720] by zmo@google.com
  • 16 edits in trunk

2010-12-23 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

Initialize to 0 for undefined values in CopyTexImage2D
​https://bugs.webkit.org/show_bug.cgi?id=51421

  • src/GraphicsContext3DChromium.cpp: Implement getInternalFramebufferSize(). (WebCore::GraphicsContext3DInternal::getInternalFramebufferSize):
  • src/GraphicsContext3DInternal.h:

2010-12-23 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

Initialize to 0 for undefined values in CopyTexImage2D
​https://bugs.webkit.org/show_bug.cgi?id=51421

  • html/canvas/WebGLFramebuffer.cpp: Track width/height/internalFormat of color buffer. (WebCore::WebGLFramebuffer::WebGLFramebuffer): (WebCore::WebGLFramebuffer::setAttachment): (WebCore::WebGLFramebuffer::getWidth): (WebCore::WebGLFramebuffer::getHeight): (WebCore::WebGLFramebuffer::getColorBufferFormat):
  • html/canvas/WebGLFramebuffer.h:
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::copyTexImage2D): Initialize undefined pixels to 0. (WebCore::WebGLRenderingContext::copyTexSubImage2D): (WebCore::WebGLRenderingContext::framebufferTexture2D): (WebCore::WebGLRenderingContext::renderbufferStorage): (WebCore::WebGLRenderingContext::getBoundFramebufferWidth): (WebCore::WebGLRenderingContext::getBoundFramebufferHeight):
  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebGLTexture.cpp: Track width/height/internalFormat of a texture by target/level. (WebCore::WebGLTexture::getInternalFormat): (WebCore::WebGLTexture::getWidth): (WebCore::WebGLTexture::getHeight): (WebCore::WebGLTexture::mapTargetToIndex): (WebCore::WebGLTexture::getLevelInfo):
  • html/canvas/WebGLTexture.h: (WebCore::WebGLTexture::isTexture):
  • platform/graphics/GraphicsContext3D.h: Add getInternalFramebufferSize() function.
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: (WebCore::GraphicsContext3D::getInternalFramebufferSize):
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::getInternalFramebufferSize):

2010-12-23 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

Initialize to 0 for undefined values in CopyTexImage2D
​https://bugs.webkit.org/show_bug.cgi?id=51421

  • fast/canvas/webgl/uninitialized-test-expected.txt: Add test cases for copyTexImage2D.
  • fast/canvas/webgl/uninitialized-test.html: Ditto.
1:26 PM Changeset in webkit [74719] by zmo@google.com
  • 7 edits in trunk

2010-12-23 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

Map GLsizei to long instead of unsigned long in WebGLRenderingContext and GraphicsContext3D
​https://bugs.webkit.org/show_bug.cgi?id=39855

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::copyTexImage2D): Map GLsizei to long. (WebCore::WebGLRenderingContext::copyTexSubImage2D): Ditto. (WebCore::WebGLRenderingContext::renderbufferStorage): Ditto. (WebCore::WebGLRenderingContext::scissor): Ditto. (WebCore::WebGLRenderingContext::texImage2DBase): Ditto. (WebCore::WebGLRenderingContext::texImage2D): Ditto. (WebCore::WebGLRenderingContext::texSubImage2DBase): Ditto. (WebCore::WebGLRenderingContext::texSubImage2DImpl): Ditto. (WebCore::WebGLRenderingContext::texSubImage2D): Ditto. (WebCore::WebGLRenderingContext::viewport): Ditto. (WebCore::WebGLRenderingContext::validateSize): Check the sizes are non-negative.
  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebGLRenderingContext.idl:

2010-12-28 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

Map GLsizei to long instead of unsigned long in WebGLRenderingContext and GraphicsContext3D
​https://bugs.webkit.org/show_bug.cgi?id=39855

  • fast/canvas/webgl/invalid-passed-params-expected.txt: Add test cases for negative offset/width/height.
  • fast/canvas/webgl/invalid-passed-params.html: Ditto.
12:01 PM Changeset in webkit [74718] by kbr@google.com
  • 2 edits in trunk/LayoutTests

2010-12-28 Kenneth Russell <​kbr@google.com>

Unreviewed, Chromium test expectations update. Mark
fast/forms/input-text-paste-maxlength.html as a flaky crash on
Linux Release as well as Debug.

  • platform/chromium/test_expectations.txt:
11:36 AM Changeset in webkit [74717] by kbr@google.com
  • 2 edits in trunk/LayoutTests

2010-12-28 Kenneth Russell <​kbr@google.com>

Unreviewed, Chromium test expectations update.

Marked inspector/styles-source-lines.html as a flaky failure on
Win Debug and
http/tests/inspector/extensions-resources-redirect.html as a flaky
timeout on Win Release.

  • platform/chromium/test_expectations.txt:
11:18 AM Changeset in webkit [74716] by inferno@chromium.org
  • 5 edits
    2 adds in trunk

2010-12-28 Abhishek Arya <​inferno@chromium.org>

Reviewed by Kenneth Russell.

Fix crash with invalid font in m_fontList by not drawing text when a custom font is in the
process of loading.
​https://bugs.webkit.org/show_bug.cgi?id=51681

Test: canvas/philip/tests/2d.text-custom-font-load-crash.html

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawTextInternal): bail out if a custom font is loading.
  • platform/graphics/Font.cpp: (WebCore::Font::operator==): Replace condition with new function loadingCustomFonts() (WebCore::Font::drawText): Replace condition with new function loadingCustomFonts() (WebCore::Font::drawEmphasisMarks): Replace condition with new function loadingCustomFonts()
  • platform/graphics/Font.h: (WebCore::Font::loadingCustomFonts): new function that returns if a custom font is loading.

2010-12-28 Abhishek Arya <​inferno@chromium.org>

Reviewed by Kenneth Russell.

Tests that we do not crash when drawing text during custom font load.
​https://bugs.webkit.org/show_bug.cgi?id=51681

  • canvas/philip/tests/2d.text-custom-font-load-crash-expected.txt: Added.
  • canvas/philip/tests/2d.text-custom-font-load-crash.html: Added.
10:55 AM Changeset in webkit [74715] by Dimitri Glazkov
  • 4 edits in trunk/WebCore

2010-12-28 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

Combine setShadowRoot and clearShadowRoot into a simpler API
​https://bugs.webkit.org/show_bug.cgi?id=50971

No change in behavior, and API is not used yet.

  • dom/Element.cpp: (WebCore::Element::setShadowRoot): Combined clearing and setting of

the shadowRoot, also hooked up with setting and clearing of the
corresponding shadowHost values.

  • dom/Element.h: renamed clearShadowRoot to removeShadowRoot and made it

private.

  • dom/Node.h: Made shadow host-related functions public so that

Element::setShadowRoot can access setShadowHost. It seems logical
to make shadowHost public as well to keep the defs together.

10:11 AM Changeset in webkit [74714] by caseq@chromium.org
  • 6 edits
    3 adds in trunk

2010-12-28 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Expose extension API to select a node in WebInspector
Do not request content for resources with non-numeric identifiers.
​https://bugs.webkit.org/show_bug.cgi?id=49727

Test: http/tests/inspector/extensions-resources-redirect.html

  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager.prototype._appendRedirect):

2010-12-28 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Expose extension API to select a node in WebInspector
Do not request content for resources with non-numeric identifiers.
​https://bugs.webkit.org/show_bug.cgi?id=49727

  • http/tests/inspector/extensions-resources-redirect-expected.txt: Added.
  • http/tests/inspector/extensions-resources-redirect.html: Added.
  • http/tests/inspector/extensions-resources-test.js: Added. (extension_getResourceByUrl.onHAR): (extension_getResourceByUrl):
  • inspector/extensions-resources-expected.txt:
  • inspector/extensions-resources.html:
  • platform/mac-leopard/inspector/extensions-resources-expected.txt:
9:58 AM Changeset in webkit [74713] by loislo@chromium.org
  • 2 edits in trunk/WebCore

2010-12-28 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed build fix for Qt.

ResourceTreeModel.js was added.

  • inspector/front-end/WebKit.qrc:
9:24 AM Changeset in webkit [74712] by mnaganov@chromium.org
  • 2 edits in trunk/WebCore

2010-12-28 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Fix memory leak in Profiles tab concerned with heap profiles views.

​https://bugs.webkit.org/show_bug.cgi?id=51680

  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype._reset):
7:55 AM Changeset in webkit [74711] by kbr@google.com
  • 2 edits in trunk/LayoutTests

2010-12-28 Kenneth Russell <​kbr@google.com>

Unreviewed, Chromium test expectations update. Coalesce WebGL
expectations for chromium-gpu platform and fix duplicate
expectation for gl-object-get-calls.html accidentally introduced
on Windows Debug.

  • platform/chromium-gpu/test_expectations.txt:
7:32 AM Changeset in webkit [74710] by apavlov@chromium.org
  • 4 edits
    4 adds in trunk

2010-12-28 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: REGRESSION: Clicking image resource in style sidebar doesn't actually go to resource anymore
​https://bugs.webkit.org/show_bug.cgi?id=51663

  • inspector/elements-tests2.js: (initialize_ElementTest.InspectorTest.dumpSelectedElementStyles): Drive-by: remove bad test exit code.
  • inspector/resources/styles-url-linkify-iframe.html: Added.
  • inspector/resources/styles-url-linkify.css: Added. (#local):
  • inspector/styles-url-linkify-expected.txt: Added.
  • inspector/styles-url-linkify.html: Added.

2010-12-28 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: REGRESSION: Clicking image resource in style sidebar doesn't actually go to resource anymore
​https://bugs.webkit.org/show_bug.cgi?id=51663

The base URI is now computed correctly for links from CSS property uri(...) values. Additionally,
optional quotes/apostrophes and spaces are now allowed inside uri(...).

Test: inspector/styles-url-linkify.html

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL): (WebInspector.StylePropertyTreeElement.prototype.updateTitle):
7:11 AM Changeset in webkit [74709] by loislo@chromium.org
  • 21 edits
    2 adds
    1 delete in trunk/WebCore

2010-12-21 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Protocol cleanup task. Introduce Network, DOMStorage and Database domains.

Domain was changed for Resources, FileSystem etc. related methods.
ResourcesManager was renamed to NetworkManager.
ResourceTreeModel was extracted as separate file.
FileSystem, Database, DOMStorage and ApplicationCache methods were
removed from NetworkManager and added to corresponding classes.

​https://bugs.webkit.org/show_bug.cgi?id=51334

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/CodeGeneratorInspector.pm:
  • inspector/Inspector.idl:
  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback): (WebInspector.CSSStyleModel.prototype._styleSheetChanged):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.addMessage): (WebInspector.ConsoleView.prototype.clearMessages):
  • inspector/front-end/DOMAgent.js: (WebInspector.ApplicationCache.updateApplicationCacheStatus): (WebInspector.ApplicationCache.updateNetworkState):
  • inspector/front-end/DOMStorage.js: (WebInspector.DOMStorage.addDOMStorage): (WebInspector.DOMStorage.selectDOMStorage): (WebInspector.DOMStorage.updateDOMStorage):
  • inspector/front-end/Database.js: (WebInspector.Database.prototype.executeSql): (WebInspector.Database.addDatabase): (WebInspector.Database.selectDatabase): (WebInspector.Database.sqlTransactionSucceeded): (WebInspector.Database.sqlTransactionFailed):
  • inspector/front-end/FileSystemView.js: (WebInspector.FileSystem.didGetFileSystemPath): (WebInspector.FileSystem.didGetFileSystemError): (WebInspector.FileSystem.didGetFileSystemDisabled):
  • inspector/front-end/NetworkItemView.js: (WebInspector.NetworkItemView):
  • inspector/front-end/NetworkManager.js: Added. (WebInspector.NetworkManager): (WebInspector.NetworkManager.prototype._createResource): (WebInspector.NetworkManager.prototype.identifierForInitialRequest): (WebInspector.NetworkManager.prototype.willSendRequest): (WebInspector.NetworkManager.prototype._updateResourceWithRequest): (WebInspector.NetworkManager.prototype._appendRedirect): (WebInspector.NetworkManager.prototype.markResourceAsCached): (WebInspector.NetworkManager.prototype.didReceiveResponse): (WebInspector.NetworkManager.prototype._updateResourceWithResponse): (WebInspector.NetworkManager.prototype.didReceiveContentLength): (WebInspector.NetworkManager.prototype.didFinishLoading): (WebInspector.NetworkManager.prototype.didFailLoading): (WebInspector.NetworkManager.prototype.didLoadResourceFromMemoryCache): (WebInspector.NetworkManager.prototype._updateResourceWithCachedResource): (WebInspector.NetworkManager.prototype.setInitialContent): (WebInspector.NetworkManager.prototype.didCommitLoadForFrame): (WebInspector.NetworkManager.prototype.frameDetachedFromParent): (WebInspector.NetworkManager.prototype.didCreateWebSocket): (WebInspector.NetworkManager.prototype.willSendWebSocketHandshakeRequest): (WebInspector.NetworkManager.prototype.didReceiveWebSocketHandshakeResponse): (WebInspector.NetworkManager.prototype.didCloseWebSocket): (WebInspector.NetworkManager.prototype._processCachedResources): (WebInspector.NetworkManager.prototype._addFramesRecursively): (WebInspector.NetworkManager.requestContent):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.refreshResource):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype._innerRequestContent):
  • inspector/front-end/ResourceManager.js: Removed.
  • inspector/front-end/ResourceTreeModel.js: Added. (WebInspector.ResourceTreeModel): (WebInspector.ResourceTreeModel.prototype.addOrUpdateFrame): (WebInspector.ResourceTreeModel.prototype.didCommitLoadForFrame): (WebInspector.ResourceTreeModel.prototype.frameDetachedFromParent): (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources): (WebInspector.ResourceTreeModel.prototype.addResourceToFrame): (WebInspector.ResourceTreeModel.prototype._clearResources): (WebInspector.ResourceTreeModel.prototype.forAllResources): (WebInspector.ResourceTreeModel.prototype.addConsoleMessage): (WebInspector.ResourceTreeModel.prototype.clearConsoleMessages): (WebInspector.ResourceTreeModel.prototype._callForFrameResources): (WebInspector.ResourceTreeModel.prototype.resourceForURL): (WebInspector.ResourceTreeModel.prototype.bindResourceURL): (WebInspector.ResourceTreeModel.prototype._unbindResourceURL): (WebInspector.ResourceTreeModel.createResource):
  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView.createResourceView): (WebInspector.ResourceView.resourceViewTypeMatchesResource): (WebInspector.ResourceView.resourceViewForResource): (WebInspector.ResourceView.recreateResourceView): (WebInspector.ResourceView.existingResourceViewForResource):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.canShowSourceLine): (WebInspector.ResourcesPanel.prototype.showSourceLine): (WebInspector.ResourcesPanel.prototype.showResource): (WebInspector.ResourcesPanel.prototype.get searchableViews.callback): (WebInspector.ResourcesPanel.prototype.get searchableViews): (WebInspector.FrameResourceTreeElement.prototype._errorsWarningsUpdated): (WebInspector.FrameResourceTreeElement.prototype._contentChanged):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._addScript): (WebInspector.ScriptsPanel.prototype.reset): (WebInspector.ScriptsPanel.prototype._sourceFrameForResource): (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector.forAllResources): (WebInspector.resourceForURL):
Note: See TracTimeline for information about the timeline view.