⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 1, 2011:

11:52 PM Changeset in webkit [74862] by abarth@webkit.org
  • 2 edits in trunk/WebKit2

2011-01-01 Adam Barth <abarth@webkit.org>

Speculative build fix for Qt. Add some more include paths.

  • WebKit2.pro:
11:42 PM Changeset in webkit [74861] by abarth@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-01-01 Adam Barth <abarth@webkit.org>

Fix relative include paths in an attempt to fix the Qt build.

11:14 PM Changeset in webkit [74860] by abarth@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-01 Adam Barth <abarth@webkit.org>

Another speculative build fix for GTK.

  • GNUmakefile.am:
11:09 PM Changeset in webkit [74859] by abarth@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-01 Adam Barth <abarth@webkit.org>

Speculative build fix for GTK. Update the paths in GNUmakefile to
include "Source".

  • GNUmakefile.am:
10:46 PM Changeset in webkit [74858] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-01-01 Adam Barth <abarth@webkit.org>

Remove the assumption from the Qt and Gtk builds that every project is
in the root directory.

  • Scripts/build-webkit:
10:40 PM Changeset in webkit [74857] by abarth@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-01 Adam Barth <abarth@webkit.org>

Update relative paths in JavaScriptCore.gyp to account for the extra
level of directories.

10:28 PM Changeset in webkit [74856] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-01-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Teach svn-apply how to apply patches even though JavaScriptCore has moved
https://bugs.webkit.org/show_bug.cgi?id=51796

After this change, svn-apply will magically apply patches to
JavaScriptCore/foo to Source/JavaScriptCore/foo.

  • Scripts/VCSUtils.pm:
10:22 PM Changeset in webkit [74855] by abarth@webkit.org
  • 57 edits
    1 move in trunk

Move JavaScriptCore to Source
https://bugs.webkit.org/show_bug.cgi?id=51604

Reviewed by Eric Seidel.

Update references to JavaScriptCore to point to the new location.

  • Android.mk:
  • CMakeLists.txt:
  • DerivedSources.pro:
  • GNUmakefile.am:
  • Makefile:
  • WebKit.pri:
  • WebKit.pro:
  • wscript:

Tools:

Update references to JavaScriptCore to point to the new location.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
  • DumpRenderTree/qt/DumpRenderTree.pro:
  • DumpRenderTree/qt/ImageDiff.pro:
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  • DumpRenderTree/wscript:
  • Scripts/build-jsc:
  • Scripts/build-webkit:
  • Scripts/do-file-rename:
  • Scripts/do-webcore-rename:
  • Scripts/run-javascriptcore-tests:
  • Scripts/update-javascriptcore-test-results:
  • Scripts/webkitdirs.pm:
  • Scripts/webkitpy/common/config/build_unittest.py:
  • Scripts/webkitpy/style/checker.py:
  • Scripts/webkitpy/style/checker_unittest.py:
  • Scripts/webkitpy/style/checkers/cpp_unittest.py:
  • WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
  • WebKitTestRunner/qt/WebKitTestRunner.pro:
  • wx/build/settings.py:

WebCore:

Update references to JavaScriptCore.

  • Android.derived.jscbindings.mk:
  • Android.v8bindings.mk:
  • CMakeLists.txt:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.pro:
    • These changes are subtle and might not be 100% correct.
  • move-js-headers.sh:

WebKit/chromium:

WebKit/gtk:

  • GNUmakefile.am:
  • docs/GNUmakefile.am:

WebKit/qt:

  • WebKit_pch.h:
  • docs/qtwebkit.qdocconf:

WebKit/win:

  • WebKit.vcproj/WebKit.sln:

WebKit/wx:

  • bindings/python/wscript:
  • wscript:

WebKit2:

Websites/bugs.webkit.org:

  • PrettyPatch/PrettyPatch.rb:

Websites/webkit.org:

  • coding/assertion-guidelines.html:
8:33 PM Changeset in webkit [74854] by abarth@webkit.org
  • 5 edits
    7 adds in trunk

2011-01-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

forbid sandboxed frames to call top.close() when allow-same-origin is not setted
https://bugs.webkit.org/show_bug.cgi?id=38340

We now pass the ScriptExecutionContext to window.close so it can find
the Frame and check whether navigation is allowed. This check will
almost always pass because you can only close top-level frames, but the
check will fail when the calling script is sandboxed.

Tests: fast/frames/sandboxed-iframe-close-top-noclose.html

fast/frames/sandboxed-iframe-close-top.html

  • page/DOMWindow.cpp: (WebCore::DOMWindow::close):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:

2011-01-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

forbid sandboxed frames to call top.close() when allow-same-origin is not setted
https://bugs.webkit.org/show_bug.cgi?id=38340

Test the interaction between the HTML5 sandbox and window.close.

  • fast/frames/resources/close-top.html: Added.
  • fast/frames/resources/sandboxed-iframe-close-top-does-close.html: Added.
  • fast/frames/resources/sandboxed-iframe-close-top-does-not-close.html: Added.
  • fast/frames/sandboxed-iframe-close-top-expected.txt: Added.
  • fast/frames/sandboxed-iframe-close-top-noclose-expected.txt: Added.
  • fast/frames/sandboxed-iframe-close-top-noclose.html: Added.
  • fast/frames/sandboxed-iframe-close-top.html: Added.
6:28 PM Changeset in webkit [74853] by abarth@webkit.org
  • 5 edits
    2 adds in trunk

2011-01-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

sandbox iframes have access to top.history methods
https://bugs.webkit.org/show_bug.cgi?id=38152

To enforce the sandbox restrictions on History, we need to pass the
ScriptExecutionContext to WebCore. This patch leaves the original
History methods in place because they are used directly by folks who
don't care about security checks.

Test: fast/frames/sandboxed-iframe-history-denied.html

  • page/History.cpp: (WebCore::History::back): (WebCore::History::forward): (WebCore::History::go):
  • page/History.h:
  • page/History.idl:

2011-01-01 Justin Schuh <jschuh@chromium.org>

Reviewed by Eric Seidel.

sandbox iframes have access to top.history methods
https://bugs.webkit.org/show_bug.cgi?id=38152

Test that sandboxed iframes cannot use history to navigate the top
frame. This test is less than ideal, as described in the test itself.
If I was really on top of things, I'd add a test for successful use of
the history API when allow-top-navigation is set, but that test would
be complicated and I'm lazy (enough to copy directly from abarth).

  • fast/frames/sandboxed-iframe-history-denied-expected.txt: Added.
  • fast/frames/sandboxed-iframe-history-denied.html: Added.
6:04 PM Changeset in webkit [74852] by abarth@webkit.org
  • 14 edits
    1 move in trunk

Move Sources to Source
https://bugs.webkit.org/show_bug.cgi?id=51794

Reviewed by Eric Seidel.

Update build files to point to the new location.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • Makefile:
  • autogen.sh:
  • configure.ac:

Tools:

Update scripts to point to the new location.

  • Scripts/build-webkit:
  • Scripts/do-file-rename:
  • Scripts/do-webcore-rename:
  • Scripts/webkitpy/common/config/build.py:
  • Scripts/webkitpy/common/config/build_unittest.py:

Websites/bugs.webkit.org:

  • PrettyPatch/PrettyPatch.rb:
5:50 PM Changeset in webkit [74851] by abarth@webkit.org
  • 9 edits
    1 delete in trunk/WebCore

2011-01-01 Adam Barth <abarth@webkit.org>

Remove empty file.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/Entity.cpp: Removed.
5:43 PM Changeset in webkit [74850] by abarth@webkit.org
  • 7 edits
    1 delete in trunk/WebCore

2011-01-01 Adam Barth <abarth@webkit.org>

Remove empty file.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSPopStateEventCustom.cpp: Removed.
5:37 PM Changeset in webkit [74849] by abarth@webkit.org
  • 5 edits
    2 deletes in trunk/WebCore

2011-01-01 Adam Barth <abarth@webkit.org>

Remove empty files.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/generic/BindingFrame.h: Removed.
  • bindings/generic/BindingLocation.h: Removed.
4:35 PM Changeset in webkit [74848] by mitz@apple.com
  • 1 edit in trunk/WebKit2/WebKit2.xcodeproj

Changed WebKit2.xcodeproj's svn:ignore property up to match other projects'

10:00 AM Changeset in webkit [74847] by commit-queue@webkit.org
  • 20 edits in trunk/WebCore

2011-01-01 Konstantin Tokarev <Konstantin Tokarev>

Reviewed by Darin Adler.

Don't include Inspector headers when Inspector is disabled
https://bugs.webkit.org/show_bug.cgi?id=51789

  • bindings/js/JSDOMWindowBase.cpp: Include Inspector headers when Inspector is enabled
  • dom/Document.cpp: Include Inspector headers when Inspector is enabled (WebCore::Document::recalcStyle): Disabled InspectorInstrumentationCookie handling
  • html/HTMLDocument.cpp: Include Inspector headers when Inspector is enabled
  • loader/FrameLoader.cpp: Include Inspector headers when Inspector is enabled
  • loader/ResourceLoadNotifier.cpp: Include Inspector headers when Inspector is enabled
  • page/Chrome.cpp: Include Inspector headers when Inspector is enabled
  • page/Console.cpp: Include Inspector headers when Inspector is enabled
  • page/ContextMenuController.cpp: Include Inspector headers when Inspector is enabled
  • page/DOMWindow.cpp: Include Inspector headers when Inspector is enabled (WebCore::DOMWindow::dispatchEvent): Disabled InspectorInstrumentationCookie handling
  • page/EventHandler.cpp: Include Inspector headers when Inspector is enabled
  • page/Page.cpp: Include Inspector headers when Inspector is enabled
  • storage/Database.cpp: Include Inspector headers when Inspector is enabled
  • workers/AbstractWorker.cpp: Include Inspector headers when Inspector is enabled
  • workers/DefaultSharedWorkerRepository.cpp: Include Inspector headers when Inspector is enabled
  • workers/SharedWorker.cpp: Include Inspector headers when Inspector is enabled
  • workers/Worker.cpp: Include Inspector headers when Inspector is enabled
  • workers/WorkerContext.cpp: Include Inspector headers when Inspector is enabled
  • workers/WorkerMessagingProxy.cpp: Include Inspector headers when Inspector is enabled
  • xml/XMLHttpRequest.cpp: Include Inspector headers when Inspector is enabled (WebCore::XMLHttpRequest::callReadyStateChangeListener): Disabled InspectorInstrumentationCookie handling
3:01 AM Changeset in webkit [74846] by tkent@chromium.org
  • 2 edits
    5 adds in trunk/LayoutTests

2011-01-01 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

One more rebaseline for a spelling test, and remove passing tests from
test_expectations.txt.

  • platform/chromium-linux/editing/spelling/inline_spelling_markers-expected.checksum: Added.
  • platform/chromium-linux/editing/spelling/inline_spelling_markers-expected.png: Added.
  • platform/chromium-win/editing/spelling/inline_spelling_markers-expected.checksum: Added.
  • platform/chromium-win/editing/spelling/inline_spelling_markers-expected.png: Added.
  • platform/chromium-win/editing/spelling/inline_spelling_markers-expected.txt: Added.
  • platform/chromium/test_expectations.txt:

Dec 31, 2010:

10:54 PM Changeset in webkit [74845] by tkent@chromium.org
  • 371 edits in trunk/LayoutTests

Unreviewed, test expectation update.

r74844 enabled spell checker on Chromium Linux and Chromium
Windows. So we need to update all of images with misspelled words.

  • platform/chromium-linux/editing/deleting/delete-3928305-fix-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-3928305-fix-expected.png:
  • platform/chromium-linux/editing/deleting/delete-3959464-fix-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-3959464-fix-expected.png:
  • platform/chromium-linux/editing/deleting/delete-and-undo-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-and-undo-expected.png:
  • platform/chromium-linux/editing/deleting/delete-block-contents-003-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-block-contents-003-expected.png:
  • platform/chromium-linux/editing/deleting/delete-contiguous-ws-001-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-contiguous-ws-001-expected.png:
  • platform/chromium-linux/editing/deleting/delete-tab-002-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-tab-002-expected.png:
  • platform/chromium-linux/editing/deleting/delete-tab-003-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-tab-003-expected.png:
  • platform/chromium-linux/editing/deleting/delete-to-select-table-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-to-select-table-expected.png:
  • platform/chromium-linux/editing/deleting/delete-trailing-ws-002-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-trailing-ws-002-expected.png:
  • platform/chromium-linux/editing/deleting/delete-ws-fixup-001-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-ws-fixup-001-expected.png:
  • platform/chromium-linux/editing/deleting/delete-ws-fixup-002-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-ws-fixup-002-expected.png:
  • platform/chromium-linux/editing/execCommand/5569741-expected.checksum:
  • platform/chromium-linux/editing/execCommand/5569741-expected.png:
  • platform/chromium-linux/editing/execCommand/insert-list-and-stitch-expected.checksum:
  • platform/chromium-linux/editing/execCommand/insert-list-and-stitch-expected.png:
  • platform/chromium-linux/editing/execCommand/insertHorizontalRule-expected.checksum:
  • platform/chromium-linux/editing/execCommand/insertHorizontalRule-expected.png:
  • platform/chromium-linux/editing/execCommand/outdent-selection-expected.checksum:
  • platform/chromium-linux/editing/execCommand/outdent-selection-expected.png:
  • platform/chromium-linux/editing/inserting/5418891-expected.checksum:
  • platform/chromium-linux/editing/inserting/5418891-expected.png:
  • platform/chromium-linux/editing/inserting/editing-empty-divs-expected.checksum:
  • platform/chromium-linux/editing/inserting/editing-empty-divs-expected.png:
  • platform/chromium-linux/editing/inserting/insert-3907422-fix-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-3907422-fix-expected.png:
  • platform/chromium-linux/editing/inserting/insert-br-004-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-br-004-expected.png:
  • platform/chromium-linux/editing/inserting/insert-br-005-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-br-005-expected.png:
  • platform/chromium-linux/editing/inserting/insert-br-007-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-br-007-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-007-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-007-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-012-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-012-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-013-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-013-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-014-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-014-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-015-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-015-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-016-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-016-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-017-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-017-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-018-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-018-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-019-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-019-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-020-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-020-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-021-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-021-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-022-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-022-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-025-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-025-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-027-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-027-expected.png:
  • platform/chromium-linux/editing/inserting/insert-paragraph-02-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-paragraph-02-expected.png:
  • platform/chromium-linux/editing/inserting/insert-paragraph-03-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-paragraph-03-expected.png:
  • platform/chromium-linux/editing/inserting/insert-tab-002-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-tab-002-expected.png:
  • platform/chromium-linux/editing/inserting/insert-tab-003-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-tab-003-expected.png:
  • platform/chromium-linux/editing/inserting/insert-text-with-newlines-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-text-with-newlines-expected.png:
  • platform/chromium-linux/editing/inserting/paragraph-separator-01-expected.checksum:
  • platform/chromium-linux/editing/inserting/paragraph-separator-01-expected.png:
  • platform/chromium-linux/editing/inserting/paragraph-separator-02-expected.checksum:
  • platform/chromium-linux/editing/inserting/paragraph-separator-02-expected.png:
  • platform/chromium-linux/editing/inserting/paragraph-separator-03-expected.checksum:
  • platform/chromium-linux/editing/inserting/paragraph-separator-03-expected.png:
  • platform/chromium-linux/editing/inserting/return-key-with-selection-001-expected.checksum:
  • platform/chromium-linux/editing/inserting/return-key-with-selection-001-expected.png:
  • platform/chromium-linux/editing/inserting/return-key-with-selection-002-expected.checksum:
  • platform/chromium-linux/editing/inserting/return-key-with-selection-002-expected.png:
  • platform/chromium-linux/editing/inserting/return-key-with-selection-003-expected.checksum:
  • platform/chromium-linux/editing/inserting/return-key-with-selection-003-expected.png:
  • platform/chromium-linux/editing/inserting/typing-002-expected.checksum:
  • platform/chromium-linux/editing/inserting/typing-002-expected.png:
  • platform/chromium-linux/editing/inserting/typing-around-br-001-expected.checksum:
  • platform/chromium-linux/editing/inserting/typing-around-br-001-expected.png:
  • platform/chromium-linux/editing/pasteboard/4242293-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/4242293-expected.png:
  • platform/chromium-linux/editing/pasteboard/4944770-1-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/4944770-1-expected.png:
  • platform/chromium-linux/editing/pasteboard/8145-2-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/8145-2-expected.png:
  • platform/chromium-linux/editing/pasteboard/cut-text-001-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/cut-text-001-expected.png:
  • platform/chromium-linux/editing/pasteboard/interchange-newline-1-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/interchange-newline-1-expected.png:
  • platform/chromium-linux/editing/pasteboard/merge-after-delete-1-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/merge-after-delete-1-expected.png:
  • platform/chromium-linux/editing/pasteboard/merge-after-delete-2-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/merge-after-delete-2-expected.png:
  • platform/chromium-linux/editing/pasteboard/merge-after-delete-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/merge-after-delete-expected.png:
  • platform/chromium-linux/editing/pasteboard/merge-end-4-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/merge-end-4-expected.png:
  • platform/chromium-linux/editing/pasteboard/merge-end-blockquote-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/merge-end-blockquote-expected.png:
  • platform/chromium-linux/editing/pasteboard/merge-end-list-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/merge-end-list-expected.png:
  • platform/chromium-linux/editing/pasteboard/merge-end-table-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/merge-end-table-expected.png:
  • platform/chromium-linux/editing/pasteboard/paste-blockquote-3-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-blockquote-3-expected.png:
  • platform/chromium-linux/editing/pasteboard/paste-text-001-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-text-001-expected.png:
  • platform/chromium-linux/editing/pasteboard/paste-text-012-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-text-012-expected.png:
  • platform/chromium-linux/editing/pasteboard/paste-text-013-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-text-013-expected.png:
  • platform/chromium-linux/editing/pasteboard/paste-text-014-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-text-014-expected.png:
  • platform/chromium-linux/editing/pasteboard/paste-text-019-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-text-019-expected.png:
  • platform/chromium-linux/editing/pasteboard/paste-xml-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-xml-expected.png:
  • platform/chromium-linux/editing/pasteboard/undoable-fragment-removes-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/undoable-fragment-removes-expected.png:
  • platform/chromium-linux/editing/selection/13804-expected.checksum:
  • platform/chromium-linux/editing/selection/13804-expected.png:
  • platform/chromium-linux/editing/selection/5234383-1-expected.checksum:
  • platform/chromium-linux/editing/selection/5234383-1-expected.png:
  • platform/chromium-linux/editing/selection/5234383-2-expected.checksum:
  • platform/chromium-linux/editing/selection/5234383-2-expected.png:
  • platform/chromium-linux/editing/selection/extend-by-word-001-expected.checksum:
  • platform/chromium-linux/editing/selection/extend-by-word-001-expected.png:
  • platform/chromium-linux/editing/selection/move-backwords-by-word-001-expected.checksum:
  • platform/chromium-linux/editing/selection/move-backwords-by-word-001-expected.png:
  • platform/chromium-linux/editing/selection/move-by-character-001-expected.checksum:
  • platform/chromium-linux/editing/selection/move-by-character-001-expected.png:
  • platform/chromium-linux/editing/selection/move-by-line-001-expected.checksum:
  • platform/chromium-linux/editing/selection/move-by-line-001-expected.png:
  • platform/chromium-linux/editing/selection/move-by-word-001-expected.checksum:
  • platform/chromium-linux/editing/selection/move-by-word-001-expected.png:
  • platform/chromium-linux/editing/selection/select-from-textfield-outwards-expected.checksum:
  • platform/chromium-linux/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-linux/editing/selection/unrendered-002-expected.checksum:
  • platform/chromium-linux/editing/selection/unrendered-002-expected.png:
  • platform/chromium-linux/editing/spelling/spelling-expected.checksum:
  • platform/chromium-linux/editing/spelling/spelling-expected.png:
  • platform/chromium-linux/editing/style/5046875-2-expected.checksum:
  • platform/chromium-linux/editing/style/5046875-2-expected.png:
  • platform/chromium-linux/editing/style/block-styles-007-expected.checksum:
  • platform/chromium-linux/editing/style/block-styles-007-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-002-expected.checksum:
  • platform/chromium-linux/editing/style/create-block-for-style-002-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-003-expected.checksum:
  • platform/chromium-linux/editing/style/create-block-for-style-003-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-004-expected.checksum:
  • platform/chromium-linux/editing/style/create-block-for-style-004-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-006-expected.checksum:
  • platform/chromium-linux/editing/style/create-block-for-style-006-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-008-expected.checksum:
  • platform/chromium-linux/editing/style/create-block-for-style-008-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-009-expected.checksum:
  • platform/chromium-linux/editing/style/create-block-for-style-009-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-011-expected.checksum:
  • platform/chromium-linux/editing/style/create-block-for-style-011-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-012-expected.checksum:
  • platform/chromium-linux/editing/style/create-block-for-style-012-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-013-expected.checksum:
  • platform/chromium-linux/editing/style/create-block-for-style-013-expected.png:
  • platform/chromium-linux/fast/dom/blur-contenteditable-expected.checksum:
  • platform/chromium-linux/fast/dom/blur-contenteditable-expected.png:
  • platform/chromium-win/editing/deleting/delete-3928305-fix-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-3928305-fix-expected.png:
  • platform/chromium-win/editing/deleting/delete-3959464-fix-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-3959464-fix-expected.png:
  • platform/chromium-win/editing/deleting/delete-and-undo-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-and-undo-expected.png:
  • platform/chromium-win/editing/deleting/delete-block-contents-003-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-block-contents-003-expected.png:
  • platform/chromium-win/editing/deleting/delete-contiguous-ws-001-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-contiguous-ws-001-expected.png:
  • platform/chromium-win/editing/deleting/delete-tab-002-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-tab-002-expected.png:
  • platform/chromium-win/editing/deleting/delete-tab-003-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-tab-003-expected.png:
  • platform/chromium-win/editing/deleting/delete-to-select-table-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-to-select-table-expected.png:
  • platform/chromium-win/editing/deleting/delete-trailing-ws-002-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-trailing-ws-002-expected.png:
  • platform/chromium-win/editing/deleting/delete-ws-fixup-001-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-ws-fixup-001-expected.png:
  • platform/chromium-win/editing/deleting/delete-ws-fixup-002-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-ws-fixup-002-expected.png:
  • platform/chromium-win/editing/deleting/smart-delete-002-expected.checksum:
  • platform/chromium-win/editing/deleting/smart-delete-002-expected.png:
  • platform/chromium-win/editing/deleting/smart-delete-003-expected.checksum:
  • platform/chromium-win/editing/deleting/smart-delete-003-expected.png:
  • platform/chromium-win/editing/deleting/smart-delete-004-expected.checksum:
  • platform/chromium-win/editing/deleting/smart-delete-004-expected.png:
  • platform/chromium-win/editing/execCommand/5569741-expected.checksum:
  • platform/chromium-win/editing/execCommand/5569741-expected.png:
  • platform/chromium-win/editing/execCommand/insert-list-and-stitch-expected.checksum:
  • platform/chromium-win/editing/execCommand/insert-list-and-stitch-expected.png:
  • platform/chromium-win/editing/execCommand/insertHorizontalRule-expected.checksum:
  • platform/chromium-win/editing/execCommand/insertHorizontalRule-expected.png:
  • platform/chromium-win/editing/execCommand/outdent-selection-expected.checksum:
  • platform/chromium-win/editing/execCommand/outdent-selection-expected.png:
  • platform/chromium-win/editing/inserting/5418891-expected.checksum:
  • platform/chromium-win/editing/inserting/5418891-expected.png:
  • platform/chromium-win/editing/inserting/editing-empty-divs-expected.checksum:
  • platform/chromium-win/editing/inserting/editing-empty-divs-expected.png:
  • platform/chromium-win/editing/inserting/insert-3907422-fix-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-3907422-fix-expected.png:
  • platform/chromium-win/editing/inserting/insert-br-004-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-br-004-expected.png:
  • platform/chromium-win/editing/inserting/insert-br-005-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-br-005-expected.png:
  • platform/chromium-win/editing/inserting/insert-br-007-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-br-007-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-007-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-007-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-012-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-012-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-013-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-013-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-014-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-014-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-015-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-015-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-016-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-016-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-017-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-017-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-018-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-018-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-019-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-019-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-020-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-020-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-021-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-021-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-022-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-022-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-025-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-025-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-027-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-027-expected.png:
  • platform/chromium-win/editing/inserting/insert-paragraph-02-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-paragraph-02-expected.png:
  • platform/chromium-win/editing/inserting/insert-paragraph-03-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-paragraph-03-expected.png:
  • platform/chromium-win/editing/inserting/insert-tab-002-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-tab-002-expected.png:
  • platform/chromium-win/editing/inserting/insert-tab-003-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-tab-003-expected.png:
  • platform/chromium-win/editing/inserting/insert-text-with-newlines-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-text-with-newlines-expected.png:
  • platform/chromium-win/editing/inserting/paragraph-separator-01-expected.checksum:
  • platform/chromium-win/editing/inserting/paragraph-separator-01-expected.png:
  • platform/chromium-win/editing/inserting/paragraph-separator-02-expected.checksum:
  • platform/chromium-win/editing/inserting/paragraph-separator-02-expected.png:
  • platform/chromium-win/editing/inserting/paragraph-separator-03-expected.checksum:
  • platform/chromium-win/editing/inserting/paragraph-separator-03-expected.png:
  • platform/chromium-win/editing/inserting/return-key-with-selection-001-expected.checksum:
  • platform/chromium-win/editing/inserting/return-key-with-selection-001-expected.png:
  • platform/chromium-win/editing/inserting/return-key-with-selection-002-expected.checksum:
  • platform/chromium-win/editing/inserting/return-key-with-selection-002-expected.png:
  • platform/chromium-win/editing/inserting/return-key-with-selection-003-expected.checksum:
  • platform/chromium-win/editing/inserting/return-key-with-selection-003-expected.png:
  • platform/chromium-win/editing/inserting/typing-002-expected.checksum:
  • platform/chromium-win/editing/inserting/typing-002-expected.png:
  • platform/chromium-win/editing/inserting/typing-around-br-001-expected.checksum:
  • platform/chromium-win/editing/inserting/typing-around-br-001-expected.png:
  • platform/chromium-win/editing/pasteboard/4242293-expected.checksum:
  • platform/chromium-win/editing/pasteboard/4242293-expected.png:
  • platform/chromium-win/editing/pasteboard/4944770-1-expected.checksum:
  • platform/chromium-win/editing/pasteboard/4944770-1-expected.png:
  • platform/chromium-win/editing/pasteboard/8145-2-expected.checksum:
  • platform/chromium-win/editing/pasteboard/8145-2-expected.png:
  • platform/chromium-win/editing/pasteboard/cut-text-001-expected.checksum:
  • platform/chromium-win/editing/pasteboard/cut-text-001-expected.png:
  • platform/chromium-win/editing/pasteboard/interchange-newline-1-expected.checksum:
  • platform/chromium-win/editing/pasteboard/interchange-newline-1-expected.png:
  • platform/chromium-win/editing/pasteboard/merge-after-delete-1-expected.checksum:
  • platform/chromium-win/editing/pasteboard/merge-after-delete-1-expected.png:
  • platform/chromium-win/editing/pasteboard/merge-after-delete-2-expected.checksum:
  • platform/chromium-win/editing/pasteboard/merge-after-delete-2-expected.png:
  • platform/chromium-win/editing/pasteboard/merge-after-delete-expected.checksum:
  • platform/chromium-win/editing/pasteboard/merge-after-delete-expected.png:
  • platform/chromium-win/editing/pasteboard/merge-end-4-expected.checksum:
  • platform/chromium-win/editing/pasteboard/merge-end-4-expected.png:
  • platform/chromium-win/editing/pasteboard/merge-end-blockquote-expected.checksum:
  • platform/chromium-win/editing/pasteboard/merge-end-blockquote-expected.png:
  • platform/chromium-win/editing/pasteboard/merge-end-list-expected.checksum:
  • platform/chromium-win/editing/pasteboard/merge-end-list-expected.png:
  • platform/chromium-win/editing/pasteboard/merge-end-table-expected.checksum:
  • platform/chromium-win/editing/pasteboard/merge-end-table-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-blockquote-3-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-blockquote-3-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-text-001-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-text-001-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-text-012-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-text-012-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-text-013-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-text-013-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-text-014-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-text-014-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-text-019-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-text-019-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-xml-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-xml-expected.png:
  • platform/chromium-win/editing/pasteboard/undoable-fragment-removes-expected.checksum:
  • platform/chromium-win/editing/pasteboard/undoable-fragment-removes-expected.png:
  • platform/chromium-win/editing/selection/13804-expected.checksum:
  • platform/chromium-win/editing/selection/13804-expected.png:
  • platform/chromium-win/editing/selection/5234383-1-expected.checksum:
  • platform/chromium-win/editing/selection/5234383-1-expected.png:
  • platform/chromium-win/editing/selection/5234383-2-expected.checksum:
  • platform/chromium-win/editing/selection/5234383-2-expected.png:
  • platform/chromium-win/editing/selection/extend-by-word-001-expected.checksum:
  • platform/chromium-win/editing/selection/extend-by-word-001-expected.png:
  • platform/chromium-win/editing/selection/move-backwords-by-word-001-expected.checksum:
  • platform/chromium-win/editing/selection/move-backwords-by-word-001-expected.png:
  • platform/chromium-win/editing/selection/move-by-character-001-expected.checksum:
  • platform/chromium-win/editing/selection/move-by-character-001-expected.png:
  • platform/chromium-win/editing/selection/move-by-line-001-expected.checksum:
  • platform/chromium-win/editing/selection/move-by-line-001-expected.png:
  • platform/chromium-win/editing/selection/move-by-word-001-expected.checksum:
  • platform/chromium-win/editing/selection/move-by-word-001-expected.png:
  • platform/chromium-win/editing/selection/select-from-textfield-outwards-expected.checksum:
  • platform/chromium-win/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-win/editing/selection/unrendered-002-expected.checksum:
  • platform/chromium-win/editing/selection/unrendered-002-expected.png:
  • platform/chromium-win/editing/spelling/spelling-expected.checksum:
  • platform/chromium-win/editing/spelling/spelling-expected.png:
  • platform/chromium-win/editing/style/5046875-2-expected.checksum:
  • platform/chromium-win/editing/style/5046875-2-expected.png:
  • platform/chromium-win/editing/style/block-styles-007-expected.checksum:
  • platform/chromium-win/editing/style/block-styles-007-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-002-expected.checksum:
  • platform/chromium-win/editing/style/create-block-for-style-002-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-003-expected.checksum:
  • platform/chromium-win/editing/style/create-block-for-style-003-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-004-expected.checksum:
  • platform/chromium-win/editing/style/create-block-for-style-004-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-006-expected.checksum:
  • platform/chromium-win/editing/style/create-block-for-style-006-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-008-expected.checksum:
  • platform/chromium-win/editing/style/create-block-for-style-008-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-009-expected.checksum:
  • platform/chromium-win/editing/style/create-block-for-style-009-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-011-expected.checksum:
  • platform/chromium-win/editing/style/create-block-for-style-011-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-012-expected.checksum:
  • platform/chromium-win/editing/style/create-block-for-style-012-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-013-expected.checksum:
  • platform/chromium-win/editing/style/create-block-for-style-013-expected.png:
  • platform/chromium-win/fast/dom/blur-contenteditable-expected.checksum:
  • platform/chromium-win/fast/dom/blur-contenteditable-expected.png:
10:06 PM Changeset in webkit [74844] by tkent@chromium.org
  • 2 edits in trunk/Tools

2010-12-31 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

[DRT/Chromium] Enable mock spell checker on non-OSX
https://bugs.webkit.org/show_bug.cgi?id=51401

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::spellCheck):
6:38 PM Changeset in webkit [74843] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-12-31 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

fast/loader/about-blank-hash-change.html fails on Chromium
https://bugs.webkit.org/show_bug.cgi?id=51788

I'm unable to reproduce the failure locally, so this patch is slightly
speculative. We need to be slighly more careful how we compare the
fragment identifiers for Chromium because Chromium uses a URL parser
that is more agressive about canonicalization.

  • page/Location.cpp: (WebCore::Location::setHash):
6:17 PM Changeset in webkit [74842] by Martin Robinson
  • 3 edits in trunk/WebCore

2010-12-31 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Use GLib/GIO API for FileSystemGtk implementation
https://bugs.webkit.org/show_bug.cgi?id=51617

Complete implementation of FileSystem platform code for GLib. This
converts remaining API points using POSIX calls to platform-independent
GLib calls and fixes other compilation errors.

No new tests. This code will be tested when an implementation
of beginDragWithFiles is complete.

(WebCore::JSDirectoryEntry::getFile):
(WebCore::JSDirectoryEntry::getDirectory):

  • platform/FileSystem.h: Added forward declarations for GLib types to avoid GLib includes and changed the PlatformFileHandle to be a GIOStream.
  • platform/gtk/FileSystemGtk.cpp: (WebCore::openTemporaryFile): Reimplement using only GLib calls. (WebCore::openFile): Ditto. (WebCore::closeFile): Ditto. (WebCore::seekFile): Added implementation. (WebCore::writeToFile): Reimplement using only GLib calls. (WebCore::readFromFile): Ditto.
4:58 PM Changeset in webkit [74841] by Darin Adler
  • 12 edits in trunk/WebCore

2010-12-31 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Some renaming and refactoring of form element code
https://bugs.webkit.org/show_bug.cgi?id=51784

  • bindings/js/JSHTMLSelectElementCustom.cpp: (WebCore::JSHTMLSelectElement::remove): Call new overload of remove for option elements instead of putting the logic in the binding.
  • html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::HTMLButtonElement): Updated for name changes. (WebCore::HTMLButtonElement::defaultEventHandler): Renamed argument to "event" instead of "evt". Also updated for name changes. (WebCore::HTMLButtonElement::isActivatedSubmit): Ditto. (WebCore::HTMLButtonElement::setActivatedSubmit): Ditto. (WebCore::HTMLButtonElement::appendFormData): Ditto.
  • html/HTMLButtonElement.h: Renamed m_activeSubmit to m_isActivatedSubmit to match the getter function name. The name still doesn't seem great.
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::HTMLFormElement): Updated for name changes. (WebCore::HTMLFormElement::~HTMLFormElement): Use autoComplete function instead of m_autocomplete data member. (WebCore::HTMLFormElement::rendererIsNeeded): Use m_wasDemoted data member instead of otherwise-unused isDemoted function. (WebCore::HTMLFormElement::submitImplicitly): Updated for name changes. (WebCore::HTMLFormElement::validateInteractively): Removed code to clear m_insubmit. This is now handled by the caller, prepareForSubmission. (WebCore::HTMLFormElement::prepareForSubmission): Renamed. Updated for name changes. Moved code to clear m_isSubmittingOrPreparingForSubmission here from validateInteractively. Removed unneeded check of m_doingsubmit boolean before setting it. (WebCore::HTMLFormElement::submit): Factored this function into two. One for JavaScript and one for non-JavaScript. Neither function needs a frame argument, because the question being asked, anyPageIsProcessingUserGesture, is a question asked of an entire page group, not a specific frame or page, so it's not important which is the active frame. (WebCore::HTMLFormElement::submitFromJavaScript): Ditto. (WebCore::HTMLFormElement::reset): Updated for name changes. (WebCore::HTMLFormElement::parseMappedAttribute): Removed code to parse acceptAttr and got rid of code to set m_autocomplete. (WebCore::HTMLFormElement::elementForAlias): Changed return type to a raw pointer. (WebCore::HTMLFormElement::getNamedElements): Updated to use raw pointer and the vector find function. Added a FIXME about the comment. (WebCore::HTMLFormElement::documentDidBecomeActive): Use autoComplete function instead of m_autocomplete data member. (WebCore::HTMLFormElement::willMoveToNewOwnerDocument): Ditto. (WebCore::HTMLFormElement::didMoveToNewOwnerDocument): Ditto. (WebCore::HTMLFormElement::autoComplete): Ditto.
  • html/HTMLFormElement.h: Added a FIXME about renaming the autoComplete function. Renamed prepareSubmit to prepareForSubmission. Got rid of the frame argument from the submit function and added a new submitFromJavaScript variant. Removed the unneeded isDemoted function. Changed the return type of elementForAlias to a raw pointer. Removed m_autocomplete. Renamed m_insubmit to m_isSubmittingOrPreparingForSubmission, m_doingsubmit to m_shouldSubmit, m_inreset to m_inResetFunction, m_malformed to m_wasMalformed, m_demoted to m_wasDemoted. Use plain bool instead of bitfields.
  • html/HTMLFormElement.idl: Use the function named submitFromJavaScript instead of using CallWith=DynamicFrame because we don't need to know what frame is calling. If we did, it's not clear that the "dynamic" frame would be the right one anyway.
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::remove): Added an overload that takes an option element, since the JavaScript binding supports this.
  • html/HTMLSelectElement.h: Ditto.
  • html/ImageInputType.cpp: (WebCore::ImageInputType::handleDOMActivateEvent): Updated for name changes.
  • html/ImageInputType.h: Ditto.
  • html/SubmitInputType.cpp: (WebCore::SubmitInputType::handleDOMActivateEvent): Ditto.
4:48 PM Changeset in webkit [74840] by jberlin@webkit.org
  • 2 edits
    1 delete in trunk/LayoutTests

The correct temporary fix for media/video-element-other-namespace-crash.html timing out on
the Windows 7 Release Test bots is to add it to the Windows skipped list.

Unreviewed.

https://bugs.webkit.org/show_bug.cgi?id=51787

  • platform/win/Skipped:
  • platform/win/media/video-element-other-namespace-crash-expected.txt: Removed.
4:36 PM Changeset in webkit [74839] by dbates@webkit.org
  • 2 edits in trunk/WebCore

2010-12-31 Daniel Bates <dbates@rim.com>

Reviewed by Darin Adler.

Pass style for <area> instead of associated <img> when querying whether
the theme draws the focus ring for an <area>
https://bugs.webkit.org/show_bug.cgi?id=51632

Fixes an issue where the style for the associated <img> of an <area>
was passed when considering whether the theme should draw a focus ring
for the <area>. Instead, we should pass the theme the style for the <area>.

It's not possible to test this at this time since there are no themes
that override focus ring drawing for <area>s.

  • rendering/RenderImage.cpp: (WebCore::RenderImage::paintFocusRing): Moved call to RenderTheme::supportsFocusRing() such that it's called with respect to the focused <area>.
2:46 PM Changeset in webkit [74838] by abarth@webkit.org
  • 2 edits in trunk/WebKit

2010-12-31 Adam Barth <abarth@webkit.org>

Update SVN ignore property to hide two more external dependencies.

  • chromium: Modified property svn:ignore.
2:10 PM Changeset in webkit [74837] by jberlin@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

Add Windows-specific (failing) expected results for
media/video-element-other-namespace-crash.html in order to get the Windows 7 Release test bot green again.
Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=51787

  • platform/win/media/video-element-other-namespace-crash-expected.txt: Added.
1:45 PM Changeset in webkit [74836] by jberlin@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add Windows-specific (failing) expected results for
svg/dom/length-list-parser.html in order to get the Windows 7 Release test bot green again.
Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=51786

  • platform/win/svg/dom: Added.
  • platform/win/svg/dom/length-list-parser-expected.txt: Added.
12:36 PM Changeset in webkit [74835] by abarth@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

2010-12-31 Adam Barth <abarth@webkit.org>

Remove custom Chromium expectation for invalid-protocol. Now that we
share more code with JavaScriptCore, we throw exactly the same
exception and therefore can share results.

  • platform/chromium/fast/dom/Window/invalid-protocol-expected.txt: Removed.
12:12 PM Changeset in webkit [74834] by Darin Adler
  • 2 edits in trunk/WebCore
  • WebCore.xcodeproj/project.pbxproj: Added back the language.

Developers should be using Xcode 3.2.5 or newer.

11:56 AM Changeset in webkit [74833] by abarth@webkit.org
  • 8 edits in trunk/WebCore

2010-12-31 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move V8 to WebCore Location implementation
https://bugs.webkit.org/show_bug.cgi?id=51768

  • bindings/generic/BindingFrame.h:
  • bindings/generic/BindingLocation.h:
  • bindings/v8/V8Binding.h:
  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::setLocation):
  • bindings/v8/V8Utilities.cpp:
  • bindings/v8/V8Utilities.h:
  • bindings/v8/custom/V8LocationCustom.cpp: (WebCore::V8Location::hashAccessorSetter): (WebCore::V8Location::hostAccessorSetter): (WebCore::V8Location::hostnameAccessorSetter): (WebCore::V8Location::hrefAccessorSetter): (WebCore::V8Location::pathnameAccessorSetter): (WebCore::V8Location::portAccessorSetter): (WebCore::V8Location::protocolAccessorSetter): (WebCore::V8Location::searchAccessorSetter): (WebCore::V8Location::reloadCallback): (WebCore::V8Location::replaceCallback): (WebCore::V8Location::assignCallback):
9:58 AM Changeset in webkit [74832] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-12-31 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Eric Seidel.

Make retrieving extraMediaControlsStyleSheet be page dependent.
https://bugs.webkit.org/show_bug.cgi?id=51752

Use themeForPage to retrieve extraMediaControlsStyleSheet for media
controls.

No new tests because no platform-specific theme implementation uses
the passed page pointer yet.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::styleForElement):
8:11 AM Changeset in webkit [74831] by abarth@webkit.org
  • 1 edit
    1 delete in trunk/Tools

2010-12-31 Adam Barth <abarth@webkit.org>

Reviewed by Ariya Hidayat.

Remove Tools/Scripts/wkstyle
https://bugs.webkit.org/show_bug.cgi?id=51774

This script appears to not have been touched in a while and seems to
have been replaced by check-webkit-style.

  • Scripts/wkstyle: Removed.
5:02 AM Changeset in webkit [74830] by loislo@chromium.org
  • 2 edits in trunk/WebCore

2010-12-31 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] WebInspector.ResourcesPanel.prototype.canShowSourceLine() broken.

https://bugs.webkit.org/show_bug.cgi?id=51709

  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.canShowSourceLine):
4:43 AM Changeset in webkit [74829] by Patrick Gansterer
  • 2 edits in trunk/JavaScriptCore

2010-12-31 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Add a fast case for ASCII strings in HashAndUTF8CharactersTranslator::equal
https://bugs.webkit.org/show_bug.cgi?id=50517

This change shows about 2% performance win on the xml-parser benchmark.

  • wtf/text/AtomicString.cpp: (WTF::HashAndUTF8CharactersTranslator::equal):
3:59 AM Changeset in webkit [74828] by Patrick Gansterer
  • 3 edits in trunk/WebCore

2010-12-31 Patrick Gansterer <Patrick Gansterer>

Unreviewed build fix after r74800.

  • bindings/js/JSDOMWindowCustom.cpp: Add missing header.
  • bindings/js/JSLocationCustom.cpp: Ditto.
3:47 AM Changeset in webkit [74827] by loislo@chromium.org
  • 2 edits in trunk/Tools

2010-12-31 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed. Coding style fix.

  • DumpRenderTree/chromium/TestShell.h:
3:41 AM Changeset in webkit [74826] by loislo@chromium.org
  • 4 edits in trunk/Tools

2010-12-31 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).

It was a problem with Chromium DRT. DevToolsAgent object instance was
attached not only to the inspected page but to the DevTools window too.
As result all the inspector files were interpreted as a content of inspected page
and were transfered to the DevTools scripts panel for debugging etc.

https://bugs.webkit.org/show_bug.cgi?id=51735

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): (TestShell::bindJSObjectsToWindow): (TestShell::createNewWindow):
  • DumpRenderTree/chromium/TestShell.h:
2:16 AM Changeset in webkit [74825] by abarth@webkit.org
  • 2 edits
    1 copy
    1 add
    1 delete in trunk

Move HTML and XML parser benchmarks into PerformanceTests/Parser
https://bugs.webkit.org/show_bug.cgi?id=51772

Rubber-stamped by Eric Seidel.

Actually move the directory.

  • PerformanceTests/Parser: Copied from WebCore/benchmarks/parser.

PerformanceTests/Parser:

Add a ChangeLog for tracking changes to the Parser PerformanceTest.

  • ChangeLog: Added.

WebCore:

Remove the benchmarks folder now that it's empty. Future benchmarks
should go in the PerformanceTests directory.

  • benchmarks: Removed.
  • benchmarks/parser: Removed.
  • benchmarks/parser/html-parser.html: Removed.
  • benchmarks/parser/resources: Removed.
  • benchmarks/parser/resources/html5.html: Removed.
  • benchmarks/parser/resources/runner.js: Removed.
  • benchmarks/parser/xml-parser.html: Removed.
2:01 AM Changeset in webkit [74824] by abarth@webkit.org
  • 2 edits
    2 copies in trunk/WebCore

2010-12-31 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Add XML parser benchmark
https://bugs.webkit.org/show_bug.cgi?id=51612

Move the JavaScript code of html parser into a separate file to share it with xml parser.

  • benchmarks/parser/html-parser.html:
  • benchmarks/parser/resources/runner.js: Copied from WebCore/benchmarks/parser/html-parser.html. (runFunction): (run): (start):
  • benchmarks/parser/xml-parser.html: Copied from WebCore/benchmarks/parser/html-parser.html.
1:51 AM Changeset in webkit [74823] by abarth@webkit.org
  • 9 edits
    1 move in trunk

Move PageLoadTests to PerformanceTests/PageLoad
https://bugs.webkit.org/show_bug.cgi?id=51771

Rubber-stamped by Eric Seidel.

Actually move the directory.

  • PageLoadTests: Removed.
  • PageLoadTests/svg: Removed.
  • PageLoadTests/svg/LICENSES: Removed.
  • PageLoadTests/svg/files: Removed.
  • PageLoadTests/svg/files/33041-Samurai.svg: Removed.
  • PageLoadTests/svg/files/42450-under the see.svg: Removed.
  • PageLoadTests/svg/files/42470-flower_from_my_garden_v2.svg: Removed.
  • PageLoadTests/svg/files/44057-drops on a blade.svg: Removed.
  • PageLoadTests/svg/files/Harvey_Rayner.svg: Removed.
  • PageLoadTests/svg/files/az-lizard_benji_park_01.svg: Removed.
  • PageLoadTests/svg/files/bamboo_01.svg: Removed.
  • PageLoadTests/svg/files/cacuts_01.svg: Removed.
  • PageLoadTests/svg/files/cowboy.svg: Removed.
  • PageLoadTests/svg/files/crawfish2_ganson.svg: Removed.
  • PageLoadTests/svg/files/deb9frac1.svg: Removed.
  • PageLoadTests/svg/files/food_leif_lodahl_01.svg: Removed.
  • PageLoadTests/svg/files/france.svg: Removed.
  • PageLoadTests/svg/files/francobollo_gnome_ezechi_02.svg: Removed.
  • PageLoadTests/svg/files/gearflowers.svg: Removed.
  • PageLoadTests/svg/files/hereGear4.svg: Removed.
  • PageLoadTests/svg/files/mtsthelens.svg: Removed.
  • PageLoadTests/svg/files/mtsthelens0.jpg: Removed.
  • PageLoadTests/svg/files/world-iso.svg: Removed.
  • PageLoadTests/svg/files/worldcup.svg: Removed.
  • PageLoadTests/svg/svg.pltsuite: Removed.
  • PerformanceTests/PageLoad: Copied from PageLoadTests.
  • Sources/cmake/WebKitPackaging.cmake:

PerformanceTests/PageLoad:

Update URLs to point to the new directory name.

  • svg/svg.pltsuite:

Tools:

Update references to PageLoadTests to point to the new location.

  • Scripts/run-pageloadtest:
  • Scripts/webkitpy/common/config/build.py:

Websites/bugs.webkit.org:

Update list of top-level open-source directories.

  • PrettyPatch/PrettyPatch.rb:
1:28 AM Changeset in webkit [74822] by abarth@webkit.org
  • 7 edits
    1 move
    1 add in trunk

Move SunSpider into PerformanceTests
https://bugs.webkit.org/show_bug.cgi?id=51769

Rubber-stamped by Eric Seidel.

Actually move the directory.

  • PerformanceTests: Added.
  • PerformanceTests/SunSpider: Copied from SunSpider.
  • Sources/cmake/WebKitPackaging.cmake:
  • SunSpider: Removed.
  • SunSpider/SunSpider.make: Removed.
  • SunSpider/TODO: Removed.
  • SunSpider/UNCOVERED: Removed.
  • SunSpider/hosted: Removed.
  • SunSpider/hosted/json2.js: Removed.
  • SunSpider/hosted/sunspider.css: Removed.
  • SunSpider/hosted/sunspider.html: Removed.
  • SunSpider/hosted/versions.html: Removed.
  • SunSpider/make-hosted: Removed.
  • SunSpider/resources: Removed.
  • SunSpider/resources/TEMPLATE.html: Removed.
  • SunSpider/resources/driver-TEMPLATE.html: Removed.
  • SunSpider/resources/results-TEMPLATE.html: Removed.
  • SunSpider/resources/sunspider-analyze-results.js: Removed.
  • SunSpider/resources/sunspider-compare-results.js: Removed.
  • SunSpider/resources/sunspider-standalone-compare.js: Removed.
  • SunSpider/resources/sunspider-standalone-driver.js: Removed.
  • SunSpider/sunspider: Removed.
  • SunSpider/sunspider-compare-results: Removed.
  • SunSpider/tests: Removed.
  • SunSpider/tests/parse-only: Removed.
  • SunSpider/tests/parse-only/LIST: Removed.
  • SunSpider/tests/parse-only/concat-jquery-mootools-prototype.js: Removed.
  • SunSpider/tests/parse-only/jquery-1.3.2.js: Removed.
  • SunSpider/tests/parse-only/mootools-1.2.2-core-nc.js: Removed.
  • SunSpider/tests/parse-only/prototype-1.6.0.3.js: Removed.
  • SunSpider/tests/sunspider-0.9: Removed.
  • SunSpider/tests/sunspider-0.9.1: Removed.
  • SunSpider/tests/sunspider-0.9.1/3d-cube.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/3d-morph.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/3d-raytrace.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/LIST: Removed.
  • SunSpider/tests/sunspider-0.9.1/access-binary-trees.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/access-fannkuch.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/access-nbody.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/access-nsieve.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/bitops-3bit-bits-in-byte.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/bitops-bits-in-byte.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/bitops-bitwise-and.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/bitops-nsieve-bits.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/controlflow-recursive.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/crypto-aes.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/crypto-md5.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/crypto-sha1.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/date-format-tofte.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/date-format-xparb.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/math-cordic.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/math-partial-sums.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/math-spectral-norm.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/regexp-dna.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/string-base64.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/string-fasta.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/string-tagcloud.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/string-unpack-code.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/string-validate-input.js: Removed.
  • SunSpider/tests/sunspider-0.9/3d-cube.js: Removed.
  • SunSpider/tests/sunspider-0.9/3d-morph.js: Removed.
  • SunSpider/tests/sunspider-0.9/3d-raytrace.js: Removed.
  • SunSpider/tests/sunspider-0.9/LIST: Removed.
  • SunSpider/tests/sunspider-0.9/access-binary-trees.js: Removed.
  • SunSpider/tests/sunspider-0.9/access-fannkuch.js: Removed.
  • SunSpider/tests/sunspider-0.9/access-nbody.js: Removed.
  • SunSpider/tests/sunspider-0.9/access-nsieve.js: Removed.
  • SunSpider/tests/sunspider-0.9/bitops-3bit-bits-in-byte.js: Removed.
  • SunSpider/tests/sunspider-0.9/bitops-bits-in-byte.js: Removed.
  • SunSpider/tests/sunspider-0.9/bitops-bitwise-and.js: Removed.
  • SunSpider/tests/sunspider-0.9/bitops-nsieve-bits.js: Removed.
  • SunSpider/tests/sunspider-0.9/controlflow-recursive.js: Removed.
  • SunSpider/tests/sunspider-0.9/crypto-aes.js: Removed.
  • SunSpider/tests/sunspider-0.9/crypto-md5.js: Removed.
  • SunSpider/tests/sunspider-0.9/crypto-sha1.js: Removed.
  • SunSpider/tests/sunspider-0.9/date-format-tofte.js: Removed.
  • SunSpider/tests/sunspider-0.9/date-format-xparb.js: Removed.
  • SunSpider/tests/sunspider-0.9/math-cordic.js: Removed.
  • SunSpider/tests/sunspider-0.9/math-partial-sums.js: Removed.
  • SunSpider/tests/sunspider-0.9/math-spectral-norm.js: Removed.
  • SunSpider/tests/sunspider-0.9/regexp-dna.js: Removed.
  • SunSpider/tests/sunspider-0.9/string-base64.js: Removed.
  • SunSpider/tests/sunspider-0.9/string-fasta.js: Removed.
  • SunSpider/tests/sunspider-0.9/string-tagcloud.js: Removed.
  • SunSpider/tests/sunspider-0.9/string-unpack-code.js: Removed.
  • SunSpider/tests/sunspider-0.9/string-validate-input.js: Removed.
  • SunSpider/tests/ubench: Removed.
  • SunSpider/tests/ubench/LIST: Removed.
  • SunSpider/tests/ubench/function-closure.js: Removed.
  • SunSpider/tests/ubench/function-correct-args.js: Removed.
  • SunSpider/tests/ubench/function-empty.js: Removed.
  • SunSpider/tests/ubench/function-excess-args.js: Removed.
  • SunSpider/tests/ubench/function-missing-args.js: Removed.
  • SunSpider/tests/ubench/function-sum.js: Removed.
  • SunSpider/tests/ubench/loop-empty-resolve.js: Removed.
  • SunSpider/tests/ubench/loop-empty.js: Removed.
  • SunSpider/tests/ubench/loop-sum.js: Removed.
  • SunSpider/tests/v8-v4: Removed.
  • SunSpider/tests/v8-v4/LIST: Removed.
  • SunSpider/tests/v8-v4/v8-crypto.js: Removed.
  • SunSpider/tests/v8-v4/v8-deltablue.js: Removed.
  • SunSpider/tests/v8-v4/v8-earley-boyer.js: Removed.
  • SunSpider/tests/v8-v4/v8-raytrace.js: Removed.
  • SunSpider/tests/v8-v4/v8-regexp.js: Removed.
  • SunSpider/tests/v8-v4/v8-richards.js: Removed.
  • SunSpider/tests/v8-v4/v8-splay.js: Removed.
  • SunSpider/tests/v8-v5: Removed.
  • SunSpider/tests/v8-v5/LIST: Removed.
  • SunSpider/tests/v8-v5/v8-crypto.js: Removed.
  • SunSpider/tests/v8-v5/v8-deltablue.js: Removed.
  • SunSpider/tests/v8-v5/v8-earley-boyer.js: Removed.
  • SunSpider/tests/v8-v5/v8-raytrace.js: Removed.
  • SunSpider/tests/v8-v5/v8-regexp.js: Removed.
  • SunSpider/tests/v8-v5/v8-richards.js: Removed.
  • SunSpider/tests/v8-v5/v8-splay.js: Removed.
  • SunSpider/tests/v8-v6: Removed.
  • SunSpider/tests/v8-v6/LIST: Removed.
  • SunSpider/tests/v8-v6/v8-crypto.js: Removed.
  • SunSpider/tests/v8-v6/v8-deltablue.js: Removed.
  • SunSpider/tests/v8-v6/v8-earley-boyer.js: Removed.
  • SunSpider/tests/v8-v6/v8-raytrace.js: Removed.
  • SunSpider/tests/v8-v6/v8-regexp.js: Removed.
  • SunSpider/tests/v8-v6/v8-richards.js: Removed.
  • SunSpider/tests/v8-v6/v8-splay.js: Removed.
  • SunSpider/xcopy.excludes: Removed.

Tools:

Update these scripts to point to the new location.

  • Scripts/run-sunspider:
  • Scripts/sunspider-compare-results:

Websites/bugs.webkit.org:

Update list of top-level open-source directories.

  • PrettyPatch/PrettyPatch.rb:
Note: See TracTimeline for information about the timeline view.