Timeline
Jan 3, 2011:
- 10:47 PM Changeset in webkit [74958] by
-
- 1 edit28 adds in trunk/LayoutTests
2011-01-03 Kent Tamura <tkent@chromium.org>
Unreviewed, test expectation update
Add expectations of r74954 tests for Chromium.
- platform/chromium-linux/fast/css-generated-content/table-before-after-child-add-expected.checksum: Added.
- platform/chromium-linux/fast/css-generated-content/table-before-after-child-add-expected.png: Added.
- platform/chromium-linux/fast/css-generated-content/table-cell-before-after-child-add-expected.checksum: Added.
- platform/chromium-linux/fast/css-generated-content/table-cell-before-after-child-add-expected.png: Added.
- platform/chromium-linux/fast/css-generated-content/table-row-before-after-child-add-expected.checksum: Added.
- platform/chromium-linux/fast/css-generated-content/table-row-before-after-child-add-expected.png: Added.
- platform/chromium-linux/fast/css-generated-content/table-table-before-after-child-add-expected.checksum: Added.
- platform/chromium-linux/fast/css-generated-content/table-table-before-after-child-add-expected.png: Added.
- platform/chromium-mac/fast/css-generated-content/table-before-after-child-add-expected.checksum: Added.
- platform/chromium-mac/fast/css-generated-content/table-before-after-child-add-expected.png: Added.
- platform/chromium-mac/fast/css-generated-content/table-cell-before-after-child-add-expected.checksum: Added.
- platform/chromium-mac/fast/css-generated-content/table-cell-before-after-child-add-expected.png: Added.
- platform/chromium-mac/fast/css-generated-content/table-row-before-after-child-add-expected.checksum: Added.
- platform/chromium-mac/fast/css-generated-content/table-row-before-after-child-add-expected.png: Added.
- platform/chromium-mac/fast/css-generated-content/table-table-before-after-child-add-expected.checksum: Added.
- platform/chromium-mac/fast/css-generated-content/table-table-before-after-child-add-expected.png: Added.
- platform/chromium-win/fast/css-generated-content/table-before-after-child-add-expected.checksum: Added.
- platform/chromium-win/fast/css-generated-content/table-before-after-child-add-expected.png: Added.
- platform/chromium-win/fast/css-generated-content/table-before-after-child-add-expected.txt: Added.
- platform/chromium-win/fast/css-generated-content/table-cell-before-after-child-add-expected.checksum: Added.
- platform/chromium-win/fast/css-generated-content/table-cell-before-after-child-add-expected.png: Added.
- platform/chromium-win/fast/css-generated-content/table-cell-before-after-child-add-expected.txt: Added.
- platform/chromium-win/fast/css-generated-content/table-row-before-after-child-add-expected.checksum: Added.
- platform/chromium-win/fast/css-generated-content/table-row-before-after-child-add-expected.png: Added.
- platform/chromium-win/fast/css-generated-content/table-row-before-after-child-add-expected.txt: Added.
- platform/chromium-win/fast/css-generated-content/table-table-before-after-child-add-expected.checksum: Added.
- platform/chromium-win/fast/css-generated-content/table-table-before-after-child-add-expected.png: Added.
- platform/chromium-win/fast/css-generated-content/table-table-before-after-child-add-expected.txt: Added.
- 10:20 PM Changeset in webkit [74957] by
-
- 3 edits4 adds in trunk
WebCore: HTML5 Conformance Test failure: approved/xhtml5/object_border_pixel.xhtml
https://bugs.webkit.org/show_bug.cgi?id=48596
Patch by Julie-Jeongeun-Kim <Jeongeun.Kim@obigo.com> on 2011-01-03
Reviewed by Darin Adler.
border attribute was not parsed in HTMLObjectElement.
I added code for it as HTMLImageElement handled.
new test:fast/html/object-border.html
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::parseMappedAttribute):
LayoutTests: HTML5 Conformance Test failure: approved/xhtml5/object_border_pixel.xhtml
https://bugs.webkit.org/show_bug.cgi?id=48596
Patch by Julie-Jeongeun-Kim <Jeongeun.Kim@obigo.com> on 2011-01-03
Reviewed by Darin Adler.
- fast/html/object-border-expected.txt: Added.
- fast/html/object-border.html: Added.
- fast/html/resources/images/blue-border.png: Added.
- fast/html/resources/images/blue.png: Added.
- 9:36 PM Changeset in webkit [74956] by
-
- 2 edits in trunk/WebCore
Try to fix Chromium build.
- history/HistoryItem.cpp:
(WebCore::HistoryItem::encodeBackForwardTreeNode): Added a V8 case here.
Not sure this ever will be used with V8.
(WebCore::HistoryItem::decodeBackForwardTree): Ditto.
- 9:31 PM Changeset in webkit [74955] by
-
- 2 edits in trunk/WebCore
Try to fix Leopard build.
- history/HistoryItem.cpp: Use a consistent type, uint64_t, for the
size variable.
- 6:27 PM Changeset in webkit [74954] by
-
- 5 edits16 adds2 deletes in trunk
2011-01-01 Abhishek Arya <inferno@chromium.org>
Reviewed by Darin Adler.
Fixes before child calculation when adding anonymous childs to table parts.
https://bugs.webkit.org/show_bug.cgi?id=50932
Fix in r74364 was incomplete. When before child is equal to the table part(to
which the new child is getting added), it confuses the table part to add it
incorrectly as an after child. The patch fixes by passing the before child as
the table part's first child.
Tests: fast/css-generated-content/table-before-after-child-add.html
fast/css-generated-content/table-cell-before-after-child-add.html
fast/css-generated-content/table-row-before-after-child-add.html
fast/css-generated-content/table-row-before-after-child-add.html
- rendering/RenderTable.cpp: (WebCore::RenderTable::addChild):
- rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::addChild):
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addChild):
2010-12-20 Abhishek Arya <inferno@chromium.org>
Reviewed by Darin Adler.
Tests that "before" and "after" childs are added to table correctly.
https://bugs.webkit.org/show_bug.cgi?id=50932
- fast/css-generated-content/table-before-after-child-add.html: Added.
- fast/css-generated-content/table-before-child-add.html: Removed.
- fast/css-generated-content/table-cell-before-after-child-add.html: Added.
- fast/css-generated-content/table-row-before-after-child-add.html: Added.
- platform/mac/fast/css-generated-content/table-before-after-child-add-expected.checksum: Added.
- platform/mac/fast/css-generated-content/table-before-after-child-add-expected.png: Added.
- platform/mac/fast/css-generated-content/table-before-after-child-add-expected.txt: Added.
- platform/mac/fast/css-generated-content/table-before-child-add-expected.txt: Removed.
- platform/mac/fast/css-generated-content/table-cell-before-after-child-add-expected.checksum: Added.
- platform/mac/fast/css-generated-content/table-cell-before-after-child-add-expected.png: Added.
- platform/mac/fast/css-generated-content/table-cell-before-after-child-add-expected.txt: Added.
- platform/mac/fast/css-generated-content/table-row-before-after-child-add-expected.checksum: Added.
- platform/mac/fast/css-generated-content/table-row-before-after-child-add-expected.png: Added.
- platform/mac/fast/css-generated-content/table-row-before-after-child-add-expected.txt: Added.
- platform/mac/fast/css-generated-content/table-table-before-after-child-add-expected.checksum: Added.
- platform/mac/fast/css-generated-content/table-table-before-after-child-add-expected.png: Added.
- platform/mac/fast/css-generated-content/table-table-before-after-child-add-expected.txt: Added.
- 6:02 PM Changeset in webkit [74953] by
-
- 3 edits in trunk/WebCore
Shrink HTMLTableCellElement
https://bugs.webkit.org/show_bug.cgi?id=51858
Reviewed by Simon Fraser.
- html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::HTMLTableCellElement): Removed intialization of m_row and
m_col.
- html/HTMLTableCellElement.h: Removed m_row and m_col and their accessors.
- 5:57 PM Changeset in webkit [74952] by
-
- 4 edits in trunk/WebCore
Fix build.
- platform/network/FormData.cpp:
(WebCore::FormData::create): Roll back uint8_t change.
(WebCore::FormData::flatten): Ditto.
(WebCore::FormData::flattenToString): Ditto.
(WebCore::encode): Ditto.
(WebCore::decode): Ditto.
(WebCore::FormData::encodeForBackForward):
- platform/network/FormData.h: Ditto.
- platform/network/mac/FormDataStreamMac.mm:
(WebCore::advanceCurrentStream): Ditto.
- 5:35 PM Changeset in webkit [74951] by
-
- 6 edits in trunk/WebCore
2011-01-03 Darin Adler <Darin Adler>
Reviewed by Brady Eidson.
Add code to encode/decode the back/forward tree
https://bugs.webkit.org/show_bug.cgi?id=51853
- history/HistoryItem.cpp: (WebCore::HistoryItem::encodeBackForwardTree): Added. (WebCore::HistoryItem::encodeBackForwardTreeNode): Added. (WebCore::HistoryItem::decodeBackForwardTree): Added.
- history/HistoryItem.h: Added functions above.
- platform/network/FormData.cpp: (WebCore::FormData::create): Changed type to Vector<uint8_t> instead of Vector<char>. This type is used in our newer code for vectors of bytes. (WebCore::FormData::flatten): Ditto. (WebCore::FormData::flattenToString): Ditto. Had to add a cast here. (WebCore::FormData::encodeForBackForward): Added. (WebCore::FormData::decodeForBackForward): Added.
- platform/network/FormData.h: Changed type to Vector<uint8_t> instead of Vector<char>. Also made some single-argument constructors explicit. Also added the new functions.
- platform/network/mac/FormDataStreamMac.mm: (WebCore::advanceCurrentStream): Changed to use uint8_t to match above.
- 5:28 PM Changeset in webkit [74950] by
-
- 2 edits in trunk/WebCore
2011-01-03 Simon Fraser <Simon Fraser>
Attempt to fix GTK build.
- platform/graphics/gtk/FontGtk.cpp: (WebCore::drawGlyphsShadow):
- 4:54 PM Changeset in webkit [74949] by
-
- 2 edits in trunk/WebKit/cf
Mac build fix. Define WTF_USE_CFNETWORK for Windows build only.
- WebCoreSupport/WebInspectorClientCF.cpp:
- 4:39 PM Changeset in webkit [74948] by
-
- 2 edits in trunk/WebKit/cf
Windows build fix. Define WTF_USE_CFNETWORK in WebInspectorClientCF.
- WebCoreSupport/WebInspectorClientCF.cpp:
- 4:21 PM Changeset in webkit [74947] by
-
- 13 edits in trunk/WebCore
2011-01-03 Helder Correia <helder@sencha.com>
Reviewed by Simon Fraser.
ContextShadow can avoid code duplication for getting the CTM
https://bugs.webkit.org/show_bug.cgi?id=51799
ContextShadow defines its own getTransformationMatrixFromContext()
which does exactly the same as GraphicsContext::getCTM().
Existing tests: fast/canvas/canvas*shadow*html
- platform/graphics/ContextShadow.cpp: (WebCore::ContextShadow::mustUseContextShadow): (WebCore::ContextShadow::adjustBlurDistance): (WebCore::ContextShadow::calculateLayerBoundingRect):
- platform/graphics/ContextShadow.h:
- platform/graphics/cairo/ContextShadowCairo.cpp: (WebCore::ContextShadow::beginShadowLayer): (WebCore::ContextShadow::endShadowLayer): (WebCore::ContextShadow::drawRectShadowWithoutTiling):
- platform/graphics/cairo/FontCairo.cpp: (WebCore::drawGlyphsShadow):
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::drawPathShadow):
- platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::draw):
- platform/graphics/gtk/FontGtk.cpp: (WebCore::drawGlyphsShadow):
- platform/graphics/qt/ContextShadowQt.cpp: (WebCore::ContextShadow::beginShadowLayer): (WebCore::ContextShadow::endShadowLayer):
- platform/graphics/qt/FontQt.cpp: (WebCore::drawTextCommon):
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect):
- platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::draw):
- platform/graphics/qt/StillImageQt.cpp: (WebCore::StillImage::draw):
- 4:09 PM Changeset in webkit [74946] by
-
- 3 edits in trunk/WebCore
2011-01-03 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
InsertTextCommand::m_charactersAdded is unused
https://bugs.webkit.org/show_bug.cgi?id=51849
- editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::InsertTextCommand): Don't initialize m_charactersAdded. (WebCore::InsertTextCommand::input): Don't update m_charactersAdded.
- editing/InsertTextCommand.h: Removed charactersAdded function and m_charactersAdded data member.
- 3:56 PM Changeset in webkit [74945] by
-
- 4 edits in trunk/WebCore
2011-01-03 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Move paintMenuListButton() to RenderThemeGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=51832
Method paintMenuListButton() contains code common to both gtk 2
and 3, so it can be moved to RenderThemeGtk.cpp instead of
duplicating it.
- platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::paintMenuListButton):
- platform/gtk/RenderThemeGtk2.cpp:
- platform/gtk/RenderThemeGtk3.cpp:
- 3:52 PM WebKit Team edited by
- Adding myself to the committers list. (diff)
- 3:52 PM Changeset in webkit [74944] by
-
- 2 edits in trunk
2011-01-03 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
- autogen.sh: also pass $ACLOCAL_FLAGS for tools that set that env variable (like jhbuild).
- 3:45 PM Changeset in webkit [74943] by
-
- 31 edits in trunk/WebCore
2011-01-03 Pratik Solanki <psolanki@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=51850
Put CFNetwork loader code inside USE(CFNETWORK)
Add USE(CFNETWORK) macros around all the cf/mac network files. Also added all CFNetwork
files to the WebCore Xcode project.
- WebCore.xcodeproj/project.pbxproj:
- loader/cf/ResourceLoaderCFNet.cpp:
- loader/mac/ResourceLoaderMac.mm:
- platform/network/cf/AuthenticationCF.cpp:
- platform/network/cf/AuthenticationCF.h:
- platform/network/cf/CookieJarCFNet.cpp:
- platform/network/cf/CookieStorageCFNet.cpp:
- platform/network/cf/CookieStorageCFNet.h:
- platform/network/cf/CredentialStorageCFNet.cpp:
- platform/network/cf/FormDataStreamCFNet.cpp:
- platform/network/cf/FormDataStreamCFNet.h:
- platform/network/cf/LoaderRunLoopCF.cpp:
- platform/network/cf/LoaderRunLoopCF.h:
- platform/network/cf/ResourceError.h:
- platform/network/cf/ResourceHandleCFNet.cpp:
- platform/network/cf/ResourceRequest.h:
- platform/network/cf/ResourceRequestCFNet.cpp:
- platform/network/cf/ResourceRequestCFNet.h:
- platform/network/cf/ResourceResponse.h:
- platform/network/cf/ResourceResponseCFNet.cpp:
- platform/network/mac/AuthenticationMac.h:
- platform/network/mac/AuthenticationMac.mm:
- platform/network/mac/FormDataStreamMac.h:
- platform/network/mac/FormDataStreamMac.mm:
- platform/network/mac/ResourceError.h:
- platform/network/mac/ResourceHandleMac.mm:
- platform/network/mac/ResourceRequest.h:
- platform/network/mac/ResourceRequestMac.mm:
- platform/network/mac/ResourceResponse.h:
- platform/network/mac/ResourceResponseMac.mm:
- 3:43 PM Changeset in webkit [74942] by
-
- 2 edits in trunk
2011-01-03 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
Use autoreconf instead of calling manually all the usual commands.
- autogen.sh: call autoreconf instead of aclocal/autoheader/autoconf/automake/libtoolize.
- 3:42 PM Changeset in webkit [74941] by
-
- 15 edits in trunk
2011-01-03 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Adam Barth.
[Qt] Add SelectAll option to the context menu for the editor
https://bugs.webkit.org/show_bug.cgi?id=50049
Set shortcut for the SelectAll action.
- QtTestBrowser/mainwindow.cpp: (MainWindow::buildUI):
2011-01-03 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Adam Barth.
[Qt] Add SelectAll option to the context menu for the editor
https://bugs.webkit.org/show_bug.cgi?id=50049
Enable SelectAll for the Qt context menu.
- page/ContextMenuController.cpp: (WebCore::ContextMenuController::populate):
- platform/ContextMenuItem.h:
- platform/LocalizationStrategy.h:
- platform/LocalizedStrings.cpp: (WebCore::contextMenuItemTagSelectAll):
- platform/LocalizedStrings.h:
2011-01-03 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Adam Barth.
[Qt] Add SelectAll option to the context menu for the editor
https://bugs.webkit.org/show_bug.cgi?id=50049
Enable SelectAll for the Qt context menu.
- Api/qwebpage.cpp: (webActionForContextMenuAction): (QWebPage::action):
- WebCoreSupport/WebPlatformStrategies.cpp: (WebPlatformStrategies::contextMenuItemTagSelectAll):
- WebCoreSupport/WebPlatformStrategies.h:
2011-01-03 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Adam Barth.
[Qt] Add SelectAll option to the context menu for the editor
https://bugs.webkit.org/show_bug.cgi?id=50049
Add WebPlatformStrategies::contextMenuItemTagSelectAll for Qt.
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::WebPlatformStrategies::contextMenuItemTagSelectAll):
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
- 2:25 PM Changeset in webkit [74940] by
-
- 4 edits in trunk/WebKitLibraries
Reviewed, tweaked and landed by Sam Weinig.
Patch by Chris Fleizach <Chris Fleizach> on 2011-01-03
WebKit2: Accessibility support (42130)
<rdar://problem/7660629>
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- 1:53 PM Changeset in webkit [74939] by
-
- 2 edits in trunk/LayoutTests
2011-01-03 Mihai Parparita <mihaip@chromium.org>
Unreviewed, Chromium test expectation update.
Group tests that fail on Leopard but pass on Snow Leopard (due to
stale platform/mac baselines).
- platform/chromium/test_expectations.txt:
- 1:42 PM Changeset in webkit [74938] by
-
- 2 edits in trunk
2011-01-03 Patrick Gansterer <Patrick Gansterer>
Reviewed by Darin Adler.
[WINCE] Provide third party directory via environment variable
https://bugs.webkit.org/show_bug.cgi?id=51643
- Source/cmake/OptionsWinCE.cmake:
- 1:40 PM Changeset in webkit [74937] by
-
- 3 edits in trunk/WebCore
Shrink RootInlineBox
https://bugs.webkit.org/show_bug.cgi?id=51847
Reviewed by Darin Adler.
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::alignBoxesInBlockDirection): Changed to use the baselineType()
accessor.
- rendering/RootInlineBox.h: Rolled m_baselineType into a bitfield. Changed its type to
unsigned because otherwise MSVC treats it as signed.
(WebCore::RootInlineBox::baselineType): Added a cast.
- 1:38 PM Changeset in webkit [74936] by
-
- 2 edits in trunk/Source/JavaScriptCore
- wtf/Forward.h: Added Decoder and Encoder.
Reviewed by Brady Eidson.
- 1:36 PM Changeset in webkit [74935] by
-
- 4 adds in trunk/WebKit/gtk/webkit
Adding files I missed in my last git add. *shame*
- 1:21 PM Changeset in webkit [74934] by
-
- 3 edits in trunk/Tools
2011-01-03 David Levin <levin@chromium.org>
Reviewed by Eric Seidel.
check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
https://bugs.webkit.org/show_bug.cgi?id=51842
- Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
- Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
- 1:20 PM Changeset in webkit [74933] by
-
- 39 edits1 copy2 adds2 deletes in trunk
WebKit/gtk
2011-01-03 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Martin Robinson.
[GTK] Split webkitprivate.{cpp,h} in more manageable chunks
https://bugs.webkit.org/show_bug.cgi?id=50698
Final patch, removing webkitprivate.{cpp,h}, and adding a
webkitglobals module to hold non-object-specific functions and
definitions that do not make sense on their own.
- GNUmakefile.am:
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::createWindow):
- WebCoreSupport/ContextMenuClientGtk.cpp:
- WebCoreSupport/DocumentLoaderGtk.cpp: (WebKit::DocumentLoader::attachToFrame):
- WebCoreSupport/DragClientGtk.cpp:
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::ignoreWordInSpellDocument): (WebKit::EditorClient::learnWord): (WebKit::EditorClient::checkSpellingOfString): (WebKit::EditorClient::getGuessesForWord):
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createDocumentLoader):
- WebCoreSupport/InspectorClientGtk.cpp:
- webkit/webkit.h:
- webkit/webkitapplicationcache.cpp: (webkit_application_cache_set_maximum_size):
- webkit/webkitdownload.cpp: (webkit_download_class_init):
- webkit/webkitgeolocationpolicydecision.cpp:
- webkit/webkitglobals.cpp: Added. (webkit_get_default_session): (webkit_set_cache_model): (webkit_get_cache_model): (webkit_get_web_plugin_database): (currentToplevelCallback): (closeIconDatabaseOnExit): (webkitInit): (WebKit::pasteboardHelperInstance):
- webkit/webkitglobals.h: Added.
- webkit/webkitglobalsprivate.h: Copied from WebKit/gtk/webkit/webkitwebsettingsprivate.h.
- webkit/webkithittestresult.cpp: (webkit_hit_test_result_class_init):
- webkit/webkitnetworkrequest.cpp: (webkit_network_request_class_init):
- webkit/webkitnetworkresponse.cpp: (webkit_network_response_class_init):
- webkit/webkitprivate.cpp: Removed.
- webkit/webkitprivate.h: Removed.
- webkit/webkitsecurityorigin.cpp:
- webkit/webkitviewportattributes.cpp:
- webkit/webkitwebbackforwardlist.cpp: (webkit_web_back_forward_list_class_init):
- webkit/webkitwebdatabase.cpp:
- webkit/webkitwebdatasource.cpp: (webkit_web_data_source_class_init): (webkit_web_data_source_new_with_request): (WebKit::kitNew):
- webkit/webkitwebframe.cpp: (webkit_web_frame_class_init):
- webkit/webkitwebframeprivate.h:
- webkit/webkitwebhistoryitem.cpp: (webkit_web_history_item_class_init):
- webkit/webkitwebinspector.cpp:
- webkit/webkitwebnavigationaction.cpp:
- webkit/webkitwebplugin.cpp: (webkit_web_plugin_class_init):
- webkit/webkitwebplugindatabase.cpp: (webkit_web_plugin_database_class_init):
- webkit/webkitwebpluginprivate.h:
- webkit/webkitwebpolicydecision.cpp:
- webkit/webkitwebresource.cpp:
- webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkitWebViewGetEnchantDicts): (WebKit::core):
- webkit/webkitwebsettingsprivate.h:
- webkit/webkitwebview.cpp: (webkit_web_view_class_init): (webkit_web_view_update_settings): (webkit_web_view_settings_notify):
- webkit/webkitwebview.h:
- webkit/webkitwebwindowfeatures.cpp: (webkit_web_window_features_class_init): (WebKit::kitNew):
WebCore
2011-01-03 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Martin Robinson.
[GTK] Split webkitprivate.{cpp,h} in more manageable chunks
https://bugs.webkit.org/show_bug.cgi?id=50698
Fix DOM bindings generation to no longer include the now-gone
webkitprivate.h header, including the appropriate replacements
instead.
- bindings/scripts/CodeGeneratorGObject.pm:
- 1:16 PM Changeset in webkit [74932] by
-
- 2 edits in trunk/WebKit/qt
2011-01-03 Antonio Gomes <agomes@rim.com>
Unreviewed crash fix.
Follow up of r74891: potential crash fix (bogus assertion).
- WebCoreSupport/EditorClientQt.cpp: (WebCore::editorCommandForKeyDownEvent):
- 1:13 PM Changeset in webkit [74931] by
-
- 2 edits in trunk/LayoutTests
2011-01-03 Mihai Parparita <mihaip@chromium.org>
Unreviewed, Chromium test expectation update.
Missed a few failing tests.
- platform/chromium/test_expectations.txt:
- 1:10 PM Changeset in webkit [74930] by
-
- 3 edits in trunk/Tools
2011-01-03 Patrick Gansterer <Patrick Gansterer>
Reviewed by David Kilzer.
[WINCE] Adds a build slave.
https://bugs.webkit.org/show_bug.cgi?id=50523
- BuildSlaveSupport/build.webkit.org-config/config.json: Add an entry for a release build of the WinCE port.
- BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform flag to build the WinCE port.
- 1:04 PM Changeset in webkit [74929] by
-
- 2 edits182 deletes in trunk/LayoutTests
2011-01-03 Mihai Parparita <mihaip@chromium.org>
Unreviewed, Chromium test expectation update.
Remove fast/, printing/, svg/, tables/ and transforms/ chromium-mac
baselines that are no longer necessary after r74892 (now that
chromium-mac scrollbars match mac ones).
- platform/chromium-mac-leopard/fast/text/international/bidi-neutral-run-expected.checksum: Removed.
- platform/chromium-mac-leopard/fast/text/international/bidi-neutral-run-expected.png: Removed.
- platform/chromium-mac/fast/css/text-overflow-ellipsis-strict-expected.checksum: Removed.
- platform/chromium-mac/fast/css/text-overflow-ellipsis-strict-expected.png: Removed.
- platform/chromium-mac/fast/events/autoscroll-expected.checksum: Removed.
- platform/chromium-mac/fast/events/autoscroll-expected.png: Removed.
- platform/chromium-mac/fast/events/reveal-link-when-focused-expected.checksum: Removed.
- platform/chromium-mac/fast/events/reveal-link-when-focused-expected.png: Removed.
- platform/chromium-mac/fast/events/standalone-image-drag-to-editable-expected.checksum: Removed.
- platform/chromium-mac/fast/events/standalone-image-drag-to-editable-expected.png: Removed.
- platform/chromium-mac/fast/forms/basic-textareas-expected.checksum: Removed.
- platform/chromium-mac/fast/forms/basic-textareas-expected.png: Removed.
- platform/chromium-mac/fast/forms/basic-textareas-quirks-expected.checksum: Removed.
- platform/chromium-mac/fast/forms/basic-textareas-quirks-expected.png: Removed.
- platform/chromium-mac/fast/forms/button-default-title-expected.checksum: Removed.
- platform/chromium-mac/fast/forms/button-default-title-expected.png: Removed.
- platform/chromium-mac/fast/frames/frame-scrolling-attribute-expected.checksum: Removed.
- platform/chromium-mac/fast/frames/frame-scrolling-attribute-expected.png: Removed.
- platform/chromium-mac/fast/frames/iframe-scrolling-attribute-expected.checksum: Removed.
- platform/chromium-mac/fast/frames/iframe-scrolling-attribute-expected.png: Removed.
- platform/chromium-mac/fast/invalid/residual-style-expected.checksum: Removed.
- platform/chromium-mac/fast/invalid/residual-style-expected.png: Removed.
- platform/chromium-mac/fast/lists/001-vertical-expected.checksum: Removed.
- platform/chromium-mac/fast/lists/001-vertical-expected.png: Removed.
- platform/chromium-mac/fast/lists/008-vertical-expected.checksum: Removed.
- platform/chromium-mac/fast/lists/008-vertical-expected.png: Removed.
- platform/chromium-mac/fast/media/mq-relative-constraints-02-expected.checksum: Removed.
- platform/chromium-mac/fast/media/mq-relative-constraints-02-expected.png: Removed.
- platform/chromium-mac/fast/media/mq-relative-constraints-03-expected.checksum: Removed.
- platform/chromium-mac/fast/media/mq-relative-constraints-03-expected.png: Removed.
- platform/chromium-mac/fast/media/mq-relative-constraints-04-expected.checksum: Removed.
- platform/chromium-mac/fast/media/mq-relative-constraints-04-expected.png: Removed.
- platform/chromium-mac/fast/media/mq-relative-constraints-05-expected.checksum: Removed.
- platform/chromium-mac/fast/media/mq-relative-constraints-05-expected.png: Removed.
- platform/chromium-mac/fast/media/mq-relative-constraints-06-expected.checksum: Removed.
- platform/chromium-mac/fast/media/mq-relative-constraints-06-expected.png: Removed.
- platform/chromium-mac/fast/media/mq-relative-constraints-07-expected.checksum: Removed.
- platform/chromium-mac/fast/media/mq-relative-constraints-07-expected.png: Removed.
- platform/chromium-mac/fast/media/mq-relative-constraints-08-expected.checksum: Removed.
- platform/chromium-mac/fast/media/mq-relative-constraints-08-expected.png: Removed.
- platform/chromium-mac/fast/media/mq-relative-constraints-09-expected.checksum: Removed.
- platform/chromium-mac/fast/media/mq-relative-constraints-09-expected.png: Removed.
- platform/chromium-mac/fast/media/mq-width-absolute-01-expected.checksum: Removed.
- platform/chromium-mac/fast/media/mq-width-absolute-01-expected.png: Removed.
- platform/chromium-mac/fast/media/mq-width-absolute-02-expected.checksum: Removed.
- platform/chromium-mac/fast/media/mq-width-absolute-02-expected.png: Removed.
- platform/chromium-mac/fast/media/mq-width-absolute-03-expected.checksum: Removed.
- platform/chromium-mac/fast/media/mq-width-absolute-03-expected.png: Removed.
- platform/chromium-mac/fast/media/mq-width-absolute-04-expected.checksum: Removed.
- platform/chromium-mac/fast/media/mq-width-absolute-04-expected.png: Removed.
- platform/chromium-mac/fast/multicol/client-rects-expected.checksum: Removed.
- platform/chromium-mac/fast/multicol/column-break-with-balancing-expected.checksum: Removed.
- platform/chromium-mac/fast/multicol/column-break-with-balancing-expected.png: Removed.
- platform/chromium-mac/fast/multicol/float-multicol-expected.checksum: Removed.
- platform/chromium-mac/fast/multicol/float-multicol-expected.png: Removed.
- platform/chromium-mac/fast/multicol/float-paginate-complex-expected.checksum: Removed.
- platform/chromium-mac/fast/multicol/float-paginate-complex-expected.png: Removed.
- platform/chromium-mac/fast/multicol/float-paginate-expected.checksum: Removed.
- platform/chromium-mac/fast/multicol/float-paginate-expected.png: Removed.
- platform/chromium-mac/fast/multicol/layers-in-multicol-expected.checksum: Removed.
- platform/chromium-mac/fast/multicol/layers-in-multicol-expected.png: Removed.
- platform/chromium-mac/fast/multicol/layers-split-across-columns-expected.checksum: Removed.
- platform/chromium-mac/fast/multicol/paginate-block-replaced-expected.checksum: Removed.
- platform/chromium-mac/fast/multicol/span/anonymous-style-inheritance-expected.checksum: Removed.
- platform/chromium-mac/fast/multicol/span/anonymous-style-inheritance-expected.png: Removed.
- platform/chromium-mac/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.checksum: Removed.
- platform/chromium-mac/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png: Removed.
- platform/chromium-mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.checksum: Removed.
- platform/chromium-mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.png: Removed.
- platform/chromium-mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.checksum: Removed.
- platform/chromium-mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.png: Removed.
- platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.checksum: Removed.
- platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png: Removed.
- platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-expected.checksum: Removed.
- platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.checksum: Removed.
- platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png: Removed.
- platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.checksum: Removed.
- platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png: Removed.
- platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-expected.checksum: Removed.
- platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-expected.png: Removed.
- platform/chromium-mac/fast/multicol/span/span-margin-collapsing-expected.checksum: Removed.
- platform/chromium-mac/fast/multicol/span/span-margin-collapsing-expected.png: Removed.
- platform/chromium-mac/fast/multicol/table-vertical-align-expected.checksum: Removed.
- platform/chromium-mac/fast/multicol/table-vertical-align-expected.png: Removed.
- platform/chromium-mac/fast/repaint/overflow-scroll-body-appear-expected.checksum: Removed.
- platform/chromium-mac/fast/repaint/overflow-scroll-body-appear-expected.png: Removed.
- platform/chromium-mac/fast/table/027-vertical-expected.checksum: Removed.
- platform/chromium-mac/fast/table/027-vertical-expected.png: Removed.
- platform/chromium-mac/fast/table/028-vertical-expected.checksum: Removed.
- platform/chromium-mac/fast/table/028-vertical-expected.png: Removed.
- platform/chromium-mac/fast/table/038-vertical-expected.checksum: Removed.
- platform/chromium-mac/fast/table/038-vertical-expected.png: Removed.
- platform/chromium-mac/fast/table/040-vertical-expected.checksum: Removed.
- platform/chromium-mac/fast/table/040-vertical-expected.png: Removed.
- platform/chromium-mac/fast/table/border-collapsing/002-vertical-expected.checksum: Removed.
- platform/chromium-mac/fast/table/border-collapsing/002-vertical-expected.png: Removed.
- platform/chromium-mac/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.checksum: Removed.
- platform/chromium-mac/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.png: Removed.
- platform/chromium-mac/fast/table/table-display-types-vertical-expected.checksum: Removed.
- platform/chromium-mac/fast/table/table-display-types-vertical-expected.png: Removed.
- platform/chromium-mac/fast/text/backslash-to-yen-sign-euc-expected.checksum: Removed.
- platform/chromium-mac/fast/text/backslash-to-yen-sign-euc-expected.png: Removed.
- platform/chromium-mac/fast/text/text-letter-spacing-expected.checksum: Removed.
- platform/chromium-mac/fast/text/text-letter-spacing-expected.png: Removed.
- platform/chromium-mac/fast/transforms/rotated-transform-affects-scrolling-1-expected.checksum: Removed.
- platform/chromium-mac/fast/transforms/rotated-transform-affects-scrolling-1-expected.png: Removed.
- platform/chromium-mac/fast/transforms/rotated-transform-affects-scrolling-2-expected.checksum: Removed.
- platform/chromium-mac/fast/transforms/rotated-transform-affects-scrolling-2-expected.png: Removed.
- platform/chromium-mac/printing/return-from-printing-mode-expected.checksum: Removed.
- platform/chromium-mac/printing/return-from-printing-mode-expected.png: Removed.
- platform/chromium-mac/svg/custom/altglyph-expected.checksum: Removed.
- platform/chromium-mac/svg/custom/altglyph-expected.png: Removed.
- platform/chromium-mac/svg/custom/getscreenctm-in-scrollable-svg-area-expected.checksum: Removed.
- platform/chromium-mac/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png: Removed.
- platform/chromium-mac/svg/custom/junk-data-expected.checksum: Removed.
- platform/chromium-mac/svg/custom/junk-data-expected.png: Removed.
- platform/chromium-mac/svg/custom/missing-xlink-expected.checksum: Removed.
- platform/chromium-mac/svg/custom/missing-xlink-expected.png: Removed.
- platform/chromium-mac/svg/custom/text-xy-updates-SVGList-expected.checksum: Removed.
- platform/chromium-mac/svg/custom/text-xy-updates-SVGList-expected.png: Removed.
- platform/chromium-mac/svg/dom/SVGLengthList-appendItem-expected.checksum: Removed.
- platform/chromium-mac/svg/dom/SVGLengthList-appendItem-expected.png: Removed.
- platform/chromium-mac/svg/dom/SVGLengthList-initialize-expected.checksum: Removed.
- platform/chromium-mac/svg/dom/SVGLengthList-initialize-expected.png: Removed.
- platform/chromium-mac/svg/dom/SVGLengthList-insertItemBefore-expected.checksum: Removed.
- platform/chromium-mac/svg/dom/SVGLengthList-insertItemBefore-expected.png: Removed.
- platform/chromium-mac/svg/dom/SVGLengthList-removeItem-expected.checksum: Removed.
- platform/chromium-mac/svg/dom/SVGLengthList-removeItem-expected.png: Removed.
- platform/chromium-mac/svg/dom/SVGLengthList-replaceItem-expected.checksum: Removed.
- platform/chromium-mac/svg/dom/SVGLengthList-replaceItem-expected.png: Removed.
- platform/chromium-mac/svg/dom/SVGLengthList-xml-dom-modifications-expected.checksum: Removed.
- platform/chromium-mac/svg/dom/SVGLengthList-xml-dom-modifications-expected.png: Removed.
- platform/chromium-mac/svg/dom/SVGNumberList-basics-expected.checksum: Removed.
- platform/chromium-mac/svg/dom/SVGNumberList-basics-expected.png: Removed.
- platform/chromium-mac/svg/dom/SVGPathSegList-appendItem-expected.checksum: Removed.
- platform/chromium-mac/svg/dom/SVGPathSegList-appendItem-expected.png: Removed.
- platform/chromium-mac/svg/dom/SVGPathSegList-clear-and-initialize-expected.checksum: Removed.
- platform/chromium-mac/svg/dom/SVGPathSegList-clear-and-initialize-expected.png: Removed.
- platform/chromium-mac/svg/dom/SVGPathSegList-insertItemBefore-expected.checksum: Removed.
- platform/chromium-mac/svg/dom/SVGPathSegList-insertItemBefore-expected.png: Removed.
- platform/chromium-mac/svg/dom/SVGPathSegList-removeItem-expected.checksum: Removed.
- platform/chromium-mac/svg/dom/SVGPathSegList-removeItem-expected.png: Removed.
- platform/chromium-mac/svg/dom/SVGPathSegList-replaceItem-expected.checksum: Removed.
- platform/chromium-mac/svg/dom/SVGPathSegList-replaceItem-expected.png: Removed.
- platform/chromium-mac/svg/dom/SVGPointList-basics-expected.checksum: Removed.
- platform/chromium-mac/svg/dom/SVGPointList-basics-expected.png: Removed.
- platform/chromium-mac/svg/dom/SVGStringList-basics-expected.checksum: Removed.
- platform/chromium-mac/svg/dom/SVGStringList-basics-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.checksum: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.checksum: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.checksum: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.checksum: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.checksum: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.checksum: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.checksum: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.checksum: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png: Removed.
- platform/chromium-mac/svg/in-html/circle-expected.checksum: Removed.
- platform/chromium-mac/svg/in-html/circle-expected.png: Removed.
- platform/chromium-mac/svg/text/kerning-expected.checksum: Removed.
- platform/chromium-mac/svg/zoom/page/absolute-sized-document-scrollbars-expected.checksum: Removed.
- platform/chromium-mac/svg/zoom/page/absolute-sized-document-scrollbars-expected.png: Removed.
- platform/chromium-mac/svg/zoom/page/relative-sized-document-scrollbars-expected.checksum: Removed.
- platform/chromium-mac/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Removed.
- platform/chromium-mac/svg/zoom/page/zoom-svg-float-border-padding-expected.checksum: Removed.
- platform/chromium-mac/svg/zoom/page/zoom-svg-float-border-padding-expected.png: Removed.
- platform/chromium-mac/svg/zoom/text/zoom-svg-float-border-padding-expected.checksum: Removed.
- platform/chromium-mac/svg/zoom/text/zoom-svg-float-border-padding-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug96334-expected.checksum: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug96343-expected.checksum: Removed.
- platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-3-expected.checksum: Removed.
- platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-3-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/other/wa_table_thtd_rowspan-expected.checksum: Removed.
- platform/chromium-mac/tables/mozilla/other/wa_table_thtd_rowspan-expected.png: Removed.
- platform/chromium-mac/transforms/2d/transform-fixed-container-expected.checksum: Removed.
- platform/chromium-mac/transforms/2d/transform-fixed-container-expected.png: Removed.
- platform/chromium/test_expectations.txt:
- 1:04 PM Changeset in webkit [74928] by
-
- 3 edits in trunk/Tools
2011-01-03 Patrick Gansterer <Patrick Gansterer>
Reviewed by David Kilzer.
Add WinCE support to build-webkit
https://bugs.webkit.org/show_bug.cgi?id=51642
- Scripts/build-webkit:
- Scripts/webkitdirs.pm:
- 12:59 PM Changeset in webkit [74927] by
-
- 10 edits in trunk/Tools
2011-01-03 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
https://bugs.webkit.org/show_bug.cgi?id=51802
I'm not the biggest fan of the test_failures or test_results classes,
but it's better to have one shared set of classes, than separate ones
for new vs. old run-webkit-test result handling.
This moves the ORWT results class "LayoutTestResults" over to using
TestResult and TestFailure classes, making it easy for us to
make all our sheriff-bot and other webkitpy code NRWT ready.
This also makes it a trivial patch to generate results.json information
from ORWT results.html files (for flaky test analysis, etc.) as well
as making it a one-liner to report test failure types when the
commit-queue sees flaky tests.
This patch tried not to add new functionality, but only to replace
the guts of LayoutTestResults, while adding unit tests and hoping
not to break anything.
I also moved callers which assumed User.prompt* were static/class methods
to using them as instance methods (since we'll eventually want to make them such).
In the process of re-writing things, I broke the rebaseline command, so I wrote
a unit test to catch my breakage were I do do so again in the future.
- Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
- Scripts/webkitpy/common/net/layouttestresults.py:
- Scripts/webkitpy/common/net/layouttestresults_unittest.py:
- Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
- Scripts/webkitpy/layout_tests/layout_package/test_results.py:
- Scripts/webkitpy/tool/commands/queries.py:
- Scripts/webkitpy/tool/commands/rebaseline.py:
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
- Scripts/webkitpy/tool/mocktool.py:
- 12:57 PM Changeset in webkit [74926] by
-
- 6 edits4 adds in trunk
Add Encode/Decode machinery Darin and I plan to work with for back/forward stuff in WebKit2.
Reviewed by Darin Adler.
Source/JavaScriptCore:
Starting out with a pure virtual interface to be implemented in WK2, but we might change that later.
- GNUmakefile.am:
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/Decoder.h: Added.
- wtf/Encoder.h: Added.
WebCore:
- ForwardingHeaders/wtf/Decoder.h: Added.
- ForwardingHeaders/wtf/Encoder.h: Added.
- 12:40 PM Changeset in webkit [74925] by
-
- 2 edits in trunk/Tools
2011-01-03 Adam Barth <abarth@webkit.org>
Reviewed by Simon Fraser.
webkit-patch shouldn't waste time cleaning a working directory that's already clean
https://bugs.webkit.org/show_bug.cgi?id=51840
- Scripts/webkitpy/common/checkout/scm.py:
- 12:36 PM Changeset in webkit [74924] by
-
- 2 edits in trunk/LayoutTests
2011-01-03 Mihai Parparita <mihaip@chromium.org>
Unreviewed, Chromium test expectation update.
New gradient tests fail on chromium-mac too.
- platform/chromium/test_expectations.txt:
- 12:26 PM Changeset in webkit [74923] by
-
- 2 edits48 deletes in trunk/LayoutTests
2011-01-03 Mihai Parparita <mihaip@chromium.org>
Unreviewed, Chromium test expectation update.
Remove editing/, fast/backgrounds, fast/block, fast/blockflow, and
fast/borders chromium-mac baselines that are no longer necessary after
r74892 (now that chromium-mac scrollbars match mac ones).
- platform/chromium-mac/editing/deleting/delete-after-span-ws-001-expected.checksum: Removed.
- platform/chromium-mac/editing/deleting/delete-after-span-ws-001-expected.png: Removed.
- platform/chromium-mac/editing/deleting/delete-after-span-ws-002-expected.checksum: Removed.
- platform/chromium-mac/editing/deleting/delete-after-span-ws-002-expected.png: Removed.
- platform/chromium-mac/editing/deleting/delete-after-span-ws-003-expected.checksum: Removed.
- platform/chromium-mac/editing/deleting/delete-after-span-ws-003-expected.png: Removed.
- platform/chromium-mac/editing/deleting/delete-line-end-ws-001-expected.checksum: Removed.
- platform/chromium-mac/editing/deleting/delete-line-end-ws-001-expected.png: Removed.
- platform/chromium-mac/editing/deleting/delete-line-end-ws-002-expected.checksum: Removed.
- platform/chromium-mac/editing/deleting/delete-line-end-ws-002-expected.png: Removed.
- platform/chromium-mac/editing/inserting/insert-div-023-expected.checksum: Removed.
- platform/chromium-mac/editing/inserting/insert-div-023-expected.png: Removed.
- platform/chromium-mac/editing/selection/focus_editable_html-expected.checksum: Removed.
- platform/chromium-mac/editing/selection/focus_editable_html-expected.png: Removed.
- platform/chromium-mac/editing/selection/iframe-expected.checksum: Removed.
- platform/chromium-mac/editing/selection/iframe-expected.png: Removed.
- platform/chromium-mac/editing/selection/select-all-001-expected.checksum: Removed.
- platform/chromium-mac/editing/selection/select-all-001-expected.png: Removed.
- platform/chromium-mac/editing/selection/select-all-002-expected.checksum: Removed.
- platform/chromium-mac/editing/selection/select-all-002-expected.png: Removed.
- platform/chromium-mac/editing/selection/select-all-003-expected.checksum: Removed.
- platform/chromium-mac/editing/selection/select-all-003-expected.png: Removed.
- platform/chromium-mac/editing/selection/select-all-004-expected.checksum: Removed.
- platform/chromium-mac/editing/selection/select-all-004-expected.png: Removed.
- platform/chromium-mac/editing/selection/unrendered-001-expected.checksum: Removed.
- platform/chromium-mac/editing/selection/unrendered-001-expected.png: Removed.
- platform/chromium-mac/editing/selection/unrendered-002-expected.checksum: Removed.
- platform/chromium-mac/editing/selection/unrendered-002-expected.png: Removed.
- platform/chromium-mac/editing/selection/unrendered-003-expected.checksum: Removed.
- platform/chromium-mac/editing/selection/unrendered-003-expected.png: Removed.
- platform/chromium-mac/editing/selection/unrendered-004-expected.checksum: Removed.
- platform/chromium-mac/editing/selection/unrendered-004-expected.png: Removed.
- platform/chromium-mac/editing/selection/unrendered-005-expected.checksum: Removed.
- platform/chromium-mac/editing/selection/unrendered-005-expected.png: Removed.
- platform/chromium-mac/fast/backgrounds/background-inherit-color-bug-expected.checksum: Removed.
- platform/chromium-mac/fast/backgrounds/background-inherit-color-bug-expected.png: Removed.
- platform/chromium-mac/fast/block/basic/016-expected.checksum: Removed.
- platform/chromium-mac/fast/block/basic/truncation-rtl-expected.checksum: Removed.
- platform/chromium-mac/fast/block/basic/truncation-rtl-expected.png: Removed.
- platform/chromium-mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum: Removed.
- platform/chromium-mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.png: Removed.
- platform/chromium-mac/fast/blockflow/box-shadow-vertical-lr-expected.checksum: Removed.
- platform/chromium-mac/fast/blockflow/box-shadow-vertical-lr-expected.png: Removed.
- platform/chromium-mac/fast/blockflow/box-shadow-vertical-rl-expected.checksum: Removed.
- platform/chromium-mac/fast/blockflow/fieldsets-expected.checksum: Removed.
- platform/chromium-mac/fast/blockflow/fieldsets-expected.png: Removed.
- platform/chromium-mac/fast/borders/border-image-scale-transform-expected.checksum: Removed.
- platform/chromium-mac/fast/borders/border-image-scale-transform-expected.png: Removed.
- platform/chromium/test_expectations.txt:
- 12:08 PM Changeset in webkit [74922] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-01-03 Laszlo Gombos <Laszlo Gombos>
Unreviewed build fix.
[Qt] Add NullPtr.cpp introduced in r71155 to the Qt build system.
This fix is required for builds where HAVE(NULLPTR) is false
(e.g. some MSVC and Symbian builds).
- wtf/wtf.pri:
- 12:02 PM Changeset in webkit [74921] by
-
- 2 edits in trunk/LayoutTests
2011-01-03 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium test expectation update.
Add failing expectations for tests that depend on elliptical gradient
support.
- platform/chromium/test_expectations.txt:
- 12:01 PM Changeset in webkit [74920] by
-
- 3 edits2 adds in trunk
AX: Regression: WebKit no longer auto-scrolls with VoiceOver navigation
https://bugs.webkit.org/show_bug.cgi?id=51833
Reviewed by Darin Adler.
WebCore:
Make sure the web area returns the contentsSize, not the same size as what is displayed.
Test: platform/mac/accessibility/webarea-size-equals-content-size.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::boundingBoxRect):
LayoutTests:
- platform/mac/accessibility/webarea-size-equals-content-size-expected.txt: Added.
- platform/mac/accessibility/webarea-size-equals-content-size.html: Added.
- 11:57 AM Changeset in webkit [74919] by
-
- 2 edits in trunk/WebCore
2011-01-03 Simon Fraser <Simon Fraser>
Fix warning in 32-bit builds.
- css/CSSGradientValue.cpp: (WebCore::CSSLinearGradientValue::createGradient):
- 11:50 AM Changeset in webkit [74918] by
-
- 2 edits26 deletes in trunk/LayoutTests
2011-01-03 Mihai Parparita <mihaip@chromium.org>
Unreviewed, Chromium test expectation update.
Remove css2.1/ chromium-mac baselines that are no longer necessary after
r74892 (now that chromium-mac scrollbars match mac ones).
- platform/chromium-mac/css2.1/t0803-c5502-mrgn-r-02-c-expected.checksum: Removed.
- platform/chromium-mac/css2.1/t0803-c5502-mrgn-r-02-c-expected.png: Removed.
- platform/chromium-mac/css2.1/t0803-c5505-mrgn-02-c-expected.checksum: Removed.
- platform/chromium-mac/css2.1/t0803-c5505-mrgn-02-c-expected.png: Removed.
- platform/chromium-mac/css2.1/t080301-c411-vt-mrgn-00-b-expected.checksum: Removed.
- platform/chromium-mac/css2.1/t080301-c411-vt-mrgn-00-b-expected.png: Removed.
- platform/chromium-mac/css2.1/t0905-c5525-fltclr-00-c-ag-expected.checksum: Removed.
- platform/chromium-mac/css2.1/t0905-c5525-fltclr-00-c-ag-expected.png: Removed.
- platform/chromium-mac/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.checksum: Removed.
- platform/chromium-mac/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.png: Removed.
- platform/chromium-mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum: Removed.
- platform/chromium-mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png: Removed.
- platform/chromium-mac/css2.1/t0905-c5526-fltclr-00-c-ag-expected.checksum: Removed.
- platform/chromium-mac/css2.1/t0905-c5526-fltclr-00-c-ag-expected.png: Removed.
- platform/chromium-mac/css2.1/t1002-c5523-width-02-b-g-expected.checksum: Removed.
- platform/chromium-mac/css2.1/t1002-c5523-width-02-b-g-expected.png: Removed.
- platform/chromium-mac/css2.1/t1202-counters-08-b-expected.checksum: Removed.
- platform/chromium-mac/css2.1/t1202-counters-08-b-expected.png: Removed.
- platform/chromium-mac/css2.1/t1202-counters-09-b-expected.checksum: Removed.
- platform/chromium-mac/css2.1/t1202-counters-09-b-expected.png: Removed.
- platform/chromium-mac/css2.1/t140201-c535-bg-fixd-00-b-g-expected.checksum: Removed.
- platform/chromium-mac/css2.1/t140201-c535-bg-fixd-00-b-g-expected.png: Removed.
- platform/chromium-mac/css2.1/t140201-c537-bgfxps-00-c-ag-expected.checksum: Removed.
- platform/chromium-mac/css2.1/t140201-c537-bgfxps-00-c-ag-expected.png: Removed.
- platform/chromium-mac/css2.1/t1508-c527-font-07-b-expected.checksum: Removed.
- platform/chromium-mac/css2.1/t1508-c527-font-07-b-expected.png: Removed.
- platform/chromium/test_expectations.txt:
- 11:43 AM Changeset in webkit [74917] by
-
- 2 edits in trunk/LayoutTests
2011-01-03 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium test expectation update.
Remove failing expectations for tests that now pass (due to r74892).
- platform/chromium/test_expectations.txt:
- 11:37 AM Changeset in webkit [74916] by
-
- 2 edits in trunk/WebCore
2011-01-03 Benjamin C Meyer <bmeyer@rim.com>
Reviewed by Daniel Bates.
In the cmake build system move logic related to ENABLE_NOTIFICATIONS into its own block.
https://bugs.webkit.org/show_bug.cgi?id=51827
- CMakeLists.txt:
- 11:36 AM Changeset in webkit [74915] by
-
- 13 edits8 adds in trunk
2011-01-03 Simon Fraser <Simon Fraser>
Reviewed by David Hyatt.
Implement -webkit-linear-gradient and -webkit-radial-gradient
https://bugs.webkit.org/show_bug.cgi?id=28152
Add support for -webkit-radial-gradients.
Tests: fast/gradients/css3-radial-gradients.html
fast/gradients/css3-radial-gradients2.html
- css/CSSGradientValue.cpp: (WebCore::blend): Used to blend colors, which is necessary when truncating the start of radial gradients. (WebCore::GradientStop): Small struct to aid gradient stop processing. (WebCore::CSSGradientValue::addStops): Rename 'positions' to 'stops', and store the color so that we can blend it when truncating radial gradients. Changed to handle both linear and radial gradients. (WebCore::CSSRadialGradientValue::cssText): Update to follow the spec. (WebCore::CSSRadialGradientValue::resolveRadius): Stylistic change. (WebCore::distanceToClosestCorner): New utility method. (WebCore::distanceToFarthestCorner): Ditto. (WebCore::CSSRadialGradientValue::createGradient): New logic to deal with shape and fill rules.
- css/CSSGradientValue.h: (WebCore::CSSGradientValue::isLinearGradient): Color-stop processing needs to know what kind of gradient it's dealing with, so add new isFooGradient methods. (WebCore::CSSGradientValue::isRadialGradient): Ditto. (WebCore::CSSLinearGradientValue::isLinearGradient): (WebCore::CSSRadialGradientValue::setShape): New setters for shape, size etc. (WebCore::CSSRadialGradientValue::setSizingBehavior): (WebCore::CSSRadialGradientValue::setEndHorizontalSize): (WebCore::CSSRadialGradientValue::setEndVerticalSize): (WebCore::CSSRadialGradientValue::isRadialGradient):
- css/CSSParser.h:
- css/CSSParser.h: Pass a CSSParserValueList* into parseFillPositionXY() and parseFillPosition() so we can use parseFillPosition() when parsing a gradient function.
- css/CSSParser.cpp: (WebCore::CSSParser::parseFillPositionXY): Pass in a CSSParserValueList* (WebCore::CSSParser::parseFillPosition): Ditto (WebCore::CSSParser::parseFillProperty): Pass m_valueList to parseFillPosition. (WebCore::CSSParser::parseTransformOriginShorthand): Ditto (WebCore::CSSParser::parseRadialGradient): Flesh out radial gradient parsing. (WebCore::CSSParser::parseTransformOrigin): Pass m_valueList to parseFillPosition. (WebCore::CSSParser::parsePerspectiveOrigin): Ditto
- css/CSSValueKeywords.in: New keywords for radial gradient shape and fill behaviors.
- platform/graphics/Gradient.cpp: (WebCore::Gradient::Gradient): Pass aspect ratio for elliptical gradients.
- platform/graphics/Gradient.h: Add aspect ratio for elliptical gradients. (WebCore::Gradient::create): (WebCore::Gradient::startRadius): Expose radii. (WebCore::Gradient::endRadius): (WebCore::Gradient::setStartRadius): Setters are required for when we need to scale color stops. (WebCore::Gradient::setEndRadius): (WebCore::Gradient::aspectRatio):
- platform/graphics/cg/GradientCG.cpp: (WebCore::Gradient::paint): For elliptical gradients, scale the CTM.
- platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::GraphicsContext::fillRect): Use start/endRadius() rather than r0() and r1().
- 11:33 AM Changeset in webkit [74914] by
-
- 2 edits in trunk/Tools
2011-01-03 Adam Barth <abarth@webkit.org>
Reviewed by Simon Fraser.
webkit-patch should only hide update output if --quiet
https://bugs.webkit.org/show_bug.cgi?id=51838
As requested by smfr.
- Scripts/webkitpy/tool/steps/update.py:
- 11:33 AM Changeset in webkit [74913] by
-
- 3 edits in trunk/WebCore
2011-01-03 Dan Bernstein <mitz@apple.com>
Reviewed by Simon Fraser.
Remove the unused RenderTableCell::m_percentageHeight
https://bugs.webkit.org/show_bug.cgi?id=51837
- rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::RenderTableCell): Removed initialization of m_percentageHeight.
- rendering/RenderTableCell.h: Removed m_percentageHeight.
- 11:31 AM Changeset in webkit [74912] by
-
- 7 edits14 adds in trunk
2011-01-03 Simon Fraser <Simon Fraser>
Reviewed by David Hyatt.
Implement -webkit-linear-gradient and -webkit-radial-gradient
https://bugs.webkit.org/show_bug.cgi?id=28152
Add support for the parsing and rendering of non-repeating CSS3 linear gradients,
according to <http://dev.w3.org/csswg/css3-images/#linear-gradients>.
Tests: fast/gradients/css3-color-stop-units.html
fast/gradients/css3-color-stops.html
fast/gradients/css3-gradient-parsing.html
fast/gradients/css3-linear-angle-gradients.html
- css/CSSGradientValue.h: Add subclasses of CSSGradientValue for linear and radial gradients.
- css/CSSGradientValue.cpp: (WebCore::CSSGradientValue::image): Add FIXME comment about why we can't cache the gradient sometimes. (WebCore::compareStops): positions are CSSValues now. (WebCore::CSSGradientValue::sortStopsIfNeeded): Add assertion that this is only called for old-style gradients. (WebCore::CSSGradientValue::addStops): New method that handles the spec rules about missing positions, ensuring that stop position is ordered, and spacing out stops without positions. Also normalize gradients which use stops outside the 0-1 range so that platforms can render them correctly. (WebCore::positionFromValue): Determin the position on the gradient line for percentage, number and length values. (WebCore::CSSGradientValue::computeEndPoint): (WebCore::CSSLinearGradientValue::cssText): (WebCore::endPointsFromAngle): Compute endpoints for a gradient which covers the rectangle given an angle. (WebCore::CSSLinearGradientValue::createGradient): (WebCore::CSSRadialGradientValue::cssText): (WebCore::CSSRadialGradientValue::resolveRadius): (WebCore::CSSRadialGradientValue::createGradient):
- css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Style fix. (WebCore::CSSParser::parseContent): Use isGeneratedImageValue() and parseGeneratedImage() (WebCore::CSSParser::parseFillImage): Use isGeneratedImageValue() and parseGeneratedImage() (WebCore::CSSParser::parseBorderImage): Use isGeneratedImageValue() and parseGeneratedImage() (WebCore::parseDeprecatedGradientPoint): Renamed to indicate that it's only used for -webkit-gradient. (WebCore::parseDeprecatedGradientColorStop): Renamed to indicate that it's only used for -webkit-gradient, and fixed to store CSSValues for the stop position. (WebCore::CSSParser::parseDeprecatedGradient): Renamed to indicate that it's only used for -webkit-gradient, and create CSSLinearGradientValue and CSSRadialGradientValue as appropriate. (WebCore::valueFromSideKeyword): (WebCore::parseGradientColorOrKeyword): Color parsing utility. (WebCore::CSSParser::parseLinearGradient): New method to parse linear gradients. (WebCore::CSSParser::parseRadialGradient): Stub for new method to parse radial gradients. (WebCore::CSSParser::isGeneratedImageValue): Detect gradients and CSS canvas. (WebCore::CSSParser::parseGeneratedImage): Parser for generated images like gradients and CSS canvas.
- css/CSSParser.h:
- platform/graphics/Gradient.h: (WebCore::Gradient::setP0): We need to be able to change the points when normalizing gradients. (WebCore::Gradient::setP1): Ditto.
- 11:18 AM Changeset in webkit [74911] by
-
- 2 edits in trunk/LayoutTests
2011-01-03 Mihai Parparita <mihaip@chromium.org>
Unreviewed, Chromium test expectation update.
Missed a few failing tests.
- platform/chromium/test_expectations.txt:
- 11:04 AM Changeset in webkit [74910] by
-
- 2 edits in trunk/Tools
2011-01-03 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
commit-queue shouldn't reject patches twice if two bots process the same patch
https://bugs.webkit.org/show_bug.cgi?id=51805
Before raising an error, we first check whether the patch is still in
the commit-queue. This check is still racy, of course, but the time
window is much smaller.
- Scripts/webkitpy/tool/bot/commitqueuetask.py:
- 11:01 AM Changeset in webkit [74909] by
-
- 7 edits in trunk
2011-01-03 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Andreas Kling.
[Qt] document.getElementById(...) doesn't return the right object in combination with QGraphicsWidget
https://bugs.webkit.org/show_bug.cgi?id=51464
Added a way to bind any QObject created as a plugin to JavaScript,
by adding a custom member (qtObject) to WebCore::Widget.
Added a test to tst_qwebpage to make sure plugins created
as QGraphicsWidget are accessible through JavaScript.
- bindings/js/ScriptControllerQt.cpp: (WebCore::ScriptController::createScriptInstanceForWidget):
- platform/Widget.h:
- platform/qt/WidgetQt.cpp: (WebCore::Widget::Widget): (WebCore::Widget::setBindingObject): (WebCore::Widget::bindingObject):
2011-01-03 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Andreas Kling.
[Qt] document.getElementById(...) doesn't return the right object in combination with QGraphicsWidget
https://bugs.webkit.org/show_bug.cgi?id=51464
Added a way to bind any QObject created as a plugin to JavaScript,
by adding a custom membe to WebCore::Widget.
Added a test to make sure plugins created as QGraphicsWidget are
accessible through JavaScript.
- WebCoreSupport/FrameLoaderClientQt.cpp:
- tests/qwebpage/tst_qwebpage.cpp: (PluginPage::createPlugin): (tst_QWebPage::graphicsWidgetPlugin):
- 10:55 AM Changeset in webkit [74908] by
-
- 3 edits3 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=51328
Reviewed by Simon Fraser.
WebCore:
Printing on a page with body { height: 100% } clips out the overflow contents. This happened
because the computePageRects function was never correct. It was using the layer's width and height
for the document's width and height, and the layer no longer includes overflow in its width and
height. It was also incorrectly assuming the first page would begin at (0,0), and this is an invalid
assumption in RTL or vertical text environments.
Added printing/page-count-percentage-height.html
- page/PrintContext.cpp:
(WebCore::PrintContext::computePageRects):
(WebCore::PrintContext::computePageRectsWithPageSizeInternal):
LayoutTests:
Add layout test for printing clipping bug.
- printing/page-count-percentage-height-expected.txt: Added.
- printing/page-count-percentage-height.html: Added.
- printing/script-tests/page-count-percentage-height.js: Added.
(test):
- 10:41 AM Changeset in webkit [74907] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rolling out unnecessary r74905.
[Qt] DRT sideeffect revealed by r74896
https://bugs.webkit.org/show_bug.cgi?id=51829
- platform/qt/Skipped:
- 10:40 AM Changeset in webkit [74906] by
-
- 2 edits in trunk/Tools
Make run-api-tests less chatty.
https://bugs.webkit.org/show_bug.cgi?id=51831
Reviewed by Anders Carlsson.
- Make script quiet by default and add --verbose option (replacing --quiet).
- When not verbose, pipe stdout and stderr to devnull.
- Scripts/run-api-tests:
- 10:33 AM Changeset in webkit [74905] by
-
- 2 edits in trunk/LayoutTests
Unreviewed fix.
[Qt] DRT sideeffect revealed by r74896
https://bugs.webkit.org/show_bug.cgi?id=51829
- platform/qt/Skipped: http/tests/misc/401-alternative-content.php added until fix.
- 10:29 AM Changeset in webkit [74904] by
-
- 2 edits in trunk/LayoutTests
2011-01-03 Mihai Parparita <mihaip@chromium.org>
Unreviewed, Chromium test expectation update.
Fix duplicate expectation.
- platform/chromium/test_expectations.txt:
- 10:26 AM Changeset in webkit [74903] by
-
- 2 edits in trunk
2011-01-03 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Disable superfluous GNU make built-in implicit rules
https://bugs.webkit.org/show_bug.cgi?id=51826
GNU make ships some superflous built-in rules that we never use
and that end up adding up to a very significant portion of our
total Makefile processing time. Disable them completely by
defining the rule without any recipe, as suggested by the GNU make
manual (10.5.6, Cancelling Implicit Rules).
In my system the null-build goes from:
make 43.51s user 12.77s system 99% cpu 56.628 total
to:
make 31.45s user 11.59s system 99% cpu 43.227 total
- GNUmakefile.am: disable implicit built-in rules.
- 10:24 AM Changeset in webkit [74902] by
-
- 2 edits in trunk/Tools
2011-01-03 Pratik Solanki <psolanki@apple.com>
Unreviewed. Adding myself to committers.py.
- Scripts/webkitpy/common/config/committers.py:
- 10:12 AM Changeset in webkit [74901] by
-
- 2 edits in trunk/LayoutTests
2011-01-03 Laszlo Gombos <Laszlo Gombos>
Unreviewed, build fix.
[Qt] Add back auth.html to the skipped list after r74896.
- platform/qt/Skipped: Add http/tests/appcache/auth.html to the list.
- 10:10 AM Changeset in webkit [74900] by
-
- 3 edits in trunk/WebCore
[Qt] Unreviewed buildfix for --minimal build after r74895.
- html/InputType.cpp: Missing include added.
- html/NumberInputType.cpp: Missing include added.
- 9:59 AM Changeset in webkit [74899] by
-
- 2 edits in trunk/WebKit/chromium
2011-01-03 Daniel Bates <dbates@rim.com>
Attempt to fix the Chromium Linux Release build after changeset 74895 <http://trac.webkit.org/changeset/74895>.
The portion of the patch in <https://bugs.webkit.org/show_bug.cgi?id=51791> that modified the
file src/WebSearchableFormData.cpp was not landed (why?). Although the change log entry
associated with this change was landed.
- src/WebSearchableFormData.cpp: (HTMLNames::IsInDefaultState):
- 9:53 AM Changeset in webkit [74898] by
-
- 2 edits in trunk
2011-01-03 Mihai Parparita <mihaip@chromium.org>
Unreviewed. Update .gitignore with new JavaScriptCore location.
- .gitignore:
- 9:48 AM Changeset in webkit [74897] by
-
- 2 edits124 deletes in trunk/LayoutTests
2011-01-03 Laszlo Gombos <Laszlo Gombos>
Reviewed by David Levin.
[Qt] Unskip some passing tests as the bot is migrated to Qt 4.7+
https://bugs.webkit.org/show_bug.cgi?id=51819
- platform/qt/Skipped: Remove passing HTTP tests. Keep timer-vs-loading.html as it is still failing.
- platform/qt/http/tests/loading/bad-scheme-subframe-expected.txt: Match the expected results with chromium to pass the test.
- 9:31 AM QtWebKitReleases edited by
- (diff)
- 9:28 AM QtWebKit edited by
- (diff)
- 9:26 AM Changeset in webkit [74896] by
-
- 3 edits in trunk/LayoutTests
2011-01-03 Laszlo Gombos <Laszlo Gombos>
Reviewed by David Levin.
[Qt] Unskip some passing tests as the bot is migrated to Qt 4.7+
https://bugs.webkit.org/show_bug.cgi?id=51819
- platform/qt/Skipped: Remove passing HTTP tests. Keep timer-vs-loading.html as it is still failing.
- platform/qt/http/tests/loading/bad-scheme-subframe-expected.txt: Match the expected results with chromium to pass the test.
- 9:21 AM Changeset in webkit [74895] by
-
- 55 edits in trunk/WebCore
2011-01-02 Darin Adler <Darin Adler>
Reviewed by Kent Tamura.
Eliminate HTMLInputElement::m_deprecatedTypeNumber, other input refactoring and renaming
https://bugs.webkit.org/show_bug.cgi?id=51791
- src/WebSearchableFormData.cpp: (HTMLNames::IsInDefaultState): Use hasAttribute(checkedAttr) to find out whether a button should be checked by default, rather than calling the defaultChecked function.
2011-01-02 Darin Adler <Darin Adler>
Reviewed by Kent Tamura.
Eliminate HTMLInputElement::m_deprecatedTypeNumber, other input refactoring and renaming
https://bugs.webkit.org/show_bug.cgi?id=51791
- dom/InputElement.h: Make sanitizeValueForTextField public so it can be called by InputType.
- html/BaseButtonInputType.cpp: (WebCore::BaseButtonInputType::accessKeyAction): Added. (WebCore::BaseButtonInputType::storesValueSeparateFromAttribute): Added.
- html/BaseButtonInputType.h: Ditto.
- html/BaseCheckableInputType.cpp: (WebCore::BaseCheckableInputType::canSetStringValue): Added. (WebCore::BaseCheckableInputType::accessKeyAction): Added. (WebCore::BaseCheckableInputType::fallbackValue): Added. (WebCore::BaseCheckableInputType::storesValueSeparateFromAttribute): Added. (WebCore::BaseCheckableInputType::isCheckable): Added.
- html/BaseCheckableInputType.h: Ditto.
- html/BaseDateAndTimeInputType.cpp: (WebCore::BaseDateAndTimeInputType::hasSpinButton): Added.
- html/BaseDateAndTimeInputType.h: Ditto.
- html/BaseTextInputType.h: Made more functions private.
- html/ButtonInputType.cpp: (WebCore::ButtonInputType::isTextButton): Added.
- html/ButtonInputType.h: Ditto.
- html/CheckboxInputType.cpp: (WebCore::CheckboxInputType::willDispatchClick): Added. (WebCore::CheckboxInputType::didDispatchClick): Added. (WebCore::CheckboxInputType::isCheckbox): Added.
- html/CheckboxInputType.h: Ditto.
- html/DateTimeInputType.cpp: (WebCore::DateTimeInputType::scaledStepValueShouldBeInteger): Fixed typo in name of this function.
- html/DateTimeInputType.h: Ditto.
- html/DateTimeLocalInputType.cpp: (WebCore::DateTimeLocalInputType::scaledStepValueShouldBeInteger): Ditto.
- html/DateTimeLocalInputType.h: Ditto.
- html/EmailInputType.cpp: (WebCore::EmailInputType::isEmailField): Added.
- html/EmailInputType.h: Ditto.
- html/FileInputType.cpp: (WebCore::FileInputType::FileInputType): Added. (WebCore::FileInputType::canSetStringValue): Added. (WebCore::FileInputType::canChangeFromAnotherType): Added. (WebCore::FileInputType::files): Added. (WebCore::FileInputType::canSetValue): Added. (WebCore::FileInputType::getTypeSpecificValue): Added. (WebCore::FileInputType::storesValueSeparateFromAttribute): Added. (WebCore::FileInputType::setFileList): Added. (WebCore::FileInputType::isFileUpload): Added.
- html/FileInputType.h: Ditto.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::HTMLInputElement): Updated for data member renaming and removal. (WebCore::HTMLInputElement::isValidValue): Call canSetStringValue instead of checking specific type numbers. (WebCore::HTMLInputElement::getAllowedValueStepWithDecimalPlaces): Use fastGetAttribute and fixed typo in the name of the scaledStepValueShouldBeInteger function. (WebCore::HTMLInputElement::isKeyboardFocusable): Call InputType::isKeyboardFocusable; moved most of the type-specific logic there. (WebCore::HTMLInputElement::shouldUseInputMethod): Call InputType::shouldUseInputMethod; moved the type-specific logic there. (WebCore::HTMLInputElement::handleBlurEvent): Call InputType::handleBlurEvent; moved the type-specific logic there. (WebCore::HTMLInputElement::setType): Tweak the names and types in this function. (WebCore::HTMLInputElement::updateType): Removed the code that set m_deprecatedTypeNumber. Compare types by comparing the value from formControlType. Removed file-specific logic and instead call InputType::canChangeFromAnotherType. Streamlined the logic for activation callbacks. (WebCore::HTMLInputElement::accessKeyAction): Call InputType::accessKeyAction; moved the type-specific logic there. (WebCore::HTMLInputElement::mapToEntry): Call InputType::shouldRespectHeightAndWidthAttributes and InputType::shouldRespectAlignAttribute. (WebCore::HTMLInputElement::parseMappedAttribute): Updated for name changes and the removal of m_defaultChecked. Changed the alt attribute logic to be based on the class of the renderer. Call InputType::srcAttributeChanged and moved the type-specific logic there. Call shouldRespectAlignAttribute and shouldRespectHeightAndWidthAttributes rather than having type-specific logic here. Call minOrMaxAttributeChanged. (WebCore::HTMLInputElement::rendererIsNeeded): Call InputType::rendererIsNeeded; moved the type-specific logic there. (WebCore::HTMLInputElement::attach): Removed the unneeded m_inited flag, which was redundant with the m_haveType flag. Call InputType::attach; moved the type-specific logic there. (WebCore::HTMLInputElement::altText): Use fastGetAttribute. (WebCore::HTMLInputElement::isSuccessfulSubmitButton): Call InputType::canBeSuccessfulSubmitButton; moved the type-specific logic there. (WebCore::HTMLInputElement::isActivatedSubmit): Updated for name changes. (WebCore::HTMLInputElement::setActivatedSubmit): Ditto. (WebCore::HTMLInputElement::reset): Updated to use InputType::storesValueSeparateFromAttribute. Also use hasAttribute(checkedAttr) rather than m_defaultChecked, since both are the same. Also updated for name change. (WebCore::HTMLInputElement::setChecked): Updated for name changes. Also added call to InputType::shouldSendChangeEventAfterCheckedChanged and moved the type-specific logic there. (WebCore::HTMLInputElement::setIndeterminate): Call isCheckable to see if indeterminate is allowed. Also updated for name changes. (WebCore::HTMLInputElement::copyNonAttributeProperties): Updated for name changes and removed data members. (WebCore::HTMLInputElement::value): Call InputType::getTypeSpecificValue and InputType::fallbackValue. Moved the type-specific logic there. (WebCore::HTMLInputElement::valueWithDefault): Call InputType::defaultValue. Moved the type-specific logic there. (WebCore::HTMLInputElement::setSuggestedValue): Call InputType::canSetSuggestedValue. Moved the type-specific logic there. (WebCore::HTMLInputElement::setValue): Call InputType::canSetValue. Moved the type-specific logic there. Clear the file list if it exists rather than checking the type explicitly. We could probably do that a more elegant way. (WebCore::HTMLInputElement::placeholder): Use fastGetAttribute. (WebCore::HTMLInputElement::setValueFromRenderer): Use the isFileUpload function in the assertion. (WebCore::HTMLInputElement::setFileListFromRenderer): Put most of the code from this function into FileInputType::setFileList. (WebCore::HTMLInputElement::preDispatchEventHandler): Changed to call InputType::willDispatchClick, which does the type-specific work. Still need to use a single struct for all types, because the type of the element could change during the event handling. (WebCore::HTMLInputElement::postDispatchEventHandler): Changed to call InputType::didDispatchClick. (WebCore::HTMLInputElement::defaultValue): Use fastGetAttribute. (WebCore::HTMLInputElement::accept): Use fastGetAttribute. (WebCore::HTMLInputElement::alt): Use fastGetAttribute. (WebCore::HTMLInputElement::src): Use fastGetAttribute. (WebCore::HTMLInputElement::setAutofilled): Updated for name changes. (WebCore::HTMLInputElement::files): Use InputType::files. (WebCore::HTMLInputElement::isAcceptableValue): Use InputType::isAcceptableValue. (WebCore::HTMLInputElement::sanitizeValue): Use InputType::sanitizeValue. (WebCore::HTMLInputElement::hasUnacceptableValue): Use InputType::hasUnacceptableValue. (WebCore::HTMLInputElement::needsActivationCallback): Use InputType::shouldResetOnDocumentActivation. (WebCore::HTMLInputElement::willMoveToNewOwnerDocument): Use InputType::willMoveToNewOwnerDocument. (WebCore::HTMLInputElement::dataList): Use InputType::shouldRespectListAttribute. (WebCore::HTMLInputElement::selectedOption): Tweaked logic and naming a bit. (WebCore::HTMLInputElement::stepUpFromRenderer): Use fastGetAttribute. (WebCore::HTMLInputElement::isSpeechEnabled): Use InputType::shouldRespectSpeechAttribute. (WebCore::HTMLInputElement::isTextButton): No longer inline. Calls through to InputType. (WebCore::HTMLInputElement::isRadioButton): Ditto. (WebCore::HTMLInputElement::isSearchField): Ditto. (WebCore::HTMLInputElement::isInputTypeHidden): Ditto. (WebCore::HTMLInputElement::isPasswordField): Ditto. (WebCore::HTMLInputElement::isCheckbox): Ditto. (WebCore::HTMLInputElement::isText): Ditto. (WebCore::HTMLInputElement::isEmailField): Ditto. (WebCore::HTMLInputElement::isFileUpload): Ditto. (WebCore::HTMLInputElement::isImageButton): Ditto. (WebCore::HTMLInputElement::isNumberField): Ditto. (WebCore::HTMLInputElement::isSubmitButton): Ditto. (WebCore::HTMLInputElement::isTelephoneField): Ditto. (WebCore::HTMLInputElement::isURLField): Ditto. (WebCore::HTMLInputElement::isEnumeratable): Ditto. (WebCore::HTMLInputElement::isChecked): No longer inline. Calls InputType::isCheckable. (WebCore::HTMLInputElement::hasSpinButton): No longer inline. Calls through to InputType. (WebCore::HTMLInputElement::supportsPlaceholder): No longer inline. Calls isTextType as before, but with no special case for ISINDEX. That special case was unneeded since it returns true from isTextType. (WebCore::HTMLInputElement::checkedRadioButtons): No longer inline. (WebCore::HTMLInputElement::handleBeforeTextInsertedEvent): No longer inline.
- html/HTMLInputElement.h: Removed multiple unneeded includes. The big one is probably InputType.h, but also HTMLFormElement.h. Removed unneeded forward declarations. Made many functions no longer inline since they now need to make virtual function dispatches. Removed the unneeded defaultChecked and webkitdirectory functions. Both are handled by HTML attribute reflection for DOM bindings, and the callers instead can get at the attribute. Made updateCheckedRadioButtons public so it can be called by an InputType class. Removed DeprecatedInputType, InputTypeMap, createTypeMap, deprecatedInputType, allowsIndeterminate, respectHeightAndWidthAttrs, storesValueSeparateFromAttribute, m_imageLoader, m_fileList, m_deprecatedTypeNumber, m_defaultChecked, and m_inited. Renamed m_checked to m_isChecked, m_useDefaultChecked to m_reflectsCheckedAttribute, m_indeterminate tom_isIndeterminate, m_haveType to m_hasType, m_activeSubmit to m_isActivatedSubmit, and m_autofilled to m_isAutofilled.
- html/HiddenInputType.cpp: (WebCore::HiddenInputType::accessKeyAction): Added. (WebCore::HiddenInputType::rendererIsNeeded) Added.: (WebCore::HiddenInputType::storesValueSeparateFromAttribute): Added. (WebCore::HiddenInputType::isHiddenType): Added. (WebCore::HiddenInputType::shouldRespectHeightAndWidthAttributes): Added.
- html/HiddenInputType.h: Ditto.
- html/ImageInputType.cpp: (WebCore::ImageInputType::ImageInputType): Moved out of the header file. (WebCore::ImageInputType::srcAttributeChanged): Added. (WebCore::ImageInputType::attach): Added. (WebCore::ImageInputType::willMoveToNewOwnerDocument): Added. (WebCore::ImageInputType::shouldRespectAlignAttribute): Added. (WebCore::ImageInputType::canBeSuccessfulSubmitButton): Added. (WebCore::ImageInputType::isImageButton): Added. (WebCore::ImageInputType::isEnumeratable): Added. (WebCore::ImageInputType::shouldRespectHeightAndWidthAttributes): Added.
- html/ImageInputType.h: Ditto.
- html/InputType.cpp: (WebCore::InputType::create): Changed argument type to String. There is no value in taking an AtomicString here. (WebCore::InputType::scaledStepValueShouldBeInteger): Fixed typo in this function name. (WebCore::InputType::canSetStringValue): Added. (WebCore::InputType::isKeyboardFocusable): Added. (WebCore::InputType::shouldUseInputMethod): Added. (WebCore::InputType::handleBlurEvent): Added. (WebCore::InputType::accessKeyAction): Added. (WebCore::InputType::attach): Added. (WebCore::InputType::srcAttributeChanged): Added. (WebCore::InputType::willMoveToNewOwnerDocument): Added. (WebCore::InputType::shouldRespectAlignAttribute): Added. (WebCore::InputType::canChangeFromAnotherType): Added. (WebCore::InputType::minOrMaxAttributeChanged): Added. (WebCore::InputType::canBeSuccessfulSubmitButton): Added. (WebCore::InputType::rendererIsNeeded): Added. (WebCore::InputType::files): Added. (WebCore::InputType::getTypeSpecificValue): Added. (WebCore::InputType::fallbackValue): Added. (WebCore::InputType::defaultValue): Added. (WebCore::InputType::canSetSuggestedValue): Added. (WebCore::InputType::shouldSendChangeEventAfterCheckedChanged): Added. (WebCore::InputType::storesValueSeparateFromAttribute): Added. (WebCore::InputType::canSetValue): Added. (WebCore::InputType::willDispatchClick): Added. (WebCore::InputType::didDispatchClick): Added. (WebCore::InputType::isAcceptableValue): Added. (WebCore::InputType::sanitizeValue): Added. (WebCore::InputType::hasUnacceptableValue): Added. (WebCore::InputType::setFileList): Added. (WebCore::InputType::shouldResetOnDocumentActivation): Added. (WebCore::InputType::shouldRespectListAttribute): Added. (WebCore::InputType::shouldRespectSpeechAttribute): Added. (WebCore::InputType::isTextButton): Added. (WebCore::InputType::isRadioButton): Added. (WebCore::InputType::isSearchField): Added. (WebCore::InputType::isHiddenType): Added. (WebCore::InputType::isPasswordField): Added. (WebCore::InputType::isCheckbox): Added. (WebCore::InputType::isEmailField): Added. (WebCore::InputType::isFileUpload): Added. (WebCore::InputType::isImageButton): Added. (WebCore::InputType::isNumberField): Added. (WebCore::InputType::isSubmitButton): Added. (WebCore::InputType::isTelephoneField): Added. (WebCore::InputType::isURLField): Added. (WebCore::InputType::isEnumeratable): Added. (WebCore::InputType::isCheckable): Added. (WebCore::InputType::hasSpinButton): Added. (WebCore::InputType::shouldRespectHeightAndWidthAttributes): Added.
- html/InputType.h: Removed unneeded ExceptionCode.h include and used a typedef instead as we do when we want for forward declare it. Added includes and forward declarations needed for new functions. Added ClickHandlingState structure. Changed the argument to create to a String rather than AtomicString. Added many virtual functions.
- html/IsIndexInputType.cpp: (WebCore::IsIndexInputType::shouldRespectListAttribute): Added.
- html/IsIndexInputType.h: Ditto.
- html/NumberInputType.cpp: (WebCore::NumberInputType::handleBlurEvent): Added. (WebCore::NumberInputType::isAcceptableValue): Added. (WebCore::NumberInputType::sanitizeValue): Added. (WebCore::NumberInputType::hasUnacceptableValue): Added. (WebCore::NumberInputType::shouldRespectSpeechAttribute): Added. (WebCore::NumberInputType::isNumberField): Added. (WebCore::NumberInputType::hasSpinButton): Added.
- html/NumberInputType.h: Ditto.
- html/PasswordInputType.cpp: (WebCore::PasswordInputType::shouldUseInputMethod): Added. (WebCore::PasswordInputType::shouldResetOnDocumentActivation): Added. (WebCore::PasswordInputType::shouldRespectListAttribute): Added. (WebCore::PasswordInputType::shouldRespectSpeechAttribute): Added. (WebCore::PasswordInputType::isPasswordField): Added.
- html/PasswordInputType.h: Ditto.
- html/RadioInputType.cpp: (WebCore::RadioInputType::isKeyboardFocusable): Added. (WebCore::RadioInputType::attach): Added. (WebCore::RadioInputType::shouldSendChangeEventAfterCheckedChanged): Added. (WebCore::RadioInputType::willDispatchClick): Added. (WebCore::RadioInputType::didDispatchClick): Added. (WebCore::RadioInputType::isRadioButton): Added.
- html/RadioInputType.h: Ditto.
- html/RangeInputType.cpp: (WebCore::RangeInputType::accessKeyAction): Added. (WebCore::RangeInputType::minOrMaxAttributeChanged): Added. (WebCore::RangeInputType::fallbackValue): Added. (WebCore::RangeInputType::sanitizeValue): Added. (WebCore::RangeInputType::shouldRespectListAttribute): Added.
- html/RangeInputType.h: Ditto.
- html/ResetInputType.cpp: (WebCore::ResetInputType::defaultValue): Added. (WebCore::ResetInputType::isTextButton): Added.
- html/ResetInputType.h: Ditto.
- html/SearchInputType.cpp: (WebCore::SearchInputType::shouldRespectSpeechAttribute): Added. (WebCore::SearchInputType::isSearchField): Added.
- html/SearchInputType.h: Ditto.
- html/SubmitInputType.cpp: (WebCore::SubmitInputType::canBeSuccessfulSubmitButton): Added. (WebCore::SubmitInputType::defaultValue): Added. (WebCore::SubmitInputType::isSubmitButton): Added. (WebCore::SubmitInputType::isTextButton): Added.
- html/SubmitInputType.h: Ditto.
- html/TelephoneInputType.cpp: (WebCore::TelephoneInputType::shouldRespectSpeechAttribute): Added. (WebCore::TelephoneInputType::isTelephoneField): Added.
- html/TelephoneInputType.h: Ditto.
- html/TextFieldInputType.cpp: (WebCore::TextFieldInputType::shouldUseInputMethod): Added. (WebCore::TextFieldInputType::sanitizeValue): Added. (WebCore::TextFieldInputType::shouldRespectListAttribute): Added.
- html/TextFieldInputType.h: Ditto.
- html/TextInputType.cpp: (WebCore::TextInputType::canSetSuggestedValue): Added. (WebCore::TextInputType::shouldRespectSpeechAttribute): Added.
- html/TextInputType.h: Ditto.
- html/TimeInputType.cpp: (WebCore::TimeInputType::scaledStepValueShouldBeInteger): Fixed typo in the name of this function.
- html/TimeInputType.h: Ditto.
- html/URLInputType.cpp: (WebCore::URLInputType::isURLField): Added.
- html/URLInputType.h: Ditto.
- 9:11 AM Changeset in webkit [74894] by
-
- 2 edits in trunk/LayoutTests
2011-01-03 Mihai Parparita <mihaip@chromium.org>
Unreviewed, Chromium test expectation update.
Update expectations after r74892. A bunch of previously failing tests
now pass (since they match scrollbars with the mac port). Some tests
also started to fail, they should be fixed by removing their
chromium-mac baselines.
- platform/chromium/test_expectations.txt:
- 9:02 AM Changeset in webkit [74893] by
-
- 2 edits in trunk/WebKit2
Ensure that the correct initial focusable area is focused when tabbing
and shift-tabbing into the WKView.
Reviewed by Anders Carlsson.
- UIProcess/API/mac/WKView.mm:
(-[WKView becomeFirstResponder]): Use the keyViewSelectionDirection to set
the initial focus.
- 8:16 AM Changeset in webkit [74892] by
-
- 2 edits in trunk/WebCore
2011-01-03 Mihai Parparita <mihaip@chromium.org>
Unreviewed.
NSScrollView-based scrollbars and ScrollBarTheme-based scrollbars don't look the same
https://bugs.webkit.org/show_bug.cgi?id=51151
Flip switch to use WebThemeEngine for Chromium/Mac scrollbar rendering,
so that it can match Safari's (and thus use the same baselines).
No new tests, should be covered by layout tests (which will need
expectation changes)
- platform/chromium/ScrollbarThemeChromiumMac.mm:
- 8:04 AM Changeset in webkit [74891] by
-
- 2 edits in trunk/WebKit/qt
2011-01-02 Antonio Gomes <agomes@rim.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Refactor EditorClientQt::handleKeyboardEvent
https://bugs.webkit.org/show_bug.cgi?id=51306
EditorClientQt::handleKeyboardEvent relies on QWebPagePrivate::editorActionForKeyEvent()
to handle all editor commands that have a QAction associted with it.
In practice, that covers most of editor commands (as one can see in editorCommandWebActions,
in qwebpage.cpp). However, there are some key down events that are associated to no QAction
or need special handling when features like spatial navigation or
caret browsing are enabled. Currently, these cases are being handled with confusing
and nested if/else switch's statements in EditorClientQt::handleKeyboardEvent(),
and the code is hardly readable.
This patch introduces a mapping hash for those cases, simplifying much
the code. Basically, nested switches statements mixed with if/else's were
refactored, and early returns were added right after an event gets consumed
by the Editor.
Since it is a refactor only patch, there is no funcionality change at
all, and then no new tests are being added.
- WebCoreSupport/EditorClientQt.cpp: (WebCore::interpretKeyEvent): (WebCore::EditorClientQt::handleKeyboardEvent):
- 7:50 AM Changeset in webkit [74890] by
-
- 2 edits in trunk/WebCore
2011-01-03 Antonio Gomes <agomes@rim.com>
Unreviewed build fix for WebKit/Gtk+.
RenderThemeGtk::initMediaColors() in RenderThemeGtk2.cpp needs to be
guarded by ENABLE(VIDEO), as it is in its header.
No new tests.
- platform/gtk/RenderThemeGtk2.cpp:
- 6:00 AM Changeset in webkit [74889] by
-
- 2 edits in trunk/Tools
2011-01-03 Koan-Sin Tan <koansin.tan@gmail.com>
Reviewed by Xan Lopez.
"Tool/Scripts/run-launcher --gtk" stopped working after 74855
https://bugs.webkit.org/show_bug.cgi?id=51806
Originally, the $libraryName is 'JavaScriptCore'. When building release
one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
is 'WebKitBuild/Release/Source/JavaScriptCore' now), and
'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
so make it 'WebKitBuild/Release/.libs'
- Scripts/webkitdirs.pm:
Jan 2, 2011:
- 9:45 PM Changeset in webkit [74888] by
-
- 2 edits in trunk/LayoutTests
2011-01-02 Adam Barth <abarth@webkit.org>
Skip this test for now. It's been failing for a while. I'm
investigating the root cause now, but having this red on the buildbot
isn't productive.
- platform/mac/Skipped:
- 8:53 PM Changeset in webkit [74887] by
-
- 13 edits in trunk
<rdar://problem/8812159> Update copyright strings
Rubber-stamped by Simon Fraser.
Source/JavaScriptCore:
- Info.plist:
Source/JavaScriptGlue:
- Info.plist:
WebCore:
- Info.plist:
WebKit/mac:
- Info.plist:
WebKit2:
- Info.plist:
- WebProcess/Info.plist:
WebKitLibraries:
- win/tools/scripts/COPYRIGHT-END-YEAR:
- 8:45 PM Changeset in webkit [74886] by
-
- 2 edits1 add in trunk/WebCore
<rdar://problem/8806570> REGRESSION (r73337): Incorrect text match count when a match occurs in a text field
https://bugs.webkit.org/show_bug.cgi?id=51623
Reviewed by Sam Weinig.
- editing/Editor.cpp:
(WebCore::Editor::countMatchesForText): Actually remember the original search range end
container and offset and restore them when needed, instead of using two references to the
same Range.
- manual-tests/find-count-matches-after-text-control.html: Added.
- 7:29 PM Changeset in webkit [74885] by
-
- 2 edits in trunk/LayoutTests
2011-01-02 Kent Tamura <tkent@chromium.org>
Unreviewed, test expectation update.
Two more fixes.
- platform/chromium/test_expectations.txt:
- 7:18 PM Changeset in webkit [74884] by
-
- 2 edits in trunk/LayoutTests
2011-01-02 Kent Tamura <tkent@chromium.org>
Unreviewed, correct test_expectations.txt syntax.
- platform/chromium/test_expectations.txt:
- 6:18 PM Changeset in webkit [74883] by
-
- 2 edits7 adds in trunk/LayoutTests
2011-01-02 Kent Tamura <tkent@chromium.org>
Unreviewed, test expectation update.
- Add expectation files for application-plugin-plugins-disabled.html
- Add some flaky tests to test_expectations.txt
- platform/chromium-linux/plugins/application-plugin-plugins-disabled-expected.checksum: Added.
- platform/chromium-linux/plugins/application-plugin-plugins-disabled-expected.png: Added.
- platform/chromium-mac/plugins/application-plugin-plugins-disabled-expected.checksum: Added.
- platform/chromium-mac/plugins/application-plugin-plugins-disabled-expected.png: Added.
- platform/chromium-win/plugins/application-plugin-plugins-disabled-expected.checksum: Added.
- platform/chromium-win/plugins/application-plugin-plugins-disabled-expected.png: Added.
- platform/chromium-win/plugins/application-plugin-plugins-disabled-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 5:29 PM Changeset in webkit [74882] by
-
- 5 edits in trunk
2011-01-02 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Csaba Osztrogonác.
WebKit 2 does not build on 64bits with a recent GCC
https://bugs.webkit.org/show_bug.cgi?id=51754
Use explicitely 64 bits types for the attributes of DatabaseDetails.
- storage/DatabaseDetails.h: (WebCore::DatabaseDetails::expectedUsage): (WebCore::DatabaseDetails::currentUsage):
2011-01-02 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Csaba Osztrogonác.
WebKit 2 does not build on 64bits with a recent GCC
https://bugs.webkit.org/show_bug.cgi?id=51754
Change the argument coding for DatabaseDetails to use explicitely the 64 bits type.
- Shared/OriginAndDatabases.h:
- Shared/WebCoreArgumentCoders.h:
- 5:06 PM Changeset in webkit [74881] by
-
- 3 edits in trunk/Tools
2011-01-02 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Barth.
Make EFL a core builder
https://bugs.webkit.org/show_bug.cgi?id=51804
- Scripts/webkitpy/common/net/buildbot/buildbot.py:
- Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
- 4:08 PM Changeset in webkit [74880] by
-
- 2 edits in trunk/Tools
[Qt] Unreviewed fix after r74855 and r74875.
- BuildSlaveSupport/built-product-archive:
- Create directories explicitly.
- Pass shell=True to subprocess.call().
- 3:38 PM Changeset in webkit [74879] by
-
- 2 edits in trunk/WebCore
2011-01-02 Patrick Gansterer <Patrick Gansterer>
Unreviewed WinCE build fix for r74868.
- platform/graphics/wince/ImageBufferWinCE.cpp: (WebCore::getImageData):
- 3:26 PM Changeset in webkit [74878] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix GTK+ build after r74855.
Reviewed by Xan Lopez.
- GNUmakefile.am: Fix include pathes.
- 2:27 PM Changeset in webkit [74877] by
-
- 20 edits in trunk/WebCore
2011-01-02 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r74847.
http://trac.webkit.org/changeset/74847
https://bugs.webkit.org/show_bug.cgi?id=51803
"Preprocessor guards should be in header files" (Requested by
ap on #webkit).
- bindings/js/JSDOMWindowBase.cpp:
- dom/Document.cpp: (WebCore::Document::recalcStyle):
- html/HTMLDocument.cpp:
- loader/FrameLoader.cpp:
- loader/ResourceLoadNotifier.cpp:
- page/Chrome.cpp:
- page/Console.cpp:
- page/ContextMenuController.cpp:
- page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchEvent):
- page/EventHandler.cpp:
- page/Page.cpp:
- storage/Database.cpp:
- workers/AbstractWorker.cpp:
- workers/DefaultSharedWorkerRepository.cpp:
- workers/SharedWorker.cpp:
- workers/Worker.cpp:
- workers/WorkerContext.cpp:
- workers/WorkerMessagingProxy.cpp:
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::callReadyStateChangeListener):
- 2:11 PM Changeset in webkit [74876] by
-
- 3 edits1 copy in trunk/LayoutTests
2011-01-02 Robert Hogan <robert@webkit.org>
Unreviewed, update expected results.
Update expected results for tests added in r74872
Skip test on Qt as Qt Styled Widgets are no longer getting
rendered when plugins are disabled. This is a bug.
- platform/gtk/plugins/application-plugin-plugins-disabled-expected.txt: Copied from LayoutTests/plugins/application-plugin-plugins-disabled-expected.txt.
- platform/qt/Skipped:
- plugins/application-plugin-plugins-disabled-expected.txt:
- 1:44 PM Changeset in webkit [74875] by
-
- 2 edits in trunk/Tools
[Qt] Unreviewed fix after r74855.
Move JavaScriptCore to Source
https://bugs.webkit.org/show_bug.cgi?id=51604
- BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
- 1:28 PM Changeset in webkit [74874] by
-
- 2 edits in trunk/Tools
[Qt] Unreviewed run-javasriptcore-tests fix after r74855.
Move JavaScriptCore to Source
https://bugs.webkit.org/show_bug.cgi?id=51604
- Scripts/webkitdirs.pm:
- 1:16 PM Changeset in webkit [74873] by
-
- 2 edits in trunk/WebKit2
Move JavaScriptCore to Source
https://bugs.webkit.org/show_bug.cgi?id=51604
Reviewed by Adam Barth.
Workaround until moving all sources to Source directory is finished.
- Scripts/generate-forwarding-headers.pl: Add Sources to searching path for JavaScriptCore.
- 1:13 PM Changeset in webkit [74872] by
-
- 1 edit3 adds in trunk/LayoutTests
2011-01-02 Robert Hogan <robert@webkit.org>
Unreviewed.
Layout tests from changeset r56661 were missed
This test was accidentally omitted from changeset 56661.
See also https://webkit.org/b/32196
- platform/qt/plugins/application-plugin-plugins-disabled-expected.txt: Added.
- plugins/application-plugin-plugins-disabled-expected.txt: Added.
- plugins/application-plugin-plugins-disabled.html: Added.
- 11:31 AM Changeset in webkit [74871] by
-
- 2 edits in trunk/WebCore
2011-01-02 Patrick Gansterer <Patrick Gansterer>
[CMake] Unreviewed build fix.
- CMakeLists.txt:
- 11:16 AM Changeset in webkit [74870] by
-
- 3 edits in trunk
2011-01-02 Patrick Gansterer <Patrick Gansterer>
[CMake] Unreviewed build fix.
- CMakeLists.txt:
- Source/cmake/OptionsCommon.cmake:
- 8:06 AM Changeset in webkit [74869] by
-
- 2 edits in trunk/Tools
2011-01-02 Robert Hogan <robert@webkit.org>
Unreviewed, build fix.
[Qt] Fix DRT build after 74855
- DumpRenderTree/qt/DumpRenderTree.pro:
- 2:38 AM Changeset in webkit [74868] by
-
- 29 edits in trunk
2011-01-02 Dirk Schulze <krit@webkit.org>
Reviewed by Simon Fraser.
Clarify ImageBuffer and ImageData relationship
https://bugs.webkit.org/show_bug.cgi?id=51297
Use ByteArray instead of ImageData.
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::doPixelReadbackToCanvas):
2011-01-02 Dirk Schulze <krit@webkit.org>
Reviewed by Simon Fraser.
Clarify ImageBuffer and ImageData relationship
https://bugs.webkit.org/show_bug.cgi?id=51297
Remove references to ImageData and CanvasPixelArray from ImageBuffer and SVG filter/masker code,
since this was a layering violation, and replaced it by ByteArray.
No change of functionality, so no new test added.
- html/ImageData.cpp: (WebCore::ImageData::create): (WebCore::ImageData::ImageData):
- html/ImageData.h: Added new constructor with ByteArray input. (WebCore::ImageData::width): (WebCore::ImageData::height): (WebCore::ImageData::data):
- html/canvas/CanvasPixelArray.cpp: (WebCore::CanvasPixelArray::create): (WebCore::CanvasPixelArray::CanvasPixelArray):
- html/canvas/CanvasPixelArray.h: New conctructor with ByteArray input, used by HTML Canvas. (WebCore::CanvasPixelArray::data): (WebCore::CanvasPixelArray::length): (WebCore::CanvasPixelArray::set): (WebCore::CanvasPixelArray::get):
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::getImageData): (WebCore::CanvasRenderingContext2D::putImageData):
- platform/graphics/ImageBuffer.h:
- platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::getImageData): (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::putImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):
- platform/graphics/cg/ImageBufferCG.cpp: (WebCore::getImageData): (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::putImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):
- platform/graphics/filters/FEBlend.cpp: (WebCore::FEBlend::apply):
- platform/graphics/filters/FEColorMatrix.cpp: (WebCore::FEColorMatrix::apply):
- platform/graphics/filters/FEComponentTransfer.cpp: (WebCore::FEComponentTransfer::apply):
- platform/graphics/filters/FEComposite.cpp: (WebCore::FEComposite::apply):
- platform/graphics/filters/FEConvolveMatrix.cpp: (WebCore::setDestinationPixels): (WebCore::FEConvolveMatrix::apply):
- platform/graphics/filters/FEConvolveMatrix.h:
- platform/graphics/filters/FEDisplacementMap.cpp: (WebCore::FEDisplacementMap::apply):
- platform/graphics/filters/FEGaussianBlur.cpp: (WebCore::FEGaussianBlur::apply):
- platform/graphics/filters/FELighting.cpp: (WebCore::FELighting::apply):
- platform/graphics/filters/FEMorphology.cpp: (WebCore::FEMorphology::apply):
- platform/graphics/filters/FETurbulence.cpp: (WebCore::FETurbulence::apply):
- platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::asImageBuffer): (WebCore::FilterEffect::asUnmultipliedImage): (WebCore::FilterEffect::asPremultipliedImage): (WebCore::FilterEffect::copyImageBytes): (WebCore::FilterEffect::copyUnmultipliedImage): (WebCore::FilterEffect::copyPremultipliedImage): (WebCore::FilterEffect::createUnmultipliedImageResult): (WebCore::FilterEffect::createPremultipliedImageResult):
- platform/graphics/filters/FilterEffect.h:
- platform/graphics/qt/ImageBufferQt.cpp: (WebCore::getImageData): (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::putImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):
- platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::getImageData): (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::putImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):
- platform/graphics/wince/ImageBufferWinCE.cpp: (WebCore::getImageData): (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::putImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):
- platform/graphics/wx/ImageBufferWx.cpp: (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):
- rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):
- 1:51 AM Changeset in webkit [74867] by
-
- 2 edits in trunk/WebKit/gtk
2011-01-02 Xan Lopez <xlopez@igalia.com>
Fix GTK+ build.
- GNUmakefile.am: tests do actually include JSC.
- 1:12 AM Changeset in webkit [74866] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-01-02 Adam Barth <abarth@webkit.org>
One more .. missing in the Qt build.
- jsc.pro:
- 1:06 AM Changeset in webkit [74865] by
-
- 4 edits in trunk
WebKit/gtk:
2011-01-02 Xan Lopez <xlopez@igalia.com>
Fix GTK+ build.
- GNUmakefile.am: remove individual -I$(srcdir)/Source when we'll already get them from javascriptcore_cppflags, and add it for the introspection build (which is not tested in the bots).
2011-01-02 Xan Lopez <xlopez@igalia.com>
Fix GTK+ build.
- GNUmakefile.am: add -I$(srcdir)/Source to the JSC cppflags so that anyone can include its headers without adding the prefix 'Source/'.
- 12:28 AM Changeset in webkit [74864] by
-
- 2 edits in trunk/WebKit/gtk
2011-01-02 Adam Barth <abarth@webkit.org>
Speculative build fix for GTK. Add Source to the include paths.
- GNUmakefile.am:
- 12:15 AM Changeset in webkit [74863] by
-
- 6 edits in trunk/Source/JavaScriptCore
2011-01-02 Carl Lobo <carllobo@gmail.com>
Reviewed by Adam Barth.
Fix Windows Build for non-production where VSPropsRedirectionDir is not defined.
https://bugs.webkit.org/show_bug.cgi?id=51797
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh:
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- JavaScriptCore.vcproj/jsc/jsc.vcproj:
- JavaScriptCore.vcproj/testapi/testapi.vcproj:
