⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 5, 2011:

11:43 PM Changeset in webkit [75146] by jam@chromium.org
  • 2 edits
    1 add in trunk/WebKit/chromium

2010-12-29 John Abd-El-Malek <​jam@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add a WebAutoFillClient interface that moves some functions from WebViewClient
​https://bugs.webkit.org/show_bug.cgi?id=51710

  • WebKit.gyp:
  • public/WebAutoFillClient.h: Added. (WebKit::WebAutoFillClient::didAcceptAutoFillSuggestion): (WebKit::WebAutoFillClient::didSelectAutoFillSuggestion): (WebKit::WebAutoFillClient::didClearAutoFillSelection): (WebKit::WebAutoFillClient::removeAutocompleteSugestion): (WebKit::WebAutoFillClient::didAcceptAutocompleteSuggestion): (WebKit::WebAutoFillClient::textFieldDidBeginEditing): (WebKit::WebAutoFillClient::textFieldDidEndEditing): (WebKit::WebAutoFillClient::textFieldDidChange): (WebKit::WebAutoFillClient::textFieldDidReceiveKeyDown): (WebKit::WebAutoFillClient::~WebAutoFillClient):
11:16 PM Changeset in webkit [75145] by Darin Adler
  • 2 edits in trunk/WebCore

Fix Chromium Mac build.

  • platform/graphics/Gradient.h: Forward-declare CGContextRef.

This might even make it possible to remove the include of
<CoreGraphics/CoreGraphics.h> for PLATFORM(WIN), but I did not
do that at this time because I don't want to break the Windows
build when fixing the Chromium build.

11:12 PM Changeset in webkit [75144] by Darin Adler
  • 10 edits in trunk/WebKit2

2011-01-05 Darin Adler <Darin Adler>

Reviewed by Geoff Garen.

Back/Forward entries in WebKit2 leak
​https://bugs.webkit.org/show_bug.cgi?id=51983

Besides fixing the leak, this also fixes a problem where
all history items were sent over to the UI process, but
we wanted to send only back/forward items.

  • UIProcess/WebBackForwardList.cpp: (WebKit::WebBackForwardList::pageClosed): Added. Tells the web process about all the back/forward items being removed. (WebKit::WebBackForwardList::addItem): Ditto. Also removed a redundant call to didChangeBackForwardList. (WebKit::WebBackForwardList::clear): Ditto.
  • UIProcess/WebBackForwardList.h: Added pageClosed.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::close): Added a call to pageClosed. (WebKit::WebPageProxy::backForwardRemovedItem): Added. Sends a message to the web page in the web process.
  • UIProcess/WebPageProxy.h: Added backForwardRemovedItem.
  • WebProcess/WebPage/WebBackForwardListProxy.cpp: (WebKit::updateBackForwardItem): Added an itemID argument, since callers will now be getting it and we don't want to get it twice. Removed the code to generate an ID. Also removed some local variables to make the code a little tighter and clearer. (WebKit::WK2NotifyHistoryItemChanged): Only call updateBackForwardItem for items that already have IDs. We don't want to send cross-process messages for every history item; just the ones that are top level back/forward items. (WebKit::WebBackForwardListProxy::removeItem): Added. For use when the UI process tells us to remove it. (WebKit::WebBackForwardListProxy::addItem): Added code to assign an ID and put this item into the maps. This is called exactly once on each back/forward item.
  • WebProcess/WebPage/WebBackForwardListProxy.h: Added removeItem.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::didRemoveBackForwardItem): Added.
  • WebProcess/WebPage/WebPage.h: Added didRemoveBackForwardItem.
  • WebProcess/WebPage/WebPage.messages.in: Added DidRemoveBackForwardItem message.
11:11 PM Changeset in webkit [75143] by sfalken@apple.com
  • 2 edits in trunk/Tools

Windows build fix.
Back out attempted change to built-product-archive.

  • BuildSlaveSupport/built-product-archive:
11:00 PM Changeset in webkit [75142] by sfalken@apple.com
  • 2 edits in trunk/Tools

Windows build fix.
Include configuration name when unpacking a build archive.

Needed, since we split Windows build results into configuration-specific directories
under WebKitOutputDir.

  • BuildSlaveSupport/built-product-archive:
10:20 PM Changeset in webkit [75141] by sfalken@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops: Revert change to additional library search path needed to find ICU.
10:15 PM Changeset in webkit [75140] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2011-01-05 Xianzhu Wang <​wangxianzhu@google.com>

Reviewed by David Levin.

Implement RemoteFontStream's skip behavior (in FontCustomPlatformData.cpp)
​https://bugs.webkit.org/show_bug.cgi?id=51736

No new tests. This change has potential effect on @font-face CSS feature
on ports using Skia. Tested on Chromium that this change won't break
fast/css/font-face-remote.html. This change can make the test pass on
other ports using Skia.

  • platform/graphics/skia/FontCustomPlatformData.cpp: (WebCore::RemoteFontStream::read):
10:11 PM Changeset in webkit [75139] by commit-queue@webkit.org
  • 7 edits
    3 adds
    3 deletes in trunk

2011-01-05 Helder Correia <​helder@sencha.com>

Reviewed by Simon Fraser.

Shadows are not drawn when filling a rect with a gradient fillStyle on Mac and Chromium-Mac
​https://bugs.webkit.org/show_bug.cgi?id=51869

GraphicsContext::fillRect(const FloatRect&) is clipping to the rect.
The shadow is being drawn, but getting clipped to the rect being filled.
The solution is to draw the gradient into a CGLayer (when a shadow is
required), then render the layer to the GraphicsContext.

This patch also fixes:
canvas/philip/tests/2d.shadow.gradient.alpha.html
canvas/philip/tests/2d.shadow.gradient.basic.html
canvas/philip/tests/2d.shadow.gradient.transparent.2.html

New test to ensure that shadows are drawn when fillStyle is a gradient,
possibly with some transparency and blur, and specifically using
fillRect.

  • fast/canvas/canvas-fillRect-gradient-shadow-expected.txt: Added.
  • fast/canvas/canvas-fillRect-gradient-shadow.html: Added.
  • fast/canvas/script-tests/canvas-fillRect-gradient-shadow.js: Added.

2011-01-05 Helder Correia <​helder@sencha.com>

Reviewed by Simon Fraser.

Shadows are not drawn when filling a rect with a gradient fillStyle on Mac and Chromium-Mac
​https://bugs.webkit.org/show_bug.cgi?id=51869

GraphicsContext::fillRect(const FloatRect&) is clipping to the rect.
The shadow is being drawn, but getting clipped to the rect being filled.
The solution is to draw the gradient into a CGLayer (when a shadow is
required), then render the layer to the GraphicsContext.

This patch also fixes:
canvas/philip/tests/2d.shadow.gradient.alpha.html
canvas/philip/tests/2d.shadow.gradient.basic.html
canvas/philip/tests/2d.shadow.gradient.transparent.2.html

Test: fast/canvas/canvas-fillRect-gradient-shadow.html

  • platform/graphics/Gradient.h:
  • platform/graphics/cg/GradientCG.cpp: (WebCore::Gradient::paint):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillRect):
10:02 PM Changeset in webkit [75138] by sfalken@apple.com
  • 97 edits
    1 add in trunk

2011-01-05 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin Adler.

Debug and Release builds on Windows clobber each other
​https://bugs.webkit.org/show_bug.cgi?id=49185

Changes the structure of WebKitBuild build products directory so we
completely separate each build configuration into independent directories.


Although we previously had per-configuration directories for obj, this change adds
per-configuration directories for bin, lib, obj, and include. Each configuration's
build products are stored within a directory inside of WebKitBuild.


Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).

  • win/tools/vsprops/common.vsprops:

2011-01-05 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin Adler.

Debug and Release builds on Windows clobber each other
​https://bugs.webkit.org/show_bug.cgi?id=49185

Changes the structure of WebKitBuild build products directory so we
completely separate each build configuration into independent directories.


Although we previously had per-configuration directories for obj, this change adds
per-configuration directories for bin, lib, obj, and include. Each configuration's
build products are stored within a directory inside of WebKitBuild.


Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).

  • WebKit.vcproj/InterfacesCommon.vsprops:
  • WebKit.vcproj/InterfacesPostBuild.cmd:
  • WebKit.vcproj/InterfacesPreBuild.cmd:
  • WebKit.vcproj/WebKit.make:
  • WebKit.vcproj/WebKitGUID.vcproj:
  • WebKit.vcproj/WebKitGUIDCommon.vsprops:
  • WebKit.vcproj/WebKitGUIDPostBuild.cmd:
  • WebKit.vcproj/WebKitGUIDPreBuild.cmd:
  • WebKit.vcproj/WebKitLibCommon.vsprops:
  • WebKit.vcproj/WebKitLibPostBuild.cmd:
  • WebKit.vcproj/WebKitLibPreBuild.cmd:

2011-01-05 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin Adler.

Debug and Release builds on Windows clobber each other
​https://bugs.webkit.org/show_bug.cgi?id=49185

Changes the structure of WebKitBuild build products directory so we
completely separate each build configuration into independent directories.


Although we previously had per-configuration directories for obj, this change adds
per-configuration directories for bin, lib, obj, and include. Each configuration's
build products are stored within a directory inside of WebKitBuild.


Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).

  • WebCore.vcproj/QTMovieWinCommon.vsprops:
  • WebCore.vcproj/QTMovieWinPostBuild.cmd:
  • WebCore.vcproj/QTMovieWinPreBuild.cmd:
  • WebCore.vcproj/WebCore.make:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/WebCoreCommon.vsprops:
  • WebCore.vcproj/WebCoreGeneratedCairo.vsprops:
  • WebCore.vcproj/WebCoreGeneratedCommon.vsprops:
  • WebCore.vcproj/WebCoreMediaQT.vsprops:
  • WebCore.vcproj/WebCorePostBuild.cmd:
  • WebCore.vcproj/WebCorePreBuild.cmd:
  • WebCore.vcproj/copyForwardingHeaders.cmd:
  • WebCore.vcproj/copyInspectorFiles.cmd:

2011-01-05 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin Adler.

Debug and Release builds on Windows clobber each other
​https://bugs.webkit.org/show_bug.cgi?id=49185


Changes the structure of WebKitBuild build products directory so we
completely separate each build configuration into independent directories.


Although we previously had per-configuration directories for obj, this change adds
per-configuration directories for bin, lib, obj, and include. Each configuration's
build products are stored within a directory inside of WebKitBuild.


Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).


For PGO, $(ConfigurationBuildDir) points to the same directory (Release_PGO) to allow
for proper operation of the instrumentation/optimization scripts.

2011-01-05 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin Adler.

Debug and Release builds on Windows clobber each other
​https://bugs.webkit.org/show_bug.cgi?id=49185

Changes the structure of WebKitBuild build products directory so we
completely separate each build configuration into independent directories.


Although we previously had per-configuration directories for obj, this change adds
per-configuration directories for bin, lib, obj, and include. Each configuration's
build products are stored within a directory inside of WebKitBuild.


Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).

  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
  • DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
  • DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
  • DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
  • DumpRenderTree/win/ImageDiffCommon.vsprops:
  • DumpRenderTree/win/ImageDiffPostBuild.cmd:
  • DumpRenderTree/win/ImageDiffPreBuild.cmd:
  • FindSafari/FindSafari.vcproj:
  • MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
  • MiniBrowser/MiniBrowserPostBuild.cmd:
  • MiniBrowser/MiniBrowserPreBuild.cmd:
  • Scripts/webkitdirs.pm:
  • TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
  • TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
  • TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
  • TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
  • TestWebKitAPI/win/copy-resources.cmd:
  • WebKitAPITest/WebKitAPITestCommon.vsprops:
  • WebKitAPITest/WebKitAPITestPostBuild.cmd:
  • WebKitAPITest/WebKitAPITestPreBuild.cmd:
  • WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
  • WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
  • WebKitTestRunner/win/InjectedBundle.vcproj:
  • WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
  • WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
  • WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
  • WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
  • WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
  • WinLauncher/WinLauncherCommon.vsprops:
  • WinLauncher/WinLauncherPostBuild.cmd:
  • WinLauncher/WinLauncherPreBuild.cmd:

2011-01-05 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin Adler.

Debug and Release builds on Windows clobber each other
​https://bugs.webkit.org/show_bug.cgi?id=49185

Changes the structure of WebKitBuild build products directory so we
completely separate each build configuration into independent directories.


Although we previously had per-configuration directories for obj, this change adds
per-configuration directories for bin, lib, obj, and include. Each configuration's
build products are stored within a directory inside of WebKitBuild.


Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).

  • win/WebKit2.make:
  • win/WebKit2.vcproj:
  • win/WebKit2Common.vsprops:
  • win/WebKit2Generated.make:
  • win/WebKit2GeneratedCommon.vsprops:
  • win/WebKit2WebProcessPostBuild.cmd:
  • win/WebKit2WebProcessPreBuild.cmd:
  • win/WebKitPostBuild.cmd:
  • win/WebKitPreBuild.cmd:
9:44 PM Changeset in webkit [75137] by Simon Fraser
  • 6 edits
    1 copy
    3 adds in trunk

2011-01-05 Simon Fraser <Simon Fraser>

Reviewed by Ariya Hidayat.

Directly composited SVG images fail to render
​https://bugs.webkit.org/show_bug.cgi?id=51975

There was already code, added in r67900, to detect whether an image
may be directly composited, by checking to see if it's a bitmap image.

However, CachedImage::image() returns the nullImage() if m_image is null,
which is a BitmapImage, confusing this test.

Test: compositing/images/direct-svg-image.html

  • loader/cache/CachedImage.cpp: Remove nullImage(), since Image has exactly the same method. (WebCore::CachedImage::image): Use Image::nullImage().
  • loader/cache/CachedImage.h: (WebCore::CachedImage::hasImage): New method to ask whether the m_image is non-null.
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::isDirectlyCompositedImage): Use hasImage() so that we don't test the nullImage.
9:28 PM Changeset in webkit [75136] by Simon Fraser
  • 4 edits
    4 adds in trunk

2011-01-05 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

Fix percentage values in radius of radial gradients
​https://bugs.webkit.org/show_bug.cgi?id=51979

Handle percentage values for the ending size of radial gradients.

Test: fast/gradients/css3-radial-gradients3.html

  • css/CSSGradientValue.cpp: (WebCore::CSSRadialGradientValue::resolveRadius): Add parameter for height or width, which is non-null if percentage values are allowed, and compute percentage values when we see them. (WebCore::CSSRadialGradientValue::createGradient): Pass height or width down to say that percentages are OK when resolving end radii.
  • css/CSSGradientValue.h: New parameter for resolveRadius.
9:16 PM Changeset in webkit [75135] by ap@apple.com
  • 5 edits in trunk/WebKit2

2011-01-05 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Anders Carlsson.

​https://bugs.webkit.org/show_bug.cgi?id=51973
Make main frame PDF printing work

  • UIProcess/API/mac/PDFViewController.h:
  • UIProcess/API/mac/PDFViewController.mm: (WebKit::PDFViewController::makePrintOperation): Ask PDFDocument to create an NSPrintOperation.
  • UIProcess/API/mac/WKView.h:
  • UIProcess/API/mac/WKView.mm: (-[WKView printOperationWithPrintInfo:forFrame:]): Create a new NSPrintOperation, either from scratch or from a PDF view. (-[WKView canPrintHeadersAndFooters]): Report if the view can be re-paginated to add headers and footers.
8:56 PM Changeset in webkit [75134] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-01-05 Jan Erik Hanssen <​jhanssen@sencha.com>

Reviewed by Ariya Hidayat.

[Qt] TestNetscapePlugin doesn't link on OS X
​https://bugs.webkit.org/show_bug.cgi?id=51948

Only add a dependency on libX11 on X11 systems

  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
8:36 PM Changeset in webkit [75133] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-01-05 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

change the way we do comment highlighting in the code review tool
​https://bugs.webkit.org/show_bug.cgi?id=51971

Store a space-separated list of base line IDs on each line that has
comments associated with that line. This allows for overlapping comments,
but more importantly, makes adding side-by-side diff support easier.

  • code-review.js:
8:09 PM Changeset in webkit [75132] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-01-05 Jeff Miller <​jeffm@apple.com>

Reviewed by Adam Roben.

check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
​https://bugs.webkit.org/show_bug.cgi?id=51970

  • Scripts/webkitpy/style/checker.py: Add -readability/naming for WebKit2 C API directories.
7:19 PM Changeset in webkit [75131] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-01-05 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

minor code cleanup for code review tool
​https://bugs.webkit.org/show_bug.cgi?id=51962

Consolidates some queries to using shared functions.

  • code-review.js:
6:50 PM Changeset in webkit [75130] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-01-05 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

assorted cleanups to prepare for side-by-side diffing
​https://bugs.webkit.org/show_bug.cgi?id=51961

Mostly, use selector queries instead of assuming comments are next siblings.

  • code-review.js:
6:41 PM Changeset in webkit [75129] by simonjam@chromium.org
  • 13 edits
    9 adds in trunk

2011-01-05 James Simonsen <​simonjam@chromium.org>

Reviewed by Adam Barth.

[Web Timing] Zero out some values on cross-origin redirects
​https://bugs.webkit.org/show_bug.cgi?id=49294

  • fast/dom/script-tests/webtiming.js: (checkTimingBeforeLoad): Remove unload. Its behavior depends on prior navigation and is tested separately. (checkTimingWhileDeferred): Ditto. (checkWebTimingOnDOMContentLoaded): Ditto. (checkWebTimingWhileAsync): Ditto. (checkWebTimingOnLoad): Ditto. (checkWebTimingAfterLoad): Ditto.
  • fast/dom/webtiming-expected.txt:
  • http/tests/misc/resources/webtiming-cross-origin-and-back-redirect1.php: Added.
  • http/tests/misc/resources/webtiming-cross-origin-and-back-redirect2.php: Added.
  • http/tests/misc/resources/webtiming-cross-origin-and-back1.html: Added.
  • http/tests/misc/resources/webtiming-cross-origin-and-back2.html: Added.
  • http/tests/misc/resources/webtiming-cross-origin-redirect.html: Added.
  • http/tests/misc/resources/webtiming-cross-origin-redirect.php: Added.
  • http/tests/misc/resources/webtiming-no-origin.html: Added.
  • http/tests/misc/webtiming-origins-expected.txt: Added.
  • http/tests/misc/webtiming-origins.html: Added.
  • platform/gtk/Skipped: Skip new web timing test.
  • platform/mac/Skipped: Ditto.
  • platform/win/Skipped: Ditto.

2011-01-05 James Simonsen <​simonjam@chromium.org>

Reviewed by Adam Barth.

[Web Timing] Zero out some values on cross-origin redirects
​https://bugs.webkit.org/show_bug.cgi?id=49294

Tests: http/tests/misc/webtiming-cross-origin-redirect.php

http/tests/misc/webtiming-origins.html

  • loader/DocumentLoadTiming.h: (WebCore::DocumentLoadTiming::DocumentLoadTiming): Add flags for cross-origin redirects and same-origin navigation.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::~FrameLoader): (WebCore::FrameLoader::stopLoading): Don't overwrite previous unload times. (WebCore::FrameLoader::completed): (WebCore::FrameLoader::loadWithDocumentLoader): Remember previous URL to see if navigation is same-origin. (WebCore::FrameLoader::commitProvisionalLoad): Set flag if navigation is same-origin.
  • loader/FrameLoader.h:
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::willSendRequest): Set flag on cross-origin redirects.
  • page/PerformanceNavigation.cpp: (WebCore::PerformanceNavigation::redirectCount): Clear if cross-origin redirect flag is set.
  • page/PerformanceTiming.cpp: (WebCore::PerformanceTiming::redirectStart): Ditto. (WebCore::PerformanceTiming::redirectEnd): Ditto. (WebCore::PerformanceTiming::unloadEventStart): Clear if cross-origin navigation is set. (WebCore::PerformanceTiming::unloadEventEnd): Ditto.
6:39 PM Changeset in webkit [75128] by andersca@apple.com
  • 15 edits
    1 add in trunk/WebKit2

<rdar://problem/8750248>
Need a way to create a new DownloadProxy from an arbitrary resource request

Reviewed by Sam Weinig.

<rdar://problem/8750465>
Need a way to start a download in WKDownload

<rdar://problem/8752204>
WK2 Context Menus - "Save linked file" support

  • Shared/ContextMenuState.h: Added.

Add a ContextMenuState struct which contains state for context menus.

  • UIProcess/API/C/WKContext.cpp:

(WKContextDownloadURLRequest):
Call WebContext::download.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::download):
Send a DownloadRequest message to the web process.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showContextMenu):
Set the active context menu state.

(WebKit::WebPageProxy::contextMenuItemSelected):
Handle ContextMenuItemTagDownloadImageToDisk and ContextMenuItemTagDownloadLinkToDisk by calling
WebContext::Download, passing the respective URLs.

  • UIProcess/WebPageProxy.messages.in:

ShowContextMenu now takes state as well.

  • WebProcess/WebCoreSupport/WebContextMenuClient.cpp:

(WebKit::WebContextMenuClient::downloadURL):
Assert that this is never reached; downloads are handled in the UI process.

  • WebProcess/WebPage/WebContextMenu.cpp:

(WebKit::WebContextMenu::show):
Pass the context menu state along when sending the ShowContextMenu message.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::downloadRequest):
Call the shared DownloadManager.

  • WebProcess/WebProcess.messages.in:

Add DownloadRequest message.

  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Add ContextMenuState.h.

6:33 PM Changeset in webkit [75127] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-01-05 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

fix message container selector for code review tool
​https://bugs.webkit.org/show_bug.cgi?id=51959

  • code-review.js:
6:16 PM Changeset in webkit [75126] by commit-queue@webkit.org
  • 11 edits
    3 adds in trunk

2011-01-05 Helder Correia <​helder@sencha.com>

Reviewed by Ariya Hidayat.

[Qt] Default focus ring is too wide
​https://bugs.webkit.org/show_bug.cgi?id=51854

This is an intermediate step to solve this bug. Use QPalette::Highlight
instead of default half-transparent black as the focus ring color.

  • platform/qt/editing/selection/caret-and-focus-ring-expected.checksum: Added.
  • platform/qt/editing/selection/caret-and-focus-ring-expected.png: Added.
  • platform/qt/editing/selection/caret-and-focus-ring-expected.txt: Added.
  • platform/qt/fast/css/focus-ring-outline-color-expected.checksum:
  • platform/qt/fast/css/focus-ring-outline-color-expected.png:
  • platform/qt/fast/css/focus-ring-outline-offset-expected.checksum:
  • platform/qt/fast/css/focus-ring-outline-offset-expected.png:
  • platform/qt/fast/css/focus-ring-outline-width-expected.checksum:
  • platform/qt/fast/css/focus-ring-outline-width-expected.png:

2011-01-05 Helder Correia <​helder@sencha.com>

Reviewed by Ariya Hidayat.

[Qt] Default focus ring is too wide
​https://bugs.webkit.org/show_bug.cgi?id=51854

This is an intermediate step to solve this bug. Use QPalette::Highlight
instead of default half-transparent black as the focus ring color.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::drawFocusRingForPath):
  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::platformFocusRingColor):
  • platform/qt/RenderThemeQt.h:
6:15 PM Changeset in webkit [75125] by eric@webkit.org
  • 3 edits in trunk/Tools

2011-01-05 Eric Seidel <​eric@webkit.org>

Unreviewed, just fixing one more log error from my previous python patch.

Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
​https://bugs.webkit.org/show_bug.cgi?id=51802

webkit-patch failure-reason was logging about parsing errors
due to my misunderstanding of how BeautifulSoup.findAll worked.

Fixed, and added a unit test.

  • Scripts/webkitpy/common/net/layouttestresults.py:
  • Scripts/webkitpy/common/net/layouttestresults_unittest.py:
6:04 PM Changeset in webkit [75124] by benjamin.poulain@nokia.com
  • 4 edits in trunk/Tools

2011-01-05 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
​https://bugs.webkit.org/show_bug.cgi?id=51951

Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
to create new window from WebKit.

  • MiniBrowser/qt/BrowserWindow.cpp: (newPageFunction): (BrowserWindow::BrowserWindow): (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class (BrowserWindow::newWindow): (BrowserWindow::updateUserAgentList): (BrowserWindow::showUserAgentDialog):
  • MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to define the type of the backing store used for new windows.
  • MiniBrowser/qt/main.cpp: (main):
5:38 PM Changeset in webkit [75123] by Laszlo Gombos
  • 2 edits in trunk/WebKit2

2011-01-05 Laszlo Gombos <Laszlo Gombos>

Unreviewed build fix.

[Qt] [Symbian] Fix building NPAPI support

NPEvent is mapped to QAction on Symbian. QAction has no
default constructor, so toNP() fails to build. Add a case for
Symbian behind the OS(SYMBIAN) guard.

  • WebProcess/Plugins/Netscape/qt/NetscapePluginQt.cpp: (WebKit::toNP):
5:28 PM Changeset in webkit [75122] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit2

2011-01-05 Jeff Miller <​jeffm@apple.com>

Reviewed by Dan Bernstein.

Copy WKImageCG.h to include\WebKit2 in build output
​https://bugs.webkit.org/show_bug.cgi?id=51944

  • win/WebKit2Generated.make: Add xcopy command to copy WKImageCG.h.
5:26 PM Changeset in webkit [75121] by beidson@apple.com
  • 8 edits in trunk/WebKit2

Part of <rdar://problem/8261624> and ​https://bugs.webkit.org/show_bug.cgi?id=47355
Change WebKit2 session restoring to restore the full back/forward list

Reviewed by Sam Weinig.

Add a new message to tell the WebProcess to restore a session state:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::restoreSession):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in: Add the new message, AND fix the intentional misspellings.


Also, Sam sucks.

Change WebProcess back/forward list item ids to be odd (UIProcess's will be even):

  • WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit::generateHistoryItemID):

Provide accessors to the entries in the list to pass to the WebProcess:

  • UIProcess/WebBackForwardList.h:

(WebKit::WebBackForwardList::entries):
(WebKit::WebBackForwardList::currentIndex):

Add decoding of the saved back/forward list itmes (we already encode them):

  • UIProcess/cf/WebBackForwardListCF.cpp:

(WebKit::generateWebBackForwardItemID):
(WebKit::WebBackForwardList::restoreFromCFDictionaryRepresentation):

Instead of loading the current URL, pass the entire last back to the WebProcess:

  • UIProcess/cf/WebPageProxyCF.cpp:

(WebKit::WebPageProxy::restoreFromSessionStateData):

5:22 PM Changeset in webkit [75120] by simonjam@chromium.org
  • 6 edits
    2 adds in trunk

2011-01-05 James Simonsen <​simonjam@chromium.org>

Reviewed by Darin Fisher.

[Web Timing] requestStart and responseStart should be available even if the document is still loading
​https://bugs.webkit.org/show_bug.cgi?id=51368

  • http/tests/misc/webtiming-slow-load-expected.txt: Added.
  • http/tests/misc/webtiming-slow-load.php: Added.

2011-01-05 James Simonsen <​simonjam@chromium.org>

Reviewed by Darin Fisher.

[Web Timing] requestStart and responseStart should be available even if the document is still loading
​https://bugs.webkit.org/show_bug.cgi?id=51368

Test: http/tests/misc/webtiming-slow-load.php

  • page/PerformanceTiming.cpp: (WebCore::getPossiblySkewedTimeInKnownRange): Handle case where response is not yet complete. (WebCore::PerformanceTiming::resourceLoadTimeRelativeToAbsolute): Use full upper bound.
4:41 PM Changeset in webkit [75119] by Girish Ramakrishnan
  • 2 edits in trunk/WebKit/qt

[Qt] QML WebView does not transfer focus to underlying QGraphicsWebView

QML WebView creates QGraphicsWebView as it's child. The WebView is not
setup as a focus proxy of the QGraphicsWebView. Thus, even though the
WebView gets focus, the QGraphicsWebView does not get focus.
In QML, focus proxies or "focus scopes" are created using FocusScope.
This change makes WebView a FocusScope and sets the focus on the
QGraphicsWebView.

Reviewed by Simon Hausmann.
Acked by Aaron Kennedy <​aaron.kennedy@nokia.com>

​https://bugs.webkit.org/show_bug.cgi?id=51094

  • declarative/qdeclarativewebview.cpp:

(QDeclarativeWebView::init):

4:37 PM Changeset in webkit [75118] by crogers@google.com
  • 6 edits
    3 adds in trunk

2011-01-05 Chris Rogers <​crogers@google.com>

Reviewed by Darin Fisher.

Add WebKitClient::createAudioDevice() for Chromium port of web audio API
​https://bugs.webkit.org/show_bug.cgi?id=51424

  • WebKit.gyp:
  • public/WebAudioDevice.h: Added. (WebKit::WebAudioDevice::RenderCallback::~RenderCallback): (WebKit::WebAudioDevice::~WebAudioDevice):
  • public/WebKitClient.h: (WebKit::WebKitClient::createAudioDevice):
  • src/AudioDestinationChromium.cpp: Added. (WebCore::AudioDestination::create): (WebCore::AudioDestinationChromium::AudioDestinationChromium): (WebCore::AudioDestinationChromium::~AudioDestinationChromium): (WebCore::AudioDestinationChromium::start): (WebCore::AudioDestinationChromium::stop): (WebCore::AudioDestination::hardwareSampleRate): (WebCore::AudioDestinationChromium::render):
  • src/AudioDestinationChromium.h: Added. (WebCore::AudioDestinationChromium::isPlaying): (WebCore::AudioDestinationChromium::sampleRate):

2011-01-05 Chris Rogers <​crogers@google.com>

Reviewed by Darin Fisher.

Add WebKitClient::createAudioDevice() for Chromium port of web audio API
​https://bugs.webkit.org/show_bug.cgi?id=51424

No new tests since audio API is not yet implemented.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
4:32 PM Changeset in webkit [75117] by beidson@apple.com
  • 4 edits
    2 adds in trunk/WebKit2

​https://bugs.webkit.org/show_bug.cgi?id=51953
Add a "SessionState" object for IPC messaging.

Reviewed by Darin Adler.

This object includes all data necessary to restore a session state;
For now, this is just the back/forward list to restore.

  • Shared/SessionState.cpp: Added.

(WebKit::SessionState::SessionState):
(WebKit::SessionState::encode):
(WebKit::SessionState::decode):

  • Shared/SessionState.h: Added.

(WebKit::SessionState::list):
(WebKit::SessionState::currentIndex):

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
4:28 PM Changeset in webkit [75116] by tkent@chromium.org
  • 7 edits
    2 adds in trunk/LayoutTests

2011-01-05 Kent Tamura <​tkent@chromium.org>

Unreviewed, test expectation update.

Rebaseline of renderer-destruction-by-invalidateSelection-crash.html

  • platform/chromium-linux/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.checksum:
  • platform/chromium-linux/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
  • platform/chromium-mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png: Added.
  • platform/chromium-win/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.checksum:
  • platform/chromium-win/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
  • platform/chromium-win/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/chromium/test_expectations.txt:
4:17 PM Changeset in webkit [75115] by andersca@apple.com
  • 2 edits in trunk/WebCore

Try again.

  • WebCore.exp.in:
4:10 PM Changeset in webkit [75114] by eric@webkit.org
  • 16 edits in trunk/Tools

2011-01-05 Eric Seidel <​eric@webkit.org>

Reviewed by Ojan Vafai.

commit-queue should report failure type when reporting flaky tests
​https://bugs.webkit.org/show_bug.cgi?id=51900

This patch was a ridiculous amount of plumbing. In the end I like
the NRWT-style TestResult class even less. But now we're passing
a list of TestResult objects from the queue to the FlakyTestReporter.
Thus the FlakyTestReporter can more easily report what type of failure
occurred.

In the process, I found that I was not alone in finding TestResult
cumbersome to use. A bunch of code was trying to create a TestResult
object with default values. However since the constructor didn't make
this easy, some places were getting it wrong (including the TestResult unit test)!
I've fixed the TestResult constructor to have default values for non-essential
arguments.

  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
  • Scripts/webkitpy/common/net/layouttestresults.py:
  • Scripts/webkitpy/common/net/layouttestresults_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_results.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  • Scripts/webkitpy/tool/bot/commitqueuetask.py:
  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
  • Scripts/webkitpy/tool/bot/flakytestreporter.py:
  • Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
3:57 PM Changeset in webkit [75113] by eric@webkit.org
  • 3 edits in trunk/Tools

2011-01-05 Eric Seidel <​eric@webkit.org>

Unreviewed.

Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
​https://bugs.webkit.org/show_bug.cgi?id=51802

Add another unit test to cover a previously missing import.

  • Scripts/webkitpy/common/net/layouttestresults.py:
  • Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3:48 PM Changeset in webkit [75112] by andersca@apple.com
  • 2 edits in trunk/WebCore

Attempt to fix Leopard build.

  • WebCore.exp.in:
3:38 PM Changeset in webkit [75111] by commit-queue@webkit.org
  • 3 edits
    25 adds in trunk/LayoutTests

2011-01-05 Jenn Braithwaite <​jennb@chromium.org>

Reviewed by Adam Barth.

fast/encoding/parser-tests.html is slow on debug builds
​https://bugs.webkit.org/show_bug.cgi?id=51721

Break up parser tests to run 10 tests per batch.

  • fast/encoding/parser-tests-10-expected.txt: Added.
  • fast/encoding/parser-tests-10.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
  • fast/encoding/parser-tests-100-expected.txt: Added.
  • fast/encoding/parser-tests-100.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
  • fast/encoding/parser-tests-110-expected.txt: Added.
  • fast/encoding/parser-tests-110.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
  • fast/encoding/parser-tests-120-expected.txt: Added.
  • fast/encoding/parser-tests-120.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
  • fast/encoding/parser-tests-20-expected.txt: Added.
  • fast/encoding/parser-tests-20.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
  • fast/encoding/parser-tests-30-expected.txt: Added.
  • fast/encoding/parser-tests-30.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
  • fast/encoding/parser-tests-40-expected.txt: Added.
  • fast/encoding/parser-tests-40.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
  • fast/encoding/parser-tests-50-expected.txt: Added.
  • fast/encoding/parser-tests-50.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
  • fast/encoding/parser-tests-60-expected.txt: Added.
  • fast/encoding/parser-tests-60.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
  • fast/encoding/parser-tests-70-expected.txt: Added.
  • fast/encoding/parser-tests-70.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
  • fast/encoding/parser-tests-80-expected.txt: Added.
  • fast/encoding/parser-tests-80.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
  • fast/encoding/parser-tests-90-expected.txt: Added.
  • fast/encoding/parser-tests-90.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
  • fast/encoding/parser-tests-expected.txt:
  • fast/encoding/parser-tests.html:
  • fast/encoding/resources/parser-tests.js: Added.
3:31 PM Changeset in webkit [75110] by mihaip@chromium.org
  • 2 edits in trunk/Tools

2011-01-05 Mihai Parparita <​mihaip@chromium.org>

Reviewed by David Levin.

Add ​mihaip@chromium.org as a reviewer
​https://bugs.webkit.org/show_bug.cgi?id=51966

Add myself as a reviewer.

  • Scripts/webkitpy/common/config/committers.py:
3:20 PM WebKit Team edited by mihaip@chromium.org
(diff)
3:18 PM Changeset in webkit [75109] by hans@chromium.org
  • 4 edits in trunk/LayoutTests

2011-01-05 Hans Wennborg <​hans@chromium.org>

Reviewed by Jeremy Orlow.

[Chromium] storage/indexeddb/objectstore-basics.html is flaky after r74266
​https://bugs.webkit.org/show_bug.cgi?id=51731

Fix the layout test by using a known-good date value rather than
new Date(), which sometimes causes the test to fail.

(The underlying reason for failing to store certain Date values
should of course be fixed too, but that will come in a later patch.)

  • platform/chromium/test_expectations.txt:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
3:17 PM Changeset in webkit [75108] by evan@chromium.org
  • 4 edits
    2 adds in trunk/WebCore

2011-01-05 Evan Martin <​evan@chromium.org>

Reviewed by Tony Chang.

[chromium] refactor complex text on Linux
​https://bugs.webkit.org/show_bug.cgi?id=51956

Pull out TextRunWalker from FontLinux.cpp. Put it in its own file.
Rename it to ComplexTextController, to match platform/graphics/mac
more closely.

No tests because the change is just renaming a class.

  • WebCore.gyp/WebCore.gyp:
  • platform/graphics/chromium/ComplexTextControllerLinux.cpp: Added. (WebCore::ComplexTextController::ComplexTextController): (WebCore::ComplexTextController::~ComplexTextController): (WebCore::ComplexTextController::isWordBreak): (WebCore::ComplexTextController::determineWordBreakSpacing): (WebCore::ComplexTextController::setPadding): (WebCore::ComplexTextController::reset): (WebCore::ComplexTextController::setBackwardsIteration): (WebCore::ComplexTextController::nextScriptRun): (WebCore::ComplexTextController::widthOfFullRun): (WebCore::ComplexTextController::setupFontForScriptRun): (WebCore::ComplexTextController::allocHarfbuzzFont): (WebCore::ComplexTextController::deleteGlyphArrays): (WebCore::ComplexTextController::createGlyphArrays): (WebCore::ComplexTextController::resetGlyphArrays): (WebCore::ComplexTextController::shapeGlyphs): (WebCore::ComplexTextController::setGlyphXPositions): (WebCore::ComplexTextController::normalizeSpacesAndMirrorChars): (WebCore::ComplexTextController::getNormalizedTextRun):
  • platform/graphics/chromium/ComplexTextControllerLinux.h: Added. (WebCore::ComplexTextController::setWordSpacingAdjustment): (WebCore::ComplexTextController::setLetterSpacingAdjustment): (WebCore::ComplexTextController::letterSpacing): (WebCore::ComplexTextController::setXOffsetToZero): (WebCore::ComplexTextController::rtl): (WebCore::ComplexTextController::glyphs): (WebCore::ComplexTextController::length): (WebCore::ComplexTextController::xPositions): (WebCore::ComplexTextController::advances): (WebCore::ComplexTextController::width): (WebCore::ComplexTextController::logClusters): (WebCore::ComplexTextController::numCodePoints): (WebCore::ComplexTextController::fontPlatformDataForScriptRun): (WebCore::ComplexTextController::isCodepointSpace):
  • platform/graphics/chromium/FontLinux.cpp: (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::glyphIndexForXPositionInScriptRun): (WebCore::Font::offsetForPositionForComplexText): (WebCore::Font::selectionRectForComplexText):
2:46 PM Changeset in webkit [75107] by Laszlo Gombos
  • 2 edits in trunk/WebKit2

2011-01-05 Laszlo Gombos <Laszlo Gombos>

Unreviewed build fix.

Include unistd.h for _exit() for non-Windows builds.

Build break noticed on QtWebkit Symbian builds.

  • Shared/ChildProcess.cpp:
2:20 PM Changeset in webkit [75106] by levin@chromium.org
  • 8 edits in trunk/WebKit/chromium

2011-01-05 David Levin <​levin@chromium.org>

Reviewed by Darin Fisher.

[chromium] WEBKIT_API and styling fixes for the chromium api.
​https://bugs.webkit.org/show_bug.cgi?id=51863

Removed some incorrect uses of WEBKIT_API.
Fixed some abbreviations by making them whole words.

  • public/WebAnimationController.h: Removed WEBKIT_API from virtual functions.
  • public/WebFormElement.h: Removed WEBKIT_API from inline functions and fixed some abbreviations. (WebKit::WebFormElement::WebFormElement): (WebKit::WebFormElement::operator=): (WebKit::WebFormElement::assign):
  • public/WebIDBDatabaseError.h: Ditto. (WebKit::WebIDBDatabaseError::WebIDBDatabaseError): (WebKit::WebIDBDatabaseError::operator=):
  • public/WebInputElement.h: Ditto. (WebKit::WebInputElement::WebInputElement): (WebKit::WebInputElement::operator=): (WebKit::WebInputElement::assign):
  • public/WebLabelElement.h: Ditto. (WebKit::WebLabelElement::WebLabelElement): (WebKit::WebLabelElement::operator=): (WebKit::WebLabelElement::assign):
  • public/WebOptionElement.h: Ditto. (WebKit::WebOptionElement::WebOptionElement): (WebKit::WebOptionElement::operator=): (WebKit::WebOptionElement::assign):
  • public/WebSelectElement.h: Ditto (and minor spacing cleanup). (WebKit::WebSelectElement::WebSelectElement): (WebKit::WebSelectElement::operator=): (WebKit::WebSelectElement::assign):
2:00 PM Changeset in webkit [75105] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-05 Stephen White <​senorblanco@chromium.org>

Unreviewed; test expectations update..

Fix the expectations for the hyphenation tests on chromium-win.

  • platform/chromium/test_expectations.txt:
1:56 PM Changeset in webkit [75104] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-05 Stephen White <​senorblanco@chromium.org>

Unreviewed; test expectations fix.

  • platform/chromium/test_expectations.txt: Add expectations for new tests introduced by r75097.
1:55 PM Changeset in webkit [75103] by psolanki@apple.com
  • 6 edits
    4 deletes in trunk/WebCore

2011-01-05 Pratik Solanki <​psolanki@apple.com>

Reviewed by Darin Adler.

Merge cf and mac header files with same name
​https://bugs.webkit.org/show_bug.cgi?id=51916

Since most of the code in the header files is identical, we can merge them and have #if
USE(CFNETWORK) to separate out the network specific parts.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/network/cf/AuthenticationChallenge.h: (WebCore::AuthenticationChallenge::sender): (WebCore::AuthenticationChallenge::nsURLAuthenticationChallenge):
  • platform/network/cf/ResourceError.h: (WebCore::ResourceError::ResourceError):
  • platform/network/cf/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest):
  • platform/network/cf/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse):
  • platform/network/mac/AuthenticationChallenge.h: Removed.
  • platform/network/mac/ResourceError.h: Removed.
  • platform/network/mac/ResourceRequest.h: Removed.
  • platform/network/mac/ResourceResponse.h: Removed.
1:48 PM Changeset in webkit [75102] by andersca@apple.com
  • 2 edits in trunk/WebCore

Implement word transformation
​https://bugs.webkit.org/show_bug.cgi?id=51943

Reviewed by Adele Peterson.

Export Editor functions needed by WebKit2.

  • WebCore.exp.in:
1:45 PM Changeset in webkit [75101] by simonjam@chromium.org
  • 2 edits in trunk/Tools

2011-01-05 James Simonsen <​simonjam@chromium.org>

Unreviewed. Adding myself to the list of committers.

  • Scripts/webkitpy/common/config/committers.py:
1:45 PM Changeset in webkit [75100] by beidson@apple.com
  • 4 edits
    2 moves in trunk/WebKit2

​https://bugs.webkit.org/show_bug.cgi?id=51949
Make WebBackForwardListItem shared, and add encoders and decoders

Reviewed by Darin Adler.

  • Shared/WebBackForwardListItem.cpp: Copied from UIProcess/WebBackForwardListItem.cpp.

(WebKit::WebBackForwardListItem::encode):
(WebKit::WebBackForwardListItem::decode):

  • Shared/WebBackForwardListItem.h: Copied from UIProcess/WebBackForwardListItem.h.
  • UIProcess/WebBackForwardListItem.cpp: Removed.
  • UIProcess/WebBackForwardListItem.h: Removed.
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
1:34 PM Changeset in webkit [75099] by eric@webkit.org
  • 3 edits in trunk/Tools

2011-01-05 Eric Seidel <​eric@webkit.org>

Unreviewed.

Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
​https://bugs.webkit.org/show_bug.cgi?id=51802

Fix two exceptions seen on the bots after my original commit.

  • Scripts/webkitpy/common/net/layouttestresults.py:
  • Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1:22 PM Changeset in webkit [75098] by andersca@apple.com
  • 13 edits in trunk/WebKit2

2011-01-05 Anders Carlsson <​andersca@apple.com>

Reviewed by Adele Peterson.

Implement word transformation
​https://bugs.webkit.org/show_bug.cgi?id=51943

Export Editor functions needed by WebKit2.

  • WebCore.exp.in:

2011-01-05 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Handle smart insert/delete
​https://bugs.webkit.org/show_bug.cgi?id=51946

  • Shared/WebPageCreationParameters.cpp: (WebKit::WebPageCreationParameters::encode): (WebKit::WebPageCreationParameters::decode):
  • Shared/WebPageCreationParameters.h: Add isSmartInsertDelete enabled.
  • UIProcess/API/mac/WKView.mm: (-[WKView validateUserInterfaceItem:]): Handle toggleSmartInsertDelete:.

(-[WKView toggleSmartInsertDelete:]):
Toggle the smart insert/delete state.

  • UIProcess/TextChecker.h: Add isSmartInsertDeleteEnabled and setSmartInsertDeleteEnabled.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::WebPageProxy): Initialize m_isSmartInsertDeleteEnabled.

(WebKit::WebPageProxy::contextMenuItemSelected):
Handle ContextMenuItemTagSmartCopyPaste.

(WebKit::WebPageProxy::setSmartInsertDeleteEnabled):
Update the state and send a SetSmartInsertDeleteEnabled message.

(WebKit::WebPageProxy::creationParameters):
Initialize isSmartInsertDeleteEnabled.

  • UIProcess/WebPageProxy.h: (WebKit::WebPageProxy::isSmartInsertDeleteEnabled): Return m_isSmartInsertDeleteEnabled.
  • UIProcess/mac/TextCheckerMac.mm: (WebKit::TextChecker::isSmartInsertDeleteEnabled): (WebKit::TextChecker::setSmartInsertDeleteEnabled): Store and fetch the smart insert delete state.
  • WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::smartInsertDeleteEnabled): Call WebPage::isSmartInsertDeleteEnabled.
  • WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm: (WebKit::WebEditorClient::toggleSmartInsertDelete): Assert that this is never called.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage): Initialize m_isSmartInsertDeleteEnabled
  • WebProcess/WebPage/WebPage.h: (WebKit::WebPage::isSmartInsertDeleteEnabled): (WebKit::WebPage::setSmartInsertDeleteEnabled): Add getter and setter.
  • WebProcess/WebPage/WebPage.messages.in: Add SetSmartInsertDeleteEnabled message.
1:06 PM Changeset in webkit [75097] by Simon Fraser
  • 9 edits
    8 adds in trunk

2011-01-05 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt.

Implement repeating CSS3 gradients
​https://bugs.webkit.org/show_bug.cgi?id=51843

Add support for repeating gradients, via the new gradient functions
-webkit-repeating-linear-gradient and -webkit-repeating-radial-gradient.

Tests: fast/gradients/css3-repeating-linear-gradients.html

fast/gradients/css3-repeating-radial-gradients.html

  • css/CSSGradientValue.h: (WebCore::CSSGradientValue::isRepeating): Accessor for whethe the gradient repeats. (WebCore::CSSGradientValue::CSSGradientValue): Pass CSSGradientRepeat in. (WebCore::CSSLinearGradientValue::create): Pass CSSGradientRepeat. (WebCore::CSSLinearGradientValue::CSSLinearGradientValue): Ditto (WebCore::CSSRadialGradientValue::create): Ditto. (WebCore::CSSRadialGradientValue::CSSRadialGradientValue): Ditto.
  • css/CSSGradientValue.cpp: (WebCore::CSSGradientValue::addStops): Pass maxLengthForRepeat, which is used for repeating radial gradients. Add code to repeat the stops, adding stops before the start, and after the end until the 0-N range is covered, where N is large enough to ensure the box is covered. Fix an issue with repeating gradients where if both stops were < 0, it would fail to clamp them to 0.

(WebCore::CSSLinearGradientValue::cssText): Output strings for repeating gradients.
(WebCore::CSSLinearGradientValue::createGradient): maxExtent for linear gradients is 1,
because they are guaranteed to fill the box already.
(WebCore::CSSRadialGradientValue::cssText): Output strings for repeating gradients.
(WebCore::CSSRadialGradientValue::createGradient): Compute the distance to the furthest
corner in order to inform addStops() how much additional extent is required.

  • css/CSSParser.cpp: (WebCore::CSSParser::parseDeprecatedGradient): Old gradients never repeat. (WebCore::CSSParser::parseLinearGradient): Pass down CSSGradientRepeat. (WebCore::CSSParser::parseRadialGradient): Ditto. (WebCore::CSSParser::isGeneratedImageValue): Add repeating gradient functions. (WebCore::CSSParser::parseGeneratedImage): Ditto.
  • css/CSSParser.h: Pass CSSGradientRepeat to gradient functions.
  • platform/graphics/cg/GradientCG.cpp: Remove unused #include.
12:50 PM Changeset in webkit [75096] by senorblanco@chromium.org
  • 3 edits in trunk/LayoutTests

2011-01-05 Stephen White <​senorblanco@chromium.org>

Unreviewed; test expectations fix.

  • platform/chromium/test_expectations.txt: Add a few failing tests to chromium's test expectations file.
  • platform/chromium-gpu/test_expectations.txt: Mark the shadow-offset tests as crashing on win debug (GPU). Remove a duplicate MAC expectation.
12:33 PM Changeset in webkit [75095] by Martin Robinson
  • 2 edits in trunk/WebCore

2011-01-05 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Ariya Hidayat.

ContextShadow::blurLayerImage() not endian-safe
​https://bugs.webkit.org/show_bug.cgi?id=51822

Correct the channel map in ContextShadow to reflect the different
ordering of pixels on processors with different endianness.

No new tests. This is covered by the existing shadow tests. It was
not discovered, because all of the bots using ContextShadow are
little-endian.

  • platform/graphics/ContextShadow.cpp: (WebCore::ContextShadow::blurLayerImage): Initialize the channel mapping based on machine endianness.
12:26 PM Changeset in webkit [75094] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Fix Windows build.

  • WebProcess/WebPage/WebPage.cpp:
12:19 PM Changeset in webkit [75093] by andersca@apple.com
  • 8 edits in trunk/WebKit2

2011-01-05 Anders Carlsson <​andersca@apple.com>

Reviewed by Adele Peterson.

Implement word transformation
​https://bugs.webkit.org/show_bug.cgi?id=51943

Export Editor functions needed by WebKit2.

  • WebCore.exp.in:

2011-01-05 Anders Carlsson <​andersca@apple.com>

Reviewed by Adele Peterson.

Implement word transformation
​https://bugs.webkit.org/show_bug.cgi?id=51943

  • UIProcess/API/mac/WKView.mm: (-[WKView validateUserInterfaceItem:]): Handle the word transformation selectors.

(-[WKView uppercaseWord:]):
(-[WKView lowercaseWord:]):
(-[WKView capitalizeWord:]):
Call down to the WebPageProxy.

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::uppercaseWord): (WebKit::WebPageProxy::lowercaseWord): (WebKit::WebPageProxy::capitalizeWord): Send messages to the WebPage.
  • WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm: (WebKit::changeWordCase): Add helper function.

(WebKit::WebEditorClient::uppercaseWord):
(WebKit::WebEditorClient::lowercaseWord):
(WebKit::WebEditorClient::capitalizeWord):
Call helper function.

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::changeSpellingToWord): Call replaceSelectionWithText.

(WebKit::WebPage::uppercaseWord):
(WebKit::WebPage::lowercaseWord):
(WebKit::WebPage::capitalizeWord):
Call the editor functions.

(WebKit::WebPage::replaceSelectionWithText):
New helper function that replaces the selected string with another string.

  • WebProcess/WebPage/WebPage.messages.in: Add new messages.
12:03 PM Changeset in webkit [75092] by mihaip@chromium.org
  • 2 edits in trunk/WebCore

2011-01-05 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Nate Chapin.

[Chromium] Crash when drawing PDF plug-in scrollbars
​https://bugs.webkit.org/show_bug.cgi?id=51942

Pepper plug-in scrollbars don't have a parent, guard against that before
seeing if the parent is a FrameView.

Not testable via layout tests, verified fix by hand.

  • platform/chromium/ScrollbarThemeChromiumMac.mm: (WebCore::ScrollbarThemeChromiumMac::paint):
11:59 AM Changeset in webkit [75091] by mnaganov@chromium.org
  • 2 edits in branches/chromium/597/WebCore/inspector/front-end

Revert 73364 - Merge 73229 - 2010-12-02 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Fix heap snapshots loading. Loading is now
conducted by the Profiles panel which prevents accidental
simultaneous attempts to load the same profile several times in
parallel.

​https://bugs.webkit.org/show_bug.cgi?id=50427

  • inspector/front-end/HeapSnapshotView.js: (WebInspector.HeapSnapshotView.prototype._loadProfile): (WebInspector.HeapSnapshotView.prototype.processLoadedSnapshot):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.loadHeapSnapshot): (WebInspector.ProfilesPanel.prototype.addHeapSnapshotChunk): (WebInspector.ProfilesPanel.prototype.finishHeapSnapshot):

TBR=​mnaganov@chromium.org
Review URL: ​http://codereview.chromium.org/5657001

TBR=​yurys@chromium.org
Review URL: ​http://codereview.chromium.org/6048013

11:59 AM Changeset in webkit [75090] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/552

Merge 75082

BUG=68439

11:48 AM Changeset in webkit [75089] by ap@apple.com
  • 3 edits in trunk/WebKit2

Reviewed by Anders Carlsson.

​https://bugs.webkit.org/show_bug.cgi?id=51935
Add WebKit2 API for largest frame

  • UIProcess/API/C/WKPage.cpp: (WKPageGetFrameSetLargestFrame):
  • UIProcess/API/C/WKPage.h:
11:45 AM Changeset in webkit [75088] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-05 Stephen White <​senorblanco@chromium.org>

Unreviewed; test expectations fix.

Update chromium GPU test_expectations.txt file to match the
layout of the CPU results more closely.

  • platform/chromium-gpu/test_expectations.txt:
11:44 AM Changeset in webkit [75087] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2011-01-05 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Anders Carlsson.

Remove entries from WebKit2 skipped list that no longer exist
​https://bugs.webkit.org/show_bug.cgi?id=51936

  • platform/mac-wk2/Skipped:
11:41 AM Changeset in webkit [75086] by andersca@apple.com
  • 14 edits in trunk/WebKit2

2011-01-05 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

More work on spelling
​https://bugs.webkit.org/show_bug.cgi?id=51939

  • UIProcess/API/mac/WKView.mm: (-[WKView validateUserInterfaceItem:]): Handle changeSpelling: as well.

(-[WKView showGuessPanel:]):
Show or hide the guess panel.

(-[WKView checkSpelling:]):
Pass false to advanceToNextMisspelling.

(-[WKView changeSpelling:]):
Call changeSpellingToWord.

  • UIProcess/TextChecker.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::WebPageProxy): Initialize m_pendingLearnOrIgnoreWordMessageCount.

(WebKit::WebPageProxy::contextMenuItemSelected):
Handle smart toggles directly in the UI process, keep track of whether
we're asked to learn or ignore a word.

(WebKit::WebPageProxy::advanceToNextMisspelling):
Pass the boolean through.

(WebKit::WebPageProxy::changeSpellingToWord):
Send a ChangeSpellingToWord message.

(WebKit::WebPageProxy::learnWord):
(WebKit::WebPageProxy::ignoreWord):
Check that we do have a pending learn or ignore word message. Call through to
the text checker.

(WebKit::WebPageProxy::processDidCrash):
Reset the m_pendingLearnOrIgnoreWordMessageCount variable.

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in: Add new messages.
  • UIProcess/mac/TextCheckerMac.mm: (WebKit::TextChecker::learnWord): (WebKit::TextChecker::ignoreWord): Implement in terms of NSSpellChecker.
  • WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::ignoreWordInSpellDocument): (WebKit::WebEditorClient::learnWord): Send IgnoreWord and LearnWord messages.
  • WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm: (WebKit::WebEditorClient::toggleAutomaticQuoteSubstitution): (WebKit::WebEditorClient::toggleAutomaticLinkDetection): (WebKit::WebEditorClient::toggleAutomaticDashSubstitution): (WebKit::WebEditorClient::toggleAutomaticTextReplacement): Add assertions.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::advanceToNextMisspelling): Pass the bool along to the Editor.

(WebKit::WebPage::changeSpellingToWord):
Replace the selected text.

  • WebProcess/WebPage/WebPage.messages.in: Add new ChangeSpellingToWord message and add a boolean to AdvanceToNextMisspelling.
11:23 AM Changeset in webkit [75085] by bfulgham@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed build fix.

  • wtf/Encoder.h: Add <stdint.h> include for systems that

do not natively know about uint8_t, etc.

11:15 AM BuildingQtOnWindows edited by dbates@webkit.org
Removed "C Program Files\SlikSvn\bin\" from Path since this path is … (diff)
11:09 AM Changeset in webkit [75084] by inferno@chromium.org
  • 2 edits in trunk/WebCore

2011-01-05 Abhishek Arya <​inferno@chromium.org>

Unreviewed.

Update FIXME comment to sound better. Also initialize the block to fix compile.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::removeChild):
11:03 AM Changeset in webkit [75083] by bweinstein@apple.com
  • 3 edits in trunk/LayoutTests

Land failing Windows results after r75031. Fixing the tests is being tracked by
​https://bugs.webkit.org/show_bug.cgi?id=51912.

  • platform/win/accessibility/document-role-expected.txt:
  • platform/win/accessibility/selection-and-focus-expected.txt:
10:58 AM Changeset in webkit [75082] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2011-01-05 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dave Hyatt.

Do not merge anonymous blocks when one of them is the one getting removed.
​https://bugs.webkit.org/show_bug.cgi?id=51919

Test: fast/block/merge-anonymous-block-remove-child-crash.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::removeChild):

2011-01-05 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dave Hyatt.

Tests that we do not crash when trying to merge two anonymous blocks,
one of which is getting removed.
​https://bugs.webkit.org/show_bug.cgi?id=51919

  • fast/block/merge-anonymous-block-remove-child-crash-expected.txt: Added.
  • fast/block/merge-anonymous-block-remove-child-crash.html: Added.
10:48 AM Changeset in webkit [75081] by Martin Robinson
  • 2 edits in trunk/WebKit/gtk

2011-01-05 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha.

Build fix for GTK+ 3.x. Remove the call to gtk_range_set_update_policy.
GTK+ 3.x has removed this method and the default in GTK+ 2.x is continuous,
so this call is unnecessary.

  • WebCoreSupport/FullscreenVideoController.cpp: (FullscreenVideoController::createHud): Remove call to gtk_range_set_update_policy().
10:32 AM Changeset in webkit [75080] by rniwa@webkit.org
  • 5 edits in trunk/WebCore

2011-01-05 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

ApplyStyleCommand::applyRelativeFontStyleChange should take EditingStyle*
​https://bugs.webkit.org/show_bug.cgi?id=50641

Modified applyRelativeFontStyleChange to take EditingStyle instead of CSSMutableStyleDeclaration.
Also extracted the logic to obtain the font size delta from ApplyStyleCommand to EditingStyle.
The font size delta is now stored as a member variable of EditingStyle as supposed to a property
in CSSMutableStyleDeclration as soon as EditingStyle is instantiated.

No new tests are added since this is a refactoring.

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::doApply): Calls applyRelativeFontStyleChange. (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Takes EditingStyle.
  • editing/ApplyStyleCommand.h:
  • editing/EditingStyle.cpp: (WebCore::EditingStyle::EditingStyle): Initializes m_fontSizeDelta. (WebCore::EditingStyle::init): Ditto. (WebCore::EditingStyle::extractFontSizeDelta): Extracted from applyRelativeFontStyleChange. (WebCore::EditingStyle::isEmpty): Takes care of m_fontSizeDelta. (WebCore::EditingStyle::setStyle): Calls extractFontSizeDelta. (WebCore::EditingStyle::overrideWithStyle): Ditto. (WebCore::EditingStyle::clear): Initializes m_fontSizeDelta. (WebCore::EditingStyle::copy): Calls extractFontSizeDelta.
  • editing/EditingStyle.h: (WebCore::EditingStyle::fontSizeDelta): Added. (WebCore::EditingStyle::hasFontSizeDelta): Added.
  • editing/Editor.h:
10:28 AM Changeset in webkit [75079] by andersca@apple.com
  • 6 edits in trunk/WebKit2

2011-01-05 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Keep track of active text substitution preferences
​https://bugs.webkit.org/show_bug.cgi?id=51931

  • Shared/TextCheckerState.h:
  • UIProcess/API/mac/WKView.mm: (-[WKView validateUserInterfaceItem:]): Handle new selectors, mostly copied from WebKit1 code.

(-[WKView orderFrontSubstitutionsPanel:]):
Open the substitution panel.

(-[WKView isAutomaticQuoteSubstitutionEnabled]):
(-[WKView setAutomaticQuoteSubstitutionEnabled:]):
(-[WKView toggleAutomaticQuoteSubstitution:]):
(-[WKView isAutomaticDashSubstitutionEnabled]):
(-[WKView setAutomaticDashSubstitutionEnabled:]):
(-[WKView toggleAutomaticDashSubstitution:]):
(-[WKView isAutomaticLinkDetectionEnabled]):
(-[WKView setAutomaticLinkDetectionEnabled:]):
(-[WKView toggleAutomaticLinkDetection:]):
(-[WKView isAutomaticTextReplacementEnabled]):
(-[WKView setAutomaticTextReplacementEnabled:]):
(-[WKView toggleAutomaticTextReplacement:]):
Call the text checker, and update the state in the web process if needed.

  • UIProcess/TextChecker.h: Add new flags.
  • UIProcess/mac/TextCheckerMac.mm: (WebKit::initializeState): Initialize flags from user defaults.

(WebKit::TextChecker::setAutomaticQuoteSubstitutionEnabled):
(WebKit::TextChecker::setAutomaticDashSubstitutionEnabled):
(WebKit::TextChecker::setAutomaticLinkDetectionEnabled):
(WebKit::TextChecker::setAutomaticTextReplacementEnabled):
Update and save the flags.

  • WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm: (WebKit::WebEditorClient::isAutomaticQuoteSubstitutionEnabled): (WebKit::WebEditorClient::isAutomaticLinkDetectionEnabled): (WebKit::WebEditorClient::isAutomaticDashSubstitutionEnabled): (WebKit::WebEditorClient::isAutomaticTextReplacementEnabled): Get the text checker state.
10:16 AM Changeset in webkit [75078] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/qt

2011-01-05 Yi Shen <​yi.4.shen@nokia.com>

Reviewed by Andreas Kling.

[Qt] Sync qwebkitplatformplugin.h in the plugin example
​https://bugs.webkit.org/show_bug.cgi?id=51882

Make examples/platformplugin/qwebkitplatformplugin.h exactly the same
as the one in the Api folder.

  • examples/platformplugin/qwebkitplatformplugin.h:
10:03 AM Changeset in webkit [75077] by mitz@apple.com
  • 15 edits in trunk

<rdar://problem/8799835> hyphenate-character: auto should fall back to hyphen-minus if the primary font lacks a hyphen glyph
​https://bugs.webkit.org/show_bug.cgi?id=51915

Reviewed by Darin Adler.

WebCore:

This changes the results of existing tests in fast/text.

  • platform/graphics/Font.h:
  • platform/graphics/FontFastPath.cpp:

(WebCore::Font::primaryFontHasGlyphForCharacter): Added.

  • rendering/style/RenderStyle.cpp:
  • platform/graphics/qt/FontQt.cpp:

(WebCore::Font::primaryFontHasGlyphForCharacter): Added a stub.
(WebCore::RenderStyle::hyphenString): For hyphenate-character: auto, return a
hyphen only if the primary font has a hyphen glyph, and otherwise return a
hyphen-minus.

LayoutTests:

  • platform/mac/fast/text/basic/014-expected.checksum:
  • platform/mac/fast/text/basic/014-expected.png:
  • platform/mac/fast/text/basic/014-expected.txt:
  • platform/mac/fast/text/capitalize-boundaries-expected.checksum:
  • platform/mac/fast/text/capitalize-boundaries-expected.png:
  • platform/mac/fast/text/capitalize-boundaries-expected.txt:
  • platform/mac/fast/text/midword-break-after-breakable-char-expected.checksum:
  • platform/mac/fast/text/midword-break-after-breakable-char-expected.png:
  • platform/mac/fast/text/midword-break-after-breakable-char-expected.txt:
9:55 AM Changeset in webkit [75076] by Laszlo Gombos
  • 2 edits in trunk/WebCore

2011-01-05 Laszlo Gombos <Laszlo Gombos>

Reviewed by Ariya Hidayat.

[Qt] [Symbian] Make CONFIG-=def_files the default configuration for trunk builds
​https://bugs.webkit.org/show_bug.cgi?id=51888

Overrule Qt's default from qconfig.pri for non-production builds so
that CONFIG(def_files) evaluates to false and QtWebKit trunk builds succeed.

No new tests as there is no new functionality.

  • WebCore.pro:
9:50 AM Changeset in webkit [75075] by mitz@apple.com
  • 2 edits in trunk/WebKit2

Cleaned up com.apple.WebProcess.sb

Rubber-stamped by Darin Adler.

  • WebProcess/com.apple.WebProcess.sb: Moved the closing parentheses of multi-line blocks to

their own lines. Changed to use WebKit-standard 4-space indentation.

9:37 AM Changeset in webkit [75074] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-01-05 Kundu Suchismita <​suchi.kundu@nokia.com>

Reviewed by Andreas Kling.

[Qt]Add local storage settings to QtTestBrowser command line arguments
​https://bugs.webkit.org/show_bug.cgi?id=51750

  • QtTestBrowser/main.cpp: (LauncherApplication::handleUserOptions): Local storage settings can be enable form command line arguments for QtTestBrowser.
9:33 AM Changeset in webkit [75073] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2011-01-05 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r74778.
​http://trac.webkit.org/changeset/74778
​https://bugs.webkit.org/show_bug.cgi?id=51930

Android and QtWebKit-V8 uses V8DOMWindowShell::setContext.
(Requested by bbandix on #webkit).

  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::setContext):
  • bindings/v8/V8DOMWindowShell.h:
9:31 AM Changeset in webkit [75072] by Chris Fleizach
  • 5 edits in trunk

GTK: AX: DRT needs to use correct root object method.
​https://bugs.webkit.org/show_bug.cgi?id=51911

Reviewed by Martin Robinson.

Tools:

  • DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:

(AccessibilityController::rootElement):

WebKit/gtk:

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::getRootAccessibleElement):
(DumpRenderTreeSupportGtk::getFocusedAccessibleElement):

  • WebCoreSupport/DumpRenderTreeSupportGtk.h:
9:27 AM Changeset in webkit [75071] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/WebCore

2011-01-05 Yi Shen <​yi.4.shen@nokia.com>

Reviewed by Andreas Kling.

[Qt] Animated GIF images does not animate 10x as expected by default.
​https://bugs.webkit.org/show_bug.cgi?id=36818

Add a test animated GIF which should be displayed 2 times and stop.

  • manual-tests/animated-gif-looping.html:
  • manual-tests/resources/animated-2x.gif: Added.
9:23 AM Changeset in webkit [75070] by Carlos Garcia Campos
  • 4 edits
    2 adds in trunk/WebCore

2011-01-05 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Fork code of ScrollbarThemeGtk that will differ for GTK+ 3
​https://bugs.webkit.org/show_bug.cgi?id=51923

Split out pieces of ScrollbarThemeGtk into ScrollbarThemeGtk2 and
ScrollbarThemeGtk3 that will differ between GTK+ 2 and GTK+ 3.

No new tests. This should not change functionality.

  • GNUmakefile.am: Add ScrollbarThemeGtk2.cpp and ScrollbarThemeGtk3.cpp
  • platform/gtk/ScrollbarThemeGtk.cpp: (WebCore::ScrollbarThemeGtk::updateScrollbarsFrameThickness):
  • platform/gtk/ScrollbarThemeGtk.h:
  • platform/gtk/ScrollbarThemeGtk2.cpp: Added. (WebCore::ScrollbarThemeGtk::updateThemeProperties): (WebCore::ScrollbarThemeGtk::paintTrackBackground): (WebCore::ScrollbarThemeGtk::paintScrollbarBackground): (WebCore::ScrollbarThemeGtk::paintThumb): (WebCore::ScrollbarThemeGtk::paintButton):
  • platform/gtk/ScrollbarThemeGtk3.cpp: Added. (WebCore::ScrollbarThemeGtk::updateThemeProperties): (WebCore::ScrollbarThemeGtk::paintTrackBackground): (WebCore::ScrollbarThemeGtk::paintScrollbarBackground): (WebCore::ScrollbarThemeGtk::paintThumb): (WebCore::ScrollbarThemeGtk::paintButton):
8:55 AM Changeset in webkit [75069] by Patrick Gansterer
  • 6 edits in trunk

2011-01-05 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[CMake] Fix the usage of SOURCE_GROUP
​https://bugs.webkit.org/show_bug.cgi?id=51739

  • Source/cmake/WebKitMacros.cmake:

2011-01-05 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[CMake] Fix the usage of SOURCE_GROUP
​https://bugs.webkit.org/show_bug.cgi?id=51739

  • CMakeLists.txt:

2011-01-05 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[CMake] Fix the usage of SOURCE_GROUP
​https://bugs.webkit.org/show_bug.cgi?id=51739

  • CMakeLists.txt:
8:37 AM Changeset in webkit [75068] by abecsi@webkit.org
  • 4 edits in trunk

2011-01-05 Andras Becsi <​abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt][V8] Fix the build after recent changes.

  • pcre/pcre.pri: Correct the path after Source was introduced.

2011-01-05 Andras Becsi <​abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt][V8] Fix the build after recent changes.

No new tests needed.

  • WebCore.pro: Add missing files, and remove obsolete ones.
8:28 AM Changeset in webkit [75067] by Patrick Gansterer
  • 2 edits in trunk

2011-01-05 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[WINCE] Remove CMake warning
​https://bugs.webkit.org/show_bug.cgi?id=51921

  • Source/cmake/WebKitHelpers.cmake:
7:51 AM Changeset in webkit [75066] by commit-queue@webkit.org
  • 8 edits in trunk/WebCore

2011-01-05 Yong Li <​yoli@rim.com>

Reviewed by Adam Barth.

Suspend HTMLParserScheduler when page load is deferred to
avoid potential JS re-entrancy. Otherwise, when JS execution is triggered
from an external script or by events, and is blocked by a modal dialog,
WebKit can parse more HTML source and also start another JS execution.

​https://bugs.webkit.org/show_bug.cgi?id=48077

Test case: WebCore/manual-tests/bugzilla-48077.html.

  • dom/DocumentParser.cpp: (WebCore::DocumentParser::suspendScheduledTasks): (WebCore::DocumentParser::resumeScheduledTasks):
  • dom/DocumentParser.h:
  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::suspendScheduledTasks): (WebCore::HTMLDocumentParser::resumeScheduledTasks):
  • html/parser/HTMLParserScheduler.cpp: (WebCore::HTMLParserScheduler::HTMLParserScheduler): (WebCore::HTMLParserScheduler::suspend): (WebCore::HTMLParserScheduler::resume):
  • html/parser/HTMLParserScheduler.h: (WebCore::HTMLParserScheduler::isScheduledForResume):
  • page/PageGroupLoadDeferrer.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
7:48 AM Changeset in webkit [75065] by Simon Hausmann
  • 2 edits in trunk/WebCore

[GStreamer] MediaPlayerPrivateGStreamer::totalBytes() does not work reliably
​https://bugs.webkit.org/show_bug.cgi?id=51926

Reviewed by Kenneth Rohde Christiansen, Gustavo Noronha Silva

Work around potential upstream bug: Querying a GstBin for the duration,
will forward the query to all sink children. Our WebKitWebSrc however
is a bin with only source children, therefore the query fails. Until
this is changed upstream, this patch works around it as follows,
based on suggestion by Philippe Normand and Sebastian Dröge:

When the initial query fails, attempt the same query on all source
pads and take the maximum length reported.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::totalBytes):

7:24 AM Changeset in webkit [75064] by hans@chromium.org
  • 2 edits in trunk/WebKit/chromium

2011-01-05 Hans Wennborg <​hans@chromium.org>

Reviewed by David Levin.

[Chromium] WebIDBKey clean-up
​https://bugs.webkit.org/show_bug.cgi?id=51925

Remove constructors that are no longer used since the
Chromium side has been updated.

  • public/WebIDBKey.h:
6:11 AM Changeset in webkit [75063] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Based on idea from Péter Gál.

Patch by Gabor Rapcsanyi <​rgabor@inf.u-szeged.hu> on 2011-01-05
Rubber-stamped by Csaba Osztrogonác.

  • Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
5:25 AM Changeset in webkit [75062] by Csaba Osztrogonác
  • 4 edits in trunk/Tools

sheriff-bot should be able to do multi-revision rollouts
​https://bugs.webkit.org/show_bug.cgi?id=51176

Patch by Gabor Rapcsanyi <​rgabor@inf.u-szeged.hu> on 2011-01-05
Reviewed by Adam Barth.

  • Scripts/webkitpy/tool/bot/irc_command.py:
  • Scripts/webkitpy/tool/bot/sheriff.py:
  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
5:13 AM WinCE edited by Patrick Gansterer
(diff)
5:04 AM Changeset in webkit [75061] by Philippe Normand
  • 2 edits in trunk/WebCore

2011-01-05 Philippe Normand <​pnormand@igalia.com>

Rubber-stamped by Eric Seidel.

[GStreamer] build fails with gstreamer core 0.10.31 and -plugins-base 0.10.30
​https://bugs.webkit.org/show_bug.cgi?id=51810

Based on a patch by Mart Raudsepp.

No new tests, build fix only.

  • platform/graphics/gstreamer/GStreamerGWorld.cpp: (WebCore::GStreamerGWorld::setWindowOverlay): Use the new xoverlay API if the GST_CHECK_PLUGINS_BASE_VERSION macro is defined. It was introduced in same version as the xoverlay API change.
4:39 AM Changeset in webkit [75060] by eric@webkit.org
  • 6 edits in trunk/Tools

2011-01-05 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

queues.webkit.org should have per-bot status pages
​https://bugs.webkit.org/show_bug.cgi?id=51906

Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
statuses from a single queue. Now that we have many bots servicing
some queues (commit-queue, win-ews, etc.) its easy to have the messages
you care about scroll off the end of the 15-message limit on the main page.

Eventually we should probably rename /queue-status to /queue or /queues,
but that's fodder for another patch.

  • QueueStatusServer/handlers/queuestatus.py:
  • QueueStatusServer/index.yaml:
  • QueueStatusServer/main.py:
  • QueueStatusServer/templates/includes/singlequeuestatus.html:
    • This probably should use a custom filter instead of hard-coding the URL scheme here, but I couldn't figure out how to easily create such a filter. Most filters work with "strings" so we can't pass the status object. We could add a method to the status object and call that, but that seemed a bit strange too.
  • QueueStatusServer/templates/queuestatus.html:
4:11 AM Changeset in webkit [75059] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

2011-01-05 Leo Yang <​leo.yang@torchmobile.com.cn>

Reviewed by Dirk Schulze.

Malformed SVG causes crash in updateContainerOffset
​https://bugs.webkit.org/show_bug.cgi?id=44610

Test case for recursive svg <use>.
This test case passes if no crash occurs.

  • svg/custom/recursive-use-expected.txt: Added.
  • svg/custom/recursive-use.svg: Added.

2011-01-05 Leo Yang <​leo.yang@torchmobile.com.cn>

Reviewed by Dirk Schulze.

Malformed SVG causes crash in updateContainerOffset
​https://bugs.webkit.org/show_bug.cgi?id=44610

We should check recursive <use> at the begining of
WebCore::SVGUseElement::buildInstanceTree instead
of at the end of it because the target element's
children may cause infinite recursive <use>.

Test: svg/custom/recursive-use.svg

  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::buildInstanceTree): (WebCore::SVGUseElement::hasCycleUseReferencing):
  • svg/SVGUseElement.h:
4:03 AM Changeset in webkit [75058] by Antti Koivisto
  • 2 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=51907
Style selector should only be recalculated when the pending sheet count goes to zero

Reviewed by Dan Bernstein.

Shark says this is a significant performance improvement on some sites with lots of stylesheets.

  • dom/Document.cpp:

(WebCore::Document::removePendingSheet):

3:52 AM Changeset in webkit [75057] by Antti Koivisto
  • 3 edits in trunk/LayoutTests

Not reviewed.

Update a pixel test result for ​https://bugs.webkit.org/show_bug.cgi?id=8852.

  • platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.checksum:
  • platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
2:45 AM Changeset in webkit [75056] by Carlos Garcia Campos
  • 4 edits in trunk/WebCore

2011-01-05 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Use GtkStyleContext to get platform colors
​https://bugs.webkit.org/show_bug.cgi?id=51830

Use GtkStyleContext API to get platform colors when building with
GTK+ 3.x.

No new tests. This should not change functionality.

  • platform/graphics/Color.h: Add specialized constructor for GdkRGBA.
  • platform/graphics/gtk/ColorGtk.cpp: (WebCore::Color::Color): (WebCore::Color::operator GdkRGBA):
  • platform/gtk/RenderThemeGtk3.cpp: (WebCore::RenderThemeGtk::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeGtk::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeGtk::platformActiveSelectionForegroundColor): (WebCore::RenderThemeGtk::platformInactiveSelectionForegroundColor): (WebCore::RenderThemeGtk::activeListBoxSelectionBackgroundColor): (WebCore::RenderThemeGtk::inactiveListBoxSelectionBackgroundColor): (WebCore::RenderThemeGtk::activeListBoxSelectionForegroundColor): (WebCore::RenderThemeGtk::inactiveListBoxSelectionForegroundColor): (WebCore::RenderThemeGtk::systemColor):
2:18 AM Changeset in webkit [75055] by Carlos Garcia Campos
  • 2 edits in trunk/WebCore

2011-01-05 Carlos Garcia Campos <​cgarcia@igalia.com>

Unreviewed. Build fix for GTK when using gtk+-3 after r75009.

  • platform/gtk/RenderThemeGtk3.cpp: (WebCore::RenderThemeGtk::getStockIcon): Use adoptGRef instead of adoptGRefPtr which doesn't exist.
1:32 AM Changeset in webkit [75054] by ap@apple.com
  • 10 edits in trunk

2011-01-05 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=51903
Tell UI process which subframe is largest

  • WebCore.exp.in: Exported FrameView::contentsSize().

2011-01-05 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=51903
Tell UI process which subframe is largest

  • UIProcess/WebPageProxy.h: (WebKit::WebPageProxy::frameSetLargestFrame): Remember largest frame in frameset pages.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::frameDidBecomeFrameSet): Reset stored largest frame if main frame changes to a frameset or back. (WebKit::WebPageProxy::frameSetLargestFrameChanged): Store a new largest frame when notified of a change.
  • UIProcess/WebPageProxy.messages.in: Added FrameSetLargestFrameChanged.
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::area): Calculate area of a frame. (WebKit::findLargestFrameInFrameSet): Find largest first-level subframe in a frameset page. (WebKit::WebChromeClient::contentsSizeChanged): Recalculate largest frame, and notify UI process if it changed.
  • WebProcess/WebCoreSupport/WebChromeClient.h: Store the latest largest frame.
  • WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::size):
  • WebProcess/WebPage/WebFrame.h: Expose frame size.
1:12 AM Changeset in webkit [75053] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

2011-01-05 Carlos Garcia Campos <​cgarcia@igalia.com>

Unreviewed. Adding myself to the list of committers.

  • Scripts/webkitpy/common/config/committers.py:
12:06 AM WebKit Team edited by Carlos Garcia Campos
Add myself to committer list (diff)

Jan 4, 2011:

11:45 PM Changeset in webkit [75052] by Chris Fleizach
  • 2 edits in trunk/WebCore

2011-01-04 Chris Fleizach <Chris Fleizach>

Unreviewed. GTK build fix.

WK2: Support Accessibility
​https://bugs.webkit.org/show_bug.cgi?id=51859

  • page/FrameView.cpp: (WebCore::FrameView::axObjectCache):
11:37 PM Changeset in webkit [75051] by sfalken@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Build fix. Update path to FindSafari after source code reorganization.

11:33 PM Changeset in webkit [75050] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-01-04 Koan-Sin Tan <​koansin.tan@gmail.com>

Reviewed by David Levin.

check-webkit-style treated some macros with parentheses after #elif as function calls
​https://bugs.webkit.org/show_bug.cgi?id=51695

Ingore function call space checking in any preprocessor directives
(things starting with #). Change search() to match() because
preprocessor directives are supposed to be in the beginning of lines.

  • Scripts/webkitpy/style/checkers/cpp.py:
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
11:24 PM Changeset in webkit [75049] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-04 Kent Tamura <​tkent@chromium.org>

Unreviewed, test expectation update.

insecure-css-in-main-frame.html is flaky on Chromium-linux too.

  • platform/chromium/test_expectations.txt:
11:21 PM Changeset in webkit [75048] by tkent@chromium.org
  • 8 edits in trunk/WebCore

2011-01-04 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r74992.
​http://trac.webkit.org/changeset/74992
​https://bugs.webkit.org/show_bug.cgi?id=51917

Crash in HTMLDocumentParser::suspendScheduledTasks()
(Requested by tkent on #webkit).

  • dom/DocumentParser.cpp:
  • dom/DocumentParser.h:
  • html/parser/HTMLDocumentParser.cpp:
  • html/parser/HTMLDocumentParser.h:
  • html/parser/HTMLParserScheduler.cpp: (WebCore::HTMLParserScheduler::HTMLParserScheduler):
  • html/parser/HTMLParserScheduler.h: (WebCore::HTMLParserScheduler::isScheduledForResume):
  • page/PageGroupLoadDeferrer.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
10:24 PM Changeset in webkit [75047] by benjamin.poulain@nokia.com
  • 6 edits in trunk

2011-01-04 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] [WK2] Add support for non-trivial context menu action
​https://bugs.webkit.org/show_bug.cgi?id=51902

Fix the preprocessor guard for ContextMenuItemTagSelectAll in
the implementation of ContextMenuController::contextMenuItemSelected(). The guard was
inconsistent with what is defined in ContextMenuItem.h.

  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected):

2011-01-04 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] [WK2] Add support for non-trivial context menu action
​https://bugs.webkit.org/show_bug.cgi?id=51902

Implement a call back from the QAction triggered in the UIProcess to the
action in WebProcess.

A few basic actions have been implemented based on this feature.

  • UIProcess/API/qt/qwkpage.cpp: (contextMenuActionForWebAction): (QWKPage::triggerAction): (QWKPage::action):
  • UIProcess/API/qt/qwkpage.h:
  • UIProcess/qt/WebContextMenuProxyQt.cpp: (WebKit::webActionForContextMenuAction):
9:48 PM Changeset in webkit [75046] by Laszlo Gombos
  • 3 edits in trunk/WebKit2

2011-01-04 Siddharth Mathur <​siddharth.mathur@nokia.com>

Reviewed by Laszlo Gombos.

Include unistd.h for sleep() for non-Windows builds.

  • WebProcess/WebProcess.cpp:
  • WebProcess/qt/WebProcessMainQt.cpp:
9:30 PM Changeset in webkit [75045] by tonyg@chromium.org
  • 5 edits in trunk/WebCore

2011-01-04 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Ryosuke Niwa.

Avoid manual ref/deref in AsyncScriptRunner by using PendingScript
​https://bugs.webkit.org/show_bug.cgi?id=51723

ScriptElement should also be able to keep its Element+CachedScript in
a PendingScript, and then executeScriptSoon can accept a PendingScript.
Once HTMLScriptRunner, ScriptElement, and AsyncScriptRunner all use
PendingScripts, then generic request and execute which operate on
PendingScripts can be factored out to avoid code duplicate that we have.

No new tests because no new functionality.

  • dom/AsyncScriptRunner.cpp: (WebCore::AsyncScriptRunner::~AsyncScriptRunner): (WebCore::AsyncScriptRunner::executeScriptSoon): (WebCore::AsyncScriptRunner::timerFired):
  • dom/AsyncScriptRunner.h:
  • dom/PendingScript.h: Add ctor which sets element and cachedScript. Rename adoptElement->setElement.
  • dom/HTMLScriptRunner.cpp: (WebCore::HTMLScriptRunner::requestPendingScript):
8:07 PM Changeset in webkit [75044] by bweinstein@apple.com
  • 2 edits in trunk/WebKit2

Windows build fix. Change the inline type of consumePermanently.

  • Shared/SandboxExtension.h:

(WebKit::SandboxExtension::consumePermanently):

7:30 PM Changeset in webkit [75043] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-04 Kent Tamura <​tkent@chromium.org>

Unreviewed, test expectation update

  • slow-loading-image-in-pattern.html had a wrong expectation for Chromium-win.
  • insecure-css-in-main-frame.html is flaky on Chromium-win?
  • platform/chromium/test_expectations.txt:
7:10 PM Changeset in webkit [75042] by andersca@apple.com
  • 7 edits in trunk/WebKit2

<rdar://problem/8821203> Sandbox violations trying to access the Safari cache

Reviewed by Dan Bernstein.

  • Shared/SandboxExtension.h:

(WebKit::SandboxExtension::consumePermanently):
New function which consumes a sandbox extension and destroys it, making it impossible
to later revoke it.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
Encode and decode the path extension handle.

  • Shared/mac/SandboxExtensionMac.mm:

(WebKit::SandboxExtension::createHandle):
Standardize the path before creating the handle.

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformInitializeWebProcess):
Create a sandbox extension for the cache path.

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::platformInitializeWebProcess):
Consume the sandbox extension.

7:08 PM Changeset in webkit [75041] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Fix build.

  • UIProcess/mac/TextCheckerMac.mm:

(WebKit::TextChecker::getGuessesForWord):

7:08 PM Changeset in webkit [75040] by commit-queue@webkit.org
  • 12 edits in trunk

2011-01-04 Jeff Miller <​jeffm@apple.com>

Reviewed by Darin Adler.

Member variable and method naming cleanup to be consistent with WebKit2.
​https://bugs.webkit.org/show_bug.cgi?id=51228

  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::eventActivatedView): Rename activatedWebView() to didActivateWebView().
  • platform/PlatformMouseEvent.h: Rename m_activatedWebView to m_didActivateWebView.

(WebCore::PlatformMouseEvent::PlatformMouseEvent):
Initialize platform-specific member variables in PlatformMouseEvent constructors.

(WebCore::PlatformMouseEvent::didActivateWebView):
Rename activatedWebView() to didActivateWebView().

  • platform/win/PlatformMouseEventWin.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent): Rename m_activatedWebView to m_didActivateWebView.

2011-01-04 Jeff Miller <​jeffm@apple.com>

Reviewed by Darin Adler.

Mouse events in WebKit2 on Windows need to know whether the click activated the WebView to match WebKit1 behavior.
​https://bugs.webkit.org/show_bug.cgi?id=51228

  • Shared/WebEvent.h: (WebKit::WebMouseEvent::didActivateWebView): Add m_didActivateWebView to WebMouseEvent on Windows.
  • Shared/WebEventConversion.cpp: (WebKit::WebKit2PlatformMouseEvent::WebKit2PlatformMouseEvent): Propagate whether the click activated the WebView when converting to a PlatformMouseEvent.
  • Shared/WebMouseEvent.cpp: (WebKit::WebMouseEvent::WebMouseEvent): Add m_didActivateWebView to WebMouseEvent on Windows.

(WebKit::WebMouseEvent::encode):
(WebKit::WebMouseEvent::decode):
Encode and decode new m_didActivateWebView member variable.

  • Shared/win/WebEventFactory.cpp: (WebKit::WebEventFactory::createWebMouseEvent):
  • Shared/win/WebEventFactory.h: Add didActivateWebView parameter to createWebMouseEvent().
  • UIProcess/win/WebView.cpp: (WebKit::WebView::wndProc): (WebKit::WebView::WebView): (WebKit::WebView::onMouseEvent):
  • UIProcess/win/WebView.h: (WebKit::WebView::setWasActivatedByMouseEvent): Keep track of whether the click activated the WebView.
6:21 PM Changeset in webkit [75039] by yael.aharon@nokia.com
  • 3 edits
    2 adds in trunk

2011-01-04 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Darin Adler.

CSS3 :nth-child selector and valid whitespace test fails
​https://bugs.webkit.org/show_bug.cgi?id=36279

  • fast/css/css3-nth-space-expected.txt: Added.
  • fast/css/css3-nth-space.html: Added.

2011-01-04 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Darin Adler.

CSS3 :nth-child selector and valid whitespace test fails
​https://bugs.webkit.org/show_bug.cgi?id=36279

Teach the tokenizer to allow white spaces around [+/-] signs in nth constructs.

Test: fast/css/css3-nth-space.html

  • css/tokenizer.flex:
6:16 PM Changeset in webkit [75038] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Reviewed and landed by Anders Carlsson.

Patch by Ivan Krstić <​ike@apple.com> on 2011-01-04
<rdar://problem/8602585>
<rdar://problem/8711641>

  • WebProcess/com.apple.WebProcess.sb:

Fix a misplaced right parenthesis and add a new system path regex.

6:13 PM Changeset in webkit [75037] by andersca@apple.com
  • 18 edits in trunk/WebKit2

2011-01-04 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

More work on spelling and grammar
​https://bugs.webkit.org/show_bug.cgi?id=51910

  • Scripts/webkit2/messages.py: Add special case for WebCore::TextCheckingResult.
  • Shared/NotImplemented.h: Fix macro so that defining DISABLE_NOT_IMPLEMENTED_WARNINGS to 0 will enable the warnings.


  • Shared/WebCoreArgumentCoders.h: Add argument coders for WebCore::GrammarDetail and WebCore::TextCheckingResult.
  • UIProcess/API/mac/WKView.mm: (-[WKView checkSpelling:]): Call advanceToNextMisspelling.
  • UIProcess/TextChecker.h: Add new NSSpellChecker wrappers.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::WebPageProxy): Initialize the new member variables.

(WebKit::WebPageProxy::~WebPageProxy):
Call TextChecker::closeSpellDocumentWithTag.

(WebKit::WebPageProxy::advanceToNextMisspelling):
Send the AdvanceToNextMisspelling message.

(WebKit::WebPageProxy::spellDocumentTag):
Create a spell document tag if necessary.

(WebKit::WebPageProxy::checkTextOfParagraph):
(WebKit::WebPageProxy::updateSpellingUIWithMisspelledWord):
(WebKit::WebPageProxy::getGuessesForWord):
Call the TextChecker.


  • UIProcess/WebPageProxy.messages.in: Add new messages.
  • UIProcess/mac/TextCheckerMac.mm: (WebKit::TextChecker::uniqueSpellDocumentTag): (WebKit::TextChecker::closeSpellDocumentWithTag): (WebKit::TextChecker::checkTextOfParagraph): (WebKit::TextChecker::updateSpellingUIWithMisspelledWord): (WebKit::TextChecker::getGuessesForWord): Add NSSpellChecker wrappers.
  • UIProcess/qt/TextCheckerQt.cpp:
  • UIProcess/win/TextCheckerWin.cpp: Add stubs.
  • WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::isContinuousSpellCheckingEnabled): (WebKit::WebEditorClient::isGrammarCheckingEnabled): Get the text checking state from the web process.

(WebKit::WebEditorClient::updateSpellingUIWithMisspelledWord):
(WebKit::WebEditorClient::getGuessesForWord):
Proxy calls to the UI process.

  • WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm: (WebKit::WebEditorClient::isAutomaticSpellingCorrectionEnabled):


(WebKit::WebEditorClient::checkTextOfParagraph):
Proxy calls to the UI process.

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::advanceToNextMisspelling): Call the frame.
  • WebProcess/WebPage/WebPage.messages.in: Add AdvanceToNextMisspelling message.
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::initializeWebProcess): Set the text checker state.
6:09 PM Changeset in webkit [75036] by commit-queue@webkit.org
  • 6 edits in trunk/Tools

2011-01-04 Søren Gjesse <​sgjesse@chromium.org>

Reviewed by Tony Chang.

Change the --multi-load test option to --stress-opt
​https://bugs.webkit.org/show_bug.cgi?id=50751

  • DumpRenderTree/chromium/DumpRenderTree.cpp: (runTest): (main):
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell):
  • DumpRenderTree/chromium/TestShell.h: (TestShell::stressOpt): (TestShell::setStressOpt): (TestShell::stressDeopt): (TestShell::setStressDeopt): (TestShell::javaScriptFlags): (TestShell::setJavaScriptFlags):
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
5:45 PM Changeset in webkit [75035] by tonyg@chromium.org
  • 4 edits in trunk/LayoutTests

2011-01-04 Tony Gentilcore <​tonyg@chromium.org>

Unreviewed expectations update.

Fix text metrics for "You should not see this at all" message
​https://bugs.webkit.org/show_bug.cgi?id=51909

  • http/tests/misc/acid3-expected.checksum:
  • http/tests/misc/acid3-expected.png:
  • platform/chromium/test_expectations.txt:
5:36 PM Changeset in webkit [75034] by Chris Fleizach
  • 4 edits in trunk

Unreviewed. Build fix.

WK2: Support Accessibility
​https://bugs.webkit.org/show_bug.cgi?id=51859

WebCore:

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

(fallbackObject):

WebKit2:

  • WebProcess/WebPage/mac/AccessibilityWebPageObject.mm:
5:21 PM Changeset in webkit [75033] by Chris Fleizach
  • 2 edits in trunk/WebKit2

Unreviewed. Build fix.

WK2: Support Accessibility
​https://bugs.webkit.org/show_bug.cgi?id=51859

  • WebProcess/WebPage/mac/AccessibilityWebPageObject.mm:

(-[AccessibilityWebPageObject accessibilityAttributeValue:]):

5:14 PM Changeset in webkit [75032] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2011-01-04 Cosmin Truta <​ctruta@chromium.org>

Reviewed by Eric Seidel.

[chromium] PNG compression settings optimized for speed
​https://bugs.webkit.org/show_bug.cgi?id=51719

Although Z_HUFFMAN_ONLY is the fastest on hard-to-compress images,
it is also the slowest, by a wide margin, on easy-to-compress images.
Use a more balanced configuration, based on the libpng compression defaults,
but with a faster compression level (3 instead of 6), and a faster filter
("sub" instead of "all").

No change in behaviour, so no new tests.

  • platform/image-encoders/skia/PNGImageEncoder.cpp: (WebCore::PNGImageEncoder::encode):
5:07 PM Changeset in webkit [75031] by Chris Fleizach
  • 69 edits
    6 adds in trunk

WK2: Support Accessibility
​https://bugs.webkit.org/show_bug.cgi?id=51859

Reviewed by Sam Weinig.

Tools:

Use rootObject() method to get top of accessibility tree.

  • DumpRenderTree/mac/AccessibilityControllerMac.mm:

(AccessibilityController::focusedElement):
(AccessibilityController::rootElement):

WebCore:

WK2 doesn't use platform scroll views anymore. Accessibility code
needs to have its own scroll views.

Test: platform/mac/accessibility/webkit-scrollarea.html

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::AXObjectCache):
(WebCore::AXObjectCache::get):
(WebCore::AXObjectCache::getOrCreate):
(WebCore::AXObjectCache::rootObject):
(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::handleScrollbarUpdate):

  • accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::handleScrollbarUpdate):

  • accessibility/AccessibilityARIAGrid.h:
  • accessibility/AccessibilityAllInOne.cpp:
  • accessibility/AccessibilityImageMapLink.cpp:
  • accessibility/AccessibilityImageMapLink.h:
  • accessibility/AccessibilityListBoxOption.cpp:
  • accessibility/AccessibilityListBoxOption.h:
  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::updateChildrenIfNecessary):
(WebCore::AccessibilityObject::elementAccessibilityHitTest):
(WebCore::AccessibilityObject::axObjectCache):
(WebCore::AccessibilityObject::focusedUIElement):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isAccessibilityScrollView):
(WebCore::AccessibilityObject::isScrollView):
(WebCore::AccessibilityObject::canSetNumericValue):
(WebCore::AccessibilityObject::scrollBar):
(WebCore::AccessibilityObject::size):
(WebCore::AccessibilityObject::setValue):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::parentObject):
(WebCore::AccessibilityRenderObject::accessibilityHitTest):
(WebCore::AccessibilityRenderObject::updateChildrenIfNecessary):
(WebCore::AccessibilityRenderObject::addChildren):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/AccessibilityScrollView.cpp: Added.

(WebCore::AccessibilityScrollView::AccessibilityScrollView):
(WebCore::AccessibilityScrollView::create):
(WebCore::AccessibilityScrollView::scrollBar):
(WebCore::AccessibilityScrollView::children):
(WebCore::AccessibilityScrollView::updateChildrenIfNecessary):
(WebCore::AccessibilityScrollView::removeChildScrollbar):
(WebCore::AccessibilityScrollView::addChildScrollbar):
(WebCore::AccessibilityScrollView::addChildren):
(WebCore::AccessibilityScrollView::webAreaObject):
(WebCore::AccessibilityScrollView::accessibilityHitTest):
(WebCore::AccessibilityScrollView::document):
(WebCore::AccessibilityScrollView::elementRect):
(WebCore::AccessibilityScrollView::parentObject):

  • accessibility/AccessibilityScrollView.h: Added.

(WebCore::AccessibilityScrollView::roleValue):
(WebCore::AccessibilityScrollView::scrollView):
(WebCore::AccessibilityScrollView::accessibilityIsIgnored):
(WebCore::AccessibilityScrollView::isAccessibilityScrollView):
(WebCore::toAccessibilityScrollView):

  • accessibility/AccessibilityScrollbar.cpp:

(WebCore::AccessibilityScrollbar::AccessibilityScrollbar):
(WebCore::AccessibilityScrollbar::create):
(WebCore::AccessibilityScrollbar::elementRect):
(WebCore::AccessibilityScrollbar::document):
(WebCore::AccessibilityScrollbar::orientation):
(WebCore::AccessibilityScrollbar::isEnabled):
(WebCore::AccessibilityScrollbar::valueForRange):
(WebCore::AccessibilityScrollbar::setValue):

  • accessibility/AccessibilityScrollbar.h:

(WebCore::AccessibilityScrollbar::setParent):
(WebCore::AccessibilityScrollbar::canSetValueAttribute):
(WebCore::AccessibilityScrollbar::canSetNumericValue):
(WebCore::AccessibilityScrollbar::isAccessibilityScrollbar):
(WebCore::AccessibilityScrollbar::parentObject):
(WebCore::AccessibilityScrollbar::roleValue):

  • accessibility/mac/AccessibilityObjectMac.mm:

(WebCore::AccessibilityObject::accessibilityIgnoreAttachment):

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityAttributeNames]):
(-[AccessibilityObjectWrapper remoteAccessibilityParentObject]):
(-[AccessibilityObjectWrapper position]):
(-[AccessibilityObjectWrapper scrollViewParent]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[AccessibilityObjectWrapper accessibilityHitTest:]):
(-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):

  • dom/Document.cpp:

(WebCore::Document::axObjectCache):

  • loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::accessibilityRemoteObject):

  • loader/FrameLoaderClient.h:
  • page/FrameView.cpp:

(WebCore::FrameView::~FrameView):
(WebCore::FrameView::axObjectCache):

  • page/FrameView.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::setHasHorizontalScrollbar):
(WebCore::ScrollView::setHasVerticalScrollbar):

  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::~Scrollbar):
(WebCore::Scrollbar::scroll):
(WebCore::Scrollbar::axObjectCache):

  • platform/Scrollbar.h:
  • platform/Widget.h:

(WebCore::Widget::axObjectCache):

WebKit/gtk:

Use rootObject() method to get top of ax tree.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::getFocusedAccessibleElement):

  • webkit/webkitwebview.cpp:

(webkit_web_view_get_accessible):

WebKit/mac:

Use rootObject() method to get top of AX tree.

  • WebCoreSupport/WebFrameLoaderClient.h:

(WebFrameLoaderClient::accessibilityRemoteObject):

  • WebView/WebFrame.mm:

(-[WebFrame setAccessibleName:]):
(-[WebFrame accessibilityRoot]):

  • WebView/WebFrameInternal.h:
  • WebView/WebFramePrivate.h:
  • WebView/WebHTMLView.mm:

(-[WebHTMLView accessibilityAttributeValue:]):
(-[WebHTMLView accessibilityFocusedUIElement]):
(-[WebHTMLView accessibilityHitTest:]):
(-[WebHTMLView _accessibilityParentForSubview:]):

WebKit/win:

Use rootObject() method to get the top of the AX tree.

  • AccessibleDocument.cpp:

(AccessibleDocument::AccessibleDocument):

WebKit2:

Implement remote accessibility API to support cross process accessibility
on the Mac platform.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:
  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::accessibilityChildTokenReceived):

  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:contextRef:pageGroupRef:]):
(-[WKView _updateWindowAndViewFrames]):
(-[WKView _setAccessibilityChildToken:]):
(-[WKView accessibilityIsIgnored]):
(-[WKView accessibilityHitTest:]):
(-[WKView accessibilityAttributeValue:]):

  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::ensureWebProcess):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::windowAndViewFramesChanged):
(WebKit::WebPageProxy::didReceiveAccessibilityPageToken):
(WebKit::WebPageProxy::sendAccessibilityPresenterToken):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::accessibilityRemoteObject):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::windowAndViewFramesChanged):

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::accessibilityPosition):

  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/mac/AccessibilityWebPageObject.h: Added.
  • WebProcess/WebPage/mac/AccessibilityWebPageObject.mm: Added.

(-[AccessibilityWebPageObject setWebPage:]):
(-[AccessibilityWebPageObject setRemoteParent:]):
(-[AccessibilityWebPageObject dealloc]):
(-[AccessibilityWebPageObject accessibilityIsIgnored]):
(-[AccessibilityWebPageObject accessibilityAttributeNames]):
(-[AccessibilityWebPageObject accessibilityIsAttributeSettable:]):
(-[AccessibilityWebPageObject accessibilitySetValue:forAttribute:]):
(-[AccessibilityWebPageObject accessibilityActionNames]):
(-[AccessibilityWebPageObject accessibilityChildren]):
(-[AccessibilityWebPageObject accessibilityAttributeValue:]):
(-[AccessibilityWebPageObject accessibilityShouldUseUniqueId]):
(-[AccessibilityWebPageObject accessibilityHitTest:]):
(-[AccessibilityWebPageObject accessibilityFocusedUIElement]):

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::platformInitialize):
(WebKit::WebPage::sendAccessibilityPresenterToken):
(WebKit::WebPage::accessibilityRemoteObject):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

  • WebProcess/WebProcess.h:

(WebKit::WebProcess::presenterApplicationPid):

  • WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain):

LayoutTests:

  • platform/mac/accessibility/webkit-scrollarea-expected.txt: Added.
  • platform/mac/accessibility/webkit-scrollarea.html: Added.
4:53 PM Changeset in webkit [75030] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2011-01-04 W. James MacLean <​wjmaclean@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Add support to compositor to composite to offscreen texture.
​https://bugs.webkit.org/show_bug.cgi?id=50833

A patch to extend compositor to be able to composite into an offscreen texture instead
of just directly to the display buffer. Builds on RenderSurfaceChromium support.
Explicitly resets alpha channel before rendering to display.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::updateAndDrawRootLayer): (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::setCompositeOffscreen): (WebCore::LayerRendererChromium::useRenderSurface): (WebCore::LayerRendererChromium::setScissorToRect):
  • platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::isCompositingOffscreen): (WebCore::LayerRendererChromium::getOffscreenLayerTexture):
4:50 PM Changeset in webkit [75029] by tkent@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-01-04 Kent Tamura <​tkent@chromium.org>

Unreviewed, test expectation update.

Add home-end-expected.txt for Chromium-win again. It's a
platform-dependent text test.

  • platform/chromium-win/editing/selection/home-end-expected.txt: Added.
4:26 PM Changeset in webkit [75028] by jschuh@chromium.org
  • 3 edits
    2 copies in branches/chromium/552

Merge 74779 - 2010-12-29 Justin Schuh <​jschuh@chromium.org>

Reviewed by Darin Adler.

Check SVG element type in FrameView::scrollToAnchor
​https://bugs.webkit.org/show_bug.cgi?id=51718

Test: svg/custom/scroll-to-anchor-in-symbol.svg

  • page/FrameView.cpp: (WebCore::FrameView::scrollToAnchor):

2010-12-29 Justin Schuh <​jschuh@chromium.org>

Reviewed by Darin Adler.

Check SVG element type in FrameView::scrollToAnchor
​https://bugs.webkit.org/show_bug.cgi?id=51718

  • svg/custom/scroll-to-anchor-in-symbol-expected.txt: Added.
  • svg/custom/scroll-to-anchor-in-symbol.svg: Added.

BUG=68178
TBR=​jschuh@chromium.org

4:23 PM Changeset in webkit [75027] by darin@chromium.org
  • 2 edits in trunk/WebKit/chromium

2011-01-04 Darin Fisher <​darin@chromium.org>

Reviewed by David Levin.

Update README file with a description of the WEBKIT_API macro and
guidelines for its usage. Also document the various WEBKIT_USING_*
macros.

​https://bugs.webkit.org/show_bug.cgi?id=51880

  • README:
4:21 PM Changeset in webkit [75026] by jschuh@chromium.org
  • 1 edit in branches/chromium/552/WebCore/svg/SVGLength.cpp

Merge 74788 - 2010-12-30 Justin Schuh <​jschuh@chromium.org>

Reviewed by Dirk Schulze.

Prevent stringToLengthType() from skipping past end-of-string on invalid length unit.
​https://bugs.webkit.org/show_bug.cgi?id=51692

  • svg/SVGLength.cpp: (WebCore::stringToLengthType): (WebCore::SVGLength::setValueAsString):

2010-12-30 Justin Schuh <​jschuh@chromium.org>

Reviewed by Dirk Schulze.

Adding long float string to improve test coverage.
​https://bugs.webkit.org/show_bug.cgi?id=51692

  • svg/dom/length-list-parser.html:
  • svg/dom/length-list-parser-expected.txt:

BUG=68062
TBR=​jschuh@chromium.org

4:17 PM Changeset in webkit [75025] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-04 Kent Tamura <​tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/test_expectations.txt: Fix a syntax error in the previous change
4:09 PM Changeset in webkit [75024] by tkent@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

2011-01-04 Kent Tamura <​tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium-win/editing/selection/home-end-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
4:06 PM Changeset in webkit [75023] by evan@chromium.org
  • 4 edits in trunk

2011-01-04 Evan Martin <​evan@chromium.org>

Reviewed by Tony Chang.

[chromium] depend on harfbuzz explicitly
​https://bugs.webkit.org/show_bug.cgi?id=51895

platform/graphics/chromium uses Harfbuzz directly. Rather than
expecting Skia to adjust the include paths, be explicit about
the dependency.

  • WebCore.gyp/WebCore.gyp:

2011-01-04 Evan Martin <​evan@chromium.org>

Reviewed by Tony Chang.

[chromium] depend on harfbuzz explicitly
​https://bugs.webkit.org/show_bug.cgi?id=51895

Update Chromium DEPS to pick up newer Chromium version
that simplifies expressing the Harfbuzz dependency.

  • DEPS:
3:57 PM Changeset in webkit [75022] by beidson@apple.com
  • 10 edits in trunk/WebKit2

Get rid of an extra copy in the back/forward item IPC message by using a DataReference.

Reviewed by Darin Adler.

  • UIProcess/WebBackForwardListItem.cpp:

(WebKit::WebBackForwardListItem::WebBackForwardListItem):
(WebKit::WebBackForwardListItem::setBackForwardData):

  • UIProcess/WebBackForwardListItem.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::dataCallback): Get rid of no-longer-needed check for size 0.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::addBackForwardItem):

  • UIProcess/WebProcessProxy.h:
  • UIProcess/WebProcessProxy.messages.in:
  • WebProcess/WebPage/EncoderAdapter.cpp:

(WebKit::EncoderAdapter::data):

  • WebProcess/WebPage/EncoderAdapter.h:
  • WebProcess/WebPage/WebBackForwardListProxy.cpp:
3:35 PM Changeset in webkit [75021] by beidson@apple.com
  • 6 edits in trunk/WebKit2

Store more data per history entry in the session state blob.

Reviewed by Darin Adler.

  • UIProcess/WebBackForwardListItem.cpp:

(WebKit::WebBackForwardListItem::WebBackForwardListItem):

  • UIProcess/WebBackForwardListItem.h:

(WebKit::WebBackForwardListItem::create):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::addBackForwardItem):

  • UIProcess/cf/WebBackForwardListCF.cpp:

(WebKit::WebBackForwardList::createCFDictionaryRepresentation):

  • UIProcess/cf/WebPageProxyCF.cpp:
3:28 PM Changeset in webkit [75020] by Darin Adler
  • 12 edits
    4 adds in trunk

2011-01-04 Darin Adler <Darin Adler>

Reviewed by Brady Eidson.

Add back/forward encoding and decoding to WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=51901

  • WebCore.exp.in: Export functions used in WebKit2.
  • history/HistoryItem.cpp: (WebCore::HistoryItem::encodeBackForwardTree): Use references instead of pointers. (WebCore::HistoryItem::encodeBackForwardTreeNode): Ditto. (WebCore::HistoryItem::decodeBackForwardTree): Ditto.
  • history/HistoryItem.h: Ditto.
  • platform/network/FormData.cpp: (WebCore::encode): Ditto. (WebCore::decode): Ditto. (WebCore::FormData::encodeForBackForward): Ditto. (WebCore::FormData::decodeForBackForward): Ditto.
  • platform/network/FormData.h: Ditto.

2011-01-04 Darin Adler <Darin Adler>

Reviewed by Brady Eidson.

Add back/forward encoding and decoding to WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=51901

  • GNUmakefile.am: Added new source files.
  • WebKit2.pro: Ditto.
  • WebKit2.xcodeproj/project.pbxproj: Ditto.
  • win/WebKit2.vcproj: Ditto.
  • WebProcess/WebPage/DecoderAdapter.cpp: Added.
  • WebProcess/WebPage/DecoderAdapter.h: Added.
  • WebProcess/WebPage/EncoderAdapter.cpp: Added.
  • WebProcess/WebPage/EncoderAdapter.h: Added.
  • WebProcess/WebPage/WebBackForwardListProxy.cpp: (WebKit::updateBackForwardItem): Added code to encode the back/forward tree and send it along. The code to decode needs to wait on Brady's current project.
3:17 PM Changeset in webkit [75019] by dbates@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-04 Daniel Bates <​dbates@rim.com>

Fix the Android build after changeset 74975 <​http://trac.webkit.org/changeset/74975>
(​https://bugs.webkit.org/show_bug.cgi?id=51855).

  • wtf/ThreadingPthreads.cpp: Add include of PassOwnPtr.h. (WTF::runThreadWithRegistration): Use -> instead of . to dereference pointer.
3:05 PM Changeset in webkit [75018] by xji@chromium.org
  • 7 edits in trunk

2011-01-04 Xiaomei Ji <​xji@chromium.org>

Reviewed by Dan Bernstein.

Implement sel.modify('move', 'left'/'right', 'lineBoundary').
​https://bugs.webkit.org/show_bug.cgi?id=33435

  • editing/SelectionController.cpp: (WebCore::SelectionController::modifyMovingRight): (WebCore::SelectionController::modifyMovingLeft):
  • editing/visible_units.cpp: (WebCore::logicalStartOfLine): (WebCore::logicalEndOfLine): (WebCore::leftBoundaryOfLine): (WebCore::rightBoundaryOfLine):
  • editing/visible_units.h:

2011-01-04 Xiaomei Ji <​xji@chromium.org>

Implement sel.modify('move', 'left'/'right', 'lineBoundary').
​https://bugs.webkit.org/show_bug.cgi?id=33435

  • editing/selection/home-end-expected.txt:
  • editing/selection/home-end.html:
3:04 PM Changeset in webkit [75017] by Martin Robinson
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-04 Martin Robinson <​mrobinson@igalia.com>

Try to fix the EFL build.

  • wtf/CMakeLists.txt: Remove PlatformRefPtr from the CMake source list.
2:58 PM Changeset in webkit [75016] by Martin Robinson
  • 21 edits in trunk

2011-01-04 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Use the default CSS text input control border width of relying on the GTK+ theme
​https://bugs.webkit.org/show_bug.cgi?id=51887

Update all results that use text areas. These controls now have a 1 pixel
border (the default in html.css) instead of using the border size from the
GTK+ theme.

  • platform/gtk/fast/forms/basic-textareas-expected.txt:
  • platform/gtk/fast/forms/form-element-geometry-expected.txt:
  • platform/gtk/fast/forms/onselect-textarea-expected.txt:
  • platform/gtk/fast/forms/placeholder-stripped-expected.txt:
  • platform/gtk/fast/forms/search-styled-expected.txt:
  • platform/gtk/fast/forms/textAreaLineHeight-expected.txt:
  • platform/gtk/fast/forms/textarea-align-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-set-attribute-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-set-value-expected.txt:
  • platform/gtk/fast/forms/textarea-scroll-height-expected.txt:
  • platform/gtk/fast/forms/textarea-scrollbar-expected.txt:
  • platform/gtk/fast/forms/textarea-scrolled-type-expected.txt:
  • platform/gtk/fast/forms/textarea-setinnerhtml-expected.txt:
  • platform/gtk/fast/forms/textarea-width-expected.txt:

2011-01-04 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Use the default CSS text input control border width of relying on the GTK+ theme
​https://bugs.webkit.org/show_bug.cgi?id=51887

Do not rely on the GTK+ theme to determine text control borders. This simplifies
the RenderTheme code, prevents metrics differences between GTK+ 2.x and 3.x and
doesn't break the rendering of any theme that I've encountered.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::adjustSearchFieldStyle): No longer call setTextInputBorders, but still disable any border radius.
  • platform/gtk/RenderThemeGtk.h: Remove setTextInputBorders and no longer override the default style of text areas and text input controls.
  • platform/gtk/RenderThemeGtk2.cpp: Ditto.
  • platform/gtk/RenderThemeGtk3.cpp: Ditto.
2:58 PM Changeset in webkit [75015] by andersca@apple.com
  • 2 edits in trunk/WebKit2

<rdar://problem/8766999> WebKit2: Sandboxing causes certificate error on access to any HTTPS URL

Reviewed by Sam Weinig.

Allow read access to /Library/Preferences/com.apple.security.plist.

  • WebProcess/com.apple.WebProcess.sb:
2:56 PM Changeset in webkit [75014] by jschuh@chromium.org
  • 6 edits
    2 copies in branches/chromium/552

Merge 74636 - 2010-12-24 Justin Schuh <​jschuh@chromium.org>

Reviewed by Nikolas Zimmermann.

SVGElementInstance::m_useElement should be cleared when use element is removed from document
​https://bugs.webkit.org/show_bug.cgi?id=51486

Test: svg/custom/use-instanceRoot-with-use-removed.svg

  • svg/SVGElementInstance.cpp: (WebCore::SVGElementInstance::invalidateAllInstancesOfElement):
  • svg/SVGElementInstance.h: (WebCore::SVGElementInstance::clearUseElement):
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::removedFromDocument): (WebCore::ShadowTreeUpdateBlocker::if): (WebCore::SVGUseElement::detachInstance): (WebCore::SVGUseElement::detach):
  • svg/SVGUseElement.h:

2010-12-24 Justin Schuh <​jschuh@chromium.org>

Reviewed by Nikolas Zimmermann.

SVGElementInstance::m_useElement should be cleared when use element is removed from document
​https://bugs.webkit.org/show_bug.cgi?id=51486

  • svg/custom/use-instanceRoot-with-use-removed-expected.txt: Added.
  • svg/custom/use-instanceRoot-with-use-removed.svg: Added.

BUG=67363
TBR=​jschuh@chromium.org

2:56 PM Changeset in webkit [75013] by andersca@apple.com
  • 3 edits in trunk/WebKit2

Build fixes.

  • UIProcess/qt/TextCheckerQt.cpp:
  • UIProcess/win/TextCheckerWin.cpp:
2:49 PM Changeset in webkit [75012] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Don't use macros for the key names.

Reviewed by Darin Adler.

  • UIProcess/mac/TextCheckerMac.mm:
2:47 PM Changeset in webkit [75011] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-01-04 James Robinson <​jamesr@chromium.org>

Reviewed by Darin Adler.

StackBounds initialization in WTFThreadData should be guarded by #if USE(JSC)
​https://bugs.webkit.org/show_bug.cgi?id=51881

The StackBounds class is only used by JavaScriptCore.

  • wtf/WTFThreadData.cpp: (WTF::WTFThreadData::WTFThreadData):
  • wtf/WTFThreadData.h: (WTF::WTFThreadData::resetCurrentIdentifierTable):
2:41 PM Changeset in webkit [75010] by andersca@apple.com
  • 17 edits
    1 add in trunk/WebKit2

2011-01-04 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Send over text checker state to the web process
​https://bugs.webkit.org/show_bug.cgi?id=51896

  • Platform/CoreIPC/Arguments.h: Remove 'const' from the argument, this matches all the other Arguments classes.
  • Shared/TextCheckerState.h: Added. New class with text checker state.
  • Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode): (WebKit::WebProcessCreationParameters::decode):
  • Shared/WebProcessCreationParameters.h: Add textCheckerState.
  • UIProcess/API/mac/WKView.mm: (-[WKView validateUserInterfaceItem:]): (-[WKView toggleContinuousSpellChecking:]): (-[WKView toggleGrammarChecking:]): (-[WKView toggleAutomaticSpellingCorrection:]): Get the needed flags from the text checker state.
  • UIProcess/TextChecker.h: Add state() function, remove getters.
  • UIProcess/WebContext.cpp: (WebKit::WebContext::ensureWebProcess): Initialize the text checker state.
  • UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::updateTextCheckerState): Send the SetTextCheckerState message to the web process.
  • UIProcess/mac/TextCheckerMac.mm: (WebKit::initializeState): Initialize the state from the user defaults.

(WebKit::TextChecker::state):
Return the state.

(WebKit::TextChecker::setContinuousSpellCheckingEnabled):
(WebKit::TextChecker::setGrammarCheckingEnabled):
(WebKit::TextChecker::setAutomaticSpellingCorrectionEnabled):
Make sure to write the new state.


  • UIProcess/qt/TextCheckerQt.cpp: (WebKit::TextChecker::state):
  • UIProcess/win/TextCheckerWin.cpp: (WebKit::TextChecker::state): Add stubs.
  • WebKit2.xcodeproj/project.pbxproj: Add TextCheckerState.h.
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::WebProcess): Initialize m_textCheckerState.

(WebKit::WebProcess::setTextCheckerState):
Update.

  • WebProcess/WebProcess.messages.in: Add SetTextCheckerState message.
  • win/WebKit2.vcproj: Add TextCheckerState.h.
2:29 PM Changeset in webkit [75009] by Martin Robinson
  • 53 edits
    1 delete in trunk

2011-01-03 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Darin Adler.

Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
​https://bugs.webkit.org/show_bug.cgi?id=51846

  • GNUmakefile.am: Remove PlatformRefPtr.h from the sources list.
  • JavaScriptCore.vcproj/WTF/WTF.vcproj: Ditto.
  • jit/ExecutableAllocator.h: Change references to PlatformRefPtr to RefPtr. (JSC::ExecutableAllocator::cacheFlush): Ditto.
  • wtf/PlatformRefPtr.h: Removed.
  • wtf/RandomNumber.cpp: Change references to PlatformRefPtr to RefPtr. (WTF::randomNumber): Ditto.
  • wtf/brew/RefPtrBrew.h: Ditto. (WTF::refIfNotNull): Added. (WTF::derefIfNotNull): Added.
  • wtf/brew/ShellBrew.h: Change references to PlatformRefPtr to RefPtr. (WTF::createRefPtrInstance): Modified to return a RefPtr.
  • wtf/gobject/GRefPtr.cpp: (WTF::refGPtr): Moved from PlatformRefPtr here. (WTF::derefGPtr): Ditto.
  • wtf/gobject/GRefPtr.h: Ditto. (WTF::GRefPtr::GRefPtr): Ditto. (WTF::GRefPtr::~GRefPtr): Ditto. (WTF::GRefPtr::clear): Ditto. (WTF::GRefPtr::isHashTableDeletedValue): Ditto. (WTF::GRefPtr::get): Ditto. (WTF::GRefPtr::operator*): Ditto. (WTF::GRefPtr::operator->): Ditto. (WTF::GRefPtr::operator!): Ditto. (WTF::GRefPtr::operator UnspecifiedBoolType): Ditto. (WTF::GRefPtr::hashTableDeletedValue): Ditto. (WTF::::operator): Ditto. (WTF::::swap): Ditto. (WTF::swap): Ditto. (WTF::operator==): Ditto. (WTF::operator!=): Ditto. (WTF::static_pointer_cast): Ditto. (WTF::const_pointer_cast): Ditto. (WTF::getPtr): Ditto. (WTF::adoptGRef): Ditto. (WTF::refGPtr): Ditto. (WTF::derefGPtr): Ditto.

2011-01-03 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Darin Adler.

Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
​https://bugs.webkit.org/show_bug.cgi?id=51846

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr back to GRefPtr.

2011-01-03 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Darin Adler.

Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
​https://bugs.webkit.org/show_bug.cgi?id=51846

No new tests. This should not introduce any functional changes.

Changed all references to PlatformRefPtr in GTK+ code to GRefPtr. Changed
all references to PlatformRefPtr in Brew code to RefPtr.

2011-01-03 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Darin Adler.

Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
​https://bugs.webkit.org/show_bug.cgi?id=51846

Changed all references to PlatformRefPtr in GTK+ code to GRefPtr.

2:28 PM Changeset in webkit [75008] by inferno@chromium.org
  • 3 edits
    2 copies in branches/chromium/552

Merge 74574

BUG=66748

2:21 PM Changeset in webkit [75007] by inferno@chromium.org
  • 3 edits
    2 copies in branches/chromium/552

Merge 73927

BUG=66560

2:07 PM Changeset in webkit [75006] by ddkilzer@apple.com
  • 5 edits
    1 move in trunk/WebCore

<​http://webkit.org/b/51890> Move ResourceLoadPriority.h into WebCore/platform/network

Reviewed by Antti Koivisto.

This is needed to prevent a WebCore/platform policy violation in
my next patch.

  • WebCore.gypi: Updated for moved header.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • platform/network/ResourceLoadPriority.h: Renamed from WebCore/loader/ResourceLoadPriority.h.
2:04 PM Changeset in webkit [75005] by Martin Robinson
  • 2 edits in trunk

2011-01-04 Martin Robinson <​mrobinson@igalia.com>

Reviewed by David Levin.

.gitignore should be updated to reflect Sources rename to Source
​https://bugs.webkit.org/show_bug.cgi?id=51893

  • .gitignore: Change all paths that reference the "Sources" directory to say "Source".
1:56 PM Changeset in webkit [75004] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-01-04 Ojan Vafai <​ojan@chromium.org>

Increment version number to avoid getting the cached JS file.

  • PrettyPatch/PrettyPatch.rb:
1:52 PM Changeset in webkit [75003] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

2010-12-15 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

anchor the toolbar to the bottom of the diff if the diff doesn't take a full screen of height
​https://bugs.webkit.org/show_bug.cgi?id=51162

  • PrettyPatch/PrettyPatch.rb:
  • code-review.js:
1:39 PM Changeset in webkit [75002] by inferno@chromium.org
  • 1 edit in branches/chromium/552/WebCore/dom/Range.cpp

Merge 73818 Build Fix for 552 branch

BUG=65942

1:35 PM Changeset in webkit [75001] by beidson@apple.com
  • 2 edits in trunk/WebCore
  • storage/StorageMap.h: mesured? Really?

Reviewed by a spell checker.

1:27 PM Changeset in webkit [75000] by commit-queue@webkit.org
  • 16 edits
    2 copies
    2 deletes in trunk

2011-01-04 Zhe Su <​suzhe@chromium.org>

Reviewed by Kenneth Russell.

  1. Remove entry for editing/input/ime-composition-clearpreedit.html test.
  2. Improve fast/events/ime-composition-events-001.html to cover more cases. And fix test expectations of chromium port. ​https://bugs.webkit.org/show_bug.cgi?id=51693
  • fast/events/ime-composition-events-001-expected.txt:
  • fast/events/ime-composition-events-001.html:
  • platform/chromium-mac/fast/events/ime-composition-events-001-expected.txt: Removed.
  • platform/chromium-win/fast/events/ime-composition-events-001-expected.txt: Removed.
  • platform/chromium/fast/events/ime-composition-events-001-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/qt/fast/events/ime-composition-events-001-expected.txt: Added.

2011-01-04 Zhe Su <​suzhe@chromium.org>

Reviewed by Kenneth Russell.

Fix insertText, setMarkedText and unmarkText methods of
TextInputController to call corresponding methods of WebKit::WebView
rather than WebKit::WebFrame. This change matches the behavior of
chromium browser.
insertText corresponds to WebView::confirmComposition(text)
setMarkedText corresponds to WebView::setComposition(...)
unmarkText corresponds to WebView::confirmComposition()
​https://bugs.webkit.org/show_bug.cgi?id=51693

  • DumpRenderTree/chromium/TextInputController.cpp: (TextInputController::insertText): (TextInputController::setMarkedText): (TextInputController::unmarkText):

2011-01-04 Zhe Su <​suzhe@chromium.org>

Reviewed by Kenneth Russell.

Changes:

  1. Add WebKit::WebWidget::confirmComposition(const WebString& text) This new method corresponds to Editor::confirmComposition(text) and Editor::insertText(text). It'll be used by both DumpRenderTree's TextInputController and chromium browser.
  2. Fix WebFrameImpl::insertText It should call Editor::confirmComposition(text) rather than Editor::insertText(text) if there is an ongoing composition. It matches the behavior of WebKit Mac port.
  3. Fix WebFrameImpl::setMarkedText Editor::confirmComposition(text) shouldn't be called in this method, which incorrectly inserts the text.

​https://bugs.webkit.org/show_bug.cgi?id=51693

  • public/WebWidget.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::insertText): (WebKit::WebFrameImpl::setMarkedText):
  • src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::confirmComposition):
  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::confirmComposition):
  • src/WebViewImpl.h:
  • tests/PopupMenuTest.cpp: (WebKit::TestWebWidget::confirmComposition):

2011-01-04 Zhe Su <​suzhe@chromium.org>

Reviewed by Kenneth Russell.

Fix test LayoutTests/fast/events/ime-composition-events-001.html.

​https://bugs.webkit.org/show_bug.cgi?id=51693

  • Api/qwebpage.cpp: (QWebPagePrivate::inputMethodEvent): Calls editor->insertText() to insert the commit string when no composition text is available.
1:23 PM Changeset in webkit [74999] by beidson@apple.com
  • 2 edits in trunk/WebKit2

Attach a radar # to this FIXME:

  • WebProcess/WebPage/WebBackForwardListProxy.cpp:

Rubberstamped by Anders Carlsson.

1:12 PM Changeset in webkit [74998] by Laszlo Gombos
  • 2 edits in trunk

2011-01-04 Dihan Wickremasuriya <​dihan.wickremasuriya@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] [Symbian] Build system cleanup

After r74811 special handling for the Symbian build is no longer needed.
This patch reverts r58756.

  • WebKit.pri:
1:09 PM Changeset in webkit [74997] by commit-queue@webkit.org
  • 5 edits in trunk/WebCore

2011-01-04 Carlos Garcia Campos <​cgarcia@igalia.com> and Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Port stock icon painting to GtkStyleContext
​https://bugs.webkit.org/show_bug.cgi?id=51764

Port stock icon painting for media and search input elements to
GtkStyleContext. Also create the initial machinery for accessing
style contexts for all GTK+ 3.x based widgets.

No new tests. This should not change functionality.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::paintGdkPixbuf): (WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration): (WebCore::RenderThemeGtk::paintSearchFieldCancelButton): (WebCore::RenderThemeGtk::paintMediaButton):
  • platform/gtk/RenderThemeGtk.h:
  • platform/gtk/RenderThemeGtk2.cpp: (WebCore::RenderThemeGtk::getStockIcon):
  • platform/gtk/RenderThemeGtk3.cpp: (WebCore::gtkStyleChangedCallback): (WebCore::styleContextMap): (WebCore::getStyleContext): (WebCore::RenderThemeGtk::paintMenuList):
12:47 PM Changeset in webkit [74996] by ddkilzer@apple.com
  • 2 edits in trunk/WebKit/mac

<​http://webkit.org/b/51889> WebFrameLoaderClient::createMediaPlayerProxyPlugin() should use WebCore::PluginInfo.name

Reviewed by Eric Carlson.

This originally broke in r61581. It is inside an
ENABLE(PLUGIN_PROXY_FOR_VIDEO) macro, so it didn't break the Mac
build then.

  • WebCoreSupport/WebFrameLoaderClient.mm: Call

(WebFrameLoaderClient::createMediaPlayerProxyPlugin): Updated to
use WebCore::PluginInfo.name instead of
-[WebBasePluginPackage name].

12:46 PM Changeset in webkit [74995] by Antti Koivisto
  • 8 edits
    4 adds in trunk

WebCore: Scripts should not be executed before preceding stylesheets are loaded
​https://bugs.webkit.org/show_bug.cgi?id=8852

Reviewed by Dave Hyatt.

Block inline script execution on pending stylesheet loads. This matches
other browsers and HTML5.

Tests: fast/tokenizer/inline-script-stylesheet-write.html

fast/tokenizer/inline-script-stylesheet.html

  • dom/PendingScript.cpp:

(WebCore::PendingScript::releaseElementAndClear):

  • dom/PendingScript.h:

(WebCore::PendingScript::PendingScript):
(WebCore::PendingScript::operator=):
(WebCore::PendingScript::startingPosition):
(WebCore::PendingScript::setStartingPosition):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::process):

This fixes an unrelated bug with beforeload events that was exposed by the other
changes (fast/dom/beforeload/remove-link-in-beforeload-listener.html).

  • html/parser/HTMLScriptRunner.cpp:

(WebCore::HTMLScriptRunner::sourceFromPendingScript):
(WebCore::HTMLScriptRunner::runScript):

LayoutTests: Scripts should not be executed before preceding stylesheets are loaded
​https://bugs.webkit.org/show_bug.cgi?id=8852

Reviewed by Dave Hyatt.

New tests plus a few test with slightly changed output due to different load serialization behavior.

  • fast/tokenizer/inline-script-stylesheet-expected.txt: Added.
  • fast/tokenizer/inline-script-stylesheet-write-expected.txt: Added.
  • fast/tokenizer/inline-script-stylesheet-write.html: Added.
  • fast/tokenizer/inline-script-stylesheet.html: Added.
  • http/tests/security/mixedContent/insecure-css-in-main-frame-expected.txt:
  • platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
12:43 PM Changeset in webkit [74994] by commit-queue@webkit.org
  • 6 edits in trunk/WebCore

2011-01-04 Xianzhu Wang <​wangxianzhu@google.com>

Reviewed by Darin Adler.

Let DataView.getInt8() and DataView.setInt8() use int8_t instead of
ambiguous 'char' to fix fast/canvas/webgl/data-view-test.html failure
on ARM.
​https://bugs.webkit.org/show_bug.cgi?id=51861

By the way, changed other getIntXX() and setIntXX() methods to use
more precise integer types.

  • bindings/js/JSDataViewCustom.cpp: (WebCore::setDataViewMember):
  • bindings/v8/custom/V8DataViewCustom.cpp: (WebCore::V8DataView::getInt8Callback): (WebCore::V8DataView::setInt8Callback):
  • html/canvas/DataView.cpp: (WebCore::DataView::getInt8): (WebCore::DataView::setInt8):
  • html/canvas/DataView.h:
  • html/canvas/DataView.idl:
12:34 PM Changeset in webkit [74993] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed trivial fix after r74976.

  • platform/qt/Skipped:
12:20 PM Changeset in webkit [74992] by commit-queue@webkit.org
  • 8 edits in trunk/WebCore

2011-01-04 Yong Li <​yoli@rim.com>

Reviewed by Adam Barth.

Suspend HTMLParserScheduler when page load is deferred to
avoid potential JS re-entrancy. Otherwise, when JS execution is triggered
from an external script or by events, and is blocked by a modal dialog,
WebKit can parse more HTML source and also start another JS execution.

​https://bugs.webkit.org/show_bug.cgi?id=48077

Test case: WebCore/manual-tests/bugzilla-48077.html.

  • dom/DocumentParser.cpp: (WebCore::DocumentParser::suspendScheduledTasks): (WebCore::DocumentParser::resumeScheduledTasks):
  • dom/DocumentParser.h:
  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::suspendScheduledTasks): (WebCore::HTMLDocumentParser::resumeScheduledTasks):
  • html/parser/HTMLParserScheduler.cpp: (WebCore::HTMLParserScheduler::HTMLParserScheduler): (WebCore::HTMLParserScheduler::suspend): (WebCore::HTMLParserScheduler::resume):
  • html/parser/HTMLParserScheduler.h: (WebCore::HTMLParserScheduler::isScheduledForResume):
  • page/PageGroupLoadDeferrer.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
12:07 PM Changeset in webkit [74991] by rniwa@webkit.org
  • 1 edit in branches/chromium/552/WebCore/dom/Range.cpp

Merge 73818 - 2010-12-10 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

REGRESSION(r73799): editing/execCommand/4920488.html fails
​https://bugs.webkit.org/show_bug.cgi?id=50854

The regression was caused by Range::processContents's not extracting
m_end.container()->firstChild(). Fixed the bug by always adding the first child.

  • dom/Range.cpp: (WebCore::Range::processContents):

TBR=​rniwa@webkit.org
BUG=65942

12:04 PM Changeset in webkit [74990] by rniwa@webkit.org
  • 1 edit
    2 copies in branches/chromium/552

Merge 73799 - 2010-12-10 Emil Eklund <​eae@chromium.org>

Reviewed by Adam Barth.

Fix crash in Range::processContents when modified during mutation event.
​https://bugs.webkit.org/show_bug.cgi?id=50710

Test: fast/dom/Range/range-extractContents.html

  • dom/Range.cpp: (WebCore::Range::processContents): Replace raw pointers with RefPtrs and add checks.

2010-12-10 Emil Eklund <​eae@chromium.org>

Reviewed by Adam Barth.

Add testcase for range.extractContents crash.
​https://bugs.webkit.org/show_bug.cgi?id=50710

  • fast/dom/Range/range-extractContents-expected.txt: Added.
  • fast/dom/Range/range-extractContents.html: Added.

TBR=​inferno@chromium.org
BUG=65942

11:49 AM Changeset in webkit [74989] by andersca@apple.com
  • 6 edits in trunk/WebKit2

2011-01-04 Anders Carlsson <​andersca@apple.com>

Reviewed by John Sullivan.

Add more spelling/grammar related methods
​https://bugs.webkit.org/show_bug.cgi?id=51886

  • UIProcess/API/mac/WKView.mm: (-[WKView validateUserInterfaceItem:]): Handle more selectors.

(-[WKView showGuessPanel:]):
Add stub.

(-[WKView checkSpelling:]):
Ditto.

(-[WKView toggleAutomaticSpellingCorrection:]):
Toggle automatic spelling correction.

  • UIProcess/TextChecker.h: Add setAutomaticSpellingCorrectionEnabled and isAutomaticSpellingCorrectionEnabled.
  • UIProcess/mac/TextCheckerMac.mm: (WebKit::TextChecker::setAutomaticSpellingCorrectionEnabled): (WebKit::TextChecker::isAutomaticSpellingCorrectionEnabled): Update the toggle.
  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
  • WebProcess/WebCoreSupport/mac/WebErrorsMac.mm: Add a Radar URL for the localization FIXMEs.
11:40 AM Changeset in webkit [74988] by bfulgham@webkit.org
  • 2 edits in trunk/WebKit2

Unreviewed build fix.

  • win/WebKit2.vcproj: Correct the missing $(WebKitVSPropsRedirectionDir)

variables that Visual Studio helpfully removes when making changes.

11:38 AM Changeset in webkit [74987] by inferno@chromium.org
  • 3 edits
    16 copies
    2 deletes in branches/chromium/552

Merge 74954

BUG=66760

11:35 AM Changeset in webkit [74986] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/552

Merge 74364

BUG=66760

11:33 AM Changeset in webkit [74985] by dbates@webkit.org
  • 1 edit in trunk/Source/JavaScriptCore/ChangeLog

2011-01-04 Daniel Bates <​dbates@rim.com>

Fix the date recorded in the change log entry for changeset 74973 <​http://trac.webkit.org/changeset/74973>.
It was recorded as "2011-01-03". Instead, it should be "2011-01-04" to correspond
with the date this changeset was committed.

11:29 AM Changeset in webkit [74984] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/552

Merge 74787

BUG=68181

11:29 AM Changeset in webkit [74983] by dbates@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-04 Daniel Bates <​dbates@rim.com>

Reviewed by Adam Roben.

LEAK: Deallocate instance of ThreadFunctionInvocation if thread creation fails
​https://bugs.webkit.org/show_bug.cgi?id=51860

  • wtf/ThreadingWin.cpp: (WTF::createThreadInternal):
11:26 AM Changeset in webkit [74982] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/552

Merge 74781

BUG=66986

11:24 AM Changeset in webkit [74981] by inferno@chromium.org
  • 1 edit
    4 copies in branches/chromium/552

Merge 74743

BUG=65796

11:21 AM Changeset in webkit [74980] by bfulgham@webkit.org
  • 2 edits in trunk/WebKit2

Unreviewed build fix.

  • win/WebKit2.vcproj: Disable CG-specific WKImageCG.cpp from

Debug_Cairo_CFLite/Release_Cario_CFLite builds.

11:19 AM Changeset in webkit [74979] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/552

Merge 73801

BUG=66473

11:16 AM Changeset in webkit [74978] by Laszlo Gombos
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-04 Laszlo Gombos <Laszlo Gombos>

Reviewed by Ariya Hidayat.

[Qt][Symbian] Make sure that WebKit headers are included before platform headers on Symbian
​https://bugs.webkit.org/show_bug.cgi?id=31273

On Symbian PREPEND_INCLUDEPATH is the best way to make sure that WebKit headers
are included before platform headers. On all other platforms continue to use
INCLUDEPATH (as before). This is a continuation of r65877.

No new tests as there is no new functionality.

11:11 AM Changeset in webkit [74977] by Darin Adler
  • 2 edits in trunk/Source/JavaScriptCore

Try to fix Windows build.

  • wtf/ThreadingWin.cpp: Added include of PassOwnPtr.h. Fixed paragraphing

of conditional includes.
(WTF::wtfThreadEntryPoint): Use -> instead of . to dereference pointer.
(WTF::createThreadInternal): Tweaked #if to not need separate macro.

11:04 AM Changeset in webkit [74976] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-04 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed; Added editing/selection/caret-bidi-first-and-last-letters.html to Qt's skipped list.
The tracking bug 51884 (​https://bugs.webkit.org/show_bug.cgi?id=51884) has been filed.

  • platform/qt/Skipped:
10:56 AM Changeset in webkit [74975] by dbates@webkit.org
  • 4 edits
    1 add in trunk/Source/JavaScriptCore

2011-01-04 Daniel Bates <​dbates@rim.com>

Reviewed by Adam Roben.

Extract ThreadFunctionInvocation into separate file and share between Apple Windows and Android
​https://bugs.webkit.org/show_bug.cgi?id=51855

Both the Apple Windows and Android ports implement a similar adapter structure,
called ThreadFunctionInvocation and ThreadData respectively, as part of
their thread creation process. Instead, we should share such an adapter
structure and remove duplicate code.

  • JavaScriptCore.gypi: Added header wtf/ThreadFunctionInvocation.h.
  • wtf/ThreadFunctionInvocation.h: Added. (WTF::ThreadFunctionInvocation::ThreadFunctionInvocation):
  • wtf/ThreadingPthreads.cpp: Removed Android-specific structure ThreadData; Instead, use ThreadFunctionInvocation. (WTF::runThreadWithRegistration): (WTF::createThreadInternal):
  • wtf/ThreadingWin.cpp: Moved structure ThreadFunctionInvocation to its own file so that it can be shared with the Android implementation of createThreadInternal(). (WTF::wtfThreadEntryPoint): Use OwnPtr to hold passed instance of ThreadFunctionInvocation.
10:53 AM Changeset in webkit [74974] by Laszlo Gombos
  • 2 edits in trunk/Tools

2011-01-04 Dihan Wickremasuriya <​dihan.wickremasuriya@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] [Symbian] Do not remove 0 byte sized files from productDir

On Symbian productDir points to the source directory. Removing all the
empty files from the productDir directory corrupts the svn repository.

  • Scripts/build-webkit:
10:32 AM BuildBot edited by wsiegrist@apple.com
Add umask change for slaves (diff)
9:44 AM Changeset in webkit [74973] by dbates@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-03 Daniel Bates <​dbates@rim.com>

Reviewed by Darin Adler.

Use builtin_expect when compiling using RVCT in GNU mode
​https://bugs.webkit.org/show_bug.cgi?id=51866

Derived from a patch by Dave Tapuska.

  • wtf/AlwaysInline.h:
9:29 AM Changeset in webkit [74972] by tonyg@chromium.org
  • 2 edits in trunk/WebCore

2011-01-04 Tony Gentilcore <​tonyg@chromium.org>

Unreviewed build fix.

Include glib-object.h for GObject
​https://bugs.webkit.org/show_bug.cgi?id=51876

  • bindings/gobject/DOMObjectCache.cpp:
9:21 AM Changeset in webkit [74971] by rniwa@webkit.org
  • 4 edits
    2 adds in trunk

2011-01-04 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Dan Bernstein.

Clicking on the first or the last letter of LTR/RTL text in a RTL/LTR block puts caret on the opposite side.
​https://bugs.webkit.org/show_bug.cgi?id=50992

Fixed the bug by interchanging the offset when the direction of inline text box and the containing block
does not match. Reused the code added by ​http://trac.webkit.org/changeset/73553.

Test: editing/selection/caret-bidi-first-and-last-letters.html

  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::offsetForPosition):

2011-01-04 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Dan Bernstein.

Clicking on the first or the last letter of LTR/RTL text in a RTL/LTR block puts caret on the opposite side.
​https://bugs.webkit.org/show_bug.cgi?id=50992

Added a test to ensure WebKit places the caret on the side user clicked even when text's natural direction
and the containing block's direction do not match.

  • editing/selection/caret-bidi-first-and-last-letters-expected.txt: Added.
  • editing/selection/caret-bidi-first-and-last-letters.html: Added.
  • editing/selection/resources/caret-edge-shared.js: Avoid calling verify() outside of DRT.
9:05 AM Changeset in webkit [74970] by beidson@apple.com
  • 11 edits in trunk/WebKit2

​https://bugs.webkit.org/show_bug.cgi?id=51856
Pass encoded back/forward tree data from the WebProcess to the UIProcess

Reviewed by Darin Adler.

Remove the WKBackForwardListItemCopyOriginalURL API as it's not needed:

  • UIProcess/API/C/WKBackForwardListItem.cpp:
  • UIProcess/API/C/WKBackForwardListItem.h:
  • UIProcess/API/qt/qwkhistory.cpp:
  • UIProcess/API/qt/qwkhistory.h:


  • UIProcess/WebBackForwardListItem.cpp:

(WebKit::WebBackForwardListItem::WebBackForwardListItem):

  • UIProcess/WebBackForwardListItem.h:

(WebKit::WebBackForwardListItem::create):
(WebKit::WebBackForwardListItem::setBackForwardData):
(WebKit::WebBackForwardListItem::backForwardData):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::addBackForwardItem):

  • UIProcess/WebProcessProxy.h:


  • UIProcess/WebProcessProxy.messages.in:


  • WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit::updateBackForwardItem):

8:56 AM Changeset in webkit [74969] by tonyg@chromium.org
  • 22 edits in trunk

2010-12-29 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Darin Adler.

Remove 2 unnecessary includes from Document.h
​https://bugs.webkit.org/show_bug.cgi?id=51727

No new tests because no changed functionality.

  • dom/Document.cpp:
  • dom/Document.h:
  • editing/Editor.cpp:
  • editing/SpellChecker.h:
  • editing/SplitTextNodeCommand.cpp:
  • editing/TextCheckingHelper.cpp:
  • page/FrameView.cpp:
  • page/Page.cpp:
  • rendering/HitTestResult.cpp:
  • rendering/InlineTextBox.cpp:
  • rendering/InlineTextBox.h:
  • rendering/svg/SVGInlineFlowBox.cpp:
7:33 AM Changeset in webkit [74968] by Patrick Gansterer
  • 2 edits in trunk/WebCore

2011-01-04 Patrick Gansterer <Patrick Gansterer>

Unreviewed WinCE build fix.

  • CMakeListsWinCE.txt: Added missing include directories, files and libraries.
6:01 AM Changeset in webkit [74967] by kbalazs@webkit.org
  • 7 edits
    2 moves in trunk/WebKit2

2011-01-04 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt][WK2] Incomplete clean up on termination
​https://bugs.webkit.org/show_bug.cgi?id=51474

Do not kill the web process to force it's termination.
Fix object destruction and cleanup logic and make the cleanup more reliable.
Do not try to cleanup on crash because it is not reliable.

  • Platform/CoreIPC/qt/ConnectionQt.cpp: (CoreIPC::Connection::platformInvalidate): Do not delete the socket if we do not own it. This is the case with a server connection.
  • Platform/qt/MappedMemoryPool.cpp: Turn MappedMemoryPool into a QObject so the CleanupHandler can destruct it in the same way as the other objects. (WebKit::MappedMemoryPool::instance): (WebKit::MappedMemoryPool::~MappedMemoryPool):
  • Platform/qt/MappedMemoryPool.h: (WebKit::MappedMemoryPool::MappedMemoryPool):
  • Platform/qt/SharedMemoryQt.cpp: (WebKit::SharedMemory::create): No need to care about QCoreApplication::aboutToQuit. It is handled by the CleanupHandler. (WebKit::SharedMemory::~SharedMemory): Ditto.
  • Shared/qt/CleanupHandler.cpp: Renamed from WebKit2/Shared/qt/CrashHandler.cpp. No longer try to handle crash but just normal termination. (WebKit::CleanupHandler::CleanupHandler): Connect deleteObjects with QCoreApplication::aboutToQuit. Ensure appropriate thread affinity. (WebKit::CleanupHandler::sigTermHandler): Stop the main event loop. (WebKit::CleanupHandler::deleteObjects): Use deleteLater instead of delete since it is more reliable.
  • Shared/qt/CleanupHandler.h: Renamed from WebKit2/Shared/qt/CrashHandler.h. (WebKit::CleanupHandler::instance): (WebKit::CleanupHandler::markForCleanup): (WebKit::CleanupHandler::unmark):
  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp: Do not kill the web process immidiately but give it a chance to cleanup. Use QLocalServer::removeServer for assuring that the socket file will be removed. (WebKit::ProcessLauncherHelper::serverName): (WebKit::cleanupAtExit): Renamed from cleanupProcesses. Only kill the web process when it times out terminating. Fixed the bug of changing the list while iterating it over by disconnecting from the processStateChanged slot. (WebKit::QtWebProcess::QtWebProcess): Added missing meta type registration of QProcess::ProcessState. (WebKit::ProcessLauncherHelper::~ProcessLauncherHelper): (WebKit::ProcessLauncherHelper::ProcessLauncherHelper): No need to add the the instance to the CleanupHandler because we will remove the socket file in cleanupAtExit. (WebKit::ProcessLauncherHelper::instance): (WebKit::ProcessLauncher::terminateProcess):
  • WebKit2.pro:
5:44 AM Changeset in webkit [74966] by Patrick Gansterer
  • 3 edits in trunk/WebKit/wince

2011-01-04 Patrick Gansterer <Patrick Gansterer>

Unreviewed WinCE build fix.

  • WebCoreSupport/ChromeClientWinCE.cpp: (WebKit::ChromeClientWinCE::exceededDatabaseQuota): Added missing semicolon. (WebKit::ChromeClientWinCE::reachedApplicationCacheOriginQuota):
  • WebCoreSupport/ChromeClientWinCE.h:
5:17 AM Changeset in webkit [74965] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2011-01-04 Yi Shen <​yi.4.shen@nokia.com>

Reviewed by Simon Hausmann.

Provide an interface to require using fullscreen mediaplayer
​https://bugs.webkit.org/show_bug.cgi?id=51133

Only video should be displayed in fullscreen when
requiresFullscreenForVideoPlayback is specified.

No new tests because no client implements requiresFullscreenForVideoPlayback yet.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::updatePlayState):
3:53 AM Changeset in webkit [74964] by benjamin.poulain@nokia.com
  • 9 edits in trunk

2011-01-04 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] [WK2] create an initial implementation of the context menu handling for WebKit 2
​https://bugs.webkit.org/show_bug.cgi?id=51825

Implement contextMenuItemVector() for Qt, this method is used in WebKit 2 to get the
platform independent menu informations.

  • platform/qt/ContextMenuQt.cpp: (WebCore::contextMenuItemVector):

2011-01-04 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] [WK2] create an initial implementation of the context menu handling for WebKit 2
​https://bugs.webkit.org/show_bug.cgi?id=51825

Implement the necessary methods to get a basic context menu working for Qt.

Only 4 basic WebAction have been added on the UIProcess side: back, forward, stop and reload.

  • UIProcess/API/qt/qgraphicswkview.cpp: (QGraphicsWKView::QGraphicsWKView): (QGraphicsWKView::showContextMenu): (QGraphicsWKViewPrivate::QGraphicsWKViewPrivate):
  • UIProcess/API/qt/qgraphicswkview.h:
  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::createContextMenuProxy):
  • UIProcess/API/qt/qwkpage.h:
  • UIProcess/qt/WebContextMenuProxyQt.cpp: (WebKit::webActionForContextMenuAction): (WebKit::WebContextMenuProxyQt::WebContextMenuProxyQt): (WebKit::WebContextMenuProxyQt::create): (WebKit::WebContextMenuProxyQt::showContextMenu): (WebKit::WebContextMenuProxyQt::hideContextMenu): (WebKit::WebContextMenuProxyQt::createContextMenu):
  • UIProcess/qt/WebContextMenuProxyQt.h:
2:43 AM Changeset in webkit [74963] by commit-queue@webkit.org
  • 3 edits
    2 deletes in trunk

2011-01-04 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r74960.
​http://trac.webkit.org/changeset/74960
​https://bugs.webkit.org/show_bug.cgi?id=51868

Rollout since we hit an assert after this patch. (Requested by
krit on #webkit).

  • svg/custom/recursive-use-expected.txt: Removed.
  • svg/custom/recursive-use.svg: Removed.

2011-01-04 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r74960.
​http://trac.webkit.org/changeset/74960
​https://bugs.webkit.org/show_bug.cgi?id=51868

Rollout since we hit an assert after this patch. (Requested by
krit on #webkit).

  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::buildInstanceTree):
1:43 AM Changeset in webkit [74962] by Philippe Normand
  • 2 edits in trunk/WebCore

2011-01-04 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r74961.
​http://trac.webkit.org/changeset/74961
​https://bugs.webkit.org/show_bug.cgi?id=51867

breaks 32/64-bits debug bots build (Requested by philn-tp on
#webkit).

  • platform/graphics/gstreamer/GStreamerGWorld.cpp: (WebCore::GStreamerGWorld::setWindowOverlay):
1:12 AM Changeset in webkit [74961] by Philippe Normand
  • 2 edits in trunk/WebCore

2011-01-03 Philippe Normand <​pnormand@igalia.com>

Rubber-stamped by Eric Seidel.

[GStreamer] build fails with gstreamer core 0.10.31 and -plugins-base 0.10.30
​https://bugs.webkit.org/show_bug.cgi?id=51810

Based on a patch by Mart Raudsepp.

No new tests, build fix only.

  • platform/graphics/gstreamer/GStreamerGWorld.cpp: (WebCore::GStreamerGWorld::setWindowOverlay): Use the new xoverlay API if the GST_CHECK_PLUGINS_BASE_VERSION macro is defined. It was introduced in same version as the xoverlay API change.
1:11 AM Changeset in webkit [74960] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-01-04 Leo Yang <​leo.yang@torchmobile.com.cn>

Reviewed by Dirk Schulze.

Malformed SVG causes crash in updateContainerOffset
​https://bugs.webkit.org/show_bug.cgi?id=44610

Test case for recursive svg <use>.
This test case passes if no crash occurs.

  • svg/custom/recursive-use-expected.txt: Added.
  • svg/custom/recursive-use.svg: Added.

2011-01-04 Leo Yang <​leo.yang@torchmobile.com.cn>

Reviewed by Dirk Schulze.

Malformed SVG causes crash in updateContainerOffset
​https://bugs.webkit.org/show_bug.cgi?id=44610

We should check recursive <use> at the begining of
WebCore::SVGUseElement::buildInstanceTree instead
of at the end of it because the target element's
children may cause infinite recursive <use>.

Test: svg/custom/recursive-use.svg

  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::buildInstanceTree):
12:33 AM Changeset in webkit [74959] by tkent@chromium.org
  • 2 edits in trunk/WebCore

2011-01-04 Kent Tamura <​tkent@chromium.org>

Unreviewed, build fix.

Try to fix Clang build.

  • css/CSSParser.cpp: (WebCore::valueFromSideKeyword): (WebCore::CSSParser::parseLinearGradient):
Note: See TracTimeline for information about the timeline view.