Timeline
Jan 6, 2011:
- 11:31 PM Changeset in webkit [75234] by
-
- 3 edits in trunk/Tools
2011-01-06 Julie Parent <jparent@chromium.org>
Reviewed by Eric Seidel.
Test Result Server not removing old results.
https://bugs.webkit.org/show_bug.cgi?id=52012
- TestResultServer/model/jsonresults.py: Fix off-by-one: Truncate if >= num_runs, not just >.
- TestResultServer/model/jsonresults_unittest.py: Add unit test to test that merging in a new result with the same value as the last result causes previous result to fall off.
- 11:13 PM Changeset in webkit [75233] by
-
- 3 edits5 adds in trunk/Tools
2011-01-06 James Kozianski <koz@chromium.org>
Reviewed by Mihai Parparita.
Add classes to provide a consistent interface to a set of files.
https://bugs.webkit.org/show_bug.cgi?id=50901
These classes allow us to write code that is agnostic to whether a
particular set of files resides in a local directory or in a zip file
on a remote machine.
- Scripts/webkitpy/common/system/directoryfileset.py: Added.
- Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
- Scripts/webkitpy/common/system/fileset.py: Added.
- Scripts/webkitpy/common/system/filesystem.py:
- Scripts/webkitpy/common/system/filesystem_mock.py:
- Scripts/webkitpy/common/system/zipfileset.py: Added.
- Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
- 11:07 PM Changeset in webkit [75232] by
-
- 2 edits3 adds in trunk/LayoutTests
2011-01-06 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by David Levin.
Add layout tests for Entry.getMetadata (FileSystem API)
https://bugs.webkit.org/show_bug.cgi?id=47311
- fast/filesystem/op-get-metadata-expected.txt: Added.
- fast/filesystem/op-get-metadata.html: Added.
- fast/filesystem/resources/op-get-metadata.js: Added.
- fast/filesystem/resources/op-tests-helper.js: Updated getMetadata implementation.
- 10:05 PM Changeset in webkit [75231] by
-
- 2 edits in trunk/LayoutTests
2011-01-06 Mihai Parparita <mihaip@chromium.org>
Unreviewed; chromium test expectations update.
Remove failing expectations for tests that started to pass after
rebaselining in r75215.
Make failing expectations added by r75213 more specific (failures are
only on Windows and Linux).
- platform/chromium/test_expectations.txt:
- 9:32 PM Changeset in webkit [75230] by
-
- 3 edits in trunk/Tools
2011-01-06 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
NetworkTransaction should log the url it is retrying
https://bugs.webkit.org/show_bug.cgi?id=52043
- Scripts/webkitpy/common/net/networktransaction.py:
- Scripts/webkitpy/common/net/networktransaction_unittest.py:
- 9:24 PM Changeset in webkit [75229] by
-
- 2 edits in trunk/Tools
Windows build fix.
Import os before using it.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
- 9:14 PM Changeset in webkit [75228] by
-
- 3 edits2 adds in trunk
2011-01-06 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
REGRESSION (r74663): ASSERTION FAILED: m_tokenizer->lineNumber() == line.zeroBasedInt()
https://bugs.webkit.org/show_bug.cgi?id=52013
This test case used to trigger an ASSERT. It's unclear to me whether
there's a more direct way to test this fix.
- fast/parser/line-number-composite-segmented-string-expected.txt: Added.
- fast/parser/line-number-composite-segmented-string.html: Added.
2011-01-06 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
REGRESSION (r74663): ASSERTION FAILED: m_tokenizer->lineNumber() == line.zeroBasedInt()
https://bugs.webkit.org/show_bug.cgi?id=52013
When excluding line numbers for composite strings, we forgot to exclude
the line number for the current string!
Test: fast/parser/line-number-composite-segmented-string.html
- platform/text/SegmentedString.cpp: (WebCore::SegmentedString::setExcludeLineNumbers):
- 8:53 PM Changeset in webkit [75227] by
-
- 15 edits1 delete in trunk/WebCore
2011-01-06 Chris Marrin <cmarrin@apple.com>
Unreviewed.
Back out changes in http://trac.webkit.org/changeset/75199
This breaks the Windows build. Fixing it on that side. Until
then I'll back this out.
- 8:32 PM Changeset in webkit [75226] by
-
- 2 edits in trunk/LayoutTests
2011-01-06 Stephen White <senorblanco@chromium.org>
Unreviewed; chromium test expectations update.
- platform/chromium/test_expectations.txt: New test fast/frames/iframe-reparenting-plugins.html failing on windows.
- 8:22 PM Changeset in webkit [75225] by
-
- 2 edits in trunk/Tools
2011-01-06 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
StyleQueue fails to report errors when patches have many files
https://bugs.webkit.org/show_bug.cgi?id=52042
This is one of at least two errors preventing style error reporting at the moment.
When we moved to passing the list of files to check explicitly,
we started to exceed the 500 character TEXT field limit for our AppEngine model object.
We could change the type of the QueueStatus.message type, or we could
just teach statusserver.py how to clamp values (and warn when it does).
I chose the latter path.
- Scripts/webkitpy/common/net/statusserver.py:
- 7:37 PM Changeset in webkit [75224] by
-
- 2 edits123 adds in trunk/LayoutTests
2011-01-06 Martin Robinson <mrobinson@igalia.com>
Add new expected results for GTK+. Skip viewport tests which
have results differing from Opera.
- fast/dom/left-overflow-in-ltr-expected.txt: Added.
- fast/dom/right-overflow-in-rtl-expected.txt: Added.
- fast/viewport/viewport-126-expected.txt: Added.
- fast/viewport/viewport-127-expected.txt: Added.
- fast/viewport/viewport-65-expected.txt: Added.
- fast/viewport/viewport-82-expected.txt: Added.
- fast/viewport/viewport-84-expected.txt: Added.
- fast/viewport/viewport-87-expected.txt: Added.
- platform/gtk/Skipped:
- platform/gtk/css2.1/t040105-import-10-b-expected.checksum: Added.
- platform/gtk/css2.1/t040105-import-10-b-expected.png: Added.
- platform/gtk/css2.1/t040105-import-10-b-expected.txt: Added.
- platform/gtk/fast/block/positioning/rtl-static-positioning-expected.checksum: Added.
- platform/gtk/fast/block/positioning/rtl-static-positioning-expected.png: Added.
- platform/gtk/fast/block/positioning/rtl-static-positioning-expected.txt: Added.
- platform/gtk/fast/block/positioning/rtl-static-positioning-inline-block-expected.checksum: Added.
- platform/gtk/fast/block/positioning/rtl-static-positioning-inline-block-expected.png: Added.
- platform/gtk/fast/block/positioning/rtl-static-positioning-inline-block-expected.txt: Added.
- platform/gtk/fast/block/positioning/table-cell-static-position-expected.checksum: Added.
- platform/gtk/fast/block/positioning/table-cell-static-position-expected.png: Added.
- platform/gtk/fast/block/positioning/table-cell-static-position-expected.txt: Added.
- platform/gtk/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum: Added.
- platform/gtk/fast/blockflow/Kusa-Makura-background-canvas-expected.png: Added.
- platform/gtk/fast/blockflow/Kusa-Makura-background-canvas-expected.txt: Added.
- platform/gtk/fast/blockflow/japanese-rl-text-with-broken-font-expected.checksum: Added.
- platform/gtk/fast/blockflow/japanese-rl-text-with-broken-font-expected.png: Added.
- platform/gtk/fast/blockflow/japanese-rl-text-with-broken-font-expected.txt: Added.
- platform/gtk/fast/blockflow/vertical-align-table-baseline-expected.checksum: Added.
- platform/gtk/fast/blockflow/vertical-align-table-baseline-expected.png: Added.
- platform/gtk/fast/blockflow/vertical-align-table-baseline-expected.txt: Added.
- platform/gtk/fast/blockflow/vertical-baseline-alignment-expected.checksum: Added.
- platform/gtk/fast/blockflow/vertical-baseline-alignment-expected.png: Added.
- platform/gtk/fast/blockflow/vertical-baseline-alignment-expected.txt: Added.
- platform/gtk/fast/css-generated-content/table-before-after-child-add-expected.checksum: Added.
- platform/gtk/fast/css-generated-content/table-before-after-child-add-expected.png: Added.
- platform/gtk/fast/css-generated-content/table-before-after-child-add-expected.txt: Added.
- platform/gtk/fast/css-generated-content/table-cell-before-after-child-add-expected.checksum: Added.
- platform/gtk/fast/css-generated-content/table-cell-before-after-child-add-expected.png: Added.
- platform/gtk/fast/css-generated-content/table-cell-before-after-child-add-expected.txt: Added.
- platform/gtk/fast/css-generated-content/table-row-before-after-child-add-expected.checksum: Added.
- platform/gtk/fast/css-generated-content/table-row-before-after-child-add-expected.png: Added.
- platform/gtk/fast/css-generated-content/table-row-before-after-child-add-expected.txt: Added.
- platform/gtk/fast/css-generated-content/table-table-before-after-child-add-expected.checksum: Added.
- platform/gtk/fast/css-generated-content/table-table-before-after-child-add-expected.png: Added.
- platform/gtk/fast/css-generated-content/table-table-before-after-child-add-expected.txt: Added.
- platform/gtk/fast/css/box-shadow-expected.checksum: Added.
- platform/gtk/fast/css/box-shadow-expected.png: Added.
- platform/gtk/fast/css/box-shadow-expected.txt: Added.
- platform/gtk/fast/css/focus-ring-detached-expected.checksum: Added.
- platform/gtk/fast/css/focus-ring-detached-expected.png: Added.
- platform/gtk/fast/css/focus-ring-detached-expected.txt: Added.
- platform/gtk/fast/css/focus-ring-multiline-expected.checksum: Added.
- platform/gtk/fast/css/focus-ring-multiline-expected.png: Added.
- platform/gtk/fast/css/focus-ring-multiline-expected.txt: Added.
- platform/gtk/fast/css/focus-ring-outline-color-expected.checksum: Added.
- platform/gtk/fast/css/focus-ring-outline-color-expected.png: Added.
- platform/gtk/fast/css/focus-ring-outline-color-expected.txt: Added.
- platform/gtk/fast/css/focus-ring-outline-offset-expected.checksum: Added.
- platform/gtk/fast/css/focus-ring-outline-offset-expected.png: Added.
- platform/gtk/fast/css/focus-ring-outline-offset-expected.txt: Added.
- platform/gtk/fast/css/focus-ring-outline-width-expected.checksum: Added.
- platform/gtk/fast/css/focus-ring-outline-width-expected.png: Added.
- platform/gtk/fast/css/focus-ring-outline-width-expected.txt: Added.
- platform/gtk/fast/forms/placeholder-position-expected.checksum: Added.
- platform/gtk/fast/forms/placeholder-position-expected.png: Added.
- platform/gtk/fast/forms/placeholder-position-expected.txt: Added.
- platform/gtk/fast/html/marquee-scrollamount-expected.checksum: Added.
- platform/gtk/fast/html/marquee-scrollamount-expected.png: Added.
- platform/gtk/fast/html/marquee-scrollamount-expected.txt: Added.
- platform/gtk/fast/images/gray-scale-jpeg-with-color-profile-expected.checksum: Added.
- platform/gtk/fast/images/gray-scale-jpeg-with-color-profile-expected.png: Added.
- platform/gtk/fast/images/gray-scale-jpeg-with-color-profile-expected.txt: Added.
- platform/gtk/fast/images/imagemap-focus-ring-outline-color-expected.txt: Added.
- platform/gtk/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.checksum: Added.
- platform/gtk/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.png: Added.
- platform/gtk/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.txt: Added.
- platform/gtk/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.txt: Added.
- platform/gtk/fast/images/imagemap-focus-ring-zoom-expected.txt: Added.
- platform/gtk/fast/multicol/span/anonymous-before-child-parent-crash-expected.checksum: Added.
- platform/gtk/fast/multicol/span/anonymous-before-child-parent-crash-expected.png: Added.
- platform/gtk/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt: Added.
- platform/gtk/fast/multicol/span/anonymous-split-block-crash-expected.checksum: Added.
- platform/gtk/fast/multicol/span/anonymous-split-block-crash-expected.png: Added.
- platform/gtk/fast/multicol/span/anonymous-split-block-crash-expected.txt: Added.
- platform/gtk/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.checksum: Added.
- platform/gtk/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png: Added.
- platform/gtk/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Added.
- platform/gtk/fast/overflow/overflow-rtl-vertical-expected.checksum: Added.
- platform/gtk/fast/overflow/overflow-rtl-vertical-expected.png: Added.
- platform/gtk/fast/overflow/overflow-rtl-vertical-expected.txt: Added.
- platform/gtk/fast/overflow/overflow-update-transform-expected.checksum: Added.
- platform/gtk/fast/overflow/overflow-update-transform-expected.png: Added.
- platform/gtk/fast/overflow/overflow-update-transform-expected.txt: Added.
- platform/gtk/fast/ruby/nested-ruby-expected.checksum: Added.
- platform/gtk/fast/ruby/nested-ruby-expected.png: Added.
- platform/gtk/fast/ruby/nested-ruby-expected.txt: Added.
- platform/gtk/fast/text/emphasis-expected.checksum: Added.
- platform/gtk/fast/text/emphasis-expected.png: Added.
- platform/gtk/fast/text/emphasis-expected.txt: Added.
- platform/gtk/fast/text/emphasis-vertical-expected.checksum: Added.
- platform/gtk/fast/text/emphasis-vertical-expected.png: Added.
- platform/gtk/fast/text/emphasis-vertical-expected.txt: Added.
- platform/gtk/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum: Added.
- platform/gtk/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Added.
- platform/gtk/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Added.
- platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum: Added.
- platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png: Added.
- platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt: Added.
- platform/gtk/svg/custom/image-rescale-clip-expected.checksum: Added.
- platform/gtk/svg/custom/image-rescale-clip-expected.png: Added.
- platform/gtk/svg/custom/image-rescale-clip-expected.txt: Added.
- platform/gtk/svg/custom/image-rescale-scroll-expected.checksum: Added.
- platform/gtk/svg/custom/image-rescale-scroll-expected.png: Added.
- platform/gtk/svg/custom/image-rescale-scroll-expected.txt: Added.
- platform/gtk/svg/dom/SVGPathSegList-cloning-expected.checksum: Added.
- platform/gtk/svg/dom/SVGPathSegList-cloning-expected.png: Added.
- platform/gtk/svg/dom/SVGPathSegList-cloning-expected.txt: Added.
- platform/gtk/svg/dom/SVGPathSegList-segment-modification-expected.checksum: Added.
- platform/gtk/svg/dom/SVGPathSegList-segment-modification-expected.png: Added.
- platform/gtk/svg/dom/SVGPathSegList-segment-modification-expected.txt: Added.
- platform/gtk/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.checksum: Added.
- platform/gtk/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.png: Added.
- platform/gtk/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.txt: Added.
- platform/gtk/svg/filters/feColorMatrix-offset-expected.checksum: Added.
- platform/gtk/svg/filters/feColorMatrix-offset-expected.png: Added.
- platform/gtk/svg/filters/feColorMatrix-offset-expected.txt: Added.
- 6:59 PM Changeset in webkit [75223] by
-
- 2 edits in trunk/LayoutTests
2011-01-06 Stephen White <senorblanco@chromium.org>
Unreviewed; yet another test expectations update.
- platform/chromium/test_expectations.txt:
- 6:52 PM Changeset in webkit [75222] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
2011-01-06 Ojan Vafai <ojan@chromium.org>
Fix line context when replying to comments.
- code-review.js:
- 6:35 PM Changeset in webkit [75221] by
-
- 2 edits4 adds in trunk/LayoutTests
2011-01-06 Stephen White <senorblanco@chromium.org>
Unreviewed; test expectations update.
Add new results for new tests introduced in r75097.
- platform/chromium-mac/fast/gradients/css3-repeating-linear-gradients-expected.checksum: Added.
- platform/chromium-mac/fast/gradients/css3-repeating-linear-gradients-expected.png: Added.
- platform/chromium-win/fast/gradients/css3-repeating-linear-gradients-expected.checksum: Added.
- platform/chromium-win/fast/gradients/css3-repeating-linear-gradients-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 6:25 PM Changeset in webkit [75220] by
-
- 2 edits in trunk/LayoutTests
2011-01-06 Robert Hogan <robert@webkit.org>
[Qt] Update expected results after r75177
Unreviewed, update expected results.
- platform/qt/fast/dom/prototype-inheritance-expected.txt:
- 6:11 PM Changeset in webkit [75219] by
-
- 3 edits in trunk/LayoutTests
2011-01-06 Martin Robinson <mrobinson@igalia.com>
Reviewed by Adam Barth.
fast/dom/Window/window-postmessage-clone.html may fail on platforms with larger fonts
https://bugs.webkit.org/show_bug.cgi?id=52027
Move the console output div after the file input control in
fast/dom/Window/window-postmessage-clone.html so that console
text does not push it outside of the viewport.
- fast/dom/Window/window-postmessage-clone-expected.txt: Updated results to match new text output.
- fast/dom/Window/window-postmessage-clone.html: Moved console div.
- 6:06 PM Changeset in webkit [75218] by
-
- 2 edits in trunk/LayoutTests
2011-01-06 Martin Robinson <mrobinson@igalia.com>
Update GTK+-specific results after r75177.
- platform/gtk/fast/dom/prototype-inheritance-expected.txt: Update results.
- 5:58 PM Changeset in webkit [75217] by
-
- 17 edits4 adds in trunk
2011-01-06 Jenn Braithwaite <jennb@chromium.org>
Reviewed by Dmitry Titov.
When a live frame is moved between pages, some plug-in DOM methods cease to function
https://bugs.webkit.org/show_bug.cgi?id=45770
- fast/frames/iframe-reparenting-plugins-expected.txt: Added.
- fast/frames/iframe-reparenting-plugins.html: Added.
- fast/frames/resources/iframe-reparenting-plugins-iframe-content.html: Added.
- fast/frames/resources/iframe-reparenting-plugins-new-page.html: Added.
2011-01-06 Jenn Braithwaite <jennb@chromium.org>
Reviewed by Dmitry Titov.
When a live frame is moved between pages, some plug-in DOM methods cease to function
https://bugs.webkit.org/show_bug.cgi?id=45770
Test: fast/frames/iframe-reparenting-plugins.html
- page/Frame.cpp: (WebCore::Frame::~Frame): (WebCore::Frame::addObserver): (WebCore::Frame::removeObserver):
- page/Frame.h: (WebCore::FrameDestructionObserver::~FrameDestructionObserver): Added observer to be notified when frame is destroyed.
- page/Page.cpp: (WebCore::Page::~Page): (WebCore::Page::refreshPlugins): PluginData no longer stores page pointer.
- plugins/DOMMimeType.cpp: (WebCore::DOMMimeType::DOMMimeType): (WebCore::DOMMimeType::~DOMMimeType): (WebCore::DOMMimeType::enabledPlugin):
- plugins/DOMMimeType.h: (WebCore::DOMMimeType::create): (WebCore::DOMMimeType::frameDestroyed): Store frame instead of page pointer in DOMMimeType.
- plugins/DOMMimeTypeArray.cpp: (WebCore::DOMMimeTypeArray::item): (WebCore::DOMMimeTypeArray::namedItem): Provide frame to create DOMMimeType.
- plugins/DOMPlugin.cpp: (WebCore::DOMPlugin::DOMPlugin): (WebCore::DOMPlugin::~DOMPlugin): (WebCore::DOMPlugin::item): (WebCore::DOMPlugin::namedItem):
- plugins/DOMPlugin.h: (WebCore::DOMPlugin::create): (WebCore::DOMPlugin::frameDestroyed): Store frame instead of page pointer in DOMPlugin.
- plugins/DOMPluginArray.cpp: (WebCore::DOMPluginArray::item): (WebCore::DOMPluginArray::namedItem): Provide frame to create DOMPlugin.
- plugins/PluginData.cpp: (WebCore::PluginData::PluginData): (WebCore::PluginData::initPlugins):
- plugins/PluginData.h: No longer stores a pointer to the page. Added page parameter to initPlugins.
- plugins/PluginDataNone.cpp: (WebCore::PluginData::initPlugins):
- plugins/chromium/PluginDataChromium.cpp: (WebCore::PluginData::initPlugins):
- plugins/gtk/PluginDataGtk.cpp: (WebCore::PluginData::initPlugins):
- plugins/wx/PluginDataWx.cpp: (WebCore::PluginData::initPlugins): Updated platforms to add (unused) page parameter to initPlugins.
- 5:55 PM Changeset in webkit [75216] by
-
- 2 edits in trunk/LayoutTests
2011-01-06 Stephen White <senorblanco@chromium.org>
Unreviewed; test expectations update.
- platform/chromium-gpu/test_expectations.txt: Remove duplicate expectations.
- 5:45 PM Changeset in webkit [75215] by
-
- 2 edits25 adds in trunk/LayoutTests
2011-01-06 Mihai Parparita <mihaip@chromium.org>
Unreviewed, test expectation update.
Add mac-leopard baselines for tests that currently have Snow Leopard
baselines in platform/mac.
- platform/mac-leopard/fast/multicol/client-rects-expected.checksum:
- platform/mac-leopard/fast/multicol/client-rects-expected.png: Added.
- platform/mac-leopard/fast/multicol/column-break-with-balancing-expected.checksum: Added.
- platform/mac-leopard/fast/multicol/column-break-with-balancing-expected.png: Added.
- platform/mac-leopard/fast/multicol/float-multicol-expected.checksum: Added.
- platform/mac-leopard/fast/multicol/float-multicol-expected.png: Added.
- platform/mac-leopard/fast/multicol/float-paginate-complex-expected.checksum: Added.
- platform/mac-leopard/fast/multicol/float-paginate-complex-expected.png: Added.
- platform/mac-leopard/fast/multicol/float-paginate-expected.checksum: Added.
- platform/mac-leopard/fast/multicol/float-paginate-expected.png: Added.
- platform/mac-leopard/fast/multicol/layers-in-multicol-expected.checksum: Added.
- platform/mac-leopard/fast/multicol/layers-in-multicol-expected.png: Added.
- platform/mac-leopard/fast/multicol/layers-split-across-columns-expected.checksum: Added.
- platform/mac-leopard/fast/multicol/layers-split-across-columns-expected.png: Added.
- platform/mac-leopard/fast/multicol/paginate-block-replaced-expected.checksum: Added.
- platform/mac-leopard/fast/multicol/paginate-block-replaced-expected.png: Added.
- platform/mac-leopard/fast/multicol/span/anonymous-style-inheritance-expected.checksum: Added.
- platform/mac-leopard/fast/multicol/span/anonymous-style-inheritance-expected.png: Added.
- platform/mac-leopard/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.checksum: Added.
- platform/mac-leopard/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png: Added.
- platform/mac-leopard/fast/multicol/span/span-as-nested-columns-child-expected.checksum: Added.
- platform/mac-leopard/fast/multicol/span/span-as-nested-columns-child-expected.png: Added.
- platform/mac-leopard/fast/multicol/table-vertical-align-expected.checksum: Added.
- platform/mac-leopard/fast/multicol/table-vertical-align-expected.png: Added.
- platform/mac-leopard/fast/repaint/overflow-scroll-body-appear-expected.checksum: Added.
- platform/mac-leopard/fast/repaint/overflow-scroll-body-appear-expected.png: Added.
- 5:43 PM Changeset in webkit [75214] by
-
- 13 edits in trunk
2011-01-05 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Define GC3D types to match GL types and use them in GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=45557
- src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DInternal::bindAttribLocation): (WebCore::GraphicsContext3DInternal::bufferData): (WebCore::GraphicsContext3DInternal::bufferSubData): (WebCore::GraphicsContext3DInternal::getActiveAttrib): (WebCore::GraphicsContext3DInternal::getActiveUniform): (WebCore::GraphicsContext3DInternal::getAttribLocation): (WebCore::GraphicsContext3DInternal::getString): (WebCore::GraphicsContext3DInternal::getUniformLocation): (WebCore::GraphicsContext3DInternal::texImage2D): (WebCore::GraphicsContext3DInternal::texSubImage2D): (WebCore::GraphicsContext3DInternal::uniform1fv): (WebCore::GraphicsContext3DInternal::uniform1iv): (WebCore::GraphicsContext3DInternal::uniform2fv): (WebCore::GraphicsContext3DInternal::uniform2iv): (WebCore::GraphicsContext3DInternal::uniform3fv): (WebCore::GraphicsContext3DInternal::uniform3iv): (WebCore::GraphicsContext3DInternal::uniform4fv): (WebCore::GraphicsContext3DInternal::uniform4iv): (WebCore::GraphicsContext3DInternal::uniformMatrix2fv): (WebCore::GraphicsContext3DInternal::uniformMatrix3fv): (WebCore::GraphicsContext3DInternal::uniformMatrix4fv):
- src/GraphicsContext3DInternal.h:
2011-01-05 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Define GC3D types to match GL types and use them in GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=45557
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::readPixels): (WebCore::WebGLRenderingContext::validateTexFuncData):
- platform/graphics/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::texImage2DResourceSafe): (WebCore::GraphicsContext3D::computeFormatAndTypeParameters): (WebCore::GraphicsContext3D::extractImageData): (WebCore::GraphicsContext3D::extractTextureData):
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/cg/GraphicsContext3DCG.cpp: (WebCore::GraphicsContext3D::getImageData):
- platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::enable): (WebCore::SharedGraphicsContext3D::disable): (WebCore::SharedGraphicsContext3D::clear): (WebCore::SharedGraphicsContext3D::drawArrays): (WebCore::SharedGraphicsContext3D::getError): (WebCore::SharedGraphicsContext3D::getIntegerv): (WebCore::SharedGraphicsContext3D::createFramebuffer): (WebCore::SharedGraphicsContext3D::createTexture): (WebCore::SharedGraphicsContext3D::deleteFramebuffer): (WebCore::SharedGraphicsContext3D::deleteTexture): (WebCore::SharedGraphicsContext3D::framebufferTexture2D): (WebCore::SharedGraphicsContext3D::texParameteri): (WebCore::SharedGraphicsContext3D::texImage2D): (WebCore::SharedGraphicsContext3D::texSubImage2D): (WebCore::SharedGraphicsContext3D::readPixels): (WebCore::SharedGraphicsContext3D::setActiveTexture): (WebCore::SharedGraphicsContext3D::bindTexture): (WebCore::SharedGraphicsContext3D::bindFramebuffer):
- platform/graphics/gpu/SharedGraphicsContext3D.h:
- platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: (WebCore::GraphicsContext3D::activeTexture): (WebCore::GraphicsContext3D::attachShader): (WebCore::GraphicsContext3D::bindAttribLocation): (WebCore::GraphicsContext3D::bindBuffer): (WebCore::GraphicsContext3D::bindFramebuffer): (WebCore::GraphicsContext3D::bindRenderbuffer): (WebCore::GraphicsContext3D::bindTexture): (WebCore::GraphicsContext3D::blendColor): (WebCore::GraphicsContext3D::blendEquation): (WebCore::GraphicsContext3D::blendEquationSeparate): (WebCore::GraphicsContext3D::blendFunc): (WebCore::GraphicsContext3D::blendFuncSeparate): (WebCore::GraphicsContext3D::bufferData): (WebCore::GraphicsContext3D::bufferSubData): (WebCore::GraphicsContext3D::checkFramebufferStatus): (WebCore::GraphicsContext3D::clearColor): (WebCore::GraphicsContext3D::clear): (WebCore::GraphicsContext3D::clearDepth): (WebCore::GraphicsContext3D::clearStencil): (WebCore::GraphicsContext3D::colorMask): (WebCore::GraphicsContext3D::compileShader): (WebCore::GraphicsContext3D::copyTexImage2D): (WebCore::GraphicsContext3D::copyTexSubImage2D): (WebCore::GraphicsContext3D::cullFace): (WebCore::GraphicsContext3D::depthFunc): (WebCore::GraphicsContext3D::depthMask): (WebCore::GraphicsContext3D::depthRange): (WebCore::GraphicsContext3D::detachShader): (WebCore::GraphicsContext3D::disable): (WebCore::GraphicsContext3D::disableVertexAttribArray): (WebCore::GraphicsContext3D::drawArrays): (WebCore::GraphicsContext3D::drawElements): (WebCore::GraphicsContext3D::enable): (WebCore::GraphicsContext3D::enableVertexAttribArray): (WebCore::GraphicsContext3D::framebufferRenderbuffer): (WebCore::GraphicsContext3D::framebufferTexture2D): (WebCore::GraphicsContext3D::frontFace): (WebCore::GraphicsContext3D::generateMipmap): (WebCore::GraphicsContext3D::getActiveAttrib): (WebCore::GraphicsContext3D::getActiveUniform): (WebCore::GraphicsContext3D::getAttachedShaders): (WebCore::GraphicsContext3D::getAttribLocation): (WebCore::GraphicsContext3D::getError): (WebCore::GraphicsContext3D::getString): (WebCore::GraphicsContext3D::hint): (WebCore::GraphicsContext3D::isBuffer): (WebCore::GraphicsContext3D::isEnabled): (WebCore::GraphicsContext3D::isFramebuffer): (WebCore::GraphicsContext3D::isProgram): (WebCore::GraphicsContext3D::isRenderbuffer): (WebCore::GraphicsContext3D::isShader): (WebCore::GraphicsContext3D::isTexture): (WebCore::GraphicsContext3D::lineWidth): (WebCore::GraphicsContext3D::linkProgram): (WebCore::GraphicsContext3D::pixelStorei): (WebCore::GraphicsContext3D::polygonOffset): (WebCore::GraphicsContext3D::readPixels): (WebCore::GraphicsContext3D::renderbufferStorage): (WebCore::GraphicsContext3D::sampleCoverage): (WebCore::GraphicsContext3D::scissor): (WebCore::GraphicsContext3D::stencilFunc): (WebCore::GraphicsContext3D::stencilFuncSeparate): (WebCore::GraphicsContext3D::stencilMask): (WebCore::GraphicsContext3D::stencilMaskSeparate): (WebCore::GraphicsContext3D::stencilOp): (WebCore::GraphicsContext3D::stencilOpSeparate): (WebCore::GraphicsContext3D::texParameterf): (WebCore::GraphicsContext3D::texParameteri): (WebCore::GraphicsContext3D::uniform1f): (WebCore::GraphicsContext3D::uniform1fv): (WebCore::GraphicsContext3D::uniform2f): (WebCore::GraphicsContext3D::uniform2fv): (WebCore::GraphicsContext3D::uniform3f): (WebCore::GraphicsContext3D::uniform3fv): (WebCore::GraphicsContext3D::uniform4f): (WebCore::GraphicsContext3D::uniform4fv): (WebCore::GraphicsContext3D::uniform1i): (WebCore::GraphicsContext3D::uniform1iv): (WebCore::GraphicsContext3D::uniform2i): (WebCore::GraphicsContext3D::uniform2iv): (WebCore::GraphicsContext3D::uniform3i): (WebCore::GraphicsContext3D::uniform3iv): (WebCore::GraphicsContext3D::uniform4i): (WebCore::GraphicsContext3D::uniform4iv): (WebCore::GraphicsContext3D::uniformMatrix2fv): (WebCore::GraphicsContext3D::uniformMatrix3fv): (WebCore::GraphicsContext3D::uniformMatrix4fv): (WebCore::GraphicsContext3D::useProgram): (WebCore::GraphicsContext3D::validateProgram): (WebCore::GraphicsContext3D::vertexAttrib1f): (WebCore::GraphicsContext3D::vertexAttrib1fv): (WebCore::GraphicsContext3D::vertexAttrib2f): (WebCore::GraphicsContext3D::vertexAttrib2fv): (WebCore::GraphicsContext3D::vertexAttrib3f): (WebCore::GraphicsContext3D::vertexAttrib3fv): (WebCore::GraphicsContext3D::vertexAttrib4f): (WebCore::GraphicsContext3D::vertexAttrib4fv): (WebCore::GraphicsContext3D::vertexAttribPointer): (WebCore::GraphicsContext3D::viewport): (WebCore::GraphicsContext3D::getBooleanv): (WebCore::GraphicsContext3D::getBufferParameteriv): (WebCore::GraphicsContext3D::getFloatv): (WebCore::GraphicsContext3D::getFramebufferAttachmentParameteriv): (WebCore::GraphicsContext3D::getIntegerv): (WebCore::GraphicsContext3D::getProgramiv): (WebCore::GraphicsContext3D::getProgramInfoLog): (WebCore::GraphicsContext3D::getRenderbufferParameteriv): (WebCore::GraphicsContext3D::getShaderiv): (WebCore::GraphicsContext3D::getShaderInfoLog): (WebCore::GraphicsContext3D::getTexParameterfv): (WebCore::GraphicsContext3D::getTexParameteriv): (WebCore::GraphicsContext3D::getUniformfv): (WebCore::GraphicsContext3D::getUniformiv): (WebCore::GraphicsContext3D::getUniformLocation): (WebCore::GraphicsContext3D::getVertexAttribfv): (WebCore::GraphicsContext3D::getVertexAttribiv): (WebCore::GraphicsContext3D::getVertexAttribOffset): (WebCore::GraphicsContext3D::texImage2D): (WebCore::GraphicsContext3D::texSubImage2D): (WebCore::GraphicsContext3D::createBuffer): (WebCore::GraphicsContext3D::createFramebuffer): (WebCore::GraphicsContext3D::createProgram): (WebCore::GraphicsContext3D::createRenderbuffer): (WebCore::GraphicsContext3D::createShader): (WebCore::GraphicsContext3D::createTexture): (WebCore::GraphicsContext3D::deleteBuffer): (WebCore::GraphicsContext3D::deleteFramebuffer): (WebCore::GraphicsContext3D::deleteProgram): (WebCore::GraphicsContext3D::deleteRenderbuffer): (WebCore::GraphicsContext3D::deleteShader): (WebCore::GraphicsContext3D::deleteTexture): (WebCore::GraphicsContext3D::sizeInBytes): (WebCore::GraphicsContext3D::synthesizeGLError):
- platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::activeTexture): (WebCore::GraphicsContext3D::attachShader): (WebCore::GraphicsContext3D::getAttachedShaders): (WebCore::GraphicsContext3D::bindAttribLocation): (WebCore::GraphicsContext3D::bindBuffer): (WebCore::GraphicsContext3D::bindFramebuffer): (WebCore::GraphicsContext3D::bindRenderbuffer): (WebCore::GraphicsContext3D::bindTexture): (WebCore::GraphicsContext3D::blendColor): (WebCore::GraphicsContext3D::blendEquation): (WebCore::GraphicsContext3D::blendEquationSeparate): (WebCore::GraphicsContext3D::blendFunc): (WebCore::GraphicsContext3D::blendFuncSeparate): (WebCore::GraphicsContext3D::bufferData): (WebCore::GraphicsContext3D::bufferSubData): (WebCore::GraphicsContext3D::checkFramebufferStatus): (WebCore::GraphicsContext3D::clearColor): (WebCore::GraphicsContext3D::clear): (WebCore::GraphicsContext3D::clearDepth): (WebCore::GraphicsContext3D::clearStencil): (WebCore::GraphicsContext3D::colorMask): (WebCore::GraphicsContext3D::compileShader): (WebCore::GraphicsContext3D::copyTexImage2D): (WebCore::GraphicsContext3D::copyTexSubImage2D): (WebCore::GraphicsContext3D::cullFace): (WebCore::GraphicsContext3D::depthFunc): (WebCore::GraphicsContext3D::depthMask): (WebCore::GraphicsContext3D::depthRange): (WebCore::GraphicsContext3D::detachShader): (WebCore::GraphicsContext3D::disable): (WebCore::GraphicsContext3D::disableVertexAttribArray): (WebCore::GraphicsContext3D::drawArrays): (WebCore::GraphicsContext3D::drawElements): (WebCore::GraphicsContext3D::enable): (WebCore::GraphicsContext3D::enableVertexAttribArray): (WebCore::GraphicsContext3D::framebufferRenderbuffer): (WebCore::GraphicsContext3D::framebufferTexture2D): (WebCore::GraphicsContext3D::frontFace): (WebCore::GraphicsContext3D::generateMipmap): (WebCore::GraphicsContext3D::getActiveAttrib): (WebCore::GraphicsContext3D::getActiveUniform): (WebCore::GraphicsContext3D::getAttribLocation): (WebCore::GraphicsContext3D::getError): (WebCore::GraphicsContext3D::getString): (WebCore::GraphicsContext3D::hint): (WebCore::GraphicsContext3D::isBuffer): (WebCore::GraphicsContext3D::isEnabled): (WebCore::GraphicsContext3D::isFramebuffer): (WebCore::GraphicsContext3D::isProgram): (WebCore::GraphicsContext3D::isRenderbuffer): (WebCore::GraphicsContext3D::isShader): (WebCore::GraphicsContext3D::isTexture): (WebCore::GraphicsContext3D::linkProgram): (WebCore::GraphicsContext3D::pixelStorei): (WebCore::GraphicsContext3D::polygonOffset): (WebCore::GraphicsContext3D::readPixels): (WebCore::GraphicsContext3D::renderbufferStorage): (WebCore::GraphicsContext3D::sampleCoverage): (WebCore::GraphicsContext3D::scissor): (WebCore::GraphicsContext3D::stencilFunc): (WebCore::GraphicsContext3D::stencilFuncSeparate): (WebCore::GraphicsContext3D::stencilMask): (WebCore::GraphicsContext3D::stencilMaskSeparate): (WebCore::GraphicsContext3D::stencilOp): (WebCore::GraphicsContext3D::stencilOpSeparate): (WebCore::GraphicsContext3D::texParameterf): (WebCore::GraphicsContext3D::texParameteri): (WebCore::GraphicsContext3D::uniform1f): (WebCore::GraphicsContext3D::uniform1fv): (WebCore::GraphicsContext3D::uniform2f): (WebCore::GraphicsContext3D::uniform2fv): (WebCore::GraphicsContext3D::uniform3f): (WebCore::GraphicsContext3D::uniform3fv): (WebCore::GraphicsContext3D::uniform4f): (WebCore::GraphicsContext3D::uniform4fv): (WebCore::GraphicsContext3D::uniform1i): (WebCore::GraphicsContext3D::uniform1iv): (WebCore::GraphicsContext3D::uniform2i): (WebCore::GraphicsContext3D::uniform2iv): (WebCore::GraphicsContext3D::uniform3i): (WebCore::GraphicsContext3D::uniform3iv): (WebCore::GraphicsContext3D::uniform4i): (WebCore::GraphicsContext3D::uniform4iv): (WebCore::GraphicsContext3D::uniformMatrix2fv): (WebCore::GraphicsContext3D::uniformMatrix3fv): (WebCore::GraphicsContext3D::uniformMatrix4fv): (WebCore::GraphicsContext3D::useProgram): (WebCore::GraphicsContext3D::validateProgram): (WebCore::GraphicsContext3D::vertexAttrib1f): (WebCore::GraphicsContext3D::vertexAttrib1fv): (WebCore::GraphicsContext3D::vertexAttrib2f): (WebCore::GraphicsContext3D::vertexAttrib2fv): (WebCore::GraphicsContext3D::vertexAttrib3f): (WebCore::GraphicsContext3D::vertexAttrib3fv): (WebCore::GraphicsContext3D::vertexAttrib4f): (WebCore::GraphicsContext3D::vertexAttrib4fv): (WebCore::GraphicsContext3D::vertexAttribPointer): (WebCore::GraphicsContext3D::viewport): (WebCore::GraphicsContext3D::getBooleanv): (WebCore::GraphicsContext3D::getBufferParameteriv): (WebCore::GraphicsContext3D::getFloatv): (WebCore::GraphicsContext3D::getFramebufferAttachmentParameteriv): (WebCore::GraphicsContext3D::getIntegerv): (WebCore::GraphicsContext3D::getProgramiv): (WebCore::GraphicsContext3D::getProgramInfoLog): (WebCore::GraphicsContext3D::getRenderbufferParameteriv): (WebCore::GraphicsContext3D::getShaderiv): (WebCore::GraphicsContext3D::getShaderInfoLog): (WebCore::GraphicsContext3D::getShaderSource): (WebCore::GraphicsContext3D::getTexParameterfv): (WebCore::GraphicsContext3D::getTexParameteriv): (WebCore::GraphicsContext3D::getUniformfv): (WebCore::GraphicsContext3D::getUniformiv): (WebCore::GraphicsContext3D::getUniformLocation): (WebCore::GraphicsContext3D::getVertexAttribfv): (WebCore::GraphicsContext3D::getVertexAttribiv): (WebCore::GraphicsContext3D::getVertexAttribOffset): (WebCore::GraphicsContext3D::texImage2D): (WebCore::GraphicsContext3D::texSubImage2D): (WebCore::GraphicsContext3D::createBuffer): (WebCore::GraphicsContext3D::createFramebuffer): (WebCore::GraphicsContext3D::createProgram): (WebCore::GraphicsContext3D::createRenderbuffer): (WebCore::GraphicsContext3D::createShader): (WebCore::GraphicsContext3D::createTexture): (WebCore::GraphicsContext3D::deleteBuffer): (WebCore::GraphicsContext3D::deleteFramebuffer): (WebCore::GraphicsContext3D::deleteProgram): (WebCore::GraphicsContext3D::deleteRenderbuffer): (WebCore::GraphicsContext3D::deleteShader): (WebCore::GraphicsContext3D::deleteTexture): (WebCore::GraphicsContext3D::sizeInBytes): (WebCore::GraphicsContext3D::synthesizeGLError): (WebCore::GraphicsContext3D::getImageData):
- platform/graphics/skia/GraphicsContext3DSkia.cpp: (WebCore::GraphicsContext3D::getImageData):
- 5:03 PM Changeset in webkit [75213] by
-
- 2 edits in trunk/LayoutTests
2011-01-06 Stephen White <senorblanco@chromium.org>
Unreviewed; chromium test expectations update.
- platform/chromium/test_expectations.txt: Add some expected "failing" tests post-r75205.
- 4:47 PM Changeset in webkit [75212] by
-
- 2 edits in trunk/LayoutTests
2011-01-06 Stephen White <senorblanco@chromium.org>
Unreviewed; chromium test expectations update.
- platform/chromium/test_expectations.txt: Remove duplicate expectations.
- 4:39 PM Changeset in webkit [75211] by
-
- 2 edits in trunk/Tools
2011-01-06 Steve Falkenburg <sfalken@apple.com>
Reviewed by Stephanie Lewis.
Fix syntax error in script.
Windows bots need to archive/unarchive builds to/from configuration-specific directories
https://bugs.webkit.org/show_bug.cgi?id=51996
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
- 4:38 PM Changeset in webkit [75210] by
-
- 7 edits in trunk/Source/JavaScriptCore
Bug 52021 - zeroDouble broken on ARMv7
Reviewed by Darin Adler.
The bug here is that zeroDouble was working incorrectly,
leading to op_loop_if_true failing - specifically in the
case where the value being checked is 0.0 encoded as a
double (rather than an integer immediate).
Additionally this patch removes a redundant duplicate compare
in some (many) case.
- assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::vcmp_F64):
(JSC::ARMv7Assembler::vcmpz_F64):
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::branchDoubleNonZero):
(JSC::MacroAssemblerARM::branchDoubleZeroOrNaN):
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::branchDouble):
(JSC::MacroAssemblerARMv7::branchDoubleNonZero):
(JSC::MacroAssemblerARMv7::branchDoubleZeroOrNaN):
(JSC::MacroAssemblerARMv7::compare32):
- assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::branchDoubleNonZero):
(JSC::MacroAssemblerMIPS::branchDoubleZeroOrNaN):
- assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::branchDoubleNonZero):
(JSC::MacroAssemblerX86Common::branchDoubleZeroOrNaN):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_jfalse):
(JSC::JIT::emit_op_jtrue):
- 4:24 PM Changeset in webkit [75209] by
-
- 5 edits in trunk
2011-01-06 Martin Robinson <mrobinson@igalia.com>
Reviewed by Eric Seidel.
[GTK] Initial build support for WebGL
https://bugs.webkit.org/show_bug.cgi?id=51716
- configure.ac: Add a configure option for WebGL.
2011-01-06 Martin Robinson <mrobinson@igalia.com>
Reviewed by Eric Seidel.
[GTK] Initial build support for WebGL
https://bugs.webkit.org/show_bug.cgi?id=51716
Add initial build support for WebGL and insert bits of implementation
necessary for clean compilation into GraphicsContext3D.
No new tests. This is just a build change.
- GNUmakefile.am: Add missing files to the source lists.
- platform/graphics/GraphicsContext3D.h: Include IntSize.h as it's used below. Include typedefs necessary for WebGL on GTK+ and consolidate typdefs which are the same across different platforms. X11 headers define the VERSION symbol, so it's necessary to undefine it, since it's used as an enum value.
- 4:17 PM Changeset in webkit [75208] by
-
- 5 edits in trunk
2011-01-06 Michael Saboff <msaboff@apple.com>
Reviewed by Gavin Barraclough.
Enhancement: Add Regexp Debug Compare between JIT and Interpreter
https://bugs.webkit.org/show_bug.cgi?id=51834
- JavaScriptCore: Copied from JavaScriptCore.
2011-01-06 Michael Saboff <msaboff@apple.com>
Reviewed by Gavin Barraclough.
Added debug code to compare the results of JIT regexp with
interpreted regexp and displays discrepencies. This debug code is
controlled by the ENABLE_YARR_JIT_DEBUG macro in wtf/Platform.h and
is only valid if ENABLE_YARR_JIT is enabled.
Fixed a discovered problem in RegExp::printTraceData, changing
m_pattern to the getter pattern().
Also deleted an extraneous semicolon.
Enhancement: Add Regexp Debug Compare between JIT and Interpreter
https://bugs.webkit.org/show_bug.cgi?id=51834
- runtime/RegExp.cpp: (JSC::RegExp::compile): (JSC::RegExp::match): (JSC::RegExp::printTraceData):
- wtf/Platform.h:
- 4:08 PM Changeset in webkit [75207] by
-
- 2 edits in trunk/WebCore
2011-01-06 Helder Correia <helder@sencha.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] GraphicsContext::drawConvexPolygon() has unnecessary code for shadow
https://bugs.webkit.org/show_bug.cgi?id=52014
The function is only used by RenderObject to draw box sides.
The shadow branch is never used and thus can be removed.
No new tests are necessary.
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawConvexPolygon):
- 3:39 PM Changeset in webkit [75206] by
-
- 2 edits in trunk/WebCore
2011-01-06 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Make sure touch is disabled in the minimal configuration
https://bugs.webkit.org/show_bug.cgi?id=51316
No new tests as there is no new functionality.
- features.pri:
- 3:29 PM Changeset in webkit [75205] by
-
- 2 edits5 adds in trunk/LayoutTests
Add/update Windows-specific test results for recent regressions
Bugs:
http://webkit.org/b/52026
http://webkit.org/b/52028
http://webkit.org/b/52029
- platform/win/animations/animation-time-expected.txt: Added.
- platform/win/fast/canvas/canvas-fillRect-gradient-shadow-expected.txt: Added.
- platform/win/fast/css/css3-nth-tokens-script-expected.txt: Added.
- platform/win/fast/css/css3-nth-tokens-style-expected.txt: Added.
- platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
- 3:29 PM Changeset in webkit [75204] by
-
- 2 edits in trunk/LayoutTests
Update Windows results after r75177
- platform/win/fast/dom/prototype-inheritance-expected.txt:
- 3:07 PM Changeset in webkit [75203] by
-
- 2 edits in trunk/Tools
2011-01-06 Laszlo Gombos <Laszlo Gombos>
Unreviewed, fixing WinCE build after r75196.
WinCE port does not (yet) support NPAPI.
- Scripts/build-webkit:
- 2:55 PM Changeset in webkit [75202] by
-
- 6 edits3 adds in trunk
2011-01-06 Martin Robinson <mrobinson@igalia.com>
Reviewed by Eric Seidel.
[GTK] Freetype backend does not support WOFF
https://bugs.webkit.org/show_bug.cgi?id=51904
- platform/gtk/Skipped: Unskip passing WOFF test. Add results.
- platform/gtk/fast/css/font-face-woff-expected.checksum: Added.
- platform/gtk/fast/css/font-face-woff-expected.png: Added.
- platform/gtk/fast/css/font-face-woff-expected.txt: Added.
2011-01-06 Martin Robinson <mrobinson@igalia.com>
Reviewed by Eric Seidel.
[GTK] Freetype backend does not support WOFF
https://bugs.webkit.org/show_bug.cgi?id=51904
- CMakeListsEfl.txt: Add WOFF support to the sources list.
- GNUmakefile.am: Add WOFF support to the sources list.
- platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp: (WebCore::createFontCustomPlatformData): Call the WOFF decoder when appropriate. (WebCore::FontCustomPlatformData::supportsFormat): Advertise support for WOFF.
- 2:51 PM Changeset in webkit [75201] by
-
- 3 edits in trunk/WebKit/gtk
2011-01-06 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
GTK: AX: atk tests need to be updated after recent changes
https://bugs.webkit.org/show_bug.cgi?id=51932
Skip ATK unit tests until we can look into what is causing these failures.
- tests/testatk.c: (main): Skip all tests.
- tests/testatkroles.c: (main): Ditto.
- 2:39 PM Changeset in webkit [75200] by
-
- 23 edits in trunk
2011-01-06 James Simonsen <simonjam@chromium.org>
Reviewed by Darin Fisher.
[Web Timing] Remove vendor prefix
https://bugs.webkit.org/show_bug.cgi?id=48922
- fast/dom/Window/window-properties-performance-expected.txt: Test replaceability.
- fast/dom/Window/window-properties-performance.html: Ditto.
- fast/dom/Window/window-properties.html: Rename to performance.
- fast/dom/resources/navigation-type-matches-querystring.html: Ditto.
- fast/dom/script-tests/prototype-inheritance.js: Ditto.
- fast/dom/script-tests/webtiming-document-open.js: Ditto.
- fast/dom/script-tests/webtiming-navigate-within-document.js: Ditto.
- fast/dom/script-tests/webtiming.js: Ditto.
- http/tests/misc/resources/webtiming-one-redirect.html: Ditto.
- http/tests/misc/resources/webtiming-two-redirects.html: Ditto.
2011-01-06 James Simonsen <simonjam@chromium.org>
Reviewed by Darin Fisher.
[Web Timing] Remove vendor prefix
https://bugs.webkit.org/show_bug.cgi?id=48922
- page/DOMWindow.cpp: (WebCore::DOMWindow::performance): Rename to performance.
- page/DOMWindow.h:
- page/DOMWindow.idl: Rename to performance and make replaceable.
2011-01-06 James Simonsen <simonjam@chromium.org>
Reviewed by Darin Fisher.
[Web Timing] Remove vendor prefix
https://bugs.webkit.org/show_bug.cgi?id=48922
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::performance): Rename to performance.
- 2:26 PM Changeset in webkit [75199] by
-
- 15 edits1 add in trunk/WebCore
2011-01-06 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
https://bugs.webkit.org/show_bug.cgi?id=49388
Changed PlatformCALayer API. Added PlatformCALayerClient abstract class which is
used to communicate from PlatformCALayer to the owner. This replaces passing
GraphicsLayerCA pointer when creating PlatformCALayer. It also includes the
API that used to be in PlatformCALayerLayout. GraphicsLayerCA now implements
the PlatformCALayerClient API.
This change has little impact on the Mac side but makes the Windows
interface simpler, especially when handling video layers on Windows.
- WebCore.xcodeproj/project.pbxproj:
- config.h:
- platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::layerDidDisplay): (WebCore::GraphicsLayer::showDebugBorders): (WebCore::GraphicsLayer::showRepaintCounter):
- platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::platformCALayerAnimationStarted): (WebCore::GraphicsLayerCA::setContentsToImage): (WebCore::GraphicsLayerCA::setContentsToMedia): (WebCore::GraphicsLayerCA::layerDidDisplay): (WebCore::GraphicsLayerCA::updateSublayerList):
- platform/graphics/ca/GraphicsLayerCA.h: (WebCore::GraphicsLayerCA::platformCALayerLayoutSublayersOfLayer): (WebCore::GraphicsLayerCA::platformCALayerRespondsToLayoutChanges): (WebCore::GraphicsLayerCA::platformCALayerContentsOrientation): (WebCore::GraphicsLayerCA::platformCALayerPaintContents): (WebCore::GraphicsLayerCA::platformCALayerShowDebugBorders): (WebCore::GraphicsLayerCA::platformCALayerShowRepaintCounter): (WebCore::GraphicsLayerCA::platformCALayerIncrementRepaintCount): (WebCore::GraphicsLayerCA::platformCALayerContentsOpaque): (WebCore::GraphicsLayerCA::platformCALayerDrawsContent): (WebCore::GraphicsLayerCA::platformCALayerLayerDidDisplay): (WebCore::GraphicsLayerCA::platformCALayer):
- platform/graphics/ca/PlatformCALayer.h: (WebCore::PlatformCALayer::owner): (WebCore::PlatformCALayer::animationStarted):
- platform/graphics/ca/PlatformCALayerClient.h: Added. (WebCore::PlatformCALayerClient::~PlatformCALayerClient):
- platform/graphics/ca/mac/PlatformCALayerMac.mm: (PlatformCALayer::setOwner): (PlatformCALayer::create): (PlatformCALayer::PlatformCALayer): (PlatformCALayer::contents): (PlatformCALayer::setContents):
- platform/graphics/mac/WebGLLayer.mm: (-[WebGLLayer display]):
- platform/graphics/mac/WebLayer.h:
- platform/graphics/mac/WebLayer.mm: (drawLayerContents): (setLayerNeedsDisplayInRect): (-[WebLayer setNeedsDisplay]): (-[WebLayer display]):
- platform/graphics/mac/WebTiledLayer.mm: (-[WebTiledLayer setNeedsDisplay]): (-[WebTiledLayer display]):
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::showDebugBorders): (WebCore::RenderLayerBacking::showRepaintCounter):
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::ensureRootPlatformLayer):
- rendering/RenderLayerCompositor.h: (WebCore::RenderLayerCompositor::compositorShowDebugBorders): (WebCore::RenderLayerCompositor::compositorShowRepaintCounter): (WebCore::RenderLayerCompositor::notifyAnimationStarted): (WebCore::RenderLayerCompositor::notifySyncRequired): (WebCore::RenderLayerCompositor::paintContents): (WebCore::RenderLayerCompositor::showDebugBorders): (WebCore::RenderLayerCompositor::showRepaintCounter):
- 2:07 PM Changeset in webkit [75198] by
-
- 4 edits in trunk
2011-01-06 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Eric Seidel.
Allow framesets after hidden inputs
https://bugs.webkit.org/show_bug.cgi?id=51998
- html5lib/resources/webkit01.dat: Demonstrate that the value of the type attribute matters. An input with no type is tested in tests19.dat.
2011-01-06 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Eric Seidel.
Allow framesets after hidden inputs
https://bugs.webkit.org/show_bug.cgi?id=51998
This implements the HTML5 spec update in response to:
http://www.w3.org/Bugs/Public/show_bug.cgi?id=11156
- html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInBody):
- 2:01 PM Changeset in webkit [75197] by
-
- 2 edits in trunk/Tools
2011-01-06 Xan Lopez <xlopez@igalia.com>
Reviewed by Darin Adler.
File::Spec->rel2abs in sunspider-compare-results mangles parameters
https://bugs.webkit.org/show_bug.cgi?id=52015
- Scripts/sunspider-compare-results: call rel2abs on our arguments after the platform has been detected, otherwise the script will mangle things like '--gtk' into '/a/path/--gtk', breaking the detection.
- 1:49 PM Changeset in webkit [75196] by
-
- 2 edits in trunk/Tools
2011-01-06 Laszlo Gombos <Laszlo Gombos>
Reviewed by Eric Seidel.
Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
https://bugs.webkit.org/show_bug.cgi?id=51346
- Scripts/build-webkit:
- 1:49 PM Changeset in webkit [75195] by
-
- 5 edits in trunk
2010-12-29 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
vertexAttribPointer should raise INVALID_OPERATION if stride/offset is not multiple of the type size
https://bugs.webkit.org/show_bug.cgi?id=51725
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::vertexAttribPointer):
2010-12-29 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
vertexAttribPointer should raise INVALID_OPERATION if stride/offset is not multiple of the type size
https://bugs.webkit.org/show_bug.cgi?id=51725
- fast/canvas/webgl/gl-vertexattribpointer-expected.txt:
- fast/canvas/webgl/gl-vertexattribpointer.html: Sync with khronos.
- 1:42 PM Changeset in webkit [75194] by
-
- 3 edits in trunk/LayoutTests
2011-01-06 Zhenyao Mo <zmo@google.com>
Unreviewed, add glsl-conformance.html to test_expectations.txt temporarily.
- platform/chromium-gpu/test_expectations.txt:
- platform/chromium/test_expectations.txt:
- 1:41 PM Changeset in webkit [75193] by
-
- 2 edits4 copies in branches/chromium/552
Merge 75168
BUG=68558
- 1:32 PM Changeset in webkit [75192] by
-
- 3 edits in trunk/Tools
2011-01-06 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
Windows bots need to archive/unarchive builds to/from configuration-specific directories
https://bugs.webkit.org/show_bug.cgi?id=51996
After the configuration directory change, we were archiving the incorrect directory for
build product, so we were running tests on the wrong binaries.
This change archives the correct directory, and also unarchives it into a configuration-
specific directory.
- BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
- BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
- 1:30 PM Changeset in webkit [75191] by
-
- 4 edits in trunk/Tools
2011-01-06 Eric Seidel <eric@webkit.org>
Reviewed by Mihai Parparita.
commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
https://bugs.webkit.org/show_bug.cgi?id=52002
See an example of this here:
https://bugs.webkit.org/show_bug.cgi?id=51314#c2
It's due to the fact that we pass around TestFailure() instance
objects and yet expect them to all compare to be the same.
This is bad. We should either have shared instances of these values
or we should just pass around the class names. There are already hacks
in place to make TestFailure objects pass equality tests, I just added
a hash implementation so they can be used in sets as expected.
- Scripts/webkitpy/common/net/layouttestresults_unittest.py:
- Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
- 1:19 PM Changeset in webkit [75190] by
-
- 4 edits in trunk
2011-01-06 Patrick Gansterer <Patrick Gansterer>
Reviewed by Eric Seidel.
[WINCE] Remove JSC::g_stackBase
https://bugs.webkit.org/show_bug.cgi?id=51779
- wtf/StackBounds.cpp:
2011-01-06 Patrick Gansterer <Patrick Gansterer>
Reviewed by Eric Seidel.
[WINCE] Remove JSC::g_stackBase
https://bugs.webkit.org/show_bug.cgi?id=51779
- platform/wince/SharedTimerWinCE.cpp: (WebCore::TimerWindowWndProc):
- 12:54 PM Changeset in webkit [75189] by
-
- 13 edits in trunk
2011-01-06 Robert Hogan <robert@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Introduce QDRTNode for passing WebCore::Node across JS bridge
This allows LayoutTestController to pass WebCore::Node back to
layout tests.
Also amend nodesFromRect-links-and-text.html and
nodesFromRect-inner-documents.html so that they do not produce
platform-specific results.
Unskip:
fast/dom/nodesFromRect-links-and-text.html
fast/dom/nodesFromRect-inner-documents.html
- fast/dom/nodesFromRect-inner-documents-expected.txt:
- fast/dom/nodesFromRect-inner-documents.html:
- fast/dom/nodesFromRect-links-and-text-expected.txt:
- fast/dom/nodesFromRect-links-and-text.html:
- fast/dom/resources/nodesFromRect.js: (check): (getTopFor): (getBottomFor):
- platform/qt/Skipped:
2011-01-06 Robert Hogan <robert@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Introduce QDRTNode for passing WebCore::Node across JS bridge
This allows LayoutTestController to pass WebCore::Node back to
layout tests.
Also amend nodesFromRect-links-and-text.html and
nodesFromRect-inner-documents.html so that they do not produce
platform-specific results.
Unskip:
fast/dom/nodesFromRect-links-and-text.html
fast/dom/nodesFromRect-inner-documents.html
- bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtDRTNodeRuntime::create): (JSC::Bindings::QtDRTNodeRuntime::get): (JSC::Bindings::convertValueToQVariant): (JSC::Bindings::convertQVariantToValue):
2011-01-06 Robert Hogan <robert@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Introduce QDRTNode for passing WebCore::Node across JS bridge
This allows LayoutTestController to pass WebCore::Node back to
layout tests.
Also amend nodesFromRect-links-and-text.html and
nodesFromRect-inner-documents.html so that they do not produce
platform-specific results.
Unskip:
fast/dom/nodesFromRect-links-and-text.html
fast/dom/nodesFromRect-inner-documents.html
- WebCoreSupport/DumpRenderTreeSupportQt.cpp: (QDRTNode::QDRTNode): (QDRTNode::~QDRTNode): (DumpRenderTreeSupportQt::nodesFromRect):
- WebCoreSupport/DumpRenderTreeSupportQt.h:
- 12:53 PM Changeset in webkit [75188] by
-
- 8 edits in trunk
2011-01-06 Joone Hur <joone.hur@collabora.co.uk>
Reviewed by Eric Seidel.
WML Parser should treat line/column number in a consistent way
https://bugs.webkit.org/show_bug.cgi?id=51601
Add the equality operators to TextPosition class.
- wtf/text/TextPosition.h: (WTF::TextPosition::operator==): Added. (WTF::TextPosition::operator!=): Added. (WTF::TextPosition::belowRangePosition): Use belowBase() instead of base(). (WTF::ZeroBasedNumber::operator==): Added. (WTF::ZeroBasedNumber::operator!=): Added. (WTF::OneBasedNumber::operator==): Added. (WTF::OneBasedNumber::operator!=): Added.
2011-01-06 Joone Hur <joone.hur@collabora.co.uk>
Reviewed by Eric Seidel.
WML Parser should treat line/column number in a consistent way
https://bugs.webkit.org/show_bug.cgi?id=51601
XML Parser treats line/column number as 1-based values, but WML ErrorHandler treat them as 0-based.
Therefore, this patch allows WML ErrorHandler to use 1-based values.
- dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::handleError): Treat line/column number as 1 based values.
- dom/XMLDocumentParser.h: Make textPositionOneBased public and Add TextPosition1(m_lastErrorPosition) to keep error line/column number.
- dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::XMLDocumentParser): Initialize m_lastErrorPosition.
- dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::XMLDocumentParser): Initialize m_lastErrorPosition.
- wml/WMLErrorHandling.cpp: (WebCore::reportWMLError): Use 1 based value instead of 0 based value to report error line/column number.
- 12:49 PM Changeset in webkit [75187] by
-
- 2 edits in trunk/WebKit2
Always show the arrow cursor when the web process has crashed
Fixes <http://webkit.org/b/52006> WKView shows a stale cursor when the
web process crashes
Reviewed by Ada Chan.
- UIProcess/win/WebView.cpp:
(WebKit::WebView::processDidCrash):
(WebKit::WebView::didRelaunchProcess):
Update the cursor to reflect the new state.
(WebKit::WebView::cursorToShow): Always show the arrow cursor when the
web process has crashed.
- 12:49 PM Changeset in webkit [75186] by
-
- 3 edits in trunk/WebKit2
Reduce code duplication in WebView::updateNativeCursor
Fixes <http://webkit.org/b/52005> It's not easy to add new behavior to
WebView::updateNativeCursor
Reviewed by Ada Chan.
- UIProcess/win/WebView.cpp:
(WebKit::WebView::cursorToShow): Moved code to choose a cursor here...
(WebKit::WebView::updateNativeCursor): ...from here.
- UIProcess/win/WebView.h: Added cursorToShow.
- 12:48 PM Changeset in webkit [75185] by
-
- 2 edits in trunk/WebKit2
Make WKView fill with white when the web process has crashed
Previously we would just draw whatever we had last drawn into the
WKView (i.e., a stale picture of the web page), which was confusing
(because the web page would mysteriously not respond to input) and ugly
(because it wouldn't behave properly if the window was resized).
Fixes <http://webkit.org/b/52004> WKView keeps painting a stale
picture of the web page when the web process crashes
Reviewed by Ada Chan.
- UIProcess/win/WebView.cpp:
(WebKit::WebView::onPaintEvent): Ported code from -[WKView drawRect:]
to fill with white if the page is invalid or has no DrawingArea. As a
bonus, also ported the call to WebPageProxy::didDraw from that method.
(WebKit::WebView::processDidCrash):
(WebKit::WebView::didRelaunchProcess):
Invalidate our window so that we'll redraw with white or the new page.
- 12:48 PM Changeset in webkit [75184] by
-
- 2 edits in trunk/WebKit2
Make WKViews work on Windows after a crashed web process gets relaunched
Fixes <http://webkit.org/b/52001> Relaunching the web process fails to
revivify WKViews on Windows
Reviewed by Ada Chan.
- UIProcess/win/WebView.cpp:
(WebKit::WebView::didRelaunchProcess): Implemented by porting code from
-[WKView _didRelaunchProcess].
- 12:47 PM Changeset in webkit [75183] by
-
- 3 edits in trunk/WebKit2
Remove WebView::m_rect
It was only used in the constructor, and wasn't even kept up-to-date as
the WebView's size changed.
Fixes <http://webkit.org/b/52000> WebView::m_rect is unnecessary
Reviewed by Ada Chan.
- UIProcess/win/WebView.cpp:
- UIProcess/win/WebView.h:
- 12:46 PM Changeset in webkit [75182] by
-
- 3 edits in trunk/WebCore
Remove some dead code from WKCACFLayerRenderer
Fixes <http://webkit.org/b/51954> WKCACFLayerRenderer has dead and
redundant code for reacting to changes to the layer tree
Reviewed by Sam Weinig.
- platform/graphics/win/WKCACFLayerRenderer.cpp:
- platform/graphics/win/WKCACFLayerRenderer.h:
Removed didFlushContext and the HashMap it depended on. We react to
changes to the layer tree in layerTreeDidChange instead.
- 12:44 PM Changeset in webkit [75181] by
-
- 3 edits in trunk/LayoutTests
2011-01-06 Stephen White <senorblanco@chromium.org>
Unreviewed; test expectations update.
Update test_expectations.txt files to reflect reality on the canaries.
- platform/chromium-gpu/test_expectations.txt:
- platform/chromium/test_expectations.txt:
- 12:39 PM Changeset in webkit [75180] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-01-06 Patrick Gansterer <Patrick Gansterer>
Reviewed by Gavin Barraclough.
[WINCE] Determine stack extent
https://bugs.webkit.org/show_bug.cgi?id=26276
Scan the stack for writeable pages and use the limits.
- wtf/StackBounds.cpp: (WTF::detectGrowingDownward): (WTF::isPageWritable): (WTF::getLowerStackBound): (WTF::getUpperStackBound): (WTF::StackBounds::initialize):
- 12:39 PM Changeset in webkit [75179] by
-
- 7 edits2 adds in trunk
AX: "AXExpanded" not exposed on most ARIA roles that use aria-expanded
https://bugs.webkit.org/show_bug.cgi?id=51995
Reviewed by Beth Dakin.
WebCore:
Test: platform/mac/accessibility/aria-expanded-standard-items.html
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::supportsARIAExpanded):
(WebCore::AccessibilityObject::isExpanded):
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isVisited):
- accessibility/AccessibilityRenderObject.h:
- accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
LayoutTests:
- platform/mac/accessibility/aria-expanded-standard-items-expected.txt: Added.
- platform/mac/accessibility/aria-expanded-standard-items.html: Added.
- 12:34 PM Changeset in webkit [75178] by
-
- 2 edits in trunk/Tools
2011-01-06 Evan Martin <evan@chromium.org>
Reviewed by Tony Chang.
[gdb] handle inaccessible memory and UChar*
https://bugs.webkit.org/show_bug.cgi?id=52003
To pretty-print a UChar*, we just grope around in the memory
looking for a terminating NUL. We need to handle the exception
that can occur when we poke into an invalid location.
Additionally, the logic for choosing which pretty-printer would
early return before hitting the point where we'd use the UChar*
printer. (Did this ever work? How did it regress?)
- gdb/webkit.py:
- 12:28 PM Changeset in webkit [75177] by
-
- 3 edits in trunk/LayoutTests
2011-01-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
prototype-inheritance prints FAIL when it shouldn't
https://bugs.webkit.org/show_bug.cgi?id=52007
Before this patch, we were testing the prototypes of primitive values,
but the rules for primitive values are different than the rules for
objects. Primitive values get their prototypes from the current
lexical scope when they get boxed. This test is designed to test that
objects get their prototypes from their original holder.
In this patch, we skip testing non-object/non-functions. We can add
another test for primitives if we think that would be valuable.
- fast/dom/prototype-inheritance-expected.txt:
- fast/dom/script-tests/prototype-inheritance.js:
- 12:20 PM Changeset in webkit [75176] by
-
- 8 edits in trunk/LayoutTests
2011-01-06 James Robinson <jamesr@chromium.org>
Update expectations for tests that enumerate properties on the window to reflect newly added property.
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/Window/window-property-descriptors-expected.txt:
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
- 11:33 AM Changeset in webkit [75175] by
-
- 6 edits in trunk
2010-12-28 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Must generate INVALID_VALUE errors for strings containing out-of-range characters
https://bugs.webkit.org/show_bug.cgi?id=50929
- html/canvas/WebGLRenderingContext.cpp: Validate characters according to GLSL ES 1.0 spec section 3.1. (WebCore::WebGLRenderingContext::bindAttribLocation): (WebCore::WebGLRenderingContext::getAttribLocation): (WebCore::WebGLRenderingContext::getUniformLocation): (WebCore::WebGLRenderingContext::shaderSource): (WebCore::WebGLRenderingContext::validateString): Helper function to perform the character validation.
- html/canvas/WebGLRenderingContext.h: Declare validateString().
2010-12-28 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Must generate INVALID_VALUE errors for strings containing out-of-range characters
https://bugs.webkit.org/show_bug.cgi?id=50929
- fast/canvas/webgl/invalid-passed-params-expected.txt: Add test cases for invalid characters.
- fast/canvas/webgl/invalid-passed-params.html: Ditto.
- 11:27 AM Changeset in webkit [75174] by
-
- 8 edits in trunk
WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
https://bugs.webkit.org/show_bug.cgi?id=51969
Reviewed by Ada Chan.
Tools:
Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
WebKit2:
Add the ability to call into the injected bundle to ask if we should allow resource loads.
If the injected bundle says we should cancel, we clear out the ResourceRequest that was
passed into willSendRequest, which cancels the resource load.
- WebProcess/InjectedBundle/API/c/WKBundlePage.h: Add the new callback for allowing/cancelling
resource loads.
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::shouldLoadResourceForFrame): Calls through to the client.
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchWillSendRequest): Ask the InjectedBundlePageLoaderClient if we
should load the resource or not.
- 11:23 AM Changeset in webkit [75173] by
-
- 3 edits in trunk/LayoutTests
2011-01-06 Abhishek Arya <inferno@chromium.org>
Reviewed by Alexey Proskuryakov.
Improve the layouttests from r75168 and make sure that the parent stylesheet value is null
before showing test passed.
- fast/dom/StyleSheet/removed-media-rule-deleted-parent-crash.html:
- fast/dom/StyleSheet/removed-stylesheet-rule-deleted-parent-crash.html:
- 11:14 AM Changeset in webkit [75172] by
-
- 1 edit1 add in trunk/WebCore
2011-01-06 Yong Li <yoli@rim.com>
Reviewed by Adam Barth.
Add the test case that is missed in r75066.
https://bugs.webkit.org/show_bug.cgi?id=48077
Test case: WebCore/manual-tests/bugzilla-48077.html.
- 11:08 AM Changeset in webkit [75171] by
-
- 3 edits in trunk/WebKit2
2011-01-06 Jeff Miller <jeffm@apple.com>
Reviewed by Darin Adler.
WebKit2: Add APIs to WKBundleFrame to get content bounds and scroll offset
https://bugs.webkit.org/show_bug.cgi?id=51968
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: (WKBundleFrameGetContentBounds): (WKBundleFrameGetScrollOffset):
- WebProcess/InjectedBundle/API/c/WKBundleFrame.h: Add WKBundleFrameGetContentBounds() and WKBundleFrameGetScrollOffset().
- 11:07 AM Changeset in webkit [75170] by
-
- 2 edits in trunk/WebKit/gtk
2011-01-06 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
Include a new header in the static headers list. This is necessary
so that "make install" installs the header.
- GNUmakefile.am: Include webkitglobals.h in the header list.
- 11:07 AM Changeset in webkit [75169] by
-
- 32 edits5 adds in trunk
2011-01-06 James Robinson <jamesr@chromium.org>
Reviewed by Simon Fraser.
Implement mozilla's animationTime property
https://bugs.webkit.org/show_bug.cgi?id=51952
Tests for window.webkitAnimationTime.
- animations/animation-time-expected.txt: Added.
- animations/animation-time.html: Added.
- animations/script-tests/animation-time.js: Added.
2011-01-06 James Robinson <jamesr@chromium.org>
Reviewed by Simon Fraser.
Implement mozilla's animationTime property
https://bugs.webkit.org/show_bug.cgi?id=51952
Chromium DRT support for webkitAnimationTime.
- DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::paintInvalidatedRegion):
2011-01-06 James Robinson <jamesr@chromium.org>
Reviewed by Simon Fraser.
Implement mozilla's animationTime property
https://bugs.webkit.org/show_bug.cgi?id=51952
Implements mozilla's animationTime property as described here:
https://developer.mozilla.org/en/DOM/window.mozAnimationStartTime
and http://hacks.mozilla.org/2010/08/more-efficient-javascript-animations-with-mozrequestanimationframe/
The property is called webkitAnimationTime as calling it the 'Start' time is not very informative.
This property exposes a notion of a 'current' time to use for declarative animations and allows
scripts to synchronize imperative animations with declarative ones if they choose to. Once queried
this time is saved and used for all declarative animation updates until the embedder paints/composites
the next frame and clears it, or 15ms elapse (in case the embedder isn't producing frames, for example
if the page is in a background tab).
This patch also ensures that all declarative animations started in the same script execution block
are synchronized even if some time elapses while script is running.
Test: fast/animation/animation-time.html
- WebCore.gypi:
- page/DOMWindow.cpp: (WebCore::DOMWindow::webkitAnimationTime):
- page/DOMWindow.h:
- page/DOMWindow.idl:
- page/Frame.cpp: (WebCore::Frame::currentAnimationTime):
- page/Frame.h:
- page/Page.cpp: (WebCore::Page::Page):
- page/Page.h: (WebCore::Page::animationTime):
- page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::beginAnimationUpdateTime):
- page/animation/AnimationTimeController.cpp: Added. (WebCore::AnimationTimeController::AnimationTimeController): (WebCore::AnimationTimeController::~AnimationTimeController): (WebCore::AnimationTimeController::currentAnimationTime): (WebCore::AnimationTimeController::clearCurrentAnimationTime): (WebCore::AnimationTimeController::clearCurrentAnimationTimeTimerFired):
- page/animation/AnimationTimeController.h: Added. (WebCore::AnimationTimeController::create):
2011-01-06 James Robinson <jamesr@chromium.org>
Reviewed by Simon Fraser.
Implement mozilla's animationTime property
https://bugs.webkit.org/show_bug.cgi?id=51952
WebKit API support for webkitAnimationTime.
- public/WebWidget.h:
- src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::clearCurrentAnimationTime):
- src/WebPopupMenuImpl.h:
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::clearCurrentAnimationTime):
- src/WebViewImpl.h:
2011-01-06 James Robinson <jamesr@chromium.org>
Reviewed by Simon Fraser.
Implement mozilla's animationTime property
https://bugs.webkit.org/show_bug.cgi?id=51952
Tells the page to clear the current animation time after producing a frame.
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::drawRect):
- WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp: (WebKit::ChunkedUpdateDrawingArea::display): (WebKit::ChunkedUpdateDrawingArea::setSize):
- WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm: (WebKit::LayerBackedDrawingArea::syncCompositingLayers):
- 10:52 AM Changeset in webkit [75168] by
-
- 4 edits4 adds in trunk
2011-01-06 Abhishek Arya <inferno@chromium.org>
Reviewed by Simon Fraser.
Null out the parent stylesheet pointer when a css rule is removed.
https://bugs.webkit.org/show_bug.cgi?id=51993
Tests: fast/dom/StyleSheet/removed-media-rule-deleted-parent-crash.html
fast/dom/StyleSheet/removed-stylesheet-rule-deleted-parent-crash.html
- css/CSSRuleList.cpp: (WebCore::CSSRuleList::deleteRule):
- css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::deleteRule):
2011-01-06 Abhishek Arya <inferno@chromium.org>
Reviewed by Simon Fraser.
Tests that we do not crash when accessing a deleted parent stylesheet
from a removed css rule.
https://bugs.webkit.org/show_bug.cgi?id=51993
- fast/dom/StyleSheet/removed-media-rule-deleted-parent-crash-expected.txt: Added.
- fast/dom/StyleSheet/removed-media-rule-deleted-parent-crash.html: Added.
- fast/dom/StyleSheet/removed-stylesheet-rule-deleted-parent-crash-expected.txt: Added.
- fast/dom/StyleSheet/removed-stylesheet-rule-deleted-parent-crash.html: Added.
- 10:47 AM Changeset in webkit [75167] by
-
- 6 edits in trunk
2011-01-04 Adrienne Walker <enne@google.com>
Reviewed by Kenneth Russell.
Add test cases for storing NaN in typed arrays.
https://bugs.webkit.org/show_bug.cgi?id=46990
- fast/canvas/webgl/array-unit-tests-expected.txt:
- fast/canvas/webgl/array-unit-tests.html:
2011-01-04 Adrienne Walker <enne@google.com>
Reviewed by Kenneth Russell.
NaN in a TypedArray should be converted to zero only for Float32Array.
https://bugs.webkit.org/show_bug.cgi?id=46990
Test: LayoutTests/fast/canvas/webgl/array-unit-tests.html
- bindings/js/JSArrayBufferViewHelper.h: (WebCore::convertArrayValue): (WebCore::constructArrayBufferView):
- html/canvas/Float32Array.h: (WebCore::Float32Array::set): (WebCore::Float32Array::item):
- 10:42 AM Changeset in webkit [75166] by
-
- 3 edits in trunk/Tools
2011-01-06 Julie Parent <jparent@chromium.org>
Reviewed by Tony Chang.
Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
https://bugs.webkit.org/show_bug.cgi?id=51217
- TestResultServer/model/jsonresults.py: Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value. Adds missing documentation.
- TestResultServer/model/jsonresults_unittest.py: Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS. Update test_merge to take a number of builds to truncate at.
- 10:21 AM Changeset in webkit [75165] by
-
- 2 edits in trunk
2011-01-06 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Enable blob support by default
https://bugs.webkit.org/show_bug.cgi?id=51994
- configure.ac: Enable Blob support by default.
- 10:19 AM Changeset in webkit [75164] by
-
- 2 edits in trunk/LayoutTests
2011-01-06 Andrei Popescu <andreip@google.com>
Unreviewed, build fix.
[Chromium] Add elliptical gradient support to GradientSkia
https://bugs.webkit.org/show_bug.cgi?id=51841
Marks fast/gradients/css3-radial-gradients3.html as expected to fail.
Also marks
canvas/philip/tests/2d.shadow.gradient.alpha.html
canvas/philip/tests/2d.shadow.gradient.basic.html
canvas/philip/tests/2d.shadow.gradient.transparent.2.html
as passing on Chromium-mac as a result of r75139.
- platform/chromium/test_expectations.txt:
- 10:16 AM Changeset in webkit [75163] by
-
- 2 edits in trunk/WebCore
2011-01-06 Patrick Gansterer <Patrick Gansterer>
Unreviewed Windows build fix for r75161.
- platform/graphics/cg/GraphicsContextCG.cpp: Missing include added.
- 9:57 AM Changeset in webkit [75162] by
-
- 1 edit4 deletes in trunk/LayoutTests
2011-01-06 Andrei Popescu <andreip@google.com>
Unreviewed, rolling out r75152.
[Chromium] fast/gradients/css3-radial-gradients3.html needs Chromium-specific results
https://bugs.webkit.org/show_bug.cgi?id=51988
Rolling out since, on closer inspection, the expectations are wrong and the corresponding test really fails.
- platform/chromium-mac/fast/gradients/css3-radial-gradients3-expected.checksum: Removed.
- platform/chromium-mac/fast/gradients/css3-radial-gradients3-expected.png: Removed.
- platform/chromium-win/fast/gradients/css3-radial-gradients3-expected.checksum: Removed.
- platform/chromium-win/fast/gradients/css3-radial-gradients3-expected.png: Removed.
- 9:36 AM Changeset in webkit [75161] by
-
- 2 edits in trunk/WebCore
2011-01-06 Patrick Gansterer <Patrick Gansterer>
Unreviewed WinCE build fix for r75139.
Try to remove include after adding forward-declaration in r75145.
- platform/graphics/Gradient.h:
- 8:50 AM Changeset in webkit [75160] by
-
- 8 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=51811
Merge m_height and m_width members of ImageData into the new m_size member.
Patch by Renata Hodovan <reni@webkit.org> on 2011-01-06
Reviewed by Andreas Kling.
Image (BitmapImage, ImageSource) types in WebKit use IntSize to store their
width and height argument, except ImageData. This patch refactors ImageData
to follow the style of other Image types in WebKit.
Using of PassRefPtrs other than argument passing is not allowed in WebKit anymore.
This patch also refactors the PassRefPtr usages of ImageData.
It's just a refactoring, so we don't need any new tests.
- bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::write):
(WebCore::CloneDeserializer::readTerminal):
- bindings/v8/SerializedScriptValue.cpp:
(WebCore::ZigZag::Reader::readImageData):
- html/ImageData.cpp:
(WebCore::ImageData::create):
(WebCore::ImageData::ImageData):
- html/ImageData.h:
(WebCore::ImageData::size):
(WebCore::ImageData::width):
(WebCore::ImageData::height):
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::createEmptyImageData):
(WebCore::CanvasRenderingContext2D::createImageData):
(WebCore::CanvasRenderingContext2D::getImageData):
- html/canvas/CanvasRenderingContext2D.h:
- platform/graphics/haiku/ImageBufferHaiku.cpp:
(WebCore::getImageData):
- 8:48 AM Changeset in webkit [75159] by
-
- 1 edit in branches/chromium/552/WebCore/html/HTMLInputElement.cpp
Merge 70644 - 2010-10-27 Satish Sampath <satish@chromium.org>
Reviewed by Steve Block.
Add runtime flag check before enabling speech input in code.
https://bugs.webkit.org/show_bug.cgi?id=48426
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::isSpeechEnabled): Added runtime flag check.
BUG=68666
TBR=jschuh@chromium.org
- 8:46 AM Changeset in webkit [75158] by
-
- 5 edits4 adds in trunk
WebCore: document.querySelector(':nth-child(foo)') should throw a syntax error
https://bugs.webkit.org/show_bug.cgi?id=51231
Reviewed by Darin Adler.
Also fixes
CSSNthSelector parsing code is illegible and buggy (allows "n3" as a valid selector)
https://bugs.webkit.org/show_bug.cgi?id=21815
Add a check in the parser that other than an+b, only "odd" or "even" would be allowed
as parameters to nth selector.
Tests: fast/css/css3-nth-tokens-script.html
fast/css/css3-nth-tokens-style.html
- css/CSSGrammar.y:
- css/CSSParser.cpp:
(WebCore::isValidNthToken):
- css/CSSParser.h:
LayoutTests: document.querySelector(':nth-child(foo)') should throw a syntax error
https://bugs.webkit.org/show_bug.cgi?id=51231
CSSNthSelector parsing code is illegible and buggy (allows "n3" as a valid selector)
https://bugs.webkit.org/show_bug.cgi?id=21815
Reviewed by Darin Adler.
- fast/css/css3-nth-tokens-script-expected.txt: Added.
- fast/css/css3-nth-tokens-script.html: Added.
- fast/css/css3-nth-tokens-style-expected.txt: Added.
- fast/css/css3-nth-tokens-style.html: Added.
- 8:31 AM Changeset in webkit [75157] by
-
- 2 edits1 add in trunk/WebCore
2011-01-06 Jan Erik Hanssen <jhanssen@sencha.com>
Reviewed by Andreas Kling.
[Qt] crash in QNetworkReplyHandler::sendResponseIfNeeded()
https://bugs.webkit.org/show_bug.cgi?id=51453
Check if m_reply is NULL before accessing.
- manual-tests/load-deferrer-resume-crash.html: Added.
- platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::setLoadMode): (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
- 8:24 AM Changeset in webkit [75156] by
-
- 4 edits in trunk/WebKit2
Redo the half-done rename from the last check-in.
Sorry for the broken build last night.
- WebProcess/WebPage/WebBackForwardListProxy.cpp:
(WebKit::WebBackForwardListProxy::removeItem): Renamed.
- WebProcess/WebPage/WebBackForwardListProxy.h: Updated
for new name.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didRemoveBackForwardItem): Updated to
use the new name.
- 8:16 AM Changeset in webkit [75155] by
-
- 2 edits in trunk/LayoutTests
2011-01-06 Andrei Popescu <andreip@google.com>
Unreviewed, build fix.
[Chromium] canvas/canvas-fillRect-gradient-shadow.html fails on Chromium.
https://bugs.webkit.org/show_bug.cgi?id=51989
Updating the test expectations for the chromium-gpu platform.
- platform/chromium-gpu/test_expectations.txt:
- 7:31 AM Changeset in webkit [75154] by
-
- 2 edits in trunk/LayoutTests
2011-01-06 Andrei Popescu <andreip@google.com>
Unreviewed, build fix.
[Chromium] canvas/canvas-fillRect-gradient-shadow.html fails on Chromium.
https://bugs.webkit.org/show_bug.cgi?id=51989
Added suppressions for
svg/batik/text/textEffect.svg
svg/batik/text/textEffect3.svg
svg/css/composite-shadow-text.svg
svg/custom/js-late-gradient-and-object-creation.svg
svg/custom/js-late-gradient-creation.svg
svg/text/selection-background-color.xhtml
svg/text/selection-styles.xhtml
svg/text/text-gradient-positioning.svg
These tests are all failing as a result of the same change: r75153.
- platform/chromium/test_expectations.txt:
- 6:32 AM Changeset in webkit [75153] by
-
- 2 edits in trunk/LayoutTests
2011-01-06 Andrei Popescu <andreip@google.com>
Unreviewed, build fix.
[Chromium] canvas/canvas-fillRect-gradient-shadow.html fails on Chromium.
https://bugs.webkit.org/show_bug.cgi?id=51989
Updating Chromium expectations until we find a fix.
- platform/chromium/test_expectations.txt:
- 6:13 AM Changeset in webkit [75152] by
-
- 1 edit4 adds in trunk/LayoutTests
2011-01-06 Andrei Popescu <andreip@google.com>
Unreviewed, build fix.
[Chromium] fast/gradients/css3-radial-gradients3.html needs Chromium-specific results
https://bugs.webkit.org/show_bug.cgi?id=51988
- platform/chromium-mac/fast/gradients/css3-radial-gradients3-expected.checksum: Added.
- platform/chromium-mac/fast/gradients/css3-radial-gradients3-expected.png: Added.
- platform/chromium-win/fast/gradients/css3-radial-gradients3-expected.checksum: Added.
- platform/chromium-win/fast/gradients/css3-radial-gradients3-expected.png: Added.
- 6:04 AM Changeset in webkit [75151] by
-
- 2 edits in trunk/WebCore
2011-01-06 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt][V8] Fix the build when DEVICE_ORIENTATION is enabled.
No new tests needed.
- WebCore.pro: remove duplications and globally add RuntimeEnabledFeatures.
- 4:48 AM Changeset in webkit [75150] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
[Qt] Web Timing related bugs
https://bugs.webkit.org/show_bug.cgi?id=51245
- platform/qt/Skipped: Add new tests.
- http/tests/misc/webtiming-origins.html
- http/tests/misc/webtiming-slow-load.php
- 3:31 AM Changeset in webkit [75149] by
-
- 3 edits in trunk/Tools
2011-01-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
The EWS should log outside of the working directory
https://bugs.webkit.org/show_bug.cgi?id=51986
This patch prepare us for using git clean -x -d -f in the EWS wrapper
script, which will actually clean the working copy back to a pristine
state instead of leaving untracked directories and ignored files.
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- 2:49 AM Changeset in webkit [75148] by
-
- 4 edits in trunk/WebCore
2011-01-06 Helder Correia <helder@sencha.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt][GTK] Use GraphicsContext::hasShadow() in port-specific code
https://bugs.webkit.org/show_bug.cgi?id=51985
r75139 introduced GraphicsContext::hasShadow(). This can now simplify
and unify some code in the Qt and GTK ports.
No new tests necessary for this refactoring.
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect):
- platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect):
- 12:41 AM Changeset in webkit [75147] by
-
- 3 edits in trunk/WebKit2
Fix build for Darin's previous change w/ the obvious renaming.
Rubber stamped by Dan Bernstein.
- WebProcess/WebPage/WebBackForwardListProxy.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didRemoveBackForwardItem):
Jan 5, 2011:
- 11:43 PM Changeset in webkit [75146] by
-
- 2 edits1 add in trunk/WebKit/chromium
2010-12-29 John Abd-El-Malek <jam@chromium.org>
Reviewed by Darin Fisher.
[chromium] Add a WebAutoFillClient interface that moves some functions from WebViewClient
https://bugs.webkit.org/show_bug.cgi?id=51710
- WebKit.gyp:
- public/WebAutoFillClient.h: Added. (WebKit::WebAutoFillClient::didAcceptAutoFillSuggestion): (WebKit::WebAutoFillClient::didSelectAutoFillSuggestion): (WebKit::WebAutoFillClient::didClearAutoFillSelection): (WebKit::WebAutoFillClient::removeAutocompleteSugestion): (WebKit::WebAutoFillClient::didAcceptAutocompleteSuggestion): (WebKit::WebAutoFillClient::textFieldDidBeginEditing): (WebKit::WebAutoFillClient::textFieldDidEndEditing): (WebKit::WebAutoFillClient::textFieldDidChange): (WebKit::WebAutoFillClient::textFieldDidReceiveKeyDown): (WebKit::WebAutoFillClient::~WebAutoFillClient):
- 11:16 PM Changeset in webkit [75145] by
-
- 2 edits in trunk/WebCore
Fix Chromium Mac build.
- platform/graphics/Gradient.h: Forward-declare CGContextRef.
This might even make it possible to remove the include of
<CoreGraphics/CoreGraphics.h> for PLATFORM(WIN), but I did not
do that at this time because I don't want to break the Windows
build when fixing the Chromium build.
- 11:12 PM Changeset in webkit [75144] by
-
- 10 edits in trunk/WebKit2
2011-01-05 Darin Adler <Darin Adler>
Reviewed by Geoff Garen.
Back/Forward entries in WebKit2 leak
https://bugs.webkit.org/show_bug.cgi?id=51983
Besides fixing the leak, this also fixes a problem where
all history items were sent over to the UI process, but
we wanted to send only back/forward items.
- UIProcess/WebBackForwardList.cpp: (WebKit::WebBackForwardList::pageClosed): Added. Tells the web process about all the back/forward items being removed. (WebKit::WebBackForwardList::addItem): Ditto. Also removed a redundant call to didChangeBackForwardList. (WebKit::WebBackForwardList::clear): Ditto.
- UIProcess/WebBackForwardList.h: Added pageClosed.
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::close): Added a call to pageClosed. (WebKit::WebPageProxy::backForwardRemovedItem): Added. Sends a message to the web page in the web process.
- UIProcess/WebPageProxy.h: Added backForwardRemovedItem.
- WebProcess/WebPage/WebBackForwardListProxy.cpp: (WebKit::updateBackForwardItem): Added an itemID argument, since callers will now be getting it and we don't want to get it twice. Removed the code to generate an ID. Also removed some local variables to make the code a little tighter and clearer. (WebKit::WK2NotifyHistoryItemChanged): Only call updateBackForwardItem for items that already have IDs. We don't want to send cross-process messages for every history item; just the ones that are top level back/forward items. (WebKit::WebBackForwardListProxy::removeItem): Added. For use when the UI process tells us to remove it. (WebKit::WebBackForwardListProxy::addItem): Added code to assign an ID and put this item into the maps. This is called exactly once on each back/forward item.
- WebProcess/WebPage/WebBackForwardListProxy.h: Added removeItem.
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::didRemoveBackForwardItem): Added.
- WebProcess/WebPage/WebPage.h: Added didRemoveBackForwardItem.
- WebProcess/WebPage/WebPage.messages.in: Added DidRemoveBackForwardItem message.
- 11:11 PM Changeset in webkit [75143] by
-
- 2 edits in trunk/Tools
Windows build fix.
Back out attempted change to built-product-archive.
- BuildSlaveSupport/built-product-archive:
- 11:00 PM Changeset in webkit [75142] by
-
- 2 edits in trunk/Tools
Windows build fix.
Include configuration name when unpacking a build archive.
Needed, since we split Windows build results into configuration-specific directories
under WebKitOutputDir.
- BuildSlaveSupport/built-product-archive:
- 10:20 PM Changeset in webkit [75141] by
-
- 2 edits in trunk/Source/JavaScriptCore
Windows build fix.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops: Revert change to additional library search path needed to find ICU.
- 10:15 PM Changeset in webkit [75140] by
-
- 2 edits in trunk/WebCore
2011-01-05 Xianzhu Wang <wangxianzhu@google.com>
Reviewed by David Levin.
Implement RemoteFontStream's skip behavior (in FontCustomPlatformData.cpp)
https://bugs.webkit.org/show_bug.cgi?id=51736
No new tests. This change has potential effect on @font-face CSS feature
on ports using Skia. Tested on Chromium that this change won't break
fast/css/font-face-remote.html. This change can make the test pass on
other ports using Skia.
- platform/graphics/skia/FontCustomPlatformData.cpp: (WebCore::RemoteFontStream::read):
- 10:11 PM Changeset in webkit [75139] by
-
- 7 edits3 adds3 deletes in trunk
2011-01-05 Helder Correia <helder@sencha.com>
Reviewed by Simon Fraser.
Shadows are not drawn when filling a rect with a gradient fillStyle on Mac and Chromium-Mac
https://bugs.webkit.org/show_bug.cgi?id=51869
GraphicsContext::fillRect(const FloatRect&) is clipping to the rect.
The shadow is being drawn, but getting clipped to the rect being filled.
The solution is to draw the gradient into a CGLayer (when a shadow is
required), then render the layer to the GraphicsContext.
This patch also fixes:
canvas/philip/tests/2d.shadow.gradient.alpha.html
canvas/philip/tests/2d.shadow.gradient.basic.html
canvas/philip/tests/2d.shadow.gradient.transparent.2.html
New test to ensure that shadows are drawn when fillStyle is a gradient,
possibly with some transparency and blur, and specifically using
fillRect.
- fast/canvas/canvas-fillRect-gradient-shadow-expected.txt: Added.
- fast/canvas/canvas-fillRect-gradient-shadow.html: Added.
- fast/canvas/script-tests/canvas-fillRect-gradient-shadow.js: Added.
2011-01-05 Helder Correia <helder@sencha.com>
Reviewed by Simon Fraser.
Shadows are not drawn when filling a rect with a gradient fillStyle on Mac and Chromium-Mac
https://bugs.webkit.org/show_bug.cgi?id=51869
GraphicsContext::fillRect(const FloatRect&) is clipping to the rect.
The shadow is being drawn, but getting clipped to the rect being filled.
The solution is to draw the gradient into a CGLayer (when a shadow is
required), then render the layer to the GraphicsContext.
This patch also fixes:
canvas/philip/tests/2d.shadow.gradient.alpha.html
canvas/philip/tests/2d.shadow.gradient.basic.html
canvas/philip/tests/2d.shadow.gradient.transparent.2.html
Test: fast/canvas/canvas-fillRect-gradient-shadow.html
- platform/graphics/Gradient.h:
- platform/graphics/cg/GradientCG.cpp: (WebCore::Gradient::paint):
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillRect):
- 10:02 PM Changeset in webkit [75138] by
-
- 97 edits1 add in trunk
2011-01-05 Steve Falkenburg <sfalken@apple.com>
Reviewed by Darin Adler.
Debug and Release builds on Windows clobber each other
https://bugs.webkit.org/show_bug.cgi?id=49185
Changes the structure of WebKitBuild build products directory so we
completely separate each build configuration into independent directories.
Although we previously had per-configuration directories for obj, this change adds
per-configuration directories for bin, lib, obj, and include. Each configuration's
build products are stored within a directory inside of WebKitBuild.
Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
- win/tools/vsprops/common.vsprops:
2011-01-05 Steve Falkenburg <sfalken@apple.com>
Reviewed by Darin Adler.
Debug and Release builds on Windows clobber each other
https://bugs.webkit.org/show_bug.cgi?id=49185
Changes the structure of WebKitBuild build products directory so we
completely separate each build configuration into independent directories.
Although we previously had per-configuration directories for obj, this change adds
per-configuration directories for bin, lib, obj, and include. Each configuration's
build products are stored within a directory inside of WebKitBuild.
Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
- WebKit.vcproj/InterfacesCommon.vsprops:
- WebKit.vcproj/InterfacesPostBuild.cmd:
- WebKit.vcproj/InterfacesPreBuild.cmd:
- WebKit.vcproj/WebKit.make:
- WebKit.vcproj/WebKitGUID.vcproj:
- WebKit.vcproj/WebKitGUIDCommon.vsprops:
- WebKit.vcproj/WebKitGUIDPostBuild.cmd:
- WebKit.vcproj/WebKitGUIDPreBuild.cmd:
- WebKit.vcproj/WebKitLibCommon.vsprops:
- WebKit.vcproj/WebKitLibPostBuild.cmd:
- WebKit.vcproj/WebKitLibPreBuild.cmd:
2011-01-05 Steve Falkenburg <sfalken@apple.com>
Reviewed by Darin Adler.
Debug and Release builds on Windows clobber each other
https://bugs.webkit.org/show_bug.cgi?id=49185
Changes the structure of WebKitBuild build products directory so we
completely separate each build configuration into independent directories.
Although we previously had per-configuration directories for obj, this change adds
per-configuration directories for bin, lib, obj, and include. Each configuration's
build products are stored within a directory inside of WebKitBuild.
Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
- WebCore.vcproj/QTMovieWinCommon.vsprops:
- WebCore.vcproj/QTMovieWinPostBuild.cmd:
- WebCore.vcproj/QTMovieWinPreBuild.cmd:
- WebCore.vcproj/WebCore.make:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcproj/WebCoreCommon.vsprops:
- WebCore.vcproj/WebCoreGeneratedCairo.vsprops:
- WebCore.vcproj/WebCoreGeneratedCommon.vsprops:
- WebCore.vcproj/WebCoreMediaQT.vsprops:
- WebCore.vcproj/WebCorePostBuild.cmd:
- WebCore.vcproj/WebCorePreBuild.cmd:
- WebCore.vcproj/copyForwardingHeaders.cmd:
- WebCore.vcproj/copyInspectorFiles.cmd:
2011-01-05 Steve Falkenburg <sfalken@apple.com>
Reviewed by Darin Adler.
Debug and Release builds on Windows clobber each other
https://bugs.webkit.org/show_bug.cgi?id=49185
Changes the structure of WebKitBuild build products directory so we
completely separate each build configuration into independent directories.
Although we previously had per-configuration directories for obj, this change adds
per-configuration directories for bin, lib, obj, and include. Each configuration's
build products are stored within a directory inside of WebKitBuild.
Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
For PGO, $(ConfigurationBuildDir) points to the same directory (Release_PGO) to allow
for proper operation of the instrumentation/optimization scripts.
- JavaScriptCore.vcproj/JavaScriptCore.make:
- JavaScriptCore.vcproj/JavaScriptCore.sln:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedCommon.vsprops:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCorePGOOptimize.vsprops: Added.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCorePostBuild.cmd:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCorePreBuild.cmd:
- JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh:
- JavaScriptCore.vcproj/JavaScriptCore/react-to-vsprops-changes.py:
- JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln:
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- JavaScriptCore.vcproj/WTF/WTFCommon.vsprops:
- JavaScriptCore.vcproj/WTF/WTFPostBuild.cmd:
- JavaScriptCore.vcproj/WTF/WTFPreBuild.cmd:
- JavaScriptCore.vcproj/jsc/jsc.vcproj:
- JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
- JavaScriptCore.vcproj/jsc/jscPostBuild.cmd:
- JavaScriptCore.vcproj/jsc/jscPreBuild.cmd:
- JavaScriptCore.vcproj/testapi/testapiCommon.vsprops:
- JavaScriptCore.vcproj/testapi/testapiPostBuild.cmd:
- JavaScriptCore.vcproj/testapi/testapiPreBuild.cmd:
2011-01-05 Steve Falkenburg <sfalken@apple.com>
Reviewed by Darin Adler.
Debug and Release builds on Windows clobber each other
https://bugs.webkit.org/show_bug.cgi?id=49185
Changes the structure of WebKitBuild build products directory so we
completely separate each build configuration into independent directories.
Although we previously had per-configuration directories for obj, this change adds
per-configuration directories for bin, lib, obj, and include. Each configuration's
build products are stored within a directory inside of WebKitBuild.
Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
- DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
- DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
- DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
- DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
- DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
- DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
- DumpRenderTree/win/ImageDiffCommon.vsprops:
- DumpRenderTree/win/ImageDiffPostBuild.cmd:
- DumpRenderTree/win/ImageDiffPreBuild.cmd:
- FindSafari/FindSafari.vcproj:
- MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
- MiniBrowser/MiniBrowserPostBuild.cmd:
- MiniBrowser/MiniBrowserPreBuild.cmd:
- Scripts/webkitdirs.pm:
- TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
- TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
- TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
- TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
- TestWebKitAPI/win/copy-resources.cmd:
- WebKitAPITest/WebKitAPITestCommon.vsprops:
- WebKitAPITest/WebKitAPITestPostBuild.cmd:
- WebKitAPITest/WebKitAPITestPreBuild.cmd:
- WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
- WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
- WebKitTestRunner/win/InjectedBundle.vcproj:
- WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
- WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
- WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
- WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
- WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
- WinLauncher/WinLauncherCommon.vsprops:
- WinLauncher/WinLauncherPostBuild.cmd:
- WinLauncher/WinLauncherPreBuild.cmd:
2011-01-05 Steve Falkenburg <sfalken@apple.com>
Reviewed by Darin Adler.
Debug and Release builds on Windows clobber each other
https://bugs.webkit.org/show_bug.cgi?id=49185
Changes the structure of WebKitBuild build products directory so we
completely separate each build configuration into independent directories.
Although we previously had per-configuration directories for obj, this change adds
per-configuration directories for bin, lib, obj, and include. Each configuration's
build products are stored within a directory inside of WebKitBuild.
Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
- win/WebKit2.make:
- win/WebKit2.vcproj:
- win/WebKit2Common.vsprops:
- win/WebKit2Generated.make:
- win/WebKit2GeneratedCommon.vsprops:
- win/WebKit2WebProcessPostBuild.cmd:
- win/WebKit2WebProcessPreBuild.cmd:
- win/WebKitPostBuild.cmd:
- win/WebKitPreBuild.cmd:
- 9:44 PM Changeset in webkit [75137] by
-
- 6 edits1 copy3 adds in trunk
2011-01-05 Simon Fraser <Simon Fraser>
Reviewed by Ariya Hidayat.
Directly composited SVG images fail to render
https://bugs.webkit.org/show_bug.cgi?id=51975
There was already code, added in r67900, to detect whether an image
may be directly composited, by checking to see if it's a bitmap image.
However, CachedImage::image() returns the nullImage() if m_image is null,
which is a BitmapImage, confusing this test.
Test: compositing/images/direct-svg-image.html
- loader/cache/CachedImage.cpp: Remove nullImage(), since Image has exactly the same method. (WebCore::CachedImage::image): Use Image::nullImage().
- loader/cache/CachedImage.h: (WebCore::CachedImage::hasImage): New method to ask whether the m_image is non-null.
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::isDirectlyCompositedImage): Use hasImage() so that we don't test the nullImage.
- 9:28 PM Changeset in webkit [75136] by
-
- 4 edits4 adds in trunk
2011-01-05 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
Fix percentage values in radius of radial gradients
https://bugs.webkit.org/show_bug.cgi?id=51979
Handle percentage values for the ending size of radial gradients.
Test: fast/gradients/css3-radial-gradients3.html
- css/CSSGradientValue.cpp: (WebCore::CSSRadialGradientValue::resolveRadius): Add parameter for height or width, which is non-null if percentage values are allowed, and compute percentage values when we see them. (WebCore::CSSRadialGradientValue::createGradient): Pass height or width down to say that percentages are OK when resolving end radii.
- css/CSSGradientValue.h: New parameter for resolveRadius.
- 9:16 PM Changeset in webkit [75135] by
-
- 5 edits in trunk/WebKit2
2011-01-05 Alexey Proskuryakov <ap@apple.com>
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=51973
Make main frame PDF printing work
- UIProcess/API/mac/PDFViewController.h:
- UIProcess/API/mac/PDFViewController.mm: (WebKit::PDFViewController::makePrintOperation): Ask PDFDocument to create an NSPrintOperation.
- UIProcess/API/mac/WKView.h:
- UIProcess/API/mac/WKView.mm: (-[WKView printOperationWithPrintInfo:forFrame:]): Create a new NSPrintOperation, either from scratch or from a PDF view. (-[WKView canPrintHeadersAndFooters]): Report if the view can be re-paginated to add headers and footers.
- 8:56 PM Changeset in webkit [75134] by
-
- 2 edits in trunk/Tools
2011-01-05 Jan Erik Hanssen <jhanssen@sencha.com>
Reviewed by Ariya Hidayat.
[Qt] TestNetscapePlugin doesn't link on OS X
https://bugs.webkit.org/show_bug.cgi?id=51948
Only add a dependency on libX11 on X11 systems
- DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
- 8:36 PM Changeset in webkit [75133] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
2011-01-05 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
change the way we do comment highlighting in the code review tool
https://bugs.webkit.org/show_bug.cgi?id=51971
Store a space-separated list of base line IDs on each line that has
comments associated with that line. This allows for overlapping comments,
but more importantly, makes adding side-by-side diff support easier.
- code-review.js:
- 8:09 PM Changeset in webkit [75132] by
-
- 2 edits in trunk/Tools
2011-01-05 Jeff Miller <jeffm@apple.com>
Reviewed by Adam Roben.
check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
https://bugs.webkit.org/show_bug.cgi?id=51970
- Scripts/webkitpy/style/checker.py: Add -readability/naming for WebKit2 C API directories.
- 7:19 PM Changeset in webkit [75131] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
2011-01-05 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
minor code cleanup for code review tool
https://bugs.webkit.org/show_bug.cgi?id=51962
Consolidates some queries to using shared functions.
- code-review.js:
- 6:50 PM Changeset in webkit [75130] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
2011-01-05 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
assorted cleanups to prepare for side-by-side diffing
https://bugs.webkit.org/show_bug.cgi?id=51961
Mostly, use selector queries instead of assuming comments are next siblings.
- code-review.js:
- 6:41 PM Changeset in webkit [75129] by
-
- 13 edits9 adds in trunk
2011-01-05 James Simonsen <simonjam@chromium.org>
Reviewed by Adam Barth.
[Web Timing] Zero out some values on cross-origin redirects
https://bugs.webkit.org/show_bug.cgi?id=49294
- fast/dom/script-tests/webtiming.js: (checkTimingBeforeLoad): Remove unload. Its behavior depends on prior navigation and is tested separately. (checkTimingWhileDeferred): Ditto. (checkWebTimingOnDOMContentLoaded): Ditto. (checkWebTimingWhileAsync): Ditto. (checkWebTimingOnLoad): Ditto. (checkWebTimingAfterLoad): Ditto.
- fast/dom/webtiming-expected.txt:
- http/tests/misc/resources/webtiming-cross-origin-and-back-redirect1.php: Added.
- http/tests/misc/resources/webtiming-cross-origin-and-back-redirect2.php: Added.
- http/tests/misc/resources/webtiming-cross-origin-and-back1.html: Added.
- http/tests/misc/resources/webtiming-cross-origin-and-back2.html: Added.
- http/tests/misc/resources/webtiming-cross-origin-redirect.html: Added.
- http/tests/misc/resources/webtiming-cross-origin-redirect.php: Added.
- http/tests/misc/resources/webtiming-no-origin.html: Added.
- http/tests/misc/webtiming-origins-expected.txt: Added.
- http/tests/misc/webtiming-origins.html: Added.
- platform/gtk/Skipped: Skip new web timing test.
- platform/mac/Skipped: Ditto.
- platform/win/Skipped: Ditto.
2011-01-05 James Simonsen <simonjam@chromium.org>
Reviewed by Adam Barth.
[Web Timing] Zero out some values on cross-origin redirects
https://bugs.webkit.org/show_bug.cgi?id=49294
Tests: http/tests/misc/webtiming-cross-origin-redirect.php
http/tests/misc/webtiming-origins.html
- loader/DocumentLoadTiming.h: (WebCore::DocumentLoadTiming::DocumentLoadTiming): Add flags for cross-origin redirects and same-origin navigation.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::~FrameLoader): (WebCore::FrameLoader::stopLoading): Don't overwrite previous unload times. (WebCore::FrameLoader::completed): (WebCore::FrameLoader::loadWithDocumentLoader): Remember previous URL to see if navigation is same-origin. (WebCore::FrameLoader::commitProvisionalLoad): Set flag if navigation is same-origin.
- loader/FrameLoader.h:
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::willSendRequest): Set flag on cross-origin redirects.
- page/PerformanceNavigation.cpp: (WebCore::PerformanceNavigation::redirectCount): Clear if cross-origin redirect flag is set.
- page/PerformanceTiming.cpp: (WebCore::PerformanceTiming::redirectStart): Ditto. (WebCore::PerformanceTiming::redirectEnd): Ditto. (WebCore::PerformanceTiming::unloadEventStart): Clear if cross-origin navigation is set. (WebCore::PerformanceTiming::unloadEventEnd): Ditto.
- 6:39 PM Changeset in webkit [75128] by
-
- 15 edits1 add in trunk/WebKit2
<rdar://problem/8750248>
Need a way to create a new DownloadProxy from an arbitrary resource request
Reviewed by Sam Weinig.
<rdar://problem/8750465>
Need a way to start a download in WKDownload
<rdar://problem/8752204>
WK2 Context Menus - "Save linked file" support
- Shared/ContextMenuState.h: Added.
Add a ContextMenuState struct which contains state for context menus.
- UIProcess/API/C/WKContext.cpp:
(WKContextDownloadURLRequest):
Call WebContext::download.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::download):
Send a DownloadRequest message to the web process.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showContextMenu):
Set the active context menu state.
(WebKit::WebPageProxy::contextMenuItemSelected):
Handle ContextMenuItemTagDownloadImageToDisk and ContextMenuItemTagDownloadLinkToDisk by calling
WebContext::Download, passing the respective URLs.
- UIProcess/WebPageProxy.messages.in:
ShowContextMenu now takes state as well.
- WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
(WebKit::WebContextMenuClient::downloadURL):
Assert that this is never reached; downloads are handled in the UI process.
- WebProcess/WebPage/WebContextMenu.cpp:
(WebKit::WebContextMenu::show):
Pass the context menu state along when sending the ShowContextMenu message.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::downloadRequest):
Call the shared DownloadManager.
- WebProcess/WebProcess.messages.in:
Add DownloadRequest message.
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
Add ContextMenuState.h.
- 6:33 PM Changeset in webkit [75127] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
2011-01-05 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
fix message container selector for code review tool
https://bugs.webkit.org/show_bug.cgi?id=51959
- code-review.js:
- 6:16 PM Changeset in webkit [75126] by
-
- 11 edits3 adds in trunk
2011-01-05 Helder Correia <helder@sencha.com>
Reviewed by Ariya Hidayat.
[Qt] Default focus ring is too wide
https://bugs.webkit.org/show_bug.cgi?id=51854
This is an intermediate step to solve this bug. Use QPalette::Highlight
instead of default half-transparent black as the focus ring color.
- platform/qt/editing/selection/caret-and-focus-ring-expected.checksum: Added.
- platform/qt/editing/selection/caret-and-focus-ring-expected.png: Added.
- platform/qt/editing/selection/caret-and-focus-ring-expected.txt: Added.
- platform/qt/fast/css/focus-ring-outline-color-expected.checksum:
- platform/qt/fast/css/focus-ring-outline-color-expected.png:
- platform/qt/fast/css/focus-ring-outline-offset-expected.checksum:
- platform/qt/fast/css/focus-ring-outline-offset-expected.png:
- platform/qt/fast/css/focus-ring-outline-width-expected.checksum:
- platform/qt/fast/css/focus-ring-outline-width-expected.png:
2011-01-05 Helder Correia <helder@sencha.com>
Reviewed by Ariya Hidayat.
[Qt] Default focus ring is too wide
https://bugs.webkit.org/show_bug.cgi?id=51854
This is an intermediate step to solve this bug. Use QPalette::Highlight
instead of default half-transparent black as the focus ring color.
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::drawFocusRingForPath):
- platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::platformFocusRingColor):
- platform/qt/RenderThemeQt.h:
- 6:15 PM Changeset in webkit [75125] by
-
- 3 edits in trunk/Tools
2011-01-05 Eric Seidel <eric@webkit.org>
Unreviewed, just fixing one more log error from my previous python patch.
Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
https://bugs.webkit.org/show_bug.cgi?id=51802
webkit-patch failure-reason was logging about parsing errors
due to my misunderstanding of how BeautifulSoup.findAll worked.
Fixed, and added a unit test.
- Scripts/webkitpy/common/net/layouttestresults.py:
- Scripts/webkitpy/common/net/layouttestresults_unittest.py:
- 6:04 PM Changeset in webkit [75124] by
-
- 4 edits in trunk/Tools
2011-01-05 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
https://bugs.webkit.org/show_bug.cgi?id=51951
Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
to create new window from WebKit.
- MiniBrowser/qt/BrowserWindow.cpp: (newPageFunction): (BrowserWindow::BrowserWindow): (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class (BrowserWindow::newWindow): (BrowserWindow::updateUserAgentList): (BrowserWindow::showUserAgentDialog):
- MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to define the type of the backing store used for new windows.
- MiniBrowser/qt/main.cpp: (main):
- 5:38 PM Changeset in webkit [75123] by
-
- 2 edits in trunk/WebKit2
2011-01-05 Laszlo Gombos <Laszlo Gombos>
Unreviewed build fix.
[Qt] [Symbian] Fix building NPAPI support
NPEvent is mapped to QAction on Symbian. QAction has no
default constructor, so toNP() fails to build. Add a case for
Symbian behind the OS(SYMBIAN) guard.
- WebProcess/Plugins/Netscape/qt/NetscapePluginQt.cpp: (WebKit::toNP):
- 5:28 PM Changeset in webkit [75122] by
-
- 2 edits in trunk/WebKit2
2011-01-05 Jeff Miller <jeffm@apple.com>
Reviewed by Dan Bernstein.
Copy WKImageCG.h to include\WebKit2 in build output
https://bugs.webkit.org/show_bug.cgi?id=51944
- win/WebKit2Generated.make: Add xcopy command to copy WKImageCG.h.
- 5:26 PM Changeset in webkit [75121] by
-
- 8 edits in trunk/WebKit2
Part of <rdar://problem/8261624> and https://bugs.webkit.org/show_bug.cgi?id=47355
Change WebKit2 session restoring to restore the full back/forward list
Reviewed by Sam Weinig.
Add a new message to tell the WebProcess to restore a session state:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::restoreSession):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in: Add the new message, AND fix the intentional misspellings.
Also, Sam sucks.
Change WebProcess back/forward list item ids to be odd (UIProcess's will be even):
- WebProcess/WebPage/WebBackForwardListProxy.cpp:
(WebKit::generateHistoryItemID):
Provide accessors to the entries in the list to pass to the WebProcess:
- UIProcess/WebBackForwardList.h:
(WebKit::WebBackForwardList::entries):
(WebKit::WebBackForwardList::currentIndex):
Add decoding of the saved back/forward list itmes (we already encode them):
- UIProcess/cf/WebBackForwardListCF.cpp:
(WebKit::generateWebBackForwardItemID):
(WebKit::WebBackForwardList::restoreFromCFDictionaryRepresentation):
Instead of loading the current URL, pass the entire last back to the WebProcess:
- UIProcess/cf/WebPageProxyCF.cpp:
(WebKit::WebPageProxy::restoreFromSessionStateData):
- 5:22 PM Changeset in webkit [75120] by
-
- 6 edits2 adds in trunk
2011-01-05 James Simonsen <simonjam@chromium.org>
Reviewed by Darin Fisher.
[Web Timing] requestStart and responseStart should be available even if the document is still loading
https://bugs.webkit.org/show_bug.cgi?id=51368
- http/tests/misc/webtiming-slow-load-expected.txt: Added.
- http/tests/misc/webtiming-slow-load.php: Added.
2011-01-05 James Simonsen <simonjam@chromium.org>
Reviewed by Darin Fisher.
[Web Timing] requestStart and responseStart should be available even if the document is still loading
https://bugs.webkit.org/show_bug.cgi?id=51368
Test: http/tests/misc/webtiming-slow-load.php
- page/PerformanceTiming.cpp: (WebCore::getPossiblySkewedTimeInKnownRange): Handle case where response is not yet complete. (WebCore::PerformanceTiming::resourceLoadTimeRelativeToAbsolute): Use full upper bound.
- 4:41 PM Changeset in webkit [75119] by
-
- 2 edits in trunk/WebKit/qt
[Qt] QML WebView does not transfer focus to underlying QGraphicsWebView
QML WebView creates QGraphicsWebView as it's child. The WebView is not
setup as a focus proxy of the QGraphicsWebView. Thus, even though the
WebView gets focus, the QGraphicsWebView does not get focus.
In QML, focus proxies or "focus scopes" are created using FocusScope.
This change makes WebView a FocusScope and sets the focus on the
QGraphicsWebView.
Reviewed by Simon Hausmann.
Acked by Aaron Kennedy <aaron.kennedy@nokia.com>
https://bugs.webkit.org/show_bug.cgi?id=51094
- declarative/qdeclarativewebview.cpp:
(QDeclarativeWebView::init):
- 4:37 PM Changeset in webkit [75118] by
-
- 6 edits3 adds in trunk
2011-01-05 Chris Rogers <crogers@google.com>
Reviewed by Darin Fisher.
Add WebKitClient::createAudioDevice() for Chromium port of web audio API
https://bugs.webkit.org/show_bug.cgi?id=51424
- WebKit.gyp:
- public/WebAudioDevice.h: Added. (WebKit::WebAudioDevice::RenderCallback::~RenderCallback): (WebKit::WebAudioDevice::~WebAudioDevice):
- public/WebKitClient.h: (WebKit::WebKitClient::createAudioDevice):
- src/AudioDestinationChromium.cpp: Added. (WebCore::AudioDestination::create): (WebCore::AudioDestinationChromium::AudioDestinationChromium): (WebCore::AudioDestinationChromium::~AudioDestinationChromium): (WebCore::AudioDestinationChromium::start): (WebCore::AudioDestinationChromium::stop): (WebCore::AudioDestination::hardwareSampleRate): (WebCore::AudioDestinationChromium::render):
- src/AudioDestinationChromium.h: Added. (WebCore::AudioDestinationChromium::isPlaying): (WebCore::AudioDestinationChromium::sampleRate):
2011-01-05 Chris Rogers <crogers@google.com>
Reviewed by Darin Fisher.
Add WebKitClient::createAudioDevice() for Chromium port of web audio API
https://bugs.webkit.org/show_bug.cgi?id=51424
No new tests since audio API is not yet implemented.
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- 4:32 PM Changeset in webkit [75117] by
-
- 4 edits2 adds in trunk/WebKit2
https://bugs.webkit.org/show_bug.cgi?id=51953
Add a "SessionState" object for IPC messaging.
Reviewed by Darin Adler.
This object includes all data necessary to restore a session state;
For now, this is just the back/forward list to restore.
- Shared/SessionState.cpp: Added.
(WebKit::SessionState::SessionState):
(WebKit::SessionState::encode):
(WebKit::SessionState::decode):
- Shared/SessionState.h: Added.
(WebKit::SessionState::list):
(WebKit::SessionState::currentIndex):
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
- 4:28 PM Changeset in webkit [75116] by
-
- 7 edits2 adds in trunk/LayoutTests
2011-01-05 Kent Tamura <tkent@chromium.org>
Unreviewed, test expectation update.
Rebaseline of renderer-destruction-by-invalidateSelection-crash.html
- platform/chromium-linux/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.checksum:
- platform/chromium-linux/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
- platform/chromium-mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.checksum: Added.
- platform/chromium-mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png: Added.
- platform/chromium-win/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.checksum:
- platform/chromium-win/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
- platform/chromium-win/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
- platform/chromium/test_expectations.txt:
- 4:17 PM Changeset in webkit [75115] by
-
- 2 edits in trunk/WebCore
Try again.
- WebCore.exp.in:
- 4:10 PM Changeset in webkit [75114] by
-
- 16 edits in trunk/Tools
2011-01-05 Eric Seidel <eric@webkit.org>
Reviewed by Ojan Vafai.
commit-queue should report failure type when reporting flaky tests
https://bugs.webkit.org/show_bug.cgi?id=51900
This patch was a ridiculous amount of plumbing. In the end I like
the NRWT-style TestResult class even less. But now we're passing
a list of TestResult objects from the queue to the FlakyTestReporter.
Thus the FlakyTestReporter can more easily report what type of failure
occurred.
In the process, I found that I was not alone in finding TestResult
cumbersome to use. A bunch of code was trying to create a TestResult
object with default values. However since the constructor didn't make
this easy, some places were getting it wrong (including the TestResult unit test)!
I've fixed the TestResult constructor to have default values for non-essential
arguments.
- Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
- Scripts/webkitpy/common/net/layouttestresults.py:
- Scripts/webkitpy/common/net/layouttestresults_unittest.py:
- Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
- Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
- Scripts/webkitpy/layout_tests/layout_package/test_results.py:
- Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
- Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
- Scripts/webkitpy/tool/bot/commitqueuetask.py:
- Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
- Scripts/webkitpy/tool/bot/flakytestreporter.py:
- Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- 3:57 PM Changeset in webkit [75113] by
-
- 3 edits in trunk/Tools
2011-01-05 Eric Seidel <eric@webkit.org>
Unreviewed.
Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
https://bugs.webkit.org/show_bug.cgi?id=51802
Add another unit test to cover a previously missing import.
- Scripts/webkitpy/common/net/layouttestresults.py:
- Scripts/webkitpy/common/net/layouttestresults_unittest.py:
- 3:48 PM Changeset in webkit [75112] by
-
- 2 edits in trunk/WebCore
Attempt to fix Leopard build.
- WebCore.exp.in:
- 3:38 PM Changeset in webkit [75111] by
-
- 3 edits25 adds in trunk/LayoutTests
2011-01-05 Jenn Braithwaite <jennb@chromium.org>
Reviewed by Adam Barth.
fast/encoding/parser-tests.html is slow on debug builds
https://bugs.webkit.org/show_bug.cgi?id=51721
Break up parser tests to run 10 tests per batch.
- fast/encoding/parser-tests-10-expected.txt: Added.
- fast/encoding/parser-tests-10.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
- fast/encoding/parser-tests-100-expected.txt: Added.
- fast/encoding/parser-tests-100.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
- fast/encoding/parser-tests-110-expected.txt: Added.
- fast/encoding/parser-tests-110.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
- fast/encoding/parser-tests-120-expected.txt: Added.
- fast/encoding/parser-tests-120.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
- fast/encoding/parser-tests-20-expected.txt: Added.
- fast/encoding/parser-tests-20.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
- fast/encoding/parser-tests-30-expected.txt: Added.
- fast/encoding/parser-tests-30.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
- fast/encoding/parser-tests-40-expected.txt: Added.
- fast/encoding/parser-tests-40.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
- fast/encoding/parser-tests-50-expected.txt: Added.
- fast/encoding/parser-tests-50.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
- fast/encoding/parser-tests-60-expected.txt: Added.
- fast/encoding/parser-tests-60.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
- fast/encoding/parser-tests-70-expected.txt: Added.
- fast/encoding/parser-tests-70.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
- fast/encoding/parser-tests-80-expected.txt: Added.
- fast/encoding/parser-tests-80.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
- fast/encoding/parser-tests-90-expected.txt: Added.
- fast/encoding/parser-tests-90.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
- fast/encoding/parser-tests-expected.txt:
- fast/encoding/parser-tests.html:
- fast/encoding/resources/parser-tests.js: Added.
- 3:31 PM Changeset in webkit [75110] by
-
- 2 edits in trunk/Tools
2011-01-05 Mihai Parparita <mihaip@chromium.org>
Reviewed by David Levin.
Add mihaip@chromium.org as a reviewer
https://bugs.webkit.org/show_bug.cgi?id=51966
Add myself as a reviewer.
- Scripts/webkitpy/common/config/committers.py:
- 3:20 PM WebKit Team edited by
- (diff)
- 3:18 PM Changeset in webkit [75109] by
-
- 4 edits in trunk/LayoutTests
2011-01-05 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
[Chromium] storage/indexeddb/objectstore-basics.html is flaky after r74266
https://bugs.webkit.org/show_bug.cgi?id=51731
Fix the layout test by using a known-good date value rather than
new Date(), which sometimes causes the test to fail.
(The underlying reason for failing to store certain Date values
should of course be fixed too, but that will come in a later patch.)
- platform/chromium/test_expectations.txt:
- storage/indexeddb/objectstore-basics-expected.txt:
- storage/indexeddb/objectstore-basics.html:
- 3:17 PM Changeset in webkit [75108] by
-
- 4 edits2 adds in trunk/WebCore
2011-01-05 Evan Martin <evan@chromium.org>
Reviewed by Tony Chang.
[chromium] refactor complex text on Linux
https://bugs.webkit.org/show_bug.cgi?id=51956
Pull out TextRunWalker from FontLinux.cpp. Put it in its own file.
Rename it to ComplexTextController, to match platform/graphics/mac
more closely.
No tests because the change is just renaming a class.
- WebCore.gyp/WebCore.gyp:
- platform/graphics/chromium/ComplexTextControllerLinux.cpp: Added. (WebCore::ComplexTextController::ComplexTextController): (WebCore::ComplexTextController::~ComplexTextController): (WebCore::ComplexTextController::isWordBreak): (WebCore::ComplexTextController::determineWordBreakSpacing): (WebCore::ComplexTextController::setPadding): (WebCore::ComplexTextController::reset): (WebCore::ComplexTextController::setBackwardsIteration): (WebCore::ComplexTextController::nextScriptRun): (WebCore::ComplexTextController::widthOfFullRun): (WebCore::ComplexTextController::setupFontForScriptRun): (WebCore::ComplexTextController::allocHarfbuzzFont): (WebCore::ComplexTextController::deleteGlyphArrays): (WebCore::ComplexTextController::createGlyphArrays): (WebCore::ComplexTextController::resetGlyphArrays): (WebCore::ComplexTextController::shapeGlyphs): (WebCore::ComplexTextController::setGlyphXPositions): (WebCore::ComplexTextController::normalizeSpacesAndMirrorChars): (WebCore::ComplexTextController::getNormalizedTextRun):
- platform/graphics/chromium/ComplexTextControllerLinux.h: Added. (WebCore::ComplexTextController::setWordSpacingAdjustment): (WebCore::ComplexTextController::setLetterSpacingAdjustment): (WebCore::ComplexTextController::letterSpacing): (WebCore::ComplexTextController::setXOffsetToZero): (WebCore::ComplexTextController::rtl): (WebCore::ComplexTextController::glyphs): (WebCore::ComplexTextController::length): (WebCore::ComplexTextController::xPositions): (WebCore::ComplexTextController::advances): (WebCore::ComplexTextController::width): (WebCore::ComplexTextController::logClusters): (WebCore::ComplexTextController::numCodePoints): (WebCore::ComplexTextController::fontPlatformDataForScriptRun): (WebCore::ComplexTextController::isCodepointSpace):
- platform/graphics/chromium/FontLinux.cpp: (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::glyphIndexForXPositionInScriptRun): (WebCore::Font::offsetForPositionForComplexText): (WebCore::Font::selectionRectForComplexText):
- 2:46 PM Changeset in webkit [75107] by
-
- 2 edits in trunk/WebKit2
2011-01-05 Laszlo Gombos <Laszlo Gombos>
Unreviewed build fix.
Include unistd.h for _exit() for non-Windows builds.
Build break noticed on QtWebkit Symbian builds.
- Shared/ChildProcess.cpp:
- 2:20 PM Changeset in webkit [75106] by
-
- 8 edits in trunk/WebKit/chromium
2011-01-05 David Levin <levin@chromium.org>
Reviewed by Darin Fisher.
[chromium] WEBKIT_API and styling fixes for the chromium api.
https://bugs.webkit.org/show_bug.cgi?id=51863
Removed some incorrect uses of WEBKIT_API.
Fixed some abbreviations by making them whole words.
- public/WebAnimationController.h: Removed WEBKIT_API from virtual functions.
- public/WebFormElement.h: Removed WEBKIT_API from inline functions and fixed some abbreviations. (WebKit::WebFormElement::WebFormElement): (WebKit::WebFormElement::operator=): (WebKit::WebFormElement::assign):
- public/WebIDBDatabaseError.h: Ditto. (WebKit::WebIDBDatabaseError::WebIDBDatabaseError): (WebKit::WebIDBDatabaseError::operator=):
- public/WebInputElement.h: Ditto. (WebKit::WebInputElement::WebInputElement): (WebKit::WebInputElement::operator=): (WebKit::WebInputElement::assign):
- public/WebLabelElement.h: Ditto. (WebKit::WebLabelElement::WebLabelElement): (WebKit::WebLabelElement::operator=): (WebKit::WebLabelElement::assign):
- public/WebOptionElement.h: Ditto. (WebKit::WebOptionElement::WebOptionElement): (WebKit::WebOptionElement::operator=): (WebKit::WebOptionElement::assign):
- public/WebSelectElement.h: Ditto (and minor spacing cleanup). (WebKit::WebSelectElement::WebSelectElement): (WebKit::WebSelectElement::operator=): (WebKit::WebSelectElement::assign):
- 2:00 PM Changeset in webkit [75105] by
-
- 2 edits in trunk/LayoutTests
2011-01-05 Stephen White <senorblanco@chromium.org>
Unreviewed; test expectations update..
Fix the expectations for the hyphenation tests on chromium-win.
- platform/chromium/test_expectations.txt:
- 1:56 PM Changeset in webkit [75104] by
-
- 2 edits in trunk/LayoutTests
2011-01-05 Stephen White <senorblanco@chromium.org>
Unreviewed; test expectations fix.
- platform/chromium/test_expectations.txt: Add expectations for new tests introduced by r75097.
- 1:55 PM Changeset in webkit [75103] by
-
- 6 edits4 deletes in trunk/WebCore
2011-01-05 Pratik Solanki <psolanki@apple.com>
Reviewed by Darin Adler.
Merge cf and mac header files with same name
https://bugs.webkit.org/show_bug.cgi?id=51916
Since most of the code in the header files is identical, we can merge them and have #if
USE(CFNETWORK) to separate out the network specific parts.
- WebCore.xcodeproj/project.pbxproj:
- platform/network/cf/AuthenticationChallenge.h: (WebCore::AuthenticationChallenge::sender): (WebCore::AuthenticationChallenge::nsURLAuthenticationChallenge):
- platform/network/cf/ResourceError.h: (WebCore::ResourceError::ResourceError):
- platform/network/cf/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest):
- platform/network/cf/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse):
- platform/network/mac/AuthenticationChallenge.h: Removed.
- platform/network/mac/ResourceError.h: Removed.
- platform/network/mac/ResourceRequest.h: Removed.
- platform/network/mac/ResourceResponse.h: Removed.
- 1:48 PM Changeset in webkit [75102] by
-
- 2 edits in trunk/WebCore
Implement word transformation
https://bugs.webkit.org/show_bug.cgi?id=51943
Reviewed by Adele Peterson.
Export Editor functions needed by WebKit2.
- WebCore.exp.in:
- 1:45 PM Changeset in webkit [75101] by
-
- 2 edits in trunk/Tools
2011-01-05 James Simonsen <simonjam@chromium.org>
Unreviewed. Adding myself to the list of committers.
- Scripts/webkitpy/common/config/committers.py:
- 1:45 PM Changeset in webkit [75100] by
-
- 4 edits2 moves in trunk/WebKit2
https://bugs.webkit.org/show_bug.cgi?id=51949
Make WebBackForwardListItem shared, and add encoders and decoders
Reviewed by Darin Adler.
- Shared/WebBackForwardListItem.cpp: Copied from UIProcess/WebBackForwardListItem.cpp.
(WebKit::WebBackForwardListItem::encode):
(WebKit::WebBackForwardListItem::decode):
- Shared/WebBackForwardListItem.h: Copied from UIProcess/WebBackForwardListItem.h.
- UIProcess/WebBackForwardListItem.cpp: Removed.
- UIProcess/WebBackForwardListItem.h: Removed.
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
- 1:34 PM Changeset in webkit [75099] by
-
- 3 edits in trunk/Tools
2011-01-05 Eric Seidel <eric@webkit.org>
Unreviewed.
Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
https://bugs.webkit.org/show_bug.cgi?id=51802
Fix two exceptions seen on the bots after my original commit.
- Scripts/webkitpy/common/net/layouttestresults.py:
- Scripts/webkitpy/common/net/layouttestresults_unittest.py:
- 1:22 PM Changeset in webkit [75098] by
-
- 13 edits in trunk/WebKit2
2011-01-05 Anders Carlsson <andersca@apple.com>
Reviewed by Adele Peterson.
Implement word transformation
https://bugs.webkit.org/show_bug.cgi?id=51943
Export Editor functions needed by WebKit2.
- WebCore.exp.in:
2011-01-05 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Handle smart insert/delete
https://bugs.webkit.org/show_bug.cgi?id=51946
- Shared/WebPageCreationParameters.cpp: (WebKit::WebPageCreationParameters::encode): (WebKit::WebPageCreationParameters::decode):
- Shared/WebPageCreationParameters.h: Add isSmartInsertDelete enabled.
- UIProcess/API/mac/WKView.mm: (-[WKView validateUserInterfaceItem:]): Handle toggleSmartInsertDelete:.
(-[WKView toggleSmartInsertDelete:]):
Toggle the smart insert/delete state.
- UIProcess/TextChecker.h: Add isSmartInsertDeleteEnabled and setSmartInsertDeleteEnabled.
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::WebPageProxy): Initialize m_isSmartInsertDeleteEnabled.
(WebKit::WebPageProxy::contextMenuItemSelected):
Handle ContextMenuItemTagSmartCopyPaste.
(WebKit::WebPageProxy::setSmartInsertDeleteEnabled):
Update the state and send a SetSmartInsertDeleteEnabled message.
(WebKit::WebPageProxy::creationParameters):
Initialize isSmartInsertDeleteEnabled.
- UIProcess/WebPageProxy.h: (WebKit::WebPageProxy::isSmartInsertDeleteEnabled): Return m_isSmartInsertDeleteEnabled.
- UIProcess/mac/TextCheckerMac.mm: (WebKit::TextChecker::isSmartInsertDeleteEnabled): (WebKit::TextChecker::setSmartInsertDeleteEnabled): Store and fetch the smart insert delete state.
- WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::smartInsertDeleteEnabled): Call WebPage::isSmartInsertDeleteEnabled.
- WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm: (WebKit::WebEditorClient::toggleSmartInsertDelete): Assert that this is never called.
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage): Initialize m_isSmartInsertDeleteEnabled
- WebProcess/WebPage/WebPage.h: (WebKit::WebPage::isSmartInsertDeleteEnabled): (WebKit::WebPage::setSmartInsertDeleteEnabled): Add getter and setter.
- WebProcess/WebPage/WebPage.messages.in: Add SetSmartInsertDeleteEnabled message.
- 1:06 PM Changeset in webkit [75097] by
-
- 9 edits8 adds in trunk
2011-01-05 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt.
Implement repeating CSS3 gradients
https://bugs.webkit.org/show_bug.cgi?id=51843
Add support for repeating gradients, via the new gradient functions
-webkit-repeating-linear-gradient and -webkit-repeating-radial-gradient.
Tests: fast/gradients/css3-repeating-linear-gradients.html
fast/gradients/css3-repeating-radial-gradients.html
- css/CSSGradientValue.h: (WebCore::CSSGradientValue::isRepeating): Accessor for whethe the gradient repeats. (WebCore::CSSGradientValue::CSSGradientValue): Pass CSSGradientRepeat in. (WebCore::CSSLinearGradientValue::create): Pass CSSGradientRepeat. (WebCore::CSSLinearGradientValue::CSSLinearGradientValue): Ditto (WebCore::CSSRadialGradientValue::create): Ditto. (WebCore::CSSRadialGradientValue::CSSRadialGradientValue): Ditto.
- css/CSSGradientValue.cpp: (WebCore::CSSGradientValue::addStops): Pass maxLengthForRepeat, which is used for repeating radial gradients. Add code to repeat the stops, adding stops before the start, and after the end until the 0-N range is covered, where N is large enough to ensure the box is covered. Fix an issue with repeating gradients where if both stops were < 0, it would fail to clamp them to 0.
(WebCore::CSSLinearGradientValue::cssText): Output strings for repeating gradients.
(WebCore::CSSLinearGradientValue::createGradient): maxExtent for linear gradients is 1,
because they are guaranteed to fill the box already.
(WebCore::CSSRadialGradientValue::cssText): Output strings for repeating gradients.
(WebCore::CSSRadialGradientValue::createGradient): Compute the distance to the furthest
corner in order to inform addStops() how much additional extent is required.
- css/CSSParser.cpp: (WebCore::CSSParser::parseDeprecatedGradient): Old gradients never repeat. (WebCore::CSSParser::parseLinearGradient): Pass down CSSGradientRepeat. (WebCore::CSSParser::parseRadialGradient): Ditto. (WebCore::CSSParser::isGeneratedImageValue): Add repeating gradient functions. (WebCore::CSSParser::parseGeneratedImage): Ditto.
- css/CSSParser.h: Pass CSSGradientRepeat to gradient functions.
- platform/graphics/cg/GradientCG.cpp: Remove unused #include.
- 12:50 PM Changeset in webkit [75096] by
-
- 3 edits in trunk/LayoutTests
2011-01-05 Stephen White <senorblanco@chromium.org>
Unreviewed; test expectations fix.
- platform/chromium/test_expectations.txt: Add a few failing tests to chromium's test expectations file.
- platform/chromium-gpu/test_expectations.txt: Mark the shadow-offset tests as crashing on win debug (GPU). Remove a duplicate MAC expectation.
- 12:33 PM Changeset in webkit [75095] by
-
- 2 edits in trunk/WebCore
2011-01-05 Martin Robinson <mrobinson@igalia.com>
Reviewed by Ariya Hidayat.
ContextShadow::blurLayerImage() not endian-safe
https://bugs.webkit.org/show_bug.cgi?id=51822
Correct the channel map in ContextShadow to reflect the different
ordering of pixels on processors with different endianness.
No new tests. This is covered by the existing shadow tests. It was
not discovered, because all of the bots using ContextShadow are
little-endian.
- platform/graphics/ContextShadow.cpp: (WebCore::ContextShadow::blurLayerImage): Initialize the channel mapping based on machine endianness.
- 12:26 PM Changeset in webkit [75094] by
-
- 2 edits in trunk/WebKit2
Fix Windows build.
- WebProcess/WebPage/WebPage.cpp:
- 12:19 PM Changeset in webkit [75093] by
-
- 8 edits in trunk/WebKit2
2011-01-05 Anders Carlsson <andersca@apple.com>
Reviewed by Adele Peterson.
Implement word transformation
https://bugs.webkit.org/show_bug.cgi?id=51943
Export Editor functions needed by WebKit2.
- WebCore.exp.in:
2011-01-05 Anders Carlsson <andersca@apple.com>
Reviewed by Adele Peterson.
Implement word transformation
https://bugs.webkit.org/show_bug.cgi?id=51943
- UIProcess/API/mac/WKView.mm: (-[WKView validateUserInterfaceItem:]): Handle the word transformation selectors.
(-[WKView uppercaseWord:]):
(-[WKView lowercaseWord:]):
(-[WKView capitalizeWord:]):
Call down to the WebPageProxy.
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::uppercaseWord): (WebKit::WebPageProxy::lowercaseWord): (WebKit::WebPageProxy::capitalizeWord): Send messages to the WebPage.
- WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm: (WebKit::changeWordCase): Add helper function.
(WebKit::WebEditorClient::uppercaseWord):
(WebKit::WebEditorClient::lowercaseWord):
(WebKit::WebEditorClient::capitalizeWord):
Call helper function.
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::changeSpellingToWord): Call replaceSelectionWithText.
(WebKit::WebPage::uppercaseWord):
(WebKit::WebPage::lowercaseWord):
(WebKit::WebPage::capitalizeWord):
Call the editor functions.
(WebKit::WebPage::replaceSelectionWithText):
New helper function that replaces the selected string with another string.
- WebProcess/WebPage/WebPage.messages.in: Add new messages.
- 12:03 PM Changeset in webkit [75092] by
-
- 2 edits in trunk/WebCore
2011-01-05 Mihai Parparita <mihaip@chromium.org>
Reviewed by Nate Chapin.
[Chromium] Crash when drawing PDF plug-in scrollbars
https://bugs.webkit.org/show_bug.cgi?id=51942
Pepper plug-in scrollbars don't have a parent, guard against that before
seeing if the parent is a FrameView.
Not testable via layout tests, verified fix by hand.
- platform/chromium/ScrollbarThemeChromiumMac.mm: (WebCore::ScrollbarThemeChromiumMac::paint):
- 11:59 AM Changeset in webkit [75091] by
-
- 2 edits in branches/chromium/597/WebCore/inspector/front-end
Revert 73364 - Merge 73229 - 2010-12-02 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Fix heap snapshots loading. Loading is now
conducted by the Profiles panel which prevents accidental
simultaneous attempts to load the same profile several times in
parallel.
- inspector/front-end/HeapSnapshotView.js: (WebInspector.HeapSnapshotView.prototype._loadProfile): (WebInspector.HeapSnapshotView.prototype.processLoadedSnapshot):
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.loadHeapSnapshot): (WebInspector.ProfilesPanel.prototype.addHeapSnapshotChunk): (WebInspector.ProfilesPanel.prototype.finishHeapSnapshot):
TBR=mnaganov@chromium.org
Review URL: http://codereview.chromium.org/5657001
TBR=yurys@chromium.org
Review URL: http://codereview.chromium.org/6048013
- 11:59 AM Changeset in webkit [75090] by
-
- 1 edit2 copies in branches/chromium/552
Merge 75082
BUG=68439
- 11:48 AM Changeset in webkit [75089] by
-
- 3 edits in trunk/WebKit2
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=51935
Add WebKit2 API for largest frame
- UIProcess/API/C/WKPage.cpp: (WKPageGetFrameSetLargestFrame):
- UIProcess/API/C/WKPage.h:
- 11:45 AM Changeset in webkit [75088] by
-
- 2 edits in trunk/LayoutTests
2011-01-05 Stephen White <senorblanco@chromium.org>
Unreviewed; test expectations fix.
Update chromium GPU test_expectations.txt file to match the
layout of the CPU results more closely.
- platform/chromium-gpu/test_expectations.txt:
- 11:44 AM Changeset in webkit [75087] by
-
- 2 edits in trunk/LayoutTests
2011-01-05 Maciej Stachowiak <mjs@apple.com>
Reviewed by Anders Carlsson.
Remove entries from WebKit2 skipped list that no longer exist
https://bugs.webkit.org/show_bug.cgi?id=51936
- platform/mac-wk2/Skipped:
- 11:41 AM Changeset in webkit [75086] by
-
- 14 edits in trunk/WebKit2
2011-01-05 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
More work on spelling
https://bugs.webkit.org/show_bug.cgi?id=51939
- UIProcess/API/mac/WKView.mm: (-[WKView validateUserInterfaceItem:]): Handle changeSpelling: as well.
(-[WKView showGuessPanel:]):
Show or hide the guess panel.
(-[WKView checkSpelling:]):
Pass false to advanceToNextMisspelling.
(-[WKView changeSpelling:]):
Call changeSpellingToWord.
- UIProcess/TextChecker.h:
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::WebPageProxy): Initialize m_pendingLearnOrIgnoreWordMessageCount.
(WebKit::WebPageProxy::contextMenuItemSelected):
Handle smart toggles directly in the UI process, keep track of whether
we're asked to learn or ignore a word.
(WebKit::WebPageProxy::advanceToNextMisspelling):
Pass the boolean through.
(WebKit::WebPageProxy::changeSpellingToWord):
Send a ChangeSpellingToWord message.
(WebKit::WebPageProxy::learnWord):
(WebKit::WebPageProxy::ignoreWord):
Check that we do have a pending learn or ignore word message. Call through to
the text checker.
(WebKit::WebPageProxy::processDidCrash):
Reset the m_pendingLearnOrIgnoreWordMessageCount variable.
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in: Add new messages.
- UIProcess/mac/TextCheckerMac.mm: (WebKit::TextChecker::learnWord): (WebKit::TextChecker::ignoreWord): Implement in terms of NSSpellChecker.
- WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::ignoreWordInSpellDocument): (WebKit::WebEditorClient::learnWord): Send IgnoreWord and LearnWord messages.
- WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm: (WebKit::WebEditorClient::toggleAutomaticQuoteSubstitution): (WebKit::WebEditorClient::toggleAutomaticLinkDetection): (WebKit::WebEditorClient::toggleAutomaticDashSubstitution): (WebKit::WebEditorClient::toggleAutomaticTextReplacement): Add assertions.
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::advanceToNextMisspelling): Pass the bool along to the Editor.
(WebKit::WebPage::changeSpellingToWord):
Replace the selected text.
- WebProcess/WebPage/WebPage.messages.in: Add new ChangeSpellingToWord message and add a boolean to AdvanceToNextMisspelling.
- 11:23 AM Changeset in webkit [75085] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed build fix.
- wtf/Encoder.h: Add <stdint.h> include for systems that
do not natively know about uint8_t, etc.
- 11:15 AM BuildingQtOnWindows edited by
- Removed "C Program Files\SlikSvn\bin\" from Path since this path is … (diff)
- 11:09 AM Changeset in webkit [75084] by
-
- 2 edits in trunk/WebCore
2011-01-05 Abhishek Arya <inferno@chromium.org>
Unreviewed.
Update FIXME comment to sound better. Also initialize the block to fix compile.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::removeChild):
- 11:03 AM Changeset in webkit [75083] by
-
- 3 edits in trunk/LayoutTests
Land failing Windows results after r75031. Fixing the tests is being tracked by
https://bugs.webkit.org/show_bug.cgi?id=51912.
- platform/win/accessibility/document-role-expected.txt:
- platform/win/accessibility/selection-and-focus-expected.txt:
- 10:58 AM Changeset in webkit [75082] by
-
- 3 edits2 adds in trunk
2011-01-05 Abhishek Arya <inferno@chromium.org>
Reviewed by Dave Hyatt.
Do not merge anonymous blocks when one of them is the one getting removed.
https://bugs.webkit.org/show_bug.cgi?id=51919
Test: fast/block/merge-anonymous-block-remove-child-crash.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::removeChild):
2011-01-05 Abhishek Arya <inferno@chromium.org>
Reviewed by Dave Hyatt.
Tests that we do not crash when trying to merge two anonymous blocks,
one of which is getting removed.
https://bugs.webkit.org/show_bug.cgi?id=51919
- fast/block/merge-anonymous-block-remove-child-crash-expected.txt: Added.
- fast/block/merge-anonymous-block-remove-child-crash.html: Added.
- 10:48 AM Changeset in webkit [75081] by
-
- 2 edits in trunk/WebKit/gtk
2011-01-05 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha.
Build fix for GTK+ 3.x. Remove the call to gtk_range_set_update_policy.
GTK+ 3.x has removed this method and the default in GTK+ 2.x is continuous,
so this call is unnecessary.
- WebCoreSupport/FullscreenVideoController.cpp: (FullscreenVideoController::createHud): Remove call to gtk_range_set_update_policy().
- 10:32 AM Changeset in webkit [75080] by
-
- 5 edits in trunk/WebCore
2011-01-05 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
ApplyStyleCommand::applyRelativeFontStyleChange should take EditingStyle*
https://bugs.webkit.org/show_bug.cgi?id=50641
Modified applyRelativeFontStyleChange to take EditingStyle instead of CSSMutableStyleDeclaration.
Also extracted the logic to obtain the font size delta from ApplyStyleCommand to EditingStyle.
The font size delta is now stored as a member variable of EditingStyle as supposed to a property
in CSSMutableStyleDeclration as soon as EditingStyle is instantiated.
No new tests are added since this is a refactoring.
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::doApply): Calls applyRelativeFontStyleChange. (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Takes EditingStyle.
- editing/ApplyStyleCommand.h:
- editing/EditingStyle.cpp: (WebCore::EditingStyle::EditingStyle): Initializes m_fontSizeDelta. (WebCore::EditingStyle::init): Ditto. (WebCore::EditingStyle::extractFontSizeDelta): Extracted from applyRelativeFontStyleChange. (WebCore::EditingStyle::isEmpty): Takes care of m_fontSizeDelta. (WebCore::EditingStyle::setStyle): Calls extractFontSizeDelta. (WebCore::EditingStyle::overrideWithStyle): Ditto. (WebCore::EditingStyle::clear): Initializes m_fontSizeDelta. (WebCore::EditingStyle::copy): Calls extractFontSizeDelta.
- editing/EditingStyle.h: (WebCore::EditingStyle::fontSizeDelta): Added. (WebCore::EditingStyle::hasFontSizeDelta): Added.
- editing/Editor.h:
- 10:28 AM Changeset in webkit [75079] by
-
- 6 edits in trunk/WebKit2
2011-01-05 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Keep track of active text substitution preferences
https://bugs.webkit.org/show_bug.cgi?id=51931
- Shared/TextCheckerState.h:
- UIProcess/API/mac/WKView.mm: (-[WKView validateUserInterfaceItem:]): Handle new selectors, mostly copied from WebKit1 code.
(-[WKView orderFrontSubstitutionsPanel:]):
Open the substitution panel.
(-[WKView isAutomaticQuoteSubstitutionEnabled]):
(-[WKView setAutomaticQuoteSubstitutionEnabled:]):
(-[WKView toggleAutomaticQuoteSubstitution:]):
(-[WKView isAutomaticDashSubstitutionEnabled]):
(-[WKView setAutomaticDashSubstitutionEnabled:]):
(-[WKView toggleAutomaticDashSubstitution:]):
(-[WKView isAutomaticLinkDetectionEnabled]):
(-[WKView setAutomaticLinkDetectionEnabled:]):
(-[WKView toggleAutomaticLinkDetection:]):
(-[WKView isAutomaticTextReplacementEnabled]):
(-[WKView setAutomaticTextReplacementEnabled:]):
(-[WKView toggleAutomaticTextReplacement:]):
Call the text checker, and update the state in the web process if needed.
- UIProcess/TextChecker.h: Add new flags.
- UIProcess/mac/TextCheckerMac.mm: (WebKit::initializeState): Initialize flags from user defaults.
(WebKit::TextChecker::setAutomaticQuoteSubstitutionEnabled):
(WebKit::TextChecker::setAutomaticDashSubstitutionEnabled):
(WebKit::TextChecker::setAutomaticLinkDetectionEnabled):
(WebKit::TextChecker::setAutomaticTextReplacementEnabled):
Update and save the flags.
- WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm: (WebKit::WebEditorClient::isAutomaticQuoteSubstitutionEnabled): (WebKit::WebEditorClient::isAutomaticLinkDetectionEnabled): (WebKit::WebEditorClient::isAutomaticDashSubstitutionEnabled): (WebKit::WebEditorClient::isAutomaticTextReplacementEnabled): Get the text checker state.
- 10:16 AM Changeset in webkit [75078] by
-
- 2 edits in trunk/WebKit/qt
2011-01-05 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Andreas Kling.
[Qt] Sync qwebkitplatformplugin.h in the plugin example
https://bugs.webkit.org/show_bug.cgi?id=51882
Make examples/platformplugin/qwebkitplatformplugin.h exactly the same
as the one in the Api folder.
- examples/platformplugin/qwebkitplatformplugin.h:
- 10:03 AM Changeset in webkit [75077] by
-
- 15 edits in trunk
<rdar://problem/8799835> hyphenate-character: auto should fall back to hyphen-minus if the primary font lacks a hyphen glyph
https://bugs.webkit.org/show_bug.cgi?id=51915
Reviewed by Darin Adler.
WebCore:
This changes the results of existing tests in fast/text.
- platform/graphics/Font.h:
- platform/graphics/FontFastPath.cpp:
(WebCore::Font::primaryFontHasGlyphForCharacter): Added.
- rendering/style/RenderStyle.cpp:
- platform/graphics/qt/FontQt.cpp:
(WebCore::Font::primaryFontHasGlyphForCharacter): Added a stub.
(WebCore::RenderStyle::hyphenString): For hyphenate-character: auto, return a
hyphen only if the primary font has a hyphen glyph, and otherwise return a
hyphen-minus.
LayoutTests:
- platform/mac/fast/text/basic/014-expected.checksum:
- platform/mac/fast/text/basic/014-expected.png:
- platform/mac/fast/text/basic/014-expected.txt:
- platform/mac/fast/text/capitalize-boundaries-expected.checksum:
- platform/mac/fast/text/capitalize-boundaries-expected.png:
- platform/mac/fast/text/capitalize-boundaries-expected.txt:
- platform/mac/fast/text/midword-break-after-breakable-char-expected.checksum:
- platform/mac/fast/text/midword-break-after-breakable-char-expected.png:
- platform/mac/fast/text/midword-break-after-breakable-char-expected.txt:
- 9:55 AM Changeset in webkit [75076] by
-
- 2 edits in trunk/WebCore
2011-01-05 Laszlo Gombos <Laszlo Gombos>
Reviewed by Ariya Hidayat.
[Qt] [Symbian] Make CONFIG-=def_files the default configuration for trunk builds
https://bugs.webkit.org/show_bug.cgi?id=51888
Overrule Qt's default from qconfig.pri for non-production builds so
that CONFIG(def_files) evaluates to false and QtWebKit trunk builds succeed.
No new tests as there is no new functionality.
- WebCore.pro:
- 9:50 AM Changeset in webkit [75075] by
-
- 2 edits in trunk/WebKit2
Cleaned up com.apple.WebProcess.sb
Rubber-stamped by Darin Adler.
- WebProcess/com.apple.WebProcess.sb: Moved the closing parentheses of multi-line blocks to
their own lines. Changed to use WebKit-standard 4-space indentation.
- 9:37 AM Changeset in webkit [75074] by
-
- 2 edits in trunk/Tools
2011-01-05 Kundu Suchismita <suchi.kundu@nokia.com>
Reviewed by Andreas Kling.
[Qt]Add local storage settings to QtTestBrowser command line arguments
https://bugs.webkit.org/show_bug.cgi?id=51750
- QtTestBrowser/main.cpp: (LauncherApplication::handleUserOptions): Local storage settings can be enable form command line arguments for QtTestBrowser.
- 9:33 AM Changeset in webkit [75073] by
-
- 3 edits in trunk/WebCore
2011-01-05 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r74778.
http://trac.webkit.org/changeset/74778
https://bugs.webkit.org/show_bug.cgi?id=51930
Android and QtWebKit-V8 uses V8DOMWindowShell::setContext.
(Requested by bbandix on #webkit).
- bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::setContext):
- bindings/v8/V8DOMWindowShell.h:
- 9:31 AM Changeset in webkit [75072] by
-
- 5 edits in trunk
GTK: AX: DRT needs to use correct root object method.
https://bugs.webkit.org/show_bug.cgi?id=51911
Reviewed by Martin Robinson.
Tools:
- DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
(AccessibilityController::rootElement):
WebKit/gtk:
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::getRootAccessibleElement):
(DumpRenderTreeSupportGtk::getFocusedAccessibleElement):
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
- 9:27 AM Changeset in webkit [75071] by
-
- 2 edits1 add in trunk/WebCore
2011-01-05 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Andreas Kling.
[Qt] Animated GIF images does not animate 10x as expected by default.
https://bugs.webkit.org/show_bug.cgi?id=36818
Add a test animated GIF which should be displayed 2 times and stop.
- manual-tests/animated-gif-looping.html:
- manual-tests/resources/animated-2x.gif: Added.
- 9:23 AM Changeset in webkit [75070] by
-
- 4 edits2 adds in trunk/WebCore
2011-01-05 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Fork code of ScrollbarThemeGtk that will differ for GTK+ 3
https://bugs.webkit.org/show_bug.cgi?id=51923
Split out pieces of ScrollbarThemeGtk into ScrollbarThemeGtk2 and
ScrollbarThemeGtk3 that will differ between GTK+ 2 and GTK+ 3.
No new tests. This should not change functionality.
- GNUmakefile.am: Add ScrollbarThemeGtk2.cpp and ScrollbarThemeGtk3.cpp
- platform/gtk/ScrollbarThemeGtk.cpp: (WebCore::ScrollbarThemeGtk::updateScrollbarsFrameThickness):
- platform/gtk/ScrollbarThemeGtk.h:
- platform/gtk/ScrollbarThemeGtk2.cpp: Added. (WebCore::ScrollbarThemeGtk::updateThemeProperties): (WebCore::ScrollbarThemeGtk::paintTrackBackground): (WebCore::ScrollbarThemeGtk::paintScrollbarBackground): (WebCore::ScrollbarThemeGtk::paintThumb): (WebCore::ScrollbarThemeGtk::paintButton):
- platform/gtk/ScrollbarThemeGtk3.cpp: Added. (WebCore::ScrollbarThemeGtk::updateThemeProperties): (WebCore::ScrollbarThemeGtk::paintTrackBackground): (WebCore::ScrollbarThemeGtk::paintScrollbarBackground): (WebCore::ScrollbarThemeGtk::paintThumb): (WebCore::ScrollbarThemeGtk::paintButton):
- 8:55 AM Changeset in webkit [75069] by
-
- 6 edits in trunk
2011-01-05 Patrick Gansterer <Patrick Gansterer>
Reviewed by Andreas Kling.
[CMake] Fix the usage of SOURCE_GROUP
https://bugs.webkit.org/show_bug.cgi?id=51739
- Source/cmake/WebKitMacros.cmake:
2011-01-05 Patrick Gansterer <Patrick Gansterer>
Reviewed by Andreas Kling.
[CMake] Fix the usage of SOURCE_GROUP
https://bugs.webkit.org/show_bug.cgi?id=51739
- CMakeLists.txt:
2011-01-05 Patrick Gansterer <Patrick Gansterer>
Reviewed by Andreas Kling.
[CMake] Fix the usage of SOURCE_GROUP
https://bugs.webkit.org/show_bug.cgi?id=51739
- CMakeLists.txt:
- 8:37 AM Changeset in webkit [75068] by
-
- 4 edits in trunk
2011-01-05 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt][V8] Fix the build after recent changes.
- pcre/pcre.pri: Correct the path after Source was introduced.
2011-01-05 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt][V8] Fix the build after recent changes.
No new tests needed.
- WebCore.pro: Add missing files, and remove obsolete ones.
- 8:28 AM Changeset in webkit [75067] by
-
- 2 edits in trunk
2011-01-05 Patrick Gansterer <Patrick Gansterer>
Reviewed by Andreas Kling.
[WINCE] Remove CMake warning
https://bugs.webkit.org/show_bug.cgi?id=51921
- Source/cmake/WebKitHelpers.cmake:
- 7:51 AM Changeset in webkit [75066] by
-
- 8 edits in trunk/WebCore
2011-01-05 Yong Li <yoli@rim.com>
Reviewed by Adam Barth.
Suspend HTMLParserScheduler when page load is deferred to
avoid potential JS re-entrancy. Otherwise, when JS execution is triggered
from an external script or by events, and is blocked by a modal dialog,
WebKit can parse more HTML source and also start another JS execution.
Test case: WebCore/manual-tests/bugzilla-48077.html.
- dom/DocumentParser.cpp: (WebCore::DocumentParser::suspendScheduledTasks): (WebCore::DocumentParser::resumeScheduledTasks):
- dom/DocumentParser.h:
- html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::suspendScheduledTasks): (WebCore::HTMLDocumentParser::resumeScheduledTasks):
- html/parser/HTMLParserScheduler.cpp: (WebCore::HTMLParserScheduler::HTMLParserScheduler): (WebCore::HTMLParserScheduler::suspend): (WebCore::HTMLParserScheduler::resume):
- html/parser/HTMLParserScheduler.h: (WebCore::HTMLParserScheduler::isScheduledForResume):
- page/PageGroupLoadDeferrer.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
- 7:48 AM Changeset in webkit [75065] by
-
- 2 edits in trunk/WebCore
[GStreamer] MediaPlayerPrivateGStreamer::totalBytes() does not work reliably
https://bugs.webkit.org/show_bug.cgi?id=51926
Reviewed by Kenneth Rohde Christiansen, Gustavo Noronha Silva
Work around potential upstream bug: Querying a GstBin for the duration,
will forward the query to all sink children. Our WebKitWebSrc however
is a bin with only source children, therefore the query fails. Until
this is changed upstream, this patch works around it as follows,
based on suggestion by Philippe Normand and Sebastian Dröge:
When the initial query fails, attempt the same query on all source
pads and take the maximum length reported.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::totalBytes):
- 7:24 AM Changeset in webkit [75064] by
-
- 2 edits in trunk/WebKit/chromium
2011-01-05 Hans Wennborg <hans@chromium.org>
Reviewed by David Levin.
[Chromium] WebIDBKey clean-up
https://bugs.webkit.org/show_bug.cgi?id=51925
Remove constructors that are no longer used since the
Chromium side has been updated.
- public/WebIDBKey.h:
- 6:11 AM Changeset in webkit [75063] by
-
- 2 edits in trunk/Tools
Based on idea from Péter Gál.
Patch by Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> on 2011-01-05
Rubber-stamped by Csaba Osztrogonác.
- Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
- 5:25 AM Changeset in webkit [75062] by
-
- 4 edits in trunk/Tools
sheriff-bot should be able to do multi-revision rollouts
https://bugs.webkit.org/show_bug.cgi?id=51176
Patch by Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> on 2011-01-05
Reviewed by Adam Barth.
- Scripts/webkitpy/tool/bot/irc_command.py:
- Scripts/webkitpy/tool/bot/sheriff.py:
- Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
- 5:13 AM WinCE edited by
- (diff)
- 5:04 AM Changeset in webkit [75061] by
-
- 2 edits in trunk/WebCore
2011-01-05 Philippe Normand <pnormand@igalia.com>
Rubber-stamped by Eric Seidel.
[GStreamer] build fails with gstreamer core 0.10.31 and -plugins-base 0.10.30
https://bugs.webkit.org/show_bug.cgi?id=51810
Based on a patch by Mart Raudsepp.
No new tests, build fix only.
- platform/graphics/gstreamer/GStreamerGWorld.cpp: (WebCore::GStreamerGWorld::setWindowOverlay): Use the new xoverlay API if the GST_CHECK_PLUGINS_BASE_VERSION macro is defined. It was introduced in same version as the xoverlay API change.
- 4:39 AM Changeset in webkit [75060] by
-
- 6 edits in trunk/Tools
2011-01-05 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
queues.webkit.org should have per-bot status pages
https://bugs.webkit.org/show_bug.cgi?id=51906
Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
statuses from a single queue. Now that we have many bots servicing
some queues (commit-queue, win-ews, etc.) its easy to have the messages
you care about scroll off the end of the 15-message limit on the main page.
Eventually we should probably rename /queue-status to /queue or /queues,
but that's fodder for another patch.
- QueueStatusServer/handlers/queuestatus.py:
- QueueStatusServer/index.yaml:
- QueueStatusServer/main.py:
- QueueStatusServer/templates/includes/singlequeuestatus.html:
- This probably should use a custom filter instead of hard-coding the URL scheme here, but I couldn't figure out how to easily create such a filter. Most filters work with "strings" so we can't pass the status object. We could add a method to the status object and call that, but that seemed a bit strange too.
- QueueStatusServer/templates/queuestatus.html:
- 4:11 AM Changeset in webkit [75059] by
-
- 4 edits2 adds in trunk
2011-01-05 Leo Yang <leo.yang@torchmobile.com.cn>
Reviewed by Dirk Schulze.
Malformed SVG causes crash in updateContainerOffset
https://bugs.webkit.org/show_bug.cgi?id=44610
Test case for recursive svg <use>.
This test case passes if no crash occurs.
- svg/custom/recursive-use-expected.txt: Added.
- svg/custom/recursive-use.svg: Added.
2011-01-05 Leo Yang <leo.yang@torchmobile.com.cn>
Reviewed by Dirk Schulze.
Malformed SVG causes crash in updateContainerOffset
https://bugs.webkit.org/show_bug.cgi?id=44610
We should check recursive <use> at the begining of
WebCore::SVGUseElement::buildInstanceTree instead
of at the end of it because the target element's
children may cause infinite recursive <use>.
Test: svg/custom/recursive-use.svg
- svg/SVGUseElement.cpp: (WebCore::SVGUseElement::buildInstanceTree): (WebCore::SVGUseElement::hasCycleUseReferencing):
- svg/SVGUseElement.h:
- 4:03 AM Changeset in webkit [75058] by
-
- 2 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=51907
Style selector should only be recalculated when the pending sheet count goes to zero
Reviewed by Dan Bernstein.
Shark says this is a significant performance improvement on some sites with lots of stylesheets.
- dom/Document.cpp:
(WebCore::Document::removePendingSheet):
- 3:52 AM Changeset in webkit [75057] by
-
- 3 edits in trunk/LayoutTests
Not reviewed.
Update a pixel test result for https://bugs.webkit.org/show_bug.cgi?id=8852.
- platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.checksum:
- platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
- 2:45 AM Changeset in webkit [75056] by
-
- 4 edits in trunk/WebCore
2011-01-05 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Use GtkStyleContext to get platform colors
https://bugs.webkit.org/show_bug.cgi?id=51830
Use GtkStyleContext API to get platform colors when building with
GTK+ 3.x.
No new tests. This should not change functionality.
- platform/graphics/Color.h: Add specialized constructor for GdkRGBA.
- platform/graphics/gtk/ColorGtk.cpp: (WebCore::Color::Color): (WebCore::Color::operator GdkRGBA):
- platform/gtk/RenderThemeGtk3.cpp: (WebCore::RenderThemeGtk::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeGtk::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeGtk::platformActiveSelectionForegroundColor): (WebCore::RenderThemeGtk::platformInactiveSelectionForegroundColor): (WebCore::RenderThemeGtk::activeListBoxSelectionBackgroundColor): (WebCore::RenderThemeGtk::inactiveListBoxSelectionBackgroundColor): (WebCore::RenderThemeGtk::activeListBoxSelectionForegroundColor): (WebCore::RenderThemeGtk::inactiveListBoxSelectionForegroundColor): (WebCore::RenderThemeGtk::systemColor):
- 2:18 AM Changeset in webkit [75055] by
-
- 2 edits in trunk/WebCore
2011-01-05 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Build fix for GTK when using gtk+-3 after r75009.
- platform/gtk/RenderThemeGtk3.cpp: (WebCore::RenderThemeGtk::getStockIcon): Use adoptGRef instead of adoptGRefPtr which doesn't exist.
- 1:32 AM Changeset in webkit [75054] by
-
- 10 edits in trunk
2011-01-05 Alexey Proskuryakov <ap@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=51903
Tell UI process which subframe is largest
- WebCore.exp.in: Exported FrameView::contentsSize().
2011-01-05 Alexey Proskuryakov <ap@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=51903
Tell UI process which subframe is largest
- UIProcess/WebPageProxy.h: (WebKit::WebPageProxy::frameSetLargestFrame): Remember largest frame in frameset pages.
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::frameDidBecomeFrameSet): Reset stored largest frame if main frame changes to a frameset or back. (WebKit::WebPageProxy::frameSetLargestFrameChanged): Store a new largest frame when notified of a change.
- UIProcess/WebPageProxy.messages.in: Added FrameSetLargestFrameChanged.
- WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::area): Calculate area of a frame. (WebKit::findLargestFrameInFrameSet): Find largest first-level subframe in a frameset page. (WebKit::WebChromeClient::contentsSizeChanged): Recalculate largest frame, and notify UI process if it changed.
- WebProcess/WebCoreSupport/WebChromeClient.h: Store the latest largest frame.
- WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::size):
- WebProcess/WebPage/WebFrame.h: Expose frame size.
- 1:12 AM Changeset in webkit [75053] by
-
- 2 edits in trunk/Tools
2011-01-05 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Adding myself to the list of committers.
- Scripts/webkitpy/common/config/committers.py:
- 12:06 AM WebKit Team edited by
- Add myself to committer list (diff)
