⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 7, 2011:

11:37 PM Changeset in webkit [75310] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-07 Adam Barth <​abarth@webkit.org>

Record expectation for test.

  • platform/chromium/test_expectations.txt:
8:38 PM Changeset in webkit [75309] by mihaip@chromium.org
  • 37 edits in trunk/LayoutTests

2011-01-07 Mihai Parparita <​mihaip@chromium.org>

Unreviewed, test expectation update.

Update mac-leopard baselines for tests that currently have up to date
Snow Leopard baselines in platform/mac.

  • platform/mac-leopard/fast/css/text-overflow-ellipsis-strict-expected.checksum:
  • platform/mac-leopard/fast/css/text-overflow-ellipsis-strict-expected.png:
  • platform/mac-leopard/fast/invalid/residual-style-expected.checksum:
  • platform/mac-leopard/fast/invalid/residual-style-expected.png:
  • platform/mac-leopard/fast/multicol/span/span-as-immediate-child-generated-content-expected.checksum:
  • platform/mac-leopard/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
  • platform/mac-leopard/fast/multicol/span/span-as-immediate-child-property-removal-expected.checksum:
  • platform/mac-leopard/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
  • platform/mac-leopard/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.checksum:
  • platform/mac-leopard/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png:
  • platform/mac-leopard/fast/multicol/span/span-as-immediate-columns-child-removal-expected.checksum:
  • platform/mac-leopard/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
  • platform/mac-leopard/fast/table/027-vertical-expected.checksum:
  • platform/mac-leopard/fast/table/027-vertical-expected.png:
  • platform/mac-leopard/fast/table/028-vertical-expected.checksum:
  • platform/mac-leopard/fast/table/028-vertical-expected.png:
  • platform/mac-leopard/fast/table/038-vertical-expected.checksum:
  • platform/mac-leopard/fast/table/038-vertical-expected.png:
  • platform/mac-leopard/fast/table/040-vertical-expected.checksum:
  • platform/mac-leopard/fast/table/040-vertical-expected.png:
  • platform/mac-leopard/fast/table/border-collapsing/002-vertical-expected.checksum:
  • platform/mac-leopard/fast/table/border-collapsing/002-vertical-expected.png:
  • platform/mac-leopard/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.checksum:
  • platform/mac-leopard/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.png:
  • platform/mac-leopard/fast/table/table-display-types-vertical-expected.checksum:
  • platform/mac-leopard/fast/table/table-display-types-vertical-expected.png:
  • platform/mac-leopard/fast/text/backslash-to-yen-sign-euc-expected.checksum:
  • platform/mac-leopard/fast/text/backslash-to-yen-sign-euc-expected.png:
  • platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.checksum:
  • platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.png:
  • platform/mac-leopard/svg/custom/junk-data-expected.checksum:
  • platform/mac-leopard/svg/custom/junk-data-expected.png:
  • platform/mac-leopard/svg/custom/missing-xlink-expected.checksum:
  • platform/mac-leopard/svg/custom/missing-xlink-expected.png:
  • platform/mac-leopard/tables/mozilla/other/wa_table_thtd_rowspan-expected.checksum:
  • platform/mac-leopard/tables/mozilla/other/wa_table_thtd_rowspan-expected.png:
6:59 PM Changeset in webkit [75308] by justin.garcia@apple.com
  • 3 edits
    2 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=51851
Implement RenderSVGInlineText::localCaretRect()

Reviewed by Dan Bernstein.

WebCore:

  • rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::localCaretRect): Implemented.

LayoutTests:

  • svg/text/caret-in-svg-text-expected.txt: Added.
  • svg/text/caret-in-svg-text.xhtml: Added.
6:42 PM Changeset in webkit [75307] by rniwa@webkit.org
  • 2 edits in trunk/WebCore

2011-01-07 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed; Added the missing null pointer check for r75293.

  • dom/Document.cpp: (WebCore::Document::adoptNode):
6:24 PM Changeset in webkit [75306] by Stephanie Lewis
  • 14 edits
    3 adds in trunk

WebCore: <rdar://problem/8649617> Migrate memory tracking from Safari to WebKit
​https://bugs.webkit.org/show_bug.cgi?id=50799 Add Memory Sampler to WebKit

Reviewed by Geoff Garen.

Add a sampler for printing off process memory statistics.
Export file mode.

  • WebCore.exp.in:

WebKit2: <rdar://problem/8649617> Migrate memory tracking from Safari to WebKit
​https://bugs.webkit.org/show_bug.cgi?id=50799 Add Memory Sampler to WebKit

Reviewed by Geoff Garen.

Add a sampler for printing off process memory statistics.
This tool can track:

WebCore

  • FastMalloc allocations bytes (in use or committed)

JavaScriptCore

  • Garbage collector heap bytes (in use or committed)
  • Stack bytes (committed only!)
  • JIT Code bytes (committed only!)

Malloc zones

  • In use bytes for the following zones:
    • Default zone (in use or committed)
    • DispCon zone (in use or committed)
    • Purgable zone (in use or committed)

Task Info

  • Resident size memory (RSIZE)


Data collected is dumped to a temporary file.


Create a sandbox for a temporary file.

  • Shared/SandboxExtension.h:

(WebKit::SandboxExtension::createHandleForTemporaryFile):

  • Shared/mac/SandboxExtensionMac.mm:

(WebKit::SandboxExtension::createHandleForTemporaryFile):

Memory Sampler files

  • Shared/WebMemorySampler.cpp: Added.

(WebKit::WebMemorySampler::shared):
(WebKit::WebMemorySampler::WebMemorySampler):
(WebKit::WebMemorySampler::start):
(WebKit::WebMemorySampler::initializeTimers):
(WebKit::WebMemorySampler::stop):
(WebKit::WebMemorySampler::isRunning):
(WebKit::WebMemorySampler::initializeTempLogFile):
(WebKit::WebMemorySampler::initializeSandboxedLogFile):
(WebKit::WebMemorySampler::writeHeaders):
(WebKit::WebMemorySampler::sampleTimerFired):
(WebKit::WebMemorySampler::stopTimerFired):
(WebKit::WebMemorySampler::appendCurrentMemoryUsageToFile):

  • Shared/WebMemorySampler.h: Added.
  • Shared/mac/WebMemorySampler.mac.mm: Added.

(WebKit::WebMemorySampler::sampleSystemMalloc):
(WebKit::WebMemorySampler::sampleProcessCommittedBytes):
(WebKit::WebMemorySampler::processName):
(WebKit::WebMemorySampler::sampleWebKit):

API to start and stop UIProcess and WebProcess sampling.

  • UIProcess/API/C/WKContext.cpp:

(WKContextStartMemorySampler):
(WKContextStopMemorySampler):

  • UIProcess/API/C/WKContext.h:


Send messages to WebProcess to start and stop memory sampling.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::processDidFinishLaunching):
(WebKit::WebContext::startMemorySampler):
(WebKit::WebContext::stopMemorySampler):

  • UIProcess/WebContext.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::startMemorySampler):
(WebKit::WebProcess::stopMemorySampler):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:
6:15 PM Changeset in webkit [75305] by rniwa@webkit.org
  • 7 edits
    22 adds in trunk

2011-01-06 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Adam Barth.

onbeforeunload is broken for framesets
​https://bugs.webkit.org/show_bug.cgi?id=19418

Added beforeunload event support for sub frames. WebKit's implementation tries to match
that of Internet Explorer as much as possible. beforeunload event is fired for each and
every descendent of a frame that is about to navigate.

When a value other than null is returned by a beforeunload handler, a confirmation dialog
is shown for each handler (calls chrome's runBeforeUnloadConfirmPanel) just like it is done
for main frames.

In addition, navigation is forbidden while beforeunload handlers are being called.
Setting values to location.href, location.reload, and other means of navigations are thus
ignored while beforeunload event handler is being ran, matching Internet Explorer's behavior.

Because navigation needs to prevented globally, NavigationDisablerForBeforeUnload is added to
NavigationScheduler.h, which is instantiated as a RAII object in FrameLoader::shouldClose.

Tests: fast/events/before-unload-adopt-subframe-to-outside.html

fast/events/before-unload-adopt-within-subframes.html
fast/events/before-unload-forbidden-navigation.html
fast/events/before-unload-in-multiple-subframes.html
fast/events/before-unload-in-subframe.html
fast/events/before-unload-javascript-navigation.html
fast/events/before-unload-remove-and-add-subframe.html
fact/events/before-unload-remove-itself.html
fast/events/before-unload-with-subframes.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::shouldClose): Calls fireBeforeUnloadEvent on m_frame and m_frame's descendents. Returns true only if every call to fireBeforeUnloadEvent returned true. (WebCore::FrameLoader::fireBeforeUnloadEvent): Fires a beforeunload event and calls chrome's runBeforeUnloadConfirmPanel as needed. (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Calls shouldClose for all frames.
  • loader/FrameLoader.h:
  • loader/NavigationScheduler.cpp: (WebCore::NavigationScheduler::shouldScheduleNavigation): Checks the nullity of Page and calls NavigationDisablerForBeforeUnload::isNavigationAllowed when url is not javascript scheme. (WebCore::NavigationScheduler::scheduleRedirect): Calls shouldScheduleNavigation. (WebCore::NavigationScheduler::scheduleLocationChange): Ditto. (WebCore::NavigationScheduler::scheduleRefresh): Ditto. (WebCore::NavigationScheduler::scheduleHistoryNavigation): Ditto.
  • loader/NavigationScheduler.h: (WebCore::NavigationDisablerForBeforeUnload::NavigationDisablerForBeforeUnload): Disables navigation. (WebCore::NavigationDisablerForBeforeUnload::~NavigationDisablerForBeforeUnload): Enables navigation when called on the last instance of NavigationDisablerForBeforeUnload. (WebCore::NavigationDisablerForBeforeUnload::isNavigationAllowed): Returns true if there are no instance of NavigationDisablerForBeforeUnload left on the stack.

2011-01-06 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Adam Barth.

onbeforeunload is broken for framesets
​https://bugs.webkit.org/show_bug.cgi?id=19418

Added tests to ensure WebKit fires beforeunload events for subframes,
and disallows navigation except that of javascript scheme while beforeunload event
handlers are being called.

Also added a test to ensure WebKit fires beforeunload event for subframes exactly
once even if a subframe was moved around within a beforeunload event handler.

A test that ensures beforeunload event is not fired for an iframe if the iframe
was added or removed within a beforeunload event handler is also added.

Furthermore, a test to ensure WebKit does not fire a beforeunload event to an iframe
that has been adopted by a document outside of the unloading document is added.

  • fast/events/before-unload-adopt-subframe-to-outside-expected.txt: Added.
  • fast/events/before-unload-adopt-subframe-to-outside.html: Added.
  • fast/events/before-unload-adopt-within-subframes-expected.txt: Added.
  • fast/events/before-unload-adopt-within-subframes.html: Added.
  • fast/events/before-unload-forbidden-navigation-expected.txt: Added.
  • fast/events/before-unload-forbidden-navigation.html: Added.
  • fast/events/before-unload-in-multiple-subframes-expected.txt: Added.
  • fast/events/before-unload-in-multiple-subframes.html: Added.
  • fast/events/before-unload-in-subframe-expected.txt: Added.
  • fast/events/before-unload-in-subframe.html: Added.
  • fast/events/before-unload-javascript-navigation-expected.txt: Added.
  • fast/events/before-unload-javascript-navigation.html: Added.
  • fast/events/before-unload-remove-and-add-subframe-expected.txt: Added.
  • fast/events/before-unload-remove-and-add-subframe.html: Added.
  • fact/events/before-unload-remove-itself-expected.txt: Added.
  • fact/events/before-unload-remove-itself.html: Added.
  • fast/events/before-unload-with-subframes-expected.txt: Added.
  • fast/events/before-unload-with-subframes.html: Added.
  • fast/events/resources/before-unload-in-subframe-child.html: Added.
  • fast/events/resources/before-unload-in-subframe-destination.html: Added.
  • fast/events/resources/before-unload-in-subframe-fail.html: Added.
  • fast/events/resources/before-unload-with-subframes-parent.html: Added.
5:58 PM Changeset in webkit [75304] by mrowe@apple.com
  • 3 edits
    3 adds in tags/Safari-534.15.3

Merge r74427.

5:58 PM Changeset in webkit [75303] by mrowe@apple.com
  • 7 edits in tags/Safari-534.15.3

Merge r74453.

5:58 PM Changeset in webkit [75302] by mrowe@apple.com
  • 4 edits in tags/Safari-534.15.3

Merge r74375.

5:51 PM Changeset in webkit [75301] by mrowe@apple.com
  • 5 edits in tags/Safari-534.15.3

Versioning.

5:45 PM Changeset in webkit [75300] by mrowe@apple.com
  • 1 copy in tags/Safari-534.15.3

New tag.

5:45 PM Changeset in webkit [75299] by mrowe@apple.com
  • 1 delete in tags/Safari-534.15.1

Remove bogus tag.

5:38 PM Changeset in webkit [75298] by Martin Robinson
  • 3 edits in trunk/LayoutTests

2011-01-07 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Mihai Parparita.

fast/dom/Window/window-postmessage-clone-frames.html has some timing issues
​https://bugs.webkit.org/show_bug.cgi?id=52032

Fix the timing issue in fast/dom/Window/window-postmessage-clone-frames.html
and move the output console div beyond the file input control, so that output
text does not push it outside the viewport.

  • fast/dom/Window/window-postmessage-clone-frames-expected.txt: Updated results to reflect div movement.
  • fast/dom/Window/window-postmessage-clone-frames.html: Fix the timing and layout issues with this test.
5:34 PM Changeset in webkit [75297] by mrowe@apple.com
  • 1 copy in tags/Safari-534.15.1

New tag.

5:20 PM Changeset in webkit [75296] by Martin Robinson
  • 3 edits in trunk/WebCore

2011-01-07 Martin Robinson <​mrobinson@igalia.com>

Build fix for GTK+.

  • GNUmakefile.am: Add RenderFullScreen.cpp to the sources list.
  • rendering/RenderFullScreen.cpp: (RenderFullScreen::setAnimating): Guard the call to contentChanged with ENABLED(ACCELERATED_COMPOSITING).
5:15 PM Changeset in webkit [75295] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

2011-01-06 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

side-by-side diffs in the code review tool
​https://bugs.webkit.org/show_bug.cgi?id=52019

Support for conversion from the formatted diff to a side-by-side diff.
Maintains comments and new comments can be added.

The main architectural change is that Line elements are no longer necessarily
siblings. Each physical line is now in a LineContainer and LineContainers are
siblings. Each Line corresponds to a Line in the unified diff and has an id (e.g. line12).
A Line can be a LineContainer or a child of a LineContainer.

In this way, converting to side-by-side and, in the future, back to unified is non-lossy.

  • PrettyPatch/PrettyPatch.rb:
  • code-review.js:
4:53 PM Changeset in webkit [75294] by rniwa@webkit.org
  • 2 edits in trunk/WebCore

2011-01-07 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed; speculative fix for Windows debug build.

  • bindings/js/JSBindingsAllInOne.cpp:
4:49 PM Changeset in webkit [75293] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

2011-01-07 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Ojan Vafai.

Adopting an iframe to a child frame results in stack overflow
​https://bugs.webkit.org/show_bug.cgi?id=52018

Throws an exception when a document adopts an iframe that is an ancestor
of the document in the frame hierarchy. New behavior matches that of Firefox.

Test: fast/html/adopt-parent-frame.html

  • dom/Document.cpp: (WebCore::Document::adoptNode):

2011-01-07 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Ojan Vafai.

Adopting an iframe to a child frame results in stack overflow
​https://bugs.webkit.org/show_bug.cgi?id=52018

Added a test to ensure calling adoptNode with an iframe throws an exception
if the adoptee is an ancestor of the document adopting the node in the frame hierarchy.

  • fast/html/adopt-parent-frame-expected.txt: Added.
  • fast/html/adopt-parent-frame.html: Added.
4:38 PM Changeset in webkit [75292] by mihaip@chromium.org
  • 8 edits in trunk

2011-01-07 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Scrollbar code cleanup
​https://bugs.webkit.org/show_bug.cgi?id=52073

Scrollbar code cleanup:

  • Remove ScrollbarThemeMac.{mm|h} from the mac sources list, we use ScrollbarThemeChromiumMac.{mm|h}
  • Remove USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define now that switch to WebThemeEngine is permanent
  • Fix typo in Linux scrollbar enum name

No new tests (compiles).

  • WebCore.gypi:
  • platform/chromium/ChromiumBridge.h:
  • platform/chromium/ScrollbarThemeChromiumLinux.cpp: (WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece):
  • platform/chromium/ScrollbarThemeChromiumMac.mm: (WebCore::scrollbarStateToThemeState): (WebCore::ScrollbarThemeChromiumMac::paint):

2011-01-07 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Scrollbar code cleanup
​https://bugs.webkit.org/show_bug.cgi?id=52073

Scrollbar code cleanup:

  • Fix typo in Linux scrollbar enum name
  • public/linux/WebThemeEngine.h:
  • src/ChromiumBridge.cpp: (WebCore::WebThemePart): (WebCore::GetWebThemeExtraParams):
4:21 PM Changeset in webkit [75291] by mjs@apple.com
  • 4 edits in trunk/Tools

2011-01-07 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Sam Weinig.

Make WebKitTestRunner rest between loads more robust to avoid test crashes
​https://bugs.webkit.org/show_bug.cgi?id=52086

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::didReceiveMessage):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::notifyDone):
  • WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues): (WTR::TestController::run):
4:21 PM Changeset in webkit [75290] by jer.noble@apple.com
  • 2 edits in trunk/WebCore

GTK Linux build fix: isDocumentRunningFullScreenAnimation should
be protected both by ENABLE(FULLSCREEN_API) && USE(ACCELERATED_COMPOSITING)

  • page/FrameView.cpp:
3:59 PM Changeset in webkit [75289] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Bug 26276 - Need a mechanism to determine stack extent on WINDOWS, SOLARIS, OPENBSD, SYMBIAN, HAIKU, WINCE platforms

Reviewed by Geoff Garen.

Fix for win32. The base of the stack is stored in the "deallocation stack" field of the
Thread Information Block - see: ​http://en.wikipedia.org/wiki/Win32_Thread_Information_Block
for more information!

  • wtf/StackBounds.cpp:

(WTF::StackBounds::initialize):

3:57 PM Changeset in webkit [75288] by jer.noble@apple.com
  • 2 edits in trunk/WebKit/mac

Yet another Leopard build fix: NSRect and CGRect are not inter-
changable in 32-bit.

  • WebView/WebFullScreenController.mm:

(-[WebFullScreenController exitFullscreen]):

3:48 PM Changeset in webkit [75287] by commit-queue@webkit.org
  • 10 edits in trunk/WebCore

2011-01-07 Rafael Weinstein <​rafaelw@chromium.org>

Reviewed by Eric Seidel.

Cleanup: Fold shadowParentNode into shadowHost
​https://bugs.webkit.org/show_bug.cgi?id=51059

Replaces all uses of shadowParentNode.

No new tests because no behavior has changed.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::initForStyleResolve):
  • dom/Node.cpp: (WebCore::Node::shadowHost): (WebCore::Node::shadowAncestorNode): (WebCore::eventTargetRespectingSVGTargetRules): (WebCore::Node::getEventAncestors):
  • dom/Node.h:
  • editing/Editor.cpp: (WebCore::Editor::findString):
  • page/DragController.cpp: (WebCore::asFileInput):
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): (WebCore::instanceAssociatedWithShadowTreeElement): (WebCore::EventHandler::dispatchMouseEvent):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::hasLineIfEmpty):
  • rendering/RenderSVGShadowTreeRootContainer.cpp: (WebCore::RenderSVGShadowTreeRootContainer::updateFromElement):
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::title):
3:39 PM Changeset in webkit [75286] by Martin Robinson
  • 1 edit
    3 adds in trunk/LayoutTests

2011-01-07 Martin Robinson <​mrobinson@igalia.com>

Add a platform-specific baseline for GTK+ after r75257.

  • platform/gtk/fast/text/emphasis-avoid-ruby-expected.checksum: Added.
  • platform/gtk/fast/text/emphasis-avoid-ruby-expected.png: Added.
  • platform/gtk/fast/text/emphasis-avoid-ruby-expected.txt: Added.
3:39 PM Changeset in webkit [75285] by jer.noble@apple.com
  • 2 edits in trunk/WebKit/mac

Fix the Leopard build: Replace CoreAnimation SL-only functions
with Leopard equivalents.

  • WebView/WebFullScreenController.mm:

(+[CATransaction setDisableActions:]):
(+[CATransaction setAnimationDuration:]):
(-[WebFullScreenController _animationDuration]):
(-[WebFullscreenWindow initWithContentRect:styleMask:backing:defer:]):

3:35 PM Changeset in webkit [75284] by cmarrin@apple.com
  • 2 edits in trunk/WebCore

2011-01-07 Chris Marrin <​cmarrin@apple.com>

Unreviewed.

I mistakenly included a Windows only file in a
cross platform file.

  • platform/graphics/ca/GraphicsLayerCA.cpp:
3:27 PM Changeset in webkit [75283] by cmarrin@apple.com
  • 2 edits in trunk/WebCore

2011-01-07 Chris Marrin <​cmarrin@apple.com>

Unreviewed.

Get rid of include of <QuartzCore/QuartzCore.h>

  • platform/graphics/ca/GraphicsLayerCA.cpp:
3:18 PM Changeset in webkit [75282] by jer.noble@apple.com
  • 2 edits in trunk/WebCore

Further build fixes. Add a ENABLE(FULLSCREEN_API) guard around
the implementation of requiresCompositingfForFullScreen.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForFullScreen):

3:09 PM Changeset in webkit [75281] by jer.noble@apple.com
  • 2 edits in trunk/WebCore

No review, build fix only. Removed parameter who was causing
a warning in Release builds.

  • dom/Document.cpp:

(WebCore::Document::webkitDidExitFullScreenForElement):

3:07 PM Changeset in webkit [75280] by cmarrin@apple.com
  • 5 edits in trunk

2011-01-07 Chris Marrin <​cmarrin@apple.com>

Unreviewed.

Use new wkCACFLayerGetContextUserData function

  • platform/graphics/ca/win/PlatformCALayerWin.cpp:

2011-01-07 Chris Marrin <​cmarrin@apple.com>

Unreviewed.

Minor change to check for null context

  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:
2:58 PM Changeset in webkit [75279] by jberlin@webkit.org
  • 5 edits in trunk/WebKit2

WebKit2: Need WKBundleFrameCopyProvisionalURL
​https://bugs.webkit.org/show_bug.cgi?id=52083

Reviewed by Dan Bernstein.

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFrameCopyProvisionalURL):

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::provisionalURL):
Grab the URL from the provisional document loader.

  • WebProcess/WebPage/WebFrame.h:
2:51 PM Changeset in webkit [75278] by jamesr@google.com
  • 2 edits in trunk/WebCore

2011-01-07 James Robinson <​jamesr@chromium.org>

Fix compile bustage due to bad merge in 75276.

  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::beginAnimationUpdateTime):
2:45 PM Changeset in webkit [75277] by jer.noble@apple.com
  • 36 edits
    4 adds in trunk

WebCore: Implement WebKit Full Screen support.
​https://bugs.webkit.org/show_bug.cgi?id=49481
rdar://problem/8247444

Patch by Jer Noble <​jer@kokode.apple.com> on 2010-12-17
Reviewed by Simon Fraser.

Mark for export all those WebCore functions needed by WebFullscreenController.

  • WebCore.exp.in:

WebCore: Implement WebKit Full Screen support.
​https://bugs.webkit.org/show_bug.cgi?id=49481
rdar://problem/8247444

Patch by Jer Noble <​jer@kokode.apple.com> on 2010-12-17
Reviewed by Simon Fraser.

screenRect is useful for more than just HTMLMediaElements. Promote it into
Element.

  • dom/Element.cpp: Moved into Element from HTMLMediaElement.
  • dom/Element.h: Ditto.
  • dom/Node.cpp:
  • html/HTMLMediaElement.cpp: Moved screenRect into Element.
  • html/HTMLMediaElement.h: Ditto.
  • WebCore.exp.in: Modify the exports list to reflect the new symbol name.

WebCore: Implement WebKit Full Screen support.
​https://bugs.webkit.org/show_bug.cgi?id=49481
rdar://problem/8247444

Patch by Jer Noble <​jer@kokode.apple.com> on 2010-12-17
Reviewed by Simon Fraser.

The RenderFullScreen is intended to be used by clients of that API to allow a DOM subtree to
be rendered outside its original Frame. Because of this, there are a few areas of the
rendering code which need to be special cased: RenderFullScreen layers should not be clipped
to the viewport, as they will almost always be rendering outside the viewport area;
RenderFullScreen graphics layers should not be reparented by the RenderLayerCompositor, as
the client will likely want to reparent the platformLayer into their own fullscreen platform
window; the FrameView must update the RenderFullScreen graphics layer tree separately from
the root layer, as the two trees are disconnected.

  • page/FrameView.cpp:

(WebCore::FrameView::updateCompositingLayers): Special treatment for fullscreen renderer.
(WebCore::FrameView::syncCompositingStateRecursive): Ditto.
(WebCore::FrameView::paintContents): Ditto.

  • rendering/RenderLayer.h: Add a new ContentChangeType enum entry for FullScreen.
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::contentChanged): Add support for above.

  • rendering/RenderLayerBacking.cpp:

(WebCore::layerOrAncestorIsFullScreen): New function.
(WebCore::RenderLayerBacking::updateCompositedBounds): Do not clip if the layerOrAncestorIsFullScreen.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): Special treatment for fullscreen renderer.
(WebCore::RenderLayerCompositor::requiresCompositingLayer): Ditto.
(WebCore::RenderLayerCompositor::requiresCompositingForFullScreen): Ditto.

  • rendering/RenderLayerCompositor.h:

WebCore: Implement WebKit Full Screen support.
​https://bugs.webkit.org/show_bug.cgi?id=49481
rdar://problem/8247444

Patch by Jer Noble <​jer@kokode.apple.com> on 2010-12-17
Reviewed by Simon Fraser.

Implemented non-accelerated fullscreen support. The Document will now vend a RenderFullScreen object for clients to
use to relocate the fullscreen element subtree.

  • css/CSSStyleSelector.cpp:

(WebCore::loadFullScreenRulesIfNeeded): Change webkitFullScreen -> webkitIsFullScreen.
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Ditto.

  • dom/Document.cpp:

(WebCore::Document::Document): Initialize m_fullScreenRenderer.
(WebCore::Document::detach): Call setFullScreenRenderer(0).
(WebCore::Document::nodeWillBeRemoved): Replicate the logic in webkitWillEnterFullScreenForElement.
(WebCore::Document::webkitWillEnterFullScreenForElement): Detach the fullscreen element to cause

a new RenderFullScreen renderer to be created with the new fullscreen element.

(WebCore::Document::webkitDidEnterFullScreenForElement): Notify clients of a fullscreen change

here, rather in "willEnter", to avoid reentrancy problems when clients remove nodes in response
to webkitfullscreenchange events.

(WebCore::Document::webkitWillExitFullScreenForElement): Recalculate the fullscreen element's style.
(WebCore::Document::webkitDidExitFullScreenForElement): Ditto.
(WebCore::Document::setFullScreenRenderer): Accessor for m_fullScreenRenderer.
(WebCore::Document::setFullScreenRendererSize): Set the style on the m_fullScreenRenderer with a new

size; this keeps clients from having to access the renderer's style directly.

(WebCore::Document::setFullScreenRendererBackgroundColor): Ditto.

  • dom/Document.h:

(WebCore::Document::webkitIsFullScreen): Change webkitFullScreen -> webkitIsFullScreen.
(WebCore::Document::fullScreenRenderer): Accessor.

  • dom/Document.idl:
  • dom/Node.cpp:

(WebCore::Node::createRendererIfNeeded): If the document is in fullscreen mode, create a RenderFullScreen

object to insert between the fullscreen element and its parent.

  • page/ChromeClient.h:

(WebCore::ChromeClient::fullScreenRendererChanged): Added.

  • rendering/MediaControlElements.cpp:

(WebCore::MediaControlFullscreenButtonElement::defaultEventHandler): Change webkitFullScreen -> webkitIsFullScreen.

WebCore: Implement WebKit Full Screen support.
​https://bugs.webkit.org/show_bug.cgi?id=49481
rdar://problem/8247444

Patch by Jer Noble <​jer@kokode.apple.com> on 2010-12-17
Reviewed by Simon Fraser.

This patch introduces a new RenderObject type: RenderFullScreen. The RenderFullScreen renderer
will be used to implement new FullScreen APIs. Because the RenderFullScreen object will be the
parent of the current fullscreen element, the style rules for fullscreen objects must change to
match.

  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderFullScreen.cpp: Added.

(RenderFullScreen::setAnimating): Sets the m_isAnimating flag.
(RenderFullScreen::createFullScreenStyle): Returns a new RenderStyle containing the default stye

for RenderFullScreen objects.

  • rendering/RenderFullScreen.h: Added.

(WebCore::RenderFullScreen::isRenderFullScreen): Added. Overrides the RenderObject version.

  • rendering/RenderObject.h:

(WebCore::RenderObject::isRenderFullScreen): Added. Used for type-checking RenderFullScreen objects.

  • css/fullscreen.css: Modified the contained fullscreen styles.

WebKit/mac: Implement WebKit Full Screen support.
​https://bugs.webkit.org/show_bug.cgi?id=49481
rdar://problem/8247444

Patch by Jer Noble <​jer@kokode.apple.com> on 2011-01-05
Reviewed by Simon Fraser.

Support the new fullscreen Chrome client requests. WebView will pass
through these requests to a WebFullscreenController.

  • WebCoreSupport/WebChromeClient.h: Add fullScreenRendererChanged().
  • WebView/WebView.mm:

(-[WebView _supportsFullScreenForElement:WebCore::]): Check to see if the fullscreen pref has been enabled.
(-[WebView _enterFullScreenForElement:WebCore::]): Create a WebFullScreenController.
(-[WebView _exitFullScreenForElement:WebCore::]): Request that the WebFullScreenController exit fullscreen.
(-[WebView _fullScreenRendererChanged:WebCore::]): Notify the WebFullScreenController that its renderer has changed.

  • WebView/WebViewData.h: Add ivar newFullscreenController.

Patch by Jer Noble <​jer@kokode.apple.com> on 2011-01-05
Reviewed by Simon Fraser.

This patch implements the FullScreen APIs using the new RenderFullScreen renderer and the new
Document client APIs. The RenderFullScreen renderer's CALayer is hosted in a new, fullscreen
window, and a custom CAAnimation animates that layer between the initial screen rect of the
full screen element, to its final value. WebFullscreenController will swap the WebView out of
its original window, and into the fullscreen window. The controller will replace the WebView
with a placeholder view, so that if the placeholder moves or resized while the WebView is
absent, the WebView will move back to the correct location when exiting fullscreen.

  • WebView/WebFullscreenController.h: Added.
  • WebView/WebFullscreenController.mm: Added.

(-[WebFullscreenController windowDidExitFullscreen:]): Close the fullscreen window.
(-[WebFullscreenController windowDidEnterFullscreen:]): Swap the webView back into the fullscreen window.
(-[WebFullscreenController animationDidStop:finished:]): Call windowDid{Exit|Enter}FullScreen as appropriate.
(-[WebFullscreenController applicationDidResignActive:]):
(-[WebFullscreenController applicationDidChangeScreenParameters:]): Resize the fullscreen window to match

the new screen parameters.

(-[WebFullscreenController enterFullscreen:]): Set up the animation that will take the fullscreen element

from its original screen rect into fullscreen.

(-[WebFullscreenController exitFullscreen]): Swap the webView back into its original window.

Set up the animation that will take the fullscreen element back into its original screen
rect.

(-[WebFullscreenController _updatePowerAssertions]): Now checks _isAnyMoviePlaying to determine

whether to disable screensaver and sleep.

(-[WebFullscreenController _isAnyMoviePlaying]): Walks through the sub-tree starting at the fullscreen element

looking for HTMLVideoElements; returns whether any are found to be playing.

(-[WebFullscreenController _animationDuration]): Returns the current animation duration, affected by control

and shift keys.

(-[WebFullscreenWindow canBecomeKeyWindow]): Allow the window to become key.
(-[WebFullscreenWindow keyDown:]): Handle the 'Esc' key.
(-[WebFullscreenWindow cancelOperation:]): Request to exit fullscreen.
(-[WebFullscreenWindow rendererLayer]): Convenience accessor.
(-[WebFullscreenWindow setRendererLayer:]): Ditto.
(-[WebFullscreenWindow backgroundLayer]): Ditto.
(-[WebFullscreenWindow animationView]): Ditto.
(MediaEventListener::MediaEventListener): Implements the EventListener protocol.
(MediaEventListener::handleEvent): Tells its delegate to _updatePowerAssertions.

LayoutTests: Implement WebKit Full Screen support.
​https://bugs.webkit.org/show_bug.cgi?id=49481
rdar://problem/8247444

Patch by Jer Noble <​jer@kokode.apple.com> on 2011-01-05
Reviewed by Simon Fraser.

Update the tests with new API names and spec values.

  • fullscreen/full-screen-api-expected.txt:
  • fullscreen/full-screen-api.html:
  • fullscreen/full-screen-css.html:
  • fullscreen/full-screen-request-expected.txt:
  • fullscreen/full-screen-request.html:
2:32 PM Changeset in webkit [75276] by jamesr@google.com
  • 40 edits
    5 deletes in trunk

2011-01-07 James Robinson <​jamesr@chromium.org>

Revert "Implement mozilla's animationTime property"
​https://bugs.webkit.org/show_bug.cgi?id=51952

This approach isn't quite right.

  • animations/animation-time-expected.txt: Removed.
  • animations/animation-time.html: Removed.
  • animations/script-tests/animation-time.js: Removed.
  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:

2011-01-07 James Robinson <​jamesr@chromium.org>

Revert "Implement mozilla's animationTime property"
​https://bugs.webkit.org/show_bug.cgi?id=51952

This approach isn't quite right.

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::paintInvalidatedRegion):

2011-01-07 James Robinson <​jamesr@chromium.org>

Revert "Implement mozilla's animationTime property"
​https://bugs.webkit.org/show_bug.cgi?id=51952

This approach isn't quite right.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/DOMWindow.cpp:
  • page/DOMWindow.h:
  • page/DOMWindow.idl:
  • page/Frame.cpp:
  • page/Frame.h:
  • page/Page.cpp: (WebCore::Page::Page):
  • page/Page.h:
  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::beginAnimationUpdateTime):
  • page/animation/AnimationTimeController.cpp: Removed.
  • page/animation/AnimationTimeController.h: Removed.

2011-01-07 James Robinson <​jamesr@chromium.org>

Revert "Implement mozilla's animationTime property"
​https://bugs.webkit.org/show_bug.cgi?id=51952

This approach isn't quite right.

  • public/WebWidget.h:
  • src/WebPopupMenuImpl.cpp:
  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp:
  • src/WebViewImpl.h:

2011-01-07 James Robinson <​jamesr@chromium.org>

Revert "Implement mozilla's animationTime property"
​https://bugs.webkit.org/show_bug.cgi?id=51952

This approach isn't quite right.

  • WebView/WebHTMLView.mm: (-[WebHTMLView drawRect:]):
  • WebView/WebView.mm: (layerSyncRunLoopObserverCallBack):

2011-01-07 James Robinson <​jamesr@chromium.org>

Revert "Implement mozilla's animationTime property"
​https://bugs.webkit.org/show_bug.cgi?id=51952

This approach isn't quite right.

  • WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp: (WebKit::ChunkedUpdateDrawingArea::display): (WebKit::ChunkedUpdateDrawingArea::setSize):
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::drawRect):
  • WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm: (WebKit::LayerBackedDrawingArea::syncCompositingLayers):
2:19 PM Changeset in webkit [75275] by cmarrin@apple.com
  • 4 edits in trunk/WebKitLibraries

2011-01-07 Chris Marrin <​cmarrin@apple.com>

Unreviewed.

Added one more API to WKSI to get the user data
out of the CACFContext.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:
2:13 PM Changeset in webkit [75274] by senorblanco@chromium.org
  • 3 edits in trunk/LayoutTests

2011-01-07 Stephen White <​senorblanco@chromium.org>

Unreviewed; test expectations update.

  • platform/chromium-gpu/test_expectations.txt: Removed some no-longer-failing tests; moved some lines around to match the CPU results.
  • platform/chromium/test_expectations.txt: Bug assignment and cleanup.
2:06 PM Changeset in webkit [75273] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2011-01-07 Jan Erik Hanssen <​jhanssen@sencha.com>

Reviewed by Andreas Kling.

[Qt] Black text on black buttons using a dark theme
​https://bugs.webkit.org/show_bug.cgi?id=35024

Implement RenderThemeQt::systemColor to apply the correct colors from the current Qt style.

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::systemColor):
  • platform/qt/RenderThemeQt.h:
1:53 PM Changeset in webkit [75272] by commit-queue@webkit.org
  • 1 edit
    10 adds in trunk/WebKit2

2011-01-07 Amruth Raj <​amruthraj@motorola.com> and Ravi Phaneendra Kasibhatla <​ravi.kasibhatla@motorola.com>

Reviewed by Martin Robinson.

[GTK] WebKit2 GNUmakefile is out of date from trunk
Adding new stub files for compiling on latest revision
​https://bugs.webkit.org/show_bug.cgi?id=51883

  • UIProcess/gtk: Added.
  • UIProcess/gtk/TextCheckerGtk.cpp: Added. (WebKit::TextChecker::state): (WebKit::TextChecker::isContinuousSpellCheckingAllowed): (WebKit::TextChecker::setContinuousSpellCheckingEnabled): (WebKit::TextChecker::setGrammarCheckingEnabled): (WebKit::TextChecker::uniqueSpellDocumentTag): (WebKit::TextChecker::closeSpellDocumentWithTag): (WebKit::TextChecker::checkTextOfParagraph): (WebKit::TextChecker::updateSpellingUIWithMisspelledWord): (WebKit::TextChecker::getGuessesForWord): (WebKit::TextChecker::learnWord): (WebKit::TextChecker::ignoreWord):
  • UIProcess/gtk/WebInspectorGtk.cpp: Added. (WebKit::WebInspectorProxy::platformCreateInspectorPage): (WebKit::WebInspectorProxy::platformOpen): (WebKit::WebInspectorProxy::platformClose): (WebKit::WebInspectorProxy::inspectorPageURL):
  • UIProcess/gtk/WebPageProxyGtk.cpp: Added. (WebKit::WebPageProxy::standardUserAgent):
  • UIProcess/gtk/WebPreferencesGtk.cpp: Added. (WebKit::WebPreferences::platformInitializeStore): (WebKit::WebPreferences::platformUpdateStringValueForKey): (WebKit::WebPreferences::platformUpdateBoolValueForKey): (WebKit::WebPreferences::platformUpdateUInt32ValueForKey):
  • WebProcess/WebCoreSupport/gtk/WebContextMenuClientGtk.cpp: Added. (WebKit::WebContextMenuClient::lookUpInDictionary): (WebKit::WebContextMenuClient::isSpeaking): (WebKit::WebContextMenuClient::speak): (WebKit::WebContextMenuClient::stopSpeaking):
  • WebProcess/WebCoreSupport/gtk/WebDatabaseManagerGtk.cpp: Added. (WebKit::WebDatabaseManager::databaseDirectory):
  • WebProcess/WebCoreSupport/gtk/WebPopupMenuGtk.cpp: Added. (WebKit::WebPopupMenu::setUpPlatformData):
  • WebProcess/WebPage/gtk: Added.
  • WebProcess/WebPage/gtk/WebInspectorGtk.cpp: Added. (WebKit::WebInspector::localizedStringsURL):
1:41 PM Changeset in webkit [75271] by enne@google.com
  • 14 edits
    3 copies
    4 adds in trunk

2011-01-05 Adrienne Walker <​enne@google.com>

Reviewed by Kenneth Russell.

Add tests for WebGL's lost context events.
​https://bugs.webkit.org/show_bug.cgi?id=51492

  • fast/canvas/webgl/context-lost-expected.txt: Added.
  • fast/canvas/webgl/context-lost-restored-expected.txt: Added.
  • fast/canvas/webgl/context-lost-restored.html: Added.
  • fast/canvas/webgl/context-lost.html: Added.

2011-01-05 Adrienne Walker <​enne@google.com>

Reviewed by Kenneth Russell.

Add WEBKIT_lose_context WebGL extension.
​https://bugs.webkit.org/show_bug.cgi?id=51492

Tests: fast/canvas/webgl/context-lost-restored.html

fast/canvas/webgl/context-lost.html

  • CMakeLists.txt:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSWebGLRenderingContextCustom.cpp: (WebCore::toJS): (WebCore::JSWebGLRenderingContext::getSupportedExtensions):
  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::toV8Object): (WebCore::V8WebGLRenderingContext::getSupportedExtensionsCallback):
  • html/canvas/WebGLExtension.h:
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::WebGLRenderingContextRestoreTimer::fired): (WebCore::WebGLRenderingContext::getExtension): (WebCore::WebGLRenderingContext::getSupportedExtensions): (WebCore::WebGLRenderingContext::forceLostContext): (WebCore::WebGLRenderingContext::onLostContext): (WebCore::WebGLRenderingContext::getNumberOfExtensions): (WebCore::WebGLRenderingContext::getExtensionNumber):
  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebKitLoseContext.cpp: Copied from WebCore/html/canvas/WebGLExtension.h. (WebCore::WebKitLoseContext::WebKitLoseContext): (WebCore::WebKitLoseContext::~WebKitLoseContext): (WebCore::WebKitLoseContext::getName): (WebCore::WebKitLoseContext::create): (WebCore::WebKitLoseContext::loseContext):
  • html/canvas/WebKitLoseContext.h: Copied from WebCore/html/canvas/WebGLExtension.h.
  • html/canvas/WebKitLoseContext.idl: Copied from WebCore/html/canvas/WebGLExtension.h.
1:28 PM Changeset in webkit [75270] by cmarrin@apple.com
  • 2 edits in trunk/WebCore

2011-01-07 Chris Marrin <​cmarrin@apple.com>

Unreviewed.

Build fix for Chromium. Missing include.

  • page/animation/AnimationBase.cpp:
1:21 PM Changeset in webkit [75269] by Adam Roben
  • 2 edits in trunk/Source/JavaScriptCore

Update react-to-vsprops-changes.py after r74855

1:20 PM Changeset in webkit [75268] by Adam Roben
  • 2 edits in trunk/WebKit2

Don't ever call ::SetCursor(0)

Doing so makes the cursor disappear from the screen.

Fixes <​http://webkit.org/b/52024> Mouse cursor flashes when moving it
around a WKView before the web process has finished launching

Reviewed by Jon Honeycutt.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::onSetCursor): If we don't have a cursor to set, just
let Windows do its default thing (which is to set the cursor to the
window class's cursor, which in our case is the arrow cursor).
(WebKit::WebView::cursorToShow): Just return 0 when the page has
crashed so that we'll show the default cursor (which is the arrow
cursor). This change has no visible effect, but seems slightly better
conceptually.
(WebKit::WebView::updateNativeCursor): Don't do anything if we don't
have a cursor to set.

1:19 PM Changeset in webkit [75267] by Adam Roben
  • 13 edits in trunk/WebKit2

Fill the WKView with white when the web process hasn't drawn anything yet

Fixes <​http://webkit.org/b/52023> WKView accumulates pixel garbage
before web process has had a chance to draw anything (if Aero is
disabled)

Reviewed by Jon Honeycutt.

  • UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:

(WebKit::ChunkedUpdateDrawingAreaProxy::paint):

  • UIProcess/ChunkedUpdateDrawingAreaProxy.h:
  • UIProcess/DrawingAreaProxy.h:
  • UIProcess/LayerBackedDrawingAreaProxy.cpp:

(WebKit::LayerBackedDrawingAreaProxy::paint):

  • UIProcess/LayerBackedDrawingAreaProxy.h:
  • UIProcess/TiledDrawingAreaProxy.cpp:

(WebKit::TiledDrawingAreaProxy::paint):

  • UIProcess/TiledDrawingAreaProxy.h:
  • UIProcess/mac/ChunkedUpdateDrawingAreaProxyMac.mm:

(WebKit::ChunkedUpdateDrawingAreaProxy::platformPaint):

  • UIProcess/qt/ChunkedUpdateDrawingAreaProxyQt.cpp:

(WebKit::ChunkedUpdateDrawingAreaProxy::platformPaint):

  • UIProcess/win/ChunkedUpdateDrawingAreaProxyWin.cpp:

(WebKit::ChunkedUpdateDrawingAreaProxy::platformPaint):

  • UIProcess/win/LayerBackedDrawingAreaProxyWin.cpp:

(WebKit::LayerBackedDrawingAreaProxy::paint):
Changed these functions to return a boolean indicating whether we
actually painted anything.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::onPaintEvent): Fill with white (and don't call
didDraw) when the DrawingAreaProxy isn't able to paint.

1:08 PM Changeset in webkit [75266] by cmarrin@apple.com
  • 2 edits in trunk/WebCore

2011-01-07 Chris Marrin <​cmarrin@apple.com>

Unreviewed.

Build fix.

  • platform/graphics/ca/win/PlatformCALayerWin.cpp:
1:04 PM Changeset in webkit [75265] by barraclough@apple.com
  • 10 edits in trunk

Source/JavaScriptCore: [GTK] Port scrollbar painting to GtkStyleContext
​https://bugs.webkit.org/show_bug.cgi?id=52051

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2011-01-07
Reviewed by Martin Robinson.

  • wtf/gobject/GTypedefs.h: Add GtkStyleContext forward

declaration.

WebCore: Bug 52035 - Unregistering DOMWrapperWorlds is unsafe

Reviewed by Geoff Garen.

The method DOMWrapperWorld::unregisterWorld() effectively calls the DOMWrapperWorld's
destructor early, in order to release wrappers once we know we no longer intend to use them.
Whilst it is okay to have a method to throw away wrappers (assuming we know we're willing to
lose any state stored on them) it is not okay to deregister the world from the JSGlobalData.
A sequence of events that triggers the bug would look like this:

(1) Create a DOMWrapperWorld.
(2) Register a timer in the world.
(3) Call unregisterWorld() on the world.
(4) Timer goes off, code is executed in the world, creates a Node not attached to a Document.
(5) We attempt to lookup a wrapper map for the world on the JSGlobalData, but because we've

called forgetWorld() none exists.

(6) Attempt to add a wrapper to a NULL map.

Fix the problem by not removing the JSGlobalData's wrapper map until the world really goes away.

  • WebCore.exp.in:
  • bindings/js/DOMWrapperWorld.cpp:

(WebCore::DOMWrapperWorld::DOMWrapperWorld):
(WebCore::DOMWrapperWorld::~DOMWrapperWorld):
(WebCore::DOMWrapperWorld::clearWrappers):

  • bindings/js/DOMWrapperWorld.h:

WebKit/mac: Bug 52035 - Unregistering DOMWrapperWorlds is unsafe

Reviewed by Geoff Garen.

The method DOMWrapperWorld::unregisterWorld() effectively calls the DOMWrapperWorld's
destructor early, in order to release wrappers once we know we no longer intend to use them.
Whilst it is okay to have a method to throw away wrappers (assuming we know we're willing to
lose any state stored on them) it is not okay to deregister the world from the JSGlobalData.
A sequence of events that triggers the bug would look like this:

(1) Create a DOMWrapperWorld.
(2) Register a timer in the world.
(3) Call unregisterWorld() on the world.
(4) Timer goes off, code is executed in the world, creates a Node not attached to a Document.
(5) We attempt to lookup a wrapper map for the world on the JSGlobalData, but because we've

called forgetWorld() none exists.

(6) Attempt to add a wrapper to a NULL map.

Fix the problem by not removing the JSGlobalData's wrapper map until the world really goes away.

  • WebView/WebScriptWorld.mm:

(-[WebScriptWorld unregisterWorld]):

WebKit/win: Bug 52035 - Unregistering DOMWrapperWorlds is unsafe

Reviewed by Geoff Garen.

The method DOMWrapperWorld::unregisterWorld() effectively calls the DOMWrapperWorld's
destructor early, in order to release wrappers once we know we no longer intend to use them.
Whilst it is okay to have a method to throw away wrappers (assuming we know we're willing to
lose any state stored on them) it is not okay to deregister the world from the JSGlobalData.
A sequence of events that triggers the bug would look like this:

(1) Create a DOMWrapperWorld.
(2) Register a timer in the world.
(3) Call unregisterWorld() on the world.
(4) Timer goes off, code is executed in the world, creates a Node not attached to a Document.
(5) We attempt to lookup a wrapper map for the world on the JSGlobalData, but because we've

called forgetWorld() none exists.

(6) Attempt to add a wrapper to a NULL map.

Fix the problem by not removing the JSGlobalData's wrapper map until the world really goes away.

  • WebScriptWorld.cpp:

(WebScriptWorld::unregisterWorld):

12:44 PM Changeset in webkit [75264] by cmarrin@apple.com
  • 4 edits in trunk/WebKitLibraries

2011-01-07 Chris Marrin <​cmarrin@apple.com>

Unreviewed.

Adding updated WKSI files missed in ​http://trac.webkit.org/changeset/75262

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:
12:43 PM Changeset in webkit [75263] by senorblanco@chromium.org
  • 3 edits
    2 adds in trunk/LayoutTests

2011-01-07 Stephen White <​senorblanco@chromium.org>

Unreviewed; new test baselines and updated chromium expectations.

  • platform/chromium-gpu/test_expectations.txt:
  • platform/chromium-linux/fast/gradients/css3-repeating-linear-gradients-expected.checksum: Added.
  • platform/chromium-linux/fast/gradients/css3-repeating-linear-gradients-expected.png: Added.
  • platform/chromium/test_expectations.txt:
12:00 PM Changeset in webkit [75262] by cmarrin@apple.com
  • 39 edits
    1 copy
    5 adds in trunk

2011-01-07 Chris Marrin <​cmarrin@apple.com>

Rubber-stamped by Simon Fraser.

Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
​https://bugs.webkit.org/show_bug.cgi?id=49388

Final step in unifying GraphicsLayer logic across Win and Mac. This
implements the Windows side classes for PlatformCALayer and supporting
classes. Also changed MediaPlayer to use new PlatformCALayerClient
so it can use PlatformCALayer directly rather than a dummy GraphicsLayer.
WKCACFLayerRenderer now does the task of notifying animations of their
start time. Also commented out an assert in AnimationBase because
AnimationController's frame time is not in sync with the new
AnimationTimeController. I've opened a new bug for that issue:

​https://bugs.webkit.org/show_bug.cgi?id=52037


This also includes the Mac side changes backed out in
​http://trac.webkit.org/changeset/75227.

11:58 AM BuildBot edited by Dimitri Glazkov
(diff)
11:46 AM Changeset in webkit [75261] by Nate Chapin
  • 5 edits
    2 adds in trunk

2011-01-07 Nate Chapin <Nate Chapin>

Reviewed by Darin Fisher.

Let PingLoader send cookies if FrameLoaderClient permits it.
​https://bugs.webkit.org/show_bug.cgi?id=51898

Test: http/tests/navigation/ping-cookie.html

  • loader/PingLoader.cpp: (WebCore::PingLoader::PingLoader): Set m_shouldUseCredentialStorage

at load start time, since we won't be able to call
FrameLoaderClient::shouldUseCredentialStorage() later.

  • loader/PingLoader.h: (WebCore::PingLoader::shouldUseCredentialStorage):
11:41 AM Changeset in webkit [75260] by xan@webkit.org
  • 4 edits in trunk

2011-01-07 Xan Lopez <​xlopez@igalia.com>

Unreviewed, rolling out r75256.
​http://trac.webkit.org/changeset/75256
​https://bugs.webkit.org/show_bug.cgi?id=50869

Broke GTK+ canvas tests

  • platform/gtk/Skipped:

2011-01-07 Xan Lopez <​xlopez@igalia.com>

Unreviewed, rolling out r75256.
​http://trac.webkit.org/changeset/75256
​https://bugs.webkit.org/show_bug.cgi?id=50869

Broke GTK+ canvas tests

  • platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::addArc):
11:32 AM Changeset in webkit [75259] by Carlos Garcia Campos
  • 9 edits in trunk

2011-01-07 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Port scrollbar painting to GtkStyleContext
​https://bugs.webkit.org/show_bug.cgi?id=52051

  • wtf/gobject/GTypedefs.h: Add GtkStyleContext forward declaration.

2011-01-07 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Port scrollbar painting to GtkStyleContext
​https://bugs.webkit.org/show_bug.cgi?id=52051

Use GtkStyleContext API to paint scrollbars when building with
GTK+ 3.x.

No new tests. This should not change functionality.

  • platform/gtk/RenderThemeGtk.h:
  • platform/gtk/RenderThemeGtk3.cpp: (WebCore::RenderThemeGtk::gtkScrollbarStyle):
  • platform/gtk/ScrollbarThemeGtk.cpp:
  • platform/gtk/ScrollbarThemeGtk.h:
  • platform/gtk/ScrollbarThemeGtk2.cpp: (WebCore::gtkStyleSetCallback): (WebCore::ScrollbarThemeGtk::ScrollbarThemeGtk):
  • platform/gtk/ScrollbarThemeGtk3.cpp: (WebCore::gtkStyleChangedCallback): (WebCore::ScrollbarThemeGtk::ScrollbarThemeGtk): (WebCore::ScrollbarThemeGtk::updateThemeProperties): (WebCore::ScrollbarThemeGtk::paintTrackBackground): (WebCore::ScrollbarThemeGtk::paintScrollbarBackground): (WebCore::ScrollbarThemeGtk::paintThumb): (WebCore::ScrollbarThemeGtk::paintButton):
11:31 AM Changeset in webkit [75258] by jberlin@webkit.org
  • 2 edits
    4 deletes in trunk/LayoutTests

Unreviewed, rolling out r75205.
​http://trac.webkit.org/changeset/75205
​https://bugs.webkit.org/show_bug.cgi?id=52026
​https://bugs.webkit.org/show_bug.cgi?id=52028
​https://bugs.webkit.org/show_bug.cgi?id=52029

The Windows 7 Release Test Bots are fixed.

  • platform/win/animations: Removed.
  • platform/win/animations/animation-time-expected.txt: Removed.
  • platform/win/fast/canvas/canvas-fillRect-gradient-shadow-expected.txt: Removed.
  • platform/win/fast/css/css3-nth-tokens-script-expected.txt: Removed.
  • platform/win/fast/css/css3-nth-tokens-style-expected.txt: Removed.
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
11:27 AM Changeset in webkit [75257] by mitz@apple.com
  • 5 edits
    4 adds in trunk

<rdar://problem/8783318> Text emphasis marks should not appear over characters that have ruby annotations
​https://bugs.webkit.org/show_bug.cgi?id=51267

Reviewed by Darin Adler.

WebCore:

Test: fast/text/emphasis-avoid-ruby.html

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesInBlockDirection): Use getEmphasisMarkPosition() to check if
there are text emphasis marks.
(WebCore::InlineFlowBox::addTextBoxVisualOverflow): Ditto.
(WebCore::InlineFlowBox::computeOverAnnotationAdjustment): Ditto.

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::getEmphasisMarkPosition): Added. Returns true and sets the emphasis mark
position if the text is style with emphasis marks and there isn’t a ruby annotation that should
suppress them. Otherwise returns false.
(WebCore::InlineTextBox::paint): Use getEmphasisMarkPosition() to check if emphasis marks should
be painted.

  • rendering/InlineTextBox.h:

LayoutTests:

  • fast/text/emphasis-avoid-ruby-expected.checksum: Added.
  • fast/text/emphasis-avoid-ruby-expected.png: Added.
  • fast/text/emphasis-avoid-ruby-expected.txt: Added.
  • fast/text/emphasis-avoid-ruby.html: Added.
11:08 AM BuildBot edited by Dimitri Glazkov
(diff)
11:05 AM Changeset in webkit [75256] by alex
  • 4 edits in trunk

2011-01-07 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Martin Robinson.

[cairo] Rendering a lot of arcs on top of each other causes time
outs in some tests
​https://bugs.webkit.org/show_bug.cgi?id=50869

We avoid the situation where we have to render the same arc
multiple times over itself. Now it renders just one oval and
moves to the end angle.

  • platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::addArc):

2011-01-07 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Martin Robinson.

[cairo] Rendering a lot of arcs on top of each other causes time
outs in some tests
​https://bugs.webkit.org/show_bug.cgi?id=50869

Unskip canvas-largedraws.html after improving the performance for
big angles.

  • platform/gtk/Skipped:
10:58 AM Changeset in webkit [75255] by Carlos Garcia Campos
  • 2 edits in trunk/WebCore

2011-01-07 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Port buttons painting to GtkStyleContext
​https://bugs.webkit.org/show_bug.cgi?id=51812

Use GtkStyleContext API to paint buttons when building with GTK+
3.x.

No new tests. This should not change functionality.

  • platform/gtk/RenderThemeGtk3.cpp: (WebCore::adjustRectForFocus): (WebCore::RenderThemeGtk::adjustRepaintRect): (WebCore::RenderThemeGtk::paintButton):
10:52 AM Changeset in webkit [75254] by zmo@google.com
  • 2 edits in trunk/WebCore

2011-01-07 Zhenyao Mo <​zmo@google.com>

Unreviewed, build fix.

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::copyTexSubImage2D):
10:43 AM Changeset in webkit [75253] by jberlin@webkit.org
  • 5 edits in trunk/WebKit2

WebKit2: Need WKBundlePagePrivate equivalent of WebKit1's WebViewPrivate's setDefersCallbacks
​https://bugs.webkit.org/show_bug.cgi?id=52038

Reviewed by Jon Honeycutt.

The implementation of WebKit1's WebViewPrivate's setDefersCallbacks on both Windows and Mac
calls WebCore::Page::setDefersLoading.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageSetDefersLoading):

  • WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setDefersLoading):

  • WebProcess/WebPage/WebPage.h:
10:35 AM BuildBot edited by Dimitri Glazkov
(diff)
10:32 AM BuildBot edited by Dimitri Glazkov
(diff)
10:31 AM BuildBot edited by Dimitri Glazkov
(diff)
10:26 AM BuildBot edited by Dimitri Glazkov
(diff)
10:23 AM BuildBot edited by Dimitri Glazkov
(diff)
10:19 AM Changeset in webkit [75252] by zmo@google.com
  • 8 edits in trunk

2011-01-06 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

copyTexSubImage2D shouldn't have undefined pixels
​https://bugs.webkit.org/show_bug.cgi?id=51559

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::copyTexImage2D): Refactor to share some code with copyTexSubImage2D through helper function clip2D. (WebCore::WebGLRenderingContext::copyTexSubImage2D): Initialize undefined pixels to 0. (WebCore::WebGLRenderingContext::validateTexFuncLevel): Seperate the validation of level from validateTexFuncParameters. (WebCore::WebGLRenderingContext::validateTexFuncParameters): Ditto.
  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebGLTexture.cpp: (WebCore::WebGLTexture::getType): Expose the type of a texture.
  • html/canvas/WebGLTexture.h:

2011-01-06 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

copyTexSubImage2D shouldn't have undefined pixels
​https://bugs.webkit.org/show_bug.cgi?id=51559

  • fast/canvas/webgl/uninitialized-test-expected.txt:
  • fast/canvas/webgl/uninitialized-test.html: Add test cases for copyTexSubImage2D.
10:16 AM BuildBot edited by Dimitri Glazkov
(diff)
9:51 AM Changeset in webkit [75251] by zmo@google.com
  • 2 edits in trunk/WebCore

2011-01-07 Takashi Toyoshima <​toyoshim@google.com>

Reviewed by Kenneth Russell.

cleanupAfterGraphicsCall() is never called in
WebGLRenderingContext::checkFramebufferStatus()
​https://bugs.webkit.org/show_bug.cgi?id=51668

No new tests. This is a trivial bug.

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::checkFramebufferStatus):
9:34 AM Changeset in webkit [75250] by mario@webkit.org
  • 6 edits in trunk

2011-01-07 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Chris Fleizach.

GTK: AX: atk tests need to be updated after recent changes
​https://bugs.webkit.org/show_bug.cgi?id=51932

Make sure we can always get the right accesssible parent for an
AtkObject when traversing the hierarchy bottom up.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (isRootObject): New function to check whether an AccessibilityObject is the root one or not, according to the latest changes in the hierarchy. (atkParentOfRootObject): Gets the appropriate AtkObject from GTK's GAIL as the parent of the root AtkObject from WebCore. (webkit_accessible_get_parent): Use atkParentOfRootObject. (webkit_accessible_get_index_in_parent): Ditto. (atkRole): Expose AccessibilityObjects with ScrollAreaRole as AtkObject's of role ATK_ROLE_SCROLLED_PANE.

2011-01-07 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Chris Fleizach.

GTK: AX: atk tests need to be updated after recent changes
​https://bugs.webkit.org/show_bug.cgi?id=51932

Fix gtk_widget_get_accessible() in WebKitWebView to keep returning
the AtkObject of role ATK_ROLE_DOCUMENT_FRAME.

With the change to support WK2 accessibility, the root object of
the AX hierarchy is different from what GTK expects as the current
hirarchy right now includes a new accessible object as the parent
of the accessible web area (AXScrollView).

  • webkit/webkitwebview.cpp: (webkit_web_view_get_accessible): Return the first child of the wrapper associated to the root accessible object in the document, to keep everything in the GTK port working as it used to be.

Re-enable skipped ATK unit tests now they are passing again.

  • tests/testatk.c: (main): Re-enable skipped tests.
  • tests/testatkroles.c: (main): Ditto.
9:32 AM Changeset in webkit [75249] by zmo@google.com
  • 4 edits in trunk/WebCore

2011-01-07 Zhenyao Mo <​zmo@google.com>

Unreviewed, Mac 32-bit build fix.
Use float instead of double in GL function arguments to avoid implicit type down casting.

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::blendColor): (WebCore::WebGLRenderingContext::clearColor): (WebCore::WebGLRenderingContext::clearDepth): (WebCore::WebGLRenderingContext::depthRange): (WebCore::WebGLRenderingContext::lineWidth): (WebCore::WebGLRenderingContext::polygonOffset): (WebCore::WebGLRenderingContext::sampleCoverage):
  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebGLRenderingContext.idl:
9:26 AM Changeset in webkit [75248] by sfalken@apple.com
  • 11 edits in trunk

Set svn:ignore on Visual Studio .user files inside directories that can contain them.

9:07 AM Changeset in webkit [75247] by dbates@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-01-07 Daniel Bates <​dbates@rim.com>

Reviewed by Martin Robinson.

Enable PCRE computed gotos when compiling with RCVT 4.0 or greater in GNU mode
​https://bugs.webkit.org/show_bug.cgi?id=52034

Derived from a patch by Eli Fidler.

RVCT 4 or greater in GNU mode supports the computed goto GNU language extension
as per <​http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0348c/ch03s07s12.html>.

  • pcre/pcre_exec.cpp: Modified to check for feature, HAVE(COMPUTED_GOTO), instead of hardcoding the GCC compiler.
  • wtf/Platform.h: Define WTF_COMPILER_RVCT4_OR_GREATER if ARMCC_VERSION >= 400000.
8:56 AM Changeset in webkit [75246] by beidson@apple.com
  • 7 edits in trunk/WebKit2

<rdar://problem/8261624> and ​https://bugs.webkit.org/show_bug.cgi?id=47355
Change WebKit2 session restoring to restore the full back/forward list.

Reviewed by Darin Adler.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::registerNewWebBackForwardListItem): Let the UIProcess register its own

WebBackForwardListItems in its ID map upon creation.

  • UIProcess/WebProcessProxy.h:
  • UIProcess/cf/WebPageProxyCF.cpp:

(WebKit::WebPageProxy::restoreFromSessionStateData): Register each new list entry in the

UIProcess ID map.

  • WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit::WebBackForwardListProxy::addItemFromUIProcess): Add this method to register UIProcess

created items without doing any of the other work normally associated with adding a new back/forward item
(such as notifying the UIProcess).

  • WebProcess/WebPage/WebBackForwardListProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::restoreSession): Map all of the back/forward list entries from the UIProcess then

cause a load of the current entry.

8:44 AM Changeset in webkit [75245] by senorblanco@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

2011-01-07 Stephen White <​senorblanco@chromium.org>

Unreviewed; new test results and expectations updates.

Created new results for tests which do not fail on chrome win (failing
Safari results were recently checked in). Also assigned bugs to many
of my recent test_expectations updates.

  • platform/chromium-win/animations/animation-time-expected.txt: Added.
  • platform/chromium-win/fast/css/css3-nth-tokens-script-expected.txt: Added.
  • platform/chromium-win/fast/css/css3-nth-tokens-style-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
8:02 AM Changeset in webkit [75244] by Adam Roben
  • 2 edits in trunk/Tools

Build master fix

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunWebKitTests.start): Don't try to concatenate a list and a string.

7:55 AM Changeset in webkit [75243] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-07 Stephen White <​senorblanco@chromium.org>

Unreviewed; chromium test expectations update.

  • platform/chromium/test_expectations.txt: A few tests that were flaky before are failing more frequently now.
5:59 AM Changeset in webkit [75242] by andreas.kling@nokia.com
  • 6 edits in trunk/WebKit/qt

2011-01-07 Andreas Kling <​kling@webkit.org>

Reviewed by Adam Barth.

[Qt] Add selectedHtml function to QWebView
​https://bugs.webkit.org/show_bug.cgi?id=35028

Add QWebView::selectedHtml() and QWebPage::selectedHtml()
which return the current selection range's HTML representation.

  • Api/qwebpage.cpp: (QWebPage::selectedHtml):
  • Api/qwebpage.h:
  • Api/qwebview.cpp: (QWebView::selectedText): (QWebView::selectedHtml):
  • Api/qwebview.h:
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::cursorMovements): (tst_QWebPage::textSelection): (tst_QWebPage::crashTests_LazyInitializationOfMainFrame): (tst_QWebPage::findText):
5:58 AM Changeset in webkit [75241] by Carlos Garcia Campos
  • 5 edits in trunk/WebCore

2011-01-07 Carlos Garcia Campos <​cgarcia@igalia.com> and Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Port slider painting to GtkStyleContext
​https://bugs.webkit.org/show_bug.cgi?id=51874

Use GtkStyleContext API to paint sliders when building with GTK+
3.x. Also move the code to adjust media slider to its own method
in RenderThemeGtk.cpp since it's common to both gtk 2 and 3.

No new tests. This should not change functionality.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::adjustMediaSliderThumbSize):
  • platform/gtk/RenderThemeGtk.h:
  • platform/gtk/RenderThemeGtk2.cpp: (WebCore::RenderThemeGtk::adjustSliderThumbSize):
  • platform/gtk/RenderThemeGtk3.cpp: (WebCore::RenderThemeGtk::paintSliderTrack): (WebCore::RenderThemeGtk::paintSliderThumb): (WebCore::RenderThemeGtk::adjustSliderThumbSize):
5:07 AM Changeset in webkit [75240] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-01-07 Jedrzej Nowacki <​jedrzej.nowacki@nokia.com>

Reviewed by Csaba Osztrogonác.

run-qtwebkit-tests should be able to kill a testsuite.

Add new option in the script that can setup a timeout for a test.
If the test execution takes more then specified time then the test
would be terminated.

[Qt] run-qtwebkit-tests needs timeout
​https://bugs.webkit.org/show_bug.cgi?id=51894

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
  • Scripts/run-qtwebkit-tests:
4:31 AM Changeset in webkit [75239] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Unreviewed fix after r75233.

Based on idea from Eric Seidel.

Add remote zip file handling to webkitpy.
​https://bugs.webkit.org/show_bug.cgi?id=50901

  • Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
3:26 AM Changeset in webkit [75238] by benjamin.poulain@nokia.com
  • 2 edits in trunk/WebCore

2011-01-07 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Andreas Kling.

[Qt] [WK2] QtWebKit does not build in debug, FileReader.cpp does not compile
​https://bugs.webkit.org/show_bug.cgi?id=51992

Add the missing header. CString is used in debug by the calls to LOG().

  • fileapi/FileReader.cpp:
2:25 AM Changeset in webkit [75237] by alex
  • 3 edits
    4 adds in trunk

2011-01-07 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Martin Robinson.

Cairo's ContextShadow may mis-render some box shadows
​https://bugs.webkit.org/show_bug.cgi?id=51374

The space required for the internal shadow of the corners was not
correctly considered.

  • platform/graphics/cairo/ContextShadowCairo.cpp: (WebCore::ContextShadow::drawRectShadow):

2011-01-07 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Martin Robinson.

Cairo's ContextShadow may mis-render some box shadows
​https://bugs.webkit.org/show_bug.cgi?id=51374

Added new test to check rectangular tiled shadows.

  • platform/gtk/fast/css/rect-shadow-tiled-expected.checksum: Added.
  • platform/gtk/fast/css/rect-shadow-tiled-expected.png: Added.
  • platform/gtk/fast/css/rect-shadow-tiled-expected.txt: Added.
  • platform/gtk/fast/css/rect-shadow-tiled.html: Added.
1:49 AM Changeset in webkit [75236] by kinuko@chromium.org
  • 3 edits in trunk/LayoutTests

2011-01-07 Kinuko Yasuda <​kinuko@chromium.org>

Unreviewed; an attempt to fix chromium bot failures by removing failing test line (they must be failing due to modificationTime accuracy error).

  • fast/filesystem/op-get-metadata-expected.txt:
  • fast/filesystem/resources/op-tests-helper.js: (runOperationTest.OperationTestHelper.this.testMetadataSuccessCallback):
1:46 AM Changeset in webkit [75235] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-01-07 Shane Stephens <​shanestephens@google.com>

Reviewed by Eric Seidel.

svn-apply: should support git binary delta diffs
​https://bugs.webkit.org/show_bug.cgi?id=38864

  • Scripts/VCSUtils.pm:
  • Scripts/svn-apply:

Jan 6, 2011:

11:31 PM Changeset in webkit [75234] by jparent@chromium.org
  • 3 edits in trunk/Tools

2011-01-06 Julie Parent <​jparent@chromium.org>

Reviewed by Eric Seidel.

Test Result Server not removing old results.
​https://bugs.webkit.org/show_bug.cgi?id=52012

  • TestResultServer/model/jsonresults.py: Fix off-by-one: Truncate if >= num_runs, not just >.
  • TestResultServer/model/jsonresults_unittest.py: Add unit test to test that merging in a new result with the same value as the last result causes previous result to fall off.
11:13 PM Changeset in webkit [75233] by commit-queue@webkit.org
  • 3 edits
    5 adds in trunk/Tools

2011-01-06 James Kozianski <​koz@chromium.org>

Reviewed by Mihai Parparita.

Add classes to provide a consistent interface to a set of files.
​https://bugs.webkit.org/show_bug.cgi?id=50901

These classes allow us to write code that is agnostic to whether a
particular set of files resides in a local directory or in a zip file
on a remote machine.

  • Scripts/webkitpy/common/system/directoryfileset.py: Added.
  • Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
  • Scripts/webkitpy/common/system/fileset.py: Added.
  • Scripts/webkitpy/common/system/filesystem.py:
  • Scripts/webkitpy/common/system/filesystem_mock.py:
  • Scripts/webkitpy/common/system/zipfileset.py: Added.
  • Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
11:07 PM Changeset in webkit [75232] by kinuko@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

2011-01-06 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by David Levin.

Add layout tests for Entry.getMetadata (FileSystem API)
​https://bugs.webkit.org/show_bug.cgi?id=47311

  • fast/filesystem/op-get-metadata-expected.txt: Added.
  • fast/filesystem/op-get-metadata.html: Added.
  • fast/filesystem/resources/op-get-metadata.js: Added.
  • fast/filesystem/resources/op-tests-helper.js: Updated getMetadata implementation.
10:05 PM Changeset in webkit [75231] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-06 Mihai Parparita <​mihaip@chromium.org>

Unreviewed; chromium test expectations update.

Remove failing expectations for tests that started to pass after
rebaselining in r75215.

Make failing expectations added by r75213 more specific (failures are
only on Windows and Linux).

  • platform/chromium/test_expectations.txt:
9:32 PM Changeset in webkit [75230] by eric@webkit.org
  • 3 edits in trunk/Tools

2011-01-06 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

NetworkTransaction should log the url it is retrying
​https://bugs.webkit.org/show_bug.cgi?id=52043

  • Scripts/webkitpy/common/net/networktransaction.py:
  • Scripts/webkitpy/common/net/networktransaction_unittest.py:
9:24 PM Changeset in webkit [75229] by sfalken@apple.com
  • 2 edits in trunk/Tools

Windows build fix.
Import os before using it.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
9:14 PM Changeset in webkit [75228] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

2011-01-06 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

REGRESSION (r74663): ASSERTION FAILED: m_tokenizer->lineNumber() == line.zeroBasedInt()
​https://bugs.webkit.org/show_bug.cgi?id=52013

This test case used to trigger an ASSERT. It's unclear to me whether
there's a more direct way to test this fix.

  • fast/parser/line-number-composite-segmented-string-expected.txt: Added.
  • fast/parser/line-number-composite-segmented-string.html: Added.

2011-01-06 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

REGRESSION (r74663): ASSERTION FAILED: m_tokenizer->lineNumber() == line.zeroBasedInt()
​https://bugs.webkit.org/show_bug.cgi?id=52013

When excluding line numbers for composite strings, we forgot to exclude
the line number for the current string!

Test: fast/parser/line-number-composite-segmented-string.html

  • platform/text/SegmentedString.cpp: (WebCore::SegmentedString::setExcludeLineNumbers):
8:53 PM Changeset in webkit [75227] by cmarrin@apple.com
  • 15 edits
    1 delete in trunk/WebCore

2011-01-06 Chris Marrin <​cmarrin@apple.com>

Unreviewed.

Back out changes in ​http://trac.webkit.org/changeset/75199
This breaks the Windows build. Fixing it on that side. Until
then I'll back this out.

8:32 PM Changeset in webkit [75226] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-06 Stephen White <​senorblanco@chromium.org>

Unreviewed; chromium test expectations update.

  • platform/chromium/test_expectations.txt: New test fast/frames/iframe-reparenting-plugins.html failing on windows.
8:22 PM Changeset in webkit [75225] by eric@webkit.org
  • 2 edits in trunk/Tools

2011-01-06 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

StyleQueue fails to report errors when patches have many files
​https://bugs.webkit.org/show_bug.cgi?id=52042

This is one of at least two errors preventing style error reporting at the moment.
When we moved to passing the list of files to check explicitly,
we started to exceed the 500 character TEXT field limit for our AppEngine model object.
We could change the type of the QueueStatus.message type, or we could
just teach statusserver.py how to clamp values (and warn when it does).
I chose the latter path.

  • Scripts/webkitpy/common/net/statusserver.py:
7:37 PM Changeset in webkit [75224] by Martin Robinson
  • 2 edits
    123 adds in trunk/LayoutTests

2011-01-06 Martin Robinson <​mrobinson@igalia.com>

Add new expected results for GTK+. Skip viewport tests which
have results differing from Opera.

  • fast/dom/left-overflow-in-ltr-expected.txt: Added.
  • fast/dom/right-overflow-in-rtl-expected.txt: Added.
  • fast/viewport/viewport-126-expected.txt: Added.
  • fast/viewport/viewport-127-expected.txt: Added.
  • fast/viewport/viewport-65-expected.txt: Added.
  • fast/viewport/viewport-82-expected.txt: Added.
  • fast/viewport/viewport-84-expected.txt: Added.
  • fast/viewport/viewport-87-expected.txt: Added.
  • platform/gtk/Skipped:
  • platform/gtk/css2.1/t040105-import-10-b-expected.checksum: Added.
  • platform/gtk/css2.1/t040105-import-10-b-expected.png: Added.
  • platform/gtk/css2.1/t040105-import-10-b-expected.txt: Added.
  • platform/gtk/fast/block/positioning/rtl-static-positioning-expected.checksum: Added.
  • platform/gtk/fast/block/positioning/rtl-static-positioning-expected.png: Added.
  • platform/gtk/fast/block/positioning/rtl-static-positioning-expected.txt: Added.
  • platform/gtk/fast/block/positioning/rtl-static-positioning-inline-block-expected.checksum: Added.
  • platform/gtk/fast/block/positioning/rtl-static-positioning-inline-block-expected.png: Added.
  • platform/gtk/fast/block/positioning/rtl-static-positioning-inline-block-expected.txt: Added.
  • platform/gtk/fast/block/positioning/table-cell-static-position-expected.checksum: Added.
  • platform/gtk/fast/block/positioning/table-cell-static-position-expected.png: Added.
  • platform/gtk/fast/block/positioning/table-cell-static-position-expected.txt: Added.
  • platform/gtk/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum: Added.
  • platform/gtk/fast/blockflow/Kusa-Makura-background-canvas-expected.png: Added.
  • platform/gtk/fast/blockflow/Kusa-Makura-background-canvas-expected.txt: Added.
  • platform/gtk/fast/blockflow/japanese-rl-text-with-broken-font-expected.checksum: Added.
  • platform/gtk/fast/blockflow/japanese-rl-text-with-broken-font-expected.png: Added.
  • platform/gtk/fast/blockflow/japanese-rl-text-with-broken-font-expected.txt: Added.
  • platform/gtk/fast/blockflow/vertical-align-table-baseline-expected.checksum: Added.
  • platform/gtk/fast/blockflow/vertical-align-table-baseline-expected.png: Added.
  • platform/gtk/fast/blockflow/vertical-align-table-baseline-expected.txt: Added.
  • platform/gtk/fast/blockflow/vertical-baseline-alignment-expected.checksum: Added.
  • platform/gtk/fast/blockflow/vertical-baseline-alignment-expected.png: Added.
  • platform/gtk/fast/blockflow/vertical-baseline-alignment-expected.txt: Added.
  • platform/gtk/fast/css-generated-content/table-before-after-child-add-expected.checksum: Added.
  • platform/gtk/fast/css-generated-content/table-before-after-child-add-expected.png: Added.
  • platform/gtk/fast/css-generated-content/table-before-after-child-add-expected.txt: Added.
  • platform/gtk/fast/css-generated-content/table-cell-before-after-child-add-expected.checksum: Added.
  • platform/gtk/fast/css-generated-content/table-cell-before-after-child-add-expected.png: Added.
  • platform/gtk/fast/css-generated-content/table-cell-before-after-child-add-expected.txt: Added.
  • platform/gtk/fast/css-generated-content/table-row-before-after-child-add-expected.checksum: Added.
  • platform/gtk/fast/css-generated-content/table-row-before-after-child-add-expected.png: Added.
  • platform/gtk/fast/css-generated-content/table-row-before-after-child-add-expected.txt: Added.
  • platform/gtk/fast/css-generated-content/table-table-before-after-child-add-expected.checksum: Added.
  • platform/gtk/fast/css-generated-content/table-table-before-after-child-add-expected.png: Added.
  • platform/gtk/fast/css-generated-content/table-table-before-after-child-add-expected.txt: Added.
  • platform/gtk/fast/css/box-shadow-expected.checksum: Added.
  • platform/gtk/fast/css/box-shadow-expected.png: Added.
  • platform/gtk/fast/css/box-shadow-expected.txt: Added.
  • platform/gtk/fast/css/focus-ring-detached-expected.checksum: Added.
  • platform/gtk/fast/css/focus-ring-detached-expected.png: Added.
  • platform/gtk/fast/css/focus-ring-detached-expected.txt: Added.
  • platform/gtk/fast/css/focus-ring-multiline-expected.checksum: Added.
  • platform/gtk/fast/css/focus-ring-multiline-expected.png: Added.
  • platform/gtk/fast/css/focus-ring-multiline-expected.txt: Added.
  • platform/gtk/fast/css/focus-ring-outline-color-expected.checksum: Added.
  • platform/gtk/fast/css/focus-ring-outline-color-expected.png: Added.
  • platform/gtk/fast/css/focus-ring-outline-color-expected.txt: Added.
  • platform/gtk/fast/css/focus-ring-outline-offset-expected.checksum: Added.
  • platform/gtk/fast/css/focus-ring-outline-offset-expected.png: Added.
  • platform/gtk/fast/css/focus-ring-outline-offset-expected.txt: Added.
  • platform/gtk/fast/css/focus-ring-outline-width-expected.checksum: Added.
  • platform/gtk/fast/css/focus-ring-outline-width-expected.png: Added.
  • platform/gtk/fast/css/focus-ring-outline-width-expected.txt: Added.
  • platform/gtk/fast/forms/placeholder-position-expected.checksum: Added.
  • platform/gtk/fast/forms/placeholder-position-expected.png: Added.
  • platform/gtk/fast/forms/placeholder-position-expected.txt: Added.
  • platform/gtk/fast/html/marquee-scrollamount-expected.checksum: Added.
  • platform/gtk/fast/html/marquee-scrollamount-expected.png: Added.
  • platform/gtk/fast/html/marquee-scrollamount-expected.txt: Added.
  • platform/gtk/fast/images/gray-scale-jpeg-with-color-profile-expected.checksum: Added.
  • platform/gtk/fast/images/gray-scale-jpeg-with-color-profile-expected.png: Added.
  • platform/gtk/fast/images/gray-scale-jpeg-with-color-profile-expected.txt: Added.
  • platform/gtk/fast/images/imagemap-focus-ring-outline-color-expected.txt: Added.
  • platform/gtk/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.checksum: Added.
  • platform/gtk/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.png: Added.
  • platform/gtk/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.txt: Added.
  • platform/gtk/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.txt: Added.
  • platform/gtk/fast/images/imagemap-focus-ring-zoom-expected.txt: Added.
  • platform/gtk/fast/multicol/span/anonymous-before-child-parent-crash-expected.checksum: Added.
  • platform/gtk/fast/multicol/span/anonymous-before-child-parent-crash-expected.png: Added.
  • platform/gtk/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt: Added.
  • platform/gtk/fast/multicol/span/anonymous-split-block-crash-expected.checksum: Added.
  • platform/gtk/fast/multicol/span/anonymous-split-block-crash-expected.png: Added.
  • platform/gtk/fast/multicol/span/anonymous-split-block-crash-expected.txt: Added.
  • platform/gtk/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.checksum: Added.
  • platform/gtk/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png: Added.
  • platform/gtk/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Added.
  • platform/gtk/fast/overflow/overflow-rtl-vertical-expected.checksum: Added.
  • platform/gtk/fast/overflow/overflow-rtl-vertical-expected.png: Added.
  • platform/gtk/fast/overflow/overflow-rtl-vertical-expected.txt: Added.
  • platform/gtk/fast/overflow/overflow-update-transform-expected.checksum: Added.
  • platform/gtk/fast/overflow/overflow-update-transform-expected.png: Added.
  • platform/gtk/fast/overflow/overflow-update-transform-expected.txt: Added.
  • platform/gtk/fast/ruby/nested-ruby-expected.checksum: Added.
  • platform/gtk/fast/ruby/nested-ruby-expected.png: Added.
  • platform/gtk/fast/ruby/nested-ruby-expected.txt: Added.
  • platform/gtk/fast/text/emphasis-expected.checksum: Added.
  • platform/gtk/fast/text/emphasis-expected.png: Added.
  • platform/gtk/fast/text/emphasis-expected.txt: Added.
  • platform/gtk/fast/text/emphasis-vertical-expected.checksum: Added.
  • platform/gtk/fast/text/emphasis-vertical-expected.png: Added.
  • platform/gtk/fast/text/emphasis-vertical-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt: Added.
  • platform/gtk/svg/custom/image-rescale-clip-expected.checksum: Added.
  • platform/gtk/svg/custom/image-rescale-clip-expected.png: Added.
  • platform/gtk/svg/custom/image-rescale-clip-expected.txt: Added.
  • platform/gtk/svg/custom/image-rescale-scroll-expected.checksum: Added.
  • platform/gtk/svg/custom/image-rescale-scroll-expected.png: Added.
  • platform/gtk/svg/custom/image-rescale-scroll-expected.txt: Added.
  • platform/gtk/svg/dom/SVGPathSegList-cloning-expected.checksum: Added.
  • platform/gtk/svg/dom/SVGPathSegList-cloning-expected.png: Added.
  • platform/gtk/svg/dom/SVGPathSegList-cloning-expected.txt: Added.
  • platform/gtk/svg/dom/SVGPathSegList-segment-modification-expected.checksum: Added.
  • platform/gtk/svg/dom/SVGPathSegList-segment-modification-expected.png: Added.
  • platform/gtk/svg/dom/SVGPathSegList-segment-modification-expected.txt: Added.
  • platform/gtk/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.checksum: Added.
  • platform/gtk/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.png: Added.
  • platform/gtk/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.txt: Added.
  • platform/gtk/svg/filters/feColorMatrix-offset-expected.checksum: Added.
  • platform/gtk/svg/filters/feColorMatrix-offset-expected.png: Added.
  • platform/gtk/svg/filters/feColorMatrix-offset-expected.txt: Added.
6:59 PM Changeset in webkit [75223] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-06 Stephen White <​senorblanco@chromium.org>

Unreviewed; yet another test expectations update.

  • platform/chromium/test_expectations.txt:
6:52 PM Changeset in webkit [75222] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-01-06 Ojan Vafai <​ojan@chromium.org>

Fix line context when replying to comments.

  • code-review.js:
6:35 PM Changeset in webkit [75221] by senorblanco@chromium.org
  • 2 edits
    4 adds in trunk/LayoutTests

2011-01-06 Stephen White <​senorblanco@chromium.org>

Unreviewed; test expectations update.

Add new results for new tests introduced in r75097.

  • platform/chromium-mac/fast/gradients/css3-repeating-linear-gradients-expected.checksum: Added.
  • platform/chromium-mac/fast/gradients/css3-repeating-linear-gradients-expected.png: Added.
  • platform/chromium-win/fast/gradients/css3-repeating-linear-gradients-expected.checksum: Added.
  • platform/chromium-win/fast/gradients/css3-repeating-linear-gradients-expected.png: Added.
  • platform/chromium/test_expectations.txt:


6:25 PM Changeset in webkit [75220] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-06 Robert Hogan <​robert@webkit.org>

[Qt] Update expected results after r75177

Unreviewed, update expected results.

  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
6:11 PM Changeset in webkit [75219] by Martin Robinson
  • 3 edits in trunk/LayoutTests

2011-01-06 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Adam Barth.

fast/dom/Window/window-postmessage-clone.html may fail on platforms with larger fonts
​https://bugs.webkit.org/show_bug.cgi?id=52027

Move the console output div after the file input control in
fast/dom/Window/window-postmessage-clone.html so that console
text does not push it outside of the viewport.

  • fast/dom/Window/window-postmessage-clone-expected.txt: Updated results to match new text output.
  • fast/dom/Window/window-postmessage-clone.html: Moved console div.
6:06 PM Changeset in webkit [75218] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2011-01-06 Martin Robinson <​mrobinson@igalia.com>

Update GTK+-specific results after r75177.

  • platform/gtk/fast/dom/prototype-inheritance-expected.txt: Update results.
5:58 PM Changeset in webkit [75217] by commit-queue@webkit.org
  • 17 edits
    4 adds in trunk

2011-01-06 Jenn Braithwaite <​jennb@chromium.org>

Reviewed by Dmitry Titov.

When a live frame is moved between pages, some plug-in DOM methods cease to function
​https://bugs.webkit.org/show_bug.cgi?id=45770

  • fast/frames/iframe-reparenting-plugins-expected.txt: Added.
  • fast/frames/iframe-reparenting-plugins.html: Added.
  • fast/frames/resources/iframe-reparenting-plugins-iframe-content.html: Added.
  • fast/frames/resources/iframe-reparenting-plugins-new-page.html: Added.

2011-01-06 Jenn Braithwaite <​jennb@chromium.org>

Reviewed by Dmitry Titov.

When a live frame is moved between pages, some plug-in DOM methods cease to function
​https://bugs.webkit.org/show_bug.cgi?id=45770

Test: fast/frames/iframe-reparenting-plugins.html

  • page/Frame.cpp: (WebCore::Frame::~Frame): (WebCore::Frame::addObserver): (WebCore::Frame::removeObserver):
  • page/Frame.h: (WebCore::FrameDestructionObserver::~FrameDestructionObserver): Added observer to be notified when frame is destroyed.
  • page/Page.cpp: (WebCore::Page::~Page): (WebCore::Page::refreshPlugins): PluginData no longer stores page pointer.
  • plugins/DOMMimeType.cpp: (WebCore::DOMMimeType::DOMMimeType): (WebCore::DOMMimeType::~DOMMimeType): (WebCore::DOMMimeType::enabledPlugin):
  • plugins/DOMMimeType.h: (WebCore::DOMMimeType::create): (WebCore::DOMMimeType::frameDestroyed): Store frame instead of page pointer in DOMMimeType.
  • plugins/DOMMimeTypeArray.cpp: (WebCore::DOMMimeTypeArray::item): (WebCore::DOMMimeTypeArray::namedItem): Provide frame to create DOMMimeType.
  • plugins/DOMPlugin.cpp: (WebCore::DOMPlugin::DOMPlugin): (WebCore::DOMPlugin::~DOMPlugin): (WebCore::DOMPlugin::item): (WebCore::DOMPlugin::namedItem):
  • plugins/DOMPlugin.h: (WebCore::DOMPlugin::create): (WebCore::DOMPlugin::frameDestroyed): Store frame instead of page pointer in DOMPlugin.
  • plugins/DOMPluginArray.cpp: (WebCore::DOMPluginArray::item): (WebCore::DOMPluginArray::namedItem): Provide frame to create DOMPlugin.
  • plugins/PluginData.cpp: (WebCore::PluginData::PluginData): (WebCore::PluginData::initPlugins):
  • plugins/PluginData.h: No longer stores a pointer to the page. Added page parameter to initPlugins.
  • plugins/PluginDataNone.cpp: (WebCore::PluginData::initPlugins):
  • plugins/chromium/PluginDataChromium.cpp: (WebCore::PluginData::initPlugins):
  • plugins/gtk/PluginDataGtk.cpp: (WebCore::PluginData::initPlugins):
  • plugins/wx/PluginDataWx.cpp: (WebCore::PluginData::initPlugins): Updated platforms to add (unused) page parameter to initPlugins.
5:55 PM Changeset in webkit [75216] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-06 Stephen White <​senorblanco@chromium.org>

Unreviewed; test expectations update.

  • platform/chromium-gpu/test_expectations.txt: Remove duplicate expectations.
5:45 PM Changeset in webkit [75215] by mihaip@chromium.org
  • 2 edits
    25 adds in trunk/LayoutTests

2011-01-06 Mihai Parparita <​mihaip@chromium.org>

Unreviewed, test expectation update.

Add mac-leopard baselines for tests that currently have Snow Leopard
baselines in platform/mac.

  • platform/mac-leopard/fast/multicol/client-rects-expected.checksum:
  • platform/mac-leopard/fast/multicol/client-rects-expected.png: Added.
  • platform/mac-leopard/fast/multicol/column-break-with-balancing-expected.checksum: Added.
  • platform/mac-leopard/fast/multicol/column-break-with-balancing-expected.png: Added.
  • platform/mac-leopard/fast/multicol/float-multicol-expected.checksum: Added.
  • platform/mac-leopard/fast/multicol/float-multicol-expected.png: Added.
  • platform/mac-leopard/fast/multicol/float-paginate-complex-expected.checksum: Added.
  • platform/mac-leopard/fast/multicol/float-paginate-complex-expected.png: Added.
  • platform/mac-leopard/fast/multicol/float-paginate-expected.checksum: Added.
  • platform/mac-leopard/fast/multicol/float-paginate-expected.png: Added.
  • platform/mac-leopard/fast/multicol/layers-in-multicol-expected.checksum: Added.
  • platform/mac-leopard/fast/multicol/layers-in-multicol-expected.png: Added.
  • platform/mac-leopard/fast/multicol/layers-split-across-columns-expected.checksum: Added.
  • platform/mac-leopard/fast/multicol/layers-split-across-columns-expected.png: Added.
  • platform/mac-leopard/fast/multicol/paginate-block-replaced-expected.checksum: Added.
  • platform/mac-leopard/fast/multicol/paginate-block-replaced-expected.png: Added.
  • platform/mac-leopard/fast/multicol/span/anonymous-style-inheritance-expected.checksum: Added.
  • platform/mac-leopard/fast/multicol/span/anonymous-style-inheritance-expected.png: Added.
  • platform/mac-leopard/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.checksum: Added.
  • platform/mac-leopard/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png: Added.
  • platform/mac-leopard/fast/multicol/span/span-as-nested-columns-child-expected.checksum: Added.
  • platform/mac-leopard/fast/multicol/span/span-as-nested-columns-child-expected.png: Added.
  • platform/mac-leopard/fast/multicol/table-vertical-align-expected.checksum: Added.
  • platform/mac-leopard/fast/multicol/table-vertical-align-expected.png: Added.
  • platform/mac-leopard/fast/repaint/overflow-scroll-body-appear-expected.checksum: Added.
  • platform/mac-leopard/fast/repaint/overflow-scroll-body-appear-expected.png: Added.
5:43 PM Changeset in webkit [75214] by zmo@google.com
  • 13 edits in trunk

2011-01-05 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

Define GC3D types to match GL types and use them in GraphicsContext3D
​https://bugs.webkit.org/show_bug.cgi?id=45557

  • src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DInternal::bindAttribLocation): (WebCore::GraphicsContext3DInternal::bufferData): (WebCore::GraphicsContext3DInternal::bufferSubData): (WebCore::GraphicsContext3DInternal::getActiveAttrib): (WebCore::GraphicsContext3DInternal::getActiveUniform): (WebCore::GraphicsContext3DInternal::getAttribLocation): (WebCore::GraphicsContext3DInternal::getString): (WebCore::GraphicsContext3DInternal::getUniformLocation): (WebCore::GraphicsContext3DInternal::texImage2D): (WebCore::GraphicsContext3DInternal::texSubImage2D): (WebCore::GraphicsContext3DInternal::uniform1fv): (WebCore::GraphicsContext3DInternal::uniform1iv): (WebCore::GraphicsContext3DInternal::uniform2fv): (WebCore::GraphicsContext3DInternal::uniform2iv): (WebCore::GraphicsContext3DInternal::uniform3fv): (WebCore::GraphicsContext3DInternal::uniform3iv): (WebCore::GraphicsContext3DInternal::uniform4fv): (WebCore::GraphicsContext3DInternal::uniform4iv): (WebCore::GraphicsContext3DInternal::uniformMatrix2fv): (WebCore::GraphicsContext3DInternal::uniformMatrix3fv): (WebCore::GraphicsContext3DInternal::uniformMatrix4fv):
  • src/GraphicsContext3DInternal.h:

2011-01-05 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

Define GC3D types to match GL types and use them in GraphicsContext3D
​https://bugs.webkit.org/show_bug.cgi?id=45557

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::readPixels): (WebCore::WebGLRenderingContext::validateTexFuncData):
  • platform/graphics/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::texImage2DResourceSafe): (WebCore::GraphicsContext3D::computeFormatAndTypeParameters): (WebCore::GraphicsContext3D::extractImageData): (WebCore::GraphicsContext3D::extractTextureData):
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/cg/GraphicsContext3DCG.cpp: (WebCore::GraphicsContext3D::getImageData):
  • platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::enable): (WebCore::SharedGraphicsContext3D::disable): (WebCore::SharedGraphicsContext3D::clear): (WebCore::SharedGraphicsContext3D::drawArrays): (WebCore::SharedGraphicsContext3D::getError): (WebCore::SharedGraphicsContext3D::getIntegerv): (WebCore::SharedGraphicsContext3D::createFramebuffer): (WebCore::SharedGraphicsContext3D::createTexture): (WebCore::SharedGraphicsContext3D::deleteFramebuffer): (WebCore::SharedGraphicsContext3D::deleteTexture): (WebCore::SharedGraphicsContext3D::framebufferTexture2D): (WebCore::SharedGraphicsContext3D::texParameteri): (WebCore::SharedGraphicsContext3D::texImage2D): (WebCore::SharedGraphicsContext3D::texSubImage2D): (WebCore::SharedGraphicsContext3D::readPixels): (WebCore::SharedGraphicsContext3D::setActiveTexture): (WebCore::SharedGraphicsContext3D::bindTexture): (WebCore::SharedGraphicsContext3D::bindFramebuffer):
  • platform/graphics/gpu/SharedGraphicsContext3D.h:
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: (WebCore::GraphicsContext3D::activeTexture): (WebCore::GraphicsContext3D::attachShader): (WebCore::GraphicsContext3D::bindAttribLocation): (WebCore::GraphicsContext3D::bindBuffer): (WebCore::GraphicsContext3D::bindFramebuffer): (WebCore::GraphicsContext3D::bindRenderbuffer): (WebCore::GraphicsContext3D::bindTexture): (WebCore::GraphicsContext3D::blendColor): (WebCore::GraphicsContext3D::blendEquation): (WebCore::GraphicsContext3D::blendEquationSeparate): (WebCore::GraphicsContext3D::blendFunc): (WebCore::GraphicsContext3D::blendFuncSeparate): (WebCore::GraphicsContext3D::bufferData): (WebCore::GraphicsContext3D::bufferSubData): (WebCore::GraphicsContext3D::checkFramebufferStatus): (WebCore::GraphicsContext3D::clearColor): (WebCore::GraphicsContext3D::clear): (WebCore::GraphicsContext3D::clearDepth): (WebCore::GraphicsContext3D::clearStencil): (WebCore::GraphicsContext3D::colorMask): (WebCore::GraphicsContext3D::compileShader): (WebCore::GraphicsContext3D::copyTexImage2D): (WebCore::GraphicsContext3D::copyTexSubImage2D): (WebCore::GraphicsContext3D::cullFace): (WebCore::GraphicsContext3D::depthFunc): (WebCore::GraphicsContext3D::depthMask): (WebCore::GraphicsContext3D::depthRange): (WebCore::GraphicsContext3D::detachShader): (WebCore::GraphicsContext3D::disable): (WebCore::GraphicsContext3D::disableVertexAttribArray): (WebCore::GraphicsContext3D::drawArrays): (WebCore::GraphicsContext3D::drawElements): (WebCore::GraphicsContext3D::enable): (WebCore::GraphicsContext3D::enableVertexAttribArray): (WebCore::GraphicsContext3D::framebufferRenderbuffer): (WebCore::GraphicsContext3D::framebufferTexture2D): (WebCore::GraphicsContext3D::frontFace): (WebCore::GraphicsContext3D::generateMipmap): (WebCore::GraphicsContext3D::getActiveAttrib): (WebCore::GraphicsContext3D::getActiveUniform): (WebCore::GraphicsContext3D::getAttachedShaders): (WebCore::GraphicsContext3D::getAttribLocation): (WebCore::GraphicsContext3D::getError): (WebCore::GraphicsContext3D::getString): (WebCore::GraphicsContext3D::hint): (WebCore::GraphicsContext3D::isBuffer): (WebCore::GraphicsContext3D::isEnabled): (WebCore::GraphicsContext3D::isFramebuffer): (WebCore::GraphicsContext3D::isProgram): (WebCore::GraphicsContext3D::isRenderbuffer): (WebCore::GraphicsContext3D::isShader): (WebCore::GraphicsContext3D::isTexture): (WebCore::GraphicsContext3D::lineWidth): (WebCore::GraphicsContext3D::linkProgram): (WebCore::GraphicsContext3D::pixelStorei): (WebCore::GraphicsContext3D::polygonOffset): (WebCore::GraphicsContext3D::readPixels): (WebCore::GraphicsContext3D::renderbufferStorage): (WebCore::GraphicsContext3D::sampleCoverage): (WebCore::GraphicsContext3D::scissor): (WebCore::GraphicsContext3D::stencilFunc): (WebCore::GraphicsContext3D::stencilFuncSeparate): (WebCore::GraphicsContext3D::stencilMask): (WebCore::GraphicsContext3D::stencilMaskSeparate): (WebCore::GraphicsContext3D::stencilOp): (WebCore::GraphicsContext3D::stencilOpSeparate): (WebCore::GraphicsContext3D::texParameterf): (WebCore::GraphicsContext3D::texParameteri): (WebCore::GraphicsContext3D::uniform1f): (WebCore::GraphicsContext3D::uniform1fv): (WebCore::GraphicsContext3D::uniform2f): (WebCore::GraphicsContext3D::uniform2fv): (WebCore::GraphicsContext3D::uniform3f): (WebCore::GraphicsContext3D::uniform3fv): (WebCore::GraphicsContext3D::uniform4f): (WebCore::GraphicsContext3D::uniform4fv): (WebCore::GraphicsContext3D::uniform1i): (WebCore::GraphicsContext3D::uniform1iv): (WebCore::GraphicsContext3D::uniform2i): (WebCore::GraphicsContext3D::uniform2iv): (WebCore::GraphicsContext3D::uniform3i): (WebCore::GraphicsContext3D::uniform3iv): (WebCore::GraphicsContext3D::uniform4i): (WebCore::GraphicsContext3D::uniform4iv): (WebCore::GraphicsContext3D::uniformMatrix2fv): (WebCore::GraphicsContext3D::uniformMatrix3fv): (WebCore::GraphicsContext3D::uniformMatrix4fv): (WebCore::GraphicsContext3D::useProgram): (WebCore::GraphicsContext3D::validateProgram): (WebCore::GraphicsContext3D::vertexAttrib1f): (WebCore::GraphicsContext3D::vertexAttrib1fv): (WebCore::GraphicsContext3D::vertexAttrib2f): (WebCore::GraphicsContext3D::vertexAttrib2fv): (WebCore::GraphicsContext3D::vertexAttrib3f): (WebCore::GraphicsContext3D::vertexAttrib3fv): (WebCore::GraphicsContext3D::vertexAttrib4f): (WebCore::GraphicsContext3D::vertexAttrib4fv): (WebCore::GraphicsContext3D::vertexAttribPointer): (WebCore::GraphicsContext3D::viewport): (WebCore::GraphicsContext3D::getBooleanv): (WebCore::GraphicsContext3D::getBufferParameteriv): (WebCore::GraphicsContext3D::getFloatv): (WebCore::GraphicsContext3D::getFramebufferAttachmentParameteriv): (WebCore::GraphicsContext3D::getIntegerv): (WebCore::GraphicsContext3D::getProgramiv): (WebCore::GraphicsContext3D::getProgramInfoLog): (WebCore::GraphicsContext3D::getRenderbufferParameteriv): (WebCore::GraphicsContext3D::getShaderiv): (WebCore::GraphicsContext3D::getShaderInfoLog): (WebCore::GraphicsContext3D::getTexParameterfv): (WebCore::GraphicsContext3D::getTexParameteriv): (WebCore::GraphicsContext3D::getUniformfv): (WebCore::GraphicsContext3D::getUniformiv): (WebCore::GraphicsContext3D::getUniformLocation): (WebCore::GraphicsContext3D::getVertexAttribfv): (WebCore::GraphicsContext3D::getVertexAttribiv): (WebCore::GraphicsContext3D::getVertexAttribOffset): (WebCore::GraphicsContext3D::texImage2D): (WebCore::GraphicsContext3D::texSubImage2D): (WebCore::GraphicsContext3D::createBuffer): (WebCore::GraphicsContext3D::createFramebuffer): (WebCore::GraphicsContext3D::createProgram): (WebCore::GraphicsContext3D::createRenderbuffer): (WebCore::GraphicsContext3D::createShader): (WebCore::GraphicsContext3D::createTexture): (WebCore::GraphicsContext3D::deleteBuffer): (WebCore::GraphicsContext3D::deleteFramebuffer): (WebCore::GraphicsContext3D::deleteProgram): (WebCore::GraphicsContext3D::deleteRenderbuffer): (WebCore::GraphicsContext3D::deleteShader): (WebCore::GraphicsContext3D::deleteTexture): (WebCore::GraphicsContext3D::sizeInBytes): (WebCore::GraphicsContext3D::synthesizeGLError):
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::activeTexture): (WebCore::GraphicsContext3D::attachShader): (WebCore::GraphicsContext3D::getAttachedShaders): (WebCore::GraphicsContext3D::bindAttribLocation): (WebCore::GraphicsContext3D::bindBuffer): (WebCore::GraphicsContext3D::bindFramebuffer): (WebCore::GraphicsContext3D::bindRenderbuffer): (WebCore::GraphicsContext3D::bindTexture): (WebCore::GraphicsContext3D::blendColor): (WebCore::GraphicsContext3D::blendEquation): (WebCore::GraphicsContext3D::blendEquationSeparate): (WebCore::GraphicsContext3D::blendFunc): (WebCore::GraphicsContext3D::blendFuncSeparate): (WebCore::GraphicsContext3D::bufferData): (WebCore::GraphicsContext3D::bufferSubData): (WebCore::GraphicsContext3D::checkFramebufferStatus): (WebCore::GraphicsContext3D::clearColor): (WebCore::GraphicsContext3D::clear): (WebCore::GraphicsContext3D::clearDepth): (WebCore::GraphicsContext3D::clearStencil): (WebCore::GraphicsContext3D::colorMask): (WebCore::GraphicsContext3D::compileShader): (WebCore::GraphicsContext3D::copyTexImage2D): (WebCore::GraphicsContext3D::copyTexSubImage2D): (WebCore::GraphicsContext3D::cullFace): (WebCore::GraphicsContext3D::depthFunc): (WebCore::GraphicsContext3D::depthMask): (WebCore::GraphicsContext3D::depthRange): (WebCore::GraphicsContext3D::detachShader): (WebCore::GraphicsContext3D::disable): (WebCore::GraphicsContext3D::disableVertexAttribArray): (WebCore::GraphicsContext3D::drawArrays): (WebCore::GraphicsContext3D::drawElements): (WebCore::GraphicsContext3D::enable): (WebCore::GraphicsContext3D::enableVertexAttribArray): (WebCore::GraphicsContext3D::framebufferRenderbuffer): (WebCore::GraphicsContext3D::framebufferTexture2D): (WebCore::GraphicsContext3D::frontFace): (WebCore::GraphicsContext3D::generateMipmap): (WebCore::GraphicsContext3D::getActiveAttrib): (WebCore::GraphicsContext3D::getActiveUniform): (WebCore::GraphicsContext3D::getAttribLocation): (WebCore::GraphicsContext3D::getError): (WebCore::GraphicsContext3D::getString): (WebCore::GraphicsContext3D::hint): (WebCore::GraphicsContext3D::isBuffer): (WebCore::GraphicsContext3D::isEnabled): (WebCore::GraphicsContext3D::isFramebuffer): (WebCore::GraphicsContext3D::isProgram): (WebCore::GraphicsContext3D::isRenderbuffer): (WebCore::GraphicsContext3D::isShader): (WebCore::GraphicsContext3D::isTexture): (WebCore::GraphicsContext3D::linkProgram): (WebCore::GraphicsContext3D::pixelStorei): (WebCore::GraphicsContext3D::polygonOffset): (WebCore::GraphicsContext3D::readPixels): (WebCore::GraphicsContext3D::renderbufferStorage): (WebCore::GraphicsContext3D::sampleCoverage): (WebCore::GraphicsContext3D::scissor): (WebCore::GraphicsContext3D::stencilFunc): (WebCore::GraphicsContext3D::stencilFuncSeparate): (WebCore::GraphicsContext3D::stencilMask): (WebCore::GraphicsContext3D::stencilMaskSeparate): (WebCore::GraphicsContext3D::stencilOp): (WebCore::GraphicsContext3D::stencilOpSeparate): (WebCore::GraphicsContext3D::texParameterf): (WebCore::GraphicsContext3D::texParameteri): (WebCore::GraphicsContext3D::uniform1f): (WebCore::GraphicsContext3D::uniform1fv): (WebCore::GraphicsContext3D::uniform2f): (WebCore::GraphicsContext3D::uniform2fv): (WebCore::GraphicsContext3D::uniform3f): (WebCore::GraphicsContext3D::uniform3fv): (WebCore::GraphicsContext3D::uniform4f): (WebCore::GraphicsContext3D::uniform4fv): (WebCore::GraphicsContext3D::uniform1i): (WebCore::GraphicsContext3D::uniform1iv): (WebCore::GraphicsContext3D::uniform2i): (WebCore::GraphicsContext3D::uniform2iv): (WebCore::GraphicsContext3D::uniform3i): (WebCore::GraphicsContext3D::uniform3iv): (WebCore::GraphicsContext3D::uniform4i): (WebCore::GraphicsContext3D::uniform4iv): (WebCore::GraphicsContext3D::uniformMatrix2fv): (WebCore::GraphicsContext3D::uniformMatrix3fv): (WebCore::GraphicsContext3D::uniformMatrix4fv): (WebCore::GraphicsContext3D::useProgram): (WebCore::GraphicsContext3D::validateProgram): (WebCore::GraphicsContext3D::vertexAttrib1f): (WebCore::GraphicsContext3D::vertexAttrib1fv): (WebCore::GraphicsContext3D::vertexAttrib2f): (WebCore::GraphicsContext3D::vertexAttrib2fv): (WebCore::GraphicsContext3D::vertexAttrib3f): (WebCore::GraphicsContext3D::vertexAttrib3fv): (WebCore::GraphicsContext3D::vertexAttrib4f): (WebCore::GraphicsContext3D::vertexAttrib4fv): (WebCore::GraphicsContext3D::vertexAttribPointer): (WebCore::GraphicsContext3D::viewport): (WebCore::GraphicsContext3D::getBooleanv): (WebCore::GraphicsContext3D::getBufferParameteriv): (WebCore::GraphicsContext3D::getFloatv): (WebCore::GraphicsContext3D::getFramebufferAttachmentParameteriv): (WebCore::GraphicsContext3D::getIntegerv): (WebCore::GraphicsContext3D::getProgramiv): (WebCore::GraphicsContext3D::getProgramInfoLog): (WebCore::GraphicsContext3D::getRenderbufferParameteriv): (WebCore::GraphicsContext3D::getShaderiv): (WebCore::GraphicsContext3D::getShaderInfoLog): (WebCore::GraphicsContext3D::getShaderSource): (WebCore::GraphicsContext3D::getTexParameterfv): (WebCore::GraphicsContext3D::getTexParameteriv): (WebCore::GraphicsContext3D::getUniformfv): (WebCore::GraphicsContext3D::getUniformiv): (WebCore::GraphicsContext3D::getUniformLocation): (WebCore::GraphicsContext3D::getVertexAttribfv): (WebCore::GraphicsContext3D::getVertexAttribiv): (WebCore::GraphicsContext3D::getVertexAttribOffset): (WebCore::GraphicsContext3D::texImage2D): (WebCore::GraphicsContext3D::texSubImage2D): (WebCore::GraphicsContext3D::createBuffer): (WebCore::GraphicsContext3D::createFramebuffer): (WebCore::GraphicsContext3D::createProgram): (WebCore::GraphicsContext3D::createRenderbuffer): (WebCore::GraphicsContext3D::createShader): (WebCore::GraphicsContext3D::createTexture): (WebCore::GraphicsContext3D::deleteBuffer): (WebCore::GraphicsContext3D::deleteFramebuffer): (WebCore::GraphicsContext3D::deleteProgram): (WebCore::GraphicsContext3D::deleteRenderbuffer): (WebCore::GraphicsContext3D::deleteShader): (WebCore::GraphicsContext3D::deleteTexture): (WebCore::GraphicsContext3D::sizeInBytes): (WebCore::GraphicsContext3D::synthesizeGLError): (WebCore::GraphicsContext3D::getImageData):
  • platform/graphics/skia/GraphicsContext3DSkia.cpp: (WebCore::GraphicsContext3D::getImageData):
5:03 PM Changeset in webkit [75213] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-06 Stephen White <​senorblanco@chromium.org>

Unreviewed; chromium test expectations update.

  • platform/chromium/test_expectations.txt: Add some expected "failing" tests post-r75205.
4:47 PM Changeset in webkit [75212] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-06 Stephen White <​senorblanco@chromium.org>

Unreviewed; chromium test expectations update.

  • platform/chromium/test_expectations.txt: Remove duplicate expectations.
4:39 PM Changeset in webkit [75211] by sfalken@apple.com
  • 2 edits in trunk/Tools

2011-01-06 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Stephanie Lewis.


Fix syntax error in script.

Windows bots need to archive/unarchive builds to/from configuration-specific directories
​https://bugs.webkit.org/show_bug.cgi?id=51996

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
4:38 PM Changeset in webkit [75210] by barraclough@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Bug 52021 - zeroDouble broken on ARMv7

Reviewed by Darin Adler.

The bug here is that zeroDouble was working incorrectly,
leading to op_loop_if_true failing - specifically in the
case where the value being checked is 0.0 encoded as a
double (rather than an integer immediate).

Additionally this patch removes a redundant duplicate compare
in some (many) case.

  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::vcmp_F64):
(JSC::ARMv7Assembler::vcmpz_F64):

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::branchDoubleNonZero):
(JSC::MacroAssemblerARM::branchDoubleZeroOrNaN):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::branchDouble):
(JSC::MacroAssemblerARMv7::branchDoubleNonZero):
(JSC::MacroAssemblerARMv7::branchDoubleZeroOrNaN):
(JSC::MacroAssemblerARMv7::compare32):

  • assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::branchDoubleNonZero):
(JSC::MacroAssemblerMIPS::branchDoubleZeroOrNaN):

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::branchDoubleNonZero):
(JSC::MacroAssemblerX86Common::branchDoubleZeroOrNaN):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_jfalse):
(JSC::JIT::emit_op_jtrue):

4:24 PM Changeset in webkit [75209] by Martin Robinson
  • 5 edits in trunk

2011-01-06 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] Initial build support for WebGL
​https://bugs.webkit.org/show_bug.cgi?id=51716

  • configure.ac: Add a configure option for WebGL.

2011-01-06 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] Initial build support for WebGL
​https://bugs.webkit.org/show_bug.cgi?id=51716

Add initial build support for WebGL and insert bits of implementation
necessary for clean compilation into GraphicsContext3D.

No new tests. This is just a build change.

  • GNUmakefile.am: Add missing files to the source lists.
  • platform/graphics/GraphicsContext3D.h: Include IntSize.h as it's used below. Include typedefs necessary for WebGL on GTK+ and consolidate typdefs which are the same across different platforms. X11 headers define the VERSION symbol, so it's necessary to undefine it, since it's used as an enum value.
4:17 PM Changeset in webkit [75208] by msaboff@apple.com
  • 5 edits in trunk

2011-01-06 Michael Saboff <​msaboff@apple.com>

Reviewed by Gavin Barraclough.

Enhancement: Add Regexp Debug Compare between JIT and Interpreter
​https://bugs.webkit.org/show_bug.cgi?id=51834

2011-01-06 Michael Saboff <​msaboff@apple.com>

Reviewed by Gavin Barraclough.

Added debug code to compare the results of JIT regexp with
interpreted regexp and displays discrepencies. This debug code is
controlled by the ENABLE_YARR_JIT_DEBUG macro in wtf/Platform.h and
is only valid if ENABLE_YARR_JIT is enabled.

Fixed a discovered problem in RegExp::printTraceData, changing
m_pattern to the getter pattern().
Also deleted an extraneous semicolon.

Enhancement: Add Regexp Debug Compare between JIT and Interpreter
​https://bugs.webkit.org/show_bug.cgi?id=51834

  • runtime/RegExp.cpp: (JSC::RegExp::compile): (JSC::RegExp::match): (JSC::RegExp::printTraceData):
  • wtf/Platform.h:
4:08 PM Changeset in webkit [75207] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2011-01-06 Helder Correia <​helder@sencha.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] GraphicsContext::drawConvexPolygon() has unnecessary code for shadow
​https://bugs.webkit.org/show_bug.cgi?id=52014

The function is only used by RenderObject to draw box sides.
The shadow branch is never used and thus can be removed.

No new tests are necessary.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawConvexPolygon):
3:39 PM Changeset in webkit [75206] by Laszlo Gombos
  • 2 edits in trunk/WebCore

2011-01-06 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Make sure touch is disabled in the minimal configuration
​https://bugs.webkit.org/show_bug.cgi?id=51316

No new tests as there is no new functionality.

  • features.pri:
3:29 PM Changeset in webkit [75205] by Adam Roben
  • 2 edits
    5 adds in trunk/LayoutTests

Add/update Windows-specific test results for recent regressions

Bugs:

​http://webkit.org/b/52026
​http://webkit.org/b/52028
​http://webkit.org/b/52029

  • platform/win/animations/animation-time-expected.txt: Added.
  • platform/win/fast/canvas/canvas-fillRect-gradient-shadow-expected.txt: Added.
  • platform/win/fast/css/css3-nth-tokens-script-expected.txt: Added.
  • platform/win/fast/css/css3-nth-tokens-style-expected.txt: Added.
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
3:29 PM Changeset in webkit [75204] by Adam Roben
  • 2 edits in trunk/LayoutTests

Update Windows results after r75177

  • platform/win/fast/dom/prototype-inheritance-expected.txt:
3:07 PM Changeset in webkit [75203] by Laszlo Gombos
  • 2 edits in trunk/Tools

2011-01-06 Laszlo Gombos <Laszlo Gombos>

Unreviewed, fixing WinCE build after r75196.

WinCE port does not (yet) support NPAPI.

  • Scripts/build-webkit:
2:55 PM Changeset in webkit [75202] by Martin Robinson
  • 6 edits
    3 adds in trunk

2011-01-06 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] Freetype backend does not support WOFF
​https://bugs.webkit.org/show_bug.cgi?id=51904

  • platform/gtk/Skipped: Unskip passing WOFF test. Add results.
  • platform/gtk/fast/css/font-face-woff-expected.checksum: Added.
  • platform/gtk/fast/css/font-face-woff-expected.png: Added.
  • platform/gtk/fast/css/font-face-woff-expected.txt: Added.

2011-01-06 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] Freetype backend does not support WOFF
​https://bugs.webkit.org/show_bug.cgi?id=51904

  • CMakeListsEfl.txt: Add WOFF support to the sources list.
  • GNUmakefile.am: Add WOFF support to the sources list.
  • platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp: (WebCore::createFontCustomPlatformData): Call the WOFF decoder when appropriate. (WebCore::FontCustomPlatformData::supportsFormat): Advertise support for WOFF.
2:51 PM Changeset in webkit [75201] by Martin Robinson
  • 3 edits in trunk/WebKit/gtk

2011-01-06 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

GTK: AX: atk tests need to be updated after recent changes
​https://bugs.webkit.org/show_bug.cgi?id=51932

Skip ATK unit tests until we can look into what is causing these failures.

  • tests/testatk.c: (main): Skip all tests.
  • tests/testatkroles.c: (main): Ditto.
2:39 PM Changeset in webkit [75200] by simonjam@chromium.org
  • 23 edits in trunk

2011-01-06 James Simonsen <​simonjam@chromium.org>

Reviewed by Darin Fisher.

[Web Timing] Remove vendor prefix
​https://bugs.webkit.org/show_bug.cgi?id=48922

  • fast/dom/Window/window-properties-performance-expected.txt: Test replaceability.
  • fast/dom/Window/window-properties-performance.html: Ditto.
  • fast/dom/Window/window-properties.html: Rename to performance.
  • fast/dom/resources/navigation-type-matches-querystring.html: Ditto.
  • fast/dom/script-tests/prototype-inheritance.js: Ditto.
  • fast/dom/script-tests/webtiming-document-open.js: Ditto.
  • fast/dom/script-tests/webtiming-navigate-within-document.js: Ditto.
  • fast/dom/script-tests/webtiming.js: Ditto.
  • http/tests/misc/resources/webtiming-one-redirect.html: Ditto.
  • http/tests/misc/resources/webtiming-two-redirects.html: Ditto.

2011-01-06 James Simonsen <​simonjam@chromium.org>

Reviewed by Darin Fisher.

[Web Timing] Remove vendor prefix
​https://bugs.webkit.org/show_bug.cgi?id=48922

  • page/DOMWindow.cpp: (WebCore::DOMWindow::performance): Rename to performance.
  • page/DOMWindow.h:
  • page/DOMWindow.idl: Rename to performance and make replaceable.

2011-01-06 James Simonsen <​simonjam@chromium.org>

Reviewed by Darin Fisher.

[Web Timing] Remove vendor prefix
​https://bugs.webkit.org/show_bug.cgi?id=48922

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::performance): Rename to performance.
2:26 PM Changeset in webkit [75199] by cmarrin@apple.com
  • 15 edits
    1 add in trunk/WebCore

2011-01-06 Chris Marrin <​cmarrin@apple.com>

Reviewed by Simon Fraser.

Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
​https://bugs.webkit.org/show_bug.cgi?id=49388

Changed PlatformCALayer API. Added PlatformCALayerClient abstract class which is
used to communicate from PlatformCALayer to the owner. This replaces passing
GraphicsLayerCA pointer when creating PlatformCALayer. It also includes the
API that used to be in PlatformCALayerLayout. GraphicsLayerCA now implements
the PlatformCALayerClient API.

This change has little impact on the Mac side but makes the Windows
interface simpler, especially when handling video layers on Windows.

  • WebCore.xcodeproj/project.pbxproj:
  • config.h:
  • platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::layerDidDisplay): (WebCore::GraphicsLayer::showDebugBorders): (WebCore::GraphicsLayer::showRepaintCounter):
  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::platformCALayerAnimationStarted): (WebCore::GraphicsLayerCA::setContentsToImage): (WebCore::GraphicsLayerCA::setContentsToMedia): (WebCore::GraphicsLayerCA::layerDidDisplay): (WebCore::GraphicsLayerCA::updateSublayerList):
  • platform/graphics/ca/GraphicsLayerCA.h: (WebCore::GraphicsLayerCA::platformCALayerLayoutSublayersOfLayer): (WebCore::GraphicsLayerCA::platformCALayerRespondsToLayoutChanges): (WebCore::GraphicsLayerCA::platformCALayerContentsOrientation): (WebCore::GraphicsLayerCA::platformCALayerPaintContents): (WebCore::GraphicsLayerCA::platformCALayerShowDebugBorders): (WebCore::GraphicsLayerCA::platformCALayerShowRepaintCounter): (WebCore::GraphicsLayerCA::platformCALayerIncrementRepaintCount): (WebCore::GraphicsLayerCA::platformCALayerContentsOpaque): (WebCore::GraphicsLayerCA::platformCALayerDrawsContent): (WebCore::GraphicsLayerCA::platformCALayerLayerDidDisplay): (WebCore::GraphicsLayerCA::platformCALayer):
  • platform/graphics/ca/PlatformCALayer.h: (WebCore::PlatformCALayer::owner): (WebCore::PlatformCALayer::animationStarted):
  • platform/graphics/ca/PlatformCALayerClient.h: Added. (WebCore::PlatformCALayerClient::~PlatformCALayerClient):
  • platform/graphics/ca/mac/PlatformCALayerMac.mm: (PlatformCALayer::setOwner): (PlatformCALayer::create): (PlatformCALayer::PlatformCALayer): (PlatformCALayer::contents): (PlatformCALayer::setContents):
  • platform/graphics/mac/WebGLLayer.mm: (-[WebGLLayer display]):
  • platform/graphics/mac/WebLayer.h:
  • platform/graphics/mac/WebLayer.mm: (drawLayerContents): (setLayerNeedsDisplayInRect): (-[WebLayer setNeedsDisplay]): (-[WebLayer display]):
  • platform/graphics/mac/WebTiledLayer.mm: (-[WebTiledLayer setNeedsDisplay]): (-[WebTiledLayer display]):
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::showDebugBorders): (WebCore::RenderLayerBacking::showRepaintCounter):
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::ensureRootPlatformLayer):
  • rendering/RenderLayerCompositor.h: (WebCore::RenderLayerCompositor::compositorShowDebugBorders): (WebCore::RenderLayerCompositor::compositorShowRepaintCounter): (WebCore::RenderLayerCompositor::notifyAnimationStarted): (WebCore::RenderLayerCompositor::notifySyncRequired): (WebCore::RenderLayerCompositor::paintContents): (WebCore::RenderLayerCompositor::showDebugBorders): (WebCore::RenderLayerCompositor::showRepaintCounter):
2:07 PM Changeset in webkit [75198] by tonyg@chromium.org
  • 4 edits in trunk

2011-01-06 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Eric Seidel.

Allow framesets after hidden inputs
​https://bugs.webkit.org/show_bug.cgi?id=51998

  • html5lib/resources/webkit01.dat: Demonstrate that the value of the type attribute matters. An input with no type is tested in tests19.dat.

2011-01-06 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Eric Seidel.

Allow framesets after hidden inputs
​https://bugs.webkit.org/show_bug.cgi?id=51998

This implements the HTML5 spec update in response to:
​http://www.w3.org/Bugs/Public/show_bug.cgi?id=11156

  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInBody):
2:01 PM Changeset in webkit [75197] by xan@webkit.org
  • 2 edits in trunk/Tools

2011-01-06 Xan Lopez <​xlopez@igalia.com>

Reviewed by Darin Adler.

File::Spec->rel2abs in sunspider-compare-results mangles parameters
​https://bugs.webkit.org/show_bug.cgi?id=52015

  • Scripts/sunspider-compare-results: call rel2abs on our arguments after the platform has been detected, otherwise the script will mangle things like '--gtk' into '/a/path/--gtk', breaking the detection.
1:49 PM Changeset in webkit [75196] by Laszlo Gombos
  • 2 edits in trunk/Tools

2011-01-06 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
​https://bugs.webkit.org/show_bug.cgi?id=51346

  • Scripts/build-webkit:
1:49 PM Changeset in webkit [75195] by zmo@google.com
  • 5 edits in trunk

2010-12-29 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

vertexAttribPointer should raise INVALID_OPERATION if stride/offset is not multiple of the type size
​https://bugs.webkit.org/show_bug.cgi?id=51725

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::vertexAttribPointer):

2010-12-29 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

vertexAttribPointer should raise INVALID_OPERATION if stride/offset is not multiple of the type size
​https://bugs.webkit.org/show_bug.cgi?id=51725

  • fast/canvas/webgl/gl-vertexattribpointer-expected.txt:
  • fast/canvas/webgl/gl-vertexattribpointer.html: Sync with khronos.
1:42 PM Changeset in webkit [75194] by zmo@google.com
  • 3 edits in trunk/LayoutTests

2011-01-06 Zhenyao Mo <​zmo@google.com>

Unreviewed, add glsl-conformance.html to test_expectations.txt temporarily.

  • platform/chromium-gpu/test_expectations.txt:
  • platform/chromium/test_expectations.txt:
1:41 PM Changeset in webkit [75193] by inferno@chromium.org
  • 2 edits
    4 copies in branches/chromium/552

Merge 75168

BUG=68558

1:32 PM Changeset in webkit [75192] by sfalken@apple.com
  • 3 edits in trunk/Tools

2011-01-06 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam Roben.

Windows bots need to archive/unarchive builds to/from configuration-specific directories
​https://bugs.webkit.org/show_bug.cgi?id=51996


After the configuration directory change, we were archiving the incorrect directory for
build product, so we were running tests on the wrong binaries.


This change archives the correct directory, and also unarchives it into a configuration-
specific directory.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
  • BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
1:30 PM Changeset in webkit [75191] by eric@webkit.org
  • 4 edits in trunk/Tools

2011-01-06 Eric Seidel <​eric@webkit.org>

Reviewed by Mihai Parparita.

commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
​https://bugs.webkit.org/show_bug.cgi?id=52002

See an example of this here:
​https://bugs.webkit.org/show_bug.cgi?id=51314#c2

It's due to the fact that we pass around TestFailure() instance
objects and yet expect them to all compare to be the same.

This is bad. We should either have shared instances of these values
or we should just pass around the class names. There are already hacks
in place to make TestFailure objects pass equality tests, I just added
a hash implementation so they can be used in sets as expected.

  • Scripts/webkitpy/common/net/layouttestresults_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1:19 PM Changeset in webkit [75190] by Patrick Gansterer
  • 4 edits in trunk

2011-01-06 Patrick Gansterer <Patrick Gansterer>

Reviewed by Eric Seidel.

[WINCE] Remove JSC::g_stackBase
​https://bugs.webkit.org/show_bug.cgi?id=51779

  • wtf/StackBounds.cpp:

2011-01-06 Patrick Gansterer <Patrick Gansterer>

Reviewed by Eric Seidel.

[WINCE] Remove JSC::g_stackBase
​https://bugs.webkit.org/show_bug.cgi?id=51779

  • platform/wince/SharedTimerWinCE.cpp: (WebCore::TimerWindowWndProc):
12:54 PM Changeset in webkit [75189] by robert@webkit.org
  • 13 edits in trunk

2011-01-06 Robert Hogan <​robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Introduce QDRTNode for passing WebCore::Node across JS bridge

This allows LayoutTestController to pass WebCore::Node back to
layout tests.

Also amend nodesFromRect-links-and-text.html and
nodesFromRect-inner-documents.html so that they do not produce
platform-specific results.

Unskip:
fast/dom/nodesFromRect-links-and-text.html
fast/dom/nodesFromRect-inner-documents.html

​https://bugs.webkit.org/show_bug.cgi?id=48957

  • fast/dom/nodesFromRect-inner-documents-expected.txt:
  • fast/dom/nodesFromRect-inner-documents.html:
  • fast/dom/nodesFromRect-links-and-text-expected.txt:
  • fast/dom/nodesFromRect-links-and-text.html:
  • fast/dom/resources/nodesFromRect.js: (check): (getTopFor): (getBottomFor):
  • platform/qt/Skipped:

2011-01-06 Robert Hogan <​robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Introduce QDRTNode for passing WebCore::Node across JS bridge

This allows LayoutTestController to pass WebCore::Node back to
layout tests.

Also amend nodesFromRect-links-and-text.html and
nodesFromRect-inner-documents.html so that they do not produce
platform-specific results.

Unskip:
fast/dom/nodesFromRect-links-and-text.html
fast/dom/nodesFromRect-inner-documents.html

​https://bugs.webkit.org/show_bug.cgi?id=48957

  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtDRTNodeRuntime::create): (JSC::Bindings::QtDRTNodeRuntime::get): (JSC::Bindings::convertValueToQVariant): (JSC::Bindings::convertQVariantToValue):

2011-01-06 Robert Hogan <​robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Introduce QDRTNode for passing WebCore::Node across JS bridge

This allows LayoutTestController to pass WebCore::Node back to
layout tests.

Also amend nodesFromRect-links-and-text.html and
nodesFromRect-inner-documents.html so that they do not produce
platform-specific results.

Unskip:
fast/dom/nodesFromRect-links-and-text.html
fast/dom/nodesFromRect-inner-documents.html

​https://bugs.webkit.org/show_bug.cgi?id=48957

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (QDRTNode::QDRTNode): (QDRTNode::~QDRTNode): (DumpRenderTreeSupportQt::nodesFromRect):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:
12:53 PM Changeset in webkit [75188] by commit-queue@webkit.org
  • 8 edits in trunk

2011-01-06 Joone Hur <​joone.hur@collabora.co.uk>

Reviewed by Eric Seidel.

WML Parser should treat line/column number in a consistent way
​https://bugs.webkit.org/show_bug.cgi?id=51601

Add the equality operators to TextPosition class.

  • wtf/text/TextPosition.h: (WTF::TextPosition::operator==): Added. (WTF::TextPosition::operator!=): Added. (WTF::TextPosition::belowRangePosition): Use belowBase() instead of base(). (WTF::ZeroBasedNumber::operator==): Added. (WTF::ZeroBasedNumber::operator!=): Added. (WTF::OneBasedNumber::operator==): Added. (WTF::OneBasedNumber::operator!=): Added.

2011-01-06 Joone Hur <​joone.hur@collabora.co.uk>

Reviewed by Eric Seidel.

WML Parser should treat line/column number in a consistent way
​https://bugs.webkit.org/show_bug.cgi?id=51601

XML Parser treats line/column number as 1-based values, but WML ErrorHandler treat them as 0-based.
Therefore, this patch allows WML ErrorHandler to use 1-based values.

  • dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::handleError): Treat line/column number as 1 based values.
  • dom/XMLDocumentParser.h: Make textPositionOneBased public and Add TextPosition1(m_lastErrorPosition) to keep error line/column number.
  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::XMLDocumentParser): Initialize m_lastErrorPosition.
  • dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::XMLDocumentParser): Initialize m_lastErrorPosition.
  • wml/WMLErrorHandling.cpp: (WebCore::reportWMLError): Use 1 based value instead of 0 based value to report error line/column number.
12:49 PM Changeset in webkit [75187] by Adam Roben
  • 2 edits in trunk/WebKit2

Always show the arrow cursor when the web process has crashed

Fixes <​http://webkit.org/b/52006> WKView shows a stale cursor when the
web process crashes

Reviewed by Ada Chan.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::processDidCrash):
(WebKit::WebView::didRelaunchProcess):
Update the cursor to reflect the new state.

(WebKit::WebView::cursorToShow): Always show the arrow cursor when the
web process has crashed.

12:49 PM Changeset in webkit [75186] by Adam Roben
  • 3 edits in trunk/WebKit2

Reduce code duplication in WebView::updateNativeCursor

Fixes <​http://webkit.org/b/52005> It's not easy to add new behavior to
WebView::updateNativeCursor

Reviewed by Ada Chan.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::cursorToShow): Moved code to choose a cursor here...
(WebKit::WebView::updateNativeCursor): ...from here.

  • UIProcess/win/WebView.h: Added cursorToShow.
12:48 PM Changeset in webkit [75185] by Adam Roben
  • 2 edits in trunk/WebKit2

Make WKView fill with white when the web process has crashed

Previously we would just draw whatever we had last drawn into the
WKView (i.e., a stale picture of the web page), which was confusing
(because the web page would mysteriously not respond to input) and ugly
(because it wouldn't behave properly if the window was resized).

Fixes <​http://webkit.org/b/52004> WKView keeps painting a stale
picture of the web page when the web process crashes

Reviewed by Ada Chan.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::onPaintEvent): Ported code from -[WKView drawRect:]
to fill with white if the page is invalid or has no DrawingArea. As a
bonus, also ported the call to WebPageProxy::didDraw from that method.

(WebKit::WebView::processDidCrash):
(WebKit::WebView::didRelaunchProcess):
Invalidate our window so that we'll redraw with white or the new page.

12:48 PM Changeset in webkit [75184] by Adam Roben
  • 2 edits in trunk/WebKit2

Make WKViews work on Windows after a crashed web process gets relaunched

Fixes <​http://webkit.org/b/52001> Relaunching the web process fails to
revivify WKViews on Windows

Reviewed by Ada Chan.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::didRelaunchProcess): Implemented by porting code from
-[WKView _didRelaunchProcess].

12:47 PM Changeset in webkit [75183] by Adam Roben
  • 3 edits in trunk/WebKit2

Remove WebView::m_rect

It was only used in the constructor, and wasn't even kept up-to-date as
the WebView's size changed.

Fixes <​http://webkit.org/b/52000> WebView::m_rect is unnecessary

Reviewed by Ada Chan.

  • UIProcess/win/WebView.cpp:
  • UIProcess/win/WebView.h:
12:46 PM Changeset in webkit [75182] by Adam Roben
  • 3 edits in trunk/WebCore

Remove some dead code from WKCACFLayerRenderer

Fixes <​http://webkit.org/b/51954> WKCACFLayerRenderer has dead and
redundant code for reacting to changes to the layer tree

Reviewed by Sam Weinig.

  • platform/graphics/win/WKCACFLayerRenderer.cpp:
  • platform/graphics/win/WKCACFLayerRenderer.h:

Removed didFlushContext and the HashMap it depended on. We react to
changes to the layer tree in layerTreeDidChange instead.

12:44 PM Changeset in webkit [75181] by senorblanco@chromium.org
  • 3 edits in trunk/LayoutTests

2011-01-06 Stephen White <​senorblanco@chromium.org>

Unreviewed; test expectations update.

Update test_expectations.txt files to reflect reality on the canaries.

  • platform/chromium-gpu/test_expectations.txt:
  • platform/chromium/test_expectations.txt:
12:39 PM Changeset in webkit [75180] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-06 Patrick Gansterer <Patrick Gansterer>

Reviewed by Gavin Barraclough.

[WINCE] Determine stack extent
​https://bugs.webkit.org/show_bug.cgi?id=26276

Scan the stack for writeable pages and use the limits.

  • wtf/StackBounds.cpp: (WTF::detectGrowingDownward): (WTF::isPageWritable): (WTF::getLowerStackBound): (WTF::getUpperStackBound): (WTF::StackBounds::initialize):
12:39 PM Changeset in webkit [75179] by Chris Fleizach
  • 7 edits
    2 adds in trunk

AX: "AXExpanded" not exposed on most ARIA roles that use aria-expanded
​https://bugs.webkit.org/show_bug.cgi?id=51995

Reviewed by Beth Dakin.

WebCore:

Test: platform/mac/accessibility/aria-expanded-standard-items.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::supportsARIAExpanded):
(WebCore::AccessibilityObject::isExpanded):

  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isVisited):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):

LayoutTests:

  • platform/mac/accessibility/aria-expanded-standard-items-expected.txt: Added.
  • platform/mac/accessibility/aria-expanded-standard-items.html: Added.
12:34 PM Changeset in webkit [75178] by evan@chromium.org
  • 2 edits in trunk/Tools

2011-01-06 Evan Martin <​evan@chromium.org>

Reviewed by Tony Chang.

[gdb] handle inaccessible memory and UChar*
​https://bugs.webkit.org/show_bug.cgi?id=52003

To pretty-print a UChar*, we just grope around in the memory
looking for a terminating NUL. We need to handle the exception
that can occur when we poke into an invalid location.

Additionally, the logic for choosing which pretty-printer would
early return before hitting the point where we'd use the UChar*
printer. (Did this ever work? How did it regress?)

  • gdb/webkit.py:
12:28 PM Changeset in webkit [75177] by abarth@webkit.org
  • 3 edits in trunk/LayoutTests

2011-01-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

prototype-inheritance prints FAIL when it shouldn't
​https://bugs.webkit.org/show_bug.cgi?id=52007

Before this patch, we were testing the prototypes of primitive values,
but the rules for primitive values are different than the rules for
objects. Primitive values get their prototypes from the current
lexical scope when they get boxed. This test is designed to test that
objects get their prototypes from their original holder.

In this patch, we skip testing non-object/non-functions. We can add
another test for primitives if we think that would be valuable.

  • fast/dom/prototype-inheritance-expected.txt:
  • fast/dom/script-tests/prototype-inheritance.js:
12:20 PM Changeset in webkit [75176] by jamesr@google.com
  • 8 edits in trunk/LayoutTests

2011-01-06 James Robinson <​jamesr@chromium.org>

Update expectations for tests that enumerate properties on the window to reflect newly added property.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
11:33 AM Changeset in webkit [75175] by zmo@google.com
  • 6 edits in trunk

2010-12-28 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

Must generate INVALID_VALUE errors for strings containing out-of-range characters
​https://bugs.webkit.org/show_bug.cgi?id=50929

  • html/canvas/WebGLRenderingContext.cpp: Validate characters according to GLSL ES 1.0 spec section 3.1. (WebCore::WebGLRenderingContext::bindAttribLocation): (WebCore::WebGLRenderingContext::getAttribLocation): (WebCore::WebGLRenderingContext::getUniformLocation): (WebCore::WebGLRenderingContext::shaderSource): (WebCore::WebGLRenderingContext::validateString): Helper function to perform the character validation.
  • html/canvas/WebGLRenderingContext.h: Declare validateString().

2010-12-28 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

Must generate INVALID_VALUE errors for strings containing out-of-range characters
​https://bugs.webkit.org/show_bug.cgi?id=50929

  • fast/canvas/webgl/invalid-passed-params-expected.txt: Add test cases for invalid characters.
  • fast/canvas/webgl/invalid-passed-params.html: Ditto.
11:27 AM Changeset in webkit [75174] by bweinstein@apple.com
  • 8 edits in trunk

WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
​https://bugs.webkit.org/show_bug.cgi?id=51969

Reviewed by Ada Chan.

Tools:

Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:

WebKit2:

Add the ability to call into the injected bundle to ask if we should allow resource loads.
If the injected bundle says we should cancel, we clear out the ResourceRequest that was
passed into willSendRequest, which cancels the resource load.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h: Add the new callback for allowing/cancelling

resource loads.

  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::shouldLoadResourceForFrame): Calls through to the client.

  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchWillSendRequest): Ask the InjectedBundlePageLoaderClient if we

should load the resource or not.

11:23 AM Changeset in webkit [75173] by inferno@chromium.org
  • 3 edits in trunk/LayoutTests

2011-01-06 Abhishek Arya <​inferno@chromium.org>

Reviewed by Alexey Proskuryakov.

Improve the layouttests from r75168 and make sure that the parent stylesheet value is null
before showing test passed.

  • fast/dom/StyleSheet/removed-media-rule-deleted-parent-crash.html:
  • fast/dom/StyleSheet/removed-stylesheet-rule-deleted-parent-crash.html:
11:14 AM Changeset in webkit [75172] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/WebCore

2011-01-06 Yong Li <​yoli@rim.com>

Reviewed by Adam Barth.
Add the test case that is missed in r75066.
​https://bugs.webkit.org/show_bug.cgi?id=48077

Test case: WebCore/manual-tests/bugzilla-48077.html.

11:08 AM Changeset in webkit [75171] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit2

2011-01-06 Jeff Miller <​jeffm@apple.com>

Reviewed by Darin Adler.

WebKit2: Add APIs to WKBundleFrame to get content bounds and scroll offset
​https://bugs.webkit.org/show_bug.cgi?id=51968

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: (WKBundleFrameGetContentBounds): (WKBundleFrameGetScrollOffset):
  • WebProcess/InjectedBundle/API/c/WKBundleFrame.h: Add WKBundleFrameGetContentBounds() and WKBundleFrameGetScrollOffset().
11:07 AM Changeset in webkit [75170] by Martin Robinson
  • 2 edits in trunk/WebKit/gtk

2011-01-06 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

Include a new header in the static headers list. This is necessary
so that "make install" installs the header.

  • GNUmakefile.am: Include webkitglobals.h in the header list.
11:07 AM Changeset in webkit [75169] by jamesr@google.com
  • 32 edits
    5 adds in trunk

2011-01-06 James Robinson <​jamesr@chromium.org>

Reviewed by Simon Fraser.

Implement mozilla's animationTime property
​https://bugs.webkit.org/show_bug.cgi?id=51952

Tests for window.webkitAnimationTime.

  • animations/animation-time-expected.txt: Added.
  • animations/animation-time.html: Added.
  • animations/script-tests/animation-time.js: Added.

2011-01-06 James Robinson <​jamesr@chromium.org>

Reviewed by Simon Fraser.

Implement mozilla's animationTime property
​https://bugs.webkit.org/show_bug.cgi?id=51952

Chromium DRT support for webkitAnimationTime.

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::paintInvalidatedRegion):

2011-01-06 James Robinson <​jamesr@chromium.org>

Reviewed by Simon Fraser.

Implement mozilla's animationTime property
​https://bugs.webkit.org/show_bug.cgi?id=51952

Implements mozilla's animationTime property as described here:
​https://developer.mozilla.org/en/DOM/window.mozAnimationStartTime
and ​http://hacks.mozilla.org/2010/08/more-efficient-javascript-animations-with-mozrequestanimationframe/
The property is called webkitAnimationTime as calling it the 'Start' time is not very informative.
This property exposes a notion of a 'current' time to use for declarative animations and allows
scripts to synchronize imperative animations with declarative ones if they choose to. Once queried
this time is saved and used for all declarative animation updates until the embedder paints/composites
the next frame and clears it, or 15ms elapse (in case the embedder isn't producing frames, for example
if the page is in a background tab).

This patch also ensures that all declarative animations started in the same script execution block
are synchronized even if some time elapses while script is running.

Test: fast/animation/animation-time.html

  • WebCore.gypi:
  • page/DOMWindow.cpp: (WebCore::DOMWindow::webkitAnimationTime):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:
  • page/Frame.cpp: (WebCore::Frame::currentAnimationTime):
  • page/Frame.h:
  • page/Page.cpp: (WebCore::Page::Page):
  • page/Page.h: (WebCore::Page::animationTime):
  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::beginAnimationUpdateTime):
  • page/animation/AnimationTimeController.cpp: Added. (WebCore::AnimationTimeController::AnimationTimeController): (WebCore::AnimationTimeController::~AnimationTimeController): (WebCore::AnimationTimeController::currentAnimationTime): (WebCore::AnimationTimeController::clearCurrentAnimationTime): (WebCore::AnimationTimeController::clearCurrentAnimationTimeTimerFired):
  • page/animation/AnimationTimeController.h: Added. (WebCore::AnimationTimeController::create):

2011-01-06 James Robinson <​jamesr@chromium.org>

Reviewed by Simon Fraser.

Implement mozilla's animationTime property
​https://bugs.webkit.org/show_bug.cgi?id=51952

WebKit API support for webkitAnimationTime.

  • public/WebWidget.h:
  • src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::clearCurrentAnimationTime):
  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::clearCurrentAnimationTime):
  • src/WebViewImpl.h:

2011-01-06 James Robinson <​jamesr@chromium.org>

Reviewed by Simon Fraser.

Implement mozilla's animationTime property
​https://bugs.webkit.org/show_bug.cgi?id=51952

Tells the page to clear the current animation time after producing a frame.

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::drawRect):
  • WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp: (WebKit::ChunkedUpdateDrawingArea::display): (WebKit::ChunkedUpdateDrawingArea::setSize):
  • WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm: (WebKit::LayerBackedDrawingArea::syncCompositingLayers):
10:52 AM Changeset in webkit [75168] by inferno@chromium.org
  • 4 edits
    4 adds in trunk

2011-01-06 Abhishek Arya <​inferno@chromium.org>

Reviewed by Simon Fraser.

Null out the parent stylesheet pointer when a css rule is removed.
​https://bugs.webkit.org/show_bug.cgi?id=51993

Tests: fast/dom/StyleSheet/removed-media-rule-deleted-parent-crash.html

fast/dom/StyleSheet/removed-stylesheet-rule-deleted-parent-crash.html

  • css/CSSRuleList.cpp: (WebCore::CSSRuleList::deleteRule):
  • css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::deleteRule):

2011-01-06 Abhishek Arya <​inferno@chromium.org>

Reviewed by Simon Fraser.

Tests that we do not crash when accessing a deleted parent stylesheet
from a removed css rule.
​https://bugs.webkit.org/show_bug.cgi?id=51993

  • fast/dom/StyleSheet/removed-media-rule-deleted-parent-crash-expected.txt: Added.
  • fast/dom/StyleSheet/removed-media-rule-deleted-parent-crash.html: Added.
  • fast/dom/StyleSheet/removed-stylesheet-rule-deleted-parent-crash-expected.txt: Added.
  • fast/dom/StyleSheet/removed-stylesheet-rule-deleted-parent-crash.html: Added.
10:47 AM Changeset in webkit [75167] by enne@google.com
  • 6 edits in trunk

2011-01-04 Adrienne Walker <​enne@google.com>

Reviewed by Kenneth Russell.

Add test cases for storing NaN in typed arrays.
​https://bugs.webkit.org/show_bug.cgi?id=46990

  • fast/canvas/webgl/array-unit-tests-expected.txt:
  • fast/canvas/webgl/array-unit-tests.html:

2011-01-04 Adrienne Walker <​enne@google.com>

Reviewed by Kenneth Russell.

NaN in a TypedArray should be converted to zero only for Float32Array.
​https://bugs.webkit.org/show_bug.cgi?id=46990

Test: LayoutTests/fast/canvas/webgl/array-unit-tests.html

  • bindings/js/JSArrayBufferViewHelper.h: (WebCore::convertArrayValue): (WebCore::constructArrayBufferView):
  • html/canvas/Float32Array.h: (WebCore::Float32Array::set): (WebCore::Float32Array::item):
10:42 AM Changeset in webkit [75166] by jparent@chromium.org
  • 3 edits in trunk/Tools

2011-01-06 Julie Parent <​jparent@chromium.org>

Reviewed by Tony Chang.

Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
​https://bugs.webkit.org/show_bug.cgi?id=51217

  • TestResultServer/model/jsonresults.py: Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value. Adds missing documentation.
  • TestResultServer/model/jsonresults_unittest.py: Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS. Update test_merge to take a number of builds to truncate at.
10:21 AM Changeset in webkit [75165] by Martin Robinson
  • 2 edits in trunk

2011-01-06 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Enable blob support by default
​https://bugs.webkit.org/show_bug.cgi?id=51994

  • configure.ac: Enable Blob support by default.
10:19 AM Changeset in webkit [75164] by andreip@google.com
  • 2 edits in trunk/LayoutTests

2011-01-06 Andrei Popescu <​andreip@google.com>

Unreviewed, build fix.

[Chromium] Add elliptical gradient support to GradientSkia
​https://bugs.webkit.org/show_bug.cgi?id=51841

Marks fast/gradients/css3-radial-gradients3.html as expected to fail.
Also marks
canvas/philip/tests/2d.shadow.gradient.alpha.html
canvas/philip/tests/2d.shadow.gradient.basic.html
canvas/philip/tests/2d.shadow.gradient.transparent.2.html
as passing on Chromium-mac as a result of r75139.

  • platform/chromium/test_expectations.txt:
10:16 AM Changeset in webkit [75163] by Patrick Gansterer
  • 2 edits in trunk/WebCore

2011-01-06 Patrick Gansterer <Patrick Gansterer>

Unreviewed Windows build fix for r75161.

  • platform/graphics/cg/GraphicsContextCG.cpp: Missing include added.
9:57 AM Changeset in webkit [75162] by andreip@google.com
  • 1 edit
    4 deletes in trunk/LayoutTests

2011-01-06 Andrei Popescu <​andreip@google.com>

Unreviewed, rolling out r75152.

[Chromium] fast/gradients/css3-radial-gradients3.html needs Chromium-specific results
​https://bugs.webkit.org/show_bug.cgi?id=51988

Rolling out since, on closer inspection, the expectations are wrong and the corresponding test really fails.

  • platform/chromium-mac/fast/gradients/css3-radial-gradients3-expected.checksum: Removed.
  • platform/chromium-mac/fast/gradients/css3-radial-gradients3-expected.png: Removed.
  • platform/chromium-win/fast/gradients/css3-radial-gradients3-expected.checksum: Removed.
  • platform/chromium-win/fast/gradients/css3-radial-gradients3-expected.png: Removed.
9:36 AM Changeset in webkit [75161] by Patrick Gansterer
  • 2 edits in trunk/WebCore

2011-01-06 Patrick Gansterer <Patrick Gansterer>

Unreviewed WinCE build fix for r75139.

Try to remove include after adding forward-declaration in r75145.

  • platform/graphics/Gradient.h:
8:50 AM Changeset in webkit [75160] by reni@webkit.org
  • 8 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=51811
Merge m_height and m_width members of ImageData into the new m_size member.

Patch by Renata Hodovan <​reni@webkit.org> on 2011-01-06
Reviewed by Andreas Kling.

Image (BitmapImage, ImageSource) types in WebKit use IntSize to store their
width and height argument, except ImageData. This patch refactors ImageData
to follow the style of other Image types in WebKit.
Using of PassRefPtrs other than argument passing is not allowed in WebKit anymore.
This patch also refactors the PassRefPtr usages of ImageData.

It's just a refactoring, so we don't need any new tests.

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::write):
(WebCore::CloneDeserializer::readTerminal):

  • bindings/v8/SerializedScriptValue.cpp:

(WebCore::ZigZag::Reader::readImageData):

  • html/ImageData.cpp:

(WebCore::ImageData::create):
(WebCore::ImageData::ImageData):

  • html/ImageData.h:

(WebCore::ImageData::size):
(WebCore::ImageData::width):
(WebCore::ImageData::height):

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::createEmptyImageData):
(WebCore::CanvasRenderingContext2D::createImageData):
(WebCore::CanvasRenderingContext2D::getImageData):

  • html/canvas/CanvasRenderingContext2D.h:
  • platform/graphics/haiku/ImageBufferHaiku.cpp:

(WebCore::getImageData):

8:48 AM Changeset in webkit [75159] by jschuh@chromium.org
  • 1 edit in branches/chromium/552/WebCore/html/HTMLInputElement.cpp

Merge 70644 - 2010-10-27 Satish Sampath <​satish@chromium.org>

Reviewed by Steve Block.

Add runtime flag check before enabling speech input in code.
​https://bugs.webkit.org/show_bug.cgi?id=48426

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::isSpeechEnabled): Added runtime flag check.

BUG=68666
TBR=​jschuh@chromium.org

8:46 AM Changeset in webkit [75158] by yael.aharon@nokia.com
  • 5 edits
    4 adds in trunk

WebCore: document.querySelector(':nth-child(foo)') should throw a syntax error
​https://bugs.webkit.org/show_bug.cgi?id=51231

Reviewed by Darin Adler.

Also fixes
CSSNthSelector parsing code is illegible and buggy (allows "n3" as a valid selector)
​https://bugs.webkit.org/show_bug.cgi?id=21815

Add a check in the parser that other than an+b, only "odd" or "even" would be allowed
as parameters to nth selector.

Tests: fast/css/css3-nth-tokens-script.html

fast/css/css3-nth-tokens-style.html

  • css/CSSGrammar.y:
  • css/CSSParser.cpp:

(WebCore::isValidNthToken):

  • css/CSSParser.h:

LayoutTests: document.querySelector(':nth-child(foo)') should throw a syntax error
​https://bugs.webkit.org/show_bug.cgi?id=51231
CSSNthSelector parsing code is illegible and buggy (allows "n3" as a valid selector)
​https://bugs.webkit.org/show_bug.cgi?id=21815

Reviewed by Darin Adler.

  • fast/css/css3-nth-tokens-script-expected.txt: Added.
  • fast/css/css3-nth-tokens-script.html: Added.
  • fast/css/css3-nth-tokens-style-expected.txt: Added.
  • fast/css/css3-nth-tokens-style.html: Added.
8:31 AM Changeset in webkit [75157] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/WebCore

2011-01-06 Jan Erik Hanssen <​jhanssen@sencha.com>

Reviewed by Andreas Kling.

[Qt] crash in QNetworkReplyHandler::sendResponseIfNeeded()
​https://bugs.webkit.org/show_bug.cgi?id=51453

Check if m_reply is NULL before accessing.

  • manual-tests/load-deferrer-resume-crash.html: Added.
  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::setLoadMode): (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
8:24 AM Changeset in webkit [75156] by Darin Adler
  • 4 edits in trunk/WebKit2

Redo the half-done rename from the last check-in.
Sorry for the broken build last night.

  • WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit::WebBackForwardListProxy::removeItem): Renamed.

  • WebProcess/WebPage/WebBackForwardListProxy.h: Updated

for new name.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didRemoveBackForwardItem): Updated to
use the new name.

8:16 AM Changeset in webkit [75155] by andreip@google.com
  • 2 edits in trunk/LayoutTests

2011-01-06 Andrei Popescu <​andreip@google.com>

Unreviewed, build fix.

[Chromium] canvas/canvas-fillRect-gradient-shadow.html fails on Chromium.
​https://bugs.webkit.org/show_bug.cgi?id=51989

Updating the test expectations for the chromium-gpu platform.

  • platform/chromium-gpu/test_expectations.txt:
7:31 AM Changeset in webkit [75154] by andreip@google.com
  • 2 edits in trunk/LayoutTests

2011-01-06 Andrei Popescu <​andreip@google.com>

Unreviewed, build fix.

[Chromium] canvas/canvas-fillRect-gradient-shadow.html fails on Chromium.
​https://bugs.webkit.org/show_bug.cgi?id=51989

Added suppressions for
svg/batik/text/textEffect.svg
svg/batik/text/textEffect3.svg
svg/css/composite-shadow-text.svg
svg/custom/js-late-gradient-and-object-creation.svg
svg/custom/js-late-gradient-creation.svg
svg/text/selection-background-color.xhtml
svg/text/selection-styles.xhtml
svg/text/text-gradient-positioning.svg

These tests are all failing as a result of the same change: r75153.

  • platform/chromium/test_expectations.txt:
6:32 AM Changeset in webkit [75153] by andreip@google.com
  • 2 edits in trunk/LayoutTests

2011-01-06 Andrei Popescu <​andreip@google.com>

Unreviewed, build fix.

[Chromium] canvas/canvas-fillRect-gradient-shadow.html fails on Chromium.
​https://bugs.webkit.org/show_bug.cgi?id=51989

Updating Chromium expectations until we find a fix.

  • platform/chromium/test_expectations.txt:
6:13 AM Changeset in webkit [75152] by andreip@google.com
  • 1 edit
    4 adds in trunk/LayoutTests

2011-01-06 Andrei Popescu <​andreip@google.com>

Unreviewed, build fix.

[Chromium] fast/gradients/css3-radial-gradients3.html needs Chromium-specific results
​https://bugs.webkit.org/show_bug.cgi?id=51988

  • platform/chromium-mac/fast/gradients/css3-radial-gradients3-expected.checksum: Added.
  • platform/chromium-mac/fast/gradients/css3-radial-gradients3-expected.png: Added.
  • platform/chromium-win/fast/gradients/css3-radial-gradients3-expected.checksum: Added.
  • platform/chromium-win/fast/gradients/css3-radial-gradients3-expected.png: Added.
6:04 AM Changeset in webkit [75151] by abecsi@webkit.org
  • 2 edits in trunk/WebCore

2011-01-06 Andras Becsi <​abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt][V8] Fix the build when DEVICE_ORIENTATION is enabled.

No new tests needed.

  • WebCore.pro: remove duplications and globally add RuntimeEnabledFeatures.
4:48 AM Changeset in webkit [75150] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] Web Timing related bugs
​https://bugs.webkit.org/show_bug.cgi?id=51245

  • platform/qt/Skipped: Add new tests.
    • http/tests/misc/webtiming-origins.html
    • http/tests/misc/webtiming-slow-load.php
3:31 AM Changeset in webkit [75149] by abarth@webkit.org
  • 3 edits in trunk/Tools

2011-01-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

The EWS should log outside of the working directory
​https://bugs.webkit.org/show_bug.cgi?id=51986

This patch prepare us for using git clean -x -d -f in the EWS wrapper
script, which will actually clean the working copy back to a pristine
state instead of leaving untracked directories and ignored files.

  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
2:49 AM Changeset in webkit [75148] by commit-queue@webkit.org
  • 4 edits in trunk/WebCore

2011-01-06 Helder Correia <​helder@sencha.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt][GTK] Use GraphicsContext::hasShadow() in port-specific code
​https://bugs.webkit.org/show_bug.cgi?id=51985

r75139 introduced GraphicsContext::hasShadow(). This can now simplify
and unify some code in the Qt and GTK ports.

No new tests necessary for this refactoring.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect):
  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect):
12:41 AM Changeset in webkit [75147] by mjs@apple.com
  • 3 edits in trunk/WebKit2

Fix build for Darin's previous change w/ the obvious renaming.

Rubber stamped by Dan Bernstein.

  • WebProcess/WebPage/WebBackForwardListProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didRemoveBackForwardItem):

Note: See TracTimeline for information about the timeline view.