Context Navigation

Merge 75676
Because 597 branch doesn't have FormAssociatedElement.cpp, this change
was applied manually. The actual code change is in
WebCore/html/HTMLFormControlElement.cpp attributeChanged().

2011-01-12 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.

M_formElementsWithFormAttribute not cleared when FormAssociatedElement is inserted with a null m_form and then removed.
https://bugs.webkit.org/show_bug.cgi?id=51905

Calls unregisterFormElementWithFormAttribute() when 'form' attribute
is removed.

Tests: fast/forms/form-associated-element-crash.html

fast/forms/form-associated-element-crash2.html

html/FormAssociatedElement.cpp: (WebCore::FormAssociatedElement::formAttributeChanged):

2011-01-12 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.

M_formElementsWithFormAttribute not cleared when FormAssociatedElement is inserted with a null m_form and then removed.
https://bugs.webkit.org/show_bug.cgi?id=51905

Add test for crash when modifying the form attribute of a form
associated element before removing it.

fast/forms/form-associated-element-crash-expected.txt: Added.
fast/forms/form-associated-element-crash.html: Added.
fast/forms/form-associated-element-crash2-expected.txt: Added.
fast/forms/form-associated-element-crash2.html: Added.

BUG=

10:35 PM Changeset in webkit [75680] by tkent@chromium.org

4 edits
2 adds in branches/chromium/597

Merge 75675
Because 597 branch doesn't have FormAssociatedElement.{cpp,h}, this
change was manually applied and the ChangeLog entries are not
accurate.

2011-01-12 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura

M_formElementsWithFormAttribute not cleared when Node is moved to another document.
https://bugs.webkit.org/show_bug.cgi?id=51418

Calls unregisterFormElementWithFormAttribute() when form associated elements
are moved to another document.

Test: fast/forms/change-form-element-document-crash.html

html/FormAssociatedElement.cpp: (WebCore::FormAssociatedElement::willMoveToNewOwnerDocument): Added.
html/FormAssociatedElement.h: Added willMoveToNewOwnerDocument().
html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::willMoveToNewOwnerDocument): Added.
html/HTMLFormControlElement.h: Added willMoveToNewOwnerDocument().
html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::willMoveToNewOwnerDocument): Added.
html/HTMLObjectElement.h: Added willMoveToNewOwnerDocument().
html/HTMLPlugInImageElement.h: Moves willMoveToNewOwnerDocument() to protected.

2011-01-12 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura

M_formElementsWithFormAttribute not cleared when Node is moved to another document.
https://bugs.webkit.org/show_bug.cgi?id=51418

Added test for crash when moving form elements from one document to another.

fast/forms/change-form-element-document-crash-expected.txt: Added.
fast/forms/change-form-element-document-crash.html: Added.

BUG=http://code.google.com/p/chromium/issues/detail?id=65577

9:55 PM Changeset in webkit [75679] by hayato@chromium.org

3 edits in trunk/LayoutTests

2011-01-12 Hayato Ito <hayato@chromium.org>

Unreviewed test expectations files fix.

Fix a culprit revision number.

platform/chromium-gpu/test_expectations.txt:
platform/chromium/test_expectations.txt:

8:59 PM Changeset in webkit [75678] by hayato@chromium.org

2 edits in trunk/LayoutTests

2011-01-12 Hayato Ito <hayato@chromium.org>

Unreviewed chromium-gpu test expectations fix.

Disable canvas-large-dimensions.html after r75639.

platform/chromium-gpu/test_expectations.txt:

8:51 PM Changeset in webkit [75677] by rniwa@webkit.org

3 edits
2 adds in trunk

2011-01-12 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

REGRESSION(r69831): focus() in onkeypress discards input (affects chaseonline.chase.com)
https://bugs.webkit.org/show_bug.cgi?id=52241

The bug was caused by RenderTextControl::selection's creating a Range with m_insertText
which is a shadow DOM div as both start and end containers. Fixed the bug by traversing
through the descendents of m_innerText and using the right start and end containers to
create a Range.

Test: fast/forms/focus-change-on-keypress.html

rendering/RenderTextControl.cpp: (WebCore::setContainerAndOffsetForRange): Added; a helper function. (WebCore::RenderTextControl::selection): See above.

2011-01-12 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

REGRESSION(r69831): focus() in onkeypress discards input (affects chaseonline.chase.com)
https://bugs.webkit.org/show_bug.cgi?id=52241

Added a test to ensure WebKit inserts the character typed by a user when focus's node
is changed by a presskey event handler.

fast/forms/focus-change-on-keypress-expected.txt: Added.
fast/forms/focus-change-on-keypress.html: Added.

7:55 PM Changeset in webkit [75676] by tkent@chromium.org

3 edits
4 adds in trunk

2011-01-12 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.

M_formElementsWithFormAttribute not cleared when FormAssociatedElement is inserted with a null m_form and then removed.
https://bugs.webkit.org/show_bug.cgi?id=51905

Calls unregisterFormElementWithFormAttribute() when 'form' attribute
is removed.

Tests: fast/forms/form-associated-element-crash.html

fast/forms/form-associated-element-crash2.html

html/FormAssociatedElement.cpp: (WebCore::FormAssociatedElement::formAttributeChanged):

2011-01-12 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.

M_formElementsWithFormAttribute not cleared when FormAssociatedElement is inserted with a null m_form and then removed.
https://bugs.webkit.org/show_bug.cgi?id=51905

Add test for crash when modifying the form attribute of a form
associated element before removing it.

fast/forms/form-associated-element-crash-expected.txt: Added.
fast/forms/form-associated-element-crash.html: Added.
fast/forms/form-associated-element-crash2-expected.txt: Added.
fast/forms/form-associated-element-crash2.html: Added.

7:48 PM Changeset in webkit [75675] by tkent@chromium.org

9 edits
2 adds in trunk

2011-01-12 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.

M_formElementsWithFormAttribute not cleared when Node is moved to another document.
https://bugs.webkit.org/show_bug.cgi?id=51418

Calls unregisterFormElementWithFormAttribute() when form associated elements
are moved to another document.

Test: fast/forms/change-form-element-document-crash.html

html/FormAssociatedElement.cpp: (WebCore::FormAssociatedElement::willMoveToNewOwnerDocument): Added.
html/FormAssociatedElement.h: Added willMoveToNewOwnerDocument().
html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::willMoveToNewOwnerDocument): Added.
html/HTMLFormControlElement.h: Added willMoveToNewOwnerDocument().
html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::willMoveToNewOwnerDocument): Added.
html/HTMLObjectElement.h: Added willMoveToNewOwnerDocument().
html/HTMLPlugInImageElement.h: Moves willMoveToNewOwnerDocument() to protected.

2011-01-12 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.

M_formElementsWithFormAttribute not cleared when Node is moved to another document.
https://bugs.webkit.org/show_bug.cgi?id=51418

Added test for crash when moving form elements from one document to another.

fast/forms/change-form-element-document-crash-expected.txt: Added.
fast/forms/change-form-element-document-crash.html: Added.

7:26 PM Changeset in webkit [75674] by rniwa@webkit.org

1 edit in trunk/Source/WebCore/ChangeLog

Unreviwed. Added the missing bug id for r75672.

7:23 PM Changeset in webkit [75673] by kbalazs@webkit.org

4 edits in trunk/WebKit2

Unreviewed.

Getting rid of the unused 'viewportSize' argument in QWKPagePrivate:init.
The argument is unused since http://trac.webkit.org/changeset/75468.

UIProcess/API/qt/qgraphicswkview.cpp:

(QGraphicsWKView::QGraphicsWKView):

UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::init):

UIProcess/API/qt/qwkpage_p.h:

7:17 PM Changeset in webkit [75672] by rniwa@webkit.org

5 edits in trunk/Source/WebCore

2011-01-12 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Removed instantiation of legacy editing positions.
Calls to Position::Position are replaced by calls to Position's convenience functions.

Also added firstPositionInOrBeforeNode and lastPositionInOrAfterNode,
which are functions that return firstPositionInNode and lastPositionInNode respectively
when the specified node can have children for editing purpose and return positionBeforeNode
and positionAfterNode respectively otherwise. They can be used to guarantee that we never
create a bogus position like [img, 0] or [br, 0].

No tests are added since this is a cleanup.

editing/ApplyBlockElementCommand.cpp: (WebCore::ApplyBlockElementCommand::formatSelection):
editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyBlockStyle): (WebCore::ApplyStyleCommand::fixRangeAndApplyInlineStyle): (WebCore::ApplyStyleCommand::highestAncestorWithConflictingInlineStyle): (WebCore::ApplyStyleCommand::removeInlineStyle): (WebCore::ApplyStyleCommand::nodeFullySelected): (WebCore::ApplyStyleCommand::nodeFullyUnselected): (WebCore::ApplyStyleCommand::splitTextAtStart): (WebCore::ApplyStyleCommand::splitTextAtEnd): (WebCore::ApplyStyleCommand::splitTextElementAtStart): (WebCore::ApplyStyleCommand::splitTextElementAtEnd): (WebCore::ApplyStyleCommand::isValidCaretPositionInTextNode): (WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical): (WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical): (WebCore::ApplyStyleCommand::computedFontSize): (WebCore::ApplyStyleCommand::joinChildTextNodes):
editing/ApplyStyleCommand.h:
editing/htmlediting.h: (WebCore::firstPositionInOrBeforeNode): Added. (WebCore::lastPositionInOrAfterNode): Added.

7:15 PM Changeset in webkit [75671] by mrowe@apple.com

1 copy in tags/Safari-534.15.5

New tag.

6:50 PM Changeset in webkit [75670] by andersca@apple.com

3 edits in trunk/WebKit2

2011-01-12 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Implement DrawingAreaImpl::scroll
https://bugs.webkit.org/show_bug.cgi?id=52346

WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::scroll): If there is already an active scroll, compute the area of both scroll rects and invalidate the smallest one. Compute a new dirty region if necessary and also add the scroll repaint region to the dirty region.

(WebKit::DrawingAreaImpl::display):
Reset the scroll area and scroll delta.

WebProcess/WebPage/DrawingAreaImpl.h: Add scroll area and scroll delta member variables.

6:34 PM Changeset in webkit [75669] by andersca@apple.com

3 edits in trunk/WebKit2

2011-01-12 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Region improvements
https://bugs.webkit.org/show_bug.cgi?id=52344

Platform/Region.cpp: (WebKit::Region::Shape::move): (WebKit::Region::move): Change Region::move to take an IntSize.

Platform/Region.h: (WebKit::intersect): (WebKit::subtract): (WebKit::move): Add convenience functions.

6:01 PM Changeset in webkit [75668] by weinig@apple.com

2 edits in trunk/Source/WebCore

Another build fix.

platform/mac/WheelEventMac.mm:

(WebCore::phaseForEvent):

5:58 PM Changeset in webkit [75667] by rniwa@webkit.org

2 edits in trunk/WebKit2

2011-01-12 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Qt build fix for r75661

Shared/WebEvent.h: Don't declare phase() on non-Mac platforms.

5:47 PM Changeset in webkit [75666] by jschuh@chromium.org

2 edits in trunk/LayoutTests

2011-01-12 Justin Schuh <jschuh@chromium.org>

Unreviewed chromium test expectations fix.

Disable canvas-large-dimensions.html after r75639.

platform/chromium/test_expectations.txt:

5:45 PM Changeset in webkit [75665] by weinig@apple.com

2 edits in trunk/Source/WebCore

Fix build.

platform/mac/WheelEventMac.mm:

(WebCore::phaseForEvent):

5:39 PM Changeset in webkit [75664] by abarth@webkit.org

2 edits in trunk/Source/WebCore

2011-01-12 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Remove premature optimization from SchemeRegistry
https://bugs.webkit.org/show_bug.cgi?id=52283

As far as I can tell, this optimization isn't necessary. I'm slightly
unsure which benchmarks to run to demonstrate this numerically, but
none of the benchmarks Chromium tracks were affected by adding a
similar check for "display-isolated" schemes.

platform/SchemeRegistry.cpp: (WebCore::SchemeRegistry::shouldTreatURLSchemeAsLocal):

5:38 PM Changeset in webkit [75663] by enrica@apple.com

1 edit in trunk/Source/WebCore/platform/mac/WheelEventMac.mm

Build fix, unreviewed.

5:34 PM Changeset in webkit [75662] by Beth Dakin

9 edits in trunk

Add-on for https://bugs.webkit.org/show_bug.cgi?id=52309
Expose fixed layout through WebKit SPI
-and corresponding-
<rdar://problem/8844464>

Reviewed by Anders Carlsson.

Source/WebCore:

And now with getters!

WebCore.exp.in:

WebKit/mac:

And now with getters!

WebView/WebView.mm:

(-[WebView _useFixedLayout]):
(-[WebView _fixedLayoutSize]):

WebView/WebViewPrivate.h:

WebKit2:

And now with getters!

UIProcess/API/C/WKPage.cpp:

(WKPageUseFixedLayout):
(WKPageFixedLayoutSize):

UIProcess/API/C/WKPage.h:
UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::useFixedLayout):
(WebKit::WebPageProxy::fixedLayoutSize):

5:25 PM Changeset in webkit [75661] by weinig@apple.com

8 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=52337
PlatformWheelEvent should know about the scroll phase on the Mac

Reviewed by Anders Carlsson.

Source/WebCore:

Add a phase parameter on Mac PlatformWheelEvents.

platform/PlatformWheelEvent.h:

(WebCore::PlatformWheelEvent::PlatformWheelEvent):
(WebCore::PlatformWheelEvent::phase):

platform/mac/WheelEventMac.mm:

(WebCore::phaseForEvent):
(WebCore::PlatformWheelEvent::PlatformWheelEvent):

WebKit2:

Add a phase parameter on Mac WebWheelEvent and pipe it down to PlatformWheelEvent.

Shared/WebEvent.h:

(WebKit::WebWheelEvent::phase):

Shared/WebEventConversion.cpp:

(WebKit::WebKit2PlatformWheelEvent::WebKit2PlatformWheelEvent):

Shared/WebWheelEvent.cpp:

(WebKit::WebWheelEvent::WebWheelEvent):
(WebKit::WebWheelEvent::encode):
(WebKit::WebWheelEvent::decode):

Shared/mac/WebEventFactory.mm:

(WebKit::phaseForEvent):
(WebKit::WebEventFactory::createWebWheelEvent):

5:24 PM Changeset in webkit [75660] by cmarrin@apple.com

2 edits in trunk/Source/WebCore

2011-01-12 Chris Marrin <cmarrin@apple.com>

Unreviewed.

A couple of lines of the patch for https://bugs.webkit.org/show_bug.cgi?id=52321
were omitted.

platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):

5:02 PM Changeset in webkit [75659] by andersca@apple.com

12 edits in trunk/WebKit2

2011-01-12 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Get rid of an unneeded parameter from DrawingArea::scroll
https://bugs.webkit.org/show_bug.cgi?id=52336

WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::scroll):
WebProcess/WebCoreSupport/WebChromeClient.h:
WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp: (WebKit::ChunkedUpdateDrawingArea::scroll):
WebProcess/WebPage/ChunkedUpdateDrawingArea.h:
WebProcess/WebPage/DrawingArea.h:
WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::scroll):
WebProcess/WebPage/DrawingAreaImpl.h:
WebProcess/WebPage/LayerBackedDrawingArea.cpp: (WebKit::LayerBackedDrawingArea::scroll):
WebProcess/WebPage/LayerBackedDrawingArea.h:
WebProcess/WebPage/TiledDrawingArea.cpp: (WebKit::TiledDrawingArea::scroll):
WebProcess/WebPage/TiledDrawingArea.h:

4:51 PM Changeset in webkit [75658] by mihaip@chromium.org

3 edits in trunk/WebKit/chromium

2011-01-12 Mihai Parparita <mihaip@chromium.org>

Reviewed by David Levin.

[Chromium] Remove PartScrollbarHoriztonalTrack
https://bugs.webkit.org/show_bug.cgi?id=52329

Remove PartScrollbarHoriztonalTrack now that usages of it were removed
with http://crrev.com/71249.

DEPS:
public/linux/WebThemeEngine.h:

4:41 PM Changeset in webkit [75657] by andersca@apple.com

5 edits in trunk/WebKit2

2011-01-12 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Get the new drawing area painting to the screen
https://bugs.webkit.org/show_bug.cgi?id=52331

UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::incorporateUpdate): Call setViewNeedsDisplay on all the update rects.

UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setViewNeedsDisplay): Call through to the page client.

(WebKit::WebPageProxy::processDidCrash):
Null out the drawing area proxy.

UIProcess/mac/BackingStoreMac.mm: (WebKit::BackingStore::paint): Paint.

4:35 PM Changeset in webkit [75656] by cmarrin@apple.com

2 edits in trunk/Source/WebCore

2011-01-12 Chris Marrin <cmarrin@apple.com>

Unreviewed.

Getting rid of an assert that was causing build failures that turns out not to be needed.

rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintsWithTransform):

4:22 PM Changeset in webkit [75655] by mjs@apple.com

4 edits in trunk/Tools

2011-01-12 Maciej Stachowiak <mjs@apple.com>

Reviewed by Sam Weinig.

Detect, identify and recover from WebProcess crashes in run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=52330

Scripts/old-run-webkit-tests: Detect when the regression test tool reports a web process crash.
WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): Set up a processDidCrash callback. (WTR::TestController::processDidCrash): Report that the Web process crashed.
WebKitTestRunner/TestController.h:

4:20 PM Changeset in webkit [75654] by ojan@chromium.org

3 edits in trunk/Websites/bugs.webkit.org

2011-01-12 Ojan Vafai <ojan@chromium.org>

Reviewed by Mihai Parparita.

fix assorted bugs with expansion lines
https://bugs.webkit.org/show_bug.cgi?id=52326

-Clicking "all" would collapse whitespace in the expanded lines.
-Converted the remaining line creation code to using the DOM.

PrettyPatch/PrettyPatch.rb:
code-review.js:

4:14 PM Changeset in webkit [75653] by cmarrin@apple.com

2 edits in trunk/Source/WebCore

2011-01-12 Chris Marrin <cmarrin@apple.com>

Unreviewed.

Another fix for Gtk

rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintsWithTransform):

4:08 PM Changeset in webkit [75652] by cmarrin@apple.com

4 edits in trunk/Source/WebCore

2011-01-12 Chris Marrin <cmarrin@apple.com>

Unreviewed.

Fix for Gtk and Windows builds

page/Frame.cpp: (WebCore::Frame::scalePage):
page/Frame.h:
platform/graphics/ca/win/PlatformCALayerWin.cpp: (PlatformCALayer::contentsScale): (PlatformCALayer::setContentsScale):

3:52 PM Changeset in webkit [75651] by cmarrin@apple.com

2 edits in trunk/Source/WebCore

2011-01-12 Chris Marrin <cmarrin@apple.com>

UNreviewed.

Fix for the Windows build

platform/graphics/ca/win/PlatformCALayerWin.cpp: (contentsScale): (setContentsScale):

3:48 PM Changeset in webkit [75650] by ojan@chromium.org

2 edits in trunk/Websites/bugs.webkit.org

2011-01-12 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

review tool formatted diff doesn't match the uploaded diff
https://bugs.webkit.org/show_bug.cgi?id=51960

PrettyPatch works just fine if there is no newline at the end of the file.

attachment.cgi:

3:41 PM Changeset in webkit [75649] by cmarrin@apple.com

3 edits in trunk/Source/WebCore

2011-01-12 Chris Marrin <cmarrin@apple.com>

Unreviewed.

Another build fix

platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::clampedContentsScaleForScale):
platform/graphics/ca/mac/PlatformCALayerMac.mm: (PlatformCALayer::setContentsScale):

3:35 PM Changeset in webkit [75648] by mdelaney@apple.com

3 edits
2 adds in trunk

2011-01-11 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Max area bound needed in creation of IOSurface in ImageBufferCG.cpp
https://bugs.webkit.org/show_bug.cgi?id=52172

Tests: fast/canvas/canvas-large-dimensions.html

platform/graphics/cg/ImageBufferCG.cpp: (WebCore::ImageBuffer::ImageBuffer):

2011-01-11 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Max area bound needed in creation of IOSurface in ImageBufferCG.cpp
https://bugs.webkit.org/show_bug.cgi?id=52172

fast/canvas/canvas-large-dimensions.html: Added.
fast/canvas/canvas-large-dimensions-expected.txt: Added.

3:29 PM Changeset in webkit [75647] by andersca@apple.com

6 edits in trunk/WebKit2

2011-01-12 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

More work on getting the drawing area proxy to paint
https://bugs.webkit.org/show_bug.cgi?id=52328

UIProcess/API/mac/WKView.mm: (-[WKView drawRect:]): Handle the new drawing area.

UIProcess/BackingStore.cpp: (WebKit::BackingStore::BackingStore): Assert that the size isn't empty.

UIProcess/BackingStore.h:
UIProcess/mac/BackingStoreMac.mm: (WebKit::BackingStore::incorporateUpdate): Paint all update rects into the bitmap context.

WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::display): Create a handle so the shareable bitmap will actually be transferred over.

3:27 PM Changeset in webkit [75646] by ojan@chromium.org

3 edits in trunk/Websites/bugs.webkit.org

2011-01-12 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

Bugzilla: Add keyboard shortcuts to jump to next change
https://bugs.webkit.org/show_bug.cgi?id=52305

Comments and diff blocks go in the same queue. If you have a
comment focused, then j/k will focus the next/prev diff block
with respect to that comment.

PrettyPatch/PrettyPatch.rb:
code-review.js:

3:27 PM Changeset in webkit [75645] by dbates@webkit.org

3 edits in trunk/Source/WebCore

2011-01-12 Daniel Bates <dbates@rim.com>

And Benjamin C Meyer <bmeyer@rim.com>

Build fix when building with Inspector disabled
https://bugs.webkit.org/show_bug.cgi?id=52313

After changeset 75604 <http://trac.webkit.org/changeset/75604> it's not
possible to build when the Inspector is disabled.

inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::updateApplicationCacheStatus): Fix build breakage when building with Inspector disabled and Offline Web Applications enabled by moving macro guard condition ENABLE(INSPECTOR) && ENABLE(OFFLINE_WEB_APPLICATIONS) into function body. This makes us also consistent with the form we use for InspectorInstrumentation::networkStateChanged() and other InspectorInstrumentation functions.
loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didReceiveData): Fix build breakage when building with Inspector disabled by adding ENABLE(INSPECTOR) guard around code that references the instance variable ApplicationCacheGroup::m_currentResourceIdentifier as this variable only exists when building with the Inspector. (WebCore::ApplicationCacheGroup::didFinishLoading): Ditto. (WebCore::ApplicationCacheGroup::didFail): Ditto.

3:12 PM Changeset in webkit [75644] by cmarrin@apple.com

2 edits in trunk/Source/WebCore

2011-01-12 Chris Marrin <cmarrin@apple.com>

Unreviewed.

Fix a build issue from http://trac.webkit.org/changeset/75639.

platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::contentsScale): (WebCore::GraphicsLayer::setContentsScale):

3:06 PM Changeset in webkit [75643] by cmarrin@apple.com

4 edits in trunk/Source/WebCore

2011-01-12 Chris Marrin <cmarrin@apple.com>

Reviewed by Kevin Decker.

Pages with accelerated layers lose subpixel-AA and become blurry when a scale factor is applied
rdar://problem/8824974

This prevents the rootLayer (with the WebKit rendered content) from going becoming
a tiled layer when zoomed, and when there is other layered content on the page.
This speeds up zooming a lot and avoids some buggy behavior in CA with a very large
number of layers.

rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintsWithTransform):
rendering/RenderLayer.h:
rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::paintingGoesToWindow):

2:58 PM Changeset in webkit [75642] by ojan@chromium.org

2 edits in trunk/Websites/bugs.webkit.org

2011-01-12 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

show shared lines on both sides in code review tool
https://bugs.webkit.org/show_bug.cgi?id=52308

We were appending the same DOM node twice. Instead, make
the from column a clone of the original node.

code-review.js:

2:44 PM Changeset in webkit [75641] by andersca@apple.com

2 edits in trunk/WebKit2

Fix build.

UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::incorporateUpdate):

2:34 PM Changeset in webkit [75640] by andersca@apple.com

6 edits
1 add in trunk/WebKit2

2011-01-12 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Begin stubbing out some more BackingStore member functions
https://bugs.webkit.org/show_bug.cgi?id=52323

UIProcess/BackingStore.cpp: (WebKit::BackingStore::~BackingStore): This was accidentally made into a constructor; it should be a destructor.

UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::paint): Call the backing store.

(WebKit::DrawingAreaProxyImpl::update):
Incorporate the update.

(WebKit::DrawingAreaProxyImpl::incorporateUpdate):
Create the backing store if needed and incorporate the update.

UIProcess/mac/BackingStoreMac.mm: Added. (WebKit::BackingStore::platformInitialize): Create a bitmap context.

(WebKit::BackingStore::paint):
(WebKit::BackingStore::incorporateUpdate):
Add stubs.

WebKit2.xcodeproj/project.pbxproj: Add BackingStoreMac.mm

2:27 PM Changeset in webkit [75639] by cmarrin@apple.com

14 edits in trunk/Source/WebCore

2011-01-12 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

Pages with accelerated layers lose subpixel-AA and become blurry when a scale factor is applied
rdar://problem/8824974

When scaled, WebKit renders the page content at the scaled up size, so there are no
scaling artifacts. But content drawn into a layer's backing store does not scale up.
This is made worse by the fact that the root page contents become layered when there
are other accelerated compositing layers present (video, plugins, etc.).

Plumb scaling factor from Frame::scalePage() down into all layers with content. It
eventually calls CALayer::setContentsScale which renders to a backing store whose dimensions
are scaled, causing them to render larger and appear pixel perfect at the scaled
page size.

page/Frame.cpp: (WebCore::Frame::updateContentsScale): (WebCore::Frame::scalePage):
page/Frame.h:
platform/graphics/GraphicsLayer.h:
platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::setContentsScale): (WebCore::GraphicsLayerCA::clampedContentsScaleForScale):
platform/graphics/ca/GraphicsLayerCA.h: (WebCore::GraphicsLayerCA::contentsScale):
platform/graphics/ca/PlatformCALayer.h:
platform/graphics/ca/mac/PlatformCALayerMac.mm: (PlatformCALayer::contentsScale): (PlatformCALayer::setContentsScale):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateContentsScale):
rendering/RenderLayer.h:
rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::createGraphicsLayer): (WebCore::RenderLayerBacking::updateForegroundLayer): (WebCore::RenderLayerBacking::updateMaskLayer): (WebCore::RenderLayerBacking::updateContentsScale):
rendering/RenderLayerBacking.h:
rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateContentsScale):
rendering/RenderLayerCompositor.h:

2:26 PM Changeset in webkit [75638] by tony@chromium.org

8 edits
2 adds in trunk/LayoutTests

2011-01-12 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

output the value of input and textarea nodes when using dump-as-markup
https://bugs.webkit.org/show_bug.cgi?id=52319

editing/inserting/5607069-2-expected.txt:
editing/inserting/5607069-3-expected.txt:
editing/selection/dump-as-markup-expected.txt:
editing/selection/dump-as-markup-form-text-expected.txt: Added.
editing/selection/dump-as-markup-form-text.html: Added.
fast/parser/object-with-textarea-fallback-expected.txt:
html5lib/runner.html:
html5lib/webkit-resumer.html:
resources/dump-as-markup.js: (Markup.useHTML5libOutputFormat): Add a flag for html5lib compatibility (Markup._get):

1:58 PM Changeset in webkit [75637] by senorblanco@chromium.org

5 edits in trunk/Source/WebCore

2011-01-12 Stephen White <senorblanco@chromium.org>

Reviewed by James Robinson.

Fix DrawingBuffer issues for depth/stencil, extensions, etc.
https://bugs.webkit.org/show_bug.cgi?id=52310

1) GL_TEXTURE is not a valid argument to glFramebufferTexture2D()
(should be GL_TEXTURE_2D).
2) Support for the multisampling extension was being checked after
the DrawingBuffer constructor was called, which calls multisample()
to check for the extension.
3) If depth or stencil is set, the corresponding framebuffers must
be created in the DrawingBuffer constructor.
4) GL_DEPTH_STENCIL is not a valid framebuffer internal type in
GLES2. Must use GL_OES_DEPTH24_STENCIL8, and check for the
OES_packed_depth_stencil extension.

platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::DrawingBuffer): Record the extension support in the constructor. Create all the secondary drawing buffers (for multisampling, depth/stencil).
platform/graphics/gpu/DrawingBuffer.cpp: (WebCore::DrawingBuffer::create): Check for the extensions before calling the DrawingBuffer constructor. (WebCore::DrawingBuffer::createSecondaryBuffers): Refactor creation of the secondary buffers from DrawingBufferMac.mm to here. (WebCore::DrawingBuffer::reset): Use DEPTH24_STENCIL8 format, not DEPTH_STENCIL. Use DEPTH_COMPONENT16, not DEPTH_COMPONENT. Use GL_TEXTURE_2D, not GL_TEXTURE (for glFramebufferTexture2D).
platform/graphics/gpu/DrawingBuffer.h: Refactor createSecondaryBuffers(). Add extension support arguments to constructor. Add support for packed_depth_stencil extension.
platform/graphics/gpu/mac/DrawingBufferMac.mm: (WebCore::DrawingBuffer::DrawingBuffer): Record extension support in constructor. Refactor out creation of secondary buffers.

1:12 PM Changeset in webkit [75636] by robert@webkit.org

1 edit
6 adds in trunk/LayoutTests

2011-01-12 Robert Hogan <robert@webkit.org>

Unreviewed, add expected results.

[Qt] Add new expected results from r75632

https://bugs.webkit.org/show_bug.cgi?id=42887

platform/qt/fast/forms/search-display-none-cancel-button-expected.txt: Added.
platform/qt/fast/forms/search-placeholder-value-changed-expected.txt: Added.
platform/qt/fast/forms/search-rtl-expected.txt: Added.
platform/qt/fast/forms/search-styled-expected.txt: Added.
platform/qt/fast/forms/search-transformed-expected.txt: Added.
platform/qt/fast/forms/search-zoomed-expected.txt: Added.

1:04 PM Changeset in webkit [75635] by Beth Dakin

15 edits in trunk

Fix for https://bugs.webkit.org/show_bug.cgi?id=52309 Expose
fixed layout through WebKit SPI
-and corresponding-
<rdar://problem/8844464>

Reviewed by Anders Carlsson.

Source/WebCore:

Export symbols for ScrollView::setUseFixedLayout() and
ScrollView::setFixedLayoutSize()

WebCore.exp.in:

WebKit/mac:

WebView/WebView.mm:

(-[WebView _setUseFixedLayout:]):
(-[WebView _setFixedLayoutSize:]):

WebView/WebViewPrivate.h:

WebKit2:

Store useFixedLayout and fixedLayoutSize in the
WebPageCreationParameters and the WebPageProxy.

Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

Shared/WebPageCreationParameters.h:
UIProcess/API/C/WKPage.cpp:

(WKPageSetUseFixedLayout):
(WKPageSetFixedLayoutSize):

UIProcess/API/C/WKPage.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::setUseFixedLayout):
(WebKit::WebPageProxy::setFixedLayoutSize):
(WebKit::WebPageProxy::creationParameters):

UIProcess/WebPageProxy.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setUseFixedLayout):
(WebKit::WebPage::setFixedLayoutSize):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

1:03 PM Changeset in webkit [75634] by robert@webkit.org

5 edits in trunk/LayoutTests

2011-01-12 Robert Hogan <robert@webkit.org>

Unreviewed, update expected results.

[Qt] Update expected results from r75632

https://bugs.webkit.org/show_bug.cgi?id=42887

platform/qt/fast/css/pseudo-cache-stale-expected.txt:
platform/qt/fast/css/text-input-with-webkit-border-radius-expected.txt:
platform/qt/fast/forms/search-cancel-button-style-sharing-expected.txt:
platform/qt/fast/forms/search-vertical-alignment-expected.txt:

12:53 PM Changeset in webkit [75633] by andersca@apple.com

2 edits
2 adds in trunk/WebKit2

2011-01-12 Anders Carlsson <andersca@apple.com>

Reviewed by Beth Dakin.

Add BackingStore class
https://bugs.webkit.org/show_bug.cgi?id=52318

UIProcess/BackingStore.cpp: Added. (WebKit::BackingStore::create): (WebKit::BackingStore::BackingStore):
UIProcess/BackingStore.h: Added.
WebKit2.xcodeproj/project.pbxproj:

12:27 PM Changeset in webkit [75632] by robert@webkit.org

9 edits in trunk

2011-01-12 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Search input field doesn't have cancel button

Add a cancel button to the search field and make it customizable
by the client. For now, use the close dialog button associated
with the application's style as the default.

Unskip a bunch of search field related tests that pass now:

fast/forms/search-cancel-button-mouseup.html
fast/forms/search-rtl.html
fast/forms/search-abs-pos-cancel-button.html
fast/forms/search-styled.html
fast/forms/search-transformed.html
fast/forms/search-zoomed.html
fast/forms/search-cancel-button-style-sharing.html
fast/forms/search-display-none-cancel-button.html
fast/forms/search-placeholder-value-changed.html
fast/repaint/search-field-cancel.html
fast/forms/search-cancel-button-events.html

https://bugs.webkit.org/show_bug.cgi?id=42887

platform/qt/Skipped:

2011-01-12 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Search input field doesn't have cancel button

Add a cancel button to the search field and make it customizable
by the client. For now, use the close dialog button associated
with the application's style as the default.

Unskip a bunch of search field related tests that pass now:

fast/forms/search-cancel-button-mouseup.html
fast/forms/search-rtl.html
fast/forms/search-abs-pos-cancel-button.html
fast/forms/search-styled.html
fast/forms/search-transformed.html
fast/forms/search-zoomed.html
fast/forms/search-cancel-button-style-sharing.html
fast/forms/search-display-none-cancel-button.html
fast/forms/search-placeholder-value-changed.html
fast/repaint/search-field-cancel.html
fast/forms/search-cancel-button-events.html

https://bugs.webkit.org/show_bug.cgi?id=42887

platform/graphics/qt/ImageQt.cpp: (loadResourcePixmap):
platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::isControlStyled): (WebCore::RenderThemeQt::computeSizeBasedOnStyle): (WebCore::RenderThemeQt::paintSearchField): (WebCore::RenderThemeQt::adjustSearchFieldStyle): (WebCore::RenderThemeQt::adjustSearchFieldCancelButtonStyle): (WebCore::RenderThemeQt::convertToPaintingRect): (WebCore::RenderThemeQt::paintSearchFieldCancelButton):
platform/qt/RenderThemeQt.h:

2011-01-12 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Search input field doesn't have cancel button

Add a cancel button to the search field and make it customizable
by the client. For now, use the close dialog button associated
with the application's style as the default.

https://bugs.webkit.org/show_bug.cgi?id=42887

Api/qwebsettings.cpp: (graphics):
Api/qwebsettings.h:

12:12 PM Changeset in webkit [75631] by beidson@apple.com

15 edits in trunk/WebKit2

<rdar://problem/8837307>, <rdar://problem/8637038>, and https://bugs.webkit.org/show_bug.cgi?id=52248
Back/forward list recovery after a WebProcess crash is crashy itself.

Reviewed by Sam Weinig.

Add an isEmpty() accessor so the WebProcess knows if it is actually restoring a session:

Shared/SessionState.cpp:

(WebKit::SessionState::isEmpty):

Shared/SessionState.h:

Keep track of the highest used itemID so a relaunched WebProcess can later be informed:

Shared/WebBackForwardListItem.cpp:

(WebKit::WebBackForwardListItem::WebBackForwardListItem):
(WebKit::WebBackForwardListItem::highedUsedItemID):

Shared/WebBackForwardListItem.h:
WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit::generateHistoryItemID):
(WebKit::WebBackForwardListProxy::setHighestItemIDFromUIProcess):
(WebKit::WebBackForwardListProxy::addItemFromUIProcess): Remove a now-invalid ASSERT, as the UIProcess

now tells the WebProcess that a previous WebProcess created.

WebProcess/WebPage/WebBackForwardListProxy.h:

Encode/decode data relevant to restoring a session on WebPage creation:

Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

Shared/WebPageCreationParameters.h:

If the WebProcess has crashed since the last load, change reload and the various back/forward APIs to
update the current back/forward item (if necessary) then relaunch the process:

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::reattachToWebProcessWithItem):
(WebKit::WebPageProxy::reattachToWebProcess): Renamed from "relaunch()" and made private.
(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::loadURL):
(WebKit::WebPageProxy::loadURLRequest):
(WebKit::WebPageProxy::reload):
(WebKit::WebPageProxy::goForward):
(WebKit::WebPageProxy::goBack):
(WebKit::WebPageProxy::goToBackForwardItem):
(WebKit::WebPageProxy::creationParameters):

UIProcess/WebPageProxy.h:

Rename "RestoreSession" to "RestoreSessionAndNavigateToCurrentItem"

WebProcess/WebPage/WebPage.messages.in:
UIProcess/cf/WebPageProxyCF.cpp:

(WebKit::WebPageProxy::restoreFromSessionStateData):

Restore a session on page creation if the parameters include it:

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage): Call restoreSession if session state exists.
(WebKit::WebPage::restoreSessionAndNavigateToCurrentItem):
(WebKit::WebPage::restoreSession):

WebProcess/WebPage/WebPage.h:

12:11 PM Changeset in webkit [75630] by andersca@apple.com

9 edits in trunk/WebKit2

2011-01-12 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Send Update and DidUpdate messages
https://bugs.webkit.org/show_bug.cgi?id=52316

UIProcess/DrawingAreaProxy.h: (WebKit::DrawingAreaProxy::update): Add empty stub.

UIProcess/DrawingAreaProxy.messages.in: Add Update message.

UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::update): Just send back a DidUpdate message.

WebProcess/WebPage/DrawingArea.h: (WebKit::DrawingArea::didUpdate): Add empty stub.

WebProcess/WebPage/DrawingArea.messages.in: Add DidUpdate message.

WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::didUpdate): Call display().

(WebKit::DrawingAreaImpl::display):
Send an Update message.

12:07 PM Changeset in webkit [75629] by caseq@chromium.org

2 edits in trunk/Source/WebCore

2011-01-12 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: cookie table is multiplied after repeated switching to cookies tab in network item view
Only create cookiesTable is it hasn't been done yet.
https://bugs.webkit.org/show_bug.cgi?id=52303

inspector/front-end/ResourceCookiesView.js: (WebInspector.ResourceCookiesView.prototype.show):

11:41 AM Changeset in webkit [75628] by levin@chromium.org

3 edits in trunk/Tools

check-webkit-style -- close_expression function doesn't work correctly.
https://bugs.webkit.org/show_bug.cgi?id=52272

Reviewed by Shinichiro Hamaji.

Scripts/webkitpy/style/checkers/cpp.py:

(Position.str): Added a way to convert it to a string which is useful in tests.
(Position.cmp): Added a way to compare Position which is useful in tests and
generally useful (for upcoming code changes).
(close_expression): Changed to use Position for input and output.
Also, fixed many bugs such as only working correctly for parenthesis,
not working correctly if given an offset in a line and not finding
the real closing element if there were multiple closing elements in
the same line.
(detect_functions): Adjusted due to the change in arguments for
close_expression.

Scripts/webkitpy/style/checkers/cpp_unittest.py:

(CppStyleTestBase.assert_positions_equal): Added a way to verify that
two positions are the same.
(CppStyleTest.test_position): Added tests for the str_ and cmp methods.
(CppStyleTest.test_close_expression): Added tests to catch the issues
that were fixed.

11:41 AM Changeset in webkit [75627] by andersca@apple.com

8 edits in trunk/WebKit2

2011-01-12 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Make the new drawing area actually draw something
https://bugs.webkit.org/show_bug.cgi?id=52314

Shared/UpdateInfo.cpp: (WebKit::UpdateInfo::encode): (WebKit::UpdateInfo::decode): Encode and decode newly added fields.

Shared/UpdateInfo.h: Add a vector of update rects and a handle for the sharable bitmap.

WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::display): Get the individual rects from the region and paint them into the shareable bitmap.

WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::mainFrameHasCustomRepresentation):
WebProcess/WebPage/WebPage.h: Add helper function.

WebProcess/WebPage/mac/ChunkedUpdateDrawingAreaMac.cpp: (WebKit::ChunkedUpdateDrawingArea::paintIntoUpdateChunk): Use helper function.

11:25 AM Changeset in webkit [75626] by commit-queue@webkit.org

13 edits in trunk/Tools

2011-01-12 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r75576.
http://trac.webkit.org/changeset/75576
https://bugs.webkit.org/show_bug.cgi?id=52304

broke rebaseline-chromium-webkit-test (Requested by thakis on
#webkit).

Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
Scripts/webkitpy/layout_tests/port/base.py:
Scripts/webkitpy/layout_tests/port/chromium.py:
Scripts/webkitpy/layout_tests/port/port_testcase.py:
Scripts/webkitpy/layout_tests/port/test.py:
Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
Scripts/webkitpy/layout_tests/run_webkit_tests.py:
Scripts/webkitpy/style/checkers/test_expectations.py:
Scripts/webkitpy/style/checkers/test_expectations_unittest.py:

11:24 AM Changeset in webkit [75625] by xan@webkit.org

2 edits in trunk/Source/JavaScriptCore

2011-01-12 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

Add new Yarr.h header to the list file.

GNUmakefile.am: ditto.

10:57 AM Changeset in webkit [75624] by andersca@apple.com

2 edits
2 adds in trunk/WebKit2

2011-01-12 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add UpdateInfo class
https://bugs.webkit.org/show_bug.cgi?id=52306

Shared/UpdateInfo.cpp: Added. (WebKit::UpdateInfo::encode): (WebKit::UpdateInfo::decode):
Shared/UpdateInfo.h: Added. (WebKit::UpdateInfo::UpdateInfo):
WebKit2.xcodeproj/project.pbxproj:

10:55 AM Changeset in webkit [75623] by mjs@apple.com

2 edits in trunk/Tools

2011-01-12 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin Adler.

Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
https://bugs.webkit.org/show_bug.cgi?id=52307

Scripts/old-run-webkit-tests:

10:28 AM Changeset in webkit [75622] by pfeldman@chromium.org

2 edits in branches/chromium/597/WebCore/inspector

Follow up to r75606, fixing compilation (explicit .get() in cast + transitive import).

10:28 AM Changeset in webkit [75621] by thakis@chromium.org

1 edit
2 deletes in trunk/LayoutTests

2011-01-12 Nico Weber <thakis@chromium.org>

Unreviewed, test expectations.

Remove now-unnecessary vista-specific baseline.
https://bugs.webkit.org/show_bug.cgi?id=52105

platform/chromium-win-vista/svg/custom/js-late-gradient-and-object-creation-expected.checksum: Removed.
platform/chromium-win-vista/svg/custom/js-late-gradient-and-object-creation-expected.png: Removed.

10:19 AM Changeset in webkit [75620] by andersca@apple.com

4 edits in trunk/WebKit2

2011-01-12 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

More work on the new drawing area implementation
https://bugs.webkit.org/show_bug.cgi?id=52302

Platform/Region.cpp: (WebKit::Region::Shape::segments_end): segments_end could end up returning an iterator that is one element past the Vector data, so we can't use operator[] since that will assert.

WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::DrawingAreaImpl): Initialize the timer.

(WebKit::DrawingAreaImpl::setNeedsDisplay):
Unite the rect with the dirty region and schedule a display.

(WebKit::DrawingAreaImpl::setSize):
Tell the web page to resize.

(WebKit::DrawingAreaImpl::scheduleDisplay):
Start a display timer if needed.

(WebKit::DrawingAreaImpl::display):
Add a stub.

10:11 AM Changeset in webkit [75619] by Martin Robinson

6 edits in trunk

2011-01-12 Koan-Sin Tan <koansin.tan@gmail.com>

Reviewed by Martin Robinson.

[Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
https://bugs.webkit.org/show_bug.cgi?id=50867

config.h: Don't disallow ctype for (OS(DARWIN) && PLATFORM(GTK)) Many GTK+ related files include <libintl.h> or <glib/gi18n-lib.h>. On Mac, <libintl.h> includes <xlocale.h>. <xclocale.h> includes <xlocale/_ctype.h>, which uses isacii().
platform/UUID.cpp: (WebCore::createCanonicalUUIDString): For OS(DARWIN) && !PLATFORM(CF) use the Chromium Linux UUID generation.

2011-01-12 Koan-Sin Tan <koansin.tan@gmail.com>

Reviewed by Martin Robinson.

[Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
https://bugs.webkit.org/show_bug.cgi?id=50867

Fixed library extention for Mac in webkitdirs.pm and type conflict in
TestNetscapePlugin.cpp

GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
Scripts/webkitdirs.pm:

9:57 AM Changeset in webkit [75618] by jschuh@chromium.org

2 edits in trunk/LayoutTests

2011-01-12 Justin Schuh <jschuh@chromium.org>

Unreviewed expectatinos update.

Excluding SVG test for sporadic image failure.

platform/chromium/test_expectations.txt:

9:45 AM Changeset in webkit [75617] by Martin Robinson

2 edits in trunk/Source/JavaScriptCore

2011-01-12 Martin Robinson <mrobinson@igalia.com>

Missing Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h in WebKitGtk tarball
https://bugs.webkit.org/show_bug.cgi?id=52299

GNUmakefile.am: Fix the GTK+ build on ARMv7 by including missing source files in the source list.

9:31 AM Changeset in webkit [75616] by jschuh@chromium.org

2 edits in trunk/LayoutTests

2011-01-12 Justin Schuh <jschuh@chromium.org>

Unreviewed chromium expectations update.

Added chromium win to exclusion for bug 48164.

platform/chromium/test_expectations.txt:

9:09 AM Changeset in webkit [75615] by Simon Fraser

8 edits in trunk

2011-01-12 Simon Fraser <Simon Fraser>

Reviewed by Eric Seidel.

[CSS Gradients] One color stop should not paint anything for linear-gradient
https://bugs.webkit.org/show_bug.cgi?id=52259

Share color stop parsing code between linear and radial gradients.
Consider the gradient invalid if it has less than two color stops.

css/CSSParser.cpp: (WebCore::CSSParser::parseLinearGradient): (WebCore::CSSParser::parseRadialGradient): (WebCore::CSSParser::parseGradientColorStops):
css/CSSParser.h:

9:05 AM Changeset in webkit [75614] by bfulgham@webkit.org

1 edit
1 move in trunk/WebKit2

Unreviewed build fix after r75527. Rename 'BackingStoreCairo.cpp'
to 'ShareableBitmapCairo.cpp' to match VS project changes.

Shared/cairo/BackingStoreCairo.cpp: Removed.
Shared/cairo/ShareableBitmapCairo.cpp: Copied from Shared/cairo/BackingStoreCairo.cpp.

8:42 AM Changeset in webkit [75613] by mnaganov@chromium.org

8 edits
1 add in trunk

2011-01-12 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Add check-inspector-strings script.
Fix inconsistencies in Inspector strings found by the script.

https://bugs.webkit.org/show_bug.cgi?id=52295

English.lproj/localizedStrings.js:
inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.EventListenerBreakpointsSidebarPane):
inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.setRecordingProfile):
inspector/front-end/Resource.js: (WebInspector.Resource.Type.toString):
inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceRevisionTreeElement):
inspector/front-end/utilities.js: ():
Scripts/check-inspector-strings: Added.

8:21 AM Changeset in webkit [75612] by yurys@chromium.org

3 edits in trunk/Source/WebCore

2011-01-12 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Fix WML compilation on Mac.

wml/WMLInputElement.cpp: (WebCore::WMLInputElement::setValue): (WebCore::WMLInputElement::setValueForUser): (WebCore::WMLInputElement::initialize): (WebCore::WMLInputElement::validateInputMask):
wml/WMLSelectElement.cpp: (WebCore::WMLSelectElement::listBoxSelectItem):

8:07 AM Changeset in webkit [75611] by jschuh@chromium.org

2 edits in trunk/Source/WebCore

2011-01-12 Justin Schuh <jschuh@chromium.org>

Unreviewed build fix for debug strict compiles.

Use fprintf for debug statements instead of fwrite, which caused compile failures
in debug strict mode because of failure to check the fwrite return value.

No behavior changed.

rendering/CounterNode.cpp: (WebCore::showTreeAndMark):

8:06 AM Changeset in webkit [75610] by Adam Roben

2 edits in trunk/Tools

Advertise the .testnetscape file extension on Windows

Fixes <http://webkit.org/b/52298>
plugins/no-mime-with-valid-extension.html fails on Windows

Reviewed by Dan Bernstein.

DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a

FileExtents field to map the .testnetscape file extension to the
application/x-webkit-test-netscape MIME type, just as we do on Mac.

7:41 AM Changeset in webkit [75609] by Csaba Osztrogonác

1 edit
15 adds in trunk/LayoutTests

Unreviewed.

Add Qt specific expected results for new passing tests introduced in r74954 and r74743.
Compared to Mac png files and Mac expected files.

platform/qt/fast/css-generated-content/table-before-after-child-add-expected.checksum: Added.
platform/qt/fast/css-generated-content/table-before-after-child-add-expected.png: Added.
platform/qt/fast/css-generated-content/table-before-after-child-add-expected.txt: Added.
platform/qt/fast/css-generated-content/table-cell-before-after-child-add-expected.checksum: Added.
platform/qt/fast/css-generated-content/table-cell-before-after-child-add-expected.png: Added.
platform/qt/fast/css-generated-content/table-cell-before-after-child-add-expected.txt: Added.
platform/qt/fast/css-generated-content/table-row-before-after-child-add-expected.checksum: Added.
platform/qt/fast/css-generated-content/table-row-before-after-child-add-expected.png: Added.
platform/qt/fast/css-generated-content/table-row-before-after-child-add-expected.txt: Added.
platform/qt/fast/css-generated-content/table-table-before-after-child-add-expected.checksum: Added.
platform/qt/fast/css-generated-content/table-table-before-after-child-add-expected.png: Added.
platform/qt/fast/css-generated-content/table-table-before-after-child-add-expected.txt: Added.
platform/qt/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.checksum: Added.
platform/qt/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png: Added.
platform/qt/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Added.

7:33 AM Changeset in webkit [75608] by jschuh@chromium.org

2 edits in trunk/LayoutTests

2011-01-12 Justin Schuh <jschuh@chromium.org>

Unreviewed expectations update for chromium.

Exclude failing test from r75064.

platform/chromium/test_expectations.txt:

7:08 AM Changeset in webkit [75607] by Philippe Normand

2 edits in trunk/LayoutTests

2011-01-12 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip failing test on GTK.

platform/gtk/Skipped: Skip editing/input/page-up-down-scrolls.html

6:54 AM Changeset in webkit [75606] by pfeldman@chromium.org

3 edits in branches/chromium/597/WebCore/inspector

Merge 74637 - 2010-12-24 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Darin Adler.

inspector/debugger-step-out.html crashing intermittently in the bots
https://bugs.webkit.org/show_bug.cgi?id=50868

Use RefPtr rather instead of raw pointers when keeping references
to refcounted objects.

inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::getStylesForNode2): (WebCore::InspectorCSSAgent::getComputedStyleForNode2):
inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyle::create): (WebCore::InspectorStyle::InspectorStyle): (WebCore::InspectorStyle::buildObjectForStyle): (WebCore::InspectorStyle::setPropertyText): (WebCore::InspectorStyle::toggleProperty): (WebCore::InspectorStyle::styleText): (WebCore::InspectorStyle::populateAllProperties): (WebCore::InspectorStyle::replacePropertyInStyleText): (WebCore::InspectorStyleSheet::create): (WebCore::InspectorStyleSheet::InspectorStyleSheet): (WebCore::InspectorStyleSheetForInlineStyle::create): (WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle): (WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):
inspector/InspectorStyleSheet.h: (WebCore::InspectorStyle::cssStyle): (WebCore::InspectorStyleSheet::pageStyleSheet):

TBR=yurys@chromium.org
BUG=69296
Review URL: http://codereview.chromium.org/6205007

6:42 AM Changeset in webkit [75605] by Philippe Normand

2 edits in trunk/WebKit/gtk

2011-01-12 Philippe Normand <pnormand@igalia.com>

Unreviewed build fix for 32-bits Release. Include GRefPtrGtk.h so
the GdkCursor templates are found and used at runtime.

WebCoreSupport/FullscreenVideoController.cpp:

5:06 AM Changeset in webkit [75604] by yurys@chromium.org

35 edits in trunk

2010-12-29 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

inspector/timeline-network-resource.html fails when run twice
https://bugs.webkit.org/show_bug.cgi?id=37394

Send didReceiveResponse notification to the timeline agent from ResourceLoadNotifier
instead of ResourceLoader::didReceiveResponse to cover the cases when resources
are loaded from memory cache.

Network notifications are now send to InspectorInstrumentation which dispatches
them to interested agents and InspectorController.
fix

inspector/timeline-network-resource-expected.txt:
inspector/timeline-network-resource.html:
inspector/timeline-network-resource.js:

2010-12-29 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

inspector/timeline-network-resource.html fails when run twice
https://bugs.webkit.org/show_bug.cgi?id=37394

Send didReceiveResponse notification to the timeline agent from ResourceLoadNotifier
instead of ResourceLoader::didReceiveResponse to cover the cases when resources
are loaded from memory cache.

Network notifications are now sent to InspectorInstrumentation which dispatches
them to interested agents and InspectorController.

inspector/Inspector.idl:
inspector/InspectorApplicationCacheAgent.cpp: (WebCore::InspectorApplicationCacheAgent::didReceiveManifestResponse):
inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didFailLoading): (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
inspector/InspectorController.h:
inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::identifierForInitialRequestImpl): (WebCore::InspectorInstrumentation::willSendRequestImpl): (WebCore::InspectorInstrumentation::markResourceAsCachedImpl): (WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCacheImpl): (WebCore::InspectorInstrumentation::willReceiveResourceResponseImpl): (WebCore::InspectorInstrumentation::didReceiveContentLengthImpl): (WebCore::InspectorInstrumentation::didFinishLoadingImpl): (WebCore::InspectorInstrumentation::didFailLoadingImpl): (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl): (WebCore::InspectorInstrumentation::scriptImportedImpl): (WebCore::InspectorInstrumentation::retrieveResourceAgent):
inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::identifierForInitialRequest): (WebCore::InspectorInstrumentation::willSendRequest): (WebCore::InspectorInstrumentation::markResourceAsCached): (WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCache): (WebCore::InspectorInstrumentation::willReceiveResourceResponse): (WebCore::InspectorInstrumentation::didReceiveContentLength): (WebCore::InspectorInstrumentation::didFinishLoading): (WebCore::InspectorInstrumentation::didFailLoading): (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorInstrumentation::scriptImported):
inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::identifierForInitialRequest):
inspector/InspectorResourceAgent.h:
inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::willSendResourceRequest):
inspector/InspectorTimelineAgent.h:
inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createResourceSendRequestData):
inspector/TimelineRecordFactory.h:
inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager.prototype.identifierForInitialRequest):
inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype.addRecordToTimeline):
loader/FrameLoader.cpp: (WebCore::FrameLoader::loadedResourceFromMemoryCache):
loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::didReceiveResponse): (WebCore::ResourceLoadNotifier::didFailToLoad): (WebCore::ResourceLoadNotifier::assignIdentifierToInitialRequest): (WebCore::ResourceLoadNotifier::dispatchWillSendRequest): (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse): (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength): (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading): (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didReceiveResponse):
loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::createResourceHandle): (WebCore::ApplicationCacheGroup::didReceiveResponse): (WebCore::ApplicationCacheGroup::didReceiveData): (WebCore::ApplicationCacheGroup::didFinishLoading): (WebCore::ApplicationCacheGroup::didFail):
loader/appcache/ApplicationCacheGroup.h:
workers/DefaultSharedWorkerRepository.cpp: (WebCore::SharedWorkerScriptLoader::notifyFinished):
workers/Worker.cpp: (WebCore::Worker::notifyFinished):
workers/WorkerContext.cpp: (WebCore::WorkerContext::importScripts):
xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didFinishLoading):

2010-12-29 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

inspector/timeline-network-resource.html fails when run twice
https://bugs.webkit.org/show_bug.cgi?id=37394

Send didReceiveResponse notification to the timeline agent from ResourceLoadNotifier
instead of ResourceLoader::didReceiveResponse to cover the cases when resources
are loaded from memory cache.

Network notifications are now sent to InspectorInstrumentation which dispatches
them to interested agents and InspectorController.

src/SharedWorkerRepository.cpp: (WebCore::SharedWorkerScriptLoader::notifyFinished):
src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::mainFrame): (WebKit::WebDevToolsAgentImpl::identifierForInitialRequest): (WebKit::WebDevToolsAgentImpl::willSendRequest): (WebKit::WebDevToolsAgentImpl::didReceiveData): (WebKit::WebDevToolsAgentImpl::didReceiveResponse): (WebKit::WebDevToolsAgentImpl::didFinishLoading): (WebKit::WebDevToolsAgentImpl::didFailLoading):
src/WebDevToolsAgentImpl.h:

5:03 AM Changeset in webkit [75603] by jorlow@chromium.org

1 edit
1 add in trunk/LayoutTests

2011-01-12 Jeremy Orlow <jorlow@chromium.org>

Add forgotten file.

storage/indexeddb/transaction-read-only-expected.txt: Added.

4:57 AM Changeset in webkit [75602] by pvarga@webkit.org

12 edits
1 add in trunk/Source/JavaScriptCore

2011-01-12 Peter Varga <pvarga@webkit.org>

Reviewed by Gavin Barraclough.

Add Yarr.h to YARR
https://bugs.webkit.org/show_bug.cgi?id=51021

Move other common constants and functions from YARR's different files
to Yarr.h.
Use Yarr.h header instead of including other YARR headers where it
is possible.

JavaScriptCore.gypi:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
runtime/RegExp.cpp:
yarr/Yarr.h: Added.
yarr/YarrInterpreter.cpp:
yarr/YarrInterpreter.h:
yarr/YarrJIT.cpp: (JSC::Yarr::jitCompile): (JSC::Yarr::execute):
yarr/YarrJIT.h:
yarr/YarrParser.h:
yarr/YarrPattern.cpp: (JSC::Yarr::YarrPattern::compile): (JSC::Yarr::YarrPattern::YarrPattern):
yarr/YarrPattern.h:

4:55 AM Changeset in webkit [75601] by podivilov@chromium.org

2 edits in trunk/Source/WebCore

2011-01-12 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: do not replace all tabs with spaces when editing script source
https://bugs.webkit.org/show_bug.cgi?id=52291

inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.setContent): (WebInspector.SourceFrame.prototype._editLine):

4:29 AM Changeset in webkit [75600] by abarth@webkit.org

2 edits in trunk/Tools

2011-01-12 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Make webkit-patch support subdirectories for SVN checkouts
https://bugs.webkit.org/show_bug.cgi?id=52261

os.relpath does not exist on Python 2.5, so we need to call our version
of the API.

Scripts/webkitpy/common/checkout/scm.py:

4:22 AM Changeset in webkit [75599] by commit-queue@webkit.org

2 edits in trunk/WebKit/qt

2011-01-12 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r74344.
http://trac.webkit.org/changeset/74344
https://bugs.webkit.org/show_bug.cgi?id=52290

broke QWebPluginFactory for unusual mime-types (Requested by
kling on #webkit).

WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createPlugin):

3:28 AM Changeset in webkit [75598] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

Unreviewed.

[Qt] plugins/no-mime-with-valid-extension.html fails
https://bugs.webkit.org/show_bug.cgi?id=52288

platform/qt/Skipped: plugins/no-mime-with-valid-extension.html added until fix.

3:16 AM Changeset in webkit [75597] by Csaba Osztrogonác

12 edits
1 delete in trunk/Source/JavaScriptCore

Unreviewed, rolling out r75595.
http://trac.webkit.org/changeset/75595
https://bugs.webkit.org/show_bug.cgi?id=52286

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-01-12
It broke fast/regex/pcre-test-1.html (Requested by Ossy on
#webkit).

JavaScriptCore.gypi:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
runtime/RegExp.cpp:
yarr/Yarr.h: Removed.
yarr/YarrInterpreter.cpp:
yarr/YarrInterpreter.h:
yarr/YarrJIT.cpp:

(JSC::Yarr::jitCompile):

yarr/YarrJIT.h:

(JSC::Yarr::execute):

yarr/YarrParser.h:
yarr/YarrPattern.cpp:

(JSC::Yarr::compile):
(JSC::Yarr::YarrPattern::YarrPattern):

yarr/YarrPattern.h:

2:40 AM Changeset in webkit [75596] by jorlow@chromium.org

22 edits
1 add in trunk

2011-01-11 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

Enforce READ_ONLY transactions in IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=52229

Fix existing errors in tests + add a new test for
this issue.

storage/indexeddb/cursor-delete-expected.txt:
storage/indexeddb/cursor-delete.html:
storage/indexeddb/cursor-index-delete-expected.txt:
storage/indexeddb/cursor-index-delete.html:
storage/indexeddb/database-quota-expected.txt:
storage/indexeddb/database-quota.html:
storage/indexeddb/objectstore-basics-expected.txt:
storage/indexeddb/objectstore-basics.html:
storage/indexeddb/objectstore-removeobjectstore-expected.txt:
storage/indexeddb/objectstore-removeobjectstore.html:
storage/indexeddb/transaction-basics-expected.txt:
storage/indexeddb/transaction-basics.html:
storage/indexeddb/transaction-crash-on-abort-expected.txt:
storage/indexeddb/transaction-crash-on-abort.html:
storage/indexeddb/transaction-read-only.html: Added.

2011-01-11 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

Enforce READ_ONLY transactions in IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=52229

Add READ_ONLY_ERR and return it whenever delete or put
are called. Note that IDBCursor's delete and update
are simply aliases for delete/put, which is why no
extra code is required to handle those cases.

Test: storage/indexeddb/transaction-read-only.html

dom/ExceptionCode.cpp:
storage/IDBCursorBackendImpl.cpp: (WebCore::IDBCursorBackendImpl::deleteFunction):
storage/IDBDatabase.idl:
storage/IDBDatabaseException.h:
storage/IDBDatabaseException.idl:
storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::put): (WebCore::IDBObjectStoreBackendImpl::deleteFunction): (WebCore::IDBObjectStoreBackendImpl::deleteIndex):

2:32 AM Changeset in webkit [75595] by pvarga@webkit.org

12 edits
1 add in trunk/Source/JavaScriptCore

2011-01-12 Peter Varga <pvarga@webkit.org>

Reviewed by Gavin Barraclough.

Add Yarr.h to YARR
https://bugs.webkit.org/show_bug.cgi?id=51021

Move other common constants and functions from YARR's different files
to Yarr.h.
Use Yarr.h header instead of including other YARR headers where it
is possible.

JavaScriptCore.gypi:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
runtime/RegExp.cpp:
yarr/Yarr.h: Added.
yarr/YarrInterpreter.cpp:
yarr/YarrInterpreter.h:
yarr/YarrJIT.cpp: (JSC::Yarr::jitCompile): (JSC::Yarr::execute):
yarr/YarrJIT.h:
yarr/YarrParser.h:
yarr/YarrPattern.cpp: (JSC::Yarr::YarrPattern::compile): (JSC::Yarr::YarrPattern::YarrPattern):
yarr/YarrPattern.h:

1:38 AM Changeset in webkit [75594] by pfeldman@chromium.org

1 edit in branches/chromium/597/WebCore/inspector/front-end/ResourceManager.js

Merge 75503 - 2011-01-11 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: redirects are lost from the network panel upon navigation.
https://bugs.webkit.org/show_bug.cgi?id=52210

inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager.prototype.didCommitLoadForFrame):

TBR=pfeldman@chromium.org
BUG=69359

1:36 AM Changeset in webkit [75593] by pfeldman@chromium.org

2 edits in branches/chromium/597/WebCore/inspector/front-end

Merge 75498 - 2011-01-11 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: "Audit present state" always disabled
https://bugs.webkit.org/show_bug.cgi?id=52199

Removed all traces of resource tracking checks, as we have it no more.

English.lproj/localizedStrings.js:
inspector/front-end/AuditLauncherView.js: (WebInspector.AuditLauncherView.prototype._createLauncherUI):
inspector/front-end/AuditsPanel.js:

TBR=apavlov@chromium.org
BUG=69241

1:32 AM Changeset in webkit [75592] by pfeldman@chromium.org

2 edits in branches/chromium/597/WebCore

Merge 75485 - 2011-01-11 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [REGRESSION] Load timing is requested
for all resources (not only for the main one).
https://bugs.webkit.org/show_bug.cgi?id=51749

inspector/InspectorController.cpp: (WebCore::InspectorController::willSendRequest):
loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):

TBR=pfeldman@chromium.org
BUG=69229

1:27 AM Changeset in webkit [75591] by Philippe Normand

2 edits in trunk/Source/WebCore

2011-01-11 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Seidel.

[GTK] minimal build breaks in RenderThemeGtk3
https://bugs.webkit.org/show_bug.cgi?id=52202

platform/gtk/RenderThemeGtk3.cpp: Added VIDEO guards around initMediaColors().

1:08 AM Changeset in webkit [75590] by Philippe Normand

3 edits
1 copy in trunk/Source/WebCore

2011-01-11 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Carlson.

[GStreamer] PlatformVideoWindowMac implementation
https://bugs.webkit.org/show_bug.cgi?id=50770

This new implementation will be used on Mac OS to display the
fullscreen video window with the GStreamer-based media player.

platform/graphics/gstreamer/GStreamerGWorld.cpp: (WebCore::gstGWorldSyncMessageCallback):
platform/graphics/gstreamer/PlatformVideoWindow.h: (WebCore::PlatformVideoWindow::window):
platform/graphics/gstreamer/PlatformVideoWindowMac.mm: (PlatformVideoWindow::PlatformVideoWindow): (PlatformVideoWindow::~PlatformVideoWindow): (PlatformVideoWindow::prepareForOverlay):

12:37 AM Changeset in webkit [75589] by ojan@chromium.org

3 edits in trunk/Websites/bugs.webkit.org

2011-01-12 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

fix wrapping bug in expansion lines in the code review tool
https://bugs.webkit.org/show_bug.cgi?id=52270

PrettyPatch/PrettyPatch.rb:
code-review.js:

Jan 11, 2011:

11:57 PM Changeset in webkit [75588] by mjs@apple.com

2 edits in trunk/LayoutTests

2011-01-11 Maciej Stachowiak <mjs@apple.com>

Reviewed by David Levin.

Fix typo in WebKit2 skipped list which was causing a test to not get skipped
https://bugs.webkit.org/show_bug.cgi?id=52277

platform/mac-wk2/Skipped:

11:41 PM Changeset in webkit [75587] by mjs@apple.com

2 edits in trunk/Tools

2011-01-11 Maciej Stachowiak <mjs@apple.com>

Reviewed by Eric Seidel.

Close additional pages opened during a test once the test completes.
https://bugs.webkit.org/show_bug.cgi?id=52276

WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::done):

10:53 PM Changeset in webkit [75586] by levin@chromium.org

3 edits in trunk/Tools

2011-01-11 David Levin <levin@chromium.org>

Reviewed by Eric Seidel.

Errors should be separated from the command line in bot messages.
https://bugs.webkit.org/show_bug.cgi?id=52275

Scripts/webkitpy/common/system/executive.py: (ScriptError.message_with_output): Added a newline to separate the command line from the errors.
Scripts/webkitpy/common/system/executive_unittest.py: (ScriptErrorTest.test_message_with_output): Added tests for the various code paths in message_with_output.

9:25 PM Changeset in webkit [75585] by Simon Fraser

3 edits
2 adds in trunk

2011-01-11 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Webkit crashes when a gradient is applied using the first-line pseudo element
https://bugs.webkit.org/show_bug.cgi?id=52225

When a pseudostyle references images, we fail to register/unregister
the relevant RenderObjects as clients of the image in the style.
For gradients, this caused a crash.

This patch fixes the crash by returning a null gradient image in this
situation.

Test: fast/gradients/gradient-on-pseudoelement-crash.html

css/CSSGradientValue.cpp: (WebCore::CSSGradientValue::image):

7:35 PM Changeset in webkit [75584] by jschuh@chromium.org

2 edits in trunk/LayoutTests

2011-01-11 Justin Schuh <jschuh@chromium.org>

Unreviewed chromium expectations update.

Windows exclusion for no-mime-with-valid-extension.html (from r75567)

platform/chromium/test_expectations.txt:

7:20 PM Changeset in webkit [75583] by eric@webkit.org

5 edits in trunk/Tools

2011-01-11 Eric Seidel <eric@webkit.org>

Unreviewed.

commit-queue should know how to upload archived results (for test flakes or general failures)
https://bugs.webkit.org/show_bug.cgi?id=52048

The zips are mostly empty due to forgetting -r.
Expected diffs were not being pulled from the archive due
to the archive having longer paths than I realized.

Scripts/webkitpy/common/system/workspace.py:
Scripts/webkitpy/common/system/workspace_unittest.py:
Scripts/webkitpy/tool/bot/flakytestreporter.py:
Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:

6:38 PM Changeset in webkit [75582] by dpranke@chromium.org

2 edits in trunk/LayoutTests

2011-01-11 Dirk Pranke <dpranke@chromium.org>

Unreviewed, fix typo in expectations file.

platform/chromium-gpu/test_expectations.txt:

6:16 PM Changeset in webkit [75581] by thakis@chromium.org

1 edit
2 deletes in trunk/LayoutTests

2011-01-11 Nico Weber <thakis@chromium.org>

Unreviewed, test expectations.

Remove now-unnecessary xp-specific baseline.
https://bugs.webkit.org/show_bug.cgi?id=52105

platform/chromium-win-xp/fast/gradients/radial-centered-expected.checksum: Removed.
platform/chromium-win-xp/fast/gradients/radial-centered-expected.png: Removed.

5:57 PM Changeset in webkit [75580] by aestes@apple.com

2 edits in trunk/Source/WebCore

2011-01-11 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

REGRESSION (r71562): servePendingRequests() no longer called when
resources are done loading.
https://bugs.webkit.org/show_bug.cgi?id=52264
<rdar://problem/8767429>

In r71562, servePendingRequests() is no longer called in Loader's
didFinishLoading(), didFail() and didReceiveResponse() methods. Since
r71562 was intended only as a refactoring, these calls should be
restored. At least one WebKit-based Mac OS X application relies on this
for correct behavior.

loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::loadDone): Call resourceLoadScheduler()->servePendingRequests().

5:36 PM Changeset in webkit [75579] by enne@google.com

2 edits in trunk/LayoutTests

2011-01-11 Adrienne Walker <enne@google.com>

Unreviewed, test expectations update.

Revert expect change for Snow Leopard in r75570.

platform/mac-snowleopard/Skipped:

5:28 PM Changeset in webkit [75578] by mihaip@chromium.org

2 edits in trunk/LayoutTests

2011-01-11 Mihai Parparita <mihaip@chromium.org>

Unreviewed; chromium test expectations update.

Remove failing expectations for tests that pass after r75569.

platform/chromium/test_expectations.txt:

5:26 PM Changeset in webkit [75577] by Patrick Gansterer

8 edits in trunk/Source/WebCore

2011-01-11 Patrick Gansterer <Patrick Gansterer>

Reviewed by Eric Seidel.

Add Document::setContent()
https://bugs.webkit.org/show_bug.cgi?id=52085

Add a method to Document to set the whole content at once.
This removes the hack of the insert method in the xml parser
and is a predecessor to feed the xml parser with raw data.

dom/Document.cpp: (WebCore::Document::setContent):
dom/Document.h:
dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::insert): Added ASSERT_NOT_REACHED().
loader/cache/CachedFont.cpp: (WebCore::CachedFont::ensureSVGFontData): Use setContent.
xml/DOMParser.cpp: (WebCore::DOMParser::parseFromString): Ditto.
xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::responseXML): Ditto.
xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource): Ditto.

5:15 PM Changeset in webkit [75576] by dpranke@chromium.org

13 edits in trunk/Tools

2011-01-11 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

The current modifier parsing code in test_expectations is
fragile and hard-coded, so it's not easy to understand the logic
or easily add new types of modifiers (like GPU vs. CPU testing
for graphics tests, or 32-bit vs. 64-bit differences).

This is the first of two patches that will add in more generic
support and then eliminate the GPU-specific test expectations
files for Chromium.

This patch adds two standalone objects for handling modifiers. The
rules for interpreting modifiers, precedence, and conflicts are
given in the docstring to the ModifierMatcher class, which
returns ModifierMatchResult objects.

This patch also adds routines to the Port interface and a
default set of values in the base object, in order to obtain the
values needed on a given test run. These values are then passed
to the expectation parser. This also allows us to clean up the
logic used to lint all of the different configurations in a
single test_expectations.txt file.

The next patch will merge in the separate GPU expectations file.

https://bugs.webkit.org/show_bug.cgi?id=51222

Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
Scripts/webkitpy/layout_tests/port/base.py:
Scripts/webkitpy/layout_tests/port/base_unittest.py:
Scripts/webkitpy/layout_tests/port/chromium.py:
Scripts/webkitpy/layout_tests/port/port_testcase.py:
Scripts/webkitpy/layout_tests/port/test.py:
Scripts/webkitpy/layout_tests/run_webkit_tests.py:
Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

4:56 PM Changeset in webkit [75575] by mjs@apple.com

5 edits in trunk/Tools

2011-01-11 Maciej Stachowiak <mjs@apple.com>

Reviewed by Adam Barth.

Make webkit-patch support subdirectories for SVN checkouts
https://bugs.webkit.org/show_bug.cgi?id=52261

Scripts/webkitpy/common/checkout/scm.py:
Scripts/webkitpy/style_references.py:
Scripts/webkitpy/tool/main.py:
Scripts/webkitpy/tool/steps/preparechangelog.py:

4:56 PM Changeset in webkit [75574] by jamesr@google.com

2 edits in trunk/LayoutTests

2011-01-11 James Robinson <jamesr@chromium.org>

Update test to use layoutTestController.waitUntilDone()/notifyDone() since it relies on the scroll event which is now async.

fast/repaint/resources/fixed-move-after-keyboard-scroll-iframe.html:

4:53 PM Changeset in webkit [75573] by bfulgham@webkit.org

2 edits in trunk/Source/WebCore

Unreviewed build fix.

platform/graphics/cairo/PathCairo.cpp:

(WebCore::Path::addArc): Switch to MathExtra's piFloat define,
rather than M_PI which is not always available.

4:52 PM Changeset in webkit [75572] by mihaip@chromium.org

2 edits in trunk/LayoutTests

2011-01-11 Mihai Parparita <mihaip@chromium.org>

Unreviewed; chromium test expectations update.

Remove failing expectations for tests that pass after r75552.

platform/chromium/test_expectations.txt:

4:43 PM Changeset in webkit [75571] by ojan@chromium.org

3 edits in trunk/Websites/bugs.webkit.org

2011-01-11 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

fix difflink centering to be vertical, not horizontal
https://bugs.webkit.org/show_bug.cgi?id=52263

PrettyPatch/PrettyPatch.rb:
code-review.js:

4:39 PM Changeset in webkit [75570] by enne@google.com

6 edits
3 adds
2 deletes in trunk/LayoutTests

2011-01-11 Adrienne Walker <enne@google.com>

Reviewed by Kenneth Russell.

Sync WebGL texImage2D video test from Khronos and re-enable it.
https://bugs.webkit.org/show_bug.cgi?id=44459

fast/canvas/webgl/resources/quadrants.mp4: Removed.
fast/canvas/webgl/resources/quadrants.ogv: Removed.
fast/canvas/webgl/resources/red-green.mp4: Added.
fast/canvas/webgl/resources/red-green.theora.ogv: Added.
fast/canvas/webgl/resources/red-green.webmvp8.webm: Added.
fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-expected.txt:
fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html:
platform/chromium-gpu/test_expectations.txt:
platform/chromium/test_expectations.txt:
platform/mac-snowleopard/Skipped:

4:36 PM Changeset in webkit [75569] by mihaip@chromium.org

8 edits
38 adds
2 deletes in trunk/LayoutTests

2011-01-11 Mihai Parparita <mihaip@chromium.org>

Unreviewed, new chromium-mac baselines.

Rebaseline after the scrollbar change (these tests still need
chromium-mac baselines since they have controls or images that render
slightly differently from the Mac port).

platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.checksum:
platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
platform/chromium-mac/fast/block/margin-collapse/103-expected.checksum: Added.
platform/chromium-mac/fast/block/margin-collapse/103-expected.png: Added.
platform/chromium-mac/fast/borders/border-image-rotate-transform-expected.checksum:
platform/chromium-mac/fast/borders/border-image-rotate-transform-expected.png:
platform/chromium-mac/fast/events/pointer-events-2-expected.checksum:
platform/chromium-mac/fast/events/pointer-events-2-expected.png:
platform/chromium-mac/fast/images/gif-large-checkerboard-expected.checksum: Removed.
platform/chromium-mac/fast/images/gif-large-checkerboard-expected.png: Removed.
platform/chromium-mac/fast/replaced/width100percent-image-expected.checksum: Added.
platform/chromium-mac/fast/replaced/width100percent-image-expected.png: Added.
platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.checksum: Added.
platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png: Added.
platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.checksum: Added.
platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png: Added.
platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.checksum: Added.
platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png: Added.
platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.checksum: Added.
platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png: Added.
platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.checksum: Added.
platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png: Added.
platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.checksum: Added.
platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png: Added.
platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.checksum: Added.
platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
platform/chromium-mac/tables/mozilla/bugs/bug101674-expected.checksum: Added.
platform/chromium-mac/tables/mozilla/bugs/bug101674-expected.png: Added.
platform/chromium-mac/tables/mozilla/bugs/bug29314-expected.checksum: Added.
platform/chromium-mac/tables/mozilla/bugs/bug29314-expected.png: Added.
platform/chromium-mac/tables/mozilla/bugs/bug5797-expected.checksum: Added.
platform/chromium-mac/tables/mozilla/bugs/bug5797-expected.png: Added.
platform/chromium-mac/tables/mozilla/bugs/bug625-expected.checksum: Added.
platform/chromium-mac/tables/mozilla/bugs/bug625-expected.png: Added.
platform/chromium-mac/tables/mozilla/core/bloomberg-expected.checksum: Added.
platform/chromium-mac/tables/mozilla/core/bloomberg-expected.png: Added.
platform/chromium-mac/tables/mozilla/core/row_span-expected.checksum: Added.
platform/chromium-mac/tables/mozilla/core/row_span-expected.png: Added.
platform/chromium-mac/tables/mozilla/other/cell_widths-expected.checksum: Added.
platform/chromium-mac/tables/mozilla/other/cell_widths-expected.png: Added.
platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.checksum: Added.
platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png: Added.
platform/chromium-mac/tables/mozilla_expected_failures/other/test4-expected.checksum: Added.
platform/chromium-mac/tables/mozilla_expected_failures/other/test4-expected.png: Added.
platform/chromium/test_expectations.txt:

4:33 PM Changeset in webkit [75568] by commit-queue@webkit.org

2 edits in trunk/WebKit2

2011-01-11 Jeff Miller <jeffm@apple.com>

Reviewed by John Sullivan.

WebKit2: "Webpages not responding" dialog appears when <select> popup menu is showing
https://bugs.webkit.org/show_bug.cgi?id=52242

UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::showPopupMenu): On Windows, stop the responsiveness timer before calling showPopupMenu().

4:33 PM Changeset in webkit [75567] by commit-queue@webkit.org

3 edits
2 adds in trunk

2011-01-11 Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>

Reviewed by Adam Barth.

Use plug-in DB for extensions to MIME type convertion

Plugins extension to MIME type conversion was not used in the
frameLoader. This was causing some fallback to be use which as the side
effect of loosing all the <OBJECT> parameters or <EMBED> attributes.
This patch ensure that we try to convert the extension to MIME type
using the plugin database beofre using this fallback.

Attribute lost with Flash plugin without mime type set
https://bugs.webkit.org/show_bug.cgi?id=50657

plugins/no-mime-with-valid-extension.html: Added.
plugins/no-mime-with-valid-extension-expected.txt: Added.

2011-01-11 Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>

Reviewed by Adam Barth.

Use plug-in DB for extensions to MIME type convertion

Plugins extension to MIME type conversion was not used in the
frameLoader. This was causing some fallback to be use which as the side
effect of loosing all the <OBJECT> parameters or <EMBED> attributes.
This patch ensure that we try to convert the extension to MIME type
using the plugin database beofre using this fallback.

Attribute lost with Flash plugin without mime type set
https://bugs.webkit.org/show_bug.cgi?id=50657

Test: plugins/no-mime-with-valid-extension.html

loader/FrameLoader.cpp: (WebCore::FrameLoader::defaultObjectContentType): Use PluginDatabase for MIME

4:17 PM Changeset in webkit [75566] by mjs@apple.com

2 edits in trunk/WebKit2

2011-01-11 Maciej Stachowiak <mjs@apple.com>

Reviewed by Anders Carlsson.

UIProcess kills the WebProcess sometimes when detached frames exist
https://bugs.webkit.org/show_bug.cgi?id=52227

UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didSaveFrameToPageCache): Don't consider the message invalid if it came in for a detached frame.

3:56 PM Changeset in webkit [75565] by ojan@chromium.org

2 edits in trunk/Websites/bugs.webkit.org

2011-01-11 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

remember diffstate for review tool
https://bugs.webkit.org/show_bug.cgi?id=52253

If you use the global sidebyside/unified links, store the diff type
in localstorage. Then, onload, use that diff type. That way, people
who prefer one diff type or the other can always get that by default.

code-review.js:

3:44 PM Changeset in webkit [75564] by jschuh@chromium.org

2 edits in trunk/LayoutTests

2011-01-11 Justin Schuh <jschuh@chromium.org>

Unreviewed, test expectations update.

Flaky expectations for textOnPath.svg.

platform/chromium/test_expectations.txt:

3:41 PM Changeset in webkit [75563] by andersca@apple.com

2 edits in trunk/WebKit2

Build fix.

WebKit2.xcodeproj/project.pbxproj:

3:40 PM Changeset in webkit [75562] by andersca@apple.com

2 edits
2 adds in trunk/WebKit2

2011-01-11 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add a Region class which represents a graphical region
https://bugs.webkit.org/show_bug.cgi?id=52255

Platform/Region.cpp: Added. (WebKit::Region::Region): (WebKit::Region::rects): (WebKit::Region::Shape::Shape): (WebKit::Region::Shape::appendSpan): (WebKit::Region::Shape::canCoalesce): (WebKit::Region::Shape::appendSpans): (WebKit::Region::Shape::appendSegment): (WebKit::Region::Shape::spans_begin): (WebKit::Region::Shape::spans_end): (WebKit::Region::Shape::segments_begin): (WebKit::Region::Shape::segments_end): (WebKit::Region::Shape::dump): (WebKit::Region::Shape::bounds): (WebKit::Region::Shape::move): (WebKit::Region::Shape::swap): (WebKit::Region::Shape::shapeOperation): (WebKit::Region::Shape::UnionOperation::trySimpleOperation): (WebKit::Region::Shape::unionShapes): (WebKit::Region::Shape::IntersectOperation::trySimpleOperation): (WebKit::Region::Shape::intersectShapes): (WebKit::Region::Shape::SubtractOperation::trySimpleOperation): (WebKit::Region::Shape::subtractShapes): (WebKit::Region::dump): (WebKit::Region::intersect): (WebKit::Region::unite): (WebKit::Region::subtract): (WebKit::Region::move):
Platform/Region.h: Added. (WebKit::Region::bounds): (WebKit::Region::isEmpty): (WebKit::Region::Span::Span): (WebKit::Region::Shape::isEmpty):
WebKit2.xcodeproj/project.pbxproj:

3:35 PM Changeset in webkit [75561] by tony@chromium.org

2 edits in trunk/WebKit/chromium

2011-01-11 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

[chromium] copy test netscape plugin into TestNetscapePlugin
https://bugs.webkit.org/show_bug.cgi?id=52232

WebKit.gyp: Make a copy of the TestNetscapePlugIn in

TestNetscapePlugIn and WebKitTestNetscapePlugIn

3:19 PM Changeset in webkit [75560] by simonjam@chromium.org

16 edits in trunk

2011-01-11 James Simonsen <simonjam@chromium.org>

Reviewed by Eric Seidel.

[Web Timing] Rename sslHandshakeStart to secureConnectionStart
https://bugs.webkit.org/show_bug.cgi?id=52239

fast/dom/Window/window-properties-performance-expected.txt:
fast/dom/script-tests/webtiming.js: (checkTimingBeforeLoad): (checkTimingWhileDeferred): (checkWebTimingOnDOMContentLoaded): (checkWebTimingWhileAsync): (checkWebTimingOnLoad): (checkWebTimingAfterLoad):
fast/dom/webtiming-document-open-expected.txt:
fast/dom/webtiming-expected.txt:
fast/dom/webtiming-navigate-within-document-expected.txt:
http/tests/misc/resources/webtiming-cross-origin-and-back2.html:
http/tests/misc/resources/webtiming-cross-origin-redirect.html:
http/tests/misc/resources/webtiming-no-origin.html:
http/tests/misc/resources/webtiming-ssl.html:
http/tests/misc/webtiming-origins-expected.txt:
http/tests/misc/webtiming-ssl-expected.txt:

2011-01-11 James Simonsen <simonjam@chromium.org>

Reviewed by Eric Seidel.

[Web Timing] Rename sslHandshakeStart to secureConnectionStart
https://bugs.webkit.org/show_bug.cgi?id=52239

page/PerformanceTiming.cpp: (WebCore::PerformanceTiming::secureConnectionStart):
page/PerformanceTiming.h:
page/PerformanceTiming.idl:

3:16 PM Changeset in webkit [75559] by ojan@chromium.org

3 edits in trunk/Websites/bugs.webkit.org

2011-01-11 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

allow sidebysideifying individual files in the code review tool
https://bugs.webkit.org/show_bug.cgi?id=52226

code-review.js:

2:58 PM Changeset in webkit [75558] by andersca@apple.com

9 edits
1 add in trunk/WebKit2

2011-01-11 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Add DidSetSize message
https://bugs.webkit.org/show_bug.cgi?id=52254

DerivedSources.make: Add DrawingAReaProxy.messages.in.

Platform/CoreIPC/MessageID.h: Add DrawingAreaProxy message class.

UIProcess/DrawingAreaProxy.h: (WebKit::DrawingAreaProxy::didSetSize): Add CoreIPC message handler function.

UIProcess/DrawingAreaProxy.messages.in: Added.

UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::didSetSize): Add stub.

UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didReceiveMessage): Handle DrawingAreaProxy messages.

WebKit2.xcodeproj/project.pbxproj: Add new files.

WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::setSize): Send a DidSetSize message for now.

2:53 PM Changeset in webkit [75557] by abarth@webkit.org

5 edits in trunk/Source/WebCore

2011-01-11 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Introduce the notion of a "display-isolated" URL scheme for use by
Chrome-internal URLs
https://bugs.webkit.org/show_bug.cgi?id=50182

This patch actually makes the display-isolated schemes display
isolated. The behavior should be the same as the previous iteration of
this patch, but re-organized a bit because reading the access white
list is expensive.

page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::isAccessToURLWhiteListed): (WebCore::SecurityOrigin::canDisplay):
page/SecurityOrigin.h:
platform/SchemeRegistry.cpp:
platform/SchemeRegistry.h:

2:52 PM Changeset in webkit [75556] by inferno@chromium.org

3 edits
2 adds in branches/chromium/597

2011-01-11 Merge 75548 - BUGCR69275 - Abhishek Arya <inferno@chromium.org>

Reviewed by Dimitri Glazkov.

RefPtr the FrameView to prevent scrollbar from getting deleted inside
its scroll event.
https://bugs.webkit.org/show_bug.cgi?id=52238

Test: scrollbars/scrollable-iframe-remove-crash.html

page/DOMWindow.cpp: (WebCore::DOMWindow::scrollTo):

2011-01-11 Merge 75548 - Abhishek Arya <inferno@chromium.org>

Reviewed by Dimitri Glazkov.

Tests that we do not crash when we remove scrollable iframe when executing
inside its scroll event.
https://bugs.webkit.org/show_bug.cgi?id=52238

scrollbars/scrollable-iframe-remove-crash-expected.txt: Added.
scrollbars/scrollable-iframe-remove-crash.html: Added.

2:47 PM Changeset in webkit [75555] by mihaip@chromium.org

17 edits
4 adds in trunk

2011-01-11 Mihai Parparita <mihaip@chromium.org>

Reviewed by Darin Fisher.

Scroll event should be fired asynchronously
https://bugs.webkit.org/show_bug.cgi?id=45631

Update existing tests that assumed that scroll events fired
synchronously.

editing/input/page-up-down-scrolls-expected.txt:
editing/input/page-up-down-scrolls.html:
fast/events/fire-scroll-event-element-expected.txt: Copied from LayoutTests/fast/events/fire-scroll-event-expected.txt.
fast/events/fire-scroll-event-element.html: Added. Does the same

tests as fire-scroll-event.html, but on an individual element instead
of the whole document.

fast/events/fire-scroll-event-expected.txt:
fast/events/fire-scroll-event.html: Now explicitly tests for

synchronous behavior when scrolling the document, and that we don't
fire the event more than once.

fast/events/remove-child-onscroll.html:
fast/events/scroll-during-zoom-change.html:
fast/events/scroll-event-does-not-bubble.html:
fast/events/scroll-event-phase-expected.txt: Added.
fast/events/scroll-event-phase.html: Added. Checks that we can listen

for scroll events in both the capture and bubble phase.

fast/layers/removed-by-scroll-handler.html:
fast/overflow/onscroll-layer-self-destruct.html:
fast/repaint/repaint-during-scroll.html:

2011-01-11 Mihai Parparita <mihaip@chromium.org>

Reviewed by Darin Fisher.

Scroll event should be fired asynchronously
https://bugs.webkit.org/show_bug.cgi?id=45631

Tests: fast/events/fire-scroll-event.html

fast/events/fire-scroll-event-element.html
fast/events/scroll-event-phase.html

Makes scroll events fire asynchronously to be in compliance with the
CSSOM View Module and consistent with Gecko, Opera and (to some degree)
IE.

Implemented via the EventQueue class added by r74062 (EventQueue now
has a convenience enqueueScrollEvent method).

dom/EventQueue.cpp: (WebCore::EventQueue::enqueueScrollEvent): (WebCore::EventQueue::pendingEventTimerFired):
dom/EventQueue.h:
page/EventHandler.cpp: (WebCore::EventHandler::sendScrollEvent):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollToOffset):
rendering/RenderListBox.cpp: (WebCore::RenderListBox::valueChanged):

2:42 PM Changeset in webkit [75554] by inferno@chromium.org

3 edits
2 adds in branches/chromium/597

2011-01-11 Abhishek Arya <inferno@chromium.org>

Reviewed by Dimitri Glazkov.

RefPtr text node in setOuterText since calling appendData
on a text node can fire away dom event listener which might
remove the text node from underneath.
https://bugs.webkit.org/show_bug.cgi?id=52163

Test: fast/dom/text-node-append-data-remove-crash.html

html/HTMLElement.cpp: (WebCore::HTMLElement::setOuterText):

2011-01-11 Abhishek Arya <inferno@chromium.org>

Reviewed by Dimitri Glazkov.

Tests that calling append data on a text node which removes its
sibling text node does not result in crash.
https://bugs.webkit.org/show_bug.cgi?id=52163

fast/dom/text-node-append-data-remove-crash-expected.txt: Added.
fast/dom/text-node-append-data-remove-crash.html: Added.

2:16 PM Changeset in webkit [75553] by kbr@google.com

5 edits
3 deletes in trunk/WebKit/chromium

2011-01-11 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

[chromium] Move WebGraphicsContext3DDefaultImpl to Chromium repository
https://bugs.webkit.org/show_bug.cgi?id=52235

Deleted WebGraphicsContext3DDefaultImpl, which has been moved to
the Chromium repository under WebGraphicsContext3DInProcessImpl.
Removed WebGraphicsContext3D::createDefault(). Rolled forward
Chromium version to pick up needed changes.

Tested with build-webkit --chromium --debug and a run of the WebGL
layout tests in DRT.

DEPS:
WebKit.gyp:
public/WebGraphicsContext3D.h:
src/GraphicsContext3DChromium.cpp:
src/WebGraphicsContext3D.cpp: Removed.
src/WebGraphicsContext3DDefaultImpl.cpp: Removed.
src/WebGraphicsContext3DDefaultImpl.h: Removed.

2:03 PM Changeset in webkit [75552] by mihaip@chromium.org

10 edits
7 adds in trunk/LayoutTests

2011-01-11 Mihai Parparita <mihaip@chromium.org>

Unreviewed; new and updated mac-leopard baselines.

Update stale or missing Leopard baselines (tests currently pass on Snow
Leopard).

platform/chromium/test_expectations.txt:
platform/mac-leopard/editing/deleting/delete-line-end-ws-001-expected.checksum:
platform/mac-leopard/editing/deleting/delete-line-end-ws-001-expected.png:
platform/mac-leopard/editing/deleting/delete-line-end-ws-002-expected.checksum:
platform/mac-leopard/editing/deleting/delete-line-end-ws-002-expected.png:
platform/mac-leopard/fast/block/basic/016-expected.checksum: Added.
platform/mac-leopard/fast/block/basic/016-expected.png: Added.
platform/mac-leopard/fast/block/basic/truncation-rtl-expected.checksum: Added.
platform/mac-leopard/fast/block/basic/truncation-rtl-expected.png: Added.
platform/mac-leopard/fast/blockflow/fieldsets-expected.checksum: Added.
platform/mac-leopard/fast/blockflow/fieldsets-expected.png: Added.
platform/mac-leopard/fast/borders/border-image-scale-transform-expected.checksum:
platform/mac-leopard/fast/borders/border-image-scale-transform-expected.png:
platform/mac-leopard/tables/mozilla_expected_failures/bugs/bug2479-5-expected.checksum:
platform/mac-leopard/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:

2:03 PM Changeset in webkit [75551] by weinig@apple.com

5 edits in trunk/WebKit2

Fix spelling mistake. Sharable -> Shareable.

Reviewed by Anders Carlsson.

Shared/API/c/WKImage.h:
Shared/API/c/WKSharedAPICast.h:

(WebKit::toImageOptions):

Shared/ImageOptions.h:
Shared/WebImage.cpp:

(WebKit::WebImage::create):

1:53 PM Changeset in webkit [75550] by andersca@apple.com

10 edits
1 add in trunk/WebKit2

2011-01-11 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add SetSize message
https://bugs.webkit.org/show_bug.cgi?id=52247

DerivedSources.make: Add DrawingArea.messages.in

Platform/CoreIPC/MessageID.h: Add DrawingArea message class.

UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::sizeDidChange): Call sendSetSize.

(WebKit::DrawingAreaProxyImpl::sendSetSize):
Send a SetSize message.

UIProcess/DrawingAreaProxyImpl.h: Add setSize override.

WebKit2.xcodeproj/project.pbxproj: Add new files.

WebProcess/WebPage/DrawingArea.h: (WebKit::DrawingArea::setSize): Add setSize member function.

WebProcess/WebPage/DrawingArea.messages.in: Added.

WebProcess/WebPage/DrawingAreaImpl.cpp:
WebProcess/WebPage/DrawingAreaImpl.h: Add setSize.

WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::didReceiveMessage): Handle drawing area messages.

1:33 PM Changeset in webkit [75549] by Patrick Gansterer

2 edits in trunk/Source/WebCore

2011-01-11 Patrick Gansterer <Patrick Gansterer>

Unreviewed WinCE build fix for r75523.

platform/wince/DragDataWinCE.cpp: Added missing include.

1:28 PM Changeset in webkit [75548] by inferno@chromium.org

3 edits
2 adds in trunk

2011-01-11 Abhishek Arya <inferno@chromium.org>

Reviewed by Dimitri Glazkov.

RefPtr the FrameView to prevent scrollbar from getting deleted inside
its scroll event.
https://bugs.webkit.org/show_bug.cgi?id=52238

Test: scrollbars/scrollable-iframe-remove-crash.html

page/DOMWindow.cpp: (WebCore::DOMWindow::scrollTo):

2011-01-11 Abhishek Arya <inferno@chromium.org>

Reviewed by Dimitri Glazkov.

Tests that we do not crash when we remove scrollable iframe when executing
inside its scroll event.
https://bugs.webkit.org/show_bug.cgi?id=52238

scrollbars/scrollable-iframe-remove-crash-expected.txt: Added.
scrollbars/scrollable-iframe-remove-crash.html: Added.

1:24 PM Changeset in webkit [75547] by andersca@apple.com

2 edits in trunk/WebKit2

Replace ASSERTs with FIXMEs.

Reviewed by Sam Weinig.

UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::sizeDidChange):
(WebKit::DrawingAreaProxyImpl::setPageIsVisible):

1:20 PM Changeset in webkit [75546] by andersca@apple.com

4 edits
2 adds in trunk/WebKit2

2011-01-11 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add DrawingAreaImpl skeleton class
https://bugs.webkit.org/show_bug.cgi?id=52246

UIProcess/API/mac/WKView.mm: (useNewDrawingArea): New function which controls which drawing area to use, through an environment variable.

(-[WKView drawRect:]):
Bail if we're using the new drawing area (for now).

(-[WKView WebKit::]):
Create a DrawingAreaProxyImpl when asked to.

WebKit2.xcodeproj/project.pbxproj: Add new files.

WebProcess/WebPage/DrawingArea.cpp: (WebKit::DrawingArea::create): Create a DrawingAreaImpl when asked to.

WebProcess/WebPage/DrawingAreaImpl.cpp: Added.
WebProcess/WebPage/DrawingAreaImpl.h: Added. Add DrawingAreaImpl class.

1:17 PM Changeset in webkit [75545] by Martin Robinson

1 edit
3 deletes in trunk/LayoutTests

2011-01-11 Martin Robinson <mrobinson@igalia.com>

Remove some GTK+-specific baselines. GTK+ now enough feature parity with the Mac
port to make these platform-specific results unnecessary.

platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
platform/gtk/fast/dom/prototype-inheritance-expected.txt: Removed.
platform/gtk/fast/js/global-constructors-expected.txt: Removed.

1:08 PM Changeset in webkit [75544] by thakis@chromium.org

3 edits in trunk/LayoutTests

2011-01-11 Nico Weber <thakis@chromium.org>

Unreviewed, test expectations.

Another new baselines due to updated skia
https://bugs.webkit.org/show_bug.cgi?id=52105

platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.checksum:
platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png:

1:05 PM Changeset in webkit [75543] by Dimitri Glazkov

16 edits
2 adds in trunk

2011-01-08 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by David Hyatt.

Make pseudo-style resolution less hard-coded when used to select a shadow node
https://bugs.webkit.org/show_bug.cgi?id=46595

New test that comprehensively travels the code paths affected by the change.

fast/css/unknown-pseudo-element-matching-expected.txt: Added.
fast/css/unknown-pseudo-element-matching.html: Added.

2011-01-08 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by David Hyatt.

Make pseudo-style resolution less hard-coded when used to select a shadow node
https://bugs.webkit.org/show_bug.cgi?id=46595

Essentially implements the plumbing for the XBL2 pseudo attribute:
http://dev.w3.org/2006/xbl2/#the-pseudo-attribute

Test: fast/css/unknown-pseudo-element-matching.html

css/CSSGrammar.y: Changed to handle specifier_list structure with the

CSSParser::updateSpecifierWithElementName helper, added logic to
keep unknown pseudo-element selectors at the top of the selector chain,
so that we can easily check for them and grab them, and also because
they would either not match anything or act as a descendant selector
(descendant into a shadow DOM subtree that is), not a specifier.

css/CSSParser.cpp: (WebCore::CSSParser::updateSpecifiersWithElementName): Generalized/combined

the logic adding element name to selectors and added the special case
to handle unknown pseudo-element selectors.

css/CSSParser.h: Added def.
css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): Removed any mention of PseudoSliderThumb/SLIDER_THUMB. (WebCore::nameToPseudoTypeMap): Ditto. (WebCore::CSSSelector::extractPseudoType): Ditto.
css/CSSSelector.h: Added a new ShadowDescendant relation type,

removed PseudoSliderThumb def.

(WebCore::CSSSelector::isUnknownPseudoElement): Added a helper method.

css/CSSSelectorList.cpp: (WebCore::SelectorHasUnknownPseudoElementFunctor::operator()): Added a functor

to check for an unknown pseudo-element in the list.

(WebCore::CSSSelectorList::hasUnknownPseudoElements): Added.

css/CSSSelectorList.h: Added a def.
css/CSSStyleSelector.cpp: (WebCore::CSSRuleSet::getPseudoRules): Added accessor to pseudo-element hash. (WebCore::CSSStyleSelector::matchRules): Added matching pseudo elements. (WebCore::CSSStyleSelector::SelectorChecker::checkSelector): Added handling

of ShadowDescendant relation.

(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Enabled handling

of unknown pseudo-element selectors.

(WebCore::CSSRuleSet::addRule): Added populating unknown pseudo-element hash.

css/html.css: (input[type="range"]::-webkit-slider-thumb): Added previously-hard-coded

display:block.

dom/Element.h: (WebCore::Element::shadowPseudoId): Added new virtual method to allow

elements to provide the value of pseudo-element selector they would match.

dom/Node.cpp: (WebCore::Node::querySelector): Added checking for unknown pseudo-element selectors,

so that we can throw a SYNTAX_ERR if found.

(WebCore::Node::querySelectorAll): Ditto.

html/shadow/SliderThumbElement.h: (WebCore::SliderThumbElement::shadowPseudoId): Added to return "-webkit-slider-thumb";
rendering/RenderSlider.cpp: (WebCore::RenderSlider::createThumbStyle): Changed to use the new styleForElement logic.
rendering/style/RenderStyleConstants.h: Removed SLIDER_THUMB.

1:03 PM Changeset in webkit [75542] by dino@apple.com

5 edits in trunk

2011-01-11 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=52233

WebKitCSSMatrix constructor should accept 'none'
as a valid string parameter.

css/WebKitCSSMatrix.cpp: (WebCore::WebKitCSSMatrix::setMatrixValue):

2011-01-11 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=52233

Update WebKitCSSMatrix test to cover a constructor
that accepts 'none' as input.

transforms/cssmatrix-2d-interface-expected.txt:
transforms/cssmatrix-2d-interface.xhtml:

1:00 PM Changeset in webkit [75541] by Dimitri Glazkov

4 edits
2 deletes in branches/chromium/597

Merged r75536.

12:56 PM Changeset in webkit [75540] by andersca@apple.com

5 edits
2 adds in trunk/WebKit2

2011-01-11 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add Mac-only DrawingAreaProxyImpl class skeleton
https://bugs.webkit.org/show_bug.cgi?id=52243

This is the proxy side of a new drawing area implementation. This is Mac only for now
while the design is being fleshed out.

Shared/DrawingAreaInfo.h:
UIProcess/API/mac/WKView.mm: (-[WKView _switchToDrawingAreaTypeIfNecessary:DrawingAreaInfo::]):
UIProcess/DrawingAreaProxyImpl.cpp: Added. (WebKit::DrawingAreaProxyImpl::create): (WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl): (WebKit::DrawingAreaProxyImpl::~DrawingAreaProxyImpl): (WebKit::DrawingAreaProxyImpl::didReceiveMessage): (WebKit::DrawingAreaProxyImpl::didReceiveSyncMessage): (WebKit::DrawingAreaProxyImpl::paint): (WebKit::DrawingAreaProxyImpl::sizeDidChange): (WebKit::DrawingAreaProxyImpl::setPageIsVisible): (WebKit::DrawingAreaProxyImpl::attachCompositingContext): (WebKit::DrawingAreaProxyImpl::detachCompositingContext):
UIProcess/DrawingAreaProxyImpl.h: Added.
WebKit2.xcodeproj/project.pbxproj:
WebProcess/WebPage/DrawingArea.cpp: (WebKit::DrawingArea::create):

12:56 PM Changeset in webkit [75539] by ojan@chromium.org

2 edits in trunk/Websites/bugs.webkit.org

2011-01-11 Ojan Vafai <ojan@chromium.org>

Reviewed by Mihai Parparita.

fix exception when adding a comment to a side-by-side diff
https://bugs.webkit.org/show_bug.cgi?id=52240

prev() and next() won't get the previous and next lines in
side-by-side mode. Instead do a query to find them.

code-review.js:

12:54 PM Changeset in webkit [75538] by ojan@chromium.org

2 edits in trunk/Websites/bugs.webkit.org

2011-01-11 Ojan Vafai <ojan@chromium.org>

Reviewed by Mihai Parparita.

maintain word diffs when converting to side-by-side and back
https://bugs.webkit.org/show_bug.cgi?id=52244

Using textContent would lose the spans use to make the word-diff highlighting.
Just move the span element itself.

code-review.js:

12:47 PM Changeset in webkit [75537] by jamesr@google.com

11 edits in trunk/Source/WebCore

2011-01-11 James Robinson <jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

Set all RenderBlocks as replaced when an inline display type is specified
https://bugs.webkit.org/show_bug.cgi?id=50858

When a RenderBlock is created for an element with a specified display:inline style,
it should always be treated as inline-block. This situations often comes up for form
controls. Previously, RenderBlock::styleWillChange set the replaced flag for display
values of inline-block, inline-table, and inline-table and a number of subclasses of
RenderBlock set the replaced flag in styleDidChange for a display:inline. However
sometimes new subclasses would miss this step leading to bugs (such as with RenderDetails).
This patch sets the replaced flag for all inline display types in RenderBlock::styleWillChange.

Code cleanup only, no change in behavior so no new tests.

rendering/RenderBlock.cpp: (WebCore::RenderBlock::styleWillChange):
rendering/RenderButton.cpp: (WebCore::RenderButton::styleDidChange):
rendering/RenderFieldset.cpp:
rendering/RenderFieldset.h:
rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::styleDidChange):
rendering/RenderListBox.cpp:
rendering/RenderListBox.h:
rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::styleDidChange):
rendering/RenderSlider.cpp: (WebCore::RenderSlider::styleDidChange):
rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::styleDidChange):

12:44 PM Changeset in webkit [75536] by Dimitri Glazkov

5 edits
2 deletes in trunk

2011-01-11 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

REGRESSION(r71934) Can't type in search edit field on skin-one.com
https://bugs.webkit.org/show_bug.cgi?id=52195

Restored original (pre-71934) check in the test to ensure that
selectstart does not propagate outside of the shadow DOM.

Consolidated shadow-boundary-crossing-2.html into shadow-boundary-crossing.html.

fast/events/shadow-boundary-crossing-2-expected.txt: Renamed to

shadow-boundary-crossing-expected.txt.

fast/events/shadow-boundary-crossing-2.html: Renamed to

shadow-boundary-crossing.html.

fast/events/shadow-boundary-crossing-expected.txt: Removed.
fast/events/shadow-boundary-crossing.html: Removed after folding the

test into the new shadow-boundary-crossing.html.

2011-01-11 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

REGRESSION(r71934) Can't type in search edit field on skin-one.com
https://bugs.webkit.org/show_bug.cgi?id=52195

Restored the original behavior, where the selectstart event is not
dispatched when selection changes inside of the shadow DOM.

dom/Node.cpp: (WebCore::determineDispatchBehavior): Moved EventDispatchBehavior-determining

logic into a helper function, also added a check to keep selectstart

events inside of the shadow DOM.

(WebCore::Node::dispatchGenericEvent): Changed to use the helper function.

12:39 PM Changeset in webkit [75535] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

2011-01-11 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>

Reviewed by Eric Seidel.

[Qt] Provide plugin coordinates to windowless plugins on Symbian.
https://bugs.webkit.org/show_bug.cgi?id=52213

plugins/symbian/PluginViewSymbian.cpp: (WebCore::PluginView::setNPWindowIfNeeded):

12:34 PM Changeset in webkit [75534] by zmo@google.com

2 edits in trunk/LayoutTests

2011-01-11 Zhenyao Mo <zmo@google.com>

Unreviewed, test expectation update.

platform/mac-snowleopard/Skipped:

12:33 PM Changeset in webkit [75533] by Laszlo Gombos

2 edits in trunk

2011-01-11 Laszlo Gombos <Laszlo Gombos>

Reviewed by Csaba Osztrogonác.

[Qt] Add QT_NO_CONCURRENT to the qt_minimal configuration
https://bugs.webkit.org/show_bug.cgi?id=52223

Add QT_NO_CONCURRENT to the qt_minimal configuration to make sure
that QtWebKit builds with QT_NO_CONCURRENT defined.

WebKit.pri:

12:28 PM Changeset in webkit [75532] by andersca@apple.com

2 edits in trunk/WebKit2

Fix Windows build.

WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp:

(WebKit::WebPopupMenu::setUpPlatformData):

12:24 PM Changeset in webkit [75531] by msaboff@apple.com

3 edits
3 adds in trunk

2011-01-11 Michael Saboff <msaboff@apple.com>

Reviewed by Geoffrey Garen.

Missing call to popTempSortVector() for exception case in JSArray::sort.
https://bugs.webkit.org/show_bug.cgi?id=50718

Fix to patch of 50718 that added pushTempSortVector() and
popTempSortVector() to JSArray::sort() to mark elements during sort.
Need to add popTempSortVector() for the return case if toString()
had an exception.

runtime/JSArray.cpp: (JSC::JSArray::sort): Added popTempSortVector()

2011-01-11 Michael Saboff <msaboff@apple.com>

Reviewed by Geoffrey Garen.

Missing call to popTempSortVector() for exception case in JSArray::sort.
https://bugs.webkit.org/show_bug.cgi?id=50718

New test to validate balanced calls to pushTempSortVector() and
popTempSortVector().

fast/js/array-sort-exception-expected.txt: Added.
fast/js/array-sort-exception.html: Added.
fast/js/script-tests/array-sort-exception.js: Added. (do_gc): (Item): (toString_throw): (test):

12:22 PM Changeset in webkit [75530] by zmo@google.com

3 edits in trunk/LayoutTests

2011-01-11 Zhenyao Mo <zmo@google.com>

Unreviewed, test expectations update.

platform/chromium-gpu/test_expectations.txt:
platform/chromium/test_expectations.txt:

12:21 PM Changeset in webkit [75529] by ojan@chromium.org

2 edits in trunk/Websites/bugs.webkit.org

2011-01-11 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

fix layout error with comments in code review tool
https://bugs.webkit.org/show_bug.cgi?id=52230

PrettyPatch/PrettyPatch.rb:

12:20 PM Changeset in webkit [75528] by andersca@apple.com

7 edits in trunk/WebKit2

2011-01-11 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Rename ShareableBitmap::createSharable to createShareable
https://bugs.webkit.org/show_bug.cgi?id=52234

Shared/ShareableBitmap.cpp: (WebKit::ShareableBitmap::createShareable):
Shared/ShareableBitmap.h:
Shared/WebImage.cpp: (WebKit::WebImage::create):
WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::geometryDidChange):
WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp: (WebKit::WebPopupMenu::setUpPlatformData):
WebProcess/WebPage/FindController.cpp: (WebKit::FindController::updateFindIndicator):

12:13 PM Changeset in webkit [75527] by andersca@apple.com

21 edits
5 moves in trunk/WebKit2

2011-01-11 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Rename BackingStore to ShareableBitmap
https://bugs.webkit.org/show_bug.cgi?id=52228

GNUmakefile.am:
PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::geometryDidChange):
PluginProcess/PluginControllerProxy.h:
Shared/API/c/cg/WKImageCG.cpp: (WKImageCreateCGImage):
Shared/BackingStore.cpp: Removed.
Shared/BackingStore.h: Removed.
Shared/PlatformPopupMenuData.cpp: (WebKit::PlatformPopupMenuData::decode):
Shared/PlatformPopupMenuData.h:
Shared/ShareableBitmap.cpp: Copied from WebKit2/Shared/BackingStore.cpp. (WebKit::ShareableBitmap::create): (WebKit::ShareableBitmap::createSharable): (WebKit::ShareableBitmap::createHandle): (WebKit::ShareableBitmap::ShareableBitmap): (WebKit::ShareableBitmap::~ShareableBitmap): (WebKit::ShareableBitmap::resize): (WebKit::ShareableBitmap::data):
Shared/ShareableBitmap.h: Copied from WebKit2/Shared/BackingStore.h.
Shared/UserMessageCoders.h: (WebKit::UserMessageEncoder::baseEncode): (WebKit::UserMessageDecoder::baseDecode):
Shared/WebImage.cpp: (WebKit::WebImage::create): (WebKit::WebImage::WebImage): (WebKit::WebImage::~WebImage): (WebKit::WebImage::size):
Shared/WebImage.h: (WebKit::WebImage::bitmap):
Shared/cairo/BackingStoreCairo.cpp: (WebKit::ShareableBitmap::createGraphicsContext): (WebKit::ShareableBitmap::paint):
Shared/cg/BackingStoreCG.cpp: Removed.
Shared/cg/ShareableBitmapCG.cpp: Copied from WebKit2/Shared/cg/BackingStoreCG.cpp. (WebKit::ShareableBitmap::createGraphicsContext): (WebKit::ShareableBitmap::paint):
Shared/gtk/BackingStoreGtk.cpp: Removed.
Shared/gtk/ShareableBitmapGtk.cpp: Copied from WebKit2/Shared/gtk/BackingStoreGtk.cpp. (WebKit::ShareableBitmap::createGraphicsContext): (WebKit::ShareableBitmap::paint):
Shared/qt/BackingStoreQt.cpp: Removed.
Shared/qt/ShareableBitmapQt.cpp: Copied from WebKit2/Shared/qt/BackingStoreQt.cpp. (WebKit::ShareableBitmap::createGraphicsContext): (WebKit::ShareableBitmap::paint):
UIProcess/FindIndicator.cpp: (WebKit::FindIndicator::create): (WebKit::FindIndicator::FindIndicator):
UIProcess/FindIndicator.h: (WebKit::FindIndicator::contentImage):
WebKit2.pro:
WebKit2.xcodeproj/project.pbxproj:
WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::geometryDidChange):
WebProcess/Plugins/PluginProxy.h:
WebProcess/WebPage/FindController.cpp: (WebKit::FindController::updateFindIndicator):
WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::snapshotInViewCoordinates): (WebKit::WebPage::snapshotInDocumentCoordinates):
win/WebKit2.vcproj:

12:12 PM Changeset in webkit [75526] by thakis@chromium.org

3 edits in trunk/LayoutTests

2011-01-11 Nico Weber <thakis@chromium.org>

Unreviewed, test expectations.

Another baseline for the recent skia roll.
https://bugs.webkit.org/show_bug.cgi?id=52105

platform/chromium-linux/svg/custom/focus-ring-expected.checksum:
platform/chromium-linux/svg/custom/focus-ring-expected.png:

12:05 PM Changeset in webkit [75525] by sullivan@apple.com

2 edits in trunk/WebKit2

[WKView setFrameSize:] derefs _page->drawingArea() without null check
<https://bugs.webkit.org/show_bug.cgi?id=52231>

Reviewed by Anders Carlsson.

UIProcess/API/mac/WKView.mm:

(-[WKView setFrameSize:]):
Null check drawingArea(). This is OK because if it doesn't exist then it will be
created later with the correct initial size.

11:49 AM Changeset in webkit [75524] by zmo@google.com

8 edits in trunk

2011-01-10 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Need to consider UNPACK_ALIGNMENT in GraphicsContext3D::texImage2DResourceSafe
https://bugs.webkit.org/show_bug.cgi?id=52068

html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::copyTexImage2D): Use computeImageSizeInBytes. (WebCore::WebGLRenderingContext::copyTexSubImage2D): Ditto. (WebCore::WebGLRenderingContext::readPixels): Ditto, and fix a bug on generating the wrong error. (WebCore::WebGLRenderingContext::texImage2DBase): Ditto. (WebCore::WebGLRenderingContext::validateTexFuncData): Use computeImageSizeInBytes.
platform/graphics/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::texImage2DResourceSafe): Add a new parameter alignment. (WebCore::GraphicsContext3D::computeFormatAndTypeParameters): Add more supported format/type. (WebCore::GraphicsContext3D::computeImageSizeInBytes): Added.
platform/graphics/GraphicsContext3D.h:

2011-01-10 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Need to consider UNPACK_ALIGNMENT in GraphicsContext3D::texImage2DResourceSafe
https://bugs.webkit.org/show_bug.cgi?id=52068

fast/canvas/webgl/read-pixels-test-expected.txt:
fast/canvas/webgl/read-pixels-test.html: Sync with khronos.
fast/canvas/webgl/resources/webgl-test.js: Add finishTest().

11:47 AM Changeset in webkit [75523] by enrica@apple.com

39 edits
2 deletes in trunk

Source/WebCore: Paste and drag and drop use different code paths to interact with the pasteboard.
https://bugs.webkit.org/show_bug.cgi?id=52093
The change consists in a refactoring of the code to have only one class that
deals with the pasteboard on Mac.

Reviewed by Alexey Proskuryakov.

No new tests. A test is already available for this
(editing/pasteboard/drag-image-to-contenteditable-in-iframe.html) but had incorrect results.

WebCore.exp.in:
loader/EmptyClients.h: Added two Mac only methods to call into WebKit to use functionality

that is in NSURLExtras.
(WebCore::EmptyEditorClient::canonicalizeURL):
(WebCore::EmptyEditorClient::canonicalizeURLString):

page/DragController.cpp:

The following methods have been changed to pass a pointer to the Frame object
to the DragData class.
(WebCore::documentFragmentFromDragData):
(WebCore::DragController::performDrag):
(WebCore::DragController::dispatchTextInputEventFor):
(WebCore::DragController::concludeEditDrag):

page/EditorClient.h: Added two Mac only methods to call into WebKit to use functionality

that is in NSURLExtras.
The following files have been modified to pass the Frame object to the DragData method calls.

page/chromium/DragControllerChromium.cpp: