Timeline
Jan 14, 2011:
- 10:48 PM Changeset in webkit [75873] by
-
- 5 edits in trunk/WebKit/mac
2011-01-14 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Plugins render incorrectly with transformed ancestors
https://bugs.webkit.org/show_bug.cgi?id=52507
-[NSView visibleRect] gives the wrong answer if there are CSS transforms
in the ancestor chain of a plugin.
So use of this method with calls to -actualVisibleRectInWindow, which
maps rects through the render tree to compute the correct rect,
clipping via windowClipRect() if necessary.
Not testable, because doing so relies on the behavior of some
plugins, which stop rendering if setWindow passes an empty rect.
- Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView updateAndSetWindow]):
- Plugins/WebBaseNetscapePluginView.h:
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView actualVisibleRectInWindow]):
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
- 10:35 PM Changeset in webkit [75872] by
-
- 5 edits in trunk
2011-01-14 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
[jsfunfuzz] Incorrect handling of consecutive duplicate labels
https://bugs.webkit.org/show_bug.cgi?id=52505
Add a few tests of consecutive labels containing duplicates to the parser check.
- fast/js/parser-syntax-check-expected.txt:
- fast/js/script-tests/parser-syntax-check.js:
2011-01-14 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
[jsfunfuzz] Incorrect handling of consecutive duplicate labels
https://bugs.webkit.org/show_bug.cgi?id=52505
Compare StringImpl*'s instead of Identifier*'s when looking for duplicate
labels.
- parser/JSParser.cpp: (JSC::JSParser::parseExpressionOrLabelStatement):
- 10:01 PM Changeset in webkit [75871] by
-
- 2 edits in trunk/WebKit/chromium
2011-01-14 Xiyuan Xia <xiyuan@chromium.org>
Reviewed by Darin Fisher.
Prepare Linux WebThemeEngine interface to support new theme parts.
https://bugs.webkit.org/show_bug.cgi?id=52413
- public/linux/WebThemeEngine.h:
- 9:38 PM Changeset in webkit [75870] by
-
- 12 edits in trunk
2011-01-14 Sam Magnuson <smagnuso@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Compile with QT_NO_GRAPHICSVIEW
https://bugs.webkit.org/show_bug.cgi?id=49750
- platform/graphics/qt/GraphicsLayerQt.cpp:
- platform/graphics/qt/GraphicsLayerQt.h:
- platform/qt/PlatformMouseEventQt.cpp:
2011-01-14 Sam Magnuson <smagnuso@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Compile with QT_NO_GRAPHICSVIEW
https://bugs.webkit.org/show_bug.cgi?id=49750
- Api/qgraphicswebview.cpp:
- Api/qgraphicswebview.h:
- Api/qwebpage.cpp: (QWebPage::event):
- Api/qwebpage_p.h:
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createPlugin):
- WebCoreSupport/PageClientQt.cpp:
- WebCoreSupport/PageClientQt.h:
- 8:20 PM Changeset in webkit [75869] by
-
- 5 edits1 delete in trunk/LayoutTests
Not reviewed, update of Chromium test expectations.
Update of files affected by mass rebaseline in r75828 and r75838
- platform/chromium-mac/animations/3d/state-at-end-event-transform-expected.checksum:
- platform/chromium-mac/animations/3d/state-at-end-event-transform-expected.png:
- platform/chromium-mac/plugins/embed-attributes-style-expected.txt: Removed.
- platform/chromium-mac/svg/custom/svg-curve-with-relative-cordinates-expected.checksum:
- platform/chromium-mac/svg/custom/svg-curve-with-relative-cordinates-expected.png:
- 7:53 PM Changeset in webkit [75868] by
-
- 1 edit in trunk/Source/JavaScriptCore/ChangeLog
2011-01-14 Simon Fraser <Simon Fraser>
No review.
Initialize m_operationInProgress after r75855.
- runtime/Heap.cpp: (JSC::Heap::Heap):
- 7:32 PM Changeset in webkit [75867] by
-
- 2 edits in trunk/Source/JavaScriptCore
Reverted accidentally committed code from my last checkin.
- runtime/Heap.cpp:
(JSC::Heap::markRoots):
- 7:28 PM Changeset in webkit [75866] by
-
- 2 edits in trunk/Source/JavaScriptCore
Try to fix the GTK bot.
Reviewed by Sam Weinig.
- runtime/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::markRoots): Kids, remember to initialize your data members.
Knowing is half the battle.
- 6:33 PM Changeset in webkit [75865] by
-
- 2 edits in trunk/LayoutTests
Not reviewed, update of test expectations.
Ignore new test fast/js/js-continue-break-restrictions.html, it fails for V8.
- platform/chromium/test_expectations.txt:
- 6:26 PM Changeset in webkit [75864] by
-
- 2 edits6 adds in trunk/LayoutTests
2011-01-14 Eric Uhrhane <ericu@chromium.org>
Reviewed by David Levin.
Add tests for FileWriterSync
https://bugs.webkit.org/show_bug.cgi?id=50720
- fast/filesystem/resources/file-writer-sync-truncate-extend.js: Added.
- fast/filesystem/workers/file-writer-sync-truncate-extend.html: Added.
- fast/filesystem/workers/file-writer-sync-truncate-extend-expected.txt: Added.
- fast/filesystem/resources/file-writer-sync-write-overlapped.js: Added.
- fast/filesystem/workers/file-writer-sync-write-overlapped.html: Added.
- fast/filesystem/workers/file-writer-sync-write-overlapped-expected.txt: Added.
- fast/filesystem/resources/file-writer-utils.js: (assert): Make assert throw, rather than continue. (cleanUp): Always call finishJSTest, even without fileEntryForCleanup.
- 6:22 PM Changeset in webkit [75863] by
-
- 3 edits in trunk/WebKit/efl
2011-01-14 Patrick Gansterer <Patrick Gansterer>
Unreviewed. Try to fix EFL build.
- ewk/ewk_frame.cpp: (ewk_frame_scroll_add): Added WebCore namespace to IntSize.
- ewk/ewk_view.cpp: (_ewk_view_viewport_attributes_compute): Ditto.
- 6:14 PM Changeset in webkit [75862] by
-
- 5 edits in trunk
2011-01-14 Oliver Hunt <oliver@apple.com>
Reviewed by Stephanie Lewis.
[jsfunfuzz] We should be clearing the lexers temporary character buffers when switching to strict mode
https://bugs.webkit.org/show_bug.cgi?id=52501
Add checks for correct behaviour when the strict mode token is immediately followed
by a value that needs a temporary buffer in the lexer.
- fast/js/basic-strict-mode-expected.txt:
- fast/js/script-tests/basic-strict-mode.js:
2011-01-14 Oliver Hunt <oliver@apple.com>
Reviewed by Stephanie Lewis.
[jsfunfuzz] We should be clearing the lexers temporary character buffers when switching to strict mode
https://bugs.webkit.org/show_bug.cgi?id=52501
Clear the temporary character buffers used for reading escaped characters and
numbers.
- parser/Lexer.h: (JSC::Lexer::setOffset):
- 6:06 PM Changeset in webkit [75861] by
-
- 4 edits2 adds in trunk
2011-01-14 Tony Chang <tony@chromium.org>
Reviewed by Alexey Proskuryakov.
Strip NUL character when copying text on Windows
https://bugs.webkit.org/show_bug.cgi?id=52236
- editing/pasteboard/copy-null-characters-expected.txt: Added.
- editing/pasteboard/copy-null-characters.html: Added.
2011-01-14 Tony Chang <tony@chromium.org>
Reviewed by Alexey Proskuryakov.
Strip NUL character when copying text on Windows
https://bugs.webkit.org/show_bug.cgi?id=52236
Test: editing/pasteboard/copy-null-characters.html
- editing/Editor.cpp: (WebCore::Editor::selectedText):
- platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeSelection): Use editor()->selectedText() which matches the other platforms.
- 6:00 PM Changeset in webkit [75860] by
-
- 4 edits in tags/Safari-534.15.8/WebCore
Merge r75758.
- 6:00 PM Changeset in webkit [75859] by
-
- 3 edits in tags/Safari-534.15.8/WebKit/mac
Merge r75829.
- 6:00 PM Changeset in webkit [75858] by
-
- 5 edits in tags/Safari-534.15.8
Versioning.
- 5:59 PM Changeset in webkit [75857] by
-
- 32 edits in trunk
2011-01-14 Yuzo Fujishima <yuzo@google.com>
Reviewed by Antti Koivisto.
Rename cache() to memoryCache()
https://bugs.webkit.org/show_bug.cgi?id=52433
No new tests because the behavior remains the same.
- WebCore.exp.in:
- WebCore.order:
- history/PageCache.cpp: (WebCore::PageCache::releaseAutoreleasedPagesNow):
- inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::cachedResource):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::tellClientAboutPastMemoryCacheLoads):
- loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::create):
- loader/cache/CachedImage.cpp: (WebCore::CachedImage::allClientsRemoved): (WebCore::CachedImage::data):
- loader/cache/CachedResource.cpp: (WebCore::CachedResource::~CachedResource): (WebCore::CachedResource::addClientToSet): (WebCore::CachedResource::removeClient): (WebCore::CachedResource::setDecodedSize): (WebCore::CachedResource::setEncodedSize): (WebCore::CachedResource::didAccessDecodedData):
- loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::CachedResourceLoader): (WebCore::CachedResourceLoader::requestUserCSSStyleSheet): (WebCore::CachedResourceLoader::requestResource): (WebCore::CachedResourceLoader::revalidateResource): (WebCore::CachedResourceLoader::loadResource): (WebCore::CachedResourceLoader::clearPreloads): (WebCore::CachedResourceLoader::printPreloadStats):
- loader/cache/CachedResourceRequest.cpp: (WebCore::CachedResourceRequest::load): (WebCore::CachedResourceRequest::didFail): (WebCore::CachedResourceRequest::didReceiveResponse):
- loader/cache/MemoryCache.cpp: (WebCore::memoryCache):
- loader/cache/MemoryCache.h:
2011-01-14 Yuzo Fujishima <yuzo@google.com>
Reviewed by Antti Koivisto.
Rename cache() to memoryCache()
https://bugs.webkit.org/show_bug.cgi?id=52433
- src/WebCache.cpp: (WebKit::WebCache::setCapacities): (WebKit::WebCache::clear): (WebKit::WebCache::getUsageStats): (WebKit::WebCache::getResourceTypeStats):
2011-01-14 Yuzo Fujishima <yuzo@google.com>
Reviewed by Antti Koivisto.
Rename cache() to memoryCache()
https://bugs.webkit.org/show_bug.cgi?id=52433
- webkit/webkitglobals.cpp: (webkit_set_cache_model):
2011-01-14 Yuzo Fujishima <yuzo@google.com>
Reviewed by Antti Koivisto.
Rename cache() to memoryCache()
https://bugs.webkit.org/show_bug.cgi?id=52433
- Misc/WebCache.mm: (+[WebCache statistics]): (+[WebCache setDisabled:]): (+[WebCache isDisabled]):
- WebView/WebView.mm: (+[WebView _setCacheModel:]):
2011-01-14 Yuzo Fujishima <yuzo@google.com>
Reviewed by Antti Koivisto.
Rename cache() to memoryCache()
https://bugs.webkit.org/show_bug.cgi?id=52433
- Api/qwebpage.cpp: (QWebPagePrivate::_q_cleanupLeakMessages):
- Api/qwebsettings.cpp: (QWebSettings::clearMemoryCaches): (QWebSettings::setObjectCacheCapacities):
2011-01-14 Yuzo Fujishima <yuzo@google.com>
Reviewed by Antti Koivisto.
Rename cache() to memoryCache()
https://bugs.webkit.org/show_bug.cgi?id=52433
- WebCache.cpp: (WebCache::statistics): (WebCache::empty): (WebCache::setDisabled): (WebCache::disabled):
- WebView.cpp: (WebView::setCacheModel):
2011-01-14 Yuzo Fujishima <yuzo@google.com>
Reviewed by Antti Koivisto.
Rename cache() to memoryCache()
https://bugs.webkit.org/show_bug.cgi?id=52433
- WebView.cpp: (wxWebView::SetCachePolicy):
2011-01-14 Yuzo Fujishima <yuzo@google.com>
Reviewed by Antti Koivisto.
Rename cache() to memoryCache()
https://bugs.webkit.org/show_bug.cgi?id=52433
- WebProcess/WebProcess.cpp: (WebKit::WebProcess::shutdownIfPossible): (WebKit::WebProcess::didClose):
- WebProcess/mac/WebProcessMac.mm: (WebKit::WebProcess::platformSetCacheModel):
- WebProcess/win/WebProcessWin.cpp: (WebKit::WebProcess::platformSetCacheModel):
- 5:52 PM Changeset in webkit [75856] by
-
- 2 edits in trunk/Source/JavaScriptCore
Try to fix non-Dtrace builds: #include Tracing.h instead of TracingDtrace.h.
- runtime/Heap.cpp:
- 5:43 PM Changeset in webkit [75855] by
-
- 18 edits2 copies in trunk
2011-01-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Split out a MarkedSpace strategy object from Heap.
https://bugs.webkit.org/show_bug.cgi?id=52421
- Misc/WebCoreStatistics.mm: (+[WebCoreStatistics memoryStatistics]): Updated for class move.
2011-01-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Split out a MarkedSpace strategy object from Heap.
https://bugs.webkit.org/show_bug.cgi?id=52421
SunSpider reports no change.
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- JavaScriptCore.gypi:
- JavaScriptCore.pro:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj: Updated our 7 build systems. Which is cool.
- runtime/Heap.cpp: (JSC::Heap::Heap): (JSC::Heap::destroy): (JSC::Heap::recordExtraCost): (JSC::Heap::allocate): (JSC::Heap::markConservatively): (JSC::Heap::markRoots): (JSC::Heap::objectCount): (JSC::Heap::statistics): (JSC::Heap::size): (JSC::Heap::isBusy): (JSC::Heap::collectAllGarbage): (JSC::Heap::primaryHeapBegin): (JSC::Heap::primaryHeapEnd):
- runtime/Heap.h: (JSC::Heap::globalData): (JSC::Heap::markedSpace): (JSC::Heap::isCellMarked): (JSC::Heap::checkMarkCell): (JSC::Heap::markCell): Moved all code pertaining to managing chunks of collector memory out of this class. Heap now just delegates to MarkedSpace.
- runtime/JSCell.h: (JSC::JSCell::Heap::heap): Updated for MarkedSpace delegation.
- runtime/JSValue.h: Moved the ValueStringPair typedef to help with #includes.
- runtime/MarkedSpace.cpp: Copied from runtime/Heap.cpp. (JSC::MarkedSpace::MarkedSpace): (JSC::MarkedSpace::destroy): (JSC::MarkedSpace::allocateBlock): (JSC::MarkedSpace::freeBlock): (JSC::MarkedSpace::allocate): (JSC::MarkedSpace::resizeBlocks): (JSC::MarkedSpace::growBlocks): (JSC::MarkedSpace::shrinkBlocks): (JSC::MarkedSpace::markConservatively): (JSC::MarkedSpace::clearMarkBits): (JSC::MarkedSpace::markedCells): (JSC::MarkedSpace::sweep): (JSC::MarkedSpace::objectCount): (JSC::MarkedSpace::addToStatistics): (JSC::MarkedSpace::statistics): (JSC::MarkedSpace::size): (JSC::MarkedSpace::reset): (JSC::MarkedSpace::primaryHeapBegin): (JSC::MarkedSpace::primaryHeapEnd):
- runtime/MarkedSpace.h: Copied from runtime/Heap.h. (JSC::MarkedSpace::globalData): (JSC::MarkedSpace::didShrink): (JSC::MarkedSpace::cellBlock): (JSC::MarkedSpace::cellOffset): (JSC::MarkedSpace::isCellMarked): (JSC::MarkedSpace::checkMarkCell): (JSC::MarkedSpace::markCell): Moved all code pertaining to managing chunks of collector memory into this class.
- runtime/MemoryStatistics.cpp: (JSC::heapStatistics):
- runtime/MemoryStatistics.h: Updated for MarkedSpace delegation.
2011-01-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Split out a MarkedSpace strategy object from Heap.
https://bugs.webkit.org/show_bug.cgi?id=52421
- Shared/mac/WebMemorySampler.mac.mm: (WebKit::WebMemorySampler::sampleWebKit): Updated for class move.
- 5:40 PM Changeset in webkit [75854] by
-
- 5 edits in trunk/LayoutTests
2011-01-14 Nico Weber <thakis@chromium.org>
Unreviewed, test expectations.
Rebaseline gradient test due to updated skia. reed checked the test and
says the new look is right and is an intentional change.
https://bugs.webkit.org/show_bug.cgi?id=52105
- platform/chromium-linux/svg/batik/paints/gradientLimit-expected.checksum:
- platform/chromium-linux/svg/batik/paints/gradientLimit-expected.png:
- platform/chromium-win/svg/batik/paints/gradientLimit-expected.checksum:
- platform/chromium-win/svg/batik/paints/gradientLimit-expected.png:
- 5:31 PM Changeset in webkit [75853] by
-
- 10 edits in trunk/WebKit2
2011-01-14 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Add a new PageClient::displayView function and expose it on WebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=52500
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::displayView):
- UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::displayView):
- UIProcess/API/qt/qwkpage_p.h:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::displayView):
- UIProcess/WebPageProxy.h:
- UIProcess/win/WebView.cpp: (WebKit::WebView::displayView):
- UIProcess/win/WebView.h:
- 5:22 PM Changeset in webkit [75852] by
-
- 5 edits3 adds in trunk
2011-01-14 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
[jsfunfuzz] parser doesn't enforce continue restrictions correctly.
https://bugs.webkit.org/show_bug.cgi?id=52493
Add a few tests for continue to cover the cases where continue
isn't syntactically valid.
- fast/js/js-continue-break-restrictions-expected.txt: Added.
- fast/js/js-continue-break-restrictions.html: Added.
- fast/js/script-tests/js-continue-break-restrictions.js: Added.
2011-01-14 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
[jsfunfuzz] parser doesn't enforce continue restrictions correctly.
https://bugs.webkit.org/show_bug.cgi?id=52493
This patch reworks handling of break, continue and label statements
to correctly handle all the valid and invalid cases. Previously certain
errors would be missed by the parser in strict mode, but the bytecode
generator needed to handle those cases for non-strict code so nothing
failed, it simply became non-standard behaviour.
Now that we treat break and continue errors as early faults in non-strict
mode as well that safety net has been removed so the parser bugs result in
crashes at codegen time.
- parser/JSParser.cpp: (JSC::JSParser::ScopeLabelInfo::ScopeLabelInfo): (JSC::JSParser::next): (JSC::JSParser::nextTokenIsColon): (JSC::JSParser::continueIsValid):
Continue is only valid in loops so we can't use breakIsValid()
(JSC::JSParser::pushLabel):
We now track whether the label is for a loop (and is therefore a
valid target for continue.
(JSC::JSParser::popLabel):
(JSC::JSParser::getLabel):
Replace hasLabel with getLabel so that we can validate the target
when parsing continue statements.
(JSC::JSParser::Scope::continueIsValid):
(JSC::JSParser::Scope::pushLabel):
(JSC::JSParser::Scope::getLabel):
(JSC::JSParser::JSParser):
(JSC::JSParser::parseBreakStatement):
(JSC::JSParser::parseContinueStatement):
(JSC::LabelInfo::LabelInfo):
(JSC::JSParser::parseExpressionOrLabelStatement):
Consecutive labels now get handled iteratively so that we can determine
whether they're valid targets for continue.
- parser/Lexer.cpp: (JSC::Lexer::nextTokenIsColon):
- parser/Lexer.h: (JSC::Lexer::setOffset):
- 5:20 PM Changeset in webkit [75851] by
-
- 5 edits1 add in trunk
Source/WebCore: WebCore part of <rdar://problem/8441312> Crash in -[NSView _invalidateGStatesForTree]
Reviewed by Simon Fraser.
- WebCore.exp.in: Export RenderWidget::suspendWidgetHierarchyUpdates() and
RenderWidget::resumeWidgetHierarchyUpdates().
- manual-tests/plug-in-mutates-NSView-hierarchy-during-resize.html: Added.
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidgetGeometry): Removed the assertion that widget hierarchy updates
are disabled. When this assertion was added, this condition was a subset of the “calling out to
plug-in code is forbidden” condition, hence the assertion was valid. The WebKit part of this
change now suspends widget hierarchy updates even at times where plug-in code is expected to be
called, which invalidates the assertion.
WebKit/mac: WebKit/mac part of <rdar://problem/8441312> Crash in -[NSView _invalidateGStatesForTree]
Reviewed by Simon Fraser.
- WebView/WebHTMLView.mm:
(-[WebHTMLView _invalidateGStatesForTree]): Override this NSView method, and bracket the call
to the superclass implementation with suspending WebCore Widget hierarchy updates. This ensures
that the NSView tree doesn’t change from under AppKit as it traverses it.
- 5:19 PM Changeset in webkit [75850] by
-
- 2 edits in trunk
2011-01-14 Ahmad Sharif <asharif.tools@gmail.com>
Reviewed by Darin Fisher.
When inlining is performed, the progress variable is
declared as uninitialized.
https://bugs.webkit.org/show_bug.cgi?id=51084
- WebCore: Copied from WebCore.
- WebCore/page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::animate): (WebCore::KeyframeAnimation::getAnimatedStyle):
- 5:18 PM Changeset in webkit [75849] by
-
- 2 edits in trunk/WebKit2
2011-01-14 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Implement the "should paint bounds instead of indiviual rects" algorithm from WebKit1
https://bugs.webkit.org/show_bug.cgi?id=52499
- WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::shouldPaintBoundsRect): Port code from -[WebView _mustDrawUnionedRect:singleRects:count:].
(WebKit::DrawingAreaImpl::display):
If shouldPaintBoundsRect returns true, clear the rects vector and append the bounds rect.
- 5:17 PM Changeset in webkit [75848] by
-
- 4 edits in trunk
2011-01-14 Tony Gentilcore <tonyg@chromium.org>
Unreviewed build fix.
Fix Qt build after r75837
https://bugs.webkit.org/show_bug.cgi?id=52494
- rendering/style/StyleRareInheritedData.cpp:
- rendering/style/StyleRareNonInheritedData.cpp:
- 5:15 PM Changeset in webkit [75847] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
2011-01-14 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
fix expanded lines in the code review tool
https://bugs.webkit.org/show_bug.cgi?id=52498
Fixes them to work now that we have wrapper divs.
Also fixes the long-standing bug that the line numbers
were incorrect sometimes.
- code-review.js:
- 5:08 PM Changeset in webkit [75846] by
-
- 4 edits in trunk
2011-01-14 Tony Gentilcore <tonyg@chromium.org>
Unreviewed build fix.
Fix Qt build after r75837
https://bugs.webkit.org/show_bug.cgi?id=52494
- rendering/style/RenderStyle.cpp:
2011-01-14 Tony Gentilcore <tonyg@chromium.org>
Unreviewed build fix.
Fix Qt build after r75837
https://bugs.webkit.org/show_bug.cgi?id=52494
- ewk/ewk_view.cpp:
- 5:02 PM Changeset in webkit [75845] by
-
- 3 edits in trunk/Websites/bugs.webkit.org
2011-01-14 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
put remove lines to the left of add lines in sidebyside view
https://bugs.webkit.org/show_bug.cgi?id=52458
Also, sneaking in a fix to make long lines with no whitespace wrap.
- PrettyPatch/PrettyPatch.rb:
- code-review.js:
- 5:00 PM Changeset in webkit [75844] by
-
- 2 edits in trunk/Source/WebCore
2011-01-14 Tony Gentilcore <tonyg@chromium.org>
Unreviewed build fix.
Fix Qt build after r75837
https://bugs.webkit.org/show_bug.cgi?id=52494
- editing/EditorCommand.cpp:
- 4:55 PM Changeset in webkit [75843] by
-
- 3 edits in trunk/Source/WebCore
2011-01-14 Tony Gentilcore <tonyg@chromium.org>
Unreviewed build fix.
Fix Qt build after r75837
https://bugs.webkit.org/show_bug.cgi?id=52494
- editing/ApplyStyleCommand.cpp:
- 4:44 PM Changeset in webkit [75842] by
-
- 2 edits in trunk/Source/WebCore
2011-01-14 Tony Gentilcore <tonyg@chromium.org>
Unreviewed build fix.
Fix Qt build after r75837
https://bugs.webkit.org/show_bug.cgi?id=52494
- css/CSSStyleSelector.cpp:
- 4:42 PM Changeset in webkit [75841] by
-
- 3 edits in trunk/LayoutTests
2011-01-14 Maciej Stachowiak <mjs@apple.com>
Reviewed by Anders Carlsson.
Fix a few things in the WebKit2 skipped list
https://bugs.webkit.org/show_bug.cgi?id=52484
- platform/mac-wk2/Skipped: Add/remove some tests to the WK2 skipped list.
- editing/style/stylewithcss-without-selection.html: Fix this test to avoid referencing an undefined variable in the failure case.
- 4:35 PM Changeset in webkit [75840] by
-
- 3 edits in trunk/Source/WebCore
2011-01-14 Tony Gentilcore <tonyg@chromium.org>
Unreviewed build fix.
Fix Qt build after r75837
https://bugs.webkit.org/show_bug.cgi?id=52494
- rendering/InlineFlowBox.h:
- rendering/RenderBoxModelObject.h:
- 4:29 PM Changeset in webkit [75839] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-01-14 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Roben.
Use the Windows thread pool instead of an extra thread for FastMalloc scavenging
https://bugs.webkit.org/show_bug.cgi?id=45186
- wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::scheduleScavenger): Added missing this pointer to CreateTimerQueueTimer().
- 4:28 PM Changeset in webkit [75838] by
-
- 231 edits230 copies16 adds in trunk/LayoutTests
2011-01-14 Mihai Parparita <mihaip@chromium.org>
Update the svg/ pixel expectations for the chromium-mac port.
For the pixel tests that currently fail on Snow Leopard, this moves the
current pixel results to platform/chromium-mac-leopard and adds new
results to platform/chromium-mac.
List of files omitted due to length but composed entirely of moves from
platform/chromium-mac to platform/chromium-mac-leopard and newly added
files in platform/chromium-mac.
- 4:27 PM Changeset in webkit [75837] by
-
- 56 edits in trunk
2011-01-14 Tony Gentilcore <tonyg@chromium.org>
Reviewed by David Levin.
Do some forward declaration in RenderStyle.h
https://bugs.webkit.org/show_bug.cgi?id=52453
No new tests because no new functionality.
- css/CSSComputedStyleDeclaration.cpp:
- css/CSSStyleSelector.cpp:
- editing/Editor.cpp:
- page/EventHandler.cpp:
- rendering/EllipsisBox.cpp:
- rendering/InlineBox.cpp:
- rendering/InlineTextBox.cpp:
- rendering/RenderBlock.cpp:
- rendering/RenderBlock.h:
- rendering/RenderBox.cpp:
- rendering/RenderBox.h:
- rendering/RenderEmbeddedObject.cpp:
- rendering/RenderFieldset.cpp:
- rendering/RenderFileUploadControl.cpp:
- rendering/RenderFrameSet.cpp:
- rendering/RenderHTMLCanvas.cpp:
- rendering/RenderImageResource.cpp:
- rendering/RenderInputSpeech.cpp:
- rendering/RenderLayer.h:
- rendering/RenderLineBoxList.cpp:
- rendering/RenderListBox.cpp:
- rendering/RenderMediaControlsChromium.cpp:
- rendering/RenderObject.cpp:
- rendering/RenderObject.h:
- rendering/RenderObjectChildList.cpp:
- rendering/RenderProgress.cpp:
- rendering/RenderScrollbarPart.cpp:
- rendering/RenderTable.cpp:
- rendering/RenderTable.h:
- rendering/RenderTableCell.cpp:
- rendering/RenderTableRow.cpp:
- rendering/RenderTableSection.cpp:
- rendering/RenderTheme.cpp:
- rendering/RenderThemeChromiumSkia.cpp:
- rendering/RenderThemeChromiumWin.cpp:
- rendering/RootInlineBox.cpp:
- rendering/style/RenderStyle.cpp:
- rendering/style/RenderStyle.h:
- rendering/style/StyleRareInheritedData.cpp:
- 4:19 PM Changeset in webkit [75836] by
-
- 2 edits in trunk/WebKit/chromium
2011-01-14 Jochen Eisinger <jochen@chromium.org>
Unreviewed, roll chromium deps to r71432.
- DEPS:
- 4:16 PM Changeset in webkit [75835] by
-
- 7 edits in trunk/Source/WebCore
2011-01-14 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
Stop instantiating legacy editing positions in AccessibilityRenderObject.cpp, Element.cpp,
BreakBlockquoteCommand.cpp, CompositeEditCommand.cpp, and DeleteButtonController.cpp
https://bugs.webkit.org/show_bug.cgi?id=52481
Removed instantiation of legacy editing positions.
Calls to Position::Position are replaced by calls to Position's convenience functions.
Also fixed firstPositionInOrBeforeNode and lastPositionInOrAfterNode so that
they instantiate right positions for text nodes.
- accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::setSelectedTextRange):
- dom/Element.cpp: (WebCore::Element::updateFocusAppearance):
- editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply):
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::inputText): (WebCore::CompositeEditCommand::rebalanceWhitespaceAt): (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): (WebCore::CompositeEditCommand::moveParagraphs): (WebCore::CompositeEditCommand::breakOutOfEmptyListItem): (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph): (WebCore::CompositeEditCommand::splitTreeToNode):
- editing/DeleteButtonController.cpp: (WebCore::enclosingDeletableElement):
- editing/htmlediting.h: (WebCore::firstPositionInOrBeforeNode): Instantiates firstPositionInNode instead of positionBeforeNode for a text node. (WebCore::lastPositionInOrAfterNode): Ditto.
- 4:10 PM Changeset in webkit [75834] by
-
- 1 copy in tags/Safari-534.15.8
New tag.
- 3:46 PM Changeset in webkit [75833] by
-
- 5 edits3 adds in trunk
2011-01-14 Helder Correia <helder@sencha.com>
Reviewed by Simon Fraser.
Shadow is not drawn when filling a path with a gradient
https://bugs.webkit.org/show_bug.cgi?id=51982
This happens in CG and is related to bug 51869, this time to be fixed
in GraphicsContext::fillPath(const Path& path). We need to draw the
gradient clipped to the path on a CGLayer first, and then draw the
layer on the GraphicsContext.
- fast/canvas/canvas-fillPath-gradient-shadow-expected.txt: Added.
- fast/canvas/canvas-fillPath-gradient-shadow.html: Added.
- fast/canvas/script-tests/canvas-fillPath-gradient-shadow.js: Added.
- platform/chromium/test_expectations.txt: Skipping new test since it fails.
- platform/qt/Skipped: Ditto.
2011-01-14 Helder Correia <helder@sencha.com>
Reviewed by Simon Fraser.
Shadow is not drawn when filling a path with a gradient
https://bugs.webkit.org/show_bug.cgi?id=51982
This happens in CG and is related to bug 51869, this time to be fixed
in GraphicsContext::fillPath(const Path& path). We need to draw the
gradient clipped to the path on a CGLayer first, and then draw the
layer on the GraphicsContext.
Test: fast/canvas/canvas-fillPath-gradient-shadow.html
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillPath):
- 3:45 PM Changeset in webkit [75832] by
-
- 5 edits in trunk/Source/WebCore
2011-01-14 Simon Fraser <Simon Fraser>
Reviewed by Adam Roben.
Layer syncing should go through the compositor
https://bugs.webkit.org/show_bug.cgi?id=52486
Rather than have FrameView go directly to GraphicsLayer to
sync pending changes, route the call through RenderLayerCompositor.
Add a FIXME about an existing issue with flushing and subframes.
No behavior change, so no tests.
- page/FrameView.cpp: (WebCore::FrameView::syncCompositingStateForThisFrame):
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::notifySyncRequired):
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::scheduleLayerFlush): (WebCore::RenderLayerCompositor::flushPendingLayerChanges):
- rendering/RenderLayerCompositor.h: (WebCore::RenderLayerCompositor::notifySyncRequired):
- 3:37 PM Changeset in webkit [75831] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
2011-01-14 Ojan Vafai <ojan@chromium.org>
Fix bad merge in r75816.
- code-review.js:
- 3:36 PM Changeset in webkit [75830] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-01-14 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Roben.
Use the Windows thread pool instead of an extra thread for FastMalloc scavenging
https://bugs.webkit.org/show_bug.cgi?id=45186
r75819 accidentally changed the initial state of the scavenge timer.
- wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::initializeScavenger): Changed initial state of m_scavengingSuspended to true.
- 3:35 PM Changeset in webkit [75829] by
-
- 3 edits in trunk/WebKit/mac
Fix for <rdar://problem/7793902> Artifacts when scrolling
page in Safari while page is loading
Reviewed by Mark Rowe.
Call setDrawsBackground:YES on the scrollView in
dispatchDidFirstLayout() rather than waiting until
frameLoadCompleted(). Also suspend scrolling elasticity
between provisionalLoadStarted() and dispatchDidFirstLayout()
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::WebFrameLoaderClient):
(WebFrameLoaderClient::dispatchDidFirstLayout):
(WebFrameLoaderClient::provisionalLoadStarted):
- 3:04 PM Changeset in webkit [75828] by
-
- 248 edits247 copies28 adds in trunk/LayoutTests
2011-01-14 Mihai Parparita <mihaip@chromium.org>
Update the pixel expectations for the chromium-mac port.
For the pixel tests that currently fail on Snow Leopard, this moves the
current pixel results to platform/chromium-mac-leopard and adds new
results to platform/chromium-mac.
List of files omitted due to length but composed entirely of moves from
platform/chromium-mac to platform/chromium-mac-leopard and newly added
files in platform/chromium-mac.
- 2:57 PM Changeset in webkit [75827] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-01-14 Patrick Gansterer <Patrick Gansterer>
Unreviewed Windows Release build fix.
- wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::scavengerTimerFired):
- 2:57 PM Changeset in webkit [75826] by
-
- 6 edits in trunk
ShouldLoadResourceForFrame should use strings, not URLs.
https://bugs.webkit.org/show_bug.cgi?id=52476
Reviewed by Geoff Garen.
Tools:
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
WebKit2:
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::shouldLoadResourceForFrame): Pass resourceURL as a string instead of
a URL, and rename from subresourceURL to resourceURL.
- 2:49 PM Changeset in webkit [75825] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-01-14 Patrick Gansterer <Patrick Gansterer>
Unreviewed Windows Release build fix.
- wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::scavengerTimerFired):
- 2:45 PM Changeset in webkit [75824] by
-
- 2 edits in trunk/LayoutTests
2011-01-14 Steve Lacey <sjl@chromium.org>
Reviewed by Simon Fraser.
Update media/video-zoom-controls.html to set the video source before initializing the test.
https://bugs.webkit.org/show_bug.cgi?id=52461
- media/video-zoom-controls.html:
- 2:40 PM Changeset in webkit [75823] by
-
- 3 edits2 adds in trunk
2011-01-14 Abhishek Arya <inferno@chromium.org>
Reviewed by David Hyatt.
Fix parent block calculation when trying to find top most node
containing "this" float.
https://bugs.webkit.org/show_bug.cgi?id=51711
Replace use of containingBlock and traverse the parents directly
to check for float existence. containingBlock can skip parents and
jump to the RenderView directly which will cause floats to not get
cleared from intermediate parents.
Test: fast/block/float/floats-not-cleared-crash.html
- rendering/RenderBox.cpp: (WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):
2011-01-14 Abhishek Arya <inferno@chromium.org>
Reviewed by Dave Hyatt.
Tests that we do not crash due to uncleared floats in parent nodes.
https://bugs.webkit.org/show_bug.cgi?id=51711
- fast/block/float/floats-not-cleared-crash-expected.txt: Added.
- fast/block/float/floats-not-cleared-crash.html: Added.
- 2:39 PM Changeset in webkit [75822] by
-
- 6 edits in trunk/WebKit2
Fix for <rdar://problem/8711576> The web process should be able to read resources from the UI process.
Reviewed by Sam Weinig.
Based on a patch by Ivan Krstić. This also makes the NSURLCache path a sandbox parameter.
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
Encode and decode the uiProcessBundleResourcePath member variable.
- Shared/WebProcessCreationParameters.h:
Add uiProcessBundleResourcePath member variable.
- UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformInitializeWebProcess):
Set the uiProcessBundleResourcePath member variable.
- WebProcess/com.apple.WebProcess.sb:
Allow read-only access to UI_PROCESS_BUNDLE_RESOURCE_DIR and all subdirectories.
- WebProcess/mac/WebProcessMac.mm:
(WebKit::initializeSandbox):
When initializing the sandbox, pass UI_PROCESS_BUNDLE_RESOURCE_DIR.
(WebKit::WebProcess::platformInitializeWebProcess):
Remove the code that would consume a sandbox extension for the url cache path.
- 2:32 PM Changeset in webkit [75821] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r75660): compositing/reflections/load-video-in-reflection.html crashes on Windows 7
https://bugs.webkit.org/show_bug.cgi?id=52397
Unskipping tests that no longer fail on Windows 7 Release. Unreviewed.
- platform/win/Skipped:
Un-skip compositing/reflections/load-video-in-reflection.html, which appears to be fixed by
http://trac.webkit.org/changeset/75807
- 2:27 PM Changeset in webkit [75820] by
-
- 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py
Add ericu@chromium.org [me] to the committers file.
- 2:21 PM Changeset in webkit [75819] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-01-14 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Roben.
Use the Windows thread pool instead of an extra thread for FastMalloc scavenging
https://bugs.webkit.org/show_bug.cgi?id=45186
Use CreateTimerQueueTimer() to start periodicScavenge() and stop it with DeleteTimerQueueTimer().
- wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::initializeScavenger): (WTF::TCMalloc_PageHeap::isScavengerSuspended): (WTF::TCMalloc_PageHeap::scheduleScavenger): (WTF::TCMalloc_PageHeap::rescheduleScavenger): (WTF::TCMalloc_PageHeap::suspendScavenger): (WTF::scavengerTimerFired): (WTF::TCMalloc_PageHeap::periodicScavenge): (WTF::TCMalloc_PageHeap::signalScavenger):
- 2:15 PM Changeset in webkit [75818] by
-
- 2 edits in trunk/Tools
2011-01-14 Tony Gentilcore <tonyg@chromium.org>
Reviewed by David Levin.
Add Tony Gentilcore as a reviewer
https://bugs.webkit.org/show_bug.cgi?id=52480
- Scripts/webkitpy/common/config/committers.py:
- 2:13 PM Changeset in webkit [75817] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
2011-01-14 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
improve line selection with fast drags
https://bugs.webkit.org/show_bug.cgi?id=52477
- code-review.js:
- 2:08 PM WebKit Team edited by
- (diff)
- 2:00 PM Changeset in webkit [75816] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
2011-01-14 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
tweak line selection in code review tool
https://bugs.webkit.org/show_bug.cgi?id=52462
-Improve handling of data-comment-base-line code to deal with
lines that have multiple values.
-Make it so that if you click on the line immediately above
a line that has a comment it will add a new comment instead of
adding lines to the following comment. If the last selected line
overlaps existing comment lines though they will still get
added to the existing comment.
- code-review.js:
- 1:59 PM Changeset in webkit [75815] by
-
- 10 edits2 moves1 delete in trunk
2011-01-14 Adam Klein <adamk@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Replace BackForwardListClient with BackForwardControllerClient/BackForwardList
https://bugs.webkit.org/show_bug.cgi?id=42237
Remove Chromium-specific implementation from WebCore.
No tests added; this refactor should be covered by existing history-exercising tests.
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- history/BackForwardListChromium.cpp: Removed.
- history/BackForwardListImpl.h:
2011-01-14 Adam Klein <adamk@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Replace BackForwardListClient with BackForwardControllerClient/BackForwardList
https://bugs.webkit.org/show_bug.cgi?id=42237
Replace Chromium-specific BackForwardListClient in WebCore with a Chromium impl
of the BackForwardList interface.
- WebKit.gyp:
- src/BackForwardListChromium.cpp: Copied from WebKit/chromium/src/BackForwardListClientImpl.cpp. (WebKit::BackForwardListChromium::create): (WebKit::BackForwardListChromium::BackForwardListChromium): (WebKit::BackForwardListChromium::~BackForwardListChromium): (WebKit::BackForwardListChromium::addItem): (WebKit::BackForwardListChromium::goToItem): (WebKit::BackForwardListChromium::itemAtIndex): (WebKit::BackForwardListChromium::backListCount): (WebKit::BackForwardListChromium::forwardListCount): (WebKit::BackForwardListChromium::isActive): (WebKit::BackForwardListChromium::close):
- src/BackForwardListChromium.h: Copied from WebKit/chromium/src/BackForwardListClientImpl.h.
- src/BackForwardListClientImpl.cpp: Removed.
- src/BackForwardListClientImpl.h: Removed.
- src/FrameLoaderClientImpl.cpp:
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::loadHistoryItem): (WebKit::WebFrameImpl::currentHistoryItem):
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl):
- src/WebViewImpl.h:
- 1:51 PM Changeset in webkit [75814] by
-
- 3 edits in trunk/WebKit2
Delay initializing the sandbox until we get the InitializeWebProcess message.
Reviewed by Sam Weinig.
- WebProcess/mac/WebProcessMac.mm:
(WebKit::initializeSandbox):
(WebKit::WebProcess::platformInitializeWebProcess):
- WebProcess/mac/WebProcessMainMac.mm:
(WebKit::WebProcessMain):
- 1:30 PM Changeset in webkit [75813] by
-
- 3 edits in trunk/Tools
2011-01-14 David Levin <levin@chromium.org>
Reviewed by Eric Seidel.
check-webkit-style: _FunctionState should keep track of where the function name starts.
https://bugs.webkit.org/show_bug.cgi?id=52454
- Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to _FunctionState and logic for setting it correctly.
- Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
- 12:43 PM Changeset in webkit [75812] by
-
- 2 edits in trunk/WebKit/qt
2011-01-14 Konstantin Tokarev <Konstantin Tokarev>
Reviewed by Laszlo Gombos.
[Qt] Fixed compilation when QT_NO_SHORTCUT is defined
https://bugs.webkit.org/show_bug.cgi?id=52460
This patch fixes compilation when QT_NO_SHORTCUT is defined in Qt
configuration.
- WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleKeyboardEvent): Added QT_NO_SHORTCUT guards
- 12:39 PM Changeset in webkit [75811] by
-
- 7 edits2 adds in trunk
2011-01-12 Satish Sampath <satish@chromium.org>
Reviewed by Dimitri Glazkov.
Fix a crash when accessing speech input from script.
https://bugs.webkit.org/show_bug.cgi?id=52325
Added a layout test to check enabling/disabling speech input from script.
- fast/speech/speech-input-scripting-expected.txt: Added.
- fast/speech/speech-input-scripting.html: Added.
2011-01-12 Satish Sampath <satish@chromium.org>
Reviewed by Dimitri Glazkov.
Fix a crash when accessing speech input from script.
https://bugs.webkit.org/show_bug.cgi?id=52325
Test: fast/speech/speech-input-scripting.html
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute): Recreate renderer when speech input is enabled/disabled.
- rendering/RenderTextControlSingleLine.cpp: Remove unused code.
- rendering/RenderTextControlSingleLine.h:
- rendering/TextControlInnerElements.cpp: Take self references before firing events and check for renderer validity after. (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): (WebCore::InputFieldSpeechButtonElement::setRecognitionResult): (WebCore::InputFieldSpeechButtonElement::detach):
- 12:35 PM Changeset in webkit [75810] by
-
- 4 edits2 adds in trunk
2011-01-14 Abhishek Arya <inferno@chromium.org>
Reviewed by David Hyatt.
Prevent merging of anonymous blocks if one of them is already getting
destroyed.
https://bugs.webkit.org/show_bug.cgi?id=52402
Test: fast/block/merge-anonymous-block-remove-child-crash2.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::RenderBlock): initialize m_beingDestroyed to false. (WebCore::RenderBlock::destroy): set m_beingDestroyed to true. (WebCore::canMergeContiguousAnonymousBlocks): do not merge if any or prev or next is being destroyed. (WebCore::RenderBlock::removeChild): remove the hack previously done for preventing oldChild merging with nextBlock's next sibling.
- rendering/RenderBlock.h: (WebCore::RenderBlock::beingDestroyed): public function for m_beingDestroyed.
2011-01-14 Abhishek Arya <inferno@chromium.org>
Reviewed by David Hyatt.
Tests that we do not crash when trying to merge anonymous blocks, one of which
is already getting destroyed.
https://bugs.webkit.org/show_bug.cgi?id=52402
- fast/block/merge-anonymous-block-remove-child-crash2-expected.txt: Added.
- fast/block/merge-anonymous-block-remove-child-crash2.html: Added.
- 12:30 PM Changeset in webkit [75809] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
2011-01-14 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Roben.
fix bugs going back and forth between unified and sidebyside
https://bugs.webkit.org/show_bug.cgi?id=52470
Now that we're appending DOM nodes directly, we only want to
get the first ".text" element in the subtree. In the cases
where there are multiple, their contents are the same.
Also, when making side-by-side expansion lines, we need to
clone the contents so we have a second copy to append to the DOM.
- code-review.js:
- 12:27 PM Changeset in webkit [75808] by
-
- 2 edits in trunk/Source/WebCore
2011-01-14 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Follow up to r75791: fix missing dispatch.
https://bugs.webkit.org/show_bug.cgi?id=52442
- inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerDispatcher.prototype.breakpointResolved):
- 12:01 PM Changeset in webkit [75807] by
-
- 2 edits in trunk/Source/WebCore
2011-01-14 Simon Fraser <Simon Fraser>
Reviewed by Adam Roben.
Issues with contentsScale in GraphicsLayerCA
https://bugs.webkit.org/show_bug.cgi?id=52463
Fix various issues with the recent contentsScale changes:
- platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::GraphicsLayerCA): Initialize m_contentsScale to 1. (WebCore::GraphicsLayerCA::updateContentsScale): Only do a setNeedsDisplay() if the layer draws content, otherwise we'll create backing store for empty layers. (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): Be sure to set contentsScale on the new (tiled or untiled) layer. (WebCore::GraphicsLayerCA::cloneLayer): Clones need contentsScale too.
- 11:50 AM Changeset in webkit [75806] by
-
- 4 edits in trunk
2011-01-14 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
Align import/export directives
https://bugs.webkit.org/show_bug.cgi?id=52208
- API/JSBase.h: Align import/export directives with WebKit2/Shared/API/c/WKBase.h
2011-01-14 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
Align import/export directives
https://bugs.webkit.org/show_bug.cgi?id=52208
- Shared/API/c/WKBase.h: Align import/export directives with JavaScriptCore/API/JSBase.h.
- 11:16 AM Changeset in webkit [75805] by
-
- 4 edits in trunk/WebKit/chromium
2011-01-14 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Fisher.
[Chromium] WebKit API: Add a function for form interactive validation setting
https://bugs.webkit.org/show_bug.cgi?id=52430
- public/WebSettings.h: Add a pure setInteractiveFormValidationEnabled().
- src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setInteractiveFormValidationEnabled): Implemented.
- src/WebSettingsImpl.h: Add a declaration.
- 10:54 AM Changeset in webkit [75804] by
-
- 2 edits in trunk/Source/WebCore
2011-01-14 Simon Fraser <Simon Fraser>
Let Xcode have it's way with the project file.
- WebCore.xcodeproj/project.pbxproj:
- 10:53 AM Changeset in webkit [75803] by
-
- 3 edits in trunk/Source/WebCore
2011-01-14 Simon Fraser <Simon Fraser>
Reviewed by Anders Carlsson.
Refactor some FrameView::syncCompositingState code
https://bugs.webkit.org/show_bug.cgi?id=52459
Refactor some code in FrameView related to synchronizing
compositing layer state.
- page/FrameView.cpp: (WebCore::FrameView::syncCompositingStateForThisFrame): (WebCore::FrameView::syncCompositingStateRecursive): (WebCore::FrameView::paintContents):
- page/FrameView.h:
- 10:38 AM Changeset in webkit [75802] by
-
- 12 edits in trunk/LayoutTests
2011-01-14 Tony Chang <tony@chromium.org>
Unreviewed, updating baselines.
[chromium] rebaseline vertical tests on linux
https://bugs.webkit.org/show_bug.cgi?id=52457
After updating fonts.conf, these tests are now passing.
- platform/chromium-linux/fast/blockflow/japanese-lr-text-expected.checksum:
- platform/chromium-linux/fast/blockflow/japanese-lr-text-expected.png:
- platform/chromium-linux/fast/blockflow/japanese-rl-text-expected.checksum:
- platform/chromium-linux/fast/blockflow/japanese-rl-text-expected.png:
- platform/chromium-linux/fast/repaint/japanese-rl-selection-clear-expected.checksum:
- platform/chromium-linux/fast/repaint/japanese-rl-selection-clear-expected.png:
- platform/chromium-linux/fast/repaint/japanese-rl-selection-repaint-expected.checksum:
- platform/chromium-linux/fast/repaint/japanese-rl-selection-repaint-expected.png:
- platform/chromium-linux/svg/batik/text/verticalText-expected.checksum:
- platform/chromium-linux/svg/batik/text/verticalText-expected.png:
- platform/chromium/test_expectations.txt:
- 10:30 AM Changeset in webkit [75801] by
-
- 2 edits in trunk/Source/WebCore
2011-01-14 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
Reviewed by Eric Seidel.
[Qt] Fix build problem introduced by http://trac.webkit.org/changeset/75713
https://bugs.webkit.org/show_bug.cgi?id=30179
- plugins/symbian/PluginViewSymbian.cpp:
- 10:09 AM Changeset in webkit [75800] by
-
- 7 edits in trunk
2011-01-14 Vincent Scheib <scheib@chromium.org>
Reviewed by David Levin.
Add support to DumpRenderTree to use the GPU rather than software renderer
https://bugs.webkit.org/show_bug.cgi?id=52333
- DumpRenderTree/chromium/DumpRenderTree.cpp: (main):
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2011-01-14 Vincent Scheib <scheib@chromium.org>
Reviewed by David Levin.
Add support to DumpRenderTree to use the GPU rather than software renderer
https://bugs.webkit.org/show_bug.cgi?id=52333
- DEPS: Moved forward to take required support from webkit_support.h
- WebKit.gyp: DumpRenderTree depends on Angle on windows
- 9:35 AM Changeset in webkit [75799] by
-
- 4 edits in trunk
2011-01-14 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] update fonts.conf to fix 6 linux tests in drt
https://bugs.webkit.org/show_bug.cgi?id=52411
- platform/chromium/test_expectations.txt:
2011-01-14 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] update fonts.conf to fix 6 linux tests in drt
https://bugs.webkit.org/show_bug.cgi?id=52411
- DumpRenderTree/chromium/fonts.conf: Update to match the copy in
chromium's src/webkit/tools/test_shell/resources/fonts.conf
- 9:27 AM Changeset in webkit [75798] by
-
- 16 edits1 add in trunk
2011-01-14 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
[GTK] Add volume slider to media player
https://bugs.webkit.org/show_bug.cgi?id=51532
- platform/gtk/Skipped:
- platform/gtk/media/audio-controls-rendering-expected.txt:
- platform/gtk/media/controls-after-reload-expected.txt:
- platform/gtk/media/controls-strict-expected.txt:
- platform/gtk/media/controls-styling-expected.txt:
- platform/gtk/media/video-controls-rendering-expected.txt:
- platform/gtk/media/video-display-toggle-expected.txt:
- platform/gtk/media/video-empty-source-expected.txt:
- platform/gtk/media/video-no-audio-expected.txt:
- platform/gtk/media/video-volume-slider-expected.txt: Added.
2011-01-14 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Add volume slider to media player
https://bugs.webkit.org/show_bug.cgi?id=51532
- css/mediaControlsGtk.css: (audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel): (audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container): (audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):
- platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::adjustMediaSliderThumbSize): (WebCore::RenderThemeGtk::paintMediaVolumeSliderContainer): (WebCore::RenderThemeGtk::paintMediaVolumeSliderTrack): (WebCore::RenderThemeGtk::paintMediaVolumeSliderThumb):
- platform/gtk/RenderThemeGtk.h:
- platform/gtk/RenderThemeGtk2.cpp: (WebCore::RenderThemeGtk::paintSliderTrack): (WebCore::RenderThemeGtk::paintSliderThumb): (WebCore::RenderThemeGtk::adjustSliderThumbSize):
- platform/gtk/RenderThemeGtk3.cpp: (WebCore::RenderThemeGtk::paintSliderTrack): (WebCore::RenderThemeGtk::paintSliderThumb): (WebCore::RenderThemeGtk::adjustSliderThumbSize):
- 9:03 AM Changeset in webkit [75797] by
-
- 2 edits in trunk/Source/WebCore
2011-01-14 Joone Hur <joone.hur@collabora.co.uk>
Reviewed by David Levin.
[GTK] Convert use of raw pointers to GOwnPtr in FileSystemGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=52434
No new tests. This code will be tested when an implementation
of beginDragWithFiles is complete.
- platform/gtk/FileSystemGtk.cpp: (WebCore::filenameToString): Use GOwnPtr instead of gchar pointer. (WebCore::fileSystemRepresentation): Ditto. (WebCore::filenameForDisplay): Ditto. (WebCore::pathGetFileName): Ditto.
- 8:02 AM Changeset in webkit [75796] by
-
- 5 edits in trunk
2011-01-14 Michael Saboff <msaboff@apple.com>
Reviewed by Oliver Hunt.
Incorrect backtracking for nested alternatives
https://bugs.webkit.org/show_bug.cgi?id=52387
Added tests to verfiy backtracking of alternatives following
parenthesis.
- fast/regex/parentheses-expected.txt:
- fast/regex/script-tests/parentheses.js:
2011-01-14 Michael Saboff <msaboff@apple.com>
Reviewed by Oliver Hunt.
Incorrect backtracking for nested alternatives
https://bugs.webkit.org/show_bug.cgi?id=52387
In the process of propigating a datalabel it wasn't getting connected
to a destination when the destination was an indirect jump. Added
code to recognize a direct backtrack destination that was an indirect
jump and added mechanism to associate DataLabelPtrs with indirect
jump entries.
Removed dead method
BacktrackDestination::linkDataLabelToHereIfExists()
- yarr/YarrJIT.cpp: (JSC::Yarr::YarrGenerator::IndirectJumpEntry::IndirectJumpEntry): (JSC::Yarr::YarrGenerator::IndirectJumpEntry::addDataLabel): (JSC::Yarr::YarrGenerator::GenerationState::addIndirectJumpEntry): (JSC::Yarr::YarrGenerator::GenerationState::emitIndirectJumpTable): Changes to link indirect jumps with DataLabelPtr's. (JSC::Yarr::YarrGenerator::BacktrackDestination::clearSubDataLabelPtr): (JSC::Yarr::YarrGenerator::TermGenerationState::linkDataLabelToBacktrackIfExists): Updated to handle immediate linking of indirect jumps to DataLabelPtr. (JSC::Yarr::YarrGenerator::generateParenthesesDisjunction): Changed to reflect updated linkDataLabelToBacktrackIfExists().
- 7:58 AM Changeset in webkit [75795] by
-
- 6 edits in trunk/Source/WebCore
2011-01-14 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: breakpoint text snippet in breakpoints sidebar pane disappears after reload.
https://bugs.webkit.org/show_bug.cgi?id=52215
- inspector/front-end/Breakpoint.js: (WebInspector.Breakpoint): (WebInspector.Breakpoint.prototype.populateLabelElement):
- inspector/front-end/Script.js: (WebInspector.Script.prototype.get linesCount): (WebInspector.Script.prototype.sourceLine): (WebInspector.Script.prototype.sourceLine.didRequestSource): (WebInspector.Script.prototype.set source): (WebInspector.Script.prototype.requestSource.didGetScriptSource): (WebInspector.Script.prototype.requestSource):
- inspector/front-end/ScriptView.js: (WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded.didRequestSource): (WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._addBreakpoint):
- inspector/front-end/utilities.js: (String.prototype.findAll):
- 7:49 AM Changeset in webkit [75794] by
-
- 13 edits in trunk/Source
2011-01-14 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: provide script column offset to frontend.
https://bugs.webkit.org/show_bug.cgi?id=52377
- parser/SourceCode.h: (JSC::SourceCode::SourceCode): (JSC::SourceCode::firstColumn):
2011-01-14 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: provide script column offset to frontend.
https://bugs.webkit.org/show_bug.cgi?id=52377
- bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::dispatchDidParseSource):
- bindings/js/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode):
- bindings/v8/DebuggerScript.js: ():
- bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::dispatchDidParseSource):
- inspector/Inspector.idl:
- inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::didParseSource):
- inspector/InspectorDebuggerAgent.h:
- inspector/ScriptDebugListener.h:
- inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.parsedScriptSource):
- inspector/front-end/Script.js: (WebInspector.Script):
- 7:28 AM Changeset in webkit [75793] by
-
- 2 edits in trunk/Source/WebCore
2011-01-14 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed one line fix for console-xhr-logging test.
The problem was introduced at r75788.
- inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
- 6:57 AM Changeset in webkit [75792] by
-
- 22 edits2 adds in trunk/Source/WebCore
2011-01-13 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: extract console related functionality into InspectorConsoleAgent
https://bugs.webkit.org/show_bug.cgi?id=52282
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- inspector/CodeGeneratorInspector.pm:
- inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::~ConsoleMessage):
- inspector/ConsoleMessage.h:
- inspector/Inspector.idl:
- inspector/InspectorConsoleAgent.cpp: Added. (WebCore::InspectorConsoleAgent::InspectorConsoleAgent): (WebCore::InspectorConsoleAgent::~InspectorConsoleAgent): (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled): (WebCore::InspectorConsoleAgent::clearConsoleMessages): (WebCore::InspectorConsoleAgent::reset): (WebCore::InspectorConsoleAgent::setFrontend): (WebCore::InspectorConsoleAgent::addMessageToConsole): (WebCore::InspectorConsoleAgent::startTiming): (WebCore::InspectorConsoleAgent::stopTiming): (WebCore::InspectorConsoleAgent::count): (WebCore::InspectorConsoleAgent::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorConsoleAgent::didReceiveResponse): (WebCore::InspectorConsoleAgent::didFailLoading): (WebCore::InspectorConsoleAgent::addConsoleMessage):
- inspector/InspectorConsoleAgent.h: Added.
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::clearConsoleMessages): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::didCommitLoad):
- inspector/InspectorController.h: (WebCore::InspectorController::consoleAgent):
- inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl): (WebCore::InspectorInstrumentation::didFailLoadingImpl): (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl): (WebCore::InspectorInstrumentation::addMessageToConsole): (WebCore::InspectorInstrumentation::count): (WebCore::InspectorInstrumentation::startTiming): (WebCore::InspectorInstrumentation::stopTiming): (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsole):
- inspector/InspectorInstrumentation.h:
- inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole): (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView): (WebInspector.ConsoleView.prototype.addConsoleMessage): (WebInspector.ConsoleView.prototype.updateConsoleMessageExpiredCount): (WebInspector.ConsoleView.prototype.consoleMessagesCleared):
- inspector/front-end/inspector.js:
- page/Console.cpp: (WebCore::Console::addMessage): (WebCore::Console::count): (WebCore::Console::profile): (WebCore::Console::time): (WebCore::Console::timeEnd): (WebCore::Console::group): (WebCore::Console::groupCollapsed): (WebCore::Console::groupEnd):
- page/Console.h:
- page/Console.idl:
- 6:50 AM Changeset in webkit [75791] by
-
- 11 edits in trunk
2011-01-14 Pavel Feldman <pfeldman@chromium.org>
Web Inspector: do not use this as protocol message
dispatcher in models / agents.
https://bugs.webkit.org/show_bug.cgi?id=52442
Models should never for InspectorBackend.registerDomainDispatcher("foo", this).
There should be a clear way to tell whether method is being called
from within front-end or by the backend.
- http/tests/inspector/debugger-test2.js: (initialize_DebuggerTest.InspectorTest.startDebuggerTest.startTest): (initialize_DebuggerTest.InspectorTest.startDebuggerTest): (initialize_DebuggerTest.InspectorTest.completeDebuggerTest.disableDebugger): (initialize_DebuggerTest.InspectorTest.showScriptSource):
2011-01-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: do not use this as protocol message
dispatcher in models / agents.
https://bugs.webkit.org/show_bug.cgi?id=52442
Models should never for InspectorBackend.registerDomainDispatcher("foo", this).
There should be a clear way to tell whether method is being called
from within front-end or by the backend.
- inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent): (WebInspector.DOMAgent.prototype.nodeForId): (WebInspector.DOMAgent.prototype._bindNodes): (WebInspector.DOMAgent.prototype._removeBreakpoints): (WebInspector.DOMDispatcher): (WebInspector.DOMDispatcher.prototype.setDocument): (WebInspector.DOMDispatcher.prototype.attributesUpdated): (WebInspector.DOMDispatcher.prototype.characterDataModified): (WebInspector.DOMDispatcher.prototype.setChildNodes): (WebInspector.DOMDispatcher.prototype.setDetachedRoot): (WebInspector.DOMDispatcher.prototype.childNodeCountUpdated): (WebInspector.DOMDispatcher.prototype.childNodeInserted): (WebInspector.DOMDispatcher.prototype.childNodeRemoved): (WebInspector.DOMDispatcher.prototype.didCommitLoad): (WebInspector.ApplicationCacheDispatcher): (WebInspector.ApplicationCacheDispatcher.prototype.getApplicationCachesAsync): (WebInspector.ApplicationCacheDispatcher.prototype.updateApplicationCacheStatus): (WebInspector.ApplicationCacheDispatcher.prototype.updateNetworkState):
- inspector/front-end/DOMStorage.js: (WebInspector.DOMStorageDispatcher): (WebInspector.DOMStorageDispatcher.prototype.addDOMStorage): (WebInspector.DOMStorageDispatcher.prototype.selectDOMStorage): (WebInspector.DOMStorageDispatcher.prototype.updateDOMStorage):
- inspector/front-end/Database.js: (WebInspector.Database.prototype.executeSql): (WebInspector.DatabaseDispatcher): (WebInspector.DatabaseDispatcher.prototype.addDatabase): (WebInspector.DatabaseDispatcher.prototype.selectDatabase): (WebInspector.DatabaseDispatcher.prototype.sqlTransactionSucceeded): (WebInspector.DatabaseDispatcher.prototype.sqlTransactionFailed):
- inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel): (WebInspector.DebuggerModel.prototype._pausedScript): (WebInspector.DebuggerModel.prototype._resumedScript): (WebInspector.DebuggerModel.prototype._parsedScriptSource): (WebInspector.DebuggerModel.prototype._failedToParseScriptSource): (WebInspector.DebuggerDispatcher): (WebInspector.DebuggerDispatcher.prototype.pausedScript): (WebInspector.DebuggerDispatcher.prototype.resumedScript): (WebInspector.DebuggerDispatcher.prototype.parsedScriptSource): (WebInspector.DebuggerDispatcher.prototype.failedToParseScriptSource):
- inspector/front-end/FileSystemView.js: (WebInspector.FileSystemDispatcher): (WebInspector.FileSystemDispatcher.prototype.getFileSystemPathsAsync): (WebInspector.FileSystemDispatcher.prototype.didGetFileSystemPath): (WebInspector.FileSystemDispatcher.prototype.didGetFileSystemError): (WebInspector.FileSystemDispatcher.prototype.didGetFileSystemDisabled):
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel): (WebInspector.ProfilesPanel.prototype._addProfileHeader): (WebInspector.ProfilesPanel.prototype._removeProfileHeader): (WebInspector.ProfilesPanel.prototype._addHeapSnapshotChunk): (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot): (WebInspector.ProfilesPanel.prototype._setRecordingProfile): (WebInspector.ProfilerDispatcher): (WebInspector.ProfilerDispatcher.prototype.profilerWasEnabled): (WebInspector.ProfilerDispatcher.prototype.profilerWasDisabled): (WebInspector.ProfilerDispatcher.prototype.resetProfiles): (WebInspector.ProfilerDispatcher.prototype.addProfileHeader): (WebInspector.ProfilerDispatcher.prototype.addHeapSnapshotChunk): (WebInspector.ProfilerDispatcher.prototype.finishHeapSnapshot): (WebInspector.ProfilerDispatcher.prototype.setRecordingProfile): (WebInspector.ProfileSidebarTreeElement.prototype.ondelete):
- inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel):
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype._timelineProfilerWasStarted): (WebInspector.TimelinePanel.prototype._timelineProfilerWasStopped): (WebInspector.TimelinePanel.prototype._addRecordToTimeline): (WebInspector.TimelineDispatcher): (WebInspector.TimelineDispatcher.prototype.timelineProfilerWasStarted): (WebInspector.TimelineDispatcher.prototype.timelineProfilerWasStopped): (WebInspector.TimelineDispatcher.prototype.addRecordToTimeline):
- 6:25 AM Changeset in webkit [75790] by
-
- 2 edits in trunk/Source/WebCore
[Qt][V8] Unreviewed buildfix after r75788.
- inspector/InspectorBrowserDebuggerAgent.cpp:
- 5:31 AM Changeset in webkit [75789] by
-
- 2 edits in trunk/LayoutTests
2011-01-14 Andrey Kosyakov <caseq@chromium.org>
Unreviewed test fix.
Filter out /favicon.ico from page resources list to avoid test expectations mismatch on GTK.
- http/tests/inspector/extensions-resources-redirect.html:
- 4:54 AM Changeset in webkit [75788] by
-
- 14 edits2 adds in trunk/Source/WebCore
2011-01-12 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Extract BrowserDebuggerAgent from InspectorController, InspectorDOMAgent and InspectorDebugger agent.
We have some methods of Debugger which are related to DOM.
Lets extract these methods to BrowserDebugger agent.
- CMakeLists.txt:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- inspector/CodeGeneratorInspector.pm:
- inspector/Inspector.idl:
- inspector/InspectorBrowserDebuggerAgent.cpp: Added. (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent): (WebCore::InspectorBrowserDebuggerAgent::~InspectorBrowserDebuggerAgent): (WebCore::InspectorBrowserDebuggerAgent::discardBindings): (WebCore::InspectorBrowserDebuggerAgent::setEventListenerBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeEventListenerBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::didInsertDOMNode): (WebCore::InspectorBrowserDebuggerAgent::didRemoveDOMNode): (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode): (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode): (WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr): (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent): (WebCore::InspectorBrowserDebuggerAgent::hasBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::updateSubtreeBreakpoints): (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded): (WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest): (WebCore::InspectorBrowserDebuggerAgent::clearForPageNavigation):
- inspector/InspectorBrowserDebuggerAgent.h: Added. (WebCore::InspectorBrowserDebuggerAgent::create):
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::enableDebuggerFromFrontend): (WebCore::InspectorController::disableDebugger): (WebCore::InspectorController::restoreStickyBreakpoints): (WebCore::InspectorController::restoreStickyBreakpoint):
- inspector/InspectorController.h:
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::discardBindings): (WebCore::InspectorDOMAgent::didInsertDOMNode): (WebCore::InspectorDOMAgent::didRemoveDOMNode):
- inspector/InspectorDOMAgent.h:
- inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl): (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
- 4:33 AM Changeset in webkit [75787] by
-
- 4 edits in trunk/Tools
2011-01-14 Eric Seidel <eric@webkit.org>
Original patch from Peter Gal <galpater@inf.u-szeged.hu>
Reviewed by Adam Barth.
Fix when running Tools/Scripts/check-webkit-style without arguments.
https://bugs.webkit.org/show_bug.cgi?id=52261#c16
- Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
- Scripts/webkitpy/common/checkout/scm_unittest.py:
- 4:25 AM Changeset in webkit [75786] by
-
- 18 edits in trunk
2011-01-14 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: redirected resources not handled properly in Network panel
https://bugs.webkit.org/show_bug.cgi?id=52292
- inspector/Inspector.idl: Do not pass isMainResource to identifierForInitialRequest() (it's useless, as we may hit provisional load)
- inspector/InspectorInstrumentation.cpp: Ditto. (WebCore::InspectorInstrumentation::identifierForInitialRequestImpl):
- inspector/InspectorResourceAgent.cpp: Ditto. (WebCore::InspectorResourceAgent::identifierForInitialRequest):
- inspector/InspectorResourceAgent.h: Ditto.
- inspector/InspectorInstrumentation.cpp: Ditto. (WebCore::InspectorInstrumentation::identifierForInitialRequestImpl): Fix main resource detection.
- inspector/front-end/AuditsPanel.js: WebInspector.networkResources now returns array, not map.
- inspector/front-end/ConsoleView.js: User WebInspector.resourceById() to get resource (WebInspector.ConsoleMessage.prototype._formatMessage):
- inspector/front-end/ExtensionServer.js: Ditto. (WebInspector.ExtensionServer.prototype._onRevealAndSelectResource): (WebInspector.ExtensionServer.prototype._onGetResourceContent):
- inspector/front-end/HAREntry.js: WebInspector.networkResources now returns array, not map (WebInspector.HARLog.prototype.build): (WebInspector.HARLog.prototype._convertResource):
- inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager): Use appendResource, not refreshResource, when adding a new resource. (WebInspector.NetworkManager.prototype.identifierForInitialRequest): (WebInspector.NetworkManager.prototype.willSendRequest): (WebInspector.NetworkManager.prototype.didLoadResourceFromMemoryCache): (WebInspector.NetworkManager.prototype.setInitialContent): (WebInspector.NetworkManager.prototype.didCommitLoadForFrame): (WebInspector.NetworkManager.prototype.didCreateWebSocket): (WebInspector.NetworkManager.prototype._createResource): always register resource URL with ResourceTreeModel (WebInspector.NetworkManager.prototype._appendRedirect):
- inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel): (WebInspector.NetworkPanel.prototype.get resources): (WebInspector.NetworkPanel.prototype.resourceById): (WebInspector.NetworkPanel.prototype.appendResource): Add resource as new iff appendResource was added. (WebInspector.NetworkPanel.prototype.refreshResource): ditto. (WebInspector.NetworkPanel.prototype.mainResourceChanged): Clear console upon arrival of new main resource.
- inspector/front-end/ResourceTreeModel.js: Expose unbindResourceURL, bind resources automatically upon creation. (WebInspector.ResourceTreeModel.prototype._clearResources): (WebInspector.ResourceTreeModel.prototype.unbindResourceURL): (WebInspector.ResourceTreeModel.prototype._addFramesRecursively): (WebInspector.ResourceTreeModel.prototype.createResource):
- inspector/front-end/inspector.js: (WebInspector.resourceById):
2011-01-14 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: redirected resources not handled properly in Network panel
Added test for redirected resource presence in HAR
Changed test to request entire HAR log, not multiple HAR entries.
https://bugs.webkit.org/show_bug.cgi?id=52292
- http/tests/inspector/extensions-resources-redirect-expected.txt:
- http/tests/inspector/extensions-resources-redirect.html:
- http/tests/inspector/resource-har-conversion.html:
- inspector/extensions-resources.html:
- 2:48 AM Changeset in webkit [75785] by
-
- 14 edits2 deletes in trunk/Source/WebCore
2011-01-14 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r75783.
http://trac.webkit.org/changeset/75783
https://bugs.webkit.org/show_bug.cgi?id=52439
a bit strange but the same patch have broken mac builds at
linking stage. (Requested by loislo2 on #webkit).
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- inspector/CodeGeneratorInspector.pm:
- inspector/Inspector.idl:
- inspector/InspectorBrowserDebuggerAgent.cpp: Removed.
- inspector/InspectorBrowserDebuggerAgent.h: Removed.
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::enableDebuggerFromFrontend): (WebCore::InspectorController::disableDebugger): (WebCore::InspectorController::restoreStickyBreakpoints): (WebCore::InspectorController::restoreStickyBreakpoint): (WebCore::InspectorController::setEventListenerBreakpoint): (WebCore::InspectorController::removeEventListenerBreakpoint): (WebCore::InspectorController::hasEventListenerBreakpoint): (WebCore::InspectorController::setXHRBreakpoint): (WebCore::InspectorController::removeXHRBreakpoint): (WebCore::InspectorController::hasXHRBreakpoint):
- inspector/InspectorController.h:
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::discardBindings): (WebCore::InspectorDOMAgent::setDOMBreakpoint): (WebCore::InspectorDOMAgent::removeDOMBreakpoint): (WebCore::InspectorDOMAgent::shouldBreakOnNodeInsertion): (WebCore::InspectorDOMAgent::shouldBreakOnNodeRemoval): (WebCore::InspectorDOMAgent::shouldBreakOnAttributeModification): (WebCore::InspectorDOMAgent::descriptionForDOMEvent): (WebCore::InspectorDOMAgent::didInsertDOMNode): (WebCore::InspectorDOMAgent::didRemoveDOMNode): (WebCore::InspectorDOMAgent::hasBreakpoint): (WebCore::InspectorDOMAgent::updateSubtreeBreakpoints):
- inspector/InspectorDOMAgent.h:
- inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl): (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
- 2:24 AM Changeset in webkit [75784] by
-
- 2 edits in trunk/WebKit/chromium
2011-01-14 Finnur Thorarinsson <finnur.webkit@gmail.com>
Reviewed by Ojan Vafai.
Address some user-select-none issues better in our Find in page scoping
function.
The scoping function is in part based on Editor::countMatchesForText
(formerly Frame::markAllMatchesForText), but was rewritten with
asychronous search and interruptability in mind. At the time the
function was written, countMatchesForText didn't work well with
user-select-none style but that has now changed. While
investigating http://crbug.com/68494 I noticed WebKit had fixed this
very problem in the countMatchesForText and I believe we should make
the same changes in our platform code. Therefore, this changelist
adopts the same approach by integrating:
https://bugs.webkit.org/show_bug.cgi?id=33508
(r53142: handling user-select-none better) and
https://bugs.webkit.org/show_bug.cgi?id=51623
(r74886: handling match within textfield better).
For more details see those changelists.
This changelist, however, is tracked here:
https://bugs.webkit.org/show_bug.cgi?id=52367
The original changelists did not come with layout tests, but I'm adding
a test on the Chromium side for this.
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::scopeStringMatches):
- 2:22 AM Changeset in webkit [75783] by
-
- 14 edits2 adds in trunk/Source/WebCore
2011-01-12 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Extract BrowserDebuggerAgent from InspectorController, InspectorDOMAgent and InspectorDebugger agent.
We have some methods of Debugger which are related to DOM.
Lets extract these methods to BrowserDebugger agent.
- CMakeLists.txt:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- inspector/CodeGeneratorInspector.pm:
- inspector/Inspector.idl:
- inspector/InspectorBrowserDebuggerAgent.cpp: Added. (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent): (WebCore::InspectorBrowserDebuggerAgent::~InspectorBrowserDebuggerAgent): (WebCore::InspectorBrowserDebuggerAgent::discardBindings): (WebCore::InspectorBrowserDebuggerAgent::setEventListenerBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeEventListenerBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::didInsertDOMNode): (WebCore::InspectorBrowserDebuggerAgent::didRemoveDOMNode): (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode): (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode): (WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr): (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent): (WebCore::InspectorBrowserDebuggerAgent::hasBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::updateSubtreeBreakpoints): (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded): (WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest): (WebCore::InspectorBrowserDebuggerAgent::clearForPageNavigation):
- inspector/InspectorBrowserDebuggerAgent.h: Added. (WebCore::InspectorBrowserDebuggerAgent::create):
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::enableDebuggerFromFrontend): (WebCore::InspectorController::disableDebugger): (WebCore::InspectorController::restoreStickyBreakpoints): (WebCore::InspectorController::restoreStickyBreakpoint):
- inspector/InspectorController.h:
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::discardBindings): (WebCore::InspectorDOMAgent::didInsertDOMNode): (WebCore::InspectorDOMAgent::didRemoveDOMNode):
- inspector/InspectorDOMAgent.h:
- inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl): (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
- 2:05 AM Changeset in webkit [75782] by
-
- 2 edits in trunk/WebKit/gtk
2011-01-14 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: gtk build fix (2).
- webkit/webkitwebview.cpp:
- 2:02 AM Changeset in webkit [75781] by
-
- 3 edits in trunk/Tools
2011-01-04 Jochen Eisinger <jochen@chromium.org>
Reviewed by David Levin.
Store the tempdir object in a variable so it doesn't get deleted too early.
https://bugs.webkit.org/show_bug.cgi?id=51875
- Scripts/update-webkit-auxiliary-libs:
- Scripts/update-webkit-support-libs:
- 1:59 AM Changeset in webkit [75780] by
-
- 2 edits in trunk/WebKit/gtk
2011-01-14 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: gtk build fix.
- webkit/webkitwebinspector.cpp:
- 1:52 AM Changeset in webkit [75779] by
-
- 2 edits in trunk/Tools
2011-01-14 Eric Seidel <eric@webkit.org>
Unreviewed. Make it work in python 2.5.
webkit-patch suggest-reviewers dies when ChangeLogs are missing
https://bugs.webkit.org/show_bug.cgi?id=49158
- Scripts/webkitpy/common/checkout/api_unittest.py:
- 1:47 AM Changeset in webkit [75778] by
-
- 4 edits in trunk
2011-01-14 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: build fix.
- WebCore.vcproj/WebCore.vcproj:
- 1:28 AM Changeset in webkit [75777] by
-
- 13 edits2 adds in trunk
2011-01-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: extract InspectorSettings from InspectorState,
simplify it.
https://bugs.webkit.org/show_bug.cgi?id=52429
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.xcodeproj/project.pbxproj:
- inspector/InspectorClient.h:
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::inspectorStartsAttached): (WebCore::InspectorController::setInspectorStartsAttached): (WebCore::InspectorController::setInspectorAttachedHeight): (WebCore::InspectorController::inspectorAttachedHeight): (WebCore::InspectorController::setMonitoringXHREnabled): (WebCore::InspectorController::restoreDebugger): (WebCore::InspectorController::restoreProfiler): (WebCore::InspectorController::ensureSettingsLoaded): (WebCore::InspectorController::enableProfiler): (WebCore::InspectorController::disableProfiler): (WebCore::InspectorController::enableDebuggerFromFrontend): (WebCore::InspectorController::disableDebugger):
- inspector/InspectorController.h:
- inspector/InspectorSettings.cpp: Added. (WebCore::InspectorSettings::InspectorSettings): (WebCore::InspectorSettings::getBoolean): (WebCore::InspectorSettings::setBoolean): (WebCore::InspectorSettings::getLong): (WebCore::InspectorSettings::setLong): (WebCore::InspectorSettings::registerBoolean): (WebCore::InspectorSettings::registerLong):
- inspector/InspectorSettings.h: Added.
- inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState): (WebCore::InspectorState::setValue): (WebCore::InspectorState::setObject): (WebCore::InspectorState::registerBoolean): (WebCore::InspectorState::registerString): (WebCore::InspectorState::registerLong): (WebCore::InspectorState::registerObject): (WebCore::InspectorState::Property::create):
- inspector/InspectorState.h: (WebCore::InspectorState::setBoolean): (WebCore::InspectorState::setString): (WebCore::InspectorState::setLong):
2011-01-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: extract InspectorSettings from InspectorState,
simplify it.
https://bugs.webkit.org/show_bug.cgi?id=52429
- WebProcess/WebCoreSupport/WebInspectorClient.cpp:
- 1:21 AM Changeset in webkit [75776] by
-
- 15 edits2 deletes in trunk
2011-01-14 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r75774.
http://trac.webkit.org/changeset/75774
https://bugs.webkit.org/show_bug.cgi?id=52431
gtk builds were broken (Requested by loislo2 on #webkit).
- CMakeLists.txt:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- inspector/CodeGeneratorInspector.pm:
- inspector/Inspector.idl:
- inspector/InspectorBrowserDebuggerAgent.cpp: Removed.
- inspector/InspectorBrowserDebuggerAgent.h: Removed.
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::enableDebuggerFromFrontend): (WebCore::InspectorController::disableDebugger): (WebCore::InspectorController::restoreStickyBreakpoints): (WebCore::InspectorController::restoreStickyBreakpoint): (WebCore::InspectorController::setEventListenerBreakpoint): (WebCore::InspectorController::removeEventListenerBreakpoint): (WebCore::InspectorController::hasEventListenerBreakpoint): (WebCore::InspectorController::setXHRBreakpoint): (WebCore::InspectorController::removeXHRBreakpoint): (WebCore::InspectorController::hasXHRBreakpoint):
- inspector/InspectorController.h:
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::discardBindings): (WebCore::InspectorDOMAgent::setDOMBreakpoint): (WebCore::InspectorDOMAgent::removeDOMBreakpoint): (WebCore::InspectorDOMAgent::shouldBreakOnNodeInsertion): (WebCore::InspectorDOMAgent::shouldBreakOnNodeRemoval): (WebCore::InspectorDOMAgent::shouldBreakOnAttributeModification): (WebCore::InspectorDOMAgent::descriptionForDOMEvent): (WebCore::InspectorDOMAgent::didInsertDOMNode): (WebCore::InspectorDOMAgent::didRemoveDOMNode): (WebCore::InspectorDOMAgent::hasBreakpoint): (WebCore::InspectorDOMAgent::updateSubtreeBreakpoints):
- inspector/InspectorDOMAgent.h:
- inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl): (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
2011-01-14 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r75774.
http://trac.webkit.org/changeset/75774
https://bugs.webkit.org/show_bug.cgi?id=52431
gtk builds were broken (Requested by loislo2 on #webkit).
- Scripts/webkitpy/common/checkout/scm.py:
- 12:56 AM Changeset in webkit [75775] by
-
- 3 edits in trunk/Tools
check-webkit-style: _FunctionState should detect pure functions.
https://bugs.webkit.org/show_bug.cgi?id=52428
Reviewed by Shinichiro Hamaji.
- Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
is a pure virtual function.
- Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
virtual functions are correctly detected.
- 12:21 AM Changeset in webkit [75774] by
-
- 15 edits2 adds in trunk
2011-01-12 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Extract BrowserDebuggerAgent from InspectorController, InspectorDOMAgent and InspectorDebugger agent.
We have some methods of Debugger which are related to DOM.
Lets extract these methods to BrowserDebugger agent.
- CMakeLists.txt:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- inspector/CodeGeneratorInspector.pm:
- inspector/Inspector.idl:
- inspector/InspectorBrowserDebuggerAgent.cpp: Added. (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent): (WebCore::InspectorBrowserDebuggerAgent::~InspectorBrowserDebuggerAgent): (WebCore::InspectorBrowserDebuggerAgent::discardBindings): (WebCore::InspectorBrowserDebuggerAgent::setEventListenerBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeEventListenerBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::didInsertDOMNode): (WebCore::InspectorBrowserDebuggerAgent::didRemoveDOMNode): (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode): (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode): (WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr): (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent): (WebCore::InspectorBrowserDebuggerAgent::hasBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::updateSubtreeBreakpoints): (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded): (WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest): (WebCore::InspectorBrowserDebuggerAgent::clearForPageNavigation):
- inspector/InspectorBrowserDebuggerAgent.h: Added. (WebCore::InspectorBrowserDebuggerAgent::create):
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::enableDebuggerFromFrontend): (WebCore::InspectorController::disableDebugger): (WebCore::InspectorController::restoreStickyBreakpoints): (WebCore::InspectorController::restoreStickyBreakpoint):
- inspector/InspectorController.h:
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::discardBindings): (WebCore::InspectorDOMAgent::didInsertDOMNode): (WebCore::InspectorDOMAgent::didRemoveDOMNode):
- inspector/InspectorDOMAgent.h:
- inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl): (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
2011-01-13 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Just small fix for problem with check-webkit-style.
It just didn't work for this patch.
Old code can't concatenate a list of strings with None.
- Scripts/webkitpy/common/checkout/scm.py:
- 12:14 AM Changeset in webkit [75773] by
-
- 2 edits in trunk/LayoutTests
2011-01-14 Hayato Ito <hayato@chromium.org>
Unreviewed chromium expectations update.
Exclude http/tests/loading/cross-origin-XHR-willLoadRequest.html (added in r75768)
- platform/chromium/test_expectations.txt:
Jan 13, 2011:
- 10:58 PM Changeset in webkit [75772] by
-
- 3 edits in trunk/Tools
2011-01-13 David Levin <levin@chromium.org>
Reviewed by Shinichiro Hamaji.
check-webkit-style: _FunctionState should use Position to know where items are.
https://bugs.webkit.org/show_bug.cgi?id=52424
- Scripts/webkitpy/style/checkers/cpp.py: (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers. (detect_functions): Changed to pass Position's to _FunctionState.begin and did some minor clean-up. (*): Other changes are simply about converting to use the Position's in_FunctionState instead of line numbers.
- Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code to verify the positions stored in _FunctionState.
- 10:58 PM Changeset in webkit [75771] by
-
- 4 edits in trunk/LayoutTests
2011-01-13 Hayato Ito <hayato@chromium.org>
Unreviewed, build fix.
Fix Skipped lists in r75768.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 10:21 PM Changeset in webkit [75770] by
-
- 7 edits in trunk/Source/WebCore
Implement form validation message UI
https://bugs.webkit.org/show_bug.cgi?id=48980
Reviewed by Dimitri Glazkov.
- Add four internal pseudo selectors:
- -webkit-validation-bubble
- -webkit-validation-bubble-message
- -webkit-validation-bubble-top-outer-arrow
- -webkit-validation-bubble-top-inner-arrow
- Implement ValidationMessage functions Show the message for <the number of characters> / 20.0 seconds.
No new tests because the feature is disabled by default for now and the
new behavior is strongly timing-dependent.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::canShareStyleWithElement):
Do not share a style with elements with different shadowPseudoId().
- css/html.css: Define appearance for the internal selectors.
(::-webkit-validation-bubble):
(::-webkit-validation-bubble-message):
(::-webkit-validation-bubble-top-outer-arrow):
(::-webkit-validation-bubble-top-inner-arrow):
- dom/Node.cpp:
(WebCore::Node::createRendererIfNeeded):
Allow to add shadow renderers even if canHaveChildren() returns false.
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::detach):
Remove m_validationMessage immediately because we can't use
hideVisibleValidationMessage(), which calls a ValidationMessage function later.
(WebCore::HTMLFormControlElement::updateVisibleValidationMessage):
- Don't create ValidationMessage if the message is empty.
- Remove the check for message equality.
(WebCore::HTMLFormControlElement::hideVisibleValidationMessage):
Don't remove m_validationMessage immediately. We shouldn't make the
element needsLayout() state in this context.
- html/ValidationMessage.cpp:
(WebCore::ValidationMessage::~ValidationMessage):
hideMessage() -> deleteBubbleTree() renaming.
(WebCore::ValidationMessage::setMessage): Implemented.
(WebCore::ValidationMessage::setMessageDOMAndStartTimer):
Added. This updates the validation message and starts the timer to hide it.
(WebCore::ElementWithPseudoId):
Added to help implementations of styled shadow nodes.
(WebCore::ValidationMessage::buildBubbleTree): Added.
(WebCore::ValidationMessage::requestToHideMessage): Added.
(WebCore::ValidationMessage::deleteBubbleTree):
Renamed from hideMessage(), and implemented.
- html/ValidationMessage.h: Add declarations.
- 9:40 PM Changeset in webkit [75769] by
-
- 3 edits in trunk/Tools
2011-01-13 Eric Seidel <eric@webkit.org>
Reviewed by David Levin.
webkit-patch suggest-reviewers dies when ChangeLogs are missing
https://bugs.webkit.org/show_bug.cgi?id=49158
This is not the most elegant, but it is a very safe fix to this bug.
One advantage of catching ScriptError like this instead of adding a
new added_or_modified_files or fixing all changed_files callers
to use a more specific change_files variant, is that we catch
all kinds of ScriptErrors which might cause our (non-essential)
suggest-reviewers code to fail out. This should make passing
--suggest-reviewers to webkit-patch upload much more robust
and may even make it possible for us to make it default.
The root of the problem here is that SCM.changed_files includes
deleted ChangeLog paths (from moves, etc) which then when we ask
SVN/Git for the contents of the file at that revision, the command
errors out and Executive.run_command raises a ScriptError.
In the future we might fix this differently by making all current
callers of chagned_files use a more specific method for requesting
what types of changes they're interested in (adds, modifies, deletes, etc.)
- Scripts/webkitpy/common/checkout/api.py:
- Scripts/webkitpy/common/checkout/api_unittest.py:
- 9:19 PM Changeset in webkit [75768] by
-
- 10 edits2 adds in trunk
<rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
https://bugs.webkit.org/show_bug.cgi?id=52419
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Test: http/tests/loading/cross-origin-XHR-willLoadRequest.html
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::init): Complete r74453 by ensuring that m_request is only set after
willSendRequest(). Otherwise, willSendRequest() ends up calling into
ThreadableDocumentRequest::willSendRequest(), which cancels the request.
Tools:
Allow to further control the behavior of the willSendRequest delegate callback by making it
set a different URL in the new request.
- DumpRenderTree/LayoutTestController.cpp:
(addURLToRedirectCallback): Added.
(LayoutTestController::staticFunctions): Added addURLToRedirect.
(LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
(LayoutTestController::redirectionDestinationForURL): Added this getter.
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/mac/ResourceLoadDelegate.mm:
(-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
change the URL in the new request to the redirect destination.
LayoutTests:
- http/tests/loading/cross-origin-XHR-willLoadRequest-expected.txt: Added.
- http/tests/loading/cross-origin-XHR-willLoadRequest.html: Added.
- platform/gtk/Skipped: Skip the new test.
- platform/qt/Skipped: Ditto.
- platform/win/Skipped: Ditto.
- 8:19 PM Changeset in webkit [75767] by
-
- 2 edits in trunk/Source/WebCore
Don’t try to compile InjectedScriptSource.js into WebCore.
Reviewed by Mark Rowe.
- WebCore.xcodeproj/project.pbxproj:
- 6:52 PM Changeset in webkit [75766] by
-
- 4 edits in trunk/Source/JavaScriptCore
<rdar://problem/5469576> Use PTK_FRAMEWORK_JAVASCRIPTCORE_KEY0 if available.
Reviewed by Geoff Garen.
- DerivedSources.make: Create a header file, HeaderDetection.h, that tells
us whether pthread_machdep.h is available.
- wtf/FastMalloc.cpp: If PTK_FRAMEWORK_JAVASCRIPTCORE_KEY0 is available, then
don't do the pthread_getspecific_function_pointer trick.
(WTF::setThreadHeap): Ditto, but set thread-specific data.
(WTF::TCMalloc_ThreadCache::GetThreadHeap): Ditto, but get rather than set.
- 6:24 PM Changeset in webkit [75765] by
-
- 2 edits in trunk/LayoutTests
2011-01-13 Justin Schuh <jschuh@chromium.org>
Unreviewed chromium expectations update.
Several text layout tests failing on linux after r75756
- platform/chromium/test_expectations.txt:
- 6:11 PM Changeset in webkit [75764] by
-
- 2 edits in trunk/LayoutTests
2011-01-13 Martin Robinson <mrobinson@igalia.com>
Unreviewed, rolling out r75740.
http://trac.webkit.org/changeset/75740
This led to GTK+ redness
- platform/gtk/Skipped:
- 6:07 PM Changeset in webkit [75763] by
-
- 2 edits in trunk/LayoutTests
2011-01-13 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] Unskip http/tests/security/originHeader/origin-header-for-empty.html
https://bugs.webkit.org/show_bug.cgi?id=52389
- platform/qt/Skipped:
- 5:58 PM Changeset in webkit [75762] by
-
- 1 edit63 adds in trunk/LayoutTests
2011-01-13 Mihai Parparita <mihaip@chromium.org>
Unreviewed chromium expectations update.
Add Chromium Snow Leopard expectations. These need to go into a new
chromium-mac-snowleopard directory, since these tests do not have
chromium-mac expectations, but currently pass on Leopard.
The differences are due to bug 52335 (which explains why we can't use
the regular mac port Snow Leopard baselines).
- platform/chromium-mac-snowleopard/css1/box_properties/clear-expected.checksum: Added.
- platform/chromium-mac-snowleopard/css1/box_properties/clear-expected.png: Added.
- platform/chromium-mac-snowleopard/css1/box_properties/float-expected.checksum: Added.
- platform/chromium-mac-snowleopard/css1/box_properties/float-expected.png: Added.
- platform/chromium-mac-snowleopard/css1/text_properties/vertical_align-expected.checksum: Added.
- platform/chromium-mac-snowleopard/css1/text_properties/vertical_align-expected.png: Added.
- platform/chromium-mac-snowleopard/css2.1/t0803-c5501-imrgn-t-00-b-ag-expected.checksum: Added.
- platform/chromium-mac-snowleopard/css2.1/t0803-c5501-imrgn-t-00-b-ag-expected.png: Added.
- platform/chromium-mac-snowleopard/css2.1/t0803-c5502-mrgn-r-00-c-ag-expected.checksum: Added.
- platform/chromium-mac-snowleopard/css2.1/t0803-c5502-mrgn-r-00-c-ag-expected.png: Added.
- platform/chromium-mac-snowleopard/css2.1/t0803-c5503-imrgn-b-00-b-a-expected.checksum: Added.
- platform/chromium-mac-snowleopard/css2.1/t0803-c5503-imrgn-b-00-b-a-expected.png: Added.
- platform/chromium-mac-snowleopard/css2.1/t0803-c5504-mrgn-l-00-c-ag-expected.checksum: Added.
- platform/chromium-mac-snowleopard/css2.1/t0803-c5504-mrgn-l-00-c-ag-expected.png: Added.
- platform/chromium-mac-snowleopard/css2.1/t0803-c5505-mrgn-00-b-ag-expected.checksum: Added.
- platform/chromium-mac-snowleopard/css2.1/t0803-c5505-mrgn-00-b-ag-expected.png: Added.
- platform/chromium-mac-snowleopard/css2.1/t0905-c414-flt-01-d-g-expected.checksum: Added.
- platform/chromium-mac-snowleopard/css2.1/t0905-c414-flt-01-d-g-expected.png: Added.
- platform/chromium-mac-snowleopard/css2.1/t100304-c43-rpl-bbx-00-d-g-expected.checksum: Added.
- platform/chromium-mac-snowleopard/css2.1/t100304-c43-rpl-bbx-00-d-g-expected.png: Added.
- platform/chromium-mac-snowleopard/css2.1/t1008-c44-ln-box-00-d-ag-expected.checksum: Added.
- platform/chromium-mac-snowleopard/css2.1/t1008-c44-ln-box-00-d-ag-expected.png: Added.
- platform/chromium-mac-snowleopard/css2.1/t1008-c44-ln-box-02-d-ag-expected.checksum: Added.
- platform/chromium-mac-snowleopard/css2.1/t1008-c44-ln-box-02-d-ag-expected.png: Added.
- platform/chromium-mac-snowleopard/css2.1/t1008-c44-ln-box-03-d-ag-expected.checksum: Added.
- platform/chromium-mac-snowleopard/css2.1/t1008-c44-ln-box-03-d-ag-expected.png: Added.
- platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-02-d-agi-expected.checksum: Added.
- platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-02-d-agi-expected.png: Added.
- platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-03-d-agi-expected.checksum: Added.
- platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-03-d-agi-expected.png: Added.
- platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-04-d-agi-expected.checksum: Added.
- platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-04-d-agi-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/css/resize-corner-tracking-transformed-expected.checksum: Added.
- platform/chromium-mac-snowleopard/fast/css/resize-corner-tracking-transformed-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/searchfield-heights-expected.checksum: Added.
- platform/chromium-mac-snowleopard/fast/forms/searchfield-heights-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/slider-thumb-shared-style-expected.checksum: Added.
- platform/chromium-mac-snowleopard/fast/forms/slider-thumb-shared-style-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/gradients/background-clipped-expected.checksum: Added.
- platform/chromium-mac-snowleopard/fast/gradients/background-clipped-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/replaced/selection-rect-transform-expected.checksum: Added.
- platform/chromium-mac-snowleopard/fast/replaced/selection-rect-transform-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/text/whitespace/tab-character-basics-expected.checksum: Added.
- platform/chromium-mac-snowleopard/fast/text/whitespace/tab-character-basics-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/transforms/diamond-expected.checksum: Added.
- platform/chromium-mac-snowleopard/fast/transforms/diamond-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/transforms/shadows-expected.checksum: Added.
- platform/chromium-mac-snowleopard/fast/transforms/shadows-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/transforms/transformed-caret-expected.checksum: Added.
- platform/chromium-mac-snowleopard/fast/transforms/transformed-caret-expected.png: Added.
- 5:56 PM Changeset in webkit [75761] by
-
- 4 edits in trunk/Tools
2011-01-13 Eric Seidel <eric@webkit.org>
Reviewed by Mihai Parparita.
webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
https://bugs.webkit.org/show_bug.cgi?id=52416
Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717
UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
I also added FIXMEs about the changed_files returning deleted files problem
which is causing the other most common exception for suggest-reviewers
(and is probably breaking sheriff-bots blame detection).
- Scripts/webkitpy/common/checkout/api.py:
- Scripts/webkitpy/common/checkout/api_unittest.py:
- Scripts/webkitpy/common/checkout/scm.py:
- 5:51 PM Changeset in webkit [75760] by
-
- 4 edits in trunk/Tools
2011-01-13 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
results archives from commit-queue are too large to upload
https://bugs.webkit.org/show_bug.cgi?id=52405
- Scripts/webkitpy/common/system/filesystem.py:
- Scripts/webkitpy/common/system/filesystem_mock.py:
- Scripts/webkitpy/tool/commands/queues.py:
- 5:31 PM Changeset in webkit [75759] by
-
- 2 edits in trunk/WebKit/chromium
2011-01-13 John Abd-El-Malek <jam@chromium.org>
Reviewed by Mihai Parparita.
[chromium] Fix minor type in plugin printing
https://bugs.webkit.org/show_bug.cgi?id=52410
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::printBegin):
- 5:16 PM Changeset in webkit [75758] by
-
- 4 edits in trunk/Source/WebCore
The pageScaleFactor() should be saved/restored along with the scroll position
https://bugs.webkit.org/show_bug.cgi?id=52406
<rdar://problem/8714412>
Reviewed by Darin Adler and Brady Eidson.
- history/HistoryItem.cpp:
(WebCore::HistoryItem::HistoryItem): Initialize m_pageScaleFactor.
(WebCore::HistoryItem::pageScaleFactor): Added getter.
(WebCore::HistoryItem::setPageScaleFactor): Added setter.
(WebCore::HistoryItem::encodeBackForwardTreeNode): Encode m_pageScaleFactor.
(WebCore::HistoryItem::decodeBackForwardTree): Decode m_pageScaleFactor.
- history/HistoryItem.h:
- loader/HistoryController.cpp:
(WebCore::HistoryController::saveScrollPositionAndViewStateToItem): Save the page scale factor...
(WebCore::HistoryController::restoreScrollPositionAndViewState): ...and restore it here.
- 5:15 PM Changeset in webkit [75757] by
-
- 2 edits4 adds in trunk/LayoutTests
2011-01-13 Mihai Parparita <mihaip@chromium.org>
Unreviewed chromium expectations update.
Categorize remaining scrollbar-related failures. 6 are due to bug 52414
(small remaining difference between mac and chromium-mac scrollbars).
fast/text/international/thai-line-breaks.html just needed a baseline
update (done for both Leopard and Snow Leopard).
- platform/chromium-mac-leopard/fast/text/international/thai-line-breaks-expected.checksum: Added.
- platform/chromium-mac-leopard/fast/text/international/thai-line-breaks-expected.png: Added.
- platform/chromium-mac/fast/text/international/thai-line-breaks-expected.checksum: Added.
- platform/chromium-mac/fast/text/international/thai-line-breaks-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 4:48 PM Changeset in webkit [75756] by
-
- 4 edits in trunk/Source/WebCore
2011-01-13 Evan Martin <evan@chromium.org>
Reviewed by Tony Chang.
[chromium] drop backwards iteration in Linux complex text code
https://bugs.webkit.org/show_bug.cgi?id=52403
ComplexTextController previously supported iterating through the text in
both directions, but this resulted in duplicate code for each path.
Instead, by being more careful about flipping signs where appropriate,
we can refactor the code into one code path.
No tests, just a refactoring; should be covered by existing tests.
- platform/graphics/chromium/ComplexTextControllerLinux.cpp: (WebCore::ComplexTextController::ComplexTextController): (WebCore::ComplexTextController::reset): (WebCore::ComplexTextController::nextScriptRun):
- platform/graphics/chromium/ComplexTextControllerLinux.h:
- platform/graphics/chromium/FontLinux.cpp: (WebCore::glyphIndexForXPositionInScriptRun): (WebCore::Font::selectionRectForComplexText):
- 4:41 PM Changeset in webkit [75755] by
-
- 2 edits in tags/Safari-534.15.7/WebKit2
Build fix.
- 4:39 PM Changeset in webkit [75754] by
-
- 3 edits in trunk/Websites/bugs.webkit.org
2011-01-13 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
simplify keyboard handling in code review tool
https://bugs.webkit.org/show_bug.cgi?id=52407
Now that we have DiffBlock containers, the only things that are
focusable are previousComment nodes and DiffBlock containers
that contain add/remove lines.
Also, this means we show the focus border around the entire diff
instead of just the first line.
- code-review.js:
- 4:16 PM Changeset in webkit [75753] by
-
- 9 edits in tags/Safari-534.15.7
Merge r75662.
- 4:16 PM Changeset in webkit [75752] by
-
- 15 edits in tags/Safari-534.15.7
Merge r75635.
- 4:16 PM Changeset in webkit [75751] by
-
- 5 edits in tags/Safari-534.15.7
Merge r74309.
- 4:15 PM Changeset in webkit [75750] by
-
- 5 edits in tags/Safari-534.15.7
Versioning.
- 4:14 PM Changeset in webkit [75749] by
-
- 12 edits in trunk/Source/WebCore
2011-01-13 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Adler.
Flip input[type=range] to use the new shadow DOM model.
https://bugs.webkit.org/show_bug.cgi?id=52317
This is a straight-up flip, minimal change to the logic, which will be
refactored in a follow-up patch.
Covered by existing tests.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::initForStyleResolve): Changed to use either
host or parent node to find parent.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::updateType): Added logic for destroying/creating
shadow DOM subtree.
- html/InputType.cpp: (WebCore::InputType::createShadowSubtree): Added empty decl. (WebCore::InputType::destroyShadowSubtree): Added a method to destroy
shadow subtree.
- html/InputType.h: Added defs.
- html/RangeInputType.cpp: (WebCore::RangeInputType::createShadowSubtree): Added a virtual method to create
slider thumb.
- html/RangeInputType.h: Adde def.
- html/shadow/SliderThumbElement.cpp: Added temporary RenderSliderThumb class
to handle cascading appearance.
(WebCore::RenderSliderThumb::RenderSliderThumb): Added.
(WebCore::RenderSliderThumb::layout): Moved here the logic from
RenderSlider::createThumbStyle.
(WebCore::SliderThumbElement::createRenderer): Added virtual method to
create RenderSliderThumb instance.
(WebCore::SliderThumbElement::defaultEventHandler): Changed to use HTMLDivElement
as base class.
(WebCore::SliderThumbElement::detach): Ditto.
- html/shadow/SliderThumbElement.h: (WebCore::SliderThumbElement::SliderThumbElement): Ditto. (WebCore::SliderThumbElement::create): Ditto. (WebCore::toSliderThumbElement): Added a casting helper.
- rendering/MediaControlElements.cpp: (WebCore::MediaControlInputElement::attach): Added handling of shadow DOM,
since the whole method is hand-rolled.
(WebCore::MediaControlInputElement::updateStyle): Ditto.
- rendering/RenderSlider.cpp: (WebCore::RenderSlider::~RenderSlider): Removed unneeded code. (WebCore::RenderSlider::thumbRect): Changed to use sliderThumbElement helper. (WebCore::RenderSlider::layout): Ditto. (WebCore::RenderSlider::sliderThumbElement): Added a temporary helper to access
SliderThumbElement.
(WebCore::RenderSlider::mouseEventIsInThumb): Changed to use sliderThumbElement helper.
(WebCore::RenderSlider::mouseEventOffsetToThumb): Ditto.
(WebCore::RenderSlider::setValueForPosition): Ditto.
(WebCore::RenderSlider::positionForOffset): Ditto.
(WebCore::RenderSlider::currentPosition): Ditto.
(WebCore::RenderSlider::trackSize): Ditto.
(WebCore::RenderSlider::forwardEvent): Ditto.
(WebCore::RenderSlider::inDragMode): Ditto.
- rendering/RenderSlider.h: Added def.
- 4:06 PM BuildBot edited by
- (diff)
- 3:55 PM Changeset in webkit [75748] by
-
- 32 edits1 move in trunk
2011-01-13 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Rename RGBA32Buffer to ImageFrame
https://bugs.webkit.org/show_bug.cgi?id=52363
Update references to the new name.
- src/WebImageDecoder.cpp: (WebKit::WebImageDecoder::isFrameCompleteAtIndex): (WebKit::WebImageDecoder::getFrameAtIndex):
2011-01-13 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Rename RGBA32Buffer to ImageFrame
https://bugs.webkit.org/show_bug.cgi?id=52363
RGBA32Buffer is a terrible misnomer. ImageFrame is vastly
more accurate. More cleanup to come.
- WebCore.pro:
- platform/graphics/ImageSource.cpp: (WebCore::ImageSource::createFrameAtIndex): (WebCore::ImageSource::frameDurationAtIndex): (WebCore::ImageSource::frameIsCompleteAtIndex):
- platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::frameBufferAtIndex): (WebCore::ImageDecoderQt::internalReadImage): (WebCore::ImageDecoderQt::internalHandleCurrentImage):
- platform/graphics/qt/ImageDecoderQt.h:
- platform/graphics/wince/ImageWinCE.cpp: (WebCore::ImageFrame::asNewNativeImage):
- platform/image-decoders/ImageDecoder.cpp: (WebCore::ImageFrame::ImageFrame): (WebCore::ImageFrame::operator=): (WebCore::ImageFrame::clear): (WebCore::ImageFrame::zeroFill): (WebCore::ImageFrame::copyReferenceToBitmapData): (WebCore::ImageFrame::copyBitmapData): (WebCore::ImageFrame::setSize): (WebCore::ImageFrame::hasAlpha): (WebCore::ImageFrame::setHasAlpha): (WebCore::ImageFrame::setColorProfile): (WebCore::ImageFrame::setStatus): (WebCore::ImageFrame::width): (WebCore::ImageFrame::height):
- platform/image-decoders/ImageDecoder.h: (WebCore::ImageFrame::ImageFrame):
- platform/image-decoders/bmp/BMPImageDecoder.cpp: (WebCore::BMPImageDecoder::frameBufferAtIndex): (WebCore::BMPImageDecoder::decode):
- platform/image-decoders/bmp/BMPImageDecoder.h:
- platform/image-decoders/bmp/BMPImageReader.cpp: (WebCore::BMPImageReader::decodeBMP):
- platform/image-decoders/bmp/BMPImageReader.h: (WebCore::BMPImageReader::setBuffer):
- platform/image-decoders/cairo/ImageDecoderCairo.cpp: (WebCore::ImageFrame::asNewNativeImage):
- platform/image-decoders/cg/ImageDecoderCG.cpp: (WebCore::getPtrAsPixelData): (WebCore::ImageFrame::copyReferenceToBitmapData): (WebCore::ImageFrame::copyBitmapData): (WebCore::ImageFrame::setSize): (WebCore::ImageFrame::asNewNativeImage):
- platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::frameBufferAtIndex): (WebCore::GIFImageDecoder::clearFrameBufferCache): (WebCore::GIFImageDecoder::haveDecodedRow): (WebCore::GIFImageDecoder::frameComplete): (WebCore::GIFImageDecoder::initFrameBuffer):
- platform/image-decoders/gif/GIFImageDecoder.h:
- platform/image-decoders/gif/GIFImageReader.cpp: (GIFImageReader::read):
- platform/image-decoders/gif/GIFImageReader.h: (GIFFrameReader::GIFFrameReader):
- platform/image-decoders/haiku/ImageDecoderHaiku.cpp: (WebCore::ImageFrame::asNewNativeImage):
- platform/image-decoders/ico/ICOImageDecoder.cpp: (WebCore::ICOImageDecoder::frameBufferAtIndex): (WebCore::ICOImageDecoder::decode):
- platform/image-decoders/ico/ICOImageDecoder.h:
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageDecoder::frameBufferAtIndex): (WebCore::JPEGImageDecoder::outputScanlines): (WebCore::JPEGImageDecoder::jpegComplete): (WebCore::JPEGImageDecoder::decode):
- platform/image-decoders/jpeg/JPEGImageDecoder.h:
- platform/image-decoders/openvg/ImageDecoderOpenVG.cpp: (WebCore::ImageFrame::asNewNativeImage):
- platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::frameBufferAtIndex): (WebCore::PNGImageDecoder::rowAvailable): (WebCore::PNGImageDecoder::pngComplete):
- platform/image-decoders/png/PNGImageDecoder.h: (WebCore::PNGImageDecoder::isComplete):
- platform/image-decoders/qt/ImageFrameQt.cpp: Copied from Source/WebCore/platform/image-decoders/qt/RGBA32BufferQt.cpp. (WebCore::ImageFrame::ImageFrame): (WebCore::ImageFrame::operator=): (WebCore::ImageFrame::clear): (WebCore::ImageFrame::zeroFill): (WebCore::ImageFrame::copyBitmapData): (WebCore::ImageFrame::setSize): (WebCore::ImageFrame::asNewNativeImage): (WebCore::ImageFrame::hasAlpha): (WebCore::ImageFrame::setHasAlpha): (WebCore::ImageFrame::setColorProfile): (WebCore::ImageFrame::setStatus): (WebCore::ImageFrame::setPixmap): (WebCore::ImageFrame::width): (WebCore::ImageFrame::height):
- platform/image-decoders/qt/RGBA32BufferQt.cpp: Removed.
- platform/image-decoders/skia/ImageDecoderSkia.cpp: (WebCore::ImageFrame::ImageFrame): (WebCore::ImageFrame::operator=): (WebCore::ImageFrame::clear): (WebCore::ImageFrame::zeroFill): (WebCore::ImageFrame::copyBitmapData): (WebCore::ImageFrame::setSize): (WebCore::ImageFrame::asNewNativeImage): (WebCore::ImageFrame::hasAlpha): (WebCore::ImageFrame::setHasAlpha): (WebCore::ImageFrame::setColorProfile): (WebCore::ImageFrame::setStatus): (WebCore::ImageFrame::width): (WebCore::ImageFrame::height):
- platform/image-decoders/webp/WEBPImageDecoder.cpp: (WebCore::WEBPImageDecoder::frameBufferAtIndex): (WebCore::WEBPImageDecoder::decode):
- platform/image-decoders/webp/WEBPImageDecoder.h:
- platform/image-decoders/wx/ImageDecoderWx.cpp: (WebCore::ImageFrame::asNewNativeImage):
- 3:52 PM Changeset in webkit [75747] by
-
- 3 edits in trunk/Websites/bugs.webkit.org
2011-01-13 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
add container divs for diff blocks
https://bugs.webkit.org/show_bug.cgi?id=52400
This will help simplify a lot of code in code-review.js
and make side-by-side diffs better (i.e. put removed lines
to the left of corresponding added lines).
Also, allow for running the JS from a local file. Now you can modify code-review.js
to point to a local file and then run:
ruby prettify.rb < foo.diff > foo.html
foo.html will load a dummy code review matching foo.diff.
Before structure:
Line
Line remove
Line add
Line add
Line
After structure:
DiffBlock
DiffBlockPart shared
Line shared
DiffBlock
DiffBlockPart remove
Line remove
DiffBlockPart add
Line add
Line add
DiffBlock
DiffBlockPart shared
Line shared
- PrettyPatch/PrettyPatch.rb:
- code-review.js:
- 3:38 PM Changeset in webkit [75746] by
-
- 4 edits in trunk/Source/WebCore
2011-01-13 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Adler.
Transferring nodes between documents should be aware of the shadow DOM.
https://bugs.webkit.org/show_bug.cgi?id=52399
No visible change in behavior at the moment.
Once https://bugs.webkit.org/show_bug.cgi?id=52317 lands, the following
tests should no longer crash:
- fast/css/pseudo-in-range-invalid-value.html
- fast/css/pseudo-in-range.html
- fast/forms/form-collection-elements.html
- fast/forms/range-keyoperation.html
- dom/Document.cpp: (WebCore::Document::adoptNode): Changed to use Node::setDocumentRecursively.
- dom/Node.cpp: (WebCore::Node::setDocumentRecursively): Added new method, taking existing
logic and adding shadow DOM traversal.
(WebCore::Node::traverseNextNode): Style fix.
(WebCore::Node::traverseNextSibling): Ditto.
(WebCore::Node::traversePreviousNode): Ditto.
(WebCore::Node::traversePreviousNodePostOrder): Ditto.
(WebCore::Node::checkReplaceChild): Changed to use setDocumentRecursively.
(WebCore::Node::checkAddChild): Ditto.
- dom/Node.h: Added def.
- 3:28 PM Changeset in webkit [75745] by
-
- 2 edits in trunk/LayoutTests
2011-01-13 Justin Schuh <jschuh@chromium.org>
Unreviewed chromium expectations update.
Remove exception for canvas-large-dimensions.html.
- platform/chromium/test_expectations.txt:
- 3:19 PM Changeset in webkit [75744] by
-
- 1 copy in tags/Safari-534.15.7
New tag.
- 3:14 PM Changeset in webkit [75743] by
-
- 30 edits1 add in trunk
Source/WebCore: WebKit2: Add support for drag and drop
https://bugs.webkit.org/show_bug.cgi?id=52343
<rdar://problem/7660558>
Reviewed by Darin Adler.
This patch contains the changes required to support dropping content
in WebKit on the Mac. The DragData class has been extended to provide
additional context from the application (keyboard state, modal windows, etc.)
as well as information of the drag pasteboard being used.
The support for WebKit as drag source will be added with a separate patch.
- WebCore.exp.in:
- page/DragController.cpp:
(WebCore::DragController::dragIsMove): Added DragData parameter.
(WebCore::DragController::tryDocumentDrag): Modified call to dragIsMove.
(WebCore::DragController::concludeEditDrag): Same as above.
- page/DragController.h: Added parameter to isCopyKeyDown.
- page/mac/DragControllerMac.mm:
The following methods have been modified to use the information stored
in the DragData class.
(WebCore::DragController::isCopyKeyDown):
(WebCore::DragController::dragOperation):
- platform/DragData.h:
(WebCore::DragData::flags):
- platform/DragData.cpp: Added default flags parameter to the constructor.
- platform/mac/DragDataMac.mm:
(WebCore::DragData::DragData): Added constructor that receives the name of the pasteboard to use.
(WebCore::DragData::canSmartReplace):
(WebCore::DragData::containsColor):
(WebCore::DragData::containsFiles):
(WebCore::DragData::asFilenames):
(WebCore::DragData::containsPlainText):
(WebCore::DragData::asPlainText):
(WebCore::DragData::containsCompatibleContent):
(WebCore::DragData::asURL):
(WebCore::DragData::asFragment):
All the following files have been modified to add the DragData
parameter to isCopyKeyDown. I plan to improve this in the future
and make isCopyKeyDown not platform specific.
- page/android/DragControllerAndroid.cpp:
(WebCore::DragController::isCopyKeyDown):
- page/brew/DragControllerBrew.cpp:
(WebCore::DragController::isCopyKeyDown):
- page/chromium/DragControllerChromium.cpp:
(WebCore::DragController::isCopyKeyDown):
- page/efl/DragControllerEfl.cpp:
(WebCore::DragController::isCopyKeyDown):
- page/gtk/DragControllerGtk.cpp:
(WebCore::DragController::isCopyKeyDown):
- page/haiku/DragControllerHaiku.cpp:
(WebCore::DragController::isCopyKeyDown):
- page/mac/DragControllerMac.mm:
(WebCore::DragController::isCopyKeyDown):
(WebCore::DragController::dragOperation):
- page/qt/DragControllerQt.cpp:
(WebCore::DragController::isCopyKeyDown):
- page/win/DragControllerWin.cpp:
(WebCore::DragController::isCopyKeyDown):
- page/wx/DragControllerWx.cpp:
(WebCore::DragController::isCopyKeyDown):
WebKit/mac: WebKit2: Add support for drag and drop
https://bugs.webkit.org/show_bug.cgi?id=52343
<rdar://problem/7660558>
Reviewed by Darin Adler.
The DragData class has been extended to provide
additional context from the application (keyboard state, modal windows, etc.)
as well as information of the drag pasteboard being used.
These are the changes to align the behavior for WebKit.
- WebView/WebView.mm:
(-[WebView applicationFlags:]): Added.
(-[WebView draggingEntered:]): Added parameter to the DragData constructor.
(-[WebView draggingUpdated:]): Added parameter to the DragData constructor.
(-[WebView draggingExited:]): Added parameter to the DragData constructor.
(-[WebView performDragOperation:]): Added parameter to the DragData constructor.
WebKit2: WebKit2: Add support for drag and drop
https://bugs.webkit.org/show_bug.cgi?id=52343
<rdar://problem/7660558>
Reviewed by Darin Adler.
This patch contains the changes required to support dropping content
in WebKit on the Mac. The DragData class has been extended to provide
additional context from the application (keyboard state, modal windows, etc.)
as well as information of the drag pasteboard being used.
The support for WebKit as drag source will be added with a separate patch.
- Shared/DragControllerAction.h: Added.
- UIProcess/API/mac/WKView.mm:
Added implemention of the methods required to add suport for a drop target.
To maintain asynchronous communication with the WebProcess, we always return
the previous calculated value for the drag operation.
(-[WKView _registerDraggedTypes]):
(-[WKView initWithFrame:contextRef:pageGroupRef:]):
(-[WKView applicationFlags:]):
(-[WKView draggingEntered:]):
(-[WKView draggingUpdated:]):
(-[WKView draggingExited:]):
(-[WKView prepareForDragOperation:]):
(-[WKView performDragOperation:]):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::performDragControllerAction):
(WebKit::WebPageProxy::didPerformDragControllerAction):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::dragOperation):
(WebKit::WebPageProxy::resetDragOperation):
- UIProcess/WebPageProxy.messages.in:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebCoreSupport/WebDragClient.cpp:
(WebKit::WebDragClient::willPerformDragDestinationAction):
(WebKit::WebDragClient::willPerformDragSourceAction):
(WebKit::WebDragClient::actionMaskForDrag):
(WebKit::WebDragClient::dragSourceActionMaskForPoint):
(WebKit::WebDragClient::startDrag):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::performDragControllerAction):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- 3:11 PM Changeset in webkit [75742] by
-
- 2 edits in trunk/Source/WebCore
Add missing MathMLElementFactory.h and MathMLNames.h to Xcode project
Not reviewed.
- WebCore.xcodeproj/project.pbxproj: Add missing headers. Note
that the corresponding source files were originally added to the
project in r48559.
- 3:05 PM Changeset in webkit [75741] by
-
- 17 edits in trunk/Source/WebCore
2011-01-12 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Use GC3D types in WebGLRenderingContext and related WebGL classes
https://bugs.webkit.org/show_bug.cgi?id=51908
- html/canvas/WebGLActiveInfo.h: (WebCore::WebGLActiveInfo::create): (WebCore::WebGLActiveInfo::type): (WebCore::WebGLActiveInfo::size): (WebCore::WebGLActiveInfo::WebGLActiveInfo):
- html/canvas/WebGLBuffer.cpp: (WebCore::WebGLBuffer::associateBufferDataImpl): (WebCore::WebGLBuffer::associateBufferData): (WebCore::WebGLBuffer::associateBufferSubDataImpl): (WebCore::WebGLBuffer::associateBufferSubData): (WebCore::WebGLBuffer::byteLength): (WebCore::WebGLBuffer::getCachedMaxIndex): (WebCore::WebGLBuffer::setCachedMaxIndex): (WebCore::WebGLBuffer::setTarget):
- html/canvas/WebGLBuffer.h: (WebCore::WebGLBuffer::getTarget):
- html/canvas/WebGLFramebuffer.cpp: (WebCore::WebGLFramebuffer::setAttachment): (WebCore::WebGLFramebuffer::getAttachment): (WebCore::WebGLFramebuffer::getWidth): (WebCore::WebGLFramebuffer::getHeight): (WebCore::WebGLFramebuffer::getColorBufferFormat): (WebCore::WebGLFramebuffer::initializeRenderbuffers):
- html/canvas/WebGLFramebuffer.h:
- html/canvas/WebGLProgram.cpp: (WebCore::WebGLProgram::cacheActiveAttribLocations): (WebCore::WebGLProgram::numActiveAttribLocations): (WebCore::WebGLProgram::getActiveAttribLocation): (WebCore::WebGLProgram::isUsingVertexAttrib0):
- html/canvas/WebGLProgram.h: (WebCore::WebGLProgram::getLinkCount):
- html/canvas/WebGLRenderbuffer.h: (WebCore::WebGLRenderbuffer::setInternalFormat): (WebCore::WebGLRenderbuffer::getInternalFormat): (WebCore::WebGLRenderbuffer::setSize): (WebCore::WebGLRenderbuffer::getWidth): (WebCore::WebGLRenderbuffer::getHeight):
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::initializeNewContext): (WebCore::WebGLRenderingContext::sizeInBytes): (WebCore::WebGLRenderingContext::activeTexture): (WebCore::WebGLRenderingContext::bindAttribLocation): (WebCore::WebGLRenderingContext::bindBuffer): (WebCore::WebGLRenderingContext::bindFramebuffer): (WebCore::WebGLRenderingContext::bindRenderbuffer): (WebCore::WebGLRenderingContext::bindTexture): (WebCore::WebGLRenderingContext::blendColor): (WebCore::WebGLRenderingContext::blendEquation): (WebCore::WebGLRenderingContext::blendEquationSeparate): (WebCore::WebGLRenderingContext::blendFunc): (WebCore::WebGLRenderingContext::blendFuncSeparate): (WebCore::WebGLRenderingContext::bufferData): (WebCore::WebGLRenderingContext::bufferSubData): (WebCore::WebGLRenderingContext::checkFramebufferStatus): (WebCore::WebGLRenderingContext::clear): (WebCore::WebGLRenderingContext::clearColor): (WebCore::WebGLRenderingContext::clearDepth): (WebCore::WebGLRenderingContext::clearStencil): (WebCore::WebGLRenderingContext::colorMask): (WebCore::WebGLRenderingContext::copyTexImage2D): (WebCore::WebGLRenderingContext::copyTexSubImage2D): (WebCore::WebGLRenderingContext::createShader): (WebCore::WebGLRenderingContext::cullFace): (WebCore::WebGLRenderingContext::deleteBuffer): (WebCore::WebGLRenderingContext::depthFunc): (WebCore::WebGLRenderingContext::depthMask): (WebCore::WebGLRenderingContext::depthRange): (WebCore::WebGLRenderingContext::disable): (WebCore::WebGLRenderingContext::disableVertexAttribArray): (WebCore::WebGLRenderingContext::validateElementArraySize): (WebCore::WebGLRenderingContext::validateIndexArrayConservative): (WebCore::WebGLRenderingContext::validateIndexArrayPrecise): (WebCore::WebGLRenderingContext::validateRenderingState): (WebCore::WebGLRenderingContext::drawArrays): (WebCore::WebGLRenderingContext::drawElements): (WebCore::WebGLRenderingContext::enable): (WebCore::WebGLRenderingContext::enableVertexAttribArray): (WebCore::WebGLRenderingContext::framebufferRenderbuffer): (WebCore::WebGLRenderingContext::framebufferTexture2D): (WebCore::WebGLRenderingContext::frontFace): (WebCore::WebGLRenderingContext::generateMipmap): (WebCore::WebGLRenderingContext::getActiveAttrib): (WebCore::WebGLRenderingContext::getActiveUniform): (WebCore::WebGLRenderingContext::getAttachedShaders): (WebCore::WebGLRenderingContext::getAttribLocation): (WebCore::WebGLRenderingContext::getBufferParameter): (WebCore::WebGLRenderingContext::getError): (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): (WebCore::WebGLRenderingContext::getParameter): (WebCore::WebGLRenderingContext::getProgramParameter): (WebCore::WebGLRenderingContext::getRenderbufferParameter): (WebCore::WebGLRenderingContext::getShaderParameter): (WebCore::WebGLRenderingContext::getTexParameter): (WebCore::WebGLRenderingContext::getUniform): (WebCore::WebGLRenderingContext::getUniformLocation): (WebCore::WebGLRenderingContext::getVertexAttrib): (WebCore::WebGLRenderingContext::getVertexAttribOffset): (WebCore::WebGLRenderingContext::hint): (WebCore::WebGLRenderingContext::isBuffer): (WebCore::WebGLRenderingContext::isEnabled): (WebCore::WebGLRenderingContext::isFramebuffer): (WebCore::WebGLRenderingContext::isProgram): (WebCore::WebGLRenderingContext::isRenderbuffer): (WebCore::WebGLRenderingContext::isShader): (WebCore::WebGLRenderingContext::isTexture): (WebCore::WebGLRenderingContext::lineWidth): (WebCore::WebGLRenderingContext::linkProgram): (WebCore::WebGLRenderingContext::pixelStorei): (WebCore::WebGLRenderingContext::polygonOffset): (WebCore::WebGLRenderingContext::readPixels): (WebCore::WebGLRenderingContext::renderbufferStorage): (WebCore::WebGLRenderingContext::sampleCoverage): (WebCore::WebGLRenderingContext::scissor): (WebCore::WebGLRenderingContext::stencilFunc): (WebCore::WebGLRenderingContext::stencilFuncSeparate): (WebCore::WebGLRenderingContext::stencilMask): (WebCore::WebGLRenderingContext::stencilMaskSeparate): (WebCore::WebGLRenderingContext::stencilOp): (WebCore::WebGLRenderingContext::stencilOpSeparate): (WebCore::WebGLRenderingContext::texImage2DBase): (WebCore::WebGLRenderingContext::texImage2DImpl): (WebCore::WebGLRenderingContext::texImage2D): (WebCore::WebGLRenderingContext::texParameter): (WebCore::WebGLRenderingContext::texParameterf): (WebCore::WebGLRenderingContext::texParameteri): (WebCore::WebGLRenderingContext::texSubImage2DBase): (WebCore::WebGLRenderingContext::texSubImage2DImpl): (WebCore::WebGLRenderingContext::texSubImage2D): (WebCore::WebGLRenderingContext::uniform1f): (WebCore::WebGLRenderingContext::uniform1fv): (WebCore::WebGLRenderingContext::uniform1i): (WebCore::WebGLRenderingContext::uniform1iv): (WebCore::WebGLRenderingContext::uniform2f): (WebCore::WebGLRenderingContext::uniform2fv): (WebCore::WebGLRenderingContext::uniform2i): (WebCore::WebGLRenderingContext::uniform2iv): (WebCore::WebGLRenderingContext::uniform3f): (WebCore::WebGLRenderingContext::uniform3fv): (WebCore::WebGLRenderingContext::uniform3i): (WebCore::WebGLRenderingContext::uniform3iv): (WebCore::WebGLRenderingContext::uniform4f): (WebCore::WebGLRenderingContext::uniform4fv): (WebCore::WebGLRenderingContext::uniform4i): (WebCore::WebGLRenderingContext::uniform4iv): (WebCore::WebGLRenderingContext::uniformMatrix2fv): (WebCore::WebGLRenderingContext::uniformMatrix3fv): (WebCore::WebGLRenderingContext::uniformMatrix4fv): (WebCore::WebGLRenderingContext::vertexAttrib1f): (WebCore::WebGLRenderingContext::vertexAttrib1fv): (WebCore::WebGLRenderingContext::vertexAttrib2f): (WebCore::WebGLRenderingContext::vertexAttrib2fv): (WebCore::WebGLRenderingContext::vertexAttrib3f): (WebCore::WebGLRenderingContext::vertexAttrib3fv): (WebCore::WebGLRenderingContext::vertexAttrib4f): (WebCore::WebGLRenderingContext::vertexAttrib4fv): (WebCore::WebGLRenderingContext::vertexAttribPointer): (WebCore::WebGLRenderingContext::viewport): (WebCore::WebGLRenderingContext::getBooleanParameter): (WebCore::WebGLRenderingContext::getBooleanArrayParameter): (WebCore::WebGLRenderingContext::getFloatParameter): (WebCore::WebGLRenderingContext::getIntParameter): (WebCore::WebGLRenderingContext::getLongParameter): (WebCore::WebGLRenderingContext::getUnsignedLongParameter): (WebCore::WebGLRenderingContext::getWebGLFloatArrayParameter): (WebCore::WebGLRenderingContext::getWebGLIntArrayParameter): (WebCore::WebGLRenderingContext::isTexInternalFormatColorBufferCombinationValid): (WebCore::WebGLRenderingContext::getBoundFramebufferColorFormat): (WebCore::WebGLRenderingContext::validateTextureBinding): (WebCore::WebGLRenderingContext::validateSize): (WebCore::WebGLRenderingContext::validateTexFuncFormatAndType): (WebCore::WebGLRenderingContext::validateTexFuncLevel): (WebCore::WebGLRenderingContext::validateTexFuncParameters): (WebCore::WebGLRenderingContext::validateTexFuncData): (WebCore::WebGLRenderingContext::validateDrawMode): (WebCore::WebGLRenderingContext::validateStencilFunc): (WebCore::WebGLRenderingContext::validateFramebufferFuncParameters): (WebCore::WebGLRenderingContext::validateBlendEquation): (WebCore::WebGLRenderingContext::validateBlendFuncFactors): (WebCore::WebGLRenderingContext::validateCapability): (WebCore::WebGLRenderingContext::validateUniformParameters): (WebCore::WebGLRenderingContext::validateUniformMatrixParameters): (WebCore::WebGLRenderingContext::validateBufferDataParameters): (WebCore::WebGLRenderingContext::vertexAttribfImpl): (WebCore::WebGLRenderingContext::vertexAttribfvImpl): (WebCore::WebGLRenderingContext::simulateVertexAttrib0):
- html/canvas/WebGLRenderingContext.h: (WebCore::WebGLRenderingContext::VertexAttribState::VertexAttribState):
- html/canvas/WebGLShader.cpp: (WebCore::WebGLShader::create): (WebCore::WebGLShader::WebGLShader):
- html/canvas/WebGLShader.h: (WebCore::WebGLShader::getType):
- html/canvas/WebGLTexture.cpp: (WebCore::WebGLTexture::setTarget): (WebCore::WebGLTexture::setParameteri): (WebCore::WebGLTexture::setParameterf): (WebCore::WebGLTexture::setLevelInfo): (WebCore::WebGLTexture::generateMipmapLevelInfo): (WebCore::WebGLTexture::getInternalFormat): (WebCore::WebGLTexture::getType): (WebCore::WebGLTexture::getWidth): (WebCore::WebGLTexture::getHeight): (WebCore::WebGLTexture::isNPOT): (WebCore::WebGLTexture::mapTargetToIndex): (WebCore::WebGLTexture::computeLevelCount): (WebCore::WebGLTexture::update): (WebCore::WebGLTexture::getLevelInfo):
- html/canvas/WebGLTexture.h: (WebCore::WebGLTexture::LevelInfo::setInfo):
- html/canvas/WebGLUniformLocation.cpp: (WebCore::WebGLUniformLocation::create): (WebCore::WebGLUniformLocation::WebGLUniformLocation): (WebCore::WebGLUniformLocation::location):
- html/canvas/WebGLUniformLocation.h:
- platform/graphics/GraphicsContext3D.h: Map GC3Dboolean to bool instead of unsigned char.
- 3:00 PM Changeset in webkit [75740] by
-
- 2 edits in trunk/LayoutTests
2011-01-13 Martin Robinson <mrobinson@igalia.com>
Unskip editing/input/page-up-down-scrolls.html as it's passing locally.
- platform/gtk/Skipped: Unskip test.
- 2:55 PM Changeset in webkit [75739] by
-
- 33 edits3 adds in trunk
Change createObjectURL and revokeObjectURL to put under webkitURL.
https://bugs.webkit.org/show_bug.cgi?id=52257
Reviewed by Darin Fisher.
Source/WebCore:
Note that we add "webkit" vendor prefix to URL that is introduced in
the latest File API spec.
For the time being, we implement webkitURL as a readonly attribute
instead of a constructor so that we will not expose prototype property,
as required by the spec.
- Android.derived.jscbindings.mk:
- Android.derived.v8bindings.mk:
- Android.mk:
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pri:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- html/DOMURL.cpp: Added.
- html/DOMURL.h: Added.
- html/DOMURL.idl: Added.
- inspector/front-end/NetworkPanel.js:
- inspector/front-end/utilities.js:
- page/DOMWindow.cpp:
(WebCore::DOMWindow::webkitURL):
- page/DOMWindow.h:
- page/DOMWindow.idl:
- workers/WorkerContext.cpp:
(WebCore::WorkerContext::webkitURL):
- workers/WorkerContext.h:
- workers/WorkerContext.idl:
LayoutTests:
Change all related test scripts and results to account for this change.
- fast/dom/Window/script-tests/window-property-descriptors.js:
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/Window/window-properties.html:
- fast/dom/script-tests/prototype-inheritance-2.js:
- fast/dom/script-tests/prototype-inheritance.js:
- fast/files/apply-blob-url-to-img.html:
- fast/files/apply-blob-url-to-xhr.html:
- fast/files/create-blob-url-crash.html:
- fast/files/revoke-blob-url.html:
- fast/files/workers/resources/worker-apply-blob-url-to-xhr.js:
(onmessage):
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- 2:49 PM Changeset in webkit [75738] by
-
- 6 edits2 adds in trunk
2011-01-13 Emil Eklund <eae@chromium.org>
Reviewed by Dimitri Glazkov.
Setting outerText should convert CR/LF to <br>
https://bugs.webkit.org/show_bug.cgi?id=52268
Add test for setting Element.outerText.
- fast/dom/set-outer-text-expected.txt: Added.
- fast/dom/set-outer-text.html: Added.
- fast/dom/text-node-append-data-remove-crash-expected.txt: Changed
expectation to "didn't crash" from "threw dom exception" as test
assumed the DOMCharacterDataModified event would fire before the node
would be replaced.
- fast/dom/text-node-append-data-remove-crash.html:
2011-01-13 Emil Eklund <eae@chromium.org>
Reviewed by Dimitri Glazkov.
Setting outerText should convert CR/LF to <br>
https://bugs.webkit.org/show_bug.cgi?id=52268
Make set outerText support line breaks (sharing the text to fragment code
with setInnerText) and handle empty text nodes the same way IE does.
Test: fast/dom/set-outer-text.html
- html/HTMLElement.cpp: (WebCore::HTMLElement::textToFragment): Shared between setInnerText and setOuterText (WebCore::HTMLElement::setInnerText): Split out text parsing code. (WebCore::mergeWithNextTextNode): Split out text node merging code. (WebCore::HTMLElement::setOuterText): Added support for line breaks.
- html/HTMLElement.h:
- 2:39 PM Changeset in webkit [75737] by
-
- 2 edits in trunk/LayoutTests
Skip a crashing test on Windows
See <http://webkit.org/b/52397>.
- platform/win/Skipped: Added
compositing/reflections/load-video-in-reflection.html.
- 2:35 PM Changeset in webkit [75736] by
-
- 2 edits in trunk/LayoutTests
2011-01-13 Martin Robinson <mrobinson@igalia.com>
Skip fast/text/emphasis.html as it shows a 1 pixel difference on the 32-bit Debug bot.
- platform/gtk/Skipped: Skip fast/text/emphasis.html.
- 2:34 PM Changeset in webkit [75735] by
-
- 5 edits in trunk
2011-01-13 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Relax the ESSL valid charset a little bit to include " ' `
https://bugs.webkit.org/show_bug.cgi?id=52396
- html/canvas/WebGLRenderingContext.cpp:
2011-01-13 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Relax the ESSL valid charset a little bit to include " ' `
https://bugs.webkit.org/show_bug.cgi?id=52396
- fast/canvas/webgl/invalid-passed-params-expected.txt:
- fast/canvas/webgl/invalid-passed-params.html:
- 1:52 PM Changeset in webkit [75734] by
-
- 2 edits in trunk/WebKit/chromium
2011-01-13 John Abd-El-Malek <jam@chromium.org>
Reviewed by Tony Chang.
[chromium]: Only swallow ctrl+c for windowless plugins if we know the plugin has a selection
https://bugs.webkit.org/show_bug.cgi?id=52393
- src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::copy): (WebKit::WebPluginContainerImpl::handleKeyboardEvent):
- 12:51 PM Changeset in webkit [75733] by
-
- 2 edits in trunk/Source/WebCore
2011-01-13 Adrienne Walker <enne@google.com>
Reviewed by Kenneth Russell.
[chromium] Attempt to fix crash in tiled compositor memcpy
https://bugs.webkit.org/show_bug.cgi?id=52379
- platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::update):
- 12:36 PM Changeset in webkit [75732] by
-
- 2 edits1 add in trunk/LayoutTests
2011-01-13 Matthew Delaney <mdelaney@apple.com>
Reviewed by nobody - reinstrumenting a test to save burning trees.
fast/canvas/canvas-large-dimensions.html (introduced in r75648) is failing on all platforms except Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=52341
- fast/canvas/canvas-large-dimensions-expected.txt: Replaced.
- fast/canvas/canvas-large-dimensions.html:
- 12:11 PM Changeset in webkit [75731] by
-
- 2 edits in trunk/LayoutTests
2011-01-13 Justin Schuh <jschuh@chromium.org>
Unreviewed chromium expectations update.
Exclude destroy-on-setwindow.html (added in r75720).
- platform/chromium/test_expectations.txt:
- 12:07 PM Changeset in webkit [75730] by
-
- 6 edits in trunk/WebKit/chromium
2011-01-11 John Abd-El-Malek <jam@chromium.org>
Reviewed by Darin Fisher.
[chromium] Add support to allow printing just a plugin in a frame
https://bugs.webkit.org/show_bug.cgi?id=52134
- public/WebContextMenuData.h:
- public/WebFrame.h:
- src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
- src/WebFrameImpl.cpp: (WebKit::ChromePluginPrintContext::ChromePluginPrintContext): (WebKit::ChromePluginPrintContext::end): (WebKit::ChromePluginPrintContext::computePageRects): (WebKit::ChromePluginPrintContext::spoolPage): (WebKit::WebFrameImpl::printBegin):
- 11:48 AM Changeset in webkit [75729] by
-
- 6 edits in trunk
2011-01-13 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[gtk] Zero-sized font does not yet work
https://bugs.webkit.org/show_bug.cgi?id=49793
Unskip font-size-zero.html.
- platform/gtk/Skipped:
2011-01-13 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[gtk] Zero-sized font does not yet work
https://bugs.webkit.org/show_bug.cgi?id=49793
Set minimum-font-size to 0 for the DRT.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
2011-01-13 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[gtk] Zero-sized font does not yet work
https://bugs.webkit.org/show_bug.cgi?id=49793
Allow 0 as a minimum-font-size value for the settings.
- webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init):
- 11:38 AM Changeset in webkit [75728] by
-
- 12 edits in trunk/Source/WebCore
Unreviewed, rolling out r75725.
http://trac.webkit.org/changeset/75725
https://bugs.webkit.org/show_bug.cgi?id=52317
Caused crashes in layout tests.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::initForStyleResolve):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateType):
- html/InputType.cpp:
- html/InputType.h:
- html/RangeInputType.cpp:
- html/RangeInputType.h:
- html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::defaultEventHandler):
(WebCore::SliderThumbElement::detach):
- html/shadow/SliderThumbElement.h:
(WebCore::SliderThumbElement::SliderThumbElement):
(WebCore::SliderThumbElement::create):
- rendering/MediaControlElements.cpp:
(WebCore::MediaControlInputElement::attach):
(WebCore::MediaControlInputElement::updateStyle):
- rendering/RenderSlider.cpp:
(WebCore::RenderSlider::~RenderSlider):
(WebCore::RenderSlider::styleDidChange):
(WebCore::RenderSlider::createThumbStyle):
(WebCore::RenderSlider::thumbRect):
(WebCore::RenderSlider::layout):
(WebCore::RenderSlider::updateFromElement):
(WebCore::RenderSlider::mouseEventIsInThumb):
(WebCore::RenderSlider::mouseEventOffsetToThumb):
(WebCore::RenderSlider::setValueForPosition):
(WebCore::RenderSlider::positionForOffset):
(WebCore::RenderSlider::currentPosition):
(WebCore::RenderSlider::trackSize):
(WebCore::RenderSlider::forwardEvent):
(WebCore::RenderSlider::inDragMode):
- rendering/RenderSlider.h:
- 10:56 AM Changeset in webkit [75727] by
-
- 2 edits in trunk/LayoutTests
2011-01-13 Tony Chang <tony@chromium.org>
Unreviewed, updating chromium test_expectations.txt
- platform/chromium/test_expectations.txt: Mark a test as slow in debug.
- 10:37 AM Changeset in webkit [75726] by
-
- 2 edits in trunk/Tools
2011-01-13 Csaba Osztrogonác <Csaba Osztrogonác>
Reviewed by Darin Adler.
Make old-run-webkit-tests more robust on buildbots
https://bugs.webkit.org/show_bug.cgi?id=52364
- BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
- 10:35 AM Changeset in webkit [75725] by
-
- 12 edits in trunk/Source/WebCore
2011-01-12 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Adler.
Flip input[type=range] to use the new shadow DOM model.
https://bugs.webkit.org/show_bug.cgi?id=52317
This is a straight-up flip, minimal change to the logic, which will be
refactored in a follow-up patch.
Covered by existing tests.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::initForStyleResolve): Changed to use either
host or parent node to find parent.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::updateType): Added logic for destroying/creating
shadow DOM subtree.
- html/InputType.cpp: (WebCore::InputType::createShadowSubtree): Added empty decl. (WebCore::InputType::destroyShadowSubtree): Added a method to destroy
shadow subtree.
- html/InputType.h: Added defs.
- html/RangeInputType.cpp: (WebCore::RangeInputType::createShadowSubtree): Added a virtual method to create
slider thumb.
- html/RangeInputType.h: Adde def.
- html/shadow/SliderThumbElement.cpp: Added temporary RenderSliderThumb class
to handle cascading appearance.
(WebCore::RenderSliderThumb::RenderSliderThumb): Added.
(WebCore::RenderSliderThumb::layout): Moved here the logic from
RenderSlider::createThumbStyle.
(WebCore::SliderThumbElement::createRenderer): Added virtual method to
create RenderSliderThumb instance.
(WebCore::SliderThumbElement::defaultEventHandler): Changed to use HTMLDivElement
as base class.
(WebCore::SliderThumbElement::detach): Ditto.
- html/shadow/SliderThumbElement.h: (WebCore::SliderThumbElement::SliderThumbElement): Ditto. (WebCore::SliderThumbElement::create): Ditto. (WebCore::toSliderThumbElement): Added a casting helper.
- rendering/MediaControlElements.cpp: (WebCore::MediaControlInputElement::attach): Added handling of shadow DOM,
since the whole method is hand-rolled.
(WebCore::MediaControlInputElement::updateStyle): Ditto.
- rendering/RenderSlider.cpp: (WebCore::RenderSlider::~RenderSlider): Removed unneeded code. (WebCore::RenderSlider::thumbRect): Changed to use sliderThumbElement helper. (WebCore::RenderSlider::layout): Ditto. (WebCore::RenderSlider::sliderThumbElement): Added a temporary helper to access
SliderThumbElement.
(WebCore::RenderSlider::mouseEventIsInThumb): Changed to use sliderThumbElement helper.
(WebCore::RenderSlider::mouseEventOffsetToThumb): Ditto.
(WebCore::RenderSlider::setValueForPosition): Ditto.
(WebCore::RenderSlider::positionForOffset): Ditto.
(WebCore::RenderSlider::currentPosition): Ditto.
(WebCore::RenderSlider::trackSize): Ditto.
(WebCore::RenderSlider::forwardEvent): Ditto.
(WebCore::RenderSlider::inDragMode): Ditto.
- rendering/RenderSlider.h: Added def.
- 10:34 AM Changeset in webkit [75724] by
-
- 1 edit2 adds in trunk/LayoutTests
Check in Windows-XP-specific results for fast/canvas/set-colors.html
See <http://webkit.org/b/52374>.
- platform/win-xp/fast/canvas/set-colors-expected.txt: Added.
- 10:33 AM Changeset in webkit [75723] by
-
- 4 edits1 move1 delete in trunk/LayoutTests
Disable fast/profiler/throw-exception-from-eval.html
This test fails non-deterministically. See <http://webkit.org/b/49801>.
- fast/profiler/throw-exception-from-eval.html-disabled: Renamed from LayoutTests/fast/profiler/throw-exception-from-eval.html.
- platform/gtk/Skipped:
- platform/mac-leopard/Skipped:
- platform/qt/Skipped:
Un-skipped this test now that it's been disabled by other means.
- platform/win-xp/fast/profiler/throw-exception-from-eval-expected.txt: Removed.
- 10:24 AM Changeset in webkit [75722] by
-
- 2 edits in trunk/WebKit2
Incorrect assertion in DrawingAreaImpl::scroll()
https://bugs.webkit.org/show_bug.cgi?id=52376
Reviewed by John Sullivan.
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::scroll): Changed to take the fast path if the rects have the same area.
This made the assertion valid, but I removed it anyway.
- 10:22 AM Changeset in webkit [75721] by
-
- 2 edits in trunk/Tools
2011-01-13 Csaba Osztrogonác <Csaba Osztrogonác>
Reviewed by Darin Adler.
Make old-run-webkit-tests more robust on buildbots
https://bugs.webkit.org/show_bug.cgi?id=52364
- Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
- 10:21 AM Changeset in webkit [75720] by
-
- 4 edits2 adds in trunk
<rdar://problem/8098442> Crash in Widget::setFrameRect()
https://bugs.webkit.org/show_bug.cgi?id=52375
Reviewed by Simon Fraser.
Source/WebCore:
Test: plugins/destroy-on-setwindow.html
- platform/mac/WidgetMac.mm:
(WebCore::Widget::setFrameRect): Protect the Widget from being deleted as a result of calling
out to the view.
(WebCore::Widget::getOuterView): Coding style fix.
(WebCore::Widget::paint): Protect the Widget from being deleted as a result of calling out to
the views. This is precautionary, since this function does not applear to access member variables
after such calls.
- platform/wx/WidgetWx.cpp:
(WebCore::Widget::setFrameRect): Protect the Widget from being deleted as a result of calling
out to the platform widget.
LayoutTests:
- plugins/destroy-on-setwindow-expected.txt: Added.
- plugins/destroy-on-setwindow.html: Added.
- 9:52 AM Changeset in webkit [75719] by
-
- 6 edits1 delete in trunk
2011-01-13 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
https://bugs.webkit.org/show_bug.cgi?id=52332
Fix Linux baseline. Mac should now match Safari Mac.
- platform/chromium-linux/plugins/plugin-javascript-access-expected.txt:
- platform/chromium/test_expectations.txt:
2011-01-13 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
https://bugs.webkit.org/show_bug.cgi?id=52332
Forked Info.plist is not longer needed.
- DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
2011-01-13 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
https://bugs.webkit.org/show_bug.cgi?id=52332
- WebKit.gyp: Remove WebKitTestNetscapePlugIn
- 9:25 AM Changeset in webkit [75718] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed buildfix after r75715.
- WebCore.pri:
- WebCore.pro:
- 9:23 AM Changeset in webkit [75717] by
-
- 3 edits in trunk/LayoutTests
2011-01-13 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: inspector extensions tests should not use
sources as test data. Commenting one out temporarily, filing a bug.
- inspector/extensions-events-expected.txt:
- inspector/extensions-events.html:
- 8:57 AM Changeset in webkit [75716] by
-
- 2 edits in trunk/Source/WebCore
2011-01-13 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: Qt build fix.
- WebCore.pri:
- 8:42 AM Changeset in webkit [75715] by
-
- 22 edits1 move1 add in trunk
2011-01-12 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: embed injected script into the backend.
https://bugs.webkit.org/show_bug.cgi?id=52312
InjectedScript belongs to the backend of the system and
should be exposed by means of protocol, not InjectedScriptAccess.
This patch makes injected script a part of the backend.
It introduces single manual generation step (xxd -i) that should be
automated by the build scripts for all the platforms.
- CMakeLists.txt:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::injectedScriptFor):
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::injectedScriptFor):
- inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::injectedScriptSource):
- inspector/InjectedScriptHost.h:
- inspector/Inspector.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::restoreInspectorStateFromCookie):
- inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState):
- inspector/InspectorState.h:
- inspector/front-end/InjectedScript.js: Removed.
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js: (WebInspector.doLoadedDone.propertyNamesCallback): (WebInspector.doLoadedDone):
- inspector/xxd.pl: Added.
2011-01-12 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: embed injected script into the backend.
https://bugs.webkit.org/show_bug.cgi?id=52312
- WebKit.grd:
- 7:49 AM Changeset in webkit [75714] by
-
- 15 edits in trunk
2011-01-13 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Cleanup after r75613 -- make all UI-facing strings
to be passed directly to WebInspector.UIString
- English.lproj/localizedStrings.js:
- inspector/front-end/ApplicationCacheItemsView.js: (WebInspector.ApplicationCacheItemsView.prototype._updateCallback): (WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid):
- inspector/front-end/AuditRules.js: (WebInspector.AuditRules.GzipRule.prototype.doRun): (WebInspector.AuditRules.CookieSizeRule.prototype.processCookies): (WebInspector.AuditRules.StaticCookielessRule.prototype.processCookies):
- inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.EventListenerBreakpointsSidebarPane): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._createCategory):
- inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView.prototype._updateWithCookies):
- inspector/front-end/ImageView.js: (WebInspector.ImageView.prototype._createContentIfNeeded.onImageLoad): (WebInspector.ImageView.prototype._createContentIfNeeded):
- inspector/front-end/NetworkPanel.js: (WebInspector.NetworkTimeCalculator.prototype.formatValue): (WebInspector.NetworkTransferTimeCalculator.prototype.formatValue): (WebInspector.NetworkTransferDurationCalculator.prototype.formatValue):
- inspector/front-end/ProfileDataGridTree.js: (WebInspector.ProfileDataGridNode.prototype.get data.formatMilliseconds): (WebInspector.ProfileDataGridNode.prototype.get data):
- inspector/front-end/Resource.js: (WebInspector.Resource.Type.toUIString): (WebInspector.Resource.Type.toString):
- inspector/front-end/TimelineOverviewPane.js: (WebInspector.TimelineOverviewCalculator.prototype.formatValue):
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelineCalculator.prototype.formatValue): (WebInspector.TimelinePanel.FormattedRecord.prototype._generateAggregatedInfo): (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
- inspector/front-end/utilities.js: ():
- Scripts/check-inspector-strings:
- 7:45 AM Changeset in webkit [75713] by
-
- 5 edits in trunk
2011-01-13 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Need a way to inform the application when a Netscape plugin is created.
https://bugs.webkit.org/show_bug.cgi?id=30179
Added "c" style static method for the application to hook up for
receiving notifications when a plugin is created.
- plugins/symbian/PluginViewSymbian.cpp: (qtwebkit_setPluginCreatedCallback): (WebCore::PluginView::platformStart):
2011-01-13 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Need a way to inform the application when a Netscape plugin is created.
https://bugs.webkit.org/show_bug.cgi?id=30179
Added "c" style static method for the application to hook up for
receiving notifications when a plugin is created.
- symbian/bwins/QtWebKitu.def:
- symbian/eabi/QtWebKitu.def:
- 7:29 AM Changeset in webkit [75712] by
-
- 2 edits in trunk/Source/WebCore
2011-01-13 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Eric Seidel.
[Qt] Use a black background color for the video element on Qt Mobile
https://bugs.webkit.org/show_bug.cgi?id=52252
Use black as the background color for the video element on Qt Mobile.
- css/themeQtMobile.css: (video):
- 7:12 AM Changeset in webkit [75711] by
-
- 3 edits1 add in trunk/Source/WebCore
2011-01-13 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Eric Seidel.
[Qt] Use a big central media play control button for video element
https://bugs.webkit.org/show_bug.cgi?id=52315
When ChromeClient::requiresFullscreenForVideoPlayback() returns true,
all other control buttons for the video element are hidden, except
a big centralized play button.
No new tests because no client implements requiresFullscreenForVideoPlayback yet.
- WebCore.pri:
- css/mediaControlsQtFullscreen.css: Added. (audio): (audio::-webkit-media-controls-panel): (video::-webkit-media-controls-panel): (video:-webkit-full-page-media::-webkit-media-controls-panel): (audio::-webkit-media-controls-mute-button): (video::-webkit-media-controls-mute-button): (audio::-webkit-media-controls-play-button): (video::-webkit-media-controls-play-button): (audio::-webkit-media-controls-timeline-container): (video::-webkit-media-controls-timeline-container): (audio::-webkit-media-controls-current-time-display): (video::-webkit-media-controls-current-time-display): (audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display): (audio::-webkit-media-controls-timeline): (video::-webkit-media-controls-timeline): (audio::-webkit-media-controls-volume-slider-container): (video::-webkit-media-controls-volume-slider-container): (audio::-webkit-media-controls-volume-slider): (video::-webkit-media-controls-volume-slider): (audio::-webkit-media-controls-seek-back-button, video::-webkit-media-controls-seek-back-button): (audio::-webkit-media-controls-seek-forward-button, video::-webkit-media-controls-seek-forward-button): (audio::-webkit-media-controls-fullscreen-button): (video::-webkit-media-controls-fullscreen-button): (audio::-webkit-media-controls-rewind-button, video::-webkit-media-controls-rewind-button): (audio::-webkit-media-controls-return-to-realtime-button, video::-webkit-media-controls-return-to-realtime-button): (audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button):
- platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::extraMediaControlsStyleSheet):
- 4:07 AM Changeset in webkit [75710] by
-
- 2 edits in trunk/Source/WebCore
2011-01-13 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Xan Lopez.
[GTK] Paint toggle buttons inconsistent when the object state is indeterminate
https://bugs.webkit.org/show_bug.cgi?id=52361
Check whether the object state is indeterminate to set the flag
GTK_STATE_FLAG_INCONSISTENT before rendering check and radio
buttons.
- platform/gtk/RenderThemeGtk3.cpp: (WebCore::paintToggle):
- 3:58 AM Changeset in webkit [75709] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-01-13 Xan Lopez <xlopez@igalia.com>
Reviewed by Gavin Barraclough.
JIT requires VM overcommit (particularly on x86-64), Linux does not by default support this without swap?
https://bugs.webkit.org/show_bug.cgi?id=42756
The FixedVMPool Allocator does not work well on systems where
allocating very large amounts of memory upfront is not reasonable,
like Linux without overcommit enabled. As a workaround, on Linux,
default to the values used in embedded environments (in the MB
range), and only jump to the GB range if we detect at runtime that
overcommit is enabled. Should fix crashes on Linux/x86_64 with
less than 3 or 4GB of RAM.
- jit/ExecutableAllocatorFixedVMPool.cpp: (JSC::FixedVMPoolAllocator::free): use new variables for VM pool size and coalesce limit. (JSC::ExecutableAllocator::isValid): swap the variables from embedded to generic values at runtime, on linux, if overcommit is enabled. (JSC::ExecutableAllocator::underMemoryPressure): use new variables for VM pool size and coalesce limit.
- 3:46 AM Changeset in webkit [75708] by
-
- 14 edits2 adds in trunk
2011-01-13 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Extend the Platform Plugin to support full screen video handler
https://bugs.webkit.org/show_bug.cgi?id=51249
Make MediaPlayerPrivateQt support a fullscreen player.
No new tests because LayoutTests/media/media-fullscreen-inline.html already exists.
However, this test failed for Qt (QtMediaPlayer) due to durationchange event getting fired twice.
So, still skip it for Qt.
- WebCore.pro:
- platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt): (WebCore::MediaPlayerPrivateQt::removeVideoItem): (WebCore::MediaPlayerPrivateQt::restoreVideoItem):
- platform/graphics/qt/MediaPlayerPrivateQt.h: (WebCore::MediaPlayerPrivateQt::supportsFullscreen): (WebCore::MediaPlayerPrivateQt::mediaPlayer):
2011-01-13 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Extend the Platform Plugin to support full screen video handler
https://bugs.webkit.org/show_bug.cgi?id=51249
Add a new webkit platform plugin interface to support full screen video handler.
- Api/qwebkitplatformplugin.h: (QWebFullScreenVideoHandler::QWebFullScreenVideoHandler): (QWebFullScreenVideoHandler::~QWebFullScreenVideoHandler):
- WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::ChromeClientQt): (WebCore::ChromeClientQt::~ChromeClientQt): (WebCore::ChromeClientQt::fullScreenVideo): (WebCore::ChromeClientQt::supportsFullscreenForNode): (WebCore::ChromeClientQt::requiresFullscreenForVideoPlayback): (WebCore::ChromeClientQt::enterFullscreenForNode): (WebCore::ChromeClientQt::exitFullscreenForNode):
- WebCoreSupport/ChromeClientQt.h:
- WebCoreSupport/FullScreenVideoQt.cpp: Added. (WebCore::FullScreenVideoQt::FullScreenVideoQt): (WebCore::FullScreenVideoQt::~FullScreenVideoQt): (WebCore::FullScreenVideoQt::enterFullScreenForNode): (WebCore::FullScreenVideoQt::exitFullScreenForNode): (WebCore::FullScreenVideoQt::aboutToClose): (WebCore::FullScreenVideoQt::mediaPlayer): (WebCore::FullScreenVideoQt::mediaPlayerForNode): (WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback):
- WebCoreSupport/FullScreenVideoQt.h: Added. (WebCore::FullScreenVideoQt::isValid):
- WebCoreSupport/QtPlatformPlugin.cpp: (WebCore::QtPlatformPlugin::createFullScreenVideoHandler):
- WebCoreSupport/QtPlatformPlugin.h:
- examples/platformplugin/WebPlugin.cpp: (FullScreenVideoWidget::FullScreenVideoWidget): (FullScreenVideoWidget::event): (FullScreenVideoWidget::keyPressEvent): (FullScreenVideoHandler::FullScreenVideoHandler): (FullScreenVideoHandler::~FullScreenVideoHandler): (FullScreenVideoHandler::requiresFullScreenForVideoPlayback): (FullScreenVideoHandler::enterFullScreen): (FullScreenVideoHandler::exitFullScreen): (WebPlugin::supportsExtension): (WebPlugin::createExtension):
- examples/platformplugin/WebPlugin.h: (FullScreenVideoWidget::~FullScreenVideoWidget):
- examples/platformplugin/platformplugin.pro:
- examples/platformplugin/qwebkitplatformplugin.h: (QWebFullScreenVideoHandler::QWebFullScreenVideoHandler): (QWebFullScreenVideoHandler::~QWebFullScreenVideoHandler):
- 1:50 AM Changeset in webkit [75707] by
-
- 3 edits2 adds in trunk
<rdar://problem/8858548> Disable inheritance of text emphasis marks to ruby text
https://bugs.webkit.org/show_bug.cgi?id=52359
Reviewed by Dave Hyatt.
Source/WebCore:
Test: fast/ruby/text-emphasis.html
- css/html.css:
(rt):
LayoutTests:
- fast/ruby/text-emphasis-expected.txt: Added.
- fast/ruby/text-emphasis.html: Added.
- 12:39 AM Changeset in webkit [75706] by
-
- 2 edits in trunk/LayoutTests
2011-01-13 Hayato Ito <hayato@chromium.org>
Unreviewed, chromium test expectations.
Flaky expectations for html5lib/webkit-resumer.html.
- platform/chromium/test_expectations.txt:
- 12:26 AM Changeset in webkit [75705] by
-
- 3 edits in trunk/Tools
2011-01-13 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r74881.
http://trac.webkit.org/changeset/74881
https://bugs.webkit.org/show_bug.cgi?id=52357
The EFL builder has been red for days (Requested by abarth on
#webkit).
- Scripts/webkitpy/common/net/buildbot/buildbot.py:
- Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
- 12:25 AM Changeset in webkit [75704] by
-
- 2 edits in trunk/Source/WebCore
Trivial fix after r75682.
Rubber-stamped by David Levin.
- loader/FrameLoader.cpp: Remove accidentally committed debug code.
(WebCore::FrameLoader::shouldClose):
