⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 18, 2011:

11:40 PM Changeset in webkit [76104] by antonm@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-01-18 Anton Muhin <​antonm@chromium.org>

Reviewed by Adam Barth.

[v8] Minor cleanup: make 2nd argument of removeIfPresnt accept only a value type stored in the DOM map
​https://bugs.webkit.org/show_bug.cgi?id=51683

Covered by the existing tests.

  • bindings/v8/DOMDataStore.cpp: (WebCore::DOMDataStore::weakNodeCallback): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::removeIfPresent):
  • bindings/v8/DOMDataStore.h:
  • bindings/v8/V8DOMMap.h: (WebCore::WeakReferenceMap::removeIfPresent):
11:12 PM Changeset in webkit [76103] by mjs@apple.com
  • 2 edits in trunk/Tools
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h

Rubber stamped by Csaba Osztrogonac

10:09 PM Changeset in webkit [76102] by eric@webkit.org
  • 1 edit
    2 deletes in trunk/LayoutTests

2011-01-18 Eric Seidel <​eric@webkit.org>

Unreviewed, rolling out r76084.
​http://trac.webkit.org/changeset/76084
​https://bugs.webkit.org/show_bug.cgi?id=52654

Crashes on the bots

  • fast/dom/Window/open-window-empty-url-expected.txt: Removed.
  • fast/dom/Window/open-window-empty-url.html: Removed.
9:15 PM Changeset in webkit [76101] by dpranke@chromium.org
  • 5 edits in trunk/Tools

2011-01-18 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Tony Chang.

new-run-webkit-tests: add a --build-directory command line argument

Official Google Chrome builds use a non-standard build directory
location. This patch adds a --build-directory argument that
allows that location to be specified on the command line. Only
Chromium-based builds will use this flag for now, but anyone can
in the future.

There are no unit tests for this since it's difficult to test
until mock filesystems are fully supported in the code. This was
tested by hand for now.

​https://bugs.webkit.org/show_bug.cgi?id=52694

  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
8:33 PM Changeset in webkit [76100] by kbr@google.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-01-18 Kenneth Russell <​kbr@google.com>

Unreviewed, rolling out r76078.
​http://trac.webkit.org/changeset/76078
​https://bugs.webkit.org/show_bug.cgi?id=52668

Caused crashes of fast/canvas/webgl/constants.html,
fast/canvas/webgl/gl-enum-tests.html, and possibly other layout
test crashes in Release mode. WebGL crashes were observed with
"run-webkit-tests fast/canvas/webgl". It was necessary to run
multiple tests to provoke the crash.

  • interpreter/RegisterFile.h: (JSC::RegisterFile::markGlobals):
  • runtime/JSActivation.cpp: (JSC::JSActivation::markChildren):
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::markChildren):
8:18 PM Changeset in webkit [76099] by morrita@google.com
  • 1 edit in trunk/Source/WebCore/ChangeLog

Added a reviewer line for the last checkin

8:11 PM Changeset in webkit [76098] by morrita@google.com
  • 11 edits
    1 add in trunk/Source/WebCore

2011-01-18 MORITA Hajime <​morrita@google.com>

Refactoring: EventHandler::handleTextInputEvent should accept an enum instead of bools.
​https://bugs.webkit.org/show_bug.cgi?id=52608

No new tests. no behavioral change.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/TextEvent.cpp: (WebCore::TextEvent::create): (WebCore::TextEvent::createForDrop): (WebCore::TextEvent::TextEvent):
  • dom/TextEvent.h: (WebCore::TextEvent::isLineBreak): (WebCore::TextEvent::isBackTab): (WebCore::TextEvent::isPaste): (WebCore::TextEvent::isDrop):
  • dom/TextEventInputType.h: Added. Extracted from TextEvent::TextInputType.
  • editing/EditorCommand.cpp: (WebCore::executeInsertBacktab): (WebCore::executeInsertLineBreak): (WebCore::executeInsertNewline): (WebCore::executeInsertTab):
  • page/EventHandler.cpp: (WebCore::EventHandler::handleTextInputEvent):
  • page/EventHandler.h:
8:08 PM Changeset in webkit [76097] by mjs@apple.com
  • 4 edits in trunk/LayoutTests

2011-01-18 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Sam Weinig.

Skip (and in a few cases fix) tests for WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=52698

  • editing/pasteboard/copy-null-characters.html: Make this test fail in a more obvious way when it fails.
  • fast/events/scroll-event-does-not-bubble.html: Make this test properly handle the fact that scroll events are async. The job was half-done before.
  • platform/mac-wk2/Skipped: Skip!
7:56 PM Changeset in webkit [76096] by mjs@apple.com
  • 2 edits in trunk/Tools

Not reviewed. Bot fix.

Remove an inadvertently committed debugging print.

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::notifyDone):

7:55 PM Changeset in webkit [76095] by kbr@google.com
  • 3 edits in trunk/Source/ThirdParty/ANGLE

2011-01-18 Kenneth Russell <​kbr@google.com>

Unreviewed, Leopard build fix. Remove flex/bison targets for GLSL
grammar because the generated sources are already checked in.

  • ANGLE.xcodeproj/project.pbxproj:
  • src/build_angle.xcodeproj/project.pbxproj:
7:30 PM Changeset in webkit [76094] by mjs@apple.com
  • 5 edits in trunk/LayoutTests

Not reviewed.

Revert inadvertantly committed test changes.

  • editing/pasteboard/copy-null-characters.html:
  • fast/events/scroll-event-does-not-bubble.html:
  • platform/mac-wk2/Skipped:
  • transitions/remove-transition-style.html:
7:23 PM Changeset in webkit [76093] by kbr@google.com
  • 2 edits in trunk/Source/ThirdParty/ANGLE

2011-01-18 Kenneth Russell <​kbr@google.com>

Unreviewed, release build fix. Explicitly cast away const.

  • src/compiler/preprocessor/scanner.c: (ScanFromString):
7:16 PM Changeset in webkit [76092] by mjs@apple.com
  • 14 edits in trunk

2011-01-18 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Sam Weinig.

WebKitTestRunner should track loading more like DumpRenderTree
​https://bugs.webkit.org/show_bug.cgi?id=52692

Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
This makes some tests that call notifyDone multiple times pass.


  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::InjectedBundle): (WTR::InjectedBundle::done):
  • WebKitTestRunner/InjectedBundle/InjectedBundle.h: (WTR::InjectedBundle::topLoadingFrame): (WTR::InjectedBundle::setTopLoadingFrame):
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage): (WTR::InjectedBundlePage::stopLoading): (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): (WTR::InjectedBundlePage::didFinishLoadForFrame): (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::notifyDone):
  • WebKitTestRunner/TestController.cpp: (WTR::TestController::didReceiveMessageFromInjectedBundle):

2011-01-18 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Sam Weinig.

WebKitTestRunner should track loading more like DumpRenderTree
​https://bugs.webkit.org/show_bug.cgi?id=52692


Relax the message check in didSaveFrameToPageCache a bit more, since
layout tests were still hitting the old one.

  • UIProcess/WebPageProxy.cpp: (WebKit::isDisconnectedFrame): (WebKit::WebPageProxy::didSaveFrameToPageCache):
7:00 PM Changeset in webkit [76091] by kbr@google.com
  • 77 edits
    21 adds
    5 deletes in trunk/Source

2011-01-18 Ben Vanik <​ben.vanik@gmail.com>

Reviewed by Kenneth Russell.

Updating ANGLE in WebKit to r533.
​https://bugs.webkit.org/show_bug.cgi?id=47194

  • platform/graphics/ANGLEWebKitBridge.cpp: (WebCore::ANGLEWebKitBridge::ANGLEWebKitBridge): (WebCore::ANGLEWebKitBridge::~ANGLEWebKitBridge): (WebCore::ANGLEWebKitBridge::validateShaderSource): Update to new ANGLE API for shader validation.
  • platform/graphics/ANGLEWebKitBridge.h: (WebCore::ANGLEWebKitBridge::setResources): Renaming types to new names.
  • platform/graphics/mac/GraphicsContext3DMac.mm: (WebCore::GraphicsContext3D::GraphicsContext3D): Initialize ANGLEResources with ANGLE init call to prevent uninitialized variables.

2011-01-18 Ben Vanik <​ben.vanik@gmail.com>

Reviewed by Kenneth Russell.

Updating ANGLE in WebKit to r533.
​https://bugs.webkit.org/show_bug.cgi?id=47194

  • ANGLE.xcodeproj/project.pbxproj:
  • include/GLSLANG/ShaderLang.h:
  • src/common/debug.cpp: (gl::trace):
  • src/common/debug.h:
  • src/compiler/CodeGenGLSL.cpp: (ConstructCompiler):
  • src/compiler/CodeGenHLSL.cpp: (ConstructCompiler):
  • src/compiler/Common.h: (EncodeSourceLoc): (DecodeSourceLoc):
  • src/compiler/Compiler.cpp: Added. (TShHandleBase::TShHandleBase): (TShHandleBase::~TShHandleBase): (TCompiler::TCompiler): (TCompiler::~TCompiler): (TCompiler::Init): (TCompiler::compile): (TCompiler::InitBuiltInSymbolTable): (TCompiler::clearResults): (TCompiler::validateLimitations): (TCompiler::collectAttribsUniforms):
  • src/compiler/ExtensionBehavior.h: Added.
  • src/compiler/InfoSink.cpp: (TInfoSinkBase::location):
  • src/compiler/InfoSink.h: (TInfoSinkBase::size):
  • src/compiler/Initialize.cpp: (BuiltInFunctionsCommon): (BuiltInFunctionsVertex): (BuiltInFunctionsFragment): (StandardUniforms): (DefaultPrecisionVertex): (DefaultPrecisionFragment): (BuiltInConstants): (TBuiltIns::initialize): (IdentifyBuiltIns): (InitExtensionBehavior):
  • src/compiler/Initialize.h:
  • src/compiler/IntermTraverse.cpp: (TIntermLoop::traverse):
  • src/compiler/Intermediate.cpp: (getOperatorString): (TIntermediate::addBinaryMath): (TIntermediate::addLoop): (TIntermediate::postProcess): (TIntermBinary::promote):
  • src/compiler/OutputGLSL.cpp: (TOutputGLSL::visitUnary): (TOutputGLSL::visitLoop):
  • src/compiler/OutputHLSL.cpp: (sh::OutputHLSL::OutputHLSL): (sh::OutputHLSL::header): (sh::OutputHLSL::visitBinary): (sh::OutputHLSL::visitUnary): (sh::OutputHLSL::visitAggregate): (sh::OutputHLSL::visitLoop): (sh::OutputHLSL::handleExcessiveLoop): (sh::OutputHLSL::argumentString):
  • src/compiler/OutputHLSL.h:
  • src/compiler/ParseHelper.cpp: (ReportInfo): (DefineExtensionMacros): (TParseContext::error): (TParseContext::warning): (TParseContext::reservedErrorCheck): (TParseContext::constructorErrorCheck): (TParseContext::arrayQualifierErrorCheck): (TParseContext::extensionErrorCheck): (TParseContext::areAllChildConst): (PaParseStrings):
  • src/compiler/ParseHelper.h: (TParseContext::TParseContext):
  • src/compiler/PoolAlloc.cpp: (InitializeGlobalPools): (FreeGlobalPools): (SetGlobalPoolAllocator): (TPoolAllocator::TPoolAllocator): (TPoolAllocator::~TPoolAllocator): (TAllocation::checkAllocList):
  • src/compiler/PoolAlloc.h:
  • src/compiler/SearchSymbol.cpp: Added. (sh::SearchSymbol::SearchSymbol): (sh::SearchSymbol::traverse): (sh::SearchSymbol::visitSymbol): (sh::SearchSymbol::foundMatch):
  • src/compiler/SearchSymbol.h: Added.
  • src/compiler/ShHandle.h: (TCompiler::getAsCompiler): (TCompiler::getInfoSink): (TCompiler::getAttribs): (TCompiler::getUniforms): (TCompiler::getShaderType): (TCompiler::getShaderSpec):
  • src/compiler/ShaderLang.cpp: (getVariableMaxLength): (getVariableInfo): (ShInitBuiltInResources): (ShConstructCompiler): (ShCompile): (ShGetInfo): (ShGetInfoLog): (ShGetObjectCode): (ShGetActiveAttrib): (ShGetActiveUniform):
  • src/compiler/SymbolTable.cpp: (TSymbolTableLevel::relateToExtension):
  • src/compiler/SymbolTable.h: (TVariable::shareConstPointer): (TFunction::relateToExtension): (TFunction::getExtension): (TFunction::getParamCount): (TFunction::getParam): (TSymbolTable::getGlobalLevel): (TSymbolTable::relateToOperator): (TSymbolTable::relateToExtension):
  • src/compiler/TranslatorGLSL.cpp: (writeVersion): (TranslatorGLSL::TranslatorGLSL): (TranslatorGLSL::translate):
  • src/compiler/TranslatorGLSL.h:
  • src/compiler/TranslatorHLSL.cpp: (TranslatorHLSL::TranslatorHLSL): (TranslatorHLSL::translate):
  • src/compiler/TranslatorHLSL.h:
  • src/compiler/Types.h: (TType::TType):
  • src/compiler/UnfoldSelect.cpp: (sh::UnfoldSelect::visitSelection):
  • src/compiler/UnfoldSelect.h:
  • src/compiler/ValidateLimitations.cpp: Added. (ValidateLimitations::ValidateLimitations): (ValidateLimitations::visitSymbol): (ValidateLimitations::visitConstantUnion): (ValidateLimitations::visitBinary): (ValidateLimitations::visitUnary): (ValidateLimitations::visitSelection): (ValidateLimitations::visitAggregate): (ValidateLimitations::visitLoop): (ValidateLimitations::visitBranch): (ValidateLimitations::error): (ValidateLimitations::withinLoopBody): (ValidateLimitations::isLoopIndex): (ValidateLimitations::validateLoopType): (ValidateLimitations::validateForLoopHeader): (ValidateLimitations::validateForLoopInit): (ValidateLimitations::validateForLoopCond): (ValidateLimitations::validateForLoopExpr): (ValidateLimitations::validateFunctionCall): (ValidateLimitations::validateOperation): (ValidateLimitations::isConstExpr): (ValidateLimitations::isConstIndexExpr): (ValidateLimitations::validateIndexing):
  • src/compiler/ValidateLimitations.h: Added. (ValidateLimitations::numErrors):
  • src/compiler/VariableInfo.cpp: Added. (arrayBrackets): (getVariableDataType): (getVariableInfo): (getBuiltInVariableInfo): (getUserDefinedVariableInfo): (CollectAttribsUniforms::CollectAttribsUniforms): (CollectAttribsUniforms::visitSymbol): (CollectAttribsUniforms::visitConstantUnion): (CollectAttribsUniforms::visitBinary): (CollectAttribsUniforms::visitUnary): (CollectAttribsUniforms::visitSelection): (CollectAttribsUniforms::visitAggregate): (CollectAttribsUniforms::visitLoop): (CollectAttribsUniforms::visitBranch):
  • src/compiler/VariableInfo.h: Added.
  • src/compiler/VersionGLSL.cpp: Added. (TVersionGLSL::TVersionGLSL): (TVersionGLSL::visitSymbol): (TVersionGLSL::visitConstantUnion): (TVersionGLSL::visitBinary): (TVersionGLSL::visitUnary): (TVersionGLSL::visitSelection): (TVersionGLSL::visitAggregate): (TVersionGLSL::visitLoop): (TVersionGLSL::visitBranch): (TVersionGLSL::updateVersion):
  • src/compiler/VersionGLSL.h: Added. (TVersionGLSL::getVersion):
  • src/compiler/generate_glslang_lexer.sh: Added.
  • src/compiler/generate_glslang_parser.sh: Added.
  • src/compiler/glslang.h: Added.
  • src/compiler/glslang.l:
  • src/compiler/glslang.y:
  • src/compiler/glslang_lex.cpp: Added. (yy_get_next_buffer): (yy_get_previous_state): (yy_try_NUL_trans): (input): (yyrestart): (yy_switch_to_buffer): (yy_load_buffer_state): (yy_create_buffer): (yy_delete_buffer): (yy_init_buffer): (yy_flush_buffer): (yypush_buffer_state): (yypop_buffer_state): (yyensure_buffer_stack): (yy_scan_buffer): (yy_scan_string): (yy_scan_bytes): (yy_push_state): (yy_pop_state): (yy_top_state): (yy_fatal_error): (yyget_extra): (yyget_lineno): (yyget_column): (yyget_in): (yyget_out): (yyget_leng): (yyget_text): (yyset_extra): (yyset_lineno): (yyset_column): (yyset_in): (yyset_out): (yyget_debug): (yyset_debug): (yyget_lval): (yyset_lval): (yylex_init): (yylex_init_extra): (yy_init_globals): (yylex_destroy): (yy_flex_strncpy): (yy_flex_strlen): (yyalloc): (yyrealloc): (yyfree): (string_input): (check_type): (reserved_word): (yyerror): (glslang_initialize): (glslang_finalize): (glslang_scan):
  • src/compiler/glslang_tab.cpp: Added. (yytnamerr): (yysyntax_error): (glslang_parse):
  • src/compiler/glslang_tab.h: Added.
  • src/compiler/intermOut.cpp: (TOutputTraverser::TOutputTraverser): (OutputTreeText): (TOutputTraverser::visitSymbol): (TOutputTraverser::visitBinary): (TOutputTraverser::visitUnary): (TOutputTraverser::visitAggregate): (TOutputTraverser::visitSelection): (TOutputTraverser::visitConstantUnion): (TOutputTraverser::visitLoop): (TOutputTraverser::visitBranch): (TIntermediate::outputTree):
  • src/compiler/intermediate.h: (TIntermLoop::TIntermLoop): (TIntermLoop::getType): (TIntermLoop::getInit): (TIntermLoop::getCondition): (TIntermLoop::getExpression): (TIntermLoop::getBody):
  • src/compiler/localintermediate.h:
  • src/compiler/osinclude.h: (OS_GetTLSValue):
  • src/compiler/ossource_nspr.cpp: Added. (OS_AllocTLSIndex): (OS_SetTLSValue): (OS_FreeTLSIndex):
  • src/compiler/preprocessor/compile.h:
  • src/compiler/preprocessor/cpp.c: (CPPdefine): (CPPelse): (CPPif): (CPPifdef): (CPPerror): (CPPextension): (readCPPline):
  • src/compiler/preprocessor/preprocess.h:
  • src/compiler/preprocessor/scanner.c: (str_getch): (str_ungetch): (ScanFromString): (lFloatConst): (byte_scan): (yylex_CPP): (check_EOF):
  • src/compiler/preprocessor/scanner.h:
  • src/compiler/preprocessor/tokens.c: (RecordToken): (ReadToken):
  • src/compiler/tools: Removed.
  • src/compiler/unistd.h: Removed.
  • src/compiler/util.cpp: Added. (atof_dot):
  • src/compiler/util.h: Added.
  • src/libEGL/Config.cpp: (egl::Config::set):
  • src/libEGL/Display.cpp: (egl::Display::Display): (egl::Display::initialize): (egl::Display::terminate): (egl::Display::createDevice): (egl::Display::resetDevice): (egl::Display::createContext): (egl::Display::destroyContext): (egl::Display::getMinSwapInterval): (egl::Display::getMaxSwapInterval): (egl::Display::getDevice): (egl::Display::getFloatTextureSupport): (egl::Display::getHalfFloatTextureSupport): (egl::Display::getLuminanceTextureSupport): (egl::Display::getLuminanceAlphaTextureSupport): (egl::Display::getBufferPool): (egl::Display::getEventQuerySupport): (egl::Display::getDefaultPresentParameters):
  • src/libEGL/Display.h:
  • src/libEGL/Surface.cpp: (egl::Surface::Surface): (egl::Surface::~Surface): (egl::Surface::release): (egl::Surface::resetSwapChain): (egl::Surface::writeRecordableFlipState): (egl::Surface::restoreState): (egl::SurfaceWindowProc): (egl::Surface::subclassWindow): (egl::Surface::unsubclassWindow): (egl::Surface::checkForOutOfDateSwapChain): (egl::Surface::convertInterval): (egl::Surface::swap): (egl::Surface::getRenderTarget): (egl::Surface::setSwapInterval):
  • src/libEGL/Surface.h:
  • src/libEGL/libEGL.cpp:
  • src/libGLESv2/Blit.cpp: (gl::Blit::copySurfaceToTexture): (gl::Blit::setCommonBlitState):
  • src/libGLESv2/Buffer.cpp: (gl::Buffer::Buffer): (gl::Buffer::~Buffer): (gl::Buffer::bufferData): (gl::Buffer::bufferSubData): (gl::Buffer::getVertexBuffer): (gl::Buffer::getIndexBuffer): (gl::Buffer::invalidateStaticData):
  • src/libGLESv2/Buffer.h:
  • src/libGLESv2/Context.cpp: (gl::Context::Context): (gl::Context::~Context): (gl::Context::makeCurrent): (gl::Context::markAllStateDirty): (gl::Context::setFragmentShaderDerivativeHint): (gl::Context::setEnableVertexAttribArray): (gl::Context::getVertexAttribState): (gl::Context::getVertexAttributes): (gl::Context::createFence): (gl::Context::deleteFence): (gl::Context::bindTexture2D): (gl::Context::bindTextureCubeMap): (gl::Context::getFence): (gl::Context::getTexture2D): (gl::Context::getTextureCubeMap): (gl::Context::getSamplerTexture): (gl::Context::getBooleanv): (gl::Context::getIntegerv): (gl::Context::getQueryParameterInfo): (gl::Context::applyRenderTarget): (gl::Context::applyState): (gl::Context::lookupAttributeMapping): (gl::Context::applyVertexBuffer): (gl::Context::applyIndexBuffer): (gl::Context::readPixels): (gl::Context::clear): (gl::Context::drawArrays): (gl::Context::drawElements): (gl::Context::finish): (gl::Context::drawClosingLine): (gl::Context::getMaximumVaryingVectors): (gl::Context::getMaximumFragmentUniformVectors): (gl::Context::supportsEventQueries): (gl::Context::supportsFloatTextures): (gl::Context::supportsFloatLinearFilter): (gl::Context::supportsFloatRenderableTextures): (gl::Context::supportsHalfFloatTextures): (gl::Context::supportsHalfFloatLinearFilter): (gl::Context::supportsHalfFloatRenderableTextures): (gl::Context::getMaximumRenderbufferDimension): (gl::Context::getMaximumTextureDimension): (gl::Context::getMaximumCubeTextureDimension): (gl::Context::getMaximumTextureLevel): (gl::Context::supportsLuminanceTextures): (gl::Context::supportsLuminanceAlphaTextures): (gl::Context::supports32bitIndices): (gl::Context::getIncompleteTexture): (gl::Context::setVertexAttrib): (gl::Context::initExtensionString): (gl::Context::blitFramebuffer):
  • src/libGLESv2/Context.h: (gl::VertexAttribute::VertexAttribute): (gl::VertexAttribute::typeSize): (gl::VertexAttribute::stride):
  • src/libGLESv2/Fence.cpp: Added. (gl::Fence::Fence): (gl::Fence::~Fence): (gl::Fence::isFence): (gl::Fence::setFence): (gl::Fence::testFence): (gl::Fence::finishFence): (gl::Fence::getFenceiv):
  • src/libGLESv2/Fence.h: Added.
  • src/libGLESv2/Framebuffer.cpp: (gl::Framebuffer::completeness): (gl::DefaultFramebuffer::DefaultFramebuffer): (gl::DefaultFramebuffer::completeness):
  • src/libGLESv2/Program.cpp: (gl::Program::Program): (gl::Program::getSamplerMapping): (gl::Program::getUniformLocation): (gl::Program::setUniform1iv): (gl::Program::applyUniforms): (gl::Program::packVaryings): (gl::Program::linkVaryings): (gl::Program::link): (gl::Program::defineUniform): (gl::Program::createUniform): (gl::Program::applyUniform1iv): (gl::Program::resetInfoLog): (gl::Program::unlink): (gl::Program::getActiveAttribute): (gl::Program::getActiveUniform): (gl::Program::getDxDepthRangeLocation):
  • src/libGLESv2/Program.h:
  • src/libGLESv2/RefCountObject.cpp: (gl::RefCountObject::~RefCountObject):
  • src/libGLESv2/Renderbuffer.cpp: (gl::RenderbufferStorage::RenderbufferStorage): (gl::RenderbufferStorage::isFloatingPoint): (gl::Colorbuffer::Colorbuffer): (gl::DepthStencilbuffer::DepthStencilbuffer):
  • src/libGLESv2/Renderbuffer.h:
  • src/libGLESv2/Shader.cpp: (gl::Shader::Shader): (gl::Shader::parseVaryings): (gl::Shader::compileToHLSL): (gl::VertexShader::parseAttributes):
  • src/libGLESv2/Texture.cpp: (gl::Texture::Texture): (gl::Texture::isFloatingPoint): (gl::Texture::isRenderableFormat): (gl::Texture::selectFormat): (gl::Texture::loadImageData): (gl::Texture::loadAlphaFloatImageData): (gl::Texture::loadAlphaHalfFloatImageData): (gl::Texture::loadLuminanceImageData): (gl::Texture::loadLuminanceFloatImageData): (gl::Texture::loadLuminanceHalfFloatImageData): (gl::Texture::loadLuminanceAlphaImageData): (gl::Texture::loadLuminanceAlphaFloatImageData): (gl::Texture::loadLuminanceAlphaHalfFloatImageData): (gl::Texture::loadRGBFloatImageData): (gl::Texture::loadRGBHalfFloatImageData): (gl::Texture::loadRGBAFloatImageData): (gl::Texture::loadRGBAHalfFloatImageData): (gl::Texture::createSurface): (gl::Texture::setImage): (gl::Texture::setCompressedImage): (gl::Texture::subImage): (gl::Texture::subImageCompressed): (gl::Texture::copyNonRenderable): (gl::Texture::getD3DFormat): (gl::Texture::isRenderable): (gl::Texture2D::Texture2D): (gl::Texture2D::~Texture2D): (gl::Texture2D::redefineTexture): (gl::Texture2D::setImage): (gl::Texture2D::setCompressedImage): (gl::Texture2D::copyImage): (gl::Texture2D::copySubImage): (gl::Texture2D::isComplete): (gl::Texture2D::createTexture): (gl::Texture2D::convertToRenderTarget): (gl::Texture2D::generateMipmaps): (gl::Texture2D::getColorbuffer): (gl::Texture2D::getRenderTarget): (gl::TextureCubeMap::TextureCubeMap): (gl::TextureCubeMap::~TextureCubeMap): (gl::TextureCubeMap::subImage): (gl::TextureCubeMap::subImageCompressed): (gl::TextureCubeMap::isComplete): (gl::TextureCubeMap::createTexture): (gl::TextureCubeMap::convertToRenderTarget): (gl::TextureCubeMap::redefineTexture): (gl::TextureCubeMap::copyImage): (gl::TextureCubeMap::copySubImage): (gl::TextureCubeMap::generateMipmaps): (gl::TextureCubeMap::getColorbuffer): (gl::TextureCubeMap::getRenderTarget): (gl::Texture::TextureColorbufferProxy::TextureColorbufferProxy): (gl::Texture::TextureColorbufferProxy::isFloatingPoint):
  • src/libGLESv2/Texture.h:
  • src/libGLESv2/geometry/IndexDataManager.cpp: (gl::IndexDataManager::IndexDataManager): (gl::IndexDataManager::~IndexDataManager): (gl::convertIndices): (gl::computeRange): (gl::IndexDataManager::prepareIndexData): (gl::IndexDataManager::indexSize): (gl::IndexDataManager::typeSize): (gl::IndexBuffer::IndexBuffer): (gl::IndexBuffer::~IndexBuffer): (gl::IndexBuffer::getBuffer): (gl::IndexBuffer::unmap): (gl::StreamingIndexBuffer::StreamingIndexBuffer): (gl::StreamingIndexBuffer::~StreamingIndexBuffer): (gl::StreamingIndexBuffer::map): (gl::StreamingIndexBuffer::reserveSpace): (gl::StaticIndexBuffer::StaticIndexBuffer): (gl::StaticIndexBuffer::~StaticIndexBuffer): (gl::StaticIndexBuffer::map): (gl::StaticIndexBuffer::reserveSpace): (gl::StaticIndexBuffer::lookupType): (gl::StaticIndexBuffer::lookupRange): (gl::StaticIndexBuffer::addRange):
  • src/libGLESv2/geometry/IndexDataManager.h: (gl::IndexBuffer::size):
  • src/libGLESv2/geometry/VertexDataManager.cpp: (gl::VertexDataManager::VertexDataManager): (gl::VertexDataManager::~VertexDataManager): (gl::VertexDataManager::writeAttributeData): (gl::VertexDataManager::prepareVertexData): (gl::VertexDataManager::spaceRequired): (gl::VertexDataManager::checkVertexCaps): (gl::VertexDataManager::typeIndex): (gl::VertexDataManager::setupAttributes): (gl::VertexBuffer::VertexBuffer): (gl::VertexBuffer::~VertexBuffer): (gl::VertexBuffer::unmap): (gl::VertexBuffer::getBuffer): (gl::ConstantVertexBuffer::ConstantVertexBuffer): (gl::ConstantVertexBuffer::~ConstantVertexBuffer): (gl::ArrayVertexBuffer::ArrayVertexBuffer): (gl::ArrayVertexBuffer::~ArrayVertexBuffer): (gl::ArrayVertexBuffer::addRequiredSpace): (gl::ArrayVertexBuffer::addRequiredSpaceFor): (gl::StreamingVertexBuffer::StreamingVertexBuffer): (gl::StreamingVertexBuffer::~StreamingVertexBuffer): (gl::StreamingVertexBuffer::map): (gl::StreamingVertexBuffer::reserveRequiredSpace): (gl::StaticVertexBuffer::StaticVertexBuffer): (gl::StaticVertexBuffer::~StaticVertexBuffer): (gl::StaticVertexBuffer::map): (gl::StaticVertexBuffer::reserveRequiredSpace): (gl::StaticVertexBuffer::lookupAttribute): (gl::VertexDataManager::formatConverter):
  • src/libGLESv2/geometry/VertexDataManager.h: (gl::ArrayVertexBuffer::size): (gl::VertexDataManager::dirtyCurrentValue):
  • src/libGLESv2/geometry/backend.cpp: Removed.
  • src/libGLESv2/geometry/backend.h: Removed.
  • src/libGLESv2/geometry/dx9.cpp: Removed.
  • src/libGLESv2/geometry/dx9.h: Removed.
  • src/libGLESv2/libGLESv2.cpp:
  • src/libGLESv2/libGLESv2.def:
  • src/libGLESv2/libGLESv2.vcproj:
  • src/libGLESv2/utilities.cpp: (gl::UniformComponentCount): (gl::UniformComponentType): (gl::ComputePixelSize): (gl::CheckTextureFormatType): (gl::IsColorRenderable): (gl::IsDepthRenderable): (gl::IsStencilRenderable): (es2dx::GetAlphaSize): (es2dx::GetRedSize): (es2dx::GetGreenSize): (es2dx::GetBlueSize): (es2dx::GetDepthSize): (es2dx::ConvertPrimitiveType): (dx2es::ConvertBackBufferFormat): (dx2es::ConvertDepthStencilFormat):
  • src/libGLESv2/utilities.h:
6:37 PM Changeset in webkit [76090] by oliver@apple.com
  • 6 edits in trunk

2011-01-18 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

[jsfunfuzz] Assertion asking activation for arguments when arguments is overridden
​https://bugs.webkit.org/show_bug.cgi?id=52690

Add a few more tests.

  • fast/js/function-dot-arguments-expected.txt:
  • fast/js/script-tests/function-dot-arguments.js: (overwroteArgumentsInDynamicScope1): (overwroteArgumentsInDynamicScope2): (overwroteArgumentsInDynamicScope3):

2011-01-18 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

[jsfunfuzz] Assertion asking activation for arguments when arguments is overridden
​https://bugs.webkit.org/show_bug.cgi?id=52690

Clean up code to retrieve arguments from activation and function objects.
Remove the incorrect assertion from JSActivation's argumentsGetter.

  • interpreter/Interpreter.cpp: (JSC::Interpreter::retrieveArguments):
  • runtime/JSActivation.cpp: (JSC::JSActivation::argumentsGetter):
5:46 PM Changeset in webkit [76089] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/8860833> and ​https://bugs.webkit.org/show_bug.cgi?id=52599
UIProcess crash in WebPageProxy::reattachToWebProcess when web process crashes with a new tab/window.

Reviewed by Darin Adler.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::reattachToWebProcessWithItem): Null check item *both* places it is used.

5:44 PM Changeset in webkit [76088] by dimich@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Chromium] Not reviewed, adding pixel expectations for new test.

  • platform/chromium-mac/fast/css/background-clip-values-expected.checksum: Added.
  • platform/chromium-mac/fast/css/background-clip-values-expected.png: Added.
5:37 PM Changeset in webkit [76087] by beidson@apple.com
  • 10 edits in trunk/Source/WebKit2

<rdar://problem/8752200> and ​https://bugs.webkit.org/show_bug.cgi?id=52664
Need WebKit2 API to asynchronously get the resource data for a URL

Reviewed by Maciej Stachowiak.

Rename WKFrameGetMainResourceDataFunction to WKFrameGetResourceDataFunction, and add
new API to get a resource by URL:

  • UIProcess/API/C/WKFrame.cpp:

(WKFrameGetMainResourceData):
(WKFrameGetResourceData):
(callGetResourceDataBlockAndDispose):
(WKFrameGetMainResourceData_b):
(WKFrameGetResourceData_b):

  • UIProcess/API/C/WKFrame.h:

Implement the new API in the UIProcess side:

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::getResourceData):

  • UIProcess/WebFrameProxy.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::getResourceDataFromFrame):

  • UIProcess/WebPageProxy.h:

Have the WebProcess get the data and call back to the UIProcess:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::getResourceDataFromFrame):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
5:30 PM Changeset in webkit [76086] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Make PageClientImpl::scrollView do hardware blitting
​https://bugs.webkit.org/show_bug.cgi?id=52689

  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::scrollView): Clip the scroll rect and scroll the view.
  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::incorporateUpdate): Scroll before painting.
5:16 PM Changeset in webkit [76085] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler.

Artifacts when scrolling with new drawing area
​https://bugs.webkit.org/show_bug.cgi?id=52682

  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::scroll): When scrolling, we want the intersection of the scroll rect and clip rect.
5:13 PM Changeset in webkit [76084] by jberlin@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add a test that calling window.open with an empty URL does not trigger an assertion or
cause a crash.
​https://bugs.webkit.org/show_bug.cgi?id=52654

Reviewed by Adam Roben.

  • fast/dom/Window/open-window-empty-url-expected.txt: Added.
  • fast/dom/Window/open-window-empty-url.html: Added.
5:10 PM Changeset in webkit [76083] by morrita@google.com
  • 23 edits
    2 adds in trunk/Source/WebCore

2011-01-18 MORITA Hajime <​morrita@google.com>

Reviewed by Simon Fraser.

Refactoring: Extract RoundedIntRect class
​https://bugs.webkit.org/show_bug.cgi?id=51664

RoundedIntRect is a pair of rect and four IntSize objects which represent
corner radii of the rectangle. IntSize is grouped into RoundedIntRect::Radii.
Now RenderStyle::getRoundedBorderFor() and RenderStyle::getRoundedInnerBorderWithBorderWidths()
return RoundedIntRect and GraphicsContext::addRoundedRectClip(), GraphicsContext::fillRoundedRect()
and other functions accept RoundedIntRect as an argument.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::addRoundedRectClip): (WebCore::GraphicsContext::clipOutRoundedRect): (WebCore::GraphicsContext::fillRoundedRect):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/RoundedIntRect.cpp: Added. (WebCore::RoundedIntRect::Radii::isZero): (WebCore::RoundedIntRect::Radii::scale): (WebCore::RoundedIntRect::Radii::expand): (WebCore::RoundedIntRect::Radii::includeLogicalEdges): (WebCore::RoundedIntRect::Radii::excludeLogicalEdges): (WebCore::RoundedIntRect::RoundedIntRect): (WebCore::RoundedIntRect::includeLogicalEdges): (WebCore::RoundedIntRect::excludeLogicalEdges):
  • platform/graphics/RoundedIntRect.h: Added. (WebCore::RoundedIntRect::Radii::Radii): (WebCore::RoundedIntRect::Radii::setTopLeft): (WebCore::RoundedIntRect::Radii::setTopRight): (WebCore::RoundedIntRect::Radii::setBottomLeft): (WebCore::RoundedIntRect::Radii::setBottomRight): (WebCore::RoundedIntRect::Radii::topLeft): (WebCore::RoundedIntRect::Radii::topRight): (WebCore::RoundedIntRect::Radii::bottomLeft): (WebCore::RoundedIntRect::Radii::bottomRight): (WebCore::RoundedIntRect::Radii::expand): (WebCore::RoundedIntRect::Radii::shrink): (WebCore::RoundedIntRect::rect): (WebCore::RoundedIntRect::radii): (WebCore::RoundedIntRect::isRounded): (WebCore::RoundedIntRect::isEmpty): (WebCore::RoundedIntRect::setRect): (WebCore::RoundedIntRect::setRadii): (WebCore::RoundedIntRect::move): (WebCore::RoundedIntRect::inflate): (WebCore::RoundedIntRect::inflateWithRadii): (WebCore::RoundedIntRect::expandRadii): (WebCore::RoundedIntRect::shrinkRadii):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::pushContentsClip):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): (WebCore::RenderBoxModelObject::paintBorder): (WebCore::RenderBoxModelObject::clipBorderSidePolygon): (WebCore::RenderBoxModelObject::paintBoxShadow):
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::drawBoxSideFromPath):
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint):
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMenuListButtonGradients): (WebCore::RenderThemeMac::paintSliderTrack):
  • rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintMenuListButtonGradients): (WebCore::RenderThemeSafari::paintSliderTrack):
  • rendering/RenderThemeWinCE.cpp: (WebCore::RenderThemeWinCE::paintSearchFieldCancelButton):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
  • rendering/style/BorderData.h:
  • rendering/style/RenderStyle.cpp: (WebCore::calcRadiiFor): (WebCore::calcConstraintScaleFor): (WebCore::RenderStyle::getRoundedBorderFor): (WebCore::RenderStyle::getRoundedInnerBorderWithBorderWidths):
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::setBorderRadius):
4:30 PM Changeset in webkit [76082] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

2011-01-18 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

make file expansion use the file at the svn revision the diff was created at
​https://bugs.webkit.org/show_bug.cgi?id=52650

This only works for patches created with SVN for now since the git
diff does not include SVN revision numbers in it.

  • PrettyPatch/PrettyPatch.rb:
  • code-review.js:
4:15 PM Changeset in webkit [76081] by mihaip@chromium.org
  • 2 edits in trunk/Tools

2011-01-18 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Kent Tamura.

[Chromium] NRWT looking for DRT binary in the wrong path on Mac
​https://bugs.webkit.org/show_bug.cgi?id=52678

Update path now that WebKit is inside Source.

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
4:15 PM Changeset in webkit [76080] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler.

Use a CGLayer for the backing store when possible
​https://bugs.webkit.org/show_bug.cgi?id=52679

  • UIProcess/mac/BackingStoreMac.mm: (WebKit::BackingStore::paint): If there is a layer, paint it into the given context.

(WebKit::BackingStore::backingStoreContext):
If we can get the containing window graphics context, use it to create a
CGLayer that we'll use for the backing store.

(WebKit::BackingStore::scroll):
Paint the layer into itself.

  • UIProcess/mac/WebPageProxyMac.mm: (WebKit::WebPageProxy::containingWindowGraphicsContext): Call the page client.
3:49 PM Changeset in webkit [76079] by robert@webkit.org
  • 7 edits in trunk

2011-01-18 Robert Hogan <​robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] http/tests/incremental/slow-utf8-text.pl fails
​https://bugs.webkit.org/show_bug.cgi?id=44282

  • platform/qt/Skipped:

2011-01-18 Robert Hogan <​robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] http/tests/incremental/slow-utf8-text.pl fails
​https://bugs.webkit.org/show_bug.cgi?id=44282

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::responseMimeType):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-01-18 Robert Hogan <​robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] http/tests/incremental/slow-utf8-text.pl fails
​https://bugs.webkit.org/show_bug.cgi?id=44282

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::dump):
3:45 PM Changeset in webkit [76078] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-01-18 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin Adler.

Removed RegisterFile::markGlobals because it was obtuse, and it
unnecessarily relied on conservative marking.
​https://bugs.webkit.org/show_bug.cgi?id=52668

  • interpreter/RegisterFile.h: Removed markGlobals.
  • runtime/JSActivation.cpp: (JSC::JSActivation::markChildren): Added a comment explaning why some JSActivations don't always mark their registers arrays.
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::markChildren): Instead of calling markGlobals, mark the registers array directly.
3:40 PM Changeset in webkit [76077] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Pass the web page proxy to BackingStore::create
​https://bugs.webkit.org/show_bug.cgi?id=52673

  • UIProcess/BackingStore.cpp: (WebKit::BackingStore::create): Add WebPageProxy parameter.


(WebKit::BackingStore::BackingStore):
Add WebPageProxy parameter.

  • UIProcess/BackingStore.h: Add WebPageProxy member variable.
  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::incorporateUpdate): Pass the web page proxy when creating the backing store.
  • UIProcess/mac/BackingStoreMac.mm: (WebKit::BackingStore::backingStoreContext): Set the default blend mode.
3:31 PM Changeset in webkit [76076] by msaboff@apple.com
  • 5 edits in trunk

2011-01-18 Michael Saboff <​msaboff@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/8875432> Regression: Some text-only e-mails cause hang beneath RegExp::match (52540)
​https://bugs.webkit.org/show_bug.cgi?id=52540
​https://bugs.webkit.org/show_bug.cgi?id=52662

Directly use backtrack label with parentheses nested under a
non-capturing parentheses. Also linked current parentheses
tail code object for possible parens nested within a non-capturing
parentheses.

  • yarr/YarrJIT.cpp: (JSC::Yarr::YarrGenerator::BacktrackDestination::linkBacktrackToLabel): (JSC::Yarr::YarrGenerator::generateParenthesesSingle):

2011-01-18 Michael Saboff <​msaboff@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/8875432> Regression: Some text-only e-mails cause hang beneath RegExp::match (52540)
​https://bugs.webkit.org/show_bug.cgi?id=52540
​https://bugs.webkit.org/show_bug.cgi?id=52662

New tests to check for proper linking of parentheses nested under
a non-capturing parentheses.

  • fast/regex/parentheses-expected.txt:
  • fast/regex/script-tests/parentheses.js:
3:27 PM Changeset in webkit [76075] by commit-queue@webkit.org
  • 4 edits in trunk/Source

2011-01-18 Victoria Kirst <​vrk@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Adding support for YV16 video frame formats.
​https://bugs.webkit.org/show_bug.cgi?id=52345

  • platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::determineTextureFormat): (WebCore::VideoLayerChromium::draw):

2011-01-18 Victoria Kirst <​vrk@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Adding support for YV16 video frame formats.
​https://bugs.webkit.org/show_bug.cgi?id=52345

  • src/VideoFrameChromiumImpl.cpp: (WebKit::VideoFrameChromiumImpl::requiredTextureSize):
3:24 PM Changeset in webkit [76074] by hyatt@apple.com
  • 3 edits
    4 adds in trunk

<rdar://problem/8479998> REGRESSION (r67660): broken button layout at devforums.apple.com

Reviewed by Dan Bernstein.

Exclude floating objects from shrinking to avoid floats. They should never do this. Timing-related bugs could
occur as a result of this mistake, and the change to rewrite pagination to defer layout of floats until they
got encountered on the correct line exposed this issue.

Source/WebCore:

Added /fast/block/float/float-overflow-hidden-containing-block-width.html.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::shrinkToAvoidFloats):

LayoutTests:

Added /fast/block/float/float-overflow-hidden-containing-block-width.html.

  • fast/block/float/float-overflow-hidden-containing-block-width.html: Added.
  • platform/mac/fast/block/float/float-overflow-hidden-containing-block-width-expected.checksum: Added.
  • platform/mac/fast/block/float/float-overflow-hidden-containing-block-width-expected.png: Added.
  • platform/mac/fast/block/float/float-overflow-hidden-containing-block-width-expected.txt: Added.
3:21 PM Changeset in webkit [76073] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-01-18 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Mihai Parparita.

Fix a small race condition that could cause the unit tests for
new-run-webkit-tests to fail in a multithreaded environment.
There was a small window in the code where one thread would
check to see if a thread had raised an exception, do something,
and then check to see if the thread was alive. If the other
thread raised an exception and exited in between these two
steps, the exception would be lost. Flipping the order of the
two checks fixes the race, since we will now always check for an
exception on the thread before exiting.

​https://bugs.webkit.org/show_bug.cgi?id=51579

  • Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3:08 PM Changeset in webkit [76072] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler.

Factor code to create the backing store bitmap context out into a new function
​https://bugs.webkit.org/show_bug.cgi?id=52670

  • UIProcess/BackingStore.h:
  • UIProcess/mac/BackingStoreMac.mm: (WebKit::BackingStore::backingStoreContext): Create the backing store context.

(WebKit::BackingStore::incorporateUpdate):
Call backingStoreContext.

(WebKit::BackingStore::scroll):
Assert that the context is not null.

2:59 PM Changeset in webkit [76071] by eric@webkit.org
  • 6 edits in trunk/Tools

2011-01-18 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

commit-queue dies when test archiving fails
​https://bugs.webkit.org/show_bug.cgi?id=52617

I looked at the machine and it had 10 archives already
thus find_unused_name was returning None. I've upped
the limit to 100 (per bug) and tested the case where
find_unused_name returns None (making archive return None).

  • Scripts/webkitpy/common/system/workspace.py:
  • Scripts/webkitpy/common/system/workspace_unittest.py:
  • Scripts/webkitpy/tool/bot/commitqueuetask.py:
  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
  • Scripts/webkitpy/tool/commands/queues.py:
2:56 PM Changeset in webkit [76070] by dimich@chromium.org
  • 5 edits
    2 adds in trunk/LayoutTests

[Chromium] Not reviewed, updated expectations for tests
affected by ​http://trac.webkit.org/changeset/76047

  • platform/chromium-mac/fast/backgrounds/size/backgroundSize22-expected.checksum:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize22-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize22-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize22-expected.png:
  • platform/chromium-win/fast/css/background-clip-values-expected.checksum: Added.
  • platform/chromium-win/fast/css/background-clip-values-expected.png: Added.
2:55 PM Changeset in webkit [76069] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Add PageClientImpl::containingWindowGraphicsContext
​https://bugs.webkit.org/show_bug.cgi?id=52666

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::containingWindowGraphicsContext):
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.h:
2:53 PM Changeset in webkit [76068] by dbates@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-18 Daniel Bates <​dbates@rim.com>

Reviewed by Gavin Barraclough.

Only use moving memory model assumption in ExecutableAllocator::intializePageSize() for Symbian OS
​https://bugs.webkit.org/show_bug.cgi?id=52517

Patch by David Tapuska

Currently, we compile code with respect to the Symbian-specific moving memory model
assumption for all ARMv5 or lower architectures. Instead, we should only compile
such code when building for Symbian OS on those architectures because this model
is Symbian-specific.

  • jit/ExecutableAllocator.cpp: (JSC::ExecutableAllocator::intializePageSize):
2:45 PM Changeset in webkit [76067] by zmo@google.com
  • 3 edits in trunk/Source/WebCore

2011-01-18 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

Make CheckedInt<long> and CheckedInt<unsigned long> work
​https://bugs.webkit.org/show_bug.cgi?id=52401

  • html/canvas/CheckedInt.h: (WebCore::CheckedInt::CheckedInt): Merge with the patch provided by Benoit Jacob.
  • html/canvas/WebGLBuffer.cpp: (WebCore::WebGLBuffer::associateBufferDataImpl): Use CheckedInt<long> instead of CheckedInt<int>. (WebCore::WebGLBuffer::associateBufferSubDataImpl): Ditto.
2:30 PM Changeset in webkit [76066] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

2011-01-18 Damian Kaleta <​dkaleta@apple.com>

Reviewed by Sam Weinig.

WK2 methods WKPageScaleWebView and WKPageGetViewScaleFactor need to have consistent names
​https://bugs.webkit.org/show_bug.cgi?id=52647

  • UIProcess/API/C/WKPage.cpp: (WKPageSetScaleFactor): (WKPageGetScaleFactor):
  • UIProcess/API/C/WKPage.h:
2:22 PM Changeset in webkit [76065] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Ask the web page proxy to scroll the view when needed
​https://bugs.webkit.org/show_bug.cgi?id=52665

  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::incorporateUpdate):
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::scrollView):
  • UIProcess/WebPageProxy.h:
2:18 PM Changeset in webkit [76064] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix build.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::scrollView):

2:11 PM Changeset in webkit [76063] by kbr@google.com
  • 7 edits
    4 adds in trunk

2011-01-18 Kenneth Russell <​kbr@google.com>

Reviewed by David Levin.

Must strip comments from WebGL shaders before enforcing character set
​https://bugs.webkit.org/show_bug.cgi?id=52390

Strip comments from incoming shaders, preserving line numbers,
before validating that they conform to the ESSL character set.
Revert changes from ​http://trac.webkit.org/changeset/75735 which
allowed invalid characters to be passed to certain APIs.

Tested with WebGL layout tests, conformance test suite and several
WebGL demos in both Safari and Chromium.

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::StripComments::StripComments::process): (WebCore::WebGLRenderingContext::shaderSource):

2011-01-18 Kenneth Russell <​kbr@google.com>

Reviewed by David Levin.

Must strip comments from WebGL shaders before enforcing character set
​https://bugs.webkit.org/show_bug.cgi?id=52390

Incorporated non-ASCII GLSL conformance tests from Khronos
repository. Updated and synchronized invalid-passed-params.html
with Khronos repository, undoing changes from
​http://trac.webkit.org/changeset/75735 .

  • fast/canvas/webgl/glsl-conformance-expected.txt:
  • fast/canvas/webgl/invalid-passed-params-expected.txt:
  • fast/canvas/webgl/invalid-passed-params.html:
  • fast/canvas/webgl/shaders/00_shaders.txt:
  • fast/canvas/webgl/shaders/misc: Added.
  • fast/canvas/webgl/shaders/misc/00_shaders.txt: Added.
  • fast/canvas/webgl/shaders/misc/non-ascii-comments.vert: Added.
  • fast/canvas/webgl/shaders/misc/non-ascii.vert: Added.
2:08 PM Changeset in webkit [76062] by andersca@apple.com
  • 8 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Add PageClient::scrollView
​https://bugs.webkit.org/show_bug.cgi?id=52663

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::scrollView):
  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::scrollView):
  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/win/WebView.cpp: (WebKit::PageClientImpl::scrollView):
  • UIProcess/win/WebView.h:
1:55 PM Changeset in webkit [76061] by andersca@apple.com
  • 14 edits in trunk/Source/WebKit2

Rename scrollDelta to scrollOffset everywhere.

Reviewed by Sam Weinig.

  • Shared/UpdateInfo.cpp:

(WebKit::UpdateInfo::encode):
(WebKit::UpdateInfo::decode):

  • Shared/UpdateInfo.h:
  • UIProcess/BackingStore.h:
  • UIProcess/mac/BackingStoreMac.mm:

(WebKit::BackingStore::incorporateUpdate):
(WebKit::BackingStore::scroll):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::scroll):
(WebKit::WebChromeClient::delegatedScrollRequested):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:

(WebKit::ChunkedUpdateDrawingArea::scroll):

  • WebProcess/WebPage/ChunkedUpdateDrawingArea.h:
  • WebProcess/WebPage/DrawingArea.h:
  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::scroll):
(WebKit::DrawingAreaImpl::display):

  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/LayerBackedDrawingArea.cpp:

(WebKit::LayerBackedDrawingArea::scroll):

  • WebProcess/WebPage/LayerBackedDrawingArea.h:
1:46 PM Changeset in webkit [76060] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-18 Dimitry Andric <​dim@freebsd.org>

Reviewed by Andreas Kling.

Fix linking JavaScriptCore on FreeBSD/amd64
​https://bugs.webkit.org/show_bug.cgi?id=52591

Linking of JavaScriptCore on FreeBSD/amd64 fails, for the same reason as
in bug 28422: cti_vm_throw needs a "@plt" suffix, otherwise the linker
complains about the relocation type.

  • jit/JITStubs.cpp: use @plt suffix on x86_64 platforms, for both Linux and FreeBSD.
1:43 PM Changeset in webkit [76059] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-01-18 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Ojan Vafai.

Update rebaseline-chromium-webkit-tests unit tests to use a mock
filesystem. Also fix a couple of "with" statements missed by
r76050.

​https://bugs.webkit.org/show_bug.cgi?id=52487

  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1:37 PM Changeset in webkit [76058] by cmarrin@apple.com
  • 1 edit
    12 adds in trunk/LayoutTests

2011-01-18 Chris Marrin <​cmarrin@apple.com>

Reviewed by Simon Fraser.

Add LayoutTests for new compositing layer logic
​https://bugs.webkit.org/show_bug.cgi?id=52657

Add 4 tests checking that the layer tree is properly constructed with nested
layers. The first test is a simple static test of a layer with a 3D transform
with a non-layered parent. It is a pixel test and is just looking for a correct
image. The second test is similar but has a 4 deep hierarchy of <div> element where
only the innermost layer has a 3D transform. It is also a pixel test.
The other 2 tests are the same except that they add and then remove the innermost
layer's transform. It makes sure the layer tree is correct before and after
these changes.

  • compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt: Added.
  • compositing/geometry/layer-due-to-layer-children-deep-switch.html: Added.
  • compositing/geometry/layer-due-to-layer-children-deep.html: Added.
  • compositing/geometry/layer-due-to-layer-children-switch-expected.txt: Added.
  • compositing/geometry/layer-due-to-layer-children-switch.html: Added.
  • compositing/geometry/layer-due-to-layer-children.html: Added.
  • platform/mac/compositing/geometry/layer-due-to-layer-children-deep-expected.checksum: Added.
  • platform/mac/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
  • platform/mac/compositing/geometry/layer-due-to-layer-children-deep-expected.txt: Added.
  • platform/mac/compositing/geometry/layer-due-to-layer-children-expected.checksum: Added.
  • platform/mac/compositing/geometry/layer-due-to-layer-children-expected.png: Added.
  • platform/mac/compositing/geometry/layer-due-to-layer-children-expected.txt: Added.
1:33 PM Changeset in webkit [76057] by rniwa@webkit.org
  • 7 edits in trunk/Source/WebCore

2011-01-18 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

Stop instantiating legacy editing positions in DeleteSelectionCommand, IndentOudentCommand,
InsertLineBreakCommand, InsertListCOmmand.cpp, InsertParagraphSeparatorCommand, and htmlediting.cpp
​https://bugs.webkit.org/show_bug.cgi?id=52644

This is a cleanup to stop instantiating legacy editing positions in the following tests.
firstDeepEditingPositionForNode and lastDeepEditingPositionForNode in htmlediting.h are not updated
because doing so requires significant code changes. They are tracked on the bug 52642.

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializeStartEnd): (WebCore::updatePositionForNodeRemoval): (WebCore::DeleteSelectionCommand::removeNode): (WebCore::updatePositionForTextRemoval): (WebCore::DeleteSelectionCommand::handleGeneralDelete):
  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::outdentParagraph):
  • editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply):
  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApplyForSingleParagraph): (WebCore::InsertListCommand::unlistifyParagraph): (WebCore::InsertListCommand::listifyParagraph):
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
  • editing/htmlediting.cpp: (WebCore::enclosingBlock): (WebCore::enclosingList): (WebCore::enclosingListChild): (WebCore::indexForVisiblePosition): (WebCore::isNodeVisiblyContainedWithin): (WebCore::avoidIntersectionWithNode):
1:29 PM Changeset in webkit [76056] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-18 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Ojan Vafai.

[Chromium] Update Sputnik test expectations
​https://bugs.webkit.org/show_bug.cgi?id=52656

Mark Sputnik tests as WONTFIX, so that they don't artificially inflate
our failing test count.

  • platform/chromium/test_expectations.txt:
1:28 PM Changeset in webkit [76055] by sergio@webkit.org
  • 2 edits in trunk/Tools

2011-01-18 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Martin Robinson.

[Gtk] Build fixes for gtk3 build
​https://bugs.webkit.org/show_bug.cgi?id=52648

  • DumpRenderTree/gtk/EventSender.cpp: (beginDragWithFilesCallback):
1:28 PM Changeset in webkit [76054] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Get and paint each individual rect in -[WKView drawRect:]
​https://bugs.webkit.org/show_bug.cgi?id=52660

  • UIProcess/API/mac/WKView.mm: (-[WKView drawRect:]):
1:24 PM Changeset in webkit [76053] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-01-18 Benjamin Kalman <​kalman@chromium.org>

Reviewed by Ryosuke Niwa.

Tweak style in visible_units.cpp and TextIterator.cpp in preparation for another patch
​https://bugs.webkit.org/show_bug.cgi?id=52610

This is a purely aesthetic change.

  • editing/TextIterator.cpp: (WebCore::SimplifiedBackwardsTextIterator::advance):
  • editing/visible_units.cpp: (WebCore::previousBoundary):
1:22 PM Changeset in webkit [76052] by mihaip@chromium.org
  • 2 edits in trunk

2011-01-18 Mihai Parparita <​mihaip@chromium.org>

Unreviewed. Update .gitignore to reflect that WebKit is now in Source.

  • .gitignore:
1:17 PM Changeset in webkit [76051] by dimich@chromium.org
  • 3 edits in trunk/LayoutTests

[Chromium] Not reviewed, test expectations update.
Added exclusion for new test fast/canvas/canvas-fillPath-alpha-shadow.html

  • platform/chromium-gpu/test_expectations.txt:
  • platform/chromium/test_expectations.txt:
1:10 PM Changeset in webkit [76050] by dpranke@chromium.org
  • 6 edits in trunk/Tools

2011-01-18 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Mihai Parparita.

Update rebaseline-chromium-webkit-tests to use filesystem objects
instead of direct references to os.path, shutil, tempfile, etc.

This patch doesn't change anything, but will allow subsequent
patches to change the unit tests to no longer use the real
filesystem.

This patch adds a bunch more methods to the filesystem object as
well.

​https://bugs.webkit.org/show_bug.cgi?id=52482

  • Scripts/webkitpy/common/system/filesystem.py:
  • Scripts/webkitpy/common/system/filesystem_mock.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1:09 PM Changeset in webkit [76049] by oliver@apple.com
  • 5 edits in trunk

2011-01-18 Oliver Hunt <​oliver@apple.com>

Reviewed by Antti Koivisto.

[jsfunfuzz] Assertion in codegen for array of NaN constants
​https://bugs.webkit.org/show_bug.cgi?id=52643

Add a testcase to ensure we handle a large number of NaN literals
in (0/0 is folded to NaN automatically during parsing).

  • fast/js/codegen-temporaries-expected.txt:
  • fast/js/script-tests/codegen-temporaries.js:

2011-01-18 Oliver Hunt <​oliver@apple.com>

Reviewed by Antti Koivisto.

[jsfunfuzz] Assertion in codegen for array of NaN constants
​https://bugs.webkit.org/show_bug.cgi?id=52643

Don't cache NaN literals in the code generator, as NaN doesn't compare
as equal to itself it causes problems when rehashing the number cache.

  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitLoad):
1:02 PM Changeset in webkit [76048] by commit-queue@webkit.org
  • 7 edits in trunk/Source

2011-01-18 Adam Klein <​adamk@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Replace ChromiumBridge::widgetSetCursor with ChromeClient::setCursor
​https://bugs.webkit.org/show_bug.cgi?id=42236

  • platform/chromium/ChromiumBridge.h:
  • platform/chromium/WidgetChromium.cpp: (WebCore::Widget::setCursor):

2011-01-18 Adam Klein <​adamk@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Replace ChromiumBridge::widgetSetCursor with ChromeClient::setCursor
​https://bugs.webkit.org/show_bug.cgi?id=42236

  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::setCursor):
  • src/ChromeClientImpl.h:
  • src/ChromiumBridge.cpp:
12:37 PM Changeset in webkit [76047] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk

2011-01-18 Krithigassree Sambamurthy <​krithigassree.sambamurthy@nokia.com>

Reviewed by Simon Fraser.

Support background-clip: content-box
​https://bugs.webkit.org/show_bug.cgi?id=48771

Addded content-box as a valid background-clip value.

  • WebCore/css/CSSParser.cpp: (WebCore::parseBackgroundClip):

2011-01-18 Krithigassree Sambamurthy <​krithigassree.sambamurthy@nokia.com>

Reviewed by Simon Fraser.

Support background-clip: content-box
​https://bugs.webkit.org/show_bug.cgi?id=48771

Added test cases to check the various valid background-clip values.

  • fast/css/background-clip-text-expected.txt:
  • fast/css/background-clip-values-expected.checksum: Added.
  • fast/css/background-clip-values-expected.txt: Added.
  • fast/css/background-clip-values.html: Added.
  • fast/css/script-tests/background-clip-text.js:
12:34 PM Changeset in webkit [76046] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler.

Assertion when loading two URLs in quick succession
​https://bugs.webkit.org/show_bug.cgi?id=52649
<rdar://problem/8764645>

If beginLoad is called twice without didStartProvisionalLoad being called in between,
m_pendingProvisionalSandboxExtension would be non-null and an assert would fire.

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::SandboxExtensionTracker::beginLoad): Instead of asserting that m_pendingProvisionalSandboxExtension is null, invalidate it if it is not null, since that's valid.
12:32 PM Changeset in webkit [76045] by dpranke@chromium.org
  • 4 edits in trunk/Tools

2011-01-18 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Mihai Parparita.

new-run-webkit-tests shouldn't crash when you try to run a
directory containing only skipped files.

​https://bugs.webkit.org/show_bug.cgi?id=52478

  • Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
12:27 PM Changeset in webkit [76044] by Chris Fleizach
  • 7 edits
    2 adds in trunk

REGRESSION: A problem with Voiceover and finding links
​https://bugs.webkit.org/show_bug.cgi?id=52324

Reviewed by Darin Adler.

Source/WebCore:

Fallout from recent change to make WebCore return its own scroll view.

1) There were two scroll views in the hierarchy, one which no needed to be ignored.
2) Hit tests for sub frames needed to be offset.
3) The check for whether an attachment is ignored must happen earlier than using

the helpText to determine if an element should be ignored.

Test: platform/mac/accessibility/iframe-with-title-correct-hierarchy.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::elementAccessibilityHitTest):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper scrollViewParent]):

Source/WebKit/mac:

  • WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView accessibilityIsIgnored]):

LayoutTests:

  • platform/mac/accessibility/iframe-with-title-correct-hierarchy-expected.txt: Added.
  • platform/mac/accessibility/iframe-with-title-correct-hierarchy.html: Added.
12:09 PM Changeset in webkit [76043] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Implement NPN_PopUpContextMenu
​https://bugs.webkit.org/show_bug.cgi?id=52646
<rdar://problem/8735616>

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::NPN_PopUpContextMenu): Call NetscapePlugin::popUpContextMenu.
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::NetscapePlugin): Initialize m_currentMouseEvent.
  • WebProcess/Plugins/Netscape/NetscapePlugin.h: Add m_currentMouseEvent.
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: (WebKit::NetscapePlugin::popUpContextMenu): Convert the coordinates from the current mouse event to screen coordinates and call WKPopupContextMenu.

(WebKit::NetscapePlugin::platformHandleMouseEvent):
Update m_currentMouseEvent.

11:56 AM Changeset in webkit [76042] by andersca@apple.com
  • 4 edits in trunk/WebKitLibraries

Add WKPopupContextMenu.

Reviewed by Darin Adler.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
11:15 AM Changeset in webkit [76041] by Adam Roben
  • 2 edits in trunk/Source/WebCore

Call alternate CFHTTPCookie functions if available

Fixes <​http://webkit.org/b/52637> <rdar://problem/8878984>.

Reviewed by Darin Adler.

  • platform/network/cf/CookieJarCFNet.cpp: Added soft-linking macros to

pull in the alternate CFHTTPCookie functions.

(WebCore::cookieDomain):
(WebCore::cookieExpirationTime):
(WebCore::cookieName):
(WebCore::cookiePath):
(WebCore::cookieValue):
Added these wrappers around the CFHTTPCookie functions. We call the
alternate functions if they exist, otherwise fall back to the current
functions.

(WebCore::filterCookies):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
Changed to use the wrapper functions.

11:06 AM Changeset in webkit [76040] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebKit2

WebKit2: Do not assert that the provisional and committed URLs cannot be empty/null
​https://bugs.webkit.org/show_bug.cgi?id=52641

Reviewed by Darin Adler.

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::didStartProvisionalLoad):
(WebKit::WebFrameProxy::didCommitLoad):
(WebKit::WebFrameProxy::didFinishLoad):

11:06 AM Changeset in webkit [76039] by Martin Robinson
  • 4 edits in trunk

2011-01-18 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] Filenames are converted to URLs during edit drags
​https://bugs.webkit.org/show_bug.cgi?id=52096

  • platform/gtk/Skipped: Unskip passing test. Fix a misspelled drag and drop test on the list as well.

2011-01-18 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] Filenames are converted to URLs during edit drags
​https://bugs.webkit.org/show_bug.cgi?id=52096

  • platform/gtk/DragDataGtk.cpp: Only advertise and deliver filenames as URLs if the conversion policy allows it. (WebCore::DragData::containsURL): Ditto. (WebCore::DragData::asURL): Ditto.
10:53 AM Changeset in webkit [76038] by jorlow@chromium.org
  • 1 edit
    6 adds in trunk/LayoutTests

2011-01-18 Jeremy Orlow <​jorlow@chromium.org>

[Chromium] Create baselines for svg/css/text-gradient-shadow.svg
​https://bugs.webkit.org/show_bug.cgi?id=52640

  • platform/chromium-linux/svg/css/text-gradient-shadow-expected.checksum: Added.
  • platform/chromium-linux/svg/css/text-gradient-shadow-expected.png: Added.
  • platform/chromium-mac/svg/css/text-gradient-shadow-expected.checksum: Added.
  • platform/chromium-win/svg/css/text-gradient-shadow-expected.checksum: Added.
  • platform/chromium-win/svg/css/text-gradient-shadow-expected.png: Added.
  • platform/chromium-win/svg/css/text-gradient-shadow-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
10:49 AM Changeset in webkit [76037] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2011-01-18 Martin Robinson <​mrobinson@igalia.com>

Skip two tests which were incorrectly passing before GTK+
had support for beginDragWithFiles.

  • platform/gtk/Skipped: Skip failing tests.
10:24 AM Changeset in webkit [76036] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

ASSERT in plug-in code when going to youtube
​https://bugs.webkit.org/show_bug.cgi?id=52638

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::paintEntirePlugin): Don't try to paint the plug-in if the plug-in frame is empty.
10:15 AM Changeset in webkit [76035] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-18 John Knottenbelt <​jknotten@chromium.org>

Reviewed by Jeremy Orlow.

[Chromium] Adjust test expectations fast/files/revoke-blob-url.html is flaky on linux.
​https://bugs.webkit.org/show_bug.cgi?id=52633

Combine test expectations for the test into one line.

  • platform/chromium/test_expectations.txt:
10:11 AM Changeset in webkit [76034] by andersca@apple.com
  • 13 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Plug-in hosting WebProcess instances appear in Activity Monitor as WebProcess
​https://bugs.webkit.org/show_bug.cgi?id=52635
<rdar://problem/8731337>

  • PluginProcess/PluginProcess.cpp: (WebKit::PluginProcess::initialize): Call platformInitialize.
  • PluginProcess/PluginProcess.h: Add platformInitialize.
  • PluginProcess/mac/PluginProcessMac.mm: (WebKit::PluginProcess::platformInitialize): Set the compositing render server port and the visible application name.
  • Shared/Plugins/PluginProcessCreationParameters.cpp: (WebKit::PluginProcessCreationParameters::encode): (WebKit::PluginProcessCreationParameters::decode): Encode/decode the parent process name.
  • Shared/Plugins/PluginProcessCreationParameters.h: Add parentProcessName.
  • Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode): (WebKit::WebProcessCreationParameters::decode): Encode/decode the parent process name.
  • Shared/WebProcessCreationParameters.h: Add parentProcessName.
  • UIProcess/Launcher/mac/ProcessLauncherMac.mm: (WebKit::ProcessLauncher::launchProcess): Don't pass the parent process name here.
  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm: (WebKit::PluginProcessProxy::platformInitializePluginProcess): Set the visible name.
  • UIProcess/mac/WebContextMac.mm: (WebKit::WebContext::platformInitializeWebProcess): Pass along the parent process name.
  • WebProcess/mac/WebProcessMac.mm: (WebKit::WebProcess::platformInitializeWebProcess): Set the visible name.
  • WebProcess/mac/WebProcessMainMac.mm: (WebKit::WebProcessMain): Don't set the visible name here. It's done in platformInitializeWebProcess.
10:10 AM Changeset in webkit [76033] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

2011-01-18 Helder Correia <​helder@sencha.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Incorrect shadow alpha with semi-transparent solid fillStyle
​https://bugs.webkit.org/show_bug.cgi?id=52611

This is related to bug 52559. The shadow color alpha must be multiplied
by the context brush alpha.

New test to ensure correct behavior of canvas with fillPath using a
semi-transparent fillStyle color and a shadow.

  • fast/canvas/canvas-fillPath-alpha-shadow-expected.txt: Added.
  • fast/canvas/canvas-fillPath-alpha-shadow.html: Added.
  • fast/canvas/script-tests/canvas-fillPath-alpha-shadow.js: Added.

2011-01-18 Helder Correia <​helder@sencha.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Incorrect shadow alpha with semi-transparent solid fillStyle
​https://bugs.webkit.org/show_bug.cgi?id=52611

This is related to bug 52559. The shadow color alpha must be multiplied
by the context brush alpha.

Test: fast/canvas/canvas-fillPath-alpha-shadow.html

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillPath):
9:56 AM Changeset in webkit [76032] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-18 John Knottenbelt <​jknotten@chromium.org>

Unreviewed; updated chromium test expectations.

[Chromium] Adjust test expectations fast/files/revoke-blob-url.html is flaky on linux.
​https://bugs.webkit.org/show_bug.cgi?id=52633

  • platform/chromium/test_expectations.txt:
9:47 AM Changeset in webkit [76031] by Martin Robinson
  • 4 edits
    4 adds in trunk

2011-01-18 Adam Bergkvist <​adam.bergkvist@ericsson.com> and Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] The GTK+ EventSender needs support for beginDragWithFiles
​https://bugs.webkit.org/show_bug.cgi?id=40833

Unskip passing tests, add in a GTK+-specific result and one more result
which is necessary because GTK+ tests run in Xvfb.

  • platform/gtk/Skipped: Unskip tests that are now passing and organize the remaining skipped tests.
  • platform/gtk/fast/forms/input-file-re-render-expected.txt: Added.
  • platform/gtk/http/tests/security/clipboard/clipboard-file-access-expected.txt: Added.

2011-01-18 Adam Bergkvist <​adam.bergkvist@ericsson.com> and Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] The GTK+ EventSender needs support for beginDragWithFiles
​https://bugs.webkit.org/show_bug.cgi?id=40833

  • DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the GTK+ event sender. (dragWithFilesDragDataGetCallback): Added. (dragWithFilesDragEndCallback): Added. (beginDragWithFilesCallback): Added.
9:40 AM Changeset in webkit [76030] by caseq@chromium.org
  • 7 edits in trunk

2011-01-18 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: fail resource.requestContent() immediately for WebSocket resources
Remove webInspector.resources.Types from test expectations.
​https://bugs.webkit.org/show_bug.cgi?id=52628

  • inspector/extensions-api-expected.txt:

2011-01-18 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: fail resource.requestContent() immediately for WebSocket resources
​https://bugs.webkit.org/show_bug.cgi?id=52628

  • English.lproj/localizedStrings.js: Rename WebSocket -> WebSockets in resource catetegories (rest are in plural, too)
  • inspector/front-end/ExtensionServer.js: Do not expose webInspector.resources.Types in extensions API (obsolete) (WebInspector.ExtensionServer.prototype._buildExtensionAPIInjectedScript):
  • inspector/front-end/Resource.js: (WebInspector.Resource.Type.toUIString): Remove ResourceType.Media as it's not used. (WebInspector.Resource.Type.toString): ditto. (WebInspector.Resource.prototype.requestContent): Fail immediately for WebSocket resources.
  • inspector/front-end/inspector.js: Rename WebSocket -> WebSockets in resource catetegories (rest are in plural, too)
9:19 AM Changeset in webkit [76029] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

2011-01-18 Helder Correia <​helder@sencha.com>

Reviewed by Dirk Schulze.

REGRESSION(75139): SVG gradients are not applied to texts
​https://bugs.webkit.org/show_bug.cgi?id=52531

r75139 caused a problem with filling and stroking text with a gradient
fill in SVG. The order of CGContextConcatCTM and CGContextClipToRect
was mixed up.

  • platform/mac/svg/css/text-gradient-shadow-expected.checksum: Added.
  • platform/mac/svg/css/text-gradient-shadow-expected.png: Added.
  • platform/mac/svg/css/text-gradient-shadow-expected.txt: Added.
  • svg/css/text-gradient-shadow.svg: Added.

2011-01-18 Helder Correia <​helder@sencha.com>

Reviewed by Dirk Schulze.

REGRESSION(75139): SVG gradients are not applied to texts
​https://bugs.webkit.org/show_bug.cgi?id=52531

r75139 caused a problem with filling and stroking text with a gradient
fill in SVG. The order of CGContextConcatCTM and CGContextClipToRect
was mixed up.

Test: svg/css/text-gradient-shadow.svg

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillRect):
9:07 AM Changeset in webkit [76028] by jknotten@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-01-18 John Knottenbelt <​jknotten@chromium.org>

Reviewed by Jeremy Orlow.

Add pixel test baseline for svg/custom/use-inherit-style.svg
​https://bugs.webkit.org/show_bug.cgi?id=52630

  • svg/custom/use-inherit-style-expected.checksum: Added.
  • svg/custom/use-inherit-style-expected.png: Added.
7:56 AM Changeset in webkit [76027] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-01-18 Leo Yang <​leo.yang@torchmobile.com.cn>

Reviewed by Nikolas Zimmermann.

Unable to indirectly animate visibility of SVGUseElement
​https://bugs.webkit.org/show_bug.cgi?id=50240

Test case to verify if SVGUseElement inherits parent's
style change.

  • svg/custom/use-inherit-style-expected.txt: Added.
  • svg/custom/use-inherit-style.svg: Added.

2011-01-18 Leo Yang <​leo.yang@torchmobile.com.cn>

Reviewed by Nikolas Zimmermann.

Unable to indirectly animate visibility of SVGUseElement
​https://bugs.webkit.org/show_bug.cgi?id=50240

SVGUseElement::recalcStyle should take care of its shadow
tree's style recalculation when it is called with change >= Inherit
or when childNeedsStyleRecalc() is true because in these two
cases needStyleRecalc() may not be true.

Test: svg/custom/use-inherit-style.svg

  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::recalcStyle):
7:34 AM Changeset in webkit [76026] by podivilov@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-01-18 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: provide script length to frontend.
​https://bugs.webkit.org/show_bug.cgi?id=52620

  • inspector/Inspector.idl:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::didParseSource):
  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype._parsedScriptSource): (WebInspector.DebuggerDispatcher.prototype.parsedScriptSource):
  • inspector/front-end/Script.js: (WebInspector.Script):
7:30 AM Changeset in webkit [76025] by podivilov@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

2011-01-18 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, remove wrong chromium expectation for console-xhr-logging test.

  • platform/chromium/http/tests/inspector/console-xhr-logging-expected.txt: Removed.
6:49 AM BuildingCairoOnWindows edited by d.nusman@re-lion.com
(diff)
6:48 AM Changeset in webkit [76024] by zherczeg@webkit.org
  • 1 edit in trunk/Source/WebCore/ChangeLog

Fixing ChangeLog

Rubber-stamped by Csaba Osztrogonác

Removing a line introduced by
​http://trac.webkit.org/changeset/75743/trunk/Source/WebCore/ChangeLog
Removing an unnecessary space before a time stamp.

6:34 AM Changeset in webkit [76023] by podivilov@chromium.org
  • 3 edits in trunk/LayoutTests

2011-01-18 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, test fix for r76019.

  • http/tests/inspector-enabled/console-log-before-frame-navigation-expected.txt:
  • http/tests/inspector-enabled/console-log-before-frame-navigation.html:
6:25 AM Changeset in webkit [76022] by caseq@chromium.org
  • 7 edits in trunk/Source/WebCore

2011-01-17 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [refactoring] use events to notify NetworkManager clients
​https://bugs.webkit.org/show_bug.cgi?id=52588

  • inspector/front-end/AuditLauncherView.js: (WebInspector.AuditLauncherView): Do not expose public interface to resource count. Do not reset resource count upon reset(). (WebInspector.AuditLauncherView.prototype._resetResourceCount): (WebInspector.AuditLauncherView.prototype._onResourceStarted): (WebInspector.AuditLauncherView.prototype._onResourceFinished):
  • inspector/front-end/AuditsPanel.js: Do not expose public interface to resource start/finish events.
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer): (WebInspector.ExtensionServer.prototype._notifyResourceFinished): (WebInspector.ExtensionServer.prototype.initExtensions):
  • inspector/front-end/NetworkManager.js: Dispatch events rather than directly call clients. (WebInspector.NetworkManager): (WebInspector.NetworkManager.prototype.willSendRequest): (WebInspector.NetworkManager.prototype.markResourceAsCached): (WebInspector.NetworkManager.prototype.didReceiveResponse): (WebInspector.NetworkManager.prototype.didReceiveContentLength): (WebInspector.NetworkManager.prototype.setInitialContent): (WebInspector.NetworkManager.prototype.didCommitLoadForFrame): (WebInspector.NetworkManager.prototype.willSendWebSocketHandshakeRequest): (WebInspector.NetworkManager.prototype.didReceiveWebSocketHandshakeResponse): (WebInspector.NetworkManager.prototype._startResource): (WebInspector.NetworkManager.prototype._finishResource):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel): (WebInspector.NetworkPanel.prototype._onResourceStarted): (WebInspector.NetworkPanel.prototype._appendResource): (WebInspector.NetworkPanel.prototype._onResourceUpdated): (WebInspector.NetworkPanel.prototype._refreshResource): (WebInspector.NetworkPanel.prototype._onMainResourceChanged):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel): (WebInspector.ResourcesPanel.prototype._refreshResource):
6:20 AM Changeset in webkit [76021] by pfeldman@chromium.org
  • 8 edits in trunk

2011-01-18 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: preserve pause on exception state in settings.
​https://bugs.webkit.org/show_bug.cgi?id=52619

  • inspector/InspectorController.cpp: (WebCore::InspectorController::getInspectorState):
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.debuggerWasEnabled): (WebInspector.ScriptsPanel.prototype._updatePauseOnExceptionsState): (WebInspector.ScriptsPanel.prototype._togglePauseOnExceptions): (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):
  • inspector/front-end/Settings.js: (WebInspector.Settings):
  • inspector/front-end/inspector.js: (WebInspector.doLoadedDone.populateInspectorState):
6:09 AM Changeset in webkit [76020] by podivilov@chromium.org
  • 5 edits in trunk/LayoutTests

2011-01-18 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: fix flaky debugger tests.
​https://bugs.webkit.org/show_bug.cgi?id=51320

  • http/tests/inspector/debugger-test2.js: (initialize_DebuggerTest.InspectorTest.setBreakpoint): (initialize_DebuggerTest.InspectorTest.showScriptSource): (initialize_DebuggerTest.InspectorTest._showScriptSource):
  • inspector/debugger-pause-on-breakpoint-expected.txt:
  • inspector/debugger-pause-on-breakpoint.html:
5:54 AM Changeset in webkit [76019] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-18 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [REGRESSION] JavaScript exceptions aren't shown in source frame.
​https://bugs.webkit.org/show_bug.cgi?id=52623

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage): (WebInspector.ConsoleMessage.prototype._formatMessage):
5:42 AM Changeset in webkit [76018] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-18 Pavel Feldman <​pfeldman@chromium.org>

Revert r76017. No need to guard InspectorInstrumentation
in WebCore.
  • page/Page.cpp: (WebCore::networkStateChanged):
4:44 AM Changeset in webkit [76017] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-18 Konstantin Tokarev <Konstantin Tokarev>

Reviewed by Kent Tamura.

Fixed compilation when Inspector is disabled
​https://bugs.webkit.org/show_bug.cgi?id=52564

  • page/Page.cpp: (WebCore::networkStateChanged): Added ENABLE(INSPECTOR) guard
4:26 AM Changeset in webkit [76016] by morrita@google.com
  • 23 edits
    2 deletes in trunk/Source/WebCore

2011-01-18 MORITA Hajime <​morrita@google.com>

Unreviewed, rolling out r76004, r76005, r76007, and r76011.
​http://trac.webkit.org/changeset/76004
​http://trac.webkit.org/changeset/76005
​http://trac.webkit.org/changeset/76007
​http://trac.webkit.org/changeset/76011
​https://bugs.webkit.org/show_bug.cgi?id=51664

The r76004 broke pixel tests.
(The failure was missed due to the tolerance.)

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::addRoundedRectClip): (WebCore::GraphicsContext::clipOutRoundedRect):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/RoundedIntRect.cpp: Removed.
  • platform/graphics/RoundedIntRect.h: Removed.
  • rendering/RenderBox.cpp: (WebCore::RenderBox::pushContentsClip):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): (WebCore::RenderBoxModelObject::paintBorder): (WebCore::RenderBoxModelObject::clipBorderSidePolygon): (WebCore::uniformlyExpandBorderRadii): (WebCore::RenderBoxModelObject::paintBoxShadow):
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::drawBoxSideFromPath):
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint):
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMenuListButtonGradients): (WebCore::RenderThemeMac::paintSliderTrack):
  • rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintMenuListButtonGradients): (WebCore::RenderThemeSafari::paintSliderTrack):
  • rendering/RenderThemeWinCE.cpp: (WebCore::RenderThemeWinCE::paintSearchFieldCancelButton):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
  • rendering/style/BorderData.h:
  • rendering/style/RenderStyle.cpp: (WebCore::constrainCornerRadiiForRect): (WebCore::RenderStyle::getBorderRadiiForRect): (WebCore::RenderStyle::getInnerBorderRadiiForRectWithBorderWidths):
  • rendering/style/RenderStyle.h:
4:19 AM Changeset in webkit [76015] by hayato@chromium.org
  • 2 edits in trunk

2011-01-18 Hayato Ito <​hayato@chromium.org>

Reviewed by Kent Tamura.

Update .gitignore file to reflect a recent WebKit directory movement.

​https://bugs.webkit.org/show_bug.cgi?id=52618

  • .gitignore:
4:16 AM Changeset in webkit [76014] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Not implemented warnings should not break layout tests
​https://bugs.webkit.org/show_bug.cgi?id=52616

Reviewed by Csaba Osztrogonác.

  • WebKit2Prefix.h: Define DISABLE_NOT_IMPLEMENTED_WARNINGS on Qt.
3:04 AM Changeset in webkit [76013] by podivilov@chromium.org
  • 10 edits in trunk/Source/WebCore

2011-01-17 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: add source column field to debugger call frames.
​https://bugs.webkit.org/show_bug.cgi?id=52443

  • bindings/js/JavaScriptCallFrame.cpp: (WebCore::JavaScriptCallFrame::JavaScriptCallFrame):
  • bindings/js/JavaScriptCallFrame.h: (WebCore::JavaScriptCallFrame::create): (WebCore::JavaScriptCallFrame::line): (WebCore::JavaScriptCallFrame::column): (WebCore::JavaScriptCallFrame::update):
  • bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::createCallFrameAndPauseIfNeeded): (WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded): (WebCore::ScriptDebugServer::callEvent): (WebCore::ScriptDebugServer::atStatement): (WebCore::ScriptDebugServer::returnEvent): (WebCore::ScriptDebugServer::exception): (WebCore::ScriptDebugServer::willExecuteProgram): (WebCore::ScriptDebugServer::didExecuteProgram): (WebCore::ScriptDebugServer::didReachBreakpoint):
  • bindings/js/ScriptDebugServer.h:
  • bindings/v8/DebuggerScript.js: ():
  • bindings/v8/JavaScriptCallFrame.cpp: (WebCore::JavaScriptCallFrame::column):
  • bindings/v8/JavaScriptCallFrame.h:
  • inspector/InjectedScriptSource.js: ():
  • inspector/JavaScriptCallFrame.idl:

2011-01-18 Antti Koivisto <Antti Koivisto>

Reviewed by Dave Hyatt.

​https://bugs.webkit.org/show_bug.cgi?id=52370
<rdar://problem/8856808>
Style sharing optimization no longer works on major web sites

The code in CSSStyleSelector::locateSharedStyle() that tries to share style information between element has been defeated
by widespread use of certain CSS selectors (:first-child pseudo class and similar). The current implementation disables
the sharing optimization for the whole page if one of these constructs is seen in any style sheet used by the page.

This patch gets the style sharing back to 25-40% range on most web sites.

  • css/CSSMutableStyleDeclaration.h: (WebCore::CSSMutableStyleDeclaration::propertiesEqual):

Needed to improve equality checking in NamedNodeMap::mappedMapsEquivalent.

  • css/CSSSelector.h: (WebCore::CSSSelector::isSiblingSelector):

Test for selectors that are affected by the sibling elements.

  • css/CSSStyleSelector.cpp: (WebCore::elementCanUseSimpleDefaultStyle): (WebCore::collectSiblingRulesInDefaultStyle): (WebCore::assertNoSiblingRulesInDefaultStyle):

Extract sibling rules from the MathML default stylesheet.
Assert that no other default stylesheet has them.

(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::locateCousinList):
(WebCore::CSSStyleSelector::matchesSiblingRules):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::locateSharedStyle):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::collectIdsAndSiblingRulesFromList):
(WebCore::CSSRuleSet::collectIdsAndSiblingRules):

Track sibling rules and ids used in the stylesheets to allow much more fine-grained rejection of cases
where style sharing can't be used.

  • css/CSSStyleSelector.h:
  • dom/NamedNodeMap.cpp: (WebCore::NamedNodeMap::mappedMapsEquivalent):

Check also for CSSValue mutation from DOM.

  • mathml/MathMLMathElement.cpp: (WebCore::MathMLMathElement::insertedIntoDocument):
  • mathml/MathMLMathElement.h:

MathML default style sheet has sibling rules which don't get noticed by the normal document
stylesheet parsing.

  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::setFirstChildState): (WebCore::InheritedFlags::setLastChildState): (WebCore::InheritedFlags::setChildIndex):

These all make style non-shareable (unique).

2:48 AM Changeset in webkit [76012] by Antti Koivisto
  • 12 edits in trunk

Source/WebCore: 2011-01-18 Antti Koivisto <Antti Koivisto>

Reviewed by Dave Hyatt.

​https://bugs.webkit.org/show_bug.cgi?id=52370
<rdar://problem/8856808>
Style sharing optimization no longer works on major web sites

The code in CSSStyleSelector::locateSharedStyle() that tries to share style information between element has been defeated
by widespread use of certain CSS selectors (:first-child pseudo class and similar). The current implementation disables
the sharing optimization for the whole page if one of these constructs is seen in any style sheet used by the page.

This patch gets the style sharing back to 25-40% range on most web sites.

  • css/CSSMutableStyleDeclaration.h:

(WebCore::CSSMutableStyleDeclaration::propertiesEqual):

Needed to improve equality checking in NamedNodeMap::mappedMapsEquivalent.


  • css/CSSSelector.h:

(WebCore::CSSSelector::isSiblingSelector):

Test for selectors that are affected by the sibling elements.


  • css/CSSStyleSelector.cpp:

(WebCore::elementCanUseSimpleDefaultStyle):
(WebCore::collectSiblingRulesInDefaultStyle):
(WebCore::assertNoSiblingRulesInDefaultStyle):

Extract sibling rules from the MathML default stylesheet.
Assert that no other default stylesheet has them.


(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::locateCousinList):
(WebCore::CSSStyleSelector::matchesSiblingRules):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::locateSharedStyle):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::collectIdsAndSiblingRulesFromList):
(WebCore::CSSRuleSet::collectIdsAndSiblingRules):

Track sibling rules and ids used in the stylesheets to allow much more fine-grained rejection of cases
where style sharing can't be used.

  • css/CSSStyleSelector.h:
  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::mappedMapsEquivalent):

Check also for CSSValue mutation from DOM.


  • mathml/MathMLMathElement.cpp:

(WebCore::MathMLMathElement::insertedIntoDocument):

  • mathml/MathMLMathElement.h:


MathML default style sheet has sibling rules which don't get noticed by the normal document
stylesheet parsing.


  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::setFirstChildState):
(WebCore::InheritedFlags::setLastChildState):
(WebCore::InheritedFlags::setChildIndex):

These all make style non-shareable (unique).

LayoutTests: ​https://bugs.webkit.org/show_bug.cgi?id=52370
Style sharing optimization no longer works on major web sites

Reviewed by Dave Hyatt.

These are progressions (with no noticable visual change).
MathML code was improperly sharing style.

  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
  • platform/mac/mathml/presentation/subsup-expected.txt:
2:37 AM Changeset in webkit [76011] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

2011-01-18 MORITA Hajime <​morrita@google.com>

Unreviewed crash fix on release builds.

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended):
2:20 AM Changeset in webkit [76010] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-18 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, update localizedStrings.js.

  • English.lproj/localizedStrings.js:
2:15 AM Changeset in webkit [76009] by podivilov@chromium.org
  • 7 edits
    1 add in trunk/Source/WebCore

2011-01-11 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: implement script beautifier prototype.
​https://bugs.webkit.org/show_bug.cgi?id=51588

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/ScriptFormatter.js: Added. (WebInspector.ScriptFormatter): Implements JavaScript source beautification and conversion between original and formatted line numbers (WebInspector.ScriptFormatter.findLineEndings): (WebInspector.ScriptFormatter.locationToPosition): (WebInspector.ScriptFormatter.positionToLocation): (WebInspector.ScriptFormatter.upperBound): (WebInspector.ScriptFormatter.prototype.format): (WebInspector.ScriptFormatter.prototype.originalLineNumberToFormattedLineNumber): (WebInspector.ScriptFormatter.prototype.formattedLineNumberToOriginalLineNumber): (WebInspector.ScriptFormatter.prototype.originalPositionToFormattedLineNumber): (WebInspector.ScriptFormatter.prototype.formattedLineNumberToOriginalPosition): (WebInspector.ScriptFormatter.prototype._convertPosition):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._clearCurrentExecutionLine): (WebInspector.ScriptsPanel.prototype._callFrameSelected): (WebInspector.ScriptsPanel.prototype._formatScript):
  • inspector/front-end/SourceFrame.js: Convert original line numbers to UI line numbers and vice versa
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
2:02 AM Changeset in webkit [76008] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Tools

2011-01-18 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Adam Barth.

ews: Add additional watcher to efl ews
​https://bugs.webkit.org/show_bug.cgi?id=52613

Add ​gyuyoung.kim@samsung.com to watcher list of efl-ews.

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1:32 AM Changeset in webkit [76007] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

2011-01-18 Philippe Normand <​pnormand@igalia.com>

Unreviewed, GTK build fix as follow-up of r76004.

  • GNUmakefile.am: Include RoundedIntRect files in the build
1:24 AM Changeset in webkit [76006] by Philippe Normand
  • 3 edits
    12 deletes in trunk

2011-01-18 Philippe Normand <​pnormand@igalia.com>

Unreviewed, rolling out r76002.
​http://trac.webkit.org/changeset/76002
​https://bugs.webkit.org/show_bug.cgi?id=49790

breaks a bunch of fast/forms tests on mac and GTK

  • fast/forms/select-option-background-color-change.html: Removed.
  • fast/forms/select-option-color-change.html: Removed.
  • fast/forms/select-option-visibility-change.html: Removed.
  • platform/mac/fast/forms/select-option-background-color-change-expected.checksum: Removed.
  • platform/mac/fast/forms/select-option-background-color-change-expected.png: Removed.
  • platform/mac/fast/forms/select-option-background-color-change-expected.txt: Removed.
  • platform/mac/fast/forms/select-option-color-change-expected.checksum: Removed.
  • platform/mac/fast/forms/select-option-color-change-expected.png: Removed.
  • platform/mac/fast/forms/select-option-color-change-expected.txt: Removed.
  • platform/mac/fast/forms/select-option-visibility-change-expected.checksum: Removed.
  • platform/mac/fast/forms/select-option-visibility-change-expected.png: Removed.
  • platform/mac/fast/forms/select-option-visibility-change-expected.txt: Removed.

2011-01-18 Philippe Normand <​pnormand@igalia.com>

Unreviewed, rolling out r76002.
​http://trac.webkit.org/changeset/76002
​https://bugs.webkit.org/show_bug.cgi?id=49790

breaks a bunch of fast/forms tests on mac and GTK

  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::setRenderStyle):
1:13 AM Changeset in webkit [76005] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

2011-01-18 MORITA Hajime <​morrita@google.com>

Unreviewed windows build fix.

  • WebCore.vcproj/WebCore.vcproj:
12:59 AM Changeset in webkit [76004] by morrita@google.com
  • 21 edits
    2 adds in trunk/Source/WebCore

2011-01-17 MORITA Hajime <​morrita@google.com>

Reviewed by Simon Fraser.

Refactoring: Extract RoundedIntRect class
​https://bugs.webkit.org/show_bug.cgi?id=51664

RoundedIntRect is a pair of rect and four IntSize objects which represent
corner radii of the rectangle. IntSize is grouped into RoundedIntRect::Radii.
Now RenderStyle::getRoundedBorderFor() and RenderStyle::getRoundedInnerBorderWithBorderWidths()
return RoundedIntRect and GraphicsContext::addRoundedRectClip(), GraphicsContext::fillRoundedRect()
and other functions accept RoundedIntRect as an argument.

No new tests. No behavioral change.

  • Android.mk:
  • CMakeLists.txt:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::addRoundedRectClip): (WebCore::GraphicsContext::clipOutRoundedRect): (WebCore::GraphicsContext::fillRoundedRect):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/RoundedIntRect.cpp: Added. (WebCore::RoundedIntRect::Radii::isZero): (WebCore::RoundedIntRect::Radii::scale): (WebCore::RoundedIntRect::Radii::expand): (WebCore::RoundedIntRect::Radii::includeLogicalEdges): (WebCore::RoundedIntRect::Radii::excludeLogicalEdges): (WebCore::RoundedIntRect::RoundedIntRect): (WebCore::RoundedIntRect::includeLogicalEdges): (WebCore::RoundedIntRect::excludeLogicalEdges):
  • platform/graphics/RoundedIntRect.h: Added. (WebCore::RoundedIntRect::Radii::Radii): (WebCore::RoundedIntRect::Radii::setTopLeft): (WebCore::RoundedIntRect::Radii::setTopRight): (WebCore::RoundedIntRect::Radii::setBottomLeft): (WebCore::RoundedIntRect::Radii::setBottomRight): (WebCore::RoundedIntRect::Radii::topLeft): (WebCore::RoundedIntRect::Radii::topRight): (WebCore::RoundedIntRect::Radii::bottomLeft): (WebCore::RoundedIntRect::Radii::bottomRight): (WebCore::RoundedIntRect::Radii::expand): (WebCore::RoundedIntRect::Radii::shrink): (WebCore::RoundedIntRect::location): (WebCore::RoundedIntRect::size): (WebCore::RoundedIntRect::x): (WebCore::RoundedIntRect::y): (WebCore::RoundedIntRect::width): (WebCore::RoundedIntRect::height): (WebCore::RoundedIntRect::right): (WebCore::RoundedIntRect::bottom): (WebCore::RoundedIntRect::rect): (WebCore::RoundedIntRect::radii): (WebCore::RoundedIntRect::isRounded): (WebCore::RoundedIntRect::isEmpty): (WebCore::RoundedIntRect::setRect): (WebCore::RoundedIntRect::setRadii): (WebCore::RoundedIntRect::move): (WebCore::RoundedIntRect::inflate): (WebCore::RoundedIntRect::inflateWithRadii): (WebCore::RoundedIntRect::expandRadii): (WebCore::RoundedIntRect::shrinkRadii):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::pushContentsClip):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): (WebCore::RenderBoxModelObject::paintBorder): (WebCore::RenderBoxModelObject::clipBorderSidePolygon): (WebCore::RenderBoxModelObject::paintBoxShadow):
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::drawBoxSideFromPath):
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint):
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMenuListButtonGradients): (WebCore::RenderThemeMac::paintSliderTrack):
  • rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintMenuListButtonGradients): (WebCore::RenderThemeSafari::paintSliderTrack):
  • rendering/RenderThemeWinCE.cpp: (WebCore::RenderThemeWinCE::paintSearchFieldCancelButton):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
  • rendering/style/BorderData.h:
  • rendering/style/RenderStyle.cpp: (WebCore::calcRadiiFor): (WebCore::calcConstraintScaleFor): (WebCore::RenderStyle::getRoundedBorderFor): (WebCore::RenderStyle::getRoundedInnerBorderWithBorderWidths):
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::setBorderRadius):
12:43 AM Changeset in webkit [76003] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] Fix LoadHTMLStringItem::invoke() after r75966
​https://bugs.webkit.org/show_bug.cgi?id=52614

  • platform/qt/Skipped: http/tests/navigation/go-back-to-error-page.html added until fix.
12:00 AM Changeset in webkit [76002] by rwlbuis@webkit.org
  • 3 edits
    12 adds in trunk

2011-01-17 Rob Buis <​rwlbuis@gmail.com>

Reviewed by Kent Tamura.

Color changes to option elements in a select multiple aren't drawn immediately
​https://bugs.webkit.org/show_bug.cgi?id=49790

Redirect style changes on <option> element to the owner <select> element.

Tests: fast/forms/select-option-background-color-change.html

fast/forms/select-option-color-change.html
fast/forms/select-option-visibility-change.html

  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::setRenderStyle):

Jan 17, 2011:

11:12 PM Changeset in webkit [76001] by morrita@google.com
  • 3 edits in trunk/Source/WebCore

2011-01-17 MORITA Hajime <​morrita@google.com>

Unreviewed, rolling out r75995.
​http://trac.webkit.org/changeset/75995
​https://bugs.webkit.org/show_bug.cgi?id=51914

Causes assertion failures.

  • dom/Element.cpp: (WebCore::Element::shadowRoot): (WebCore::Element::setShadowRoot): (WebCore::Element::removeShadowRoot):
  • dom/ElementRareData.h: (WebCore::ElementRareData::ElementRareData):
11:08 PM Changeset in webkit [76000] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

2011-01-17 MORITA Hajime <​morrita@google.com>

Unreviewed, rolling out r75999.
​http://trac.webkit.org/changeset/75999

  • dom/Element.cpp: (WebCore::Element::removeShadowRoot):
10:52 PM Changeset in webkit [75999] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

2011-01-17 MORITA Hajime <​morrita@google.com>

Unreviewed crash fix, which introduced at r75995

  • dom/Element.cpp: (WebCore::Element::removeShadowRoot):
10:02 PM Changeset in webkit [75998] by mrowe@apple.com
  • 5 edits in tags/Safari-534.15.15

Versioning.

9:54 PM Changeset in webkit [75997] by mrowe@apple.com
  • 1 copy in tags/Safari-534.15.15

New tag.

9:40 PM Changeset in webkit [75996] by commit-queue@webkit.org
  • 2 edits
    8 adds in trunk/LayoutTests

2011-01-17 Steve Lacey <​sjl@chromium.org>

Reviewed by David Levin.

Rebaseline media/video-zoom-controls for chromium.
​https://bugs.webkit.org/show_bug.cgi?id=52415

  • platform/chromium-linux/media/video-zoom-controls-expected.checksum: Added.
  • platform/chromium-linux/media/video-zoom-controls-expected.png: Added.
  • platform/chromium-mac/media/video-zoom-controls-expected.checksum: Added.
  • platform/chromium-mac/media/video-zoom-controls-expected.png: Added.
  • platform/chromium-mac/media/video-zoom-controls-expected.txt: Added.
  • platform/chromium-win/media/video-zoom-controls-expected.checksum: Added.
  • platform/chromium-win/media/video-zoom-controls-expected.png: Added.
  • platform/chromium-win/media/video-zoom-controls-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
8:30 PM Changeset in webkit [75995] by morrita@google.com
  • 3 edits in trunk/Source/WebCore

2011-01-17 MORITA Hajime <​morrita@google.com>

Reviewed by Dimitri Glazkov.

ElementRareData::m_shadowRoot should not be RefPtr.
​https://bugs.webkit.org/show_bug.cgi?id=51914

This change makes m_shadowRoot a raw pointer, as Node::m_parent is.
This change is safe because shadow host pointer is stored as TreeShared::m_parent
which prevents deletion unless set to null.

No test, no behavioral change.

  • dom/Element.cpp: (WebCore::Element::shadowRoot): (WebCore::Element::setShadowRoot): (WebCore::Element::removeShadowRoot):
  • dom/ElementRareData.h: (WebCore::ElementRareData::ElementRareData):
7:49 PM Changeset in webkit [75994] by mjs@apple.com
  • 2 edits in trunk/Source/WebCore

2011-01-17 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Dan Bernstein.

Some WebKit2 layout tests crash due to focus being on a frame in the page cache
​https://bugs.webkit.org/show_bug.cgi?id=52607

No new tests. Existing tests crash in WebKit2 without this fix.


I suspect there are other consequences besides the WebKit2 crash, but I
was unable to identify any for certain.

  • history/CachedFrame.cpp: (WebCore::CachedFrame::CachedFrame): If a frame still has focus when its page goes in the page cache, reset focus to the main frame.
7:15 PM Changeset in webkit [75993] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Not reviewed, test expectations update.
Added TIMEOUT to fast/canvas/canvas-fillPath-pattern-shadow.html

  • platform/chromium-gpu/test_expectations.txt:
7:10 PM Changeset in webkit [75992] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-17 Jarred Nicholls <​jarred@sencha.com>

Reviewed by Csaba Osztrogonác.

REGRESSION(r75709): Return value of fscanf() shouldn't be ignored.
​https://bugs.webkit.org/show_bug.cgi?id=52585

gcc 4.4.4+ has warn_unused_value attribute on fscanf, so we should check
the return value to get around the gcc warning

  • jit/ExecutableAllocatorFixedVMPool.cpp: (JSC::maybeModifyVMPoolSize):
6:10 PM Changeset in webkit [75991] by msaboff@apple.com
  • 5 edits in trunk

2011-01-17 Michael Saboff <​msaboff@apple.com>

Reviewed by Oliver Hunt.

[regexfuzz] Crash running regex with lookahead
​https://bugs.webkit.org/show_bug.cgi?id=52548

Eliminated agressive chaining of backtracks. This code was overwriting
already valid backtrack information.

  • yarr/YarrJIT.cpp: (JSC::Yarr::YarrGenerator::ParenthesesTail::processBacktracks):

2011-01-17 Michael Saboff <​msaboff@apple.com>

Reviewed by Oliver Hunt.

[regexfuzz] Crash running regex with lookahead
​https://bugs.webkit.org/show_bug.cgi?id=52548

New tests from regex fuzzer.

  • fast/regex/parentheses-expected.txt:
  • fast/regex/script-tests/parentheses.js:
6:06 PM Changeset in webkit [75990] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Not reviewed, test expectations update.
Same as previous patch, now for -gpu file.

  • platform/chromium-gpu/test_expectations.txt:
5:55 PM Changeset in webkit [75989] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Not reviewed, test expectations update.
fast/canvas/canvas-fillPath-pattern-shadow.html fails on Win and Linux.

  • platform/chromium/test_expectations.txt:
5:46 PM Changeset in webkit [75988] by Adam Roben
  • 10 edits in trunk

Simplify WKCACFLayerRenderer's API

createRenderer/destroyRenderer are now hidden behind setHostWindow.
WKCACFLayerRendererClient::animationsStarted has been removed, as it
was never called. (The work it was supposed to do was already being
accomplished by WKCACFLayerRenderer::render telling each layer that
animations are starting.)

Fixes <​http://webkit.org/b/52587> WKCACFLayerRenderer is hard to use

Reviewed by Chris Marrin.

Source/WebCore:

  • platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:

(WebCore::MediaPlayerPrivateFullscreenWindow::createWindow): Moved the
call to setHostWindow here from the WM_CREATE handler. The WM_CREATE
handler was causing the Direct3D device to be created, but MSDN says
you shouldn't create a device while handling WM_CREATE. Removed
no-longer-needed call to createRenderer (setHostWindow does this now)
and the never-needed call to setNeedsDisplay (we never draw into the
root layer; this was just creating an unnecessary backing store the
size of the screen!).
(WebCore::MediaPlayerPrivateFullscreenWindow::wndProc): Moved WM_CREATE
code, as described above. Removed call to destroyRenderer when handling
WM_DESTROY; setHostWindow does this now. Fixed up our WM_PAINT handler
to do a synchronous paint and to clear our dirty region, while I was in
here.

  • platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::WKCACFLayerRenderer::~WKCACFLayerRenderer): Changed to call
setHostWindow instead of destroyRenderer; the former calls the latter
if needed.
(WebCore::WKCACFLayerRenderer::setHostWindow): Moved here from the
header file. Destroys our old renderer (i.e., IDirect3DDevice9) if
we're losing our window, or creates a renderer if we're gaining a
window.
(WebCore::WKCACFLayerRenderer::createRenderer): Updated for WKSI function rename.
(WebCore::WKCACFLayerRenderer::destroyRenderer): Changed to clear the
D3D device from our context before releasing the device.

  • platform/graphics/win/WKCACFLayerRenderer.h: Removed

WKCACFLayerRendererClient::animationsStarted. Removed setNeedsDisplay.
Make createRenderer, destroyRenderer, and renderSoon private.

WebKit/win:

Update for WKCACFLayerRenderer changes

  • WebView.cpp:

(WebView::WebViewWndProc): Removed call to layerRendererBecameVisible
when handling WM_SHOWWINDOW. All this did was try to create the
renderer, but it had already been created in setAcceleratedCompositing,
so wasn't needed.
(WebView::setAcceleratedCompositing): Removed call to createRenderer;
setHostWindow does this for us now.

  • WebView.h: Removed animationsStarted and layerRendererBecameVisible.

WebKitLibraries:

Make it possible to both set and clear a wkCACFContext's D3D device

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
5:45 PM Changeset in webkit [75987] by Adam Roben
  • 7 edits in trunk/Source

Paint directly into a GraphicsLayer when using accelerated compositing

Before this patch, we were painting into our normal backing store
HBITMAP, wrapping it in a CGImage, and handing it off to Core
Animation. This had at least two disadvantages:

1) The bitmap could be modified while Core Animation was using it.
2) It introduced extra complexity.

When entering accelerated compositing mode, WebView now creates a
GraphicsLayer to draw into. This GraphicsLayer sits between the root
layer (owned by WKCACFLayerRenderer) and the RenderView's layer. When
WebView invalidates, it just calls setNeedsDisplayInRect on its
GraphicsLayer. When WebView paints, it just tells its
WKCACFLayerRenderer to paint, which will call back to WebView to draw
into the GraphicsLayer if it has a dirty region. This is very similar
to the current implementation of LayerBackedDrawingArea in WebKit2.

Fixes <​http://webkit.org/b/52582> WebView should paint directly into a
GraphicsLayer when in accelerated compositing mode

Reviewed by Simon Fraser and Chris Marrin.

WebCore:

Remove special-cased support for providing content for the root layer

Clients will just have to provide content through the normal
GraphicsLayer channels now!

  • platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): Removed
initialization of m_backingStoreDirty, which has itself been removed.
(WebCore::WKCACFLayerRenderer::setNeedsDisplay): Moved code to schedule
a sync from here to syncCompositingStateSoon. We only need to call
renderSoon if we don't call syncCompositingStateSoon; the latter
function calls the former.
(WebCore::WKCACFLayerRenderer::paint): Removed code to handle
m_backingStoreDirty. We don't want to know anything about clients'
backing stores.
(WebCore::WKCACFLayerRenderer::syncCompositingStateSoon): Added. Code
came from setNeedsDisplay.

  • platform/graphics/win/WKCACFLayerRenderer.h:

Removed setRootContents[AndDisplay], setBackingStoreDirty, and
m_backingStoreDirty. Made paint() public so that clients can force a
synchronous render (e.g., when handling WM_PAINT).

WebKit/win:

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::attachRootGraphicsLayer):
(WebChromeClient::scheduleCompositingLayerSync):
Updated for WebView changes.

  • WebView.cpp:

(WebView::repaint): When using accelerated compositing, just invalidate
our backing layer. This matches the behavior of LayerBackedDrawingArea.
(WebView::deleteBackingStore): Removed accelerated compositing code.
The WKCACFLayerRenderer doesn't need to know about our backing store
anymore; we don't use it at all when in accelerated compositing mode.
(WebView::addToDirtyRegion): When using accelerated compositing, just
invalidate our backing layer.
(WebView::scrollBackingStore): Added an assertion that this isn't
called in accelerated compositing mode.
(WebView::sizeChanged): Update our backing layer's size, too, and
invalidate it.
(WebView::updateBackingStore): Added an assertion that this isn't
called in accelerated compositing mode.
(WebView::paint): If we're in accelerated compositing mode, sync our
compositing state. If we're *still* in accelerated compositing mode,
just tell our WKCACFLayerRenderer to paint and clear our dirty region.
(The later changes in this function are just un-indenting code that
used to be inside an if.)

(WebView::paintIntoBackingStore):
(WebView::paintIntoWindow):
Added assertions that these aren't called in accelerated compositing
mode.

(WebView::WebViewWndProc): Updated WM_XP_THEMECHANGED handling for
removal of setRootLayerNeedsDisplay.
(WebView::setRootChildLayer): Changed to take a GraphicsLayer. We now
set the layer as a child of our own backing layer.
(WebView::scheduleCompositingLayerSync): Just call through to
WKCACFLayerRenderer.
(WebView::setAcceleratedCompositing): Create our backing layer and set
it as the child of WKCACFLayerRenderer's root layer.
(WebView::notifyAnimationStarted): Added. We never expect this
GraphicsLayerClient override to be called, as we don't use animations
on our backing layer.
(WebView::notifySyncRequired): Added. Just schedule a sync.
(WebView::paintContents): Added. Just clip and paint!

(WebView::showDebugBorders):
(WebView::showRepaintCounter):
Added. These just call through to Settings.

(WebView::syncCompositingState): Changed to first update layout, then
sync state for our backing layer, then sync WebCore's state. This
matches LayerBackedDrawingArea.

  • WebView.h: WebView now implements the GraphicsLayerClient interface.

Removed setRootLayerNeedsDisplay; it's been replaced by calling
setNeedsDisplay on our backing layer and calling
syncCompositingStateSoon on WKCACFLayerRenderer as needed. Removed
updateRootLayerContents; that function was used to pass our backing
store to Core Animation, which we no longer do. Added m_backingLayer.

5:45 PM Changeset in webkit [75986] by Adam Roben
  • 2 edits in trunk/Source/WebCore

Remove contexts from WKCACFContextFlusher before destroying them

We aren't really using WKCACFContextFlusher for anything useful at the
moment, but that will probably change in the near future.

I couldn't come up with a way to test this because it isn't possible to
resize a window in DumpRenderTree.

Fixes <​http://webkit.org/b/52573> REGRESSION (r75262): Crash beneath
WKCACFContextFlusher::flushAllContexts when resizing window on page
that uses accelerated compositing

Reviewed by Simon Fraser.

  • platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::WKCACFLayerRenderer::~WKCACFLayerRenderer): Remove our
context from WKCACFContextFlusher. (This code was erroneously removed
from WKCACFLayerRenderer::destroyRenderer in r75262. This is a more
sensible place for it.)

5:44 PM Changeset in webkit [75985] by Adam Roben
  • 6 edits in trunk

Don't access the CACFLayerRef's sublayers directly from PlatformCALayer

There might be a secret extra sublayer (the tile parent layer) that
PlatformCALayer doesn't know about. When PlatformCALayer would
encounter this, it would try to use the tile parent layer's
PlatformCALayer wrapper, which was null, and then would crash. We now
ask PlatformCALayerWinInternal for the sublayer list, since that class
knows about the tile parent layer and can exclude it from the sublayer
list.

Covered by compositing/tiling/huge-layer-resize.html.

Fixes <​http://webkit.org/b/52597> Crash beneath
PlatformCALayer::adoptSublayers when switching out of tiling mode
(null-dereference of a PlatformCALayer)

Reviewed by Darin Adler and Chris Marrin.

LayoutTests:

Make compositing/tiling/huge-layer-resize.html faster, more reliable,
and more crashy (when there's a WebKit bug)

This test was trying to cause a layout/paint to happen by returning to
the event loop for a certain amount of time via setTimeout. But this
didn't always result in a layout/paint (at least on Windows). We now
force the layout/paint explicitly, which also lets us speed up the test
by removing the setTimeouts.

  • compositing/tiling/huge-layer-resize.html:

(testOnLoad): Changed to use recordLayerTree, which forces a
layout/paint, instead of hoping that setTimeout will do the trick.
(recordLayerTree): Forces a layout/paint, then dumps the layer tree.

Source/WebCore:

  • platform/graphics/ca/win/PlatformCALayerWin.cpp:

(PlatformCALayer::adoptSublayers):
(printLayer):
Changed to use PlatformCALayerWinInternal::getSublayers.

  • platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:

(PlatformCALayerWinInternal::getSublayers): Added. Retrieves the list
of PlatformCALayers that represent our sublayers. Significantly, this
code knows about the tile parent layer and can thus exclude it.

  • platform/graphics/ca/win/PlatformCALayerWinInternal.h: Added

getSublayers.

5:13 PM Changeset in webkit [75984] by wsiegrist@apple.com
  • 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg

2011-01-17 William Siegrist <​wsiegrist@apple.com>

Explicitly set mode during file upload to ensure web server can read the files.

5:10 PM Changeset in webkit [75983] by thakis@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-01-17 Nico Weber <​thakis@chromium.org>

Unreviewed.

Roll chromium DEPS forward to pick up the skia roll to skia r692.
​https://bugs.webkit.org/show_bug.cgi?id=52600

  • DEPS:
4:44 PM Changeset in webkit [75982] by commit-queue@webkit.org
  • 5 edits in trunk/Source

2011-01-17 Naoki Takano <​takano.naoki@gmail.com>

Reviewed by Kent Tamura.

[Chromium] Fix popup menu re-positioning when the menu is opened upward, above the corresponding form field.
​https://bugs.webkit.org/show_bug.cgi?id=51382
​http://crbug.com/60427

Calculate correct location of popup window whenever the items in the window change.

No new tests, because this fix is for Chromium project and hard to test only in WebKit project

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::layoutAndCalculateWidgetRect): New Function to layout and calculate popup widget rect. (WebCore::PopupContainer::showPopup): Move widgetRect calculation logic to calculateWidgetRect(). (WebCore::PopupContainer::refresh): Add parameter focusRect to take the location and the size of focus text input field to calculate correct popup window location.
  • platform/chromium/PopupMenuChromium.h: Append new input parameter for refresh().

2011-01-17 Naoki Takano <​takano.naoki@gmail.com>

Reviewed by Kent Tamura.

[Chromium] Fix popup menu re-positioning when the menu is opened upward, above the corresponding form field.
​https://bugs.webkit.org/show_bug.cgi?id=51382
​http://crbug.com/60427

Calculate correct location of popup window whenever the items in the window change.

No new tests, because this fix is for Chromium project and hard to test only in WebKit project

  • WebKit/chromium/src/WebViewImpl.cpp: (WebKit::WebViewImpl::refreshAutoFillPopup): Change the logic in refreshAutoFilPopup() to check both the location and the size of popup window.
4:38 PM Changeset in webkit [75981] by jhoneycutt@apple.com
  • 2 edits in trunk/Source/WebKit2

Windows build fix. Unreviewed.

  • Shared/PrintInfo.cpp:

Use #include, not #import.

4:32 PM Changeset in webkit [75980] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Actually wrote a FIXME promised for a review comment.

  • UIProcess/API/mac/WKView.mm: (-[WKView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
4:27 PM Changeset in webkit [75979] by ap@apple.com
  • 15 edits
    3 adds in trunk/Source/WebKit2

Reviewed by Anders Carlsson and Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=52595
Make basic printing work in WebKit2

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetShouldPrintBackgrounds): (WKPreferencesGetShouldPrintBackgrounds):
  • UIProcess/API/C/WKPreferences.h: Implement a preference for printing backgrounds.
  • Shared/PrintInfo.cpp: Added. (WebKit::PrintInfo::encode): (WebKit::PrintInfo::decode):
  • Shared/PrintInfo.h: Added.
  • Shared/mac/PrintInfoMac.mm: Added. (WebKit::PrintInfo::PrintInfo): A new class for passing page setup information down to the web process.
  • WebKit2.xcodeproj/project.pbxproj:
  • GNUmakefile.am:
  • WebKit2.pro:
  • win/WebKit2.vcproj: Added PrintInfo.
  • Scripts/webkit2/messages.py: Added PrintInfo.h to a list of structs.
  • UIProcess/API/mac/WKView.mm: (WKViewData): Cache page count and geometry. (WebFrameWrapper): Added a wrapper class for adding a WebFrameProxy to an NSDictionary. (-[WKView drawRect:]): Added logging. (setFrameBeingPrinted): Store a frame into NSPrintOperation's NSPrintInfo, so that all methods invoked for this operation would know what's being printed. (frameBeingPrinted): Retrieve this data. (-[WKView printOperationWithPrintInfo:forFrame:]): Create a print operation that's appropriate for the frame. (-[WKView knowsPageRange:]): Ask the web process. (-[WKView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]): Take over printing, because I couldn't make drawRect: work correctly with WebKit custom fit to page implementation. (-[WKView _provideTotalScaleFactorForPrintOperation:]): Help AppKit clip correctly. (-[WKView rectForPage:]): Return a pre-calculated rect.
  • UIProcess/WebPageProxy.h: Added m_isInPrintingMode to track whether the web page is in printing mode. The UI process controls that.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::WebPageProxy): Initialize m_isInPrintingMode. (WebKit::WebPageProxy::beginPrinting): Change printing mode in web process if the value changes. (WebKit::WebPageProxy::endPrinting): Ditto. (WebKit::WebPageProxy::computePagesForPrinting): Ask the web process about output page geometry. (WebKit::WebPageProxy::drawRectToPDF): Ask the web process about printed page data.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::close): Delete m_printContext while there is still a Frame pointer. (WebKit::WebPage::updatePreferences): Pass through ShouldPrintBackgrounds. (WebKit::WebPage::beginPrinting): Switch into printing mode (or update parameters if we're already in printing mode). (WebKit::WebPage::endPrinting): Delete m_printContext, implicitly calling end(). (WebKit::WebPage::computePagesForPrinting): Make sure that we're in printing mode, and copmute page rects. (WebKit::WebPage::drawRectToPDF): Added a CG specific function to create a PDF document out of a page rect. It should really work for onscreen content, but we only need it for printing.
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in: Added BeginPrinting, EndPrinting, ComputePagesForPrinting and DrawRectToPDF.
3:59 PM Changeset in webkit [75978] by mrowe@apple.com
  • 5 edits in tags/Safari-534.15.14

Versioning.

3:31 PM Changeset in webkit [75977] by mrowe@apple.com
  • 1 copy in tags/Safari-534.15.14

New tag.

3:15 PM Changeset in webkit [75976] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the 32-bit build.

  • WebCore.exp.in:
3:14 PM Changeset in webkit [75975] by mitz@apple.com
  • 4 edits
    2 adds in trunk

Use of invalid hash map key in CSSFontFaceSource::getFontData() with 0-sized remote font
​https://bugs.webkit.org/show_bug.cgi?id=52598

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/css/font-face-zero-hash-key.html

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData): Add 1 to the font size to avoid a 0 hash key.

  • css/CSSSegmentedFontFace.cpp:

(WebCore::CSSSegmentedFontFace::getFontData): Ditto.

LayoutTests:

  • fast/css/font-face-zero-hash-key-expected.txt: Added.
  • fast/css/font-face-zero-hash-key.html: Added.
3:03 PM Changeset in webkit [75974] by ddkilzer@apple.com
  • 4 edits in trunk/Source

<​http://webkit.org/b/52596> Add missing DOMDocument/DOMDocumentFragment headers to Xcode project

Reviewed by Dan Bernstein.

WebCore:

This fixes two issues:

Add missing DOMDocumentFragmentPrivate.h and
DOMDocumentPrivate.h files to the project. These files were
never added to the the project although their *Internal.h
counterparts were added in r16548 and r17390.

Add missing DOMDocumentFragmentInternal.h to the Headers
section. It was moved from Headers to "Copy Generated Headers"
in r31045, but it should have an entry in both sections.

  • WebCore.xcodeproj/project.pbxproj:

WebKit/mac:

  • MigrateHeaders.make: Copy DOMDocumentFragmentPrivate.h and

DOMDocumentPrivate.h to the PrivateHeaders directory.

2:54 PM Changeset in webkit [75973] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

2011-01-17 Helder Correia <​helder@sencha.com>

Reviewed by Andreas Kling.

[Qt] Incorrect shadow alpha with pattern fillStyle
​https://bugs.webkit.org/show_bug.cgi?id=52559

The shadow color opacity needs to be set on the shadow painter.
This is related to bug 52556.

  • fast/canvas/canvas-fillPath-pattern-shadow-expected.txt: Added.
  • fast/canvas/canvas-fillPath-pattern-shadow.html: Added.
  • fast/canvas/script-tests/canvas-fillPath-pattern-shadow.js: Added.

2011-01-17 Helder Correia <​helder@sencha.com>

Reviewed by Andreas Kling.

[Qt] Incorrect shadow alpha with pattern fillStyle
​https://bugs.webkit.org/show_bug.cgi?id=52559

The shadow color opacity needs to be set on the shadow painter.
This is related to bug 52556.

Test: fast/canvas/canvas-fillPath-pattern-shadow.html

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillPath):
2:48 PM Changeset in webkit [75972] by Martin Robinson
  • 2 edits in trunk/Source/WebCore

2011-01-17 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Andreas Kling.

[GTK] Port a crash fix from libsoup upstream to the libsoup cache code
​https://bugs.webkit.org/show_bug.cgi?id=52586

No new tests. This is just a merge from upstream.

  • platform/network/soup/cache/soup-http-input-stream.c: (webkit_soup_http_input_stream_got_chunk): Properly handle unsigned numbers.
1:38 PM Changeset in webkit [75971] by tonyg@chromium.org
  • 23 edits in trunk

2011-01-17 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Alexey Proskuryakov.

Fix some headers with missing or misspelled #ifndef guards
​https://bugs.webkit.org/show_bug.cgi?id=52545

  • wtf/RefPtrHashMap.h:

2011-01-17 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Alexey Proskuryakov.

Fix some headers with missing or misspelled #ifndef guards
​https://bugs.webkit.org/show_bug.cgi?id=52545

No new tests because no new functionality.

  • ForwardingHeaders/runtime/InitializeThreading.h:
  • editing/SmartReplace.h:
  • loader/CrossOriginAccessControl.h:
  • loader/NetscapePlugInStreamLoader.h:
  • platform/chromium/ClipboardUtilitiesChromium.h:
  • platform/graphics/cairo/DrawErrorUnderline.h:
  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
  • platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
  • platform/graphics/cg/PDFDocumentImage.h:
  • platform/win/WebCoreTextRenderer.h:

2011-01-17 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Alexey Proskuryakov.

Fix some headers with missing or misspelled #ifndef guards
​https://bugs.webkit.org/show_bug.cgi?id=52545

  • WebKitStatistics.h:

2011-01-17 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Alexey Proskuryakov.

Fix some headers with missing or misspelled #ifndef guards
​https://bugs.webkit.org/show_bug.cgi?id=52545

  • Shared/UserMessageCoders.h:
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
  • WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:
  • WebProcess/WebProcessMain.h:

2011-01-17 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Alexey Proskuryakov.

Fix some headers with missing or misspelled #ifndef guards
​https://bugs.webkit.org/show_bug.cgi?id=52545

  • DumpRenderTree/chromium/TestEventPrinter.h:
  • DumpRenderTree/chromium/WebPreferences.h:
1:16 PM Changeset in webkit [75970] by ddkilzer@apple.com
  • 2 edits in trunk/LayoutTests

2011-01-17 David Kilzer <​ddkilzer@apple.com>

<​http://webkit.org/b/52524> fast/dom/Range/range-clone-contents.html fails only on Windows

Reviewed by Alexey Proskuryakov.

  • platform/win/Skipped: Removed fast/dom/Range/range-clone-contents.html. It appears the Windows buildbots need a clean build.
12:59 PM Changeset in webkit [75969] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-17 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: follow-up fix for r52574: do not reuse clear() for navigation.

  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.clear): (WebInspector.NetworkPanel.prototype.mainResourceChanged):
12:53 PM Changeset in webkit [75968] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Build fix.

  • Platform/Logging.cpp:
12:47 PM Changeset in webkit [75967] by sergio@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-17 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Martin Robinson.

[Gtk] No need to content sniff 304 Not Modified responses
​https://bugs.webkit.org/show_bug.cgi?id=52570

Makes no sense to wait for the outcome of content sniffing when WebCore
is validating resources. If we get a 304 Not Modified it means that we can
safely use the cached version of the resource we're asking for.

No new tests because it does not change functionality, it just
calls didReceiveResponse sooner for 304 Not Modified responses.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::gotHeadersCallback):
12:22 PM Changeset in webkit [75966] by jberlin@webkit.org
  • 11 edits
    4 adds in trunk

REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
navigating back to an unreachable URL
​https://bugs.webkit.org/show_bug.cgi?id=52388

Reviewed by Anders Carlsson.

Source/WebCore:

Test: http/tests/navigation/go-back-to-error-page.html

  • history/PageCache.cpp:

(WebCore::PageCache::canCachePageContainingThisFrame):
Do not cache any error pages (which we can recognize as having substitute data and/or an
unreachableURL).

Tools:

Add a third parameter (unreachableURL) to queueLoadHTMLString.

  • DumpRenderTree/LayoutTestController.cpp:

(queueLoadHTMLStringCallback):
(LayoutTestController::queueLoadHTMLString):
(LayoutTestController::queueLoadAlternateHTMLString):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/WorkQueueItem.h:

(LoadHTMLStringItem::LoadHTMLStringItem):

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(WorkItemLoadHTMLString::WorkItemLoadHTMLString):
(WorkItemLoadHTMLString::run):
(LayoutTestController::queueLoadHTMLString):

  • DumpRenderTree/gtk/WorkQueueItemGtk.cpp:

(LoadHTMLStringItem::invoke):

  • DumpRenderTree/mac/WorkQueueItemMac.mm:

(LoadHTMLStringItem::invoke):

  • DumpRenderTree/win/WorkQueueItemWin.cpp:

(LoadHTMLStringItem::invoke):

LayoutTests:

Add a test that loads an alternate HTML String for an "unreachable" URL, loads another
page, and then goes back to the "unreachable" URL, which is now reachable.

This tests two things:
1) No assertion failure when going back to an unreachable URL.
2) There is no page cached for the unreachable URL.

  • http/tests/navigation/go-back-to-error-page-expected.txt: Added.
  • http/tests/navigation/go-back-to-error-page.html: Added.
  • http/tests/navigation/resources/page-to-go-back-from.html: Added.
  • http/tests/navigation/resources/page-treated-as-unreachable.html: Added.
12:16 PM Changeset in webkit [75965] by ap@apple.com
  • 3 edits in trunk/Source/WebKit2

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=52592
Add a logging channel for WKView

  • Platform/Logging.cpp:
  • Platform/Logging.h:
12:16 PM Changeset in webkit [75964] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-17 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: fixing typo in r75952.

  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkDataGridNode.prototype._refreshNameCell):
12:12 PM Changeset in webkit [75963] by enrica@apple.com
  • 6 edits in trunk/Source

Drag and drop support: refactoring of image from link and image from selection
​https://bugs.webkit.org/show_bug.cgi?id=52496

Reviewed by Alexey Proskuryakov.

Source/WebCore:

This work cleans up the Mac code and makes it more similar to the Windows implementation,
avoiding the use of an NSView when the FrameView can be used.
The refactoring is a necessary step towards the complete support of drag and drop
in WebKit2.

  • page/mac/FrameMac.mm:

(WebCore::Frame::imageFromRect): Modified to use FrameView instead of NSView
to generate the image for drag.

Source/WebKit/mac:

This work cleans up the Mac code and makes it more similar to the Windows implementation,
avoiding the use of an NSView when the FrameView can be used.
The refactoring is a necessary step towards the complete support of drag and drop
in WebKit2.

  • WebCoreSupport/WebDragClient.mm:

(WebDragClient::createDragImageForLink): Added.

  • WebView/WebHTMLView.mm: Removed dragImageFromLink and dragImageFromURL.
  • WebView/WebHTMLViewPrivate.h: Removed dragImageFromLink and dragImageFromURL.
12:01 PM Changeset in webkit [75962] by andersca@apple.com
  • 6 edits
    3 adds in trunk/Source/WebKit2

2011-01-17 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Factor bitmap context drawing code out into a shared function
​https://bugs.webkit.org/show_bug.cgi?id=52589

  • Platform/cg/CGUtilities.h: Added.
  • Platform/cg/CGUtilities.cpp: Added. (WebKit::paintBitmapContext): New function that will paint a bitmap context into a CGContext.
  • Shared/cg/ShareableBitmapCG.cpp: (WebKit::ShareableBitmap::paint): Use paintBitmapContext.
  • UIProcess/mac/BackingStoreMac.mm: (WebKit::BackingStore::paint): (WebKit::BackingStore::scroll): Use paintBitmapContext.
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • win/WebKit2Common.vsprops: Add CGUtilities.{cpp|h}.
11:50 AM Changeset in webkit [75961] by mitz@apple.com
  • 25 edits in trunk

Update xcodeproj svn:ignore to include xcuserdata.

Rubber-stamped by Mark Rowe.

Examples:

  • NetscapeCocoaPlugin/NetscapeCocoaPlugin.xcodeproj: Modified property svn:ignore.
  • NetscapeCoreAnimationMoviePlugin/NetscapeCoreAnimationMoviePlugin.xcodeproj: Modified property svn:ignore.
  • NetscapeCoreAnimationPlugin/NetscapeCoreAnimationPlugin.xcodeproj: Modified property svn:ignore.
  • NetscapeInputMethodPlugin/NetscapeInputMethodPlugin.xcodeproj: Modified property svn:ignore.

Source/JavaScriptCore:

Source/JavaScriptGlue:

  • JavaScriptGlue.xcodeproj: Modified property svn:ignore.

Source/ThirdParty/ANGLE:

  • ANGLE.xcodeproj: Modified property svn:ignore.
  • src/build_angle.xcodeproj: Modified property svn:ignore.

Source/WebCore:

  • WebCore.xcodeproj: Modified property svn:ignore.
  • manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj: Modified property svn:ignore.

Source/WebKit:

  • WebKit.xcodeproj: Modified property svn:ignore.

Source/WebKit2:

  • WebKit2.xcodeproj: Modified property svn:ignore.

Tools:

  • DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
  • MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
  • TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
  • WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
  • WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
11:48 AM Changeset in webkit [75960] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Fixing a typo from a bad merge.

  • UIProcess/API/mac/WKView.mm: (-[WKView canChangeFrameLayout:]):
11:43 AM Changeset in webkit [75959] by ap@apple.com
  • 3 edits in trunk/Source/WebKit2

Reviewed by John Sullivan.

​https://bugs.webkit.org/show_bug.cgi?id=52590
Should pass a frame into -[WKView canPrintHeadersAndFooters]

  • UIProcess/API/mac/WKView.h:
  • UIProcess/API/mac/WKView.mm: (-[WKView canChangeFrameLayout:]): Also, renamed the method to canChangeFrameLayout.
11:36 AM Changeset in webkit [75958] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Leopard build fix.

  • page/PrintContext.cpp: GCC complained about shortening a double value to float.
11:27 AM WebKit Team edited by thakis@chromium.org
(diff)
10:47 AM Changeset in webkit [75957] by mrowe@apple.com
  • 3 deletes in trunk

Remove a few more empty directories that I missed.

10:41 AM Changeset in webkit [75956] by mrowe@apple.com
  • 87 deletes in trunk

Remove a large number of empty directories.

10:31 AM Changeset in webkit [75955] by ap@apple.com
  • 6 edits in trunk/Source

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=52495

No change in behavior, so no tests.

  • WebCore.exp.in: Export additional methods, as I'm going to use more code from PrintContext.
  • page/PrintContext.cpp: (WebCore::PrintContext::~PrintContext): No need to clear m_pageRects, the object is being destroyed already. (WebCore::PrintContext::pageCount): Changed page count from int to size_t. (WebCore::PrintContext::pageRect): Ditto. (WebCore::PrintContext::computePageRects): Pass allowHorizontalTiling as an argument. PrintContext already has code to calculate scale factor, so it makes sense to make methods that contain it universal (allowHorizontalTiling is always true for Safari). Round page height to an integer, because Mac code does that, and because page height is treated as integer almost everywhere else in code. (WebCore::PrintContext::begin): Allow calling this function multiple times. There is no need to return to screen mode if e.g. "print backgounds" option changes. (WebCore::PrintContext::computeAutomaticScaleFactor): Expose scale factor computation, so that clients don't have to copy it. (WebCore::PrintContext::spoolRect): Add a way to spool a precomputed rect - handy if a request comes from code that doesn't have page number. (WebCore::PrintContext::pageNumberForElement): Page number int -> size_t.
  • page/PrintContext.h: Added comments and FIXMEs. PrintContext needs cleanup, but that depends on deciding how it really needs to work (e.g. whether computePageRects() should cause relayout).
10:25 AM Changeset in webkit [75954] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-17 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: skip flaky inspector test (will look at it tomorrow).

  • platform/mac-leopard/Skipped:
10:21 AM Changeset in webkit [75953] by andersca@apple.com
  • 7 edits in trunk/Source/WebKit2

2011-01-17 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Implement scrolling support
​https://bugs.webkit.org/show_bug.cgi?id=52502

  • Shared/UpdateInfo.cpp: (WebKit::UpdateInfo::encode): (WebKit::UpdateInfo::decode):
  • Shared/UpdateInfo.h: Add scrollRect and scrollDelta member variables.
  • UIProcess/BackingStore.h: Add scroll member function.
  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::incorporateUpdate): Repaint the scroll rect. Force a display of the view when the update info contains a scroll rect.
  • UIProcess/mac/BackingStoreMac.mm: (WebKit::BackingStore::incorporateUpdate): Call scroll.

(WebKit::BackingStore::scroll):
Paint the backing store into itself.

  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::display): Pass the scroll information in the update info.
9:51 AM Changeset in webkit [75952] by pfeldman@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-01-17 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: unify image data source assignment, add image url
to the image view properties list.
​https://bugs.webkit.org/show_bug.cgi?id=52584

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ImageView.js: (WebInspector.ImageView.prototype._createContentIfNeeded.onImageLoad): (WebInspector.ImageView.prototype._createContentIfNeeded):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkDataGridNode.prototype._refreshNameCell):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype.populateImageSource): (WebInspector.Resource.prototype._contentURL):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.FrameResourceTreeElement.prototype.onattach):
9:28 AM Changeset in webkit [75951] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit

Fix up the make build on Macs

Rubberstamped by Adam Roben.

  • Makefile: Point to the correct Makefile.shared
9:10 AM Changeset in webkit [75950] by caseq@chromium.org
  • 6 edits in trunk

2011-01-17 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Extensions API] webInspector.resources.onFinished is not fired for redirected resources
Make resource start/finish hanlding more consistent.
​https://bugs.webkit.org/show_bug.cgi?id=52452

  • inspector/front-end/AuditLauncherView.js: Ignore WebSocket resources when displaying progress indicator (WebInspector.AuditLauncherView.prototype._resetResourceCount): (WebInspector.AuditLauncherView.prototype.resourceStarted): (WebInspector.AuditLauncherView.prototype.resourceFinished):
  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager): Factor out resource start/finish logic to _startResource()/_finishResource() (WebInspector.NetworkManager.prototype.identifierForInitialRequest): (WebInspector.NetworkManager.prototype.willSendRequest): (WebInspector.NetworkManager.prototype.markResourceAsCached): (WebInspector.NetworkManager.prototype.didReceiveResponse): (WebInspector.NetworkManager.prototype.didReceiveContentLength): (WebInspector.NetworkManager.prototype.didFinishLoading): (WebInspector.NetworkManager.prototype.didFailLoading): (WebInspector.NetworkManager.prototype.didLoadResourceFromMemoryCache): (WebInspector.NetworkManager.prototype.didCreateWebSocket): (WebInspector.NetworkManager.prototype.willSendWebSocketHandshakeRequest): (WebInspector.NetworkManager.prototype.didReceiveWebSocketHandshakeResponse): (WebInspector.NetworkManager.prototype.didCloseWebSocket): (WebInspector.NetworkManager.prototype._appendRedirect): (WebInspector.NetworkManager.prototype._startResource): (WebInspector.NetworkManager.prototype._finishResource):

2011-01-17 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Extensions API] webInspector.resources.onFinished is not fired for redirected resources
Added test for finished event being sent for redirected resources.
​https://bugs.webkit.org/show_bug.cgi?id=52452

  • http/tests/inspector/extensions-resources-redirect-expected.txt:
  • http/tests/inspector/extensions-resources-redirect.html:
8:42 AM Changeset in webkit [75949] by pfeldman@chromium.org
  • 10 edits in trunk/Source/WebCore

2011-01-17 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: restore dom and network state upon frontend reuse.
​https://bugs.webkit.org/show_bug.cgi?id=52574

  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::restoreInspectorStateFromCookie): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::pushDataCollectedOffline): (WebCore::InspectorController::didCommitLoad):
  • inspector/InspectorController.h:
  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager.prototype.reset):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.clear): (WebInspector.NetworkPanel.prototype.mainResourceChanged):
  • inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel): (WebInspector.ResourceTreeModel.prototype.reloadCachedResources):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.clear):
  • inspector/front-end/inspector.js: (WebInspector.frontendReused):
8:38 AM Changeset in webkit [75948] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Unreviewed fix after r75908.

Move WebKit into Source
​https://bugs.webkit.org/show_bug.cgi?id=52530

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
8:33 AM Changeset in webkit [75947] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-17 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: first timeline-network-resource flakiness.

  • inspector/timeline-network-resource.html:
8:19 AM Changeset in webkit [75946] by caseq@chromium.org
  • 4 edits in trunk/Source/WebKit2

2011-01-17 Andrey Kosyakov <​caseq@chromium.org>

Unreviewed. Fixed malformed reference to WebKitVSPropsRedirectionDir that broke win build.

  • win/WebKit2.vcproj:
  • win/WebKit2GeneratedCommon.vsprops:
  • win/WebKit2WebProcess.vcproj:
8:18 AM Changeset in webkit [75945] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Unreviewed buildfix after r75944.

  • WebCore.pro:
8:00 AM Changeset in webkit [75944] by commit-queue@webkit.org
  • 15 edits
    2 adds in trunk/Source

2011-01-17 Yi Shen <​yi.4.shen@nokia.com>

Reviewed by Andreas Kling.

[Qt] Extend the Platform Plugin to support full screen video handler
​https://bugs.webkit.org/show_bug.cgi?id=51249

Make MediaPlayerPrivateQt support a fullscreen player.

No new tests because LayoutTests/media/media-fullscreen-inline.html already exists.
However, this test failed for Qt (QtMediaPlayer) due to durationchange event getting fired twice.
So, still skip it for Qt.

  • WebCore.pro:
  • features.pri:
  • platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt): (WebCore::MediaPlayerPrivateQt::removeVideoItem): (WebCore::MediaPlayerPrivateQt::restoreVideoItem):
  • platform/graphics/qt/MediaPlayerPrivateQt.h: (WebCore::MediaPlayerPrivateQt::supportsFullscreen): (WebCore::MediaPlayerPrivateQt::mediaPlayer):

2011-01-17 Yi Shen <​yi.4.shen@nokia.com>

Reviewed by Andreas Kling.

[Qt] Extend the Platform Plugin to support full screen video handler
​https://bugs.webkit.org/show_bug.cgi?id=51249

Add a new webkit platform plugin interface to support full screen video handler.

  • Api/qwebkitplatformplugin.h: (QWebFullScreenVideoHandler::QWebFullScreenVideoHandler): (QWebFullScreenVideoHandler::~QWebFullScreenVideoHandler):
  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::ChromeClientQt): (WebCore::ChromeClientQt::~ChromeClientQt): (WebCore::ChromeClientQt::fullScreenVideo): (WebCore::ChromeClientQt::supportsFullscreenForNode): (WebCore::ChromeClientQt::requiresFullscreenForVideoPlayback): (WebCore::ChromeClientQt::enterFullscreenForNode): (WebCore::ChromeClientQt::exitFullscreenForNode):
  • WebCoreSupport/ChromeClientQt.h:
  • WebCoreSupport/FullScreenVideoQt.cpp: Added. (WebCore::FullScreenVideoQt::FullScreenVideoQt): (WebCore::FullScreenVideoQt::~FullScreenVideoQt): (WebCore::FullScreenVideoQt::enterFullScreenForNode): (WebCore::FullScreenVideoQt::exitFullScreenForNode): (WebCore::FullScreenVideoQt::aboutToClose): (WebCore::FullScreenVideoQt::mediaPlayer): (WebCore::FullScreenVideoQt::mediaPlayerForNode): (WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback):
  • WebCoreSupport/FullScreenVideoQt.h: Added. (WebCore::FullScreenVideoQt::isValid):
  • WebCoreSupport/QtPlatformPlugin.cpp: (WebCore::QtPlatformPlugin::createFullScreenVideoHandler):
  • WebCoreSupport/QtPlatformPlugin.h:
  • examples/platformplugin/WebPlugin.cpp: (FullScreenVideoWidget::FullScreenVideoWidget): (FullScreenVideoWidget::event): (FullScreenVideoWidget::keyPressEvent): (FullScreenVideoHandler::FullScreenVideoHandler): (FullScreenVideoHandler::~FullScreenVideoHandler): (FullScreenVideoHandler::requiresFullScreenForVideoPlayback): (FullScreenVideoHandler::enterFullScreen): (FullScreenVideoHandler::exitFullScreen): (WebPlugin::supportsExtension): (WebPlugin::createExtension):
  • examples/platformplugin/WebPlugin.h: (FullScreenVideoWidget::~FullScreenVideoWidget):
  • examples/platformplugin/platformplugin.pro:
  • examples/platformplugin/qwebkitplatformplugin.h: (QWebFullScreenVideoHandler::QWebFullScreenVideoHandler): (QWebFullScreenVideoHandler::~QWebFullScreenVideoHandler):
7:50 AM Changeset in webkit [75943] by podivilov@chromium.org
  • 5 edits in trunk/LayoutTests

2011-01-17 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: fix flaky debugger tests.
​https://bugs.webkit.org/show_bug.cgi?id=51320

  • http/tests/inspector/debugger-test2.js: (initialize_DebuggerTest.InspectorTest.setBreakpoint):
  • inspector/debugger-breakpoints-not-activated-on-reload.html:
  • inspector/debugger-pause-on-breakpoint-expected.txt:
  • inspector/debugger-pause-on-breakpoint.html:
7:42 AM Changeset in webkit [75942] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Unreviewed.

Remove accidentally committed debug printing after r75908.

  • Scripts/webkitdirs.pm:
7:38 AM Changeset in webkit [75941] by Csaba Osztrogonác
  • 280 edits
    556 adds in trunk/LayoutTests

Unreviewed.

Add Qt specific expected results for passing CSS tests.
Compared to Mac png files and Mac expected files.

  • platform/qt/Skipped: Unskip passing tests.
  • platform/qt/css1/[...]: Added.
  • platform/qt/css2.1/[...]: Added.
  • platform/qt/css3/[...]: Added.
6:59 AM Changeset in webkit [75940] by rik@webkit.org
  • 6 edits in trunk

2011-01-17 Anthony Ricaud <​rik@webkit.org>

Reviewed by Kent Tamura.

[HTML5] Revert display:none on datalist
​https://bugs.webkit.org/show_bug.cgi?id=52214

  • fast/forms/datalist-expected.txt:
  • fast/forms/datalist-nonoption-child-expected.txt:
  • fast/forms/datalist.html:

2011-01-17 Anthony Ricaud <​rik@webkit.org>

Reviewed by Kent Tamura.

[HTML5] Revert display:none on datalist
​https://bugs.webkit.org/show_bug.cgi?id=52214

  • css/html.css:
6:31 AM Changeset in webkit [75939] by pfeldman@chromium.org
  • 13 edits in trunk/Source

2011-01-17 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: simplify debugger enabling routine.
​https://bugs.webkit.org/show_bug.cgi?id=52472

  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::restoreDebugger): (WebCore::InspectorController::showAndEnableDebugger): (WebCore::InspectorController::enableDebugger):
  • inspector/InspectorController.h:
  • inspector/front-end/DebuggerModel.js:
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.show): (WebInspector.ScriptsPanel.prototype._toggleDebugging):

2011-01-17 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: simplify debugger enabling routine.
​https://bugs.webkit.org/show_bug.cgi?id=52472

2011-01-17 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: simplify debugger enabling routine.
​https://bugs.webkit.org/show_bug.cgi?id=52472

  • WebInspector.cpp: (WebInspector::toggleDebuggingJavaScript):

2011-01-17 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: simplify debugger enabling routine.
​https://bugs.webkit.org/show_bug.cgi?id=52472

  • WebProcess/WebPage/WebInspector.cpp: (WebKit::WebInspector::startJavaScriptDebugging):
6:25 AM Changeset in webkit [75938] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-01-17 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Chromium: updated DevTools tests.

  • src/js/Tests.js: (.TestSuite.prototype._waitForScriptPause): (.TestSuite.prototype._waitUntilScriptsAreParsed.waitForAllScripts): (.TestSuite.prototype._waitUntilScriptsAreParsed):
6:13 AM Changeset in webkit [75937] by podivilov@chromium.org
  • 9 edits in trunk

2011-01-17 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: refactoring: encapsulate lazy initialization of SourceFrame.
​https://bugs.webkit.org/show_bug.cgi?id=51738

  • http/tests/inspector/debugger-test2.js: (initialize_DebuggerTest.InspectorTest.showScriptSource): (initialize_DebuggerTest.InspectorTest._showScriptSource):
  • inspector/debugger-pause-in-eval-script-expected.txt:
  • inspector/debugger-pause-in-eval-script.html:

2011-01-17 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: refactoring: encapsulate lazy initialization of SourceFrame.
​https://bugs.webkit.org/show_bug.cgi?id=51738

Extract content loading logic from SourceView and ScriptView to ContentProvider implementations.
Pass ContentProvider in SourceFrame constructor to allow SourceFrame manage it's lazy initialization.

  • inspector/front-end/ScriptView.js: (WebInspector.ScriptView): (WebInspector.SourceFrameContentProviderForScript): (WebInspector.SourceFrameContentProviderForScript.prototype.requestContent.didRequestSource): (WebInspector.SourceFrameContentProviderForScript.prototype.requestContent): (WebInspector.SourceFrameContentProviderForScript.prototype.scripts):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._addScript): (WebInspector.ScriptsPanel.prototype.sourceFrameForScript): (WebInspector.ScriptsPanel.prototype._sourceFrameForResource):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame): (WebInspector.SourceFrame.prototype.set visible): (WebInspector.SourceFrame.prototype._createTextViewer): (WebInspector.SourceFrame.prototype._breakpointAdded): (WebInspector.SourceFrame.prototype._breakpoints): (WebInspector.SourceFrame.prototype._sourceIDForLine): (WebInspector.SourceFrame.prototype._sourceIDSet): (WebInspector.SourceFrameContentProvider): (WebInspector.SourceFrameContentProvider.prototype.requestContent): (WebInspector.SourceFrameContentProvider.prototype.scripts):
  • inspector/front-end/SourceView.js: (WebInspector.SourceView): (WebInspector.SourceView.prototype.show): (WebInspector.SourceView.prototype.resize): (WebInspector.SourceView.prototype.performSearch.didFindSearchMatches): (WebInspector.SourceView.prototype.performSearch): (WebInspector.SourceView.prototype.revealLine): (WebInspector.SourceView.prototype.highlightLine): (WebInspector.SourceView.prototype._jumpToSearchResult): (WebInspector.SourceFrameContentProviderForResource): (WebInspector.SourceFrameContentProviderForResource.prototype.requestContent): (WebInspector.SourceFrameContentProviderForResource.prototype.scripts):
6:09 AM Changeset in webkit [75936] by jknotten@chromium.org
  • 2 edits in trunk/Tools

2011-01-17 John Knottenbelt <​jknotten@chromium.org>

Unreviewed.

Add myself to committers list
​https://bugs.webkit.org/show_bug.cgi?id=52566

  • Scripts/webkitpy/common/config/committers.py:
5:28 AM Changeset in webkit [75935] by kbalazs@webkit.org
  • 4 edits in trunk/Source/WebKit2

2011-01-17 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Andreas Kling.

[Qt][WK2] Crash due to double destruction of QSharedMemory
​https://bugs.webkit.org/show_bug.cgi?id=52569

Avoid deleting the QSharedMemory twice.

  • Platform/qt/SharedMemoryQt.cpp: (WebKit::SharedMemory::~SharedMemory):
  • Shared/qt/CleanupHandler.cpp: Renamed m_inDeleteObjects to m_hasStartedDeleting and added a getter for it. (WebKit::CleanupHandler::CleanupHandler): (WebKit::CleanupHandler::deleteObjects):
  • Shared/qt/CleanupHandler.h: (WebKit::CleanupHandler::unmark): (WebKit::CleanupHandler::hasStartedDeleting):
4:21 AM Changeset in webkit [75934] by jknotten@chromium.org
  • 9 edits
    4 adds in trunk

2011-01-17 John Knottenbelt <​jknotten@chromium.org>

Reviewed by Jeremy Orlow.

GeolocationController should call stopUpdating on destruction
​https://bugs.webkit.org/show_bug.cgi?id=52216

fast/dom/window-close-crash.html tests that we do not fail the
assertion in the mock GeolocationClient that the GeolocationClient
is not updating when the GeolocationController is destroyed.

  • fast/dom/Geolocation/resources/window-close-popup.html: Added.
  • fast/dom/Geolocation/script-tests/window-close-crash.js: Added. (gotPosition): (waitForWindowToClose): (failedToCreateWatch):
  • fast/dom/Geolocation/window-close-crash-expected.txt: Added.
  • fast/dom/Geolocation/window-close-crash.html: Added.
  • platform/gtk/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:

2011-01-17 John Knottenbelt <​jknotten@chromium.org>

Reviewed by Jeremy Orlow.

GeolocationController should call stopUpdating on destruction
​https://bugs.webkit.org/show_bug.cgi?id=52216

Test: fast/dom/Geolocation/window-close-crash.html

  • page/GeolocationController.cpp: (WebCore::GeolocationController::~GeolocationController):

2011-01-17 John Knottenbelt <​jknotten@chromium.org>

Reviewed by Jeremy Orlow.

GeolocationController should call stopUpdating on destruction
​https://bugs.webkit.org/show_bug.cgi?id=52216

fast/dom/Geolocation/window-close-crash.html requires that a
Geolocation watch be started in a secondary window. Consequently,
we need to allow geolocation permission and provide a mock
geolocation position for the secondary window's
GeolocationClientMock.

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setGeolocationPermission): (LayoutTestController::setMockGeolocationPosition): (LayoutTestController::setMockGeolocationError):
  • DumpRenderTree/chromium/TestShell.h: (TestShell::windowList):
3:02 AM Changeset in webkit [75933] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-17 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: Qt build fix.

  • inspector/InspectorInstrumentation.h:
2:44 AM Changeset in webkit [75932] by pfeldman@chromium.org
  • 30 edits in trunk/Source/WebCore

2011-01-16 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: make WebCore use InspectorInstrumentation
for instrumentation calls.
​https://bugs.webkit.org/show_bug.cgi?id=52532

This change makes WebCore classes issue instrumentation signals
by means of InspectorInstrumentation interface. It covered migration
for Document, FrameLoader, Database, DOMStorage, etc. It fixed
instrumentation handling for Console as well. This all is a part
of story described in the bug 52510.

  • dom/Document.cpp: (WebCore::Document::finishedParsing):
  • dom/Document.h:
  • dom/ScriptExecutionContext.h:
  • inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent): (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode): (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode): (WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr): (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent): (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded): (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
  • inspector/InspectorBrowserDebuggerAgent.h: (WebCore::InspectorBrowserDebuggerAgent::create):
  • inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::stopTiming): (WebCore::InspectorConsoleAgent::count):
  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::handleMousePress): (WebCore::InspectorController::didClearWindowObjectInWorld): (WebCore::PostWorkerNotificationToFrontendTask::performTask):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDOMStorageAgent.h:
  • inspector/InspectorDatabaseAgent.cpp:
  • inspector/InspectorDatabaseAgent.h:
  • inspector/InspectorFrontendHost.cpp:
  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl): (WebCore::InspectorInstrumentation::inspectedPageDestroyedImpl): (WebCore::InspectorInstrumentation::mouseDidMoveOverElementImpl): (WebCore::InspectorInstrumentation::handleMousePressImpl): (WebCore::InspectorInstrumentation::mainResourceFiredLoadEventImpl): (WebCore::InspectorInstrumentation::mainResourceFiredDOMContentEventImpl): (WebCore::InspectorInstrumentation::frameDetachedFromParentImpl): (WebCore::InspectorInstrumentation::didCommitLoadImpl): (WebCore::InspectorInstrumentation::addMessageToConsoleImpl): (WebCore::InspectorInstrumentation::consoleCountImpl): (WebCore::InspectorInstrumentation::startConsoleTimingImpl): (WebCore::InspectorInstrumentation::stopConsoleTimingImpl): (WebCore::InspectorInstrumentation::consoleMarkTimelineImpl): (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsoleImpl): (WebCore::InspectorInstrumentation::didOpenDatabaseImpl): (WebCore::InspectorInstrumentation::didUseDOMStorageImpl): (WebCore::InspectorInstrumentation::didCreateWorkerImpl): (WebCore::InspectorInstrumentation::didDestroyWorkerImpl): (WebCore::InspectorInstrumentation::didCreateWebSocketImpl): (WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequestImpl): (WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponseImpl): (WebCore::InspectorInstrumentation::didCloseWebSocketImpl): (WebCore::InspectorInstrumentation::networkStateChangedImpl): (WebCore::InspectorInstrumentation::updateApplicationCacheStatusImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::inspectorControllerCreated): (WebCore::InspectorInstrumentation::inspectorControllerDeleted): (WebCore::InspectorInstrumentation::didClearWindowObjectInWorld): (WebCore::InspectorInstrumentation::inspectedPageDestroyed): (WebCore::InspectorInstrumentation::willInsertDOMNode): (WebCore::InspectorInstrumentation::didInsertDOMNode): (WebCore::InspectorInstrumentation::willRemoveDOMNode): (WebCore::InspectorInstrumentation::willModifyDOMAttr): (WebCore::InspectorInstrumentation::didModifyDOMAttr): (WebCore::InspectorInstrumentation::mouseDidMoveOverElement): (WebCore::InspectorInstrumentation::handleMousePress): (WebCore::InspectorInstrumentation::characterDataModified): (WebCore::InspectorInstrumentation::willSendXMLHttpRequest): (WebCore::InspectorInstrumentation::didScheduleResourceRequest): (WebCore::InspectorInstrumentation::didInstallTimer): (WebCore::InspectorInstrumentation::didRemoveTimer): (WebCore::InspectorInstrumentation::willCallFunction): (WebCore::InspectorInstrumentation::willChangeXHRReadyState): (WebCore::InspectorInstrumentation::willDispatchEvent): (WebCore::InspectorInstrumentation::willDispatchEventOnWindow): (WebCore::InspectorInstrumentation::willEvaluateScript): (WebCore::InspectorInstrumentation::willFireTimer): (WebCore::InspectorInstrumentation::willLayout): (WebCore::InspectorInstrumentation::willLoadXHR): (WebCore::InspectorInstrumentation::willPaint): (WebCore::InspectorInstrumentation::willRecalculateStyle): (WebCore::InspectorInstrumentation::identifierForInitialRequest): (WebCore::InspectorInstrumentation::willSendRequest): (WebCore::InspectorInstrumentation::markResourceAsCached): (WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCache): (WebCore::InspectorInstrumentation::willReceiveResourceData): (WebCore::InspectorInstrumentation::willReceiveResourceResponse): (WebCore::InspectorInstrumentation::didReceiveContentLength): (WebCore::InspectorInstrumentation::didFinishLoading): (WebCore::InspectorInstrumentation::didFailLoading): (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorInstrumentation::scriptImported): (WebCore::InspectorInstrumentation::mainResourceFiredLoadEvent): (WebCore::InspectorInstrumentation::mainResourceFiredDOMContentEvent): (WebCore::InspectorInstrumentation::frameDetachedFromParent): (WebCore::InspectorInstrumentation::didCommitLoad): (WebCore::InspectorInstrumentation::willWriteHTML): (WebCore::InspectorInstrumentation::didOpenDatabase): (WebCore::InspectorInstrumentation::didUseDOMStorage): (WebCore::InspectorInstrumentation::didCreateWorker): (WebCore::InspectorInstrumentation::didDestroyWorker): (WebCore::InspectorInstrumentation::didCreateWebSocket): (WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequest): (WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorInstrumentation::didCloseWebSocket): (WebCore::InspectorInstrumentation::networkStateChanged): (WebCore::InspectorInstrumentation::updateApplicationCacheStatus): (WebCore::InspectorInstrumentation::addMessageToConsole): (WebCore::InspectorInstrumentation::consoleCount): (WebCore::InspectorInstrumentation::startConsoleTiming): (WebCore::InspectorInstrumentation::stopConsoleTiming): (WebCore::InspectorInstrumentation::consoleMarkTimeline): (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsole): (WebCore::InspectorInstrumentation::inspectorControllerForContext): (WebCore::InspectorInstrumentation::inspectorControllerForFrame): (WebCore::InspectorInstrumentation::inspectorControllerForPage): (WebCore::InspectorInstrumentation::inspectorControllerWithFrontendForContext): (WebCore::InspectorInstrumentation::inspectorControllerWithFrontendForDocument): (WebCore::InspectorInstrumentation::inspectorControllerWithFrontendForFrame): (WebCore::InspectorInstrumentation::inspectorControllerWithFrontendForPage):
  • inspector/InspectorState.cpp:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::detachFromParent): (WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld): (WebCore::FrameLoader::dispatchDidCommitLoad):
  • page/Chrome.cpp: (WebCore::Chrome::mouseDidMoveOverElement):
  • page/Console.cpp: (WebCore::Console::addMessage): (WebCore::Console::count): (WebCore::Console::markTimeline): (WebCore::Console::profile): (WebCore::Console::time): (WebCore::Console::timeEnd): (WebCore::Console::group): (WebCore::Console::groupCollapsed): (WebCore::Console::groupEnd):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::sessionStorage): (WebCore::DOMWindow::localStorage): (WebCore::DOMWindow::dispatchLoadEvent):
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent):
  • page/Page.cpp: (WebCore::Page::~Page):
  • storage/Database.cpp: (WebCore::Database::openDatabase):
  • workers/AbstractWorker.cpp: (WebCore::AbstractWorker::onDestroyWorker):
  • workers/SharedWorker.cpp: (WebCore::SharedWorker::create):
  • workers/Worker.cpp: (WebCore::Worker::create):
  • workers/WorkerMessagingProxy.cpp:
2:15 AM Changeset in webkit [75931] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-01-17 Adam Barth <​abarth@webkit.org>

Update path to reflect new WebKit directory location.

  • tests/WebFrameTest.cpp: (WebKit::WebFrameTest::registerMockedURLLoad):
2:08 AM Changeset in webkit [75930] by loislo@chromium.org
  • 3 edits in trunk/LayoutTests

2011-01-14 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Enable inspector's tests for chromium Linux.
​https://bugs.webkit.org/show_bug.cgi?id=52445

  • platform/chromium/inspector/timeline-network-resource-expected.txt:
  • platform/chromium/test_expectations.txt:
1:40 AM Changeset in webkit [75929] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebCore

2011-01-17 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Unreviewed, rolling out r75923.

GTK guy rolls out the r75914.

  • platform/efl/ScrollViewEfl.cpp: (WebCore::ScrollView::platformInit):
1:26 AM Changeset in webkit [75928] by Philippe Normand
  • 3 edits in trunk/Source/WebKit/gtk

2011-01-17 Philippe Normand <​pnormand@igalia.com>

Unreviewed, build fix for 2 GTK tests html file paths.

  • tests/testmimehandling.c: (main):
  • tests/testwebview.c:
1:25 AM Changeset in webkit [75927] by commit-queue@webkit.org
  • 4 edits in trunk

2011-01-17 Helder Correia <​helder@sencha.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] fast/canvas/canvas-fillPath-gradient-shadow.html does not pass
​https://bugs.webkit.org/show_bug.cgi?id=52556

The shadow color opacity needs to be set on the shadow painter.
Additionally, the gradient brush should be transformed.

  • platform/qt/Skipped: Remove test from skipped list.

2011-01-17 Helder Correia <​helder@sencha.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] fast/canvas/canvas-fillPath-gradient-shadow.html does not pass
​https://bugs.webkit.org/show_bug.cgi?id=52556

The shadow color opacity needs to be set on the shadow painter.
Additionally, the gradient brush should be transformed.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillPath):
12:50 AM Changeset in webkit [75926] by noam.rosenthal@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-01-17 No'am Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Background image rendering is slow
​https://bugs.webkit.org/show_bug.cgi?id=50527

When tiling a scaled pixmap in Image::drawPattern, scale the tile
first and only then draw it to the target. Do so only when drawing
more than one tile.

Tests in fast/backgrounds/size cover this.

  • platform/graphics/qt/ImageQt.cpp: (WebCore::Image::drawPattern):
12:28 AM Changeset in webkit [75925] by Laszlo Gombos
  • 2 edits in trunk/Source/WebCore

2011-01-17 Laszlo Gombos <Laszlo Gombos>

Reviewed by Simon Hausmann.

[Qt] [Symbian] Fix building NPAPI support
​https://bugs.webkit.org/show_bug.cgi?id=51981

Make sure that npapi.h is always included outside of the extern "C"
linkage declaration block.

No new tests as there is no new functionality.

  • bridge/npruntime.h:
12:26 AM Changeset in webkit [75924] by Philippe Normand
  • 6 edits in trunk

2011-01-17 Philippe Normand <​pnormand@igalia.com>

Unreviewed, rolling out r75914.
​http://trac.webkit.org/changeset/75914
​https://bugs.webkit.org/show_bug.cgi?id=49177

multiple crashes on GTK

  • platform/gtk/Skipped:

2011-01-17 Philippe Normand <​pnormand@igalia.com>

Unreviewed, rolling out r75914.
​http://trac.webkit.org/changeset/75914
​https://bugs.webkit.org/show_bug.cgi?id=49177

multiple crashes on GTK

  • platform/ScrollView.cpp: (WebCore::ScrollView::removeChild): (WebCore::ScrollView::wheelEvent):
  • platform/gtk/MainFrameScrollbarGtk.cpp: (MainFrameScrollbarGtk::attachAdjustment): (MainFrameScrollbarGtk::gtkValueChanged):
  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::platformInit): (WebCore::ScrollView::platformAddChild): (WebCore::ScrollView::platformRemoveChild):
12:05 AM Changeset in webkit [75923] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebCore

2011-01-17 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Unreviewed build fix.

Bug 49177's patch enabled platformInit() in super class(ScrollView).
But, it didn't removed the function in ScrollViewEfl.cpp.

  • platform/efl/ScrollViewEfl.cpp:
Note: See TracTimeline for information about the timeline view.