Context Navigation

(WebCore::toChromeClientImpl):
(WebCore::toWebWidgetClient):
(WebCore::getCookieJar):
(WebCore::ChromiumBridge::cacheMetadata):
(WebCore::ChromiumBridge::clipboardIsFormatAvailable):
(WebCore::ChromiumBridge::clipboardReadPlainText):
(WebCore::ChromiumBridge::clipboardReadHTML):
(WebCore::ChromiumBridge::clipboardWriteSelection):
(WebCore::ChromiumBridge::clipboardWritePlainText):
(WebCore::ChromiumBridge::clipboardWriteURL):
(WebCore::ChromiumBridge::clipboardWriteImage):
(WebCore::ChromiumBridge::clipboardWriteData):
(WebCore::ChromiumBridge::clipboardReadAvailableTypes):
(WebCore::ChromiumBridge::clipboardReadData):
(WebCore::ChromiumBridge::clipboardReadFilenames):
(WebCore::ChromiumBridge::setCookies):
(WebCore::ChromiumBridge::cookies):
(WebCore::ChromiumBridge::cookieRequestHeaderFieldValue):
(WebCore::ChromiumBridge::rawCookies):
(WebCore::ChromiumBridge::deleteCookie):
(WebCore::ChromiumBridge::cookiesEnabled):
(WebCore::ChromiumBridge::prefetchDNS):
(WebCore::ChromiumBridge::fileExists):
(WebCore::ChromiumBridge::deleteFile):
(WebCore::ChromiumBridge::deleteEmptyDirectory):
(WebCore::ChromiumBridge::getFileSize):
(WebCore::ChromiumBridge::revealFolderInOS):
(WebCore::ChromiumBridge::getFileModificationTime):
(WebCore::ChromiumBridge::directoryName):
(WebCore::ChromiumBridge::pathByAppendingComponent):
(WebCore::ChromiumBridge::makeAllDirectories):
(WebCore::ChromiumBridge::getAbsolutePath):
(WebCore::ChromiumBridge::isDirectory):
(WebCore::ChromiumBridge::filePathToURL):
(WebCore::ChromiumBridge::openFile):
(WebCore::ChromiumBridge::closeFile):
(WebCore::ChromiumBridge::seekFile):
(WebCore::ChromiumBridge::truncateFile):
(WebCore::ChromiumBridge::readFromFile):
(WebCore::ChromiumBridge::writeToFile):
(WebCore::ChromiumBridge::ensureFontLoaded):
(WebCore::ChromiumBridge::getFontFamilyForCharacters):
(WebCore::ChromiumBridge::getRenderStyleForStrike):
(WebCore::ChromiumBridge::loadFont):
(WebCore::ChromiumBridge::databaseOpenFile):
(WebCore::ChromiumBridge::databaseDeleteFile):
(WebCore::ChromiumBridge::databaseGetFileAttributes):
(WebCore::ChromiumBridge::databaseGetFileSize):
(WebCore::ChromiumBridge::idbFactory):
(WebCore::ChromiumBridge::idbShutdown):
(WebCore::ChromiumBridge::createIDBKeysFromSerializedValuesAndKeyPath):
(WebCore::ChromiumBridge::signedPublicKeyAndChallengeString):
(WebCore::ChromiumBridge::computedDefaultLanguage):
(WebCore::ChromiumBridge::layoutTestMode):
(WebCore::ChromiumBridge::isSupportedImageMIMEType):
(WebCore::ChromiumBridge::isSupportedJavaScriptMIMEType):
(WebCore::ChromiumBridge::isSupportedNonImageMIMEType):
(WebCore::ChromiumBridge::mimeTypeForExtension):
(WebCore::ChromiumBridge::mimeTypeFromFile):
(WebCore::ChromiumBridge::preferredExtensionForMIMEType):
(WebCore::ChromiumBridge::plugins):
(WebCore::ChromiumBridge::pluginScriptableObject):
(WebCore::ChromiumBridge::loadPlatformImageResource):
(WebCore::ChromiumBridge::loadPlatformAudioResource):
(WebCore::ChromiumBridge::decodeAudioFileData):
(WebCore::ChromiumBridge::sandboxEnabled):
(WebCore::ChromiumBridge::setSharedTimerFiredFunction):
(WebCore::ChromiumBridge::setSharedTimerFireTime):
(WebCore::ChromiumBridge::stopSharedTimer):
(WebCore::ChromiumBridge::decrementStatsCounter):
(WebCore::ChromiumBridge::incrementStatsCounter):
(WebCore::ChromiumBridge::histogramCustomCounts):
(WebCore::ChromiumBridge::histogramEnumeration):
(WebCore::ChromiumBridge::suddenTerminationChanged):
(WebCore::ChromiumBridge::currentTime):
(WebCore::ChromiumBridge::paintButton):
(WebCore::ChromiumBridge::paintMenuList):
(WebCore::ChromiumBridge::paintScrollbarArrow):
(WebCore::ChromiumBridge::paintScrollbarThumb):
(WebCore::ChromiumBridge::paintScrollbarTrack):
(WebCore::ChromiumBridge::paintSpinButton):
(WebCore::ChromiumBridge::paintTextField):
(WebCore::ChromiumBridge::paintTrackbar):
(WebCore::ChromiumBridge::paintProgressBar):
(WebCore::WebThemePart):
(WebCore::WebThemeState):
(WebCore::GetWebThemeExtraParams):
(WebCore::ChromiumBridge::getThemePartSize):
(WebCore::ChromiumBridge::paintThemePart):
(WebCore::ChromiumBridge::traceEventBegin):
(WebCore::ChromiumBridge::traceEventEnd):
(WebCore::ChromiumBridge::visitedLinkHash):
(WebCore::ChromiumBridge::isLinkVisited):
(WebCore::ChromiumBridge::notifyJSOutOfMemory):
(WebCore::ChromiumBridge::memoryUsageMB):
(WebCore::ChromiumBridge::actualMemoryUsageMB):
(WebCore::ChromiumBridge::screenDepth):
(WebCore::ChromiumBridge::screenDepthPerComponent):
(WebCore::ChromiumBridge::screenIsMonochrome):
(WebCore::ChromiumBridge::screenRect):
(WebCore::ChromiumBridge::screenAvailableRect):
(WebCore::ChromiumBridge::popupsAllowed):
(WebCore::WorkerContextProxy::create):

10:35 PM Changeset in webkit [76208] by tkent@chromium.org

25 edits
3 adds
2 deletes in trunk

2011-01-19 Dominic Cooney <dominicc@google.com>

Reviewed by Kent Tamura.

Make <keygen> no longer appear to be a <select> element to script.
https://bugs.webkit.org/show_bug.cgi?id=52557

The intent is to put <keygen> options into shadow DOM. This change
takes the first step by hiding the <select> element from
JavaScript.

Test: fast/dom/HTMLKeygenElement/keygen.html

CMakeLists.txt: Adds new IDL-derived wrapper.
DerivedSources.cpp:
DerivedSources.make:
GNUmakefile.am:
WebCore.gypi:
WebCore.pri:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/gobject/GNUmakefile.am:
bindings/gobject/WebKitHTMLElementWrapperFactory.cpp: (WebKit::createKeygenWrapper): (WebKit::createHTMLElementWrapper):
bindings/objc/DOM.mm: (WebCore::createElementClassMap): Keygen no longer DOMHTMLSelectElement
html/HTMLKeygenElement.h: (WebCore::HTMLKeygenElement::willValidate): Now public.
html/HTMLKeygenElement.idl: Added.
html/HTMLTagNames.in: Keygen's wrapper is HTMLKeygenElement.
page/DOMWindow.idl: Add HTMLKeygenElement constructor.

2011-01-19 Dominic Cooney <dominicc@google.com>

Reviewed by Kent Tamura.

Make <keygen> no longer appear to be a <select> element to script.

https://bugs.webkit.org/show_bug.cgi?id=52557

fast/dom/HTMLKeygenElement/keygen-expected.txt: Added.
fast/dom/HTMLKeygenElement/keygen-option-select-expected.txt: Removed.
fast/dom/HTMLKeygenElement/keygen-option-select.html: Removed.
fast/dom/HTMLKeygenElement/keygen.html: Added.
fast/dom/Window/window-properties-expected.txt:
fast/dom/Window/window-property-descriptors-expected.txt:
fast/dom/prototype-inheritance-2-expected.txt:
fast/dom/prototype-inheritance-expected.txt:
fast/dom/wrapper-classes-expected.txt:
fast/dom/wrapper-classes.html:
fast/js/global-constructors-expected.txt:
platform/mac/fast/dom/wrapper-classes-objc-expected.txt:
platform/mac/fast/dom/wrapper-classes-objc.html:

10:09 PM Changeset in webkit [76207] by dimich@chromium.org

55 edits
1 add in trunk/Source

2011-01-19 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76203.
http://trac.webkit.org/changeset/76203
https://bugs.webkit.org/show_bug.cgi?id=52784

Broke Win compile on Chromium bots (Requested by dimich on
#webkit).

WebCore.gypi:
bindings/v8/V8DOMWindowShell.cpp: (WebCore::reportFatalErrorInV8):
page/PageGroup.cpp: (WebCore::PageGroup::isLinkVisited):
platform/android/PlatformBridge.h:
platform/audio/chromium/AudioBusChromium.cpp: (WebCore::createBusFromInMemoryAudioFile):
platform/chromium/ChromiumBridge.h: Added.
platform/chromium/ChromiumDataObjectLegacy.cpp: (WebCore::ChromiumDataObjectLegacy::getData):
platform/chromium/DragDataChromium.cpp: (WebCore::DragData::asURL):
platform/chromium/FileSystemChromium.cpp: (WebCore::deleteFile): (WebCore::deleteEmptyDirectory): (WebCore::getFileSize): (WebCore::getFileModificationTime): (WebCore::revealFolderInOS): (WebCore::directoryName): (WebCore::pathByAppendingComponent): (WebCore::makeAllDirectories): (WebCore::fileExists): (WebCore::openFile): (WebCore::closeFile): (WebCore::seekFile): (WebCore::truncateFile): (WebCore::readFromFile): (WebCore::writeToFile):
platform/chromium/LanguageChromium.cpp: (WebCore::platformDefaultLanguage):
platform/chromium/LinkHashChromium.cpp: (WebCore::visitedLinkHash):
platform/chromium/MIMETypeRegistryChromium.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension): (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType): (WebCore::MIMETypeRegistry::isSupportedImageMIMEType): (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType): (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writePlainText): (WebCore::Pasteboard::writeURL): (WebCore::Pasteboard::writeImage): (WebCore::Pasteboard::canSmartReplace): (WebCore::Pasteboard::plainText): (WebCore::Pasteboard::documentFragment):
platform/chromium/PlatformBridge.h:
platform/chromium/PlatformScreenChromium.cpp: (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::screenRect): (WebCore::screenAvailableRect):
platform/chromium/ReadableDataObject.cpp: (WebCore::ReadableDataObject::getData): (WebCore::ReadableDataObject::urlTitle): (WebCore::ReadableDataObject::htmlBaseUrl): (WebCore::ReadableDataObject::filenames): (WebCore::ReadableDataObject::ensureTypeCacheInitialized):
platform/chromium/SSLKeyGeneratorChromium.cpp: (WebCore::signedPublicKeyAndChallengeString):
platform/chromium/ScrollbarThemeChromium.cpp:
platform/chromium/ScrollbarThemeChromiumLinux.cpp: (WebCore::ScrollbarThemeChromiumLinux::scrollbarThickness): (WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece): (WebCore::ScrollbarThemeChromiumLinux::paintButton): (WebCore::ScrollbarThemeChromiumLinux::paintThumb): (WebCore::ScrollbarThemeChromiumLinux::buttonSize): (WebCore::ScrollbarThemeChromiumLinux::minimumThumbLength):
platform/chromium/ScrollbarThemeChromiumMac.mm: (WebCore::scrollbarStateToThemeState): (WebCore::ScrollbarThemeChromiumMac::paint):
platform/chromium/ScrollbarThemeChromiumWin.cpp: (WebCore::ScrollbarThemeChromiumWin::scrollbarThickness): (WebCore::ScrollbarThemeChromiumWin::paintTrackPiece): (WebCore::ScrollbarThemeChromiumWin::paintButton): (WebCore::ScrollbarThemeChromiumWin::paintThumb): (WebCore::ScrollbarThemeChromiumWin::buttonSize):
platform/chromium/SharedTimerChromium.cpp: (WebCore::setSharedTimerFiredFunction): (WebCore::setSharedTimerFireTime): (WebCore::stopSharedTimer):
platform/chromium/SuddenTerminationChromium.cpp: (WebCore::disableSuddenTermination): (WebCore::enableSuddenTermination):
platform/chromium/SystemTimeChromium.cpp: (WebCore::currentTime):
platform/chromium/WritableDataObject.cpp: (WebCore::WritableDataObject::setData):
platform/graphics/chromium/CrossProcessFontLoading.mm:
platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::fontContainsCharacter): (WebCore::FillLogFont):
platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::getFontDataForCharacters):
platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::drawGlyphs):
platform/graphics/chromium/FontPlatformDataChromiumWin.cpp: (WebCore::FontPlatformData::scriptFontProperties):
platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::querySystemForRenderStyle):
platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp: (WebCore::fillBMPGlyphs):
platform/graphics/chromium/ImageChromium.cpp: (WebCore::Image::loadPlatformResource):
platform/graphics/chromium/ImageChromiumMac.mm: (WebCore::Image::loadPlatformResource):
platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::determinePitch): (WebCore::SimpleFontData::platformWidthForGlyph):
platform/graphics/chromium/UniscribeHelperTextRun.cpp: (WebCore::UniscribeHelperTextRun::tryToPreloadFont):
platform/graphics/skia/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData):
platform/network/chromium/CookieJarChromium.cpp: (WebCore::setCookies): (WebCore::cookies): (WebCore::cookieRequestHeaderFieldValue): (WebCore::cookiesEnabled): (WebCore::getRawCookies): (WebCore::deleteCookie):
platform/network/chromium/DNSChromium.cpp: (WebCore::prefetchDNS):
platform/qt/PlatformBridge.h:
platform/sql/chromium/SQLiteFileSystemChromium.cpp: (WebCore::SQLiteFileSystem::deleteDatabaseFile): (WebCore::SQLiteFileSystem::getDatabaseFileSize):
platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp: (chromiumOpen): (chromiumDelete): (chromiumAccess):
platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:
plugins/chromium/PluginDataChromium.cpp: (WebCore::PluginCache::plugins):
rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::usesTestModeFocusRingColor):
rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::caretBlinkInterval):
rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumWin::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumWin::platformActiveSelectionForegroundColor): (WebCore::RenderThemeChromiumWin::systemColor): (WebCore::RenderThemeChromiumWin::paintButton): (WebCore::RenderThemeChromiumWin::paintSliderTrack): (WebCore::menuListButtonWidth): (WebCore::RenderThemeChromiumWin::paintMenuList): (WebCore::RenderThemeChromiumWin::paintTextFieldInternal): (WebCore::RenderThemeChromiumWin::paintInnerSpinButton): (WebCore::RenderThemeChromiumWin::paintProgressBar):
storage/chromium/IDBFactoryBackendInterface.cpp: (WebCore::IDBFactoryBackendInterface::create): (WebCore::IDBFactoryBackendInterface::~IDBFactoryBackendInterface):
storage/chromium/IDBKeyPathBackendImpl.cpp: (WebCore::IDBKeyPathBackendImpl::createIDBKeysFromSerializedValuesAndKeyPath):

2011-01-19 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76203.
http://trac.webkit.org/changeset/76203
https://bugs.webkit.org/show_bug.cgi?id=52784

Broke Win compile on Chromium bots (Requested by dimich on
#webkit).

WebKit.gyp:
src/AssertMatchingEnums.cpp:
src/ChromiumBridge.cpp: Renamed from Source/WebKit/chromium/src/PlatformBridge.cpp. (WebCore::toChromeClientImpl): (WebCore::toWebWidgetClient): (WebCore::getCookieJar): (WebCore::ChromiumBridge::cacheMetadata): (WebCore::ChromiumBridge::clipboardIsFormatAvailable): (WebCore::ChromiumBridge::clipboardReadPlainText): (WebCore::ChromiumBridge::clipboardReadHTML): (WebCore::ChromiumBridge::clipboardWriteSelection): (WebCore::ChromiumBridge::clipboardWritePlainText): (WebCore::ChromiumBridge::clipboardWriteURL): (WebCore::ChromiumBridge::clipboardWriteImage): (WebCore::ChromiumBridge::clipboardWriteData): (WebCore::ChromiumBridge::clipboardReadAvailableTypes): (WebCore::ChromiumBridge::clipboardReadData): (WebCore::ChromiumBridge::clipboardReadFilenames): (WebCore::ChromiumBridge::setCookies): (WebCore::ChromiumBridge::cookies): (WebCore::ChromiumBridge::cookieRequestHeaderFieldValue): (WebCore::ChromiumBridge::rawCookies): (WebCore::ChromiumBridge::deleteCookie): (WebCore::ChromiumBridge::cookiesEnabled): (WebCore::ChromiumBridge::prefetchDNS): (WebCore::ChromiumBridge::fileExists): (WebCore::ChromiumBridge::deleteFile): (WebCore::ChromiumBridge::deleteEmptyDirectory): (WebCore::ChromiumBridge::getFileSize): (WebCore::ChromiumBridge::revealFolderInOS): (WebCore::ChromiumBridge::getFileModificationTime): (WebCore::ChromiumBridge::directoryName): (WebCore::ChromiumBridge::pathByAppendingComponent): (WebCore::ChromiumBridge::makeAllDirectories): (WebCore::ChromiumBridge::getAbsolutePath): (WebCore::ChromiumBridge::isDirectory): (WebCore::ChromiumBridge::filePathToURL): (WebCore::ChromiumBridge::openFile): (WebCore::ChromiumBridge::closeFile): (WebCore::ChromiumBridge::seekFile): (WebCore::ChromiumBridge::truncateFile): (WebCore::ChromiumBridge::readFromFile): (WebCore::ChromiumBridge::writeToFile): (WebCore::ChromiumBridge::ensureFontLoaded): (WebCore::ChromiumBridge::getFontFamilyForCharacters): (WebCore::ChromiumBridge::getRenderStyleForStrike): (WebCore::ChromiumBridge::loadFont): (WebCore::ChromiumBridge::databaseOpenFile): (WebCore::ChromiumBridge::databaseDeleteFile): (WebCore::ChromiumBridge::databaseGetFileAttributes): (WebCore::ChromiumBridge::databaseGetFileSize): (WebCore::ChromiumBridge::idbFactory): (WebCore::ChromiumBridge::idbShutdown): (WebCore::ChromiumBridge::createIDBKeysFromSerializedValuesAndKeyPath): (WebCore::ChromiumBridge::signedPublicKeyAndChallengeString): (WebCore::ChromiumBridge::computedDefaultLanguage): (WebCore::ChromiumBridge::layoutTestMode): (WebCore::ChromiumBridge::isSupportedImageMIMEType): (WebCore::ChromiumBridge::isSupportedJavaScriptMIMEType): (WebCore::ChromiumBridge::isSupportedNonImageMIMEType): (WebCore::ChromiumBridge::mimeTypeForExtension): (WebCore::ChromiumBridge::mimeTypeFromFile): (WebCore::ChromiumBridge::preferredExtensionForMIMEType): (WebCore::ChromiumBridge::plugins): (WebCore::ChromiumBridge::pluginScriptableObject): (WebCore::ChromiumBridge::loadPlatformImageResource): (WebCore::ChromiumBridge::loadPlatformAudioResource): (WebCore::ChromiumBridge::decodeAudioFileData): (WebCore::ChromiumBridge::sandboxEnabled): (WebCore::ChromiumBridge::setSharedTimerFiredFunction): (WebCore::ChromiumBridge::setSharedTimerFireTime): (WebCore::ChromiumBridge::stopSharedTimer): (WebCore::ChromiumBridge::decrementStatsCounter): (WebCore::ChromiumBridge::incrementStatsCounter): (WebCore::ChromiumBridge::histogramCustomCounts): (WebCore::ChromiumBridge::histogramEnumeration): (WebCore::ChromiumBridge::suddenTerminationChanged): (WebCore::ChromiumBridge::currentTime): (WebCore::ChromiumBridge::paintButton): (WebCore::ChromiumBridge::paintMenuList): (WebCore::ChromiumBridge::paintScrollbarArrow): (WebCore::ChromiumBridge::paintScrollbarThumb): (WebCore::ChromiumBridge::paintScrollbarTrack): (WebCore::ChromiumBridge::paintSpinButton): (WebCore::ChromiumBridge::paintTextField): (WebCore::ChromiumBridge::paintTrackbar): (WebCore::ChromiumBridge::paintProgressBar): (WebCore::WebThemePart): (WebCore::WebThemeState): (WebCore::GetWebThemeExtraParams): (WebCore::ChromiumBridge::getThemePartSize): (WebCore::ChromiumBridge::paintThemePart): (WebCore::ChromiumBridge::traceEventBegin): (WebCore::ChromiumBridge::traceEventEnd): (WebCore::ChromiumBridge::visitedLinkHash): (WebCore::ChromiumBridge::isLinkVisited): (WebCore::ChromiumBridge::notifyJSOutOfMemory): (WebCore::ChromiumBridge::memoryUsageMB): (WebCore::ChromiumBridge::actualMemoryUsageMB): (WebCore::ChromiumBridge::screenDepth): (WebCore::ChromiumBridge::screenDepthPerComponent): (WebCore::ChromiumBridge::screenIsMonochrome): (WebCore::ChromiumBridge::screenRect): (WebCore::ChromiumBridge::screenAvailableRect): (WebCore::ChromiumBridge::popupsAllowed): (WebCore::WorkerContextProxy::create):
src/ResourceHandle.cpp: (WebCore::ResourceHandle::cacheMetadata):
src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::WebFrameImpl): (WebKit::WebFrameImpl::~WebFrameImpl):
src/WebViewImpl.cpp: (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

9:57 PM Changeset in webkit [76206] by commit-queue@webkit.org

3 edits
6 adds in trunk

2011-01-19 Helder Correia <helder@sencha.com>

Reviewed by Andreas Kling.

[Qt] GraphicsContext::strokePath() paints solid shadows with incorrect alpha
https://bugs.webkit.org/show_bug.cgi?id=52705

This is related to bug 52611. The shadow color alpha must be multiplied
by the context pen alpha. Fixing this results in correct behavior for
Canvas path stroke() and strokeRect() [which relies on stroke()].

fast/canvas/canvas-strokePath-alpha-shadow-expected.txt: Added.
fast/canvas/canvas-strokePath-alpha-shadow.html: Added.
fast/canvas/canvas-strokeRect-alpha-shadow-expected.txt: Added.
fast/canvas/canvas-strokeRect-alpha-shadow.html: Added.
fast/canvas/script-tests/canvas-strokePath-alpha-shadow.js: Added.
fast/canvas/script-tests/canvas-strokeRect-alpha-shadow.js: Added.

2011-01-19 Helder Correia <helder@sencha.com>

Reviewed by Andreas Kling.

[Qt] GraphicsContext::strokePath() paints solid shadows with incorrect alpha
https://bugs.webkit.org/show_bug.cgi?id=52705

This is related to bug 52611. The shadow color alpha must be multiplied
by the context pen alpha. Fixing this results in correct behavior for
Canvas path stroke() and strokeRect() [which relies on stroke()].

Tests: fast/canvas/canvas-strokePath-alpha-shadow.html

fast/canvas/canvas-strokeRect-alpha-shadow.html

platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::strokePath):

9:49 PM Changeset in webkit [76205] by darin@chromium.org

10 edits
16 adds
9 deletes in trunk

2011-01-19 Darin Fisher <darin@chromium.org>

Reviewed by Mihai Parparita.

Re-initialize the HistoryItem fully when navigating to a HistoryItem,
or replacing a HistoryItem, results in a different URL.

https://bugs.webkit.org/show_bug.cgi?id=49654

This patch also forces all HistoryItems to record the post-redirect
URL. Previously, frames would remember the pre-redirect URL. This is
problematic since other members of the HistoryItem correspond to the
post-redirect URL.

Tests: fast/history/history-replace-updates-current-item.html

http/tests/navigation/redirect-on-back-updates-history-item.html
http/tests/navigation/redirect-on-reload-updates-history-item.html

history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem): (WebCore::HistoryItem::reset):
history/HistoryItem.h:
loader/HistoryController.cpp: (WebCore::HistoryController::updateForBackForwardNavigation): (WebCore::HistoryController::updateForReload): (WebCore::HistoryController::updateForStandardLoad): (WebCore::HistoryController::updateForRedirectWithLockedBackForwardList): (WebCore::HistoryController::initializeItem): (WebCore::HistoryController::createItem): (WebCore::HistoryController::createItemTree): (WebCore::HistoryController::updateCurrentItem):
loader/HistoryController.h:

9:31 PM Changeset in webkit [76204] by dimich@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Unreviewed, update of test expectations.

platform/chromium/test_expectations.txt:

9:17 PM Changeset in webkit [76203] by commit-queue@webkit.org

55 edits
1 move
1 delete in trunk/Source

2011-01-19 Adam Klein <adamk@chromium.org>

Reviewed by Darin Fisher.

[chromium] Rename ChromiumBridge to PlatformBridge
https://bugs.webkit.org/show_bug.cgi?id=52471

No tests added as this is a rename; no change in behavior.

WebCore.gypi:
bindings/v8/V8DOMWindowShell.cpp: (WebCore::reportFatalErrorInV8):
page/PageGroup.cpp: (WebCore::PageGroup::isLinkVisited):
platform/android/PlatformBridge.h:
platform/audio/chromium/AudioBusChromium.cpp: (WebCore::createBusFromInMemoryAudioFile):
platform/chromium/ChromiumBridge.h: Removed.
platform/chromium/ChromiumDataObjectLegacy.cpp: (WebCore::ChromiumDataObjectLegacy::getData):
platform/chromium/DragDataChromium.cpp: (WebCore::DragData::asURL):
platform/chromium/FileSystemChromium.cpp: (WebCore::deleteFile): (WebCore::deleteEmptyDirectory): (WebCore::getFileSize): (WebCore::getFileModificationTime): (WebCore::revealFolderInOS): (WebCore::directoryName): (WebCore::pathByAppendingComponent): (WebCore::makeAllDirectories): (WebCore::fileExists): (WebCore::openFile): (WebCore::closeFile): (WebCore::seekFile): (WebCore::truncateFile): (WebCore::readFromFile): (WebCore::writeToFile):
platform/chromium/LanguageChromium.cpp: (WebCore::platformDefaultLanguage):
platform/chromium/LinkHashChromium.cpp: (WebCore::visitedLinkHash):
platform/chromium/MIMETypeRegistryChromium.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension): (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType): (WebCore::MIMETypeRegistry::isSupportedImageMIMEType): (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType): (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writePlainText): (WebCore::Pasteboard::writeURL): (WebCore::Pasteboard::writeImage): (WebCore::Pasteboard::canSmartReplace): (WebCore::Pasteboard::plainText): (WebCore::Pasteboard::documentFragment):
platform/chromium/PlatformBridge.h:
platform/chromium/PlatformScreenChromium.cpp: (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::screenRect): (WebCore::screenAvailableRect):
platform/chromium/ReadableDataObject.cpp: (WebCore::ReadableDataObject::getData): (WebCore::ReadableDataObject::urlTitle): (WebCore::ReadableDataObject::htmlBaseUrl): (WebCore::ReadableDataObject::filenames): (WebCore::ReadableDataObject::ensureTypeCacheInitialized):
platform/chromium/SSLKeyGeneratorChromium.cpp: (WebCore::signedPublicKeyAndChallengeString):
platform/chromium/ScrollbarThemeChromium.cpp:
platform/chromium/ScrollbarThemeChromiumLinux.cpp: (WebCore::ScrollbarThemeChromiumLinux::scrollbarThickness): (WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece): (WebCore::ScrollbarThemeChromiumLinux::paintButton): (WebCore::ScrollbarThemeChromiumLinux::paintThumb): (WebCore::ScrollbarThemeChromiumLinux::buttonSize): (WebCore::ScrollbarThemeChromiumLinux::minimumThumbLength):
platform/chromium/ScrollbarThemeChromiumMac.mm: (WebCore::scrollbarStateToThemeState): (WebCore::ScrollbarThemeChromiumMac::paint):
platform/chromium/ScrollbarThemeChromiumWin.cpp: (WebCore::ScrollbarThemeChromiumWin::scrollbarThickness): (WebCore::ScrollbarThemeChromiumWin::paintTrackPiece): (WebCore::ScrollbarThemeChromiumWin::paintButton): (WebCore::ScrollbarThemeChromiumWin::paintThumb): (WebCore::ScrollbarThemeChromiumWin::buttonSize):
platform/chromium/SharedTimerChromium.cpp: (WebCore::setSharedTimerFiredFunction): (WebCore::setSharedTimerFireTime): (WebCore::stopSharedTimer):
platform/chromium/SuddenTerminationChromium.cpp: (WebCore::disableSuddenTermination): (WebCore::enableSuddenTermination):
platform/chromium/SystemTimeChromium.cpp: (WebCore::currentTime):
platform/chromium/WritableDataObject.cpp: (WebCore::WritableDataObject::setData):
platform/graphics/chromium/CrossProcessFontLoading.mm:
platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::fontContainsCharacter): (WebCore::FillLogFont):
platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::getFontDataForCharacters):
platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::drawGlyphs):
platform/graphics/chromium/FontPlatformDataChromiumWin.cpp: (WebCore::FontPlatformData::scriptFontProperties):
platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::querySystemForRenderStyle):
platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp: (WebCore::fillBMPGlyphs):
platform/graphics/chromium/ImageChromium.cpp: (WebCore::Image::loadPlatformResource):
platform/graphics/chromium/ImageChromiumMac.mm: (WebCore::Image::loadPlatformResource):
platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::determinePitch): (WebCore::SimpleFontData::platformWidthForGlyph):
platform/graphics/chromium/UniscribeHelperTextRun.cpp: (WebCore::UniscribeHelperTextRun::tryToPreloadFont):
platform/graphics/skia/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData):
platform/network/chromium/CookieJarChromium.cpp: (WebCore::setCookies): (WebCore::cookies): (WebCore::cookieRequestHeaderFieldValue): (WebCore::cookiesEnabled): (WebCore::getRawCookies): (WebCore::deleteCookie):
platform/network/chromium/DNSChromium.cpp: (WebCore::prefetchDNS):
platform/qt/PlatformBridge.h:
platform/sql/chromium/SQLiteFileSystemChromium.cpp: (WebCore::SQLiteFileSystem::deleteDatabaseFile): (WebCore::SQLiteFileSystem::getDatabaseFileSize):
platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp: (chromiumOpen): (chromiumDelete): (chromiumAccess):
platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:
plugins/chromium/PluginDataChromium.cpp: (WebCore::PluginCache::plugins):
rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::usesTestModeFocusRingColor):
rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::caretBlinkInterval):
rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumWin::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumWin::platformActiveSelectionForegroundColor): (WebCore::RenderThemeChromiumWin::systemColor): (WebCore::RenderThemeChromiumWin::paintButton): (WebCore::RenderThemeChromiumWin::paintSliderTrack): (WebCore::menuListButtonWidth): (WebCore::RenderThemeChromiumWin::paintMenuList): (WebCore::RenderThemeChromiumWin::paintTextFieldInternal): (WebCore::RenderThemeChromiumWin::paintInnerSpinButton): (WebCore::RenderThemeChromiumWin::paintProgressBar):
storage/chromium/IDBFactoryBackendInterface.cpp: (WebCore::IDBFactoryBackendInterface::create): (WebCore::IDBFactoryBackendInterface::~IDBFactoryBackendInterface):
storage/chromium/IDBKeyPathBackendImpl.cpp: (WebCore::IDBKeyPathBackendImpl::createIDBKeysFromSerializedValuesAndKeyPath):

2011-01-19 Adam Klein <adamk@chromium.org>

Reviewed by Darin Fisher.

[chromium] Rename ChromiumBridge to PlatformBridge
https://bugs.webkit.org/show_bug.cgi?id=52471

WebKit.gyp:
src/AssertMatchingEnums.cpp:
src/PlatformBridge.cpp: (WebCore::toChromeClientImpl): (WebCore::toWebWidgetClient): (WebCore::getCookieJar): (WebCore::PlatformBridge::cacheMetadata): (WebCore::PlatformBridge::clipboardIsFormatAvailable): (WebCore::PlatformBridge::clipboardReadPlainText): (WebCore::PlatformBridge::clipboardReadHTML): (WebCore::PlatformBridge::clipboardWriteSelection): (WebCore::PlatformBridge::clipboardWritePlainText): (WebCore::PlatformBridge::clipboardWriteURL): (WebCore::PlatformBridge::clipboardWriteImage): (WebCore::PlatformBridge::clipboardWriteData): (WebCore::PlatformBridge::clipboardReadAvailableTypes): (WebCore::PlatformBridge::clipboardReadData): (WebCore::PlatformBridge::clipboardReadFilenames): (WebCore::PlatformBridge::setCookies): (WebCore::PlatformBridge::cookies): (WebCore::PlatformBridge::cookieRequestHeaderFieldValue): (WebCore::PlatformBridge::rawCookies): (WebCore::PlatformBridge::deleteCookie): (WebCore::PlatformBridge::cookiesEnabled): (WebCore::PlatformBridge::prefetchDNS): (WebCore::PlatformBridge::fileExists): (WebCore::PlatformBridge::deleteFile): (WebCore::PlatformBridge::deleteEmptyDirectory): (WebCore::PlatformBridge::getFileSize): (WebCore::PlatformBridge::revealFolderInOS): (WebCore::PlatformBridge::getFileModificationTime): (WebCore::PlatformBridge::directoryName): (WebCore::PlatformBridge::pathByAppendingComponent): (WebCore::PlatformBridge::makeAllDirectories): (WebCore::PlatformBridge::getAbsolutePath): (WebCore::PlatformBridge::isDirectory): (WebCore::PlatformBridge::filePathToURL): (WebCore::PlatformBridge::openFile): (WebCore::PlatformBridge::closeFile): (WebCore::PlatformBridge::seekFile): (WebCore::PlatformBridge::truncateFile): (WebCore::PlatformBridge::readFromFile): (WebCore::PlatformBridge::writeToFile): (WebCore::PlatformBridge::ensureFontLoaded): (WebCore::PlatformBridge::getFontFamilyForCharacters): (WebCore::PlatformBridge::getRenderStyleForStrike): (WebCore::PlatformBridge::loadFont): (WebCore::PlatformBridge::databaseOpenFile): (WebCore::PlatformBridge::databaseDeleteFile): (WebCore::PlatformBridge::databaseGetFileAttributes): (WebCore::PlatformBridge::databaseGetFileSize): (WebCore::PlatformBridge::idbFactory): (WebCore::PlatformBridge::idbShutdown): (WebCore::PlatformBridge::createIDBKeysFromSerializedValuesAndKeyPath): (WebCore::PlatformBridge::signedPublicKeyAndChallengeString): (WebCore::PlatformBridge::computedDefaultLanguage): (WebCore::PlatformBridge::layoutTestMode): (WebCore::PlatformBridge::isSupportedImageMIMEType): (WebCore::PlatformBridge::isSupportedJavaScriptMIMEType): (WebCore::PlatformBridge::isSupportedNonImageMIMEType): (WebCore::PlatformBridge::mimeTypeForExtension): (WebCore::PlatformBridge::mimeTypeFromFile): (WebCore::PlatformBridge::preferredExtensionForMIMEType): (WebCore::PlatformBridge::plugins): (WebCore::PlatformBridge::pluginScriptableObject): (WebCore::PlatformBridge::loadPlatformImageResource): (WebCore::PlatformBridge::loadPlatformAudioResource): (WebCore::PlatformBridge::decodeAudioFileData): (WebCore::PlatformBridge::sandboxEnabled): (WebCore::PlatformBridge::setSharedTimerFiredFunction): (WebCore::PlatformBridge::setSharedTimerFireTime): (WebCore::PlatformBridge::stopSharedTimer): (WebCore::PlatformBridge::decrementStatsCounter): (WebCore::PlatformBridge::incrementStatsCounter): (WebCore::PlatformBridge::histogramCustomCounts): (WebCore::PlatformBridge::histogramEnumeration): (WebCore::PlatformBridge::suddenTerminationChanged): (WebCore::PlatformBridge::currentTime): (WebCore::PlatformBridge::paintButton): (WebCore::PlatformBridge::paintMenuList): (WebCore::PlatformBridge::paintScrollbarArrow): (WebCore::PlatformBridge::paintScrollbarThumb): (WebCore::PlatformBridge::paintScrollbarTrack): (WebCore::PlatformBridge::paintSpinButton): (WebCore::PlatformBridge::paintTextField): (WebCore::PlatformBridge::paintTrackbar): (WebCore::PlatformBridge::paintProgressBar): (WebCore::WebThemePart): (WebCore::WebThemeState): (WebCore::GetWebThemeExtraParams): (WebCore::PlatformBridge::getThemePartSize): (WebCore::PlatformBridge::paintThemePart): (WebCore::PlatformBridge::traceEventBegin): (WebCore::PlatformBridge::traceEventEnd): (WebCore::PlatformBridge::visitedLinkHash): (WebCore::PlatformBridge::isLinkVisited): (WebCore::PlatformBridge::notifyJSOutOfMemory): (WebCore::PlatformBridge::memoryUsageMB): (WebCore::PlatformBridge::actualMemoryUsageMB): (WebCore::PlatformBridge::screenDepth): (WebCore::PlatformBridge::screenDepthPerComponent): (WebCore::PlatformBridge::screenIsMonochrome): (WebCore::PlatformBridge::screenRect): (WebCore::PlatformBridge::screenAvailableRect): (WebCore::PlatformBridge::popupsAllowed): (WebCore::WorkerContextProxy::create):
src/ResourceHandle.cpp: (WebCore::ResourceHandle::cacheMetadata):
src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::WebFrameImpl): (WebKit::WebFrameImpl::~WebFrameImpl):
src/WebViewImpl.cpp: (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

8:24 PM Changeset in webkit [76202] by dimich@chromium.org

3 edits
5 deletes in trunk

2011-01-19 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76187.
http://trac.webkit.org/changeset/76187
https://bugs.webkit.org/show_bug.cgi?id=52778

Broke caret-showing tests on SnowLeopard and Chromium
(Requested by dimich on #webkit).

editing/selection/caret-painting-in-overflowing-autowrap-content.html: Removed.
editing/selection/resources/iframe-positioning-caret-at-end.html: Removed.
platform/mac/editing/selection/caret-painting-in-overflowing-autowrap-content-expected.checksum: Removed.
platform/mac/editing/selection/caret-painting-in-overflowing-autowrap-content-expected.png: Removed.
platform/mac/editing/selection/caret-painting-in-overflowing-autowrap-content-expected.txt: Removed.

2011-01-19 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76187.
http://trac.webkit.org/changeset/76187
https://bugs.webkit.org/show_bug.cgi?id=52778

Broke caret-showing tests on SnowLeopard and Chromium
(Requested by dimich on #webkit).

rendering/RenderText.cpp: (WebCore::RenderText::localCaretRect):

8:19 PM Changeset in webkit [76201] by yuzo@google.com

3 edits
2 adds in trunk

2011-01-19 Yuzo Fujishima <yuzo@google.com>

Reviewed by Kent Tamura.

Fix for Bug 52279 - WebCore::RenderBlock::updateFirstLetter crashes for anonymous blocks
https://bugs.webkit.org/show_bug.cgi?id=52279

fast/css/first-letter-anonymous-block-crash-expected.txt: Added.
fast/css/first-letter-anonymous-block-crash.html: Added.

2011-01-19 Yuzo Fujishima <yuzo@google.com>

Reviewed by Kent Tamura.

Fix for Bug 52279 - WebCore::RenderBlock::updateFirstLetter crashes for anonymous blocks
https://bugs.webkit.org/show_bug.cgi?id=52279

In constructing text fragments to handle first-letter rule, first add
the text for the non-first letters and then remove the original text,
rather than the other way around. Otherwise, the text can be added to
an anoymous block that is different from the original one. This breaks
the assumption that a first letter render object has a non-null sibling
for the non-first letters and causes a crash.

Test: fast/css/first-letter-anonymous-block-crash.html

rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter):

8:17 PM Changeset in webkit [76200] by dpranke@chromium.org

6 edits in trunk/Tools

2011-01-19 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix - I pulled this patch in to fix an issue
revealed by r76195 running on some new bots). Also fix a couple
of other issues revealed in testing.

nrwt: remove fs refs from layout_package/json*

https://bugs.webkit.org/show_bug.cgi?id=52754

Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
Scripts/webkitpy/layout_tests/port/base.py:

7:55 PM Changeset in webkit [76199] by dpranke@chromium.org

4 edits in trunk/Tools

2011-01-19 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.

Fix a couple of minor bugs discovered while bringing up new bots
for testing.

Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
Scripts/webkitpy/layout_tests/run_webkit_tests.py:

7:52 PM Changeset in webkit [76198] by jamesr@google.com

33 edits
12 deletes in trunk

2011-01-19 James Robinson <jamesr@chromium.org>

Unreviewed, rolling out r76194.
http://trac.webkit.org/changeset/76194
https://bugs.webkit.org/show_bug.cgi?id=51218

Caused mysterious compile failure on the chromium win
build.webkit.org bots

fast/animation/request-animation-frame-cancel-expected.txt: Removed.
fast/animation/request-animation-frame-cancel.html: Removed.
fast/animation/request-animation-frame-cancel2-expected.txt: Removed.
fast/animation/request-animation-frame-cancel2.html: Removed.
fast/animation/request-animation-frame-display-expected.txt: Removed.
fast/animation/request-animation-frame-display.html: Removed.
fast/animation/request-animation-frame-expected.txt: Removed.
fast/animation/request-animation-frame-within-callback-expected.txt: Removed.
fast/animation/request-animation-frame-within-callback.html: Removed.
fast/animation/request-animation-frame.html: Removed.
platform/chromium/test_expectations.txt:
platform/gtk/Skipped:
platform/mac/Skipped:
platform/qt/Skipped:
platform/win/Skipped:

2011-01-19 James Robinson <jamesr@chromium.org>

Unreviewed, rolling out r76194.
http://trac.webkit.org/changeset/76194
https://bugs.webkit.org/show_bug.cgi?id=51218

Caused mysterious compile failure on the chromium win
build.webkit.org bots

WebCore.gypi:
dom/Document.cpp: (WebCore::Document::Document):
dom/Document.h:
dom/RequestAnimationFrameCallback.h: Removed.
dom/RequestAnimationFrameCallback.idl: Removed.
loader/EmptyClients.h:
page/Chrome.cpp:
page/Chrome.h:
page/ChromeClient.h:
page/DOMWindow.cpp:
page/DOMWindow.h:
page/DOMWindow.idl:
page/FrameView.cpp:
page/FrameView.h:
platform/HostWindow.h:

2011-01-19 James Robinson <jamesr@chromium.org>

Unreviewed, rolling out r76194.
http://trac.webkit.org/changeset/76194
https://bugs.webkit.org/show_bug.cgi?id=51218

Caused mysterious compile failure on the chromium win
build.webkit.org bots

features.gypi:
public/WebWidget.h:
public/WebWidgetClient.h:
src/ChromeClientImpl.cpp:
src/ChromeClientImpl.h:
src/WebPopupMenuImpl.cpp:
src/WebPopupMenuImpl.h:
src/WebViewImpl.cpp:
src/WebViewImpl.h:

2011-01-19 James Robinson <jamesr@chromium.org>

Unreviewed, rolling out r76194.
http://trac.webkit.org/changeset/76194
https://bugs.webkit.org/show_bug.cgi?id=51218

Caused mysterious compile failure on the chromium win
build.webkit.org bots

DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::paintInvalidatedRegion):
DumpRenderTree/chromium/WebViewHost.h:

7:46 PM Changeset in webkit [76197] by Simon Fraser

2 edits in trunk/Source/WebKit2

2011-01-19 Simon Fraser <Simon Fraser>

Fix the WebKit2 build.

WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm: (WebKit::LayerBackedDrawingArea::syncCompositingLayers):

7:20 PM Changeset in webkit [76196] by Simon Fraser

12 edits in trunk/Source

2011-01-19 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig.

GraphicsLayers in subframes can get sync'd multiple times
https://bugs.webkit.org/show_bug.cgi?id=52489

Some cleanup that will work towards fixing this bug.

Tested by existing iframe compositing tests.

WebCore.exp.in: syncCompositingStateRecursive() was renamed to syncCompositingStateIncludingSubframes().

page/FrameView.h:
page/FrameView.cpp: (WebCore::FrameView::syncCompositingStateForThisFrame): Some code cleanup: do all the word we need to do for this frame, including the needsLayout() check. (WebCore::FrameView::syncCompositingStateIncludingSubframes): This is no longer recursive; instead, it iterates over descendant frames via the frame tree, calling syncCompositingStateForThisFrame() on each Frame's view.

rendering/RenderLayerCompositor.h: (WebCore::RenderLayerCompositor::isFlushingLayers): Getter for the flag.
rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::RenderLayerCompositor): (WebCore::RenderLayerCompositor::flushPendingLayerChanges): Maintain a flag to say if we're flushing, which allows us to assert on re-entrant flushes. (WebCore::RenderLayerCompositor::enclosingCompositorFlushingLayers): Add the ability to get the rootmost compositor that is in the middle of a flush.

7:14 PM Changeset in webkit [76195] by dpranke@chromium.org

5 edits in trunk/Tools

2011-01-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

remove fs refs from test_runner, dump_render_tree_thread

https://bugs.webkit.org/show_bug.cgi?id=52753

Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

6:59 PM Changeset in webkit [76194] by jamesr@google.com

33 edits
13 adds in trunk

2011-01-19 James Robinson <jamesr@chromium.org>

Reviewed by Darin Fisher.

Implement mozilla's requestAnimationFrame API
https://bugs.webkit.org/show_bug.cgi?id=51218

Tests for window.webkitRequestAnimationFrame(). The new tests
are in the Skipped lists for platforms that do not set
ENABLE(REQUEST_ANIMATION_FRAME) - which is currently all but chromium.

fast/animation/request-animation-frame-cancel-expected.txt: Added.
fast/animation/request-animation-frame-cancel.html: Added.

Tests cancelling a callback within a webkitRequestAnimationFrame() callback.

fast/animation/request-animation-frame-cancel2-expected.txt: Added.
fast/animation/request-animation-frame-cancel2.html: Added.

Tests interactions between multiple webkitRequestAnimationFrame() callbacks.

fast/animation/request-animation-frame-display-expected.txt: Added.
fast/animation/request-animation-frame-display.html: Added.

Tests changing the display: property of an element within a callback.

fast/animation/request-animation-frame-expected.txt: Added.
fast/animation/request-animation-frame.html: Added.

Tests the basic use of window.webkitRequestAnimationFrame().

fast/animation/request-animation-frame-within-callback-expected.txt: Added.
fast/animation/request-animation-frame-within-callback.html: Added.

Tests setting one webkit.webkitRequestAnimationFrame() callback within another.

platform/gtk/Skipped:
platform/mac/Skipped:
platform/qt/Skipped:
platform/win/Skipped:

2011-01-19 James Robinson <jamesr@chromium.org>

Reviewed by Darin Fisher.

Implement mozilla's requestAnimationFrame API
https://bugs.webkit.org/show_bug.cgi?id=51218

This implements mozilla's proposed requestAnimationFrame API. The idea with this API is that
an author driving an animation from script could use window.requestAnimationFrame(callback)
instead of window.setTimeout(callback, 0) to schedule their update logic and let the browser
decide when to update the animations. This avoids doing unnecessary work when the page content
is offscreen or is being displayed at a different framerate than what the page author expects.

Mozilla's proposal is here: https://developer.mozilla.org/en/DOM/window.mozRequestAnimationFrame
This implements window.mozRequestAnimationFrame as window.webkitRequestAnimationFrame with the
following changes:
*) Only the callback syntax is supported, there is no before paint event
*) webkitRequestAnimationFrame supports a second parameter Element to let the author indicate

what content they intend to animate. That way if the page is being displayed but the element
in question is offscreen, we can avoid invoking the callback.

*) No timestamp is provided to the caller and there is no window.animationStartTime property

(see https://bugs.webkit.org/show_bug.cgi?id=51952 for discussion of this property)

*) window.webkitRequestAnimationFrame returns a numerical id that can be used to cancel the callback

using window.cancelWebkitRequestAnimationFrame, to parallel window.setTimeout()/window.clearTime().

The implementation depends on the embedder scheduling the callbacks since the callback invocation
depends on the page's visibility and the embedder's paint scheduling, neither of which are exposed
to WebCore. The expectation for the embedder is that at some point Chrome::scheduleAnimation() is
called FrameView::serviceScriptedAnimations() should be called for the associated Page's main frame.
Ideally serviceScriptedAnimations() would be called prior to rendering - although in practice the
embedder has to rate limit callbacks and may not be able to tie the callback directly to the
rendering loop.

Tests: fast/animation/request-animation-frame-cancel.html

fast/animation/request-animation-frame-cancel2.html
fast/animation/request-animation-frame-display.html
fast/animation/request-animation-frame-within-callback.html
fast/animation/request-animation-frame.html

WebCore.gypi:
dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::webkitRequestAnimationFrame): (WebCore::Document::webkitCancelRequestAnimationFrame): (WebCore::Document::serviceScriptedAnimations):
dom/Document.h:
dom/RequestAnimationFrameCallback.h: Added. (WebCore::RequestAnimationFrameCallback::~RequestAnimationFrameCallback):
dom/RequestAnimationFrameCallback.idl: Added.
loader/EmptyClients.h: (WebCore::EmptyChromeClient::scheduleAnimation):
page/Chrome.cpp: (WebCore::Chrome::scheduleAnimation):
page/Chrome.h:
page/ChromeClient.h:
page/DOMWindow.cpp: (WebCore::DOMWindow::webkitRequestAnimationFrame): (WebCore::DOMWindow::webkitCancelRequestAnimationFrame):
page/DOMWindow.h:
page/DOMWindow.idl:
page/FrameView.cpp: (WebCore::FrameView::scheduleAnimation): (WebCore::FrameView::serviceScriptedAnimations):
page/FrameView.h:
platform/HostWindow.h:

2011-01-19 James Robinson <jamesr@chromium.org>

Reviewed by Darin Fisher.

Implement mozilla's requestAnimationFrame API
https://bugs.webkit.org/show_bug.cgi?id=51218

Chromium WebKit API support for window.webkitRequestAnimationFrame()

features.gypi:
public/WebWidget.h:
public/WebWidgetClient.h: (WebKit::WebWidgetClient::scheduleAnimation):
src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::scheduleAnimation):
src/ChromeClientImpl.h:
src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::animate): (WebKit::WebPopupMenuImpl::scheduleAnimation):
src/WebPopupMenuImpl.h:
src/WebViewImpl.cpp: (WebKit::WebViewImpl::animate):
src/WebViewImpl.h:

2011-01-19 James Robinson <jamesr@chromium.org>

Reviewed by Darin Fisher.

Implement mozilla's requestAnimationFrame API
https://bugs.webkit.org/show_bug.cgi?id=51218

Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.

DumpRenderTree/chromium/WebViewHost.cpp: (invokeScheduleComposite): (WebViewHost::scheduleAnimation): (WebViewHost::paintInvalidatedRegion):
DumpRenderTree/chromium/WebViewHost.h:

6:56 PM Changeset in webkit [76193] by ggaren@apple.com

4 edits in trunk/Source/JavaScriptCore

Rolled back in r76078, with crash fixed.
https://bugs.webkit.org/show_bug.cgi?id=52668

Reviewed by Darin Adler.

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::markChildren): Account for the fact that the global
object moves its variables into and out of the register file. While out
of the register file, the symbol table's size is not an accurate count
for the size of the register array, since the BytecodeGenerator might
be compiling, adding items to the symbol table.

6:49 PM Changeset in webkit [76192] by Martin Robinson

7 edits in trunk/Source/WebCore

2011-01-13 Martin Robinson <mrobinson@igalia.com>

Reviewed by Daniel Bates.

[GTK] Move progress bar painting out of gtk2drawing.c
https://bugs.webkit.org/show_bug.cgi?id=52385

Move progress bar painting to RenderThemeGtk2 and share some animation
logic between the GTK+ 2.x and GTK+ 3.x port.

No new tests. This should not change functionality.

platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::animationRepeatIntervalForProgressBar): Moved from RenderThemeGtk3. (WebCore::RenderThemeGtk::animationDurationForProgressBar): Ditto. (WebCore::RenderThemeGtk::calculateProgressRect): Calculate the proper rectangle for the progress indicator given the rect for the maximum size of the indicator.
platform/gtk/RenderThemeGtk.h: Added calculateProgressRect declaration and a new widget member for GTK+ 2.x
platform/gtk/RenderThemeGtk2.cpp: (WebCore::RenderThemeGtk::platformInit): Added initialization for the new widget member. (WebCore::RenderThemeGtk::paintProgressBar): Paint the progress bar manually instead of calling the old Mozilla code. (WebCore::RenderThemeGtk::gtkProgressBar): Added.
platform/gtk/RenderThemeGtk3.cpp: (WebCore::RenderThemeGtk::paintProgressBar): Call calculateProgressRect now to get the area of the progress indicator.
platform/gtk/gtk2drawing.c: Remove unused code. (moz_gtk_get_widget_border): (moz_gtk_widget_paint):
platform/gtk/gtkdrawing.h: Ditto.

6:18 PM Changeset in webkit [76191] by Darin Adler

6 edits in trunk/Source/WebKit/mac

2011-01-19 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Would like script debugging protocol method to differentiate between caught and uncaught exceptions
https://bugs.webkit.org/show_bug.cgi?id=52104
rdar://problem/8704226

WebView/WebDelegateImplementationCaching.h: Fix type of second integer in CallScriptDebugDelegate function overload to be int to match the actual Objective-C method. Added a new overload that includes a BOOL in the right place. Added a boolean named exceptionWasRaisedExpectsHasHandlerFlag.

WebView/WebDelegateImplementationCaching.mm: (CallDelegate): Added overloads as above. (CallScriptDebugDelegate): Ditto.

WebView/WebScriptDebugDelegate.h: Added new method with the additional boolean argument. Marked the old method informally deprecated.

WebView/WebScriptDebugger.mm: (WebScriptDebugger::exception): Added code to call with or without the boolean depending on exceptionWasRaisedExpectsHasHandlerFlag.

WebView/WebView.mm: (-[WebView _cacheScriptDebugDelegateImplementations]): Set up the exceptionWasRaisedExpectsHasHandlerFlag. Also fixed old code that was not guaranteed to set didParseSourceExpectsBaseLineNumber to NO.

6:16 PM Changeset in webkit [76190] by dpranke@chromium.org

3 edits in trunk/Tools

2011-01-19 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.

Fix a few incorrect "self._filesystem" references introduced in
r76184.

Scripts/webkitpy/layout_tests/port/chromium.py:
Scripts/webkitpy/layout_tests/port/chromium_linux.py:

6:13 PM Changeset in webkit [76189] by dimich@chromium.org

22 edits in trunk

[Chromium] Not reviewed, reverts the following changes:
http://trac.webkit.org/changeset/76164 (build fix)
http://trac.webkit.org/changeset/76159 (main change)

The change broke Chromium Linux-shlib build.

Original issue:
Accelerated canvas2D has bad clipping performance.
https://bugs.webkit.org/show_bug.cgi?id=52627

Source/WebCore:

WebCore.gyp/WebCore.gyp:
WebCore.gypi:
html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::reset):
(WebCore::CanvasRenderingContext2D::platformLayer):

platform/graphics/chromium/DrawingBufferChromium.cpp:

(WebCore::DrawingBuffer::DrawingBuffer):

platform/graphics/chromium/GLES2Canvas.cpp:

(WebCore::GLES2Canvas::State::State):
(WebCore::GLES2Canvas::clearRect):
(WebCore::GLES2Canvas::fillRect):
(WebCore::GLES2Canvas::restore):
(WebCore::GLES2Canvas::drawTexturedRect):

platform/graphics/chromium/GLES2Canvas.h:
platform/graphics/gpu/DrawingBuffer.cpp:

(WebCore::DrawingBuffer::clear):
(WebCore::DrawingBuffer::createSecondaryBuffers):
(WebCore::DrawingBuffer::reset):

platform/graphics/gpu/DrawingBuffer.h:
platform/graphics/gpu/SharedGraphicsContext3D.cpp:

(WebCore::SharedGraphicsContext3D::create):

platform/graphics/gpu/SharedGraphicsContext3D.h:
platform/graphics/gpu/mac/DrawingBufferMac.mm:

(WebCore::DrawingBuffer::DrawingBuffer):

platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::canvasClip):
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::fillPath):

platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::canAccelerate):
(WebCore::PlatformContextSkia::uploadSoftwareToHardware):

thirdparty/glu/README.webkit:
thirdparty/glu/gluos.h:
thirdparty/glu/libtess/geom.c:
thirdparty/glu/libtess/priorityq.c:
thirdparty/glu/libtess/render.c:
thirdparty/glu/libtess/sweep.c:

(IsWindingInside):
(DoneEdgeDict):

LayoutTests:

platform/chromium-gpu/test_expectations.txt:

6:10 PM Changeset in webkit [76188] by bweinstein@apple.com

3 edits in trunk/Source/WebKit2

WebKit2: Need API to get the parent frame of a frame
https://bugs.webkit.org/show_bug.cgi?id=52774

Reviewed by Darin Adler.

Add the API to get the parent frame of a frame.

UIProcess/API/C/WKFrame.cpp:

(WKFrameGetParentFrame):

UIProcess/API/C/WKFrame.h:

6:03 PM Changeset in webkit [76187] by leviw@chromium.org

3 edits
1 copy
4 adds in trunk

2011-01-19 Levi Weintraub <leviw@google.com>

Reviewed by Darin Adler.

Re-committing this with the proper expected results.

Changing RenderText::localCaretRect to clip to its containing block's logicalLeft and
logicalRightLayoutOverflow instead of simply using logicalLeft and logicalRight, as this
resulted in the caret being placed incorrectly in overflowing editable IFrame content.

Long lines in non-white-space-pre editable documents show cursor in wrong place
https://bugs.webkit.org/show_bug.cgi?id=48132

editing/selection/caret-painting-in-overflowing-autowrap-content.html: Added.
editing/selection/resources/iframe-positioning-caret-at-end.html: Added.
platform/mac/editing/selection/caret-painting-in-overflowing-autowrap-content-expected.checksum: Added.
platform/mac/editing/selection/caret-painting-in-overflowing-autowrap-content-expected.png: Added.
platform/mac/editing/selection/caret-painting-in-overflowing-autowrap-content-expected.txt: Added.

2011-01-19 Levi Weintraub <leviw@google.com>

Reviewed by Darin Adler.

Re-committing this with the proper expected results.

Changing RenderText::localCaretRect to clip to its containing block's logicalLeft and
logicalRightLayoutOverflow instead of simply using logicalLeft and logicalRight, as this
resulted in the caret being placed incorrectly in overflowing editable IFrame content.

Long lines in non-white-space-pre editable documents show cursor in wrong place
https://bugs.webkit.org/show_bug.cgi?id=48132

Test: editing/selection/caret-painting-in-overflowing-autowrap-content.html

rendering/RenderText.cpp: (WebCore::RenderText::localCaretRect):

5:56 PM Changeset in webkit [76186] by enrica@apple.com

15 edits
3 adds in trunk/Source/WebKit2

WebKit2: add support for drag and drop
https://bugs.webkit.org/show_bug.cgi?id=52343
<rdar://problem/7660558>

Reviewed by Darin Adler.

This patch contains the remaining work to support drag and drop on Mac.
I've added a PasteboardTypes class to encapsulate all the pasteboard formats
supported for drag and drop.
In this implementation we don't support the promised types, since I could not
find an efficient way to do this across processes.
The bulk of the patch consists in creating a shareable bitmap for the drag image,
pass its handle to the UI process and create a new NSImage from it to be given to
AppKit for dragging.
I've added the missing implementation of the methods in the drag client to hook
up the placement of the data in the pasteboard.

Shared/mac/PasteboardTypes.h: Added.
Shared/mac/PasteboardTypes.mm: Added.

(WebKit::PasteboardTypes::forEditing):
(WebKit::PasteboardTypes::forURL):
(WebKit::PasteboardTypes::forImages):
(WebKit::PasteboardTypes::forImagesWithArchive):

UIProcess/API/mac/PageClientImpl.h:
UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::setDragImage): Added.

UIProcess/API/mac/WKView.mm:

(-[WKView _registerDraggedTypes]): Refactored to use the new PasteboardTypes class.
(-[WKView initWithFrame:contextRef:pageGroupRef:]):
(-[WKView _setMouseDownEvent:]):
(-[WKView _mouseHandler:]):
(-[WKView mouseDown:]):
(-[WKView mouseUp:]):
(-[WKView mouseDragged:]):
(-[WKView draggedImage:endedAt:operation:]):
(-[WKView draggingEntered:]):
(-[WKView _setDragImage:at:linkDrag:]):

UIProcess/API/mac/WKViewInternal.h:
UIProcess/PageClient.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setDragImage):
(WebKit::WebPageProxy::dragEnded):

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
WebKit2.xcodeproj/project.pbxproj:
WebProcess/WebCoreSupport/WebDragClient.cpp:
WebProcess/WebCoreSupport/WebDragClient.h:
WebProcess/WebCoreSupport/mac/WebDragClientMac.mm: Added.

(WebKit::fontFromNSFont):
(WebKit::WebDragClient::startDrag): Added implementation.
(WebKit::WebDragClient::createDragImageForLink): Ditto.
(WebKit::writeURL): Helper function.
(WebKit::writeImage): Helper function.
(WebKit::WebDragClient::declareAndWriteDragImage): Added implementation.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::dragEnded):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

5:53 PM Changeset in webkit [76185] by Darin Adler

13 edits
5 adds in trunk

2011-01-18 Darin Adler <Darin Adler>

Reviewed by Geoffrey Garen.

Stack overflow when converting an Error object to string
https://bugs.webkit.org/show_bug.cgi?id=46410

fast/js/script-tests/toString-recursion.js: Added.
fast/js/toString-recursion-expected.txt: Added.
fast/js/toString-recursion.html: Added.

2011-01-18 Darin Adler <Darin Adler>

Reviewed by Geoffrey Garen.

Stack overflow when converting an Error object to string
https://bugs.webkit.org/show_bug.cgi?id=46410

Android.mk: Added StringRecursionChecker.cpp and StringRecursionChecker.h.
CMakeLists.txt: Ditto.
GNUmakefile.am: Ditto.
JavaScriptCore.gypi: Ditto.
JavaScriptCore.pro: Ditto.
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Ditto.
JavaScriptCore.xcodeproj/project.pbxproj: Ditto.

runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncToString): Use StringRecursionChecker instead of the older hand-written code to do the same thing. (JSC::arrayProtoFuncToLocaleString): Ditto. (JSC::arrayProtoFuncJoin): Ditto.

runtime/ErrorPrototype.cpp: (JSC::errorProtoFuncToString): Use StringRecursionChecker.

runtime/JSGlobalData.h: Renamed arrayVisitedElements to stringRecursionCheckVisitedObjects.

runtime/RegExpPrototype.cpp: (JSC::regExpProtoFuncToString): Use StringRecursionChecker.

runtime/StringRecursionChecker.cpp: Added.
runtime/StringRecursionChecker.h: Added.

5:49 PM Changeset in webkit [76184] by dpranke@chromium.org

11 edits in trunk/Tools

2011-01-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

add a .sep property, abspath(), isabs(), mtime(), and
open_text_file_for_writing() to filesystem modules. Some of
these properties are not needed in this patch but will be needed
in subsequent patches (I'm doing this to avoid having to track
multiple versions of a single file).

Also, change most of the port/* modules to use the filesystem
objects instead of referencing the filesystem directly.

https://bugs.webkit.org/show_bug.cgi?id=52748

Scripts/webkitpy/common/system/filesystem.py:
Scripts/webkitpy/common/system/filesystem_mock.py:
Scripts/webkitpy/layout_tests/port/init.py:
Scripts/webkitpy/layout_tests/port/base.py:
Scripts/webkitpy/layout_tests/port/base_unittest.py:
Scripts/webkitpy/layout_tests/port/chromium.py:
Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
Scripts/webkitpy/layout_tests/port/config.py:
Scripts/webkitpy/layout_tests/port/test.py:
Scripts/webkitpy/layout_tests/port/test_files_unittest.py:

5:24 PM Changeset in webkit [76183] by morrita@google.com

3 edits in trunk/Source/WebCore

2011-01-18 MORITA Hajime <morrita@google.com>

Reviewed by David Levin.

ElementRareData::m_shadowRoot should not be RefPtr.
https://bugs.webkit.org/show_bug.cgi?id=51914

Makes ElementRareData::m_shadowRoot a raw pointer because
ElementRareData::m_shadowRoot should be like a
ContaineNode::m_firstChild, which is also a raw pointer.
pointer. Which also means that both the shadow root and the shadow
host reference each other as a parent-and-child relationship, via
a raw pointer.

Note that it is safe not to manipulate the ref-count of
m_shadowRoot because Node::m_parent of the shadow root points its
shadow host, and the object isn't deleted even if the refcount is
zero, as long as the node has non-null m_parent. (See TreeShared.)

The shadow root node is finally destroyed inside
removeShadowRoot(), where we store the root node into a local
RefPtr, then make the node's m_parent null, which results the
destroy the node, at the end of the function, by RefPtr::~RefPtr.

No new tests. No behavioral change.

dom/Element.cpp: (WebCore::Element::~Element): (WebCore::Element::shadowRoot): (WebCore::Element::setShadowRoot): (WebCore::Element::removeShadowRoot):
dom/ElementRareData.h: (WebCore::ElementRareData::ElementRareData): (WebCore::ElementRareData::~ElementRareData):

5:03 PM Changeset in webkit [76182] by Martin Robinson

6 edits in trunk/Source/WebCore

2011-01-12 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Move text field painting out of gtk2drawing.c
https://bugs.webkit.org/show_bug.cgi?id=52327

No new tests. This should not change behavior.

platform/gtk/RenderThemeGtk2.cpp: (WebCore::RenderThemeGtk::paintButton): Use the setWidgetHasFocus helper. (WebCore::RenderThemeGtk::paintTextField): Do this manually now instead of calling into the Mozilla code.
platform/gtk/WidgetRenderingContext.cpp: Added a couple more wrappers for GTK+ theme functions. (WebCore::WidgetRenderingContext::gtkPaintFlatBox): (WebCore::WidgetRenderingContext::gtkPaintShadow):
platform/gtk/WidgetRenderingContext.h: Added new method declarations.
platform/gtk/gtk2drawing.c: Remove unused code. (moz_gtk_get_widget_border): (moz_gtk_widget_paint):
platform/gtk/gtkdrawing.h:

4:40 PM Changeset in webkit [76181] by andersca@apple.com

2 edits in trunk/Source/WebKit2

2011-01-19 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Put the deprecated Connection member functions next to eachother
https://bugs.webkit.org/show_bug.cgi?id=52767

Platform/CoreIPC/Connection.h: (CoreIPC::Connection::sendSync): (CoreIPC::Connection::send):

4:35 PM Changeset in webkit [76180] by oliver@apple.com

13 edits in trunk

2011-01-19 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Remove non-spec support for callable RegExp
https://bugs.webkit.org/show_bug.cgi?id=28285

Update test results for new behaviour.

fast/js/sputnik/Conformance/11_Expressions/11.4_Unary_Operators/11.4.3_The_typeof_Operator/S11.4.3_A3.6-expected.txt:
fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.7/S15.10.7_A1_T1-expected.txt:
fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.7/S15.10.7_A1_T2-expected.txt:
fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.7/S15.10.7_A3_T1-expected.txt:
fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.7/S15.10.7_A3_T2-expected.txt:
fast/loader/stateobjects/pushstate-object-types-expected.txt:
fast/regex/cross-frame-callable-expected.txt:
fast/regex/script-tests/cross-frame-callable.js: (doTest):

2011-01-19 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Remove non-spec support for callable RegExp
https://bugs.webkit.org/show_bug.cgi?id=28285

Remove support for callable regexps. If it breaks sites we can
just roll this out.

runtime/RegExpObject.cpp:
runtime/RegExpObject.h:
tests/mozilla/expected.html: update results.

4:27 PM Changeset in webkit [76179] by andersca@apple.com

3 edits in trunk/Source/WebKit2

2011-01-19 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

When resizing, the web process should repaint the page
https://bugs.webkit.org/show_bug.cgi?id=52764

UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::didSetSize): Incorporate the update.

(WebKit::DrawingAreaProxyImpl::incorporateUpdate):
Return early if the update bounds rect is empty. This can happen if painting is
disabled and we get a DidSetSize message.

WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::setSize): If painting is disabled, just send back an empty UpdateInfo struct. Otherwise, paint and fill in the UpdateInfo struct.

(WebKit::DrawingAreaImpl::display):
Assert that painting is not disabled.

4:13 PM Changeset in webkit [76178] by mjs@apple.com

2 edits in trunk/Tools

2011-01-19 Maciej Stachowiak <mjs@apple.com>

Reviewed by Anders Carlsson.

If resetting between tests times out, treat it as a WebProcess crash
https://bugs.webkit.org/show_bug.cgi?id=52757

WebKitTestRunner/TestController.cpp: (WTR::TestController::runTest):

4:13 PM Changeset in webkit [76177] by Antti Koivisto

11 edits in trunk/Source

Cache function offsets to speed up javascript parsing
https://bugs.webkit.org/show_bug.cgi?id=52622

Reviewed by Oliver Hunt.

Use cache to save function offsets and some other info.
This avoids quite a bit of work when reparsing the source.

Source/JavaScriptCore:

parser/ASTBuilder.h:
parser/JSParser.cpp:

(JSC::JSParser::CachedFunctionInfo::CachedFunctionInfo):
(JSC::JSParser::CachedFunctionInfo::approximateByteSize):
(JSC::JSParser::CachedFunctionInfo::closeBraceToken):
(JSC::JSParser::Scope::copyCapturedVariablesToVector):
(JSC::JSParser::Scope::saveFunctionInfo):
(JSC::JSParser::Scope::restoreFunctionInfo):
(JSC::JSParser::findCachedFunctionInfo):
(JSC::JSParser::JSParser):
(JSC::JSParser::parseProgram):
(JSC::JSParser::parseFunctionInfo):

parser/Lexer.h:

(JSC::Lexer::setOffset):
(JSC::Lexer::setLineNumber):
(JSC::Lexer::sourceProvider):

parser/SourceProvider.h:

(JSC::SourceProviderCache::SourceProviderCache):
(JSC::SourceProviderCache::~SourceProviderCache):
(JSC::SourceProviderCache::byteSize):
(JSC::SourceProviderCache::add):
(JSC::SourceProviderCache::get):
(JSC::SourceProvider::SourceProvider):
(JSC::SourceProvider::~SourceProvider):
(JSC::SourceProvider::cache):
(JSC::SourceProvider::notifyCacheSizeChanged):
(JSC::SourceProvider::cacheSizeChanged):

parser/SyntaxChecker.h:

Source/WebCore:

bindings/js/CachedScriptSourceProvider.h:

(WebCore::CachedScriptSourceProvider::cache):
(WebCore::CachedScriptSourceProvider::cacheSizeChanged):
(WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider):

bindings/js/ScriptSourceProvider.h:

(WebCore::ScriptSourceProvider::ScriptSourceProvider):

loader/cache/CachedScript.cpp:

(WebCore::CachedScript::destroyDecodedData):
(WebCore::CachedScript::sourceProviderCache):
(WebCore::CachedScript::sourceProviderCacheSizeChanged):

loader/cache/CachedScript.h:

4:01 PM Changeset in webkit [76176] by mrowe@apple.com

2 edits in trunk/Source/JavaScriptCore

Follow-up to r75766 / <rdar://problem/5469576>.

Reviewed by Darin Adler.

DerivedSources.make: Evaluate the SDKROOT variable correctly.

3:45 PM Changeset in webkit [76175] by Martin Robinson

24 edits in trunk

2011-01-11 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Move toggle button rendering out of gtk2drawing.c
https://bugs.webkit.org/show_bug.cgi?id=52258

Updated results. The metrics of checkboxes and radio buttons have changed,
because the focus rect is no longer considered to be part of the button.

platform/gtk/fast/css/non-standard-checkbox-size-expected.txt
platform/gtk/fast/forms/001-expected.txt:
platform/gtk/fast/forms/basic-inputs-expected.txt:
platform/gtk/fast/forms/box-shadow-override-expected.txt:
platform/gtk/fast/forms/checkbox-radio-onchange-expected.txt:
platform/gtk/fast/forms/file-input-disabled-expected.txt:
platform/gtk/fast/forms/form-element-geometry-expected.txt:
platform/gtk/fast/forms/formmove-expected.txt:
platform/gtk/fast/forms/formmove2-expected.txt:
platform/gtk/fast/forms/indeterminate-expected.txt:
platform/gtk/fast/forms/input-appearance-height-expected.txt:
platform/gtk/fast/forms/input-value-expected.txt:
platform/gtk/fast/forms/radio-attr-order-expected.txt:
platform/gtk/fast/forms/radio-nested-labels-expected.txt:
platform/gtk/fast/forms/radio_checked-expected.txt:
platform/gtk/fast/forms/radio_checked_dynamic-expected.txt:

2011-01-11 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Move toggle button rendering out of gtk2drawing.c
https://bugs.webkit.org/show_bug.cgi?id=52258

platform/gtk/RenderThemeGtk.h:
platform/gtk/RenderThemeGtk2.cpp: (WebCore::RenderThemeGtk::platformInit): Initialize new button members. (WebCore::adjustRectForFocus): Added this function which inflates a rect based on a widget's exterior focus. (WebCore::RenderThemeGtk::adjustRepaintRect): Account for exterior focus. (WebCore::setToggleSize): Only listen to indicator-size to properly size checkboxes and radio buttons. (WebCore::RenderThemeGtk::setCheckboxSize): Call new setToggleSize properly. (WebCore::paintToggle): Added. (WebCore::RenderThemeGtk::paintCheckbox): Call paintToggle. (WebCore::RenderThemeGtk::setRadioSize): Call new setToggleSize properly. (WebCore::RenderThemeGtk::paintRadio): Call paintToggle. (WebCore::RenderThemeGtk::gtkRadioButton): Added. (WebCore::RenderThemeGtk::gtkCheckButton): Added.
platform/gtk/WidgetRenderingContext.cpp: (WebCore::WidgetRenderingContext::WidgetRenderingContext): Use a static extra space variable. This is good enough for all themes that I've tested and prevents having to pass information from RenderThemeGtk about every single type of widget. (WebCore::WidgetRenderingContext::gtkPaintFocus): Use the paintRect to draw instead of m_paintRect. This is important when we're painting something that isn't the size of the total rect. (WebCore::WidgetRenderingContext::gtkPaintCheck): Added. (WebCore::WidgetRenderingContext::gtkPaintOption): Added.
platform/gtk/WidgetRenderingContext.h: Updated to reflect new methods.
platform/gtk/gtkdrawing.h: Remove newly unused code.
platform/gtk/gtk2drawing.c: Ditto.

3:38 PM Changeset in webkit [76174] by tonyg@chromium.org

2 edits in trunk/Source/WebCore

2011-01-19 Tony Gentilcore <tonyg@chromium.org>

Unreviewed build fix.

Build fix for r76170
https://bugs.webkit.org/show_bug.cgi?id=52758

platform/graphics/chromium/UniscribeHelperTextRun.cpp:

3:23 PM Changeset in webkit [76173] by ddkilzer@apple.com

4 edits in trunk/Source/WebCore

<http://webkit.org/b/52687> Clean up FrameLoader methods for PLUGIN_PROXY_FOR_VIDEO

Reviewed by Eric Carlson.

loader/FrameLoader.cpp: Declare the methods here.

(WebCore::FrameLoader::hideMediaPlayerProxyPlugin):
(WebCore::FrameLoader::showMediaPlayerProxyPlugin):

loader/FrameLoader.cpp: Moved methods to here...

(WebCore::FrameLoader::hideMediaPlayerProxyPlugin):
(WebCore::FrameLoader::showMediaPlayerProxyPlugin):

loader/SubframeLoader.cpp: ...from here.

(WebCore::FrameLoader::hideMediaPlayerProxyPlugin):
(WebCore::FrameLoader::showMediaPlayerProxyPlugin):

3:21 PM Changeset in webkit [76172] by Martin Robinson

2 edits in trunk/LayoutTests

2011-01-19 Martin Robinson <mrobinson@igalia.com>

Unskip a test now that the 32-bit debug bot has the 2.4 series of FreeType.

platform/gtk/Skipped: Unskip a test.

3:19 PM Changeset in webkit [76171] by commit-queue@webkit.org

2 edits
1 add in trunk/LayoutTests

2011-01-19 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76166.
http://trac.webkit.org/changeset/76166
https://bugs.webkit.org/show_bug.cgi?id=52755

The platform-specific baseline should not be removed yet.
(Requested by dglazkov on #webkit).

platform/chromium-win/fast/forms/slider-mouse-events-expected.txt: Added.
platform/chromium/test_expectations.txt:

3:13 PM Changeset in webkit [76170] by tonyg@chromium.org

52 edits in trunk/Source

2011-01-19 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Mihai Parparita.

Perform some forward declaration
https://bugs.webkit.org/show_bug.cgi?id=52522

No new tests because no new functionality.

accessibility/AccessibilityObject.h:
css/WebKitCSSMatrix.cpp:
html/HTMLAreaElement.cpp:
html/canvas/CanvasRenderingContext2D.cpp:
inspector/InspectorController.cpp:
platform/graphics/FloatPoint.cpp:
platform/graphics/Font.cpp:
platform/graphics/Font.h:
platform/graphics/FontFastPath.cpp:
platform/graphics/GraphicsContext.cpp:
platform/graphics/ImageBuffer.h:
platform/graphics/StringTruncator.cpp:
platform/graphics/WidthIterator.cpp:
platform/graphics/mac/ComplexTextController.cpp:
platform/graphics/mac/ComplexTextControllerCoreText.cpp:
platform/graphics/mac/FontComplexTextMac.cpp:
platform/graphics/transforms/TransformationMatrix.cpp:
platform/graphics/transforms/TransformationMatrix.h:
rendering/EllipsisBox.cpp:
rendering/InlineTextBox.cpp:
rendering/RenderBlock.cpp:
rendering/RenderBlockLineLayout.cpp:
rendering/RenderEmbeddedObject.cpp:
rendering/RenderFileUploadControl.cpp:
rendering/RenderFlexibleBox.cpp:
rendering/RenderImage.cpp:
rendering/RenderListBox.cpp:
rendering/RenderListMarker.cpp:
rendering/RenderMenuList.cpp:
rendering/RenderObject.h:
rendering/RenderText.cpp:
rendering/RenderTextControl.cpp:
rendering/svg/SVGInlineTextBox.cpp:
rendering/svg/SVGMarkerLayoutInfo.h:
rendering/svg/SVGTextMetrics.cpp:
svg/SVGFont.cpp:

2011-01-19 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Mihai Parparita.

Perform some forward declaration
https://bugs.webkit.org/show_bug.cgi?id=52522

Misc/WebKitNSStringExtras.mm:

3:12 PM Changeset in webkit [76169] by mjs@apple.com

2 edits
3 adds in trunk/LayoutTests

2011-01-19 Maciej Stachowiak <mjs@apple.com>

Reviewed by Anders Carlsson.

Skip/fix remaining WebKit2 test failures
https://bugs.webkit.org/show_bug.cgi?id=52744

platform/mac-wk2/fast/blockflow/Kusa-Makura-background-canvas-expected.txt: Added WebKit2 mac results. It turns out that WebKit1 on Mac is the only port to report a scroll position other than 0, 0 for this test, so the WebKit2 results are arguably more correct.
platform/mac-wk2/fast/blockflow: Added.
platform/mac-wk2/fast: Added.
platform/mac-wk2/Skipped: Skip a few more tests. (And unskip in some cases where the failures were caused by other tests.)

2:53 PM Changeset in webkit [76168] by dimich@chromium.org

3 edits in trunk/LayoutTests

2011-01-19 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76152.
http://trac.webkit.org/changeset/76152
https://bugs.webkit.org/show_bug.cgi?id=52750

The original change (76144) was rolled out before (Requested
by dimich on #webkit).

platform/gtk/fast/forms/input-text-scroll-left-on-blur-expected.txt:
platform/gtk/fast/forms/plaintext-mode-2-expected.txt:

2:45 PM Changeset in webkit [76167] by ap@apple.com

11 edits in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=52739
Make it possible for a WebKit2 client to print headers and footers

UIProcess/API/C/WKPage.h:
UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::headerHeight): (WebKit::WebPageProxy::footerHeight): (WebKit::WebPageProxy::drawHeader): (WebKit::WebPageProxy::drawFooter):
UIProcess/WebPageProxy.h:
UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::headerHeight): (WebKit::WebUIClient::footerHeight): (WebKit::WebUIClient::drawHeader): (WebKit::WebUIClient::drawFooter):
UIProcess/WebUIClient.h: Pass UIClient calls through.

UIProcess/API/mac/WKView.mm: (currentPrintOperationScale): A helper to extract scale factor from the current NSPrintOperation. (-[WKView _adjustPrintingMarginsForHeaderAndFooter]): Copied from WebKit1. Change current print info to account for header and footer height as provided by the client. (-[WKView knowsPageRange:]): Call -[self _adjustPrintingMarginsForHeaderAndFooter]. (-[WKView drawPageBorderWithSize:]): When AppKit asks to print page border, call the client to do that. Code adapted form WebKit1.

UIProcess/API/qt/qwkpage: (QWKPage::QWKPage): Added zeroes for new WKPageUIClient members to avoid breaking the build.

2:45 PM Changeset in webkit [76166] by Dimitri Glazkov

2 edits
1 delete in trunk/LayoutTests

2011-01-19 Dimitri Glazkov <Dimitri Glazkov>

Removed platform-specific expectations for the test that matches
generic baseline after http://trac.webkit.org/changeset/76147.

platform/chromium-win/fast/forms/slider-mouse-events-expected.txt: Removed.
platform/chromium/test_expectations.txt: Removed expectation to fail.

2:29 PM Changeset in webkit [76165] by enne@google.com

4 edits in trunk/Source/WebCore

2011-01-19 Adrienne Walker <enne@google.com>

Reviewed by Kenneth Russell.

[chromium] Tiled compositor should use texture manager
https://bugs.webkit.org/show_bug.cgi?id=52418

Test: compositing/

platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::~LayerRendererChromium): (WebCore::LayerRendererChromium::cleanupSharedObjects):
platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::LayerTilerChromium): (WebCore::LayerTilerChromium::reset): (WebCore::LayerTilerChromium::createTile): (WebCore::LayerTilerChromium::update): (WebCore::LayerTilerChromium::draw):
platform/graphics/chromium/LayerTilerChromium.h: (WebCore::LayerTilerChromium::Tile::Tile): (WebCore::LayerTilerChromium::Tile::texture):

2:28 PM Changeset in webkit [76164] by senorblanco@chromium.org

2 edits in trunk/Source/WebCore

2011-01-19 Stephen White <senorblanco@chromium.org>

Unreviewed; build fix for chromium.

platform/graphics/chromium/GLES2Canvas.cpp: (WebCore::GLES2Canvas::fillPath):

2:26 PM Changeset in webkit [76163] by jberlin@webkit.org

5 edits in trunk/Source/WebKit2

Crash in WebDatabaseManagerProxy::getDatabaseOrigins when called after the WebProcess has
died at least once
https://bugs.webkit.org/show_bug.cgi?id=52730

Reviewed by Darin Adler.

WebDatabaseManagerProxy::invalidate was setting m_webContext to 0, and invalidate gets
called in WebContext::processDidClose. However, m_webContext is only set in the
constructor, which is only called from the constructor of WebContext, so attempting to send
a message to any new WebProcess after the first one died was causing a null deref.

This patch moves setting m_webcontext into clearContext and clearContext is only called in
the WebContext destructor.

This patch also adds checks for a valid WebProcessProxy before attempting to send messages to
the WebProcessProxy so that if the WebProcess has died and has not been revived, it does not
attempt to dereference a null WebProcessProxy.

UIProcess/WebContext.cpp:

(WebKit::WebContext::~WebContext):
Call WebDatabaseManagerProxy::clearContext.

UIProcess/WebContext.h:

(WebKit::WebContext::hasValidProcess):
Make this method public so that it can be called from WebDatabaseManagerProxy.

UIProcess/WebDatabaseManagerProxy.cpp:

(WebKit::WebDatabaseManagerProxy::getDatabasesByOrigin):
If there isn't a valid process, invalidate the callback and return early.
(WebKit::WebDatabaseManagerProxy::getDatabaseOrigins):
Ditto.
(WebKit::WebDatabaseManagerProxy::deleteDatabaseWithNameForOrigin):
If tehre isn't a valid process return early.
(WebKit::WebDatabaseManagerProxy::deleteDatabasesForOrigin):
Ditto.
(WebKit::WebDatabaseManagerProxy::deleteAllDatabases):
Ditto.
(WebKit::WebDatabaseManagerProxy::setQuotaForOrigin):
Ditto.
(WebKit::WebDatabaseManagerProxy::invalidate):
Move setting m_webContext to 0 from here ...

UIProcess/WebDatabaseManagerProxy.h:

(WebKit::WebDatabaseManagerProxy::clearContext):
... to here.

2:17 PM Changeset in webkit [76162] by tony@chromium.org

2 edits in trunk/Source/WebKit/chromium

2011-01-19 Tony Chang <tony@chromium.org>

Unreviewed, roll chromium deps to pick up fixes for the linux build.

DEPS:

2:14 PM Changeset in webkit [76161] by robert@webkit.org

3 edits in trunk/LayoutTests

2011-01-19 Robert Hogan <robert@webkit.org>

Unreviewed fix to r76153.

[Qt] Update expected results after r76153

Update missing expected results from r76153. Matches Mac.
Re-skip http/tests/misc/timer-vs-loading.html - it still times
out on the build bot.

https://bugs.webkit.org/show_bug.cgi?id=52395

platform/qt/Skipped:
platform/qt/http/tests/loading/simple-subframe-expected.txt:

2:12 PM Changeset in webkit [76160] by dpranke@chromium.org

2 edits in trunk/Tools

2011-01-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

Change webkitpy/layout_tests/port/test.py to use the
in-memory filesystem for cleaner unit testing. This
change allows us to kill a lot of code that was
specific to the test port, at the cost of being a
little less clear about how things would work if
you didn't have a filesystem.

https://bugs.webkit.org/show_bug.cgi?id=52605

Scripts/webkitpy/layout_tests/port/test.py:

2:11 PM Changeset in webkit [76159] by senorblanco@chromium.org

22 edits in trunk

2011-01-18 Stephen White <senorblanco@chromium.org>

Reviewed by James Robinson.

Add two to-be-rebaselined tests for the GPU path.

platform/chromium-gpu/test_expectations.txt:

2011-01-18 Stephen White <senorblanco@chromium.org>

Reviewed by James Robinson.

Implement accelerated path drawing and clipping for the Canvas2D GPU
path.
https://bugs.webkit.org/show_bug.cgi?id=52627

This is done with a simple curve interpolator and the GLU tesselator,
which is good enough for a 3-5X speedup on
http://ie.microsoft.com/testdrive/Performance/Galactic/Default.html.

Covered by canvas/philip/2d.path.clip.basic.html, and many, many more.
All tests canvas/philip and fast/canvas paths pass with no
regressions, although two have minor pixel differences which require
rebaselining.

WebCore.gyp/WebCore.gyp: Add internal_glu include path to chromium build.
WebCore.gypi: Add internal_glu files to chromium build.
html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::reset): (WebCore::CanvasRenderingContext2D::platformLayer): Make CanvasRenderingContext2D more robust against failure to create a DrawingBuffer.
platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::DrawingBuffer): As in DrawingBufferMac.cpp, call reset() from the constructor. Also initialize size to (-1, -1), so reset() doesn't early-out. Add initializers for depthBuffer and stencilBuffer, and remove multisampleDepthStencilBuffer.
platform/graphics/chromium/GLES2Canvas.cpp: Remove some unused #includes. (WebCore::GLES2Canvas::State::State): Add clipping state, and implement save/restore via the copy constructor. (WebCore::operator*): (WebCore::Quadratic::Quadratic): (WebCore::Quadratic::fromBezier): (WebCore::Quadratic::evaluate): Quadratic Bezier curve class. (WebCore::Cubic::Cubic): (WebCore::Cubic::fromBezier): (WebCore::Cubic::evaluate): Cubic Bezier curve class. (WebCore::GLES2Canvas::clearRect): Add clipping support to clearRect(). (WebCore::GLES2Canvas::fillPath): Implement fillPath(). (WebCore::GLES2Canvas::fillRect): Add clipping support to fillRect(). (WebCore::GLES2Canvas::clipPath): Implement clipPath(). (WebCore::GLES2Canvas::clipOut): Stub out clipOut() (not called by Canvas 2D). (WebCore::GLES2Canvas::restore): When restoring, draw any remaining clipping paths to the stencil buffer. (WebCore::GLES2Canvas::drawTexturedRect): Add clipping support. (WebCore::interpolateQuadratic): (WebCore::interpolateCubic): Simple curve interpolation, using the Cubic and Quadratic classes. (WebCore::PolygonData::PolygonData): A struct to hold the tesselation data for callbacks. (WebCore::beginData): (WebCore::edgeFlagData): (WebCore::vertexData): (WebCore::endData): (WebCore::combineData): internal_glu tesselation callbacks. (WebCore::GLES2Canvas::createVertexBufferFromPath): Build an interpolated, tesselated vertex buffer and element array buffer from a given path, suitable for filling. (WebCore::GLES2Canvas::beginStencilDraw): Enable stencilling, and disable draws to the color buffer. (WebCore::GLES2Canvas::applyClipping): If clipping is enabled, set the appropriate GL state.
platform/graphics/chromium/GLES2Canvas.h: Document the flavours of drawTexturedRect() a bit, so I don't get confused.
platform/graphics/gpu/DrawingBuffer.cpp: (WebCore::DrawingBuffer::clear): (WebCore::DrawingBuffer::createSecondaryBuffers): (WebCore::DrawingBuffer::resizeDepthStencil): (WebCore::DrawingBuffer::reset):
platform/graphics/gpu/DrawingBuffer.h: Unify m_multisampleDepthStencilBuffer with m_depthStencilBuffer. Implement separate depth and stencil buffers for when OES_packed_depth_stencil is not available. Refactor creation of multisampled and non-multisampled depth and stencil buffers into resizeDepthStencil().
platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::create): Turn on stencil, turn off depth, turn off antialiasing (for now). (WebCore::SharedGraphicsContext3D::enableStencil):
platform/graphics/gpu/SharedGraphicsContext3D.h: Implement stencil enable/disable.
platform/graphics/gpu/mac/DrawingBufferMac.mm: (WebCore::DrawingBuffer::DrawingBuffer): Remove m_multisampleDepthStencilBuffer. Set the size to (-1, -1) on creation, so reset() doesn't early-out. Initialize m_depthBuffer and m_stencilBuffer.
platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::canvasClip): (WebCore::GraphicsContext::clipOut): (WebCore::GraphicsContext::clipPath): (WebCore::GraphicsContext::fillPath): Put in GPU hooks for path clipping, and path drawing.
platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::canAccelerate): Don't check for clipping paths in canAccelerate() (since we can now accelerate them). (WebCore::PlatformContextSkia::uploadSoftwareToHardware): Don't do clipping when uploading software draws to hardware.
thirdparty/glu/README.webkit:
thirdparty/glu/gluos.h: #undef MIN and MAX, to fix warnings-as-errors in Chrome/Mac build.
thirdparty/glu/libtess/geom.c:
thirdparty/glu/libtess/priorityq.c:
thirdparty/glu/libtess/render.c: Use do{}while(0) instead of if(1)else construct in macro.
thirdparty/glu/libtess/sweep.c: (IsWindingInside): (DoneEdgeDict): Fix some warnings treated as errors for the Linux Release build.

2:04 PM Changeset in webkit [76158] by dpranke@chromium.org

2 edits in trunk/Tools

2011-01-19 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.

Fix test failure caused by committing attachment 79368 instead
of attachment 79461 on bug 52604.

Scripts/webkitpy/common/system/filesystem_mock.py:

1:56 PM Changeset in webkit [76157] by andersca@apple.com

10 edits in trunk/Source/WebKit2

2011-01-19 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Suspend/resume painting as the WKView visibility changes
https://bugs.webkit.org/show_bug.cgi?id=52738

UIProcess/DrawingAreaProxy.h: (WebKit::DrawingAreaProxy::visibilityDidChange): Add new member function. It should really be pure virtual once setPageIsVisible is removed.

UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::visibilityDidChange): Send SuspendPainting/ResumePainting messages based on whether the view is visible or not.

(WebKit::DrawingAreaProxyImpl::setPageIsVisible):
Make this a stub; it should really be removed.

UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::viewStateDidChange): Call visibilityDidChange.

UIProcess/WebPageProxy.h: (WebKit::WebPageProxy::isViewVisible): Add new getter.

WebProcess/WebPage/DrawingArea.messages.in: Add SuspendPainting and ResumePainting messages.

WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::DrawingAreaImpl): Initialize m_isPaintingSuspended.

(WebKit::DrawingAreaImpl::suspendPainting):
Set m_isPaintingSuspended to true and stop the display timer.

(WebKit::DrawingAreaImpl::resumePainting):
Set m_isPaintingSuspended to false.

(WebKit::DrawingAreaImpl::scheduleDisplay):
(WebKit::DrawingAreaImpl::display):
Bail if m_isPaintingSuspended is true.

1:48 PM Changeset in webkit [76156] by dimich@chromium.org

3 edits
5 deletes in trunk

2011-01-19 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76144.
http://trac.webkit.org/changeset/76144
https://bugs.webkit.org/show_bug.cgi?id=52737

Broke tests on multiple bots, mostly Chromium Canaries
(Requested by dimich on #webkit).

editing/selection/caret-painting-in-overflowing-autowrap-content.html: Removed.
editing/selection/resources/iframe-positioning-caret-at-end.html: Removed.
platform/mac/editing/selection/caret-painting-in-overflowing-autowrap-content-expected.checksum: Removed.
platform/mac/editing/selection/caret-painting-in-overflowing-autowrap-content-expected.png: Removed.
platform/mac/editing/selection/caret-painting-in-overflowing-autowrap-content-expected.txt: Removed.

2011-01-19 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76144.
http://trac.webkit.org/changeset/76144
https://bugs.webkit.org/show_bug.cgi?id=52737

Broke tests on multiple bots, mostly Chromium Canaries
(Requested by dimich on #webkit).

rendering/RenderText.cpp: (WebCore::RenderText::localCaretRect):

1:30 PM Changeset in webkit [76155] by dpranke@chromium.org

5 edits in trunk/Tools

2011-01-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
unit testing. os.walk() is too much of a hassle to implement on
top of the in-memory mock filesystem and adding the necessary
interface to files_under() gives clients a cleaner API anyway
(for this particular usage model).

https://bugs.webkit.org/show_bug.cgi?id=52691

Scripts/webkitpy/common/system/filesystem.py:
Scripts/webkitpy/common/system/filesystem_mock.py:
Scripts/webkitpy/layout_tests/port/test_files.py:
Scripts/webkitpy/layout_tests/port/test_files_unittest.py:

1:29 PM Changeset in webkit [76154] by Simon Fraser

3 edits
4 adds in trunk

2011-01-19 Simon Fraser <Simon Fraser>

Reviewed by Adam Roben.

[CSS Gradients] Crash due to out-of-memory with repeating-linear-gradient and latter stop positioned before former
https://bugs.webkit.org/show_bug.cgi?id=52732

When repeating gradient stops, make sure that the first and last stops are not at the same
place, otherwise we'll add stops indefinitely and run out of memory.

Test: fast/gradients/zero-range-repeating-gradient-hang.html

css/CSSGradientValue.cpp: (WebCore::CSSGradientValue::addStops):

1:25 PM Changeset in webkit [76153] by robert@webkit.org

2 edits in trunk/LayoutTests

2011-01-19 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Unskip passing http tests and annotate Skipped list
https://bugs.webkit.org/show_bug.cgi?id=52395

Unskip:
http/tests/security/xss-DENIED-xsl-document.xml
http/tests/loading/simple-subframe.html

platform/qt/Skipped:
platform/qt/http/tests/loading/simple-subframe-expected.txt:

1:15 PM Changeset in webkit [76152] by Martin Robinson

3 edits in trunk/LayoutTests

2011-01-19 Martin Robinson <mrobinson@igalia.com>

Rebaseline two GTK+ tests results after r76144.

platform/gtk/fast/forms/input-text-scroll-left-on-blur-expected.txt:
platform/gtk/fast/forms/plaintext-mode-2-expected.txt:

1:10 PM Changeset in webkit [76151] by Dimitri Glazkov

2 edits in trunk/LayoutTests

2011-01-19 Dimitri Glazkov <Dimitri Glazkov>

Added fast/forms/slider-mouse-events.html to expectations to make sure
the new results are good on all bots.

platform/chromium/test_expectations.txt: Tweaked expectations.

12:28 PM Changeset in webkit [76150] by dpranke@chromium.org

7 edits in trunk/Tools

2011-01-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

Change more modules in the layout-tests code to use the
filesystem wrapper for cleaner unit testing.

This patch also adds the glob() wrapper to the filesystem
abstraction.

https://bugs.webkit.org/show_bug.cgi?id=52604

Scripts/webkitpy/layout_tests/port/test_files.py:
Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
Scripts/webkitpy/common/system/filesystem.py:
Scripts/webkitpy/common/system/filesystem_mock.py:

12:19 PM Changeset in webkit [76149] by andreas.kling@nokia.com

2 edits in trunk/Source/WebKit2

2011-01-19 Andreas Kling <kling@webkit.org>

Reviewed by Simon Hausmann.

[Qt][WK2] Implement formatLocalizedString() for Qt.

WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::formatLocalizedString):

12:18 PM Changeset in webkit [76148] by oliver@apple.com

5 edits in trunk

2011-01-19 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

[jsfunfuzz] Defining a function called proto inside an eval triggers an assertion
https://bugs.webkit.org/show_bug.cgi?id=52672

Add tests to ensure that we disallow proto as a function name.

fast/js/parser-syntax-check-expected.txt:
fast/js/script-tests/parser-syntax-check.js:

2011-01-19 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

[jsfunfuzz] Defining a function called proto inside an eval triggers an assertion
https://bugs.webkit.org/show_bug.cgi?id=52672

Rather than coming up with a somewhat convoluted mechanism to ensure that
developers can override the global objects prototype with a function named
proto and expect it to work, we just disallow it at the syntax level.

parser/JSParser.cpp: (JSC::JSParser::parseFunctionInfo):

12:17 PM Changeset in webkit [76147] by Dimitri Glazkov

10 edits in trunk/Source/WebCore

2011-01-14 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Remove event forwarding logic from input[type=range], simplify event flow and thumb positioning logic.
https://bugs.webkit.org/show_bug.cgi?id=52464

This change has two parts:

1) Utilize shadow DOM event retargeting to get rid of forwarding events

via render tree;

2) Move thumb positioning logic from RenderSlider to SliderThumbElement.

These two are highly co-dependent. It looked ugly when I tried to
separate them.

No change in behavior, covered by existing tests.

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Added invocation of

InputType::handleMouseDownEvent.

html/InputType.cpp: (WebCore::InputType::handleMouseDownEvent): Added empty decl.
html/InputType.h: Added def.
html/RangeInputType.cpp: (WebCore::RangeInputType::handleMouseDownEvent): Added to handle the case

when the user clicks on the track of the slider. Also removed the
forwardEvent method.

html/RangeInputType.h: Added/removed defs.
html/shadow/SliderThumbElement.cpp: (WebCore::SliderThumbElement::dragFrom): Added a helper method to start

dragging from any position.

(WebCore::SliderThumbElement::dragTo): Added a helper method to drag to

specified position.

(WebCore::SliderThumbElement::setPosition): Collapsed most of the positioning

logic in RenderSlider into this method, which is now a simple calculation
and adjusting of thumb position based on supplied coordinates.

(WebCore::SliderThumbElement::startDragging): Added.
(WebCore::SliderThumbElement::stopDragging): Added.
(WebCore::SliderThumbElement::defaultEventHandler): Removed most of the

old position-sniffing logic and replaced with simple calls to start,
stop, and drag the thumb.

html/shadow/SliderThumbElement.h: Added defs.
rendering/RenderSlider.cpp: Removed a bunch of code that is no longer

necessary.

rendering/RenderSlider.h: Removed defs, removed now-unnecessary friendliness.

12:10 PM Changeset in webkit [76146] by commit-queue@webkit.org

22 edits in trunk/Source/WebCore

2011-01-19 Shane Stephens <shanestephens@google.com>

Reviewed by Chris Marrin.

Make AffineTransform and TransformationMatrix do matrix multiplication in the correct order (Column Major)
https://bugs.webkit.org/show_bug.cgi?id=48031

Fixed reversal, renamed matrix methods to be clearer, found all examples of operator* and
operator*= usage and switched operand order.

No new tests as this refactor doesn't add functionality.

html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::baseTransform):
html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::transform): (WebCore::CanvasRenderingContext2D::setTransform):
platform/graphics/cg/PatternCG.cpp: (WebCore::Pattern::createPlatformPattern):
platform/graphics/chromium/GLES2Canvas.cpp: (WebCore::GLES2Canvas::fillRect): (WebCore::GLES2Canvas::concatCTM): (WebCore::GLES2Canvas::drawQuad):
platform/graphics/chromium/TransparencyWin.cpp: (WebCore::TransparencyWin::setupLayerForOpaqueCompositeLayer): (WebCore::TransparencyWin::setupTransformForKeepTransform):
platform/graphics/transforms/AffineTransform.cpp: (WebCore::AffineTransform::multiply): (WebCore::AffineTransform::rotate):
platform/graphics/transforms/AffineTransform.h: (WebCore::AffineTransform::operator*=): (WebCore::AffineTransform::operator*):
platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::GraphicsContextPlatformPrivate::concatCTM):
platform/graphics/wince/SharedBitmap.cpp: (WebCore::SharedBitmap::drawPattern):
rendering/svg/RenderSVGResourceContainer.cpp: (WebCore::RenderSVGResourceContainer::transformOnNonScalingStroke):
rendering/svg/RenderSVGResourceGradient.cpp: (WebCore::clipToTextMask): (WebCore::RenderSVGResourceGradient::applyResource):
rendering/svg/RenderSVGResourcePattern.cpp: (WebCore::RenderSVGResourcePattern::applyResource):
rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::localToBorderBoxTransform):
rendering/svg/SVGImageBufferTools.cpp: (WebCore::SVGImageBufferTools::calculateTransformationToOutermostSVGCoordinateSystem): (WebCore::SVGImageBufferTools::renderSubtreeToImageBuffer):
rendering/svg/SVGTextLayoutEngine.cpp: (WebCore::SVGTextLayoutEngine::finalizeTransformMatrices):
svg/SVGLocatable.cpp: (WebCore::SVGLocatable::computeCTM): (WebCore::SVGLocatable::getTransformToElement):
svg/SVGMatrix.h: (WebCore::SVGMatrix::multiply):
svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::localCoordinateSpaceTransform): (WebCore::SVGSVGElement::viewBoxToViewTransform):
svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::animatedLocalTransform):
svg/SVGTextElement.cpp: (WebCore::SVGTextElement::animatedLocalTransform):
svg/SVGTransformList.cpp: (WebCore::SVGTransformList::concatenate):

11:31 AM Changeset in webkit [76145] by chang.shu@nokia.com

22 edits in trunk

2011-01-19 Chang Shu <chang.shu@nokia.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=52056

Fixed test cases in the above bug;
Partially fixed test cases in other contentEditable bugs;
Updated expected result for fast/dom/element-attribute-js-null.html. However, the test itself should be fixed later in bug 52057.

editing/editability/attr-invalid-string-expected.txt:
editing/editability/attr-invalid-string.html:
editing/editability/attr-missing-ancestor-false-expected.txt:
editing/editability/attr-missing-ancestor-false.html:
editing/editability/attr-missing-ancestor-true-expected.txt:
editing/editability/attr-missing-ancestor-true.html:
editing/editability/attr-missing-parent-ancestor-missing-expected.txt:
editing/editability/attr-missing-parent-ancestor-missing.html:
editing/editability/attr-missing-parent-false-expected.txt:
editing/editability/attr-missing-parent-false.html:
editing/editability/attr-missing-parent-true-expected.txt:
editing/editability/attr-missing-parent-true.html:
editing/editability/set-false-expected.txt:
editing/editability/set-inherit-parent-false-expected.txt:
editing/editability/set-inherit-parent-true-expected.txt:
editing/editability/set-invalid-value-expected.txt:
editing/editability/set-true-expected.txt:
editing/editability/set-value-caseinsensitive-expected.txt:
fast/dom/element-attribute-js-null-expected.txt:

2011-01-19 Chang Shu <chang.shu@nokia.com>

Reviewed by Darin Adler.

The return value of contentEditable() function should depend on the DOM attribute
instead of render style userModify. The code change fixed test cases in the bug
and partially fixed test cases in other contentEditable bugs;

https://bugs.webkit.org/show_bug.cgi?id=52056

html/HTMLElement.cpp: (WebCore::HTMLElement::contentEditable):

11:27 AM Changeset in webkit [76144] by leviw@chromium.org

3 edits
5 adds in trunk

2011-01-19 Levi Weintraub <leviw@chromium.org>

Reviewed by Darin Adler.

Changing RenderText::localCaretRect to clip to its containing block's logicalLeft and
logicalRightLayoutOverflow instead of simply using logicalLeft and logicalRight, as this
resulted in the caret being placed incorrectly in overflowing editable IFrame content.

Long lines in non-white-space-pre editable documents show cursor in wrong place
https://bugs.webkit.org/show_bug.cgi?id=48132

editing/selection/caret-painting-in-overflowing-autowrap-content.html: Added.
editing/selection/resources/iframe-positioning-caret-at-end.html: Added.
platform/mac/editing/selection/caret-painting-in-overflowing-autowrap-content-expected.checksum: Added.
platform/mac/editing/selection/caret-painting-in-overflowing-autowrap-content-expected.png: Added.
platform/mac/editing/selection/caret-painting-in-overflowing-autowrap-content-expected.txt: Added.

2011-01-19 Levi Weintraub <leviw@chromium.org>

Reviewed by Darin Adler.

Changing RenderText::localCaretRect to clip to its containing block's logicalLeft and
logicalRightLayoutOverflow instead of simply using logicalLeft and logicalRight, as this
resulted in the caret being placed incorrectly in overflowing editable IFrame content.

Long lines in non-white-space-pre editable documents show cursor in wrong place
https://bugs.webkit.org/show_bug.cgi?id=48132

Test: editing/selection/caret-painting-in-overflowing-autowrap-content.html

rendering/RenderText.cpp: (WebCore::RenderText::localCaretRect):

11:26 AM Changeset in webkit [76143] by andersca@apple.com

6 edits in trunk/Source/WebKit2

2011-01-19 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

WK2 - Multiple crashes in PlatformCALayer::replaceSublayer
https://bugs.webkit.org/show_bug.cgi?id=52695

Added a hostingLayer as the parent of the existing drawingLayer.
The hostingLayer is now the root which is passed to the
remote context. It never changes except to track the size
of the window. The backingLayer is now a child of the
hostingLayer, which allow it to switch between tiled and
non-tiled.

I also now give back accurate settings for debug borders and
repaint counters.

WebProcess/WebPage/LayerBackedDrawingArea.cpp: (WebKit::LayerBackedDrawingArea::LayerBackedDrawingArea): (WebKit::LayerBackedDrawingArea::setSize): (WebKit::LayerBackedDrawingArea::showDebugBorders): (WebKit::LayerBackedDrawingArea::showRepaintCounter):
WebProcess/WebPage/LayerBackedDrawingArea.h:
WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm: (WebKit::LayerBackedDrawingArea::platformInit): (WebKit::LayerBackedDrawingArea::attachCompositingContext): (WebKit::LayerBackedDrawingArea::syncCompositingLayers):

11:17 AM Changeset in webkit [76142] by cmarrin@apple.com

6 edits in trunk/Source

2011-01-19 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

WK2 - Multiple crashes in PlatformCALayer::replaceSublayer
https://bugs.webkit.org/show_bug.cgi?id=52695

Added a hostingLayer as the parent of the existing drawingLayer.
The hostingLayer is now the root which is passed to the
remote context. It never changes except to track the size
of the window. The backingLayer is now a child of the
hostingLayer, which allow it to switch between tiled and
non-tiled.

I also now give back accurate settings for debug borders and
repaint counters.

WebProcess/WebPage/LayerBackedDrawingArea.cpp: (WebKit::LayerBackedDrawingArea::LayerBackedDrawingArea): (WebKit::LayerBackedDrawingArea::setSize): (WebKit::LayerBackedDrawingArea::showDebugBorders): (WebKit::LayerBackedDrawingArea::showRepaintCounter):
WebProcess/WebPage/LayerBackedDrawingArea.h:
WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm: (WebKit::LayerBackedDrawingArea::platformInit): (WebKit::LayerBackedDrawingArea::attachCompositingContext): (WebKit::LayerBackedDrawingArea::syncCompositingLayers):

2011-01-19 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

WK2 - Multiple crashes in PlatformCALayer::replaceSublayer
https://bugs.webkit.org/show_bug.cgi?id=52695

Added ASSERTs to the places we assume a non-null superlayer.

platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::ensureStructuralLayer): (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):

10:49 AM Changeset in webkit [76141] by Beth Dakin

9 edits in trunk/Source/WebCore

Fix for <rdar://problem/8882916> Overlay scrollers require
content to layout underneath the scrollbar area

Reviewed by Maciej Stachowiak.

The render tree should not include scrollbar size for
overlay scrollers. This patch will allow scrollers on
the WebView to behave like overflow:overlay.

Treat overlay scrollers the same way as the !includeScrollbars
case.

platform/ScrollView.cpp:

(WebCore::ScrollView::visibleContentRect):

No corner rect for overlay scrollers.
(WebCore::ScrollView::scrollCornerRect):

usesOverlayScrollbars() currently always returns no.

platform/ScrollbarTheme.h:

(WebCore::ScrollbarTheme::usesOverlayScrollbars):

platform/mac/ScrollbarThemeMac.h:
platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::usesOverlayScrollbars):

includeVerticalScrollbarSize() and includeHorizontalScrollbarSize()
should return false for overlay scrollers. They already return
false for overflow:overlay.

rendering/RenderBox.cpp:

(WebCore::RenderBox::includeVerticalScrollbarSize):
(WebCore::RenderBox::includeHorizontalScrollbarSize):

rendering/RenderBox.h:

In the render tree, always treat overlay scrollers like
they have a width and height of 0.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::verticalScrollbarWidth):
(WebCore::RenderLayer::horizontalScrollbarHeight):

rendering/RenderListBox.cpp:

(WebCore::RenderListBox::verticalScrollbarWidth):

10:43 AM Changeset in webkit [76140] by leviw@chromium.org

2 edits in trunk/Tools

2011-01-19 Levi Weintraub <leviw@chromium.org>

Unreviewed.

Updating my email addresses and irc nick.

Scripts/webkitpy/common/config/committers.py:

10:36 AM Changeset in webkit [76139] by andersca@apple.com

3 edits in trunk/Source/WebKit2

2011-01-19 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Throttle sending of SetSize messages
https://bugs.webkit.org/show_bug.cgi?id=52727

UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl): Initialize m_isWaitingForDidSetSize to false.

(WebKit::DrawingAreaProxyImpl::didSetSize):
Null out the backing store.

(WebKit::DrawingAreaProxyImpl::sendSetSize):
If m_isWaitingForDidSetSize is true, do nothing. Otherwise, set m_isWaitingForDidSetSize
to true and send a SetSize message.

UIProcess/DrawingAreaProxyImpl.h: Add m_isWaitingForDidSetSize.

10:34 AM Changeset in webkit [76138] by bweinstein@apple.com

2 edits in trunk/LayoutTests

Update Windows expected results after r76115.

platform/win/fast/dom/Window/window-property-descriptors-expected.txt:

10:29 AM Changeset in webkit [76137] by evan@chromium.org

6 edits in trunk

2011-01-18 Evan Martin <evan@chromium.org>

Reviewed by Tony Chang.

[chromium] simplify complex text code, fixing a handful of layout tests
https://bugs.webkit.org/show_bug.cgi?id=52661

platform/chromium/test_expectations.txt: Mark 11 tests as expected to pass.

2011-01-18 Evan Martin <evan@chromium.org>

Reviewed by Tony Chang.

[chromium] simplify complex text code, fixing a handful of layout tests
https://bugs.webkit.org/show_bug.cgi?id=52661

Change ComplexTextControllerLinux to lay out RTL text to the left from
the starting point. (Previously it always went to the right.) This allows
us to map pixel offsets more directly into offsets within the text runs,
simplifying a few of the text-fiddling functions (they no longer need to
track the current position, as ComplexTextController now does it).

platform/graphics/chromium/ComplexTextControllerLinux.cpp: (WebCore::ComplexTextController::ComplexTextController): (WebCore::ComplexTextController::reset): (WebCore::ComplexTextController::setGlyphXPositions):
platform/graphics/chromium/ComplexTextControllerLinux.h: (WebCore::ComplexTextController::offsetX):
platform/graphics/chromium/FontLinux.cpp: (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::glyphIndexForXPositionInScriptRun): (WebCore::Font::offsetForPositionForComplexText): (WebCore::Font::selectionRectForComplexText):

10:27 AM Changeset in webkit [76136] by pfeldman@chromium.org

22 edits
1 copy
1 add in trunk/Source/WebCore

2011-01-19 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: move methods from InjectedScript domain into DOM,
Runtime and Debugger domains. Introduce InspectorRuntimeAgent.
https://bugs.webkit.org/show_bug.cgi?id=52717

CMakeLists.txt:
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
inspector/CodeGeneratorInspector.pm:
inspector/InjectedScript.cpp: (WebCore::InjectedScript::evaluateOnCallFrame): (WebCore::InjectedScript::getCompletions): (WebCore::InjectedScript::getCompletionsOnCallFrame):
inspector/InjectedScript.h:
inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::injectedScriptForMainWorld):
inspector/InjectedScriptHost.h:
inspector/InjectedScriptSource.js: (.): ():
inspector/Inspector.idl:
inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::releaseFrontendLifetimeAgents):
inspector/InspectorController.h:
inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::InspectorDOMAgent): (WebCore::InspectorDOMAgent::resolveNode): (WebCore::InspectorDOMAgent::getNodeProperties): (WebCore::InspectorDOMAgent::getNodePrototypes): (WebCore::InspectorDOMAgent::injectedScriptForNodeId):
inspector/InspectorDOMAgent.h: (WebCore::EventListenerInfo::EventListenerInfo): (WebCore::InspectorDOMAgent::DOMListener::~DOMListener): (WebCore::InspectorDOMAgent::create): (WebCore::InspectorDOMAgent::cast): (WebCore::InspectorDOMAgent::documents):
inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame): (WebCore::InspectorDebuggerAgent::getCompletionsOnCallFrame): (WebCore::InspectorDebuggerAgent::injectedScriptForCallFrameId):
inspector/InspectorDebuggerAgent.h:
inspector/InspectorRuntimeAgent.cpp: Added. (WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent): (WebCore::InspectorRuntimeAgent::~InspectorRuntimeAgent): (WebCore::InspectorRuntimeAgent::evaluate): (WebCore::InspectorRuntimeAgent::getCompletions): (WebCore::InspectorRuntimeAgent::getProperties): (WebCore::InspectorRuntimeAgent::setPropertyValue): (WebCore::InspectorRuntimeAgent::pushNodeToFrontend): (WebCore::InspectorRuntimeAgent::injectedScriptForObjectId):
inspector/InspectorRuntimeAgent.h: Copied from Source/WebCore/inspector/InjectedScript.h. (WebCore::InspectorRuntimeAgent::create):
inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions):
inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.doEvalInCallFrame):

10:18 AM Changeset in webkit [76135] by andersca@apple.com

6 edits in trunk/Source/WebKit2

2011-01-19 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Pass WebPageCreationParameters to DrawingArea::create
https://bugs.webkit.org/show_bug.cgi?id=52726

WebProcess/WebPage/DrawingArea.cpp: (WebKit::DrawingArea::create):
WebProcess/WebPage/DrawingArea.h:
WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::create): (WebKit::DrawingAreaImpl::DrawingAreaImpl):
WebProcess/WebPage/DrawingAreaImpl.h:
WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage): (WebKit::WebPage::changeAcceleratedCompositingMode):

10:14 AM Changeset in webkit [76134] by tony@chromium.org

4 edits in trunk/Tools

2011-01-19 Tony Chang <tony@chromium.org>

Reviewed by Mihai Parparita.

[chromium] [linux] if check-sys-deps fails, output the failure reason
https://bugs.webkit.org/show_bug.cgi?id=52671

Scripts/webkitpy/common/system/executive_mock.py: Add support for

error handler functions.

Scripts/webkitpy/layout_tests/port/chromium.py:

output the error text from --check-sys-deps

Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

9:58 AM Changeset in webkit [76133] by msaboff@apple.com

5 edits in trunk

2011-01-19 Michael Saboff <msaboff@apple.com>

Reviewed by Darin Adler.

<rdar://problem/8882994> Regression: Simple nested backtrack hangs
https://bugs.webkit.org/show_bug.cgi?id=52675

The changeset (r76076) for https://bugs.webkit.org/show_bug.cgi?id=52540
broke simple backtracking in some cases. Reworked that change to
link both jumps and labels.

yarr/YarrJIT.cpp: (JSC::Yarr::YarrGenerator::BacktrackDestination::hasBacktrackToLabel): (JSC::Yarr::YarrGenerator::TermGenerationState::propagateBacktrackingFrom): (JSC::Yarr::YarrGenerator::generateParenthesesSingle):

2011-01-19 Michael Saboff <msaboff@apple.com>

Reviewed by Darin Adler.

<rdar://problem/8882994> Regression: Simple nested backtrack hangs
https://bugs.webkit.org/show_bug.cgi?id=52675

New tests to support change.

fast/regex/parentheses-expected.txt:
fast/regex/script-tests/parentheses.js:

9:57 AM Changeset in webkit [76132] by podivilov@chromium.org

7 edits
4 adds in trunk/Source/WebCore

2011-01-18 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: add UglifyJS parser and formatter files
https://bugs.webkit.org/show_bug.cgi?id=51702

WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
inspector/front-end/ScriptFormatter.js: (WebInspector.ScriptFormatter.positionToLocation): (WebInspector.ScriptFormatter.prototype.format.messageHandler): (WebInspector.ScriptFormatter.prototype.format): (WebInspector.ScriptFormatter.prototype._buildMapping): (WebInspector.ScriptFormatter.prototype._convertPosition):
inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.formatSource.didFormat): (WebInspector.SourceFrame.prototype.formatSource):
inspector/front-end/WebKit.qrc:
inspector/front-end/parse-js.js: Added. UglifyJS parser.
inspector/front-end/process.js: Added. UglifyJS formatter.
inspector/front-end/scriptFormatterWorker.js: Added. Worker script that wraps UglifyJS code. (onmessage): (beautify): (loadModule): (require):
inspector/front-end/utilities.js: ():

9:48 AM Changeset in webkit [76131] by Csaba Osztrogonác

1 edit
3 adds in trunk/LayoutTests

Unreviewed.

Add Qt specific expected result for a new test introduced in r76074.
Compared to Mac png files and Mac expected files.

platform/qt/fast/block/float/float-overflow-hidden-containing-block-width-expected.checksum: Added.
platform/qt/fast/block/float/float-overflow-hidden-containing-block-width-expected.png: Added.
platform/qt/fast/block/float/float-overflow-hidden-containing-block-width-expected.txt: Added.

9:47 AM Changeset in webkit [76130] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/gtk

2011-01-19 Joone Hur <joone.hur@collabora.co.uk>

Reviewed by Andreas Kling.

[GTK] No need to invalidate empty areas in ChromeClient::invalidateContentsAndWindow
https://bugs.webkit.org/show_bug.cgi?id=52702

Don't call gdk_window_invalidate_rect if an updated rectangle is empty.

WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::invalidateContentsAndWindow):

9:01 AM Changeset in webkit [76129] by podivilov@chromium.org

15 edits
2 adds in trunk

2011-01-19 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [JSC] scripts have incorrect starting line (always 1).
https://bugs.webkit.org/show_bug.cgi?id=52721

inspector/debugger-scripts-expected.txt: Added.
inspector/debugger-scripts.html: Added.

2011-01-19 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [JSC] scripts have incorrect starting line (always 1).
https://bugs.webkit.org/show_bug.cgi?id=52721

debugger/Debugger.cpp: (JSC::Debugger::recompileAllJSFunctions):
debugger/Debugger.h:
parser/Parser.h: (JSC::Parser::parse):
parser/SourceCode.h: (JSC::SourceCode::SourceCode):
parser/SourceProvider.h: (JSC::SourceProvider::startPosition):

2011-01-19 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [JSC] scripts have incorrect starting line (always 1).
https://bugs.webkit.org/show_bug.cgi?id=52721

Test: inspector/debugger-scripts.html

bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::dispatchDidParseSource): (WebCore::ScriptDebugServer::dispatchFailedToParseSource): (WebCore::ScriptDebugServer::sourceParsed):
bindings/js/ScriptDebugServer.h:
bindings/js/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode):
bindings/js/StringSourceProvider.h: (WebCore::StringSourceProvider::create): (WebCore::StringSourceProvider::startPosition): (WebCore::StringSourceProvider::StringSourceProvider):

2011-01-19 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [JSC] scripts have incorrect starting line (always 1).
https://bugs.webkit.org/show_bug.cgi?id=52721

WebView/WebScriptDebugger.h:
WebView/WebScriptDebugger.mm: (toNSString): (WebScriptDebugger::sourceParsed):

8:41 AM Changeset in webkit [76128] by satish@chromium.org

14 edits in trunk/Source

2011-01-19 Satish Sampath <satish@chromium.org>

Reviewed by Jeremy Orlow.

Send origin/url as part of speech input requests to the embedder.
https://bugs.webkit.org/show_bug.cgi?id=52718

page/SpeechInput.cpp: (WebCore::SpeechInput::startRecognition): Pass up additional origin parameter.
page/SpeechInput.h:
page/SpeechInputClient.h:
platform/mock/SpeechInputClientMock.cpp: (WebCore::SpeechInputClientMock::startRecognition): Updated prototype.
platform/mock/SpeechInputClientMock.h:
rendering/TextControlInnerElements.cpp: (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): Pass the frame origin to speech input request.

2011-01-19 Satish Sampath <satish@chromium.org>

Reviewed by Jeremy Orlow.

Send origin/url as part of speech input requests to the embedder.
https://bugs.webkit.org/show_bug.cgi?id=52718

public/WebSpeechInputController.h: (WebKit::WebSpeechInputController::startRecognition): Updated prototype.
src/SpeechInputClientImpl.cpp: (WebKit::SpeechInputClientImpl::startRecognition): Pass up additional origin parameter.
src/SpeechInputClientImpl.h:
src/WebSpeechInputControllerMockImpl.cpp: Updated code to pass additional parameter. (WebKit::WebSpeechInputControllerMockImpl::startRecognition):
src/WebSpeechInputControllerMockImpl.h: Added new variant of startRecognition method.

8:27 AM Changeset in webkit [76127] by jorlow@chromium.org

3 edits in trunk/LayoutTests

2011-01-19 Jeremy Orlow <jorlow@chromium.org>

This test changed slightly, so rebaseline it. The offsets seem off
but they have been for as long as the files have been upstream so it's
likely a known issue.

platform/chromium-win/fast/events/offsetX-offsetY-expected.txt:
platform/chromium/test_expectations.txt:

8:24 AM Changeset in webkit [76126] by hans@chromium.org

7 edits
2 adds in trunk

2011-01-19 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Support auto-increment keys
https://bugs.webkit.org/show_bug.cgi?id=52576

Add layout test for auto increment keys.
Update previous test not to consider auto increment an error.

storage/indexeddb/create-object-store-options-expected.txt:
storage/indexeddb/create-object-store-options.html:
storage/indexeddb/objectstore-autoincrement-expected.txt: Added.
storage/indexeddb/objectstore-autoincrement.html: Added.

2011-01-19 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Support auto-increment keys
https://bugs.webkit.org/show_bug.cgi?id=52576

Add support for auto-increment keys.

Test: storage/indexeddb/objectstore-autoincrement.html

storage/IDBDatabase.cpp: (WebCore::IDBDatabase::createObjectStore):
storage/IDBObjectStoreBackendImpl.cpp: (WebCore::genAutoIncrementKey): (WebCore::IDBObjectStoreBackendImpl::putInternal):

6:42 AM Changeset in webkit [76125] by Csaba Osztrogonác

3 edits in trunk/LayoutTests

Unreviewed.

Update Qt specific expected files after r76115.

platform/qt/fast/dom/Window/window-properties-expected.txt:
platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:

6:39 AM Changeset in webkit [76124] by Joseph Pecoraro

3 edits in trunk/LayoutTests

2011-01-19 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Simon Fraser.

Update Test Now that Bug is Fixed
https://bugs.webkit.org/show_bug.cgi?id=52677

fast/events/offsetX-offsetY-expected.txt: one more PASS line.
fast/events/offsetX-offsetY.html: uncomment and update hit-test location.

6:32 AM Changeset in webkit [76123] by jorlow@chromium.org

1 edit
2 moves in trunk/LayoutTests

2011-01-19 Jeremy Orlow <jorlow@chromium.org>

Move pixel test results to the proper place.

platform/mac/svg/custom/use-inherit-style-expected.checksum: Renamed from LayoutTests/svg/custom/use-inherit-style-expected.checksum.
platform/mac/svg/custom/use-inherit-style-expected.png: Renamed from LayoutTests/svg/custom/use-inherit-style-expected.png.

6:31 AM Changeset in webkit [76122] by Csaba Osztrogonác

10 edits in trunk/Source

[Qt] Remove unnecessary "../Source" from paths
after moving source files into Source is finished.

Reviewed by Laszlo Gombos and Tor Arne Vestbø.

Source/JavaScriptCore:

JavaScriptCore.pri:

Source/WebCore:

WebCore.pri:
WebCore.pro:

Source/WebKit/qt:

Api/DerivedSources.pro:

Source/WebKit2:

DerivedSources.pro:
WebKit2.pro:

6:27 AM Changeset in webkit [76121] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

2011-01-19 Benjamin Kalman <kalman@chromium.org>

Reviewed by Darin Adler.

Don't return void from void function String::split
https://bugs.webkit.org/show_bug.cgi?id=52684

wtf/text/WTFString.cpp: (WTF::String::split):

6:15 AM Changeset in webkit [76120] by commit-queue@webkit.org

2 edits in trunk

2011-01-19 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>

Reviewed by Andreas Kling.

Enable usage of Google ld if it exist but is not on by default.

[Qt] Enable the google ld if it exist but is not on by default
https://bugs.webkit.org/show_bug.cgi?id=52625

common.pri: flip the test.

6:01 AM Changeset in webkit [76119] by commit-queue@webkit.org

2 edits in trunk/Tools

2011-01-19 Aparna Nandyal <aparna.nand@wipro.com>

Reviewed by Andreas Kling.

[Qt] QtTestBrowser crashes when closing if Facebook is opened
https://bugs.webkit.org/show_bug.cgi?id=52554

QtNetworkAccessManager is created in a thread and set as
member variable in QWebPage. When the thread is destroyed
the object is still used. So fix will set the object to
NULL once the thread is destroyed.

QtTestBrowser/launcherwindow.cpp: (LauncherWindow::~LauncherWindow):

5:55 AM Changeset in webkit [76118] by pfeldman@chromium.org

2 edits in trunk/LayoutTests

2011-01-19 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: fixed flaky inspector test.

http/tests/inspector/extensions-resources-redirect.html:

5:27 AM Changeset in webkit [76117] by mnaganov@chromium.org

1 edit
2 deletes in trunk/LayoutTests

Revert "2011-01-18 Mikhail Naganov <mnaganov@chromium.org>"

Revert r76114 -- added test fails on Chromium canaries.

This reverts commit 89065aef21411b68af89a8fa7ff41dfe14c54a6a.

5:24 AM Changeset in webkit [76116] by apavlov@chromium.org

9 edits
1 add in trunk

2011-01-19 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Employ TextPrompt for CSS property name/value autocompletion
https://bugs.webkit.org/show_bug.cgi?id=52212

WebInspector.CSSKeywordCompletions contains a hand-written list of accepted CSS property value keywords
for each property. WebInspector.TextPrompt is used to suggest both the name and value keywords while
editing styles, in place of the old custom suggestion code.

WebCore:

inspector/front-end/CSSCompletions.js: (WebInspector.CSSCompletions.prototype.startsWith): Fix array-out-of-bounds error.
inspector/front-end/CSSKeywordCompletions.js: Added. (WebInspector.CSSKeywordCompletions.forProperty):
inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.updateTitle): (WebInspector.StylePropertyTreeElement.prototype): ():
inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt): (WebInspector.TextPrompt.prototype.removeFromElement): (WebInspector.TextPrompt.prototype._onKeyDown): (WebInspector.TextPrompt.prototype.tabKeyPressed): (WebInspector.TextPrompt.prototype.upKeyPressed): (WebInspector.TextPrompt.prototype.downKeyPressed): (WebInspector.TextPrompt.prototype._moveBackInHistory): (WebInspector.TextPrompt.prototype._moveForwardInHistory):
inspector/front-end/inspector.css: (.auto-complete-text, .editing .auto-complete-text):
inspector/front-end/inspector.html:

LayoutTests:

inspector/styles-add-blank-property.html: Follow the altered event handling.
inspector/styles-url-linkify.html: Eliminate flakiness.

4:59 AM BuildingCairoOnWindows edited by d.nusman@re-lion.com

(diff)

4:56 AM Changeset in webkit [76115] by commit-queue@webkit.org

33 edits
6 adds in trunk

2011-01-19 Dai Mikurube <dmikurube@google.com>

Reviewed by Kent Tamura.

Implement onformchange and onforminput event handlers
https://bugs.webkit.org/show_bug.cgi?id=26141

fast/dom/Window/window-properties-expected.txt: Added form events.
fast/dom/Window/window-property-descriptors-expected.txt: Added form events.
fast/forms/formchange-event-expected.txt: Added.
fast/forms/formchange-event.html: Added to test formchange events.
fast/forms/forminput-event-expected.txt: Added.
fast/forms/forminput-event.html: Added to test forminput events.
fast/forms/script-tests/formchange-event.js: Added. (sendKey): (sendText):
fast/forms/script-tests/forminput-event.js: Added. (sendKey): (sendText):

2011-01-19 Dai Mikurube <dmikurube@google.com>

Reviewed by Kent Tamura.

Implement onformchange and onforminput event handlers
https://bugs.webkit.org/show_bug.cgi?id=26141

Tests: fast/forms/formchange-event.html

fast/forms/forminput-event.html

bindings/scripts/CodeGeneratorGObject.pm: Added event names.
dom/Document.h: Added event definitions.
dom/Document.idl: Added event definitions.
dom/Element.h: Added event definitions.
dom/Element.idl: Added event definitions.
dom/Event.cpp: (WebCore::Event::fromUserGesture): Added a condition for a formchange event in handling user gestures.
dom/EventNames.h: Added event definitions.
dom/InputElement.cpp: (WebCore::InputElement::setValueFromRenderer): Replaced a direct dispatchEvent() call into dispatchInputEvents(), a virtual function which broadcasts forminput events for HTML elements.
dom/Node.cpp: (WebCore::Node::dispatchInputEvents): Defined basic dispatchInputEvents() described above. (WebCore::Node::dispatchChangeEvents): Defined basic dispatchChangeEvents() described above. (WebCore::Node::defaultEventHandler): Replaced a direct dispatchEvent() call into dispatchInputEvents().
dom/Node.h:
html/FormAssociatedElement.h: Added isResettable() to check the element is resettable or not.
html/HTMLAttributeNames.in: Added event names.
html/HTMLElement.cpp: (WebCore::HTMLElement::parseMappedAttribute): Added event handling. (WebCore::HTMLElement::shadowAncestorOwnerForm): Added to get an ancestor <form> element from a shadow element. (WebCore::HTMLElement::dispatchChangeEvents): Defined dispatchChangeEvents() for HTML elements described above. (WebCore::HTMLElement::dispatchInputEvents): Defined dispatchInputEvents() for HTML elements described above.
html/HTMLElement.h:
html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::dispatchFormControlChangeEvent): Added calling dispatchFormChange() to broadcast formchange events. (WebCore::HTMLFormControlElement::dispatchFormControlInputEvent): Defined newly to dispatch an input event with broadcasting forminput events.
html/HTMLFormControlElement.h: Added isResettable().
html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::broadcastFormEvent): Added to broadcast forminput or formchange events. (WebCore::HTMLFormElement::dispatchFormInput): Defined newly to broadcast forminput events. (WebCore::HTMLFormElement::dispatchFormChange): Defined newly to broadcast formchange events.
html/HTMLFormElement.h:
html/HTMLFormElement.idl: Added dispatchFormInput() and dispatchFormChange() DOM API definitions.
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::stepUpFromRenderer): Replaced a direct dispatchEvent() call into dispatchInputEvents().
html/HTMLInputElement.h: Added isResettable().
html/HTMLKeygenElement.h: Added isResettable().
html/HTMLObjectElement.h: Added isResettable().
html/HTMLOutputElement.h: Added isResettable().
html/HTMLSelectElement.h: Added isResettable().
html/HTMLTextAreaElement.h: Added isResettable().
page/DOMWindow.h: Added event definitions.
page/DOMWindow.idl: Added event definitions.
rendering/TextControlInnerElements.cpp: (WebCore::SearchFieldCancelButtonElement::defaultEventHandler): Replaced a direct dispatchEvent() call into dispatchInputEvents().

4:42 AM Changeset in webkit [76114] by mnaganov@chromium.org

1 edit
2 adds in trunk/LayoutTests

2011-01-18 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Add layout test for the CPU profiler.

This test replaces DevToolsSanityTest.TestProfilerTab from
Chromium's interactive_ui_tests.

https://bugs.webkit.org/show_bug.cgi?id=52634

inspector/cpu-profiler-profiling-expected.txt: Added.
inspector/cpu-profiler-profiling.html: Added.

4:35 AM Changeset in webkit [76113] by mnaganov@chromium.org

2 deletes in trunk/LayoutTests/inspector

Revert accidental r76110..76112

4:24 AM Changeset in webkit [76112] by mnaganov@chromium.org

1 edit in trunk/LayoutTests/inspector/cpu-profiler-profiling.html

works in chromium

4:23 AM Changeset in webkit [76111] by mnaganov@chromium.org

2 edits in trunk/LayoutTests/inspector

works in safari

4:23 AM Changeset in webkit [76110] by mnaganov@chromium.org

2 adds in trunk/LayoutTests/inspector

added test

3:37 AM Changeset in webkit [76109] by caseq@chromium.org

2 edits in trunk/Source/WebCore

2011-01-19 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Extensions API] delete pending callback from callback map before invoking it
https://bugs.webkit.org/show_bug.cgi?id=52707

inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI.ExtensionServerClient.prototype._onCallback):

2:34 AM Changeset in webkit [76108] by pfeldman@chromium.org

2 edits in trunk/Source/WebKit/chromium

2011-01-19 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: updating Chromium devtools sanity tests for downstream use.

src/js/Tests.js: (.TestSuite.prototype._checkExecutionLine):

1:32 AM Changeset in webkit [76107] by commit-queue@webkit.org

20 edits in trunk/Source

2011-01-19 Levi Weintraub <leviw@google.com>

Reviewed by Ryosuke Niwa.

Replaced rangeCompliantEquivalent with Position::parentAnchoredEquivalent
and simplified the logic a bit. Unfortunately, Tables and some legacy
editing positions still need to be handled specifically.

remove rangeCompliantEquivalent and replace it with Position methods
https://bugs.webkit.org/show_bug.cgi?id=25057

No new tests as this is a refactor that doesn't change behavior.

WebCore.exp.in:
dom/Document.cpp: (WebCore::Document::caretRangeFromPoint):
dom/Position.cpp: (WebCore::Position::parentAnchoredEquivalent):
dom/Position.h:
editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyBlockStyle):
editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::insertNodeAt): (WebCore::CompositeEditCommand::moveParagraphs):
editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializePositionData): (WebCore::DeleteSelectionCommand::mergeParagraphs):
editing/Editor.cpp: (WebCore::Editor::textDirectionForSelection): (WebCore::Editor::advanceToNextMisspelling):
editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::shouldUseBreakElement):
editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
editing/ReplaceSelectionCommand.cpp: (WebCore::handleStyleSpansBeforeInsertion):
editing/VisiblePosition.cpp: (WebCore::makeRange): (WebCore::setStart): (WebCore::setEnd):
editing/VisibleSelection.cpp: (WebCore::VisibleSelection::firstRange): (WebCore::VisibleSelection::toNormalizedRange): (WebCore::makeSearchRange):
editing/htmlediting.cpp: (WebCore::indexForVisiblePosition):
editing/htmlediting.h:
editing/visible_units.cpp: (WebCore::previousBoundary): (WebCore::nextBoundary):
page/DOMSelection.cpp: (WebCore::anchorPosition): (WebCore::focusPosition): (WebCore::basePosition): (WebCore::extentPosition):

2011-01-19 Levi Weintraub <leviw@google.com>

Reviewed by Ryosuke Niwa.

Updating to use Position::parentAnchoredEquivalent instead of
the old htmlediting rangeCompliantEquivalent.

remove rangeCompliantEquivalent and replace it with Position methods
https://bugs.webkit.org/show_bug.cgi?id=25057

WebView/WebFrame.mm: (-[WebFrame _smartDeleteRangeForProposedRange:]):

1:17 AM Changeset in webkit [76106] by yurys@chromium.org

3 edits in trunk/Source/WebCore

2011-01-19 Peter Rybin <peter.rybin@gmail.com>

Reviewed by Yury Semikhatsky.

Web Inspector: script column offset is incorrect
https://bugs.webkit.org/show_bug.cgi?id=52580

Column is updated in 3 places, 2 less probable places contained error.
Fixed now.

platform/text/SegmentedString.cpp: (WebCore::SegmentedString::advanceSlowCase):
platform/text/SegmentedString.h: (WebCore::SegmentedString::advancePastNewline):

1:00 AM Changeset in webkit [76105] by pfeldman@chromium.org

32 edits
1 delete in trunk

2011-01-18 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: make InjectedScriptAccess API a part of Web Inspector protocol.
https://bugs.webkit.org/show_bug.cgi?id=52652

Calls served by the InjectedScript should be first class protocol
citizens, not dispatched via single protocol message.

http/tests/inspector/extensions-test.js: (initialize_ExtensionsTest.InspectorTest.runExtensionTests):
http/tests/inspector/inspector-test2.js: (initialize_InspectorTest.InspectorTest.evaluateInPage):
http/tests/inspector/resource-har-conversion.html:
inspector/console-command-clear.html:
inspector/console-dir-global.html:

2011-01-18 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: make InjectedScriptAccess API a part of Web Inspector protocol.
https://bugs.webkit.org/show_bug.cgi?id=52652

Calls served by the InjectedScript should be first class protocol
citizens, not dispatched via single protocol message.

WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
inspector/CodeGeneratorInspector.pm:
inspector/InjectedScript.cpp: (WebCore::InjectedScript::evaluate): (WebCore::InjectedScript::evaluateInCallFrame): (WebCore::InjectedScript::evaluateOnSelf): (WebCore::InjectedScript::getCompletions): (WebCore::InjectedScript::getProperties): (WebCore::InjectedScript::pushNodeToFrontend): (WebCore::InjectedScript::resolveNode): (WebCore::InjectedScript::getNodeProperties): (WebCore::InjectedScript::getNodePrototypes): (WebCore::InjectedScript::setPropertyValue): (WebCore::InjectedScript::makeCall):
inspector/InjectedScript.h:
inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::evaluate): (WebCore::InjectedScriptHost::evaluateInCallFrame): (WebCore::InjectedScriptHost::evaluateOnSelf): (WebCore::InjectedScriptHost::getCompletions): (WebCore::InjectedScriptHost::getProperties): (WebCore::InjectedScriptHost::pushNodeToFrontend): (WebCore::InjectedScriptHost::resolveNode): (WebCore::InjectedScriptHost::getNodeProperties): (WebCore::InjectedScriptHost::getNodePrototypes): (WebCore::InjectedScriptHost::setPropertyValue): (WebCore::InjectedScriptHost::injectedScriptForObjectId): (WebCore::InjectedScriptHost::injectedScriptForNodeId): (WebCore::InjectedScriptHost::injectedScriptForMainWorld):
inspector/InjectedScriptHost.h:
inspector/InjectedScriptSource.js: (.):
inspector/Inspector.idl:
inspector/InspectorController.cpp:
inspector/InspectorController.h:
inspector/InspectorValues.cpp: (WebCore::InspectorObject::getNumber):
inspector/InspectorValues.h:
inspector/front-end/AuditRules.js: (WebInspector.AuditRules.evaluateInTargetWindow):
inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions): (WebInspector.ConsoleView.prototype.doEvalInWindow):
inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._createTooltipForNode):
inspector/front-end/ExtensionPanel.js: (WebInspector.ExtensionWatchSidebarPane.prototype.setExpression):
inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
inspector/front-end/InjectedScriptAccess.js: Removed.
inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update.callback): (WebInspector.PropertiesSidebarPane.prototype.update):
inspector/front-end/RemoteObject.js: (WebInspector.RemoteObject.resolveNode): (WebInspector.RemoteObject.prototype.getProperties): (WebInspector.RemoteObject.prototype.setPropertyValue): (WebInspector.RemoteObject.prototype.pushNodeToFrontend):
inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.doEvalInCallFrame):
inspector/front-end/WebKit.qrc:
inspector/front-end/inspector.html:

2011-01-18 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: make InjectedScriptAccess API a part of Web Inspector protocol.
https://bugs.webkit.org/show_bug.cgi?id=52652

Calls served by the InjectedScript should be first class protocol
citizens, not dispatched via single protocol message.

src/js/Tests.js:

Jan 18, 2011:

11:40 PM Changeset in webkit [76104] by antonm@chromium.org

4 edits in trunk/Source/WebCore

2011-01-18 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

[v8] Minor cleanup: make 2nd argument of removeIfPresnt accept only a value type stored in the DOM map
https://bugs.webkit.org/show_bug.cgi?id=51683

Covered by the existing tests.

bindings/v8/DOMDataStore.cpp: (WebCore::DOMDataStore::weakNodeCallback): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::removeIfPresent):
bindings/v8/DOMDataStore.h:
bindings/v8/V8DOMMap.h: (WebCore::WeakReferenceMap::removeIfPresent):

11:12 PM Changeset in webkit [76103] by mjs@apple.com

2 edits in trunk/Tools

WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h

Rubber stamped by Csaba Osztrogonac

10:09 PM Changeset in webkit [76102] by eric@webkit.org

1 edit
2 deletes in trunk/LayoutTests

2011-01-18 Eric Seidel <eric@webkit.org>

Unreviewed, rolling out r76084.
http://trac.webkit.org/changeset/76084
https://bugs.webkit.org/show_bug.cgi?id=52654

Crashes on the bots

fast/dom/Window/open-window-empty-url-expected.txt: Removed.
fast/dom/Window/open-window-empty-url.html: Removed.

9:15 PM Changeset in webkit [76101] by dpranke@chromium.org

5 edits in trunk/Tools

2011-01-18 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

new-run-webkit-tests: add a --build-directory command line argument

Official Google Chrome builds use a non-standard build directory
location. This patch adds a --build-directory argument that
allows that location to be specified on the command line. Only
Chromium-based builds will use this flag for now, but anyone can
in the future.

There are no unit tests for this since it's difficult to test
until mock filesystems are fully supported in the code. This was
tested by hand for now.

https://bugs.webkit.org/show_bug.cgi?id=52694

Scripts/webkitpy/layout_tests/port/chromium_linux.py:
Scripts/webkitpy/layout_tests/port/chromium_mac.py:
Scripts/webkitpy/layout_tests/port/chromium_win.py:
Scripts/webkitpy/layout_tests/run_webkit_tests.py:

8:33 PM Changeset in webkit [76100] by kbr@google.com

4 edits in trunk/Source/JavaScriptCore

2011-01-18 Kenneth Russell <kbr@google.com>

Unreviewed, rolling out r76078.
http://trac.webkit.org/changeset/76078
https://bugs.webkit.org/show_bug.cgi?id=52668

Caused crashes of fast/canvas/webgl/constants.html,
fast/canvas/webgl/gl-enum-tests.html, and possibly other layout
test crashes in Release mode. WebGL crashes were observed with
"run-webkit-tests fast/canvas/webgl". It was necessary to run
multiple tests to provoke the crash.

interpreter/RegisterFile.h: (JSC::RegisterFile::markGlobals):
runtime/JSActivation.cpp: (JSC::JSActivation::markChildren):
runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::markChildren):

8:18 PM Changeset in webkit [76099] by morrita@google.com

1 edit in trunk/Source/WebCore/ChangeLog

Added a reviewer line for the last checkin

8:11 PM Changeset in webkit [76098] by morrita@google.com

11 edits
1 add in trunk/Source/WebCore

2011-01-18 MORITA Hajime <morrita@google.com>

Refactoring: EventHandler::handleTextInputEvent should accept an enum instead of bools.
https://bugs.webkit.org/show_bug.cgi?id=52608

No new tests. no behavioral change.

GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
dom/TextEvent.cpp: (WebCore::TextEvent::create): (WebCore::TextEvent::createForDrop): (WebCore::TextEvent::TextEvent):
dom/TextEvent.h: (WebCore::TextEvent::isLineBreak): (WebCore::TextEvent::isBackTab): (WebCore::TextEvent::isPaste): (WebCore::TextEvent::isDrop):
dom/TextEventInputType.h: Added. Extracted from TextEvent::TextInputType.
editing/EditorCommand.cpp: (WebCore::executeInsertBacktab): (WebCore::executeInsertLineBreak): (WebCore::executeInsertNewline): (WebCore::executeInsertTab):
page/EventHandler.cpp: (WebCore::EventHandler::handleTextInputEvent):
page/EventHandler.h:

8:08 PM Changeset in webkit [76097] by mjs@apple.com

4 edits in trunk/LayoutTests

2011-01-18 Maciej Stachowiak <mjs@apple.com>

Reviewed by Sam Weinig.

Skip (and in a few cases fix) tests for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=52698

editing/pasteboard/copy-null-characters.html: Make this test fail in a more obvious way when it fails.
fast/events/scroll-event-does-not-bubble.html: Make this test properly handle the fact that scroll events are async. The job was half-done before.
platform/mac-wk2/Skipped: Skip!

7:56 PM Changeset in webkit [76096] by mjs@apple.com

2 edits in trunk/Tools

Not reviewed. Bot fix.

Remove an inadvertently committed debugging print.

DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::notifyDone):

7:55 PM Changeset in webkit [76095] by kbr@google.com

3 edits in trunk/Source/ThirdParty/ANGLE

2011-01-18 Kenneth Russell <kbr@google.com>

Unreviewed, Leopard build fix. Remove flex/bison targets for GLSL
grammar because the generated sources are already checked in.

ANGLE.xcodeproj/project.pbxproj:
src/build_angle.xcodeproj/project.pbxproj:

7:30 PM Changeset in webkit [76094] by mjs@apple.com

5 edits in trunk/LayoutTests

Not reviewed.

Revert inadvertantly committed test changes.

editing/pasteboard/copy-null-characters.html:
fast/events/scroll-event-does-not-bubble.html:
platform/mac-wk2/Skipped:
transitions/remove-transition-style.html:

7:23 PM Changeset in webkit [76093] by kbr@google.com

2 edits in trunk/Source/ThirdParty/ANGLE

2011-01-18 Kenneth Russell <kbr@google.com>

Unreviewed, release build fix. Explicitly cast away const.

src/compiler/preprocessor/scanner.c: (ScanFromString):

7:16 PM Changeset in webkit [76092] by mjs@apple.com

14 edits in trunk

2011-01-18 Maciej Stachowiak <mjs@apple.com>

Reviewed by Sam Weinig.

WebKitTestRunner should track loading more like DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=52692

Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
This makes some tests that call notifyDone multiple times pass.

WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::InjectedBundle): (WTR::InjectedBundle::done):
WebKitTestRunner/InjectedBundle/InjectedBundle.h: (WTR::InjectedBundle::topLoadingFrame): (WTR::InjectedBundle::setTopLoadingFrame):
WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage): (WTR::InjectedBundlePage::stopLoading): (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): (WTR::InjectedBundlePage::didFinishLoadForFrame): (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::notifyDone):
WebKitTestRunner/TestController.cpp: (WTR::TestController::didReceiveMessageFromInjectedBundle):

2011-01-18 Maciej Stachowiak <mjs@apple.com>

Reviewed by Sam Weinig.

WebKitTestRunner should track loading more like DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=52692

Relax the message check in didSaveFrameToPageCache a bit more, since
layout tests were still hitting the old one.

UIProcess/WebPageProxy.cpp: (WebKit::isDisconnectedFrame): (WebKit::WebPageProxy::didSaveFrameToPageCache):

7:00 PM Changeset in webkit [76091] by kbr@google.com

77 edits
21 adds
5 deletes in trunk/Source

2011-01-18 Ben Vanik <ben.vanik@gmail.com>

Reviewed by Kenneth Russell.

Updating ANGLE in WebKit to r533.
https://bugs.webkit.org/show_bug.cgi?id=47194

platform/graphics/ANGLEWebKitBridge.cpp: (WebCore::ANGLEWebKitBridge::ANGLEWebKitBridge): (WebCore::ANGLEWebKitBridge::~ANGLEWebKitBridge): (WebCore::ANGLEWebKitBridge::validateShaderSource): Update to new ANGLE API for shader validation.
platform/graphics/ANGLEWebKitBridge.h: (WebCore::ANGLEWebKitBridge::setResources): Renaming types to new names.
platform/graphics/mac/GraphicsContext3DMac.mm: (WebCore::GraphicsContext3D::GraphicsContext3D): Initialize ANGLEResources with ANGLE init call to prevent uninitialized variables.

2011-01-18 Ben Vanik <ben.vanik@gmail.com>

Reviewed by Kenneth Russell.

Updating ANGLE in WebKit to r533.
https://bugs.webkit.org/show_bug.cgi?id=47194

ANGLE.xcodeproj/project.pbxproj:
include/GLSLANG/ShaderLang.h:
src/common/debug.cpp: (gl::trace):
src/common/debug.h:
src/compiler/CodeGenGLSL.cpp: (ConstructCompiler):
src/compiler/CodeGenHLSL.cpp: (ConstructCompiler):
src/compiler/Common.h: (EncodeSourceLoc): (DecodeSourceLoc):
src/compiler/Compiler.cpp: Added. (TShHandleBase::TShHandleBase): (TShHandleBase::~TShHandleBase): (TCompiler::TCompiler): (TCompiler::~TCompiler): (TCompiler::Init): (TCompiler::compile): (TCompiler::InitBuiltInSymbolTable): (TCompiler::clearResults): (TCompiler::validateLimitations): (TCompiler::collectAttribsUniforms):
src/compiler/ExtensionBehavior.h: Added.
src/compiler/InfoSink.cpp: (TInfoSinkBase::location):
src/compiler/InfoSink.h: (TInfoSinkBase::size):
src/compiler/Initialize.cpp: (BuiltInFunctionsCommon): (BuiltInFunctionsVertex): (BuiltInFunctionsFragment): (StandardUniforms): (DefaultPrecisionVertex): (DefaultPrecisionFragment): (BuiltInConstants): (TBuiltIns::initialize): (IdentifyBuiltIns): (InitExtensionBehavior):
src/compiler/Initialize.h:
src/compiler/IntermTraverse.cpp: (TIntermLoop::traverse):
src/compiler/Intermediate.cpp: (getOperatorString): (TIntermediate::addBinaryMath): (TIntermediate::addLoop): (TIntermediate::postProcess): (TIntermBinary::promote):
src/compiler/OutputGLSL.cpp: (TOutputGLSL::visitUnary): (TOutputGLSL::visitLoop):
src/compiler/OutputHLSL.cpp: (sh::OutputHLSL::OutputHLSL): (sh::OutputHLSL::header): (sh::OutputHLSL::visitBinary): (sh::OutputHLSL::visitUnary): (sh::OutputHLSL::visitAggregate): (sh::OutputHLSL::visitLoop): (sh::OutputHLSL::handleExcessiveLoop): (sh::OutputHLSL::argumentString):
src/compiler/OutputHLSL.h:
src/compiler/ParseHelper.cpp: (ReportInfo): (DefineExtensionMacros): (TParseContext::error): (TParseContext::warning): (TParseContext::reservedErrorCheck): (TParseContext::constructorErrorCheck): (TParseContext::arrayQualifierErrorCheck): (TParseContext::extensionErrorCheck): (TParseContext::areAllChildConst): (PaParseStrings):
src/compiler/ParseHelper.h: (TParseContext::TParseContext):
src/compiler/PoolAlloc.cpp: (InitializeGlobalPools): (FreeGlobalPools): (SetGlobalPoolAllocator): (TPoolAllocator::TPoolAllocator): (TPoolAllocator::~TPoolAllocator): (TAllocation::checkAllocList):
src/compiler/PoolAlloc.h:
src/compiler/SearchSymbol.cpp: Added. (sh::SearchSymbol::SearchSymbol): (sh::SearchSymbol::traverse): (sh::SearchSymbol::visitSymbol): (sh::SearchSymbol::foundMatch):
src/compiler/SearchSymbol.h: Added.
src/compiler/ShHandle.h: (TCompiler::getAsCompiler): (TCompiler::getInfoSink): (TCompiler::getAttribs): (TCompiler::getUniforms): (TCompiler::getShaderType): (TCompiler::getShaderSpec):
src/compiler/ShaderLang.cpp: (getVariableMaxLength): (getVariableInfo): (ShInitBuiltInResources): (ShConstructCompiler): (ShCompile): (ShGetInfo): (ShGetInfoLog): (ShGetObjectCode): (ShGetActiveAttrib): (ShGetActiveUniform):
src/compiler/SymbolTable.cpp: (TSymbolTableLevel::relateToExtension):
src/compiler/SymbolTable.h: (TVariable::shareConstPointer): (TFunction::relateToExtension): (TFunction::getExtension): (TFunction::getParamCount): (TFunction::getParam): (TSymbolTable::getGlobalLevel): (TSymbolTable::relateToOperator): (TSymbolTable::relateToExtension):
src/compiler/TranslatorGLSL.cpp: (writeVersion): (TranslatorGLSL::TranslatorGLSL): (TranslatorGLSL::translate):
src/compiler/TranslatorGLSL.h:
src/compiler/TranslatorHLSL.cpp: (TranslatorHLSL::TranslatorHLSL): (TranslatorHLSL::translate):
src/compiler/TranslatorHLSL.h:
src/compiler/Types.h: (TType::TType):
src/compiler/UnfoldSelect.cpp: (sh::UnfoldSelect::visitSelection):
src/compiler/UnfoldSelect.h:
src/compiler/ValidateLimitations.cpp: Added. (ValidateLimitations::ValidateLimitations): (ValidateLimitations::visitSymbol): (ValidateLimitations::visitConstantUnion): (ValidateLimitations::visitBinary): (ValidateLimitations::visitUnary): (ValidateLimitations::visitSelection): (ValidateLimitations::visitAggregate): (ValidateLimitations::visitLoop): (ValidateLimitations::visitBranch): (ValidateLimitations::error): (ValidateLimitations::withinLoopBody): (ValidateLimitations::isLoopIndex): (ValidateLimitations::validateLoopType): (ValidateLimitations::validateForLoopHeader): (ValidateLimitations::validateForLoopInit): (ValidateLimitations::validateForLoopCond): (ValidateLimitations::validateForLoopExpr): (ValidateLimitations::validateFunctionCall): (ValidateLimitations::validateOperation): (ValidateLimitations::isConstExpr): (ValidateLimitations::isConstIndexExpr): (ValidateLimitations::validateIndexing):
src/compiler/ValidateLimitations.h: Added. (ValidateLimitations::numErrors):
src/compiler/VariableInfo.cpp: Added. (arrayBrackets): (getVariableDataType): (getVariableInfo): (getBuiltInVariableInfo): (getUserDefinedVariableInfo): (CollectAttribsUniforms::CollectAttribsUniforms): (CollectAttribsUniforms::visitSymbol): (CollectAttribsUniforms::visitConstantUnion): (CollectAttribsUniforms::visitBinary): (CollectAttribsUniforms::visitUnary): (CollectAttribsUniforms::visitSelection): (CollectAttribsUniforms::visitAggregate): (CollectAttribsUniforms::visitLoop): (CollectAttribsUniforms::visitBranch):
src/compiler/VariableInfo.h: Added.
src/compiler/VersionGLSL.cpp: Added. (TVersionGLSL::TVersionGLSL): (TVersionGLSL::visitSymbol): (TVersionGLSL::visitConstantUnion): (TVersionGLSL::visitBinary): (TVersionGLSL::visitUnary): (TVersionGLSL::visitSelection): (TVersionGLSL::visitAggregate): (TVersionGLSL::visitLoop): (TVersionGLSL::visitBranch): (TVersionGLSL::updateVersion):
src/compiler/VersionGLSL.h: Added. (TVersionGLSL::getVersion):
src/compiler/generate_glslang_lexer.sh: Added.
src/compiler/generate_glslang_parser.sh: Added.
src/compiler/glslang.h: Added.
src/compiler/glslang.l:
src/compiler/glslang.y:
src/compiler/glslang_lex.cpp: Added. (yy_get_next_buffer): (yy_get_previous_state): (yy_try_NUL_trans): (input): (yyrestart): (yy_switch_to_buffer): (yy_load_buffer_state): (yy_create_buffer): (yy_delete_buffer): (yy_init_buffer): (yy_flush_buffer): (yypush_buffer_state): (yypop_buffer_state): (yyensure_buffer_stack): (yy_scan_buffer): (yy_scan_string): (yy_scan_bytes): (yy_push_state): (yy_pop_state): (yy_top_state): (yy_fatal_error): (yyget_extra): (yyget_lineno): (yyget_column): (yyget_in): (yyget_out): (yyget_leng): (yyget_text): (yyset_extra): (yyset_lineno): (yyset_column): (yyset_in): (yyset_out): (yyget_debug): (yyset_debug): (yyget_lval): (yyset_lval): (yylex_init): (yylex_init_extra): (yy_init_globals): (yylex_destroy): (yy_flex_strncpy): (yy_flex_strlen): (yyalloc): (yyrealloc): (yyfree): (string_input): (check_type): (reserved_word): (yyerror): (glslang_initialize): (glslang_finalize): (glslang_scan):
src/compiler/glslang_tab.cpp: Added. (yytnamerr): (yysyntax_error): (glslang_parse):
src/compiler/glslang_tab.h: Added.
src/compiler/intermOut.cpp: (TOutputTraverser::TOutputTraverser): (OutputTreeText): (TOutputTraverser::visitSymbol): (TOutputTraverser::visitBinary): (TOutputTraverser::visitUnary): (TOutputTraverser::visitAggregate): (TOutputTraverser::visitSelection): (TOutputTraverser::visitConstantUnion): (TOutputTraverser::visitLoop): (TOutputTraverser::visitBranch): (TIntermediate::outputTree):
src/compiler/intermediate.h: (TIntermLoop::TIntermLoop): (TIntermLoop::getType): (TIntermLoop::getInit): (TIntermLoop::getCondition): (TIntermLoop::getExpression): (TIntermLoop::getBody):
src/compiler/localintermediate.h:
src/compiler/osinclude.h: (OS_GetTLSValue):
src/compiler/ossource_nspr.cpp: Added. (OS_AllocTLSIndex): (OS_SetTLSValue): (OS_FreeTLSIndex):
src/compiler/preprocessor/compile.h:
src/compiler/preprocessor/cpp.c: (CPPdefine): (CPPelse): (CPPif): (CPPifdef): (CPPerror): (CPPextension): (readCPPline):
src/compiler/preprocessor/preprocess.h:
src/compiler/preprocessor/scanner.c: (str_getch): (str_ungetch): (ScanFromString): (lFloatConst): (byte_scan): (yylex_CPP): (check_EOF):
src/compiler/preprocessor/scanner.h:
src/compiler/preprocessor/tokens.c: (RecordToken): (ReadToken):
src/compiler/tools: Removed.
src/compiler/unistd.h: Removed.
src/compiler/util.cpp: Added. (atof_dot):
src/compiler/util.h: Added.
src/libEGL/Config.cpp: (egl::Config::set):
src/libEGL/Display.cpp: (egl::Display::Display): (egl::Display::initialize): (egl::Display::terminate): (egl::Display::createDevice): (egl::Display::resetDevice): (egl::Display::createContext): (egl::Display::destroyContext): (egl::Display::getMinSwapInterval): (egl::Display::getMaxSwapInterval): (egl::Display::getDevice): (egl::Display::getFloatTextureSupport): (egl::Display::getHalfFloatTextureSupport): (egl::Display::getLuminanceTextureSupport): (egl::Display::getLuminanceAlphaTextureSupport): (egl::Display::getBufferPool): (egl::Display::getEventQuerySupport): (egl::Display::getDefaultPresentParameters):
src/libEGL/Display.h:
src/libEGL/Surface.cpp: (egl::Surface::Surface): (egl::Surface::~Surface): (egl::Surface::release): (egl::Surface::resetSwapChain): (egl::Surface::writeRecordableFlipState): (egl::Surface::restoreState): (egl::SurfaceWindowProc): (egl::Surface::subclassWindow): (egl::Surface::unsubclassWindow): (egl::Surface::checkForOutOfDateSwapChain): (egl::Surface::convertInterval): (egl::Surface::swap): (egl::Surface::getRenderTarget): (egl::Surface::setSwapInterval):
src/libEGL/Surface.h:
src/libEGL/libEGL.cpp:
src/libGLESv2/Blit.cpp: (gl::Blit::copySurfaceToTexture): (gl::Blit::setCommonBlitState):
src/libGLESv2/Buffer.cpp: (gl::Buffer::Buffer): (gl::Buffer::~Buffer): (gl::Buffer::bufferData): (gl::Buffer::bufferSubData): (gl::Buffer::getVertexBuffer): (gl::Buffer::getIndexBuffer): (gl::Buffer::invalidateStaticData):
src/libGLESv2/Buffer.h:
src/libGLESv2/Context.cpp: (gl::Context::Context): (gl::Context::~Context): (gl::Context::makeCurrent): (gl::Context::markAllStateDirty): (gl::Context::setFragmentShaderDerivativeHint): (gl::Context::setEnableVertexAttribArray): (gl::Context::getVertexAttribState): (gl::Context::getVertexAttributes): (gl::Context::createFence): (gl::Context::deleteFence): (gl::Context::bindTexture2D): (gl::Context::bindTextureCubeMap): (gl::Context::getFence): (gl::Context::getTexture2D): (gl::Context::getTextureCubeMap): (gl::Context::getSamplerTexture): (gl::Context::getBooleanv): (gl::Context::getIntegerv): (gl::Context::getQueryParameterInfo): (gl::Context::applyRenderTarget): (gl::Context::applyState): (gl::Context::lookupAttributeMapping): (gl::Context::applyVertexBuffer): (gl::Context::applyIndexBuffer): (gl::Context::readPixels): (gl::Context::clear): (gl::Context::drawArrays): (gl::Context::drawElements): (gl::Context::finish): (gl::Context::drawClosingLine): (gl::Context::getMaximumVaryingVectors): (gl::Context::getMaximumFragmentUniformVectors): (gl::Context::supportsEventQueries): (gl::Context::supportsFloatTextures): (gl::Context::supportsFloatLinearFilter): (gl::Context::supportsFloatRenderableTextures): (gl::Context::supportsHalfFloatTextures): (gl::Context::supportsHalfFloatLinearFilter): (gl::Context::supportsHalfFloatRenderableTextures): (gl::Context::getMaximumRenderbufferDimension): (gl::Context::getMaximumTextureDimension): (gl::Context::getMaximumCubeTextureDimension): (gl::Context::getMaximumTextureLevel): (gl::Context::supportsLuminanceTextures): (gl::Context::supportsLuminanceAlphaTextures): (gl::Context::supports32bitIndices): (gl::Context::getIncompleteTexture): (gl::Context::setVertexAttrib): (gl::Context::initExtensionString): (gl::Context::blitFramebuffer):
src/libGLESv2/Context.h: (gl::VertexAttribute::VertexAttribute): (gl::VertexAttribute::typeSize): (gl::VertexAttribute::stride):
src/libGLESv2/Fence.cpp: Added. (gl::Fence::Fence): (gl::Fence::~Fence): (gl::Fence::isFence): (gl::Fence::setFence): (gl::Fence::testFence): (gl::Fence::finishFence): (gl::Fence::getFenceiv):
src/libGLESv2/Fence.h: Added.
src/libGLESv2/Framebuffer.cpp: (gl::Framebuffer::completeness): (gl::DefaultFramebuffer::DefaultFramebuffer): (gl::DefaultFramebuffer::completeness):
src/libGLESv2/Program.cpp: (gl::Program::Program): (gl::Program::getSamplerMapping): (gl::Program::getUniformLocation): (gl::Program::setUniform1iv): (gl::Program::applyUniforms): (gl::Program::packVaryings): (gl::Program::linkVaryings): (gl::Program::link): (gl::Program::defineUniform): (gl::Program::createUniform): (gl::Program::applyUniform1iv): (gl::Program::resetInfoLog): (gl::Program::unlink): (gl::Program::getActiveAttribute): (gl::Program::getActiveUniform): (gl::Program::getDxDepthRangeLocation):
src/libGLESv2/Program.h:
src/libGLESv2/RefCountObject.cpp: (gl::RefCountObject::~RefCountObject):
src/libGLESv2/Renderbuffer.cpp: (gl::RenderbufferStorage::RenderbufferStorage): (gl::RenderbufferStorage::isFloatingPoint): (gl::Colorbuffer::Colorbuffer): (gl::DepthStencilbuffer::DepthStencilbuffer):
src/libGLESv2/Renderbuffer.h:
src/libGLESv2/Shader.cpp: (gl::Shader::Shader): (gl::Shader::parseVaryings): (gl::Shader::compileToHLSL): (gl::VertexShader::parseAttributes):
src/libGLESv2/Texture.cpp: (gl::Texture::Texture): (gl::Texture::isFloatingPoint): (gl::Texture::isRenderableFormat): (gl::Texture::selectFormat): (gl::Texture::loadImageData): (gl::Texture::loadAlphaFloatImageData): (gl::Texture::loadAlphaHalfFloatImageData): (gl::Texture::loadLuminanceImageData): (gl::Texture::loadLuminanceFloatImageData): (gl::Texture::loadLuminanceHalfFloatImageData): (gl::Texture::loadLuminanceAlphaImageData): (gl::Texture::loadLuminanceAlphaFloatImageData): (gl::Texture::loadLuminanceAlphaHalfFloatImageData): (gl::Texture::loadRGBFloatImageData): (gl::Texture::loadRGBHalfFloatImageData): (gl::Texture::loadRGBAFloatImageData): (gl::Texture::loadRGBAHalfFloatImageData): (gl::Texture::createSurface): (gl::Texture::setImage): (gl::Texture::setCompressedImage): (gl::Texture::subImage): (gl::Texture::subImageCompressed): (gl::Texture::copyNonRenderable): (gl::Texture::getD3DFormat): (gl::Texture::isRenderable): (gl::Texture2D::Texture2D): (gl::Texture2D::~Texture2D): (gl::Texture2D::redefineTexture): (gl::Texture2D::setImage): (gl::Texture2D::setCompressedImage): (gl::Texture2D::copyImage): (gl::Texture2D::copySubImage): (gl::Texture2D::isComplete): (gl::Texture2D::createTexture): (gl::Texture2D::convertToRenderTarget): (gl::Texture2D::generateMipmaps): (gl::Texture2D::getColorbuffer): (gl::Texture2D::getRenderTarget): (gl::TextureCubeMap::TextureCubeMap): (gl::TextureCubeMap::~TextureCubeMap): (gl::TextureCubeMap::subImage): (gl::TextureCubeMap::subImageCompressed): (gl::TextureCubeMap::isComplete): (gl::TextureCubeMap::createTexture): (gl::TextureCubeMap::convertToRenderTarget): (gl::TextureCubeMap::redefineTexture): (gl::TextureCubeMap::copyImage): (gl::TextureCubeMap::copySubImage): (gl::TextureCubeMap::generateMipmaps): (gl::TextureCubeMap::getColorbuffer): (gl::TextureCubeMap::getRenderTarget): (gl::Texture::TextureColorbufferProxy::TextureColorbufferProxy): (gl::Texture::TextureColorbufferProxy::isFloatingPoint):
src/libGLESv2/Texture.h:
src/libGLESv2/geometry/IndexDataManager.cpp: (gl::IndexDataManager::IndexDataManager): (gl::IndexDataManager::~IndexDataManager): (gl::convertIndices): (gl::computeRange): (gl::IndexDataManager::prepareIndexData): (gl::IndexDataManager::indexSize): (gl::IndexDataManager::typeSize): (gl::IndexBuffer::IndexBuffer): (gl::IndexBuffer::~IndexBuffer): (gl::IndexBuffer::getBuffer): (gl::IndexBuffer::unmap): (gl::StreamingIndexBuffer::StreamingIndexBuffer): (gl::StreamingIndexBuffer::~StreamingIndexBuffer): (gl::StreamingIndexBuffer::map): (gl::StreamingIndexBuffer::reserveSpace): (gl::StaticIndexBuffer::StaticIndexBuffer): (gl::StaticIndexBuffer::~StaticIndexBuffer): (gl::StaticIndexBuffer::map): (gl::StaticIndexBuffer::reserveSpace): (gl::StaticIndexBuffer::lookupType): (gl::StaticIndexBuffer::lookupRange): (gl::StaticIndexBuffer::addRange):
src/libGLESv2/geometry/IndexDataManager.h: (gl::IndexBuffer::size):
src/libGLESv2/geometry/VertexDataManager.cpp: (gl::VertexDataManager::VertexDataManager): (gl::VertexDataManager::~VertexDataManager): (gl::VertexDataManager::writeAttributeData): (gl::VertexDataManager::prepareVertexData): (gl::VertexDataManager::spaceRequired): (gl::VertexDataManager::checkVertexCaps): (gl::VertexDataManager::typeIndex): (gl::VertexDataManager::setupAttributes): (gl::VertexBuffer::VertexBuffer): (gl::VertexBuffer::~VertexBuffer): (gl::VertexBuffer::unmap): (gl::VertexBuffer::getBuffer): (gl::ConstantVertexBuffer::ConstantVertexBuffer): (gl::ConstantVertexBuffer::~ConstantVertexBuffer): (gl::ArrayVertexBuffer::ArrayVertexBuffer): (gl::ArrayVertexBuffer::~ArrayVertexBuffer): (gl::ArrayVertexBuffer::addRequiredSpace): (gl::ArrayVertexBuffer::addRequiredSpaceFor): (gl::StreamingVertexBuffer::StreamingVertexBuffer): (gl::StreamingVertexBuffer::~StreamingVertexBuffer): (gl::StreamingVertexBuffer::map): (gl::StreamingVertexBuffer::reserveRequiredSpace): (gl::StaticVertexBuffer::StaticVertexBuffer): (gl::StaticVertexBuffer::~StaticVertexBuffer): (gl::StaticVertexBuffer::map): (gl::StaticVertexBuffer::reserveRequiredSpace): (gl::StaticVertexBuffer::lookupAttribute): (gl::VertexDataManager::formatConverter):
src/libGLESv2/geometry/VertexDataManager.h: (gl::ArrayVertexBuffer::size): (gl::VertexDataManager::dirtyCurrentValue):
src/libGLESv2/geometry/backend.cpp: Removed.
src/libGLESv2/geometry/backend.h: Removed.
src/libGLESv2/geometry/dx9.cpp: Removed.
src/libGLESv2/geometry/dx9.h: Removed.
src/libGLESv2/libGLESv2.cpp:
src/libGLESv2/libGLESv2.def:
src/libGLESv2/libGLESv2.vcproj:
src/libGLESv2/utilities.cpp: (gl::UniformComponentCount): (gl::UniformComponentType): (gl::ComputePixelSize): (gl::CheckTextureFormatType): (gl::IsColorRenderable): (gl::IsDepthRenderable): (gl::IsStencilRenderable): (es2dx::GetAlphaSize): (es2dx::GetRedSize): (es2dx::GetGreenSize): (es2dx::GetBlueSize): (es2dx::GetDepthSize): (es2dx::ConvertPrimitiveType): (dx2es::ConvertBackBufferFormat): (dx2es::ConvertDepthStencilFormat):
src/libGLESv2/utilities.h:

6:37 PM Changeset in webkit [76090] by oliver@apple.com

6 edits in trunk

2011-01-18 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

[jsfunfuzz] Assertion asking activation for arguments when arguments is overridden
https://bugs.webkit.org/show_bug.cgi?id=52690

Add a few more tests.

fast/js/function-dot-arguments-expected.txt:
fast/js/script-tests/function-dot-arguments.js: (overwroteArgumentsInDynamicScope1): (overwroteArgumentsInDynamicScope2): (overwroteArgumentsInDynamicScope3):

2011-01-18 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

[jsfunfuzz] Assertion asking activation for arguments when arguments is overridden
https://bugs.webkit.org/show_bug.cgi?id=52690

Clean up code to retrieve arguments from activation and function objects.
Remove the incorrect assertion from JSActivation's argumentsGetter.

interpreter/Interpreter.cpp: (JSC::Interpreter::retrieveArguments):
runtime/JSActivation.cpp: (JSC::JSActivation::argumentsGetter):

5:46 PM Changeset in webkit [76089] by beidson@apple.com

2 edits in trunk/Source/WebKit2

<rdar://problem/8860833> and https://bugs.webkit.org/show_bug.cgi?id=52599
UIProcess crash in WebPageProxy::reattachToWebProcess when web process crashes with a new tab/window.

Reviewed by Darin Adler.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::reattachToWebProcessWithItem): Null check item *both* places it is used.

5:44 PM Changeset in webkit [76088] by dimich@chromium.org

1 edit
2 adds in trunk/LayoutTests

[Chromium] Not reviewed, adding pixel expectations for new test.

platform/chromium-mac/fast/css/background-clip-values-expected.checksum: Added.
platform/chromium-mac/fast/css/background-clip-values-expected.png: Added.

5:37 PM Changeset in webkit [76087] by beidson@apple.com

10 edits in trunk/Source/WebKit2

<rdar://problem/8752200> and https://bugs.webkit.org/show_bug.cgi?id=52664
Need WebKit2 API to asynchronously get the resource data for a URL

Reviewed by Maciej Stachowiak.

Rename WKFrameGetMainResourceDataFunction to WKFrameGetResourceDataFunction, and add
new API to get a resource by URL:

UIProcess/API/C/WKFrame.cpp:

(WKFrameGetMainResourceData):
(WKFrameGetResourceData):
(callGetResourceDataBlockAndDispose):
(WKFrameGetMainResourceData_b):
(WKFrameGetResourceData_b):

UIProcess/API/C/WKFrame.h:

Implement the new API in the UIProcess side:

UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::getResourceData):

UIProcess/WebFrameProxy.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::getResourceDataFromFrame):

UIProcess/WebPageProxy.h:

Have the WebProcess get the data and call back to the UIProcess:

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::getResourceDataFromFrame):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

5:30 PM Changeset in webkit [76086] by andersca@apple.com

3 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Make PageClientImpl::scrollView do hardware blitting
https://bugs.webkit.org/show_bug.cgi?id=52689

UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::scrollView): Clip the scroll rect and scroll the view.

UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::incorporateUpdate): Scroll before painting.

5:16 PM Changeset in webkit [76085] by andersca@apple.com

2 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Artifacts when scrolling with new drawing area
https://bugs.webkit.org/show_bug.cgi?id=52682

WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::scroll): When scrolling, we want the intersection of the scroll rect and clip rect.

5:13 PM Changeset in webkit [76084] by jberlin@webkit.org

1 edit
2 adds in trunk/LayoutTests

Add a test that calling window.open with an empty URL does not trigger an assertion or
cause a crash.
https://bugs.webkit.org/show_bug.cgi?id=52654

Reviewed by Adam Roben.

fast/dom/Window/open-window-empty-url-expected.txt: Added.
fast/dom/Window/open-window-empty-url.html: Added.

5:10 PM Changeset in webkit [76083] by morrita@google.com

23 edits
2 adds in trunk/Source/WebCore

2011-01-18 MORITA Hajime <morrita@google.com>

Reviewed by Simon Fraser.

Refactoring: Extract RoundedIntRect class
https://bugs.webkit.org/show_bug.cgi?id=51664

RoundedIntRect is a pair of rect and four IntSize objects which represent
corner radii of the rectangle. IntSize is grouped into RoundedIntRect::Radii.
Now RenderStyle::getRoundedBorderFor() and RenderStyle::getRoundedInnerBorderWithBorderWidths()
return RoundedIntRect and GraphicsContext::addRoundedRectClip(), GraphicsContext::fillRoundedRect()
and other functions accept RoundedIntRect as an argument.

Android.mk:
CMakeLists.txt:
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::addRoundedRectClip): (WebCore::GraphicsContext::clipOutRoundedRect): (WebCore::GraphicsContext::fillRoundedRect):
platform/graphics/GraphicsContext.h:
platform/graphics/RoundedIntRect.cpp: Added. (WebCore::RoundedIntRect::Radii::isZero): (WebCore::RoundedIntRect::Radii::scale): (WebCore::RoundedIntRect::Radii::expand): (WebCore::RoundedIntRect::Radii::includeLogicalEdges): (WebCore::RoundedIntRect::Radii::excludeLogicalEdges): (WebCore::RoundedIntRect::RoundedIntRect): (WebCore::RoundedIntRect::includeLogicalEdges): (WebCore::RoundedIntRect::excludeLogicalEdges):
platform/graphics/RoundedIntRect.h: Added. (WebCore::RoundedIntRect::Radii::Radii): (WebCore::RoundedIntRect::Radii::setTopLeft): (WebCore::RoundedIntRect::Radii::setTopRight): (WebCore::RoundedIntRect::Radii::setBottomLeft): (WebCore::RoundedIntRect::Radii::setBottomRight): (WebCore::RoundedIntRect::Radii::topLeft): (WebCore::RoundedIntRect::Radii::topRight): (WebCore::RoundedIntRect::Radii::bottomLeft): (WebCore::RoundedIntRect::Radii::bottomRight): (WebCore::RoundedIntRect::Radii::expand): (WebCore::RoundedIntRect::Radii::shrink): (WebCore::RoundedIntRect::rect): (WebCore::RoundedIntRect::radii): (WebCore::RoundedIntRect::isRounded): (WebCore::RoundedIntRect::isEmpty): (WebCore::RoundedIntRect::setRect): (WebCore::RoundedIntRect::setRadii): (WebCore::RoundedIntRect::move): (WebCore::RoundedIntRect::inflate): (WebCore::RoundedIntRect::inflateWithRadii): (WebCore::RoundedIntRect::expandRadii): (WebCore::RoundedIntRect::shrinkRadii):
rendering/RenderBox.cpp: (WebCore::RenderBox::pushContentsClip):
rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): (WebCore::RenderBoxModelObject::paintBorder): (WebCore::RenderBoxModelObject::clipBorderSidePolygon): (WebCore::RenderBoxModelObject::paintBoxShadow):
rendering/RenderBoxModelObject.h:
rendering/RenderObject.cpp: (WebCore::RenderObject::drawBoxSideFromPath):
rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint):
rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMenuListButtonGradients): (WebCore::RenderThemeMac::paintSliderTrack):
rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintMenuListButtonGradients): (WebCore::RenderThemeSafari::paintSliderTrack):
rendering/RenderThemeWinCE.cpp: (WebCore::RenderThemeWinCE::paintSearchFieldCancelButton):
rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
rendering/style/BorderData.h:
rendering/style/RenderStyle.cpp: (WebCore::calcRadiiFor): (WebCore::calcConstraintScaleFor): (WebCore::RenderStyle::getRoundedBorderFor): (WebCore::RenderStyle::getRoundedInnerBorderWithBorderWidths):
rendering/style/RenderStyle.h: (WebCore::InheritedFlags::setBorderRadius):

4:30 PM Changeset in webkit [76082] by ojan@chromium.org

3 edits in trunk/Websites/bugs.webkit.org

2011-01-18 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

make file expansion use the file at the svn revision the diff was created at
https://bugs.webkit.org/show_bug.cgi?id=52650

This only works for patches created with SVN for now since the git
diff does not include SVN revision numbers in it.

PrettyPatch/PrettyPatch.rb:
code-review.js:

4:15 PM Changeset in webkit [76081] by mihaip@chromium.org

2 edits in trunk/Tools

2011-01-18 Mihai Parparita <mihaip@chromium.org>

Reviewed by Kent Tamura.

[Chromium] NRWT looking for DRT binary in the wrong path on Mac
https://bugs.webkit.org/show_bug.cgi?id=52678

Update path now that WebKit is inside Source.

Scripts/webkitpy/layout_tests/port/chromium_mac.py:

4:15 PM Changeset in webkit [76080] by andersca@apple.com

3 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Use a CGLayer for the backing store when possible
https://bugs.webkit.org/show_bug.cgi?id=52679

UIProcess/mac/BackingStoreMac.mm: (WebKit::BackingStore::paint): If there is a layer, paint it into the given context.

(WebKit::BackingStore::backingStoreContext):
If we can get the containing window graphics context, use it to create a
CGLayer that we'll use for the backing store.

(WebKit::BackingStore::scroll):
Paint the layer into itself.

UIProcess/mac/WebPageProxyMac.mm: (WebKit::WebPageProxy::containingWindowGraphicsContext): Call the page client.

3:49 PM Changeset in webkit [76079] by robert@webkit.org

7 edits in trunk

2011-01-18 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] http/tests/incremental/slow-utf8-text.pl fails
https://bugs.webkit.org/show_bug.cgi?id=44282

platform/qt/Skipped:

2011-01-18 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] http/tests/incremental/slow-utf8-text.pl fails
https://bugs.webkit.org/show_bug.cgi?id=44282

WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::responseMimeType):
WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-01-18 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] http/tests/incremental/slow-utf8-text.pl fails
https://bugs.webkit.org/show_bug.cgi?id=44282

DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::dump):

3:45 PM Changeset in webkit [76078] by ggaren@apple.com

4 edits in trunk/Source/JavaScriptCore

2011-01-18 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.

Removed RegisterFile::markGlobals because it was obtuse, and it
unnecessarily relied on conservative marking.
https://bugs.webkit.org/show_bug.cgi?id=52668

interpreter/RegisterFile.h: Removed markGlobals.

runtime/JSActivation.cpp: (JSC::JSActivation::markChildren): Added a comment explaning why some JSActivations don't always mark their registers arrays.

runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::markChildren): Instead of calling markGlobals, mark the registers array directly.

3:40 PM Changeset in webkit [76077] by andersca@apple.com

5 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Pass the web page proxy to BackingStore::create
https://bugs.webkit.org/show_bug.cgi?id=52673

UIProcess/BackingStore.cpp: (WebKit::BackingStore::create): Add WebPageProxy parameter.

(WebKit::BackingStore::BackingStore):
Add WebPageProxy parameter.

UIProcess/BackingStore.h: Add WebPageProxy member variable.

UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::incorporateUpdate): Pass the web page proxy when creating the backing store.

UIProcess/mac/BackingStoreMac.mm: (WebKit::BackingStore::backingStoreContext): Set the default blend mode.

3:31 PM Changeset in webkit [76076] by msaboff@apple.com

5 edits in trunk

2011-01-18 Michael Saboff <msaboff@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/8875432> Regression: Some text-only e-mails cause hang beneath RegExp::match (52540)
https://bugs.webkit.org/show_bug.cgi?id=52540
https://bugs.webkit.org/show_bug.cgi?id=52662

Directly use backtrack label with parentheses nested under a
non-capturing parentheses. Also linked current parentheses
tail code object for possible parens nested within a non-capturing
parentheses.

yarr/YarrJIT.cpp: (JSC::Yarr::YarrGenerator::BacktrackDestination::linkBacktrackToLabel): (JSC::Yarr::YarrGenerator::generateParenthesesSingle):

2011-01-18 Michael Saboff <msaboff@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/8875432> Regression: Some text-only e-mails cause hang beneath RegExp::match (52540)
https://bugs.webkit.org/show_bug.cgi?id=52540
https://bugs.webkit.org/show_bug.cgi?id=52662

New tests to check for proper linking of parentheses nested under
a non-capturing parentheses.

fast/regex/parentheses-expected.txt:
fast/regex/script-tests/parentheses.js:

3:27 PM Changeset in webkit [76075] by commit-queue@webkit.org

4 edits in trunk/Source

2011-01-18 Victoria Kirst <vrk@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Adding support for YV16 video frame formats.
https://bugs.webkit.org/show_bug.cgi?id=52345

platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::determineTextureFormat): (WebCore::VideoLayerChromium::draw):

2011-01-18 Victoria Kirst <vrk@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Adding support for YV16 video frame formats.
https://bugs.webkit.org/show_bug.cgi?id=52345

src/VideoFrameChromiumImpl.cpp: (WebKit::VideoFrameChromiumImpl::requiredTextureSize):

3:24 PM Changeset in webkit [76074] by hyatt@apple.com

3 edits
4 adds in trunk

<rdar://problem/8479998> REGRESSION (r67660): broken button layout at devforums.apple.com

Reviewed by Dan Bernstein.

Exclude floating objects from shrinking to avoid floats. They should never do this. Timing-related bugs could
occur as a result of this mistake, and the change to rewrite pagination to defer layout of floats until they
got encountered on the correct line exposed this issue.

Source/WebCore:

Added /fast/block/float/float-overflow-hidden-containing-block-width.html.

rendering/RenderBox.cpp:

(WebCore::RenderBox::shrinkToAvoidFloats):

LayoutTests:

Added /fast/block/float/float-overflow-hidden-containing-block-width.html.

fast/block/float/float-overflow-hidden-containing-block-width.html: Added.
platform/mac/fast/block/float/float-overflow-hidden-containing-block-width-expected.checksum: Added.
platform/mac/fast/block/float/float-overflow-hidden-containing-block-width-expected.png: Added.
platform/mac/fast/block/float/float-overflow-hidden-containing-block-width-expected.txt: Added.

3:21 PM Changeset in webkit [76073] by dpranke@chromium.org

2 edits in trunk/Tools

2011-01-18 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

Fix a small race condition that could cause the unit tests for
new-run-webkit-tests to fail in a multithreaded environment.
There was a small window in the code where one thread would
check to see if a thread had raised an exception, do something,
and then check to see if the thread was alive. If the other
thread raised an exception and exited in between these two
steps, the exception would be lost. Flipping the order of the
two checks fixes the race, since we will now always check for an
exception on the thread before exiting.

https://bugs.webkit.org/show_bug.cgi?id=51579

Scripts/webkitpy/layout_tests/layout_package/message_broker.py:

3:08 PM Changeset in webkit [76072] by andersca@apple.com

3 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Factor code to create the backing store bitmap context out into a new function
https://bugs.webkit.org/show_bug.cgi?id=52670

UIProcess/BackingStore.h:
UIProcess/mac/BackingStoreMac.mm: (WebKit::BackingStore::backingStoreContext): Create the backing store context.

(WebKit::BackingStore::incorporateUpdate):
Call backingStoreContext.

(WebKit::BackingStore::scroll):
Assert that the context is not null.

2:59 PM Changeset in webkit [76071] by eric@webkit.org

6 edits in trunk/Tools

2011-01-18 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

commit-queue dies when test archiving fails
https://bugs.webkit.org/show_bug.cgi?id=52617

I looked at the machine and it had 10 archives already
thus find_unused_name was returning None. I've upped
the limit to 100 (per bug) and tested the case where
find_unused_name returns None (making archive return None).

Scripts/webkitpy/common/system/workspace.py:
Scripts/webkitpy/common/system/workspace_unittest.py:
Scripts/webkitpy/tool/bot/commitqueuetask.py:
Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
Scripts/webkitpy/tool/commands/queues.py:

2:56 PM Changeset in webkit [76070] by dimich@chromium.org

5 edits
2 adds in trunk/LayoutTests

[Chromium] Not reviewed, updated expectations for tests
affected by http://trac.webkit.org/changeset/76047

platform/chromium-mac/fast/backgrounds/size/backgroundSize22-expected.checksum:
platform/chromium-mac/fast/backgrounds/size/backgroundSize22-expected.png:
platform/chromium-win/fast/backgrounds/size/backgroundSize22-expected.checksum:
platform/chromium-win/fast/backgrounds/size/backgroundSize22-expected.png:
platform/chromium-win/fast/css/background-clip-values-expected.checksum: Added.
platform/chromium-win/fast/css/background-clip-values-expected.png: Added.

2:55 PM Changeset in webkit [76069] by andersca@apple.com

5 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Add PageClientImpl::containingWindowGraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=52666

UIProcess/API/mac/PageClientImpl.h:
UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::containingWindowGraphicsContext):
UIProcess/PageClient.h:
UIProcess/WebPageProxy.h:

2:53 PM Changeset in webkit [76068] by dbates@webkit.org

2 edits in trunk/Source/JavaScriptCore

2011-01-18 Daniel Bates <dbates@rim.com>

Reviewed by Gavin Barraclough.

Only use moving memory model assumption in ExecutableAllocator::intializePageSize() for Symbian OS
https://bugs.webkit.org/show_bug.cgi?id=52517

Patch by David Tapuska

Currently, we compile code with respect to the Symbian-specific moving memory model
assumption for all ARMv5 or lower architectures. Instead, we should only compile
such code when building for Symbian OS on those architectures because this model
is Symbian-specific.

jit/ExecutableAllocator.cpp: (JSC::ExecutableAllocator::intializePageSize):

2:45 PM Changeset in webkit [76067] by zmo@google.com

3 edits in trunk/Source/WebCore

2011-01-18 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Make CheckedInt<long> and CheckedInt<unsigned long> work
https://bugs.webkit.org/show_bug.cgi?id=52401

html/canvas/CheckedInt.h: (WebCore::CheckedInt::CheckedInt): Merge with the patch provided by Benoit Jacob.
html/canvas/WebGLBuffer.cpp: (WebCore::WebGLBuffer::associateBufferDataImpl): Use CheckedInt<long> instead of CheckedInt<int>. (WebCore::WebGLBuffer::associateBufferSubDataImpl): Ditto.

2:30 PM Changeset in webkit [76066] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit2

2011-01-18 Damian Kaleta <dkaleta@apple.com>

Reviewed by Sam Weinig.

WK2 methods WKPageScaleWebView and WKPageGetViewScaleFactor need to have consistent names
https://bugs.webkit.org/show_bug.cgi?id=52647

UIProcess/API/C/WKPage.cpp: (WKPageSetScaleFactor): (WKPageGetScaleFactor):
UIProcess/API/C/WKPage.h:

2:22 PM Changeset in webkit [76065] by andersca@apple.com

4 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Ask the web page proxy to scroll the view when needed
https://bugs.webkit.org/show_bug.cgi?id=52665

UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::incorporateUpdate):
UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::scrollView):
UIProcess/WebPageProxy.h:

2:18 PM Changeset in webkit [76064] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Fix build.

UIProcess/win/WebView.cpp:

(WebKit::WebView::scrollView):

2:11 PM Changeset in webkit [76063] by kbr@google.com

7 edits
4 adds in trunk

2011-01-18 Kenneth Russell <kbr@google.com>

Reviewed by David Levin.

Must strip comments from WebGL shaders before enforcing character set
https://bugs.webkit.org/show_bug.cgi?id=52390

Strip comments from incoming shaders, preserving line numbers,
before validating that they conform to the ESSL character set.
Revert changes from http://trac.webkit.org/changeset/75735 which
allowed invalid characters to be passed to certain APIs.

Tested with WebGL layout tests, conformance test suite and several
WebGL demos in both Safari and Chromium.

html/canvas/WebGLRenderingContext.cpp: (WebCore::StripComments::StripComments::process): (WebCore::WebGLRenderingContext::shaderSource):

2011-01-18 Kenneth Russell <kbr@google.com>

Reviewed by David Levin.

Must strip comments from WebGL shaders before enforcing character set
https://bugs.webkit.org/show_bug.cgi?id=52390

Incorporated non-ASCII GLSL conformance tests from Khronos
repository. Updated and synchronized invalid-passed-params.html
with Khronos repository, undoing changes from
http://trac.webkit.org/changeset/75735 .

fast/canvas/webgl/glsl-conformance-expected.txt:
fast/canvas/webgl/invalid-passed-params-expected.txt:
fast/canvas/webgl/invalid-passed-params.html:
fast/canvas/webgl/shaders/00_shaders.txt:
fast/canvas/webgl/shaders/misc: Added.
fast/canvas/webgl/shaders/misc/00_shaders.txt: Added.
fast/canvas/webgl/shaders/misc/non-ascii-comments.vert: Added.
fast/canvas/webgl/shaders/misc/non-ascii.vert: Added.

2:08 PM Changeset in webkit [76062] by andersca@apple.com

8 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add PageClient::scrollView
https://bugs.webkit.org/show_bug.cgi?id=52663

UIProcess/API/mac/PageClientImpl.h:
UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::scrollView):
UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::scrollView):
UIProcess/API/qt/qwkpage_p.h:
UIProcess/PageClient.h:
UIProcess/win/WebView.cpp: (WebKit::PageClientImpl::scrollView):
UIProcess/win/WebView.h:

1:55 PM Changeset in webkit [76061] by andersca@apple.com

14 edits in trunk/Source/WebKit2

Rename scrollDelta to scrollOffset everywhere.

Reviewed by Sam Weinig.

Shared/UpdateInfo.cpp:

(WebKit::UpdateInfo::encode):
(WebKit::UpdateInfo::decode):

Shared/UpdateInfo.h:
UIProcess/BackingStore.h:
UIProcess/mac/BackingStoreMac.mm:

(WebKit::BackingStore::incorporateUpdate):
(WebKit::BackingStore::scroll):

WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::scroll):
(WebKit::WebChromeClient::delegatedScrollRequested):

WebProcess/WebCoreSupport/WebChromeClient.h:
WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:

(WebKit::ChunkedUpdateDrawingArea::scroll):

WebProcess/WebPage/ChunkedUpdateDrawingArea.h:
WebProcess/WebPage/DrawingArea.h:
WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::scroll):
(WebKit::DrawingAreaImpl::display):

WebProcess/WebPage/DrawingAreaImpl.h:
WebProcess/WebPage/LayerBackedDrawingArea.cpp:

(WebKit::LayerBackedDrawingArea::scroll):

WebProcess/WebPage/LayerBackedDrawingArea.h:

1:46 PM Changeset in webkit [76060] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

2011-01-18 Dimitry Andric <dim@freebsd.org>

Reviewed by Andreas Kling.

Fix linking JavaScriptCore on FreeBSD/amd64
https://bugs.webkit.org/show_bug.cgi?id=52591

Linking of JavaScriptCore on FreeBSD/amd64 fails, for the same reason as
in bug 28422: cti_vm_throw needs a "@plt" suffix, otherwise the linker
complains about the relocation type.

jit/JITStubs.cpp: use @plt suffix on x86_64 platforms, for both Linux and FreeBSD.

1:43 PM Changeset in webkit [76059] by dpranke@chromium.org

3 edits in trunk/Tools

2011-01-18 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

Update rebaseline-chromium-webkit-tests unit tests to use a mock
filesystem. Also fix a couple of "with" statements missed by
r76050.

https://bugs.webkit.org/show_bug.cgi?id=52487

Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:

1:37 PM Changeset in webkit [76058] by cmarrin@apple.com

1 edit
12 adds in trunk/LayoutTests

2011-01-18 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

Add LayoutTests for new compositing layer logic
https://bugs.webkit.org/show_bug.cgi?id=52657

Add 4 tests checking that the layer tree is properly constructed with nested
layers. The first test is a simple static test of a layer with a 3D transform
with a non-layered parent. It is a pixel test and is just looking for a correct
image. The second test is similar but has a 4 deep hierarchy of <div> element where
only the innermost layer has a 3D transform. It is also a pixel test.
The other 2 tests are the same except that they add and then remove the innermost
layer's transform. It makes sure the layer tree is correct before and after
these changes.

compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt: Added.
compositing/geometry/layer-due-to-layer-children-deep-switch.html: Added.
compositing/geometry/layer-due-to-layer-children-deep.html: Added.
compositing/geometry/layer-due-to-layer-children-switch-expected.txt: Added.
compositing/geometry/layer-due-to-layer-children-switch.html: Added.
compositing/geometry/layer-due-to-layer-children.html: Added.
platform/mac/compositing/geometry/layer-due-to-layer-children-deep-expected.checksum: Added.
platform/mac/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
platform/mac/compositing/geometry/layer-due-to-layer-children-deep-expected.txt: Added.
platform/mac/compositing/geometry/layer-due-to-layer-children-expected.checksum: Added.
platform/mac/compositing/geometry/layer-due-to-layer-children-expected.png: Added.
platform/mac/compositing/geometry/layer-due-to-layer-children-expected.txt: Added.

1:33 PM Changeset in webkit [76057] by rniwa@webkit.org

7 edits in trunk/Source/WebCore

2011-01-18 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Stop instantiating legacy editing positions in DeleteSelectionCommand, IndentOudentCommand,
InsertLineBreakCommand, InsertListCOmmand.cpp, InsertParagraphSeparatorCommand, and htmlediting.cpp
https://bugs.webkit.org/show_bug.cgi?id=52644

This is a cleanup to stop instantiating legacy editing positions in the following tests.
firstDeepEditingPositionForNode and lastDeepEditingPositionForNode in htmlediting.h are not updated
because doing so requires significant code changes. They are tracked on the bug 52642.

editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializeStartEnd): (WebCore::updatePositionForNodeRemoval): (WebCore::DeleteSelectionCommand::removeNode): (WebCore::updatePositionForTextRemoval): (WebCore::DeleteSelectionCommand::handleGeneralDelete):
editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::outdentParagraph):
editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply):
editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApplyForSingleParagraph): (WebCore::InsertListCommand::unlistifyParagraph): (WebCore::InsertListCommand::listifyParagraph):
editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
editing/htmlediting.cpp: (WebCore::enclosingBlock): (WebCore::enclosingList): (WebCore::enclosingListChild): (WebCore::indexForVisiblePosition): (WebCore::isNodeVisiblyContainedWithin): (WebCore::avoidIntersectionWithNode):

1:29 PM Changeset in webkit [76056] by mihaip@chromium.org

2 edits in trunk/LayoutTests

2011-01-18 Mihai Parparita <mihaip@chromium.org>

Reviewed by Ojan Vafai.

[Chromium] Update Sputnik test expectations
https://bugs.webkit.org/show_bug.cgi?id=52656

Mark Sputnik tests as WONTFIX, so that they don't artificially inflate
our failing test count.

platform/chromium/test_expectations.txt:

1:28 PM Changeset in webkit [76055] by sergio@webkit.org

2 edits in trunk/Tools

2011-01-18 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Martin Robinson.

[Gtk] Build fixes for gtk3 build
https://bugs.webkit.org/show_bug.cgi?id=52648

DumpRenderTree/gtk/EventSender.cpp: (beginDragWithFilesCallback):

1:28 PM Changeset in webkit [76054] by andersca@apple.com

2 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Get and paint each individual rect in -[WKView drawRect:]
https://bugs.webkit.org/show_bug.cgi?id=52660

UIProcess/API/mac/WKView.mm: (-[WKView drawRect:]):

1:24 PM Changeset in webkit [76053] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

2011-01-18 Benjamin Kalman <kalman@chromium.org>

Reviewed by Ryosuke Niwa.

Tweak style in visible_units.cpp and TextIterator.cpp in preparation for another patch
https://bugs.webkit.org/show_bug.cgi?id=52610

This is a purely aesthetic change.

editing/TextIterator.cpp: (WebCore::SimplifiedBackwardsTextIterator::advance):
editing/visible_units.cpp: (WebCore::previousBoundary):

1:22 PM Changeset in webkit [76052] by mihaip@chromium.org

2 edits in trunk

2011-01-18 Mihai Parparita <mihaip@chromium.org>

Unreviewed. Update .gitignore to reflect that WebKit is now in Source.

.gitignore:

1:17 PM Changeset in webkit [76051] by dimich@chromium.org

3 edits in trunk/LayoutTests

[Chromium] Not reviewed, test expectations update.
Added exclusion for new test fast/canvas/canvas-fillPath-alpha-shadow.html

platform/chromium-gpu/test_expectations.txt:
platform/chromium/test_expectations.txt:

1:10 PM Changeset in webkit [76050] by dpranke@chromium.org

6 edits in trunk/Tools

2011-01-18 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

Update rebaseline-chromium-webkit-tests to use filesystem objects
instead of direct references to os.path, shutil, tempfile, etc.

This patch doesn't change anything, but will allow subsequent
patches to change the unit tests to no longer use the real
filesystem.

This patch adds a bunch more methods to the filesystem object as
well.

https://bugs.webkit.org/show_bug.cgi?id=52482

Scripts/webkitpy/common/system/filesystem.py:
Scripts/webkitpy/common/system/filesystem_mock.py:
Scripts/webkitpy/tool/commands/queues.py:
Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:

1:09 PM Changeset in webkit [76049] by oliver@apple.com

5 edits in trunk

2011-01-18 Oliver Hunt <oliver@apple.com>

Reviewed by Antti Koivisto.

[jsfunfuzz] Assertion in codegen for array of NaN constants
https://bugs.webkit.org/show_bug.cgi?id=52643

Add a testcase to ensure we handle a large number of NaN literals
in (0/0 is folded to NaN automatically during parsing).

fast/js/codegen-temporaries-expected.txt:
fast/js/script-tests/codegen-temporaries.js:

2011-01-18 Oliver Hunt <oliver@apple.com>

Reviewed by Antti Koivisto.

[jsfunfuzz] Assertion in codegen for array of NaN constants
https://bugs.webkit.org/show_bug.cgi?id=52643

Don't cache NaN literals in the code generator, as NaN doesn't compare
as equal to itself it causes problems when rehashing the number cache.

bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitLoad):

1:02 PM Changeset in webkit [76048] by commit-queue@webkit.org

7 edits in trunk/Source

2011-01-18 Adam Klein <adamk@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Replace ChromiumBridge::widgetSetCursor with ChromeClient::setCursor
https://bugs.webkit.org/show_bug.cgi?id=42236

platform/chromium/ChromiumBridge.h:
platform/chromium/WidgetChromium.cpp: (WebCore::Widget::setCursor):

2011-01-18 Adam Klein <adamk@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Replace ChromiumBridge::widgetSetCursor with ChromeClient::setCursor
https://bugs.webkit.org/show_bug.cgi?id=42236

src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::setCursor):
src/ChromeClientImpl.h:
src/ChromiumBridge.cpp:

12:37 PM Changeset in webkit [76047] by commit-queue@webkit.org

5 edits
3 adds in trunk

2011-01-18 Krithigassree Sambamurthy <krithigassree.sambamurthy@nokia.com>

Reviewed by Simon Fraser.

Support background-clip: content-box
https://bugs.webkit.org/show_bug.cgi?id=48771

Addded content-box as a valid background-clip value.

WebCore/css/CSSParser.cpp: (WebCore::parseBackgroundClip):

2011-01-18 Krithigassree Sambamurthy <krithigassree.sambamurthy@nokia.com>

Reviewed by Simon Fraser.

Support background-clip: content-box
https://bugs.webkit.org/show_bug.cgi?id=48771

Added test cases to check the various valid background-clip values.

fast/css/background-clip-text-expected.txt:
fast/css/background-clip-values-expected.checksum: Added.
fast/css/background-clip-values-expected.txt: Added.
fast/css/background-clip-values.html: Added.
fast/css/script-tests/background-clip-text.js:

12:34 PM Changeset in webkit [76046] by andersca@apple.com

2 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Assertion when loading two URLs in quick succession
https://bugs.webkit.org/show_bug.cgi?id=52649
<rdar://problem/8764645>

If beginLoad is called twice without didStartProvisionalLoad being called in between,
m_pendingProvisionalSandboxExtension would be non-null and an assert would fire.

WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::SandboxExtensionTracker::beginLoad): Instead of asserting that m_pendingProvisionalSandboxExtension is null, invalidate it if it is not null, since that's valid.

12:32 PM Changeset in webkit [76045] by dpranke@chromium.org

4 edits in trunk/Tools

2011-01-18 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

new-run-webkit-tests shouldn't crash when you try to run a
directory containing only skipped files.

https://bugs.webkit.org/show_bug.cgi?id=52478

Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
Scripts/webkitpy/layout_tests/port/test.py:
Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

12:27 PM Changeset in webkit [76044] by Chris Fleizach

7 edits
2 adds in trunk

REGRESSION: A problem with Voiceover and finding links
https://bugs.webkit.org/show_bug.cgi?id=52324

Reviewed by Darin Adler.

Source/WebCore:

Fallout from recent change to make WebCore return its own scroll view.

1) There were two scroll views in the hierarchy, one which no needed to be ignored.
2) Hit tests for sub frames needed to be offset.
3) The check for whether an attachment is ignored must happen earlier than using

the helpText to determine if an element should be ignored.

Test: platform/mac/accessibility/iframe-with-title-correct-hierarchy.html

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::elementAccessibilityHitTest):

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):

accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper scrollViewParent]):

Source/WebKit/mac:

WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView accessibilityIsIgnored]):

LayoutTests:

platform/mac/accessibility/iframe-with-title-correct-hierarchy-expected.txt: Added.
platform/mac/accessibility/iframe-with-title-correct-hierarchy.html: Added.

12:09 PM Changeset in webkit [76043] by andersca@apple.com

5 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Implement NPN_PopUpContextMenu
https://bugs.webkit.org/show_bug.cgi?id=52646
<rdar://problem/8735616>

WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::NPN_PopUpContextMenu): Call NetscapePlugin::popUpContextMenu.

WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::NetscapePlugin): Initialize m_currentMouseEvent.

WebProcess/Plugins/Netscape/NetscapePlugin.h: Add m_currentMouseEvent.

WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: (WebKit::NetscapePlugin::popUpContextMenu): Convert the coordinates from the current mouse event to screen coordinates and call WKPopupContextMenu.

(WebKit::NetscapePlugin::platformHandleMouseEvent):
Update m_currentMouseEvent.

11:56 AM Changeset in webkit [76042] by andersca@apple.com

4 edits in trunk/WebKitLibraries

Add WKPopupContextMenu.

Reviewed by Darin Adler.

WebKitSystemInterface.h:
libWebKitSystemInterfaceLeopard.a:
libWebKitSystemInterfaceSnowLeopard.a:

11:15 AM Changeset in webkit [76041] by Adam Roben

2 edits in trunk/Source/WebCore

Call alternate CFHTTPCookie functions if available

Fixes <http://webkit.org/b/52637> <rdar://problem/8878984>.

Reviewed by Darin Adler.

platform/network/cf/CookieJarCFNet.cpp: Added soft-linking macros to

pull in the alternate CFHTTPCookie functions.

(WebCore::cookieDomain):
(WebCore::cookieExpirationTime):
(WebCore::cookieName):
(WebCore::cookiePath):
(WebCore::cookieValue):
Added these wrappers around the CFHTTPCookie functions. We call the
alternate functions if they exist, otherwise fall back to the current
functions.

(WebCore::filterCookies):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
Changed to use the wrapper functions.

11:06 AM Changeset in webkit [76040] by jberlin@webkit.org

2 edits in trunk/Source/WebKit2

WebKit2: Do not assert that the provisional and committed URLs cannot be empty/null
https://bugs.webkit.org/show_bug.cgi?id=52641

Reviewed by Darin Adler.

UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::didStartProvisionalLoad):
(WebKit::WebFrameProxy::didCommitLoad):
(WebKit::WebFrameProxy::didFinishLoad):

11:06 AM Changeset in webkit [76039] by Martin Robinson

4 edits in trunk

2011-01-18 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] Filenames are converted to URLs during edit drags
https://bugs.webkit.org/show_bug.cgi?id=52096

platform/gtk/Skipped: Unskip passing test. Fix a misspelled drag and drop test on the list as well.

2011-01-18 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] Filenames are converted to URLs during edit drags
https://bugs.webkit.org/show_bug.cgi?id=52096

platform/gtk/DragDataGtk.cpp: Only advertise and deliver filenames as URLs if the conversion policy allows it. (WebCore::DragData::containsURL): Ditto. (WebCore::DragData::asURL): Ditto.

10:53 AM Changeset in webkit [76038] by jorlow@chromium.org

1 edit
6 adds in trunk/LayoutTests

2011-01-18 Jeremy Orlow <jorlow@chromium.org>

[Chromium] Create baselines for svg/css/text-gradient-shadow.svg
https://bugs.webkit.org/show_bug.cgi?id=52640

platform/chromium-linux/svg/css/text-gradient-shadow-expected.checksum: Added.
platform/chromium-linux/svg/css/text-gradient-shadow-expected.png: Added.
platform/chromium-mac/svg/css/text-gradient-shadow-expected.checksum: Added.
platform/chromium-win/svg/css/text-gradient-shadow-expected.checksum: Added.
platform/chromium-win/svg/css/text-gradient-shadow-expected.png: Added.
platform/chromium-win/svg/css/text-gradient-shadow-expected.txt: Added.
platform/chromium/test_expectations.txt:

10:49 AM Changeset in webkit [76037] by Martin Robinson

2 edits in trunk/LayoutTests

2011-01-18 Martin Robinson <mrobinson@igalia.com>

Skip two tests which were incorrectly passing before GTK+
had support for beginDragWithFiles.

platform/gtk/Skipped: Skip failing tests.

10:24 AM Changeset in webkit [76036] by andersca@apple.com

2 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

ASSERT in plug-in code when going to youtube
https://bugs.webkit.org/show_bug.cgi?id=52638

PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::paintEntirePlugin): Don't try to paint the plug-in if the plug-in frame is empty.

10:15 AM Changeset in webkit [76035] by jknotten@chromium.org

2 edits in trunk/LayoutTests

2011-01-18 John Knottenbelt <jknotten@chromium.org>

Reviewed by Jeremy Orlow.

[Chromium] Adjust test expectations fast/files/revoke-blob-url.html is flaky on linux.
https://bugs.webkit.org/show_bug.cgi?id=52633

Combine test expectations for the test into one line.

platform/chromium/test_expectations.txt:

10:11 AM Changeset in webkit [76034] by andersca@apple.com

13 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Plug-in hosting WebProcess instances appear in Activity Monitor as WebProcess
https://bugs.webkit.org/show_bug.cgi?id=52635
<rdar://problem/8731337>

PluginProcess/PluginProcess.cpp: (WebKit::PluginProcess::initialize): Call platformInitialize.

PluginProcess/PluginProcess.h: Add platformInitialize.

PluginProcess/mac/PluginProcessMac.mm: (WebKit::PluginProcess::platformInitialize): Set the compositing render server port and the visible application name.

Shared/Plugins/PluginProcessCreationParameters.cpp: (WebKit::PluginProcessCreationParameters::encode): (WebKit::PluginProcessCreationParameters::decode): Encode/decode the parent process name.

Shared/Plugins/PluginProcessCreationParameters.h: Add parentProcessName.

Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode): (WebKit::WebProcessCreationParameters::decode): Encode/decode the parent process name.

Shared/WebProcessCreationParameters.h: Add parentProcessName.

UIProcess/Launcher/mac/ProcessLauncherMac.mm: (WebKit::ProcessLauncher::launchProcess): Don't pass the parent process name here.

UIProcess/Plugins/mac/PluginProcessProxyMac.mm: (WebKit::PluginProcessProxy::platformInitializePluginProcess): Set the visible name.

UIProcess/mac/WebContextMac.mm: (WebKit::WebContext::platformInitializeWebProcess): Pass along the parent process name.

WebProcess/mac/WebProcessMac.mm: (WebKit::WebProcess::platformInitializeWebProcess): Set the visible name.

WebProcess/mac/WebProcessMainMac.mm: (WebKit::WebProcessMain): Don't set the visible name here. It's done in platformInitializeWebProcess.

10:10 AM Changeset in webkit [76033] by commit-queue@webkit.org

3 edits
3 adds in trunk

2011-01-18 Helder Correia <helder@sencha.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Incorrect shadow alpha with semi-transparent solid fillStyle
https://bugs.webkit.org/show_bug.cgi?id=52611

This is related to bug 52559. The shadow color alpha must be multiplied
by the context brush alpha.

New test to ensure correct behavior of canvas with fillPath using a
semi-transparent fillStyle color and a shadow.

fast/canvas/canvas-fillPath-alpha-shadow-expected.txt: Added.
fast/canvas/canvas-fillPath-alpha-shadow.html: Added.
fast/canvas/script-tests/canvas-fillPath-alpha-shadow.js: Added.

2011-01-18 Helder Correia <helder@sencha.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Incorrect shadow alpha with semi-transparent solid fillStyle
https://bugs.webkit.org/show_bug.cgi?id=52611

This is related to bug 52559. The shadow color alpha must be multiplied
by the context brush alpha.

Test: fast/canvas/canvas-fillPath-alpha-shadow.html

platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillPath):

9:56 AM Changeset in webkit [76032] by jknotten@chromium.org

2 edits in trunk/LayoutTests

2011-01-18 John Knottenbelt <jknotten@chromium.org>

Unreviewed; updated chromium test expectations.

[Chromium] Adjust test expectations fast/files/revoke-blob-url.html is flaky on linux.
https://bugs.webkit.org/show_bug.cgi?id=52633

platform/chromium/test_expectations.txt:

9:47 AM Changeset in webkit [76031] by Martin Robinson

4 edits
4 adds in trunk

2011-01-18 Adam Bergkvist <adam.bergkvist@ericsson.com> and Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] The GTK+ EventSender needs support for beginDragWithFiles
https://bugs.webkit.org/show_bug.cgi?id=40833

Unskip passing tests, add in a GTK+-specific result and one more result
which is necessary because GTK+ tests run in Xvfb.

platform/gtk/Skipped: Unskip tests that are now passing and organize the remaining skipped tests.
platform/gtk/fast/forms/input-file-re-render-expected.txt: Added.
platform/gtk/http/tests/security/clipboard/clipboard-file-access-expected.txt: Added.

2011-01-18 Adam Bergkvist <adam.bergkvist@ericsson.com> and Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] The GTK+ EventSender needs support for beginDragWithFiles
https://bugs.webkit.org/show_bug.cgi?id=40833

DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the GTK+ event sender. (dragWithFilesDragDataGetCallback): Added. (dragWithFilesDragEndCallback): Added. (beginDragWithFilesCallback): Added.

9:40 AM Changeset in webkit [76030] by caseq@chromium.org

7 edits in trunk

2011-01-18 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: fail resource.requestContent() immediately for WebSocket resources
Remove webInspector.resources.Types from test expectations.
https://bugs.webkit.org/show_bug.cgi?id=52628

inspector/extensions-api-expected.txt:

2011-01-18 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: fail resource.requestContent() immediately for WebSocket resources
https://bugs.webkit.org/show_bug.cgi?id=52628

English.lproj/localizedStrings.js: Rename WebSocket -> WebSockets in resource catetegories (rest are in plural, too)
inspector/front-end/ExtensionServer.js: Do not expose webInspector.resources.Types in extensions API (obsolete) (WebInspector.ExtensionServer.prototype._buildExtensionAPIInjectedScript):
inspector/front-end/Resource.js: (WebInspector.Resource.Type.toUIString): Remove ResourceType.Media as it's not used. (WebInspector.Resource.Type.toString): ditto. (WebInspector.Resource.prototype.requestContent): Fail immediately for WebSocket resources.
inspector/front-end/inspector.js: Rename WebSocket -> WebSockets in resource catetegories (rest are in plural, too)

9:19 AM Changeset in webkit [76029] by commit-queue@webkit.org

3 edits
4 adds in trunk

2011-01-18 Helder Correia <helder@sencha.com>

Reviewed by Dirk Schulze.

REGRESSION(75139): SVG gradients are not applied to texts
https://bugs.webkit.org/show_bug.cgi?id=52531

r75139 caused a problem with filling and stroking text with a gradient
fill in SVG. The order of CGContextConcatCTM and CGContextClipToRect
was mixed up.

platform/mac/svg/css/text-gradient-shadow-expected.checksum: Added.
platform/mac/svg/css/text-gradient-shadow-expected.png: Added.
platform/mac/svg/css/text-gradient-shadow-expected.txt: Added.
svg/css/text-gradient-shadow.svg: Added.

2011-01-18 Helder Correia <helder@sencha.com>

Reviewed by Dirk Schulze.

REGRESSION(75139): SVG gradients are not applied to texts
https://bugs.webkit.org/show_bug.cgi?id=52531

r75139 caused a problem with filling and stroking text with a gradient
fill in SVG. The order of CGContextConcatCTM and CGContextClipToRect
was mixed up.

Test: svg/css/text-gradient-shadow.svg

platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillRect):

9:07 AM Changeset in webkit [76028] by jknotten@chromium.org

1 edit
2 adds in trunk/LayoutTests

2011-01-18 John Knottenbelt <jknotten@chromium.org>

Reviewed by Jeremy Orlow.

Add pixel test baseline for svg/custom/use-inherit-style.svg
https://bugs.webkit.org/show_bug.cgi?id=52630

svg/custom/use-inherit-style-expected.checksum: Added.
svg/custom/use-inherit-style-expected.png: Added.

7:56 AM Changeset in webkit [76027] by commit-queue@webkit.org

3 edits
2 adds in trunk

2011-01-18 Leo Yang <leo.yang@torchmobile.com.cn>

Reviewed by Nikolas Zimmermann.

Unable to indirectly animate visibility of SVGUseElement
https://bugs.webkit.org/show_bug.cgi?id=50240

Test case to verify if SVGUseElement inherits parent's
style change.

svg/custom/use-inherit-style-expected.txt: Added.
svg/custom/use-inherit-style.svg: Added.

2011-01-18 Leo Yang <leo.yang@torchmobile.com.cn>

Reviewed by Nikolas Zimmermann.

Unable to indirectly animate visibility of SVGUseElement
https://bugs.webkit.org/show_bug.cgi?id=50240

SVGUseElement::recalcStyle should take care of its shadow
tree's style recalculation when it is called with change >= Inherit
or when childNeedsStyleRecalc() is true because in these two
cases needStyleRecalc() may not be true.

Test: svg/custom/use-inherit-style.svg

svg/SVGUseElement.cpp: (WebCore::SVGUseElement::recalcStyle):

7:34 AM Changeset in webkit [76026] by podivilov@chromium.org

5 edits in trunk/Source/WebCore

2011-01-18 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: provide script length to frontend.
https://bugs.webkit.org/show_bug.cgi?id=52620

inspector/Inspector.idl:
inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::didParseSource):
inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype._parsedScriptSource): (WebInspector.DebuggerDispatcher.prototype.parsedScriptSource):
inspector/front-end/Script.js: (WebInspector.Script):

7:30 AM Changeset in webkit [76025] by podivilov@chromium.org

1 edit
1 delete in trunk/LayoutTests

2011-01-18 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, remove wrong chromium expectation for console-xhr-logging test.

platform/chromium/http/tests/inspector/console-xhr-logging-expected.txt: Removed.

6:49 AM BuildingCairoOnWindows edited by d.nusman@re-lion.com

(diff)

6:48 AM Changeset in webkit [76024] by zherczeg@webkit.org

1 edit in trunk/Source/WebCore/ChangeLog

Fixing ChangeLog

Rubber-stamped by Csaba OsztrogonÃ¡c

Removing a line introduced by
http://trac.webkit.org/changeset/75743/trunk/Source/WebCore/ChangeLog
Removing an unnecessary space before a time stamp.

6:34 AM Changeset in webkit [76023] by podivilov@chromium.org

3 edits in trunk/LayoutTests

2011-01-18 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, test fix for r76019.

http/tests/inspector-enabled/console-log-before-frame-navigation-expected.txt:
http/tests/inspector-enabled/console-log-before-frame-navigation.html:

6:25 AM Changeset in webkit [76022] by caseq@chromium.org

7 edits in trunk/Source/WebCore

2011-01-17 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [refactoring] use events to notify NetworkManager clients
https://bugs.webkit.org/show_bug.cgi?id=52588

inspector/front-end/AuditLauncherView.js: (WebInspector.AuditLauncherView): Do not expose public interface to resource count. Do not reset resource count upon reset(). (WebInspector.AuditLauncherView.prototype._resetResourceCount): (WebInspector.AuditLauncherView.prototype._onResourceStarted): (WebInspector.AuditLauncherView.prototype._onResourceFinished):
inspector/front-end/AuditsPanel.js: Do not expose public interface to resource start/finish events.
inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer): (WebInspector.ExtensionServer.prototype._notifyResourceFinished): (WebInspector.ExtensionServer.prototype.initExtensions):
inspector/front-end/NetworkManager.js: Dispatch events rather than directly call clients. (WebInspector.NetworkManager): (WebInspector.NetworkManager.prototype.willSendRequest): (WebInspector.NetworkManager.prototype.markResourceAsCached): (WebInspector.NetworkManager.prototype.didReceiveResponse): (WebInspector.NetworkManager.prototype.didReceiveContentLength): (WebInspector.NetworkManager.prototype.setInitialContent): (WebInspector.NetworkManager.prototype.didCommitLoadForFrame): (WebInspector.NetworkManager.prototype.willSendWebSocketHandshakeRequest): (WebInspector.NetworkManager.prototype.didReceiveWebSocketHandshakeResponse): (WebInspector.NetworkManager.prototype._startResource): (WebInspector.NetworkManager.prototype._finishResource):
inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel): (WebInspector.NetworkPanel.prototype._onResourceStarted): (WebInspector.NetworkPanel.prototype._appendResource): (WebInspector.NetworkPanel.prototype._onResourceUpdated): (WebInspector.NetworkPanel.prototype._refreshResource): (WebInspector.NetworkPanel.prototype._onMainResourceChanged):
inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel): (WebInspector.ResourcesPanel.prototype._refreshResource):

6:20 AM Changeset in webkit [76021] by pfeldman@chromium.org

8 edits in trunk

2011-01-18 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: preserve pause on exception state in settings.
https://bugs.webkit.org/show_bug.cgi?id=52619

inspector/InspectorController.cpp: (WebCore::InspectorController::getInspectorState):
inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState):
inspector/InspectorDebuggerAgent.h:
inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.debuggerWasEnabled): (WebInspector.ScriptsPanel.prototype._updatePauseOnExceptionsState): (WebInspector.ScriptsPanel.prototype._togglePauseOnExceptions): (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):
inspector/front-end/Settings.js: (WebInspector.Settings):
inspector/front-end/inspector.js: (WebInspector.doLoadedDone.populateInspectorState):

6:09 AM Changeset in webkit [76020] by podivilov@chromium.org

5 edits in trunk/LayoutTests

2011-01-18 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: fix flaky debugger tests.
https://bugs.webkit.org/show_bug.cgi?id=51320

http/tests/inspector/debugger-test2.js: (initialize_DebuggerTest.InspectorTest.setBreakpoint): (initialize_DebuggerTest.InspectorTest.showScriptSource): (initialize_DebuggerTest.InspectorTest._showScriptSource):
inspector/debugger-pause-on-breakpoint-expected.txt:
inspector/debugger-pause-on-breakpoint.html:

5:54 AM Changeset in webkit [76019] by podivilov@chromium.org

2 edits in trunk/Source/WebCore

2011-01-18 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [REGRESSION] JavaScript exceptions aren't shown in source frame.
https://bugs.webkit.org/show_bug.cgi?id=52623

inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage): (WebInspector.ConsoleMessage.prototype._formatMessage):

5:42 AM Changeset in webkit [76018] by pfeldman@chromium.org

2 edits in trunk/Source/WebCore

2011-01-18 Pavel Feldman <pfeldman@chromium.org>

Revert r76017. No need to guard InspectorInstrumentation: in WebCore.

page/Page.cpp: (WebCore::networkStateChanged):

4:44 AM Changeset in webkit [76017] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

2011-01-18 Konstantin Tokarev <Konstantin Tokarev>

Reviewed by Kent Tamura.

Fixed compilation when Inspector is disabled
https://bugs.webkit.org/show_bug.cgi?id=52564

page/Page.cpp: (WebCore::networkStateChanged): Added ENABLE(INSPECTOR) guard

4:26 AM Changeset in webkit [76016] by morrita@google.com

23 edits
2 deletes in trunk/Source/WebCore

2011-01-18 MORITA Hajime <morrita@google.com>

Unreviewed, rolling out r76004, r76005, r76007, and r76011.
http://trac.webkit.org/changeset/76004
http://trac.webkit.org/changeset/76005
http://trac.webkit.org/changeset/76007
http://trac.webkit.org/changeset/76011
https://bugs.webkit.org/show_bug.cgi?id=51664

The r76004 broke pixel tests.
(The failure was missed due to the tolerance.)

Android.mk:
CMakeLists.txt:
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::addRoundedRectClip): (WebCore::GraphicsContext::clipOutRoundedRect):
platform/graphics/GraphicsContext.h:
platform/graphics/RoundedIntRect.cpp: Removed.
platform/graphics/RoundedIntRect.h: Removed.
rendering/RenderBox.cpp: (WebCore::RenderBox::pushContentsClip):
rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): (WebCore::RenderBoxModelObject::paintBorder): (WebCore::RenderBoxModelObject::clipBorderSidePolygon): (WebCore::uniformlyExpandBorderRadii): (WebCore::RenderBoxModelObject::paintBoxShadow):
rendering/RenderBoxModelObject.h:
rendering/RenderObject.cpp: (WebCore::RenderObject::drawBoxSideFromPath):
rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint):
rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMenuListButtonGradients): (WebCore::RenderThemeMac::paintSliderTrack):
rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintMenuListButtonGradients): (WebCore::RenderThemeSafari::paintSliderTrack):
rendering/RenderThemeWinCE.cpp: (WebCore::RenderThemeWinCE::paintSearchFieldCancelButton):
rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
rendering/style/BorderData.h:
rendering/style/RenderStyle.cpp: (WebCore::constrainCornerRadiiForRect): (WebCore::RenderStyle::getBorderRadiiForRect): (WebCore::RenderStyle::getInnerBorderRadiiForRectWithBorderWidths):
rendering/style/RenderStyle.h:

4:19 AM Changeset in webkit [76015] by hayato@chromium.org

2 edits in trunk

2011-01-18 Hayato Ito <hayato@chromium.org>

Reviewed by Kent Tamura.

Update .gitignore file to reflect a recent WebKit directory movement.

https://bugs.webkit.org/show_bug.cgi?id=52618

.gitignore:

4:16 AM Changeset in webkit [76014] by kbalazs@webkit.org

2 edits in trunk/Source/WebKit2

[Qt][WK2] Not implemented warnings should not break layout tests
https://bugs.webkit.org/show_bug.cgi?id=52616

Reviewed by Csaba Osztrogonác.

WebKit2Prefix.h: Define DISABLE_NOT_IMPLEMENTED_WARNINGS on Qt.

3:04 AM Changeset in webkit [76013] by podivilov@chromium.org

10 edits in trunk/Source/WebCore

2011-01-17 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: add source column field to debugger call frames.
https://bugs.webkit.org/show_bug.cgi?id=52443

bindings/js/JavaScriptCallFrame.cpp: (WebCore::JavaScriptCallFrame::JavaScriptCallFrame):
bindings/js/JavaScriptCallFrame.h: (WebCore::JavaScriptCallFrame::create): (WebCore::JavaScriptCallFrame::line): (WebCore::JavaScriptCallFrame::column): (WebCore::JavaScriptCallFrame::update):
bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::createCallFrameAndPauseIfNeeded): (WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded): (WebCore::ScriptDebugServer::callEvent): (WebCore::ScriptDebugServer::atStatement): (WebCore::ScriptDebugServer::returnEvent): (WebCore::ScriptDebugServer::exception): (WebCore::ScriptDebugServer::willExecuteProgram): (WebCore::ScriptDebugServer::didExecuteProgram): (WebCore::ScriptDebugServer::didReachBreakpoint):
bindings/js/ScriptDebugServer.h:
bindings/v8/DebuggerScript.js: ():
bindings/v8/JavaScriptCallFrame.cpp: (WebCore::JavaScriptCallFrame::column):
bindings/v8/JavaScriptCallFrame.h:
inspector/InjectedScriptSource.js: ():
inspector/JavaScriptCallFrame.idl:

2011-01-18 Antti Koivisto <Antti Koivisto>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=52370
<rdar://problem/8856808>
Style sharing optimization no longer works on major web sites

The code in CSSStyleSelector::locateSharedStyle() that tries to share style information between element has been defeated
by widespread use of certain CSS selectors (:first-child pseudo class and similar). The current implementation disables
the sharing optimization for the whole page if one of these constructs is seen in any style sheet used by the page.

This patch gets the style sharing back to 25-40% range on most web sites.

css/CSSMutableStyleDeclaration.h: (WebCore::CSSMutableStyleDeclaration::propertiesEqual):

Needed to improve equality checking in NamedNodeMap::mappedMapsEquivalent.

css/CSSSelector.h: (WebCore::CSSSelector::isSiblingSelector):

Test for selectors that are affected by the sibling elements.

css/CSSStyleSelector.cpp: (WebCore::elementCanUseSimpleDefaultStyle): (WebCore::collectSiblingRulesInDefaultStyle): (WebCore::assertNoSiblingRulesInDefaultStyle):

Extract sibling rules from the MathML default stylesheet.
Assert that no other default stylesheet has them.

(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::locateCousinList):
(WebCore::CSSStyleSelector::matchesSiblingRules):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::locateSharedStyle):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::collectIdsAndSiblingRulesFromList):
(WebCore::CSSRuleSet::collectIdsAndSiblingRules):

Track sibling rules and ids used in the stylesheets to allow much more fine-grained rejection of cases
where style sharing can't be used.

css/CSSStyleSelector.h:
dom/NamedNodeMap.cpp: (WebCore::NamedNodeMap::mappedMapsEquivalent):

Check also for CSSValue mutation from DOM.

mathml/MathMLMathElement.cpp: (WebCore::MathMLMathElement::insertedIntoDocument):
mathml/MathMLMathElement.h:

MathML default style sheet has sibling rules which don't get noticed by the normal document
stylesheet parsing.

rendering/style/RenderStyle.h: (WebCore::InheritedFlags::setFirstChildState): (WebCore::InheritedFlags::setLastChildState): (WebCore::InheritedFlags::setChildIndex):

These all make style non-shareable (unique).

2:48 AM Changeset in webkit [76012] by Antti Koivisto

12 edits in trunk

Source/WebCore: 2011-01-18 Antti Koivisto <Antti Koivisto>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=52370
<rdar://problem/8856808>
Style sharing optimization no longer works on major web sites

The code in CSSStyleSelector::locateSharedStyle() that tries to share style information between element has been defeated
by widespread use of certain CSS selectors (:first-child pseudo class and similar). The current implementation disables
the sharing optimization for the whole page if one of these constructs is seen in any style sheet used by the page.

This patch gets the style sharing back to 25-40% range on most web sites.

css/CSSMutableStyleDeclaration.h:

(WebCore::CSSMutableStyleDeclaration::propertiesEqual):

Needed to improve equality checking in NamedNodeMap::mappedMapsEquivalent.

css/CSSSelector.h:

(WebCore::CSSSelector::isSiblingSelector):

Test for selectors that are affected by the sibling elements.

css/CSSStyleSelector.cpp:

(WebCore::elementCanUseSimpleDefaultStyle):
(WebCore::collectSiblingRulesInDefaultStyle):
(WebCore::assertNoSiblingRulesInDefaultStyle):

Extract sibling rules from the MathML default stylesheet.
Assert that no other default stylesheet has them.

(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::locateCousinList):
(WebCore::CSSStyleSelector::matchesSiblingRules):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::locateSharedStyle):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::collectIdsAndSiblingRulesFromList):
(WebCore::CSSRuleSet::collectIdsAndSiblingRules):

Track sibling rules and ids used in the stylesheets to allow much more fine-grained rejection of cases
where style sharing can't be used.

css/CSSStyleSelector.h:
dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::mappedMapsEquivalent):

Check also for CSSValue mutation from DOM.

mathml/MathMLMathElement.cpp:

(WebCore::MathMLMathElement::insertedIntoDocument):

mathml/MathMLMathElement.h:

MathML default style sheet has sibling rules which don't get noticed by the normal document
stylesheet parsing.

rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::setFirstChildState):
(WebCore::InheritedFlags::setLastChildState):
(WebCore::InheritedFlags::setChildIndex):

These all make style non-shareable (unique).

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=52370
Style sharing optimization no longer works on major web sites

Reviewed by Dave Hyatt.

These are progressions (with no noticable visual change).
MathML code was improperly sharing style.

platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
platform/mac/mathml/presentation/subsup-expected.txt:

2:37 AM Changeset in webkit [76011] by morrita@google.com

2 edits in trunk/Source/WebCore

2011-01-18 MORITA Hajime <morrita@google.com>

Unreviewed crash fix on release builds.

rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended):

2:20 AM Changeset in webkit [76010] by podivilov@chromium.org

2 edits in trunk/Source/WebCore

2011-01-18 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, update localizedStrings.js.

English.lproj/localizedStrings.js:

2:15 AM Changeset in webkit [76009] by podivilov@chromium.org

7 edits
1 add in trunk/Source/WebCore

2011-01-11 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: implement script beautifier prototype.
https://bugs.webkit.org/show_bug.cgi?id=51588

WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
inspector/front-end/ScriptFormatter.js: Added. (WebInspector.ScriptFormatter): Implements JavaScript source beautification and conversion between original and formatted line numbers (WebInspector.ScriptFormatter.findLineEndings): (WebInspector.ScriptFormatter.locationToPosition): (WebInspector.ScriptFormatter.positionToLocation): (WebInspector.ScriptFormatter.upperBound): (WebInspector.ScriptFormatter.prototype.format): (WebInspector.ScriptFormatter.prototype.originalLineNumberToFormattedLineNumber): (WebInspector.ScriptFormatter.prototype.formattedLineNumberToOriginalLineNumber): (WebInspector.ScriptFormatter.prototype.originalPositionToFormattedLineNumber): (WebInspector.ScriptFormatter.prototype.formattedLineNumberToOriginalPosition): (WebInspector.ScriptFormatter.prototype._convertPosition):
inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._clearCurrentExecutionLine): (WebInspector.ScriptsPanel.prototype._callFrameSelected): (WebInspector.ScriptsPanel.prototype._formatScript):
inspector/front-end/SourceFrame.js: Convert original line numbers to UI line numbers and vice versa
inspector/front-end/WebKit.qrc:
inspector/front-end/inspector.html:

2:02 AM Changeset in webkit [76008] by gyuyoung.kim@samsung.com

2 edits in trunk/Tools

2011-01-18 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Adam Barth.

ews: Add additional watcher to efl ews
https://bugs.webkit.org/show_bug.cgi?id=52613

Add gyuyoung.kim@samsung.com to watcher list of efl-ews.

Scripts/webkitpy/tool/commands/earlywarningsystem.py:

1:32 AM Changeset in webkit [76007] by Philippe Normand

2 edits in trunk/Source/WebCore

2011-01-18 Philippe Normand <pnormand@igalia.com>

Unreviewed, GTK build fix as follow-up of r76004.

GNUmakefile.am: Include RoundedIntRect files in the build

1:24 AM Changeset in webkit [76006] by Philippe Normand

3 edits
12 deletes in trunk

2011-01-18 Philippe Normand <pnormand@igalia.com>

Unreviewed, rolling out r76002.
http://trac.webkit.org/changeset/76002
https://bugs.webkit.org/show_bug.cgi?id=49790

breaks a bunch of fast/forms tests on mac and GTK

fast/forms/select-option-background-color-change.html: Removed.
fast/forms/select-option-color-change.html: Removed.
fast/forms/select-option-visibility-change.html: Removed.
platform/mac/fast/forms/select-option-background-color-change-expected.checksum: Removed.
platform/mac/fast/forms/select-option-background-color-change-expected.png: Removed.
platform/mac/fast/forms/select-option-background-color-change-expected.txt: Removed.
platform/mac/fast/forms/select-option-color-change-expected.checksum: Removed.
platform/mac/fast/forms/select-option-color-change-expected.png: Removed.
platform/mac/fast/forms/select-option-color-change-expected.txt: Removed.
platform/mac/fast/forms/select-option-visibility-change-expected.checksum: Removed.
platform/mac/fast/forms/select-option-visibility-change-expected.png: Removed.
platform/mac/fast/forms/select-option-visibility-change-expected.txt: Removed.

2011-01-18 Philippe Normand <pnormand@igalia.com>

Unreviewed, rolling out r76002.
http://trac.webkit.org/changeset/76002
https://bugs.webkit.org/show_bug.cgi?id=49790

breaks a bunch of fast/forms tests on mac and GTK

html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::setRenderStyle):

1:13 AM Changeset in webkit [76005] by morrita@google.com

2 edits in trunk/Source/WebCore

2011-01-18 MORITA Hajime <morrita@google.com>

Unreviewed windows build fix.

WebCore.vcproj/WebCore.vcproj:

12:59 AM Changeset in webkit [76004] by morrita@google.com

21 edits
2 adds in trunk/Source/WebCore

2011-01-17 MORITA Hajime <morrita@google.com>

Reviewed by Simon Fraser.

Refactoring: Extract RoundedIntRect class
https://bugs.webkit.org/show_bug.cgi?id=51664

RoundedIntRect is a pair of rect and four IntSize objects which represent
corner radii of the rectangle. IntSize is grouped into RoundedIntRect::Radii.
Now RenderStyle::getRoundedBorderFor() and RenderStyle::getRoundedInnerBorderWithBorderWidths()
return RoundedIntRect and GraphicsContext::addRoundedRectClip(), GraphicsContext::fillRoundedRect()
and other functions accept RoundedIntRect as an argument.

No new tests. No behavioral change.

Android.mk:
CMakeLists.txt:
WebCore.gypi:
WebCore.pro:
WebCore.xcodeproj/project.pbxproj:
platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::addRoundedRectClip): (WebCore::GraphicsContext::clipOutRoundedRect): (WebCore::GraphicsContext::fillRoundedRect):
platform/graphics/GraphicsContext.h:
platform/graphics/RoundedIntRect.cpp: Added. (WebCore::RoundedIntRect::Radii::isZero): (WebCore::RoundedIntRect::Radii::scale): (WebCore::RoundedIntRect::Radii::expand): (WebCore::RoundedIntRect::Radii::includeLogicalEdges): (WebCore::RoundedIntRect::Radii::excludeLogicalEdges): (WebCore::RoundedIntRect::RoundedIntRect): (WebCore::RoundedIntRect::includeLogicalEdges): (WebCore::RoundedIntRect::excludeLogicalEdges):
platform/graphics/RoundedIntRect.h: Added. (WebCore::RoundedIntRect::Radii::Radii): (WebCore::RoundedIntRect::Radii::setTopLeft): (WebCore::RoundedIntRect::Radii::setTopRight): (WebCore::RoundedIntRect::Radii::setBottomLeft): (WebCore::RoundedIntRect::Radii::setBottomRight): (WebCore::RoundedIntRect::Radii::topLeft): (WebCore::RoundedIntRect::Radii::topRight): (WebCore::RoundedIntRect::Radii::bottomLeft): (WebCore::RoundedIntRect::Radii::bottomRight): (WebCore::RoundedIntRect::Radii::expand): (WebCore::RoundedIntRect::Radii::shrink): (WebCore::RoundedIntRect::location): (WebCore::RoundedIntRect::size): (WebCore::RoundedIntRect::x): (WebCore::RoundedIntRect::y): (WebCore::RoundedIntRect::width): (WebCore::RoundedIntRect::height): (WebCore::RoundedIntRect::right): (WebCore::RoundedIntRect::bottom): (WebCore::RoundedIntRect::rect): (WebCore::RoundedIntRect::radii): (WebCore::RoundedIntRect::isRounded): (WebCore::RoundedIntRect::isEmpty): (WebCore::RoundedIntRect::setRect): (WebCore::RoundedIntRect::setRadii): (WebCore::RoundedIntRect::move): (WebCore::RoundedIntRect::inflate): (WebCore::RoundedIntRect::inflateWithRadii): (WebCore::RoundedIntRect::expandRadii): (WebCore::RoundedIntRect::shrinkRadii):
rendering/RenderBox.cpp: (WebCore::RenderBox::pushContentsClip):
rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): (WebCore::RenderBoxModelObject::paintBorder): (WebCore::RenderBoxModelObject::clipBorderSidePolygon): (WebCore::RenderBoxModelObject::paintBoxShadow):
rendering/RenderBoxModelObject.h:
rendering/RenderObject.cpp: (WebCore::RenderObject::drawBoxSideFromPath):
rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint):
rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMenuListButtonGradients): (WebCore::RenderThemeMac::paintSliderTrack):
rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintMenuListButtonGradients): (WebCore::RenderThemeSafari::paintSliderTrack):
rendering/RenderThemeWinCE.cpp: (WebCore::RenderThemeWinCE::paintSearchFieldCancelButton):
rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
rendering/style/BorderData.h:
rendering/style/RenderStyle.cpp: (WebCore::calcRadiiFor): (WebCore::calcConstraintScaleFor): (WebCore::RenderStyle::getRoundedBorderFor): (WebCore::RenderStyle::getRoundedInnerBorderWithBorderWidths):
rendering/style/RenderStyle.h: (WebCore::InheritedFlags::setBorderRadius):

12:43 AM Changeset in webkit [76003] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

Unreviewed.

[Qt] Fix LoadHTMLStringItem::invoke() after r75966
https://bugs.webkit.org/show_bug.cgi?id=52614

platform/qt/Skipped: http/tests/navigation/go-back-to-error-page.html added until fix.

12:00 AM Changeset in webkit [76002] by rwlbuis@webkit.org

3 edits
12 adds in trunk

2011-01-17 Rob Buis <rwlbuis@gmail.com>

Reviewed by Kent Tamura.

Color changes to option elements in a select multiple aren't drawn immediately
https://bugs.webkit.org/show_bug.cgi?id=49790

Redirect style changes on <option> element to the owner <select> element.

Tests: fast/forms/select-option-background-color-change.html

fast/forms/select-option-color-change.html
fast/forms/select-option-visibility-change.html

html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::setRenderStyle):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed