Timeline
Jan 21, 2011:
- 11:11 PM Changeset in webkit [76432] by
-
- 3 edits in trunk/Source/JavaScriptCore
Reorganized MarkedSpace, making many of its functions private.
Reviewed by Beth Dakin.
- runtime/JSCell.h:
(JSC::JSCell::Heap::heap):
- runtime/MarkedSpace.h:
(JSC::MarkedSpace::globalData):
(JSC::MarkedSpace::heap):
- 10:50 PM Changeset in webkit [76431] by
-
- 2 edits in trunk/Source/JavaScriptCore
Try to fix build: moved helper function out of #ifdef.
- runtime/MachineStackMarker.cpp:
(JSC::swapIfBackwards):
- 10:45 PM Changeset in webkit [76430] by
-
- 3 edits in trunk/Source/JavaScriptCore
A few of Maciej's review suggestions for my last patch.
https://bugs.webkit.org/show_bug.cgi?id=52946
Rubber-stamped by Maciej Stachowiak.
SunSpider reports no change.
- runtime/MachineStackMarker.cpp:
(JSC::swapIfBackwards): Added a helper function for handling platforms
where the stack can grow in any direction.
(JSC::MachineStackMarker::markCurrentThreadConservativelyInternal):
(JSC::MachineStackMarker::markOtherThreadConservatively): Use the helper
function.
(JSC::isPointerAligned): Use "!" instead of "==0" because a robot told me to.
(JSC::MachineStackMarker::markConservatively): Changed to use a more
standard looping idiom, and to use the helper function above.
- runtime/MarkedSpace.h:
(JSC::MarkedSpace::isCellAligned): Use "!" instead of "==0" because a robot told me to.
- 10:41 PM Changeset in webkit [76429] by
-
- 5 edits5 adds in trunk
2011-01-21 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Adam Barth.
Regression: new window.onerror() implementation leaks cross-origin Javascript errors
https://bugs.webkit.org/show_bug.cgi?id=52903
In case of an exception in a script from different domain only generic message
will be passed to window.onerror hander.
Tests: http/tests/security/cross-origin-script-window-onerror-redirected.html
http/tests/security/cross-origin-script-window-onerror.html
- bindings/js/CachedScriptSourceProvider.h: use URL from the resource response to make sure we do all cross origin checks agains real script URL, not the original URL which may have resulted in a sequence of redirects to different domains. (WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider):
- bindings/v8/ScriptSourceCode.h: same for v8. (WebCore::ScriptSourceCode::url):
- dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::dispatchErrorEvent): in case the error occurred in a script we cannot access provide concise "Script error." message without any information about the error source. This is what Firefox does in this case.
2011-01-21 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Adam Barth.
Regression: new window.onerror() implementation leaks cross-origin Javascript errors
https://bugs.webkit.org/show_bug.cgi?id=52903
A couple of tests to check that window.onerror won't reveal any content of the resource
from a different domain if the latter is referenced via <script src=...>
- http/tests/security/cross-origin-script-window-onerror-expected.txt: Added.
- http/tests/security/cross-origin-script-window-onerror-redirected-expected.txt: Added.
- http/tests/security/cross-origin-script-window-onerror-redirected.html: Added.
- http/tests/security/cross-origin-script-window-onerror.html: Added.
- http/tests/security/resources/cross-origin-script.txt: Added.
- 9:59 PM Changeset in webkit [76428] by
-
- 2 edits in trunk/Tools
2011-01-21 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
Disable mac_unittest.py that fails on some of the Mac bots
https://bugs.webkit.org/show_bug.cgi?id=52947
As noted in the comment, this test does not appear to be correct
because the function this test is testing returns different results
depending on which flavor of Mac the test is run on. This patch
disable the test. Hopefully we can re-enable the test once we've
probably insulated the test from its environment.
- Scripts/webkitpy/layout_tests/port/mac_unittest.py:
- 8:57 PM Changeset in webkit [76427] by
-
- 2 edits in trunk/LayoutTests
2011-01-21 Maciej Stachowiak <mjs@apple.com>
Reviewed by Geoffrey Garen.
Humor the WebKit2 buildbot in its continuing hatred of forms tests
https://bugs.webkit.org/show_bug.cgi?id=52944
- platform/mac-wk2/Skipped:
- 8:30 PM Changeset in webkit [76426] by
-
- 4 edits in trunk/LayoutTests
Updated the results after r76414 fixed text justification in this test.
Rubber-stamped by Mark Rowe.
- platform/mac/fast/text/justified-text-rect-expected.checksum:
- platform/mac/fast/text/justified-text-rect-expected.png:
- platform/mac/fast/text/justified-text-rect-expected.txt:
- 8:27 PM Changeset in webkit [76425] by
-
- 10 edits in trunk/Source/JavaScriptCore
2011-01-21 Geoffrey Garen <ggaren@apple.com>
Reviewed by Maciej Stachowiak.
Cleaned up some conservative marking code.
https://bugs.webkit.org/show_bug.cgi?id=52946
SunSpider reports no change.
- interpreter/RegisterFile.h: No need for a special marking function, since we already expose a start() and end().
- runtime/Heap.cpp: (JSC::Heap::registerFile): (JSC::Heap::markRoots):
- runtime/Heap.h: (JSC::Heap::contains): Migrated markConservatively() to the machine stack marker class. Now, Heap just provides a contains() function, which the machine stack marker uses for checking whether a pointer points into the heap.
- runtime/MachineStackMarker.cpp: (JSC::MachineStackMarker::markCurrentThreadConservativelyInternal): (JSC::MachineStackMarker::markOtherThreadConservatively): (JSC::isPointerAligned): (JSC::MachineStackMarker::markConservatively):
- runtime/MachineStackMarker.h: Move the conservative marking code here.
- runtime/MarkStack.h: (JSC::ConservativeSet::add): (JSC::ConservativeSet::mark): Changed to using a vector instead of hash set. Vector seems to be a bit faster, and it generates smaller code.
- runtime/MarkedSpace.cpp: (JSC::MarkedSpace::containsSlowCase):
- runtime/MarkedSpace.h: (JSC::MarkedSpace::isCellAligned): (JSC::MarkedSpace::isPossibleCell): (JSC::MarkedSpace::contains): Kept the code for determining whether a pointer pointed into marked space, and moved the code for marking a set of conservative pointers into the machine stack marker.
- wtf/HashSet.h: (WTF::::add): Added two missing inlines that I noticed while testing vector vs hash set.
- 8:00 PM Changeset in webkit [76424] by
-
- 2 edits in trunk/LayoutTests
2011-01-21 James Robinson <jamesr@chromium.org>
Update chromium test expectations. fast/animation tests should now pass on all chromium configurations.
- platform/chromium/test_expectations.txt:
- 7:31 PM Changeset in webkit [76423] by
-
- 5 edits in trunk/Source
Versioning.
- 7:27 PM Changeset in webkit [76422] by
-
- 1 copy in tags/Safari-534.16
New tag.
- 7:22 PM Changeset in webkit [76421] by
-
- 2 edits in trunk/LayoutTests
Fix test failure.
- fast/text/justify-nbsp.html: Removed a contenteditable attribute
that was added after generating results.
- 6:51 PM Changeset in webkit [76420] by
-
- 1 edit1 delete in trunk/LayoutTests
2011-01-21 Andreas Kling <kling@webkit.org>
Unreviewed, removing the Qt result for r76414 since the test
was actually broken beyond the usual off-by-one metrics.
- platform/qt/fast/text/justify-nbsp-expected.txt: Removed.
- 6:11 PM Changeset in webkit [76419] by
-
- 1 edit1 add in trunk/LayoutTests
2011-01-21 Andreas Kling <kling@webkit.org>
Unreviewed, add Qt-specific result for test added in r76414.
- platform/qt/fast/text/justify-nbsp-expected.txt: Added.
- 6:08 PM Changeset in webkit [76418] by
-
- 43 edits in trunk/Source/WebKit2
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=52943
Objective-C files should use #import, not #include
- UIProcess/API/C/WebKit2.h: This is an interesting one, because it's cross-platform, and there is more than one WKView.h.
- Platform/mac/ModuleMac.mm:
- Platform/mac/RunLoopMac.mm:
- PluginProcess/mac/PluginControllerProxyMac.mm:
- PluginProcess/mac/PluginProcessMac.mm:
- PluginProcess/mac/PluginProcessMainMac.mm:
- Shared/API/c/mac/WKCertificateInfoMac.mm:
- Shared/API/c/mac/WKURLRequestNS.mm:
- Shared/API/c/mac/WKURLResponseNS.mm:
- Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
- Shared/mac/PlatformCertificateInfo.mm:
- Shared/mac/SandboxExtensionMac.mm:
- Shared/mac/WebCoreArgumentCodersMac.mm:
- Shared/mac/WebMemorySampler.mac.mm:
- Shared/mac/WebURLRequestMac.mm:
- Shared/mac/WebURLResponseMac.mm:
- UIProcess/API/mac/FindIndicatorWindow.mm:
- UIProcess/API/mac/WKTextInputWindowController.mm:
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
- UIProcess/Launcher/mac/ThreadLauncherMac.mm:
- UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
- UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
- UIProcess/mac/BackingStoreMac.mm:
- UIProcess/mac/ChunkedUpdateDrawingAreaProxyMac.mm:
- UIProcess/mac/LayerBackedDrawingAreaProxyMac.mm:
- UIProcess/mac/TextCheckerMac.mm:
- UIProcess/mac/WebContextMac.mm:
- UIProcess/mac/WebContextMenuProxyMac.mm:
- UIProcess/mac/WebPageProxyMac.mm:
- UIProcess/mac/WebPopupMenuProxyMac.mm:
- UIProcess/mac/WebPreferencesMac.mm:
- WebProcess/Downloads/mac/DownloadMac.mm:
- WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
- WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:
- WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
- WebProcess/WebCoreSupport/mac/WebDatabaseManagerMac.mm:
- WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
- WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:
- WebProcess/WebCoreSupport/mac/WebPopupMenuMac.mm:
- WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm:
- WebProcess/WebPage/mac/WebPageMac.mm:
- WebProcess/mac/WebProcessMac.mm:
- 5:46 PM Changeset in webkit [76417] by
-
- 9 edits in trunk/Source/WebKit2
Fix the WebKit2 build with clang.
Reviewed by Sam Weinig.
- Scripts/webkit2/messages.py: Add some more structs to the list.
- UIProcess/DrawingAreaProxy.h: Forward-declare UpdateInfo as a class.
- UIProcess/TextChecker.h: Forward-declare TextCheckerState as a struct.
- UIProcess/WebPageProxy.h: Forward-declare ContextMenuState as a struct.
- UIProcess/mac/TextCheckerMac.mm: Fix the type of the string constants so that they can be passed to
functions expecting NSString* without generating warnings.
- WebProcess/WebPage/DrawingArea.h: Forward-declare WebPageCreationParameters as a struct.
- WebProcess/WebPage/DrawingAreaImpl.h: Forward-declare UpdateInfo as a class.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::getResourceDataFromFrame): Add parens around the assignment in the condition of
the if statement to suppress a warning.
- 5:46 PM Changeset in webkit [76416] by
-
- 3 edits in trunk/Source/WebKit/mac
Fix the build when using Clang by removing some unused variables.
Rubber-stamped by Jon Honeycutt.
- Plugins/Hosted/WebHostedNetscapePluginView.mm:
(-[WebHostedNetscapePluginView updateAndSetWindow]):
- WebView/WebFullScreenController.mm:
(-[WebFullScreenController enterFullscreen:]):
(-[WebFullScreenController exitFullscreen]):
- 5:45 PM Changeset in webkit [76415] by
-
- 4 edits in trunk/Source/WebCore
2011-01-21 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Always set composition mode through GraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=52940
GraphicsContext tracks the current composition mode so we should
never call through to the QPainter directly.
- platform/graphics/GraphicsContext.h:
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::toQtCompositionMode): Changed this method to a static inline since it's only used by GraphicsContextQt.cpp now.
- platform/graphics/qt/ImageQt.cpp: (WebCore::Image::drawPattern): (WebCore::BitmapImage::draw):
- 5:31 PM Changeset in webkit [76414] by
-
- 3 edits4 adds in trunk
Inconsistent handling of no-break space in justification logic
https://bugs.webkit.org/show_bug.cgi?id=52938
Reviewed by Adele Peterson.
Source/WebCore:
Test: fast/text/justify-nbsp.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Count no-break space as a
space when computing the distribution of space between text boxes on the line.
LayoutTests:
- fast/text/justify-nbsp-expected.checksum: Added.
- fast/text/justify-nbsp-expected.png: Added.
- fast/text/justify-nbsp-expected.txt: Added.
- fast/text/justify-nbsp.html: Added.
- 5:29 PM Changeset in webkit [76413] by
-
- 4 edits in trunk/Tools
2011-01-21 Dirk Pranke <dpranke@chromium.org>
Reviewed by Mihai Parparita.
Fix bug introduced in r76322 that caused NRWT to not actually
read the Skipped files properly.
- Scripts/webkitpy/layout_tests/port/mac_unittest.py:
- Scripts/webkitpy/layout_tests/port/webkit.py:
- Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
- 5:19 PM Changeset in webkit [76412] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-01-21 Chris Rogers <crogers@google.com>
Unreviewed
define HAS_WEBAUDIO_RUNTIMEFEATURES for synchronization with chromium patch landing
https://bugs.webkit.org/show_bug.cgi?id=52941
- public/WebRuntimeFeatures.h:
- 5:07 PM Changeset in webkit [76411] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-01-21 Chris Rogers <crogers@google.com>
Unreviewed
Add HAS_WEBAUDIO_FEATURE_ENABLE define to synchronize with chromium-side patch
https://bugs.webkit.org/show_bug.cgi?id=52939
- public/WebSettings.h:
- 4:54 PM Changeset in webkit [76410] by
-
- 2 edits in trunk/LayoutTests
2011-01-21 Kenji Imasaki <imasaki@chromium.org>
Reviewed by David Levin.
Remove resolved BUG13907 from test expectation file and added
newly filed BUGCR70252 for media/video-zoom.html to keep track
of the issue.
Also, remove non-flaky test (media/audio-only-video-intrinsic-size.htm).
- platform/chromium/test_expectations.txt:
- 4:38 PM Changeset in webkit [76409] by
-
- 3 edits in trunk/Source/JavaScriptCore
Work around a Clang bug <rdar://problem/8876150> that leads to it incorrectly emitting an access
control warning when a client tries to use operator bool exposed above via "using PageBlock::operator bool".
Reviewed by Sam Weinig.
- wtf/PageAllocation.h:
(WTF::PageAllocation::operator bool):
- wtf/PageReservation.h:
(WTF::PageReservation::operator bool):
- 4:16 PM Changeset in webkit [76408] by
-
- 8 edits in trunk/LayoutTests
2011-01-21 Martin Robinson <mrobinson@igalia.com>
Rebaseline tests that use menulists. Also unskip a non-existent test.
- platform/gtk/Skipped: Remove non-existent test.
- platform/gtk/editing/selection/select-box-expected.checksum:
- platform/gtk/editing/selection/select-box-expected.png:
- platform/gtk/editing/selection/select-box-expected.txt:
- platform/gtk/transforms/2d/zoom-menulist-expected.checksum:
- platform/gtk/transforms/2d/zoom-menulist-expected.png:
- platform/gtk/transforms/2d/zoom-menulist-expected.txt:
- 3:52 PM Changeset in webkit [76407] by
-
- 5 edits in trunk
2011-01-21 Michael Saboff <msaboff@apple.com>
Reviewed by Oliver Hunt.
[RegexFuzz] Hang with forward assertion
https://bugs.webkit.org/show_bug.cgi?id=52825
<rdar://problem/8894332>
The backtrackTo label from the first term in a list of terms is
being overwritten by processing of subsequent terms. Changed
copyBacktrackToLabel() to check for an existing bcaktrackTo label
before copying and renamed it to propagateBacktrackToLabel() since
it no longer copies.
- yarr/YarrJIT.cpp: (JSC::Yarr::YarrGenerator::BacktrackDestination::propagateBacktrackToLabel): (JSC::Yarr::YarrGenerator::generateParenthesesSingle):
2011-01-21 Michael Saboff <msaboff@apple.com>
Reviewed by Oliver Hunt.
[RegexFuzz] Hang with forward assertion
https://bugs.webkit.org/show_bug.cgi?id=52825
<rdar://problem/8894332>
New tests to check for functionality and future regression.
- fast/regex/parentheses-expected.txt:
- fast/regex/script-tests/parentheses.js:
- 3:47 PM Changeset in webkit [76406] by
-
- 4 edits in trunk/Source
2011-01-21 Charlie Reis <creis@chromium.org>
Reviewed by Darin Fisher.
Crash in WebCore::HistoryController::itemsAreClones
https://bugs.webkit.org/show_bug.cgi?id=52819
Adds sanity checks to help diagnose the crash.
- loader/HistoryController.cpp:
2011-01-21 Charlie Reis <creis@chromium.org>
Reviewed by Darin Fisher.
Crash in WebCore::HistoryController::itemsAreClones
https://bugs.webkit.org/show_bug.cgi?id=52819
Adds sanity checks to help diagnose the crash.
- src/WebFrameImpl.cpp:
- 3:45 PM Changeset in webkit [76405] by
-
- 3 edits in trunk/Source/WebCore
2011-01-21 Andreas Kling <kling@webkit.org>
Reviewed by Ariya Hidayat.
[Qt] Let QPainter decide whether a composition mode is supported or not
Lacking Porter-Duff support in the paint engine shouldn't exclude the
Source and Source-Over modes (and has nothing to do with the blend
and raster-op modes.)
Delegate this decision to QPainter instead (this will cause warnings
if an unsupported mode is used, but that's a good thing.)
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::clearRect): (WebCore::GraphicsContext::setPlatformCompositeOperation):
- platform/graphics/qt/TransparencyLayer.h: (WebCore::TransparencyLayer::TransparencyLayer):
- 3:43 PM Changeset in webkit [76404] by
-
- 2 edits in trunk/LayoutTests
2011-01-21 Maciej Stachowiak <mjs@apple.com>
Reviewed by Adele Peterson.
Skip a test that's sporadically crashing on the buildbots
https://bugs.webkit.org/show_bug.cgi?id=52932
- platform/mac-wk2/Skipped:
- 3:42 PM Changeset in webkit [76403] by
-
- 8 edits in trunk/Source/WebKit2
WebKit2: Need API to stop loading a WKFrame
https://bugs.webkit.org/show_bug.cgi?id=52925
Reviewed by Adam Roben.
- UIProcess/API/C/WKFrame.cpp:
(WKFrameStopLoading): Call through to WebFrameProxy::stopLoading.
- UIProcess/API/C/WKFrame.h:
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::stopLoading): Send a message to the WebProcess to stop loading the frame
with the passed in ID.
- UIProcess/WebFrameProxy.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::stopLoadingFrame): Call stopForUserCancel on the passed-in frame.
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in: Add StopLoadingFrame.
- 3:41 PM Changeset in webkit [76402] by
-
- 2 edits in trunk/Source/WebCore
2011-01-21 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
fix audio build: header file should be "Noncopyable.h" and not "NonCopyable.h"
https://bugs.webkit.org/show_bug.cgi?id=52933
No new tests since this just fixes the build
- webaudio/RealtimeAnalyser.h:
- 3:32 PM Changeset in webkit [76401] by
-
- 2 edits in trunk/Tools
WebKitTestRunner needs the HOME environment variable to be set.
<rdar://problem/8896573>
Reviewed by Geoffrey Sean Garen and Mark Rowe.
- Scripts/old-run-webkit-tests: Set the HOME environment variable if
it exists.
- 3:28 PM Changeset in webkit [76400] by
-
- 2 edits in trunk/Source/WebCore
2011-01-21 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Fix audio build: change ChromiumBridge to PlatformBridge
https://bugs.webkit.org/show_bug.cgi?id=52928
No new tests since audio API is not yet implemented.
- platform/audio/chromium/AudioBusChromium.cpp: (WebCore::AudioBus::loadPlatformResource):
- 3:24 PM Changeset in webkit [76399] by
-
- 5 edits in trunk/Source/JavaScriptCore
2011-01-21 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Moved the mark stack from global data to the heap, since it pertains
to the heap, and not the virtual machine as a whole.
https://bugs.webkit.org/show_bug.cgi?id=52930
SunSpider reports no change.
- runtime/Heap.cpp: (JSC::Heap::Heap): (JSC::Heap::markRoots):
- runtime/Heap.h:
- runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
- runtime/JSGlobalData.h:
- 3:23 PM Changeset in webkit [76398] by
-
- 4 edits in trunk/Tools
2011-01-21 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Suppress a few remaining integration tests so that none of the
layout_test unit tests ever read from the filesystem or launch
subprocesses that aren't part of the unit tests.
Also fix a minor bug in the printing unit tests that was
incorrectly relying on sys.argv.
- Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
- Scripts/webkitpy/layout_tests/port/port_testcase.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 3:06 PM Changeset in webkit [76397] by
-
- 2 edits1 add in trunk/Source/WebCore
2011-01-21 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Add FFTFrameStub to avoid link errors during bringup on platforms without an FFT implementation
https://bugs.webkit.org/show_bug.cgi?id=52922
No new tests since audio API is not yet implemented.
- WebCore.gypi:
- platform/audio/FFTFrameStub.cpp: Added. (WebCore::FFTFrame::FFTFrame): (WebCore::FFTFrame::~FFTFrame): (WebCore::FFTFrame::multiply): (WebCore::FFTFrame::doFFT): (WebCore::FFTFrame::doInverseFFT): (WebCore::FFTFrame::cleanup): (WebCore::FFTFrame::realData): (WebCore::FFTFrame::imagData):
- 3:01 PM UsingGitWithWebKit edited by
- Added information about proper svn:mime-type configuration (diff)
- 2:52 PM Changeset in webkit [76396] by
-
- 2 edits in trunk/LayoutTests
2011-01-21 Maciej Stachowiak <mjs@apple.com>
Reviewed by Adam Roben.
Skip some newly added tests that use DRT APIs that are not yet available for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=52924
- platform/mac-wk2/Skipped:
- 2:32 PM Changeset in webkit [76395] by
-
- 2 edits in trunk/Source/WebCore
2011-01-21 Tony Chang <tony@chromium.org>
Reviewed by Sam Weinig.
reduce number of FrameLoaderClient::didChangeScrollOffset calls
https://bugs.webkit.org/show_bug.cgi?id=52915
Only notify of changes in scroll offset when there actually is a change.
This regressed in r76291.
Covered by Chromium browser_tests.
- platform/ScrollAnimator.cpp: (WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation):
- 2:12 PM Changeset in webkit [76394] by
-
- 5 edits in trunk/Source/WebKit2
<rdar://problem/8894125> and https://bugs.webkit.org/show_bug.cgi?id=52916
Expose "suggested filename" for a resource based on its resource response.
Reviewed by Adam Roben.
API pieces:
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameCopySuggestedFilenameForResourceURL):
- WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
Implementation:
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::suggestedFilenameForResourceURL): See if the DocumentLoader has
a resource for this URL and, if so, return the response's suggested filename.
- WebProcess/WebPage/WebFrame.h:
- 2:09 PM Changeset in webkit [76393] by
-
- 5 edits in trunk/Source/WebKit2
2011-01-21 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
DrawingAreaProxyImpl::paint should return the unpainted region
https://bugs.webkit.org/show_bug.cgi?id=52918
- UIProcess/API/mac/WKView.mm: (-[WKView drawRect:]): Add unpaintedRegion parameter.
- UIProcess/BackingStore.h: (WebKit::BackingStore::size): Add a size getter.
- UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::paint): Initialize the unpainted region to the dirty region, then subtract the painted region.
- 2:00 PM Changeset in webkit [76392] by
-
- 2 edits in trunk/Source/WebCore
2011-01-21 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: ~InspectorResourceAgent crashes on closing inspected page.
https://bugs.webkit.org/show_bug.cgi?id=52900
- inspector/InspectorController.cpp: (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::inspectedPageDestroyed):
- 1:58 PM Changeset in webkit [76391] by
-
- 2 edits in trunk/Source/WebKit2
Fix for <rdar://problem/8896057>
Reviewed by Dan Bernstein and Maciej Stachowiak.
Give the Web Process access to the PubSub agent.
- WebProcess/com.apple.WebProcess.sb:
- 1:43 PM Changeset in webkit [76390] by
-
- 21 edits in trunk/Source
2011-01-21 Chris Rogers <crogers@google.com>
Reviewed by Darin Fisher.
Add run-time enable support for the web audio API
https://bugs.webkit.org/show_bug.cgi?id=52741
- public/WebRuntimeFeatures.h:
- public/WebSettings.h:
- src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableWebAudio): (WebKit::WebRuntimeFeatures::isWebAudioEnabled):
- src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setWebAudioEnabled):
- src/WebSettingsImpl.h:
2011-01-21 Chris Rogers <crogers@google.com>
Reviewed by Darin Fisher.
Add run-time enable support for the web audio API
https://bugs.webkit.org/show_bug.cgi?id=52741
- WebPreferenceKeysPrivate.h:
- WebView.cpp: (WebView::notifyPreferencesChanged):
2011-01-21 Chris Rogers <crogers@google.com>
Reviewed by Darin Fisher.
Add run-time enable support for the web audio API
https://bugs.webkit.org/show_bug.cgi?id=52741
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm: (-[WebPreferences webAudioEnabled]): (-[WebPreferences setWebAudioEnabled:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):
2011-01-21 Chris Rogers <crogers@google.com>
Reviewed by Darin Fisher.
Add run-time enable support for the web audio API
https://bugs.webkit.org/show_bug.cgi?id=52741
No new tests since audio API is not yet implemented.
- WebCore.exp.in:
- bindings/generic/RuntimeEnabledFeatures.cpp:
- bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setWebkitAudioContextEnabled): (WebCore::RuntimeEnabledFeatures::webkitAudioContextEnabled):
- page/DOMWindow.idl:
- page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setWebAudioEnabled):
- page/Settings.h: (WebCore::Settings::webAudioEnabled):
- 1:33 PM Changeset in webkit [76389] by
-
- 2 edits in trunk/Source/WebKit/win
Fix windows build.
- WebScrollBar.h:
- 1:33 PM Changeset in webkit [76388] by
-
- 114 edits2 adds in trunk
2011-01-21 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Menulist text often collides with separator
https://bugs.webkit.org/show_bug.cgi?id=51155
Rebaseline tests that have different affected by the metrics of
the menulist.
- platform/gtk/fast/forms/001-expected.checksum:
- platform/gtk/fast/forms/001-expected.png:
- platform/gtk/fast/forms/001-expected.txt:
- platform/gtk/fast/forms/003-expected.checksum:
- platform/gtk/fast/forms/003-expected.png:
- platform/gtk/fast/forms/003-expected.txt:
- platform/gtk/fast/forms/004-expected.checksum:
- platform/gtk/fast/forms/004-expected.png:
- platform/gtk/fast/forms/004-expected.txt:
- platform/gtk/fast/forms/HTMLOptionElement_label01-expected.checksum:
- platform/gtk/fast/forms/HTMLOptionElement_label01-expected.png:
- platform/gtk/fast/forms/HTMLOptionElement_label01-expected.txt:
- platform/gtk/fast/forms/HTMLOptionElement_label02-expected.checksum:
- platform/gtk/fast/forms/HTMLOptionElement_label02-expected.png:
- platform/gtk/fast/forms/HTMLOptionElement_label02-expected.txt:
- platform/gtk/fast/forms/HTMLOptionElement_label03-expected.checksum:
- platform/gtk/fast/forms/HTMLOptionElement_label03-expected.png:
- platform/gtk/fast/forms/HTMLOptionElement_label03-expected.txt:
- platform/gtk/fast/forms/HTMLOptionElement_label04-expected.checksum:
- platform/gtk/fast/forms/HTMLOptionElement_label04-expected.png:
- platform/gtk/fast/forms/HTMLOptionElement_label04-expected.txt:
- platform/gtk/fast/forms/HTMLOptionElement_label06-expected.checksum:
- platform/gtk/fast/forms/HTMLOptionElement_label06-expected.png:
- platform/gtk/fast/forms/HTMLOptionElement_label06-expected.txt:
- platform/gtk/fast/forms/HTMLOptionElement_label07-expected.checksum:
- platform/gtk/fast/forms/HTMLOptionElement_label07-expected.png:
- platform/gtk/fast/forms/HTMLOptionElement_label07-expected.txt:
- platform/gtk/fast/forms/control-clip-overflow-expected.checksum:
- platform/gtk/fast/forms/control-clip-overflow-expected.png:
- platform/gtk/fast/forms/control-clip-overflow-expected.txt:
- platform/gtk/fast/forms/control-restrict-line-height-expected.checksum:
- platform/gtk/fast/forms/control-restrict-line-height-expected.png:
- platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
- platform/gtk/fast/forms/disabled-select-change-index-expected.checksum:
- platform/gtk/fast/forms/disabled-select-change-index-expected.png:
- platform/gtk/fast/forms/disabled-select-change-index-expected.txt:
- platform/gtk/fast/forms/form-element-geometry-expected.checksum:
- platform/gtk/fast/forms/form-element-geometry-expected.png:
- platform/gtk/fast/forms/form-element-geometry-expected.txt:
- platform/gtk/fast/forms/input-file-re-render-expected.checksum: Added.
- platform/gtk/fast/forms/input-file-re-render-expected.png: Added.
- platform/gtk/fast/forms/menulist-deselect-update-expected.checksum:
- platform/gtk/fast/forms/menulist-deselect-update-expected.png:
- platform/gtk/fast/forms/menulist-deselect-update-expected.txt:
- platform/gtk/fast/forms/menulist-narrow-width-expected.checksum:
- platform/gtk/fast/forms/menulist-narrow-width-expected.png:
- platform/gtk/fast/forms/menulist-narrow-width-expected.txt:
- platform/gtk/fast/forms/menulist-no-overflow-expected.checksum:
- platform/gtk/fast/forms/menulist-no-overflow-expected.png:
- platform/gtk/fast/forms/menulist-no-overflow-expected.txt:
- platform/gtk/fast/forms/menulist-restrict-line-height-expected.checksum:
- platform/gtk/fast/forms/menulist-restrict-line-height-expected.png:
- platform/gtk/fast/forms/menulist-restrict-line-height-expected.txt:
- platform/gtk/fast/forms/menulist-separator-painting-expected.checksum:
- platform/gtk/fast/forms/menulist-separator-painting-expected.png:
- platform/gtk/fast/forms/menulist-separator-painting-expected.txt:
- platform/gtk/fast/forms/menulist-style-color-expected.checksum:
- platform/gtk/fast/forms/menulist-style-color-expected.png:
- platform/gtk/fast/forms/menulist-style-color-expected.txt:
- platform/gtk/fast/forms/menulist-width-change-expected.checksum:
- platform/gtk/fast/forms/menulist-width-change-expected.png:
- platform/gtk/fast/forms/menulist-width-change-expected.txt:
- platform/gtk/fast/forms/option-script-expected.checksum:
- platform/gtk/fast/forms/option-script-expected.png:
- platform/gtk/fast/forms/option-script-expected.txt:
- platform/gtk/fast/forms/option-strip-whitespace-expected.checksum:
- platform/gtk/fast/forms/option-strip-whitespace-expected.png:
- platform/gtk/fast/forms/option-strip-whitespace-expected.txt:
- platform/gtk/fast/forms/option-text-clip-expected.checksum:
- platform/gtk/fast/forms/option-text-clip-expected.png:
- platform/gtk/fast/forms/option-text-clip-expected.txt:
- platform/gtk/fast/forms/select-align-expected.checksum:
- platform/gtk/fast/forms/select-align-expected.png:
- platform/gtk/fast/forms/select-align-expected.txt:
- platform/gtk/fast/forms/select-baseline-expected.checksum:
- platform/gtk/fast/forms/select-baseline-expected.png:
- platform/gtk/fast/forms/select-baseline-expected.txt:
- platform/gtk/fast/forms/select-change-listbox-to-popup-expected.checksum:
- platform/gtk/fast/forms/select-change-listbox-to-popup-expected.png:
- platform/gtk/fast/forms/select-change-listbox-to-popup-expected.txt:
- platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.checksum:
- platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.png:
- platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.txt:
- platform/gtk/fast/forms/select-disabled-appearance-expected.checksum:
- platform/gtk/fast/forms/select-disabled-appearance-expected.png:
- platform/gtk/fast/forms/select-disabled-appearance-expected.txt:
- platform/gtk/fast/forms/select-initial-position-expected.checksum:
- platform/gtk/fast/forms/select-initial-position-expected.png:
- platform/gtk/fast/forms/select-initial-position-expected.txt:
- platform/gtk/fast/forms/select-selected-expected.checksum:
- platform/gtk/fast/forms/select-selected-expected.png:
- platform/gtk/fast/forms/select-selected-expected.txt:
- platform/gtk/fast/forms/select-size-expected.checksum:
- platform/gtk/fast/forms/select-size-expected.png:
- platform/gtk/fast/forms/select-size-expected.txt:
- platform/gtk/fast/forms/select-style-expected.checksum:
- platform/gtk/fast/forms/select-style-expected.png:
- platform/gtk/fast/forms/select-style-expected.txt:
- platform/gtk/fast/forms/select-visual-hebrew-expected.checksum:
- platform/gtk/fast/forms/select-visual-hebrew-expected.png:
- platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
- platform/gtk/fast/forms/select-writing-direction-natural-expected.checksum:
- platform/gtk/fast/forms/select-writing-direction-natural-expected.png:
- platform/gtk/fast/forms/select-writing-direction-natural-expected.txt:
- platform/gtk/fast/forms/stuff-on-my-optgroup-expected.checksum:
- platform/gtk/fast/forms/stuff-on-my-optgroup-expected.png:
- platform/gtk/fast/forms/stuff-on-my-optgroup-expected.txt:
2011-01-21 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Menulist text often collides with separator
https://bugs.webkit.org/show_bug.cgi?id=51155
Move menulist rendering to RenderThemeGtk and correct padding code
for separators in menulists.
- platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::RenderThemeGtk): Initialize new widget members. (WebCore::RenderThemeGtk::getComboBoxSeparatorWidth): Added. (WebCore::RenderThemeGtk::comboBoxArrowSize): Added. (WebCore::getButtonInnerBorder): Added. (WebCore::RenderThemeGtk::getComboBoxPadding): Do this manually instead of using Mozilla code. (WebCore::RenderThemeGtk::paintMenuList): Ditto. (WebCore::setupWidget): Abstracted this part of the setupWidgetAndAddToContainer out to handle child widgets of comboboxes. (WebCore::RenderThemeGtk::setupWidgetAndAddToContainer): Abstracted out setupWidget. (WebCore::RenderThemeGtk::gtkContainer): Added. (WebCore::getGtkComboBoxButton): Added. (WebCore::getGtkComboBoxPieces): Added. (WebCore::RenderThemeGtk::gtkComboBox): Call setupWidget here. (WebCore::RenderThemeGtk::refreshComboBoxChildren): Added. (WebCore::RenderThemeGtk::gtkComboBoxButton): Added. (WebCore::RenderThemeGtk::gtkComboBoxArrow): Added. (WebCore::RenderThemeGtk::gtkComboBoxSeparator): Added.
- platform/gtk/RenderThemeGtk.h: Added new members and methods.
- platform/gtk/WidgetRenderingContext.h: Added new members and methods.
- platform/gtk/WidgetRenderingContextGtk2.cpp: (WebCore::WidgetRenderingContext::gtkPaintArrow): (WebCore::WidgetRenderingContext::gtkPaintVLine):
- platform/gtk/WidgetRenderingContextGtk3.cpp: (WebCore::WidgetRenderingContext::gtkPaintArrow): (WebCore::WidgetRenderingContext::gtkPaintVLine):
- platform/gtk/gtk2drawing.c: Removed code for drawing menulists and buttons. (moz_gtk_init): (moz_gtk_get_widget_border): (moz_gtk_widget_paint):
- platform/gtk/gtk3drawing.c: (moz_gtk_init): (moz_gtk_get_widget_border): (moz_gtk_widget_paint):
- platform/gtk/gtkdrawing.h:
- 1:17 PM Changeset in webkit [76387] by
-
- 2 edits in trunk/Source/WebCore
Fix chromium mac build.
- platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::scrollbarStateToThemeState):
(WebCore::ScrollbarThemeChromiumMac::paint):
- 1:10 PM Changeset in webkit [76386] by
-
- 2 edits in trunk/LayoutTests
Unreviewed trivial fix.
FrameLoader::checkLoadCompleteForThisFrame uses wrong history item
https://bugs.webkit.org/show_bug.cgi?id=48812
- platform/qt/http/tests/navigation/forward-and-cancel-expected.txt: Updated after r76357.
- 1:08 PM Changeset in webkit [76385] by
-
- 2 edits in trunk/Source/WebCore
Fix the windows build.
- platform/ScrollbarThemeComposite.cpp:
(WebCore::ScrollbarThemeComposite::paint):
- 1:02 PM Changeset in webkit [76384] by
-
- 2 edits in trunk/LayoutTests
Skip transitions/transition-end-event-destroy-iframe.html on Windows in order to get the
Windows 7 Release bots green. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=52913
- platform/win/Skipped:
- 12:54 PM Changeset in webkit [76383] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-01-21 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed; another Chromium build fix attempt for r76378.
- src/WebScrollbarImpl.cpp: (WebKit::WebScrollbar::create): (WebKit::WebScrollbarImpl::WebScrollbarImpl): (WebKit::WebScrollbarImpl::setValue):
- 12:42 PM Changeset in webkit [76382] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-01-21 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed Chromium build fix attempt for r76378.
- src/WebScrollbarImpl.cpp: (WebKit::WebScrollbar::create): (WebKit::WebScrollbarImpl::WebScrollbarImpl):
- 12:34 PM Changeset in webkit [76381] by
-
- 2 edits in trunk/LayoutTests
2011-01-21 Maciej Stachowiak <mjs@apple.com>
Reviewed by Sam Weinig.
Skip another test that is failing sporadically on the buildbots
https://bugs.webkit.org/show_bug.cgi?id=52908
- platform/mac-wk2/Skipped:
- 12:29 PM Changeset in webkit [76380] by
-
- 5 edits in trunk/Source
2011-01-21 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Add chromium bundled audio spatialization resources to WebAudio.grd
https://bugs.webkit.org/show_bug.cgi?id=52651
- WebKit.grd:
2011-01-21 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Add chromium bundled audio spatialization resources to WebAudio.grd
https://bugs.webkit.org/show_bug.cgi?id=52651
No new tests since audio API is not yet implemented.
- WebCore.gyp/WebCore.gyp:
- platform/audio/chromium/AudioBusChromium.cpp: (WebCore::AudioBus::loadPlatformResource):
- 12:26 PM Changeset in webkit [76379] by
-
- 80 edits in trunk
2011-01-21 Xiyuan Xia <xiyuan@chromium.org>
Reviewed by Tony Chang.
Update chromium/linux baselines after drawing code moved into
WebThemeEngine.
https://bugs.webkit.org/show_bug.cgi?id=52826
- platform/chromium-linux/css1/box_properties/acid_test-expected.checksum:
- platform/chromium-linux/css1/box_properties/acid_test-expected.png:
- platform/chromium-linux/css2.1/t09-c5526c-display-00-e-expected.checksum:
- platform/chromium-linux/css2.1/t09-c5526c-display-00-e-expected.png:
- platform/chromium-linux/fast/block/basic/011-expected.checksum:
- platform/chromium-linux/fast/block/basic/011-expected.png:
- platform/chromium-linux/fast/block/margin-collapse/103-expected.checksum:
- platform/chromium-linux/fast/block/margin-collapse/103-expected.png:
- platform/chromium-linux/fast/css/non-standard-checkbox-size-expected.checksum:
- platform/chromium-linux/fast/css/non-standard-checkbox-size-expected.png:
- platform/chromium-linux/fast/dom/HTMLProgressElement/progress-element-expected.checksum:
- platform/chromium-linux/fast/dom/HTMLProgressElement/progress-element-expected.png:
- platform/chromium-linux/fast/forms/basic-inputs-expected.checksum:
- platform/chromium-linux/fast/forms/basic-inputs-expected.png:
- platform/chromium-linux/fast/forms/basic-selects-expected.checksum:
- platform/chromium-linux/fast/forms/basic-selects-expected.png:
- platform/chromium-linux/fast/forms/box-shadow-override-expected.checksum:
- platform/chromium-linux/fast/forms/box-shadow-override-expected.png:
- platform/chromium-linux/fast/forms/checkbox-radio-onchange-expected.checksum:
- platform/chromium-linux/fast/forms/checkbox-radio-onchange-expected.png:
- platform/chromium-linux/fast/forms/file-input-disabled-expected.checksum:
- platform/chromium-linux/fast/forms/file-input-disabled-expected.png:
- platform/chromium-linux/fast/forms/form-element-geometry-expected.checksum:
- platform/chromium-linux/fast/forms/form-element-geometry-expected.png:
- platform/chromium-linux/fast/forms/formmove-expected.checksum:
- platform/chromium-linux/fast/forms/formmove-expected.png:
- platform/chromium-linux/fast/forms/formmove2-expected.checksum:
- platform/chromium-linux/fast/forms/formmove2-expected.png:
- platform/chromium-linux/fast/forms/indeterminate-expected.checksum:
- platform/chromium-linux/fast/forms/indeterminate-expected.png:
- platform/chromium-linux/fast/forms/input-appearance-height-expected.checksum:
- platform/chromium-linux/fast/forms/input-appearance-height-expected.png:
- platform/chromium-linux/fast/forms/input-value-expected.checksum:
- platform/chromium-linux/fast/forms/input-value-expected.png:
- platform/chromium-linux/fast/forms/menulist-restrict-line-height-expected.checksum:
- platform/chromium-linux/fast/forms/menulist-restrict-line-height-expected.png:
- platform/chromium-linux/fast/forms/menulist-style-color-expected.checksum:
- platform/chromium-linux/fast/forms/menulist-style-color-expected.png:
- platform/chromium-linux/fast/forms/placeholder-position-expected.checksum:
- platform/chromium-linux/fast/forms/placeholder-position-expected.png: Added property svn:mime-type.
- platform/chromium-linux/fast/forms/radio-attr-order-expected.checksum:
- platform/chromium-linux/fast/forms/radio-attr-order-expected.png:
- platform/chromium-linux/fast/forms/radio-nested-labels-expected.checksum:
- platform/chromium-linux/fast/forms/radio-nested-labels-expected.png:
- platform/chromium-linux/fast/forms/radio_checked-expected.checksum:
- platform/chromium-linux/fast/forms/radio_checked-expected.png:
- platform/chromium-linux/fast/forms/radio_checked_dynamic-expected.checksum:
- platform/chromium-linux/fast/forms/radio_checked_dynamic-expected.png:
- platform/chromium-linux/fast/forms/select-baseline-expected.checksum:
- platform/chromium-linux/fast/forms/select-baseline-expected.png:
- platform/chromium-linux/fast/inline/positionedLifetime-expected.checksum:
- platform/chromium-linux/fast/inline/positionedLifetime-expected.png:
- platform/chromium-linux/fast/parser/bad-xml-slash-expected.checksum:
- platform/chromium-linux/fast/parser/bad-xml-slash-expected.png:
- platform/chromium-linux/fast/replaced/replaced-breaking-expected.checksum:
- platform/chromium-linux/fast/replaced/replaced-breaking-expected.png:
- platform/chromium-linux/fast/replaced/width100percent-checkbox-expected.checksum:
- platform/chromium-linux/fast/replaced/width100percent-checkbox-expected.png:
- platform/chromium-linux/fast/text/textIteratorNilRenderer-expected.checksum:
- platform/chromium-linux/fast/text/textIteratorNilRenderer-expected.png:
- platform/chromium-linux/fast/text/whitespace/normal-after-nowrap-breaking-expected.checksum:
- platform/chromium-linux/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.checksum:
- platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.checksum:
- platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.png: Added property svn:mime-type.
- platform/chromium-linux/tables/mozilla_expected_failures/core/captions1-expected.checksum:
- platform/chromium-linux/tables/mozilla_expected_failures/core/captions1-expected.png:
- platform/chromium-linux/tables/mozilla_expected_failures/core/captions2-expected.checksum:
- platform/chromium-linux/tables/mozilla_expected_failures/core/captions2-expected.png:
2011-01-21 Xiyuan Xia <xiyuan@chromium.org>
Reviewed by Tony Chang.
Use WebThemeEngine for relevant RenderTheme parts for chromium/linux.
https://bugs.webkit.org/show_bug.cgi?id=52826
- platform/chromium/ChromiumBridge.h:
- rendering/RenderThemeChromiumLinux.cpp: (WebCore::getWebThemeState): (WebCore::RenderThemeChromiumLinux::adjustSliderThumbSize): (WebCore::RenderThemeChromiumLinux::paintCheckbox): (WebCore::RenderThemeChromiumLinux::setCheckboxSize): (WebCore::RenderThemeChromiumLinux::paintRadio): (WebCore::RenderThemeChromiumLinux::setRadioSize): (WebCore::RenderThemeChromiumLinux::paintButton): (WebCore::RenderThemeChromiumLinux::paintTextField): (WebCore::RenderThemeChromiumLinux::paintMenuList): (WebCore::RenderThemeChromiumLinux::paintSliderTrack): (WebCore::RenderThemeChromiumLinux::paintSliderThumb): (WebCore::RenderThemeChromiumLinux::adjustInnerSpinButtonStyle): (WebCore::RenderThemeChromiumLinux::paintInnerSpinButton): (WebCore::RenderThemeChromiumLinux::paintProgressBar):
- rendering/RenderThemeChromiumLinux.h:
- rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::setCheckboxSize): (WebCore::RenderThemeChromiumSkia::setSizeIfAuto): (WebCore::RenderThemeChromiumSkia::indeterminateProgressValueRectFor):
- rendering/RenderThemeChromiumSkia.h:
2011-01-21 Xiyuan Xia <xiyuan@chromium.org>
Reviewed by Tony Chang.
Use WebThemeEngine for relevant RenderTheme parts for chromium/linux.
https://bugs.webkit.org/show_bug.cgi?id=52826
- WebKit.gyp:
- src/ChromiumBridge.cpp: (WebCore::WebThemePart): (WebCore::GetWebThemeExtraParams):
- 12:15 PM Changeset in webkit [76378] by
-
- 59 edits2 moves in trunk/Source
Part 2 of "Cleanup Scrollbar/ScrollbarClient relationship"
https://bugs.webkit.org/show_bug.cgi?id=52779
Reviewed by Anders Carlsson.
Rename ScrollbarClient -> ScrollableArea.
Source/WebCore:
- Also replaces Scrollbar::setClient with Scrollbar::disconnectFromScrollableArea since that was its only use case.
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- accessibility/AccessibilityScrollbar.cpp:
(WebCore::AccessibilityScrollbar::setValue):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
- page/FrameView.h:
- platform/PopupMenuClient.h:
- platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::create):
(WebCore::ScrollAnimator::ScrollAnimator):
(WebCore::ScrollAnimator::scroll):
(WebCore::ScrollAnimator::notityPositionChanged):
- platform/ScrollAnimator.h:
- platform/ScrollAnimatorWin.cpp:
(WebCore::ScrollAnimator::create):
(WebCore::ScrollAnimatorWin::ScrollAnimatorWin):
(WebCore::ScrollAnimatorWin::scroll):
- platform/ScrollAnimatorWin.h:
- platform/ScrollView.cpp:
(WebCore::ScrollView::scroll):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::wheelEvent):
- platform/ScrollView.h:
- platform/ScrollableArea.cpp: Copied from WebCore/platform/ScrollbarClient.cpp.
(WebCore::ScrollableArea::ScrollableArea):
(WebCore::ScrollableArea::~ScrollableArea):
(WebCore::ScrollableArea::scroll):
(WebCore::ScrollableArea::scrollToOffsetWithoutAnimation):
(WebCore::ScrollableArea::scrollToXOffsetWithoutAnimation):
(WebCore::ScrollableArea::scrollToYOffsetWithoutAnimation):
(WebCore::ScrollableArea::setScrollOffsetFromAnimation):
- platform/ScrollableArea.h: Copied from WebCore/platform/ScrollbarClient.h.
- platform/Scrollbar.cpp:
(WebCore::Scrollbar::createNativeScrollbar):
(WebCore::Scrollbar::Scrollbar):
(WebCore::Scrollbar::offsetDidChange):
(WebCore::Scrollbar::autoscrollPressedPart):
(WebCore::Scrollbar::moveThumb):
(WebCore::Scrollbar::mouseMoved):
(WebCore::Scrollbar::isWindowActive):
(WebCore::Scrollbar::invalidateRect):
(WebCore::Scrollbar::convertToContainingView):
(WebCore::Scrollbar::convertFromContainingView):
- platform/Scrollbar.h:
(WebCore::Scrollbar::disconnectFromScrollableArea):
(WebCore::Scrollbar::scrollableArea):
- platform/ScrollbarClient.cpp: Removed.
- platform/ScrollbarClient.h: Removed.
- platform/ScrollbarThemeComposite.cpp:
- platform/chromium/FramelessScrollView.h:
- platform/chromium/ScrollbarThemeChromium.cpp:
(WebCore::ScrollbarThemeChromium::paintTickmarks):
- platform/efl/ScrollbarEfl.cpp:
(Scrollbar::createNativeScrollbar):
(ScrollbarEfl::ScrollbarEfl):
(scrollbarEflEdjeMessage):
- platform/efl/ScrollbarEfl.h:
- platform/gtk/MainFrameScrollbarGtk.cpp:
(MainFrameScrollbarGtk::create):
(MainFrameScrollbarGtk::MainFrameScrollbarGtk):
(MainFrameScrollbarGtk::gtkValueChanged):
- platform/gtk/MainFrameScrollbarGtk.h:
- platform/mac/ScrollAnimatorMac.h:
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimator::create):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::scroll):
- platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::paint):
- platform/qt/ScrollbarQt.cpp:
(WebCore::Scrollbar::contextMenu):
- platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::scrollToRevealSelection):
(WebCore::PopupMenuWin::wndProc):
- platform/win/PopupMenuWin.h:
- platform/win/ScrollbarThemeSafari.cpp:
(WebCore::ScrollbarThemeSafari::paintTrackBackground):
(WebCore::ScrollbarThemeSafari::paintButton):
(WebCore::ScrollbarThemeSafari::paintThumb):
- platform/wx/ScrollbarThemeWx.cpp:
(WebCore::ScrollbarThemeWx::paint):
- rendering/RenderDataGrid.h:
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollToOffset):
(WebCore::RenderLayer::destroyScrollbar):
(WebCore::RenderLayer::scroll):
- rendering/RenderLayer.h:
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::scrollToRevealElementAtListIndex):
(WebCore::RenderListBox::scroll):
(WebCore::RenderListBox::logicalScroll):
(WebCore::RenderListBox::setScrollTop):
(WebCore::RenderListBox::destroyScrollbar):
- rendering/RenderListBox.h:
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::createScrollbar):
- rendering/RenderMenuList.h:
- rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::createCustomScrollbar):
(WebCore::RenderScrollbar::RenderScrollbar):
- rendering/RenderScrollbar.h:
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::createScrollbar):
- rendering/RenderTextControlSingleLine.h:
Source/WebKit/chromium:
- src/AutoFillPopupMenuClient.cpp:
(WebKit::AutoFillPopupMenuClient::createScrollbar):
- src/AutoFillPopupMenuClient.h:
- src/WebScrollbarImpl.cpp:
(WebKit::WebScrollbarImpl::WebScrollbarImpl):
(WebKit::WebScrollbarImpl::scroll):
(WebKit::WebScrollbarImpl::onMouseWheel):
(WebKit::WebScrollbarImpl::onKeyDown):
- src/WebScrollbarImpl.h:
- tests/PopupMenuTest.cpp:
(WebKit::TestPopupMenuClient::createScrollbar):
Source/WebKit/qt:
- Api/qwebframe.cpp:
(QWebFrame::setScrollBarValue):
Source/WebKit/win:
- WebScrollBar.cpp:
(WebScrollBar::scroll):
- WebScrollBar.h:
Source/WebKit2:
- UIProcess/win/WebPopupMenuProxyWin.cpp:
(WebKit::WebPopupMenuProxyWin::onMouseWheel):
(WebKit::WebPopupMenuProxyWin::scrollToRevealSelection):
- UIProcess/win/WebPopupMenuProxyWin.h:
- 12:13 PM Changeset in webkit [76377] by
-
- 4 edits in trunk/Source/WebKit/chromium
2011-01-21 Sailesh Agrawal <sail@chromium.org>
Reviewed by Ryosuke Niwa.
[chromium] Notify WebFrameClient when spellcheck state changes
https://bugs.webkit.org/show_bug.cgi?id=52680
- public/WebFrameClient.h: (WebKit::WebFrameClient::continuousSpellCheckingEnabledStateChanged):
- src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::toggleContinuousSpellChecking):
- src/WebFrameImpl.cpp:
- 12:01 PM Changeset in webkit [76376] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-01-21 Peter Gal <galpeter@inf.u-szeged.hu>
Reviewed by Darin Adler.
REGRESSION(r76177): All JavaScriptCore tests fail on ARM
https://bugs.webkit.org/show_bug.cgi?id=52814
Get the approximateByteSize value before releasing the OwnPtr.
- parser/JSParser.cpp: (JSC::JSParser::parseFunctionInfo):
- 11:51 AM Changeset in webkit [76375] by
-
- 2 edits in trunk/Source/WebCore
Fix Leopard build.
- rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::layout): Use ceilf instead of ceil.
- 11:44 AM Changeset in webkit [76374] by
-
- 2 edits in trunk/Source/WebCore
2011-01-21 Simon Fraser <Simon Fraser>
Reviewed by Sam Weinig.
GraphicsLayer should be non-copyable
https://bugs.webkit.org/show_bug.cgi?id=52909
Use WTF_MAKE_NONCOPYABLE on GraphicsLayer, and WTF_MAKE_FAST_ALLOCATED
on that and KeyframeValueList.
- platform/graphics/GraphicsLayer.h:
- 11:40 AM Changeset in webkit [76373] by
-
- 3 edits2 adds in trunk
2011-01-21 Anton Muhin <antonm@chromium.org>
Reviewed by Nate Chapin.
[v8] Properly deal with the case when conversion to string throws an exception for HTMLCollection accessors
https://bugs.webkit.org/show_bug.cgi?id=52901
- fast/dom/htmlcollection-conversion-throws-exception-expected.txt: Added.
- fast/dom/htmlcollection-conversion-throws-exception.html: Added.
2011-01-21 Anton Muhin <antonm@chromium.org>
Reviewed by Nate Chapin.
[v8] Properly deal with the case when conversion to string throws an exception for HTMLCollection accessors
https://bugs.webkit.org/show_bug.cgi?id=52901
Test: fast/dom/htmlcollection-conversion-throws-exception.html
- bindings/v8/custom/V8HTMLCollectionCustom.cpp: (WebCore::getItem):
- 11:35 AM Changeset in webkit [76372] by
-
- 7 edits2 adds in trunk/Source
Separate flushing layer changes from rendering in CACFLayerTreeHost
Old model:
1) A change is made to a GraphicsLayer.
2) CACFLayerTreeHost::flushPendingGraphicsLayerChangesSoon is called, which schedules the
render timer.
3) The timer fires, which calls through to CACFLayerTreeHost::render, which performs the
flush and then renders.
New model:
1) A change is made to a GraphicsLayer.
2) CACFLayerTreeHost::flushPendingGraphicsLayerChangesSoon is called, which tells the new
LayerChangesFlusher singleton that this host has changes that need to be flushed.
3) LayerChangesFlusher sets up a Windows hook that will get called on the next iteration
of the message loop.
4) LayerChangesFlusher's hook is called, which calls through to
CACFLayerTreeHost::flushPendingLayerChangesNow.
5) CACFLayerTreeHost::flushPendingLayerChangesNow schedules the render timer so the changes
that were just flushed to the context will be rendered.
When a change is made to a PlatformCALayer that doesn't have a corresponding GraphicsLayer
(e.g., for rendering <video>), CACFLayerTreeHost::layerTreeDidChange takes care of
scheduling the flush.
This change has three advantages:
1) Whenever we flush layer changes, we first update layout. This can cause the page to
leave compositing mode, which in turn can cause all references to the CACFLayerTreeHost
to be dropped. By separating flushing (and thus updating layout) from rendering, we no
longer have to worry about this happen during rendering.
2) The new model is much more similar to how things work on the Mac, so will hopefully
reduce the number of platform-specific bugs.
3) CACFLayerTreeHost::shouldRender, which was used to make sure we didn't render while a
layout was pending, is no longer needed. It actually hasn't been needed since at least
r75987, but removing it before now would have resulted in a crash whenever a page came
out of compositing mode due to (1).
Fixes <http://webkit.org/b/52852> Flushing layer changes and rendering are intertwined in
CACFLayerTreeHost, but shouldn't be
Reviewed by Simon Fraser.
Source/WebCore:
- WebCore.vcproj/WebCore.vcproj: Added LayerChangesFlusher.
- platform/graphics/ca/win/CACFLayerTreeHost.cpp: Added new #include, sorted existing #includes.
(WebCore::CACFLayerTreeHost::CACFLayerTreeHost): Initialize new member.
(WebCore::CACFLayerTreeHost::layerTreeDidChange): If we aren't already flushing changes,
schedule a flush. Removed the call to renderSoon(), which now happens when the flush is
finished.
(WebCore::CACFLayerTreeHost::destroyRenderer): Cancel any pending flush we had scheduled. Also
fixed a bug where we'd fail to clear the context's layer.
(WebCore::CACFLayerTreeHost::render): Removed code to ask the client if we should render, which
is no longer needed. Moved code to flush layer changes from here to
flushPendingLayerChangesNow, which is called via the above-described mechanism.
(WebCore::CACFLayerTreeHost::flushPendingGraphicsLayerChangesSoon): Schedule a flush. Removed
code to schedule a render, which now happens after we've flushed.
(WebCore::CACFLayerTreeHost::flushPendingLayerChangesNow): Added. Some of this code came from
render(). First we flush GraphicsLayer changes from GraphicsLayers to their underlying
PlatformCALayers, then we flush changes from PlatformCALayers to the context, then we
schedule a render so that the changes will be rendered to the screen.
- platform/graphics/ca/win/CACFLayerTreeHost.h: Removed
CACFLayerTreeHostClient::shouldRender. Added flushPendingLayerChangesNow and
m_isFlushingLayerChanges.
- platform/graphics/ca/win/LayerChangesFlusher.cpp: Added.
(WebCore::LayerChangesFlusher::shared):
(WebCore::LayerChangesFlusher::LayerChangesFlusher):
(WebCore::LayerChangesFlusher::flushPendingLayerChangesSoon):
(WebCore::LayerChangesFlusher::cancelPendingFlush):
(WebCore::LayerChangesFlusher::hookCallback):
(WebCore::LayerChangesFlusher::hookFired):
(WebCore::LayerChangesFlusher::setHook):
(WebCore::LayerChangesFlusher::removeHook):
- platform/graphics/ca/win/LayerChangesFlusher.cpp: Added.
(WebCore::LayerChangesFlusher::shared): Returns the singleton.
(WebCore::LayerChangesFlusher::LayerChangesFlusher): Initialize our members.
(WebCore::LayerChangesFlusher::flushPendingLayerChangesSoon): Add the host to the set of
hosts with changes that need to be flushed, and set up our hook if we haven't already.
(WebCore::LayerChangesFlusher::cancelPendingFlush): Remove the host from the set of hosts
with changes that need to be flushed. If we have no more such hosts, remove our hook, unless
we're currently in the process of calling out to our hosts, in which case we'll take care of
the hook once we're done calling out.
(WebCore::LayerChangesFlusher::hookCallback): This is the function that Windows calls when
our hook fires. Just calls through to hookFired on the singleton.
(WebCore::LayerChangesFlusher::hookFired): Tell all the hosts with changes that needed to be
flushed that it's time to flush. If no hosts re-added themselves to our set during this
process, remove our hook.
(WebCore::LayerChangesFlusher::setHook): Calls through to ::SetWindowsHookExW.
(WebCore::LayerChangesFlusher::removeHook): Calls through to ::UnhookWindowsHookEx.
- platform/graphics/ca/win/LayerChangesFlusher.h: Added.
Source/WebKit/win:
Update for CACFLayerTreeHost changes
- WebView.cpp:
(WebView::paint): Changed to flush layer changes via CACFLayerTreeHost, which will call back
to our own flushing function if needed.
- WebView.h: Removed shouldRender, which is no longer used or needed.
- 11:33 AM Changeset in webkit [76371] by
-
- 19 edits in trunk/Source/WebCore
2011-01-21 Simon Fraser <Simon Fraser>
Reviewed by Sam Weinig.
Report the sized used by canvases and types arrays
https://bugs.webkit.org/show_bug.cgi?id=52856
Report the memory cost associated with canvas elements,
and typed arrays to JavaScript as extraCost, so that it
can figure this into its GC behavior.
- bindings/js/JSArrayBufferViewHelper.h: (WebCore::toJSArrayBufferView): New templatized function, similar to getDOMObjectWrapper() but calls reportExtraMemoryCost() with the byteLength of the array.
- bindings/js/JSFloat32ArrayCustom.cpp: (WebCore::toJS): Use toJSArrayBufferView.
- bindings/js/JSInt16ArrayCustom.cpp: (WebCore::toJS): Use toJSArrayBufferView.
- bindings/js/JSInt32ArrayCustom.cpp: (WebCore::toJS): Use toJSArrayBufferView.
- bindings/js/JSInt8ArrayCustom.cpp: (WebCore::toJS): Use toJSArrayBufferView.
- bindings/js/JSUint16ArrayCustom.cpp: (WebCore::toJS): Use toJSArrayBufferView.
- bindings/js/JSUint32ArrayCustom.cpp: (WebCore::toJS): Use toJSArrayBufferView.
- bindings/js/JSUint8ArrayCustom.cpp: (WebCore::toJS): Use toJSArrayBufferView.
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createImageBuffer): Call heap.reportExtraMemoryCost() with the size of the canvas backing store.
- html/canvas/TypedArrayBase.h: (WebCore::TypedArrayBase::byteLength): byteLength needs to be public.
- platform/graphics/ImageBuffer.h: Add dataSize() method.
- platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::dataSize): Implement dataSize().
- platform/graphics/cg/ImageBufferCG.cpp: (WebCore::ImageBuffer::dataSize): Implement dataSize().
- platform/graphics/haiku/ImageBufferHaiku.cpp: (WebCore::ImageBuffer::dataSize): Implement dataSize().
- platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::dataSize): Implement dataSize().
- platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::dataSize): Implement dataSize().
- platform/graphics/wince/ImageBufferWinCE.cpp: (WebCore::ImageBuffer::dataSize): Implement dataSize().
- platform/graphics/wx/ImageBufferWx.cpp: (WebCore::ImageBuffer::dataSize): Implement dataSize().
- 11:32 AM Changeset in webkit [76370] by
-
- 13 edits2 moves in trunk/Source
Rename WKCACFLayerRenderer[Client] to CACFLayerTreeHost[Client]
Also renamed a few functions and data members to match.
Fixes <http://webkit.org/b/52898> WKCACFLayerRenderer sounds like a render object, but isn't
Reviewed by Simon Fraser.
Source/WebCore:
- WebCore.vcproj/WebCore.vcproj: Updated files' names and paths.
- WebCore.vcproj/WebCoreQuartzCore.vsprops: Added platform/graphics/ca/win to the include
path.
- WebCore.vcproj/copyForwardingHeaders.cmd: Copy headers from platform/graphics/ca/win, too.
- platform/graphics/ca/win/CACFLayerTreeHost.cpp: Renamed from Source/WebCore/platform/graphics/win/WKCACFLayerRenderer.cpp.
- platform/graphics/ca/win/CACFLayerTreeHost.h: Renamed from Source/WebCore/platform/graphics/win/WKCACFLayerRenderer.h.
- platform/graphics/ca/win/PlatformCALayerWin.cpp:
- platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
- platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h:
Updated for renames.
Source/WebKit/win:
Update for WKCACFLayerRenderer -> CACFLayerTreeHost rename
Also renamed WebView::m_layerRenderer to WebView::m_layerTreeHost to match.
- WebPreferences.cpp:
- WebView.cpp:
(WebView::setAcceleratedCompositing): Also made sure to remove our HWND from the layer tree
host before we get rid of the layer tree host itself.
- WebView.h:
Source/WebKit2:
Update for WKCACFLayerRenderer -> CACFLayerView rename
- WebProcess/WebPage/win/LayerBackedDrawingAreaWin.cpp: Just removed all the unnecessary #includes.
- 11:32 AM Changeset in webkit [76369] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-01-21 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
Remove unnecessary <stdio.h> include
https://bugs.webkit.org/show_bug.cgi?id=52884
- jit/JIT.cpp: remove unnecessary include.
- 11:27 AM Changeset in webkit [76368] by
-
- 3 edits in trunk/Source/WebCore
2011-01-21 Patrick Gansterer <paroga@paroga.com>
Original patch from François Sausset <François Sausset>
Reviewed by Darin Adler.
Code cleaning in rendering/mathml/RenderMathMLFraction.cpp
https://bugs.webkit.org/show_bug.cgi?id=52201
Replace unneeded doubles by floats and remove unneeded casts.
- rendering/mathml/RenderMathMLFraction.cpp: (WebCore::RenderMathMLFraction::paint):
- rendering/mathml/RenderMathMLFraction.h:
- 11:20 AM Changeset in webkit [76367] by
-
- 2 edits in trunk/Websites/webkit.org
Proposal: Require cross-organizational seconds for reviewer nominations
https://bugs.webkit.org/show_bug.cgi?id=47597
Reviewed by Darin Adler.
This changes the committer/reviewer policy to require an additional
reviewer supporting a reviewer nomination to work for a different
company and different project affiliation from the nominee.
This means reviewer nominations would require four supporting reviewers,
one of which knows the reviewer through the community (irc, email, bugs)
ensuring that the nominee has the open-source collaboration skills
we so highly value here in WebKit.
- coding/commit-review-policy.html:
- 11:20 AM Changeset in webkit [76366] by
-
- 4 edits2 adds in trunk
2011-01-21 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Adler.
REGRESSION(r73618): Clicking on a search input causes a crash.
https://bugs.webkit.org/show_bug.cgi?id=52905
- fast/dom/search-shadow-host-crash-expected.txt: Added.
- fast/dom/search-shadow-host-crash.html: Added.
2011-01-21 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Adler.
REGRESSION(r73618): Clicking on a search input causes a crash.
https://bugs.webkit.org/show_bug.cgi?id=52905
The problem is caused by TextControlInnerElement being used both as
shadow root and an element in a shadow subtree. The code assumed it is
only used as a shadow root.
Since this code is all just workaround for in-progress conversion to
new shadow DOM, I am just adding a check. This code will disappear
completely once bug 52788 is fixed.
Test: fast/dom/search-shadow-host-crash.html
- dom/Node.cpp: (WebCore::Node::setShadowHost): Added an ASSERT for early detection
of attempting to stomp on the parentNode.
- rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerElement::detach): Added a check to only
clear shadow host if we have one.
- 11:05 AM Changeset in webkit [76365] by
-
- 3 edits in trunk/LayoutTests
2011-01-21 Dimitri Glazkov <Dimitri Glazkov>
Updated slider expectations after r76147.
- platform/chromium/test_expectations.txt: Removed test that will start passing.
- platform/chromium-win/fast/forms/slider-mouse-events-expected.txt: Updated expectation.
- 11:00 AM Changeset in webkit [76364] by
-
- 1 edit1 add in trunk/LayoutTests
2011-01-21 Xiaomei Ji <xji@chromium.org>
Unreviewed.
Rebaseline for leopard after r76319.
- platform/mac-leopard/fast/dom/52776-expected.txt: Added.
- 10:50 AM Changeset in webkit [76363] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-01-21 Tony Chang <tony@chromium.org>
Unreviewed, updating chromium DEPS so we can pull in linux theme changes.
- DEPS:
- 10:44 AM Changeset in webkit [76362] by
-
- 2 edits in trunk/Tools
Fix Mac build.
- MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
- 10:41 AM Changeset in webkit [76361] by
-
- 18 edits in trunk
WebKit2: Implement showModalDialog
https://bugs.webkit.org/show_bug.cgi?id=52855
Reviewed by Dan Bernstein.
Source/WebKit2:
- Shared/WebPageCreationParameters.h: Added canRunModal.
- UIProcess/API/C/WKPage.h: Added a runModal function pointer to
WKPageUIClient. Also removed a lot of redundant typedefs and added
a new one, WKPageCallback, for callbacks without arguments or return
values.
- UIProcess/API/qt/qwkpage.cpp:
(QWKPage::QWKPage): Added a runModal function pointer of 0.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters): Set canRunModal
based on return value of WebUIClient::canRunModal.
- UIProcess/WebPageProxy.h: Added runModal.
Calls WebUIClient::runModal.
- UIProcess/WebPageProxy.messages.in: Added RunModal message.
Also removed the periods from the phrases in the comments
as Maciej requested a while back.
- UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::canRunModal): Added. Returns true or false
based on whether a runModal function was supplied in the
WKPageUIClient structure.
(WebKit::WebUIClient::runModal): Added. Calls the runModal
function from the WKPageUIClient structure.
- UIProcess/WebUIClient.h: Declared the above functions.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::canRunModal): Call through to WebPage.
(WebKit::WebChromeClient::runModal): Ditto.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage): Initialize m_canRunModal based on the
creation parameters. Initialize m_isRunningModal to false.
(WebKit::WebPage::close): Stop the nested run loop if we are running modal.
(WebKit::WebPage::runModal): Send a message to ask the UI process to run
modal and then start a nested run loop. It gets stopped when the page is closed.
- WebProcess/WebPage/WebPage.h: Defined the canRunModal function
and declared the runModal function.
Tools:
This fixes WebKitTestRunner to compile, but more work is probably
needed to get it to pass the tests.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::runModal): Added. Calls through to the
platform-specific version of runModal.
(WTR::TestController::createOtherPage): Changed to be a private
static member function so it can refer to runModal, which is
a private static member function.
(WTR::TestController::initialize): Pass 0 for the runModal
function since we don't need to run the main window modal.
I suspect this is wrong and will need to change.
- WebKitTestRunner/TestController.h: Added declarations for
the functions added above.
- WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::TestController::runModal): Added. Untested implementation.
- WebKitTestRunner/qt/TestControllerQt.cpp:
(WTR::TestController::runModal): Added.
- WebKitTestRunner/win/TestControllerWin.cpp:
(WTR::TestController::runModal): Added.
- 10:41 AM Changeset in webkit [76360] by
-
- 2 edits in trunk/LayoutTests
2011-01-21 Kenji Imasaki <imasaki@chromium.org>
Reviewed by David Levin.
remove non-flaky tests from test expectation file
https://bugs.webkit.org/show_bug.cgi?id=52746
- platform/chromium/test_expectations.txt:
- 10:31 AM Changeset in webkit [76359] by
-
- 7 edits in trunk/Source
Replace some "sync compositing state" terminology with "flush pending GraphicsLayer changes"
This seems to be the direction in which our code is moving. I chose "GraphicsLayer" as
opposed to just "layer" because there are cases where we flush changes to CACFLayers that
don't have a corresponding GraphicsLayer.
Fixes <http://webkit.org/b/52894> "Sync compositing state" terminology in
WKCACFLayerRenderer and friends is confusing
Reviewed by Simon Fraser.
Source/WebCore:
- platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer):
(WebCore::WKCACFLayerRenderer::render):
Updated for renames.
(WebCore::WKCACFLayerRenderer::flushPendingGraphicsLayerChangesSoon): Renamed from
syncCompositingStateSoon, and updated for other renames.
- platform/graphics/win/WKCACFLayerRenderer.h: Renamed m_syncLayerChanges to
- m_shouldFlushPendingGraphicsLayerChanges.
(WebCore::WKCACFLayerRendererClient::flushPendingGraphicsLayerChanges): Renamed from
syncCompositingState.
Source/WebKit/win:
- WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::scheduleCompositingLayerSync): Updated for WebView changes.
- WebView.cpp:
(WebView::paint): Updated for rename.
(WebView::flushPendingGraphicsLayerChangesSoon): Renamed from scheduleCompositingLayerSync.
(WebView::notifySyncRequired): Updated for rename.
(WebView::flushPendingGraphicsLayerChanges): Renamed from syncCompositingState.
- WebView.h: Did the renames.
- 10:31 AM Changeset in webkit [76358] by
-
- 2 edits in trunk/Source/WebCore
Clean up PlatformCAAnimationWin
Fixes <http://webkit.org/b/52904> PlatformCAAnimationWin is leaky and inefficient
Reviewed by Simon Fraser.
- platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
(toCACFFillModeType):
(fromCACFFillModeType):
(toCACFValueFunctionType):
(fromCACFValueFunctionType):
Changed to take and return CFStringRefs. There's no need to convert to WebCore::String just
so we can later convert back to CFStringRef.
(toCACFTimingFunction): Fixed leaks by changing this to return a RetainPtr and adopting the
results of CACFTimingFunctionCreate.
(PlatformCAAnimation::PlatformCAAnimation): Changed not to needlessly roundtrip through
WebCore::String. Also changed an ASSERT(0) to ASSERT_NOT_REACHED().
(PlatformCAAnimation::setFillMode):
(PlatformCAAnimation::setTimingFunction):
(PlatformCAAnimation::setValueFunction):
(PlatformCAAnimation::setTimingFunctions):
Updated for changes to the above conversion functions.
- 10:26 AM Changeset in webkit [76357] by
-
- 9 edits4 adds in trunk
2011-01-21 Charlie Reis <creis@chromium.org>
Reviewed by Darin Fisher.
FrameLoader::checkLoadCompleteForThisFrame uses wrong history item
https://bugs.webkit.org/show_bug.cgi?id=48812
Test that we avoid updating back/forward list on a canceled navigation
if a new navigation is already in process. Also update forward-and-cancel
to go forward, ensuring back/forward state is reset if user clicks stop.
- http/tests/navigation/back-twice-without-commit-expected.txt: Added.
- http/tests/navigation/back-twice-without-commit.html: Added.
- http/tests/navigation/forward-and-cancel-expected.txt:
- http/tests/navigation/forward-and-cancel.html: Go forward after stop, not back.
- http/tests/navigation/resources/back-twice-page-2.html: Added.
- http/tests/navigation/resources/back-twice-page-3.html: Added.
- http/tests/navigation/resources/forward-and-cancel-frames.html: Reduced delay.
2011-01-21 Charlie Reis <creis@chromium.org>
Reviewed by Darin Fisher.
FrameLoader::checkLoadCompleteForThisFrame uses wrong history item
https://bugs.webkit.org/show_bug.cgi?id=48812
Most calls to stopAllLoaders now clear the history's provisional item(s).
We can now avoid resetting the back/forward state if a new navigation
is in progress.
Test: http/tests/navigation/back-twice-without-commit.html
Test: http/tests/navigation/forward-and-cancel.html
- loader/FrameLoader.cpp:
- loader/FrameLoader.h:
- loader/FrameLoaderTypes.h:
- WebCore.exp.in: Update stopAllLoaders signature.
- 10:09 AM Changeset in webkit [76356] by
-
- 2 edits2 moves2 adds2 deletes in trunk/LayoutTests
2011-01-20 Mihai Parparita <mihaip@chromium.org>
Reviewed by Eric Seidel.
[Chromium] Update expectations for compositing/geometry/limit-layer-bounds-overflow-repaint.html
https://bugs.webkit.org/show_bug.cgi?id=52860
The test hasn't had a timeout in a while, remove that expectation so
that we can more easily see if this re-occurs.
Also rebaseline for chromium-gpu-mac (it has the green as 0,128,0, just
like chromium-gpu-win and -linux, for some reason the mac expectation
has it as 17,128,4).
- platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.checksum: Removed.
- platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png: Removed.
- platform/chromium-gpu/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.checksum: Renamed from LayoutTests/platform/chromium-gpu-linux/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.checksum.
- platform/chromium-gpu/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png: Renamed from LayoutTests/platform/chromium-gpu-linux/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png.
- platform/chromium-gpu/test_expectations.txt:
- 9:51 AM Changeset in webkit [76355] by
-
- 2 edits in trunk/LayoutTests
2011-01-21 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed; Reverted the last change to the text expectation.
- platform/chromium/test_expectations.txt:
- 9:39 AM Changeset in webkit [76354] by
-
- 2 edits in trunk/LayoutTests
2011-01-21 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed Chromium test expectation update.
- platform/chromium/test_expectations.txt:
- 9:33 AM Changeset in webkit [76353] by
-
- 2 edits9 adds in trunk/LayoutTests
2011-01-21 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed Chromium rebaselines for 76319.
- platform/chromium-linux/fast/dom/52776-expected.checksum: Added.
- platform/chromium-linux/fast/dom/52776-expected.png: Added.
- platform/chromium-linux/fast/dom/52776-expected.txt: Added.
- platform/chromium-mac/fast/dom/52776-expected.checksum: Added.
- platform/chromium-mac/fast/dom/52776-expected.png: Added.
- platform/chromium-mac/fast/dom/52776-expected.txt: Added.
- platform/chromium-win/fast/dom/52776-expected.checksum: Added.
- platform/chromium-win/fast/dom/52776-expected.png: Added.
- platform/chromium-win/fast/dom/52776-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 9:26 AM Changeset in webkit [76352] by
-
- 2 edits in trunk/LayoutTests
2011-01-21 Tony Chang <tony@chromium.org>
Unreviewed, these tests were fixed in r76330. Still one unknown
failure.
- platform/chromium/test_expectations.txt:
- 9:21 AM Changeset in webkit [76351] by
-
- 6 edits in trunk/Source
2011-01-21 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Show caps lock indicator in password fields
https://bugs.webkit.org/show_bug.cgi?id=52878
Test: manual-tests/password-caps-lock.html
- platform/gtk/KeyEventGtk.cpp: (WebCore::PlatformKeyboardEvent::currentCapsLockState): Implement currentCapsLockState() using GDK API.
- platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::paintCapsLockIndicator): Paint an icon in the password field when the caps lock modifier is locked.
- platform/gtk/RenderThemeGtk.h:
2011-01-21 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Show caps lock indicator in password fields
https://bugs.webkit.org/show_bug.cgi?id=52878
Test: manual-tests/password-caps-lock.html
- webkit/webkitwebview.cpp: (webkit_web_view_key_release_event): Call capsLockStateMayHaveChanged() when caps lock key is pressed.
- 8:36 AM Changeset in webkit [76350] by
-
- 5 edits in trunk/LayoutTests
Modify the Windows-specific results after http://trac.webkit.org/changeset/76208 in order to
get the bots green. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=52557
- platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/win/fast/dom/prototype-inheritance-2-expected.txt:
- platform/win/fast/dom/prototype-inheritance-expected.txt:
- platform/win/fast/js/global-constructors-expected.txt:
- 8:22 AM Changeset in webkit [76349] by
-
- 1 edit1 add in trunk/LayoutTests
Add Windows-specific results for fast/dom/52776.html to get the bot green. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=52776
- platform/win/fast/dom/52776-expected.txt: Added.
- 8:08 AM Changeset in webkit [76348] by
-
- 9 edits in trunk/Source/WebCore
2011-01-21 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: move sticky breakpoints management from InspectorController to InspectorBrowserDebuggerAgent.
https://bugs.webkit.org/show_bug.cgi?id=52874
This is the first step of debugger api refactoring (see bug 52879).
JavaScript breakpoints are still in the same list as native breakpoints and are restored by InspectorBrowserDebuggerAgent.
The second step will be to move sticky JavaScript breakpoints to InspectorDebuggerAgent.
- inspector/Inspector.idl:
- inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::setAllBrowserBreakpoints): (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged): (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::discardBindings): (WebCore::InspectorBrowserDebuggerAgent::didInsertDOMNode): (WebCore::InspectorBrowserDebuggerAgent::didRemoveDOMNode): (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent): (WebCore::InspectorBrowserDebuggerAgent::hasBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::updateSubtreeBreakpoints):
- inspector/InspectorBrowserDebuggerAgent.h:
- inspector/InspectorController.cpp: (WebCore::InspectorController::restoreInspectorStateFromCookie): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::enableDebugger): (WebCore::InspectorController::resume): (WebCore::InspectorController::inspectedURL):
- inspector/InspectorController.h:
- inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState):
- inspector/InspectorState.h:
- inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager): (WebInspector.BreakpointManager.prototype._saveBreakpoints):
- 7:51 AM Changeset in webkit [76347] by
-
- 2 edits in trunk/Source/WebCore
2011-01-21 John Knottenbelt <jknotten@chromium.org>
Reviewed by Jeremy Orlow.
Turn off uninitialized errors for ARM linux build.
https://bugs.webkit.org/show_bug.cgi?id=52893
Fix ARM compiler breakage.
- WebCore.gyp/WebCore.gyp:
- 7:00 AM Changeset in webkit [76346] by
-
- 1 edit2 adds in trunk/LayoutTests
2011-01-21 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Add layout test for the CPU profiler.
This test replaces DevToolsSanityTest.TestProfilerTab from
Chromium's interactive_ui_tests.
- inspector/cpu-profiler-profiling-expected.txt: Added.
- inspector/cpu-profiler-profiling.html: Added.
[Relanding, this time the test should work in Chromium]
- 6:41 AM Changeset in webkit [76345] by
-
- 2 edits in trunk/Source/WebCore
2011-01-21 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [Chromium] REGRESSION: Using the "Back" button
while profiling causes renderer crash.
- inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole): (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):
- 4:30 AM Changeset in webkit [76344] by
-
- 6 edits in trunk/Source/WebCore
2011-01-20 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: switch page/Console implementation from InspectorController to InspectorInstrumentation.
There are some places in WebCore where we still using direct InspectorController calls.
The idea is to pass all the Inspector related calls via InspectorInstrumentaion which is the
Inspector facade for WebCore.
- inspector/InspectorController.cpp:
- inspector/InspectorController.h:
- inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::addProfileImpl): (WebCore::InspectorInstrumentation::profilerEnabledImpl): (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileNameImpl):
- inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::addProfile): (WebCore::InspectorInstrumentation::profilerEnabled): (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileName):
- page/Console.cpp: (WebCore::Console::profile): (WebCore::Console::profileEnd):
- 4:16 AM Changeset in webkit [76343] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
[Qt] editing/selection/rtl-move-selection-right-left.html fails
https://bugs.webkit.org/show_bug.cgi?id=52883
- platform/qt/Skipped: editing/selection/rtl-move-selection-right-left.html added until fix.
- 4:08 AM Changeset in webkit [76342] by
-
- 2 edits in trunk/LayoutTests
2011-01-21 Sergio Villar Senin <svillar@igalia.com>
Unreviewed.
[GTK] http/tests/security/drag-drop-same-unique-origin.html fails on bots.
https://bugs.webkit.org/show_bug.cgi?id=52882
Skipping http/tests/security/drag-drop-same-unique-origin.html for gtk.
- platform/gtk/Skipped:
- 3:59 AM Changeset in webkit [76341] by
-
- 8 edits in trunk/Source/WebCore
2011-01-12 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: breakpoints are restored incorrectly when reverting live edit.
https://bugs.webkit.org/show_bug.cgi?id=52300
Fix breakpoints restoring when reverting to old revision by using text diff.
Move live edit logic from ScriptsPanel to DebuggerModel.
Eliminate unnecessary editLine delegate in TextViewer.
- inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel): (WebInspector.DebuggerModel.prototype.reset): (WebInspector.DebuggerModel.prototype.editScriptSource): (WebInspector.DebuggerModel.prototype._updateScriptSource): (WebInspector.DebuggerModel.prototype.get callFrames): (WebInspector.DebuggerModel.prototype.pausedScript): (WebInspector.DebuggerModel.prototype.resumedScript):
- inspector/front-end/Script.js: (WebInspector.Script.prototype.get source):
- inspector/front-end/ScriptView.js: (WebInspector.ScriptView):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._scriptSourceChanged):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame): (WebInspector.SourceFrame.prototype._createViewerIfNeeded): (WebInspector.SourceFrame.prototype._doubleClick.didEditLine): (WebInspector.SourceFrame.prototype._doubleClick):
- inspector/front-end/SourceView.js: (WebInspector.SourceView):
- inspector/front-end/TextViewer.js: (WebInspector.TextViewer): (WebInspector.TextViewer.prototype._handleKeyDown): (WebInspector.TextViewer.prototype.editLine.finishEditing): (WebInspector.TextViewer.prototype.editLine): (WebInspector.TextChunk.prototype._createRow):
- 3:31 AM Changeset in webkit [76340] by
-
- 55 edits1 move1 delete in trunk/Source
2011-01-21 Adam Klein <adamk@chromium.org>
Reviewed by Eric Seidel.
[chromium] Rename ChromiumBridge to PlatformBridge
https://bugs.webkit.org/show_bug.cgi?id=52471
No tests added as this is a rename; no change in behavior.
- WebCore.gypi:
- bindings/v8/V8DOMWindowShell.cpp: (WebCore::reportFatalErrorInV8):
- page/PageGroup.cpp: (WebCore::PageGroup::isLinkVisited):
- platform/android/PlatformBridge.h:
- platform/audio/chromium/AudioBusChromium.cpp: (WebCore::createBusFromInMemoryAudioFile):
- platform/chromium/ChromiumBridge.h: Removed.
- platform/chromium/ChromiumDataObjectLegacy.cpp: (WebCore::ChromiumDataObjectLegacy::getData):
- platform/chromium/DragDataChromium.cpp: (WebCore::DragData::asURL):
- platform/chromium/FileSystemChromium.cpp: (WebCore::deleteFile): (WebCore::deleteEmptyDirectory): (WebCore::getFileSize): (WebCore::getFileModificationTime): (WebCore::revealFolderInOS): (WebCore::directoryName): (WebCore::pathByAppendingComponent): (WebCore::makeAllDirectories): (WebCore::fileExists): (WebCore::openFile): (WebCore::closeFile): (WebCore::seekFile): (WebCore::truncateFile): (WebCore::readFromFile): (WebCore::writeToFile):
- platform/chromium/LanguageChromium.cpp: (WebCore::platformDefaultLanguage):
- platform/chromium/LinkHashChromium.cpp: (WebCore::visitedLinkHash):
- platform/chromium/MIMETypeRegistryChromium.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension): (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType): (WebCore::MIMETypeRegistry::isSupportedImageMIMEType): (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType): (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
- platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writePlainText): (WebCore::Pasteboard::writeURL): (WebCore::Pasteboard::writeImage): (WebCore::Pasteboard::canSmartReplace): (WebCore::Pasteboard::plainText): (WebCore::Pasteboard::documentFragment):
- platform/chromium/PlatformBridge.h:
- platform/chromium/PlatformScreenChromium.cpp: (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::screenRect): (WebCore::screenAvailableRect):
- platform/chromium/ReadableDataObject.cpp: (WebCore::ReadableDataObject::getData): (WebCore::ReadableDataObject::urlTitle): (WebCore::ReadableDataObject::htmlBaseUrl): (WebCore::ReadableDataObject::filenames): (WebCore::ReadableDataObject::ensureTypeCacheInitialized):
- platform/chromium/SSLKeyGeneratorChromium.cpp: (WebCore::signedPublicKeyAndChallengeString):
- platform/chromium/ScrollbarThemeChromium.cpp:
- platform/chromium/ScrollbarThemeChromiumLinux.cpp: (WebCore::ScrollbarThemeChromiumLinux::scrollbarThickness): (WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece): (WebCore::ScrollbarThemeChromiumLinux::paintButton): (WebCore::ScrollbarThemeChromiumLinux::paintThumb): (WebCore::ScrollbarThemeChromiumLinux::buttonSize): (WebCore::ScrollbarThemeChromiumLinux::minimumThumbLength):
- platform/chromium/ScrollbarThemeChromiumMac.mm: (WebCore::scrollbarStateToThemeState): (WebCore::ScrollbarThemeChromiumMac::paint):
- platform/chromium/ScrollbarThemeChromiumWin.cpp: (WebCore::ScrollbarThemeChromiumWin::scrollbarThickness): (WebCore::ScrollbarThemeChromiumWin::paintTrackPiece): (WebCore::ScrollbarThemeChromiumWin::paintButton): (WebCore::ScrollbarThemeChromiumWin::paintThumb): (WebCore::ScrollbarThemeChromiumWin::buttonSize):
- platform/chromium/SharedTimerChromium.cpp: (WebCore::setSharedTimerFiredFunction): (WebCore::setSharedTimerFireTime): (WebCore::stopSharedTimer):
- platform/chromium/SuddenTerminationChromium.cpp: (WebCore::disableSuddenTermination): (WebCore::enableSuddenTermination):
- platform/chromium/SystemTimeChromium.cpp: (WebCore::currentTime):
- platform/chromium/WritableDataObject.cpp: (WebCore::WritableDataObject::setData):
- platform/graphics/chromium/CrossProcessFontLoading.mm:
- platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::fontContainsCharacter): (WebCore::FillLogFont):
- platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::getFontDataForCharacters):
- platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::drawGlyphs):
- platform/graphics/chromium/FontPlatformDataChromiumWin.cpp: (WebCore::FontPlatformData::scriptFontProperties):
- platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::querySystemForRenderStyle):
- platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp: (WebCore::fillBMPGlyphs):
- platform/graphics/chromium/ImageChromium.cpp: (WebCore::Image::loadPlatformResource):
- platform/graphics/chromium/ImageChromiumMac.mm: (WebCore::Image::loadPlatformResource):
- platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::determinePitch): (WebCore::SimpleFontData::platformWidthForGlyph):
- platform/graphics/chromium/UniscribeHelperTextRun.cpp: (WebCore::UniscribeHelperTextRun::tryToPreloadFont):
- platform/graphics/skia/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData):
- platform/network/chromium/CookieJarChromium.cpp: (WebCore::setCookies): (WebCore::cookies): (WebCore::cookieRequestHeaderFieldValue): (WebCore::cookiesEnabled): (WebCore::getRawCookies): (WebCore::deleteCookie):
- platform/network/chromium/DNSChromium.cpp: (WebCore::prefetchDNS):
- platform/qt/PlatformBridge.h:
- platform/sql/chromium/SQLiteFileSystemChromium.cpp: (WebCore::SQLiteFileSystem::deleteDatabaseFile): (WebCore::SQLiteFileSystem::getDatabaseFileSize):
- platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp: (chromiumOpen): (chromiumDelete): (chromiumAccess):
- platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:
- plugins/chromium/PluginDataChromium.cpp: (WebCore::PluginCache::plugins):
- rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::usesTestModeFocusRingColor):
- rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::caretBlinkInterval):
- rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumWin::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumWin::platformActiveSelectionForegroundColor): (WebCore::RenderThemeChromiumWin::systemColor): (WebCore::RenderThemeChromiumWin::paintButton): (WebCore::RenderThemeChromiumWin::paintSliderTrack): (WebCore::menuListButtonWidth): (WebCore::RenderThemeChromiumWin::paintMenuList): (WebCore::RenderThemeChromiumWin::paintTextFieldInternal): (WebCore::RenderThemeChromiumWin::paintInnerSpinButton): (WebCore::RenderThemeChromiumWin::paintProgressBar):
- storage/chromium/IDBFactoryBackendInterface.cpp: (WebCore::IDBFactoryBackendInterface::create): (WebCore::IDBFactoryBackendInterface::~IDBFactoryBackendInterface):
- storage/chromium/IDBKeyPathBackendImpl.cpp: (WebCore::IDBKeyPathBackendImpl::createIDBKeysFromSerializedValuesAndKeyPath):
2011-01-21 Adam Klein <adamk@chromium.org>
Reviewed by Eric Seidel.
[chromium] Rename ChromiumBridge to PlatformBridge
https://bugs.webkit.org/show_bug.cgi?id=52471
- WebKit.gyp:
- src/AssertMatchingEnums.cpp:
- src/PlatformBridge.cpp: (WebCore::toChromeClientImpl): (WebCore::toWebWidgetClient): (WebCore::getCookieJar): (WebCore::PlatformBridge::cacheMetadata): (WebCore::PlatformBridge::clipboardIsFormatAvailable): (WebCore::PlatformBridge::clipboardReadPlainText): (WebCore::PlatformBridge::clipboardReadHTML): (WebCore::PlatformBridge::clipboardWriteSelection): (WebCore::PlatformBridge::clipboardWritePlainText): (WebCore::PlatformBridge::clipboardWriteURL): (WebCore::PlatformBridge::clipboardWriteImage): (WebCore::PlatformBridge::clipboardWriteData): (WebCore::PlatformBridge::clipboardReadAvailableTypes): (WebCore::PlatformBridge::clipboardReadData): (WebCore::PlatformBridge::clipboardReadFilenames): (WebCore::PlatformBridge::setCookies): (WebCore::PlatformBridge::cookies): (WebCore::PlatformBridge::cookieRequestHeaderFieldValue): (WebCore::PlatformBridge::rawCookies): (WebCore::PlatformBridge::deleteCookie): (WebCore::PlatformBridge::cookiesEnabled): (WebCore::PlatformBridge::prefetchDNS): (WebCore::PlatformBridge::fileExists): (WebCore::PlatformBridge::deleteFile): (WebCore::PlatformBridge::deleteEmptyDirectory): (WebCore::PlatformBridge::getFileSize): (WebCore::PlatformBridge::revealFolderInOS): (WebCore::PlatformBridge::getFileModificationTime): (WebCore::PlatformBridge::directoryName): (WebCore::PlatformBridge::pathByAppendingComponent): (WebCore::PlatformBridge::makeAllDirectories): (WebCore::PlatformBridge::getAbsolutePath): (WebCore::PlatformBridge::isDirectory): (WebCore::PlatformBridge::filePathToURL): (WebCore::PlatformBridge::openFile): (WebCore::PlatformBridge::closeFile): (WebCore::PlatformBridge::seekFile): (WebCore::PlatformBridge::truncateFile): (WebCore::PlatformBridge::readFromFile): (WebCore::PlatformBridge::writeToFile): (WebCore::PlatformBridge::ensureFontLoaded): (WebCore::PlatformBridge::getFontFamilyForCharacters): (WebCore::PlatformBridge::getRenderStyleForStrike): (WebCore::PlatformBridge::loadFont): (WebCore::PlatformBridge::databaseOpenFile): (WebCore::PlatformBridge::databaseDeleteFile): (WebCore::PlatformBridge::databaseGetFileAttributes): (WebCore::PlatformBridge::databaseGetFileSize): (WebCore::PlatformBridge::idbFactory): (WebCore::PlatformBridge::idbShutdown): (WebCore::PlatformBridge::createIDBKeysFromSerializedValuesAndKeyPath): (WebCore::PlatformBridge::signedPublicKeyAndChallengeString): (WebCore::PlatformBridge::computedDefaultLanguage): (WebCore::PlatformBridge::layoutTestMode): (WebCore::PlatformBridge::isSupportedImageMIMEType): (WebCore::PlatformBridge::isSupportedJavaScriptMIMEType): (WebCore::PlatformBridge::isSupportedNonImageMIMEType): (WebCore::PlatformBridge::mimeTypeForExtension): (WebCore::PlatformBridge::mimeTypeFromFile): (WebCore::PlatformBridge::preferredExtensionForMIMEType): (WebCore::PlatformBridge::plugins): (WebCore::PlatformBridge::pluginScriptableObject): (WebCore::PlatformBridge::loadPlatformImageResource): (WebCore::PlatformBridge::loadPlatformAudioResource): (WebCore::PlatformBridge::decodeAudioFileData): (WebCore::PlatformBridge::sandboxEnabled): (WebCore::PlatformBridge::setSharedTimerFiredFunction): (WebCore::PlatformBridge::setSharedTimerFireTime): (WebCore::PlatformBridge::stopSharedTimer): (WebCore::PlatformBridge::decrementStatsCounter): (WebCore::PlatformBridge::incrementStatsCounter): (WebCore::PlatformBridge::histogramCustomCounts): (WebCore::PlatformBridge::histogramEnumeration): (WebCore::PlatformBridge::suddenTerminationChanged): (WebCore::PlatformBridge::currentTime): (WebCore::PlatformBridge::paintButton): (WebCore::PlatformBridge::paintMenuList): (WebCore::PlatformBridge::paintScrollbarArrow): (WebCore::PlatformBridge::paintScrollbarThumb): (WebCore::PlatformBridge::paintScrollbarTrack): (WebCore::PlatformBridge::paintSpinButton): (WebCore::PlatformBridge::paintTextField): (WebCore::PlatformBridge::paintTrackbar): (WebCore::PlatformBridge::paintProgressBar): (WebCore::WebThemePart): (WebCore::WebThemeState): (WebCore::GetWebThemeExtraParams): (WebCore::PlatformBridge::getThemePartSize): (WebCore::PlatformBridge::paintThemePart): (WebCore::PlatformBridge::traceEventBegin): (WebCore::PlatformBridge::traceEventEnd): (WebCore::PlatformBridge::visitedLinkHash): (WebCore::PlatformBridge::isLinkVisited): (WebCore::PlatformBridge::notifyJSOutOfMemory): (WebCore::PlatformBridge::memoryUsageMB): (WebCore::PlatformBridge::actualMemoryUsageMB): (WebCore::PlatformBridge::screenDepth): (WebCore::PlatformBridge::screenDepthPerComponent): (WebCore::PlatformBridge::screenIsMonochrome): (WebCore::PlatformBridge::screenRect): (WebCore::PlatformBridge::screenAvailableRect): (WebCore::PlatformBridge::popupsAllowed): (WebCore::WorkerContextProxy::create):
- src/ResourceHandle.cpp: (WebCore::ResourceHandle::cacheMetadata):
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::WebFrameImpl): (WebKit::WebFrameImpl::~WebFrameImpl):
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
- 3:23 AM Changeset in webkit [76339] by
-
- 2 edits1 add in trunk/Tools
2011-01-21 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Split Host object off from WebKitPatch for easier re-use
https://bugs.webkit.org/show_bug.cgi?id=52284
new-run-webkit-tests and other tools are eventually going to want one of these.
Basically you need to inherit from this class if you want to pretend to be a
self.tool object for Steps/Commands.
- Scripts/webkitpy/common/host.py: Added.
- Scripts/webkitpy/tool/main.py:
- 3:14 AM Changeset in webkit [76338] by
-
- 1 edit3 adds in trunk/LayoutTests
2011-01-21 Helder Correia <helder@sencha.com>
Reviewed by Andreas Kling.
[Qt] svg/css/text-gradient-shadow.svg needs expected results
https://bugs.webkit.org/show_bug.cgi?id=52724
- platform/qt/svg/css/text-gradient-shadow-expected.checksum: Added.
- platform/qt/svg/css/text-gradient-shadow-expected.png: Added.
- platform/qt/svg/css/text-gradient-shadow-expected.txt: Added.
- 2:06 AM Changeset in webkit [76337] by
-
- 6 edits in trunk/Source/WebCore
2011-01-21 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r76335.
http://trac.webkit.org/changeset/76335
https://bugs.webkit.org/show_bug.cgi?id=52875
profiler tests were broken (Requested by loislo on #webkit).
- inspector/InspectorController.cpp: (WebCore::InspectorController::addProfile): (WebCore::InspectorController::getCurrentUserInitiatedProfileName):
- inspector/InspectorController.h:
- inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsoleImpl):
- inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsole): (WebCore::InspectorInstrumentation::inspectorControllerWithFrontendForPage):
- page/Console.cpp: (WebCore::Console::profile): (WebCore::Console::profileEnd):
- 1:34 AM Changeset in webkit [76336] by
-
- 7 edits in trunk/LayoutTests
2011-01-21 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Make userscripts/window-onerror-for-isolated-world-*.html give consistent output
https://bugs.webkit.org/show_bug.cgi?id=52870
Call setTimeout from "load" event listener to make sure exception in the setTimeout
callback happens after the one in the listener.
- platform/chromium/userscripts/window-onerror-for-isolated-world-1-expected.txt:
- platform/chromium/userscripts/window-onerror-for-isolated-world-2-expected.txt:
- userscripts/window-onerror-for-isolated-world-1-expected.txt:
- userscripts/window-onerror-for-isolated-world-1.html:
- userscripts/window-onerror-for-isolated-world-2-expected.txt:
- userscripts/window-onerror-for-isolated-world-2.html:
- 1:24 AM Changeset in webkit [76335] by
-
- 6 edits in trunk/Source/WebCore
2011-01-21 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: switch page/Console implementation from InspectorController to InspectorInstrumentation.
There are some places in WebCore where we still using direct InspectorController calls.
The idea is to pass all the Inspector related calls via InspectorInstrumentaion which is the
Inspector facade for WebCore.
- inspector/InspectorController.cpp:
- inspector/InspectorController.h:
- inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::addProfileImpl): (WebCore::InspectorInstrumentation::profilerEnabledImpl): (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileNameImpl):
- inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::addProfile): (WebCore::InspectorInstrumentation::profilerEnabled): (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileName):
- page/Console.cpp: (WebCore::Console::profile): (WebCore::Console::profileEnd):
Jan 20, 2011:
- 10:10 PM Changeset in webkit [76334] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-01-20 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Maciej Stachowiak.
Added OwnPtrCommon.h because OwnArrayPtr::set calls deleteOwnedPtr.
- wtf/OwnArrayPtr.h:
- 9:25 PM Changeset in webkit [76333] by
-
- 2 edits in trunk/LayoutTests
2011-01-20 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
Skip a few more tests that are failing on the bots
https://bugs.webkit.org/show_bug.cgi?id=52865
- platform/mac-wk2/Skipped:
- 8:58 PM Changeset in webkit [76332] by
-
- 3 edits in trunk/Source/JavaScriptCore
2011-01-20 Patrick Gansterer <Patrick Gansterer>
Reviewed by Oliver Hunt.
[WINCE] Remove obsolete JSVALUE32 code
https://bugs.webkit.org/show_bug.cgi?id=52450
Remove the "offset hack" in create_jit_stubs, since we
only support JSVALUE32_64 in the meantime.
- create_jit_stubs: Removed offset argument
- jit/JITStubs.cpp:
- 8:07 PM Changeset in webkit [76331] by
-
- 9 edits in trunk/Source/JavaScriptCore
2011-01-20 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
When marking conservatively, guard against reviving dead objects.
https://bugs.webkit.org/show_bug.cgi?id=52840
SunSpider and v8 say no change.
- interpreter/RegisterFile.h: (JSC::RegisterFile::markCallFrames): Updated to use the ConservativeSet API.
- runtime/Heap.cpp: (JSC::Heap::recordExtraCost): No need to guard against conservative marking reviving dead objects anymore, since the conservative marking mechanism guards against this now.
(JSC::Heap::markConservatively):
(JSC::Heap::markProtectedObjects):
(JSC::Heap::markTempSortVectors): Don't drain the mark stack inside a
marking function. We want to establish a separation of concerns between
visiting roots and draining the mark stack.
(JSC::Heap::markRoots): Gather the set of conservative references before
clearning mark bits, because conservative marking now uses the mark bits
to determine if a reference is valid, and avoid reviving dead objects.
(JSC::Heap::collectAllGarbage): No need to guard against conservative
marking reviving dead objects anymore, since the conservative marking
mechanism guards against this now.
- runtime/Heap.h: Updated to use the ConservativeSet API.
- runtime/MachineStackMarker.cpp: (JSC::MachineStackMarker::markCurrentThreadConservativelyInternal): (JSC::MachineStackMarker::markCurrentThreadConservatively): (JSC::MachineStackMarker::markOtherThreadConservatively): (JSC::MachineStackMarker::markMachineStackConservatively):
- runtime/MachineStackMarker.h: Ditto.
- runtime/MarkStack.h: (JSC::ConservativeSet::add): (JSC::ConservativeSet::mark): Added ConservativeSet, for gathering the set of conservative references. This is different from MarkStack, since we don't mark the set until it is completely gathered.
- runtime/MarkedSpace.cpp: (JSC::MarkedSpace::freeBlock): (JSC::MarkedSpace::resizeBlocks): (JSC::MarkedSpace::markConservatively):
- runtime/MarkedSpace.h: When marking conservatively, guard against reviving dead objects.
- 7:46 PM Changeset in webkit [76330] by
-
- 2 edits in trunk/Source/WebCore
Fix failing tests from r76291.
Reviewed by Gavin Barraclough.
- platform/ScrollView.cpp:
(WebCore::ScrollView::scrollPosition):
(WebCore::ScrollView::updateScrollbars):
Take the scroll origin into account in more places.
- 7:41 PM Changeset in webkit [76329] by
-
- 2 edits in trunk/Source/WebCore
2011-01-20 Kent Tamura <tkent@chromium.org>
Unreviewed, sorting an Xcode project file.
- WebCore.xcodeproj/project.pbxproj:
- 7:34 PM Changeset in webkit [76328] by
-
- 3 edits in trunk/Websites/bugs.webkit.org
2011-01-20 Ojan Vafai <ojan@chromium.org>
Fix the review tool for image diffs. We would get a javascript error
because image diffs don't have line numbers.
- code-review.js:
- 7:29 PM Changeset in webkit [76327] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Not reviewed, add a bug number to disabled test.
- platform/chromium/test_expectations.txt:
- 7:09 PM Changeset in webkit [76326] by
-
- 2 edits in trunk/Tools
2011-01-20 Dirk Pranke <dpranke@chromium.org>
Reviewed by Adam Barth.
Disable the tests that start and stop the http server and web
server, so that we don't have to worry about port collisions on
the bots.
- Scripts/webkitpy/layout_tests/port/port_testcase.py:
- 6:40 PM Changeset in webkit [76325] by
-
- 2 edits in trunk/LayoutTests
2011-01-20 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin Adler.
Skip some tests that are failing on the WebKit2 bot
https://bugs.webkit.org/show_bug.cgi?id=52858
- platform/mac-wk2/Skipped: skip or re-skip some tests that fail on the bot for various reasons.
- 6:35 PM Changeset in webkit [76324] by
-
- 20 edits3 copies in trunk/Source/WebCore
2011-01-20 Ben Vanik <ben.vanik@gmail.com>
Reviewed by Kenneth Russell.
Implementation of the OES_standard_derivatives WebGL extension.
https://bugs.webkit.org/show_bug.cgi?id=51678
Changes are modeled off of the existing OESTextureFloat extension. New files,
extension retrieval, etc all match the existing code.
Changed ANGLEWebKitBridge to allow for multiple sets of the ANGLE shader compiler
options. This supports the enabling of the standard derivatives flag when the
extension is enabled. Refactored the cleanup code to make the destruction of the
compilers (if they had been created) cleaner.
Tested with the WebGL conformance test:
https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/sdk/tests/conformance/oes-standard-derivatives.html
Passes on WebKit/OSX, Chromium/OSX, and Chromium/Windows.
- CMakeLists.txt:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pri:
- WebCore.pro:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSWebGLRenderingContextCustom.cpp: (WebCore::toJS):
- bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::toV8Object):
- html/canvas/OESStandardDerivatives.cpp: Added. (WebCore::OESStandardDerivatives::OESStandardDerivatives): (WebCore::OESStandardDerivatives::~OESStandardDerivatives): (WebCore::OESStandardDerivatives::getName): (WebCore::OESStandardDerivatives::create):
- html/canvas/OESStandardDerivatives.h: Added.
- html/canvas/OESStandardDerivatives.idl: Added.
- html/canvas/WebGLExtension.h:
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getExtension): Enable and return the new extension. (WebCore::WebGLRenderingContext::getParameter): Support extension enum when enabled. (WebCore::WebGLRenderingContext::getSupportedExtensions): (WebCore::WebGLRenderingContext::hint): Validate extension enum when enabled. (WebCore::WebGLRenderingContext::getNumberOfExtensions): (WebCore::WebGLRenderingContext::getExtensionNumber):
- html/canvas/WebGLRenderingContext.h:
- platform/graphics/ANGLEWebKitBridge.cpp: (WebCore::ANGLEWebKitBridge::~ANGLEWebKitBridge): Cleaned up compiler cleanup. (WebCore::ANGLEWebKitBridge::cleanupCompilers): Destruct compilers. (WebCore::ANGLEWebKitBridge::setResources): Cleanup existing compilers when changing ANGLE settings. (WebCore::ANGLEWebKitBridge::validateShaderSource): Cleaned up compiler cleanup on error.
- platform/graphics/ANGLEWebKitBridge.h: (WebCore::ANGLEWebKitBridge::getResources):
- platform/graphics/Extensions3D.h: Added enumeration for the extension.
- platform/graphics/GraphicsContext3D.h: lumbing for GraphicsContext3D.
- platform/graphics/opengl/Extensions3DOpenGL.cpp: (WebCore::Extensions3DOpenGL::Extensions3DOpenGL): Plumbed through a pointer to the GraphicsContext3D to handle resetting the shader compilers. (WebCore::Extensions3DOpenGL::supports): Desktop GL always supports this extension, so always return true. (WebCore::Extensions3DOpenGL::ensureEnabled): Reset shader compilers as required.
- platform/graphics/opengl/Extensions3DOpenGL.h: Plumbing for GraphicsContext3D.
- platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: (WebCore::GraphicsContext3D::getExtensions): Plumbing for GraphicsContext3D to Extensions3DOpenGL.
- 6:30 PM Changeset in webkit [76323] by
-
- 2 edits in trunk/Tools
2011-01-20 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
nrwt: rewrite google_chrome_unittest to use mock filesystem.
- Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
- 6:30 PM Changeset in webkit [76322] by
-
- 18 edits in trunk/Tools
2011-01-20 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Siedel.
nrwt: clean up almost all remaining port references, remove
unnecessary import clauses. The only remaining references are
in places where a mock filesystem makes no sense or can't be
used, and in one routine in port/google_chrome_unittest that
I'll rewrite in a separate patch.
- Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
- Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
- Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
- Scripts/webkitpy/layout_tests/port/chromium_linux.py:
- Scripts/webkitpy/layout_tests/port/chromium_mac.py:
- Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
- Scripts/webkitpy/layout_tests/port/chromium_win.py:
- Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
- Scripts/webkitpy/layout_tests/port/google_chrome.py:
- Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
- Scripts/webkitpy/layout_tests/port/gtk.py:
- Scripts/webkitpy/layout_tests/port/mac.py:
- Scripts/webkitpy/layout_tests/port/port_testcase.py:
- Scripts/webkitpy/layout_tests/port/qt.py:
- Scripts/webkitpy/layout_tests/port/webkit.py:
- Scripts/webkitpy/layout_tests/port/win.py:
- Scripts/webkitpy/layout_tests/test_types/image_diff.py:
- 6:26 PM Changeset in webkit [76321] by
-
- 3 edits in trunk/Tools
2011-01-20 Dirk Pranke <dpranke@chromium.org>
Reviewed by Mihai Parparita.
remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 6:18 PM Changeset in webkit [76320] by
-
- 2 edits in trunk/LayoutTests
Unreviewed Qt Skipped list update.
Skip the test added in r76296 for platform/qt/.
- platform/qt/Skipped:
- 6:09 PM Changeset in webkit [76319] by
-
- 3 edits4 adds in trunk
2011-01-20 Xiaomei Ji <xji@chromium.org>
Reviewed by Dan Bernstein.
Fix regression(r71566): PDF in RTL block might messes up text directionality.
https://bugs.webkit.org/show_bug.cgi?id=52776
Test: fast/dom/52776.html
- platform/text/BidiResolver.h: (WebCore::::checkDirectionInLowerRaiseEmbeddingLevel): (WebCore::::lowerExplicitEmbeddingLevel): (WebCore::::raiseExplicitEmbeddingLevel): (WebCore::::createBidiRunsForLine):
2011-01-20 Xiaomei Ji <xji@chromium.org>
Reviewed by Dan Bernstein.
Fix regression(r71566): PDF in RTL block might messes up text directionality.
https://bugs.webkit.org/show_bug.cgi?id=52776
- fast/dom/52776.html: Added.
- platform/mac/fast/dom/52776-expected.checksum: Added.
- platform/mac/fast/dom/52776-expected.png: Added.
- platform/mac/fast/dom/52776-expected.txt: Added.
- 5:59 PM Changeset in webkit [76318] by
-
- 2 edits in trunk/Source/WebCore
Follow-on for <rdar://problem/8890255>
Reviewed by Anders Carlsson.
This fixes a painting error with ScrollbarPainter scrollers
and the new drawing area code path.
- platform/mac/ScrollbarThemeMac.mm:
(WebCore::updateArrowPlacement):
- 5:43 PM Changeset in webkit [76317] by
-
- 2 edits in trunk/LayoutTests
[chromium] Updating test expectations after fixing the bug:
https://bugs.webkit.org/show_bug.cgi?id=52062
Patch by Jenn Braithwaite <jennb@chromium.org> on 2011-01-20
Reviewed by Dmitry Titov.
- platform/chromium/test_expectations.txt:
iframe-reparenting-plugins.html is now passing on Windows.
- 5:40 PM Changeset in webkit [76316] by
-
- 2 edits5 adds in trunk/LayoutTests
2011-01-20 Tony Chang <tony@chromium.org>
Unreviewed, rebaseline a test added in
http://trac.webkit.org/changeset/76274
- platform/chromium-linux/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.checksum: Added.
- platform/chromium-linux/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.png: Added.
- platform/chromium-win/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.checksum: Added.
- platform/chromium-win/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.png: Added.
- platform/chromium-win/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 5:31 PM Changeset in webkit [76315] by
-
- 2 edits in trunk/Source/WebCore
2011-01-20 Levi Weintraub <leviw@chromium.org>
Unreviewed.
Fixing build breakage.
- editing/SelectionController.cpp: (WebCore::SelectionController::willBeModified):
- 5:28 PM Changeset in webkit [76314] by
-
- 2 edits in trunk/Tools
2011-01-20 Tony Chang <tony@chromium.org>
Reviewed by Ojan Vafai.
[chromium] fix the paths used for the rebaseline tool
https://bugs.webkit.org/show_bug.cgi?id=52857
Some of the bots were renamed so the path to grab the results zip
file has changed.
- Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
- 5:22 PM Changeset in webkit [76313] by
-
- 2 edits in trunk
2011-01-20 Siddharth Mathur <siddharth.mathur@nokia.com>
Reviewed by Laszlo Gombos.
[Qt][Symbian] Smaller debug symbol size when using RVCT 4.x
https://bugs.webkit.org/show_bug.cgi?id=52835
- WebKit.pri: Use --remove_unneeded_entities for RVCT 4.x compilers
- 5:21 PM Changeset in webkit [76312] by
-
- 4 edits2 adds in trunk
2011-01-20 Levi Weintraub <leviw@chromium.org>
Reviewed by Ryosuke Niwa.
RTL: Caret goes to the opposite direction when pressing an arrow key after selection is made
https://bugs.webkit.org/show_bug.cgi?id=49511
Test: editing/selection/rtl-move-selection-right-left.html
- editing/SelectionController.cpp: (WebCore::SelectionController::willBeModified): Respecting the direction of the containing block when switching selection base and extent in RTL content.
(WebCore::SelectionController::modifyMovingRight):
(WebCore::SelectionController::modifyMovingLeft):
Using directionOfEnclosingBlock when deciding to use the selection start or end to do the
correct thing for RTL.
2011-01-20 Levi Weintraub <leviw@chromium.org>
Reviewed by Ryosuke Niwa.
RTL: Caret goes to the opposite direction when pressing an arrow key after selection is made
https://bugs.webkit.org/show_bug.cgi?id=49511
- editing/editing.js: (execMoveSelectionLeftByCharacterCommand): (moveSelectionLeftByCharacterCommand): (execMoveSelectionRightByCharacterCommand): (moveSelectionRightByCharacterCommand): (execExtendSelectionLeftByCharacterCommand): (extendSelectionLeftByCharacterCommand): (execExtendSelectionRightByCharacterCommand): (extendSelectionRightByCharacterCommand): Adding some left/right selection convenience methods for use with RTL tests.
- editing/selection/rtl-move-selection-right-left-expected.txt: Added.
- editing/selection/rtl-move-selection-right-left.html: Added.
- 5:06 PM Changeset in webkit [76311] by
-
- 3 edits in trunk/Tools
2011-01-20 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
Fix bug introduced in r72688 / bug 52768 that broke the
generation of the output filename links in the results.html
output. Apparently none of the unit tests actually checked to
make sure the generated links were correct :(
- Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
- Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
- 4:58 PM Changeset in webkit [76310] by
-
- 3 edits in trunk/Websites/bugs.webkit.org
2011-01-20 Ojan Vafai <ojan@chromium.org>
Reviewed by Oliver Hunt.
Could review tool include style failure info?
https://bugs.webkit.org/show_bug.cgi?id=49049
This does not handle patches that have old paths (e.g. without the Source prefix).
Although that would be fairly straightforward to workaround.
- code-review.js:
- 4:33 PM Changeset in webkit [76309] by
-
- 3 edits2 adds in tags/Safari-534.15.17
Merge r76296.
- 4:33 PM Changeset in webkit [76308] by
-
- 5 edits in tags/Safari-534.15.17
Versioning.
- 4:22 PM Changeset in webkit [76307] by
-
- 2 edits in trunk/LayoutTests
2011-01-20 Tony Chang <tony@chromium.org>
Unreviewed, mark some rtl scrolling tests as failing to green the chromium bots.
- platform/chromium/test_expectations.txt:
- 4:19 PM Changeset in webkit [76306] by
-
- 12 edits in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=52849
Make window.print work with WebKit2
- UIProcess/API/qt/qwkpage.cpp: (QWKPage::QWKPage):
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::printFrame):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::printFrame):
- UIProcess/WebUIClient.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::print): Just pass through deelagte call to a WebKit2 client.
- UIProcess/API/C/WKPage.h: Also added "Callback" suffix to other printing related function types.
- 4:13 PM Changeset in webkit [76305] by
-
- 5 edits in trunk/Source/WebKit2
2011-01-20 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Keep track of the latest update timestamp in the backing store
https://bugs.webkit.org/show_bug.cgi?id=52848
- Shared/UpdateInfo.h: (WebKit::UpdateInfo::UpdateInfo): Initialize timestamp to 0.
- UIProcess/BackingStore.cpp: (WebKit::BackingStore::BackingStore): Initialize m_latestUpdateTimestamp to 0.
(WebKit::BackingStore::incorporateUpdate):
If the update is too old, discard it. Otherwise, create a bitmap
and pass it to platformIncorporateUpdate. Finally update the timestamp.
- UIProcess/BackingStore.h: Add m_latestUpdateTimestamp.
- UIProcess/mac/BackingStoreMac.mm: (WebKit::BackingStore::platformIncorporateUpdate): Update now that we are already given the shareable bitmap.
- 4:08 PM Changeset in webkit [76304] by
-
- 3 edits in trunk/LayoutTests
2011-01-20 Tony Chang <tony@chromium.org>
Unreviewed, chromium test expectation updates.
- platform/chromium-gpu/test_expectations.txt:
- platform/chromium/test_expectations.txt:
- 4:05 PM Changeset in webkit [76303] by
-
- 3 edits3 adds in trunk
2011-01-20 Nate Chapin <Nate Chapin>
Reviewed by Adam Barth.
- fast/dom/Window/Location/resources/set-location-after-close-new-window.html: Added.
- fast/dom/Window/Location/set-location-after-close-expected.txt: Added.
- fast/dom/Window/Location/set-location-after-close.html: Added.
2011-01-20 Nate Chapin <Nate Chapin>
Reviewed by Adam Barth.
Null-check m_frame in DOMWindow::setLocation(), since it's
possible to reach this point without it having been checked
already.
https://bugs.webkit.org/show_bug.cgi?id=52769
Test: fast/dom/Window/Location/set-location-after-close.html
- page/DOMWindow.cpp: (WebCore::DOMWindow::setLocation):
- 4:04 PM Changeset in webkit [76302] by
-
- 3 edits in trunk/Websites/bugs.webkit.org
2011-01-20 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
handle cases where PrettyPatch.rb doesn't linkify filenames
https://bugs.webkit.org/show_bug.cgi?id=52834
- code-review.js:
- 3:57 PM Changeset in webkit [76301] by
-
- 11 edits in trunk
2011-01-20 Chang Shu <chang.shu@nokia.com>
Reviewed by Darin Adler.
setContentEditable with invalid string should throw exception.
https://bugs.webkit.org/show_bug.cgi?id=52057
Updated expected results after the fix. Also corrected test cases.
- editing/editability/set-invalid-value-expected.txt:
- editing/editability/set-invalid-value.html: 1. Fixed the getAttribute expectation as "abc" was failed to set. 2. Added additional check for setting empty string.
- editing/editability/set-value-caseinsensitive-expected.txt:
- editing/editability/set-value-caseinsensitive.html: Fixed the getAttribute expectations as all strings should be converted to lower cases.
- fast/dom/element-attribute-js-null-expected.txt:
- fast/dom/element-attribute-js-null.html: Fixed this existing test as the expectation for setting with null should throw exception instead of "false". Also added handling code when exception was thrown.
2011-01-20 Chang Shu <chang.shu@nokia.com>
Reviewed by Darin Adler.
setContentEditable with invalid string should throw exception.
https://bugs.webkit.org/show_bug.cgi?id=52057
Implemented exception throwing for setContentEditable according to the following spec:
http://www.whatwg.org/specs/web-apps/current-work/multipage/editing.html#attr-contenteditable
Related quotas: "On setting, if the new value is an ASCII case-insensitive match for the
string 'inherit' then the content attribute must be removed, if the new value is an ASCII
case-insensitive match for the string 'true' then the content attribute must be set to the
string 'true', if the new value is an ASCII case-insensitive match for the string 'false'
then the content attribute must be set to the string 'false', and otherwise the attribute
setter must raise a SYNTAX_ERR exception."
- html/HTMLElement.cpp: (WebCore::HTMLElement::setContentEditable): Throw exception on invalid input strings; Make setting values case-insensitive and also convert them to lower cases according to the spec.
- html/HTMLElement.h: Add additional parameter ExceptionCode& for function setContentEditable.
- html/HTMLElement.idl: Add exception throwing support for contentEditable setter.
- 3:55 PM Changeset in webkit [76300] by
-
- 3 edits in trunk/Source/WebKit/mac
Shift-tab doesn't cycle through fields in http authentication panel
https://bugs.webkit.org/show_bug.cgi?id=52850
Reviewed by Mark Rowe.
- Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
- Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:
Re-wired the key loop so that there aren't two views with the same nextKeyView.
- 3:53 PM Changeset in webkit [76299] by
-
- 3 edits7 adds in trunk
2011-01-20 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] Add a test for a render surface that the uses alpha channel.
https://bugs.webkit.org/show_bug.cgi?id=52766
- platform/chromium-gpu/platform/chromium/compositing/render-surface-alpha-blending-expected.checksum: Added.
- platform/chromium-gpu/platform/chromium/compositing/render-surface-alpha-blending-expected.png: Added.
- platform/chromium-gpu/platform/chromium/compositing/render-surface-alpha-blending-expected.txt: Added.
- platform/chromium/compositing/render-surface-alpha-blending.html: Added.
2011-01-19 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] Composited render surfaces should allow writes to alpha channel.
https://bugs.webkit.org/show_bug.cgi?id=52766
Test: LayoutTests/platform/chromium/compositing
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayers):
- 3:49 PM Changeset in webkit [76298] by
-
- 1 copy in tags/Safari-534.15.17
New tag.
- 3:49 PM Changeset in webkit [76297] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-01-20 Siddharth Mathur <siddharth.mathur@nokia.com>
Reviewed by Geoffrey Garen.
[Symbian] Fix StackBounds::initialize()
https://bugs.webkit.org/show_bug.cgi?id=52842
- wtf/StackBounds.cpp: (WTF::StackBounds::initialize): Use TThreadStackInfo.iLimit for stack limit
- 3:45 PM Changeset in webkit [76296] by
-
- 3 edits2 adds in trunk
2011-01-14 Jer Noble <jer.noble@apple.com>
Reviewed by Eric Carlson.
REGRESSION (r71842): Compass video is not playing in Safari welcome page
https://bugs.webkit.org/show_bug.cgi?id=52506
Test that a delay between loading and playing video does not break playback.
- media/video-currentTime-delay-expected.txt: Added.
- media/video-currentTime-delay.html: Added.
2011-01-14 Jer Noble <jer.noble@apple.com>
Reviewed by Eric Carlson.
REGRESSION (r71842): Compass video is not playing in Safari welcome page
https://bugs.webkit.org/show_bug.cgi?id=52506
New test: LayoutTests/media/video-currentTime-delay.html
Call invalidateCachedTime() every time one of the cached property dependencies changes,
i.e. m_paused and m_playbackRate.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::prepareForLoad): (WebCore::HTMLMediaElement::setReadyState): (WebCore::HTMLMediaElement::setPlaybackRate): (WebCore::HTMLMediaElement::mediaPlayerRateChanged):
- 3:41 PM Changeset in webkit [76295] by
-
- 2 edits in trunk/Source/WebKit/qt
Fix build.
- Api/qwebframe.cpp:
(QWebFrame::setScrollBarValue):
- 3:37 PM Changeset in webkit [76294] by
-
- 3 edits in trunk/Source/WebKit/chromium
2011-01-20 Adam Klein <adamk@chromium.org>
Reviewed by Andreas Kling.
[chromium] Remove deprecated WebKit::nameOfInputElement function
https://bugs.webkit.org/show_bug.cgi?id=52824
- src/DOMUtilitiesPrivate.cpp:
- src/DOMUtilitiesPrivate.h:
- 3:19 PM Changeset in webkit [76293] by
-
- 2 edits in trunk/Source/WebKit/qt
Fix build.
- Api/qwebframe.cpp:
(QWebFrame::setScrollBarValue):
- 3:18 PM Changeset in webkit [76292] by
-
- 9 edits in trunk/Source
Fix for <rdar://problem/8890255>
Reviewed by Geoffrey Garen.
Source/WebCore:
Allow WebKitSystemInterface to draw scrollbars
when appropriate.
- WebCore.exp.in:
- platform/mac/ScrollbarThemeMac.mm:
(WebCore::scrollbarMap):
(+[ScrollbarPrefsObserver appearancePrefsChanged:]):
(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::unregisterScrollbar):
(WebCore::ScrollbarThemeMac::paint):
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
Source/WebKit/mac:
Allow WebKitSystemInterface to draw scrollbars
when appropriate.
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
Source/WebKit2:
Allow WebKitSystemInterface to draw scrollbars
when appropriate.
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
- 3:14 PM Changeset in webkit [76291] by
-
- 38 edits in trunk/Source
Cleanup Scrollbar/ScrollbarClient relationship
https://bugs.webkit.org/show_bug.cgi?id=52779
Reviewed by Dave Hyatt.
Source/WebCore:
Pipe all scrolling through the ScrollbarClient/ScrollAnimator
rather than through the Scrollbar. The Scrollbar now is just
a "view" on the scroll position of the scrollable area it is
attached to.
There are now two ways to scroll a scrollable area:
- ScrollbarClient::scroll()
- ScrollbarClient::scrollToOffsetWithoutAnimation()
Both of these go through the ScrollAnimator (updating its state
or starting an animation). The ScrollAnimator, in turn, now calls
ScrollbarClient::setScrollOffsetFromAnimation, which tells the
Scrollbars to pull a new offset (via Scrollbar::offsetDidChange)
and tells the class that derives from ScrollbarClient to scroll
its contents (via ScrollbarClient::setScrollOffset).
- WebCore.xcodeproj/project.pbxproj:
Move Scrollbar.cpp to the right place.
- accessibility/AccessibilityScrollbar.cpp:
(WebCore::AccessibilityScrollbar::setValue):
Initiate the scroll through the scrollbar client, rather than the
scrollbar itself.
- page/FrameView.cpp:
(WebCore::FrameView::scrollTo):
- page/FrameView.h:
Condense the two valueChanged overrides to a single override of the
scrollTo function.
- platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::scroll):
(WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimator::currentPosition):
(WebCore::ScrollAnimator::notityPositionChanged):
- platform/ScrollAnimator.h:
- platform/ScrollAnimatorWin.cpp:
(WebCore::ScrollAnimatorWin::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorWin::animateScroll):
- platform/ScrollAnimatorWin.h:
- platform/mac/ScrollAnimatorMac.h:
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorMac::immediateScrollToPoint):
Change setScrollPositionAndStopAnimation to scrollToOffsetWithoutAnimation
and bottleneck all client notification of changed position through a new
notityPositionChanged() function.
- platform/ScrollView.cpp:
(WebCore::ScrollView::setScrollOffset):
(WebCore::ScrollView::scrollTo):
(WebCore::ScrollView::scrollPosition):
(WebCore::ScrollView::scroll):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::wheelEvent):
- platform/ScrollView.h:
(WebCore::ScrollView::horizontalScrollbar):
(WebCore::ScrollView::verticalScrollbar):
Update to scroll via the ScrollbarClient rather than the Scrollbar.
- platform/Scrollbar.cpp:
(WebCore::Scrollbar::offsetDidChange):
(WebCore::Scrollbar::autoscrollPressedPart):
(WebCore::Scrollbar::moveThumb):
(WebCore::Scrollbar::mouseMoved):
- platform/Scrollbar.h:
(WebCore::Scrollbar::setPressedPos):
Change the scrollbar to only updates its offset in response to
an offsetDidChange call.
- platform/ScrollbarClient.cpp:
(WebCore::ScrollbarClient::scroll):
(WebCore::ScrollbarClient::scrollToOffsetWithoutAnimation):
(WebCore::ScrollbarClient::scrollToXOffsetWithoutAnimation):
(WebCore::ScrollbarClient::scrollToYOffsetWithoutAnimation):
(WebCore::ScrollbarClient::setScrollOffsetFromAnimation):
- platform/ScrollbarClient.h:
(WebCore::ScrollbarClient::horizontalScrollbar):
(WebCore::ScrollbarClient::verticalScrollbar):
Make the increasingly misnamed ScrollbarClient responsible for
scrolling.
- platform/efl/ScrollbarEfl.cpp:
(scrollbarEflEdjeMessage):
- platform/gtk/MainFrameScrollbarGtk.cpp:
(MainFrameScrollbarGtk::gtkValueChanged):
- platform/qt/ScrollbarQt.cpp:
(WebCore::Scrollbar::contextMenu):
Update to move scrolling through the client.
- platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::scrollToRevealSelection):
(WebCore::PopupMenuWin::scrollPosition):
(WebCore::PopupMenuWin::setScrollOffset):
(WebCore::PopupMenuWin::scrollTo):
(WebCore::PopupMenuWin::wndProc):
- platform/win/PopupMenuWin.h:
(WebCore::PopupMenuWin::verticalScrollbar):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollToOffset):
(WebCore::RenderLayer::scrollTo):
(WebCore::RenderLayer::setScrollOffset):
(WebCore::RenderLayer::scrollPosition):
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
(WebCore::RenderLayer::scroll):
- rendering/RenderLayer.h:
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::scrollToRevealElementAtListIndex):
(WebCore::RenderListBox::scroll):
(WebCore::RenderListBox::logicalScroll):
(WebCore::RenderListBox::scrollPosition):
(WebCore::RenderListBox::setScrollOffset):
(WebCore::RenderListBox::scrollTo):
(WebCore::RenderListBox::setScrollTop):
- rendering/RenderListBox.h:
(WebCore::RenderListBox::verticalScrollbar):
Update to scroll via the ScrollbarClient rather than the Scrollbar.
- rendering/RenderMarquee.cpp:
(WebCore::RenderMarquee::start):
Simplify initial paint to just do an immediate scroll to the position.
Source/WebKit/chromium:
- src/WebScrollbarImpl.cpp:
(WebKit::WebScrollbarImpl::WebScrollbarImpl):
(WebKit::WebScrollbarImpl::value):
(WebKit::WebScrollbarImpl::setValue):
(WebKit::WebScrollbarImpl::scroll):
(WebKit::WebScrollbarImpl::onMouseDown):
(WebKit::WebScrollbarImpl::onMouseMove):
(WebKit::WebScrollbarImpl::onMouseWheel):
(WebKit::WebScrollbarImpl::onKeyDown):
(WebKit::WebScrollbarImpl::scrollPosition):
(WebKit::WebScrollbarImpl::setScrollOffset):
- src/WebScrollbarImpl.h:
Source/WebKit/qt:
- Api/qwebframe.cpp:
(QWebFrame::setScrollBarValue):
Source/WebKit/win:
- WebScrollBar.cpp:
(WebScrollBar::WebScrollBar):
(WebScrollBar::setValue):
(WebScrollBar::value):
(WebScrollBar::scroll):
(WebScrollBar::scrollPosition):
(WebScrollBar::setScrollOffset):
- WebScrollBar.h:
Source/WebKit2:
- UIProcess/win/WebPopupMenuProxyWin.cpp:
(WebKit::WebPopupMenuProxyWin::scrollPosition):
(WebKit::WebPopupMenuProxyWin::setScrollOffset):
(WebKit::WebPopupMenuProxyWin::scrollTo):
(WebKit::WebPopupMenuProxyWin::onMouseWheel):
(WebKit::WebPopupMenuProxyWin::scrollToRevealSelection):
- UIProcess/win/WebPopupMenuProxyWin.h:
(WebKit::WebPopupMenuProxyWin::verticalScrollbar):
- 3:14 PM Changeset in webkit [76290] by
-
- 2 edits in trunk/LayoutTests
2011-01-20 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed Chromium test expectations fix.
- platform/chromium/test_expectations.txt:
- 3:10 PM Changeset in webkit [76289] by
-
- 2 edits in trunk/LayoutTests
2011-01-20 Tony Chang <tony@chromium.org>
Unreviewed, another attempt at making the chromium gpu tests go green.
- platform/chromium-gpu/test_expectations.txt:
- 3:05 PM Changeset in webkit [76288] by
-
- 7 edits in trunk/Tools
2011-01-20 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
- Scripts/webkitpy/layout_tests/layout_package/printing.py:
- Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
- Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
- Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
- Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
- Scripts/webkitpy/layout_tests/test_types/text_diff.py:
- 2:53 PM Changeset in webkit [76287] by
-
- 2 edits in trunk/LayoutTests
2011-01-20 James Robinson <jamesr@chromium.org>
Update expectations for tests that need chromium-side changes.
- platform/chromium/test_expectations.txt:
- 2:50 PM Changeset in webkit [76286] by
-
- 2 edits in trunk/Tools
2011-01-20 Mansi Mithal <mansi.mithal@nokia.com>
Reviewed by Antonio Gomes.
QtTestBrowser should have a seperate menu for Settings
https://bugs.webkit.org/show_bug.cgi?id=52817
Added a new menu item named "Settings"
and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu
- QtTestBrowser/launcherwindow.cpp: (LauncherWindow::createChrome):
- 2:48 PM Changeset in webkit [76285] by
-
- 4 edits in trunk/Source/WebKit2
2011-01-20 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
Add a timestamp to UpdateInfo
https://bugs.webkit.org/show_bug.cgi?id=52844
- Shared/UpdateInfo.cpp: (WebKit::UpdateInfo::encode): (WebKit::UpdateInfo::decode):
- Shared/UpdateInfo.h:
- WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::setSize): (WebKit::DrawingAreaImpl::display):
- 2:44 PM Changeset in webkit [76284] by
-
- 2 edits in trunk/LayoutTests
2011-01-20 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed Chromium test expectation update.
Merged test_expectations.txt in the Chromium tree and
added slow to fast/text/large-text-composed-char-dos.html.
- platform/chromium/test_expectations.txt:
- 2:30 PM Changeset in webkit [76283] by
-
- 2 edits in trunk/LayoutTests
2011-01-20 Tony Chang <tony@chromium.org>
Unreviewed, updating gpu expectations.
These two tests were added to the regular chromiumg test_expectations.txt
in r76228.
- platform/chromium-gpu/test_expectations.txt:
- 2:12 PM Changeset in webkit [76282] by
-
- 3 edits in trunk/Source/WebCore
2011-01-20 Patrick Gansterer <Patrick Gansterer>
Unreviewed WinCE build fix for r76170.
- platform/graphics/wince/FontWinCE.cpp: Added a missing include.
- platform/graphics/wince/ImageBufferData.h: Added a missing include and fixed style.
- 2:07 PM Changeset in webkit [76281] by
-
- 2 edits in trunk/Tools
Update update-webkit-localizable-strings with new path to WebKit.
Reviewed by John Sullivan.
- Scripts/update-webkit-localizable-strings:
- 2:04 PM Changeset in webkit [76280] by
-
- 2 edits in trunk/Source/WebKit2
2011-01-20 Anders Carlsson <andersca@apple.com>
Reviewed by Beth Dakin.
Add Connection::waitForAndDispatchImmediately
https://bugs.webkit.org/show_bug.cgi?id=52841
- Platform/CoreIPC/Connection.h: (CoreIPC::Connection::waitForAndDispatchImmediately):
- 2:01 PM Changeset in webkit [76279] by
-
- 1 edit3 adds in trunk/LayoutTests
2011-01-20 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed; Another Chromium rebaseline for r76236.
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.checksum: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png: Added.
- platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.checksum: Added.
- 1:50 PM Changeset in webkit [76278] by
-
- 32 edits12 adds in trunk
2011-01-20 James Robinson <jamesr@chromium.org>
Reviewed by Darin Fisher.
Implement mozilla's requestAnimationFrame API
https://bugs.webkit.org/show_bug.cgi?id=51218
Tests for window.webkitRequestAnimationFrame(). The new tests
are in the Skipped lists for platforms that do not set
ENABLE(REQUEST_ANIMATION_FRAME) - which is currently all but chromium.
- fast/animation/request-animation-frame-cancel-expected.txt: Added.
- fast/animation/request-animation-frame-cancel.html: Added.
Tests cancelling a callback within a webkitRequestAnimationFrame() callback.
- fast/animation/request-animation-frame-cancel2-expected.txt: Added.
- fast/animation/request-animation-frame-cancel2.html: Added.
Tests interactions between multiple webkitRequestAnimationFrame() callbacks.
- fast/animation/request-animation-frame-display-expected.txt: Added.
- fast/animation/request-animation-frame-display.html: Added.
Tests changing the display: property of an element within a callback.
- fast/animation/request-animation-frame-expected.txt: Added.
- fast/animation/request-animation-frame.html: Added.
Tests the basic use of window.webkitRequestAnimationFrame().
- fast/animation/request-animation-frame-within-callback-expected.txt: Added.
- fast/animation/request-animation-frame-within-callback.html: Added.
Tests setting one webkit.webkitRequestAnimationFrame() callback within another.
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
2011-01-20 James Robinson <jamesr@chromium.org>
Reviewed by Darin Fisher.
Implement mozilla's requestAnimationFrame API
https://bugs.webkit.org/show_bug.cgi?id=51218
This implements mozilla's proposed requestAnimationFrame API. The idea with this API is that
an author driving an animation from script could use window.requestAnimationFrame(callback)
instead of window.setTimeout(callback, 0) to schedule their update logic and let the browser
decide when to update the animations. This avoids doing unnecessary work when the page content
is offscreen or is being displayed at a different framerate than what the page author expects.
Mozilla's proposal is here: https://developer.mozilla.org/en/DOM/window.mozRequestAnimationFrame
This implements window.mozRequestAnimationFrame as window.webkitRequestAnimationFrame with the
following changes:
*) Only the callback syntax is supported, there is no before paint event
*) webkitRequestAnimationFrame supports a second parameter Element to let the author indicate
what content they intend to animate. That way if the page is being displayed but the element
in question is offscreen, we can avoid invoking the callback.
*) No timestamp is provided to the caller and there is no window.animationStartTime property
(see https://bugs.webkit.org/show_bug.cgi?id=51952 for discussion of this property)
*) window.webkitRequestAnimationFrame returns a numerical id that can be used to cancel the callback
using window.cancelWebkitRequestAnimationFrame, to parallel window.setTimeout()/window.clearTime().
The implementation depends on the embedder scheduling the callbacks since the callback invocation
depends on the page's visibility and the embedder's paint scheduling, neither of which are exposed
to WebCore. The expectation for the embedder is that at some point Chrome::scheduleAnimation() is
called FrameView::serviceScriptedAnimations() should be called for the associated Page's main frame.
Ideally serviceScriptedAnimations() would be called prior to rendering - although in practice the
embedder has to rate limit callbacks and may not be able to tie the callback directly to the
rendering loop.
Tests: fast/animation/request-animation-frame-cancel.html
fast/animation/request-animation-frame-cancel2.html
fast/animation/request-animation-frame-display.html
fast/animation/request-animation-frame-within-callback.html
fast/animation/request-animation-frame.html
- WebCore.gypi:
- dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::webkitRequestAnimationFrame): (WebCore::Document::webkitCancelRequestAnimationFrame): (WebCore::Document::serviceScriptedAnimations):
- dom/Document.h:
- dom/RequestAnimationFrameCallback.h: Added. (WebCore::RequestAnimationFrameCallback::~RequestAnimationFrameCallback):
- dom/RequestAnimationFrameCallback.idl: Added.
- loader/EmptyClients.h: (WebCore::EmptyChromeClient::scheduleAnimation):
- page/Chrome.cpp: (WebCore::Chrome::scheduleAnimation):
- page/Chrome.h:
- page/ChromeClient.h:
- page/DOMWindow.cpp: (WebCore::DOMWindow::webkitRequestAnimationFrame): (WebCore::DOMWindow::webkitCancelRequestAnimationFrame):
- page/DOMWindow.h:
- page/DOMWindow.idl:
- page/FrameView.cpp: (WebCore::FrameView::scheduleAnimation): (WebCore::FrameView::serviceScriptedAnimations):
- page/FrameView.h:
- platform/HostWindow.h:
2011-01-20 James Robinson <jamesr@chromium.org>
Reviewed by Darin Fisher.
Implement mozilla's requestAnimationFrame API
https://bugs.webkit.org/show_bug.cgi?id=51218
Chromium WebKit API support for window.webkitRequestAnimationFrame()
- features.gypi:
- public/WebWidget.h:
- public/WebWidgetClient.h: (WebKit::WebWidgetClient::scheduleAnimation):
- src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::scheduleAnimation):
- src/ChromeClientImpl.h:
- src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::animate): (WebKit::WebPopupMenuImpl::scheduleAnimation):
- src/WebPopupMenuImpl.h:
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::animate):
- src/WebViewImpl.h:
2011-01-20 James Robinson <jamesr@chromium.org>
Reviewed by Darin Fisher.
Implement mozilla's requestAnimationFrame API
https://bugs.webkit.org/show_bug.cgi?id=51218
Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
- DumpRenderTree/chromium/WebViewHost.cpp: (invokeScheduleComposite): (WebViewHost::scheduleAnimation): (WebViewHost::paintInvalidatedRegion):
- DumpRenderTree/chromium/WebViewHost.h:
- 1:39 PM Changeset in webkit [76277] by
-
- 20 edits in trunk/Source/WebCore
2011-01-20 James Robinson <jamesr@chromium.org>
Reviewed by Nate Chapin.
[v8] CodeGeneratorV8 generates incorrect code for callbacks with no parameters
https://bugs.webkit.org/show_bug.cgi?id=52837
When generating code to invoke a callback with no parameters CodeGeneratorV8.pm was generating the following:
v8::Handle<v8::Value> argv[] = {}; which does not compile in visual studio. Instead, if the argument count
is 0, we can just pass a NULL pointer for the argv parameter.
Test added to bindings/scripts/test/TestCallback.idl and covered by run-bindings-tests. This
patch also includes some spurious changes to the bindings tests golden files (mostly GObject)
because the old golden files were out of date.
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/scripts/test/CPP/WebDOMTestCallback.cpp: (WebDOMTestCallback::callbackWithNoParam):
- bindings/scripts/test/CPP/WebDOMTestCallback.h:
- bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp: (webkit_dom_test_callback_callback_with_no_param):
- bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
- bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
- bindings/scripts/test/JS/JSTestCallback.cpp: (WebCore::JSTestCallback::callbackWithNoParam):
- bindings/scripts/test/JS/JSTestCallback.h:
- bindings/scripts/test/JS/JSTestInterface.cpp:
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/ObjC/DOMTestCallback.h:
- bindings/scripts/test/ObjC/DOMTestCallback.mm: (-[DOMTestCallback callbackWithNoParam]):
- bindings/scripts/test/TestCallback.idl:
- bindings/scripts/test/V8/V8TestCallback.cpp: (WebCore::V8TestCallback::callbackWithNoParam):
- bindings/scripts/test/V8/V8TestCallback.h:
- bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::reflectedUnsignedIntegralAttrAttrGetter):
- 1:34 PM Changeset in webkit [76276] by
-
- 4 edits2 adds in trunk
2011-01-20 James Robinson <jamesr@chromium.org>
Reviewed by Eric Seidel.
RenderTableSection's setNeedsCellRecalc needs to null check table()
https://bugs.webkit.org/show_bug.cgi?id=52770
Tests ::-webkit-scrollbar-corner inside a table.
- fast/css-generated-content/table-with-scrollbar-corner-expected.txt: Added.
- fast/css-generated-content/table-with-scrollbar-corner.html: Added.
2011-01-20 James Robinson <jamesr@chromium.org>
Reviewed by Eric "Baller" Seidel.
RenderTableSection's setNeedsCellRecalc needs to null check table()
https://bugs.webkit.org/show_bug.cgi?id=52770
Null checks table() before deferencing it in RenderTableSection::setNeedsCellRecalc.
This can be null during detach(). Test constructed by Eric Seidel.
Test: fast/css-generated-content/table-with-scrollbar-corner.html
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::setNeedsCellRecalc):
- rendering/RenderTableSection.h:
- 1:31 PM Changeset in webkit [76275] by
-
- 5 edits in trunk
2011-01-20 Michael Saboff <msaboff@apple.com>
Reviewed by Oliver Hunt.
<rdar://problem/8890203> [RegexFuzz] Crash in generated code (52773)
https://bugs.webkit.org/show_bug.cgi?id=52773
Fixed case where an existing DataLabelPtr is overwritten. The
replacing DataLabelPtr is now resolved immediately in
linkDataLabelToBacktrackIfExists(). Cleanup - eliminated bool
return value for the routine as it was never used.
- yarr/YarrJIT.cpp: (JSC::Yarr::YarrGenerator::TermGenerationState::linkDataLabelToBacktrackIfExists):
2011-01-20 Michael Saboff <msaboff@apple.com>
Reviewed by Oliver Hunt.
<rdar://problem/8890203> [RegexFuzz] Crash in generated code (52773)
https://bugs.webkit.org/show_bug.cgi?id=52773
New test to validate fix.
- fast/regex/parentheses-expected.txt:
- fast/regex/script-tests/parentheses.js:
- 1:26 PM Changeset in webkit [76274] by
-
- 5 edits4 adds in trunk
2011-01-20 Dirk Schulze <krit@webkit.org>
Reviewed by Rob Buis.
SVG Pattern doesn't take preserveAspectRatio of references Pattern
https://bugs.webkit.org/show_bug.cgi?id=52802
SVGPattern didn't take preserveAspectRatio of a referenced SVGPattern into account. Store preserveAspectRatio
in PatternAttributes as well, if the attribute was set on the referenced SVGPattern element.
Test: svg/custom/pattern-referencing-preserve-aspect-ratio.svg
- rendering/svg/RenderSVGResourcePattern.cpp: (WebCore::RenderSVGResourcePattern::buildTileImageTransform):
- svg/PatternAttributes.h: (WebCore::PatternAttributes::PatternAttributes): (WebCore::PatternAttributes::preserveAspectRatio): (WebCore::PatternAttributes::setPreserveAspectRatio): (WebCore::PatternAttributes::hasPreserveAspectRatio):
- svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::collectPatternAttributes):
2011-01-20 Dirk Schulze <krit@webkit.org>
Reviewed by Rob Buis.
SVG Pattern doesn't take preserveAspectRatio of references Pattern
https://bugs.webkit.org/show_bug.cgi?id=52802
Added a test case to check that we take preserveAspectRatio of a referenced SVGPattern into account.
- platform/mac/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.checksum: Added.
- platform/mac/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.png: Added.
- platform/mac/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.txt: Added.
- svg/custom/pattern-referencing-preserve-aspect-ratio.svg: Added.
- 12:47 PM Changeset in webkit [76273] by
-
- 4 edits5 adds in trunk
<rdar://problem/8765498> REGRESSION (r72141): Cannot order prints with Aperture 3.1
Reviewed by Adele Peterson.
<rdar://problem/8884648> REGRESSION (r72141): Safari hangs when visiting a page on www.bfmtv.com
https://bugs.webkit.org/show_bug.cgi?id=52765
<rdar://problem/8890909> REGRESSION (r72141): Very Slow Rendering With Certain Markup
https://bugs.webkit.org/show_bug.cgi?id=52265
Source/WebCore:
Test: fast/block/line-layout/negative-max-height.html
Integer overflow detection led to a block having a huge height. This manifested as broken layout
in the first bug and as extreme slowness in the latter bugs because of
https://bugs.webkit.org/show_bug.cgi?id=52832
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::alignBoxesInBlockDirection): Clamp maxHeight to 0 so the next line
cannot start above this line. The negative maxHeight also caused the integer overflow detection
logic to give the block a huge height.
LayoutTests:
- fast/block/line-layout: Added.
- fast/block/line-layout/negative-max-height-expected.checksum: Added.
- fast/block/line-layout/negative-max-height-expected.png: Added.
- fast/block/line-layout/negative-max-height-expected.txt: Added.
- fast/block/line-layout/negative-max-height.html: Added.
- 12:41 PM Changeset in webkit [76272] by
-
- 3 edits in trunk/Source/WebCore
2011-01-20 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Eric Carlson.
Clean up the Media Controls CSS for Qt
https://bugs.webkit.org/show_bug.cgi?id=52822
Split the audio::-webkit-media-xxx and video::-webkit-media-xxx rules
in mediaControlsQt.css, and remove the duplicate audio::-webkit-media-xxx
rules from mediaControlsQtFullscreen.css.
- css/mediaControlsQt.css: (audio::-webkit-media-controls-panel): (video::-webkit-media-controls-panel): (audio::-webkit-media-controls-mute-button): (video::-webkit-media-controls-mute-button): (audio::-webkit-media-controls-play-button): (video::-webkit-media-controls-play-button): (audio::-webkit-media-controls-timeline-container): (video::-webkit-media-controls-timeline-container): (audio::-webkit-media-controls-current-time-display): (video::-webkit-media-controls-current-time-display): (audio::-webkit-media-controls-time-remaining-display): (video::-webkit-media-controls-time-remaining-display): (audio::-webkit-media-controls-timeline): (video::-webkit-media-controls-timeline): (audio::-webkit-media-controls-volume-slider-container): (video::-webkit-media-controls-volume-slider-container): (audio::-webkit-media-controls-volume-slider): (video::-webkit-media-controls-volume-slider): (audio::-webkit-media-controls-seek-back-button): (video::-webkit-media-controls-seek-back-button): (audio::-webkit-media-controls-seek-forward-button): (video::-webkit-media-controls-seek-forward-button): (audio::-webkit-media-controls-fullscreen-button): (video::-webkit-media-controls-fullscreen-button): (audio::-webkit-media-controls-rewind-button): (video::-webkit-media-controls-rewind-button): (audio::-webkit-media-controls-return-to-realtime-button): (video::-webkit-media-controls-return-to-realtime-button): (audio::-webkit-media-controls-toggle-closed-captions-button): (video::-webkit-media-controls-toggle-closed-captions-button):
- css/mediaControlsQtFullscreen.css: (video::-webkit-media-controls-time-remaining-display): (video::-webkit-media-controls-seek-back-button): (video::-webkit-media-controls-seek-forward-button): (video::-webkit-media-controls-rewind-button): (video::-webkit-media-controls-return-to-realtime-button): (video::-webkit-media-controls-toggle-closed-captions-button):
- 12:32 PM Changeset in webkit [76271] by
-
- 3 edits in trunk/Websites/bugs.webkit.org
2011-01-20 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
fix goofup in http://trac.webkit.org/changeset/76082
https://bugs.webkit.org/show_bug.cgi?id=52830
We were showing the revision number of the patch at the bottom
of the diff and expanding from the bottom of the diff would fail.
Also, removed an unused variable and scoped queries appropriatly
to the file_diff they should have been operating on.
- PrettyPatch/PrettyPatch.rb:
- code-review.js:
- 12:30 PM Changeset in webkit [76270] by
-
- 3 edits in trunk/Websites/bugs.webkit.org
2011-01-19 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
[reviewtool] Add a link for annotated trac page on review page
https://bugs.webkit.org/show_bug.cgi?id=52747
-add line numbers to all trac links to the first line in the file diff
-add annotate/review log links
-make file-diff links other than the file name only show when you mouseover the filediff
-fix white-space to only wrap the .text element and it's childen, any of it's siblings/parents
- PrettyPatch/PrettyPatch.rb:
- code-review.js:
- 12:30 PM Changeset in webkit [76269] by
-
- 1 edit2 adds in trunk/LayoutTests
2011-01-20 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed Chromium rebaseline for r76236.
- platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png: Added.
- platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt: Added.
- 11:21 AM Changeset in webkit [76268] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
2011-01-14 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
make line selection have a extend only from where you start the selection in the code review tool
https://bugs.webkit.org/show_bug.cgi?id=52485
- code-review.js:
- 11:07 AM Changeset in webkit [76267] by
-
- 5 edits in trunk/Source/WebKit2
Reviewed by Anders Carlsson.
<rdar://problem/8880689> need a way to obtain the rendered rectangle for box elements
https://bugs.webkit.org/show_bug.cgi?id=52823
- WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp: (WKBundleNodeHandleGetRenderRect): Added new method that will return a rendered rectangle for box elements
- WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h: Ditto.
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp: Ditto. (WebKit::InjectedBundleNodeHandle::renderRect): Ditto.
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h: Ditto.
- 10:31 AM Changeset in webkit [76266] by
-
- 2 edits in trunk/Source/WebCore
2011-01-20 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [REGRESSION] Canceling of CSS numeric values increment/decrement is broken
https://bugs.webkit.org/show_bug.cgi?id=52816
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype):
- 10:24 AM Changeset in webkit [76265] by
-
- 2 edits in trunk/Source/WebCore
2011-01-20 Dawit Alemayehu <adawit@kde.org>
Reviewed by Andreas Kling.
[Qt] Fix Layering violation in MediaPlayerPrivateQt.
https://bugs.webkit.org/show_bug.cgi?id=52733
No new tests. no behavioral change.
- platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivateQt::commitLoad):
- 10:20 AM Changeset in webkit [76264] by
-
- 2 edits in trunk/Source/WebCore
2011-01-20 Nate Chapin <Nate Chapin>
Reviewed by Darin Fisher.
[V8] Call malloc and memcpy directly instead of
of strdup in convertV8ObjectToNPVariant() when
converting strings. If there is a null character
in the string, our use of strdup causes us to allocate
too little memory, leading to out of bounds reads.
- bindings/v8/V8NPUtils.cpp: (WebCore::convertV8ObjectToNPVariant):
- 10:13 AM Changeset in webkit [76263] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-01-20 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt][WK2] WebKit2 enabled build fails to link
Work around undefined reference linking issues until the buildsystem gets redesigned.
These issues first occured in minimal builds (see BUG 50519).
- JavaScriptCore.pri: link as whole-archive for WebKit2 builds
- 10:08 AM Changeset in webkit [76262] by
-
- 4 edits in trunk/Source/WebKit2
2011-01-20 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>
Reviewed by Andreas Kling.
Remove null ptr deref that happens when reattaching to
a new web process.
Implement didRelaunchProcess that sets the drawing area size
after the drawing area is re-instantiated.
[Qt][WK2] Null ptr deref in UI process after web process has crashed
https://bugs.webkit.org/show_bug.cgi?id=52796
- UIProcess/API/qt/qgraphicswkview.cpp: (QGraphicsWKView::QGraphicsWKView):
- UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::QWKPagePrivate): (QWKPagePrivate::init): (QWKPagePrivate::createDrawingAreaProxy): (QWKPagePrivate::didRelaunchProcess): Reset drawing area size after crash.
- UIProcess/API/qt/qwkpage_p.h:
- 10:07 AM Changeset in webkit [76261] by
-
- 1 edit1 delete in trunk/LayoutTests
2011-01-20 Philippe Normand <pnormand@igalia.com>
Unreviewed, remove GTK result for window-onerror2 as it's the same
as the generic results file.
- platform/gtk/fast/events/window-onerror2-expected.txt: Removed.
- 9:49 AM Changeset in webkit [76260] by
-
- 2 edits in trunk/Source/WebCore
2011-01-20 Andreas Kling <kling@webkit.org>
Reviewed by Ariya Hidayat.
[Qt] Fill shadow scratch buffer with proper transparent pixels
QImage::fill() has no Qt::GlobalColor overload in Qt 4.7 (coming in 4.8)
so doing QImage::fill(Qt::transparent) will actually fill all pixels with
the RGBA value 0x00000013.
- platform/graphics/qt/ContextShadowQt.cpp: (WebCore::ShadowBuffer::scratchImage):
- 9:15 AM Changeset in webkit [76259] by
-
- 13 edits in trunk
2011-01-20 Maciej Stachowiak <mjs@apple.com>
Reviewed by Adam Roben.
WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
https://bugs.webkit.org/show_bug.cgi?id=42327
- platform/mac-wk2/Skipped: Unskip the tests that needed this.
2011-01-20 Maciej Stachowiak <mjs@apple.com>
Reviewed by Adam Roben.
WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
https://bugs.webkit.org/show_bug.cgi?id=42327
Added a new API call, WKBundleFrameForJavaScriptContext, that gets the WKBundleFrameRef
that corresponds to a JSContextRef (or null if none).
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: (WKBundleFrameForJavaScriptContext): Simple wrapper, defers to a WebFrame static method.
- WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
- WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::frameForContext): Follow the maze of twisty pointers.
- WebProcess/WebPage/WebFrame.h:
2011-01-20 Maciej Stachowiak <mjs@apple.com>
Reviewed by Adam Roben.
WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
https://bugs.webkit.org/show_bug.cgi?id=42327
- WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support for methods that take their normal arguments but also a JSContextRef.
- WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition for evaluateScriptInIsolatedWorld.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if this call is for an isolated world.
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::worldMap): Helper to create a world map. (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world. (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly added LayoutTestController API.
- WebKitTestRunner/InjectedBundle/LayoutTestController.h:
- 9:12 AM Changeset in webkit [76258] by
-
- 3 edits2 deletes in trunk/Source/WebCore
Remove WKCACFContextFlusher
It wasn't doing anything.
Fixes <http://webkit.org/b/52752> WKCACFContextFlusher is unused
Reviewed by Simon Fraser.
- WebCore.vcproj/WebCore.vcproj: Removed WKCACFContextFlusher. Also let VS have its way with
the file.
- platform/graphics/win/WKCACFContextFlusher.cpp: Removed.
- platform/graphics/win/WKCACFContextFlusher.h: Removed.
- platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::~WKCACFLayerRenderer):
(WebCore::WKCACFLayerRenderer::layerTreeDidChange):
Stop telling WKCACFContextFlusher about our context, since it never did anything with it.
- 9:12 AM Changeset in webkit [76257] by
-
- 2 edits in trunk/Source/WebCore
Only flush our own context when we get resized
Fixes <http://webkit.org/b/52751> All WKCACFContexts with uncommitted
changes get flushed whenever any composited page is resized
Reviewed by Simon Fraser.
- platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::resize): Just flush our own context, not all contexts
WKCACFContextFlusher knows about. After all, ours is the only one that just got resized!
- 9:11 AM Changeset in webkit [76256] by
-
- 8 edits in trunk/Source
Make WKCACFLayerRenderer ref-counted
This will be needed to handle cases where the client might release its reference to us while
we're calling out to it.
WKCACFLayerRenderer now has a setClient function, which is used rather than passing the
client to create(). This allows clients to null out the client pointer when they're done
with the renderer.
Fixes <http://webkit.org/b/52749> WKCACFLayerRenderer should be
ref-counted
Reviewed by Simon Fraser.
Source/WebCore:
- platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
(WebCore::MediaPlayerPrivateFullscreenWindow::MediaPlayerPrivateFullscreenWindow):
- platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h:
Updated for WKCACFLayerRenderer changes.
- platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::acceleratedCompositingAvailable): Updated for changes to
create().
(WebCore::WKCACFLayerRenderer::create): No longer takes a WKCACFLayerRendererClient. Now
returns a PassOwnPtr.
(WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): No longer takes a
WKCACFLayerRendererClient.
- platform/graphics/win/WKCACFLayerRenderer.h: Made WKCACFLayerRenderer inherit from
RefCounted.
(WebCore::WKCACFLayerRenderer::setClient): Added this simple setter.
Source/WebKit/win:
Update for WKCACFLayerRenderer changes
- WebView.cpp:
(WebView::~WebView): Added some assertions to make sure we've gotten rid of our
compositing-related members. My biggest concern was making sure that m_layerRenderer was
gone, which would also mean we had nulled out its client pointer.
(WebView::setAcceleratedCompositing): Changed to call WKCACFLayerRenderer::setClient instead
of passing the client into create(), and to clear out the client before nulling out
m_layerRenderer.
- WebView.h: Changed m_layerRenderer from an OwnPtr to a RefPtr.
- 9:11 AM Changeset in webkit [76255] by
-
- 2 edits in trunk/Tools
Convert paths in environment variables back to msys-style inside commit-log-editor
When this script gets run from inside git commit, msys-style paths in the environment will
have been turned into Windows-style paths with forward slashes. This screws up functions
like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
the paths back to msys-style before doing anything else.
Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
using msysgit's Perl and multiple ChangeLogs have been edited
Reviewed by David Kilzer.
- Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
(fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
inside git commit), convert Windows-style paths in the environment back to msys-style paths.
- 9:10 AM Changeset in webkit [76254] by
-
- 3 edits2 adds in trunk
Teach WebView::scrollBackingStore about compositing mode
Test:
compositing/scroll-painted-composited-content.html
Fixes <http://webkit.org/b/52720> REGRESSION (r75987): Assertion failure in
WebView::scrollBackingStore when scrolling page with composited content
Reviewed by Anders Carlsson.
Source/WebKit/win:
- WebView.cpp:
(WebView::scrollBackingStore): Do something sensible (though naive) when in compositing
mode, rather than incorrectly asserting that this function is never called in that case. For
now we just repaint the entire scrolled region; someday hopefully we can avoid having to
repaint the areas that have just been moved.
LayoutTests:
Add a test that scrolls composited content that has already been painted
- compositing/scroll-painted-composited-content.html: Added.
- compositing/scroll-painted-composited-content-expected.txt: Added.
- 9:08 AM Changeset in webkit [76253] by
-
- 1 edit1 add in trunk/Tools
[Win] Unreviewed build fix after r76248.
- DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
- 8:55 AM Changeset in webkit [76252] by
-
- 2 edits in trunk/Source/WebKit2
2011-01-20 Alejandro G. Castro <alex@igalia.com>
Fix compilation error in GTK WebKit2.
- Platform/CoreIPC/gtk/ConnectionGtk.cpp: (CoreIPC::readBytesFromSocket): (CoreIPC::writeBytesToSocket):
- 8:54 AM Changeset in webkit [76251] by
-
- 2 edits in trunk/Source/WebCore
[Qt][V8] Unreviewed buildfix after r76248.
- bindings/v8/ScriptCachedFrameData.h: Add missing include.
- 8:53 AM Changeset in webkit [76250] by
-
- 2 edits in trunk
2011-01-20 Alejandro G. Castro <alex@igalia.com>
Reviewed by Andreas Kling.
[GTK] Fix typo in the webkit2 section of the configure.ac file
https://bugs.webkit.org/show_bug.cgi?id=52801
Fixed typo in the GTK WebKit2 compilation.
- configure.ac:
- 8:49 AM Changeset in webkit [76249] by
-
- 8 edits in trunk/Source/WebCore
2011-01-20 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: enable resource agent upon request.
https://bugs.webkit.org/show_bug.cgi?id=52815
We should not send network-related notifications unless front-end
is interested.
- inspector/Inspector.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::restoreInspectorStateFromCookie): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::resourceAgent):
- inspector/InspectorController.h: (WebCore::InspectorController::consoleAgent): (WebCore::InspectorController::cssAgent): (WebCore::InspectorController::domAgent): (WebCore::InspectorController::injectedScriptAgent): (WebCore::InspectorController::runtimeAgent): (WebCore::InspectorController::databaseAgent): (WebCore::InspectorController::domStorageAgent): (WebCore::InspectorController::fileSystemAgent):
- inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::retrieveResourceAgent):
- inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::restore): (WebCore::InspectorResourceAgent::~InspectorResourceAgent): (WebCore::InspectorResourceAgent::InspectorResourceAgent):
- inspector/InspectorResourceAgent.h: (WebCore::InspectorResourceAgent::create):
- inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState):
- inspector/InspectorState.h:
- 8:30 AM Changeset in webkit [76248] by
-
- 450 edits in trunk
Refactoring of the custom allocation framework
https://bugs.webkit.org/show_bug.cgi?id=49897
Patch by Zoltan Horvath <zoltan@webkit.org> on 2011-01-20
Reviewed by Csaba Osztrogonác.
Source/JavaScriptCore:
Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
equivalent macro implementation at the necessary places.
- wtf/FastAllocBase.h: Turn FastAllocBase's implementation into a macro.
Source/WebCore:
Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
equivalent macro implementation at the necessary places.
Source/WebKit:
Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
equivalent macro implementation at the necessary places.
Source/WebKit2:
Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
equivalent macro implementation at the necessary places.
Tools:
Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
equivalent macro implementation at the necessary places.
- 8:21 AM Changeset in webkit [76247] by
-
- 4 edits in trunk/Source/WebCore
2011-01-20 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] CPU Profiles are cleared when navigating back and forth.
Profiles are now not cleared unless renderer instance was changed.
- inspector/InspectorController.cpp: (WebCore::InspectorController::restoreProfiler):
- inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::resetState): (WebCore::InspectorProfilerAgent::resetFrontendProfiles):
- inspector/InspectorProfilerAgent.h:
- 7:59 AM Changeset in webkit [76246] by
-
- 4 edits in trunk/Source/WebCore
2011-01-20 Alexander Pavlov <apavlov@chromium.org>
Unreviewed, add new JS file refs missing from r76116.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/WebKit.qrc:
- 7:46 AM Changeset in webkit [76245] by
-
- 2 edits in trunk/Source/WebCore
2011-01-20 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Crash when adding a rule for an ImageDocument
https://bugs.webkit.org/show_bug.cgi?id=52811
- inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::addRule2): (WebCore::InspectorCSSAgent::viaInspectorStyleSheet):
- 7:38 AM Changeset in webkit [76244] by
-
- 4 edits in trunk/LayoutTests
2011-01-20 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Make fast/events/window-onerror2.html throw exception in deterministic order
https://bugs.webkit.org/show_bug.cgi?id=52813
- fast/events/window-onerror2-expected.txt:
- fast/events/window-onerror2.html: call setTimeout from onload handler to make sure exception in the onload handler will be processed before the one in the setTimeout callback
- platform/chromium/fast/events/window-onerror2-expected.txt:
- 7:32 AM Changeset in webkit [76243] by
-
- 2 edits in trunk/Tools
2011-01-20 Yi Shen <yi.4.shen@nokia.com>
Unreviewed.
Adding myself to committers.py.
- Scripts/webkitpy/common/config/committers.py:
- 7:00 AM Changeset in webkit [76242] by
-
- 1 edit1 add in trunk/LayoutTests
2011-01-20 Philippe Normand <pnormand@igalia.com>
Unreviewed, new GTK svg test baselines as follow-up of r76236.
- platform/gtk/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt: Added.
- 6:52 AM Changeset in webkit [76241] by
-
- 2 edits in trunk/LayoutTests
2011-01-20 Philippe Normand <pnormand@igalia.com>
Unreviewed, update window-onerror2.html baselines as follow-up of r76216.
- platform/gtk/fast/events/window-onerror2-expected.txt:
- 6:50 AM Changeset in webkit [76240] by
-
- 5 edits in trunk/Source/WebCore
2011-01-20 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: cleanup InspectorController's friends list.
We have a plan to extract InspectorAgent from InspectorController.
InspectorAgent will be accessible only from InspectorController.
As result we can simply made some methods public and remove long
friends list.
- inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::databaseForId): (WebCore::InjectedScriptHost::selectDatabase): (WebCore::InjectedScriptHost::selectDOMStorage): (WebCore::InjectedScriptHost::inspectorDOMAgent): (WebCore::InjectedScriptHost::frontend):
- inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode): (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode): (WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr): (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent): (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded): (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
- inspector/InspectorController.h: (WebCore::InspectorController::frontend):
- inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::didModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::characterDataModifiedImpl): (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl): (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl): (WebCore::InspectorInstrumentation::didFailLoadingImpl): (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl): (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsoleImpl): (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded): (WebCore::InspectorInstrumentation::cancelPauseOnNativeEvent): (WebCore::InspectorInstrumentation::retrieveTimelineAgent): (WebCore::InspectorInstrumentation::retrieveResourceAgent):
- 6:47 AM Changeset in webkit [76239] by
-
- 6 edits in trunk/Source/WebCore
2011-01-19 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: implement JavaScriptBreakpointsSidebarPane based on events from debugger model.
https://bugs.webkit.org/show_bug.cgi?id=52723
Extract all breakpoints-related presentation code from debugger model to JavaScriptBreakpointSidebarPane.
- inspector/front-end/Breakpoint.js: (WebInspector.Breakpoint): (WebInspector.Breakpoint.prototype.get data): (WebInspector.Breakpoint.prototype.remove):
- inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.JavaScriptBreakpointsSidebarPane): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointAdded): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointRemoved): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointEnableChanged): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointItemCheckboxClicked): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._contextMenuEventFired): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._debuggerPaused): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._debuggerResumed): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._addListElement): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._removeListElement): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._projectChanged): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._compare): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._compareBreakpoints): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._setupBreakpointElement.didGetSourceLine): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._setupBreakpointElement): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointIdForDebuggerPausedEvent): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._setBreakpointEnabled): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._removeBreakpoint): (WebInspector.NativeBreakpointsSidebarPane): (WebInspector.XHRBreakpointsSidebarPane.prototype.addBreakpointItem):
- inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.removeBreakpoint): (WebInspector.DebuggerModel.prototype.breakpointForId): (WebInspector.DebuggerModel.prototype._pausedScript): (WebInspector.DebuggerModel.prototype._resumedScript):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel):
- inspector/front-end/inspector.js:
- 6:28 AM Changeset in webkit [76238] by
-
- 1 edit3 adds in trunk/LayoutTests
2011-01-20 Philippe Normand <pnormand@igalia.com>
Unreviewed, new GTK baselines for 2 new tests.
- platform/gtk/fast/block/float/float-overflow-hidden-containing-block-width-expected.txt: Added.
- platform/gtk/svg/css/text-gradient-shadow-expected.txt: Added.
- 6:23 AM Changeset in webkit [76237] by
-
- 4 edits in trunk/LayoutTests
2011-01-20 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Update Chromium test expectations.
- platform/chromium-win/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
- platform/chromium-win/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
- platform/chromium-win/http/tests/security/xss-DENIED-frame-name-expected.txt:
- 6:11 AM Changeset in webkit [76236] by
-
- 5 edits4 adds in trunk
2011-01-20 Dirk Schulze <krit@webkit.org>
Reviewed by Andreas Kling.
SVG Pattern doesn't take the viewBox of a referenced Pattern
https://bugs.webkit.org/show_bug.cgi?id=52804
SVGPattern element didn't use the viewBox of another SVGPattern element, referenced
by xlink:href. Modified PatternAttributes, to take the value of the viewBox of the
SVGPattern element as well, if the attribute was set.
This gets checked by a W3C SVG test case.
Test: svg/W3C-SVG-1.1-SE/pservers-pattern-04-f.svg
- rendering/svg/RenderSVGResourcePattern.cpp: (WebCore::RenderSVGResourcePattern::buildTileImageTransform):
- svg/PatternAttributes.h: (WebCore::PatternAttributes::PatternAttributes): (WebCore::PatternAttributes::viewBox): (WebCore::PatternAttributes::setViewBox): (WebCore::PatternAttributes::hasViewBox):
- svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::collectPatternAttributes):
2011-01-20 Dirk Schulze <krit@webkit.org>
Reviewed by Andreas Kling.
SVG Pattern doesn't take the viewBox of a referenced Pattern
https://bugs.webkit.org/show_bug.cgi?id=52804
Added a test case of the W3C SVG test suite to check, if we take
the viewBox of a referenced SVGPattern.
- svg/W3C-SVG-1.1-SE/pservers-pattern-04-f.svg: Added.
- platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.checksum
- platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png
- platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt
- 5:48 AM Changeset in webkit [76235] by
-
- 22 edits in trunk
2011-01-19 Stephen White <senorblanco@chromium.org>
[Re-land of r76159 with a compile fix for the Chromium linux shlib
build.]
Reviewed by James Robinson.
Implement accelerated path drawing and clipping for the Canvas2D GPU
path.
https://bugs.webkit.org/show_bug.cgi?id=52627
This is done with a simple curve interpolator and the GLU tesselator,
which is good enough for a 3-5X speedup on
http://ie.microsoft.com/testdrive/Performance/Galactic/Default.html.
Covered by canvas/philip/2d.path.clip.basic.html, and many, many more.
All tests canvas/philip and fast/canvas paths pass with no
regressions, although two have minor pixel differences which require
rebaselining.
- WebCore.gyp/WebCore.gyp: Add internal_glu include path to chromium build.
- WebCore.gypi: Add internal_glu files to chromium build.
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::reset): (WebCore::CanvasRenderingContext2D::platformLayer): Make CanvasRenderingContext2D more robust against failure to create a DrawingBuffer.
- platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::DrawingBuffer): As in DrawingBufferMac.cpp, call reset() from the constructor. Also initialize size to (-1, -1), so reset() doesn't early-out. Add initializers for depthBuffer and stencilBuffer, and remove multisampleDepthStencilBuffer.
- platform/graphics/chromium/GLES2Canvas.cpp: Remove some unused #includes. (WebCore::GLES2Canvas::State::State): Add clipping state, and implement save/restore via the copy constructor. (WebCore::operator*): (WebCore::Quadratic::Quadratic): (WebCore::Quadratic::fromBezier): (WebCore::Quadratic::evaluate): Quadratic Bezier curve class. (WebCore::Cubic::Cubic): (WebCore::Cubic::fromBezier): (WebCore::Cubic::evaluate): Cubic Bezier curve class. (WebCore::GLES2Canvas::clearRect): Add clipping support to clearRect(). (WebCore::GLES2Canvas::fillPath): Implement fillPath(). (WebCore::GLES2Canvas::fillRect): Add clipping support to fillRect(). (WebCore::GLES2Canvas::clipPath): Implement clipPath(). (WebCore::GLES2Canvas::clipOut): Stub out clipOut() (not called by Canvas 2D). (WebCore::GLES2Canvas::restore): When restoring, draw any remaining clipping paths to the stencil buffer. (WebCore::GLES2Canvas::drawTexturedRect): Add clipping support. (WebCore::interpolateQuadratic): (WebCore::interpolateCubic): Simple curve interpolation, using the Cubic and Quadratic classes. (WebCore::PolygonData::PolygonData): A struct to hold the tesselation data for callbacks. (WebCore::beginData): (WebCore::edgeFlagData): (WebCore::vertexData): (WebCore::endData): (WebCore::combineData): internal_glu tesselation callbacks. (WebCore::GLES2Canvas::createVertexBufferFromPath): Build an interpolated, tesselated vertex buffer and element array buffer from a given path, suitable for filling. (WebCore::GLES2Canvas::beginStencilDraw): Enable stencilling, and disable draws to the color buffer. (WebCore::GLES2Canvas::applyClipping): If clipping is enabled, set the appropriate GL state.
- platform/graphics/chromium/GLES2Canvas.h: Document the flavours of drawTexturedRect() a bit, so I don't get confused.
- platform/graphics/gpu/DrawingBuffer.cpp: (WebCore::DrawingBuffer::clear): (WebCore::DrawingBuffer::createSecondaryBuffers): (WebCore::DrawingBuffer::resizeDepthStencil): (WebCore::DrawingBuffer::reset):
- platform/graphics/gpu/DrawingBuffer.h: Unify m_multisampleDepthStencilBuffer with m_depthStencilBuffer. Implement separate depth and stencil buffers for when OES_packed_depth_stencil is not available. Refactor creation of multisampled and non-multisampled depth and stencil buffers into resizeDepthStencil().
- platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::create): Turn on stencil, turn off depth, turn off antialiasing (for now). (WebCore::SharedGraphicsContext3D::enableStencil):
- platform/graphics/gpu/SharedGraphicsContext3D.h: Implement stencil enable/disable.
- platform/graphics/gpu/mac/DrawingBufferMac.mm: (WebCore::DrawingBuffer::DrawingBuffer): Remove m_multisampleDepthStencilBuffer. Set the size to (-1, -1) on creation, so reset() doesn't early-out. Initialize m_depthBuffer and m_stencilBuffer.
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::canvasClip): (WebCore::GraphicsContext::clipOut): (WebCore::GraphicsContext::clipPath): (WebCore::GraphicsContext::fillPath): Put in GPU hooks for path clipping, and path drawing.
- platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::canAccelerate): Don't check for clipping paths in canAccelerate() (since we can now accelerate them). (WebCore::PlatformContextSkia::uploadSoftwareToHardware): Don't do clipping when uploading software draws to hardware.
- thirdparty/glu/README.webkit:
- thirdparty/glu/gluos.h: #undef MIN and MAX, to fix warnings-as-errors in Chrome/Mac build.
- thirdparty/glu/libtess/geom.c:
- thirdparty/glu/libtess/priorityq.c:
- thirdparty/glu/libtess/render.c: Use do{}while(0) instead of if(1)else construct in macro.
- thirdparty/glu/libtess/sweep.c: (IsWindingInside): (DoneEdgeDict): Fix some warnings treated as errors for the Linux Release build.
2011-01-19 Stephen White <senorblanco@chromium.org>
Reviewed by James Robinson.
Add two to-be-rebaselined tests for the GPU path.
- platform/chromium-gpu/test_expectations.txt:
- 5:46 AM Changeset in webkit [76234] by
-
- 3 edits in trunk/LayoutTests
2011-01-20 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: rebaselined inspector tests.
- http/tests/inspector/console-xhr-logging.html:
- inspector/report-API-errors-expected.txt:
- 5:14 AM Changeset in webkit [76233] by
-
- 1 edit in trunk/Source/WebCore/ChangeLog
2011-01-20 Pavel Feldman <pfeldman@chromium.org>
Web Inspector: move releaseObjectGroup to the new Runtime agent.
https://bugs.webkit.org/show_bug.cgi?id=52803
(accedentally landed as r76231)
- inspector/InspectorContorller.h:
- inspector/InspectorContorller.cpp:
- inspector/InspectorRuntimeAgent.h:
- inspector/InspectorRuntimeAgent.cpp:
- 4:58 AM Changeset in webkit [76232] by
-
- 2 edits in trunk/Source/WebCore
2011-01-20 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: build fix.
- inspector/InspectorState.h: (WebCore::InspectorState::setBoolean): (WebCore::InspectorState::setString): (WebCore::InspectorState::setLong):
- 4:57 AM Changeset in webkit [76231] by
-
- 5 edits in trunk/Source/WebCore/inspector
2011-01-20 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: build fix.
- inspector/InspectorState.h: (WebCore::InspectorState::setBoolean): (WebCore::InspectorState::setString): (WebCore::InspectorState::setLong):
- 4:49 AM Changeset in webkit [76230] by
-
- 10 edits in trunk/Source/WebCore
2011-01-20 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: further simplify InspectorState.
https://bugs.webkit.org/show_bug.cgi?id=52731
This change moves XHR logging flag into console agent,
removes InspectorState pushing to the front-end.
- inspector/Inspector.idl:
- inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::InspectorConsoleAgent): (WebCore::InspectorConsoleAgent::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorConsoleAgent::setMonitoringXHREnabled): (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled): (WebCore::InspectorConsoleAgent::addConsoleMessage):
- inspector/InspectorConsoleAgent.h:
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController):
- inspector/InspectorController.h: (WebCore::InspectorController::state): (WebCore::InspectorController::settings):
- inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState): (WebCore::InspectorState::registerBoolean): (WebCore::InspectorState::registerString): (WebCore::InspectorState::registerLong): (WebCore::InspectorState::registerObject): (WebCore::InspectorState::Property::create):
- inspector/InspectorState.h:
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.consoleMessagesCleared): (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.monitoringXHRStateChanged): (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher): (WebInspector.ConsoleView.prototype._handleContextMenuEvent):
- inspector/front-end/inspector.js:
- 4:47 AM Changeset in webkit [76229] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed buildfix.
[Qt][V8] Remove unnecessary files after r76224.
- WebCore.pro:
- 4:46 AM Changeset in webkit [76228] by
-
- 10 edits in trunk/LayoutTests
2011-01-20 Jeremy Orlow <jorlow@chromium.org>
[Chromium] Update baselines and add exception.
- platform/chromium-mac/fast/dom/wrapper-classes-expected.txt:
- platform/chromium-mac/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
- platform/chromium-mac/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
- platform/chromium-mac/http/tests/security/xss-DENIED-frame-name-expected.txt:
- platform/chromium-win/fast/dom/wrapper-classes-expected.txt:
- platform/chromium-win/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
- platform/chromium-win/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
- platform/chromium-win/http/tests/security/xss-DENIED-frame-name-expected.txt:
- platform/chromium/test_expectations.txt:
- 4:38 AM Changeset in webkit [76227] by
-
- 3 edits in trunk/Source/WebCore
2011-01-20 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: prepare for extracting InspectorAgent from InspectorController.
https://bugs.webkit.org/show_bug.cgi?id=52797
- inspector/CodeGeneratorInspector.pm:
- inspector/InspectorController.h: (WebCore::InspectorController::inspectorAgent): (WebCore::InspectorController::cssAgent): (WebCore::InspectorController::injectedScriptAgent): (WebCore::InspectorController::resourceAgent): (WebCore::InspectorController::runtimeAgent): (WebCore::InspectorController::timelineAgent): (WebCore::InspectorController::databaseAgent): (WebCore::InspectorController::domStorageAgent): (WebCore::InspectorController::fileSystemAgent): (WebCore::InspectorController::browserDebuggerAgent): (WebCore::InspectorController::debuggerAgent): (WebCore::InspectorController::profilerAgent): (WebCore::InspectorController::applicationCacheAgent):
- 4:36 AM Changeset in webkit [76226] by
-
- 12 edits2 deletes in trunk
2011-01-20 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r76215.
http://trac.webkit.org/changeset/76215
https://bugs.webkit.org/show_bug.cgi?id=52799
Caused regressions in Chromium; morrita is going to look at it
tomrorow (Requested by jorlow on #webkit).
- editing/inserting/insert-composition-whitespace-expected.txt: Removed.
- editing/inserting/insert-composition-whitespace.html: Removed.
2011-01-20 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r76215.
http://trac.webkit.org/changeset/76215
https://bugs.webkit.org/show_bug.cgi?id=52799
Caused regressions in Chromium; morrita is going to look at it
tomrorow (Requested by jorlow on #webkit).
- dom/TextEvent.h:
- dom/TextEventInputType.h:
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::rebalanceWhitespaceAt):
- editing/CompositeEditCommand.h:
- editing/Editor.cpp: (WebCore::Editor::insertTextWithoutSendingTextEvent): (WebCore::Editor::confirmComposition): (WebCore::Editor::setComposition):
- editing/Editor.h:
- editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input):
- editing/InsertTextCommand.h:
- editing/TypingCommand.cpp: (WebCore::TypingCommand::TypingCommand): (WebCore::TypingCommand::insertText): (WebCore::TypingCommand::insertTextRunWithoutNewlines):
- editing/TypingCommand.h: (WebCore::TypingCommand::create):
- 4:31 AM Changeset in webkit [76225] by
-
- 7 edits in trunk/LayoutTests
2011-01-19 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Eric Seidel.
Web Inspector: enable debugger-pause-on-breakpoint test (fixed by r76129).
https://bugs.webkit.org/show_bug.cgi?id=45291
- http/tests/inspector/debugger-test2.js: (initialize_DebuggerTest.InspectorTest.setBreakpointInVisibleView):
- inspector/debugger-breakpoints-not-activated-on-reload.html:
- inspector/debugger-pause-on-breakpoint.html:
- platform/gtk/Skipped:
- platform/mac-leopard/Skipped:
- platform/win/Skipped:
- 4:31 AM Changeset in webkit [76224] by
-
- 10 edits2 deletes in trunk/Source
2010-12-14 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Adam Barth.
[V8] Get rid of delayed exception reporting in V8ConsoleMessage.cpp
https://bugs.webkit.org/show_bug.cgi?id=51044
- WebCore.gypi:
- bindings/v8/V8ConsoleMessage.cpp: Removed.
- bindings/v8/V8ConsoleMessage.h: Removed.
- bindings/v8/V8DOMWindowShell.cpp: (WebCore::v8UncaughtExceptionHandler): (WebCore::reportUnsafeJavaScriptAccess): (WebCore::V8DOMWindowShell::initContextIfNeeded):
- bindings/v8/V8Proxy.cpp: (WebCore::addMessageToConsole): (WebCore::logInfo): (WebCore::V8Proxy::reportUnsafeAccessTo): (WebCore::V8Proxy::runScript): (WebCore::V8Proxy::callFunction): (WebCore::V8Proxy::newInstance):
- bindings/v8/V8Proxy.h:
- bindings/v8/WorkerContextExecutionProxy.cpp:
- bindings/v8/specialization/V8BindingState.cpp: (WebCore::::immediatelyReportUnsafeAccessTo):
2010-12-14 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Adam Barth.
[V8] Get rid of delayed exception reporting in V8ConsoleMessage.cpp
https://bugs.webkit.org/show_bug.cgi?id=51044
- src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::runJavaScriptAlert):
- src/WebScriptController.cpp: (WebKit::WebScriptController::flushConsoleMessages):
- 4:28 AM Changeset in webkit [76223] by
-
- 2 edits in trunk/LayoutTests
2011-01-20 Philippe Normand <pnormand@igalia.com>
Skip failing tests due to missing trailing white space
https://bugs.webkit.org/show_bug.cgi?id=52798
- platform/gtk/Skipped: Skip 5 http/tests/security tests.
- 4:16 AM Changeset in webkit [76222] by
-
- 2 edits in trunk/Tools
2011-01-20 Adam Barth <abarth@webkit.org>
Reviewed by Tony Chang.
Chromium builders don't delete unversioned directories when DEPS change
https://bugs.webkit.org/show_bug.cgi?id=52745
If we pass this option to gclient sync, gclient will delete directories
that are no longer part of DEPS instead of leaving them around to
confuse us later. Apparently, the downstream buildbots use this option
already.
- Scripts/update-webkit-chromium:
- 4:08 AM Changeset in webkit [76221] by
-
- 2 edits in trunk/Source/WebCore
2011-01-19 MORITA Hajime <morrita@google.com>
Reviewed by Eric Seidel.
ShadowElement::m_shadowParent should be removed
https://bugs.webkit.org/show_bug.cgi?id=52558
No new tests. No behavioral change.
- rendering/ShadowElement.h: (WebCore::ShadowElement::ShadowElement):
- 2:51 AM Changeset in webkit [76220] by
-
- 2 edits in trunk/LayoutTests
2011-01-20 Martin Robinson <mrobinson@igalia.com>
Skip a test which requires the textInputController, which
the GTK+ DRT does not have.
- platform/gtk/Skipped: Skip new test.
- 2:42 AM Changeset in webkit [76219] by
-
- 2 edits in trunk/LayoutTests
2011-01-20 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r76172.
http://trac.webkit.org/changeset/76172
https://bugs.webkit.org/show_bug.cgi?id=52792
This test still fails on the 32-bit GTK+ debug bot. (Requested
by mrobinson on #webkit).
- platform/gtk/Skipped:
- 2:38 AM Changeset in webkit [76218] by
-
- 2 edits in trunk/LayoutTests
2011-01-20 MORITA Hajime <morrita@google.com>
Unreviewed, added a skip list entry
- platform/qt/Skipped:
- 1:39 AM Changeset in webkit [76217] by
-
- 11 edits in trunk
2011-01-20 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: IDBObjectStore.get should fire onsuccess rather than onerror
https://bugs.webkit.org/show_bug.cgi?id=52725
Update layout tests to expect the onsuccess handler to be fired
when looking up non-existing objects.
- storage/indexeddb/create-and-remove-object-store-expected.txt:
- storage/indexeddb/create-and-remove-object-store.html:
- storage/indexeddb/cursor-delete-expected.txt:
- storage/indexeddb/cursor-delete.html:
- storage/indexeddb/objectstore-removeobjectstore-expected.txt:
- storage/indexeddb/objectstore-removeobjectstore.html:
2011-01-20 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: IDBObjectStore.get should fire onsuccess rather than onerror
https://bugs.webkit.org/show_bug.cgi?id=52725
Let IDBObjectStore.get() fire the onsuccess handler with the value
'undefined' for when an object does not exist in the store.
Update SerializedScriptValue to provide such an undefined value.
- bindings/v8/SerializedScriptValue.cpp: (WebCore::SerializedScriptValue::nullValue): (WebCore::SerializedScriptValue::undefinedValue):
- bindings/v8/SerializedScriptValue.h:
- storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::getInternal):
- 1:28 AM Changeset in webkit [76216] by
-
- 41 edits2 copies2 moves47 adds in trunk
2010-12-27 yury semikhatsky <yurys@chromium.org>
reviewed by pavel feldman.
webcore doesn't fire window.onerror event when uncaught javascript exceptions are thrown
https://bugs.webkit.org/show_bug.cgi?id=8519
uncaught exceptions are propagated to window.onerror hander if one is present.
the handler is expected to be a function accepting three arguments: error message,
resource url and line number where the exception occured.
it was decided to dispatch errorevent to all listeners/handlers no matter if they
were created in the same isolated world where the exception occured or not.
tests: fast/events/window-onerror1.html
fast/events/window-onerror10.html
fast/events/window-onerror11.html
fast/events/window-onerror12.html
fast/events/window-onerror2.html
fast/events/window-onerror3.html
fast/events/window-onerror4.html
fast/events/window-onerror5.html
fast/events/window-onerror6.html
fast/events/window-onerror7.html
fast/events/window-onerror8.html
fast/events/window-onerror9.html
http/tests/security/window-onerror-exception-in-iframe.html
userscripts/window-onerror-for-isolated-world-1.html
userscripts/window-onerror-for-isolated-world-2.html
- android.jscbindings.mk:
- cmakelists.txt:
- gnumakefile.am:
- webcore.gypi:
- webcore.order:
- webcore.pro:
- webcore.vcproj/webcore.vcproj:
- webcore.xcodeproj/project.pbxproj:
- bindings/js/jsbindingsallinone.cpp:
- bindings/js/jsdombinding.cpp: (webcore::reportexception):
- bindings/js/jserrorhandler.cpp: renamed from webcore/bindings/js/jsworkercontexterrorhandler.cpp. (webcore::jserrorhandler::jserrorhandler): (webcore::jserrorhandler::~jserrorhandler): (webcore::jserrorhandler::handleevent):
- bindings/js/jserrorhandler.h: copied from webcore/bindings/js/jsworkercontexterrorhandler.h. (webcore::jserrorhandler::create): (webcore::createjserrorhandler):
- bindings/js/jseventlistener.h:
- bindings/scripts/codegeneratorjs.pm:
- bindings/scripts/codegeneratorv8.pm:
- bindings/v8/v8consolemessage.cpp: (webcore::v8consolemessage::dispatchnow): (webcore::v8consolemessage::handler): the method was changed to use generic webcore exception reporting mechanism which is also used by jsc bindings.
- bindings/v8/v8consolemessage.h:
- bindings/v8/v8eventlistener.h:
- bindings/v8/v8windowerrorhandler.cpp: renamed from webcore/bindings/js/jsworkercontexterrorhandler.h. (webcore::v8windowerrorhandler::v8windowerrorhandler): (webcore::v8windowerrorhandler::calllistenerfunction):
- bindings/v8/v8windowerrorhandler.h: copied from webcore/dom/errorevent.cpp. (webcore::v8windowerrorhandler::create):
- bindings/v8/workercontextexecutionproxy.cpp: (webcore::v8messagehandler):
- bindings/v8/workerscriptcontroller.cpp: (webcore::workerscriptcontroller::evaluate):
- dom/document.cpp: (webcore::document::erroreventtarget): (webcore::document::logexceptiontoconsole): (webcore::document::addmessage):
- dom/document.h:
- dom/errorevent.cpp:
- dom/errorevent.h:
- dom/event.cpp: (webcore::event::iserrorevent):
- dom/event.h:
- dom/scriptexecutioncontext.cpp: (webcore::scriptexecutioncontext::pendingexception::pendingexception): (webcore::scriptexecutioncontext::scriptexecutioncontext): (webcore::scriptexecutioncontext::reportexception): this method is not virtual anymore to ensure that error event dispatching algorithm is the same in workercontext and in document. (webcore::scriptexecutioncontext::dispatcherrorevent):
- dom/scriptexecutioncontext.h:
- websockets/websocket.cpp: (webcore::websocket::connect):
- websockets/websocketchannel.cpp: (webcore::websocketchannel::didopen): (webcore::websocketchannel::didfail): (webcore::websocketchannel::appendtobuffer):
- websockets/websockethandshake.cpp: (webcore::websockethandshake::readserverhandshake): (webcore::websockethandshake::readstatusline): (webcore::websockethandshake::readhttpheaders): (webcore::websockethandshake::checkresponseheaders):
- workers/defaultsharedworkerrepository.cpp: (webcore::postexceptiontask): (webcore::postconsolemessagetask):
- workers/workercontext.cpp: (webcore::workercontext::workercontext): (webcore::workercontext::erroreventtarget): (webcore::workercontext::logexceptiontoconsole): (webcore::workercontext::addmessage):
- workers/workercontext.h:
- workers/workermessagingproxy.cpp: (webcore::workerexceptiontask::performtask): (webcore::postconsolemessagetask):
- xml/xmlhttprequest.cpp: (webcore::reportunsafeusage):
2010-12-27 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
WebCore doesn't fire window.onerror event when uncaught JavaScript exceptions are thrown
https://bugs.webkit.org/show_bug.cgi?id=8519
Uncaught exceptions are propagated to window.onerror hander if one is present.
The handler is expected to be a function accepting three arguments: error message,
resource url and line number where the exception occured.
- fast/events/resources/window-onerror.js: Added. (throwException):
- fast/events/window-onerror1-expected.txt: Added.
- fast/events/window-onerror1.html: Added.
- fast/events/window-onerror10-expected.txt: Added.
- fast/events/window-onerror10.html: Added.
- fast/events/window-onerror11-expected.txt: Added.
- fast/events/window-onerror11.html: Added.
- fast/events/window-onerror12-expected.txt: Added.
- fast/events/window-onerror12.html: Added.
- fast/events/window-onerror2-expected.txt: Added.
- fast/events/window-onerror2.html: Added.
- fast/events/window-onerror3-expected.txt: Added.
- fast/events/window-onerror3.html: Added.
- fast/events/window-onerror4-expected.txt: Added.
- fast/events/window-onerror4.html: Added.
- fast/events/window-onerror5-expected.txt: Added.
- fast/events/window-onerror5.html: Added.
- fast/events/window-onerror6-expected.txt: Added.
- fast/events/window-onerror6.html: Added.
- fast/events/window-onerror7-expected.txt: Added.
- fast/events/window-onerror7.html: Added.
- fast/events/window-onerror8-expected.txt: Added.
- fast/events/window-onerror8.html: Added.
- fast/events/window-onerror9-expected.txt: Added.
- fast/events/window-onerror9.html: Added.
- fast/workers/worker-script-error-expected.txt:
- http/tests/security/resources/onerror-iframe.html: Added.
- http/tests/security/window-onerror-exception-in-iframe-expected.txt: Added.
- http/tests/security/window-onerror-exception-in-iframe.html: Added.
- platform/chromium-win/fast/workers/worker-script-error-expected.txt:
- platform/chromium/fast/events/window-onerror1-expected.txt: Added.
- platform/chromium/fast/events/window-onerror10-expected.txt: Added.
- platform/chromium/fast/events/window-onerror11-expected.txt: Added.
- platform/chromium/fast/events/window-onerror2-expected.txt: Added.
- platform/chromium/fast/events/window-onerror3-expected.txt: Added.
- platform/chromium/fast/events/window-onerror4-expected.txt: Added.
- platform/chromium/fast/events/window-onerror5-expected.txt: Added.
- platform/chromium/fast/events/window-onerror6-expected.txt: Added.
- platform/chromium/fast/events/window-onerror7-expected.txt: Added.
- platform/chromium/fast/events/window-onerror8-expected.txt: Added.
- platform/chromium/fast/events/window-onerror9-expected.txt: Added.
- platform/chromium/http/tests/security/window-onerror-exception-in-iframe-expected.txt: Added.
- platform/chromium/userscripts/window-onerror-for-isolated-world-1-expected.txt: Added.
- platform/chromium/userscripts/window-onerror-for-isolated-world-2-expected.txt: Added.
- platform/gtk/Skipped:
- userscripts/window-onerror-for-isolated-world-1-expected.txt: Added.
- userscripts/window-onerror-for-isolated-world-1.html: Added.
- userscripts/window-onerror-for-isolated-world-2-expected.txt: Added.
- userscripts/window-onerror-for-isolated-world-2.html: Added.
- 1:19 AM Changeset in webkit [76215] by
-
- 12 edits2 adds in trunk
2011-01-19 MORITA Hajime <morrita@google.com>
Reviewed by Ryosuke Niwa.
Space and tab characters "sent" by an input method give totally different results than typing them directly.
https://bugs.webkit.org/show_bug.cgi?id=5241
Added a test that exercises continous whitespace characters and tabs inserted by IME.
- editing/inserting/insert-composition-whitespace-expected.txt: Added.
- editing/inserting/insert-composition-whitespace.html: Added.
2011-01-19 MORITA Hajime <morrita@google.com>
Reviewed by Ryosuke Niwa.
Space and tab characters "sent" by an input method give totally different results than typing them directly
https://bugs.webkit.org/show_bug.cgi?id=5241
- Introduced TextEvent::InputTypeComposition and TypingCommand::TextCompositionType to distinguish text input which is originated by composition.
- Generalized rebalanceWhitespaceAt() to rebalanceWhitespaceOnTextSubstring() to rebalancing range of string on text node, instead of surrounding part of that.
Test: editing/inserting/insert-composition-whitespace.html
- dom/TextEvent.h: (WebCore::TextEvent::isComposition):
- dom/TextEventInputType.h: Added TextEventInputComposition as a member of TextEvent::InputType
- editing/CompositeEditCommand.cpp: (WebCore::containsOnlyWhitespace): (WebCore::CompositeEditCommand::shouldRebalanceLeadingWhitespaceFor): (WebCore::CompositeEditCommand::canRebalance): (WebCore::CompositeEditCommand::rebalanceWhitespaceAt): (WebCore::CompositeEditCommand::rebalanceWhitespaceOnTextSubstring): Added: A generalized version of rebalanceWhitespaceAt(), which takes a range inside Text string.
- editing/CompositeEditCommand.h:
- editing/Editor.cpp: (WebCore::Editor::insertTextForConfirmedComposition): Added. (WebCore::Editor::insertTextWithoutSendingTextEvent): (WebCore::Editor::confirmComposition): Now uses insertTextForConfirmedComposition(). (WebCore::Editor::setComposition):
- editing/Editor.h:
- editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input):
- editing/InsertTextCommand.h:
- editing/TypingCommand.cpp: (WebCore::TypingCommand::TypingCommand): (WebCore::TypingCommand::insertText): (WebCore::TypingCommand::insertTextRunWithoutNewlines):
- editing/TypingCommand.h: Added TypingCommand::m_compositionType and TypingCommand::TextCompositionType (WebCore::TypingCommand::setCompositionType): Added. (WebCore::TypingCommand::create):
- 12:49 AM Changeset in webkit [76214] by
-
- 2 edits in trunk/Source/JavaScriptCore
Follow-up to r75766 / <rdar://problem/5469576>.
Reviewed by Maciej Stachowiak.
We were failing to initialize the key, causing all sorts of unexpected behavior.
- wtf/FastMalloc.cpp:
(WTF::setThreadHeap):
(WTF::TCMalloc_ThreadCache::GetThreadHeap):
(WTF::TCMalloc_ThreadCache::InitTSD): Ensure that the key is initialized.
- 12:15 AM Changeset in webkit [76213] by
-
- 2 edits in trunk/LayoutTests
2011-01-20 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
Skip some tests that are failing on the WebKit2 bot
https://bugs.webkit.org/show_bug.cgi?id=52789
- platform/mac-wk2/Skipped:
