⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 23, 2011:

11:52 PM Changeset in webkit [76485] by yuzo@google.com
  • 2 edits
    15 adds in trunk/LayoutTests

2011-01-23 Yuzo Fujishima <​yuzo@google.com>

Unreviewed Chromium test expectation change.

Update Chromim test expectations (LINUX/SVG) in response to r76442.

  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-text-04-t-expected.txt: Added.
  • platform/chromium-linux/svg/text/text-vkern-on-horizontal-text-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
11:19 PM Changeset in webkit [76484] by yuzo@google.com
  • 14 edits
    3 adds in trunk/LayoutTests

2011-01-23 Yuzo Fujishima <​yuzo@google.com>

Unreviewed Chromium test expectation change.

Update Chromim test expectations (WIN/SVG) in response to r76442.

  • platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.checksum:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.txt:
  • platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.checksum:
  • platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.png:
  • platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Added.
  • platform/chromium-win/svg/text/text-hkern-on-vertical-text-expected.checksum:
  • platform/chromium-win/svg/text/text-hkern-on-vertical-text-expected.png:
  • platform/chromium-win/svg/text/text-hkern-on-vertical-text-expected.txt: Added.
  • platform/chromium-win/svg/text/text-text-04-t-expected.checksum:
  • platform/chromium-win/svg/text/text-text-04-t-expected.png:
  • platform/chromium-win/svg/text/text-text-04-t-expected.txt:
  • platform/chromium-win/svg/text/text-vkern-expected.checksum:
  • platform/chromium-win/svg/text/text-vkern-expected.png:
  • platform/chromium-win/svg/text/text-vkern-expected.txt: Added.
11:13 PM Changeset in webkit [76483] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-23 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: summary bar is not resized properly with the rest of net
​https://bugs.webkit.org/show_bug.cgi?id=52881

  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.updateSidebarWidth): (WebInspector.NetworkPanel.prototype._positionSummaryBar): (WebInspector.NetworkPanel.prototype._toggleGridMode):
10:53 PM Changeset in webkit [76482] by morrita@google.com
  • 12 edits
    2 adds in trunk

2011-01-19 MORITA Hajime <​morrita@google.com>

Reviewed by Ryosuke Niwa.

Space and tab characters "sent" by an input method give totally different results than typing them directly.
​https://bugs.webkit.org/show_bug.cgi?id=5241

Added a test that exercises continous whitespace characters and tabs inserted by IME.

  • editing/inserting/insert-composition-whitespace-expected.txt: Added.
  • editing/inserting/insert-composition-whitespace.html: Added.

2011-01-19 MORITA Hajime <​morrita@google.com>

Reviewed by Ryosuke Niwa.

Space and tab characters "sent" by an input method give totally different results than typing them directly
​https://bugs.webkit.org/show_bug.cgi?id=5241

  • Introduced TextEvent::InputTypeComposition and TypingCommand::TextCompositionType to distinguish text input which is originated by composition.
  • Generalized rebalanceWhitespaceAt() to rebalanceWhitespaceOnTextSubstring() to rebalancing range of string on text node, instead of surrounding part of that.

Test: editing/inserting/insert-composition-whitespace.html

  • dom/TextEvent.h: (WebCore::TextEvent::isComposition):
  • dom/TextEventInputType.h: Added TextEventInputComposition as a member of TextEvent::InputType
  • editing/CompositeEditCommand.cpp: (WebCore::containsOnlyWhitespace): (WebCore::CompositeEditCommand::shouldRebalanceLeadingWhitespaceFor): (WebCore::CompositeEditCommand::canRebalance): (WebCore::CompositeEditCommand::rebalanceWhitespaceAt): (WebCore::CompositeEditCommand::rebalanceWhitespaceOnTextSubstring): Added: A generalized version of rebalanceWhitespaceAt(), which takes a range inside Text string.
  • editing/CompositeEditCommand.h:
  • editing/Editor.cpp: (WebCore::Editor::insertTextForConfirmedComposition): Added. (WebCore::Editor::insertTextWithoutSendingTextEvent): (WebCore::Editor::confirmComposition): Now uses insertTextForConfirmedComposition(). (WebCore::Editor::setComposition):
  • editing/Editor.h:
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input):
  • editing/InsertTextCommand.h:
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::TypingCommand): (WebCore::TypingCommand::insertText): (WebCore::TypingCommand::insertTextRunWithoutNewlines):
  • editing/TypingCommand.h: Added TypingCommand::m_compositionType and TypingCommand::TextCompositionType (WebCore::TypingCommand::setCompositionType): Added. (WebCore::TypingCommand::create):
9:37 PM Changeset in webkit [76481] by yuzo@google.com
  • 15 edits
    4 adds in trunk/LayoutTests

2011-01-23 Yuzo Fujishima <​yuzo@google.com>

Unreviewed Chromium test expectation change.
Update Chromim test expectations (WIN) in response to r76442.

  • platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-04-t-expected.txt:
  • platform/chromium-win/svg/batik/text/xmlSpace-expected.txt:
  • platform/chromium-win/svg/text/text-hkern-expected.txt: Added.
  • platform/chromium-win/svg/text/text-vkern-on-horizontal-text-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
8:52 PM Changeset in webkit [76480] by tkent@chromium.org
  • 2 edits in branches/chromium/597/WebCore

Merge 76319

2011-01-20 Xiaomei Ji <​xji@chromium.org>

Reviewed by Dan Bernstein.

Fix regression(r71566): PDF in RTL block might messes up text directionality.
​https://bugs.webkit.org/show_bug.cgi?id=52776

Test: fast/dom/52776.html

  • platform/text/BidiResolver.h: (WebCore::::checkDirectionInLowerRaiseEmbeddingLevel): (WebCore::::lowerExplicitEmbeddingLevel): (WebCore::::raiseExplicitEmbeddingLevel): (WebCore::::createBidiRunsForLine):

BUG=70234
TBR=laforge

7:48 PM Changeset in webkit [76479] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2011-01-23 Yuzo Fujishima <​yuzo@google.com>

Unreviewed Chromium test expectation change.
Mark fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport.html as TEXT for LINUX.

  • platform/chromium/test_expectations.txt:
7:46 PM Changeset in webkit [76478] by mrowe@apple.com
  • 8 edits in trunk/Source

Follow-up to r76477.

Fix the scripts that detect problematic code such as static initializers
and destructors, weak vtables, inappropriate files in the framework wrappers,
and public headers including private headers. These had all been broken
since the projects were moved in to the Source directory as the paths to the
scripts were not updated at that time.

Source/JavaScriptCore:

Source/JavaScriptGlue:

  • JavaScriptGlue.xcodeproj/project.pbxproj:

Source/WebCore:

Stop copying an IDL file in to the framework wrapper. Doing that doesn't even make sense.

  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj:
7:26 PM Changeset in webkit [76477] by mrowe@apple.com
  • 3 edits in trunk/Source/WebCore

Build fix after r76459.

Static member variables or globals of types that have constructors or destructors are bad as
they generate static initializers and destructors. This is code that is run either at link time
when the library is loaded in to memory or at application termination time. Both of these are
terrible for performance and are thus outlawed in WebKit code.

The typical solution is to replace the static member or global with a function that allocates
the necessary variable on the heap. The variable is leaked to prevent it from being destroyed
at application termination time. The DEFINE_STATIC_LOCAL macro wraps this in to a concise little
package, but sadly fails to work in this case due to the type containing multiple template
parameters.

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::inspectorAgents):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::bindInspectorAgent):
(WebCore::InspectorInstrumentation::unbindInspectorAgent):
(WebCore::InspectorInstrumentation::inspectorAgentForPage):

6:33 PM Changeset in webkit [76476] by yuzo@google.com
  • 15 edits
    4 adds
    7 deletes in trunk/LayoutTests

2011-01-23 Yuzo Fujishima <​yuzo@google.com>

Unreviewed Chromium test expectation change.
Update Chromim test expectations in response to r76442.

  • platform/chromium-linux/fast/css/acid2-expected.txt: Added.
  • platform/chromium-linux/fast/css/acid2-pixel-expected.checksum:
  • platform/chromium-linux/fast/css/acid2-pixel-expected.png:
  • platform/chromium-linux/fast/css/acid2-pixel-expected.txt: Added.
  • platform/chromium-linux/fast/forms/button-sizes-expected.checksum:
  • platform/chromium-linux/fast/forms/button-sizes-expected.png:
  • platform/chromium-linux/fast/forms/button-sizes-expected.txt:
  • platform/chromium-linux/fast/forms/input-button-sizes-expected.checksum:
  • platform/chromium-linux/fast/forms/input-button-sizes-expected.png:
  • platform/chromium-linux/fast/forms/input-button-sizes-expected.txt:
  • platform/chromium-linux/http/tests/misc/acid2-expected.txt: Added.
  • platform/chromium-linux/http/tests/misc/acid2-pixel-expected.checksum:
  • platform/chromium-linux/http/tests/misc/acid2-pixel-expected.png:
  • platform/chromium-linux/http/tests/misc/acid2-pixel-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
  • platform/chromium-linux/svg/hixie/perf/003-expected.txt: Removed.
  • platform/chromium-linux/svg/hixie/perf/004-expected.txt: Removed.
  • platform/chromium-linux/svg/hixie/perf/005-expected.txt: Removed.
  • platform/chromium-linux/svg/hixie/perf/006-expected.txt: Removed.
  • platform/chromium-linux/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt: Removed.
  • platform/chromium-linux/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt: Removed.
  • platform/chromium-linux/svg/text/text-text-01-b-expected.checksum:
  • platform/chromium-linux/svg/text/text-text-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-text-01-b-expected.txt:
5:53 PM Changeset in webkit [76475] by vangelis@chromium.org
  • 11 edits in trunk/Source/WebCore

2011-01-21 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Add support for -webkit-mask properties to the
accelerated compositing path.
​https://bugs.webkit.org/show_bug.cgi?id=49780


Tests: Existing tests in LayoutTests/compositing/masks

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::draw): (WebCore::ContentLayerChromium::unreserveContentsTexture): (WebCore::ContentLayerChromium::bindContentsTexture):
  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::setMaskLayer):
  • platform/graphics/chromium/GraphicsLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::LayerChromium):
  • platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::setMaskLayer): (WebCore::LayerChromium::maskLayer): (WebCore::LayerChromium::unreserveContentsTexture): (WebCore::LayerChromium::bindContentsTexture):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updateLayersRecursive):
  • platform/graphics/chromium/LayerTexture.cpp: (WebCore::LayerTexture::bindTexture):
  • platform/graphics/chromium/RenderSurfaceChromium.cpp: (WebCore::RenderSurfaceChromium::SharedValues::SharedValues): (WebCore::RenderSurfaceChromium::SharedValues::~SharedValues): (WebCore::RenderSurfaceChromium::RenderSurfaceChromium): (WebCore::RenderSurfaceChromium::draw):
  • platform/graphics/chromium/RenderSurfaceChromium.h: (WebCore::RenderSurfaceChromium::SharedValues::maskShaderProgram): (WebCore::RenderSurfaceChromium::SharedValues::maskShaderSamplerLocation): (WebCore::RenderSurfaceChromium::SharedValues::maskShaderMaskSamplerLocation): (WebCore::RenderSurfaceChromium::SharedValues::maskShaderMatrixLocation): (WebCore::RenderSurfaceChromium::SharedValues::maskShaderAlphaLocation):
5:00 PM Changeset in webkit [76474] by Patrick Gansterer
  • 8 edits in trunk/Source

2011-01-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Use WTF::StringHasher in WebCore
​https://bugs.webkit.org/show_bug.cgi?id=52934

Add an additional function to calculate the hash
of data with a runtimedependent size.

  • wtf/StringHasher.h: (WTF::StringHasher::createBlobHash):

2011-01-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Use WTF::StringHasher in WebCore
​https://bugs.webkit.org/show_bug.cgi?id=52934

  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::urlHostHash):
  • platform/LinkHash.cpp: (WebCore::visitedLinkHashInline):
  • platform/cf/BinaryPropertyList.cpp: (WebCore::IntegerArrayHash::hash):
  • platform/graphics/wx/FontPlatformDataWx.cpp: (WebCore::FontPlatformData::computeHash):
  • platform/network/ProtectionSpaceHash.h: (WebCore::ProtectionSpaceHash::hash):
3:50 PM Changeset in webkit [76473] by kdecker@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-01-23 Damian Kaleta <​dkaleta@apple.com>

Reviewed by Kevin Decker.

<rdar://problem/8905171>
​https://bugs.webkit.org/show_bug.cgi?id=52985

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::scaleWebView): Eliminated early return inside WebPageProxy::scaleWebView, making it consistent with WebKit1.
3:17 PM Changeset in webkit [76472] by Patrick Gansterer
  • 11 edits in trunk/Source/WebCore

2011-01-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by David Kilzer.

Add an overload to base64Encode with String output
​https://bugs.webkit.org/show_bug.cgi?id=50122

This change removes duplicated code.

  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::resourceContentBase64):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::btoa):
  • platform/graphics/skia/FontCustomPlatformData.cpp: (WebCore::createUniqueFontName):
  • platform/graphics/win/FontCustomPlatformData.cpp: (WebCore::createUniqueFontName):
  • platform/graphics/wince/FontCustomPlatformData.cpp: (WebCore::createUniqueFontName):
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::encodeBasicAuthorization):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::encodeBasicAuthorization):
  • platform/text/Base64.cpp: (WebCore::base64Encode):
  • platform/text/Base64.h: (WebCore::base64Encode):
  • platform/wince/KeygenWinCE.cpp: (WebCore::WebCore::signedPublicKeyAndChallengeString):
2:57 PM Changeset in webkit [76471] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by David Kilzer.

Fix comment in String::ascii()
​https://bugs.webkit.org/show_bug.cgi?id=52980

  • wtf/text/WTFString.cpp: (WTF::String::ascii):
2:28 PM Changeset in webkit [76470] by ap@apple.com
  • 3 edits
    2 adds in trunk/Source/WebKit2

2011-01-23 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=52968
Use a separate NSView for printing

Also addresses <rdar://problem/8900148> Improper check for
-[NSGraphicsContext currentContextDrawingToScreen]

  • UIProcess/API/mac/WKPrintingView.h: Added.
  • UIProcess/API/mac/WKPrintingView.mm: Added. (-[WKPrintingView initWithFrameProxy:]): (-[WKPrintingView isFlipped]): (-[WKPrintingView _adjustPrintingMarginsForHeaderAndFooter]): (-[WKPrintingView knowsPageRange:]): (-[WKPrintingView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]): (-[WKPrintingView drawPageBorderWithSize:]): (-[WKPrintingView _provideTotalScaleFactorForPrintOperation:]): (-[WKPrintingView rectForPage:]):
  • UIProcess/API/mac/WKView.mm: (-[WKView drawRect:]): (-[WKView canChangeFrameLayout:]): (-[WKView printOperationWithPrintInfo:forFrame:]):
  • WebKit2.xcodeproj/project.pbxproj: Moved printing code to a separate view, simplifying as appropriate. The view is currently not referenced by anything in WebKit2 directly, being owned by NSPrintOperation.
2:02 PM Changeset in webkit [76469] by Patrick Gansterer
  • 4 edits in trunk/Source

2011-01-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by David Kilzer.

Add String::containsOnlyLatin1()
​https://bugs.webkit.org/show_bug.cgi?id=52979

  • wtf/text/WTFString.h: (WTF::String::containsOnlyLatin1): (WTF::charactersAreAllLatin1):

2011-01-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by David Kilzer.

Add String::containsOnlyLatin1()
​https://bugs.webkit.org/show_bug.cgi?id=52979

Use String::containsOnlyLatin1() instead of isSafeToConvertCharList().

  • page/DOMWindow.cpp: (WebCore::DOMWindow::btoa): (WebCore::DOMWindow::atob):
1:08 PM Changeset in webkit [76468] by ap@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

2011-01-23 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=15649
Empty STYLE elements are not reflected into the document.styleSheets object

Adding a test for a bug that no longer occurs.

  • fast/dom/document-stylesheets-empty-style-expected.txt: Added.
  • fast/dom/document-stylesheets-empty-style.html: Added.
11:50 AM Changeset in webkit [76467] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-01-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[CMake] Add missing CodeGenerator dependencies
​https://bugs.webkit.org/show_bug.cgi?id=52976

  • CMakeLists.txt:
11:28 AM Changeset in webkit [76466] by yael.aharon@nokia.com
  • 3 edits in trunk/Source/WebCore

2011-01-23 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt][Symbian] Fix --minimal build
​https://bugs.webkit.org/show_bug.cgi?id=52839

Some of the plugins' functionality is reimplemented in
Symbian specific files.
Some of this functionality should be compiled in even if
the guard NETSCAPE_PLUGIN_API is turned off.
This patch moves that functionality out of the
NETSCAPE_PLUGIN_API guard.

Build fix so no new tests.

  • WebCore.pro:
  • plugins/symbian/PluginPackageSymbian.cpp:
11:16 AM Changeset in webkit [76465] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Oliver Hunt.

Remove obsolete JSVALUE32 code
​https://bugs.webkit.org/show_bug.cgi?id=52948

r70111 removed support for JSVALUE32.
ARM, MIPS and X86 support JSVALUE32_64 only.

  • jit/JITStubs.cpp:
9:33 AM Changeset in webkit [76464] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit/mac

<rdar://problem/6097826> Mail's cursor does not become a resize cursor when moving mouse from scrolled email to the horizontal splitter

Reviewed by John Sullivan.

  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::setCursor): If the current cursor comes from a cursor rect, do not override it.

8:24 AM Changeset in webkit [76463] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebCore

2011-01-23 Andreas Kling <​kling@webkit.org>

Reviewed by Tor Arne Vestbø.

[Qt] Use rad2deg() from WTF instead of rolling our own.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::rotate):
  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::addArc):
6:43 AM Changeset in webkit [76462] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-01-23 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Andreas Kling.

Viewport meta: Always adjust device dimensions to the device pixel ratio.

  • dom/ViewportArguments.cpp: (WebCore::computeViewportAttributes):
6:33 AM Changeset in webkit [76461] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-01-23 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

Don't scale absolute geometry specified by viewport meta tag.

  • dom/ViewportArguments.cpp: (WebCore::computeViewportAttributes):
2:48 AM Changeset in webkit [76460] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-23 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed build fix.

Web Inspector: looks like efl doesn't regenerate InspectorBackendDispatcher.

Touch Inspector.idl.

  • inspector/Inspector.idl:
1:36 AM Changeset in webkit [76459] by pfeldman@chromium.org
  • 33 edits
    2 copies in trunk/Source

2011-01-22 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: next step in splitting InspectorController.

Splitting InspectorController is a bit tricky process.

As a first step I'll do the next things:
1) rename existing InspectorController to InspectorAgent;
2) s/nspectorController/nspectorAgent/g everywhere in WebCore/inspector but InspectorInstrumentation;
3) create a fake InspectorController derived from the InspectorAgent for the rest of WebCore and WebKit;

The second step is a migration of a small set of functions described in bug 52510 from InspectorAgent to InspectorController.

As far as the second step will have significant changes in the functions' implementation I'll do it as a separate patch.

​https://bugs.webkit.org/show_bug.cgi?id=52955

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::nodeForId): (WebCore::JSInjectedScriptHost::selectDOMStorage):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::nodeForIdCallback):
  • inspector/CodeGeneratorInspector.pm:
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::InjectedScriptHost): (WebCore::InjectedScriptHost::clearConsoleMessages): (WebCore::InjectedScriptHost::databaseForId): (WebCore::InjectedScriptHost::selectDatabase): (WebCore::InjectedScriptHost::selectDOMStorage): (WebCore::InjectedScriptHost::injectedScriptForMainFrame): (WebCore::InjectedScriptHost::inspectorDOMAgent): (WebCore::InjectedScriptHost::frontend): (WebCore::InjectedScriptHost::didCreateWorker): (WebCore::InjectedScriptHost::didDestroyWorker):
  • inspector/InjectedScriptHost.h: (WebCore::InjectedScriptHost::create): (WebCore::InjectedScriptHost::inspectorAgent): (WebCore::InjectedScriptHost::disconnectController):
  • inspector/InspectorAgent.cpp: Copied from Source/WebCore/inspector/InspectorController.cpp. (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::~InspectorAgent): (WebCore::InspectorAgent::inspectedPageDestroyed): (WebCore::InspectorAgent::enabled): (WebCore::InspectorAgent::inspectorStartsAttached): (WebCore::InspectorAgent::setInspectorStartsAttached): (WebCore::InspectorAgent::setInspectorAttachedHeight): (WebCore::InspectorAgent::inspectorAttachedHeight): (WebCore::InspectorAgent::searchingForNodeInPage): (WebCore::InspectorAgent::restoreInspectorStateFromCookie): (WebCore::InspectorAgent::inspect): (WebCore::InspectorAgent::focusNode): (WebCore::InspectorAgent::highlight): (WebCore::InspectorAgent::highlightDOMNode): (WebCore::InspectorAgent::highlightFrame): (WebCore::InspectorAgent::hideHighlight): (WebCore::InspectorAgent::mouseDidMoveOverElement): (WebCore::InspectorAgent::handleMousePress): (WebCore::InspectorAgent::setInspectorFrontendClient): (WebCore::InspectorAgent::didClearWindowObjectInWorld): (WebCore::InspectorAgent::setSearchingForNode): (WebCore::InspectorAgent::connectFrontend): (WebCore::InspectorAgent::show): (WebCore::InspectorAgent::showPanel): (WebCore::InspectorAgent::close): (WebCore::InspectorAgent::disconnectFrontend): (WebCore::InspectorAgent::resourceAgent): (WebCore::InspectorAgent::releaseFrontendLifetimeAgents): (WebCore::InspectorAgent::populateScriptObjects): (WebCore::InspectorAgent::pushDataCollectedOffline): (WebCore::InspectorAgent::restoreDebugger): (WebCore::InspectorAgent::restoreProfiler): (WebCore::InspectorAgent::unbindAllResources): (WebCore::InspectorAgent::didCommitLoad): (WebCore::InspectorAgent::mainResourceFiredDOMContentEvent): (WebCore::InspectorAgent::mainResourceFiredLoadEvent): (WebCore::InspectorAgent::isMainResourceLoader): (WebCore::InspectorAgent::willSendRequest): (WebCore::InspectorAgent::ensureSettingsLoaded): (WebCore::InspectorAgent::startTimelineProfiler): (WebCore::InspectorAgent::stopTimelineProfiler): (WebCore::PostWorkerNotificationToFrontendTask::create): (WebCore::PostWorkerNotificationToFrontendTask::PostWorkerNotificationToFrontendTask): (WebCore::PostWorkerNotificationToFrontendTask::performTask): (WebCore::InspectorAgent::postWorkerNotificationToFrontend): (WebCore::InspectorAgent::didCreateWorker): (WebCore::InspectorAgent::didDestroyWorker): (WebCore::InspectorAgent::didOpenDatabase): (WebCore::InspectorAgent::getCookies): (WebCore::InspectorAgent::buildArrayForCookies): (WebCore::InspectorAgent::buildObjectForCookie): (WebCore::InspectorAgent::deleteCookie): (WebCore::InspectorAgent::didUseDOMStorage): (WebCore::InspectorAgent::didCreateWebSocket): (WebCore::InspectorAgent::willSendWebSocketHandshakeRequest): (WebCore::InspectorAgent::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorAgent::didCloseWebSocket): (WebCore::InspectorAgent::isRecordingUserInitiatedProfile): (WebCore::InspectorAgent::startUserInitiatedProfiling): (WebCore::InspectorAgent::stopUserInitiatedProfiling): (WebCore::InspectorAgent::profilerEnabled): (WebCore::InspectorAgent::enableProfiler): (WebCore::InspectorAgent::disableProfiler): (WebCore::InspectorAgent::showAndEnableDebugger): (WebCore::InspectorAgent::enableDebugger): (WebCore::InspectorAgent::disableDebugger): (WebCore::InspectorAgent::resume): (WebCore::InspectorAgent::setAllBrowserBreakpoints): (WebCore::InspectorAgent::evaluateForTestInFrontend): (WebCore::InspectorAgent::didEvaluateForTestInFrontend): (WebCore::quadToPath): (WebCore::drawOutlinedQuad): (WebCore::drawOutlinedQuadWithClip): (WebCore::drawHighlightForBox): (WebCore::drawHighlightForLineBoxesOrSVGRenderer): (WebCore::convertFromFrameToMainFrame): (WebCore::frameToMainFrameOffset): (WebCore::InspectorAgent::drawNodeHighlight): (WebCore::InspectorAgent::drawElementTitle): (WebCore::InspectorAgent::openInInspectedWindow): (WebCore::InspectorAgent::addScriptToEvaluateOnLoad): (WebCore::InspectorAgent::removeAllScriptsToEvaluateOnLoad): (WebCore::InspectorAgent::setInspectorExtensionAPI): (WebCore::InspectorAgent::inspectedURL): (WebCore::InspectorAgent::reloadPage): (WebCore::InspectorAgent::setExtraHeaders):
  • inspector/InspectorAgent.h: Copied from Source/WebCore/inspector/InspectorController.h. (WebCore::InspectorAgent::inspectorBackendDispatcher): (WebCore::InspectorAgent::inspectorClient): (WebCore::InspectorAgent::injectedScriptHost): (WebCore::InspectorAgent::inspectedPage): (WebCore::InspectorAgent::hideDOMNodeHighlight): (WebCore::InspectorAgent::hideFrameHighlight): (WebCore::InspectorAgent::frontend): (WebCore::InspectorAgent::inspectorController): (WebCore::InspectorAgent::inspectorAgent): (WebCore::InspectorAgent::consoleAgent): (WebCore::InspectorAgent::cssAgent): (WebCore::InspectorAgent::domAgent): (WebCore::InspectorAgent::injectedScriptAgent): (WebCore::InspectorAgent::runtimeAgent): (WebCore::InspectorAgent::timelineAgent): (WebCore::InspectorAgent::databaseAgent): (WebCore::InspectorAgent::domStorageAgent): (WebCore::InspectorAgent::fileSystemAgent): (WebCore::InspectorAgent::browserDebuggerAgent): (WebCore::InspectorAgent::debuggerAgent): (WebCore::InspectorAgent::profilerAgent): (WebCore::InspectorAgent::applicationCacheAgent): (WebCore::InspectorAgent::hasInspectorFrontendClient): (WebCore::InspectorAgent::hasFrontend): (WebCore::InspectorAgent::startProfiling): (WebCore::InspectorAgent::stopProfiling): (WebCore::InspectorAgent::debuggerEnabled): (WebCore::InspectorAgent::state): (WebCore::InspectorAgent::settings):
  • inspector/InspectorApplicationCacheAgent.cpp: (WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent): (WebCore::InspectorApplicationCacheAgent::getApplicationCaches):
  • inspector/InspectorApplicationCacheAgent.h:
  • inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent): (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged): (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode): (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode): (WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr): (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent): (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded): (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
  • inspector/InspectorBrowserDebuggerAgent.h: (WebCore::InspectorBrowserDebuggerAgent::create):
  • inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::InspectorConsoleAgent): (WebCore::InspectorConsoleAgent::~InspectorConsoleAgent): (WebCore::InspectorConsoleAgent::clearConsoleMessages): (WebCore::InspectorConsoleAgent::addMessageToConsole): (WebCore::InspectorConsoleAgent::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorConsoleAgent::didReceiveResponse): (WebCore::InspectorConsoleAgent::didFailLoading): (WebCore::InspectorConsoleAgent::setMonitoringXHREnabled): (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled): (WebCore::InspectorConsoleAgent::addConsoleMessage):
  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController):
  • inspector/InspectorController.h:
  • inspector/InspectorDatabaseAgent.cpp:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::create): (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent): (WebCore::InspectorDebuggerAgent::~InspectorDebuggerAgent): (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame): (WebCore::InspectorDebuggerAgent::getCompletionsOnCallFrame): (WebCore::InspectorDebuggerAgent::currentCallFrames):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorFileSystemAgent.cpp: (WebCore::InspectorFileSystemAgentCallbacks::didOpenFileSystem): (WebCore::InspectorFileSystemAgent::InspectorFileSystemAgent): (WebCore::InspectorFileSystemAgent::stop): (WebCore::InspectorFileSystemAgent::getFileSystemPathAsync): (WebCore::InspectorFileSystemAgent::didGetFileSystemPath): (WebCore::InspectorFileSystemAgent::didGetFileSystemError):
  • inspector/InspectorFileSystemAgent.h: (WebCore::InspectorFileSystemAgent::create):
  • inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::setExtensionAPI):
  • inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::create): (WebCore::InspectorProfilerAgent::InspectorProfilerAgent): (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole): (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole): (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling): (WebCore::InspectorProfilerAgent::stopUserInitiatedProfiling):
  • inspector/InspectorProfilerAgent.h:

2011-01-22 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: next step in splitting InspectorController.

#include "InspectorController.h" was added.

​https://bugs.webkit.org/show_bug.cgi?id=52955

  • WebCoreSupport/InspectorServerQt.cpp:

Jan 22, 2011:

9:48 PM Changeset in webkit [76458] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2011-01-22 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Oliver Hunt.

Skip a test that seems to cause the subsequent test to sporadically fail, and unskip the several tests after it
​https://bugs.webkit.org/show_bug.cgi?id=52970

  • platform/mac-wk2/Skipped:
9:03 PM Changeset in webkit [76457] by ggaren@apple.com
  • 5 edits
    1 add in trunk

2011-01-22 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Dan Bernstein.

ASSERT running run-webkit-tests --threaded.
​https://bugs.webkit.org/show_bug.cgi?id=52971


SunSpider and v8 report no change.

  • runtime/ConservativeSet.cpp: (JSC::ConservativeSet::grow): (JSC::ConservativeSet::add):
  • runtime/ConservativeSet.h: Tweaked the inline capacity to 128, and the growth policy to 2X, to make SunSpider and v8 happy. (JSC::ConservativeSet::ConservativeSet): (JSC::ConservativeSet::~ConservativeSet): (JSC::ConservativeSet::mark): Use OSAllocator directly, instead of malloc. Malloc is forbidden during a multi-threaded mark phase because it can cause deadlock.

2011-01-22 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Dan Bernstein.

Beefed up --threaded mode to catch even more kinds of errors.
​https://bugs.webkit.org/show_bug.cgi?id=52971

  • DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared context group to force JSC to mark multiple threads. (This used to be the default, but it changed in SnowLeopard.) (runJavaScriptThread): Do more locking and unlocking, and more allocation, to give threading mistakes more chances to show themselves. (startJavaScriptThreads): (stopJavaScriptThreads):
4:33 PM Changeset in webkit [76456] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-22 Chris Rogers <​crogers@google.com>

Rubber-stamped by Anders Carlsson.

Fix FFTFrameStub to compile properly
​https://bugs.webkit.org/show_bug.cgi?id=52969

No new tests since this is a build fix.

  • platform/audio/FFTFrameStub.cpp: (WebCore::FFTFrame::FFTFrame):
1:55 PM Changeset in webkit [76455] by jam@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-01-22 John Abd-El-Malek <​jam@chromium.org>

Reviewed by Adam Barth.

[chromium]: Fix WebScrollbarImpl not getting scroll events after recent scrollbar refactoring
​https://bugs.webkit.org/show_bug.cgi?id=52967

  • src/WebScrollbarImpl.cpp: (WebKit::WebScrollbarImpl::horizontalScrollbar): (WebKit::WebScrollbarImpl::verticalScrollbar):
  • src/WebScrollbarImpl.h:
12:11 PM Changeset in webkit [76454] by ggaren@apple.com
  • 12 edits
    2 adds in trunk/Source/JavaScriptCore

2011-01-22 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Geoffrey Garen.

Rubber-stamped by Maciej Stachowiak.

A few of Maciej's review suggestions for my last patch.
​https://bugs.webkit.org/show_bug.cgi?id=52946

SunSpider reports no change.

  • runtime/ConservativeSet.cpp: Added. (JSC::isPointerAligned): (JSC::ConservativeSet::add):
  • runtime/ConservativeSet.h: Added. (JSC::ConservativeSet::ConservativeSet): (JSC::ConservativeSet::mark): Split ConservativeSet out into its own file, and moved the conservative check into ConservativeSet::add, making ConservativeSet's responsibility clearer.
  • runtime/Heap.cpp: (JSC::Heap::markRoots):
  • runtime/MachineStackMarker.cpp: (JSC::MachineStackMarker::markCurrentThreadConservativelyInternal): (JSC::MachineStackMarker::markOtherThreadConservatively):
  • runtime/MachineStackMarker.h:
  • runtime/MarkStack.h: Updated for changes above.
11:56 AM Changeset in webkit [76453] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-01-22 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Transparent windows with compositing WebKit2 content show garbage
​https://bugs.webkit.org/show_bug.cgi?id=52966
<rdar://problem/8765051>

  • UIProcess/mac/LayerBackedDrawingAreaProxyMac.mm: (WebKit::LayerBackedDrawingAreaProxy::paint): If the WKView should draw transparent background, do so.
11:36 AM Changeset in webkit [76452] by andersca@apple.com
  • 13 edits in trunk/Source/WebKit2

2011-01-22 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Add an asynchronous WKPageForceRepaint
​https://bugs.webkit.org/show_bug.cgi?id=52964
<rdar://problem/8898527>

  • UIProcess/API/C/WKPage.cpp: (WKPageForceRepaint): Call WebPageProxy::forceRepaint.
  • UIProcess/API/C/WKPage.h: Add WKPageForceRepaint.
  • UIProcess/GenericCallback.h: Add a "generic" VoidCallback class.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::forceRepaint): Insert the callback in the m_voidCallbacks map and send a forceRepaint message.

(WebKit::WebPageProxy::voidCallback):
Call the right void callback.

(WebKit::WebPageProxy::processDidCrash):
Invalidate m_voidCallbacks.

  • UIProcess/WebPageProxy.messages.in: Add a VoidCallback message.
  • WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp: (WebKit::ChunkedUpdateDrawingArea::forceRepaint): Force a repaint.
  • WebProcess/WebPage/ChunkedUpdateDrawingArea.h: Add forceRepaint.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::forceRepaint): Call forceRepaint on the drawing area.
  • WebProcess/WebPage/WebPage.messages.in: Add a ForceRepaint message.
9:27 AM Changeset in webkit [76451] by robert@webkit.org
  • 10 edits in trunk

2011-01-22 Robert Hogan <​robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Support layoutTestController.addURLToRedirect()
​https://bugs.webkit.org/show_bug.cgi?id=52956

  • platform/qt/Skipped:

2011-01-22 Robert Hogan <​robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Support layoutTestController.addURLToRedirect()
​https://bugs.webkit.org/show_bug.cgi?id=52956

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::addURLToRedirect):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
  • WebCoreSupport/FrameLoaderClientQt.h:

2011-01-22 Robert Hogan <​robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Support layoutTestController.addURLToRedirect()
​https://bugs.webkit.org/show_bug.cgi?id=52956

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::addURLToRedirect):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
8:16 AM Changeset in webkit [76450] by Nikolas Zimmermann
  • 24 edits in trunk/LayoutTests

2011-01-22 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

REGRESSION: Vertical line metrics incorrect
​https://bugs.webkit.org/show_bug.cgi?id=52960

Revert accidently landed mac baseline changes.

  • platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-04-t-expected.txt:
  • platform/mac/svg/batik/text/xmlSpace-expected.txt:
  • platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
  • platform/mac/svg/custom/svg-fonts-in-html-expected.txt:
  • platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt:
  • platform/mac/svg/text/text-hkern-expected.txt:
  • platform/mac/svg/text/text-hkern-on-vertical-text-expected.txt:
  • platform/mac/svg/text/text-text-04-t-expected.txt:
  • platform/mac/svg/text/text-vkern-expected.txt:
  • platform/mac/svg/text/text-vkern-on-horizontal-text-expected.txt:
  • platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
7:14 AM Changeset in webkit [76449] by Nikolas Zimmermann
  • 38 edits in trunk/LayoutTests/platform

2011-01-22 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

REGRESSION: Vertical line metrics incorrect
​https://bugs.webkit.org/show_bug.cgi?id=52960

Rebaselined several text dumps from the bots, after the FontMetrics change.
All show 1px diffs, but are progressions, since the lineSpacing calculation has been improved.
Mac still has the old results - as it depends on a rounding trick at the moment.

  • platform/gtk/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
  • platform/gtk/svg/text/text-hkern-expected.txt:
  • platform/gtk/svg/text/text-hkern-on-vertical-text-expected.txt:
  • platform/gtk/svg/text/text-vkern-expected.txt:
  • platform/gtk/svg/text/text-vkern-on-horizontal-text-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-04-t-expected.txt:
  • platform/mac/svg/batik/text/xmlSpace-expected.txt:
  • platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
  • platform/mac/svg/custom/svg-fonts-in-html-expected.txt:
  • platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt:
  • platform/mac/svg/text/text-hkern-expected.txt:
  • platform/mac/svg/text/text-hkern-on-vertical-text-expected.txt:
  • platform/mac/svg/text/text-text-04-t-expected.txt:
  • platform/mac/svg/text/text-vkern-expected.txt:
  • platform/mac/svg/text/text-vkern-on-horizontal-text-expected.txt:
  • platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
  • platform/qt/css2.1/t1507-c526-font-sz-02-b-a-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
  • platform/qt/svg/text/text-hkern-expected.txt:
  • platform/qt/svg/text/text-hkern-on-vertical-text-expected.txt:
  • platform/qt/svg/text/text-vkern-expected.txt:
  • platform/qt/svg/text/text-vkern-on-horizontal-text-expected.txt:
  • platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
7:00 AM Changeset in webkit [76448] by andreip@google.com
  • 7 edits
    2 adds in trunk

2011-01-22 Andrei Popescu <​andreip@google.com>

Reviewed by Jeremy Orlow.

IndexedDB corrupts data on disk
​https://bugs.webkit.org/show_bug.cgi?id=52890

  • storage/indexeddb/data-corruption-expected.txt: Added.
  • storage/indexeddb/data-corruption.html: Added.

2011-01-22 Andrei Popescu <​andreip@google.com>

Reviewed by Jeremy Orlow.

IndexedDB corrupts data on disk
​https://bugs.webkit.org/show_bug.cgi?id=52890

We need to store the SerializedScriptValues on disk in a BLOB column rather than TEXT.
Test: storage/indexeddb/data-corruption.html

  • platform/sql/SQLiteStatement.cpp: (WebCore::SQLiteStatement::bindBlob): (WebCore::SQLiteStatement::getColumnBlobAsString): (WebCore::SQLiteStatement::getColumnBlobAsVector):
  • platform/sql/SQLiteStatement.h:
  • storage/IDBCursorBackendImpl.cpp: (WebCore::IDBCursorBackendImpl::loadCurrentRow):
  • storage/IDBFactoryBackendImpl.cpp: (WebCore::runCommands): (WebCore::createTables): (WebCore::createMetaDataTable): (WebCore::migrateDatabase):
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::getInternal): (WebCore::putObjectStoreData):
6:18 AM Changeset in webkit [76447] by Nikolas Zimmermann
  • 3 edits in trunk/Source/WebCore

2011-01-22 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Fix WinCE build.

  • platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::GraphicsContext::drawText):
  • rendering/RenderThemeWinCE.cpp: (WebCore::RenderThemeWinCE::adjustMenuListButtonStyle):
6:13 AM Changeset in webkit [76446] by robert@webkit.org
  • 4 edits
    4 adds in trunk

2011-01-22 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
​https://bugs.webkit.org/show_bug.cgi?id=49802

  • platform/qt/Skipped:
  • platform/qt/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt: Added.
  • platform/qt/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt: Added.
  • platform/qt/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt: Added.

2011-01-22 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
​https://bugs.webkit.org/show_bug.cgi?id=49802

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): (WebCore::DumpRenderTree::open):
5:46 AM Changeset in webkit [76445] by Nikolas Zimmermann
  • 15 edits in trunk/Source/WebCore

2011-01-22 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

REGRESSION: Vertical line metrics incorrect
​https://bugs.webkit.org/show_bug.cgi?id=52960

SimpleFontDataMac.mm contains a hack to modifiy lineGap/descent for the 'Hiragino' font.
That didn't influence the lineSpacing so far, but does now, causing regressions.

Restore old line spacing behaviour to fix the regression.
Covered by existing fast/blockflow, fast/repaint and fast/text/international test cases.

  • platform/graphics/FontMetrics.h: (WebCore::FontMetrics::FontMetrics): (WebCore::FontMetrics::floatLineSpacing): (WebCore::FontMetrics::setLineSpacing): (WebCore::FontMetrics::lineSpacing): (WebCore::FontMetrics::reset):
  • platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::SimpleFontData):
  • platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: (WebCore::SimpleFontData::platformInit):
  • platform/graphics/chromium/SimpleFontDataLinux.cpp: (WebCore::SimpleFontData::platformInit):
  • platform/graphics/freetype/SimpleFontDataFreeType.cpp: (WebCore::SimpleFontData::platformInit):
  • platform/graphics/haiku/SimpleFontDataHaiku.cpp: (WebCore::SimpleFontData::platformInit):
  • platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::SimpleFontData::platformInit):
  • platform/graphics/pango/SimpleFontDataPango.cpp: (WebCore::SimpleFontData::platformInit):
  • platform/graphics/qt/SimpleFontDataQt.cpp: (WebCore::SimpleFontData::platformInit):
  • platform/graphics/win/SimpleFontDataCGWin.cpp: (WebCore::SimpleFontData::platformInit):
  • platform/graphics/win/SimpleFontDataCairoWin.cpp: (WebCore::SimpleFontData::platformInit):
  • platform/graphics/win/SimpleFontDataWin.cpp: (WebCore::SimpleFontData::initGDIFont):
  • platform/graphics/wince/SimpleFontDataWinCE.cpp: (WebCore::SimpleFontData::platformInit):
  • platform/graphics/wx/SimpleFontDataWx.cpp: (WebCore::SimpleFontData::platformInit):
4:52 AM Changeset in webkit [76444] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-01-22 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] fast/backgrounds/svg-as-mask.html fails
​https://bugs.webkit.org/show_bug.cgi?id=52906

Transparency layers should start out with in SourceOver mode with
alpha 1.0 (modeled after CGContextBeginTransparencyLayer.)

  • platform/graphics/qt/TransparencyLayer.h: (WebCore::TransparencyLayer::TransparencyLayer):
4:44 AM Changeset in webkit [76443] by Nikolas Zimmermann
  • 2 edits in trunk/Source/WebCore

2011-01-22 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

Introduce FontMetrics abstraction
​https://bugs.webkit.org/show_bug.cgi?id=51456

Fix Chromium/Win build.

  • platform/graphics/chromium/UniscribeHelperTextRun.cpp: s/->/./ (WebCore::UniscribeHelperTextRun::UniscribeHelperTextRun):
3:46 AM Changeset in webkit [76442] by Nikolas Zimmermann
  • 68 edits
    1 add in trunk/Source

2011-01-21 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Introduce FontMetrics abstraction
​https://bugs.webkit.org/show_bug.cgi?id=51456

  • src/ExternalPopupMenu.cpp: Use FontMetrics instead of Font to access the metrics. (WebKit::ExternalPopupMenu::getPopupMenuInfo):
  • src/WebFontImpl.cpp: Ditto. (WebKit::WebFontImpl::ascent): (WebKit::WebFontImpl::descent): (WebKit::WebFontImpl::height): (WebKit::WebFontImpl::lineSpacing): (WebKit::WebFontImpl::xHeight):

2011-01-21 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Introduce FontMetrics abstraction
​https://bugs.webkit.org/show_bug.cgi?id=51456

  • FullscreenVideoController.cpp: Use FontMetrics instead of Font to access the metrics. (FullscreenVideoController::draw):
  • WebCoreSupport/WebDragClient.cpp: Ditto. (WebDragClient::createDragImageForLink):
  • WebKitGraphics.cpp: Ditto. (FontMetrics):

2011-01-21 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Introduce FontMetrics abstraction
​https://bugs.webkit.org/show_bug.cgi?id=51456

Encapsulate ascent/descent/lineHeight/lineGap methods in a single FontMetrics class, instead of
having to define them in both Font & SimpleFontData. Changed to store floating point values
as default, in order to get accurate information for small sized fonts. All these methods
now have floating-point and integer versions. Whenever an integer variant of these functions
is called, lroundf() is used to round the value.

This makes it possible to support small font-sizes for SVG in a follow-up patch, as well
as fixing rounding issues when using SVG Fonts.


Shouldn't affect existing tests.

  • GNUmakefile.am: Add FontMetrics.h to build.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: Use style->fontMetrics() instead of style->font() to access the metrics. (baselinePositionForAccessibilityRenderObject):
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::computeLengthDouble):
  • html/canvas/CanvasRenderingContext2D.cpp: Ditto. (WebCore::CanvasRenderingContext2D::drawTextInternal):
  • inspector/InspectorController.cpp: Ditto. (WebCore::InspectorController::drawElementTitle):
  • platform/chromium/PopupMenuChromium.cpp: Ditto. (WebCore::PopupListBox::paintRow): (WebCore::PopupListBox::getRowHeight):
  • platform/graphics/Font.h: Remove ascent/descent/height/lineGap/lineSpacing/xHeight/unitsPerEm accessor... (WebCore::Font::fontMetrics): ... and only expose a single FontMetrics object here.
  • platform/graphics/FontFastPath.cpp: Use fontMetrics() to query metrics information. (WebCore::Font::emphasisMarkAscent): (WebCore::Font::emphasisMarkDescent): (WebCore::Font::emphasisMarkHeight): (WebCore::Font::floatWidthForSimpleText):
  • platform/graphics/FontMetrics.h: Added. (WebCore::FontMetrics::FontMetrics): Creates a FontMetrics object, stored in SimpleFontData. (WebCore::FontMetrics::unitsPerEm): Returns an unsigned describing the unitsPerEm. (WebCore::FontMetrics::setUnitsPerEm): Sets the unitsPerEm value. (WebCore::FontMetrics::floatAscent): Returns the stored m_ascent float. (WebCore::FontMetrics::setAscent): Sets the stored m_ascent float. (WebCore::FontMetrics::floatDescent): Returns the stored m_descent float. (WebCore::FontMetrics::setDescent): Sets the stored m_descent float. (WebCore::FontMetrics::floatHeight): Returns floatAscent() + floatDescent(). (WebCore::FontMetrics::floatLineGap): Returns the stored m_lineGap float. (WebCore::FontMetrics::setLineGap): Sets the stored m_lineGap float. (WebCore::FontMetrics::floatLineSpacing): Returns the stored m_lineSpacing float. (WebCore::FontMetrics::setLineSpacing): Sets the stored m_lineSpacing float. (WebCore::FontMetrics::xHeight): Returns the stored m_xHeight float (no integer version available, hence no 'float' prefix). (WebCore::FontMetrics::setXHeight): Sets the stored m_xHeight float. (WebCore::FontMetrics::ascent): Returns a rounded version of ascent(). (WebCore::FontMetrics::descent): Ditto (for descent). (WebCore::FontMetrics::height): Returns ascent() + descent(). (WebCore::FontMetrics::lineGap): Returns a rounded version of lineGap(). (WebCore::FontMetrics::lineSpacing): Ditto (for lineSpacing). (WebCore::FontMetrics::reset): Nulls all members, used only by the platform variants of SimpleFontData.
  • platform/graphics/SimpleFontData.cpp: Adapt SVG Fonts code, to initialize the FontMetrics object, as the m_ascent/etc.. members are gone. (WebCore::SimpleFontData::SimpleFontData): (WebCore::SimpleFontData::initCharWidths):
  • platform/graphics/SimpleFontData.h: Remove ascent/descent/height/lineSpacing/lineGap/xHeight/unitsPerEm accessors, and members, just store a FontMetrics object and expose it. (WebCore::SimpleFontData::fontMetrics): (WebCore::SimpleFontData::avgCharWidth):
  • platform/graphics/chromium/FontChromiumWin.cpp: Use fontMetrics() to query font metrics. (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::estimateTextBounds): (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs): (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::estimateTextBounds): (WebCore::Font::drawComplexText):
  • platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: Adapt platform code, to initialize the FontMetrics object. (WebCore::SimpleFontData::platformInit):
  • platform/graphics/chromium/SimpleFontDataLinux.cpp: Ditto. (WebCore::SimpleFontData::platformInit):
  • platform/graphics/chromium/UniscribeHelperTextRun.cpp: Use fontMetrics() to query font metrics. (WebCore::UniscribeHelperTextRun::UniscribeHelperTextRun): (WebCore::UniscribeHelperTextRun::nextWinFontData):
  • platform/graphics/freetype/SimpleFontDataFreeType.cpp: Adapt platform code, to initialize the FontMetrics object. (WebCore::SimpleFontData::platformInit):
  • platform/graphics/haiku/SimpleFontDataHaiku.cpp: Ditto. (WebCore::SimpleFontData::platformInit):
  • platform/graphics/mac/FontComplexTextMac.cpp: Use fontMetrics() to query font metrics. (WebCore::Font::floatWidthForComplexText):
  • platform/graphics/mac/FontMac.mm: Ditto. (WebCore::showGlyphsWithAdvances):
  • platform/graphics/mac/SimpleFontDataMac.mm: Adapt platform code, to initialize the FontMetrics object. (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::platformCharWidthInit):
  • platform/graphics/pango/SimpleFontDataPango.cpp: Ditto. (WebCore::SimpleFontData::platformInit):
  • platform/graphics/qt/SimpleFontDataQt.cpp: Ditto. (+ Switch to QFontMetricsF to get floating-point accurancy.) (WebCore::SimpleFontData::platformInit):
  • platform/graphics/win/FontCGWin.cpp: Use fontMetrics() to query font metrics. (WebCore::drawGDIGlyphs):
  • platform/graphics/win/FontWin.cpp: Ditto. (WebCore::Font::floatWidthForComplexText):
  • platform/graphics/win/SimpleFontDataCGWin.cpp: Adapt platform code, to initialize the FontMetrics object. (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::platformBoundsForGlyph):
  • platform/graphics/win/SimpleFontDataCairoWin.cpp: Ditto. (WebCore::SimpleFontData::platformInit):
  • platform/graphics/win/SimpleFontDataWin.cpp: Ditto. (WebCore::SimpleFontData::initGDIFont):
  • platform/graphics/wince/GraphicsContextWinCE.cpp: Use fontMetrics() to query font metrics. (WebCore::GraphicsContext::drawText):
  • platform/graphics/wince/SimpleFontDataWinCE.cpp: Adapt platform code, to initialize the FontMetrics object. (WebCore::SimpleFontData::platformInit):
  • platform/graphics/wx/SimpleFontDataWx.cpp: Ditto. (WebCore::SimpleFontData::platformInit):
  • platform/win/PopupMenuWin.cpp: Use style->fontMetrics() instead of style->font() to access the metrics. (WebCore::PopupMenuWin::calculatePositionAndSize): (WebCore::PopupMenuWin::paint):
  • rendering/EllipsisBox.cpp: Ditto. (WebCore::EllipsisBox::paint): (WebCore::EllipsisBox::nodeAtPoint):
  • rendering/InlineBox.cpp: Ditto. (WebCore::InlineBox::logicalHeight):
  • rendering/InlineFlowBox.cpp: Ditto. (WebCore::verticalPositionForBox): (WebCore::InlineFlowBox::computeLogicalBoxHeights): (WebCore::InlineFlowBox::placeBoxesInBlockDirection):
  • rendering/InlineTextBox.cpp: Ditto. (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintDecoration): (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): (WebCore::InlineTextBox::paintCompositionUnderline):
  • rendering/RenderBlock.cpp: Ditto. (WebCore::RenderBlock::baselinePosition): (WebCore::RenderBlock::firstLineBoxBaseline): (WebCore::RenderBlock::lastLineBoxBaseline):
  • rendering/RenderBox.cpp: Ditto. (WebCore::RenderBox::localCaretRect):
  • rendering/RenderEmbeddedObject.cpp: Ditto. (WebCore::RenderEmbeddedObject::paintReplaced):
  • rendering/RenderImage.cpp: Ditto. (WebCore::RenderImage::setImageSizeForAltText): (WebCore::RenderImage::paintReplaced):
  • rendering/RenderInline.cpp: Ditto. (WebCore::RenderInline::baselinePosition):
  • rendering/RenderListBox.cpp: Ditto. (WebCore::RenderListBox::paintItemForeground): (WebCore::RenderListBox::itemHeight):
  • rendering/RenderListMarker.cpp: Ditto. (WebCore::RenderListMarker::paint): (WebCore::RenderListMarker::layout): (WebCore::RenderListMarker::computePreferredLogicalWidths): (WebCore::RenderListMarker::updateMargins): (WebCore::RenderListMarker::getRelativeMarkerRect):
  • rendering/RenderTextControl.cpp: Ditto. (WebCore::RenderTextControl::paintPlaceholder):
  • rendering/RenderTextControlSingleLine.cpp: Ditto. (WebCore::RenderTextControlSingleLine::createInnerTextStyle):
  • rendering/RenderThemeWin.cpp: Ditto. (WebCore::RenderThemeWin::adjustMenuListButtonStyle):
  • rendering/mathml/RenderMathMLFraction.cpp: Ditto. (WebCore::RenderMathMLFraction::baselinePosition):
  • rendering/style/RenderStyle.h: Add "const FontMetrics& fontMetrics() const" accessor. (WebCore::InheritedFlags::fontMetrics): (WebCore::InheritedFlags::computedLineHeight):
  • rendering/svg/RenderSVGInlineText.cpp: Use style->fontMetrics() instead of style->font() to access the metrics. (WebCore::RenderSVGInlineText::positionForPoint):
  • rendering/svg/SVGInlineTextBox.cpp: Ditto. (WebCore::SVGInlineTextBox::selectionRectForTextFragment): (WebCore::positionOffsetForDecoration): (WebCore::SVGInlineTextBox::paintDecorationWithStyle): (WebCore::SVGInlineTextBox::paintTextWithShadows): (WebCore::SVGInlineTextBox::calculateBoundaries):
  • rendering/svg/SVGTextLayoutEngineBaseline.cpp: Ditto. (WebCore::SVGTextLayoutEngineBaseline::calculateBaselineShift): (WebCore::SVGTextLayoutEngineBaseline::calculateAlignmentBaselineShift): (WebCore::SVGTextLayoutEngineBaseline::calculateGlyphAdvanceAndOrientation):
  • rendering/svg/SVGTextLayoutEngineSpacing.cpp: Ditto. (WebCore::SVGTextLayoutEngineSpacing::calculateSVGKerning):
  • rendering/svg/SVGTextMetrics.cpp: Ditto. (WebCore::SVGTextMetrics::SVGTextMetrics):
  • rendering/svg/SVGTextQuery.cpp: Ditto. (WebCore::calculateGlyphBoundaries):
  • svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::unitsPerEm): Rename defaultUnitsPerEm global to gDefaultUnitsPerEm.
  • svg/SVGLength.cpp: Use style->fontMetrics() instead of style->font() to access the metrics. (WebCore::SVGLength::convertValueFromUserUnitsToEXS): (WebCore::SVGLength::convertValueFromEXSToUserUnits):

2011-01-21 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Introduce FontMetrics abstraction
​https://bugs.webkit.org/show_bug.cgi?id=51456

  • WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp: Use FontMetrics instead of Font to access the metrics. (WebKit::WebPopupMenu::setUpPlatformData):
3:36 AM Changeset in webkit [76441] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-22 Patrick Gansterer <Patrick Gansterer>

Unreviewed WinCE build fix for r76430.

  • runtime/MachineStackMarker.cpp: (JSC::swapIfBackwards):
3:02 AM Changeset in webkit [76440] by andreas.kling@nokia.com
  • 1 edit
    1 add in trunk/LayoutTests

2011-01-22 Andreas Kling <​kling@webkit.org>

Unreviewed, add Qt-specific result for test added in r76414.

  • platform/qt/fast/text/justify-nbsp-expected.txt: Added.
2:58 AM Changeset in webkit [76439] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-22 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed Chromium test expectation update.

  • platform/chromium/test_expectations.txt:
2:51 AM Changeset in webkit [76438] by rniwa@webkit.org
  • 6 edits in trunk/Source/WebCore

2011-01-22 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

Stop instantiating legacy editing positions in VisibleSelection, visible_units.cpp, Frame, and RenderBlock
​https://bugs.webkit.org/show_bug.cgi?id=52759

Stopped instantiating legacy editing positions in the following files.

  • editing/VisibleSelection.cpp: (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries):
  • editing/visible_units.cpp: (WebCore::previousBoundary): (WebCore::previousLinePosition): (WebCore::nextLinePosition): (WebCore::startOfBlock):
  • page/Frame.cpp: (WebCore::Frame::visiblePositionForPoint):
  • rendering/RenderBlock.cpp: Removed RenderBlock::positionForRenderer because it was not called anywhere.
  • rendering/RenderBlock.h: Ditto.
2:00 AM Changeset in webkit [76437] by enne@google.com
  • 3 edits in trunk/Source/WebCore

2011-01-22 Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

[chromium] Fix compositor repaints for offscreen fixed elements
​https://bugs.webkit.org/show_bug.cgi?id=52681

The fast path scrolling was clipping offscreen invalidations.
Additionally, the compositor was ignoring all invalidations that were
entirely out of the content rect.

Test: compositing/ to verify this caused no regressions.
Tested fix manually in browser as I could not generate a LayoutTest that reproduced the bug in run-webkit-tests.

  • page/FrameView.cpp: (WebCore::FrameView::scrollContentsFastPath):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::invalidateRootLayerRect):
1:29 AM Changeset in webkit [76436] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-22 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed Chromium test expectation update.

  • platform/chromium/test_expectations.txt:
1:23 AM Changeset in webkit [76435] by ap@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=52473
Auto-scaling to avoid orphans is broken, remove dysfunctional code

  • WebView/WebHTMLView.mm: (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]): (-[WebHTMLView _scaleFactorForPrintOperation:]): (-[WebHTMLView knowsPageRange:]):
1:15 AM Changeset in webkit [76434] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-01-22 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=52950
Leak in WebPage::drawRectToPDF

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::drawRectToPDF): Use RetainPtr here, too.
12:22 AM Changeset in webkit [76433] by ap@apple.com
  • 4 edits in trunk/Source

2011-01-22 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=52951
WebKit2 generates a bad PDF for cross process messaging

  • page/PrintContext.cpp: (WebCore::PrintContext::spoolRect): Use a correct offset to actually draw inside the requested rectangle.

2011-01-22 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=52951
WebKit2 generates a bad PDF for cross process messaging

  • UIProcess/API/mac/WKView.mm: (-[WKView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]): Use a correct offset when flipping.
Note: See TracTimeline for information about the timeline view.