⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 26, 2011:

11:42 PM Changeset in webkit [76766] by Csaba Osztrogonác
  • 17 edits
    2 adds in trunk/LayoutTests

Unreviewed.

[Qt] Update test expectations after r76726.

  • platform/qt/fast/lists/002-vertical-expected.checksum:
  • platform/qt/fast/lists/002-vertical-expected.png:
  • platform/qt/fast/lists/002-vertical-expected.txt:
  • platform/qt/fast/lists/003-vertical-expected.checksum:
  • platform/qt/fast/lists/003-vertical-expected.png:
  • platform/qt/fast/lists/003-vertical-expected.txt:
  • platform/qt/fast/overflow/overflow-rtl-vertical-expected.checksum:
  • platform/qt/fast/overflow/overflow-rtl-vertical-expected.png:
  • platform/qt/fast/overflow/overflow-rtl-vertical-expected.txt:
  • platform/qt/fast/table/028-vertical-expected.checksum:
  • platform/qt/fast/table/028-vertical-expected.png:
  • platform/qt/fast/table/028-vertical-expected.txt:
  • platform/qt/fast/table/border-collapsing/003-vertical-expected.checksum:
  • platform/qt/fast/table/border-collapsing/003-vertical-expected.png:
  • platform/qt/fast/table/border-collapsing/003-vertical-expected.txt:
  • platform/qt/fast/table/height-percent-test-vertical-expected.txt:
11:14 PM Changeset in webkit [76765] by yuzo@google.com
  • 84 edits
    9 adds in trunk/LayoutTests

2011-01-26 Yuzo Fujishima <​yuzo@google.com>

Unreviewed Chromium test expectation change.

Update test expectations for r76743

  • platform/chromium-linux/css1/box_properties/clear_float-expected.checksum:
  • platform/chromium-linux/css1/box_properties/clear_float-expected.png:
  • platform/chromium-linux/css1/box_properties/float_elements_in_series-expected.checksum:
  • platform/chromium-linux/css1/box_properties/float_elements_in_series-expected.png:
  • platform/chromium-linux/css1/box_properties/float_on_text_elements-expected.checksum:
  • platform/chromium-linux/css1/box_properties/float_on_text_elements-expected.png:
  • platform/chromium-linux/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
  • platform/chromium-linux/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/chromium-linux/fast/multicol/shadow-breaking-expected.checksum:
  • platform/chromium-linux/fast/multicol/shadow-breaking-expected.png: Added.
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-1-expected.checksum:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-10-expected.checksum:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-10-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-2-expected.checksum:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-2-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-3-expected.checksum:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-3-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-4-expected.checksum:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-4-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-5-expected.checksum:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-5-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-6-expected.checksum:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-6-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-7-expected.checksum:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-7-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-8-expected.checksum:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-8-expected.png:
  • platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.checksum:
  • platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tr_align_justify-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/x_tr_align_justify-expected.png:
  • platform/chromium-mac/css1/box_properties/clear_float-expected.checksum: Added.
  • platform/chromium-mac/css1/box_properties/clear_float-expected.png: Added.
  • platform/chromium-mac/css1/box_properties/float_on_text_elements-expected.checksum: Added.
  • platform/chromium-mac/css1/box_properties/float_on_text_elements-expected.png: Added.
  • platform/chromium-mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png: Added.
  • platform/chromium-mac/fast/multicol/shadow-breaking-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/shadow-breaking-expected.png: Added.
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-1-expected.checksum:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-10-expected.checksum:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-10-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-2-expected.checksum:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-2-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-3-expected.checksum:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-3-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-4-expected.checksum:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-4-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-5-expected.checksum:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-5-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-6-expected.checksum:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-6-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-7-expected.checksum:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-7-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-8-expected.checksum:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-8-expected.png:
  • platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.checksum:
  • platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-win/css1/box_properties/clear_float-expected.checksum:
  • platform/chromium-win/css1/box_properties/clear_float-expected.png:
  • platform/chromium-win/css1/box_properties/float_elements_in_series-expected.checksum:
  • platform/chromium-win/css1/box_properties/float_elements_in_series-expected.png:
  • platform/chromium-win/css1/box_properties/float_on_text_elements-expected.checksum:
  • platform/chromium-win/css1/box_properties/float_on_text_elements-expected.png:
  • platform/chromium-win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
  • platform/chromium-win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/chromium-win/fast/multicol/shadow-breaking-expected.checksum:
  • platform/chromium-win/fast/multicol/shadow-breaking-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-1-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-10-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-10-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-2-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-2-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-3-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-3-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-4-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-4-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-5-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-5-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-6-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-6-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-7-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-7-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-8-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-8-expected.png:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.checksum:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tr_align_justify-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/x_tr_align_justify-expected.png:
10:41 PM Changeset in webkit [76764] by Adam Roben
  • 2 edits in trunk/Source/WebCore

Don't create the Direct3D device before it's first needed

We only need the device once we decide to render. There's no point in creating it before
then.

Reviewed by Sam Weinig.

  • platform/graphics/ca/win/CACFLayerTreeHost.cpp:

(WebCore::CACFLayerTreeHost::setWindow): Removed the call to createRenderer() from here.
We already have code to create it when we first try to draw.
(WebCore::CACFLayerTreeHost::createRenderer): Flush the context after we set our layer's
bounds so that the bounds will take effect the next time we render (which could be just
after this function returns).

10:40 PM Changeset in webkit [76763] by Adam Roben
  • 3 edits in trunk/Source/WebCore

Add assertions that CACFLayerTreeHost gains and loses an HWND only once

CACFLayerTreeHost doesn't support any other use pattern.

Reviewed by Sam Weinig.

  • platform/graphics/ca/win/CACFLayerTreeHost.cpp:

(WebCore::CACFLayerTreeHost::CACFLayerTreeHost): Initialize new member.
(WebCore::CACFLayerTreeHost::setWindow): Assert that we transition from not having a window,
to having a window, to not having a window just once over the lifetime of this object.

  • platform/graphics/ca/win/CACFLayerTreeHost.h: Added m_state.
10:40 PM Changeset in webkit [76762] by Adam Roben
  • 3 edits in trunk/Source/WebCore

Notify layers that their animations have started when we flush the context, not when we render

r76372 separated context flushing from rendering, but this bit of code got left behind.

Reviewed by Sam Weinig.

  • platform/graphics/ca/win/CACFLayerTreeHost.cpp:

(WebCore::CACFLayerTreeHost::render): Moved code to notify the layers from here to
notifyAnimationsStarted.
(WebCore::CACFLayerTreeHost::flushPendingLayerChangesNow): Added a call to
notifyAnimationsStarted after we flush the context.
(WebCore::CACFLayerTreeHost::notifyAnimationsStarted): Added. Code came from render. Changed
to call PlatformCALayer::animationStarted rather than calling through to the client
directly.

  • platform/graphics/ca/win/CACFLayerTreeHost.h: Added notifyAniamtionsStarted.
10:39 PM Changeset in webkit [76761] by Adam Roben
  • 3 edits in trunk/Source/WebCore

Small cleanup in MediaPlayerPrivateFullscreenWindow

Reviewed by Sam Weinig.

  • platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:

(WebCore::MediaPlayerPrivateFullscreenWindow::~MediaPlayerPrivateFullscreenWindow): Moved
code here from close(), since this was the only place that called it after the following
change to createWindow.
(WebCore::MediaPlayerPrivateFullscreenWindow::createWindow): Replaced code that handled the
case where we had already created the window with an assertion that we have not already done
so. Our single caller (FullscreenVideoController) did not require this behavior.

  • platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h: Removed layerView.
10:31 PM Changeset in webkit [76760] by mitz@apple.com
  • 4 edits in trunk/LayoutTests

Updated results for the html.css changes in r76726. The old results were prepared before
r76726.

  • platform/mac/fast/text/justify-ideograph-vertical-expected.checksum:
  • platform/mac/fast/text/justify-ideograph-vertical-expected.png:
  • platform/mac/fast/text/justify-ideograph-vertical-expected.txt:
10:30 PM Changeset in webkit [76759] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2011-01-26 Yuzo Fujishima <​yuzo@google.com>

Unreviewed Chromium test expectation change.

fast/text/justify-ideograph-vertical.html crashes on LINUX.

  • platform/chromium/test_expectations.txt:
9:59 PM Changeset in webkit [76758] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2011-01-26 Yuzo Fujishima <​yuzo@google.com>

Unreviewed Chromium test expectation change.

Mark the tests started failing at ​http://trac.webkit.org/changeset/76726 as such.

  • platform/chromium/test_expectations.txt:
9:12 PM Changeset in webkit [76757] by weinig@apple.com
  • 6 edits in trunk/Source/WebCore

Move ScrollView scroll wheel code to ScrollAnimator.

Reviewed by Adam Roben.

  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::handleWheelEvent):

  • platform/ScrollAnimator.h:

Moved implementation of handleWheelEvent from ScrollView::wheelEvent.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):
Call down to the ScrollableArea.

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::handleWheelEvent):
Call down to the ScrollAnimator.

  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::scrollPosition):
(WebCore::ScrollableArea::minimumScrollPosition):
(WebCore::ScrollableArea::maximumScrollPosition):
(WebCore::ScrollableArea::visibleContentRect):
(WebCore::ScrollableArea::visibleHeight):
(WebCore::ScrollableArea::visibleWidth):
Add functions needed to implement wheel event in the animator.

8:57 PM Changeset in webkit [76756] by ddkilzer@apple.com
  • 21 edits in trunk

<​http://webkit.org/b/53192> Add experimental support for HTTP pipelining in CFNetwork
<rdar://problem/8821760>

Reviewed by Antti Koivisto.

Source/WebCore:

This adds support for HTTP pipelining in CFNetwork, but does not
enable it. To enable it post-SnowLeopard, use this command:

defaults write BUNDLE.ID WebKitEnableHTTPPipelining -bool YES

Once enabled, it is possible to force the same load priority
(high) to be sent to CFNetwork to allow WebCore to handle the
scheduling:

defaults write BUNDLE.ID WebKitForceHTTPPipeliningPriorityHigh -bool YES

  • WebCore.exp.in: Export _wkGetHTTPPipeliningPriority and

_wkSetHTTPPipeliningPriority.

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequestWithPreflight):
Copy the priority to preflightRequest.

  • loader/ResourceLoadScheduler.cpp:

(WebCore::ResourceLoadScheduler::scheduleLoad): Refactored code
at the end of the method to use an early return.

  • loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::load): Set the priority on the
ResourceRequest object based on the priority of the
CachedResourceRequest before calling
ResourceLoadScheduler::scheduleSubresourceLoad().

  • loader/icon/IconLoader.cpp:

(WebCore::IconLoader::startLoading): Create a ResourceRequest
object and set its priority to ResourceLoadPriorityLow before
passing it to ResourceLoadScheduler::scheduleSubresourceLoad().

  • platform/mac/WebCoreSystemInterface.h:

(wkGetHTTPPipeliningPriority): Added.
(wkSetHTTPPipeliningPriority): Added.

  • platform/mac/WebCoreSystemInterface.mm:

(wkGetHTTPPipeliningPriority): Added.
(wkSetHTTPPipeliningPriority): Added.

  • platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::adopt): Set m_priority when
adopting a CrossThreadResourceRequestData.
(WebCore::ResourceRequestBase::copyData): Set m_priority when
creating a CrossThreadResourceRequestData.
(WebCore::ResourceRequestBase::priority): Added.
(WebCore::ResourceRequestBase::setPriority): Added.
(WebCore::equalIgnoringHeaderFields): Priorities must match when
comparing two ResourceRequest objects.

  • platform/network/ResourceRequestBase.h:

(WebCore::ResourceRequestBase::ResourceRequestBase): Set default
priority of new objects to ResourceLoadPriorityLow.
(WebCore::ResourceRequestBase::priority): Added declaration.
(WebCore::ResourceRequestBase::setPriority): Added declaration.
(WebCore::isHTTPPipeliningEnabled): Added.
(WebCore::shouldUseHTTPPipeliningPriority): Added.

  • platform/network/cf/ResourceRequestCFNet.cpp: Updated so that

Mac OS X and Windows share code.
(WebCore::initializeMaximumHTTPConnectionCountPerHost): Always
set the HTTP connection count per host, but return an
'unlimited' value when using HTTP pipelining. This method used
to be defined in ResourceRequestMac.mm for Mac OS X.
(WebCore::readBooleanPreference): Added. Helper method for
reading boolean user defaults.
(WebCore::isHTTPPipeliningEnabled): Returns value of user
default key WebKitEnableHTTPPipelining, or false if not set.
(WebCore::shouldUseHTTPPipeliningPriority): Returns value of
user default key WebKitForceHTTPPipeliningPriorityHigh, or false
if not set.

  • platform/network/cf/ResourceRequestCFNet.h: Updated so that

Mac OS X and Windows share code. Fixed indentation.
(WebCore::mapHTTPPipeliningPriorityToResourceLoadPriority): Added.
(WebCore::mapResourceLoadPriorityToHTTPPipeliningPriority): Added.

  • platform/network/mac/ResourceRequestMac.mm:

(WebCore::ResourceRequest::doUpdatePlatformRequest): Update
HTTP pipelining priority on NSMutableFURLRequest object.
(WebCore::ResourceRequest::doUpdateResourceRequest): Update
m_priority from the NSURLRequest object.
(WebCore::initializeMaximumHTTPConnectionCountPerHost): Removed.
Code is now shared with Windows in ResourceRequestCFNet.cpp.

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Added initialization for
GetHTTPPipeliningPriority and SetHTTPPipeliningPriority.

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Added initialization for
GetHTTPPipeliningPriority and SetHTTPPipeliningPriority.

WebKitLibraries:

  • WebKitSystemInterface.h:

New methods added for HTTP pipelining support.

(WKGetHTTPPipeliningPriority): Added.
(WKSetHTTPPipeliningPriority): Added.

Unrelated methods added after updating the header.

(WKMakeScrollbarPainter): Added.
(WKScrollbarPainterPaint): Added.

  • libWebKitSystemInterfaceLeopard.a: Updated.
  • libWebKitSystemInterfaceSnowLeopard.a: Updated.
8:36 PM Changeset in webkit [76755] by rniwa@webkit.org
  • 1 edit
    8 adds in trunk/LayoutTests

2011-01-26 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed Chromium Mac rebaselines for r76726.

  • platform/chromium-mac/fast/blockflow/vertical-baseline-alignment-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/vertical-baseline-alignment-expected.png: Added.
  • platform/chromium-mac/fast/multicol/vertical-rl: Added.
  • platform/chromium-mac/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt: Added.
  • platform/chromium-mac/fast/table/028-vertical-expected.checksum: Added.
  • platform/chromium-mac/fast/table/028-vertical-expected.png: Added.
  • platform/chromium-mac/fast/text/complex-text-opacity-expected.checksum: Added.
  • platform/chromium-mac/fast/text/complex-text-opacity-expected.png: Added.
8:08 PM Changeset in webkit [76754] by Beth Dakin
  • 9 edits in trunk/Source

Fix for <rdar://problem/8895140> Adopt WKScrollbar metrics
when using WKScrollbars.

Reviewed by Darin Adler.

Source/WebCore:

New WebKitSystemInterface Functionality.

  • WebCore.exp.in:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Some of the terrible static arrays are now only needed in the
old non-WK code, so they are if-def'd now.

  • platform/mac/ScrollbarThemeMac.mm:


Just patching this function in a better way than I did
before.
(WebCore::updateArrowPlacement):

Call into WK for the right values.
(WebCore::ScrollbarThemeMac::scrollbarThickness):
(WebCore::ScrollbarThemeMac::hasThumb):
(WebCore::ScrollbarThemeMac::minimumThumbLength):

Return false if there are no buttons.
(WebCore::ScrollbarThemeMac::hasButtons):

Return an empty IntRect if there are not buttons.
(WebCore::buttonRepaintRect):

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

8:07 PM Changeset in webkit [76753] by rniwa@webkit.org
  • 11 edits
    25 adds in trunk/LayoutTests

2011-01-26 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed Chromium Windows/Linux rebaselines for r76726.

  • platform/chromium-linux/fast/multicol/vertical-rl/float-multicol-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/vertical-rl/float-multicol-expected.png: Added.
  • platform/chromium-linux/fast/multicol/vertical-rl/float-paginate-complex-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/vertical-rl/float-paginate-complex-expected.png: Added.
  • platform/chromium-linux/fast/multicol/vertical-rl/float-paginate-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/vertical-rl/float-paginate-expected.png: Added.
  • platform/chromium-linux/fast/multicol/vertical-rl/nested-columns-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/vertical-rl/nested-columns-expected.png: Added.
  • platform/chromium-linux/fast/multicol/vertical-rl/unsplittable-inline-block-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png: Added.
  • platform/chromium-linux/fast/table/028-vertical-expected.checksum:
  • platform/chromium-linux/fast/table/028-vertical-expected.png:
  • platform/chromium-linux/fast/table/border-collapsing/003-vertical-expected.checksum:
  • platform/chromium-linux/fast/table/border-collapsing/003-vertical-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/float-multicol-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/float-multicol-expected.png: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/float-multicol-expected.txt: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/float-paginate-complex-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/float-paginate-complex-expected.png: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/float-paginate-complex-expected.txt: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/float-paginate-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/float-paginate-expected.png: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/float-paginate-expected.txt: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/nested-columns-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/nested-columns-expected.png: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/nested-columns-expected.txt: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/unsplittable-inline-block-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/unsplittable-inline-block-expected.txt: Added.
  • platform/chromium-win/fast/table/028-vertical-expected.checksum:
  • platform/chromium-win/fast/table/028-vertical-expected.png:
  • platform/chromium-win/fast/table/028-vertical-expected.txt:
  • platform/chromium-win/fast/table/border-collapsing/003-vertical-expected.checksum:
  • platform/chromium-win/fast/table/border-collapsing/003-vertical-expected.png:
  • platform/chromium-win/fast/table/border-collapsing/003-vertical-expected.txt:
8:04 PM Changeset in webkit [76752] by rniwa@webkit.org
  • 1 edit
    47 adds in trunk/LayoutTests

2011-01-26 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed Chromium Windows/Linux rebaselines for r76726.

  • platform/chromium-linux/fast/multicol/vertical-lr/float-paginate-complex-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/vertical-lr/float-paginate-complex-expected.png: Added.
  • platform/chromium-linux/fast/multicol/vertical-lr/float-paginate-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/vertical-lr/float-paginate-expected.png: Added.
  • platform/chromium-linux/fast/multicol/vertical-lr/nested-columns-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/vertical-lr/nested-columns-expected.png: Added.
  • platform/chromium-linux/fast/multicol/vertical-lr/unsplittable-inline-block-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png: Added.
  • platform/chromium-linux/fast/multicol/vertical-rl: Added.
  • platform/chromium-linux/fast/multicol/vertical-rl/border-padding-pagination-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/vertical-rl/border-padding-pagination-expected.png: Added.
  • platform/chromium-linux/fast/multicol/vertical-rl/column-break-with-balancing-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/vertical-rl/column-break-with-balancing-expected.png: Added.
  • platform/chromium-linux/fast/multicol/vertical-rl/column-count-with-rules-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/vertical-rl/column-count-with-rules-expected.png: Added.
  • platform/chromium-linux/fast/multicol/vertical-rl/column-rules-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/vertical-rl/column-rules-expected.png: Added.
  • platform/chromium-linux/fast/multicol/vertical-rl/float-avoidance-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/vertical-rl/float-avoidance-expected.png: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/float-paginate-complex-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/float-paginate-complex-expected.png: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/float-paginate-complex-expected.txt: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/float-paginate-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/float-paginate-expected.png: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/float-paginate-expected.txt: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/nested-columns-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/nested-columns-expected.png: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/nested-columns-expected.txt: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/unsplittable-inline-block-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/unsplittable-inline-block-expected.txt: Added.
  • platform/chromium-win/fast/multicol/vertical-rl: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/border-padding-pagination-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/border-padding-pagination-expected.png: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/border-padding-pagination-expected.txt: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/column-break-with-balancing-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/column-break-with-balancing-expected.png: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/column-count-with-rules-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/column-count-with-rules-expected.png: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/column-count-with-rules-expected.txt: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/column-rules-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/column-rules-expected.png: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/column-rules-expected.txt: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.png: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.txt: Added.
7:59 PM Changeset in webkit [76751] by rniwa@webkit.org
  • 16 edits
    32 adds
    1 delete in trunk/LayoutTests

2011-01-26 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed Chromium Windows/Linux rebaselines for r76726.

  • platform/chromium-linux/fast/blockflow/vertical-baseline-alignment-expected.checksum:
  • platform/chromium-linux/fast/blockflow/vertical-baseline-alignment-expected.png:
  • platform/chromium-linux/fast/lists/002-vertical-expected.checksum:
  • platform/chromium-linux/fast/lists/002-vertical-expected.png:
  • platform/chromium-linux/fast/lists/002-vertical-expected.txt: Removed.
  • platform/chromium-linux/fast/lists/003-vertical-expected.checksum:
  • platform/chromium-linux/fast/lists/003-vertical-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-lr: Added.
  • platform/chromium-linux/fast/multicol/vertical-lr/border-padding-pagination-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/vertical-lr/border-padding-pagination-expected.png: Added.
  • platform/chromium-linux/fast/multicol/vertical-lr/column-break-with-balancing-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/vertical-lr/column-break-with-balancing-expected.png: Added.
  • platform/chromium-linux/fast/multicol/vertical-lr/column-count-with-rules-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/vertical-lr/column-count-with-rules-expected.png: Added.
  • platform/chromium-linux/fast/multicol/vertical-lr/column-rules-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/vertical-lr/column-rules-expected.png: Added.
  • platform/chromium-linux/fast/multicol/vertical-lr/float-avoidance-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/vertical-lr/float-avoidance-expected.png: Added.
  • platform/chromium-linux/fast/multicol/vertical-lr/float-multicol-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/vertical-lr/float-multicol-expected.png: Added.
  • platform/chromium-win/fast/blockflow/vertical-baseline-alignment-expected.checksum:
  • platform/chromium-win/fast/blockflow/vertical-baseline-alignment-expected.png:
  • platform/chromium-win/fast/blockflow/vertical-baseline-alignment-expected.txt:
  • platform/chromium-win/fast/lists/002-vertical-expected.checksum:
  • platform/chromium-win/fast/lists/002-vertical-expected.png:
  • platform/chromium-win/fast/lists/002-vertical-expected.txt:
  • platform/chromium-win/fast/lists/003-vertical-expected.checksum:
  • platform/chromium-win/fast/lists/003-vertical-expected.png:
  • platform/chromium-win/fast/lists/003-vertical-expected.txt:
  • platform/chromium-win/fast/multicol/vertical-lr: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/border-padding-pagination-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/border-padding-pagination-expected.png: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/border-padding-pagination-expected.txt: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/column-break-with-balancing-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/column-break-with-balancing-expected.png: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/column-count-with-rules-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/column-count-with-rules-expected.png: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/column-count-with-rules-expected.txt: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/column-rules-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/column-rules-expected.png: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/column-rules-expected.txt: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.png: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.txt: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/float-multicol-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/float-multicol-expected.png: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/float-multicol-expected.txt: Added.
7:13 PM Changeset in webkit [76750] by bweinstein@apple.com
  • 3 edits in trunk/LayoutTests

Rebaseline Windows fast/blockfow results after r76726.

  • platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:
  • platform/win/fast/blockflow/vertical-baseline-alignment-expected.txt:
6:46 PM Changeset in webkit [76749] by Martin Robinson
  • 29 edits in trunk

2011-01-26 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Pixel dumps do not include scrollbars in output images
​https://bugs.webkit.org/show_bug.cgi?id=53216

Update expected results which should show scrollbars.

  • platform/gtk/css2.1/t0803-c5502-mrgn-r-02-c-expected.checksum:
  • platform/gtk/css2.1/t0803-c5502-mrgn-r-02-c-expected.png:
  • platform/gtk/css2.1/t0803-c5505-mrgn-02-c-expected.checksum:
  • platform/gtk/css2.1/t0803-c5505-mrgn-02-c-expected.png:
  • platform/gtk/css2.1/t080301-c411-vt-mrgn-00-b-expected.checksum:
  • platform/gtk/css2.1/t080301-c411-vt-mrgn-00-b-expected.png:
  • platform/gtk/css2.1/t0905-c5525-fltclr-00-c-ag-expected.checksum:
  • platform/gtk/css2.1/t0905-c5525-fltclr-00-c-ag-expected.png:
  • platform/gtk/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.checksum:
  • platform/gtk/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.png:
  • platform/gtk/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
  • platform/gtk/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/gtk/css2.1/t0905-c5526-fltclr-00-c-ag-expected.checksum:
  • platform/gtk/css2.1/t0905-c5526-fltclr-00-c-ag-expected.png:
  • platform/gtk/css2.1/t1002-c5523-width-02-b-g-expected.checksum:
  • platform/gtk/css2.1/t1002-c5523-width-02-b-g-expected.png:
  • platform/gtk/css2.1/t1202-counters-08-b-expected.checksum:
  • platform/gtk/css2.1/t1202-counters-08-b-expected.png:
  • platform/gtk/css2.1/t1202-counters-09-b-expected.checksum:
  • platform/gtk/css2.1/t1202-counters-09-b-expected.png:
  • platform/gtk/css2.1/t140201-c535-bg-fixd-00-b-g-expected.checksum:
  • platform/gtk/css2.1/t140201-c535-bg-fixd-00-b-g-expected.png:
  • platform/gtk/css2.1/t140201-c537-bgfxps-00-c-ag-expected.checksum:
  • platform/gtk/css2.1/t140201-c537-bgfxps-00-c-ag-expected.png:
  • platform/gtk/css2.1/t1508-c527-font-07-b-expected.checksum:
  • platform/gtk/css2.1/t1508-c527-font-07-b-expected.png:

2011-01-26 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Pixel dumps do not include scrollbars in output images
​https://bugs.webkit.org/show_bug.cgi?id=53216

Show scrollbars in pixel dumps. This will fix pixel dumps for tests
that have scrollbars.

  • DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow instead of the web view itself.
6:20 PM Changeset in webkit [76748] by Martin Robinson
  • 8 edits in trunk/LayoutTests

2011-01-26 Martin Robinson <​mrobinson@igalia.com>

[GTK] Text input controls do not react properly to CSS styling
​https://bugs.webkit.org/show_bug.cgi?id=40855

Unskip tests which were previously skipped due to issue #40855.
The bug is closed now, so it's safe to rebaseline the tests and
unskip them.

  • platform/gtk/Skipped: Unskip tests.
  • platform/gtk/fast/forms/basic-selects-expected.checksum:
  • platform/gtk/fast/forms/basic-selects-expected.png:
  • platform/gtk/fast/forms/basic-selects-expected.txt:
  • platform/gtk/fast/forms/basic-textareas-quirks-expected.checksum:
  • platform/gtk/fast/forms/basic-textareas-quirks-expected.png:
  • platform/gtk/fast/forms/basic-textareas-quirks-expected.txt:
6:02 PM Changeset in webkit [76747] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2011-01-26 Martin Robinson <​mrobinson@igalia.com>

[GTK] media/unsupported-rtsp.html fails after timing out
​https://bugs.webkit.org/show_bug.cgi?id=53056

  • platform/gtk/Skipped: Update the skipped list to explain why this test is skipped and should remain skipped.
6:01 PM Changeset in webkit [76746] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-01-26 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Mihai Parparita.

Fix regression introduced in r76322 ... new-run-webkit-tests
was attempting to save the image diff output as a UTF-8-encoded
file.

​https://bugs.webkit.org/show_bug.cgi?id=53210

  • Scripts/webkitpy/layout_tests/port/webkit.py:
5:55 PM Changeset in webkit [76745] by weinig@apple.com
  • 21 edits
    2 adds in trunk/Source

Add events to represent the start/end of a gesture scroll
​https://bugs.webkit.org/show_bug.cgi?id=53215

Reviewed by Maciej Stachowiak.

Source/JavaScriptCore:

  • wtf/Platform.h: Add ENABLE for gesture events.

Source/WebCore:

  • WebCore.exp.in:

Add new file.

  • WebCore.xcodeproj/project.pbxproj:

Add new file.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent):

  • page/EventHandler.h:

Add entry point for handling gesture events.

  • platform/PlatformGestureEvent.h: Added.

(WebCore::PlatformGestureEvent::PlatformGestureEvent):
(WebCore::PlatformGestureEvent::type):
(WebCore::PlatformGestureEvent::position):
(WebCore::PlatformGestureEvent::globalPosition):
(WebCore::PlatformGestureEvent::timestamp):
Add platform agnostic representation of a gesture event.

Source/WebKit2:

  • Scripts/webkit2/messages.py:
  • Shared/WebEvent.h:

(WebKit::WebGestureEvent::WebGestureEvent):
(WebKit::WebGestureEvent::position):
(WebKit::WebGestureEvent::globalPosition):

  • Shared/WebEventConversion.cpp:

(WebKit::WebKit2PlatformGestureEvent::WebKit2PlatformGestureEvent):
(WebKit::platform):

  • Shared/WebEventConversion.h:
  • Shared/WebGestureEvent.cpp: Added.

(WebKit::WebGestureEvent::WebGestureEvent):
(WebKit::WebGestureEvent::encode):
(WebKit::WebGestureEvent::decode):
(WebKit::WebGestureEvent::isGestureEventType):

  • Shared/mac/WebEventFactory.h:
  • Shared/mac/WebEventFactory.mm:

(WebKit::gestureEventTypeForEvent):
(WebKit::WebEventFactory::createWebGestureEvent):

  • UIProcess/API/mac/WKView.mm:

(-[WKView shortCircuitedEndGestureWithEvent:]):
(-[WKView beginGestureWithEvent:]):
(-[WKView viewDidMoveToWindow]):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::handleGestureEvent):
(WebKit::WebPageProxy::didReceiveEvent):

  • UIProcess/WebPageProxy.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::handleGestureEvent):
(WebKit::WebPage::gestureEvent):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:

Pipe gesture events down to WebCore.

5:45 PM Changeset in webkit [76744] by tkent@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-01-26 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] WebFrame::forms() should not return empty WebFormElements
​https://bugs.webkit.org/show_bug.cgi?id=53204

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::forms):
    • Should iterate by forms->length(), not the number of HTMLElements.
    • Do not increment the index for "temp" if a node is not an HTMLElement.
5:39 PM Changeset in webkit [76743] by mitz@apple.com
  • 38 edits
    12 adds in trunk

<rdar://problem/8446709> Allow inter-ideograph justification for CJK
​https://bugs.webkit.org/show_bug.cgi?id=53184

Reviewed by Dave Hyatt.

Source/WebCore:

Tests: fast/text/justify-ideograph-complex.html

fast/text/justify-ideograph-simple.html
fast/text/justify-ideograph-vertical.html

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawTextInternal): Corrected the type of the third parameter
passed to the TextRun constructor and added the trailingExpansionBehavior parameter.

  • platform/graphics/Font.cpp:

(WebCore::Font::expansionOpportunityCount): Added. Returns the number of expansion opportunities
for text justification. On entry, isAfterExpansion says whether an expansion opportunity exists
before the first character. On return, isAfterExpansion says whether an expansion opportunity
exists after the last character.

  • platform/graphics/Font.h:
  • platform/graphics/GlyphBuffer.h:

(WebCore::GlyphBuffer::expandLastAdvance): Added.

  • platform/graphics/TextRun.h:

(WebCore::TextRun::TextRun): Added a TrailingExpansionBehavior parameter to the constructors.
Renamed padding to expansion.
(WebCore::TextRun::expansion): Renamed padding() to this.
(WebCore::TextRun::allowsTrailingExpansion): Added this accessor.

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::WidthIterator): Initialize m_isAfterExpansion. Use Font::expansionOpportunityCount()
and adjust the count if it includes a trailing expansion opportunity but the run disallows trailing
expansion.
(WebCore::WidthIterator::advance): Apply expansion before and after CJK ideographs.
(WebCore::WidthIterator::advanceOneCharacter): Changed to not clear the GlyphBuffer so that advance()
can expand the last advance if it is followed by a CJK ideograph.

  • platform/graphics/WidthIterator.h: Renamed m_padding to m_expansion and m_padPerSpace

to m_expansionPerOpportunity.

  • platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::Font::canExpandAroundIdeographsInComplexText): Added.

  • platform/graphics/chromium/FontLinux.cpp:

(WebCore::Font::canExpandAroundIdeographsInComplexText): Added.

  • platform/graphics/efl/FontEfl.cpp:

(WebCore::Font::canExpandAroundIdeographsInComplexText): Added.

  • platform/graphics/gtk/FontGtk.cpp:

(WebCore::Font::canExpandAroundIdeographsInComplexText): Added.

  • platform/graphics/haiku/FontHaiku.cpp:

(WebCore::Font::canExpandAroundIdeographsInComplexText): Added.

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::ComplexTextController): Initialize m_isAfterExpansion. Use
Font::expansionOpportunityCount() and adjust the count if it includes a trailing expansion
opportunity but the run disallows trailing expansion.
(WebCore::ComplexTextController::adjustGlyphsAndAdvances): Moved the definition and initialization
of hasExtraSpacing outside the loop. Apply expansion before and after CJK ideographs.

  • platform/graphics/mac/ComplexTextController.h: Renamed m_padding to m_expansion and m_padPerSpace

to m_expansionPerOpportunity.

  • platform/graphics/mac/FontMac.mm:

(WebCore::Font::canExpandAroundIdeographsInComplexText): Added.

  • platform/graphics/qt/FontQt.cpp:

(WebCore::Font::canExpandAroundIdeographsInComplexText): Added.

  • platform/graphics/win/FontWin.cpp:

(WebCore::Font::canExpandAroundIdeographsInComplexText): Added.

  • platform/graphics/win/UniscribeController.cpp:

(WebCore::UniscribeController::UniscribeController): Updated for rename.

  • platform/graphics/wince/FontWinCE.cpp:

(WebCore::Font::canExpandAroundIdeographsInComplexText): Added.

  • platform/graphics/wx/FontWx.cpp:

(WebCore::Font::canExpandAroundIdeographsInComplexText): Added.

  • rendering/EllipsisBox.cpp:

(WebCore::EllipsisBox::paint): Pass a TrailingExpansionBehavior to the TextRun constructor.
(WebCore::EllipsisBox::selectionRect): Ditto.
(WebCore::EllipsisBox::paintSelection): Ditto.

  • rendering/InlineBox.h:

(WebCore::InlineBox::InlineBox): Renamed m_toAdd to m_expansion.
(WebCore::InlineBox::expansion): Renamed toAdd() to this.

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::selectionRect): Pass a TrailingExpansionBehavior to the TextRun constructor.
(WebCore::InlineTextBox::paint): Ditto.
(WebCore::InlineTextBox::paintSelection): Ditto.
(WebCore::InlineTextBox::paintCompositionBackground): Ditto.
(WebCore::InlineTextBox::paintSpellingOrGrammarMarker): Ditto.
(WebCore::InlineTextBox::paintTextMatchMarker): Ditto.
(WebCore::InlineTextBox::computeRectForReplacementMarker): Ditto.
(WebCore::InlineTextBox::offsetForPosition): Ditto.
(WebCore::InlineTextBox::positionForOffset): Ditto.

  • rendering/InlineTextBox.h:

(WebCore::InlineTextBox::setExpansion): Renamed setSpaceAdd() to this.
(WebCore::InlineTextBox::trailingExpansionBehavior): Added. Trailing expansion is allowed if this
is not the last leaf box on the line.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Keep expansion opportunity counts
in a vector instead of computing them twice. Discard the trailing expansion opportunity in the
last text box.

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::paintObject): Pass a TrailingExpansionBehavior to the TextRun constructor.
(WebCore::RenderFileUploadControl::computePreferredLogicalWidths): Ditto.

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::updateFromElement): Ditto.
(WebCore::RenderListBox::paintItemForeground): Ditto. Also corrected the type of the second parameter.

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::getAvgCharWidth): Ditto.
(WebCore::RenderTextControl::paintPlaceholder): Ditto.

  • rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::constructTextRun): Ditto.

Source/WebKit/chromium:

  • src/WebTextRun.cpp:

(WebKit::WebTextRun::operator WebCore::TextRun): Added a TrailingExpansionBehavior parameter to the
RenderText constructor.

Source/WebKit2:

  • WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp:

(WebKit::WebPopupMenu::setUpPlatformData): Added a TrailingExpansionBehavior parameter to the
RenderText constructor.

LayoutTests:

  • fast/text/justify-ideograph-complex.html: Added.
  • fast/text/justify-ideograph-simple.html: Added.
  • fast/text/justify-ideograph-vertical.html: Added.
  • platform/mac/fast/text/justify-ideograph-complex-expected.checksum: Added.
  • platform/mac/fast/text/justify-ideograph-complex-expected.png: Added.
  • platform/mac/fast/text/justify-ideograph-complex-expected.txt: Added.
  • platform/mac/fast/text/justify-ideograph-simple-expected.checksum: Added.
  • platform/mac/fast/text/justify-ideograph-simple-expected.png: Added.
  • platform/mac/fast/text/justify-ideograph-simple-expected.txt: Added.
  • platform/mac/fast/text/justify-ideograph-vertical-expected.checksum: Added.
  • platform/mac/fast/text/justify-ideograph-vertical-expected.png: Added.
  • platform/mac/fast/text/justify-ideograph-vertical-expected.txt: Added.
5:34 PM Changeset in webkit [76742] by mitz@apple.com
  • 5 edits
    1 add in trunk/Source/WebKit2

Methods to temporarily disable size updates to the page drawing area in WKView.
​https://bugs.webkit.org/show_bug.cgi?id=53206
Part of <rdar://problem/8818585>

Patch by Jing Jin <​jjin@apple.com> on 2011-01-26
Reviewed by Darin Adler.

  • UIProcess/API/mac/WKView.h: Added _frameSizeUpdateDisabledCount.
  • UIProcess/API/mac/WKView.mm:

(-[WKView setFrameSize:]): Only update page size if frame size updates are enabled.
(-[WKView _setDrawingAreaSize:]): Helper method to set the page's drawing area's size.
(-[WKView disableFrameSizeUpdates]): Increment _frameSizeUpdateDisabledCount
(-[WKView enableFrameSizeUpdates]): Decrement _frameSizeUpdateDisabledCount, and if the count is 0, meaning
that no one is disabling frame size updates anymore, update the drawing area's size to match the current frame.
(-[WKView frameSizeUpdatesDisabled]): Returns YES if at least one caller is disabling frame size updates.

  • UIProcess/API/mac/WKViewInternal.h: Declared -disableFrameSizeUpdates, -enableFrameSizeUpdates, and -frameSizeUpdatesDisabled.
  • UIProcess/API/mac/WKViewPrivate.h: Added.
  • WebKit2.xcodeproj/project.pbxproj: Added WKViewPrivate.h
5:32 PM Changeset in webkit [76741] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Several WKView Internal category methods are implemented in the main category.
​https://bugs.webkit.org/show_bug.cgi?id=53195

Patch by Jing Jin <​jjin@apple.com> on 2011-01-26
Rubber-stamped by Dan Bernstein.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _setEventBeingResent:]): Moved into implementation of WKView (Internal).
(-[WKView _interceptKeyEvent:]): Moved into implementation of WKView (Internal).
(-[WKView _getTextInputState:selectionEnd:underlines:WebCore::]): Moved into implementation of WKView (Internal).
(-[WKView _setAccessibilityChildToken:]): Moved into implementation of WKView (Internal).

5:19 PM WikiStart edited by mihaip@chromium.org
(diff)
5:17 PM WikiStart edited by mihaip@chromium.org
(diff)
5:12 PM Changeset in webkit [76740] by Martin Robinson
  • 2 edits
    261 adds in trunk/LayoutTests

2011-01-26 Martin Robinson <​mrobinson@igalia.com>

Add the final set of CSS 2.1 GTK+ baselines.

  • platform/gtk/Skipped: Unskip the remaining CSS 2.1 tests.
  • platform/gtk/css2.1: Add the remaining baselines.
5:09 PM Changeset in webkit [76739] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/platform/mac/fast/text/text-letter-spacing-expected.txt

Update fast/text/text-letter-spacing.html since it progressed.

5:06 PM Changeset in webkit [76738] by Martin Robinson
  • 2 edits
    300 adds in trunk/LayoutTests

2011-01-26 Martin Robinson <​mrobinson@igalia.com>

Add the next set of GTK+ baselines for the CSS 2.1 test suite.

  • platform/gtk/Skipped: Unskip the next block of tests.
  • platform/gtk/css2.1: Added CSS 2.1 test results for GTK+.
5:03 PM CSS21Results edited by leviw@chromium.org
(diff)
4:58 PM Changeset in webkit [76737] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/fast/dom/vertical-scrollbar-in-rtl-doesnt-fire-onscroll-expected.txt

Update fast/dom test since it progressed.

4:57 PM Changeset in webkit [76736] by hyatt@apple.com
  • 28 edits in trunk/LayoutTests/platform/mac/fast/table

Update fast/table results since they progressed.

4:53 PM Changeset in webkit [76735] by hyatt@apple.com
  • 7 edits in trunk/LayoutTests/platform/mac/fast/overflow

Update fast/overflow results since they progressed.

4:51 PM Changeset in webkit [76734] by hyatt@apple.com
  • 6 edits in trunk/LayoutTests/platform/mac/fast/lists

Update fast/lists results since they progressed.

4:50 PM Changeset in webkit [76733] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

Inline HTMLObjectElement::hasValidClassId().

Rubber-stamped by Darin Adler.

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::hasValidClassId):

4:49 PM Changeset in webkit [76732] by evan@chromium.org
  • 4 edits
    2 adds in trunk

2010-01-26 Evan Martin <​evan@chromium.org>

Reviewed by Tony Chang.

[chromium] crash on getBoundingClientRect in complex text
​https://bugs.webkit.org/show_bug.cgi?id=53199

Add a test that reproduces the crash and verifies the resulting values
are sane (when it didn't crash, it would get garbage values).

  • platform/chromium-linux/fast/text/international/complex-text-rectangle-expected.txt: Added.
  • platform/chromium-linux/fast/text/international/complex-text-rectangle.html: Added.

2011-01-26 Evan Martin <​evan@chromium.org>

Reviewed by Tony Chang.

[chromium] crash on getBoundingClientRect in complex text
​https://bugs.webkit.org/show_bug.cgi?id=53199

Use the correct array bound; we want the number of characters processed by
the shaper, not the longest continuous script run length.

Test: platform/chromium-linux/fast/text/international/complex-text-rectangle.html

  • platform/graphics/chromium/ComplexTextControllerLinux.cpp: (WebCore::ComplexTextController::nextScriptRun):
  • platform/graphics/chromium/ComplexTextControllerLinux.h: (WebCore::ComplexTextController::numCodePoints):
4:44 PM Changeset in webkit [76731] by hyatt@apple.com
  • 6 edits in trunk/LayoutTests/platform/mac/fast/blockflow

Update fast/blockflow results since they progressed.

4:39 PM Changeset in webkit [76730] by mrowe@apple.com
  • 5 edits in branches/safari-533.20-branch

Versioning.

3:54 PM Changeset in webkit [76729] by mrowe@apple.com
  • 1 copy in branches/safari-533.20-branch

New branch.

3:43 PM Changeset in webkit [76728] by inferno@chromium.org
  • 8 edits
    2 adds in trunk

2011-01-26 Emil A Eklund <​eae@chromium.org>

Reviewed by Alexey Proskuryakov.

Remove cached document reference from CSSStyleSheet and XSLStyleSheet.
​https://bugs.webkit.org/show_bug.cgi?id=52084

Test: fast/dom/css-delete-doc.html

  • css/CSSMediaRule.cpp: (WebCore::CSSMediaRule::insertRule): (WebCore::CSSMediaRule::deleteRule):
  • css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::CSSStyleSheet): (WebCore::CSSStyleSheet::document):
  • css/CSSStyleSheet.h:
  • xml/XSLStyleSheet.h: (WebCore::XSLStyleSheet::parentStyleSheet):
  • xml/XSLStyleSheetLibxslt.cpp: (WebCore::XSLStyleSheet::XSLStyleSheet): (WebCore::XSLStyleSheet::cachedResourceLoader): (WebCore::XSLStyleSheet::setParentStyleSheet): (WebCore::XSLStyleSheet::ownerDocument):
  • xml/XSLStyleSheetQt.cpp: (WebCore::XSLStyleSheet::XSLStyleSheet): (WebCore::XSLStyleSheet::cachedResourceLoader): (WebCore::XSLStyleSheet::ownerDocument):

2011-01-26 Emil A Eklund <​eae@chromium.org>

Reviewed by Alexey Proskuryakov.

Remove cached document reference from CSSStyleSheet and XSLStyleSheet.
​https://bugs.webkit.org/show_bug.cgi?id=52084

Added test for accessing a style sheet associated with a document that
has been removed.

  • fast/dom/css-delete-doc-expected.txt: Added.
  • fast/dom/css-delete-doc.html: Added.
3:26 PM Changeset in webkit [76727] by Dimitri Glazkov
  • 5 edits in trunk/Source/WebCore

2011-01-25 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Kent Tamura.

Reduce ref-count churn in shadowPseudoId.
​https://bugs.webkit.org/show_bug.cgi?id=53136

Refactoring, so no new tests.

  • dom/Element.h: (WebCore::Element::shadowPseudoId): Changed signature to use const AtomicString&
  • html/ValidationMessage.cpp: (WebCore::ElementWithPseudoId::shadowPseudoId): Ditto.
  • html/shadow/SliderThumbElement.cpp: (WebCore::SliderThumbElement::shadowPseudoId): Ditto, plus moved from the header file.
  • html/shadow/SliderThumbElement.h: Ditto.
  • rendering/MediaControlElements.cpp: (WebCore::MediaControlMuteButtonElement::shadowPseudoId): Ditto. (WebCore::MediaControlVolumeSliderMuteButtonElement::shadowPseudoId): Ditto. (WebCore::MediaControlPlayButtonElement::shadowPseudoId): Ditto. (WebCore::MediaControlSeekForwardButtonElement::shadowPseudoId): Ditto. (WebCore::MediaControlSeekBackButtonElement::shadowPseudoId): Ditto. (WebCore::MediaControlRewindButtonElement::shadowPseudoId): Ditto. (WebCore::MediaControlReturnToRealtimeButtonElement::shadowPseudoId): Ditto. (WebCore::MediaControlToggleClosedCaptionsButtonElement::shadowPseudoId): Ditto. (WebCore::MediaControlTimelineElement::shadowPseudoId): Ditto. (WebCore::MediaControlVolumeSliderElement::shadowPseudoId): Ditto. (WebCore::MediaControlFullscreenButtonElement::shadowPseudoId): Ditto.
  • rendering/MediaControlElements.h: Ditto.
3:10 PM Changeset in webkit [76726] by hyatt@apple.com
  • 23 edits
    104 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=46421, make multi-column layout work with vertical text.

Reviewed by Dan Bernstein.

Added new tests in fast/multicol/vertical-lr and fast/multicol/vertical-rl.

Source/WebCore:

  • css/html.css:

Update p, blockquote and h1-h6 to respect directionality so that column layout tests that use those
elements work properly.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
Fix a flipping bug with the computation of lineTopIncludingMargins where it could be incorrectly shrunk
in some cases (causing lines to all stack on top of one another).

  • rendering/InlineTextBox.h:

(WebCore::InlineTextBox::calculateBoundaries):
Fix calculateBoundaries to be physical rather than logical.

  • rendering/LayoutState.cpp:

(WebCore::LayoutState::addForcedColumnBreak):

  • rendering/LayoutState.h:

Rename childY to childLogicalOffset.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::addOverflowFromChildren):
(WebCore::RenderBlock::addOverflowFromFloats):
(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::estimateLogicalTopPosition):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::markForPaginationRelayoutIfNeeded):
(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::paintColumnContents):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::removeFloatingObjectsBelow):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::hitTestColumns):
(WebCore::RenderBlock::calcColumnWidth):
(WebCore::RenderBlock::desiredColumnWidth):
(WebCore::RenderBlock::columnRectAt):
(WebCore::RenderBlock::layoutColumns):
(WebCore::RenderBlock::adjustPointToColumnContents):
(WebCore::RenderBlock::adjustRectForColumns):
(WebCore::RenderBlock::flipForWritingModeIncludingColumns):
(WebCore::RenderBlock::adjustForColumns):
(WebCore::RenderBlock::adjustForBorderFit):
(WebCore::RenderBlock::nextPageLogicalTop):
(WebCore::RenderBlock::applyBeforeBreak):
(WebCore::RenderBlock::applyAfterBreak):
(WebCore::RenderBlock::adjustForUnsplittableChild):
(WebCore::RenderBlock::adjustLinePositionForPagination):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::logicalRightOffsetForContent):
(WebCore::RenderBlock::logicalLeftOffsetForContent):
(WebCore::RenderBlock::leftForFloatIncludingMargin):
(WebCore::RenderBlock::topForFloatIncludingMargin):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::determineStartPosition):
Reworking of all the RenderBlock column functions to support flipping and vertical modes.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::offsetFromContainer):
(WebCore::RenderBox::flipForWritingModeIncludingColumns):
Patch offsetFromContainer to be aware of flipped block writing modes when dealing with column layouts.

  • rendering/RenderBox.h:

(WebCore::RenderBox::clientLogicalBottom):
Fix a bug in clientLogicalBottom where it didn't add in the right border/padding.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):
Better terminology for pagination.

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::offsetFromContainer):
(WebCore::RenderInline::mapLocalToContainer):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintChildLayerIntoColumns):
(WebCore::RenderLayer::hitTestChildLayerColumns):
(WebCore::RenderLayer::localBoundingBox):
(WebCore::RenderLayer::boundingBox):
Patch painting in RenderLayers to be vertical-text-aware.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::mapLocalToContainer):
Add code to be flipped block-aware with columns.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::layout):

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::layout):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):
Fix pagination to use better terminology.

  • rendering/RenderText.cpp:

(WebCore::RenderText::absoluteQuads):
(WebCore::RenderText::absoluteQuadsForRange):
Fix a bug where vertical text wasn't taken into account.

LayoutTests:

  • fast/multicol/break-properties-expected.txt:
  • fast/multicol/break-properties.html:
  • fast/multicol/float-truncation.html:
  • fast/multicol/vertical-lr: Added.
  • fast/multicol/vertical-lr/border-padding-pagination.html: Added.
  • fast/multicol/vertical-lr/break-properties-expected.txt: Added.
  • fast/multicol/vertical-lr/break-properties.html: Added.
  • fast/multicol/vertical-lr/column-break-with-balancing.html: Added.
  • fast/multicol/vertical-lr/column-count-with-rules.html: Added.
  • fast/multicol/vertical-lr/column-rules.html: Added.
  • fast/multicol/vertical-lr/float-avoidance.html: Added.
  • fast/multicol/vertical-lr/float-multicol.html: Added.
  • fast/multicol/vertical-lr/float-paginate-complex.html: Added.
  • fast/multicol/vertical-lr/float-paginate.html: Added.
  • fast/multicol/vertical-lr/float-truncation-expected.txt: Added.
  • fast/multicol/vertical-lr/float-truncation.html: Added.
  • fast/multicol/vertical-lr/gap-non-negative-expected.txt: Added.
  • fast/multicol/vertical-lr/gap-non-negative.html: Added.
  • fast/multicol/vertical-lr/image-inside-nested-blocks-with-border-expected.txt: Added.
  • fast/multicol/vertical-lr/image-inside-nested-blocks-with-border.html: Added.
  • fast/multicol/vertical-lr/nested-columns.html: Added.
  • fast/multicol/vertical-lr/resources: Added.
  • fast/multicol/vertical-lr/resources/blimp.png: Added.
  • fast/multicol/vertical-lr/unsplittable-inline-block.html: Added.
  • fast/multicol/vertical-rl: Added.
  • fast/multicol/vertical-rl/border-padding-pagination.html: Added.
  • fast/multicol/vertical-rl/break-properties-expected.txt: Added.
  • fast/multicol/vertical-rl/break-properties.html: Added.
  • fast/multicol/vertical-rl/column-break-with-balancing.html: Added.
  • fast/multicol/vertical-rl/column-count-with-rules.html: Added.
  • fast/multicol/vertical-rl/column-rules.html: Added.
  • fast/multicol/vertical-rl/float-avoidance.html: Added.
  • fast/multicol/vertical-rl/float-multicol.html: Added.
  • fast/multicol/vertical-rl/float-paginate-complex.html: Added.
  • fast/multicol/vertical-rl/float-paginate.html: Added.
  • fast/multicol/vertical-rl/float-truncation-expected.txt: Added.
  • fast/multicol/vertical-rl/float-truncation.html: Added.
  • fast/multicol/vertical-rl/gap-non-negative-expected.txt: Added.
  • fast/multicol/vertical-rl/gap-non-negative.html: Added.
  • fast/multicol/vertical-rl/image-inside-nested-blocks-with-border-expected.txt: Added.
  • fast/multicol/vertical-rl/image-inside-nested-blocks-with-border.html: Added.
  • fast/multicol/vertical-rl/nested-columns.html: Added.
  • fast/multicol/vertical-rl/resources: Added.
  • fast/multicol/vertical-rl/resources/blimp.png: Added.
  • fast/multicol/vertical-rl/unsplittable-inline-block.html: Added.
  • platform/mac/fast/multicol/vertical-lr: Added.
  • platform/mac/fast/multicol/vertical-lr/border-padding-pagination-expected.checksum: Added.
  • platform/mac/fast/multicol/vertical-lr/border-padding-pagination-expected.png: Added.
  • platform/mac/fast/multicol/vertical-lr/border-padding-pagination-expected.txt: Added.
  • platform/mac/fast/multicol/vertical-lr/column-break-with-balancing-expected.checksum: Added.
  • platform/mac/fast/multicol/vertical-lr/column-break-with-balancing-expected.png: Added.
  • platform/mac/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt: Added.
  • platform/mac/fast/multicol/vertical-lr/column-count-with-rules-expected.checksum: Added.
  • platform/mac/fast/multicol/vertical-lr/column-count-with-rules-expected.png: Added.
  • platform/mac/fast/multicol/vertical-lr/column-count-with-rules-expected.txt: Added.
  • platform/mac/fast/multicol/vertical-lr/column-rules-expected.checksum: Added.
  • platform/mac/fast/multicol/vertical-lr/column-rules-expected.png: Added.
  • platform/mac/fast/multicol/vertical-lr/column-rules-expected.txt: Added.
  • platform/mac/fast/multicol/vertical-lr/float-avoidance-expected.checksum: Added.
  • platform/mac/fast/multicol/vertical-lr/float-avoidance-expected.png: Added.
  • platform/mac/fast/multicol/vertical-lr/float-avoidance-expected.txt: Added.
  • platform/mac/fast/multicol/vertical-lr/float-multicol-expected.checksum: Added.
  • platform/mac/fast/multicol/vertical-lr/float-multicol-expected.png: Added.
  • platform/mac/fast/multicol/vertical-lr/float-multicol-expected.txt: Added.
  • platform/mac/fast/multicol/vertical-lr/float-paginate-complex-expected.checksum: Added.
  • platform/mac/fast/multicol/vertical-lr/float-paginate-complex-expected.png: Added.
  • platform/mac/fast/multicol/vertical-lr/float-paginate-complex-expected.txt: Added.
  • platform/mac/fast/multicol/vertical-lr/float-paginate-expected.checksum: Added.
  • platform/mac/fast/multicol/vertical-lr/float-paginate-expected.png: Added.
  • platform/mac/fast/multicol/vertical-lr/float-paginate-expected.txt: Added.
  • platform/mac/fast/multicol/vertical-lr/nested-columns-expected.checksum: Added.
  • platform/mac/fast/multicol/vertical-lr/nested-columns-expected.png: Added.
  • platform/mac/fast/multicol/vertical-lr/nested-columns-expected.txt: Added.
  • platform/mac/fast/multicol/vertical-lr/unsplittable-inline-block-expected.checksum: Added.
  • platform/mac/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png: Added.
  • platform/mac/fast/multicol/vertical-lr/unsplittable-inline-block-expected.txt: Added.
  • platform/mac/fast/multicol/vertical-rl: Added.
  • platform/mac/fast/multicol/vertical-rl/border-padding-pagination-expected.checksum: Added.
  • platform/mac/fast/multicol/vertical-rl/border-padding-pagination-expected.png: Added.
  • platform/mac/fast/multicol/vertical-rl/border-padding-pagination-expected.txt: Added.
  • platform/mac/fast/multicol/vertical-rl/column-break-with-balancing-expected.checksum: Added.
  • platform/mac/fast/multicol/vertical-rl/column-break-with-balancing-expected.png: Added.
  • platform/mac/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt: Added.
  • platform/mac/fast/multicol/vertical-rl/column-count-with-rules-expected.checksum: Added.
  • platform/mac/fast/multicol/vertical-rl/column-count-with-rules-expected.png: Added.
  • platform/mac/fast/multicol/vertical-rl/column-count-with-rules-expected.txt: Added.
  • platform/mac/fast/multicol/vertical-rl/column-rules-expected.checksum: Added.
  • platform/mac/fast/multicol/vertical-rl/column-rules-expected.png: Added.
  • platform/mac/fast/multicol/vertical-rl/column-rules-expected.txt: Added.
  • platform/mac/fast/multicol/vertical-rl/float-avoidance-expected.checksum: Added.
  • platform/mac/fast/multicol/vertical-rl/float-avoidance-expected.png: Added.
  • platform/mac/fast/multicol/vertical-rl/float-avoidance-expected.txt: Added.
  • platform/mac/fast/multicol/vertical-rl/float-multicol-expected.checksum: Added.
  • platform/mac/fast/multicol/vertical-rl/float-multicol-expected.png: Added.
  • platform/mac/fast/multicol/vertical-rl/float-multicol-expected.txt: Added.
  • platform/mac/fast/multicol/vertical-rl/float-paginate-complex-expected.checksum: Added.
  • platform/mac/fast/multicol/vertical-rl/float-paginate-complex-expected.png: Added.
  • platform/mac/fast/multicol/vertical-rl/float-paginate-complex-expected.txt: Added.
  • platform/mac/fast/multicol/vertical-rl/float-paginate-expected.checksum: Added.
  • platform/mac/fast/multicol/vertical-rl/float-paginate-expected.png: Added.
  • platform/mac/fast/multicol/vertical-rl/float-paginate-expected.txt: Added.
  • platform/mac/fast/multicol/vertical-rl/nested-columns-expected.checksum: Added.
  • platform/mac/fast/multicol/vertical-rl/nested-columns-expected.png: Added.
  • platform/mac/fast/multicol/vertical-rl/nested-columns-expected.txt: Added.
  • platform/mac/fast/multicol/vertical-rl/unsplittable-inline-block-expected.checksum: Added.
  • platform/mac/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png: Added.
  • platform/mac/fast/multicol/vertical-rl/unsplittable-inline-block-expected.txt: Added.
2:58 PM Changeset in webkit [76725] by bweinstein@apple.com
  • 3 edits in trunk/Source/WebKit2

WebKit2: Need API to get the frame load state of a BundleFrame
​https://bugs.webkit.org/show_bug.cgi?id=53193

Reviewed by John Sullivan.

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFrameGetFrameLoadState): Call through to the FrameLoader to get the frame load state.

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
2:54 PM Changeset in webkit [76724] by Dimitri Glazkov
  • 8 edits in trunk/Source/WebCore

2011-01-26 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, rolling out r76719.
​http://trac.webkit.org/changeset/76719
​https://bugs.webkit.org/show_bug.cgi?id=53122

Broke a bunch of media tests in Chromium/Qt/GTK.

2:52 PM Changeset in webkit [76723] by tony@chromium.org
  • 6 edits in trunk

2011-01-26 Tony Chang <​tony@chromium.org>

Reviewed by Ryosuke Niwa.

[gtk] strip NUL characters when copying text/html on GTK+
​https://bugs.webkit.org/show_bug.cgi?id=52508

  • editing/pasteboard/copy-null-characters.html: Make sure we didn't

change innerHTML (it should still contain the null)

  • platform/gtk/Skipped: Re-enable the test

2011-01-26 Tony Chang <​tony@chromium.org>

Reviewed by Ryosuke Niwa.

[gtk] strip NUL characters when copying text/html on GTK+
​https://bugs.webkit.org/show_bug.cgi?id=52508

Putting NUL characters in the text/html clipboard doesn't work in
WebKit GTK+ (the pasted value is truncated at the NUL). Since we're
already stripping this character for plain text (for Windows), strip
it in text/html too.

  • editing/MarkupAccumulator.h: mark function as virtual
  • editing/markup.cpp: (WebCore::StyledMarkupAccumulator::appendString): (WebCore::StyledMarkupAccumulator::takeResults): strip nulls
2:50 PM Changeset in webkit [76722] by dpranke@chromium.org
  • 2 edits
    2 deletes in trunk/Tools

2011-01-26 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r76709.
​http://trac.webkit.org/changeset/76709
​https://bugs.webkit.org/show_bug.cgi?id=53194

"broke python tests on non-snowleopard platforms" (Requested
by dpranke on #webkit).

  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/port/mock_drt.py: Removed.
  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Removed.
2:43 PM Changeset in webkit [76721] by mario@webkit.org
  • 4 edits in trunk/Source

2011-01-26 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Reliable crash with getTextAtOffset()
​https://bugs.webkit.org/show_bug.cgi?id=53131

Properly calculate length in bytes for a UTF8 substring.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (utf8Substr): Use character instead of bytes as units to calculate the length in bytes for the UTF8 string.

2011-01-26 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Reliable crash with getTextAtOffset()
​https://bugs.webkit.org/show_bug.cgi?id=53131

New unit test to check the fix for this bug.

  • tests/testatk.c: (testWebkitAtkGetTextAtOffsetWithSpecialCharacters): New. (main): Add new unit test.
2:22 PM Changeset in webkit [76720] by Martin Robinson
  • 2 edits
    282 adds in trunk/LayoutTests

2011-01-26 Martin Robinson <​mrobinson@igalia.com>

Add the next set of CSS 2.1 baselines for GTK+.

  • platform/gtk/Skipped: Unskip tests which now have results.
  • platform/gtk/css2.1/t010403-shand-border-00-c-expected.checksum: Added.
  • platform/gtk/css2.1/t010403-shand-border-00-c-expected.png: Added.
  • platform/gtk/css2.1/t010403-shand-border-00-c-expected.txt: Added.
  • platform/gtk/css2.1/t010403-shand-font-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t010403-shand-font-00-b-expected.png: Added.
  • platform/gtk/css2.1/t010403-shand-font-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t010403-shand-font-01-b-expected.checksum: Added.
  • platform/gtk/css2.1/t010403-shand-font-01-b-expected.png: Added.
  • platform/gtk/css2.1/t010403-shand-font-01-b-expected.txt: Added.
  • platform/gtk/css2.1/t010403-shand-font-02-b-expected.checksum: Added.
  • platform/gtk/css2.1/t010403-shand-font-02-b-expected.png: Added.
  • platform/gtk/css2.1/t010403-shand-font-02-b-expected.txt: Added.
  • platform/gtk/css2.1/t010403-shand-font-03-b-expected.checksum: Added.
  • platform/gtk/css2.1/t010403-shand-font-03-b-expected.png: Added.
  • platform/gtk/css2.1/t010403-shand-font-03-b-expected.txt: Added.
  • platform/gtk/css2.1/t040102-keywords-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t040102-keywords-00-b-expected.png: Added.
  • platform/gtk/css2.1/t040102-keywords-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t040102-keywords-01-b-expected.checksum: Added.
  • platform/gtk/css2.1/t040102-keywords-01-b-expected.png: Added.
  • platform/gtk/css2.1/t040102-keywords-01-b-expected.txt: Added.
  • platform/gtk/css2.1/t040103-case-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t040103-case-00-b-expected.png: Added.
  • platform/gtk/css2.1/t040103-case-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t040103-case-01-c-expected.checksum: Added.
  • platform/gtk/css2.1/t040103-case-01-c-expected.png: Added.
  • platform/gtk/css2.1/t040103-case-01-c-expected.txt: Added.
  • platform/gtk/css2.1/t040103-escapes-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t040103-escapes-00-b-expected.png: Added.
  • platform/gtk/css2.1/t040103-escapes-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t040103-escapes-01-b-expected.checksum: Added.
  • platform/gtk/css2.1/t040103-escapes-01-b-expected.png: Added.
  • platform/gtk/css2.1/t040103-escapes-01-b-expected.txt: Added.
  • platform/gtk/css2.1/t040103-escapes-02-d-expected.checksum: Added.
  • platform/gtk/css2.1/t040103-escapes-02-d-expected.png: Added.
  • platform/gtk/css2.1/t040103-escapes-02-d-expected.txt: Added.
  • platform/gtk/css2.1/t040103-escapes-03-b-expected.checksum: Added.
  • platform/gtk/css2.1/t040103-escapes-03-b-expected.png: Added.
  • platform/gtk/css2.1/t040103-escapes-03-b-expected.txt: Added.
  • platform/gtk/css2.1/t040103-escapes-04-b-expected.checksum: Added.
  • platform/gtk/css2.1/t040103-escapes-04-b-expected.png: Added.
  • platform/gtk/css2.1/t040103-escapes-04-b-expected.txt: Added.
  • platform/gtk/css2.1/t040103-escapes-05-c-expected.checksum: Added.
  • platform/gtk/css2.1/t040103-escapes-05-c-expected.png: Added.
  • platform/gtk/css2.1/t040103-escapes-05-c-expected.txt: Added.
  • platform/gtk/css2.1/t040103-escapes-06-b-expected.checksum: Added.
  • platform/gtk/css2.1/t040103-escapes-06-b-expected.png: Added.
  • platform/gtk/css2.1/t040103-escapes-06-b-expected.txt: Added.
  • platform/gtk/css2.1/t040103-escapes-07-b-expected.checksum: Added.
  • platform/gtk/css2.1/t040103-escapes-07-b-expected.png: Added.
  • platform/gtk/css2.1/t040103-escapes-07-b-expected.txt: Added.
  • platform/gtk/css2.1/t040103-escapes-08-b-expected.checksum: Added.
  • platform/gtk/css2.1/t040103-escapes-08-b-expected.png: Added.
  • platform/gtk/css2.1/t040103-escapes-08-b-expected.txt: Added.
  • platform/gtk/css2.1/t040103-ident-00-c-expected.checksum: Added.
  • platform/gtk/css2.1/t040103-ident-00-c-expected.png: Added.
  • platform/gtk/css2.1/t040103-ident-00-c-expected.txt: Added.
  • platform/gtk/css2.1/t040103-ident-01-c-expected.checksum: Added.
  • platform/gtk/css2.1/t040103-ident-01-c-expected.png: Added.
  • platform/gtk/css2.1/t040103-ident-01-c-expected.txt: Added.
  • platform/gtk/css2.1/t040103-ident-02-c-expected.checksum: Added.
  • platform/gtk/css2.1/t040103-ident-02-c-expected.png: Added.
  • platform/gtk/css2.1/t040103-ident-02-c-expected.txt: Added.
  • platform/gtk/css2.1/t040103-ident-03-c-expected.checksum: Added.
  • platform/gtk/css2.1/t040103-ident-03-c-expected.png: Added.
  • platform/gtk/css2.1/t040103-ident-03-c-expected.txt: Added.
  • platform/gtk/css2.1/t040103-ident-04-c-expected.checksum: Added.
  • platform/gtk/css2.1/t040103-ident-04-c-expected.png: Added.
  • platform/gtk/css2.1/t040103-ident-04-c-expected.txt: Added.
  • platform/gtk/css2.1/t040103-ident-05-c-expected.checksum: Added.
  • platform/gtk/css2.1/t040103-ident-05-c-expected.png: Added.
  • platform/gtk/css2.1/t040103-ident-05-c-expected.txt: Added.
  • platform/gtk/css2.1/t040103-ident-06-c-expected.checksum: Added.
  • platform/gtk/css2.1/t040103-ident-06-c-expected.png: Added.
  • platform/gtk/css2.1/t040103-ident-06-c-expected.txt: Added.
  • platform/gtk/css2.1/t040103-ident-07-c-expected.checksum: Added.
  • platform/gtk/css2.1/t040103-ident-07-c-expected.png: Added.
  • platform/gtk/css2.1/t040103-ident-07-c-expected.txt: Added.
  • platform/gtk/css2.1/t040103-ident-08-c-expected.checksum: Added.
  • platform/gtk/css2.1/t040103-ident-08-c-expected.png: Added.
  • platform/gtk/css2.1/t040103-ident-08-c-expected.txt: Added.
  • platform/gtk/css2.1/t040103-ident-09-c-expected.checksum: Added.
  • platform/gtk/css2.1/t040103-ident-09-c-expected.png: Added.
  • platform/gtk/css2.1/t040103-ident-09-c-expected.txt: Added.
  • platform/gtk/css2.1/t040103-ident-10-c-expected.checksum: Added.
  • platform/gtk/css2.1/t040103-ident-10-c-expected.png: Added.
  • platform/gtk/css2.1/t040103-ident-10-c-expected.txt: Added.
  • platform/gtk/css2.1/t040103-ident-11-c-expected.checksum: Added.
  • platform/gtk/css2.1/t040103-ident-11-c-expected.png: Added.
  • platform/gtk/css2.1/t040103-ident-11-c-expected.txt: Added.
  • platform/gtk/css2.1/t040103-ident-12-c-expected.checksum: Added.
  • platform/gtk/css2.1/t040103-ident-12-c-expected.png: Added.
  • platform/gtk/css2.1/t040103-ident-12-c-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counters-02-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counters-02-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counters-02-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counters-03-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counters-03-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counters-03-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counters-04-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counters-04-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counters-04-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counters-05-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counters-05-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counters-05-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counters-06-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counters-06-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counters-06-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counters-07-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counters-07-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counters-07-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counters-08-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counters-08-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counters-08-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counters-09-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counters-09-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counters-09-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counters-11-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counters-11-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counters-11-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counters-12-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counters-12-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counters-12-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counters-13-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counters-13-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counters-13-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counters-14-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counters-14-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counters-14-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counters-15-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counters-15-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counters-15-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counters-16-c-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counters-16-c-expected.png: Added.
  • platform/gtk/css2.1/t1202-counters-16-c-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counters-17-d-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counters-17-d-expected.png: Added.
  • platform/gtk/css2.1/t1202-counters-17-d-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counters-18-f-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counters-18-f-expected.png: Added.
  • platform/gtk/css2.1/t1202-counters-18-f-expected.txt: Added.
  • platform/gtk/css2.1/t1204-implied-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1204-implied-00-b-expected.png: Added.
  • platform/gtk/css2.1/t1204-implied-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t1204-implied-01-c-expected.checksum: Added.
  • platform/gtk/css2.1/t1204-implied-01-c-expected.png: Added.
  • platform/gtk/css2.1/t1204-implied-01-c-expected.txt: Added.
  • platform/gtk/css2.1/t1204-implied-02-d-expected.checksum: Added.
  • platform/gtk/css2.1/t1204-implied-02-d-expected.png: Added.
  • platform/gtk/css2.1/t1204-implied-02-d-expected.txt: Added.
  • platform/gtk/css2.1/t1204-multiple-00-c-expected.checksum: Added.
  • platform/gtk/css2.1/t1204-multiple-00-c-expected.png: Added.
  • platform/gtk/css2.1/t1204-multiple-00-c-expected.txt: Added.
  • platform/gtk/css2.1/t1204-multiple-01-c-expected.checksum: Added.
  • platform/gtk/css2.1/t1204-multiple-01-c-expected.png: Added.
  • platform/gtk/css2.1/t1204-multiple-01-c-expected.txt: Added.
  • platform/gtk/css2.1/t1204-order-00-c-expected.checksum: Added.
  • platform/gtk/css2.1/t1204-order-00-c-expected.png: Added.
  • platform/gtk/css2.1/t1204-order-00-c-expected.txt: Added.
  • platform/gtk/css2.1/t1204-order-01-d-expected.checksum: Added.
  • platform/gtk/css2.1/t1204-order-01-d-expected.png: Added.
  • platform/gtk/css2.1/t1204-order-01-d-expected.txt: Added.
  • platform/gtk/css2.1/t1204-root-e-expected.checksum: Added.
  • platform/gtk/css2.1/t1204-root-e-expected.png: Added.
  • platform/gtk/css2.1/t1204-root-e-expected.txt: Added.
  • platform/gtk/css2.1/t1205-c561-list-displ-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1205-c561-list-displ-00-b-expected.png: Added.
  • platform/gtk/css2.1/t1205-c561-list-displ-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t1205-c563-list-type-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1205-c563-list-type-00-b-expected.png: Added.
  • platform/gtk/css2.1/t1205-c563-list-type-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t1205-c563-list-type-01-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1205-c563-list-type-01-b-expected.png: Added.
  • platform/gtk/css2.1/t1205-c563-list-type-01-b-expected.txt: Added.
  • platform/gtk/css2.1/t1205-c564-list-img-00-b-g-expected.checksum: Added.
  • platform/gtk/css2.1/t1205-c564-list-img-00-b-g-expected.png: Added.
  • platform/gtk/css2.1/t1205-c564-list-img-00-b-g-expected.txt: Added.
  • platform/gtk/css2.1/t1205-c565-list-pos-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1205-c565-list-pos-00-b-expected.png: Added.
  • platform/gtk/css2.1/t1205-c565-list-pos-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t1205-c566-list-stl-00-e-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t1205-c566-list-stl-00-e-ag-expected.png: Added.
  • platform/gtk/css2.1/t1205-c566-list-stl-00-e-ag-expected.txt: Added.
  • platform/gtk/css2.1/t1205-c566-list-stl-01-c-g-expected.checksum: Added.
  • platform/gtk/css2.1/t1205-c566-list-stl-01-c-g-expected.png: Added.
  • platform/gtk/css2.1/t1205-c566-list-stl-01-c-g-expected.txt: Added.
  • platform/gtk/css2.1/t1401-c531-color-00-a-expected.checksum: Added.
  • platform/gtk/css2.1/t1401-c531-color-00-a-expected.png: Added.
  • platform/gtk/css2.1/t1401-c531-color-00-a-expected.txt: Added.
  • platform/gtk/css2.1/t1402-c45-bg-canvas-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1402-c45-bg-canvas-00-b-expected.png: Added.
  • platform/gtk/css2.1/t1402-c45-bg-canvas-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t1503-c522-font-family-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1503-c522-font-family-00-b-expected.png: Added.
  • platform/gtk/css2.1/t1503-c522-font-family-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t1504-c523-font-style-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1504-c523-font-style-00-b-expected.png: Added.
  • platform/gtk/css2.1/t1504-c523-font-style-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t1504-c543-txt-decor-00-d-g-expected.checksum: Added.
  • platform/gtk/css2.1/t1504-c543-txt-decor-00-d-g-expected.png: Added.
  • platform/gtk/css2.1/t1504-c543-txt-decor-00-d-g-expected.txt: Added.
  • platform/gtk/css2.1/t1505-c524-font-var-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1505-c524-font-var-00-b-expected.png: Added.
  • platform/gtk/css2.1/t1505-c524-font-var-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t1506-c525-font-wt-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1506-c525-font-wt-00-b-expected.png: Added.
  • platform/gtk/css2.1/t1506-c525-font-wt-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t1507-c526-font-sz-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1507-c526-font-sz-00-b-expected.png: Added.
  • platform/gtk/css2.1/t1507-c526-font-sz-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t1507-c526-font-sz-01-b-a-expected.checksum: Added.
  • platform/gtk/css2.1/t1507-c526-font-sz-01-b-a-expected.png: Added.
  • platform/gtk/css2.1/t1507-c526-font-sz-01-b-a-expected.txt: Added.
  • platform/gtk/css2.1/t1507-c526-font-sz-02-b-a-expected.checksum: Added.
  • platform/gtk/css2.1/t1507-c526-font-sz-02-b-a-expected.png: Added.
  • platform/gtk/css2.1/t1507-c526-font-sz-02-b-a-expected.txt: Added.
  • platform/gtk/css2.1/t1507-c526-font-sz-03-f-a-expected.checksum: Added.
  • platform/gtk/css2.1/t1507-c526-font-sz-03-f-a-expected.png: Added.
  • platform/gtk/css2.1/t1507-c526-font-sz-03-f-a-expected.txt: Added.
  • platform/gtk/css2.1/t1508-c527-font-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1508-c527-font-00-b-expected.png: Added.
  • platform/gtk/css2.1/t1508-c527-font-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t1508-c527-font-01-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1508-c527-font-01-b-expected.png: Added.
  • platform/gtk/css2.1/t1508-c527-font-01-b-expected.txt: Added.
  • platform/gtk/css2.1/t1508-c527-font-02-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1508-c527-font-02-b-expected.png: Added.
  • platform/gtk/css2.1/t1508-c527-font-02-b-expected.txt: Added.
  • platform/gtk/css2.1/t1508-c527-font-03-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1508-c527-font-03-b-expected.png: Added.
  • platform/gtk/css2.1/t1508-c527-font-03-b-expected.txt: Added.
  • platform/gtk/css2.1/t1508-c527-font-04-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1508-c527-font-04-b-expected.png: Added.
  • platform/gtk/css2.1/t1508-c527-font-04-b-expected.txt: Added.
  • platform/gtk/css2.1/t1508-c527-font-05-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1508-c527-font-05-b-expected.png: Added.
  • platform/gtk/css2.1/t1508-c527-font-05-b-expected.txt: Added.
  • platform/gtk/css2.1/t1508-c527-font-06-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1508-c527-font-06-b-expected.png: Added.
  • platform/gtk/css2.1/t1508-c527-font-06-b-expected.txt: Added.
  • platform/gtk/css2.1/t1508-c527-font-07-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1508-c527-font-07-b-expected.png: Added.
  • platform/gtk/css2.1/t1508-c527-font-07-b-expected.txt: Added.
  • platform/gtk/css2.1/t1508-c527-font-08-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1508-c527-font-08-b-expected.png: Added.
  • platform/gtk/css2.1/t1508-c527-font-08-b-expected.txt: Added.
  • platform/gtk/css2.1/t1508-c527-font-09-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1508-c527-font-09-b-expected.png: Added.
  • platform/gtk/css2.1/t1508-c527-font-09-b-expected.txt: Added.
  • platform/gtk/css2.1/t1508-c527-font-10-c-expected.checksum: Added.
  • platform/gtk/css2.1/t1508-c527-font-10-c-expected.png: Added.
  • platform/gtk/css2.1/t1508-c527-font-10-c-expected.txt: Added.
  • platform/gtk/css2.1/t1601-c547-indent-00-b-a-expected.checksum: Added.
  • platform/gtk/css2.1/t1601-c547-indent-00-b-a-expected.png: Added.
  • platform/gtk/css2.1/t1601-c547-indent-00-b-a-expected.txt: Added.
  • platform/gtk/css2.1/t1601-c547-indent-01-d-expected.checksum: Added.
  • platform/gtk/css2.1/t1601-c547-indent-01-d-expected.png: Added.
  • platform/gtk/css2.1/t1601-c547-indent-01-d-expected.txt: Added.
  • platform/gtk/css2.1/t1602-c43-center-00-d-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t1602-c43-center-00-d-ag-expected.png: Added.
  • platform/gtk/css2.1/t1602-c43-center-00-d-ag-expected.txt: Added.
  • platform/gtk/css2.1/t1602-c546-txt-align-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1602-c546-txt-align-00-b-expected.png: Added.
  • platform/gtk/css2.1/t1602-c546-txt-align-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t1604-c541-word-sp-00-b-a-expected.checksum: Added.
  • platform/gtk/css2.1/t1604-c541-word-sp-00-b-a-expected.png: Added.
  • platform/gtk/css2.1/t1604-c541-word-sp-00-b-a-expected.txt: Added.
  • platform/gtk/css2.1/t1604-c541-word-sp-01-b-a-expected.checksum: Added.
  • platform/gtk/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Added.
  • platform/gtk/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Added.
  • platform/gtk/css2.1/t1604-c542-letter-sp-00-b-a-expected.checksum: Added.
  • platform/gtk/css2.1/t1604-c542-letter-sp-00-b-a-expected.png: Added.
  • platform/gtk/css2.1/t1604-c542-letter-sp-00-b-a-expected.txt: Added.
  • platform/gtk/css2.1/t1604-c542-letter-sp-01-b-a-expected.checksum: Added.
  • platform/gtk/css2.1/t1604-c542-letter-sp-01-b-a-expected.png: Added.
  • platform/gtk/css2.1/t1604-c542-letter-sp-01-b-a-expected.txt: Added.
  • platform/gtk/css2.1/t1605-c545-txttrans-00-b-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t1605-c545-txttrans-00-b-ag-expected.png: Added.
  • platform/gtk/css2.1/t1605-c545-txttrans-00-b-ag-expected.txt: Added.
  • platform/gtk/css2.1/t1606-c562-white-sp-00-b-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t1606-c562-white-sp-00-b-ag-expected.png: Added.
  • platform/gtk/css2.1/t1606-c562-white-sp-00-b-ag-expected.txt: Added.
2:19 PM Changeset in webkit [76719] by Dimitri Glazkov
  • 8 edits in trunk/Source/WebCore

2011-01-25 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Kent Tamura.

Change HTMLInputElement-derived parts of media element shadow DOM to use shadowPseudoId.
​https://bugs.webkit.org/show_bug.cgi?id=53122

This is the first step in converting HTMLMediaElement to the new shadow DOM.

Should not regress any existing tests. No observable change in behavior.

  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): Removed now-unnecessary hard-coded pseudo-element selectors. (WebCore::nameToPseudoTypeMap): Ditto. (WebCore::CSSSelector::extractPseudoType): Ditto.
  • css/CSSSelector.h: Ditto.
  • css/mediaControls.css: Added proper initial values, now that elements use the proper selector pipeline.
  • rendering/MediaControlElements.cpp: (WebCore::MediaControlInputElement::MediaControlInputElement): Removed the switch statement,

which is now replaced with virtual shadowPseudoId on each corresponding class.

(WebCore::MediaControlInputElement::styleForElement): Changed to use element pipeline.
(WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement): Changed to set

display type in constructor.

(WebCore::MediaControlMuteButtonElement::create): Changed to not take PseudoId as

constructor argument.

(WebCore::MediaControlMuteButtonElement::shadowPseudoId): Added.
(WebCore::MediaControlVolumeSliderMuteButtonElement::MediaControlVolumeSliderMuteButtonElement): Added

to disambiguate from the MediaControlMuteButtonElement.

(WebCore::MediaControlVolumeSliderMuteButtonElement::create): Added.
(WebCore::MediaControlVolumeSliderMuteButtonElement::shadowPseudoId): Added.
(WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement): Changed to not take PseudoId as

constructor argument.

(WebCore::MediaControlPlayButtonElement::shadowPseudoId): Added.
(WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement): Changed to not take PseudoId as

constructor argument.

(WebCore::MediaControlSeekForwardButtonElement::MediaControlSeekForwardButtonElement): Added.
(WebCore::MediaControlSeekForwardButtonElement::create): Added.
(WebCore::MediaControlSeekForwardButtonElement::shadowPseudoId): Added.
(WebCore::MediaControlSeekBackButtonElement::MediaControlSeekBackButtonElement): Added.
(WebCore::MediaControlSeekBackButtonElement::create): Added.
(WebCore::MediaControlSeekBackButtonElement::shadowPseudoId): Added.
(WebCore::MediaControlRewindButtonElement::MediaControlRewindButtonElement): Added.
(WebCore::MediaControlRewindButtonElement::shadowPseudoId): Added.
(WebCore::MediaControlReturnToRealtimeButtonElement::MediaControlReturnToRealtimeButtonElement): Changed to not take PseudoId as

constructor argument.

(WebCore::MediaControlReturnToRealtimeButtonElement::shadowPseudoId): Added.
(WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement): Changed to not take PseudoId as

constructor argument.

(WebCore::MediaControlToggleClosedCaptionsButtonElement::shadowPseudoId): Added.
(WebCore::MediaControlTimelineElement::MediaControlTimelineElement): Changed to not take PseudoId as

constructor argument.

(WebCore::MediaControlTimelineElement::shadowPseudoId): Added.
(WebCore::MediaControlVolumeSliderElement::MediaControlVolumeSliderElement): Changed to not take PseudoId as

constructor argument.

(WebCore::MediaControlVolumeSliderElement::shadowPseudoId): Added.
(WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement): Changed to not take PseudoId as

constructor argument.

(WebCore::MediaControlFullscreenButtonElement::shadowPseudoId): Added.

  • rendering/MediaControlElements.h: (WebCore::MediaControlSeekForwardButtonElement::isForwardButton): Added. (WebCore::MediaControlSeekBackButtonElement::isForwardButton): Added.
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::createMuteButton): Changed to use new constructor. (WebCore::RenderMedia::createSeekBackButton): Ditto. (WebCore::RenderMedia::createSeekForwardButton): Ditto. (WebCore::RenderMedia::createVolumeSliderMuteButton): Ditto.
  • rendering/style/RenderStyleConstants.h: Removed constants that are no longer used.
2:10 PM Changeset in webkit [76718] by Martin Robinson
  • 2 edits
    300 adds in trunk/LayoutTests

2011-01-26 Martin Robinson <​mrobinson@igalia.com>

Continue the import of GTK+ test results for the CSS 2.1 test suite.

  • platform/gtk/Skipped: Unskip tests which now have results.
  • platform/gtk/css2.1/t0805-c5512-ibrdr-rw-00-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5512-ibrdr-rw-00-a-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5512-ibrdr-rw-00-a-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5513-brdr-bw-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5513-brdr-bw-00-b-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5513-brdr-bw-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5513-brdr-bw-01-b-g-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5513-brdr-bw-01-b-g-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5513-brdr-bw-01-b-g-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5513-brdr-bw-02-b-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5513-brdr-bw-02-b-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5513-brdr-bw-02-b-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5513-brdr-bw-03-b-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5513-brdr-bw-03-b-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5513-brdr-bw-03-b-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5513-ibrdr-bw-00-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5513-ibrdr-bw-00-a-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5513-ibrdr-bw-00-a-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5514-brdr-lw-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5514-brdr-lw-00-b-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5514-brdr-lw-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5514-brdr-lw-01-b-g-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5514-brdr-lw-01-b-g-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5514-brdr-lw-01-b-g-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5514-brdr-lw-02-b-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5514-brdr-lw-02-b-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5514-brdr-lw-02-b-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5514-brdr-lw-03-b-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5514-brdr-lw-03-b-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5514-brdr-lw-03-b-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5514-ibrdr-lw-00-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5514-ibrdr-lw-00-a-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5514-ibrdr-lw-00-a-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5515-brdr-w-00-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5515-brdr-w-00-a-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5515-brdr-w-00-a-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5515-brdr-w-01-b-g-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5515-brdr-w-01-b-g-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5515-brdr-w-01-b-g-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5515-brdr-w-02-b-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5515-brdr-w-02-b-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5515-brdr-w-02-b-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5515-ibrdr-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5515-ibrdr-00-b-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5515-ibrdr-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5516-brdr-c-00-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5516-brdr-c-00-a-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5516-brdr-c-00-a-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5516-ibrdr-c-00-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5516-ibrdr-c-00-a-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5516-ibrdr-c-00-a-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5517-brdr-s-00-c-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5517-brdr-s-00-c-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5517-brdr-s-00-c-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5517-ibrdr-s-00-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5517-ibrdr-s-00-a-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5517-ibrdr-s-00-a-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5518-brdr-t-00-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5518-brdr-t-00-a-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5518-brdr-t-00-a-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5518-brdr-t-01-e-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5518-brdr-t-01-e-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5518-brdr-t-01-e-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5518-ibrdr-t-00-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5518-ibrdr-t-00-a-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5518-ibrdr-t-00-a-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5519-brdr-r-00-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5519-brdr-r-00-a-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5519-brdr-r-00-a-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5519-brdr-r-01-e-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5519-brdr-r-01-e-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5519-brdr-r-01-e-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5519-brdr-r-02-e-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5519-brdr-r-02-e-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5519-brdr-r-02-e-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5519-ibrdr-r-00-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5519-ibrdr-r-00-a-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5519-ibrdr-r-00-a-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5520-brdr-b-00-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5520-brdr-b-00-a-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5520-brdr-b-00-a-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5520-brdr-b-01-e-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5520-brdr-b-01-e-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5520-brdr-b-01-e-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5520-ibrdr-b-00-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5520-ibrdr-b-00-a-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5520-ibrdr-b-00-a-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5521-brdr-l-00-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5521-brdr-l-00-a-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5521-brdr-l-00-a-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5521-brdr-l-01-e-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5521-brdr-l-01-e-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5521-brdr-l-01-e-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5521-brdr-l-02-e-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5521-brdr-l-02-e-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5521-brdr-l-02-e-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5521-ibrdr-l-00-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5521-ibrdr-l-00-a-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5522-brdr-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5522-brdr-00-b-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5522-brdr-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5522-brdr-01-b-g-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5522-brdr-01-b-g-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5522-brdr-01-b-g-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5522-brdr-02-e-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5522-brdr-02-e-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5522-brdr-02-e-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5522-ibrdr-00-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5522-ibrdr-00-a-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5522-ibrdr-00-a-expected.txt: Added.
  • platform/gtk/css2.1/t0905-c414-flt-00-d-expected.checksum: Added.
  • platform/gtk/css2.1/t0905-c414-flt-00-d-expected.png: Added.
  • platform/gtk/css2.1/t0905-c414-flt-00-d-expected.txt: Added.
  • platform/gtk/css2.1/t0905-c414-flt-01-d-g-expected.checksum: Added.
  • platform/gtk/css2.1/t0905-c414-flt-01-d-g-expected.png: Added.
  • platform/gtk/css2.1/t0905-c414-flt-01-d-g-expected.txt: Added.
  • platform/gtk/css2.1/t0905-c414-flt-02-c-expected.checksum: Added.
  • platform/gtk/css2.1/t0905-c414-flt-02-c-expected.png: Added.
  • platform/gtk/css2.1/t0905-c414-flt-02-c-expected.txt: Added.
  • platform/gtk/css2.1/t0905-c414-flt-03-c-expected.checksum: Added.
  • platform/gtk/css2.1/t0905-c414-flt-03-c-expected.png: Added.
  • platform/gtk/css2.1/t0905-c414-flt-03-c-expected.txt: Added.
  • platform/gtk/css2.1/t0905-c414-flt-04-c-expected.checksum: Added.
  • platform/gtk/css2.1/t0905-c414-flt-04-c-expected.png: Added.
  • platform/gtk/css2.1/t0905-c414-flt-04-c-expected.txt: Added.
  • platform/gtk/css2.1/t0905-c414-flt-fit-00-d-expected.checksum: Added.
  • platform/gtk/css2.1/t0905-c414-flt-fit-00-d-expected.png: Added.
  • platform/gtk/css2.1/t0905-c414-flt-fit-00-d-expected.txt: Added.
  • platform/gtk/css2.1/t0905-c414-flt-fit-01-d-g-expected.checksum: Added.
  • platform/gtk/css2.1/t0905-c414-flt-fit-01-d-g-expected.png: Added.
  • platform/gtk/css2.1/t0905-c414-flt-fit-01-d-g-expected.txt: Added.
  • platform/gtk/css2.1/t0905-c414-flt-wrap-00-e-expected.checksum: Added.
  • platform/gtk/css2.1/t0905-c414-flt-wrap-00-e-expected.png: Added.
  • platform/gtk/css2.1/t0905-c414-flt-wrap-00-e-expected.txt: Added.
  • platform/gtk/css2.1/t0905-c414-flt-wrap-01-d-g-expected.checksum: Added.
  • platform/gtk/css2.1/t0905-c414-flt-wrap-01-d-g-expected.png: Added.
  • platform/gtk/css2.1/t0905-c414-flt-wrap-01-d-g-expected.txt: Added.
  • platform/gtk/css2.1/t0905-c5525-fltblck-00-d-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0905-c5525-fltblck-00-d-ag-expected.png: Added.
  • platform/gtk/css2.1/t0905-c5525-fltblck-00-d-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0905-c5525-fltblck-01-d-expected.checksum: Added.
  • platform/gtk/css2.1/t0905-c5525-fltblck-01-d-expected.png: Added.
  • platform/gtk/css2.1/t0905-c5525-fltblck-01-d-expected.txt: Added.
  • platform/gtk/css2.1/t0905-c5525-fltclr-00-c-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0905-c5525-fltclr-00-c-ag-expected.png: Added.
  • platform/gtk/css2.1/t0905-c5525-fltclr-00-c-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum: Added.
  • platform/gtk/css2.1/t0905-c5525-fltcont-00-d-g-expected.png: Added.
  • platform/gtk/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt: Added.
  • platform/gtk/css2.1/t0905-c5525-flthw-00-c-g-expected.checksum: Added.
  • platform/gtk/css2.1/t0905-c5525-flthw-00-c-g-expected.png: Added.
  • platform/gtk/css2.1/t0905-c5525-flthw-00-c-g-expected.txt: Added.
  • platform/gtk/css2.1/t0905-c5525-fltinln-00-c-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0905-c5525-fltinln-00-c-ag-expected.png: Added.
  • platform/gtk/css2.1/t0905-c5525-fltinln-00-c-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.png: Added.
  • platform/gtk/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0905-c5525-fltmult-00-d-g-expected.checksum: Added.
  • platform/gtk/css2.1/t0905-c5525-fltmult-00-d-g-expected.png: Added.
  • platform/gtk/css2.1/t0905-c5525-fltmult-00-d-g-expected.txt: Added.
  • platform/gtk/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum: Added.
  • platform/gtk/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png: Added.
  • platform/gtk/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt: Added.
  • platform/gtk/css2.1/t0905-c5525-fltwidth-01-c-g-expected.checksum: Added.
  • platform/gtk/css2.1/t0905-c5525-fltwidth-01-c-g-expected.png: Added.
  • platform/gtk/css2.1/t0905-c5525-fltwidth-01-c-g-expected.txt: Added.
  • platform/gtk/css2.1/t0905-c5525-fltwidth-02-c-g-expected.checksum: Added.
  • platform/gtk/css2.1/t0905-c5525-fltwidth-02-c-g-expected.png: Added.
  • platform/gtk/css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt: Added.
  • platform/gtk/css2.1/t0905-c5525-fltwidth-03-c-g-expected.checksum: Added.
  • platform/gtk/css2.1/t0905-c5525-fltwidth-03-c-g-expected.png: Added.
  • platform/gtk/css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt: Added.
  • platform/gtk/css2.1/t0905-c5525-fltwrap-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t0905-c5525-fltwrap-00-b-expected.png: Added.
  • platform/gtk/css2.1/t0905-c5525-fltwrap-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t0905-c5526-fltclr-00-c-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0905-c5526-fltclr-00-c-ag-expected.png: Added.
  • platform/gtk/css2.1/t0905-c5526-fltclr-00-c-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0905-c5526-flthw-00-c-g-expected.checksum: Added.
  • platform/gtk/css2.1/t0905-c5526-flthw-00-c-g-expected.png: Added.
  • platform/gtk/css2.1/t0905-c5526-flthw-00-c-g-expected.txt: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-01-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-01-b-expected.png: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-01-b-expected.txt: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-02-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-02-b-expected.png: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-02-b-expected.txt: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-03-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-03-b-expected.png: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-03-b-expected.txt: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-04-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-04-b-expected.png: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-04-b-expected.txt: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-05-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-05-b-expected.png: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-05-b-expected.txt: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-06-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-06-b-expected.png: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-06-b-expected.txt: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-07-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-07-b-expected.png: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-07-b-expected.txt: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-08-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-08-b-expected.png: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-08-b-expected.txt: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-09-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-09-b-expected.png: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-09-b-expected.txt: Added.
  • platform/gtk/css2.1/t1002-c5523-width-00-b-g-expected.checksum: Added.
  • platform/gtk/css2.1/t1002-c5523-width-00-b-g-expected.png: Added.
  • platform/gtk/css2.1/t1002-c5523-width-00-b-g-expected.txt: Added.
  • platform/gtk/css2.1/t1002-c5523-width-01-b-g-expected.checksum: Added.
  • platform/gtk/css2.1/t1002-c5523-width-01-b-g-expected.png: Added.
  • platform/gtk/css2.1/t1002-c5523-width-01-b-g-expected.txt: Added.
  • platform/gtk/css2.1/t1002-c5523-width-02-b-g-expected.checksum: Added.
  • platform/gtk/css2.1/t1002-c5523-width-02-b-g-expected.png: Added.
  • platform/gtk/css2.1/t1002-c5523-width-02-b-g-expected.txt: Added.
  • platform/gtk/css2.1/t1004-c43-rpl-bbx-00-d-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t1004-c43-rpl-bbx-00-d-ag-expected.png: Added.
  • platform/gtk/css2.1/t1004-c43-rpl-bbx-00-d-ag-expected.txt: Added.
  • platform/gtk/css2.1/t1004-c43-rpl-ibx-00-d-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t1004-c43-rpl-ibx-00-d-ag-expected.png: Added.
  • platform/gtk/css2.1/t1004-c43-rpl-ibx-00-d-ag-expected.txt: Added.
  • platform/gtk/css2.1/t1004-c5524-width-00-b-g-expected.checksum: Added.
  • platform/gtk/css2.1/t1004-c5524-width-00-b-g-expected.png: Added.
  • platform/gtk/css2.1/t1004-c5524-width-00-b-g-expected.txt: Added.
  • platform/gtk/css2.1/t1005-c5524-width-00-b-g-expected.checksum: Added.
  • platform/gtk/css2.1/t1005-c5524-width-00-b-g-expected.png: Added.
  • platform/gtk/css2.1/t1005-c5524-width-00-b-g-expected.txt: Added.
  • platform/gtk/css2.1/t1005-c5524-width-01-b-g-expected.checksum: Added.
  • platform/gtk/css2.1/t1005-c5524-width-01-b-g-expected.png: Added.
  • platform/gtk/css2.1/t1005-c5524-width-01-b-g-expected.txt: Added.
  • platform/gtk/css2.1/t1008-c44-ln-box-00-d-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t1008-c44-ln-box-00-d-ag-expected.png: Added.
  • platform/gtk/css2.1/t1008-c44-ln-box-00-d-ag-expected.txt: Added.
  • platform/gtk/css2.1/t1008-c44-ln-box-01-d-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t1008-c44-ln-box-01-d-ag-expected.png: Added.
  • platform/gtk/css2.1/t1008-c44-ln-box-01-d-ag-expected.txt: Added.
  • platform/gtk/css2.1/t1008-c44-ln-box-02-d-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t1008-c44-ln-box-02-d-ag-expected.png: Added.
  • platform/gtk/css2.1/t1008-c44-ln-box-02-d-ag-expected.txt: Added.
  • platform/gtk/css2.1/t1008-c44-ln-box-03-d-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t1008-c44-ln-box-03-d-ag-expected.png: Added.
  • platform/gtk/css2.1/t1008-c44-ln-box-03-d-ag-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counter-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counter-00-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counter-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counter-01-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counter-01-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counter-01-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counter-02-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counter-02-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counter-02-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counter-03-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counter-03-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counter-03-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counter-04-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counter-04-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counter-04-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counter-05-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counter-05-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counter-05-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counter-06-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counter-06-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counter-06-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counter-07-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counter-07-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counter-07-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counter-08-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counter-08-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counter-08-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counter-09-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counter-09-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counter-09-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counter-11-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counter-11-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counter-11-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counter-12-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counter-12-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counter-12-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counter-13-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counter-13-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counter-13-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counter-14-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counter-14-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counter-14-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counter-15-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counter-15-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counter-15-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counter-16-f-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counter-16-f-expected.png: Added.
  • platform/gtk/css2.1/t1202-counter-16-f-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counters-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counters-00-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counters-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counters-01-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counters-01-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counters-01-b-expected.txt: Added.
2:06 PM Changeset in webkit [76717] by kbr@google.com
  • 11 edits in trunk/Source

2011-01-26 Kenneth Russell <​kbr@google.com>

Reviewed by James Robinson.

Fix multisampling support in DrawingBuffer
​https://bugs.webkit.org/show_bug.cgi?id=53154

Plumbed GL_ANGLE_framebuffer_multisample and
GL_ANGLE_framebuffer_blit (exposed as the unified extension
GL_CHROMIUM_framebuffer_multisample) through WebGraphicsContext3D.

  • public/WebGraphicsContext3D.h:
  • src/Extensions3DChromium.cpp: (WebCore::Extensions3DChromium::blitFramebuffer): (WebCore::Extensions3DChromium::renderbufferStorageMultisample):
  • src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DInternal::supportsExtension): (WebCore::GraphicsContext3DInternal::ensureExtensionEnabled):
  • src/GraphicsContext3DInternal.h:

2011-01-26 Kenneth Russell <​kbr@google.com>

Reviewed by James Robinson.

Fix multisampling support in DrawingBuffer
​https://bugs.webkit.org/show_bug.cgi?id=53154

In DrawingBuffer's multisampling code path, fixed enum usage and a
bug where it would incorrectly redefine the depth and stencil
buffers. Hooked up multisampling code path in Chromium port.

Tested manually with some accelerated 2D canvas content.
Multisampling isn't being switched on for the accelerated 2D
canvas at the current time because it will increase fill rate
requirements and cause a large number of rebaselines.

  • platform/graphics/Extensions3D.h:
  • platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::publishToPlatformLayer):
  • platform/graphics/chromium/Extensions3DChromium.h:
  • platform/graphics/gpu/DrawingBuffer.cpp: (WebCore::DrawingBuffer::create): (WebCore::DrawingBuffer::reset):
  • platform/graphics/opengl/Extensions3DOpenGL.cpp: (WebCore::Extensions3DOpenGL::supports):
1:59 PM Changeset in webkit [76716] by yael.aharon@nokia.com
  • 6 edits in trunk

2011-01-26 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Laszlo Gombos.

[Qt][Symbian] Fix --minimal build
​https://bugs.webkit.org/show_bug.cgi?id=52839

Move definition of USE_SYSTEM_MALLOC out of pri file.
Put it in platform.h instead.

  • Source/WebKit.pri:

2011-01-26 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Laszlo Gombos.

[Qt][Symbian] Fix --minimal build
​https://bugs.webkit.org/show_bug.cgi?id=52839

Move definition of USE_SYSTEM_MALLOC out of pri file.
Put it in platform.h instead.

  • wtf/Platform.h:
  • wtf/TCSystemAlloc.cpp:
  • wtf/wtf.pri:
1:54 PM Changeset in webkit [76715] by Martin Robinson
  • 2 edits
    150 adds in trunk/LayoutTests

2011-01-26 Martin Robinson <​mrobinson@igalia.com>

Continue importing GTK+ test results for the CSS 2.1 test suite.

  • platform/gtk/Skipped: Unskip tests with results.
  • platform/gtk/css2.1/t0803-c5504-imrgn-l-05-b-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5504-imrgn-l-05-b-ag-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5504-imrgn-l-05-b-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5504-imrgn-l-06-b-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5504-imrgn-l-06-b-ag-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5504-imrgn-l-06-b-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5504-mrgn-l-00-c-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5504-mrgn-l-00-c-ag-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5504-mrgn-l-00-c-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5504-mrgn-l-01-c-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5504-mrgn-l-01-c-a-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5504-mrgn-l-01-c-a-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5504-mrgn-l-02-c-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5504-mrgn-l-02-c-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5504-mrgn-l-02-c-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5504-mrgn-l-03-c-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5504-mrgn-l-03-c-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5504-mrgn-l-03-c-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5505-imrgn-00-a-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5505-imrgn-00-a-ag-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5505-imrgn-00-a-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5505-mrgn-00-b-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5505-mrgn-00-b-ag-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5505-mrgn-00-b-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5505-mrgn-01-e-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5505-mrgn-01-e-a-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5505-mrgn-01-e-a-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5505-mrgn-02-c-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5505-mrgn-02-c-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5505-mrgn-02-c-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5505-mrgn-03-c-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5505-mrgn-03-c-ag-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5505-mrgn-03-c-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5506-ipadn-t-00-b-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5506-ipadn-t-00-b-a-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5506-ipadn-t-00-b-a-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5506-ipadn-t-01-b-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5506-ipadn-t-01-b-a-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5506-ipadn-t-01-b-a-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5506-ipadn-t-02-b-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5506-ipadn-t-02-b-a-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5506-ipadn-t-02-b-a-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5506-padn-t-00-b-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5506-padn-t-00-b-a-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5506-padn-t-00-b-a-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5507-ipadn-r-00-b-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5507-ipadn-r-00-b-ag-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5507-ipadn-r-00-b-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5507-ipadn-r-01-b-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5507-ipadn-r-01-b-ag-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5507-ipadn-r-01-b-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5507-ipadn-r-02-b-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5507-ipadn-r-02-b-ag-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5507-ipadn-r-02-b-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5507-ipadn-r-03-b-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5507-ipadn-r-03-b-a-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5507-ipadn-r-03-b-a-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5507-ipadn-r-04-b-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5507-ipadn-r-04-b-ag-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5507-ipadn-r-04-b-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5507-padn-r-00-c-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5507-padn-r-00-c-ag-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5507-padn-r-00-c-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5507-padn-r-01-c-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5507-padn-r-01-c-a-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5507-padn-r-01-c-a-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5507-padn-r-02-f-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5507-padn-r-02-f-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5507-padn-r-02-f-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5507-padn-r-03-f-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5507-padn-r-03-f-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5507-padn-r-03-f-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5508-ipadn-b-00-b-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5508-ipadn-b-00-b-a-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5508-ipadn-b-00-b-a-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5508-ipadn-b-01-f-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5508-ipadn-b-01-f-a-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5508-ipadn-b-01-f-a-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5508-ipadn-b-02-b-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5508-ipadn-b-02-b-a-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5508-ipadn-b-02-b-a-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5508-ipadn-b-03-b-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5508-ipadn-b-03-b-a-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5508-ipadn-b-03-b-a-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5509-ipadn-l-00-b-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5509-ipadn-l-00-b-ag-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5509-ipadn-l-00-b-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5509-ipadn-l-01-b-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5509-ipadn-l-01-b-ag-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5509-ipadn-l-01-b-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5509-ipadn-l-02-b-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5509-ipadn-l-02-b-ag-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5509-ipadn-l-02-b-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5509-ipadn-l-03-b-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5509-ipadn-l-03-b-a-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5509-ipadn-l-03-b-a-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5509-ipadn-l-04-f-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5509-ipadn-l-04-f-ag-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5509-ipadn-l-04-f-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5509-padn-l-00-b-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5509-padn-l-00-b-ag-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5509-padn-l-00-b-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5509-padn-l-01-b-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5509-padn-l-01-b-a-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5509-padn-l-01-b-a-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5509-padn-l-02-f-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5509-padn-l-02-f-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5509-padn-l-02-f-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5509-padn-l-03-f-g-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5509-padn-l-03-f-g-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5509-padn-l-03-f-g-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5510-ipadn-00-b-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5510-ipadn-00-b-ag-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5510-ipadn-00-b-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5510-padn-00-b-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5510-padn-00-b-ag-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5510-padn-00-b-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5510-padn-01-e-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5510-padn-01-e-a-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5510-padn-01-e-a-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5510-padn-02-f-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5510-padn-02-f-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5510-padn-02-f-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5511-brdr-tw-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5511-brdr-tw-00-b-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5511-brdr-tw-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5511-brdr-tw-01-b-g-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5511-brdr-tw-01-b-g-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5511-brdr-tw-01-b-g-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5511-brdr-tw-02-b-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5511-brdr-tw-02-b-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5511-brdr-tw-02-b-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5511-brdr-tw-03-b-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5511-brdr-tw-03-b-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5511-brdr-tw-03-b-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5511-ibrdr-tw-00-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5511-ibrdr-tw-00-a-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5511-ibrdr-tw-00-a-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5512-brdr-rw-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5512-brdr-rw-00-b-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5512-brdr-rw-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5512-brdr-rw-01-b-g-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5512-brdr-rw-01-b-g-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5512-brdr-rw-01-b-g-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5512-brdr-rw-02-b-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5512-brdr-rw-02-b-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5512-brdr-rw-02-b-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5512-brdr-rw-03-b-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5512-brdr-rw-03-b-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5512-brdr-rw-03-b-expected.txt: Added.
1:45 PM Changeset in webkit [76714] by Martin Robinson
  • 2 edits
    150 adds in trunk/LayoutTests

2011-01-26 Martin Robinson <​mrobinson@igalia.com>

Begin importing GTK+ results for the CSS 2.1 test suite. This will
be the first in a series of commits. Each test results has been checked
against those generated for Qt and Mac.

  • platform/gtk/Skipped: Unskip tests which now have results.
  • platform/gtk/css2.1/t0402-c71-fwd-parsing-00-f-expected.checksum: Added.
  • platform/gtk/css2.1/t0402-c71-fwd-parsing-00-f-expected.png: Added.
  • platform/gtk/css2.1/t0402-c71-fwd-parsing-00-f-expected.txt: Added.
  • platform/gtk/css2.1/t0402-c71-fwd-parsing-01-f-expected.checksum: Added.
  • platform/gtk/css2.1/t0402-c71-fwd-parsing-01-f-expected.png: Added.
  • platform/gtk/css2.1/t0402-c71-fwd-parsing-01-f-expected.txt: Added.
  • platform/gtk/css2.1/t0402-c71-fwd-parsing-02-f-expected.checksum: Added.
  • platform/gtk/css2.1/t0402-c71-fwd-parsing-02-f-expected.png: Added.
  • platform/gtk/css2.1/t0402-c71-fwd-parsing-02-f-expected.txt: Added.
  • platform/gtk/css2.1/t0402-c71-fwd-parsing-03-f-expected.checksum: Added.
  • platform/gtk/css2.1/t0402-c71-fwd-parsing-03-f-expected.png: Added.
  • platform/gtk/css2.1/t0402-c71-fwd-parsing-03-f-expected.txt: Added.
  • platform/gtk/css2.1/t0402-c71-fwd-parsing-04-f-expected.checksum: Added.
  • platform/gtk/css2.1/t0402-c71-fwd-parsing-04-f-expected.png: Added.
  • platform/gtk/css2.1/t0402-c71-fwd-parsing-04-f-expected.txt: Added.
  • platform/gtk/css2.1/t0402-syntax-01-f-expected.checksum: Added.
  • platform/gtk/css2.1/t0402-syntax-01-f-expected.png: Added.
  • platform/gtk/css2.1/t0402-syntax-01-f-expected.txt: Added.
  • platform/gtk/css2.1/t0402-syntax-02-f-expected.checksum: Added.
  • platform/gtk/css2.1/t0402-syntax-02-f-expected.png: Added.
  • platform/gtk/css2.1/t0402-syntax-02-f-expected.txt: Added.
  • platform/gtk/css2.1/t0402-syntax-03-f-expected.checksum: Added.
  • platform/gtk/css2.1/t0402-syntax-03-f-expected.png: Added.
  • platform/gtk/css2.1/t0402-syntax-03-f-expected.txt: Added.
  • platform/gtk/css2.1/t0402-syntax-04-f-expected.checksum: Added.
  • platform/gtk/css2.1/t0402-syntax-04-f-expected.png: Added.
  • platform/gtk/css2.1/t0402-syntax-04-f-expected.txt: Added.
  • platform/gtk/css2.1/t0402-syntax-05-f-expected.checksum: Added.
  • platform/gtk/css2.1/t0402-syntax-05-f-expected.png: Added.
  • platform/gtk/css2.1/t0402-syntax-05-f-expected.txt: Added.
  • platform/gtk/css2.1/t0402-syntax-06-f-expected.checksum: Added.
  • platform/gtk/css2.1/t0402-syntax-06-f-expected.png: Added.
  • platform/gtk/css2.1/t0402-syntax-06-f-expected.txt: Added.
  • platform/gtk/css2.1/t0505-c16-descendant-00-e-expected.checksum: Added.
  • platform/gtk/css2.1/t0505-c16-descendant-00-e-expected.png: Added.
  • platform/gtk/css2.1/t0505-c16-descendant-00-e-expected.txt: Added.
  • platform/gtk/css2.1/t0505-c16-descendant-01-e-expected.checksum: Added.
  • platform/gtk/css2.1/t0505-c16-descendant-01-e-expected.png: Added.
  • platform/gtk/css2.1/t0505-c16-descendant-01-e-expected.txt: Added.
  • platform/gtk/css2.1/t0505-c16-descendant-02-e-expected.checksum: Added.
  • platform/gtk/css2.1/t0505-c16-descendant-02-e-expected.png: Added.
  • platform/gtk/css2.1/t0505-c16-descendant-02-e-expected.txt: Added.
  • platform/gtk/css2.1/t0509-c15-ids-00-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0509-c15-ids-00-a-expected.png: Added.
  • platform/gtk/css2.1/t0509-c15-ids-00-a-expected.txt: Added.
  • platform/gtk/css2.1/t0509-c15-ids-01-e-expected.checksum: Added.
  • platform/gtk/css2.1/t0509-c15-ids-01-e-expected.png: Added.
  • platform/gtk/css2.1/t0509-c15-ids-01-e-expected.txt: Added.
  • platform/gtk/css2.1/t0509-id-sel-syntax-01-f-expected.checksum: Added.
  • platform/gtk/css2.1/t0509-id-sel-syntax-01-f-expected.png: Added.
  • platform/gtk/css2.1/t0509-id-sel-syntax-01-f-expected.txt: Added.
  • platform/gtk/css2.1/t0509-id-sel-syntax-02-b-expected.checksum: Added.
  • platform/gtk/css2.1/t0509-id-sel-syntax-02-b-expected.png: Added.
  • platform/gtk/css2.1/t0509-id-sel-syntax-02-b-expected.txt: Added.
  • platform/gtk/css2.1/t0510-c25-pseudo-elmnt-00-c-expected.checksum: Added.
  • platform/gtk/css2.1/t0510-c25-pseudo-elmnt-00-c-expected.png: Added.
  • platform/gtk/css2.1/t0510-c25-pseudo-elmnt-00-c-expected.txt: Added.
  • platform/gtk/css2.1/t0511-c21-pseud-anch-00-e-i-expected.checksum: Added.
  • platform/gtk/css2.1/t0511-c21-pseud-anch-00-e-i-expected.png: Added.
  • platform/gtk/css2.1/t0511-c21-pseud-anch-00-e-i-expected.txt: Added.
  • platform/gtk/css2.1/t0511-c21-pseud-link-00-e-expected.checksum: Added.
  • platform/gtk/css2.1/t0511-c21-pseud-link-00-e-expected.png: Added.
  • platform/gtk/css2.1/t0511-c21-pseud-link-00-e-expected.txt: Added.
  • platform/gtk/css2.1/t0511-c21-pseud-link-01-e-expected.checksum: Added.
  • platform/gtk/css2.1/t0511-c21-pseud-link-01-e-expected.png: Added.
  • platform/gtk/css2.1/t0511-c21-pseud-link-01-e-expected.txt: Added.
  • platform/gtk/css2.1/t0511-c21-pseud-link-02-e-expected.checksum: Added.
  • platform/gtk/css2.1/t0511-c21-pseud-link-02-e-expected.png: Added.
  • platform/gtk/css2.1/t0511-c21-pseud-link-02-e-expected.txt: Added.
  • platform/gtk/css2.1/t0511-c21-pseud-link-03-e-expected.checksum: Added.
  • platform/gtk/css2.1/t0511-c21-pseud-link-03-e-expected.png: Added.
  • platform/gtk/css2.1/t0511-c21-pseud-link-03-e-expected.txt: Added.
  • platform/gtk/css2.1/t0602-c13-inh-underlin-00-e-expected.checksum: Added.
  • platform/gtk/css2.1/t0602-c13-inh-underlin-00-e-expected.png: Added.
  • platform/gtk/css2.1/t0602-c13-inh-underlin-00-e-expected.txt: Added.
  • platform/gtk/css2.1/t0602-c13-inheritance-00-e-expected.checksum: Added.
  • platform/gtk/css2.1/t0602-c13-inheritance-00-e-expected.png: Added.
  • platform/gtk/css2.1/t0602-c13-inheritance-00-e-expected.txt: Added.
  • platform/gtk/css2.1/t0602-inherit-bdr-pad-b-00-expected.checksum: Added.
  • platform/gtk/css2.1/t0602-inherit-bdr-pad-b-00-expected.png: Added.
  • platform/gtk/css2.1/t0602-inherit-bdr-pad-b-00-expected.txt: Added.
  • platform/gtk/css2.1/t0603-c11-import-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t0603-c11-import-00-b-expected.png: Added.
  • platform/gtk/css2.1/t0603-c11-import-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t0801-c412-hz-box-00-b-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0801-c412-hz-box-00-b-a-expected.png: Added.
  • platform/gtk/css2.1/t0801-c412-hz-box-00-b-a-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5501-imrgn-t-00-b-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5501-imrgn-t-00-b-ag-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5501-imrgn-t-00-b-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5501-mrgn-t-00-b-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5501-mrgn-t-00-b-a-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5501-mrgn-t-00-b-a-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5502-imrgn-r-00-b-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5502-imrgn-r-00-b-ag-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5502-imrgn-r-00-b-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5502-imrgn-r-01-b-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5502-imrgn-r-01-b-ag-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5502-imrgn-r-01-b-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5502-imrgn-r-02-b-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5502-imrgn-r-02-b-a-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5502-imrgn-r-02-b-a-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5502-imrgn-r-03-b-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5502-imrgn-r-03-b-a-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5502-imrgn-r-03-b-a-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5502-imrgn-r-04-b-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5502-imrgn-r-04-b-ag-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5502-imrgn-r-04-b-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5502-imrgn-r-05-b-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5502-imrgn-r-05-b-ag-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5502-imrgn-r-05-b-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5502-imrgn-r-06-b-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5502-imrgn-r-06-b-ag-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5502-imrgn-r-06-b-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5502-mrgn-r-00-c-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5502-mrgn-r-00-c-ag-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5502-mrgn-r-00-c-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5502-mrgn-r-01-c-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5502-mrgn-r-01-c-a-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5502-mrgn-r-01-c-a-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5502-mrgn-r-02-c-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5502-mrgn-r-02-c-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5502-mrgn-r-02-c-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5502-mrgn-r-03-c-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5502-mrgn-r-03-c-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5502-mrgn-r-03-c-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5503-imrgn-b-00-b-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5503-imrgn-b-00-b-a-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5503-imrgn-b-00-b-a-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5503-mrgn-b-00-b-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5503-mrgn-b-00-b-a-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5503-mrgn-b-00-b-a-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5504-imrgn-l-00-b-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5504-imrgn-l-00-b-ag-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5504-imrgn-l-00-b-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5504-imrgn-l-01-b-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5504-imrgn-l-01-b-ag-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5504-imrgn-l-01-b-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5504-imrgn-l-02-b-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5504-imrgn-l-02-b-ag-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5504-imrgn-l-02-b-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5504-imrgn-l-03-b-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5504-imrgn-l-03-b-a-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5504-imrgn-l-03-b-a-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5504-imrgn-l-04-b-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5504-imrgn-l-04-b-ag-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5504-imrgn-l-04-b-ag-expected.txt: Added.
  • platform/gtk/css2.1/t09-c5526c-display-00-e-expected.checksum: Added.
  • platform/gtk/css2.1/t09-c5526c-display-00-e-expected.png: Added.
  • platform/gtk/css2.1/t09-c5526c-display-00-e-expected.txt: Added.
1:30 PM Changeset in webkit [76713] by tony@chromium.org
  • 4 edits in trunk/Source

2011-01-26 Tony Chang <​tony@chromium.org>

Unreviewed.

[chromium] revert r68310 because of race conditions detected by tsans
​https://bugs.webkit.org/show_bug.cgi?id=53185

Causes stability problems for Chromium, ​http://crbug.com/70589

  • platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp: (WebCore::SQLiteFileSystem::registerSQLiteVFS):

2011-01-26 Tony Chang <​tony@chromium.org>

Unreviewed.

[chromium] revert r68310 because of race conditions detected by tsans
​https://bugs.webkit.org/show_bug.cgi?id=53185

  • DEPS: Roll chromium to 72673 to pick up sqlite revert.
1:07 PM Changeset in webkit [76712] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Skip fast/loader/willSendRequest-null-for-preload.html on GTK, because GTK doesn't have
support for setWillSendRequestReturnsNull.

  • platform/gtk/Skipped:
1:02 PM Changeset in webkit [76711] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-26 Ryosuke Niwa <​rniwa@webkit.org>

Another unreviewed Chromium test expectation update.

  • platform/chromium/test_expectations.txt:
12:46 PM Changeset in webkit [76710] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-26 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed Chromium test expectation update.

  • platform/chromium/test_expectations.txt:
12:45 PM Changeset in webkit [76709] by dpranke@chromium.org
  • 2 edits
    2 adds in trunk/Tools

2011-01-26 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Tony Chang.

new-run-webkit-tests: add a "mock DRT" port implementation
and a separate class that emulates what we expect the
DumpRenderTree behavior to be.

This will eventually replace port/dryrun.py and allow us to get
better test coverage of the new-run-webkit-tests code as well as
a reference for what new-run-webkit-tests expects from DRT.

This is the first attempt at this, and it is pretty bare-boned. It
really only has been tested on the 'mac' port (and a little on
the 'chromium-mac' port.

​https://bugs.webkit.org/show_bug.cgi?id=53126

  • Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
  • Scripts/webkitpy/layout_tests/port/factory.py:
12:42 PM Changeset in webkit [76708] by jschuh@chromium.org
  • 3 edits
    2 adds in trunk

2011-01-26 Justin Schuh <​jschuh@chromium.org>

Reviewed by Adam Barth.

Make fireEventsAndUpdateStyle use stack local vectors.
​https://bugs.webkit.org/show_bug.cgi?id=46760

Test: animations/animation-add-events-in-handler.html

  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::fireEventsAndUpdateStyle):

2011-01-26 Justin Schuh <​jschuh@chromium.org>

Reviewed by Adam Barth.

Make fireEventsAndUpdateStyle use stack local vectors.
​https://bugs.webkit.org/show_bug.cgi?id=46760

  • animations/animation-add-events-in-handler-expected.txt: Added.
  • animations/animation-add-events-in-handler.html: Added.
12:32 PM Changeset in webkit [76707] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-26 Tony Chang <​tony@chromium.org>

Unreviewed, marking fast/overflow/overflow-rtl-vertical.html as
passing. This was fixed in r76669.

  • platform/chromium/test_expectations.txt:
12:12 PM Changeset in webkit [76706] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Skip fast/loader/willSendRequest-null-for-preload.html on WebKit2, because WebKit2 doesn't have
setWillSendRequestReturnsNull yet.

This is tracked by ​https://bugs.webkit.org/show_bug.cgi?id=42690.

  • platform/mac-wk2/Skipped:
12:03 PM Changeset in webkit [76705] by bweinstein@apple.com
  • 3 edits
    1 add
    1 delete in trunk/LayoutTests

Update the test landed in r76701 to not depend on loading a "script" from ​http://example.com, make it
use a local script (which still reproduces the crash).

Reviewed by Ryosuke Niwa.

  • fast/loader/resources/empty-script.js: Added.
  • fast/loader/willSendRequest-null-for-preload-expected.txt: Removed the line for the console error.
  • fast/loader/willSendRequest-null-for-preload.html: Have the script in the head be a local script.
  • platform/win/fast/loader: Removed.
  • platform/win/fast/loader/willSendRequest-null-for-preload-expected.txt: Removed. No need for platform-specific results.
11:53 AM Changeset in webkit [76704] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-01-26 Xianzhu Wang <​wangxianzhu@google.com>

Reviewed by Tony Chang.

Add '--no-timeout' option to Chromium DRT to ease debugging.
​https://bugs.webkit.org/show_bug.cgi?id=52873

  • DumpRenderTree/chromium/DumpRenderTree.cpp: (main):
11:43 AM Changeset in webkit [76703] by rniwa@webkit.org
  • 5 edits in trunk/LayoutTests

2011-01-26 Ryosuke Niwa <​rniwa@webkit.org>

Another unreviewed Chromium rebaselines for r76688.

  • platform/chromium-win/svg/batik/text/textEffect3-expected.checksum:
  • platform/chromium-win/svg/batik/text/textEffect3-expected.png:
  • platform/chromium-win/svg/custom/use-setAttribute-crash-expected.checksum:
  • platform/chromium-win/svg/custom/use-setAttribute-crash-expected.png:
11:14 AM Changeset in webkit [76702] by Nate Chapin
  • 6 edits in trunk/Source/WebCore

2011-01-26 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Remove m_URL from FrameLoader and depend on Document::url()
instead. FrameLoader::url() will be removed in a followup patch.
​https://bugs.webkit.org/show_bug.cgi?id=41165

Refactor only, no new tests.

  • WebCore.exp.in:
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::updateURLForPushOrReplaceState):
  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::begin):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::iconURL): (WebCore::FrameLoader::didOpenURL): (WebCore::FrameLoader::didExplicitOpen): (WebCore::FrameLoader::receivedFirstData): (WebCore::FrameLoader::url): (WebCore::FrameLoader::setOutgoingReferrer): (WebCore::FrameLoader::startIconLoader): (WebCore::FrameLoader::commitIconURLToIconDatabase): (WebCore::FrameLoader::finishedParsing): (WebCore::FrameLoader::checkIfDisplayInsecureContent): (WebCore::FrameLoader::checkIfRunInsecureContent): (WebCore::FrameLoader::updateFirstPartyForCookies): (WebCore::FrameLoader::loadInSameDocument): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::open): (WebCore::FrameLoader::shouldScrollToAnchor):
  • loader/FrameLoader.h: Rename setURL() to setOutgoingReferrer().
11:07 AM Changeset in webkit [76701] by bweinstein@apple.com
  • 7 edits
    4 adds in trunk

Source/WebCore: Crashes loading pages when cancelling subresource loads through WebKit
​https://bugs.webkit.org/show_bug.cgi?id=53123
<rdar://problem/8914361>

Reviewed by Antti Koivisto.

Fix a crash that happened when cancelling subresource loads through WebKit.

When a load is cancelled synchronously (via the WebKit client), CachedResourceLoader::requestResource
can be called recursively on the same function, either leading to infinite recursion, or deleting
an object when it is not done being used.

The fix for this was to call checkForPendingPreloads and servePendingRequests asynchronously when
CachedResourceLoader::loadDone was called synchronously (due to the load being cancelled synchronously).

Test: fast/loader/willSendRequest-null-for-preload.html

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::setRequest): Only dispatch didReceiveServerRedirectForProvisionalLoadForFrame

if our new URL is non-null.

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::CachedResourceLoader): Initialize our timer.
(WebCore::CachedResourceLoader::loadDone): If the CachedResource we were passed in was 0, that means this

function was called synchronously
from CachedResourceRequest::load, and we don't want to call into checkForPendingPreloads synchronously,
so put it on a 0-delay timer to make the calls to checkForPendingPreloads and servePendingRequests asynchronous.

(WebCore::CachedResourceLoader::loadDonePendingActionTimerFired): Call checkForPendingPreloads and servePendingRequests.
(WebCore::CachedResourceLoader::checkForPendingPreloads): m_pendingPreloads is now a Deque instead of a Vector,

so use Deque methods.

  • loader/cache/CachedResourceLoader.h: Add the timer, the timer callback function, and make m_pendingPreloads a Deque.

Source/WebKit2: Crashes loading pages when cancelling subresource loads through WebKit
​https://bugs.webkit.org/show_bug.cgi?id=53123
<rdar://problem/8914361>

Reviewed by Antti Koivisto.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForMIMEType): If our URL is null, return early instead of dispatching

a message.

LayoutTests: Reviewed byAntti Koivisto.

Crashes loading pages when cancelling subresource loads through WebKit
​https://bugs.webkit.org/show_bug.cgi?id=53123
<rdar://problem/8914361>

Add tests for crashing when cancelling subresource loads through WebKit via setWillSendRequestReturnsNull.

  • fast/loader/willSendRequest-null-for-preload-expected.txt: Added.
  • fast/loader/willSendRequest-null-for-preload.html: Added.
11:05 AM CSS21Results edited by tabatkins@google.com
Added rtl-linebreak (was missing because Simon had marked as invalid), … (diff)
10:40 AM Changeset in webkit [76700] by rniwa@webkit.org
  • 29 edits in trunk/LayoutTests

2011-01-26 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed Chromium Linux rebaselines for r76688.

  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.png:
  • platform/chromium-linux/svg/batik/text/textOnPathSpaces-expected.checksum:
  • platform/chromium-linux/svg/batik/text/textOnPathSpaces-expected.png:
  • platform/chromium-linux/svg/batik/text/verticalText-expected.checksum:
  • platform/chromium-linux/svg/batik/text/verticalText-expected.png:
  • platform/chromium-linux/svg/batik/text/verticalTextOnPath-expected.checksum:
  • platform/chromium-linux/svg/batik/text/verticalTextOnPath-expected.png:
  • platform/chromium-linux/svg/custom/linking-a-03-b-all-expected.checksum:
  • platform/chromium-linux/svg/custom/linking-a-03-b-all-expected.png:
  • platform/chromium-linux/svg/custom/linking-a-03-b-viewBox-transform-expected.checksum:
  • platform/chromium-linux/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
  • platform/chromium-linux/svg/custom/preserve-aspect-ratio-syntax-expected.checksum:
  • platform/chromium-linux/svg/custom/preserve-aspect-ratio-syntax-expected.png:
  • platform/chromium-linux/svg/custom/use-transform-expected.checksum:
  • platform/chromium-linux/svg/custom/use-transform-expected.png:
  • platform/chromium-linux/svg/custom/viewbox-syntax-expected.checksum:
  • platform/chromium-linux/svg/custom/viewbox-syntax-expected.png:
  • platform/chromium-linux/svg/text/text-text-06-t-expected.checksum:
  • platform/chromium-linux/svg/text/text-text-06-t-expected.png:
10:40 AM QtWebKit edited by Ademar Reis
(diff)
10:39 AM QtWebKitRelease21 edited by Ademar Reis
(diff)
10:24 AM Changeset in webkit [76699] by podivilov@chromium.org
  • 3 edits
    2 adds in trunk

2011-01-25 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: evaluate in console may not work when window.console is substituted or deleted.
​https://bugs.webkit.org/show_bug.cgi?id=53072

  • inspector/console-substituted-expected.txt: Added.
  • inspector/console-substituted.html: Added.

2011-01-25 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: evaluate in console may not work when window.console is substituted or deleted.
​https://bugs.webkit.org/show_bug.cgi?id=53072

Test: inspector/console-substituted.html

  • inspector/InjectedScriptSource.js: (.):
10:20 AM Changeset in webkit [76698] by rniwa@webkit.org
  • 2 edits
    6 adds in trunk/LayoutTests

2011-01-26 Ryosuke Niwa <​rniwa@webkit.org>

Layout test missing expectation after 58524
​https://bugs.webkit.org/show_bug.cgi?id=38360

Unreviewed; Chromium rebaselines.

  • platform/chromium-linux/fast/images/svg-background-partial-redraw-expected.checksum: Added.
  • platform/chromium-linux/fast/images/svg-background-partial-redraw-expected.png: Added.
  • platform/chromium-win/fast/images/svg-background-partial-redraw-expected.checksum: Added.
  • platform/chromium-win/fast/images/svg-background-partial-redraw-expected.png: Added.
  • platform/chromium-win/fast/images/svg-background-partial-redraw-expected.txt: Added.
  • platform/chromium-win/svg/carto.net/tabgroup-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
10:17 AM Changeset in webkit [76697] by Carlos Garcia Campos
  • 4 edits
    3 adds in trunk

2011-01-26 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[cairo] Use CAIRO_OPERATOR_DARKEN when available
​https://bugs.webkit.org/show_bug.cgi?id=53084

  • platform/gtk/Skipped: Unskip test.
  • platform/gtk/fast/canvas/canvas-composite-expected.checksum: Added.
  • platform/gtk/fast/canvas/canvas-composite-expected.png: Added.
  • platform/gtk/fast/canvas/canvas-composite-expected.txt: Added.

2011-01-26 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[cairo] Use CAIRO_OPERATOR_DARKEN when available
​https://bugs.webkit.org/show_bug.cgi?id=53084

Use CAIRO_OPERATOR_DARKEN for CompositePlusDarker instead of
CAIRO_OPERATOR_SATURATE when building with cairo version >= 1.10.

  • platform/graphics/cairo/CairoUtilities.cpp: (WebCore::toCairoOperator):
10:09 AM Changeset in webkit [76696] by kov@webkit.org
  • 2 edits in trunk/Websites/planet.webkit.org

2011-01-26 Gustavo Noronha Silva <Gustavo Noronha Silva>

Rubber-stamped by Andreas Kling.

Fix my blog's feed URL, since it seems to have changed with the
new version of Wordpress causing unwanted posts to appear in
Planet WebKit.

  • config.ini:
10:08 AM QtWebKitFeatures21 edited by Ademar Reis
(diff)
10:07 AM Changeset in webkit [76695] by rniwa@webkit.org
  • 39 edits
    2 adds in trunk/LayoutTests

2011-01-26 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed Chromium rebaselines for r76688.

  • platform/chromium-linux/fast/backgrounds/size/contain-and-cover-expected.checksum:
  • platform/chromium-linux/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-linux/fast/backgrounds/svg-as-background-5-expected.checksum:
  • platform/chromium-linux/fast/backgrounds/svg-as-background-5-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-33-t-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-33-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/chromium-linux/svg/custom/focus-ring-expected.checksum:
  • platform/chromium-linux/svg/custom/focus-ring-expected.png:
  • platform/chromium-linux/svg/custom/svg-curve-with-relative-cordinates-expected.checksum:
  • platform/chromium-linux/svg/custom/svg-curve-with-relative-cordinates-expected.png:
  • platform/chromium-linux/svg/transforms/animated-path-inside-transformed-html-expected.checksum: Added.
  • platform/chromium-linux/svg/transforms/animated-path-inside-transformed-html-expected.png: Added.
  • platform/chromium-win/fast/backgrounds/size/contain-and-cover-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-win/fast/backgrounds/svg-as-background-5-expected.checksum:
  • platform/chromium-win/fast/backgrounds/svg-as-background-5-expected.png:
  • platform/chromium-win/fast/images/animated-svg-as-image-expected.checksum:
  • platform/chromium-win/fast/images/animated-svg-as-image-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-24-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-24-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-33-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-33-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/chromium-win/svg/custom/focus-ring-expected.checksum:
  • platform/chromium-win/svg/custom/focus-ring-expected.png:
  • platform/chromium-win/svg/custom/svg-curve-with-relative-cordinates-expected.checksum:
  • platform/chromium-win/svg/custom/svg-curve-with-relative-cordinates-expected.png:
  • platform/chromium-win/svg/custom/use-css-events-expected.checksum:
  • platform/chromium-win/svg/custom/use-css-events-expected.png:
  • platform/chromium-win/svg/transforms/animated-path-inside-transformed-html-expected.checksum:
  • platform/chromium-win/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/chromium-win/svg/zoom/text/zoom-coords-viewattr-01-b-expected.checksum:
  • platform/chromium-win/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png:
9:56 AM Changeset in webkit [76694] by Csaba Osztrogonác
  • 4 edits in trunk

[Qt] Fix qt_minimal build
​https://bugs.webkit.org/show_bug.cgi?id=53172

Reviewed by Andreas Kling.

  • Source/WebKit.pri:
  • Tools/QtTestBrowser/locationedit.h:
9:41 AM QtWebKitFeatures22 edited by Ademar Reis
(diff)
9:38 AM QtWebKitRelease22 edited by Ademar Reis
(diff)
9:34 AM QtWebKitRelease21 edited by Ademar Reis
(diff)
9:32 AM Changeset in webkit [76693] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-01-26 Mansi Mithal <​mansi.mithal@nokia.com>

Reviewed by Antonio Gomes.

QtTestBrowser should have a UI Setting to disable plugins
​https://bugs.webkit.org/show_bug.cgi?id=52408

Added a new action item named "Disable Plugins"
under the "Settings" menu.

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::createChrome): (LauncherWindow::togglePlugins):
  • QtTestBrowser/launcherwindow.h:
9:19 AM Changeset in webkit [76692] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-26 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: visualize \n in strings as unicode cr
symbol in stack variables sidebar.
​https://bugs.webkit.org/show_bug.cgi?id=53162

  • inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertyTreeElement.prototype.update):
8:24 AM Changeset in webkit [76691] by caseq@chromium.org
  • 1 edit in trunk/Source/WebCore/ChangeLog

Unreviewed: fixed bug summary in ChangeLog entry for r76690.

8:06 AM Changeset in webkit [76690] by caseq@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-01-26 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: summary bar is not resized properly with the rest of network panel

  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::didReceiveResponse):
  • inspector/front-end/Resource.js: (WebInspector.Resource): (WebInspector.Resource.prototype.get transferSize): (WebInspector.Resource.prototype.set responseHeaders): (WebInspector.Resource.prototype._headersSize): (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
7:51 AM Changeset in webkit [76689] by carol.szabo@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-01-26 Carol Szabo <​carol.szabo@nokia.com>

Reviewed by Simon Hausmann.

Fixed TiledBacking store to take into account new dirty regions caused by
paint time layouts.

Flawed rendering design for QtWebKit resulting in artifacts being displayed
​https://bugs.webkit.org/show_bug.cgi?id=49184

There are no new tests as this patch aims at fixing flicker that
happen randomly, mostly on slow hardware, thus are hard to reproduce
consistently in an automated test.

This patch does not fully address the said bug but it is a step in the
right direction. A full solution to the bug, as currently perceived,
requires either a Qt GUI API change, a performance hit for QtWebKit,
or a hack, until a full solution is provided this patch is progress.

  • platform/graphics/TiledBackingStore.cpp: (WebCore::TiledBackingStore::updateTileBuffers): Changed to take into account newly dirtied areas created during tile update initiated layouts during the same update.
6:50 AM Changeset in webkit [76688] by Patrick Gansterer
  • 6 edits in trunk/Source/WebCore

2011-01-26 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[SKIA] Remove "current path" of GraphicsContext
​https://bugs.webkit.org/show_bug.cgi?id=53124

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::clipPath): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath):
  • platform/graphics/skia/PathSkia.cpp: (WebCore::Path::strokeBoundingRect):
  • platform/graphics/skia/PlatformContextSkia.cpp:
  • platform/graphics/skia/PlatformContextSkia.h:
6:11 AM Changeset in webkit [76687] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-26 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[WINCE] Add JIT support to build system
​https://bugs.webkit.org/show_bug.cgi?id=53079

  • CMakeListsWinCE.txt:
6:09 AM Changeset in webkit [76686] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-01-26 Zalan Bujtas <​zbujtas@gmail.com>

Reviewed by Andreas Kling.

[Qt] Path::normalAngleAtLength() returns incorrect value on ACID3.

QPainterPath returns angle values with the origo being at the top left corner,
we need to account for this in normalAngleAtLength().
This Regressed with r66979.

No new tests as this is already covered by ACID3.

  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::normalAngleAtLength):
5:06 AM Changeset in webkit [76685] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2011-01-26 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Andreas Kling.

Skip a test for WebKit2 that uses eventSender
​https://bugs.webkit.org/show_bug.cgi?id=53168

  • platform/mac-wk2/Skipped:
3:43 AM Changeset in webkit [76684] by yurys@chromium.org
  • 2 edits in trunk/Source/WebKit/cf

2011-01-26 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: inspector should start in attached state by default
​https://bugs.webkit.org/show_bug.cgi?id=53165

  • WebCoreSupport/WebInspectorClientCF.cpp: (WebInspectorClient::inspectorStartsAttached):
3:39 AM Changeset in webkit [76683] by pfeldman@chromium.org
  • 9 edits in trunk

2011-01-26 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: inspector tests fix.

  • http/tests/inspector/inspector-test2.js: (initialize_InspectorTest.InspectorTest.evaluateInPage):
  • inspector/console-format.html:
2:26 AM Changeset in webkit [76682] by Carlos Garcia Campos
  • 2 edits
    63 adds in trunk/LayoutTests

2011-01-26 Carlos Garcia Campos <​cgarcia@igalia.com>

Unreviewed, unskip passing canvas tests in GTK port.

  • platform/gtk/Skipped: Unskip passing canvas tests.
  • platform/gtk/fast/canvas/arc360-expected.checksum: Added.
  • platform/gtk/fast/canvas/arc360-expected.png: Added.
  • platform/gtk/fast/canvas/arc360-expected.txt: Added.
  • platform/gtk/fast/canvas/canvas-as-image-expected.checksum: Added.
  • platform/gtk/fast/canvas/canvas-as-image-expected.png: Added.
  • platform/gtk/fast/canvas/canvas-as-image-expected.txt: Added.
  • platform/gtk/fast/canvas/canvas-as-image-incremental-repaint-expected.checksum: Added.
  • platform/gtk/fast/canvas/canvas-as-image-incremental-repaint-expected.png: Added.
  • platform/gtk/fast/canvas/canvas-as-image-incremental-repaint-expected.txt: Added.
  • platform/gtk/fast/canvas/canvas-before-css-expected.checksum: Added.
  • platform/gtk/fast/canvas/canvas-before-css-expected.png: Added.
  • platform/gtk/fast/canvas/canvas-before-css-expected.txt: Added.
  • platform/gtk/fast/canvas/canvas-bg-expected.checksum: Added.
  • platform/gtk/fast/canvas/canvas-bg-expected.png: Added.
  • platform/gtk/fast/canvas/canvas-bg-expected.txt: Added.
  • platform/gtk/fast/canvas/canvas-bg-zoom-expected.checksum: Added.
  • platform/gtk/fast/canvas/canvas-bg-zoom-expected.png: Added.
  • platform/gtk/fast/canvas/canvas-bg-zoom-expected.txt: Added.
  • platform/gtk/fast/canvas/canvas-incremental-repaint-2-expected.checksum: Added.
  • platform/gtk/fast/canvas/canvas-incremental-repaint-2-expected.png: Added.
  • platform/gtk/fast/canvas/canvas-incremental-repaint-2-expected.txt: Added.
  • platform/gtk/fast/canvas/canvas-resize-reset-expected.checksum: Added.
  • platform/gtk/fast/canvas/canvas-resize-reset-expected.png: Added.
  • platform/gtk/fast/canvas/canvas-resize-reset-expected.txt: Added.
  • platform/gtk/fast/canvas/canvas-size-change-after-layout-expected.checksum: Added.
  • platform/gtk/fast/canvas/canvas-size-change-after-layout-expected.png: Added.
  • platform/gtk/fast/canvas/canvas-size-change-after-layout-expected.txt: Added.
  • platform/gtk/fast/canvas/canvas-text-baseline-expected.checksum: Added.
  • platform/gtk/fast/canvas/canvas-text-baseline-expected.png: Added.
  • platform/gtk/fast/canvas/canvas-text-baseline-expected.txt: Added.
  • platform/gtk/fast/canvas/canvas-transforms-during-path-expected.checksum: Added.
  • platform/gtk/fast/canvas/canvas-transforms-during-path-expected.png: Added.
  • platform/gtk/fast/canvas/canvas-transforms-during-path-expected.txt: Added.
  • platform/gtk/fast/canvas/canvasDrawingIntoSelf-expected.checksum: Added.
  • platform/gtk/fast/canvas/canvasDrawingIntoSelf-expected.png: Added.
  • platform/gtk/fast/canvas/canvasDrawingIntoSelf-expected.txt: Added.
  • platform/gtk/fast/canvas/drawImage-expected.checksum: Added.
  • platform/gtk/fast/canvas/drawImage-expected.png: Added.
  • platform/gtk/fast/canvas/drawImage-expected.txt: Added.
  • platform/gtk/fast/canvas/drawImage-with-globalAlpha-expected.checksum: Added.
  • platform/gtk/fast/canvas/drawImage-with-globalAlpha-expected.png: Added.
  • platform/gtk/fast/canvas/drawImage-with-globalAlpha-expected.txt: Added.
  • platform/gtk/fast/canvas/fill-stroke-clip-reset-path-expected.checksum: Added.
  • platform/gtk/fast/canvas/fill-stroke-clip-reset-path-expected.png: Added.
  • platform/gtk/fast/canvas/fill-stroke-clip-reset-path-expected.txt: Added.
  • platform/gtk/fast/canvas/fillrect-gradient-zero-stops-expected.checksum: Added.
  • platform/gtk/fast/canvas/fillrect-gradient-zero-stops-expected.png: Added.
  • platform/gtk/fast/canvas/fillrect-gradient-zero-stops-expected.txt: Added.
  • platform/gtk/fast/canvas/fillrect_gradient-expected.checksum: Added.
  • platform/gtk/fast/canvas/fillrect_gradient-expected.png: Added.
  • platform/gtk/fast/canvas/fillrect_gradient-expected.txt: Added.
  • platform/gtk/fast/canvas/gradient-add-second-start-end-stop-expected.checksum: Added.
  • platform/gtk/fast/canvas/gradient-add-second-start-end-stop-expected.png: Added.
  • platform/gtk/fast/canvas/gradient-add-second-start-end-stop-expected.txt: Added.
  • platform/gtk/fast/canvas/image-object-in-canvas-expected.checksum: Added.
  • platform/gtk/fast/canvas/image-object-in-canvas-expected.png: Added.
  • platform/gtk/fast/canvas/image-object-in-canvas-expected.txt: Added.
  • platform/gtk/fast/canvas/quadraticCurveTo-expected.checksum: Added.
  • platform/gtk/fast/canvas/quadraticCurveTo-expected.png: Added.
  • platform/gtk/fast/canvas/quadraticCurveTo-expected.txt: Added.
  • platform/gtk/fast/canvas/zero-size-fill-rect-expected.checksum: Added.
  • platform/gtk/fast/canvas/zero-size-fill-rect-expected.png: Added.
  • platform/gtk/fast/canvas/zero-size-fill-rect-expected.txt: Added.
2:24 AM Changeset in webkit [76681] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-26 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: live edit does not update source snippet.
​https://bugs.webkit.org/show_bug.cgi?id=53097

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._scriptSourceChanged):
2:19 AM Changeset in webkit [76680] by pfeldman@chromium.org
  • 13 edits in trunk/Source/WebCore

2011-01-26 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Incorrect on-hover evaluation of a variable named 'profile'.
​https://bugs.webkit.org/show_bug.cgi?id=53018

  • inspector/InjectedScript.cpp: (WebCore::InjectedScript::evaluate): (WebCore::InjectedScript::evaluateOnCallFrame): (WebCore::InjectedScript::getCompletions): (WebCore::InjectedScript::getCompletionsOnCallFrame):
  • inspector/InjectedScript.h:
  • inspector/InjectedScriptSource.js: (.):
  • inspector/Inspector.idl:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame): (WebCore::InspectorDebuggerAgent::getCompletionsOnCallFrame):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorRuntimeAgent.cpp: (WebCore::InspectorRuntimeAgent::evaluate): (WebCore::InspectorRuntimeAgent::getCompletions):
  • inspector/InspectorRuntimeAgent.h:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions): (WebInspector.ConsoleView.prototype.evalInInspectedWindow): (WebInspector.ConsoleView.prototype._enterKeyPressed):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame.updatingCallbackWrapper): (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._showPopup):
  • inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSection.prototype.update):
2:12 AM Changeset in webkit [76679] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-26 Hironori Bono <​hbono@chromium.org>

Reviewed by Kent Tamura.

A speculative fix for Bug 52422 - [chromium] More crash in
FontFallbackList::determinePitch(const Font* font)
​https://bugs.webkit.org/show_bug.cgi?id=52422

My previous change may not work on non-US Windows whose system fonts
have localized aliases matching to the system locale because of a
font-name mismatch in createFontIndirectAndGetWinName(). This change
tries all the fonts installed in a PC and returns the first font that we
can create without errors.

  • platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::GetLastResortFallbackFontProcData::GetLastResortFallbackFontProcData): Added a struct used for getLastResortFallbackFontProc(). (WebCore::getLastResortFallbackFontProc): Added a callback for EnumFontFamilies(). (WebCore::FontCache::getLastResortFallbackFont): Use EnumFontFamilies() to find a last-resort font.
1:42 AM Changeset in webkit [76678] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2011-01-26 Yuzo Fujishima <​yuzo@google.com>

Unreviewed Chromium test expectation change.

Mark some complex script tests as failing since r76674.

  • platform/chromium/test_expectations.txt:
1:18 AM Changeset in webkit [76677] by commit-queue@webkit.org
  • 12 edits
    3 adds in trunk

2011-01-26 James Robinson <​jamesr@chromium.org>

Reviewed by Nate Chapin.

Add a DOMTimeStamp parameter to the requestAnimationFrame callback
​https://bugs.webkit.org/show_bug.cgi?id=53142

Adds a test for the parameter passed to the requestAnimationFrame callback.

  • fast/animation/request-animation-frame-timestamps-expected.txt: Added.
  • fast/animation/request-animation-frame-timestamps.html: Added.
  • fast/animation/script-tests/request-animation-frame-timestamps.js: Added.

2011-01-26 James Robinson <​jamesr@chromium.org>

Reviewed by Nate Chapin.

Add a DOMTimeStamp parameter to the requestAnimationFrame callback
​https://bugs.webkit.org/show_bug.cgi?id=53142

This adds a DOMTimeStamp parameter to the requestAnimationFrame callback to more
closely match mozilla's proposal. This is useful if the page has multiple imperative animations
and wants to ensure that they all remain synchronized. If each callback used Date.now() to
update its animation state, they would potentially be out of sync with each other. If they use
the timestamp then all callbacks for the same "frame" will update to the same state.

Test: fast/animation/request-animation-frame-timestamps.html

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/V8/V8TestCallback.cpp: (WebCore::V8TestCallback::callbackWithClass2Param):
  • dom/Document.cpp: (WebCore::Document::serviceScriptedAnimations):
  • dom/Document.h:
  • dom/RequestAnimationFrameCallback.h:
  • dom/RequestAnimationFrameCallback.idl:
  • page/FrameView.cpp: (WebCore::FrameView::serviceScriptedAnimations):
  • page/FrameView.h:

2011-01-26 James Robinson <​jamesr@chromium.org>

Reviewed by Nate Chapin.

Add a DOMTimeStamp parameter to the requestAnimationFrame callback
​https://bugs.webkit.org/show_bug.cgi?id=53142

Provides a timestamp to use for imperative animation callbacks. In this patch the timestamp is
just the current time at the start of the callback invocation algorithm. In the future we
could enhance this to try to take the compositing delay into effect to try to synchronize
imperative animations more closely with declarative ones, but this should do for now.

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::animate):

Jan 25, 2011:

11:58 PM Changeset in webkit [76676] by yuzo@google.com
  • 2 edits in trunk/Source/WebCore

2011-01-25 Yuzo Fujishima <​yuzo@google.com>

Unreviewed attempt to fix compilation error for Chromium Clang.

  • platform/graphics/mac/ComplexTextController.cpp: (WebCore::ComplexTextController::advance):
11:17 PM Changeset in webkit [76675] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2011-01-25 Yuzo Fujishima <​yuzo@google.com>

Unreviewed Chromium test expectation change

Mark fast/text/offsetForPosition-complex-fallback.html as failing for WIN and LINUX.

  • platform/chromium/test_expectations.txt:
10:08 PM Changeset in webkit [76674] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

2011-01-25 Ned Holbrook <​nholbrook@apple.com>

Reviewed by Dan Bernstein.

ComplexTextController incorrectly conflates string length and range of indexes
​https://bugs.webkit.org/show_bug.cgi?id=52760

  • fast/text/offsetForPosition-complex-fallback-expected.txt: Added.
  • fast/text/offsetForPosition-complex-fallback.html: Added.

2011-01-25 Ned Holbrook <​nholbrook@apple.com>

Reviewed by Dan Bernstein.

ComplexTextController incorrectly conflates string length and range of indexes
​https://bugs.webkit.org/show_bug.cgi?id=52760

Test: fast/text/offsetForPosition-complex-fallback.html

  • platform/graphics/mac/ComplexTextController.cpp: (WebCore::ComplexTextController::offsetForPosition): (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): (WebCore::ComplexTextController::ComplexTextRun::setIsNonMonotonic): (WebCore::ComplexTextController::advance):
  • platform/graphics/mac/ComplexTextController.h: (WebCore::ComplexTextController::ComplexTextRun::create): (WebCore::ComplexTextController::ComplexTextRun::indexEnd):
  • platform/graphics/mac/ComplexTextControllerATSUI.cpp: (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun):
  • platform/graphics/mac/ComplexTextControllerCoreText.cpp: (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): (WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):
9:41 PM Changeset in webkit [76673] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Make this test a bit more robust agains different scrollbar widths.

  • fast/overflow/overflow-rtl-vertical-origin.html:
9:15 PM Changeset in webkit [76672] by sfalken@apple.com
  • 2 edits in tags/Safari-534.16.2/Source/WebKit/win

Merge r76671.

9:13 PM Changeset in webkit [76671] by sfalken@apple.com
  • 2 edits in trunk/Source/WebKit/win

Windows production build fix.
Build correct configuration of Interfaces for Debug_All.

  • WebKit.vcproj/WebKit.submit.sln:
9:04 PM Changeset in webkit [76670] by sfalken@apple.com
  • 2 edits in tags/Safari-534.16.2/Source/WebCore

Merge r76665.

9:02 PM Changeset in webkit [76669] by weinig@apple.com
  • 3 edits
    2 adds in trunk

Scrollbars don't work correctly for top-to-bottom text in an overflow: scroll area
​https://bugs.webkit.org/show_bug.cgi?id=53048

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/overflow/overflow-rtl-vertical-origin.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollPosition):
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
Take the scroll origin into account when calculating scrollbars in more places.

LayoutTests:

  • fast/overflow/overflow-rtl-vertical-origin-expected.txt: Added.
  • fast/overflow/overflow-rtl-vertical-origin.html: Added.
8:50 PM Changeset in webkit [76668] by tkent@chromium.org
  • 7 edits
    3 adds in trunk

2011-01-25 Kent Tamura <​tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium-win/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.checksum: Added.
  • platform/chromium-win/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png: Added.
  • platform/chromium-win/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt: Added.
  • platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.checksum:
  • platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.txt:
  • platform/chromium/test_expectations.txt:

2011-01-25 Kent Tamura <​tkent@chromium.org>

Unreviewed trivial change.

  • DEPS: Roll to r72581 to have a webkit_support fix.
8:47 PM Changeset in webkit [76667] by sfalken@apple.com
  • 5 edits in tags/Safari-534.16.2/Source

Versioning.

8:40 PM Changeset in webkit [76666] by sfalken@apple.com
  • 1 copy in tags/Safari-534.16.2

New tag.

8:39 PM Changeset in webkit [76665] by sfalken@apple.com
  • 2 edits in trunk/Source/WebCore

Windows production build fix.
Use correct configuration-specific path in makefile.

  • WebCore.vcproj/WebCore.make:
8:18 PM Changeset in webkit [76664] by tkent@chromium.org
  • 10 edits
    2 adds in trunk

Radio button group state is not restored correctly
​https://bugs.webkit.org/show_bug.cgi?id=50442

Reviewed by Dimitri Glazkov.

Source/WebCore:

Fixes a bug that radio button states are not restored correctly in
a case that non-first radio button in a group is checked.

If "checked" attribute is present, the radio button is checked and
other radio buttons in the group are unchecked. This behavior
disturbs form state restoring. This patch changes this behavior so
that the "checked" attribute handling is delayed after form state
restoring.

Test: fast/forms/state-restore-radio-group.html

  • html/HTMLFormControlElement.h: Make finishParsingChildren() protected so that HTMLInpuElement can call it.
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::HTMLInputElement):

  • Add createdByParser parameter.
  • Initialize m_stateRestored and m_parsingInProgress.

(WebCore::HTMLInputElement::create): Sync with the constructor.
(WebCore::HTMLInputElement::restoreFormControlState):

Set m_stateRestored in order to refer it in finishParsingChildren().

(WebCore::HTMLInputElement::parseMappedAttribute):

Don't call setChecked() during parsing. Move setNeedsValidityCheck()
to setChecked().

(WebCore::HTMLInputElement::finishParsingChildren):

Call setChecked() if form state is not restored.

(WebCore::HTMLInputElement::setChecked):

Move setNeedsValidityCheck() from parseMappedAttribute() because
finishParsingChildren() also needs to call setNeedsValidityCheck().

  • html/HTMLInputElement.h:
    • Remove the default value of HTMLFormElement* of the HTMLInputElement constructor, and add createdByParser parameter.
    • Introduce m_parsingInProgress and m_stateRestored.
  • html/HTMLIsIndexElement.cpp:

(WebCore::HTMLIsIndexElement::HTMLIsIndexElement):

Sync with the HTMLInputElement constructor change.

  • html/HTMLTagNames.in: Add constructorNeedsCreatedByParser flag.
  • rendering/MediaControlElements.cpp:

(WebCore::MediaControlInputElement::MediaControlInputElement):

Sync with the HTMLInputElement constructor change.

  • rendering/ShadowElement.cpp:

(WebCore::ShadowInputElement::ShadowInputElement): ditto.

  • rendering/ShadowElement.h:

(WebCore::ShadowElement::ShadowElement): ditto.

LayoutTests:

  • fast/forms/state-restore-radio-group-expected.txt: Added.
  • fast/forms/state-restore-radio-group.html: Added.
8:00 PM Changeset in webkit [76663] by tkent@chromium.org
  • 10 edits in trunk

HTMLFormElement::checkValidity() returns incorrect result if 'invalid' events are canceled.
​https://bugs.webkit.org/show_bug.cgi?id=52565

Reviewed by Dimitri Glazkov.

Source/WebCore:

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::validateInteractively):

Check checkInvalidControlsAndCollectUnhandled() result instead of
checking emptiness of unhandled invalid controls list.

(WebCore::HTMLFormElement::checkValidity): ditto.
(WebCore::HTMLFormElement::checkInvalidControlsAndCollectUnhandled):

Renamed from collectUnhandledInvalidControls().
Returns true if there is any invalid control regardless of event canceling.

  • html/HTMLFormElement.h: Rename collectUnhandledInvalidControls() to checkInvalidControlsAndCollectUnhandled().

LayoutTests:

Fix tests and results for the behavior change.

  • fast/forms/checkValidity-cancel-expected.txt:
  • fast/forms/checkValidity-handler-updates-dom-expected.txt:
  • fast/forms/interactive-validation-cancel-expected.txt:
  • fast/forms/interactive-validation-cancel.html:
  • fast/forms/script-tests/checkValidity-cancel.js:
  • fast/forms/script-tests/checkValidity-handler-updates-dom.js:
7:50 PM Changeset in webkit [76662] by tkent@chromium.org
  • 10 edits in trunk

2011-01-25 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Range and number inputs should reject increment and decrement by
keyboard or mouse wheel if they are disabled or read-only
​https://bugs.webkit.org/show_bug.cgi?id=53151

Add checks for 'disabled' and 'readOnly'.

  • fast/forms/input-number-keyoperation-expected.txt:
  • fast/forms/input-number-wheel-expected.txt:
  • fast/forms/range-keyoperation-expected.txt:
  • fast/forms/range-keyoperation.html:
  • fast/forms/script-tests/input-number-keyoperation.js:
  • fast/forms/script-tests/input-number-wheel.js:

2011-01-25 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Range and number inputs should reject increment and decrement by
keyboard or mouse wheel if they are disabled or read-only
​https://bugs.webkit.org/show_bug.cgi?id=53151

  • html/RangeInputType.cpp: (WebCore::RangeInputType::handleKeydownEvent): Check disabled() and readOnly().
  • html/TextFieldInputType.cpp: (WebCore::TextFieldInputType::handleKeydownEventForSpinButton): ditto. (WebCore::TextFieldInputType::handleWheelEventForSpinButton): ditto.
7:44 PM Changeset in webkit [76661] by tkent@chromium.org
  • 17 edits
    2 adds in trunk/Source/WebCore

API to support localized numbers for <input type=number>
​https://bugs.webkit.org/show_bug.cgi?id=45730

Reviewed by Dimitri Glazkov.

Introduce platform/text/LocalizedNumber.h, and
LocalizedNumberNone.cpp, which is an empty implementation of the
functions in LocalizedNumber.h. We use LocalizedNumberNone.cpp in
all platforms for now.

A string in a type=number field is parsed as a localized number
first. If the parsing fails, it is parsed as the HTML5 number.

We introduce HTMLInputElement::visibleValue(). It represents a value
which should be drawn by a renderer. HTMLInputElement::value() always
returns a number formatted for HTML5, and visibleValue() may return a
localized number.

No new tests because this doesn't change any behavior.

  • Android.mk: Add LocalizedNumber.h and/or LocalizedNumberNone.cpp.
  • CMakeLists.txt: ditto.
  • GNUmakefile.am: ditto.
  • WebCore.gypi: ditto.
  • WebCore.pro: ditto.
  • WebCore.vcproj/WebCore.vcproj: ditto.
  • WebCore.xcodeproj/project.pbxproj: ditto.
  • dom/InputElement.h: Add visibleValue().
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::visibleValue): Added. Just call InputType::visibleValue().

  • html/HTMLInputElement.h: Declare visibleValue().
  • html/InputType.cpp:

(WebCore::InputType::visibleValue): Add the default implementation of

visibleValue(), which returns HTMLInputElement::value().

  • html/InputType.h: Add declarations.
  • html/NumberInputType.cpp:

(WebCore::isHTMLNumberCharacter): Renamed from isNumberCharacter().
(WebCore::isNumberCharacter): Calls isLocalizedNumberCharacter() and isHTMLNumberCharacter().
(WebCore::NumberInputType::visibleValue):

Returns a localized number string produced by formatLocalizedNumber().

(WebCore::NumberInputType::isAcceptableValue): Calls parseLocalizedNumber().
(WebCore::NumberInputType::sanitizeValue): Calls parseLocalizedNumber().

  • html/NumberInputType.h: Add declarations.
  • platform/text/LocalizedNumber.h: Added.
  • platform/text/LocalizedNumberNone.cpp: Added.

(WebCore::parseLocalizedNumber):
(WebCore::formatLocalizedNumber):
(WebCore::isLocalizedNumberCharacter):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::updateFromElement):

Calls InputElement::visibleValue() instead of value().

  • wml/WMLInputElement.h:

(WebCore::WMLInputElement::visibleValue): Added. It just calls value().

7:29 PM Changeset in webkit [76660] by ap@apple.com
  • 3 edits
    1 add in trunk/Source/WebCore

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=53143
Add IntRectHash

  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/IntRectHash.h: Added.
  • platform/graphics/IntSizeHash.h: Don't do "using WebCore::IntSize"!
7:19 PM Changeset in webkit [76659] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-25 Ilya Sherman <​isherman@chromium.org>

Reviewed by Ryosuke Niwa.

Remove trailing whitespace in HTMLInputElement.cpp
​https://bugs.webkit.org/show_bug.cgi?id=53152

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::updateCheckedRadioButtons): (WebCore::HTMLInputElement::applyStep): (WebCore::HTMLInputElement::updateFocusAppearance): (WebCore::HTMLInputElement::mapToEntry): (WebCore::HTMLInputElement::setAutofilled): (WebCore::HTMLInputElement::willMoveToNewOwnerDocument): (WebCore::HTMLInputElement::didMoveToNewOwnerDocument):
6:13 PM Changeset in webkit [76658] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-01-25 Mike Reed <​reed@google.com>

Reviewed by James Robinson.

DrawingBufer::reset() today checks if the new size is the same as its
m_size, and if so, returns immediately. This does not match the
semantics of <canvas>, which wants to clear its contents anytime the
size is specified.
​https://bugs.webkit.org/show_bug.cgi?id=53149

Test: Covered by existing <canvas> tests using gpu.

  • platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::DrawingBuffer):
  • platform/graphics/gpu/DrawingBuffer.cpp: (WebCore::DrawingBuffer::reset):
5:54 PM Changeset in webkit [76657] by Chris Fleizach
  • 10 edits in trunk/Source/WebKit2

WK2 leaks when a page is closed
​https://bugs.webkit.org/show_bug.cgi?id=53100

Reviewed by Darin Adler.

Allow the WKView a chance to clean up on a page close. In this case,
cleaning up means removing the references the accessibility token has
to the window.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::pageClosed):

  • UIProcess/API/mac/WKView.mm:

(-[WKView _setRemoteAccessibilityWindow:]):
(-[WKView _setAccessibilityChildToken:]):
(-[WKView _processDidCrash]):
(-[WKView _pageClosed]):

  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/API/qt/qwkpage_p.h:

(QWKPagePrivate::pageClosed):

  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close):

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::pageClosed):

  • UIProcess/win/WebView.h:
5:17 PM Changeset in webkit [76656] by Patrick Gansterer
  • 3 edits
    2 moves in trunk

2011-01-25 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Move main CMakeLists.txt into Source directory
​https://bugs.webkit.org/show_bug.cgi?id=52888

  • CMakeLists.txt: Removed.
  • Source/CMakeLists.txt: Copied from CMakeLists.txt.
  • Source/cmakeconfig.h.cmake: Copied from cmakeconfig.h.cmake.
  • cmakeconfig.h.cmake: Removed.

2011-01-25 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Move main CMakeLists.txt into Source directory
​https://bugs.webkit.org/show_bug.cgi?id=52888

  • Scripts/webkitdirs.pm:
5:07 PM CSS21Results edited by tabatkins@google.com
(diff)
4:50 PM Changeset in webkit [76655] by Patrick Gansterer
  • 2 edits in trunk/Tools

2011-01-25 Patrick Gansterer <Patrick Gansterer>

Reviewed by Eric Seidel.

Improve label text in submit-to-ews
​https://bugs.webkit.org/show_bug.cgi?id=53130

  • QueueStatusServer/templates/submittoews.html:
4:39 PM CSS21Results edited by tabatkins@google.com
(diff)
4:36 PM Changeset in webkit [76654] by cmarrin@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-01-25 Chris Marrin <​cmarrin@apple.com>

Reviewed by Adam Roben.

Expose WebGL flag set/get in WK2
​https://bugs.webkit.org/show_bug.cgi?id=53096

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetWebGLEnabled): (WKPreferencesGetWebGLEnabled):
  • UIProcess/API/C/WKPreferencesPrivate.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences):
4:23 PM CSS21Results edited by Simon Fraser
(diff)
4:18 PM Changeset in webkit [76653] by andersca@apple.com
  • 5 edits
    1 add in trunk/Source/WebKit2

2011-01-25 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam Roben.

Add and implement LayerTreeHost::scheduleLayerFlush
​https://bugs.webkit.org/show_bug.cgi?id=53135

  • WebKit2.xcodeproj/project.pbxproj: Add LayerTreeHostMac.mm.
  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::scheduleCompositingLayerSync): Call LayerTreeHost::scheduleLayerFlush.
  • WebProcess/WebPage/LayerTreeHost.cpp: (WebKit::LayerTreeHost::~LayerTreeHost): Call platformInvalidate().

(WebKit::LayerTreeHost::flushPendingLayerChanges):
Rename from syncCompositingLayers.

  • WebProcess/WebPage/mac/LayerTreeHostMac.mm: Added. (WebKit::LayerTreeHost::scheduleLayerFlush): Create a run loop observer if needed. This code is copied from LayerBackedDrawingAreaMac.mm

(WebKit::LayerTreeHost::platformInvalidate):
Invalidate the run loop observer.

(WebKit::LayerTreeHost::flushPendingLayerChangesRunLoopObserverCallback):
Call flushPendingChanges() and remove the run loop observer if it succeeded.

4:10 PM Changeset in webkit [76652] by inferno@chromium.org
  • 6 edits
    2 adds in trunk

2011-01-25 Cris Neckar <​cdn@chromium.org>

Reviewed by Adam Barth.

Test for crash when a window's location changes before creating an object URL.
​https://bugs.webkit.org/show_bug.cgi?id=53038

  • fast/dom/window-domurl-crash-expected.txt: Added.
  • fast/dom/window-domurl-crash.html: Added.

2011-01-25 Cris Neckar <​cdn@chromium.org>

Reviewed by Adam Barth.

Add a hashset of DOMURLs to ScriptExecutionContext to track back references.
​https://bugs.webkit.org/show_bug.cgi?id=53038

Test: fast/dom/window-domurl-crash.html

  • dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::~ScriptExecutionContext): (WebCore::ScriptExecutionContext::createdDomUrl): (WebCore::ScriptExecutionContext::destroyedDomUrl):
  • dom/ScriptExecutionContext.h: (WebCore::ScriptExecutionContext::domUrls):
  • html/DOMURL.cpp: (WebCore::DOMURL::DOMURL): (WebCore::DOMURL::~DOMURL): (WebCore::DOMURL::contextDestroyed):
  • html/DOMURL.h: (WebCore::DOMURL::scriptExecutionContext):
4:07 PM CSS21Results edited by Simon Fraser
(diff)
4:04 PM CSS21Results edited by Simon Fraser
(diff)
3:59 PM CSS21Results edited by Simon Fraser
(diff)
3:47 PM Changeset in webkit [76651] by sfalken@apple.com
  • 2 edits in tags/Safari-534.16.1/Source/JavaScriptCore

Merge r76650.

3:46 PM Changeset in webkit [76650] by Adam Roben
  • 2 edits in trunk/Source/JavaScriptCore

Windows Production build fix

Reviewed by Steve Falkenburg.

  • JavaScriptCore.vcproj/JavaScriptCore.make: Set BUILDSTYLE to Release_PGO at the very start

of the file so that ConfigurationBuildDir takes that into account. Also set it the right way
(by redefining the macro) rather than the wrong way (by modifying the environment variable).

3:40 PM Changeset in webkit [76649] by andersca@apple.com
  • 4 edits
    2 adds in trunk/Source/WebKit2

2011-01-25 Anders Carlsson <​andersca@apple.com>

Reviewed by Simon Fraser.

Add LayerTreeHost class
​https://bugs.webkit.org/show_bug.cgi?id=53132

  • WebKit2.xcodeproj/project.pbxproj: Add LayerTreeHost files.
  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::DrawingAreaImpl): Initialize m_layerTreeHost.

(WebKit::DrawingAreaImpl::setRootCompositingLayer):
Call the m_layerTreeHost.

  • WebProcess/WebPage/LayerTreeHost.cpp: Added. (WebKit::LayerTreeHost::attachRootCompositingLayer): (WebKit::LayerTreeHost::detachRootCompositingLayer): Add stubbed out functions.

(WebKit::LayerTreeHost::syncCompositingLayers):
Sync the compositing layers in the main frame.

  • WebProcess/WebPage/LayerTreeHost.h: Added.
3:31 PM Changeset in webkit [76648] by Antti Koivisto
  • 17 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=52983
Eliminate m_tagHistory pointer from CSSSelector

Reviewed by Darin Adler.

Keep the component selectors in the array in CSSSelectorList instead
of maintaining a linked list between them. This allows eliminating
m_tagHistory pointer, shrinking CSSSelector by 25% (selection performance
seems to improve some too due to better locality).

  • WebCore.xcodeproj/project.pbxproj:


Make CSSSelector.h a private header.


  • css/CSSGrammar.y:


Use CSSParserSelector during parsing to keep the tag history in
a linked list. This is flattened to an array after parsing.
Use accessors for setting selector values.
Use OwnPtr in selector vector.


  • css/CSSPageRule.cpp:

(WebCore::CSSPageRule::CSSPageRule):

  • css/CSSPageRule.h:

(WebCore::CSSPageRule::create):

Simplify.


  • css/CSSParser.cpp:

(WebCore::CSSParser::~CSSParser):
(WebCore::CSSParser::createFloatingSelector):
(WebCore::CSSParser::sinkFloatingSelector):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::updateSpecifiersWithElementName):
(WebCore::CSSParser::createPageRule):

  • css/CSSParser.h:

(WebCore::CSSParser::reusableSelectorVector):

CSSSelector -> CSSParserSelector.
Use OwnPtr in selector vector.


  • css/CSSParserValues.cpp:

(WebCore::CSSParserSelector::CSSParserSelector):
(WebCore::CSSParserSelector::~CSSParserSelector):

  • css/CSSParserValues.h:

(WebCore::CSSParserSelector::releaseSelector):
(WebCore::CSSParserSelector::setTag):
(WebCore::CSSParserSelector::setValue):
(WebCore::CSSParserSelector::setAttribute):
(WebCore::CSSParserSelector::setArgument):
(WebCore::CSSParserSelector::setSimpleSelector):
(WebCore::CSSParserSelector::setMatch):
(WebCore::CSSParserSelector::setRelation):
(WebCore::CSSParserSelector::setForPage):
(WebCore::CSSParserSelector::pseudoType):
(WebCore::CSSParserSelector::isUnknownPseudoElement):
(WebCore::CSSParserSelector::isSimple):
(WebCore::CSSParserSelector::tagHistory):
(WebCore::CSSParserSelector::setTagHistory):

Linked list used during parsing.
Avoid recursive destruction.

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::extractPseudoType):
(WebCore::CSSSelector::operator==):
(WebCore::CSSSelector::selectorText):
(WebCore::CSSSelector::setSimpleSelector):

  • css/CSSSelector.h:

(WebCore::CSSSelector::CSSSelector):
(WebCore::CSSSelector::~CSSSelector):
(WebCore::CSSSelector::tagHistory):
(WebCore::CSSSelector::tag):
(WebCore::CSSSelector::value):
(WebCore::CSSSelector::setTag):
(WebCore::CSSSelector::isLastInTagHistory):
(WebCore::CSSSelector::setNotLastInTagHistory):
(WebCore::CSSSelector::RareData::RareData):
(WebCore::CSSSelector::RareData::~RareData):
(WebCore::CSSSelector::createRareData):
(WebCore::CSSSelector::setValue):

Remove m_tagHistory.
Keep m_value in the union with the rare data pointer instead.
Make m_value and m_tag private, implement accessors.
Add a new bit to indicate end of the tag history (multipart selector).
Eliminate complex destruction. Selectors are now deleted as an array or by a CSSParserSelector chain.


  • css/CSSSelectorList.cpp:

(WebCore::CSSSelectorList::adoptSelectorVector):

Flatten everything to an array.


(WebCore::SelectorNeedsNamespaceResolutionFunctor::operator()):

  • css/CSSSelectorList.h:

(WebCore::CSSSelectorList::hasOneSelector):
(WebCore::CSSSelectorList::next):

Skip over the subparts of multipart selectors to find the next selector.


  • css/CSSStyleRule.h:

(WebCore::CSSStyleRule::adoptSelectorVector):

CSSSelector -> CSSParserSelector.


  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
(WebCore::CSSRuleSet::addRule):
(WebCore::collectIdsAndSiblingRulesFromList):
(WebCore::CSSStyleSelector::matchPageRulesForList):

  • dom/Node.cpp:

(WebCore::Node::querySelector):

  • dom/SelectorNodeList.cpp:

(WebCore::createSelectorNodeList):

Use accessors.

3:25 PM CSS21Results edited by Simon Fraser
(diff)
3:23 PM Changeset in webkit [76647] by sfalken@apple.com
  • 10 edits in tags/Safari-534.16.1/Source

Merge r76638.

3:20 PM Changeset in webkit [76646] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-01-25 Mansi Mithal <​mansi.mithal@nokia.com>

Reviewed by Antonio Gomes.

QtTestBrowser should have a UI Settings to prevent loading images
​https://bugs.webkit.org/show_bug.cgi?id=52409

Added a new action item named "DisableAutoLoadImages"
under the "Settings" menu

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::createChrome): (LauncherWindow::toggleAutoLoadImages):
  • QtTestBrowser/launcherwindow.h:
3:08 PM Changeset in webkit [76645] by sfalken@apple.com
  • 2 edits in tags/Safari-534.16.1/Source/JavaScriptCore

Merge r76598.

3:07 PM Changeset in webkit [76644] by simonjam@chromium.org
  • 5 edits
    5 adds in trunk

2011-01-25 James Simonsen <​simonjam@chromium.org>

Reviewed by Tony Chang.

[Chromium] Support small caps in complex text on linux
​https://bugs.webkit.org/show_bug.cgi?id=53051

  • platform/chromium-linux/fast/text/atsui-multiple-renderers-expected.checksum: Added.
  • platform/chromium-linux/fast/text/atsui-multiple-renderers-expected.png: Added.
  • platform/chromium-linux/fast/text/atsui-multiple-renderers-expected.txt: Added.
  • platform/chromium-linux/fast/text/atsui-small-caps-punctuation-size-expected.checksum: Added.
  • platform/chromium-linux/fast/text/atsui-small-caps-punctuation-size-expected.png: Added.
  • platform/chromium/test_expectations.txt: Re-enable 2 tests on linux.

2011-01-25 James Simonsen <​simonjam@chromium.org>

Reviewed by Tony Chang.

[Chromium] Support small caps in complex text on linux
​https://bugs.webkit.org/show_bug.cgi?id=53051

  • platform/graphics/chromium/ComplexTextControllerLinux.cpp: (WebCore::ComplexTextController::nextScriptRun): Break runs at small caps boundaries. (WebCore::ComplexTextController::setupFontForScriptRun): Setup small caps font data if needed.
  • platform/graphics/chromium/ComplexTextControllerLinux.h: Store small caps text in separate string.
3:02 PM Changeset in webkit [76643] by sfalken@apple.com
  • 8 edits in tags/Safari-534.16.1/Source

Merge r76546.

2:58 PM Applications using WebKit edited by munk666@o2.pl
added Kadu (diff)
2:52 PM Changeset in webkit [76642] by dpranke@chromium.org
  • 10 edits in trunk/Tools

2011-01-25 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Tony Chang.

Minor bug fixes and cleanup for filesystem wrappers, port/* test
classes, test_expectations.py. This change adds "test-win" and
"test-mac" variants to the test port so that we can better test
rebaselining, and adds a MockUser() object for reuse in testing.

​https://bugs.webkit.org/show_bug.cgi?id=53036

  • Scripts/webkitpy/common/system/filesystem.py:
  • Scripts/webkitpy/common/system/filesystem_mock.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
2:31 PM Changeset in webkit [76641] by sfalken@apple.com
  • 5 edits in tags/Safari-534.16.1/Source

Versioning.

2:23 PM Changeset in webkit [76640] by jer.noble@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed build fix: add failing test to gtk/Skipped.

  • platform/gtk/Skipped:
2:05 PM Changeset in webkit [76639] by sfalken@apple.com
  • 1 copy in tags/Safari-534.16.1

New tag.

1:49 PM Changeset in webkit [76638] by sfalken@apple.com
  • 10 edits in trunk/Source

Windows production build fix.
Use correct environment variable escaping

Rubber-stamped by Adam Roben.

Source/JavaScriptCore:

Source/WebCore:

  • WebCore.vcproj/WebCore.make:

Source/WebKit/win:

  • WebKit.vcproj/WebKit.make:

Source/WebKit2:

  • win/WebKit2.make:
  • win/WebKit2Generated.make:
1:29 PM Changeset in webkit [76637] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-25 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Empty URLs are never display isolated
​https://bugs.webkit.org/show_bug.cgi?id=53053

This check mirrors the check in the local case. There isn't a good way
to test this with a LayoutTest, but it is tested in Chromium (where
this registry is used).

  • platform/SchemeRegistry.cpp: (WebCore::SchemeRegistry::shouldTreatURLSchemeAsDisplayIsolated):
1:14 PM Changeset in webkit [76636] by weinig@apple.com
  • 5 edits in trunk/Source

2011-01-25 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Pipe a timestamp down into the PlatformWheelEvent for the Mac.
​https://bugs.webkit.org/show_bug.cgi?id=53111

  • platform/PlatformWheelEvent.h: (WebCore::PlatformWheelEvent::PlatformWheelEvent): (WebCore::PlatformWheelEvent::timestamp): Add timestamp member.
  • platform/mac/WheelEventMac.mm: (WebCore::PlatformWheelEvent::PlatformWheelEvent): Initialize the timestamp from the event.

2011-01-25 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Don't inform the UI process about compositing changes when using the new drawing area
​https://bugs.webkit.org/show_bug.cgi?id=53120

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::changeAcceleratedCompositingMode): Return early if we're using the new drawing area.

(WebKit::WebPage::exitAcceleratedCompositingMode):
Call setRootCompositingLayer(0) so the drawing area knows when we leave accelerated compositing.

1:13 PM Changeset in webkit [76635] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-25 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

JSON.stringify processing time exponentially grows with size of object
​https://bugs.webkit.org/show_bug.cgi?id=51922

Remove last use of reserveCapacity from JSON stringification, as it results
in appalling append behaviour when there are a large number of property names
and nothing else.

  • runtime/JSONObject.cpp: (JSC::Stringifier::appendQuotedString):
1:11 PM Changeset in webkit [76634] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-01-25 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Don't inform the UI process about compositing changes when using the new drawing area
​https://bugs.webkit.org/show_bug.cgi?id=53120

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::changeAcceleratedCompositingMode): Return early if we're using the new drawing area.

(WebKit::WebPage::exitAcceleratedCompositingMode):
Call setRootCompositingLayer(0) so the drawing area knows when we leave accelerated compositing.

1:08 PM Changeset in webkit [76633] by rniwa@webkit.org
  • 5 edits
    8 deletes in trunk

2011-01-25 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r76625.
​http://trac.webkit.org/changeset/76625
​https://bugs.webkit.org/show_bug.cgi?id=53119

"incorrect pixel test results" (Requested by rniwa on
#webkit).

  • rendering/RenderBox.cpp: (WebCore::RenderBox::localCaretRect):

2011-01-25 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r76625.
​http://trac.webkit.org/changeset/76625
​https://bugs.webkit.org/show_bug.cgi?id=53119

"incorrect pixel test results" (Requested by rniwa on
#webkit).

  • editing/selection/caret-painting-after-paste-undo-rtl.html: Removed.
  • editing/selection/caret-painting-after-paste-undo.html: Removed.
  • platform/mac/editing/deleting/5408255-expected.checksum:
  • platform/mac/editing/deleting/5408255-expected.png:
  • platform/mac/editing/selection/caret-painting-after-paste-undo-expected.checksum: Removed.
  • platform/mac/editing/selection/caret-painting-after-paste-undo-expected.png: Removed.
  • platform/mac/editing/selection/caret-painting-after-paste-undo-expected.txt: Removed.
  • platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.checksum: Removed.
  • platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.png: Removed.
  • platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.txt: Removed.
1:05 PM Changeset in webkit [76632] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-25 Tony Chang <​tony@chromium.org>

Unreviewed, debugger-scripts.html is failing on windows too.

  • platform/chromium/test_expectations.txt:
1:03 PM Changeset in webkit [76631] by dimich@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

[Chromium] Not reviewed, rebaseline for a test.
The difference is because V8 has different error messages.

  • platform/chromium-mac/fast/js/js-continue-break-restrictions-expected.txt: Added.
  • platform/chromium-win/fast/js/js-continue-break-restrictions-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
12:55 PM Changeset in webkit [76630] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2011-01-25 James Robinson <​jamesr@chromium.org>

Remove = TEXT PASS lines for tests that consistently pass.

  • platform/chromium/test_expectations.txt:
12:55 PM Changeset in webkit [76629] by Patrick Gansterer
  • 2 edits in trunk/Source/WebKit/wince

2011-01-25 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

[WINCE] Ensure layouted frame when painting
​https://bugs.webkit.org/show_bug.cgi?id=53108

  • WebView.cpp: (WebView::paint):
12:52 PM Changeset in webkit [76628] by jer.noble@apple.com
  • 4 edits in trunk/LayoutTests

Unreviewed build fix: rollback untintentional changes in media expected results.

  • media/video-source-moved-expected.txt:
  • media/video-source-none-supported-expected.txt:
  • LayoutTests/platform/win/media/audio-data-url-expected.txt:
12:48 PM Changeset in webkit [76627] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-25 Tony Chang <​tony@chromium.org>

Unreviewed, mark inspector/debugger-scripts.html as failing on chromium linux.

  • platform/chromium/test_expectations.txt:
12:41 PM Changeset in webkit [76626] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-01-25 Patrick Gansterer <Patrick Gansterer>

Unreviewed WinCE build fix for r76614.

  • platform/FileSystem.h:
12:23 PM CSS21Results edited by tabatkins@google.com
(diff)
12:18 PM CSS21Results edited by tabatkins@google.com
Added bug link for containing-block-032 (diff)
12:17 PM Changeset in webkit [76625] by leviw@chromium.org
  • 5 edits
    8 adds in trunk

2011-01-21 Levi Weintraub <​leviw@chromium.org>

Reviewed by Darin Adler.

Adding border and padding to the calculation of the local caret rect for RenderBoxes.

Undo moves caret to invalid position
​https://bugs.webkit.org/show_bug.cgi?id=49744

Tests: editing/selection/caret-painting-after-paste-undo-rtl.html

editing/selection/caret-painting-after-paste-undo.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::localCaretRect):

2011-01-21 Levi Weintraub <​leviw@chromium.org>

Reviewed by Darin Adler.

Updating the expected result for 5408255 and adding tests for caret positioning at the
beginning and end of RenderBoxes.

Undo moves caret to invalid position
​https://bugs.webkit.org/show_bug.cgi?id=49744

  • editing/selection/caret-painting-after-paste-undo-rtl.html: Added.
  • editing/selection/caret-painting-after-paste-undo.html: Added.
  • platform/mac/editing/deleting/5408255-expected.checksum:
  • platform/mac/editing/deleting/5408255-expected.png:
  • platform/mac/editing/selection/caret-painting-after-paste-undo-expected.checksum: Added.
  • platform/mac/editing/selection/caret-painting-after-paste-undo-expected.png: Added.
  • platform/mac/editing/selection/caret-painting-after-paste-undo-expected.txt: Added.
  • platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.checksum: Added.
  • platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.png: Added.
  • platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.txt: Added.
12:03 PM Changeset in webkit [76624] by tony@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

2011-01-25 Tony Chang <​tony@chromium.org>

Unreviewed, add chromium-mac baselines after r76599.

The platform/mac-leopard results were stale which is why the expected
text results aren't updated as well.

  • platform/chromium-mac/svg/custom/junk-data-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/junk-data-expected.png: Added.
  • platform/chromium-mac/svg/custom/missing-xlink-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/missing-xlink-expected.png: Added.
12:01 PM Changeset in webkit [76623] by jamesr@google.com
  • 11 edits
    3 copies
    4 adds in trunk/LayoutTests

2011-01-25 James Robinson <​jamesr@chromium.org>

Reviewed by Mihai Parparita.

Convert requestAnimationFrame tests to be script-tests
​https://bugs.webkit.org/show_bug.cgi?id=53109

This converts the new requestAnimationFrame tests to be proper script-tests using make-script-test-wrapper.

  • fast/animation/request-animation-frame-cancel-expected.txt:
  • fast/animation/request-animation-frame-cancel.html:
  • fast/animation/request-animation-frame-cancel2-expected.txt:
  • fast/animation/request-animation-frame-cancel2.html:
  • fast/animation/request-animation-frame-display-expected.txt:
  • fast/animation/request-animation-frame-display.html:
  • fast/animation/request-animation-frame-expected.txt:
  • fast/animation/request-animation-frame-within-callback-expected.txt:
  • fast/animation/request-animation-frame-within-callback.html:
  • fast/animation/request-animation-frame.html:
  • fast/animation/script-tests/TEMPLATE.html: Added.
  • fast/animation/script-tests/request-animation-frame-cancel.js: Copied from LayoutTests/fast/animation/request-animation-frame-cancel.html.
  • fast/animation/script-tests/request-animation-frame-cancel2.js: Copied from LayoutTests/fast/animation/request-animation-frame-cancel2.html. (secondCallbackId):
  • fast/animation/script-tests/request-animation-frame-display.js: Added.
  • fast/animation/script-tests/request-animation-frame-within-callback.js: Copied from LayoutTests/fast/animation/request-animation-frame-within-callback.html. (window):
  • fast/animation/script-tests/request-animation-frame.js: Added.
11:54 AM Changeset in webkit [76622] by weinig@apple.com
  • 8 edits in trunk/Source

2011-01-25 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Add hasPreciseScrollingDeltas bit to PlatformWheelEvent on the Mac.
​https://bugs.webkit.org/show_bug.cgi?id=53107

  • platform/PlatformWheelEvent.h: (WebCore::PlatformWheelEvent::PlatformWheelEvent): (WebCore::PlatformWheelEvent::hasPreciseScrollingDeltas):
  • platform/mac/WheelEventMac.mm: (WebCore::PlatformWheelEvent::PlatformWheelEvent):

2011-01-25 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Add hasPreciseScrollingDeltas bit to PlatformWheelEvent on the Mac.
​https://bugs.webkit.org/show_bug.cgi?id=53107

  • Shared/WebEvent.h: (WebKit::WebWheelEvent::hasPreciseScrollingDeltas):
  • Shared/WebEventConversion.cpp: (WebKit::WebKit2PlatformWheelEvent::WebKit2PlatformWheelEvent):
  • Shared/WebWheelEvent.cpp: (WebKit::WebWheelEvent::WebWheelEvent):
  • Shared/mac/WebEventFactory.mm: (WebKit::WebEventFactory::createWebWheelEvent):
11:52 AM Changeset in webkit [76621] by jer.noble@apple.com
  • 12 edits
    3 adds in trunk

2011-01-20 Jer Noble <​jer.noble@apple.com>

Reviewed by Eric Carlson.

REGRESSION (r72119): Audio never plays on Star Wars intro animation
​https://bugs.webkit.org/show_bug.cgi?id=52467

Test the ability to read audio/m4a files. Disabled this new test
on the chromium and qt platforms, as they do not support M4A/AAC.

  • media/audio-mpeg4-supported-expected.txt: Added.
  • media/audio-mpeg4-supported.html: Added.
  • media/content/silence.m4a: Added.
  • platform/chromium/test_expectations.txt:
  • platform/qt/Skipped:

2011-01-20 Jer Noble <​jer.noble@apple.com>

Reviewed by Eric Carlson.

REGRESSION (r72119): Audio never plays on Star Wars intro animation
​https://bugs.webkit.org/show_bug.cgi?id=52467

QuickTime's eat/m4a movie importer compontent doesn't list audio/m4a as a mime
type which it supports, though it handles .m4a files just fine. Change the way
we build the list of supported MIME Types through a new WebKitSystemInterface
function.

Caused by r72119, which adds system-specific extension->MIME entries to the cache
before global entries, and the system-specific entries include QuickTime's registry
entries which contain the audio/m4a MIME type, while its components do not.

Test: media/audio-mpeg4-supported.html

  • WebCore.vcproj/QTMovieWinCommon.vsprops:
  • platform/graphics/win/QTMovie.cpp: (getMIMETypeCallBack): (initializeSupportedTypes): (QTMovie::countSupportedTypes): gSupportedTypes is now a CFArrayRef. (QTMovie::getSupportedType): Ditto.

2011-01-24 Jer Noble <​jer.noble@apple.com>

Reviewed by Eric Carlson.

REGRESSION (r72119): Audio never plays on Star Wars intro animation
​https://bugs.webkit.org/show_bug.cgi?id=52467

Add wkGetQuickTimeMIMETypeList() function.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
11:39 AM Changeset in webkit [76620] by tony@chromium.org
  • 3 edits in trunk/Tools

2011-01-25 Tony Chang <​tony@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] remove unused layoutTestController callback
​https://bugs.webkit.org/show_bug.cgi?id=53103

This method is used by a test_shell_test, but not needed by DRT.

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController):
  • DumpRenderTree/chromium/LayoutTestController.h:
11:39 AM Changeset in webkit [76619] by tony@chromium.org
  • 5 edits in trunk/LayoutTests

2011-01-25 Tony Chang <​tony@chromium.org>

Unreviewed, rebaseline a test on chromium-win. Part of r76586 rebaselines.

  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.checksum:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.txt:
  • platform/chromium/test_expectations.txt:
11:25 AM Changeset in webkit [76618] by rniwa@webkit.org
  • 11 edits in trunk/LayoutTests

2011-01-25 Ryosuke Niwa <​rniwa@webkit.org>

Another unreviewed SVG rebaselines for Chromium.

  • platform/chromium-linux/svg/text/text-text-05-t-expected.checksum:
  • platform/chromium-linux/svg/text/text-text-05-t-expected.png:
  • platform/chromium-mac/svg/text/text-text-05-t-expected.checksum:
  • platform/chromium-mac/svg/text/text-text-05-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
  • platform/chromium-win/svg/text/text-text-05-t-expected.checksum:
  • platform/chromium-win/svg/text/text-text-05-t-expected.png:
  • platform/chromium-win/svg/text/text-text-05-t-expected.txt:
  • platform/chromium/test_expectations.txt:
11:14 AM Changeset in webkit [76617] by andersca@apple.com
  • 9 edits in trunk/Source/WebKit2

2011-01-25 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

need a way to request the host CALayer render server port
​https://bugs.webkit.org/show_bug.cgi?id=53101
<rdar://problem/8913620>

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::compositingRenderServerPort): Get the render server port from the plug-in process.
  • PluginProcess/PluginControllerProxy.h:
  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::NPN_GetValue): Call NetscapePlugin::compositingRenderServerPort.
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: (WebKit::NetscapePlugin::compositingRenderServerPort): Call PluginController::compositingRenderServerPort.
  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::compositingRenderServerPort): Get the render server port from the web process.
  • WebProcess/Plugins/PluginView.h: Add compositingRenderServerPort.
11:07 AM Changeset in webkit [76616] by hans@chromium.org
  • 8 edits in trunk/Source

2011-01-25 Hans Wennborg <​hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Remove PlatformBridge::idbShutdown()
​https://bugs.webkit.org/show_bug.cgi?id=53077

Since Chromium r72157, this is not used anymore. The previous use was
to signal to the embedder that IndexedDB was shutting down, but we
agreed it is better if the embedder keeps track of that itself.

No new tests: this does not change any functionality.

  • platform/chromium/PlatformBridge.h:
  • storage/IDBFactoryBackendInterface.cpp:
  • storage/IDBFactoryBackendInterface.h: (WebCore::IDBFactoryBackendInterface::~IDBFactoryBackendInterface):
  • storage/chromium/IDBFactoryBackendInterface.cpp:

2011-01-25 Hans Wennborg <​hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Remove PlatformBridge::idbShutdown()
​https://bugs.webkit.org/show_bug.cgi?id=53077

Since Chromium r72157, this is not used anymore. Chromium keeps track
of when it shuts down IndexedDB itself.

  • public/WebKitClient.h:
  • src/PlatformBridge.cpp:
11:06 AM Changeset in webkit [76615] by Antti Koivisto
  • 2 edits in trunk/Source/JavaScriptCore

Not reviewed.

Try to fix windows build.

11:03 AM Changeset in webkit [76614] by Darin Adler
  • 11 edits in trunk/Source

2011-01-25 Darin Adler <Darin Adler>

Reviewed by Anders Carlsson.

WebKit is using CSBackupSetItemExcluded incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=53095
rdar://problem/8790540

  • Misc/WebIconDatabase.mm: (importToWebCoreFormat): Removed code that was calling CSBackupSetItemExcluded. It was incorrect, and this responsibility has been moved to WebCore.

2011-01-25 Darin Adler <Darin Adler>

Reviewed by Anders Carlsson.

WebKit is using CSBackupSetItemExcluded incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=53095
rdar://problem/8790540

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::performOpenInitialization): Added code to exclude the database from backup one time, and record inside the database that this has been done. (WebCore::IconDatabase::wasExcludedFromBackup): Added. (WebCore::IconDatabase::setWasExcludedFromBackup): Added.
  • loader/icon/IconDatabase.h: Added new functions above.
  • platform/FileSystem.cpp: (WebCore::canExcludeFromBackup): Added. (WebCore::excludeFromBackup): Added.
  • platform/FileSystem.h: Added canExcludeFromBackup, excludeFromBackup, and pathAsURL functions. Cleaned up ifdefs and comments a bit and sorted things alphabetically, particularly platform-specific sections.
  • platform/cf/FileSystemCF.cpp: (WebCore::pathAsURL): Added.
  • platform/mac/FileSystemMac.mm: (WebCore::canExcludeFromBackup): Added. (WebCore::excludeFromBackup): Added.
  • platform/network/cf/FormDataStreamCFNet.cpp: (WebCore::advanceCurrentStream): Changed to call pathAsURL.
  • platform/network/mac/FormDataStreamMac.mm: (WebCore::advanceCurrentStream): Ditto.
10:56 AM Changeset in webkit [76613] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2011-01-25 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin Adler.

Skip another new test that uses eventSender
​https://bugs.webkit.org/show_bug.cgi?id=53094

  • platform/mac-wk2/Skipped:
10:54 AM Changeset in webkit [76612] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-25 Helder Correia <​helder@sencha.com>

Reviewed by Dirk Schulze.

REGRESSION(75139): SVG gradients are not applied to texts
​https://bugs.webkit.org/show_bug.cgi?id=52531

CGContextConcatCTM should use the CGLayer context, not the
GraphicsContext. Also, the CTM needs to be adjusted (translated).
This fixes SVG text gradient fill.

Test: svg/css/composite-shadow-text.svg

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillRect):
10:46 AM CSS21Results edited by Simon Fraser
(diff)
10:44 AM Changeset in webkit [76611] by Antti Koivisto
  • 10 edits
    3 adds in trunk/Source/JavaScriptCore

REGRESSION: Leak in JSParser::Scope::copyCapturedVariablesToVector()
​https://bugs.webkit.org/show_bug.cgi?id=53061

Reviewed by Oliver Hunt.

Cache did not know about the subclass so failed to fully delete the items.
Got rid of the subclass and moved the classes to separate files.

(JSC::JSParser::Scope::saveFunctionInfo):
(JSC::JSParser::Scope::restoreFunctionInfo):
(JSC::JSParser::findCachedFunctionInfo):
(JSC::JSParser::parseFunctionInfo):

  • parser/SourceProvider.h:
  • parser/SourceProviderCache.cpp: Added.

(JSC::SourceProviderCache::~SourceProviderCache):
(JSC::SourceProviderCache::byteSize):

  • parser/SourceProviderCache.h: Added.

(JSC::SourceProviderCache::SourceProviderCache):
(JSC::SourceProviderCache::add):
(JSC::SourceProviderCache::get):

  • parser/SourceProviderCacheItem.h: Added.

(JSC::SourceProviderCacheItem::SourceProviderCacheItem):
(JSC::SourceProviderCacheItem::approximateByteSize):
(JSC::SourceProviderCacheItem::closeBraceToken):

10:42 AM Changeset in webkit [76610] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-01-25 Benjamin Kalman <​kalman@chromium.org>

Reviewed by Ryosuke Niwa.

Cannot extend or modify forward by word over a non-contenteditable region
​https://bugs.webkit.org/show_bug.cgi?id=53070

Add regression test.

  • editing/selection/extend-forward-by-word-over-non-editable-expected.txt: Added.
  • editing/selection/extend-forward-by-word-over-non-editable.html: Added.

2011-01-25 Benjamin Kalman <​kalman@chromium.org>

Reviewed by Ryosuke Niwa.

Cannot extend or modify forward by word over a non-contenteditable region
​https://bugs.webkit.org/show_bug.cgi?id=53070

Test: editing/selection/extend-forward-by-word-over-non-editable.html

Change all instances of honorEditableBoundaryAtOrAfter to honorEditableBoundaryAtOrBefore and vice versa in the
functions which determine the end/start of words/lines/sentences in visible_units.cpp.

This fixes the bug where moving forwards by a word over a non-contenteditable region would place the cursor
inside that region, and then get moved back to the start of the word due to honorEditableBoundaryAtOrBefore.
The cursor is now moved to the end of the region (which is effectively a noop in this case).

  • editing/visible_units.cpp: Change all instances of honorEditableBoundaryAtOrAfter to honorEditableBoundaryAtOrBefore and vice versa. (WebCore::previousWordPosition): (WebCore::nextWordPosition): (WebCore::startOfLine): (WebCore::endOfLine): (WebCore::previousSentencePosition): (WebCore::nextSentencePosition): (WebCore::logicalStartOfLine): (WebCore::logicalEndOfLine):
10:28 AM Changeset in webkit [76609] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-25 Marcilio Mendonca <​mamendonca@rim.com>

Reviewed by Darin Adler.

Bug 53087: Refactoring: replaced a hanging "else" with a "return"
statement
​https://bugs.webkit.org/show_bug.cgi?id=53087.

Refactoring work: Replaced a hanging "else" within an #if PLATFORM(M
with a "return" so that the code is more readable and less error pro
(e.g., "else" doesn't use braces so adding extra lines to the else
block won't have any effect; even worse, code still compiles
successfully.

  • wtf/Assertions.cpp:
10:26 AM Changeset in webkit [76608] by mjs@apple.com
  • 2 edits in trunk/Source/WebKit2

Change some floating point constants from 1.0 to 1.

Rubber stamped by Dan Bernstein.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):

10:19 AM Changeset in webkit [76607] by rniwa@webkit.org
  • 36 edits
    2 adds
    2 deletes in trunk/LayoutTests

2011-01-25 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed SVG rebaselines for Chromium.

  • platform/chromium-linux/svg/batik/text/textEffect-expected.checksum:
  • platform/chromium-linux/svg/batik/text/textEffect-expected.png:
  • platform/chromium-linux/svg/batik/text/textEffect-expected.txt: Removed.
  • platform/chromium-linux/svg/batik/text/textEffect3-expected.checksum:
  • platform/chromium-linux/svg/batik/text/textEffect3-expected.png:
  • platform/chromium-linux/svg/batik/text/textEffect3-expected.txt: Removed.
  • platform/chromium-linux/svg/batik/text/textPosition2-expected.txt:
  • platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.checksum:
  • platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.txt: Added.
  • platform/chromium-linux/svg/custom/svg-fonts-with-no-element-reference-expected.checksum:
  • platform/chromium-linux/svg/custom/svg-fonts-with-no-element-reference-expected.png:
  • platform/chromium-linux/svg/custom/svg-fonts-without-missing-glyph-expected.checksum:
  • platform/chromium-linux/svg/custom/svg-fonts-without-missing-glyph-expected.png:
  • platform/chromium-linux/svg/text/text-text-06-t-expected.checksum:
  • platform/chromium-linux/svg/text/text-text-06-t-expected.png:
  • platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.checksum:
  • platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-mac/svg/text/text-text-06-t-expected.checksum:
  • platform/chromium-mac/svg/text/text-text-06-t-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-05-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-06-t-expected.txt:
  • platform/chromium-win/svg/batik/text/textEffect-expected.checksum:
  • platform/chromium-win/svg/batik/text/textEffect-expected.png:
  • platform/chromium-win/svg/batik/text/textEffect-expected.txt:
  • platform/chromium-win/svg/batik/text/textEffect3-expected.checksum:
  • platform/chromium-win/svg/batik/text/textEffect3-expected.png:
  • platform/chromium-win/svg/batik/text/textEffect3-expected.txt:
  • platform/chromium-win/svg/batik/text/textPosition2-expected.txt:
  • platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.checksum:
  • platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.png:
  • platform/chromium-win/svg/custom/svg-fonts-without-missing-glyph-expected.checksum:
  • platform/chromium-win/svg/custom/svg-fonts-without-missing-glyph-expected.png:
  • platform/chromium-win/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
  • platform/chromium-win/svg/text/text-text-06-t-expected.checksum:
  • platform/chromium-win/svg/text/text-text-06-t-expected.png:
  • platform/chromium-win/svg/text/text-text-06-t-expected.txt:
  • platform/chromium/test_expectations.txt:
10:18 AM Changeset in webkit [76606] by yael.aharon@nokia.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix.
After r76466, efsrv.lib is used unconditionally.
Don't guard it with ENABLE_NETSCAPE_PLUGIN_API.

  • WebCore.pro:
10:09 AM Changeset in webkit [76605] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-25 Tony Chang <​tony@chromium.org>

Unreviewed, remove passing chromium win tests.

  • platform/chromium/test_expectations.txt:
9:54 AM Changeset in webkit [76604] by mjs@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-01-25 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Anders Carlsson.

Improve scale factor resetting
​https://bugs.webkit.org/show_bug.cgi?id=53093


Two key changes:

  • Don't set the scale factor to what it already is, as this causes an uneeded force layout and scroll
  • Don't ever set the scale factor based on a non-main frame committing


This fixes two WebKit2 layout tests.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
9:47 AM Changeset in webkit [76603] by zmo@google.com
  • 12 edits in trunk/Source/WebCore

2011-01-24 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

Style cleanup for WebGLRenderingContext
​https://bugs.webkit.org/show_bug.cgi?id=52352

  • html/canvas/WebGLBuffer.cpp:
  • html/canvas/WebGLBuffer.h:
  • html/canvas/WebGLObject.cpp:
  • html/canvas/WebGLProgram.cpp:
  • html/canvas/WebGLRenderbuffer.cpp:
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::create): (WebCore::WebGLRenderingContext::blendFunc): (WebCore::WebGLRenderingContext::createShader): (WebCore::WebGLRenderingContext::deleteBuffer): (WebCore::WebGLRenderingContext::deleteShader): (WebCore::WebGLRenderingContext::deleteTexture): (WebCore::WebGLRenderingContext::disableVertexAttribArray): (WebCore::WebGLRenderingContext::validateIndexArrayPrecise): (WebCore::WebGLRenderingContext::validateRenderingState): (WebCore::WebGLRenderingContext::enableVertexAttribArray): (WebCore::WebGLRenderingContext::getUniform): (WebCore::WebGLRenderingContext::detachAndRemoveAllObjects):
  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebGLShader.cpp:
  • html/canvas/WebGLTexture.cpp:
  • html/canvas/WebGLUniformLocation.cpp:
  • html/canvas/WebGLUniformLocation.h:
9:43 AM Changeset in webkit [76602] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/chromium

2011-01-25 Ilya Sherman <​isherman@chromium.org>

Reviewed by Darin Fisher.

Chromium WebKit API: Move dispatchFormControlChangeEvent() from WebInputElement to WebFormControlElement
In service of ​https://code.google.com/p/chromium/issues/detail?id=42716
​https://bugs.webkit.org/show_bug.cgi?id=53069

  • public/WebFormControlElement.h:
  • public/WebInputElement.h:
  • src/WebFormControlElement.cpp: (WebKit::WebFormControlElement::dispatchFormControlChangeEvent): Moved from WebInputElement
  • src/WebInputElement.cpp:
9:34 AM Changeset in webkit [76601] by zmo@google.com
  • 7 edits in trunk/Source/WebCore

2011-01-24 Chris Marrin <​cmarrin@apple.com>

Reviewed by Eric Seidel.

Change ENABLE_3D_CANVAS to ENABLE_WEBGL
​https://bugs.webkit.org/show_bug.cgi?id=53041

  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.cpp:
  • GNUmakefile.am:
  • WebCore.pro:
  • bindings/generic/RuntimeEnabledFeatures.h:
  • bindings/js/JSArrayBufferCustom.cpp:
  • bindings/js/JSCanvasRenderingContextCustom.cpp: (WebCore::toJS):
  • bindings/js/JSDOMWindowCustom.cpp:
  • bindings/js/JSDataViewCustom.cpp:
  • bindings/js/JSDocumentCustom.cpp:
  • bindings/js/JSFloat32ArrayCustom.cpp:
  • bindings/js/JSHTMLCanvasElementCustom.cpp: (WebCore::JSHTMLCanvasElement::getContext):
  • bindings/js/JSInt16ArrayCustom.cpp:
  • bindings/js/JSInt32ArrayCustom.cpp:
  • bindings/js/JSInt8ArrayCustom.cpp:
  • bindings/js/JSUint16ArrayCustom.cpp:
  • bindings/js/JSUint32ArrayCustom.cpp:
  • bindings/js/JSUint8ArrayCustom.cpp:
  • bindings/js/JSWebGLRenderingContextCustom.cpp:
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::markChildren): (WebCore::JSXMLHttpRequest::send): (WebCore::JSXMLHttpRequest::response):
  • bindings/v8/custom/V8ArrayBufferCustom.cpp:
  • bindings/v8/custom/V8ArrayBufferViewCustom.h:
  • bindings/v8/custom/V8DataViewCustom.cpp:
  • bindings/v8/custom/V8DocumentCustom.cpp: (WebCore::V8Document::getCSSCanvasContextCallback):
  • bindings/v8/custom/V8Float32ArrayCustom.cpp:
  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: (WebCore::V8HTMLCanvasElement::getContextCallback):
  • bindings/v8/custom/V8Int16ArrayCustom.cpp:
  • bindings/v8/custom/V8Int32ArrayCustom.cpp:
  • bindings/v8/custom/V8Int8ArrayCustom.cpp:
  • bindings/v8/custom/V8Uint16ArrayCustom.cpp:
  • bindings/v8/custom/V8Uint32ArrayCustom.cpp:
  • bindings/v8/custom/V8Uint8ArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::V8XMLHttpRequest::responseAccessorGetter): (WebCore::V8XMLHttpRequest::sendCallback):
  • features.pri:
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::getContext): (WebCore::HTMLCanvasElement::reset):
  • html/HTMLCanvasElement.h:
  • html/canvas/ArrayBuffer.cpp:
  • html/canvas/ArrayBuffer.idl:
  • html/canvas/ArrayBufferView.cpp:
  • html/canvas/ArrayBufferView.idl:
  • html/canvas/DataView.cpp:
  • html/canvas/DataView.idl:
  • html/canvas/Float32Array.cpp:
  • html/canvas/Float32Array.idl:
  • html/canvas/Int16Array.cpp:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.cpp:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.cpp:
  • html/canvas/Int8Array.idl:
  • html/canvas/OESStandardDerivatives.cpp:
  • html/canvas/OESStandardDerivatives.idl:
  • html/canvas/OESTextureFloat.cpp:
  • html/canvas/OESTextureFloat.idl:
  • html/canvas/Uint16Array.cpp:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.cpp:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.cpp:
  • html/canvas/Uint8Array.idl:
  • html/canvas/WebGLActiveInfo.idl:
  • html/canvas/WebGLBuffer.cpp:
  • html/canvas/WebGLBuffer.idl:
  • html/canvas/WebGLContextAttributes.cpp:
  • html/canvas/WebGLContextAttributes.idl:
  • html/canvas/WebGLContextEvent.idl:
  • html/canvas/WebGLExtension.cpp:
  • html/canvas/WebGLFramebuffer.cpp:
  • html/canvas/WebGLFramebuffer.idl:
  • html/canvas/WebGLGetInfo.cpp:
  • html/canvas/WebGLObject.cpp:
  • html/canvas/WebGLProgram.cpp:
  • html/canvas/WebGLProgram.idl:
  • html/canvas/WebGLRenderbuffer.cpp:
  • html/canvas/WebGLRenderbuffer.idl:
  • html/canvas/WebGLRenderingContext.cpp:
  • html/canvas/WebGLRenderingContext.idl:
  • html/canvas/WebGLShader.cpp:
  • html/canvas/WebGLShader.idl:
  • html/canvas/WebGLTexture.cpp:
  • html/canvas/WebGLTexture.idl:
  • html/canvas/WebGLUniformLocation.cpp:
  • html/canvas/WebGLUniformLocation.idl:
  • html/canvas/WebKitLoseContext.cpp:
  • html/canvas/WebKitLoseContext.idl:
  • page/DOMWindow.idl:
  • platform/graphics/ANGLEWebKitBridge.cpp:
  • platform/graphics/GraphicsContext3D.cpp:
  • platform/graphics/cg/GraphicsContext3DCG.cpp:
  • platform/graphics/gpu/DrawingBuffer.cpp:
  • platform/graphics/gpu/mac/DrawingBufferMac.mm:
  • platform/graphics/mac/GraphicsContext3DMac.mm:
  • platform/graphics/mac/WebGLLayer.mm:
  • platform/graphics/opengl/Extensions3DOpenGL.cpp:
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
  • platform/graphics/qt/Extensions3DQt.cpp:
  • platform/graphics/qt/GraphicsContext3DQt.cpp:
  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl): (WebCore::GraphicsLayerQtImpl::paint): (WebCore::GraphicsLayerQtImpl::flushChanges):
  • platform/graphics/qt/GraphicsLayerQt.h:
  • platform/graphics/skia/GraphicsContext3DSkia.cpp:
  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:
  • rendering/RenderLayerBacking.cpp: (WebCore::isAcceleratedCanvas): (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): (WebCore::RenderLayerBacking::containsPaintedContent): (WebCore::RenderLayerBacking::contentChanged):
  • webaudio/AudioBuffer.cpp:
  • webaudio/AudioBuffer.idl:
  • webaudio/RealtimeAnalyser.cpp:
  • webaudio/RealtimeAnalyser.h:
  • webaudio/RealtimeAnalyserNode.h:
  • webaudio/RealtimeAnalyserNode.idl:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::setResponseType): (WebCore::XMLHttpRequest::clearResponse): (WebCore::XMLHttpRequest::didReceiveData):
  • xml/XMLHttpRequest.h:
9:27 AM Changeset in webkit [76600] by cmarrin@apple.com
  • 130 edits in trunk

2011-01-24 Chris Marrin <​cmarrin@apple.com>

Reviewed by Eric Seidel.

Change ENABLE_3D_CANVAS to ENABLE_WEBGL
​https://bugs.webkit.org/show_bug.cgi?id=53041

  • configure.ac:

2011-01-24 Chris Marrin <​cmarrin@apple.com>

Reviewed by Eric Seidel.

Change ENABLE_3D_CANVAS to ENABLE_WEBGL
​https://bugs.webkit.org/show_bug.cgi?id=53041

  • Configurations/FeatureDefines.xcconfig:

2011-01-24 Chris Marrin <​cmarrin@apple.com>

Reviewed by Eric Seidel.

Change ENABLE_3D_CANVAS to ENABLE_WEBGL
​https://bugs.webkit.org/show_bug.cgi?id=53041

  • WebKit.gyp:
  • features.gypi:
  • src/Extensions3DChromium.cpp:
  • src/GraphicsContext3DChromium.cpp:
  • src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableWebGL): (WebKit::WebRuntimeFeatures::isWebGLEnabled):

2011-01-24 Chris Marrin <​cmarrin@apple.com>

Reviewed by Eric Seidel.

Change ENABLE_3D_CANVAS to ENABLE_WEBGL
​https://bugs.webkit.org/show_bug.cgi?id=53041

  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply):

2011-01-24 Chris Marrin <​cmarrin@apple.com>

Reviewed by Eric Seidel.

Change ENABLE_3D_CANVAS to ENABLE_WEBGL
​https://bugs.webkit.org/show_bug.cgi?id=53041

  • WebView.cpp: (WebView::notifyPreferencesChanged):

2011-01-24 Chris Marrin <​cmarrin@apple.com>

Reviewed by Eric Seidel.

Change ENABLE_3D_CANVAS to ENABLE_WEBGL
​https://bugs.webkit.org/show_bug.cgi?id=53041

  • Configurations/FeatureDefines.xcconfig:

2011-01-24 Chris Marrin <​cmarrin@apple.com>

Reviewed by Eric Seidel.

Change ENABLE_3D_CANVAS to ENABLE_WEBGL
​https://bugs.webkit.org/show_bug.cgi?id=53041

  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.cpp:
  • GNUmakefile.am:
  • WebCore.pro:
  • bindings/generic/RuntimeEnabledFeatures.h:
  • bindings/js/JSArrayBufferCustom.cpp:
  • bindings/js/JSCanvasRenderingContextCustom.cpp: (WebCore::toJS):
  • bindings/js/JSDOMWindowCustom.cpp:
  • bindings/js/JSDataViewCustom.cpp:
  • bindings/js/JSDocumentCustom.cpp:
  • bindings/js/JSFloat32ArrayCustom.cpp:
  • bindings/js/JSHTMLCanvasElementCustom.cpp: (WebCore::JSHTMLCanvasElement::getContext):
  • bindings/js/JSInt16ArrayCustom.cpp:
  • bindings/js/JSInt32ArrayCustom.cpp:
  • bindings/js/JSInt8ArrayCustom.cpp:
  • bindings/js/JSUint16ArrayCustom.cpp:
  • bindings/js/JSUint32ArrayCustom.cpp:
  • bindings/js/JSUint8ArrayCustom.cpp:
  • bindings/js/JSWebGLRenderingContextCustom.cpp:
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::markChildren): (WebCore::JSXMLHttpRequest::send): (WebCore::JSXMLHttpRequest::response):
  • bindings/v8/custom/V8ArrayBufferCustom.cpp:
  • bindings/v8/custom/V8ArrayBufferViewCustom.h:
  • bindings/v8/custom/V8DataViewCustom.cpp:
  • bindings/v8/custom/V8DocumentCustom.cpp: (WebCore::V8Document::getCSSCanvasContextCallback):
  • bindings/v8/custom/V8Float32ArrayCustom.cpp:
  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: (WebCore::V8HTMLCanvasElement::getContextCallback):
  • bindings/v8/custom/V8Int16ArrayCustom.cpp:
  • bindings/v8/custom/V8Int32ArrayCustom.cpp:
  • bindings/v8/custom/V8Int8ArrayCustom.cpp:
  • bindings/v8/custom/V8Uint16ArrayCustom.cpp:
  • bindings/v8/custom/V8Uint32ArrayCustom.cpp:
  • bindings/v8/custom/V8Uint8ArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::V8XMLHttpRequest::responseAccessorGetter): (WebCore::V8XMLHttpRequest::sendCallback):
  • features.pri:
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::getContext): (WebCore::HTMLCanvasElement::reset):
  • html/HTMLCanvasElement.h:
  • html/canvas/ArrayBuffer.cpp:
  • html/canvas/ArrayBuffer.idl:
  • html/canvas/ArrayBufferView.cpp:
  • html/canvas/ArrayBufferView.idl:
  • html/canvas/DataView.cpp:
  • html/canvas/DataView.idl:
  • html/canvas/Float32Array.cpp:
  • html/canvas/Float32Array.idl:
  • html/canvas/Int16Array.cpp:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.cpp:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.cpp:
  • html/canvas/Int8Array.idl:
  • html/canvas/OESStandardDerivatives.cpp:
  • html/canvas/OESStandardDerivatives.idl:
  • html/canvas/OESTextureFloat.cpp:
  • html/canvas/OESTextureFloat.idl:
  • html/canvas/Uint16Array.cpp:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.cpp:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.cpp:
  • html/canvas/Uint8Array.idl:
  • html/canvas/WebGLActiveInfo.idl:
  • html/canvas/WebGLBuffer.cpp:
  • html/canvas/WebGLBuffer.idl:
  • html/canvas/WebGLContextAttributes.cpp:
  • html/canvas/WebGLContextAttributes.idl:
  • html/canvas/WebGLContextEvent.idl:
  • html/canvas/WebGLExtension.cpp:
  • html/canvas/WebGLFramebuffer.cpp:
  • html/canvas/WebGLFramebuffer.idl:
  • html/canvas/WebGLGetInfo.cpp:
  • html/canvas/WebGLObject.cpp:
  • html/canvas/WebGLProgram.cpp:
  • html/canvas/WebGLProgram.idl:
  • html/canvas/WebGLRenderbuffer.cpp:
  • html/canvas/WebGLRenderbuffer.idl:
  • html/canvas/WebGLRenderingContext.cpp:
  • html/canvas/WebGLRenderingContext.idl:
  • html/canvas/WebGLShader.cpp:
  • html/canvas/WebGLShader.idl:
  • html/canvas/WebGLTexture.cpp:
  • html/canvas/WebGLTexture.idl:
  • html/canvas/WebGLUniformLocation.cpp:
  • html/canvas/WebGLUniformLocation.idl:
  • html/canvas/WebKitLoseContext.cpp:
  • html/canvas/WebKitLoseContext.idl:
  • page/DOMWindow.idl:
  • platform/graphics/ANGLEWebKitBridge.cpp:
  • platform/graphics/GraphicsContext3D.cpp:
  • platform/graphics/cg/GraphicsContext3DCG.cpp:
  • platform/graphics/gpu/DrawingBuffer.cpp:
  • platform/graphics/gpu/mac/DrawingBufferMac.mm:
  • platform/graphics/mac/GraphicsContext3DMac.mm:
  • platform/graphics/mac/WebGLLayer.mm:
  • platform/graphics/opengl/Extensions3DOpenGL.cpp:
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
  • platform/graphics/qt/Extensions3DQt.cpp:
  • platform/graphics/qt/GraphicsContext3DQt.cpp:
  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl): (WebCore::GraphicsLayerQtImpl::paint): (WebCore::GraphicsLayerQtImpl::flushChanges):
  • platform/graphics/qt/GraphicsLayerQt.h:
  • platform/graphics/skia/GraphicsContext3DSkia.cpp:
  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:
  • rendering/RenderLayerBacking.cpp: (WebCore::isAcceleratedCanvas): (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): (WebCore::RenderLayerBacking::containsPaintedContent): (WebCore::RenderLayerBacking::contentChanged):
  • webaudio/AudioBuffer.cpp:
  • webaudio/AudioBuffer.idl:
  • webaudio/RealtimeAnalyser.cpp:
  • webaudio/RealtimeAnalyser.h:
  • webaudio/RealtimeAnalyserNode.h:
  • webaudio/RealtimeAnalyserNode.idl:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::setResponseType): (WebCore::XMLHttpRequest::clearResponse): (WebCore::XMLHttpRequest::didReceiveData):
  • xml/XMLHttpRequest.h:

2011-01-24 Chris Marrin <​cmarrin@apple.com>

Reviewed by Eric Seidel.

Change ENABLE_3D_CANVAS to ENABLE_WEBGL
​https://bugs.webkit.org/show_bug.cgi?id=53041

  • Configurations/FeatureDefines.xcconfig:
9:22 AM Changeset in webkit [76599] by Nikolas Zimmermann
  • 13 edits
    12 adds in trunk/LayoutTests

2011-01-25 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

Update Leopard svg/ pixel test baselines, to make run-webkit-tests -p pass again with --tolerance 0.
Contains only marginal differences, or updates pixel test results that were forgotten to update.

  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
  • platform/mac-leopard/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
  • platform/mac-leopard/svg/W3C-SVG-1.1/struct-image-07-t-expected.checksum: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1/struct-image-07-t-expected.png: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1/struct-use-01-t-expected.checksum: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1/struct-use-01-t-expected.png: Added.
  • platform/mac-leopard/svg/css/text-gradient-shadow-expected.checksum: Added.
  • platform/mac-leopard/svg/css/text-gradient-shadow-expected.png: Added.
  • platform/mac-leopard/svg/custom/image-rescale-clip-expected.checksum:
  • platform/mac-leopard/svg/custom/image-rescale-clip-expected.png:
  • platform/mac-leopard/svg/custom/image-rescale-scroll-expected.checksum: Added.
  • platform/mac-leopard/svg/custom/image-rescale-scroll-expected.png: Added.
  • platform/mac-leopard/svg/custom/junk-data-expected.checksum:
  • platform/mac-leopard/svg/custom/junk-data-expected.png:
  • platform/mac-leopard/svg/custom/missing-xlink-expected.checksum:
  • platform/mac-leopard/svg/custom/missing-xlink-expected.png:
  • platform/mac-leopard/svg/filters/feComposite-expected.checksum:
  • platform/mac-leopard/svg/filters/feComposite-expected.png:
  • platform/mac-leopard/svg/filters/filter-rounding-issues-expected.checksum: Added.
  • platform/mac-leopard/svg/filters/filter-rounding-issues-expected.png: Added.
  • platform/mac-leopard/svg/repaint/filter-repaint-expected.checksum:
  • platform/mac-leopard/svg/repaint/filter-repaint-expected.png:
9:14 AM Changeset in webkit [76598] by Adam Roben
  • 2 edits in trunk/Source/JavaScriptCore

Windows Production build fix

9:11 AM Changeset in webkit [76597] by mnaganov@chromium.org
  • 17 edits
    2 adds in trunk/Source

2011-01-25 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Prepare for landing of detailed heap snapshots.

  • Introduce Preferences.detailedHeapProfiles flag for controlling querying of detailed heap snapshots.
  • Add boilerplate code for the new view.
  • Factor out common code.

​https://bugs.webkit.org/show_bug.cgi?id=52624

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • bindings/js/ScriptProfiler.h: (WebCore::ScriptProfiler::HeapSnapshotControl::~HeapSnapshotControl): (WebCore::ScriptProfiler::takeHeapSnapshot):
  • bindings/v8/ScriptProfiler.cpp: (WebCore::ScriptProfiler::takeHeapSnapshot):
  • bindings/v8/ScriptProfiler.h: (WebCore::ScriptProfiler::HeapSnapshotControl::~HeapSnapshotControl):
  • inspector/Inspector.idl:
  • inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::takeHeapSnapshot):
  • inspector/InspectorProfilerAgent.h:
  • inspector/front-end/DetailedHeapshotView.js: Added. (WebInspector.DetailedHeapshotView): (WebInspector.DetailedHeapshotView.prototype.get statusBarItems): (WebInspector.DetailedHeapshotView.prototype.get profile): (WebInspector.DetailedHeapshotView.prototype.set profile): (WebInspector.DetailedHeapshotView.prototype.show): (WebInspector.DetailedHeapshotView.prototype.hide): (WebInspector.DetailedHeapshotProfileType): (WebInspector.DetailedHeapshotProfileType.prototype.get buttonTooltip): (WebInspector.DetailedHeapshotProfileType.prototype.get buttonStyle): (WebInspector.DetailedHeapshotProfileType.prototype.buttonClicked): (WebInspector.DetailedHeapshotProfileType.prototype.get welcomeMessage): (WebInspector.DetailedHeapshotProfileType.prototype.createSidebarTreeElementForProfile): (WebInspector.DetailedHeapshotProfileType.prototype.createView):
  • inspector/front-end/HeapSnapshot.js: Added. (WebInspector.HeapSnapshotEdgesIterator): (WebInspector.HeapSnapshotEdgesIterator.prototype.get done): (WebInspector.HeapSnapshotEdgesIterator.prototype.get isElement): (WebInspector.HeapSnapshotEdgesIterator.prototype.get isHidden): (WebInspector.HeapSnapshotEdgesIterator.prototype.get name): (WebInspector.HeapSnapshotEdgesIterator.prototype.next): (WebInspector.HeapSnapshotEdgesIterator.prototype.get node): (WebInspector.HeapSnapshotEdgesIterator.prototype.get nodeIndex): (WebInspector.HeapSnapshotEdgesIterator.prototype._getNameOrIndex): (WebInspector.HeapSnapshotEdgesIterator.prototype._getType): (WebInspector.HeapSnapshotNodeWrapper): (WebInspector.HeapSnapshotNodeWrapper.prototype.get edges): (WebInspector.HeapSnapshotNodeWrapper.prototype.get edgesCount): (WebInspector.HeapSnapshotNodeWrapper.prototype.get instancesCount): (WebInspector.HeapSnapshotNodeWrapper.prototype.get isHidden): (WebInspector.HeapSnapshotNodeWrapper.prototype.get name): (WebInspector.HeapSnapshotNodeWrapper.prototype.get selfSize): (WebInspector.HeapSnapshotNodeWrapper.prototype._getName): (WebInspector.HeapSnapshotNodeWrapper.prototype._getEdges): (WebInspector.HeapSnapshotNodeWrapper.prototype._getType): (WebInspector.HeapSnapshot): (WebInspector.HeapSnapshot.prototype._init): (WebInspector.HeapSnapshot.prototype.get rootEdges):
  • inspector/front-end/HeapSnapshotView.js: (WebInspector.HeapSnapshotProfileType.prototype.buttonClicked):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype._setRecordingProfile): (WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress): (WebInspector.ProfilerDispatcher.prototype.setRecordingProfile): (WebInspector.ProfilerDispatcher.prototype.reportHeapSnapshotProgress):
  • inspector/front-end/Settings.js:
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector._createPanels):
  • src/js/DevTools.js: ():
9:10 AM Changeset in webkit [76596] by Nikolas Zimmermann
  • 67 edits in trunk/LayoutTests

2011-01-25 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

Update Snow Leopard svg/ pixel test baselines, to make run-webkit-tests -p pass again with --tolerance 0.
Contains only marginal differences, or updates pixel test results that were forgotten to update.

  • platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/struct-image-06-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/struct-image-06-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/struct-image-07-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/struct-image-07-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/struct-use-01-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/struct-use-01-t-expected.png:
  • platform/mac/svg/batik/text/textEffect-expected.checksum:
  • platform/mac/svg/batik/text/textEffect-expected.png:
  • platform/mac/svg/batik/text/textEffect3-expected.checksum:
  • platform/mac/svg/batik/text/textEffect3-expected.png:
  • platform/mac/svg/custom/baseval-animval-equality-expected.checksum:
  • platform/mac/svg/custom/baseval-animval-equality-expected.png:
  • platform/mac/svg/custom/foreign-object-skew-expected.checksum:
  • platform/mac/svg/custom/foreign-object-skew-expected.png:
  • platform/mac/svg/custom/image-rescale-expected.checksum:
  • platform/mac/svg/custom/image-rescale-expected.png:
  • platform/mac/svg/custom/svg-fonts-in-html-expected.checksum:
  • platform/mac/svg/custom/svg-fonts-in-html-expected.png:
  • platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.checksum:
  • platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.png:
  • platform/mac/svg/custom/svg-fonts-without-missing-glyph-expected.checksum:
  • platform/mac/svg/custom/svg-fonts-without-missing-glyph-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
  • platform/mac/svg/filters/feComposite-expected.checksum:
  • platform/mac/svg/filters/feComposite-expected.png:
  • platform/mac/svg/filters/filter-rounding-issues-expected.checksum:
  • platform/mac/svg/filters/filter-rounding-issues-expected.png:
  • platform/mac/svg/filters/filteredImage-expected.checksum:
  • platform/mac/svg/filters/filteredImage-expected.png:
  • platform/mac/svg/repaint/filter-repaint-expected.checksum:
  • platform/mac/svg/repaint/filter-repaint-expected.png:
  • platform/mac/svg/text/text-text-05-t-expected.checksum:
  • platform/mac/svg/text/text-text-05-t-expected.png:
  • platform/mac/svg/text/text-text-06-t-expected.checksum:
  • platform/mac/svg/text/text-text-06-t-expected.png:
8:48 AM Changeset in webkit [76595] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-25 Patrick Gansterer <Patrick Gansterer>

Reviewed by Eric Seidel.

Add missing defines for COMPILER(RVCT) && CPU(ARM_THUMB2)
​https://bugs.webkit.org/show_bug.cgi?id=52949

  • jit/JITStubs.cpp:
8:09 AM Changeset in webkit [76594] by yurys@chromium.org
  • 15 edits in trunk/Source

2011-01-25 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove "attached" state related methods from InspectorAgent
​https://bugs.webkit.org/show_bug.cgi?id=53086

  • WebCore.exp.in:
  • inspector/InspectorAgent.cpp:
  • inspector/InspectorAgent.h:
  • inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorFrontendClientLocal::changeAttachedWindowHeight): (WebCore::InspectorFrontendClientLocal::restoreAttachedWindowHeight):
  • inspector/InspectorSettings.cpp: (WebCore::InspectorSettings::InspectorSettings):
  • inspector/InspectorSettings.h:

2011-01-25 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove "attached" state related methods from InspectorAgent
​https://bugs.webkit.org/show_bug.cgi?id=53086

  • WebCoreSupport/WebInspectorClientCF.cpp: (WebInspectorClient::sendMessageToFrontend): (WebInspectorClient::inspectorStartsAttached): (WebInspectorClient::setInspectorStartsAttached): (WebInspectorClient::releaseFrontendPage):

2011-01-25 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove "attached" state related methods from InspectorAgent
​https://bugs.webkit.org/show_bug.cgi?id=53086

  • WebCoreSupport/WebInspectorClient.h:
  • WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController showWindow:]): (-[WebInspectorWindowController attach]): (-[WebInspectorWindowController detach]):

2011-01-25 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove "attached" state related methods from InspectorAgent
​https://bugs.webkit.org/show_bug.cgi?id=53086

  • WebCoreSupport/WebInspectorClient.cpp: (WebInspectorFrontendClient::attachWindow): (WebInspectorFrontendClient::detachWindow): (WebInspectorFrontendClient::showWindowWithoutNotifications):
  • WebCoreSupport/WebInspectorClient.h:
7:46 AM Changeset in webkit [76593] by Carlos Garcia Campos
  • 2 edits in trunk/LayoutTests

2011-01-25 Carlos Garcia Campos <​cgarcia@igalia.com>

Unreviewed, add bug url for failing test on GTK.

[cairo] Fix LayoutTests/fast/canvas/patternfill-repeat.html
​https://bugs.webkit.org/show_bug.cgi?id=53085

  • platform/gtk/Skipped:
7:24 AM Changeset in webkit [76592] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

2011-01-25 Qi Zhang <​qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Symbian] RVCT fails to compile [U|I]nt[8|16|32]Array.h
​https://bugs.webkit.org/show_bug.cgi?id=51873

Replace the using declaration, because it doesn't compile on RVCT, and WINSCW has the same issue.
No new functionality so no new tests.

  • html/canvas/Int32Array.h: (WebCore::Int32Array::set):
  • html/canvas/Int8Array.h: (WebCore::Int8Array::set):
  • html/canvas/Uint16Array.h: (WebCore::Uint16Array::set):
  • html/canvas/Uint32Array.h: (WebCore::Uint32Array::set):
  • html/canvas/Uint8Array.h: (WebCore::Uint8Array::set):
7:15 AM Changeset in webkit [76591] by mario@webkit.org
  • 3 edits in trunk/LayoutTests

2011-01-25 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Antonio Gomes.

fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=53073

Make the two steps in the flaky test to be executed sequentially.

  • fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html: Fix flaky test by chaining its two steps up.
  • platform/gtk/Skipped: Unskip test.
7:10 AM Changeset in webkit [76590] by zherczeg@webkit.org
  • 14 edits in trunk/Source/WebCore

Repaint SVG elements with filter instead of relayout where possible
​https://bugs.webkit.org/show_bug.cgi?id=52200

Reviewed by Dirk Schulze.

This patch allows repainting of filters, when their
attribute changes does not require relayout.

Existing dynamic-update tests cover this feature.

  • platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::clearResult): Clearing the currently stored image
before repainting.

  • platform/graphics/filters/FilterEffect.h:
  • rendering/RenderObject.h:

(WebCore::RenderObject::isSVGResourceFilter): Not only the filter primitives,
but filters should also be detected to allow safe testing and casting.

  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::buildPrimitives): Passing the renderer.
(WebCore::RenderSVGResourceFilter::applyResource):
determineFilterPrimitiveSubregion does not require the filter anymore.
(WebCore::RenderSVGResourceFilter::postApplyResource): Repaint
if lastEffect->hasResult() is false.
(WebCore::RenderSVGResourceFilter::primitiveAttributeChanged):
Searching for all FilterEffects, whose created by the current FilterElement,
and clearing all resulting images depending on those FilterEffects.

  • rendering/svg/RenderSVGResourceFilter.h:

(WebCore::RenderSVGResourceFilter::isSVGResourceFilter):

  • rendering/svg/RenderSVGResourceFilterPrimitive.cpp:

(WebCore::RenderSVGResourceFilterPrimitive::determineFilterPrimitiveSubregion):
The filter argument is unnecessary anymore. But is is still kept as a static
member, since the primitive renderer still does not know about the
FilterEffect objects.

  • rendering/svg/RenderSVGResourceFilterPrimitive.h:

(WebCore::RenderSVGResourceFilterPrimitive::RenderSVGResourceFilterPrimitive):
(WebCore::RenderSVGResourceFilterPrimitive::primitiveAttributeChanged):
Calls RenderSVGResourceFilter::primitiveAttributeChanged.

  • svg/SVGFEDiffuseLightingElement.cpp:

(WebCore::SVGFEDiffuseLightingElement::setFilterEffectAttribute):
Setting the new attribute value for each FilterEffect.
(WebCore::SVGFEDiffuseLightingElement::svgAttributeChanged):

  • svg/SVGFEDiffuseLightingElement.h:

Calling primitiveAttributeChanged.

  • svg/SVGFilterPrimitiveStandardAttributes.cpp:

(WebCore::SVGFilterPrimitiveStandardAttributes::setFilterEffectAttribute):
This function will be removed when all FilterElement implements
their setFilterEffectAttribute

  • svg/SVGFilterPrimitiveStandardAttributes.h:

(WebCore::SVGFilterPrimitiveStandardAttributes::primitiveAttributeChanged):

  • svg/graphics/filters/SVGFilterBuilder.cpp:

(WebCore::SVGFilterBuilder::appendEffectToEffectReferences): The
renderers are assigned to the filter effects.
(WebCore::SVGFilterBuilder::clearEffects):
(WebCore::SVGFilterBuilder::clearResultsRecursive): Recursively
clearing the result images for those filters, whose depend on
the starting filter.

  • svg/graphics/filters/SVGFilterBuilder.h:

(WebCore::SVGFilterBuilder::effectReferences): 'get' is unnecessary
(WebCore::SVGFilterBuilder::effectByRenderer): returns the
FilterEffect belongs to this RenderObject.

5:46 AM Changeset in webkit [76589] by krit@webkit.org
  • 4 edits
    3 adds in trunk

2011-01-25 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG is missing to-animation support for Path
​https://bugs.webkit.org/show_bug.cgi?id=52982

Added an animation test to check 'to' animations in combination with SVG paths.

  • svg/animations/animate-path-to-animation-expected.txt: Added.
  • svg/animations/animate-path-to-animation.html: Added.
  • svg/animations/script-tests/animate-path-to-animation.js: Added. (sample1): (sample2): (sample3): (executeTest):

2011-01-25 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG is missing to-animation support for Path
​https://bugs.webkit.org/show_bug.cgi?id=52982

SVG was missing 'to' animation support for SVG paths. Even the fallback to discrete
animation did not work and an assert was thrown, because of the missing m_fromPath.
This also influences a test of the W3C test suite. Subtest 2 of animate-elem-83-t.svg passes now.

Test: svg/animations/animate-path-to-animation.html

  • svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::calculateAnimatedValue): Take the value of the last SVGAnimateElement for m_fromPath, since 'to' animations are accumulative. (WebCore::SVGAnimateElement::calculateFromAndToValues): Added support for 'to' animations. (WebCore::SVGAnimateElement::resetToBaseValue): Set m_animatedPath on the first animation element to baseVal.
  • svg/SVGPathByteStream.h: (WebCore::SVGPathByteStream::copySVGPathByteStream): Return copy of current byte stream.
5:34 AM Changeset in webkit [76588] by Nikolas Zimmermann
  • 22 edits in trunk/LayoutTests

2011-01-25 Nikolas Zimmermann <​nzimmermann@rim.com>

Introduce FontMetrics abstraction
​https://bugs.webkit.org/show_bug.cgi?id=51456

Update gtk/qt baseline.

  • platform/gtk/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
  • platform/gtk/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
  • platform/gtk/svg/text/text-hkern-expected.txt:
  • platform/gtk/svg/text/text-hkern-on-vertical-text-expected.txt:
  • platform/gtk/svg/text/text-vkern-expected.txt:
  • platform/gtk/svg/text/text-vkern-on-horizontal-text-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
  • platform/qt/svg/custom/svg-fonts-with-no-element-reference-expected.txt:
  • platform/qt/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
  • platform/qt/svg/text/text-hkern-expected.txt:
  • platform/qt/svg/text/text-hkern-on-vertical-text-expected.txt:
  • platform/qt/svg/text/text-vkern-expected.txt:
  • platform/qt/svg/text/text-vkern-on-horizontal-text-expected.txt:
  • platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
5:32 AM Changeset in webkit [76587] by pfeldman@chromium.org
  • 11 edits in trunk

2011-01-25 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: bind resources to URLs upon adding them into the tree.
​https://bugs.webkit.org/show_bug.cgi?id=53013

  • inspector/debugger-scripts-expected.txt:
  • inspector/debugger-scripts.html:

2011-01-25 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: bind resources to URLs upon adding them into the tree.
​https://bugs.webkit.org/show_bug.cgi?id=53013

  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback): (WebInspector.CSSStyleModel.prototype._styleSheetChanged):
  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype._parsedScriptSource):
  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager.prototype._processCachedResources): (WebInspector.NetworkManager.prototype.inflightResourceForURL): (WebInspector.NetworkDispatcher): (WebInspector.NetworkDispatcher.prototype.willSendRequest): (WebInspector.NetworkDispatcher.prototype.markResourceAsCached): (WebInspector.NetworkDispatcher.prototype.didReceiveResponse): (WebInspector.NetworkDispatcher.prototype.didReceiveContentLength): (WebInspector.NetworkDispatcher.prototype.didFinishLoading): (WebInspector.NetworkDispatcher.prototype.didFailLoading): (WebInspector.NetworkDispatcher.prototype.willSendWebSocketHandshakeRequest): (WebInspector.NetworkDispatcher.prototype.didReceiveWebSocketHandshakeResponse): (WebInspector.NetworkDispatcher.prototype.didCloseWebSocket): (WebInspector.NetworkDispatcher.prototype._appendRedirect): (WebInspector.NetworkDispatcher.prototype._startResource): (WebInspector.NetworkDispatcher.prototype._finishResource): (WebInspector.NetworkDispatcher.prototype._createResource):
  • inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel.prototype.addResourceToFrame): (WebInspector.ResourceTreeModel.prototype._bindResourceURL): (WebInspector.ResourceTreeModel.prototype._clearResources): (WebInspector.ResourceTreeModel.prototype._unbindResourceURL):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.canShowSourceLine): (WebInspector.ResourcesPanel.prototype.showSourceLine):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._parsedScriptSource): (WebInspector.ScriptsPanel.prototype._addScript):
4:47 AM Changeset in webkit [76586] by Nikolas Zimmermann
  • 42 edits in trunk

2011-01-25 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Introduce FontMetrics abstraction
​https://bugs.webkit.org/show_bug.cgi?id=51456

Use accurate floating-point metrics for SVG Font calculations instead of casting float -> integer.
This hopefully fixes differences between 32/64 bit bots.

Needs new layout test results for several platforms, which need to be taken from the bots landing afterwards.

  • platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::SimpleFontData): (WebCore::SimpleFontData::initCharWidths):

2011-01-25 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Introduce FontMetrics abstraction
​https://bugs.webkit.org/show_bug.cgi?id=51456

Update mac/mac-leopard pixel baseline after removing the float -> int truncation in the SVG Fonts ascent/descent calculation code.

  • platform/gtk/Skipped: Unskip several tests.
  • platform/mac-leopard/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.checksum:
  • platform/mac-leopard/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
  • platform/mac-leopard/svg/batik/text/textEffect-expected.checksum:
  • platform/mac-leopard/svg/batik/text/textEffect-expected.png:
  • platform/mac-leopard/svg/batik/text/textEffect3-expected.checksum:
  • platform/mac-leopard/svg/batik/text/textEffect3-expected.png:
  • platform/mac-leopard/svg/custom/svg-fonts-in-html-expected.checksum:
  • platform/mac-leopard/svg/custom/svg-fonts-in-html-expected.png:
  • platform/mac-leopard/svg/custom/svg-fonts-with-no-element-reference-expected.checksum:
  • platform/mac-leopard/svg/custom/svg-fonts-with-no-element-reference-expected.png:
  • platform/mac-leopard/svg/custom/svg-fonts-without-missing-glyph-expected.checksum:
  • platform/mac-leopard/svg/custom/svg-fonts-without-missing-glyph-expected.png:
  • platform/mac-leopard/svg/text/text-text-05-t-expected.checksum:
  • platform/mac-leopard/svg/text/text-text-05-t-expected.png:
  • platform/mac-leopard/svg/text/text-text-06-t-expected.checksum:
  • platform/mac-leopard/svg/text/text-text-06-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-24-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-05-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-06-t-expected.txt:
  • platform/mac/svg/batik/text/textEffect-expected.txt:
  • platform/mac/svg/batik/text/textEffect3-expected.txt:
  • platform/mac/svg/batik/text/textPosition2-expected.png:
  • platform/mac/svg/batik/text/textPosition2-expected.txt:
  • platform/mac/svg/custom/svg-fonts-in-html-expected.txt:
  • platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt:
  • platform/mac/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
  • platform/mac/svg/text/text-text-05-t-expected.txt:
  • platform/mac/svg/text/text-text-06-t-expected.txt:
  • svg/custom/glyph-transformation-with-hkern-expected.txt:

-This line, and those below, will be ignored--

M LayoutTests/platform/mac-leopard/svg/text/text-text-05-t-expected.checksum
M LayoutTests/platform/mac-leopard/svg/text/text-text-06-t-expected.checksum
M LayoutTests/platform/mac-leopard/svg/text/text-text-05-t-expected.png
M LayoutTests/platform/mac-leopard/svg/text/text-text-06-t-expected.png
M LayoutTests/platform/mac-leopard/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png
M LayoutTests/platform/mac-leopard/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.checksum
M LayoutTests/platform/mac-leopard/svg/batik/text/textEffect3-expected.checksum
M LayoutTests/platform/mac-leopard/svg/batik/text/textEffect-expected.checksum
M LayoutTests/platform/mac-leopard/svg/batik/text/textEffect-expected.png
M LayoutTests/platform/mac-leopard/svg/batik/text/textEffect3-expected.png
M LayoutTests/platform/mac-leopard/svg/custom/svg-fonts-without-missing-glyph-expected.png
M LayoutTests/platform/mac-leopard/svg/custom/svg-fonts-with-no-element-reference-expected.checksum
M LayoutTests/platform/mac-leopard/svg/custom/svg-fonts-in-html-expected.checksum
M LayoutTests/platform/mac-leopard/svg/custom/svg-fonts-without-missing-glyph-expected.checksum
M LayoutTests/platform/mac-leopard/svg/custom/svg-fonts-with-no-element-reference-expected.png
M LayoutTests/platform/mac-leopard/svg/custom/svg-fonts-in-html-expected.png
M LayoutTests/platform/mac/svg/text/text-text-06-t-expected.txt
M LayoutTests/platform/mac/svg/text/text-text-05-t-expected.txt
M LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-text-05-t-expected.txt
M LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt
M LayoutTests/platform/mac/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt
M LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-text-06-t-expected.txt
M LayoutTests/platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt
M LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-24-t-expected.png
M LayoutTests/platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt
M LayoutTests/platform/mac/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.png
M LayoutTests/platform/mac/svg/batik/text/textEffect3-expected.txt
M LayoutTests/platform/mac/svg/batik/text/textPosition2-expected.png
M LayoutTests/platform/mac/svg/batik/text/textEffect-expected.txt
M LayoutTests/platform/mac/svg/batik/text/textPosition2-expected.txt
M LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt
M LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt
M LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt
M LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt
M LayoutTests/platform/mac/svg/custom/svg-fonts-in-html-expected.txt
M LayoutTests/platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt
M LayoutTests/platform/mac/svg/custom/svg-fonts-without-missing-glyph-expected.txt
M LayoutTests/platform/gtk/Skipped
M LayoutTests/ChangeLog
M LayoutTests/svg/custom/glyph-transformation-with-hkern-expected.txt
M Source/WebCore/ChangeLog
M Source/WebCore/platform/graphics/SimpleFontData.cpp

4:43 AM Changeset in webkit [76585] by andreas.kling@nokia.com
  • 4 edits in trunk/Source/WebKit2

2011-01-25 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt][WK2] Add QWKPage::processCrashed() signal
​https://bugs.webkit.org/show_bug.cgi?id=53076

  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::processDidCrash):
  • UIProcess/API/qt/qwkpage.h:
  • UIProcess/API/qt/qwkpage_p.h:
3:43 AM Changeset in webkit [76584] by kov@webkit.org
  • 2 edits in trunk/Tools

2011-01-25 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Andreas Kling.

[GTK] Remove 64 bits release bot from the buildbot master
​https://bugs.webkit.org/show_bug.cgi?id=52899

Removes the 64 bits release slave from the buildbot configuration,
so that we can use it as an EWS.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
3:38 AM Changeset in webkit [76583] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-25 Mario Sanchez Prada <​msanchez@igalia.com>

Unreviewed, skipping flaky test on GTK debug bots.

editing/selection/extend-selection-bidi.html test is flaky
​https://bugs.webkit.org/show_bug.cgi?id=53074

  • platform/gtk/Skipped: Skipped test.
3:09 AM Changeset in webkit [76582] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-25 Mario Sanchez Prada <​msanchez@igalia.com>

Unreviewed, skipping flaky test on GTK debug bots.

fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=53073

  • platform/gtk/Skipped: Skipped test.
1:44 AM Changeset in webkit [76581] by podivilov@chromium.org
  • 11 edits in trunk/Source/WebCore

2011-01-24 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: debugger and browser debugger agents should manage sticky breakpoints independently.
​https://bugs.webkit.org/show_bug.cgi?id=52999

  • inspector/Inspector.idl:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::didCommitLoad): (WebCore::InspectorAgent::enableDebugger): (WebCore::InspectorAgent::inspectedURLWithoutFragment):
  • inspector/InspectorAgent.h:
  • inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::setAllBrowserBreakpoints): (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged): (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint):
  • inspector/InspectorBrowserDebuggerAgent.h:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent): (WebCore::InspectorDebuggerAgent::setAllJavaScriptBreakpoints): (WebCore::InspectorDebuggerAgent::inspectedURLChanged): (WebCore::InspectorDebuggerAgent::restoreBreakpoints):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState):
  • inspector/InspectorState.h:
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager): (WebInspector.BreakpointManager.prototype._projectChanged): (WebInspector.BreakpointManager.prototype._saveBreakpoints): (WebInspector.BreakpointManager.prototype._pushBreakpointsToBackend):
1:19 AM Changeset in webkit [76580] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2011-01-24 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Nikolas Zimmermann.

Skip some new tests for WebKit2 that use eventSender
​https://bugs.webkit.org/show_bug.cgi?id=53068

  • platform/mac-wk2/Skipped:
1:15 AM Changeset in webkit [76579] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-01-25 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, trivial debugger test fix.

  • src/js/Tests.js:
12:43 AM Changeset in webkit [76578] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

2011-01-25 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Crash in some pages containing flash
​https://bugs.webkit.org/show_bug.cgi?id=53016

Flash plugin can produce X errors that are handled by the GDK X
error handler, which exits the process. Since we don't want to
crash due to flash bugs, we install a custom error handler to show
a warning when a X error happens without aborting.

  • plugins/gtk/PluginPackageGtk.cpp: (WebCore::webkitgtkXError): (WebCore::PluginPackage::load):
12:33 AM Changeset in webkit [76577] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebCore

2011-01-25 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Implement spin buttons in RenderThemeGtk
​https://bugs.webkit.org/show_bug.cgi?id=51454

Paint inner up/down buttons for spin button elements when building
with GTK+ 3.x.

Test results will land with the GTK+ 2.x version of this patch.

  • platform/gtk/RenderThemeGtk.h:
  • platform/gtk/RenderThemeGtk2.cpp: (WebCore::RenderThemeGtk::adjustInnerSpinButtonStyle): (WebCore::RenderThemeGtk::paintInnerSpinButton):
  • platform/gtk/RenderThemeGtk3.cpp: (WebCore::spinButtonArrowSize): (WebCore::RenderThemeGtk::adjustInnerSpinButtonStyle): (WebCore::paintSpinArrowButton): (WebCore::RenderThemeGtk::paintInnerSpinButton):
Note: See TracTimeline for information about the timeline view.