Context Navigation

When we try to calculate the baseline position of a table cell,
we recurse through all the child sibling boxes (when children are
non inline) and add their first linebox baseline values. If one of
the children is a table with pending section recalc, we will access
wrong table section values. We recalc table sections if it is needed.

Test: fast/table/recalc-section-first-body-crash-main.html

rendering/RenderTable.cpp: (WebCore::RenderTable::firstLineBoxBaseline):

2011-01-27 Abhishek Arya <inferno@chromium.org>

Reviewed by Dan Bernstein.

Tests that we do not crash when calculating the first line box
baseline for the table.
https://bugs.webkit.org/show_bug.cgi?id=53265

fast/table/recalc-section-first-body-crash-main-expected.txt: Added.
fast/table/recalc-section-first-body-crash-main.html: Added.
fast/table/resources/recalc-section-first-body-crash.html: Added.

8:26 PM Changeset in webkit [76914] by enne@google.com

2 edits in trunk/Source/WebCore

2011-01-27 Adrienne Walker <enne@google.com>

Reviewed by Kenneth Russell.

[chromium] Add CRASH calls to further debug tiled compositor memcpy crash.
https://bugs.webkit.org/show_bug.cgi?id=52379

Test: LayoutTests/compositing (to verify these weren't triggered)

platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::invalidateRect): (WebCore::LayerTilerChromium::update):

8:14 PM Changeset in webkit [76913] by apavlov@chromium.org

2 edits in trunk/Source/WebCore

2011-01-27 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [STYLES] Cancelled suggestion of a property name results in a visual artifact
https://bugs.webkit.org/show_bug.cgi?id=53242

inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype):

7:42 PM Changeset in webkit [76912] by commit-queue@webkit.org

6 edits in trunk/Source

2011-01-27 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76891.
http://trac.webkit.org/changeset/76891
https://bugs.webkit.org/show_bug.cgi?id=53280

Makes every layout test crash (Requested by othermaciej on
#webkit).

page/EventHandler.cpp:
page/EventHandler.h:
rendering/RenderObject.cpp: (WebCore::RenderObject::styleDidChange):

2011-01-27 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76891.
http://trac.webkit.org/changeset/76891
https://bugs.webkit.org/show_bug.cgi?id=53280

Makes every layout test crash (Requested by othermaciej on
#webkit).

Misc/WebIconDatabase.mm: (-[ThreadEnabler threadEnablingSelector:]): (importToWebCoreFormat):

7:30 PM Changeset in webkit [76911] by rniwa@webkit.org

4 edits
8 deletes in trunk

2011-01-27 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed, rolling out r76839.
http://trac.webkit.org/changeset/76839
https://bugs.webkit.org/show_bug.cgi?id=49744

broke pixel tests

rendering/RenderBox.cpp: (WebCore::RenderBox::localCaretRect):

2011-01-27 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed, rolling out r76839.
http://trac.webkit.org/changeset/76839
https://bugs.webkit.org/show_bug.cgi?id=49744

broke pixel tests

editing/selection/caret-painting-after-paste-undo-rtl.html: Removed.
editing/selection/caret-painting-after-paste-undo.html: Removed.
platform/mac/editing/deleting/5408255-expected.png:
platform/mac/editing/selection/caret-painting-after-paste-undo-expected.checksum: Removed.
platform/mac/editing/selection/caret-painting-after-paste-undo-expected.png: Removed.
platform/mac/editing/selection/caret-painting-after-paste-undo-expected.txt: Removed.
platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.checksum: Removed.
platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.png: Removed.
platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.txt: Removed.

7:18 PM Changeset in webkit [76910] by mrowe@apple.com

2 edits
1 add in branches/safari-533.20-branch/LayoutTests

Merge r64815.

7:18 PM Changeset in webkit [76909] by mrowe@apple.com

6 edits
1 copy
1 move
3 adds
2 deletes in branches/safari-533.20-branch

Merge r64379.

7:09 PM Changeset in webkit [76908] by mjs@apple.com

9 edits in trunk

2011-01-27 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin Adler.

execCommand("Paste") doesn't work in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=52785

Unskip paste tests, except the ones that still fail.

platform/mac-wk2/Skipped:

2011-01-27 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin Adler.

execCommand("Paste") doesn't work in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=52785

Thread through the new JavaScriptCanAccessClipboard setting.

Shared/WebPreferencesStore.h:
UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetJavaScriptCanAccessClipboard): (WKPreferencesGetJavaScriptCanAccessClipboard):
UIProcess/API/C/WKPreferences.h:
WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences):

2011-01-27 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin Adler.

execCommand("Paste") doesn't work in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=52785

Enable both of the settings needed to allow paste.

WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):

7:08 PM Changeset in webkit [76907] by mrowe@apple.com

4 edits
4 adds in branches/safari-533.20-branch

Merge r75168.

7:01 PM Changeset in webkit [76906] by mrowe@apple.com

5 edits
16 adds in branches/safari-533.20-branch

Merge r74954.

6:56 PM Changeset in webkit [76905] by mrowe@apple.com

3 edits
2 adds in branches/safari-533.20-branch

Merge r74787.

6:46 PM Changeset in webkit [76904] by mrowe@apple.com

3 edits
2 adds in branches/safari-533.20-branch

Merge r75519.

6:41 PM Changeset in webkit [76903] by commit-queue@webkit.org

3 edits
2 adds in trunk

2011-01-27 Emil A Eklund <eae@chromium.org>

Reviewed by Darin Adler.

contentEditable formatBlock crashes on divs with contenteditable="false"
https://bugs.webkit.org/show_bug.cgi?id=53263

Add test for executing a formatBlock command on a selection containing an
element with contenteditable=false.

editing/execCommand/format-block-contenteditable-false-expected.txt: Added.
editing/execCommand/format-block-contenteditable-false.html: Added.

2011-01-27 Emil A Eklund <eae@chromium.org>

Reviewed by Darin Adler.

contentEditable formatBlock crashes on divs with contenteditable="false"
https://bugs.webkit.org/show_bug.cgi?id=53263

Check if editableRootForPosition returns null for position.

Test: editing/execCommand/format-block-contenteditable-false.html

editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::formatRange):

6:39 PM Changeset in webkit [76902] by mrowe@apple.com

3 edits
2 adds in branches/safari-533.20-branch

Merge r69936.

6:35 PM Changeset in webkit [76901] by mrowe@apple.com

3 edits
3 adds in branches/safari-533.20-branch

Merge r72625.

6:32 PM Changeset in webkit [76900] by mrowe@apple.com

3 edits
8 adds in branches/safari-533.20-branch

Merge r71256.

6:29 PM Changeset in webkit [76899] by mrowe@apple.com

6 edits
4 adds in branches/safari-533.20-branch

Merge r74084.

6:26 PM Changeset in webkit [76898] by Dimitri Glazkov

2 edits in trunk/Source/WebCore

2011-01-27 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Remove RenderMedia members that aren't used.
https://bugs.webkit.org/show_bug.cgi?id=53245

Refactoring, no change in behavior, so no new tests.

rendering/RenderMedia.h: Removed unused member variables.

6:24 PM Changeset in webkit [76897] by mrowe@apple.com

3 edits
2 adds in branches/safari-533.20-branch

Merge r70517.

6:22 PM Changeset in webkit [76896] by mrowe@apple.com

3 edits in branches/safari-533.20-branch/LayoutTests

Merge r72830.

6:21 PM Changeset in webkit [76895] by mrowe@apple.com

3 edits
2 moves
6 adds in branches/safari-533.20-branch

Merge r72817.

6:20 PM Changeset in webkit [76894] by abarth@webkit.org

3 edits in trunk/Source/JavaScriptCore

2011-01-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add WTFString method to compare equality with Vector<UChar>
https://bugs.webkit.org/show_bug.cgi?id=53266

I'm planning to use this method in the new XSS filter implementation,
but it seems generally useful.

wtf/text/StringImpl.h: (WTF::equalIgnoringNullity):
wtf/text/WTFString.h: (WTF::equalIgnoringNullity):

6:18 PM Changeset in webkit [76893] by msaboff@apple.com

5 edits in trunk/Source

2011-01-27 Michael Saboff <msaboff@apple.com>

Potentially Unsafe HashSet of RuntimeObject* in RootObject definition
https://bugs.webkit.org/show_bug.cgi?id=53271

Added new isValid() methods to check if a contained object in
a WeakGCMap is valid when using an unchecked iterator.

runtime/WeakGCMap.h: (JSC::WeakGCMap::isValid):

2011-01-27 Michael Saboff <msaboff@apple.com>

Reviewed by Darin Adler.

Potentially Unsafe HashSet of RuntimeObject* in RootObject definition
https://bugs.webkit.org/show_bug.cgi?id=53271

Precautionary change.
Changed RootObject to use WeakGCMap instead of HashSet.
Found will looking for another issue, but can't produce a test case
that is problematic. THerefore there aren't any new tests.

bridge/runtime_root.cpp: (JSC::Bindings::RootObject::invalidate): (JSC::Bindings::RootObject::addRuntimeObject): (JSC::Bindings::RootObject::removeRuntimeObject):
bridge/runtime_root.h:

6:15 PM Changeset in webkit [76892] by kbr@google.com

33 edits in trunk

2011-01-27 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

Rename Typed Array slice() to subset()
https://bugs.webkit.org/show_bug.cgi?id=53273

bindings/js/JSArrayBufferViewHelper.h: (WebCore::constructArrayBufferView):
bindings/v8/custom/V8ArrayBufferViewCustom.h: (WebCore::constructWebGLArray):
html/canvas/Float32Array.cpp: (WebCore::Float32Array::subset):
html/canvas/Float32Array.h:
html/canvas/Float32Array.idl:
html/canvas/Int16Array.cpp: (WebCore::Int16Array::subset):
html/canvas/Int16Array.h:
html/canvas/Int16Array.idl:
html/canvas/Int32Array.cpp: (WebCore::Int32Array::subset):
html/canvas/Int32Array.h:
html/canvas/Int32Array.idl:
html/canvas/Int8Array.cpp: (WebCore::Int8Array::subset):
html/canvas/Int8Array.h:
html/canvas/Int8Array.idl:
html/canvas/TypedArrayBase.h: (WebCore::TypedArrayBase::subsetImpl):
html/canvas/Uint16Array.cpp: (WebCore::Uint16Array::subset):
html/canvas/Uint16Array.h:
html/canvas/Uint16Array.idl:
html/canvas/Uint32Array.cpp: (WebCore::Uint32Array::subset):
html/canvas/Uint32Array.h:
html/canvas/Uint32Array.idl:
html/canvas/Uint8Array.cpp: (WebCore::Uint8Array::subset):
html/canvas/Uint8Array.h:
html/canvas/Uint8Array.idl:

2011-01-27 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

Rename Typed Array slice() to subset()
https://bugs.webkit.org/show_bug.cgi?id=53273

fast/canvas/webgl/array-setters.html:
fast/canvas/webgl/array-unit-tests-expected.txt:
fast/canvas/webgl/array-unit-tests.html:
fast/canvas/webgl/draw-elements-out-of-bounds-expected.txt:
fast/canvas/webgl/draw-elements-out-of-bounds.html:
fast/canvas/webgl/webgl-array-invalid-ranges-expected.txt:
fast/canvas/webgl/webgl-array-invalid-ranges.html:

6:12 PM Changeset in webkit [76891] by Darin Adler

5 edits in trunk/Source

2011-01-27 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Changing cursor style has no effect until the mouse moves
https://bugs.webkit.org/show_bug.cgi?id=14344
rdar://problem/7563712

No tests added because we don't have infrastructure for testing actual cursor
changes (as opposed to cursor style computation) at this time. We might add it later.

page/EventHandler.cpp: (WebCore::EventHandler::dispatchFakeMouseMoveEventSoon): Added.
page/EventHandler.h: Ditto.

rendering/RenderObject.cpp: (WebCore::areNonIdenticalCursorListsEqual): Added. (WebCore::areCursorsEqual): Added. (WebCore::RenderObject::styleDidChange): Call dispatchFakeMouseMoveEventSoon if cursor styles changed.

6:10 PM Changeset in webkit [76890] by mrowe@apple.com

6 edits in branches/safari-533.20-branch/WebKit/mac

Merge r76191.

6:03 PM Changeset in webkit [76889] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

2011-01-27 Finnur Thorarinsson <finnur.webkit@gmail.com>

Reviewed by Ojan Vafai.

This addresses a regression introduced by r75784, as described in:
https://bugs.webkit.org/show_bug.cgi?id=53176

The problem is that originalEndContainer and originalEndOffset was
meant to capture the end of the document, but was being assigned after
a call to searchRange->setStart() (when scoping is restarted), which can
result in the Range being collapsed to start (thereby assigning the
wrong value to the Container/Offset pair).

This code is never triggered by layout tests, but I'm adding a regressiono
test on the Chromium side for this.

src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::scopeStringMatches):

6:03 PM Changeset in webkit [76888] by mrowe@apple.com

5 edits
2 adds in branches/safari-533.20-branch

Merge r72969.

5:57 PM Changeset in webkit [76887] by mrowe@apple.com

4 edits
4 adds in branches/safari-533.20-branch

Merge r60992.

5:55 PM Changeset in webkit [76886] by mrowe@apple.com

7 edits in branches/safari-533.20-branch

Merge r68923.

5:52 PM Changeset in webkit [76885] by mrowe@apple.com

3 edits
3 adds in branches/safari-533.20-branch

Merge r74287.

5:52 PM Changeset in webkit [76884] by mrowe@apple.com

3 edits in branches/safari-533.20-branch/WebCore

Merge r74286.

5:51 PM Changeset in webkit [76883] by commit-queue@webkit.org

3 edits
2 adds in trunk

2011-01-27 Leo Yang <leo.yang@torchmobile.com.cn>

Reviewed by Dirk Schulze.

SVG Use Cycle is not detected
https://bugs.webkit.org/show_bug.cgi?id=52544

Test for indirect <use> recursion. This test passes if
no crash occurs.

svg/custom/recursive-use2-expected.txt: Added.
svg/custom/recursive-use2.svg: Added.

2011-01-27 Leo Yang <leo.yang@torchmobile.com.cn>

Reviewed by Dirk Schulze.

SVG Use Cycle is not detected
https://bugs.webkit.org/show_bug.cgi?id=52544

We should check if SVGUseElement::buildInstanceTree finds problem
for every child node. If it finds problem for any children we must
return immediately because otherwise the foundProblem variable may
be rewritten to false.

Test: svg/custom/recursive-use2.svg

svg/SVGUseElement.cpp: (WebCore::SVGUseElement::buildInstanceTree):

5:48 PM Changeset in webkit [76882] by mrowe@apple.com

3 edits
3 adds in branches/safari-533.20-branch

Merge r72644.

5:48 PM Changeset in webkit [76881] by mrowe@apple.com

5 edits
3 adds in branches/safari-533.20-branch

Merge r71925.

5:41 PM Changeset in webkit [76880] by mrowe@apple.com

2 edits in branches/safari-533.20-branch/WebCore

Merge r72013.

5:38 PM Changeset in webkit [76879] by mrowe@apple.com

3 edits
2 adds in branches/safari-533.20-branch

Merge r70473.

5:36 PM Changeset in webkit [76878] by mrowe@apple.com

3 edits in branches/safari-533.20-branch/WebCore

Merge r70550.

5:33 PM Changeset in webkit [76877] by mrowe@apple.com

2 edits in branches/safari-533.20-branch/WebCore

Merge r72304.

5:29 PM Changeset in webkit [76876] by zmo@google.com

2 edits in trunk/Source/WebKit/chromium

2011-01-27 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Define GC3D types to match GL types and use them in WebGraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=51947

public/WebGraphicsContext3D.h:

5:27 PM Changeset in webkit [76875] by mrowe@apple.com

9 edits
1 delete in branches/safari-533.20-branch/WebCore

<rdar://problem/8796252> Use WTF's StringBuffer.h.

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2010-10-19.
Reviewed by Aaron Golden.

css/CSSParser.cpp:
dom/Document.cpp:
platform/Length.cpp:
platform/text/StringBuffer.h: Removed.
platform/text/StringBuilder.cpp:
platform/text/TextCodecLatin1.cpp:
platform/text/TextCodecUTF16.cpp:
platform/text/TextCodecUserDefined.cpp:
rendering/RenderText.cpp:

5:26 PM Changeset in webkit [76874] by zmo@google.com

3 edits
2 adds in trunk

2011-01-27 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

texSubImage2D's format/type needs to match the internalformat/type from the previous texImage2D call
https://bugs.webkit.org/show_bug.cgi?id=53054

fast/canvas/webgl/tex-sub-image-2d-bad-args-expected.txt: Added.
fast/canvas/webgl/tex-sub-image-2d-bad-args.html: Added.

2011-01-27 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

texSubImage2D's format/type needs to match the internalformat/type from the previous texImage2D call
https://bugs.webkit.org/show_bug.cgi?id=53054

Test: fast/canvas/webgl/tex-sub-image-2d-bad-args.html

html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::texSubImage2DBase): Check format/type match.

5:23 PM Changeset in webkit [76873] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

2011-01-27 Yi Shen <yi.4.shen@nokia.com>, Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Andreas Kling.

[Qt] Add fullscreen media control button for html video
https://bugs.webkit.org/show_bug.cgi?id=51543

Implement media control fullscreen button for QtWebKit html5 video.

css/mediaControlsQt.css: (video::-webkit-media-controls-fullscreen-button):
platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::paintMediaFullscreenButton):

5:22 PM Changeset in webkit [76872] by Nate Chapin

35 edits in trunk/Source

2011-01-27 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Remove FrameLoader::url() and update callers to use
Document::url().
https://bugs.webkit.org/show_bug.cgi?id=41165

Refactor, no new tests.

WebCore.exp.in:
dom/Document.cpp: (WebCore::Document::processHttpEquiv): (WebCore::Document::removePendingSheet):
history/CachedFrame.cpp: (WebCore::CachedFrameBase::CachedFrameBase):
history/PageCache.cpp: (WebCore::logCanCacheFrameDecision): (WebCore::PageCache::canCachePageContainingThisFrame):
html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::isURLAllowed):
html/HTMLPlugInImageElement.cpp: (WebCore::HTMLPlugInImageElement::allowedToLoadFrameURL):
inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::inspectedURL):
inspector/InspectorResourceAgent.cpp: (WebCore::buildObjectForFrame):
loader/DocumentWriter.cpp: (WebCore::DocumentWriter::replaceDocument): (WebCore::DocumentWriter::deprecatedFrameEncoding):
loader/FrameLoader.cpp:
loader/FrameLoader.h:
loader/HistoryController.cpp: (WebCore::HistoryController::updateForStandardLoad): (WebCore::HistoryController::updateForRedirectWithLockedBackForwardList): (WebCore::HistoryController::updateForSameDocumentNavigation):
loader/NavigationScheduler.cpp: (WebCore::ScheduledHistoryNavigation::fire): (WebCore::NavigationScheduler::scheduleLocationChange): (WebCore::NavigationScheduler::scheduleRefresh):
page/FrameView.cpp: (WebCore::FrameView::updateControlTints):
page/Location.cpp: (WebCore::Location::url): (WebCore::Location::setProtocol): (WebCore::Location::setHost): (WebCore::Location::setHostname): (WebCore::Location::setPort): (WebCore::Location::setPathname): (WebCore::Location::setSearch): (WebCore::Location::setHash): (WebCore::Location::reload):
page/Page.cpp: (WebCore::Page::goToItem):

2011-01-27 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Use Document::url() instead of FrameLoader::url().
https://bugs.webkit.org/show_bug.cgi?id=41165

ewk/ewk_frame.cpp: (ewk_frame_uri_changed):

2011-01-27 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Use Document::url() instead of FrameLoader::url().
https://bugs.webkit.org/show_bug.cgi?id=41165

webkit/webkitwebview.cpp: (webkit_web_view_get_icon_uri):

2011-01-27 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Use Document::url() instead of FrameLoader::url().
https://bugs.webkit.org/show_bug.cgi?id=41165

WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::dispatchDidFinishDocumentLoad):

2011-01-27 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Use Document::url() instead of FrameLoader::url().
https://bugs.webkit.org/show_bug.cgi?id=41165

WebView/WebView.mm: (-[WebView _dispatchDidReceiveIconFromWebFrame:]):

2011-01-27 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Use Document::url() instead of FrameLoader::url().
https://bugs.webkit.org/show_bug.cgi?id=41165

Api/qwebframe.cpp: (QWebFrame::url):

2011-01-27 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Use Document::url() instead of FrameLoader::url().
https://bugs.webkit.org/show_bug.cgi?id=41165

WebFrame.cpp: (WebFrame::url):

2011-01-27 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Use Document::url() instead of FrameLoader::url().
https://bugs.webkit.org/show_bug.cgi?id=41165

WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::dispatchDidFinishDocumentLoad):

2011-01-27 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Use Document::url() instead of FrameLoader::url().
https://bugs.webkit.org/show_bug.cgi?id=41165

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDidChangeLocationWithinPage): (WebKit::WebFrameLoaderClient::dispatchDidPushStateWithinPage): (WebKit::WebFrameLoaderClient::dispatchDidReplaceStateWithinPage): (WebKit::WebFrameLoaderClient::dispatchDidPopStateWithinPage):
WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::url):

5:19 PM Changeset in webkit [76871] by Adam Roben

3 edits in trunk/Source/WebKit/win

Fix scrollbars in Safari's Downloads window and Bookmarks view by implementing two needed functions from ScrollableArea.

Patch by Sam Weinig <sam@webkit.org> on 2011-01-27
Reviewed by Adam Roben.

WebScrollBar.cpp:

(WebScrollBar::horizontalScrollbar): Return the WebCore::Scrollbar if
we are a horizontal scrollbar.
(WebScrollBar::verticalScrollbar): Return the WebCore::Scrollbar if we
are a vertical scrollbar.

WebScrollBar.h:

5:18 PM Changeset in webkit [76870] by mrowe@apple.com

3 edits in branches/safari-533.20-branch/WebCore

Merge r68715.

5:10 PM Changeset in webkit [76869] by mrowe@apple.com

2 edits in branches/safari-533.20-branch/WebCore

Merge r61181.

5:07 PM Changeset in webkit [76868] by rniwa@webkit.org

2 edits
5 adds in trunk/LayoutTests

2011-01-27 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed rebaselines for Chromium Mac and Windows.

[chromium] fast/repaint/select-option-background-color.html fails on Windows and Mac
https://bugs.webkit.org/show_bug.cgi?id=53260

platform/chromium-mac/fast/repaint/select-option-background-color-expected.checksum: Added.
platform/chromium-mac/fast/repaint/select-option-background-color-expected.png: Added.
platform/chromium-win/fast/repaint/select-option-background-color-expected.checksum: Added.
platform/chromium-win/fast/repaint/select-option-background-color-expected.png: Added.
platform/chromium-win/fast/repaint/select-option-background-color-expected.txt: Added.
platform/chromium/test_expectations.txt:

5:02 PM Changeset in webkit [76867] by mrowe@apple.com

5 edits
1 add in branches/safari-533.20-branch

Merge r75851.

4:58 PM Changeset in webkit [76866] by senorblanco@chromium.org

3 edits in trunk/Source/WebCore

2011-01-27 Stephen White <senorblanco@chromium.org>

Reviewed by Darin Adler.

Fix performance regression in ImageQualityController::objectDestroyed().
https://bugs.webkit.org/show_bug.cgi?id=52645

In r72282, I inadvertently introduced this regression by using a
linear search through the hash map on object destruction. This was
because the hash key consisted of both object pointer and layer id,
but on object destruction we only know the object pointer, requiring
a search to find all the layers.
By replacing the hash map with two nested hash maps, where the outer key
is the object and the inner key is the layer, we can find all the
relevant data for an object in one hash lookup.

rendering/RenderBoxModelObject.cpp: Replace the (object,layer)->size HashMap with object->layer and layer->size HashMaps. (WebCore::ImageQualityController::isEmpty): Implement isEmpty() for the outer HashMap. (WebCore::ImageQualityController::removeLayer): When a layer is removed, remove it from the inner hash map. (WebCore::ImageQualityController::set): Implement set(): if the inner map exists, set the layer->size tuple directly. If not, create a new inner map, set the tuple, and insert it in the outer map. (WebCore::ImageQualityController::objectDestroyed): Look up the object in the outer map only. (WebCore::ImageQualityController::highQualityRepaintTimerFired): Cosmetic changes for the renamed now-outer hash map. (WebCore::ImageQualityController::shouldPaintAtLowQuality): Do both outer and inner hash map lookups. Call set() to add/update entries to the hash maps. keyDestroyed() is now removeLayer(). (WebCore::imageQualityController): Make the ImageQualityController a file-static global, so it can be created and destroyed on the fly. (WebCore::RenderBoxModelObject::~RenderBoxModelObject): If there is no ImageQualityController, don't call objectDestroyed(). If it's empty, delete it.
rendering/RenderImage.cpp: (WebCore::RenderImage::paintIntoRect): Also pass the Image* as the (void*) layer, since 0 is not a valid HashMap key.

4:55 PM Changeset in webkit [76865] by mrowe@apple.com

8 edits in branches/safari-533.20-branch

Merge r71426.

4:50 PM Changeset in webkit [76864] by enne@google.com

3 edits in trunk/Source/WebCore

2011-01-27 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Tiled compositor crashes if compositing turned off mid-paint
https://bugs.webkit.org/show_bug.cgi?id=53198

platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayers):
platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::update): (WebCore::LayerTilerChromium::draw):

4:49 PM Changeset in webkit [76863] by zmo@google.com

2 edits in trunk/Source/WebKit/chromium

2011-01-27 Zhenyao Mo <zmo@google.com>

Unreviewed, roll webkit chromium rev from 72673 to 72894.
Also, added gmock section in DEPS to pull down gmock.

DEPS:

4:36 PM Changeset in webkit [76862] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

2011-01-27 Alexey Marinichev <amarinichev@chromium.org>

Reviewed by Kenneth Russell.

Add a callback to WebGraphicsContext3D that is called when a context is lost
https://bugs.webkit.org/show_bug.cgi?id=53153

public/WebGraphicsContext3D.h: (WebKit::WebGraphicsContext3D::setContextLostCallback):

4:25 PM Changeset in webkit [76861] by mrowe@apple.com

6 edits
3 adds in branches/safari-533.20-branch

Merge r73623.

4:21 PM Changeset in webkit [76860] by commit-queue@webkit.org

5 edits in trunk/Tools

2011-01-27 Jacob Dinu <dinu.jacob@nokia.com>

Reviewed by Andreas Kling.

[Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView
https://bugs.webkit.org/show_bug.cgi?id=48440

Preserve user input when toggling use of QGraphicsView

QtTestBrowser/launcherwindow.cpp: (LauncherWindow::initializeView): (LauncherWindow::loadFinished):
QtTestBrowser/launcherwindow.h:
QtTestBrowser/mainwindow.cpp: (MainWindow::addressUrl):
QtTestBrowser/mainwindow.h:

4:14 PM Changeset in webkit [76859] by carol.szabo@nokia.com

5 edits in trunk/Source/WebCore

2011-01-27 Carol Szabo <carol.szabo@nokia.com>

Reviewed by David Hyatt.

A corrupted counter tree is created when renderers are added to the
tree bypassing RenderObject::addChild
https://bugs.webkit.org/show_bug.cgi?id=51270

No new tests. This patch reimplements the fix for bugs 43812 and
51637 and hence all tests are already there as part of the original
fixes for those bugs.

rendering/RenderCounter.cpp: (WebCore::findPlaceForCounter): Removed old workaround as this patch hopefully fixes the real problem.
rendering/RenderObject.cpp: (WebCore::RenderObject::addChild): Removed call to counter updater as it was moved to a lower level. (WebCore::RenderObject::destroy): Moved attached counter nodes destruction to after the node is removed from the tree.
rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::removeChildNode): (WebCore::RenderObjectChildList::appendChildNode): (WebCore::RenderObjectChildList::insertChildNode): Added notifications to the Counter system such that the CounterForest reflects the changes to the RendererTree.
rendering/RenderWidget.cpp: (WebCore::RenderWidget::destroy): Applied the same changes as for RenderObject::destroy() since RenderObject::destroy() is not called from here.

3:40 PM Changeset in webkit [76858] by Adam Roben

6 edits
1 copy
1 add in trunk/Source/WebCore

Add WKCACFViewLayerTreeHost

This is a class that derives from CACFLayerTreeHost and uses a WKCACFView to render.

Fixes <http://webkit.org/b/53251> <rdar://problem/8925496> CACFLayerTreeHost should use
WKCACFView for rendering

WebCore.vcproj/WebCore.vcproj: Added WKCACFViewLayerTreeHost.{cpp,h}.

platform/graphics/ca/win/CACFLayerTreeHost.cpp:

(WebCore::CACFLayerTreeHost::acceleratedCompositingAvailable): Make the test window have a
non-zero size. WKCACFView will always say it can't render if you pass it a 0-sized window,
so we need a non-empty window to perform a valid test.
(WebCore::CACFLayerTreeHost::create): First try to create a WKCACFViewLayerTreeHost, then
fall back to a LegacyCACFLayerTreeHost.
(WebCore::CACFLayerTreeHost::flushPendingLayerChangesNow): Moved code to react to the
context flush from here...
(WebCore::CACFLayerTreeHost::contextDidChange): ...to here. Derived classes are required to
call this function whenever changes are flushed to the context.

platform/graphics/ca/win/CACFLayerTreeHost.h: Added contextDidChange.

platform/graphics/ca/win/LegacyCACFLayerTreeHost.cpp:

(WebCore::LegacyCACFLayerTreeHost::createRenderer):
(WebCore::LegacyCACFLayerTreeHost::resize):
Changed to use flushContext instead of flushing the context manually so that we will always
notify the base class when the context gets flushed.

(WebCore::LegacyCACFLayerTreeHost::flushContext): Added a call to contextDidChange so the
base class will know what happened. Moved code to schedule a render from here...
(WebCore::LegacyCACFLayerTreeHost::contextDidChange): ...to here.

platform/graphics/ca/win/LegacyCACFLayerTreeHost.h: Added contextDidChange.

platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp: Added.

(WebCore::WKCACFViewLayerTreeHost::create): If WebKitQuartzCoreAdditions, which provides
WKCACFView, isn't present, bail. Otherwise allocate and return a new host.
(WebCore::WKCACFViewLayerTreeHost::WKCACFViewLayerTreeHost): Initialize members.
(WebCore::WKCACFViewLayerTreeHost::updateViewIfNeeded): Update the view if we previously
marked that we needed to do so, and flush the context if our layer's bounds have changed.
(WebCore::WKCACFViewLayerTreeHost::contextDidChangeCallback): Call through to
contextDidChange.
(WebCore::WKCACFViewLayerTreeHost::contextDidChange): Tell the WKCACFView to start rendering
(if we didn't already), then call up to the base class.
(WebCore::WKCACFViewLayerTreeHost::initializeContext): Set the context's user data, the
view's layer, and hook up our "context did change" callback.
(WebCore::WKCACFViewLayerTreeHost::resize): Mark that the view needs to be updated the next
time we paint.
(WebCore::WKCACFViewLayerTreeHost::createRenderer): Update our view and return whether it is
able to render or not.
(WebCore::WKCACFViewLayerTreeHost::destroyRenderer): Clear out all the info we passed down
to the view.
(WebCore::WKCACFViewLayerTreeHost::lastCommitTime): Call through to the view.
(WebCore::WKCACFViewLayerTreeHost::flushContext): Ditto.
(WebCore::WKCACFViewLayerTreeHost::paint): Update the view so it will draw at the right
size, then call up to the base class.
(WebCore::WKCACFViewLayerTreeHost::render): Invalidate the view using the passed-in dirty
rects, then ask it to draw.

platform/graphics/ca/win/WKCACFViewLayerTreeHost.h: Copied from Source/WebCore/platform/graphics/ca/win/LegacyCACFLayerTreeHost.h.

3:40 PM Changeset in webkit [76857] by tony@chromium.org

2 edits in branches/chromium/648/LayoutTests

Merge 76816 - 2011-01-27 Charlie Reis <creis@chromium.org>

Reviewed by Mihai Parparita.

back-during-onload-hung-page.php causes Chromium WebKit bot to fail
https://bugs.webkit.org/show_bug.cgi?id=53220

Reduces the timeout on a script that shouldn't finish during a test.
This avoids problems in one of the Chromium WebKit builders.

http/tests/history/resources/back-during-onload-hung-page.php: Reduce timeout.

TBR=rniwa@webkit.org
Review URL: http://codereview.chromium.org/6280020

3:39 PM Changeset in webkit [76856] by Adam Roben

3 edits
2 adds in trunk/Source/WebCore

Move LegacyCACFLayerTreeHost into its own files

More preparation for <http://webkit.org/b/53251> <rdar://problem/8925496> CACFLayerTreeHost

Reviewed by Simon Fraser.

WebCore.vcproj/WebCore.vcproj: Added LegacyCACFLayerTreeHost.{cpp,h}.

platform/graphics/ca/win/CACFLayerTreeHost.cpp: Moved code from here to new files.

platform/graphics/ca/win/LegacyCACFLayerTreeHost.cpp: Added.
platform/graphics/ca/win/LegacyCACFLayerTreeHost.h: Added.

3:33 PM Changeset in webkit [76855] by mihaip@chromium.org

2 edits in trunk/Source/WebKit/chromium

2011-01-27 Mihai Parparita <mihaip@chromium.org>

Unreviewed, fixed upstream Chromium build

r76844 should have rolled back Chromium DEPS to 72673, not 72637.

DEPS:

3:29 PM Changeset in webkit [76854] by Patrick Gansterer

2 edits in trunk/Source/WebCore

2011-01-27 Patrick Gansterer <Patrick Gansterer>

Unreviewed WinCE build fix for r76824.

platform/wince/DragDataWinCE.cpp: (WebCore::DragData::dragDataMap):

3:26 PM Changeset in webkit [76853] by Adam Roben

3 edits in trunk/Source/WebCore

Split CACFLayerTreeHost into base and derived classes

The derived class, LegacyCACFLayerTreeHost, contains all the D3D-related code. A later patch
will add a new derived class that replaces the D3D code with a different rendering API.

For now, LegacyCACFLayerTreeHost lives in CACFLayerTreeHost.cpp. This keeps the diff a
little smaller. A later patch will move it to its own source files.

Preparation for <http://webkit.org/b/53251> <rdar://problem/8925496> CACFLayerTreeHost
should use WKCACFView for rendering

Reviewed by Simon Fraser.

platform/graphics/ca/win/CACFLayerTreeHost.cpp:

(WebCore::CACFLayerTreeHost::acceleratedCompositingAvailable): Clear the window before
destroying the host, as that is now the API contract that clients must fulfill.
(WebCore::LegacyCACFLayerTreeHost::create): Added. Simple creator.
(WebCore::CACFLayerTreeHost::create): Now instantiates a LegacyCACFLayerTreeHost. Calls the
new initialize function to perform initialization that has to happen after the vtable has
been set up.

(WebCore::LegacyCACFLayerTreeHost::LegacyCACFLayerTreeHost):
(WebCore::CACFLayerTreeHost::CACFLayerTreeHost):
(WebCore::LegacyCACFLayerTreeHost::initializeContext):
(WebCore::CACFLayerTreeHost::initialize):
Moved some initialization code from the CACFLayerTreeHost constructor into these new
functions.

(WebCore::LegacyCACFLayerTreeHost::~LegacyCACFLayerTreeHost): Added. Moved code here from
~CACFLayerTreeHost.
(WebCore::CACFLayerTreeHost::~CACFLayerTreeHost): Rather than clearing the window at this
point (which would be too late, since we won't be able to call into the derived class's
virtual functions), just assert that it has already been cleared (or was never set in the
first place).
(WebCore::LegacyCACFLayerTreeHost::createRenderer): Renamed from
CACFLayerTreeHost::createRenderer, and changed to use getters instead of accessing
CACFLayerTreeHost's data members directly.

(WebCore::LegacyCACFLayerTreeHost::destroyRenderer):
(WebCore::CACFLayerTreeHost::destroyRenderer):
Moved some code to the new LegacyCACFLayerTreeHost function.

(WebCore::LegacyCACFLayerTreeHost::resize):
(WebCore::LegacyCACFLayerTreeHost::renderTimerFired):
Moved these functions to LegacyCACFLayerTreeHost.

(WebCore::LegacyCACFLayerTreeHost::paint):
(WebCore::CACFLayerTreeHost::paint):
Moved some code to the new LegacyCACFLayerTreeHost function.

(WebCore::LegacyCACFLayerTreeHost::render):
(WebCore::LegacyCACFLayerTreeHost::renderSoon):
Moved these functions to LegacyCACFLayerTreeHost.

(WebCore::CACFLayerTreeHost::flushPendingLayerChangesNow): Moved code to flush the context
from here...
(WebCore::LegacyCACFLayerTreeHost::flushContext): ...to this new function.

(WebCore::LegacyCACFLayerTreeHost::lastCommitTime): Moved code to get the last commit time
to this new function...
(WebCore::CACFLayerTreeHost::notifyAnimationsStarted): ...from here.

(WebCore::LegacyCACFLayerTreeHost::initD3DGeometry):
(WebCore::LegacyCACFLayerTreeHost::resetDevice):
Moved these functions to LegacyCACFLayerTreeHost.

platform/graphics/ca/win/CACFLayerTreeHost.h: Made some functions virtual, removed some

members that have moved to LegacyCACFLayerTreeHost, added some getters used by
LegacyCACFLayerTreeHost.

3:25 PM Changeset in webkit [76852] by Adam Roben

9 edits
1 add in trunk/Source

Move CACFLayerTreeHostClient to its own header file

Rubber-stamped by Steve Falkenburg.

Source/WebCore:

WebCore.vcproj/WebCore.vcproj: Added CACFLayerTreeHostClient.h. Also let VS have its way

with the file.

platform/graphics/ca/win/CACFLayerTreeHost.cpp: Added new #include.

platform/graphics/ca/win/CACFLayerTreeHost.h: Removed CACFLayerTreeHostClient.

platform/graphics/ca/win/CACFLayerTreeHostClient.h: Added.

platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp: Moved some #includes here

from the header file.

platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h: Replaced broader #includes

with more specific ones, plus a forward-declaration.

Source/WebKit/win:

Trim down #includes in WebView.h

WebView.cpp: Moved some #includes here from the header file.

WebView.h: Replaced some broader #includes with more specific ones, plus a

forward-declaration.

3:23 PM Changeset in webkit [76851] by mrowe@apple.com

2 edits in branches/safari-533.20-branch/JavaScriptCore

Merge r72209.

3:23 PM Changeset in webkit [76850] by mrowe@apple.com

3 edits in branches/safari-533.20-branch/JavaScriptCore

Merge r69414.

3:23 PM Changeset in webkit [76849] by mrowe@apple.com

7 edits in branches/safari-533.20-branch

Merge r72114.

3:23 PM Changeset in webkit [76848] by mrowe@apple.com

4 edits in branches/safari-533.20-branch

Merge r71867.

3:23 PM Changeset in webkit [76847] by mrowe@apple.com

2 edits in branches/safari-533.20-branch/JavaScriptCore

Merge r65920.

3:20 PM Changeset in webkit [76846] by krit@webkit.org

4 edits in trunk/LayoutTests

2011-01-27 Dirk Schulze <krit@webkit.org>

Unreviewed rebaseline.

SVG animation of Paths with segments of different coordinate modes on begin and end
https://bugs.webkit.org/show_bug.cgi?id=52984

Rebaseline for SL. HTML were created by make-script-test-wrappers now.
Skip added tests on WebKit2 because of missing eventSender.

platform/mac-wk2/Skipped:
svg/animations/animate-path-nested-transforms-expected.txt:
svg/animations/animate-text-nested-transforms-expected.txt:

3:03 PM Changeset in webkit [76845] by simonjam@chromium.org

2 edits in trunk/Source/WebCore

2011-01-27 James Simonsen <simonjam@chromium.org>

Reviewed by Tony Chang.

[Chromium] Simplify small caps logic in complex text on linux
https://bugs.webkit.org/show_bug.cgi?id=53207

Test: fast/text/atsui-multiple-renderers.html

fast/text/atsui-small-caps-punctuation-size.html

platform/graphics/chromium/ComplexTextControllerLinux.cpp: (WebCore::ComplexTextController::nextScriptRun): Remove redundant logic. Case changes in a text run imply FontData changes. (WebCore::ComplexTextController::setupFontForScriptRun): Update comment to reflect above.

2:59 PM Changeset in webkit [76844] by zmo@google.com

2 edits in trunk/Source/WebKit/chromium

2011-01-27 Zhenyao Mo <zmo@google.com>

Unreviewed, roll back webkit chromium rev to 72637.

DEPS:

2:50 PM Changeset in webkit [76843] by abarth@webkit.org

2 edits in trunk/Source/WebCore

2011-01-27 Adam Barth <abarth@webkit.org>

In which I attempt to fix the EFL build.

CMakeLists.txt:

2:43 PM Changeset in webkit [76842] by mihaip@chromium.org

3 edits in trunk/LayoutTests

2011-01-27 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium rebaseline for fast/text/text-letter-spacing.html
with changes matching the mac ones done by r76739.

platform/chromium-win/fast/text/text-letter-spacing-expected.txt:
platform/chromium/test_expectations.txt:

2:39 PM Changeset in webkit [76841] by mrowe@apple.com

13 edits in branches/safari-533.20-branch

Merge r74887.

2:38 PM Changeset in webkit [76840] by zmo@google.com

2 edits in trunk/Source/WebKit/chromium

2011-01-27 Zhenyao Mo <zmo@google.com>

Unreviewed.

Roll Webkit Chromium rev from 72637 to 72868.

DEPS:

2:38 PM Changeset in webkit [76839] by leviw@chromium.org

4 edits
8 adds in trunk

2011-01-25 Levi Weintraub <leviw@chromium.org>

Reviewed by Darin Adler.

Updating the expected result for 5408255 and adding tests for caret positioning at the
beginning and end of RenderBoxes.

Undo moves caret to invalid position
https://bugs.webkit.org/show_bug.cgi?id=49744

editing/selection/caret-painting-after-paste-undo-rtl.html: Added.
editing/selection/caret-painting-after-paste-undo.html: Added.
platform/mac/editing/deleting/5408255-expected.png:
platform/mac/editing/selection/caret-painting-after-paste-undo-expected.checksum: Added.
platform/mac/editing/selection/caret-painting-after-paste-undo-expected.png: Added.
platform/mac/editing/selection/caret-painting-after-paste-undo-expected.txt: Added.
platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.checksum: Added.
platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.png: Added.
platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.txt: Added.

2011-01-25 Levi Weintraub <leviw@chromium.org>

Reviewed by Darin Adler.

Adding border and padding to the calculation of the local caret rect for RenderBoxes.
Corrected for mistake in r76625

Undo moves caret to invalid position
https://bugs.webkit.org/show_bug.cgi?id=49744

Tests: editing/selection/caret-painting-after-paste-undo-rtl.html

editing/selection/caret-painting-after-paste-undo.html

rendering/RenderBox.cpp: (WebCore::RenderBox::localCaretRect):

2:30 PM Changeset in webkit [76838] by rniwa@webkit.org

2 edits
3 adds in trunk/LayoutTests

2011-01-27 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium rebaseline and text expectation update.

platform/chromium-linux/fast/repaint/select-option-background-color-expected.checksum: Added.
platform/chromium-linux/fast/repaint/select-option-background-color-expected.png: Added.
platform/chromium-linux/fast/repaint/select-option-background-color-expected.txt: Added.
platform/chromium/test_expectations.txt:

2:13 PM Changeset in webkit [76837] by mihaip@chromium.org

4 edits in trunk/LayoutTests

2011-01-27 Mihai Parparita <mihaip@chromium.org>

Unreviewed rebaseline of fast/inline/continuation-outlines-with-layers.html
afte r76726.

platform/mac/fast/inline/continuation-outlines-with-layers-expected.txt:
platform/chromium-win/fast/inline/continuation-outlines-with-layers-expected.txt:
platform/chromium/test_expectations.txt:

2:02 PM Changeset in webkit [76836] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

2011-01-27 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76825.
http://trac.webkit.org/changeset/76825
https://bugs.webkit.org/show_bug.cgi?id=53256

"caused crashes on GTK and chromium" (Requested by rniwa on
#webkit).

rendering/RenderBoxModelObject.cpp: (WebCore::ImageQualityController::keyDestroyed): (WebCore::ImageQualityController::objectDestroyed): (WebCore::ImageQualityController::highQualityRepaintTimerFired): (WebCore::ImageQualityController::shouldPaintAtLowQuality): (WebCore::imageQualityController): (WebCore::RenderBoxModelObject::~RenderBoxModelObject):

1:52 PM Changeset in webkit [76835] by abarth@webkit.org

14 edits
2 adds in trunk/Source/WebCore

2011-01-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Generalize the mechanism view-source uses to remember the source for an HTMLToken
https://bugs.webkit.org/show_bug.cgi?id=53200

Currently view-source tracks the source associated with each HTMLToken.
We want to re-use this mechanism for the new XSS auditor. This patch
moves this code into its own class so it can be shared between the
view-source parser and the general HTML parser. This patch also add
support for tracking the source of tokens that span document.write
boundaries.

No functional change. This code change is somewhat tested by our
view-source layout tests.

Android.mk:
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
- Fun with updating build files.
html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::pumpTokenizer):
- Teach HTMLDocumentParser to track the source for HTMLTokens. Currently, this information isn't used, but it will be shortly. I ran the HTML parser benchmark and this change didn't have a measurable effect.
html/parser/HTMLDocumentParser.h:
- Composite in the HTMLSourceTracker.
html/parser/HTMLSourceTracker.cpp: Added. (WebCore::HTMLSourceTracker::HTMLSourceTracker): (WebCore::HTMLSourceTracker::start): (WebCore::HTMLSourceTracker::end):
- This function should eventualy be folded into HTMLTokenizer.

(WebCore::HTMLSourceTracker::sourceForToken):

html/parser/HTMLSourceTracker.h: Added.
html/parser/HTMLToken.h:
- Now HTMLTokens always have a start index of zero. To do the job of the old start index, this patch introduces the notion of a baseOffset. Unlike the start index (which was used as the base offset for all the other indicies), the baseOffset can change over the lifetime of the token. We need the flexibility to change the offset for tokens that span document.write boundaries. Values are now normalized to zero-offset when stored.

(WebCore::HTMLToken::clear):
(WebCore::HTMLToken::setBaseOffset):
(WebCore::HTMLToken::end):
(WebCore::HTMLToken::beginAttributeName):
(WebCore::HTMLToken::endAttributeName):
(WebCore::HTMLToken::beginAttributeValue):
(WebCore::HTMLToken::endAttributeValue):

html/parser/HTMLViewSourceParser.cpp:
- Updates the HTMLViewSourceParser to use the new HTMLSourceTracker.

(WebCore::HTMLViewSourceParser::pumpTokenizer):
(WebCore::HTMLViewSourceParser::append):
(WebCore::HTMLViewSourceParser::sourceForToken):

This function now just calls through to HTMLSourceTracker.

html/parser/HTMLViewSourceParser.h:
platform/text/SegmentedString.cpp: (WebCore::SegmentedString::currentColumn): (WebCore::SegmentedString::setCurrentPosition):
platform/text/SegmentedString.h: (WebCore::SegmentedString::numberOfCharactersConsumed):
- We need to handle the general case now. The "slow" version doesn't turn out to be any slower in practice anyway.

1:45 PM Changeset in webkit [76834] by robert@webkit.org

2 edits in trunk/Source/WebKit/qt

2011-01-27 Robert Hogan <robert@webkit.org>

Rubber-stamped by Andreas Kling.

[Qt] Style Fix: correct indentation in FrameLoadeClientQt:createPlugin

WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createPlugin):

1:35 PM Changeset in webkit [76833] by weinig@apple.com

2 edits in trunk/Source/WebKit2

2011-01-27 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Encode/Decode hasPreciseScrollingDeltas bit in WebWheelEvent
https://bugs.webkit.org/show_bug.cgi?id=53254

Shared/WebWheelEvent.cpp: (WebKit::WebWheelEvent::WebWheelEvent): Initialize m_phase and m_hasPreciseScrollingDeltas.

(WebKit::WebWheelEvent::encode):
(WebKit::WebWheelEvent::decode):
Add missing coding for m_hasPreciseScrollingDeltas.

1:32 PM Changeset in webkit [76832] by weinig@apple.com

2 edits in trunk/Source/WebCore

Fix all the builds.

platform/ScrollView.cpp:

(WebCore::ScrollView::paintOverhangAreas): Add parameters.

1:23 PM Changeset in webkit [76831] by weinig@apple.com

5 edits in trunk/Source/WebCore

Add ability to do an unconstrained scroll on a ScrollView
https://bugs.webkit.org/show_bug.cgi?id=53249

Reviewed by Dave Hyatt.

platform/ScrollView.cpp:

(WebCore::ScrollView::ScrollView):
Initialize m_constrainsScrollingToContentEdge to true.

(WebCore::ScrollView::setScrollOffset):
Only constrain the offset if the m_constrainsScrollingToContentEdge is set.

(WebCore::ScrollView::updateScrollbars):
Simplify expression converting an IntSize to an IntPoint.

(WebCore::ScrollView::paint):
Paint the overhang if there is any.

(WebCore::ScrollView::calculateOverhangAreasForPainting):
Calculate the overhang in viewport coordinates for painting.

platform/ScrollView.h:

(WebCore::ScrollView::constrainsScrollingToContentEdge):
(WebCore::ScrollView::setConstrainsScrollingToContentEdge):
Add bit to control whether the scroll position should be constrained
to the content edge when set.

platform/ScrollbarThemeComposite.cpp:

(WebCore::usedTotalSize):
(WebCore::ScrollbarThemeComposite::thumbPosition):
(WebCore::ScrollbarThemeComposite::thumbLength):

platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::paint):
Improve calculations of thumb size and position to take overhang into account.

1:11 PM QtWebKitSecurity created by Ademar Reis

1:03 PM Changeset in webkit [76830] by krit@webkit.org

7 edits
18 adds in trunk

2011-01-27 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG animation of Paths with segments of different coordinate modes on begin and end
https://bugs.webkit.org/show_bug.cgi?id=52984

Added tests to check the correct behavior on path animations, where the coordinate modes
of the start path differs from the one on the end path.

svg/animations/animate-path-animation-Cc-Ss-expected.txt: Added.
svg/animations/animate-path-animation-Cc-Ss.html: Added.
svg/animations/animate-path-animation-Ll-Vv-Hh-expected.txt: Added.
svg/animations/animate-path-animation-Ll-Vv-Hh.html: Added.
svg/animations/animate-path-animation-Qq-Tt-expected.txt: Added.
svg/animations/animate-path-animation-Qq-Tt.html: Added.
svg/animations/animate-path-animation-cC-sS-inverse-expected.txt: Added.
svg/animations/animate-path-animation-cC-sS-inverse.html: Added.
svg/animations/animate-path-animation-lL-vV-hH-inverse-expected.txt: Added.
svg/animations/animate-path-animation-lL-vV-hH-inverse.html: Added.
svg/animations/animate-path-animation-qQ-tT-inverse-expected.txt: Added.
svg/animations/animate-path-animation-qQ-tT-inverse.html: Added.
svg/animations/animate-path-nested-transforms.html: Cleanup.
svg/animations/animate-text-nested-transforms.html: Cleanup.
svg/animations/resources/SVGAnimationTestCase.js: (shouldBeCloseEnough): For debug output of values with tolerance level. (startTest): (sampleAnimation):
svg/animations/script-tests/animate-path-animation-Cc-Ss.js: Added. (sample1): (sample2): (sample3): (sample4): (executeTest):
svg/animations/script-tests/animate-path-animation-Ll-Vv-Hh.js: Added. (sample1): (sample2): (sample3): (sample4): (executeTest):
svg/animations/script-tests/animate-path-animation-Qq-Tt.js: Added. (sample1): (sample2): (sample3): (sample4): (executeTest):
svg/animations/script-tests/animate-path-animation-cC-sS-inverse.js: Added. (sample1): (sample2): (sample3): (sample4): (executeTest):
svg/animations/script-tests/animate-path-animation-lL-vV-hH-inverse.js: Added. (sample1): (sample2): (sample3): (sample4): (executeTest):
svg/animations/script-tests/animate-path-animation-qQ-tT-inverse.js: Added. (sample1): (sample2): (sample3): (sample4): (executeTest):

2011-01-27 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG animation of Paths with segments of different coordinate modes on begin and end
https://bugs.webkit.org/show_bug.cgi?id=52984

At the moment we just support SVG path animations, if the number of segments on the given start path
is the same as the number of segments on the given end path. But a segment on a given position must be identical
on both paths as well. Not only the segment type, also the coordinate mode of the segments must be identical.
If MoveToRel is on the second position on the start path a MoveToRel must be on the second position
of the end path too. According to the SVG spec, at least the coordinate mode can differ. Means, if we have MoveToRel
in the start path, we can use MoveToAbs on the same position in the end path.

This patch fixes the blending code to follow the spec here. It was necessary to track the current position of
both paths, transform coordinates to the same coordinate mode and transform the resulting animation coordinate back
to the coordinate mode of either the start or the end path. Which mode is taken depends on the progress of the
animation.

Tests: svg/animations/animate-path-animation-Cc-Ss.html

svg/animations/animate-path-animation-Ll-Vv-Hh.html
svg/animations/animate-path-animation-Qq-Tt.html
svg/animations/animate-path-animation-cC-sS-inverse.html
svg/animations/animate-path-animation-lL-vV-hH-inverse.html
svg/animations/animate-path-animation-qQ-tT-inverse.html

svg/SVGPathBlender.cpp: (WebCore::blendFloatPoint): (WebCore::blendAnimatedFloat): (WebCore::SVGPathBlender::blendAnimatedDimensionalFloat): (WebCore::SVGPathBlender::blendAnimatedFloatPoint): (WebCore::SVGPathBlender::blendMoveToSegment): (WebCore::SVGPathBlender::blendLineToSegment): (WebCore::SVGPathBlender::blendLineToHorizontalSegment): (WebCore::SVGPathBlender::blendLineToVerticalSegment): (WebCore::SVGPathBlender::blendCurveToCubicSegment): (WebCore::SVGPathBlender::blendCurveToCubicSmoothSegment): (WebCore::SVGPathBlender::blendCurveToQuadraticSegment): (WebCore::SVGPathBlender::blendCurveToQuadraticSmoothSegment): (WebCore::SVGPathBlender::blendArcToSegment): (WebCore::coordinateModeOfCommand): (WebCore::isSegmentEqual): (WebCore::SVGPathBlender::blendAnimatedPath): (WebCore::SVGPathBlender::cleanup):
svg/SVGPathBlender.h:

12:53 PM Changeset in webkit [76829] by dpranke@chromium.org

4 edits in trunk/Tools

2011-01-27 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

new-run-webkit-tests: turn off pixel tests correctly by default
for webkit-based ports. r70013 (bug 47510) used
port.set_option_default() to attempt to set default values, but
that didn't work correctly. I have removed set_option_default
for now since it was only being used in two places and in three
useless unit tests. There is a separate bug open to fix the
option parsing (48095), so this workaround is fine for now.

https://bugs.webkit.org/show_bug.cgi?id=53217

Scripts/webkitpy/layout_tests/port/webkit.py:
Scripts/webkitpy/layout_tests/port/base.py:
Scripts/webkitpy/layout_tests/port/base_unittest.py:

12:47 PM Changeset in webkit [76828] by jschuh@chromium.org

4 edits
2 adds in trunk

2011-01-27 Cris Neckar <cdn@chromium.org>

Reviewed by Dimitri Glazkov.

Clear the parent on a css keyframe's m_style when removing it from the stylesheet.
https://bugs.webkit.org/show_bug.cgi?id=52320

Test: fast/css/css-keyframe-style-crash.html

css/CSSRuleList.cpp: (WebCore::CSSRuleList::deleteRule):
css/WebKitCSSKeyframesRule.cpp: (WebCore::WebKitCSSKeyframesRule::~WebKitCSSKeyframesRule):

2011-01-27 Cris Neckar <cdn@chromium.org>

Reviewed by Dimitri Glazkov.

Test for crash when accessing a keyframe's style rule.
https://bugs.webkit.org/show_bug.cgi?id=52320

fast/css/css-keyframe-style-crash-expected.txt: Added.
fast/css/css-keyframe-style-crash.html: Added.

12:28 PM Changeset in webkit [76827] by rniwa@webkit.org

2 edits in trunk/LayoutTests

2011-01-27 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium text expectation update.

platform/chromium/test_expectations.txt: Apparently, video-size.html crashes on Linux due to crbug.com/71087.

12:02 PM Changeset in webkit [76826] by rwlbuis@webkit.org

3 edits
4 adds in trunk

2011-01-27 Rob Buis <rwlbuis@gmail.com>

Reviewed by Kent Tamura.

Color changes to option elements in a select multiple aren't drawn immediately
https://bugs.webkit.org/show_bug.cgi?id=49790

Redirect style changes on <option> element to the owner <select> element.

Test: fast/repaint/select-option-background-color.html

html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::setRenderStyle):

11:58 AM Changeset in webkit [76825] by senorblanco@chromium.org

2 edits in trunk/Source/WebCore

2011-01-19 Stephen White <senorblanco@chromium.org>

Reviewed by Darin Adler.

Fix performance regression in ImageQualityController::objectDestroyed().
https://bugs.webkit.org/show_bug.cgi?id=52645

In r72282, I inadvertently introduced this regression by using a
linear search through the hash map on object destruction. This was
because the hash key consisted of both object pointer and layer id,
but on object destruction we only know the object pointer, requiring
a search to find all the layers.
By replacing the hash map with two nested hash maps, where the outer key
is the object and the inner key is the layer, we can find all the
relevant data for an object in one hash lookup.

rendering/RenderBoxModelObject.cpp: Replace the (object,layer)->size HashMap with object->layer and layer->size HashMaps. (WebCore::ImageQualityController::isEmpty): Implement isEmpty() for the outer HashMap. (WebCore::ImageQualityController::removeLayer): When a layer is removed, remove it from the inner hash map. (WebCore::ImageQualityController::set): Implement set(): if the inner map exists, set the layer->size tuple directly. If not, create a new inner map, set the tuple, and insert it in the outer map. (WebCore::ImageQualityController::objectDestroyed): Look up the object in the outer map only. (WebCore::ImageQualityController::highQualityRepaintTimerFired): Cosmetic changes for the renamed now-outer hash map. (WebCore::ImageQualityController::shouldPaintAtLowQuality): Do both outer and inner hash map lookups. Call set() to add/update entries to the hash maps. keyDestroyed() is now removeLayer(). (WebCore::imageQualityController): Make the ImageQualityController a file-static global, so it can be created and destroyed on the fly. (WebCore::RenderBoxModelObject::~RenderBoxModelObject): If there is no ImageQualityController, don't call objectDestroyed(). If it's empty, delete it.

11:51 AM Changeset in webkit [76824] by enrica@apple.com

15 edits in trunk/Source

Source/WebCore: WebKit2: add support for drag and drop on Windows
https://bugs.webkit.org/show_bug.cgi?id=52775
<rdar://problem/8514409>

Reviewed by Darin Adler and Adam Roben.

On Windows the access to the content being dragged is
provided via the IDataObject interface that is made available
to the window that registers itself as drop target.
Since this interface cannot be accessed from the WebProcess,
in every call to one of the methods of the IDropTarget interface
we serialize the content of the drag clipboard and send it over to
the WebProcess.
The bulk of this patch consists in the refactoring needed in DragData
and ClipboardWin classes to extract the data from the serialized object.

platform/DragData.cpp:
platform/DragData.h:
platform/win/ClipboardUtilitiesWin.cpp:

(WebCore::getWebLocData):
(WebCore::getURL):
(WebCore::getPlainText):
(WebCore::getTextHTML):
(WebCore::getCFHTML):
(WebCore::fragmentFromFilenames):
(WebCore::containsFilenames):
(WebCore::fragmentFromHTML):
(WebCore::containsHTML):
(WebCore::getClipboardData):

platform/win/ClipboardUtilitiesWin.h:
platform/win/ClipboardWin.cpp:

(WebCore::Clipboard::create):
(WebCore::ClipboardWin::ClipboardWin):
(WebCore::ClipboardWin::getData):
(WebCore::ClipboardWin::types):
(WebCore::ClipboardWin::files):
(WebCore::ClipboardWin::hasData):

platform/win/ClipboardWin.h:

(WebCore::ClipboardWin::create):

platform/win/DragDataWin.cpp:

(WebCore::DragData::DragData):
(WebCore::DragData::containsURL):
(WebCore::DragData::dragDataMap):
(WebCore::DragData::asURL):
(WebCore::DragData::containsFiles):
(WebCore::DragData::asFilenames):
(WebCore::DragData::containsPlainText):
(WebCore::DragData::asPlainText):
(WebCore::DragData::canSmartReplace):
(WebCore::DragData::containsCompatibleContent):
(WebCore::DragData::asFragment):

Source/WebKit2: WebKit2: add support for drag and drop on Windows
https://bugs.webkit.org/show_bug.cgi?id=52775
<rdar://problem/8514409>

Reviewed by Darin Adler and Adam Roben.

On Windows the access to the content being dragged is
provided via the IDataObject interface that is made available
to the window that registers itself as drop target.
Since this interface cannot be accessed from the WebProcess,
in every call to one of the methods of the IDropTarget interface
we serialize the content of the drag clipboard and send it over to
the WebProcess. The implementation uses the same messages as the
Mac one, with slightly different parameters to pass the serialized
clipboard.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::performDragControllerAction): Added Windows
specific implementation.

UIProcess/WebPageProxy.h:
UIProcess/win/WebView.cpp:

(WebKit::WebView::WebView): Added dropTargetHelper object creation.
(WebKit::WebView::initialize): Added to register for drag/drop with out
refcount issues.
(WebKit::WebView::close):
(WebKit::WebView::windowReceivedMessage):
(WebKit::WebView::QueryInterface):
(WebKit::WebView::AddRef):
(WebKit::WebView::Release):
(WebKit::dragOperationToDragCursor):
(WebKit::WebView::keyStateToDragOperation):
(WebKit::WebView::DragEnter):
(WebKit::WebView::DragOver):
(WebKit::WebView::DragLeave):
(WebKit::WebView::Drop):

UIProcess/win/WebView.h:

(WebKit::WebView::create):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::performDragControllerAction):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

11:44 AM Changeset in webkit [76823] by estade@chromium.org

2 edits in branches/chromium/648/Source/WebCore

Merge 76637 - 2011-01-25 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Empty URLs are never display isolated
https://bugs.webkit.org/show_bug.cgi?id=53053

This check mirrors the check in the local case. There isn't a good way
to test this with a LayoutTest, but it is tested in Chromium (where
this registry is used).

platform/SchemeRegistry.cpp: (WebCore::SchemeRegistry::shouldTreatURLSchemeAsDisplayIsolated):

TBR=abarth@webkit.org
Review URL: http://codereview.chromium.org/6312016

11:38 AM Changeset in webkit [76822] by mario@webkit.org

4 edits in trunk/Source

2011-01-27 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Space characters in source document interfere with reported caret offset
https://bugs.webkit.org/show_bug.cgi?id=53033

Calculate caret offset from rendered text instead of from node contents.

accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (objectAndOffsetUnignored): Calculate the caret offset based only on positions and ranges, instead of using the computed offset in the container node.

2011-01-27 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Space characters in source document interfere with reported caret offset
https://bugs.webkit.org/show_bug.cgi?id=53033

New unit test to check the fix for this bug.

tests/testatk.c: (testWebkitAtkCaretOffsetsAndExtranousWhiteSpaces): New. (main): Add new unit test.

11:36 AM Changeset in webkit [76821] by ap@apple.com

14 edits in trunk/Source

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=53197
<rdar://problem/8895682> Make WebKit2 printing asynchronous

<rdar://problem/8899988> REGRESSION(WebKit2): Attempting to print WHATWG HTML spec shows
1-page blank preview

<rdar://problem/8900078> WebKit2 printing has a separate message exchange per page when
printing instead of printing all at once

UIProcess/API/mac/WKPrintingView.h: Store a lot more cached information.

UIProcess/API/mac/WKPrintingView.mm: (-[WKPrintingView _adjustPrintingMarginsForHeaderAndFooter]): Use PrintOperation stored in class. We generally want that now, because current operation will not be set up on other threads. (-[WKPrintingView _isPrintingPreview]): Added. Preview is different, because it can draw a placeholder - but actual printing need to wait until UI process has data. (-[WKPrintingView _updatePreview]): Force AppKit to update print preview when we have real data to replace placeholder with. (-[WKPrintingView _hasPageRects]): Return if page rects have already been computed. (-[WKPrintingView _expectedPreviewCallbackForRect:]): Find an existing request for this rect, if any. (pageDidDrawToPDF): Update preview - or if actually printing, release control to printing thread. (-[WKPrintingView _preparePDFDataForPrintingOnSecondaryThread]): Ask for a PDF document with pages the user asked to print. (pageDidComputePageRects): When web process returns page geometry data, we update preview to display a page count (which indirectly triggers a request for a preview). When actually printing, request a PDF right away, we'll need it later. (-[WKPrintingView _askPageToComputePageRects]): Ask web process for page geometry. (prepareDataForPrintingOnSecondaryThread): This function starts preparing all data necessary for actual printing on main thread. (-[WKPrintingView knowsPageRange:]): Changed to be async for preview, and to call main thread for actual printing. (-[WKPrintingView _pageForRect:]): Find page number for a given range, assuming that AppKit always asks for full pages. (-[WKPrintingView _drawPDFDocument:page:atPoint:]): A helper function to draw a PDF document. (-[WKPrintingView _drawPreview:]): Draw the whole page for preview. (-[WKPrintingView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]): Draw the whole page for actual printing. (-[WKPrintingView _drawPageBorderWithSizeOnMainThread:]): Call drawPageBorderWithSize: with correct graphics context and print operation. (-[WKPrintingView drawPageBorderWithSize:]): Delegate work to main thread when called from a secondary one. (-[WKPrintingView _provideTotalScaleFactorForPrintOperation:]): Added an assertion that our stored NSPrintOperation isn't out of sync with reality. (-[WKPrintingView rectForPage:]): Handle the case where we don't have the data yet, drawing a placeholder. (-[WKPrintingView endDocument]): When page setup changes, we must reset all state.

UIProcess/API/mac/WKView.mm: (-[WKView printOperationWithPrintInfo:forFrame:]): Tell NSPrintingView which operation it's serving, so that it knows it even when current operation isn't set.

UIProcess/GenericCallback.h: (WebKit::ComputedPagesCallback::create): (WebKit::ComputedPagesCallback::~ComputedPagesCallback): (WebKit::ComputedPagesCallback::performCallbackWithReturnValue): (WebKit::ComputedPagesCallback::invalidate): (WebKit::ComputedPagesCallback::callbackID): (WebKit::ComputedPagesCallback::generateCallbackID): (WebKit::ComputedPagesCallback::ComputedPagesCallback): Added ComputedPagesCallback, which returns a vector of IntRects and a double. Hopefully, it will become a specialization of GenericCallback one day.

UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::close): Added m_voidCallbacks - it looks like they were omitted by accident. (WebKit::WebPageProxy::computedPagesCallback): Added. (WebKit::WebPageProxy::processDidCrash): Added m_computedPagesCallbacks. (WebKit::WebPageProxy::computePagesForPrinting): Async now! (WebKit::WebPageProxy::drawRectToPDF): Ditto. (WebKit::WebPageProxy::drawPagesToPDF): Added.
UIProcess/WebPageProxy.h:

UIProcess/WebPageProxy.messages.in: Added ComputedPagesCallback.

WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::beginPriting): Compute page rects right away - we'll need them in drawPagesToPDF(), which doesn't have a PrintInfo. (WebKit::WebPage::computePagesForPrinting): Send async response. (WebKit::WebPage::drawRectToPDF): This function used to draw into original location at frame coordinates, and now it draws at (0, 0). (WebKit::WebPage::drawPagesToPDF): Added - make a multi-page PDF.
WebProcess/WebPage/WebPage.h:

WebProcess/WebPage/WebPage.messages.in: Added DrawPagesToPDF.

11:24 AM Changeset in webkit [76820] by jorlow@chromium.org

5 edits
2 adds in trunk

2011-01-27 David Grogan <dgrogan@google.com>

Reviewed by Jeremy Orlow.

initial support for close() in indexeddb backend
https://bugs.webkit.org/show_bug.cgi?id=53150

storage/indexeddb/transaction-after-close-expected.txt: Added.
storage/indexeddb/transaction-after-close.html: Added.

2011-01-27 David Grogan <dgrogan@google.com>

Reviewed by Jeremy Orlow.

initial support for close() in indexeddb backend
https://bugs.webkit.org/show_bug.cgi?id=53150

Test: storage/indexeddb/transaction-after-close.html

storage/IDBDatabase.cpp: (WebCore::IDBDatabase::IDBDatabase): (WebCore::IDBDatabase::transaction): (WebCore::IDBDatabase::close):
storage/IDBDatabase.h:
storage/IDBDatabase.idl:
storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::transaction): (WebCore::IDBDatabaseBackendImpl::close):

11:23 AM Changeset in webkit [76819] by krit@webkit.org

3 edits
6 adds in trunk

2011-01-27 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG animation doesn't support calcMode discrete for number and color values.
https://bugs.webkit.org/show_bug.cgi?id=53189

Add support for calcMode discrete on number and color animation.

Tests: svg/animations/animate-color-calcMode-discrete.html

svg/animations/animate-number-calcMode-discrete.html

svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::calculateAnimatedValue):

2011-01-27 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG animation doesn't support calcMode discrete for number and color values.
https://bugs.webkit.org/show_bug.cgi?id=53189

Test for correct behavior on animating numbers and colors with calcMode discrete.

svg/animations/animate-color-calcMode-discrete-expected.txt: Added.
svg/animations/animate-color-calcMode-discrete.html: Added.
svg/animations/animate-number-calcMode-discrete-expected.txt: Added.
svg/animations/animate-number-calcMode-discrete.html: Added.
svg/animations/script-tests/animate-color-calcMode-discrete.js: Added. (sample1): (sample2): (executeTest):
svg/animations/script-tests/animate-number-calcMode-discrete.js: Added. (sample1): (sample2): (executeTest):

11:18 AM Changeset in webkit [76818] by rniwa@webkit.org

2 edits in trunk/LayoutTests

2011-01-27 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium test expectation update for video tests.

platform/chromium/test_expectations.txt:

11:16 AM Changeset in webkit [76817] by alex

2 edits in trunk/Source/WebKit2

2011-01-27 Alejandro G. Castro <alex@igalia.com>

Unreviewed GTK build fix after r76797.

Shared/WebPreferencesStore.h: Use Qt fonts preference for the moment.

11:11 AM Changeset in webkit [76816] by rniwa@webkit.org

2 edits in trunk/LayoutTests

2011-01-27 Charlie Reis <creis@chromium.org>

Reviewed by Mihai Parparita.

back-during-onload-hung-page.php causes Chromium WebKit bot to fail
https://bugs.webkit.org/show_bug.cgi?id=53220

Reduces the timeout on a script that shouldn't finish during a test.
This avoids problems in one of the Chromium WebKit builders.

http/tests/history/resources/back-during-onload-hung-page.php: Reduce timeout.

11:05 AM Changeset in webkit [76815] by mitz@apple.com

2 edits in trunk/Source/WebKit2

Allow pop-up menus to contain multiple items that have the same title.

Reviewed by Anders Carlsson.

UIProcess/mac/WebPopupMenuProxyMac.mm:

(WebKit::WebPopupMenuProxyMac::populate): Set the item’s title after adding it rather than
when adding it, so that it will not replace any existing item with the same title.

10:58 AM Changeset in webkit [76814] by zmo@google.com

5 edits
2 adds in trunk

2011-01-26 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

shaderSource needs to preserve original source
https://bugs.webkit.org/show_bug.cgi?id=52833

fast/canvas/webgl/gl-getshadersource-expected.txt: Added.
fast/canvas/webgl/gl-getshadersource.html: Added.

2011-01-26 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

shaderSource needs to preserve original source
https://bugs.webkit.org/show_bug.cgi?id=52833

Test: fast/canvas/webgl/gl-getshadersource.html

html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getShaderParameter): Intercept SHADER_SOURCE_LENGTH. (WebCore::WebGLRenderingContext::getShaderSource): Intercept the call. (WebCore::WebGLRenderingContext::shaderSource): Cache the source.
html/canvas/WebGLShader.cpp: Cache shader source. (WebCore::WebGLShader::WebGLShader):
html/canvas/WebGLShader.h: Ditto. (WebCore::WebGLShader::getSource): (WebCore::WebGLShader::setSource):

10:52 AM Changeset in webkit [76813] by mitz@apple.com

2 edits in trunk/Source/WebKit/mac

Reverted an accidental change in r76561.

Rubber-stamped by Anders Carlsson.

WebView/WebHTMLView.mm:

10:24 AM Changeset in webkit [76812] by Philippe Normand

2 edits in trunk/LayoutTests

2011-01-27 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip flaky test, needs further investigation on the failure.

[GTK] media/audio-delete-while-slider-thumb-clicked.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=53247

platform/gtk/Skipped:

10:09 AM Changeset in webkit [76811] by kbalazs@webkit.org

2 edits in trunk/Tools

Trivial crash fix in WTR.

Rubber-stamped by Ariya Hidayat.

WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize): Increase the size
of the vector by one to be able to store the null character.

10:06 AM CSS3 3D Transforms.zip attached to QtWebKitContrib by kcomkar@gmail.com

Testcases checking for CSS3 3D Transforms functionality.

10:04 AM CSS3 2D Transforms.zip attached to QtWebKitContrib by kcomkar@gmail.com

Testcases checking for CSS3 2D Transforms functionality.

9:58 AM Browser Performance Tests.zip attached to QtWebKitContrib by kcomkar@gmail.com

Analyses browser's performance at various stress-conditions. An …

9:32 AM Changeset in webkit [76810] by jberlin@webkit.org

2 edits in trunk/LayoutTests

fast/text/international/bidi-mirror-he-ar.html now passed on Windows in WebKit2.
Unreviewed.

platform/win-wk2/Skipped:

9:26 AM Changeset in webkit [76809] by mjs@apple.com

2 edits in trunk/LayoutTests

Unreviewed.

Fix mistake in my previous commit; I accidentally copied the old mac results instead
of the new mac results for this test.

platform/mac-wk2/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:

9:05 AM Changeset in webkit [76808] by rniwa@webkit.org

1 edit in trunk/LayoutTests/ChangeLog

Unreviewed; Fixed change log entries because Chromium rebaselines are unreviewed but claimed to be reviewed.

8:58 AM Changeset in webkit [76807] by Philippe Normand

2 edits in trunk/LayoutTests

2011-01-27 Philippe Normand <pnormand@igalia.com>

Unreviewed, rebaseline of the favicon-as-image test from the build
bot.

platform/gtk/http/tests/misc/favicon-as-image-expected.txt:

8:55 AM Changeset in webkit [76806] by rniwa@webkit.org

2 edits in trunk/LayoutTests

2011-01-27 Ryosuke Niwa <rniwa@webkit.org>

Another Unreviewed Chromium test expectation update.

platform/chromium/test_expectations.txt:

8:50 AM Changeset in webkit [76805] by rniwa@webkit.org

2 edits in trunk/LayoutTests

2011-01-27 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium test expectation update.

platform/chromium/test_expectations.txt:

8:31 AM Changeset in webkit [76804] by rniwa@webkit.org

4 edits
10 adds in trunk/LayoutTests

2011-01-27 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium rebaselines.

platform/chromium-mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum: Added.
platform/chromium-mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.png: Added.
platform/chromium-mac/fast/repaint/line-flow-with-floats-9-expected.checksum:
platform/chromium-mac/fast/repaint/line-flow-with-floats-9-expected.png:
platform/chromium-mac/fast/text/justify-ideograph-complex-expected.checksum: Added.
platform/chromium-mac/fast/text/justify-ideograph-complex-expected.png: Added.
platform/chromium-mac/fast/text/justify-ideograph-simple-expected.checksum: Added.
platform/chromium-mac/fast/text/justify-ideograph-simple-expected.png: Added.
platform/chromium-mac/fast/text/justify-ideograph-vertical-expected.checksum: Added.
platform/chromium-mac/fast/text/justify-ideograph-vertical-expected.png: Added.
platform/chromium-mac/tables/mozilla/marvin/x_thead_align_justify-expected.checksum: Added.
platform/chromium-mac/tables/mozilla/marvin/x_thead_align_justify-expected.png: Added.
platform/chromium/test_expectations.txt:

8:29 AM Changeset in webkit [76803] by kbalazs@webkit.org

2 edits in trunk/Tools

2011-01-27 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt][WK2] WTR should be initialized in the same way as DRT
https://bugs.webkit.org/show_bug.cgi?id=53240

WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: (WTR::activateFonts): Added missing initialization steps.

7:55 AM Changeset in webkit [76802] by Patrick Gansterer

2 edits in trunk/Source/WebCore

2011-01-27 Patrick Gansterer <Patrick Gansterer>

Unreviewed WinCE build fix for r76743.

platform/graphics/wince/FontWinCE.cpp: (WebCore::TextRunComponent::TextRunComponent):

7:38 AM Changeset in webkit [76801] by Philippe Normand

1 edit
1 add in trunk/LayoutTests

2011-01-27 Philippe Normand <pnormand@igalia.com>

Unreviewed, GTK baselines for
svg/custom/pattern-referencing-preserve-aspect-ratio.svg added in r76274.

platform/gtk/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.txt: Added.

7:25 AM Changeset in webkit [76800] by Philippe Normand

1 edit
1 add in trunk/LayoutTests

2011-01-27 Philippe Normand <pnormand@igalia.com>

Unreviewed, GTK baselines for
http/tests/misc/favicon-as-image.html which was unskipped in r76555.

platform/gtk/http/tests/misc/favicon-as-image-expected.txt: Added.

7:11 AM Changeset in webkit [76799] by Philippe Normand

1 edit
1 add in trunk/LayoutTests

2011-01-27 Philippe Normand <pnormand@igalia.com>

Unreviewed, GTK baselines for fast/dom/52776.html, follow-up of r76319.

platform/gtk/fast/dom/52776-expected.txt: Added.

7:07 AM Changeset in webkit [76798] by andreas.kling@nokia.com

4 edits in trunk/Source/WebKit2

2011-01-27 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt][WK2] Add QWKPage APIs regarding engine process availability
https://bugs.webkit.org/show_bug.cgi?id=53237

QWKPage will now emit engineConnected() and engineDisconnected()
when the web process crashes and is relaunched respectively.

Also added QWKPage::isConnectedToEngine() for convenience.

UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::QWKPagePrivate): (QWKPagePrivate::didRelaunchProcess): (QWKPagePrivate::processDidCrash): (QWKPage::isConnectedToEngine):
UIProcess/API/qt/qwkpage.h:
UIProcess/API/qt/qwkpage_p.h:

6:56 AM Changeset in webkit [76797] by kbalazs@webkit.org

2 edits in trunk/Source/WebKit2

2011-01-27 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Andreas Kling.

[Qt][WK2] Lots of layout test failures due to wrong font type
https://bugs.webkit.org/show_bug.cgi?id=53233

Shared/WebPreferencesStore.h: Specialize default font families for Qt.

6:25 AM Changeset in webkit [76796] by Philippe Normand

1 edit
3 adds in trunk/LayoutTests

2011-01-27 Philippe Normand <pnormand@igalia.com>

Unreviewed, new GTK baselines for fast/text/justify* tests
introduced in r76743.

platform/gtk/fast/text/justify-ideograph-complex-expected.txt: Added.
platform/gtk/fast/text/justify-ideograph-simple-expected.txt: Added.
platform/gtk/fast/text/justify-ideograph-vertical-expected.txt: Added.

6:22 AM Changeset in webkit [76795] by podivilov@chromium.org

5 edits in trunk

2011-01-27 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Closure and Global variable details automatically collapsing on each step through JavaScript code.
https://bugs.webkit.org/show_bug.cgi?id=53234

inspector/debugger-expand-scope.html:
inspector/debugger-proto-property.html:

2011-01-27 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Closure and Global variable details automatically collapsing on each step through JavaScript code.
https://bugs.webkit.org/show_bug.cgi?id=53234

inspector/front-end/ScopeChainSidebarPane.js: (WebInspector.ScopeChainSidebarPane): (WebInspector.ScopeChainSidebarPane.prototype.update):

6:14 AM Changeset in webkit [76794] by podivilov@chromium.org

2 edits in trunk/Source/WebCore

2011-01-27 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76789.
http://trac.webkit.org/changeset/76789
https://bugs.webkit.org/show_bug.cgi?id=53238

Broke GTK layout tests (Requested by podivilov on #webkit).

inspector/front-end/ScopeChainSidebarPane.js: (WebInspector.ScopeChainSidebarPane): (WebInspector.ScopeChainSidebarPane.prototype.update):

6:07 AM Changeset in webkit [76793] by Philippe Normand

2 edits in trunk/LayoutTests

2011-01-27 Philippe Normand <pnormand@igalia.com>

Unreviewed, fix typo introduced in r76783.

platform/gtk/Skipped:

6:03 AM Changeset in webkit [76792] by yurys@chromium.org

34 edits
2 deletes in trunk

2011-01-27 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: store all settings related to the agents on the frontend side
https://bugs.webkit.org/show_bug.cgi?id=53174

http/tests/inspector/console-xhr-logging.html: since the setting doesn't change on the front-end side there is no need to check it after modifying backend's value.
inspector/report-protocol-errors.html: use the new signature of disableDebugger method.

2011-01-27 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: store all settings related to the agents on the frontend side
https://bugs.webkit.org/show_bug.cgi?id=53174

CMakeLists.txt:
GNUmakefile.am:
WebCore.exp.in:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/js/ScriptDebugServer.cpp:
bindings/js/ScriptDebugServer.h:
bindings/js/ScriptProfiler.cpp:
bindings/js/ScriptProfiler.h:
bindings/v8/ScriptDebugServer.cpp:
bindings/v8/ScriptDebugServer.h:
bindings/v8/ScriptProfiler.cpp:
bindings/v8/ScriptProfiler.h:
inspector/Inspector.idl:
inspector/InspectorAgent.cpp: profiler and debugger enablement state is now stored on the front-end side and will be pushed to the backend when the frontend is loaded. (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::disconnectFrontend): (WebCore::InspectorAgent::restoreDebugger): (WebCore::InspectorAgent::restoreProfiler): (WebCore::InspectorAgent::enableProfiler): (WebCore::InspectorAgent::disableProfiler): (WebCore::InspectorAgent::showAndEnableDebugger): (WebCore::InspectorAgent::enableDebugger): (WebCore::InspectorAgent::disableDebugger):
inspector/InspectorAgent.h:
inspector/InspectorConsoleAgent.cpp: XHR failures will be logged to the console only if the front-end was opened during current browser session and XHR logging is turned on there. (WebCore::InspectorConsoleAgent::setMonitoringXHREnabled): (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
inspector/InspectorDebuggerAgent.cpp:
inspector/InspectorDebuggerAgent.h:
inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::identifierForInitialRequestImpl): (WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCacheImpl):
inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::InspectorProfilerAgent): (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
inspector/InspectorSettings.cpp: Removed.
inspector/InspectorSettings.h: Removed.
inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState):
inspector/InspectorState.h:
inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.consoleMessagesCleared): (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher): (WebInspector.ConsoleView.prototype._handleContextMenuEvent.itemAction): (WebInspector.ConsoleView.prototype._handleContextMenuEvent):
inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype._toggleProfiling):
inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._toggleDebugging):
inspector/front-end/Settings.js: (WebInspector.Settings):
inspector/front-end/inspector.js:

5:56 AM Changeset in webkit [76791] by Philippe Normand

1 edit
22 adds in trunk/LayoutTests

2011-01-27 Philippe Normand <pnormand@igalia.com>

Unreviewed, new GTK baselines for fast/multicol tests as follow-up
of r76726.

platform/gtk/fast/multicol/vertical-lr/border-padding-pagination-expected.txt: Added.
platform/gtk/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt: Added.
platform/gtk/fast/multicol/vertical-lr/column-count-with-rules-expected.txt: Added.
platform/gtk/fast/multicol/vertical-lr/column-rules-expected.txt: Added.
platform/gtk/fast/multicol/vertical-lr/float-avoidance-expected.txt: Added.
platform/gtk/fast/multicol/vertical-lr/float-multicol-expected.txt: Added.
platform/gtk/fast/multicol/vertical-lr/float-paginate-complex-expected.txt: Added.
platform/gtk/fast/multicol/vertical-lr/float-paginate-expected.txt: Added.
platform/gtk/fast/multicol/vertical-lr/nested-columns-expected.txt: Added.
platform/gtk/fast/multicol/vertical-lr/unsplittable-inline-block-expected.txt: Added.
platform/gtk/fast/multicol/vertical-rl/border-padding-pagination-expected.txt: Added.
platform/gtk/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt: Added.
platform/gtk/fast/multicol/vertical-rl/column-count-with-rules-expected.txt: Added.
platform/gtk/fast/multicol/vertical-rl/column-rules-expected.txt: Added.
platform/gtk/fast/multicol/vertical-rl/float-avoidance-expected.txt: Added.
platform/gtk/fast/multicol/vertical-rl/float-multicol-expected.txt: Added.
platform/gtk/fast/multicol/vertical-rl/float-paginate-complex-expected.txt: Added.
platform/gtk/fast/multicol/vertical-rl/float-paginate-expected.txt: Added.
platform/gtk/fast/multicol/vertical-rl/nested-columns-expected.txt: Added.
platform/gtk/fast/multicol/vertical-rl/unsplittable-inline-block-expected.txt: Added.

5:43 AM Changeset in webkit [76790] by joone.hur@collabora.co.uk

2 edits in trunk/Tools

2011-01-27 Joone Hur <joone.hur@collabora.co.uk>

Unreviewed.

Adding myself to committers.py.

Scripts/webkitpy/common/config/committers.py:

5:41 AM WebKitGTK edited by Philippe Normand

(diff)

5:40 AM WebKitGTK/KeepingTheTreeGreen created by Philippe Normand

5:01 AM Changeset in webkit [76789] by podivilov@chromium.org

2 edits in trunk/Source/WebCore

2011-01-27 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Closure and Global variable details automatically collapsing on each step through JavaScript code.
https://bugs.webkit.org/show_bug.cgi?id=53234

inspector/front-end/ScopeChainSidebarPane.js: (WebInspector.ScopeChainSidebarPane): (WebInspector.ScopeChainSidebarPane.prototype.update):

4:54 AM Changeset in webkit [76788] by apavlov@chromium.org

5 edits in trunk

2011-01-27 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Elements panel] Tooltip for relative links incorrectly identifies current URL
https://bugs.webkit.org/show_bug.cgi?id=53171

WebCore:

inspector/front-end/inspector.js: (WebInspector.completeURL): Taught to understand partial href's that start with "?" (contain GET parameters only)

LayoutTests:

inspector/styles-url-linkify-expected.txt:
inspector/styles-url-linkify.html:

4:44 AM Changeset in webkit [76787] by sergio@webkit.org

2 edits
4 adds in trunk/LayoutTests

2011-01-27 Sergio Villar Senin <svillar@igalia.com>

Unreviewed.

New test expectations for http/tests/navigation/error404* in GTK.

platform/gtk/Skipped:
platform/gtk/http/tests/navigation/error404-basic-expected.txt: Added.
platform/gtk/http/tests/navigation/error404-goback-expected.txt: Added.
platform/gtk/http/tests/navigation/error404-subframeload-expected.txt: Added.

4:38 AM Changeset in webkit [76786] by yurys@chromium.org

2 edits in trunk/Source/WebCore

2011-01-27 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[V8] Crash in WebCore::addMessageToConsole
https://bugs.webkit.org/show_bug.cgi?id=53227

bindings/v8/V8Proxy.cpp: check that the Frame where the error occured still has a page before getting a console object from it. (WebCore::V8Proxy::reportUnsafeAccessTo):

4:30 AM Changeset in webkit [76785] by Csaba Osztrogonác

2 edits in trunk/Tools

[Qt] [Symbian] Move project files into Source
https://bugs.webkit.org/show_bug.cgi?id=52891

Patch by Laszlo Gombos <Laszlo Gombos> on 2011-01-27
Reviewed by Csaba Osztrogonác.

Fix the Symbian build after the project files
are moved to Source directory. On Symbian qmake
needs to run in the same directory where the main
pro files (WebKit.pro, Tools.pro) are located.

Scripts/webkitdirs.pm: Change to the directory where the pro file

is located before running qmake for Symbian. Qmake on Symbian
does not properly honor the "-o" option, work it around by setting
the name of the Makefile to bld.inf.

3:57 AM Changeset in webkit [76784] by hans@chromium.org

13 edits in trunk/Source

2011-01-27 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Remove IDBCallbacks::onSuccess() used for null values.
https://bugs.webkit.org/show_bug.cgi?id=53178

Remove the IDBCallbacks::onSuccess() function that was used for
null values, and replace such calls with calls to
IDBCallBacks::onSuccess(SerializedScriptValue::nullValue())
instead.

No new functionality, so no new tests.

storage/IDBCallbacks.h:
storage/IDBCursorBackendImpl.cpp: (WebCore::IDBCursorBackendImpl::updateInternal): (WebCore::IDBCursorBackendImpl::continueFunctionInternal):
storage/IDBIndexBackendImpl.cpp: (WebCore::IDBIndexBackendImpl::openCursorInternal):
storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::deleteInternal): (WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
storage/IDBRequest.cpp:
storage/IDBRequest.h:

2011-01-27 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Remove IDBCallbacks::onSuccess() used for null values.
https://bugs.webkit.org/show_bug.cgi?id=53178

Remove the IDBCallbacks::onSuccess() function that was used for
null values, and replace such calls with calls to
IDBCallBacks::onSuccess(SerializedScriptValue::nullValue())
instead.

public/WebIDBCallbacks.h: (WebKit::WebIDBCallbacks::onSuccess):
src/IDBCallbacksProxy.cpp:
src/IDBCallbacksProxy.h:
src/WebIDBCallbacksImpl.cpp:
src/WebIDBCallbacksImpl.h:

3:54 AM Changeset in webkit [76783] by Philippe Normand

2 edits in trunk/LayoutTests

2011-01-27 Philippe Normand <pnormand@igalia.com>

Unreviewed, skipping 2 more media tests.

[GStreamer] wrong media duration report in media/controls-after-reload.html
https://bugs.webkit.org/show_bug.cgi?id=51602

platform/gtk/Skipped:

3:38 AM Changeset in webkit [76782] by yuzo@google.com

2 edits in trunk/LayoutTests

2011-01-27 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.

platform/chromium/test_expectations.txt:

3:27 AM Changeset in webkit [76781] by yuzo@google.com

1 edit
30 deletes in trunk/LayoutTests

2011-01-27 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.

platform/chromium-mac-leopard/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum: Removed.
platform/chromium-mac-leopard/css2.1/t0905-c5525-fltcont-00-d-g-expected.png: Removed.
platform/chromium-mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.checksum: Removed.
platform/chromium-mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.png: Removed.
platform/chromium-mac-leopard/fast/multicol/shadow-breaking-expected.checksum: Removed.
platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-1-expected.checksum: Removed.
platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-1-expected.png: Removed.
platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-10-expected.checksum: Removed.
platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-10-expected.png: Removed.
platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-2-expected.checksum: Removed.
platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-2-expected.png: Removed.
platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-3-expected.checksum: Removed.
platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-3-expected.png: Removed.
platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-4-expected.checksum: Removed.
platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-4-expected.png: Removed.
platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-5-expected.checksum: Removed.
platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-5-expected.png: Removed.
platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-6-expected.checksum: Removed.
platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-6-expected.png: Removed.
platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-7-expected.checksum: Removed.
platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-7-expected.png: Removed.
platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-8-expected.checksum: Removed.
platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-8-expected.png: Removed.
platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-9-expected.checksum: Removed.
platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-9-expected.png: Removed.
platform/chromium-mac-leopard/fast/text/complex-text-opacity-expected.checksum: Removed.
platform/chromium-mac-leopard/fast/text/complex-text-opacity-expected.png: Removed.
platform/chromium-mac-leopard/fast/text/complex-text-opacity-expected.txt: Removed.
platform/chromium-mac-leopard/tables/mozilla/marvin/x_thead_align_justify-expected.checksum: Removed.
platform/chromium-mac-leopard/tables/mozilla/marvin/x_thead_align_justify-expected.png: Removed.

3:13 AM Changeset in webkit [76780] by mjs@apple.com

1 edit in trunk/LayoutTests/ChangeLog

Unreviewed.

Fix mistake in my previous commit; I accidentally copied the old mac results instead
of the new mac results for this test.

platform/mac-wk2/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:

2:51 AM Changeset in webkit [76779] by Csaba Osztrogonác

1 edit
56 adds in trunk/LayoutTests

Unreviewed.

Add Qt specific expected results for new passing tests introduced in r76726.
Compared to Mac png files and Mac expected files.

platform/qt/fast/multicol/vertical-lr/border-padding-pagination-expected.checksum: Added.
platform/qt/fast/multicol/vertical-lr/border-padding-pagination-expected.png: Added.
platform/qt/fast/multicol/vertical-lr/border-padding-pagination-expected.txt: Added.
platform/qt/fast/multicol/vertical-lr/column-break-with-balancing-expected.checksum: Added.
platform/qt/fast/multicol/vertical-lr/column-break-with-balancing-expected.png: Added.
platform/qt/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt: Added.
platform/qt/fast/multicol/vertical-lr/column-rules-expected.checksum: Added.
platform/qt/fast/multicol/vertical-lr/column-rules-expected.png: Added.
platform/qt/fast/multicol/vertical-lr/column-rules-expected.txt: Added.
platform/qt/fast/multicol/vertical-lr/float-avoidance-expected.checksum: Added.
platform/qt/fast/multicol/vertical-lr/float-avoidance-expected.png: Added.
platform/qt/fast/multicol/vertical-lr/float-avoidance-expected.txt: Added.
platform/qt/fast/multicol/vertical-lr/float-multicol-expected.checksum: Added.
platform/qt/fast/multicol/vertical-lr/float-multicol-expected.png: Added.
platform/qt/fast/multicol/vertical-lr/float-multicol-expected.txt: Added.
platform/qt/fast/multicol/vertical-lr/float-paginate-complex-expected.checksum: Added.
platform/qt/fast/multicol/vertical-lr/float-paginate-complex-expected.png: Added.
platform/qt/fast/multicol/vertical-lr/float-paginate-complex-expected.txt: Added.
platform/qt/fast/multicol/vertical-lr/float-paginate-expected.checksum: Added.
platform/qt/fast/multicol/vertical-lr/float-paginate-expected.png: Added.
platform/qt/fast/multicol/vertical-lr/float-paginate-expected.txt: Added.
platform/qt/fast/multicol/vertical-lr/nested-columns-expected.checksum: Added.
platform/qt/fast/multicol/vertical-lr/nested-columns-expected.png: Added.
platform/qt/fast/multicol/vertical-lr/nested-columns-expected.txt: Added.
platform/qt/fast/multicol/vertical-lr/unsplittable-inline-block-expected.checksum: Added.
platform/qt/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png: Added.
platform/qt/fast/multicol/vertical-lr/unsplittable-inline-block-expected.txt: Added.
platform/qt/fast/multicol/vertical-rl/border-padding-pagination-expected.checksum: Added.
platform/qt/fast/multicol/vertical-rl/border-padding-pagination-expected.png: Added.
platform/qt/fast/multicol/vertical-rl/border-padding-pagination-expected.txt: Added.
platform/qt/fast/multicol/vertical-rl/column-break-with-balancing-expected.checksum: Added.
platform/qt/fast/multicol/vertical-rl/column-break-with-balancing-expected.png: Added.
platform/qt/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt: Added.
platform/qt/fast/multicol/vertical-rl/column-rules-expected.checksum: Added.
platform/qt/fast/multicol/vertical-rl/column-rules-expected.png: Added.
platform/qt/fast/multicol/vertical-rl/column-rules-expected.txt: Added.
platform/qt/fast/multicol/vertical-rl/float-avoidance-expected.checksum: Added.
platform/qt/fast/multicol/vertical-rl/float-avoidance-expected.png: Added.
platform/qt/fast/multicol/vertical-rl/float-avoidance-expected.txt: Added.
platform/qt/fast/multicol/vertical-rl/float-multicol-expected.checksum: Added.
platform/qt/fast/multicol/vertical-rl/float-multicol-expected.png: Added.
platform/qt/fast/multicol/vertical-rl/float-multicol-expected.txt: Added.
platform/qt/fast/multicol/vertical-rl/float-paginate-complex-expected.checksum: Added.
platform/qt/fast/multicol/vertical-rl/float-paginate-complex-expected.png: Added.
platform/qt/fast/multicol/vertical-rl/float-paginate-complex-expected.txt: Added.
platform/qt/fast/multicol/vertical-rl/float-paginate-expected.checksum: Added.
platform/qt/fast/multicol/vertical-rl/float-paginate-expected.png: Added.
platform/qt/fast/multicol/vertical-rl/float-paginate-expected.txt: Added.
platform/qt/fast/multicol/vertical-rl/nested-columns-expected.checksum: Added.
platform/qt/fast/multicol/vertical-rl/nested-columns-expected.png: Added.
platform/qt/fast/multicol/vertical-rl/nested-columns-expected.txt: Added.
platform/qt/fast/multicol/vertical-rl/unsplittable-inline-block-expected.checksum: Added.
platform/qt/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png: Added.
platform/qt/fast/multicol/vertical-rl/unsplittable-inline-block-expected.txt: Added.

2:25 AM Changeset in webkit [76778] by zoltan@webkit.org

3 edits in trunk/Tools

[Qt] Add simple zooming features to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=53231

Reviewed by Andreas Kling.

Add View menu and Zoom In, Zoom Out, Zoom Reset actions to MiniBrowser.

MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::zoomIn):
(BrowserWindow::zoomOut):
(BrowserWindow::resetZoom):
(BrowserWindow::updateUserAgentList):
(BrowserWindow::applyZoom):

MiniBrowser/qt/BrowserWindow.h:

2:00 AM Changeset in webkit [76777] by Philippe Normand

4 edits in trunk

2011-01-27 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76773.
http://trac.webkit.org/changeset/76773
https://bugs.webkit.org/show_bug.cgi?id=53230

breaks multiple GTK media tests (Requested by philn-tp on
#webkit).

platform/gtk/Skipped:

2011-01-27 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76773.
http://trac.webkit.org/changeset/76773
https://bugs.webkit.org/show_bug.cgi?id=53230

breaks multiple GTK media tests (Requested by philn-tp on
#webkit).

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::mimeTypeCache):

1:41 AM Changeset in webkit [76776] by yuzo@google.com

2 edits in trunk/LayoutTests

2011-01-27 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectaion change.

platform/chromium/test_expectations.txt:

1:34 AM Changeset in webkit [76775] by yurys@chromium.org

31 edits
1 copy
1 add in trunk/Source/WebCore

2011-01-27 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76770.
http://trac.webkit.org/changeset/76770
https://bugs.webkit.org/show_bug.cgi?id=53229

Some inspector tests fail (Requested by yurys on #webkit).

CMakeLists.txt:
GNUmakefile.am:
WebCore.exp.in:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::isDebuggerAlwaysEnabled):
bindings/js/ScriptDebugServer.h:
bindings/js/ScriptProfiler.cpp: (WebCore::ScriptProfiler::isProfilerAlwaysEnabled):
bindings/js/ScriptProfiler.h:
bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::isDebuggerAlwaysEnabled):
bindings/v8/ScriptDebugServer.h:
bindings/v8/ScriptProfiler.cpp: (WebCore::ScriptProfiler::isProfilerAlwaysEnabled):
bindings/v8/ScriptProfiler.h:
inspector/Inspector.idl:
inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::disconnectFrontend): (WebCore::InspectorAgent::restoreDebugger): (WebCore::InspectorAgent::restoreProfiler): (WebCore::InspectorAgent::ensureSettingsLoaded): (WebCore::InspectorAgent::enableProfiler): (WebCore::InspectorAgent::disableProfiler): (WebCore::InspectorAgent::showAndEnableDebugger): (WebCore::InspectorAgent::enableDebugger): (WebCore::InspectorAgent::disableDebugger):
inspector/InspectorAgent.h: (WebCore::InspectorAgent::settings):
inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::setMonitoringXHREnabled): (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::isDebuggerAlwaysEnabled):
inspector/InspectorDebuggerAgent.h:
inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::identifierForInitialRequestImpl): (WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCacheImpl):
inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::InspectorProfilerAgent): (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
inspector/InspectorSettings.cpp: Added. (WebCore::InspectorSettings::InspectorSettings): (WebCore::InspectorSettings::getBoolean): (WebCore::InspectorSettings::setBoolean): (WebCore::InspectorSettings::getLong): (WebCore::InspectorSettings::setLong): (WebCore::InspectorSettings::registerBoolean): (WebCore::InspectorSettings::registerLong):
inspector/InspectorSettings.h: Copied from Source/WebCore/bindings/v8/ScriptProfiler.h.
inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState):
inspector/InspectorState.h:
inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.monitoringXHRStateChanged): (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher): (WebInspector.ConsoleView.prototype._handleContextMenuEvent):
inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype._toggleProfiling):
inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._toggleDebugging):
inspector/front-end/Settings.js: (WebInspector.Settings):
inspector/front-end/inspector.js:

1:08 AM Changeset in webkit [76774] by mjs@apple.com

1 edit
4 adds in trunk/LayoutTests

2011-01-27 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

Add or update WebKit2-specific results to account for different reporting of scroll position
https://bugs.webkit.org/show_bug.cgi?id=53226

platform/mac-wk2/fast/multicol: Added.
platform/mac-wk2/fast/multicol/vertical-rl: Added.
platform/mac-wk2/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt: Added.
platform/mac-wk2/fast/multicol/vertical-rl/float-paginate-complex-expected.txt: Added.

12:55 AM Changeset in webkit [76773] by Philippe Normand

4 edits in trunk

2011-01-26 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] LayoutTests/media/audio-mpeg4-supported.html fails
https://bugs.webkit.org/show_bug.cgi?id=53125

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::mimeTypeCache): Add audio/x-m4a mimetype in the cache.

2011-01-26 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] LayoutTests/media/audio-mpeg4-supported.html fails
https://bugs.webkit.org/show_bug.cgi?id=53125

platform/gtk/Skipped: Unskip fixed test.

12:43 AM Changeset in webkit [76772] by Philippe Normand

9 edits in trunk/LayoutTests

2011-01-27 Philippe Normand <pnormand@igalia.com>

Unreviewed, updated GTK baselines after r76726.

platform/gtk/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:
platform/gtk/fast/blockflow/vertical-baseline-alignment-expected.txt:
platform/gtk/fast/lists/002-vertical-expected.txt:
platform/gtk/fast/lists/003-vertical-expected.txt:
platform/gtk/fast/overflow/overflow-rtl-vertical-expected.txt:
platform/gtk/fast/table/028-vertical-expected.txt:
platform/gtk/fast/table/border-collapsing/003-vertical-expected.txt:
platform/gtk/fast/table/height-percent-test-vertical-expected.txt:

12:38 AM Changeset in webkit [76771] by yuzo@google.com

2 edits in trunk/LayoutTests

2011-01-27 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.

Update expectation for r76760.

platform/chromium/test_expectations.txt:

12:36 AM Changeset in webkit [76770] by yurys@chromium.org

31 edits
2 deletes in trunk/Source/WebCore

2011-01-26 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: store all settings related to the agents on the frontend side
https://bugs.webkit.org/show_bug.cgi?id=53174

CMakeLists.txt:
GNUmakefile.am:
WebCore.exp.in:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
inspector/Inspector.idl:
inspector/InspectorAgent.cpp: profiler and debugger enablement state is now stored on the front-end side and will be pushed to the backend when the frontend is loaded. (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::disconnectFrontend): (WebCore::InspectorAgent::restoreDebugger): (WebCore::InspectorAgent::restoreProfiler): (WebCore::InspectorAgent::enableProfiler): (WebCore::InspectorAgent::disableProfiler): (WebCore::InspectorAgent::showAndEnableDebugger): (WebCore::InspectorAgent::enableDebugger): (WebCore::InspectorAgent::disableDebugger):
inspector/InspectorAgent.h:
inspector/InspectorConsoleAgent.cpp: XHR failures will be logged to the console only if the front-end was opened during current browser session and XHR logging is turned on there. (WebCore::InspectorConsoleAgent::setMonitoringXHREnabled): (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::identifierForInitialRequestImpl): (WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCacheImpl):
inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::enable): (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
inspector/InspectorProfilerAgent.h:
inspector/InspectorSettings.cpp: Removed.
inspector/InspectorSettings.h: Removed.
inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState):
inspector/InspectorState.h:
inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.consoleMessagesCleared): (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher): (WebInspector.ConsoleView.prototype._handleContextMenuEvent.itemAction): (WebInspector.ConsoleView.prototype._handleContextMenuEvent):
inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype._toggleProfiling):
inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._toggleDebugging):
inspector/front-end/Settings.js: (WebInspector.Settings):
inspector/front-end/inspector.js:

12:32 AM Changeset in webkit [76769] by mjs@apple.com

23 edits
2 adds in trunk

2011-01-26 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
https://bugs.webkit.org/show_bug.cgi?id=42319

Unskip inspector tests (except the few that mysteriously fail).

platform/mac-wk2/Skipped:

2011-01-26 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
https://bugs.webkit.org/show_bug.cgi?id=42319

Add evaluateInWebInspector and other APIs needed for inspector tests to run.

WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::showWebInspector): (WTR::LayoutTestController::closeWebInspector): (WTR::LayoutTestController::evaluateInWebInspector): (WTR::LayoutTestController::setTimelineProfilingEnabled):
WebKitTestRunner/InjectedBundle/LayoutTestController.h:
WebKitTestRunner/TestInvocation.cpp: (WTR::shouldOpenWebInspector): (WTR::TestInvocation::invoke):
WebKitTestRunner/WebKitTestRunnerPrefix.h:

2011-01-26 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
https://bugs.webkit.org/show_bug.cgi?id=42319

Add WKBundleInspector and APIs needed to implement WebKitTestRunner APIs.

GNUmakefile.am:
Shared/API/c/WKBase.h:
Shared/APIObject.h:
WebKit2.pro:
WebKit2.xcodeproj/project.pbxproj:
WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
WebProcess/InjectedBundle/API/c/WKBundleInspector.cpp: Added. (WKBundleInspectorGetTypeID): (WKBundleInspectorShow): (WKBundleInspectorClose): (WKBundleInspectorEvaluateScriptForTest): (WKBundleInspectorSetPageProfilingEnabled):
WebProcess/InjectedBundle/API/c/WKBundleInspector.h: Added.
WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePageGetInspector):
WebProcess/InjectedBundle/API/c/WKBundlePage.h:
WebProcess/WebPage/WebInspector.cpp: (WebKit::WebInspector::create): (WebKit::WebInspector::evaluateScriptForTest):
WebProcess/WebPage/WebInspector.h: (WebKit::WebInspector::type):
WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::inspector):
WebProcess/WebPage/WebPage.h:
win/WebKit2.vcproj:
win/WebKit2Generated.make:

12:23 AM Changeset in webkit [76768] by mitz@apple.com

6 edits in trunk/Source/WebCore

REGRESSION (r76743): Uneven spacing in right-to-left justified text
https://bugs.webkit.org/show_bug.cgi?id=53225

Reviewed by Sam Weinig.

Fixes failure in fast/text/atsui-spacing-features.html

There was an inconsistency between rendering code and font code in the interpretation of
'after expansion' and 'trailing expansion'. Changed all code to interpret these in terms of
visual order rather than logical.

platform/graphics/Font.cpp:

(WebCore::Font::expansionOpportunityCount): Added a text direction parameter and changed to
iterate in visual order accordingly.

platform/graphics/Font.h:
platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::WidthIterator): Pass the run direction to expansionOpportunityCount().
(WebCore::WidthIterator::advance): For right-to-left runs, evaluate the trailing expansion
condition with respect to the first character, which is the trailing character in visual order.

platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::ComplexTextController): Pass the run direction to
expansionOpportunityCount().

rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Ditto.

12:15 AM Changeset in webkit [76767] by yuzo@google.com

2 edits in trunk/LayoutTests

2011-01-27 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.

Another test expectation update for r76743.

platform/chromium/test_expectations.txt:

Jan 26, 2011:

11:42 PM Changeset in webkit [76766] by Csaba Osztrogonác

17 edits
2 adds in trunk/LayoutTests

Unreviewed.

[Qt] Update test expectations after r76726.

platform/qt/fast/lists/002-vertical-expected.checksum:
platform/qt/fast/lists/002-vertical-expected.png:
platform/qt/fast/lists/002-vertical-expected.txt:
platform/qt/fast/lists/003-vertical-expected.checksum:
platform/qt/fast/lists/003-vertical-expected.png:
platform/qt/fast/lists/003-vertical-expected.txt:
platform/qt/fast/overflow/overflow-rtl-vertical-expected.checksum:
platform/qt/fast/overflow/overflow-rtl-vertical-expected.png:
platform/qt/fast/overflow/overflow-rtl-vertical-expected.txt:
platform/qt/fast/table/028-vertical-expected.checksum:
platform/qt/fast/table/028-vertical-expected.png:
platform/qt/fast/table/028-vertical-expected.txt:
platform/qt/fast/table/border-collapsing/003-vertical-expected.checksum:
platform/qt/fast/table/border-collapsing/003-vertical-expected.png:
platform/qt/fast/table/border-collapsing/003-vertical-expected.txt:
platform/qt/fast/table/height-percent-test-vertical-expected.txt:

11:14 PM Changeset in webkit [76765] by yuzo@google.com

84 edits
9 adds in trunk/LayoutTests

2011-01-26 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.

Update test expectations for r76743

platform/chromium-linux/css1/box_properties/clear_float-expected.checksum:
platform/chromium-linux/css1/box_properties/clear_float-expected.png:
platform/chromium-linux/css1/box_properties/float_elements_in_series-expected.checksum:
platform/chromium-linux/css1/box_properties/float_elements_in_series-expected.png:
platform/chromium-linux/css1/box_properties/float_on_text_elements-expected.checksum:
platform/chromium-linux/css1/box_properties/float_on_text_elements-expected.png:
platform/chromium-linux/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
platform/chromium-linux/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
platform/chromium-linux/fast/multicol/shadow-breaking-expected.checksum:
platform/chromium-linux/fast/multicol/shadow-breaking-expected.png: Added.
platform/chromium-linux/fast/repaint/line-flow-with-floats-1-expected.checksum:
platform/chromium-linux/fast/repaint/line-flow-with-floats-1-expected.png:
platform/chromium-linux/fast/repaint/line-flow-with-floats-10-expected.checksum:
platform/chromium-linux/fast/repaint/line-flow-with-floats-10-expected.png:
platform/chromium-linux/fast/repaint/line-flow-with-floats-2-expected.checksum:
platform/chromium-linux/fast/repaint/line-flow-with-floats-2-expected.png:
platform/chromium-linux/fast/repaint/line-flow-with-floats-3-expected.checksum:
platform/chromium-linux/fast/repaint/line-flow-with-floats-3-expected.png:
platform/chromium-linux/fast/repaint/line-flow-with-floats-4-expected.checksum:
platform/chromium-linux/fast/repaint/line-flow-with-floats-4-expected.png:
platform/chromium-linux/fast/repaint/line-flow-with-floats-5-expected.checksum:
platform/chromium-linux/fast/repaint/line-flow-with-floats-5-expected.png:
platform/chromium-linux/fast/repaint/line-flow-with-floats-6-expected.checksum:
platform/chromium-linux/fast/repaint/line-flow-with-floats-6-expected.png:
platform/chromium-linux/fast/repaint/line-flow-with-floats-7-expected.checksum:
platform/chromium-linux/fast/repaint/line-flow-with-floats-7-expected.png:
platform/chromium-linux/fast/repaint/line-flow-with-floats-8-expected.checksum:
platform/chromium-linux/fast/repaint/line-flow-with-floats-8-expected.png:
platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.checksum:
platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png:
platform/chromium-linux/tables/mozilla/marvin/x_tr_align_justify-expected.checksum:
platform/chromium-linux/tables/mozilla/marvin/x_tr_align_justify-expected.png:
platform/chromium-mac/css1/box_properties/clear_float-expected.checksum: Added.
platform/chromium-mac/css1/box_properties/clear_float-expected.png: Added.
platform/chromium-mac/css1/box_properties/float_on_text_elements-expected.checksum: Added.
platform/chromium-mac/css1/box_properties/float_on_text_elements-expected.png: Added.
platform/chromium-mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum: Added.
platform/chromium-mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png: Added.
platform/chromium-mac/fast/multicol/shadow-breaking-expected.checksum: Added.
platform/chromium-mac/fast/multicol/shadow-breaking-expected.png: Added.
platform/chromium-mac/fast/repaint/line-flow-with-floats-1-expected.checksum:
platform/chromium-mac/fast/repaint/line-flow-with-floats-1-expected.png:
platform/chromium-mac/fast/repaint/line-flow-with-floats-10-expected.checksum:
platform/chromium-mac/fast/repaint/line-flow-with-floats-10-expected.png:
platform/chromium-mac/fast/repaint/line-flow-with-floats-2-expected.checksum:
platform/chromium-mac/fast/repaint/line-flow-with-floats-2-expected.png:
platform/chromium-mac/fast/repaint/line-flow-with-floats-3-expected.checksum:
platform/chromium-mac/fast/repaint/line-flow-with-floats-3-expected.png:
platform/chromium-mac/fast/repaint/line-flow-with-floats-4-expected.checksum:
platform/chromium-mac/fast/repaint/line-flow-with-floats-4-expected.png:
platform/chromium-mac/fast/repaint/line-flow-with-floats-5-expected.checksum:
platform/chromium-mac/fast/repaint/line-flow-with-floats-5-expected.png:
platform/chromium-mac/fast/repaint/line-flow-with-floats-6-expected.checksum:
platform/chromium-mac/fast/repaint/line-flow-with-floats-6-expected.png:
platform/chromium-mac/fast/repaint/line-flow-with-floats-7-expected.checksum:
platform/chromium-mac/fast/repaint/line-flow-with-floats-7-expected.png:
platform/chromium-mac/fast/repaint/line-flow-with-floats-8-expected.checksum:
platform/chromium-mac/fast/repaint/line-flow-with-floats-8-expected.png:
platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.checksum:
platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.png:
platform/chromium-win/css1/box_properties/clear_float-expected.checksum:
platform/chromium-win/css1/box_properties/clear_float-expected.png:
platform/chromium-win/css1/box_properties/float_elements_in_series-expected.checksum:
platform/chromium-win/css1/box_properties/float_elements_in_series-expected.png:
platform/chromium-win/css1/box_properties/float_on_text_elements-expected.checksum:
platform/chromium-win/css1/box_properties/float_on_text_elements-expected.png:
platform/chromium-win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
platform/chromium-win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
platform/chromium-win/fast/multicol/shadow-breaking-expected.checksum:
platform/chromium-win/fast/multicol/shadow-breaking-expected.png:
platform/chromium-win/fast/repaint/line-flow-with-floats-1-expected.checksum:
platform/chromium-win/fast/repaint/line-flow-with-floats-1-expected.png:
platform/chromium-win/fast/repaint/line-flow-with-floats-10-expected.checksum:
platform/chromium-win/fast/repaint/line-flow-with-floats-10-expected.png:
platform/chromium-win/fast/repaint/line-flow-with-floats-2-expected.checksum:
platform/chromium-win/fast/repaint/line-flow-with-floats-2-expected.png:
platform/chromium-win/fast/repaint/line-flow-with-floats-3-expected.checksum:
platform/chromium-win/fast/repaint/line-flow-with-floats-3-expected.png:
platform/chromium-win/fast/repaint/line-flow-with-floats-4-expected.checksum:
platform/chromium-win/fast/repaint/line-flow-with-floats-4-expected.png:
platform/chromium-win/fast/repaint/line-flow-with-floats-5-expected.checksum:
platform/chromium-win/fast/repaint/line-flow-with-floats-5-expected.png:
platform/chromium-win/fast/repaint/line-flow-with-floats-6-expected.checksum:
platform/chromium-win/fast/repaint/line-flow-with-floats-6-expected.png:
platform/chromium-win/fast/repaint/line-flow-with-floats-7-expected.checksum:
platform/chromium-win/fast/repaint/line-flow-with-floats-7-expected.png:
platform/chromium-win/fast/repaint/line-flow-with-floats-8-expected.checksum:
platform/chromium-win/fast/repaint/line-flow-with-floats-8-expected.png:
platform/chromium-win/svg/custom/svg-fonts-in-html-expected.checksum:
platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
platform/chromium-win/tables/mozilla/marvin/x_tr_align_justify-expected.checksum:
platform/chromium-win/tables/mozilla/marvin/x_tr_align_justify-expected.png:

10:41 PM Changeset in webkit [76764] by Adam Roben

2 edits in trunk/Source/WebCore

Don't create the Direct3D device before it's first needed

We only need the device once we decide to render. There's no point in creating it before
then.

Reviewed by Sam Weinig.

platform/graphics/ca/win/CACFLayerTreeHost.cpp:

(WebCore::CACFLayerTreeHost::setWindow): Removed the call to createRenderer() from here.
We already have code to create it when we first try to draw.
(WebCore::CACFLayerTreeHost::createRenderer): Flush the context after we set our layer's
bounds so that the bounds will take effect the next time we render (which could be just
after this function returns).

10:40 PM Changeset in webkit [76763] by Adam Roben

3 edits in trunk/Source/WebCore

Add assertions that CACFLayerTreeHost gains and loses an HWND only once

CACFLayerTreeHost doesn't support any other use pattern.

Reviewed by Sam Weinig.

platform/graphics/ca/win/CACFLayerTreeHost.cpp:

(WebCore::CACFLayerTreeHost::CACFLayerTreeHost): Initialize new member.
(WebCore::CACFLayerTreeHost::setWindow): Assert that we transition from not having a window,
to having a window, to not having a window just once over the lifetime of this object.

platform/graphics/ca/win/CACFLayerTreeHost.h: Added m_state.

10:40 PM Changeset in webkit [76762] by Adam Roben

3 edits in trunk/Source/WebCore

Notify layers that their animations have started when we flush the context, not when we render

r76372 separated context flushing from rendering, but this bit of code got left behind.

Reviewed by Sam Weinig.

platform/graphics/ca/win/CACFLayerTreeHost.cpp:

(WebCore::CACFLayerTreeHost::render): Moved code to notify the layers from here to
notifyAnimationsStarted.
(WebCore::CACFLayerTreeHost::flushPendingLayerChangesNow): Added a call to
notifyAnimationsStarted after we flush the context.
(WebCore::CACFLayerTreeHost::notifyAnimationsStarted): Added. Code came from render. Changed
to call PlatformCALayer::animationStarted rather than calling through to the client
directly.

platform/graphics/ca/win/CACFLayerTreeHost.h: Added notifyAniamtionsStarted.

10:39 PM Changeset in webkit [76761] by Adam Roben

3 edits in trunk/Source/WebCore

Small cleanup in MediaPlayerPrivateFullscreenWindow

Reviewed by Sam Weinig.

platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:

(WebCore::MediaPlayerPrivateFullscreenWindow::~MediaPlayerPrivateFullscreenWindow): Moved
code here from close(), since this was the only place that called it after the following
change to createWindow.
(WebCore::MediaPlayerPrivateFullscreenWindow::createWindow): Replaced code that handled the
case where we had already created the window with an assertion that we have not already done
so. Our single caller (FullscreenVideoController) did not require this behavior.

platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h: Removed layerView.

10:31 PM Changeset in webkit [76760] by mitz@apple.com

4 edits in trunk/LayoutTests

Updated results for the html.css changes in r76726. The old results were prepared before
r76726.

platform/mac/fast/text/justify-ideograph-vertical-expected.checksum:
platform/mac/fast/text/justify-ideograph-vertical-expected.png:
platform/mac/fast/text/justify-ideograph-vertical-expected.txt:

10:30 PM Changeset in webkit [76759] by yuzo@google.com

2 edits in trunk/LayoutTests

2011-01-26 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.

fast/text/justify-ideograph-vertical.html crashes on LINUX.

platform/chromium/test_expectations.txt:

9:59 PM Changeset in webkit [76758] by yuzo@google.com

2 edits in trunk/LayoutTests

2011-01-26 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.

Mark the tests started failing at http://trac.webkit.org/changeset/76726 as such.

platform/chromium/test_expectations.txt:

9:12 PM Changeset in webkit [76757] by weinig@apple.com

6 edits in trunk/Source/WebCore

Move ScrollView scroll wheel code to ScrollAnimator.

Reviewed by Adam Roben.

platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::handleWheelEvent):

platform/ScrollAnimator.h:

Moved implementation of handleWheelEvent from ScrollView::wheelEvent.

platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):
Call down to the ScrollableArea.

platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::handleWheelEvent):
Call down to the ScrollAnimator.

platform/ScrollableArea.h:

(WebCore::ScrollableArea::scrollPosition):
(WebCore::ScrollableArea::minimumScrollPosition):
(WebCore::ScrollableArea::maximumScrollPosition):
(WebCore::ScrollableArea::visibleContentRect):
(WebCore::ScrollableArea::visibleHeight):
(WebCore::ScrollableArea::visibleWidth):
Add functions needed to implement wheel event in the animator.

8:57 PM Changeset in webkit [76756] by ddkilzer@apple.com

21 edits in trunk

<http://webkit.org/b/53192> Add experimental support for HTTP pipelining in CFNetwork
<rdar://problem/8821760>

Reviewed by Antti Koivisto.

Source/WebCore:

This adds support for HTTP pipelining in CFNetwork, but does not
enable it. To enable it post-SnowLeopard, use this command:

defaults write BUNDLE.ID WebKitEnableHTTPPipelining -bool YES

Once enabled, it is possible to force the same load priority
(high) to be sent to CFNetwork to allow WebCore to handle the
scheduling:

defaults write BUNDLE.ID WebKitForceHTTPPipeliningPriorityHigh -bool YES

WebCore.exp.in: Export _wkGetHTTPPipeliningPriority and

_wkSetHTTPPipeliningPriority.

loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequestWithPreflight):
Copy the priority to preflightRequest.

loader/ResourceLoadScheduler.cpp:

(WebCore::ResourceLoadScheduler::scheduleLoad): Refactored code
at the end of the method to use an early return.

loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::load): Set the priority on the
ResourceRequest object based on the priority of the
CachedResourceRequest before calling
ResourceLoadScheduler::scheduleSubresourceLoad().

loader/icon/IconLoader.cpp:

(WebCore::IconLoader::startLoading): Create a ResourceRequest
object and set its priority to ResourceLoadPriorityLow before
passing it to ResourceLoadScheduler::scheduleSubresourceLoad().

platform/mac/WebCoreSystemInterface.h:

(wkGetHTTPPipeliningPriority): Added.
(wkSetHTTPPipeliningPriority): Added.

platform/mac/WebCoreSystemInterface.mm:

(wkGetHTTPPipeliningPriority): Added.
(wkSetHTTPPipeliningPriority): Added.

platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::adopt): Set m_priority when
adopting a CrossThreadResourceRequestData.
(WebCore::ResourceRequestBase::copyData): Set m_priority when
creating a CrossThreadResourceRequestData.
(WebCore::ResourceRequestBase::priority): Added.
(WebCore::ResourceRequestBase::setPriority): Added.
(WebCore::equalIgnoringHeaderFields): Priorities must match when
comparing two ResourceRequest objects.

platform/network/ResourceRequestBase.h:

(WebCore::ResourceRequestBase::ResourceRequestBase): Set default
priority of new objects to ResourceLoadPriorityLow.
(WebCore::ResourceRequestBase::priority): Added declaration.
(WebCore::ResourceRequestBase::setPriority): Added declaration.
(WebCore::isHTTPPipeliningEnabled): Added.
(WebCore::shouldUseHTTPPipeliningPriority): Added.

platform/network/cf/ResourceRequestCFNet.cpp: Updated so that

Mac OS X and Windows share code.
(WebCore::initializeMaximumHTTPConnectionCountPerHost): Always
set the HTTP connection count per host, but return an
'unlimited' value when using HTTP pipelining. This method used
to be defined in ResourceRequestMac.mm for Mac OS X.
(WebCore::readBooleanPreference): Added. Helper method for
reading boolean user defaults.
(WebCore::isHTTPPipeliningEnabled): Returns value of user
default key WebKitEnableHTTPPipelining, or false if not set.
(WebCore::shouldUseHTTPPipeliningPriority): Returns value of
user default key WebKitForceHTTPPipeliningPriorityHigh, or false
if not set.

platform/network/cf/ResourceRequestCFNet.h: Updated so that

Mac OS X and Windows share code. Fixed indentation.
(WebCore::mapHTTPPipeliningPriorityToResourceLoadPriority): Added.
(WebCore::mapResourceLoadPriorityToHTTPPipeliningPriority): Added.

platform/network/mac/ResourceRequestMac.mm:

(WebCore::ResourceRequest::doUpdatePlatformRequest): Update
HTTP pipelining priority on NSMutableFURLRequest object.
(WebCore::ResourceRequest::doUpdateResourceRequest): Update
m_priority from the NSURLRequest object.
(WebCore::initializeMaximumHTTPConnectionCountPerHost): Removed.
Code is now shared with Windows in ResourceRequestCFNet.cpp.

Source/WebKit/mac:

WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Added initialization for
GetHTTPPipeliningPriority and SetHTTPPipeliningPriority.

Source/WebKit2:

WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Added initialization for
GetHTTPPipeliningPriority and SetHTTPPipeliningPriority.

WebKitLibraries:

WebKitSystemInterface.h:

New methods added for HTTP pipelining support.

(WKGetHTTPPipeliningPriority): Added.
(WKSetHTTPPipeliningPriority): Added.

Unrelated methods added after updating the header.

(WKMakeScrollbarPainter): Added.
(WKScrollbarPainterPaint): Added.

libWebKitSystemInterfaceLeopard.a: Updated.
libWebKitSystemInterfaceSnowLeopard.a: Updated.

8:36 PM Changeset in webkit [76755] by rniwa@webkit.org

1 edit
8 adds in trunk/LayoutTests

2011-01-26 Ryosuke Niwa <rniwa@webkit.org>

Reviewed Chromium Mac rebaselines for r76726.

platform/chromium-mac/fast/blockflow/vertical-baseline-alignment-expected.checksum: Added.
platform/chromium-mac/fast/blockflow/vertical-baseline-alignment-expected.png: Added.
platform/chromium-mac/fast/multicol/vertical-rl: Added.
platform/chromium-mac/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt: Added.
platform/chromium-mac/fast/table/028-vertical-expected.checksum: Added.
platform/chromium-mac/fast/table/028-vertical-expected.png: Added.
platform/chromium-mac/fast/text/complex-text-opacity-expected.checksum: Added.
platform/chromium-mac/fast/text/complex-text-opacity-expected.png: Added.

8:08 PM Changeset in webkit [76754] by Beth Dakin

9 edits in trunk/Source

Fix for <rdar://problem/8895140> Adopt WKScrollbar metrics
when using WKScrollbars.

Reviewed by Darin Adler.

Source/WebCore:

New WebKitSystemInterface Functionality.

WebCore.exp.in:
platform/mac/WebCoreSystemInterface.h:
platform/mac/WebCoreSystemInterface.mm:

Some of the terrible static arrays are now only needed in the
old non-WK code, so they are if-def'd now.

platform/mac/ScrollbarThemeMac.mm:

Just patching this function in a better way than I did
before.
(WebCore::updateArrowPlacement):

Call into WK for the right values.
(WebCore::ScrollbarThemeMac::scrollbarThickness):
(WebCore::ScrollbarThemeMac::hasThumb):
(WebCore::ScrollbarThemeMac::minimumThumbLength):

Return false if there are no buttons.
(WebCore::ScrollbarThemeMac::hasButtons):

Return an empty IntRect if there are not buttons.
(WebCore::buttonRepaintRect):

Source/WebKit/mac:

WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2:

WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

8:07 PM Changeset in webkit [76753] by rniwa@webkit.org

11 edits
25 adds in trunk/LayoutTests

2011-01-26 Ryosuke Niwa <rniwa@webkit.org>

Reviewed Chromium Windows/Linux rebaselines for r76726.

platform/chromium-linux/fast/multicol/vertical-rl/float-multicol-expected.checksum: Added.
platform/chromium-linux/fast/multicol/vertical-rl/float-multicol-expected.png: Added.
platform/chromium-linux/fast/multicol/vertical-rl/float-paginate-complex-expected.checksum: Added.
platform/chromium-linux/fast/multicol/vertical-rl/float-paginate-complex-expected.png: Added.
platform/chromium-linux/fast/multicol/vertical-rl/float-paginate-expected.checksum: Added.
platform/chromium-linux/fast/multicol/vertical-rl/float-paginate-expected.png: Added.
platform/chromium-linux/fast/multicol/vertical-rl/nested-columns-expected.checksum: Added.
platform/chromium-linux/fast/multicol/vertical-rl/nested-columns-expected.png: Added.
platform/chromium-linux/fast/multicol/vertical-rl/unsplittable-inline-block-expected.checksum: Added.
platform/chromium-linux/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png: Added.
platform/chromium-linux/fast/table/028-vertical-expected.checksum:
platform/chromium-linux/fast/table/028-vertical-expected.png:
platform/chromium-linux/fast/table/border-collapsing/003-vertical-expected.checksum:
platform/chromium-linux/fast/table/border-collapsing/003-vertical-expected.png:
platform/chromium-win/fast/multicol/vertical-rl/float-multicol-expected.checksum: Added.
platform/chromium-win/fast/multicol/vertical-rl/float-multicol-expected.png: Added.
platform/chromium-win/fast/multicol/vertical-rl/float-multicol-expected.txt: Added.
platform/chromium-win/fast/multicol/vertical-rl/float-paginate-complex-expected.checksum: Added.
platform/chromium-win/fast/multicol/vertical-rl/float-paginate-complex-expected.png: Added.
platform/chromium-win/fast/multicol/vertical-rl/float-paginate-complex-expected.txt: Added.
platform/chromium-win/fast/multicol/vertical-rl/float-paginate-expected.checksum: Added.
platform/chromium-win/fast/multicol/vertical-rl/float-paginate-expected.png: Added.
platform/chromium-win/fast/multicol/vertical-rl/float-paginate-expected.txt: Added.
platform/chromium-win/fast/multicol/vertical-rl/nested-columns-expected.checksum: Added.
platform/chromium-win/fast/multicol/vertical-rl/nested-columns-expected.png: Added.
platform/chromium-win/fast/multicol/vertical-rl/nested-columns-expected.txt: Added.
platform/chromium-win/fast/multicol/vertical-rl/unsplittable-inline-block-expected.checksum: Added.
platform/chromium-win/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png: Added.
platform/chromium-win/fast/multicol/vertical-rl/unsplittable-inline-block-expected.txt: Added.
platform/chromium-win/fast/table/028-vertical-expected.checksum:
platform/chromium-win/fast/table/028-vertical-expected.png:
platform/chromium-win/fast/table/028-vertical-expected.txt:
platform/chromium-win/fast/table/border-collapsing/003-vertical-expected.checksum:
platform/chromium-win/fast/table/border-collapsing/003-vertical-expected.png:
platform/chromium-win/fast/table/border-collapsing/003-vertical-expected.txt:

8:04 PM Changeset in webkit [76752] by rniwa@webkit.org

1 edit
47 adds in trunk/LayoutTests

2011-01-26 Ryosuke Niwa <rniwa@webkit.org>

Reviewed Chromium Windows/Linux rebaselines for r76726.

platform/chromium-linux/fast/multicol/vertical-lr/float-paginate-complex-expected.checksum: Added.
platform/chromium-linux/fast/multicol/vertical-lr/float-paginate-complex-expected.png: Added.
platform/chromium-linux/fast/multicol/vertical-lr/float-paginate-expected.checksum: Added.
platform/chromium-linux/fast/multicol/vertical-lr/float-paginate-expected.png: Added.
platform/chromium-linux/fast/multicol/vertical-lr/nested-columns-expected.checksum: Added.
platform/chromium-linux/fast/multicol/vertical-lr/nested-columns-expected.png: Added.
platform/chromium-linux/fast/multicol/vertical-lr/unsplittable-inline-block-expected.checksum: Added.
platform/chromium-linux/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png: Added.
platform/chromium-linux/fast/multicol/vertical-rl: Added.
platform/chromium-linux/fast/multicol/vertical-rl/border-padding-pagination-expected.checksum: Added.
platform/chromium-linux/fast/multicol/vertical-rl/border-padding-pagination-expected.png: Added.
platform/chromium-linux/fast/multicol/vertical-rl/column-break-with-balancing-expected.checksum: Added.
platform/chromium-linux/fast/multicol/vertical-rl/column-break-with-balancing-expected.png: Added.
platform/chromium-linux/fast/multicol/vertical-rl/column-count-with-rules-expected.checksum: Added.
platform/chromium-linux/fast/multicol/vertical-rl/column-count-with-rules-expected.png: Added.
platform/chromium-linux/fast/multicol/vertical-rl/column-rules-expected.checksum: Added.
platform/chromium-linux/fast/multicol/vertical-rl/column-rules-expected.png: Added.
platform/chromium-linux/fast/multicol/vertical-rl/float-avoidance-expected.checksum: Added.
platform/chromium-linux/fast/multicol/vertical-rl/float-avoidance-expected.png: Added.
platform/chromium-win/fast/multicol/vertical-lr/float-paginate-complex-expected.checksum: Added.
platform/chromium-win/fast/multicol/vertical-lr/float-paginate-complex-expected.png: Added.
platform/chromium-win/fast/multicol/vertical-lr/float-paginate-complex-expected.txt: Added.
platform/chromium-win/fast/multicol/vertical-lr/float-paginate-expected.checksum: Added.
platform/chromium-win/fast/multicol/vertical-lr/float-paginate-expected.png: Added.
platform/chromium-win/fast/multicol/vertical-lr/float-paginate-expected.txt: Added.
platform/chromium-win/fast/multicol/vertical-lr/nested-columns-expected.checksum: Added.
platform/chromium-win/fast/multicol/vertical-lr/nested-columns-expected.png: Added.
platform/chromium-win/fast/multicol/vertical-lr/nested-columns-expected.txt: Added.
platform/chromium-win/fast/multicol/vertical-lr/unsplittable-inline-block-expected.checksum: Added.
platform/chromium-win/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png: Added.
platform/chromium-win/fast/multicol/vertical-lr/unsplittable-inline-block-expected.txt: Added.
platform/chromium-win/fast/multicol/vertical-rl: Added.
platform/chromium-win/fast/multicol/vertical-rl/border-padding-pagination-expected.checksum: Added.
platform/chromium-win/fast/multicol/vertical-rl/border-padding-pagination-expected.png: Added.
platform/chromium-win/fast/multicol/vertical-rl/border-padding-pagination-expected.txt: Added.
platform/chromium-win/fast/multicol/vertical-rl/column-break-with-balancing-expected.checksum: Added.
platform/chromium-win/fast/multicol/vertical-rl/column-break-with-balancing-expected.png: Added.
platform/chromium-win/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt: Added.
platform/chromium-win/fast/multicol/vertical-rl/column-count-with-rules-expected.checksum: Added.
platform/chromium-win/fast/multicol/vertical-rl/column-count-with-rules-expected.png: Added.
platform/chromium-win/fast/multicol/vertical-rl/column-count-with-rules-expected.txt: Added.
platform/chromium-win/fast/multicol/vertical-rl/column-rules-expected.checksum: Added.
platform/chromium-win/fast/multicol/vertical-rl/column-rules-expected.png: Added.
platform/chromium-win/fast/multicol/vertical-rl/column-rules-expected.txt: Added.
platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.checksum: Added.
platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.png: Added.
platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.txt: Added.

7:59 PM Changeset in webkit [76751] by rniwa@webkit.org

16 edits
32 adds
1 delete in trunk/LayoutTests

2011-01-26 Ryosuke Niwa <rniwa@webkit.org>

Reviewed Chromium Windows/Linux rebaselines for r76726.

platform/chromium-linux/fast/blockflow/vertical-baseline-alignment-expected.checksum:
platform/chromium-linux/fast/blockflow/vertical-baseline-alignment-expected.png:
platform/chromium-linux/fast/lists/002-vertical-expected.checksum:
platform/chromium-linux/fast/lists/002-vertical-expected.png:
platform/chromium-linux/fast/lists/002-vertical-expected.txt: Removed.
platform/chromium-linux/fast/lists/003-vertical-expected.checksum:
platform/chromium-linux/fast/lists/003-vertical-expected.png:
platform/chromium-linux/fast/multicol/vertical-lr: Added.
platform/chromium-linux/fast/multicol/vertical-lr/border-padding-pagination-expected.checksum: Added.
platform/chromium-linux/fast/multicol/vertical-lr/border-padding-pagination-expected.png: Added.
platform/chromium-linux/fast/multicol/vertical-lr/column-break-with-balancing-expected.checksum: Added.
platform/chromium-linux/fast/multicol/vertical-lr/column-break-with-balancing-expected.png: Added.
platform/chromium-linux/fast/multicol/vertical-lr/column-count-with-rules-expected.checksum: Added.
platform/chromium-linux/fast/multicol/vertical-lr/column-count-with-rules-expected.png: Added.
platform/chromium-linux/fast/multicol/vertical-lr/column-rules-expected.checksum: Added.
platform/chromium-linux/fast/multicol/vertical-lr/column-rules-expected.png: Added.
platform/chromium-linux/fast/multicol/vertical-lr/float-avoidance-expected.checksum: Added.
platform/chromium-linux/fast/multicol/vertical-lr/float-avoidance-expected.png: Added.
platform/chromium-linux/fast/multicol/vertical-lr/float-multicol-expected.checksum: Added.
platform/chromium-linux/fast/multicol/vertical-lr/float-multicol-expected.png: Added.
platform/chromium-win/fast/blockflow/vertical-baseline-alignment-expected.checksum:
platform/chromium-win/fast/blockflow/vertical-baseline-alignment-expected.png:
platform/chromium-win/fast/blockflow/vertical-baseline-alignment-expected.txt:
platform/chromium-win/fast/lists/002-vertical-expected.checksum:
platform/chromium-win/fast/lists/002-vertical-expected.png:
platform/chromium-win/fast/lists/002-vertical-expected.txt:
platform/chromium-win/fast/lists/003-vertical-expected.checksum:
platform/chromium-win/fast/lists/003-vertical-expected.png:
platform/chromium-win/fast/lists/003-vertical-expected.txt:
platform/chromium-win/fast/multicol/vertical-lr: Added.
platform/chromium-win/fast/multicol/vertical-lr/border-padding-pagination-expected.checksum: Added.
platform/chromium-win/fast/multicol/vertical-lr/border-padding-pagination-expected.png: Added.
platform/chromium-win/fast/multicol/vertical-lr/border-padding-pagination-expected.txt: Added.
platform/chromium-win/fast/multicol/vertical-lr/column-break-with-balancing-expected.checksum: Added.
platform/chromium-win/fast/multicol/vertical-lr/column-break-with-balancing-expected.png: Added.
platform/chromium-win/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt: Added.
platform/chromium-win/fast/multicol/vertical-lr/column-count-with-rules-expected.checksum: Added.
platform/chromium-win/fast/multicol/vertical-lr/column-count-with-rules-expected.png: Added.
platform/chromium-win/fast/multicol/vertical-lr/column-count-with-rules-expected.txt: Added.
platform/chromium-win/fast/multicol/vertical-lr/column-rules-expected.checksum: Added.
platform/chromium-win/fast/multicol/vertical-lr/column-rules-expected.png: Added.
platform/chromium-win/fast/multicol/vertical-lr/column-rules-expected.txt: Added.
platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.checksum: Added.
platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.png: Added.
platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.txt: Added.
platform/chromium-win/fast/multicol/vertical-lr/float-multicol-expected.checksum: Added.
platform/chromium-win/fast/multicol/vertical-lr/float-multicol-expected.png: Added.
platform/chromium-win/fast/multicol/vertical-lr/float-multicol-expected.txt: Added.

7:13 PM Changeset in webkit [76750] by bweinstein@apple.com

3 edits in trunk/LayoutTests

Rebaseline Windows fast/blockfow results after r76726.

platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:
platform/win/fast/blockflow/vertical-baseline-alignment-expected.txt:

6:46 PM Changeset in webkit [76749] by Martin Robinson

29 edits in trunk

2011-01-26 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Pixel dumps do not include scrollbars in output images
https://bugs.webkit.org/show_bug.cgi?id=53216

Update expected results which should show scrollbars.

platform/gtk/css2.1/t0803-c5502-mrgn-r-02-c-expected.checksum:
platform/gtk/css2.1/t0803-c5502-mrgn-r-02-c-expected.png:
platform/gtk/css2.1/t0803-c5505-mrgn-02-c-expected.checksum:
platform/gtk/css2.1/t0803-c5505-mrgn-02-c-expected.png:
platform/gtk/css2.1/t080301-c411-vt-mrgn-00-b-expected.checksum:
platform/gtk/css2.1/t080301-c411-vt-mrgn-00-b-expected.png:
platform/gtk/css2.1/t0905-c5525-fltclr-00-c-ag-expected.checksum:
platform/gtk/css2.1/t0905-c5525-fltclr-00-c-ag-expected.png:
platform/gtk/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.checksum:
platform/gtk/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.png:
platform/gtk/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
platform/gtk/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
platform/gtk/css2.1/t0905-c5526-fltclr-00-c-ag-expected.checksum:
platform/gtk/css2.1/t0905-c5526-fltclr-00-c-ag-expected.png:
platform/gtk/css2.1/t1002-c5523-width-02-b-g-expected.checksum:
platform/gtk/css2.1/t1002-c5523-width-02-b-g-expected.png:
platform/gtk/css2.1/t1202-counters-08-b-expected.checksum:
platform/gtk/css2.1/t1202-counters-08-b-expected.png:
platform/gtk/css2.1/t1202-counters-09-b-expected.checksum:
platform/gtk/css2.1/t1202-counters-09-b-expected.png:
platform/gtk/css2.1/t140201-c535-bg-fixd-00-b-g-expected.checksum:
platform/gtk/css2.1/t140201-c535-bg-fixd-00-b-g-expected.png:
platform/gtk/css2.1/t140201-c537-bgfxps-00-c-ag-expected.checksum:
platform/gtk/css2.1/t140201-c537-bgfxps-00-c-ag-expected.png:
platform/gtk/css2.1/t1508-c527-font-07-b-expected.checksum:
platform/gtk/css2.1/t1508-c527-font-07-b-expected.png:

2011-01-26 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Pixel dumps do not include scrollbars in output images
https://bugs.webkit.org/show_bug.cgi?id=53216

Show scrollbars in pixel dumps. This will fix pixel dumps for tests
that have scrollbars.

DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow instead of the web view itself.

6:20 PM Changeset in webkit [76748] by Martin Robinson

8 edits in trunk/LayoutTests

2011-01-26 Martin Robinson <mrobinson@igalia.com>

[GTK] Text input controls do not react properly to CSS styling
https://bugs.webkit.org/show_bug.cgi?id=40855

Unskip tests which were previously skipped due to issue #40855.
The bug is closed now, so it's safe to rebaseline the tests and
unskip them.

platform/gtk/Skipped: Unskip tests.
platform/gtk/fast/forms/basic-selects-expected.checksum:
platform/gtk/fast/forms/basic-selects-expected.png:
platform/gtk/fast/forms/basic-selects-expected.txt:
platform/gtk/fast/forms/basic-textareas-quirks-expected.checksum:
platform/gtk/fast/forms/basic-textareas-quirks-expected.png:
platform/gtk/fast/forms/basic-textareas-quirks-expected.txt:

6:02 PM Changeset in webkit [76747] by Martin Robinson

2 edits in trunk/LayoutTests

2011-01-26 Martin Robinson <mrobinson@igalia.com>

[GTK] media/unsupported-rtsp.html fails after timing out
https://bugs.webkit.org/show_bug.cgi?id=53056

platform/gtk/Skipped: Update the skipped list to explain why this test is skipped and should remain skipped.

6:01 PM Changeset in webkit [76746] by dpranke@chromium.org

2 edits in trunk/Tools

2011-01-26 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

Fix regression introduced in r76322 ... new-run-webkit-tests
was attempting to save the image diff output as a UTF-8-encoded
file.

https://bugs.webkit.org/show_bug.cgi?id=53210

Scripts/webkitpy/layout_tests/port/webkit.py:

5:55 PM Changeset in webkit [76745] by weinig@apple.com

21 edits
2 adds in trunk/Source

Add events to represent the start/end of a gesture scroll
https://bugs.webkit.org/show_bug.cgi?id=53215

Reviewed by Maciej Stachowiak.

Source/JavaScriptCore:

wtf/Platform.h: Add ENABLE for gesture events.

Source/WebCore:

WebCore.exp.in:

Add new file.

WebCore.xcodeproj/project.pbxproj:

Add new file.

page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent):

page/EventHandler.h:

Add entry point for handling gesture events.

platform/PlatformGestureEvent.h: Added.

(WebCore::PlatformGestureEvent::PlatformGestureEvent):
(WebCore::PlatformGestureEvent::type):
(WebCore::PlatformGestureEvent::position):
(WebCore::PlatformGestureEvent::globalPosition):
(WebCore::PlatformGestureEvent::timestamp):
Add platform agnostic representation of a gesture event.

Source/WebKit2:

Scripts/webkit2/messages.py:
Shared/WebEvent.h:

(WebKit::WebGestureEvent::WebGestureEvent):
(WebKit::WebGestureEvent::position):
(WebKit::WebGestureEvent::globalPosition):

Shared/WebEventConversion.cpp:

(WebKit::WebKit2PlatformGestureEvent::WebKit2PlatformGestureEvent):
(WebKit::platform):

Shared/WebEventConversion.h:
Shared/WebGestureEvent.cpp: Added.

(WebKit::WebGestureEvent::WebGestureEvent):
(WebKit::WebGestureEvent::encode):
(WebKit::WebGestureEvent::decode):
(WebKit::WebGestureEvent::isGestureEventType):

Shared/mac/WebEventFactory.h:
Shared/mac/WebEventFactory.mm:

(WebKit::gestureEventTypeForEvent):
(WebKit::WebEventFactory::createWebGestureEvent):

UIProcess/API/mac/WKView.mm:

(-[WKView shortCircuitedEndGestureWithEvent:]):
(-[WKView beginGestureWithEvent:]):
(-[WKView viewDidMoveToWindow]):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::handleGestureEvent):
(WebKit::WebPageProxy::didReceiveEvent):

UIProcess/WebPageProxy.h:
WebKit2.xcodeproj/project.pbxproj:
WebProcess/WebPage/WebPage.cpp:

(WebKit::handleGestureEvent):
(WebKit::WebPage::gestureEvent):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

Pipe gesture events down to WebCore.

5:45 PM Changeset in webkit [76744] by tkent@chromium.org

2 edits in trunk/Source/WebKit/chromium

2011-01-26 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] WebFrame::forms() should not return empty WebFormElements
https://bugs.webkit.org/show_bug.cgi?id=53204

src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::forms):
- Should iterate by forms->length(), not the number of HTMLElements.
- Do not increment the index for "temp" if a node is not an HTMLElement.

5:39 PM Changeset in webkit [76743] by mitz@apple.com

38 edits
12 adds in trunk

<rdar://problem/8446709> Allow inter-ideograph justification for CJK
https://bugs.webkit.org/show_bug.cgi?id=53184

Reviewed by Dave Hyatt.

Source/WebCore:

Tests: fast/text/justify-ideograph-complex.html

fast/text/justify-ideograph-simple.html
fast/text/justify-ideograph-vertical.html

html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawTextInternal): Corrected the type of the third parameter
passed to the TextRun constructor and added the trailingExpansionBehavior parameter.

platform/graphics/Font.cpp:

(WebCore::Font::expansionOpportunityCount): Added. Returns the number of expansion opportunities
for text justification. On entry, isAfterExpansion says whether an expansion opportunity exists
before the first character. On return, isAfterExpansion says whether an expansion opportunity
exists after the last character.

platform/graphics/Font.h:
platform/graphics/GlyphBuffer.h:

(WebCore::GlyphBuffer::expandLastAdvance): Added.

platform/graphics/TextRun.h:

(WebCore::TextRun::TextRun): Added a TrailingExpansionBehavior parameter to the constructors.
Renamed padding to expansion.
(WebCore::TextRun::expansion): Renamed padding() to this.
(WebCore::TextRun::allowsTrailingExpansion): Added this accessor.

platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::WidthIterator): Initialize m_isAfterExpansion. Use Font::expansionOpportunityCount()
and adjust the count if it includes a trailing expansion opportunity but the run disallows trailing
expansion.
(WebCore::WidthIterator::advance): Apply expansion before and after CJK ideographs.
(WebCore::WidthIterator::advanceOneCharacter): Changed to not clear the GlyphBuffer so that advance()
can expand the last advance if it is followed by a CJK ideograph.

platform/graphics/WidthIterator.h: Renamed m_padding to m_expansion and m_padPerSpace

to m_expansionPerOpportunity.

platform/graphics/chromium/FontChromiumWin.cpp: