⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 30, 2011:

11:18 PM Changeset in webkit [77114] by tkent@chromium.org
  • 7 edits
    2 adds in trunk

2011-01-30 Kenichi Ishibashi <​bashi@google.com>

Reviewed by Kent Tamura.

Dangling form associated elements should not be registered on the document
​https://bugs.webkit.org/show_bug.cgi?id=53223

Adds insertedIntoDocument() and remvoedFromDocument() to
FormAssociatedElement class to register the element on the document
if and only if it actually inserted into (removed from) the document.

Test: fast/forms/dangling-form-element-crash.html

  • html/FormAssociatedElement.cpp: (WebCore::FormAssociatedElement::insertedIntoDocument): Added. (WebCore::FormAssociatedElement::removedFromDocument): Ditto. (WebCore::FormAssociatedElement::insertedIntoTree): Don't register the element to a document. (WebCore::FormAssociatedElement::removedFromTree): Don't unregister the element from a document.
  • html/FormAssociatedElement.h:
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::insertedIntoDocument): Added. (WebCore::HTMLFormControlElement::removedFromDocument): Ditto.
  • html/HTMLFormControlElement.h:
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::insertedIntoDocument): Calls FormAssociatedElement::insertedIntoDocument(). (WebCore::HTMLObjectElement::removedFromDocument): Calls FormAssociatedElement::removedFromDocument().

2011-01-30 Kenichi Ishibashi <​bashi@google.com>

Reviewed by Kent Tamura.

Dangling form associated elements should not be registered on the document
​https://bugs.webkit.org/show_bug.cgi?id=53223

Adds a test that ensures dangling form associated elements are not
registered on the document.

  • fast/forms/dangling-form-element-crash-expected.txt: Added.
  • fast/forms/dangling-form-element-crash.html: Added.
10:56 PM Changeset in webkit [77113] by Csaba Osztrogonác
  • 127 edits
    2 deletes in trunk/Source

2011-01-30 Csaba Osztrogonác <Csaba Osztrogonác>

Unreviewed, rolling out r77098, r77099, r77100, r77109, and
r77111.
​http://trac.webkit.org/changeset/77098
​http://trac.webkit.org/changeset/77099
​http://trac.webkit.org/changeset/77100
​http://trac.webkit.org/changeset/77109
​http://trac.webkit.org/changeset/77111
​https://bugs.webkit.org/show_bug.cgi?id=53219

Qt build is broken

  • API/JSCallbackObject.h: (JSC::JSCallbackObjectData::setPrivateProperty): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::getPrivateProperty): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::setPrivateProperty): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::markChildren): (JSC::JSCallbackObject::setPrivateProperty):
  • API/JSCallbackObjectFunctions.h: (JSC::::put): (JSC::::staticFunctionGetter):
  • API/JSObjectRef.cpp: (JSObjectMakeConstructor): (JSObjectSetPrivateProperty):
  • API/JSWeakObjectMapRefInternal.h:
  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::markAggregate):
  • bytecode/CodeBlock.h: (JSC::CodeBlock::globalObject):
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): (JSC::BytecodeGenerator::emitJumpIfNotFunctionCall): (JSC::BytecodeGenerator::emitJumpIfNotFunctionApply): (JSC::BytecodeGenerator::findScopedProperty):
  • debugger/Debugger.cpp: (JSC::evaluateInGlobalCallFrame):
  • debugger/DebuggerActivation.cpp: (JSC::DebuggerActivation::DebuggerActivation): (JSC::DebuggerActivation::markChildren):
  • debugger/DebuggerActivation.h:
  • debugger/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::evaluate):
  • interpreter/CallFrame.h: (JSC::ExecState::exception):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::resolve): (JSC::Interpreter::resolveSkip): (JSC::Interpreter::resolveGlobal): (JSC::Interpreter::resolveGlobalDynamic): (JSC::Interpreter::resolveBaseAndProperty): (JSC::Interpreter::unwindCallFrame): (JSC::appendSourceToError): (JSC::Interpreter::execute): (JSC::Interpreter::tryCacheGetByID): (JSC::Interpreter::privateExecute):
  • jit/JITStubs.cpp: (JSC::JITThunks::tryCacheGetByID): (JSC::DEFINE_STUB_FUNCTION):
  • jsc.cpp: (GlobalObject::GlobalObject):
  • runtime/ArgList.cpp: (JSC::MarkedArgumentBuffer::markLists):
  • runtime/Arguments.cpp: (JSC::Arguments::markChildren): (JSC::Arguments::getOwnPropertySlot): (JSC::Arguments::getOwnPropertyDescriptor): (JSC::Arguments::put):
  • runtime/Arguments.h: (JSC::Arguments::setActivation): (JSC::Arguments::Arguments):
  • runtime/ArrayConstructor.cpp: (JSC::ArrayConstructor::ArrayConstructor): (JSC::constructArrayWithSizeQuirk):
  • runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncSplice):
  • runtime/BatchedTransitionOptimizer.h: (JSC::BatchedTransitionOptimizer::BatchedTransitionOptimizer): (JSC::BatchedTransitionOptimizer::~BatchedTransitionOptimizer):
  • runtime/BooleanConstructor.cpp: (JSC::BooleanConstructor::BooleanConstructor): (JSC::constructBoolean): (JSC::constructBooleanFromImmediateBoolean):
  • runtime/BooleanPrototype.cpp: (JSC::BooleanPrototype::BooleanPrototype):
  • runtime/ConservativeSet.cpp: (JSC::ConservativeSet::grow):
  • runtime/ConservativeSet.h: (JSC::ConservativeSet::~ConservativeSet): (JSC::ConservativeSet::mark):
  • runtime/DateConstructor.cpp: (JSC::DateConstructor::DateConstructor):
  • runtime/DateInstance.cpp: (JSC::DateInstance::DateInstance):
  • runtime/DatePrototype.cpp: (JSC::dateProtoFuncSetTime): (JSC::setNewValueFromTimeArgs): (JSC::setNewValueFromDateArgs): (JSC::dateProtoFuncSetYear):
  • runtime/ErrorConstructor.cpp: (JSC::ErrorConstructor::ErrorConstructor):
  • runtime/ErrorInstance.cpp: (JSC::ErrorInstance::ErrorInstance):
  • runtime/ErrorPrototype.cpp: (JSC::ErrorPrototype::ErrorPrototype):
  • runtime/FunctionConstructor.cpp: (JSC::FunctionConstructor::FunctionConstructor):
  • runtime/FunctionPrototype.cpp: (JSC::FunctionPrototype::FunctionPrototype):
  • runtime/GetterSetter.cpp: (JSC::GetterSetter::markChildren):
  • runtime/GetterSetter.h: (JSC::GetterSetter::GetterSetter): (JSC::GetterSetter::getter): (JSC::GetterSetter::setGetter): (JSC::GetterSetter::setter): (JSC::GetterSetter::setSetter):
  • runtime/GlobalEvalFunction.cpp: (JSC::GlobalEvalFunction::GlobalEvalFunction): (JSC::GlobalEvalFunction::markChildren):
  • runtime/GlobalEvalFunction.h: (JSC::GlobalEvalFunction::cachedGlobalObject):
  • runtime/Heap.cpp: (JSC::Heap::markProtectedObjects): (JSC::Heap::markTempSortVectors): (JSC::Heap::markRoots):
  • runtime/InternalFunction.cpp: (JSC::InternalFunction::InternalFunction):
  • runtime/JSAPIValueWrapper.h: (JSC::JSAPIValueWrapper::value): (JSC::JSAPIValueWrapper::JSAPIValueWrapper):
  • runtime/JSActivation.cpp: (JSC::JSActivation::markChildren): (JSC::JSActivation::put):
  • runtime/JSArray.cpp: (JSC::JSArray::JSArray): (JSC::JSArray::getOwnPropertySlot): (JSC::JSArray::getOwnPropertyDescriptor): (JSC::JSArray::put): (JSC::JSArray::putSlowCase): (JSC::JSArray::deleteProperty): (JSC::JSArray::increaseVectorLength): (JSC::JSArray::setLength): (JSC::JSArray::pop): (JSC::JSArray::push): (JSC::JSArray::unshiftCount): (JSC::JSArray::sort): (JSC::JSArray::fillArgList): (JSC::JSArray::copyToRegisters): (JSC::JSArray::compactForSorting):
  • runtime/JSArray.h: (JSC::JSArray::getIndex): (JSC::JSArray::setIndex): (JSC::JSArray::uncheckedSetIndex): (JSC::JSArray::markChildrenDirect):
  • runtime/JSByteArray.cpp: (JSC::JSByteArray::JSByteArray):
  • runtime/JSCell.h: (JSC::JSCell::JSValue::toThisObject): (JSC::JSCell::MarkStack::append):
  • runtime/JSFunction.cpp: (JSC::JSFunction::JSFunction): (JSC::JSFunction::getOwnPropertySlot):
  • runtime/JSGlobalData.h:
  • runtime/JSGlobalObject.cpp: (JSC::markIfNeeded): (JSC::JSGlobalObject::reset): (JSC::JSGlobalObject::resetPrototype): (JSC::JSGlobalObject::markChildren):
  • runtime/JSGlobalObject.h: (JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData): (JSC::JSGlobalObject::regExpConstructor): (JSC::JSGlobalObject::errorConstructor): (JSC::JSGlobalObject::evalErrorConstructor): (JSC::JSGlobalObject::rangeErrorConstructor): (JSC::JSGlobalObject::referenceErrorConstructor): (JSC::JSGlobalObject::syntaxErrorConstructor): (JSC::JSGlobalObject::typeErrorConstructor): (JSC::JSGlobalObject::URIErrorConstructor): (JSC::JSGlobalObject::evalFunction): (JSC::JSGlobalObject::objectPrototype): (JSC::JSGlobalObject::functionPrototype): (JSC::JSGlobalObject::arrayPrototype): (JSC::JSGlobalObject::booleanPrototype): (JSC::JSGlobalObject::stringPrototype): (JSC::JSGlobalObject::numberPrototype): (JSC::JSGlobalObject::datePrototype): (JSC::JSGlobalObject::regExpPrototype): (JSC::JSGlobalObject::methodCallDummy): (JSC::Structure::prototypeForLookup): (JSC::constructArray):
  • runtime/JSONObject.cpp: (JSC::Stringifier::Holder::object): (JSC::Stringifier::markAggregate): (JSC::Stringifier::stringify): (JSC::Stringifier::Holder::appendNextProperty): (JSC::Walker::callReviver): (JSC::Walker::walk):
  • runtime/JSObject.cpp: (JSC::JSObject::defineGetter): (JSC::JSObject::defineSetter): (JSC::JSObject::removeDirect): (JSC::JSObject::putDirectFunction): (JSC::JSObject::putDirectFunctionWithoutTransition): (JSC::putDescriptor): (JSC::JSObject::defineOwnProperty):
  • runtime/JSObject.h: (JSC::JSObject::getDirectOffset): (JSC::JSObject::putDirectOffset): (JSC::JSObject::flattenDictionaryObject): (JSC::JSObject::putDirectInternal): (JSC::JSObject::putDirect): (JSC::JSObject::putDirectFunction): (JSC::JSObject::putDirectWithoutTransition): (JSC::JSObject::putDirectFunctionWithoutTransition): (JSC::JSValue::putDirect): (JSC::JSObject::allocatePropertyStorageInline): (JSC::JSObject::markChildrenDirect):
  • runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::JSPropertyNameIterator): (JSC::JSPropertyNameIterator::get):
  • runtime/JSPropertyNameIterator.h:
  • runtime/JSStaticScopeObject.cpp: (JSC::JSStaticScopeObject::markChildren):
  • runtime/JSString.cpp: (JSC::StringObject::create):
  • runtime/JSValue.h:
  • runtime/JSWrapperObject.cpp: (JSC::JSWrapperObject::markChildren):
  • runtime/JSWrapperObject.h: (JSC::JSWrapperObject::internalValue): (JSC::JSWrapperObject::setInternalValue):
  • runtime/LiteralParser.cpp: (JSC::LiteralParser::parse):
  • runtime/Lookup.cpp: (JSC::setUpStaticFunctionSlot):
  • runtime/Lookup.h: (JSC::lookupPut):
  • runtime/MarkStack.h: (JSC::MarkStack::appendValues):
  • runtime/MathObject.cpp: (JSC::MathObject::MathObject):
  • runtime/NativeErrorConstructor.cpp: (JSC::NativeErrorConstructor::NativeErrorConstructor):
  • runtime/NativeErrorPrototype.cpp: (JSC::NativeErrorPrototype::NativeErrorPrototype):
  • runtime/NumberConstructor.cpp: (JSC::NumberConstructor::NumberConstructor): (JSC::constructWithNumberConstructor):
  • runtime/NumberObject.cpp: (JSC::constructNumber):
  • runtime/NumberPrototype.cpp: (JSC::NumberPrototype::NumberPrototype):
  • runtime/ObjectConstructor.cpp: (JSC::ObjectConstructor::ObjectConstructor): (JSC::objectConstructorGetOwnPropertyDescriptor):
  • runtime/Operations.h: (JSC::normalizePrototypeChain): (JSC::resolveBase):
  • runtime/PrototypeFunction.cpp: (JSC::PrototypeFunction::PrototypeFunction):
  • runtime/PutPropertySlot.h: (JSC::PutPropertySlot::setExistingProperty): (JSC::PutPropertySlot::setNewProperty): (JSC::PutPropertySlot::base):
  • runtime/RegExpConstructor.cpp: (JSC::RegExpConstructor::RegExpConstructor):
  • runtime/ScopeChain.cpp: (JSC::ScopeChainNode::print):
  • runtime/ScopeChain.h: (JSC::ScopeChainNode::~ScopeChainNode): (JSC::ScopeChainIterator::operator*): (JSC::ScopeChainIterator::operator->): (JSC::ScopeChain::top):
  • runtime/ScopeChainMark.h: (JSC::ScopeChain::markAggregate):
  • runtime/SmallStrings.cpp: (JSC::isMarked): (JSC::SmallStrings::markChildren):
  • runtime/SmallStrings.h: (JSC::SmallStrings::emptyString): (JSC::SmallStrings::singleCharacterString): (JSC::SmallStrings::singleCharacterStrings):
  • runtime/StringConstructor.cpp: (JSC::StringConstructor::StringConstructor):
  • runtime/StringObject.cpp: (JSC::StringObject::StringObject):
  • runtime/StringObject.h:
  • runtime/StringPrototype.cpp: (JSC::StringPrototype::StringPrototype):
  • runtime/Structure.cpp: (JSC::Structure::Structure): (JSC::Structure::addPropertyTransition): (JSC::Structure::toDictionaryTransition): (JSC::Structure::flattenDictionaryStructure):
  • runtime/Structure.h: (JSC::Structure::storedPrototype):
  • runtime/WeakGCMap.h: (JSC::WeakGCMap::uncheckedGet): (JSC::WeakGCMap::isValid): (JSC::::get): (JSC::::take): (JSC::::set): (JSC::::uncheckedRemove):
  • runtime/WriteBarrier.h: Removed.

2011-01-30 Csaba Osztrogonác <Csaba Osztrogonác>

Unreviewed, rolling out r77098, r77099, r77100, r77109, and
r77111.
​http://trac.webkit.org/changeset/77098
​http://trac.webkit.org/changeset/77099
​http://trac.webkit.org/changeset/77100
​http://trac.webkit.org/changeset/77109
​http://trac.webkit.org/changeset/77111
​https://bugs.webkit.org/show_bug.cgi?id=53219

Qt build is broken

  • JSValueWrapper.cpp: (JSValueWrapper::JSObjectMark):

2011-01-30 Csaba Osztrogonác <Csaba Osztrogonác>

Unreviewed, rolling out r77098, r77099, r77100, r77109, and
r77111.
​http://trac.webkit.org/changeset/77098
​http://trac.webkit.org/changeset/77099
​http://trac.webkit.org/changeset/77100
​http://trac.webkit.org/changeset/77109
​http://trac.webkit.org/changeset/77111
​https://bugs.webkit.org/show_bug.cgi?id=53219

Qt build is broken

  • ForwardingHeaders/runtime/WriteBarrier.h: Removed.
  • WebCore.exp.in:
  • bindings/js/DOMWrapperWorld.h:
  • bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::JSAudioConstructor):
  • bindings/js/JSDOMBinding.cpp: (WebCore::markDOMNodesForDocument): (WebCore::markDOMObjectWrapper): (WebCore::markDOMNodeWrapper):
  • bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::markChildren): (WebCore::JSDOMGlobalObject::setInjectedScript): (WebCore::JSDOMGlobalObject::injectedScript):
  • bindings/js/JSDOMGlobalObject.h: (WebCore::JSDOMGlobalObject::JSDOMGlobalObjectData::JSDOMGlobalObjectData): (WebCore::getDOMConstructor):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation): (WebCore::DialogHandler::dialogCreated):
  • bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::JSDOMWindowShell): (WebCore::JSDOMWindowShell::setWindow): (WebCore::JSDOMWindowShell::markChildren): (WebCore::JSDOMWindowShell::unwrappedObject):
  • bindings/js/JSDOMWindowShell.h: (WebCore::JSDOMWindowShell::window): (WebCore::JSDOMWindowShell::setWindow):
  • bindings/js/JSDeviceMotionEventCustom.cpp: (WebCore::createAccelerationObject): (WebCore::createRotationRateObject):
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::JSEventListener): (WebCore::JSEventListener::markJSFunction):
  • bindings/js/JSEventListener.h: (WebCore::JSEventListener::jsFunction):
  • bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::setAll):
  • bindings/js/JSImageConstructor.cpp: (WebCore::JSImageConstructor::JSImageConstructor):
  • bindings/js/JSImageDataCustom.cpp: (WebCore::toJS):
  • bindings/js/JSJavaScriptCallFrameCustom.cpp: (WebCore::JSJavaScriptCallFrame::scopeChain): (WebCore::JSJavaScriptCallFrame::scopeType):
  • bindings/js/JSNodeFilterCondition.cpp: (WebCore::JSNodeFilterCondition::markAggregate): (WebCore::JSNodeFilterCondition::acceptNode):
  • bindings/js/JSNodeFilterCondition.h:
  • bindings/js/JSNodeFilterCustom.cpp:
  • bindings/js/JSOptionConstructor.cpp: (WebCore::JSOptionConstructor::JSOptionConstructor):
  • bindings/js/JSSQLResultSetRowListCustom.cpp: (WebCore::JSSQLResultSetRowList::item):
  • bindings/js/ScriptCachedFrameData.cpp: (WebCore::ScriptCachedFrameData::restore):
  • bindings/js/ScriptObject.cpp: (WebCore::ScriptGlobalObject::set):
  • bindings/js/SerializedScriptValue.cpp: (WebCore::CloneDeserializer::putProperty):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::QtInstance): (JSC::Bindings::QtInstance::removeCachedMethod): (JSC::Bindings::QtInstance::markAggregate):
  • bridge/qt/qt_instance.h:
  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtRuntimeMetaMethod::QtRuntimeMetaMethod): (JSC::Bindings::QtRuntimeMetaMethod::markChildren): (JSC::Bindings::QtRuntimeMetaMethod::connectGetter): (JSC::Bindings::QtRuntimeMetaMethod::disconnectGetter):
  • bridge/qt/qt_runtime.h:
  • bridge/runtime_root.cpp: (JSC::Bindings::RootObject::invalidate):
  • bridge/runtime_root.h:
  • dom/Document.h:

2011-01-30 Csaba Osztrogonác <Csaba Osztrogonác>

Unreviewed, rolling out r77098, r77099, r77100, r77109, and
r77111.
​http://trac.webkit.org/changeset/77098
​http://trac.webkit.org/changeset/77099
​http://trac.webkit.org/changeset/77100
​http://trac.webkit.org/changeset/77109
​http://trac.webkit.org/changeset/77111
​https://bugs.webkit.org/show_bug.cgi?id=53219

Qt build is broken

  • WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame scopeChain]):
10:18 PM Changeset in webkit [77112] by Simon Fraser
  • 8 edits in trunk/Source/WebCore

2011-01-30 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r77107.
​http://trac.webkit.org/changeset/77107
​https://bugs.webkit.org/show_bug.cgi?id=53412

Caused 5 new form-related test crashes (Requested by smfr on
#webkit).

  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): (WebCore::nameToPseudoTypeMap): (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h:
  • html/HTMLProgressElement.cpp: (WebCore::HTMLProgressElement::parseMappedAttribute): (WebCore::HTMLProgressElement::attach):
  • html/HTMLProgressElement.h:
  • rendering/RenderProgress.cpp: (WebCore::RenderProgress::~RenderProgress): (WebCore::RenderProgress::updateFromElement): (WebCore::RenderProgress::layoutParts): (WebCore::RenderProgress::shouldHaveParts):
  • rendering/RenderProgress.h:
  • rendering/style/RenderStyleConstants.h:
10:05 PM Changeset in webkit [77111] by Simon Fraser
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-30 Simon Fraser <Simon Fraser>

Build fix the build fix. I assume Oliver meant m_cell, not m_value.

  • runtime/WriteBarrier.h: (JSC::WriteBarrierBase::clear):
10:02 PM Changeset in webkit [77110] by Simon Fraser
  • 10 edits
    4 adds in trunk

2011-01-30 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig.

Enhance ShadowBlur to render inset box shadows
​https://bugs.webkit.org/show_bug.cgi?id=51567

Use ShadowBlur for inset box-shadows with CG. It
currently lacks a tiled version, but is still much
faster than CG shadows.

Test: fast/box-shadow/inset-box-shadow-radius.html

  • platform/graphics/ShadowBlur.cpp:
  • platform/graphics/ShadowBlur.h: New method for inset shadows. (WebCore::ShadowBlur::drawInsetShadow):
  • platform/graphics/GraphicsContext.cpp: #ifdef out fillRectWithRoundedHole() for CG.
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillRectWithRoundedHole): If there's a shadow with a radius > 0, use ShadowBlur.
9:54 PM Changeset in webkit [77109] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

More Qt build fixes

9:11 PM Changeset in webkit [77108] by kbr@google.com
  • 5 edits
    1 add in trunk

2011-01-28 Kenneth Russell <​kbr@google.com>

Reviewed by Chris Marrin.

WebGL shows PNG Textures with indexed colors too dark
​https://bugs.webkit.org/show_bug.cgi?id=47477

Added test case for upload of indexed PNG images to
gl-teximage.html in the Khronos WebGL conformance tests.
Synchronized this test with the Khronos repository.

  • fast/canvas/webgl/gl-teximage-expected.txt:
  • fast/canvas/webgl/gl-teximage.html:
  • fast/canvas/webgl/resources/red-indexed.png: Added.

2011-01-28 Kenneth Russell <​kbr@google.com>

Reviewed by Chris Marrin.

WebGL shows PNG Textures with indexed colors too dark
​https://bugs.webkit.org/show_bug.cgi?id=47477

Properly handle indexed PNG images by re-rendering them as RGBA
images before upload. Verified with this layout test and the test
cases from bugs 47477 and 53269.

  • platform/graphics/cg/GraphicsContext3DCG.cpp: (WebCore::GraphicsContext3D::getImageData):
8:39 PM Changeset in webkit [77107] by morrita@google.com
  • 8 edits in trunk/Source/WebCore

2011-01-27 MORITA Hajime <​morrita@google.com>

Reviewed by Dimitri Glazkov.

Convert <progress> shadow DOM to a DOM-based shadow.
​https://bugs.webkit.org/show_bug.cgi?id=50660

  • Removed RenderProgress::m_valuePart, moved the shadow node to the shadow root of HTMLProgressElement.
  • Removed hard-coded pseudo ID for -webkit-progress-bar-value. ProgressBarValueElement is defined only for overriding shadowPseudoId().

No new tests. No behavioral change.

  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): (WebCore::nameToPseudoTypeMap): (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h:
  • html/HTMLProgressElement.cpp: (WebCore::ProgressBarValueElement::ProgressBarValueElement): (WebCore::ProgressBarValueElement::shadowPseudoId): (WebCore::ProgressBarValueElement::create): (WebCore::HTMLProgressElement::parseMappedAttribute): (WebCore::HTMLProgressElement::attach): (WebCore::HTMLProgressElement::valuePart): (WebCore::HTMLProgressElement::didElementStateChange): (WebCore::HTMLProgressElement::createShadowSubtreeIfNeeded):
  • html/HTMLProgressElement.h:
  • rendering/RenderProgress.cpp: (WebCore::RenderProgress::~RenderProgress): (WebCore::RenderProgress::updateFromElement): (WebCore::RenderProgress::layoutParts): (WebCore::RenderProgress::shouldHaveParts): (WebCore::RenderProgress::valuePart):
  • rendering/RenderProgress.h:
  • rendering/style/RenderStyleConstants.h:
8:26 PM Changeset in webkit [77106] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

2011-01-30 Simon Fraser <Simon Fraser>

Reviewed by Ariya Hidayat.

Enhance ShadowBlur to render inset box shadows; Part 1.
​https://bugs.webkit.org/show_bug.cgi?id=51567

Add a new method to GraphicsContext to render a rect with a rounded hole,
for use by inset box-shadow code. Knowledge that we're rendering a rounded
hole will enable ShadowBlur to be used here in future.

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::fillRectWithRoundedHole):
  • platform/graphics/GraphicsContext.h:
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBoxShadow):
8:23 PM Changeset in webkit [77105] by morrita@google.com
  • 3 edits
    4 adds in trunk

2011-01-23 MORITA Hajime <​morrita@google.com>

Reviewed by Eric Seidel.

REGRESSION: Inset shadow with too large border radius misses rounded corner.
​https://bugs.webkit.org/show_bug.cgi?id=52800

  • fast/box-shadow/inset-with-extraordinary-radii-and-border.html: Added.
  • platform/mac/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.checksum: Added.
  • platform/mac/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Added.
  • platform/mac/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.txt: Added.

2011-01-23 MORITA Hajime <​morrita@google.com>

Reviewed by Eric Seidel.

REGRESSION: Inset shadow with too large border radius misses rounded corner.
​https://bugs.webkit.org/show_bug.cgi?id=52800

The refactoring on r76083 broke the invariant between border
IntRect and its radii because RoundedIntRect::setRect() is called
after getRoundedInnerBorderWithBorderWidths(), which enforces the
invariant. Th rounded-rect clipping code verifies the invariant,
and discard the invalid radii, that results broken paintings.

This change moved setRect() before
getRoundedInnerBorderWithBorderWidths() not to modify the valid
RoundedIntRect value.

Test: fast/box-shadow/inset-with-extraordinary-radii-and-border.html

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBoxShadow):
8:06 PM Changeset in webkit [77104] by ggaren@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-01-30 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.

[Take 2!]
Fixed crash on window close (maybe crash on launch?) due to missing frame null checks
​https://bugs.webkit.org/show_bug.cgi?id=53408

  • UIProcess/WebContext.cpp: (WebKit::WebContext::didNavigateWithNavigationData): (WebKit::WebContext::didPerformClientRedirect): (WebKit::WebContext::didPerformServerRedirect): (WebKit::WebContext::didUpdateHistoryTitle): Use MESSAGE_CHECK because we don't think we should be able to reach this state under normal conditions.
8:05 PM Changeset in webkit [77103] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

2011-01-30 Simon Fraser <Simon Fraser>

Attempt to fix Windows build by adding ShadowBlur.cpp/h to the
vcproj.

  • WebCore.vcproj/WebCore.vcproj:
7:36 PM Changeset in webkit [77102] by ggaren@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-01-30 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Fixed crash on window close (maybe crash on launch?) due to missing
frame null checks
​https://bugs.webkit.org/show_bug.cgi?id=53408

  • UIProcess/WebContext.cpp: (WebKit::WebContext::didNavigateWithNavigationData): (WebKit::WebContext::didPerformClientRedirect): (WebKit::WebContext::didPerformServerRedirect): (WebKit::WebContext::didUpdateHistoryTitle): Check for NULL, since we're calling a function that can return it.
7:36 PM Changeset in webkit [77101] by Simon Fraser
  • 32 edits
    1 move
    7 adds
    6 deletes in trunk

2011-01-30 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

-webkit-box-shadow causes awful scroll/resize/redraw performance
​https://bugs.webkit.org/show_bug.cgi?id=22102

Use ShadowBlur for CG, whe rendering shadows on rects and
rounded rects outside of canvas.

CG shadows with a radius of more than 8px do not render
correctly. We preserve this incorrect rendering by compensating
for it when rending -webkit-box-shadow. Calls that should use
this deprecated radius behavior now use setLegacyShadow().

Test: fast/box-shadow/box-shadow-transformed.html

  • html/canvas/CanvasRenderingContext2D.cpp: Use setLegacyShadow() for canvas, to indicate that it should use the deprecated radius behavior. (WebCore::CanvasRenderingContext2D::setAllAttributesToDefault): Ditto. (WebCore::CanvasRenderingContext2D::setShadow): Ditto. (WebCore::CanvasRenderingContext2D::applyShadow): Ditto.
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setLegacyShadow): Set the m_state.shadowsUseLegacyRadius bit.
  • platform/graphics/GraphicsContext.h: (WebCore::GraphicsContextState::GraphicsContextState): Add a shadowsUseLegacyRadius bit to the state.
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::radiusToLegacyRadius): Map from the actual radius to one that approximates CG behavior. (WebCore::hasBlurredShadow): Helper that returns true if we have a shadow with a non-zero blur radius. (WebCore::GraphicsContext::fillRect): Use ShadowBlur if not canvas. (WebCore::GraphicsContext::fillRoundedRect): Ditto. (WebCore::GraphicsContext::setPlatformShadow): Comment.
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBoxShadow): Call setLegacyShadow() for -webkit-box-shadow.
  • platform/graphics/ShadowBlur.cpp: (WebCore::ShadowBlur::calculateLayerBoundingRect): Fix some pixel crack issues by rounding up the blur radius. (WebCore::ShadowBlur::drawRectShadow): Ditto (WebCore::ShadowBlur::drawRectShadowWithTiling): Ditto.
7:11 PM Changeset in webkit [77100] by oliver@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix Qt build (again).

5:35 PM Changeset in webkit [77099] by oliver@apple.com
  • 3 edits in trunk/Source/WebCore

Try to fix Qt build.

5:13 PM Changeset in webkit [77098] by oliver@apple.com
  • 125 edits
    2 adds in trunk/Source

Convert markstack to a slot visitor API
​https://bugs.webkit.org/show_bug.cgi?id=53219

rolling r77006 and r77020 back in.

4:44 PM Changeset in webkit [77097] by Simon Fraser
  • 6 edits
    2 adds in trunk/Source/WebCore

2011-01-30 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig.

Make ContextShadow code cross-platform
​https://bugs.webkit.org/show_bug.cgi?id=51312

Add a new class, ShadowBlur, that contains most of the
code from ContextShadow, but is fully cross-platform.
It depends on one new method, GraphicsContext::clipBounds(),
which platforms will have to implement.

Add ShadowBlur to the Mac Xcode project, but don't use it
anywhere yet.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::clipBounds):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/ShadowBlur.cpp: Added. (WebCore::roundUpToMultipleOf32): (WebCore::ScratchBuffer::ScratchBuffer): (WebCore::ScratchBuffer::getScratchBuffer): (WebCore::ScratchBuffer::scheduleScratchBufferPurge): (WebCore::ScratchBuffer::timerFired): (WebCore::ScratchBuffer::clearScratchBuffer): (WebCore::ScratchBuffer::shared): (WebCore::ShadowBlur::ShadowBlur): (WebCore::ShadowBlur::blurLayerImage): (WebCore::ShadowBlur::adjustBlurDistance): (WebCore::ShadowBlur::calculateLayerBoundingRect): (WebCore::ShadowBlur::beginShadowLayer): (WebCore::ShadowBlur::endShadowLayer): (WebCore::ShadowBlur::drawRectShadow): (WebCore::ShadowBlur::drawRectShadowWithoutTiling): (WebCore::ShadowBlur::drawRectShadowWithTiling): (WebCore::ShadowBlur::clipBounds):
  • platform/graphics/ShadowBlur.h: Added. (WebCore::ShadowBlur::setShadowsIgnoreTransforms): (WebCore::ShadowBlur::shadowsIgnoreTransforms):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::clipBounds):
3:32 PM Changeset in webkit [77096] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-01-30 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, build fix.

Fix regression introduced in r77093 - path.rsplit() doesn't
take keyword arguments.

​https://bugs.webkit.org/show_bug.cgi?id=53326

  • Scripts/webkitpy/common/system/filesystem_mock.py:
3:16 PM Changeset in webkit [77095] by dpranke@chromium.org
  • 5 edits
    3 copies in trunk/Tools

2011-01-30 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Mihai Parparita.

Add more unit tests for rebaseline-chromium-webkit-tests. This
change involves restructuring a bunch of r-c-w-t code to make it
more testable as well. We also add wrapper classes for handling
testing zip files and fetching URLs.

​https://bugs.webkit.org/show_bug.cgi?id=53040

  • Scripts/webkitpy/common/system/urlfetcher.py:
  • Scripts/webkitpy/common/system/urlfetcher_mock.py:
  • Scripts/webkitpy/common/system/zipfileset_mock.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
3:07 PM Changeset in webkit [77094] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

2011-01-30 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Filter all Heap collection through a common reset function, in
preparation for adding features triggered by collection.
​https://bugs.webkit.org/show_bug.cgi?id=53396


SunSpider reports no change.

  • runtime/Heap.cpp: (JSC::Heap::reportExtraMemoryCostSlowCase): When we're over the extraCost limit, just call collectAllGarbage() instead of rolling our own special way of resetting the heap. In theory, this may be slower in some cases, but it also fixes cases of pathological heap growth that we've seen, where the only objects being allocated are temporary and huge (<rdar://problem/8885843>).

(JSC::Heap::allocate):
(JSC::Heap::collectAllGarbage): Use the shared reset function.

(JSC::Heap::reset):

  • runtime/Heap.h: Carved a new shared reset function out of the old collectAllGarbage.
3:07 PM Changeset in webkit [77093] by dpranke@chromium.org
  • 9 edits in trunk/Tools

2011-01-30 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

Clean up of the filesystem-related modules used in webkitpy.
I've added relpath() to the filesystem interface, modified
ospath.relpath() so that it could work with the filesystem
interface, and modified the fileset* routines to use the
filesystem interface consistently.

This patch also adds a close() routine to the fileset routines
to indicate that the caller is done with the fileset. This
allows zipfileset to clean up after itself when it creates
tempfiles to store downloads.

​https://bugs.webkit.org/show_bug.cgi?id=53326

  • Scripts/webkitpy/common/system/directoryfileset.py:
  • Scripts/webkitpy/common/system/fileset.py:
  • Scripts/webkitpy/common/system/filesystem.py:
  • Scripts/webkitpy/common/system/filesystem_mock.py:
  • Scripts/webkitpy/common/system/filesystem_unittest.py:
  • Scripts/webkitpy/common/system/ospath.py:
  • Scripts/webkitpy/common/system/zipfileset.py:
  • Scripts/webkitpy/common/system/zipfileset_unittest.py:
12:25 PM Changeset in webkit [77092] by kbalazs@webkit.org
  • 6 edits in trunk

2011-01-30 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt][WK2]REGRESSION (r76991): Fix build errors
​https://bugs.webkit.org/show_bug.cgi?id=53400

Revert the temporary build fix (​http://trac.webkit.org/changeset/77088)
and remove WebKit2Prefix.h from the build.

  • UIProcess/API/qt/qwkhistory.h:
  • UIProcess/API/qt/qwkpage.h:
  • WebKit2.pro:

2011-01-30 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt][WK2]REGRESSION (r76991): Fix build errors
​https://bugs.webkit.org/show_bug.cgi?id=53400

Revert the temporary build fix (​http://trac.webkit.org/changeset/77088)
and remove WebKit2Prefix.h from the build.

  • MiniBrowser/qt/MiniBrowser.pro:
12:04 PM Changeset in webkit [77091] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-01-30 Jeff Miller <​jeffm@apple.com>

Reviewed by Dan Bernstein.

FindController::updateFindIndicator() crashes if selection isn't visible
​https://bugs.webkit.org/show_bug.cgi?id=53399

  • WebProcess/WebPage/FindController.cpp: (WebKit::FindController::updateFindIndicator): Return false if ShareableBitmap::createShareable() returns null (typically because the selection rect is empty).
11:54 AM Changeset in webkit [77090] by Csaba Osztrogonác
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r77025.
​http://trac.webkit.org/changeset/77025
​https://bugs.webkit.org/show_bug.cgi?id=53401

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-01-30
It made js1_5/Regress/regress-159334.js fail on 64 bit Linux
(Requested by Ossy on #webkit).

  • jit/ExecutableAllocatorFixedVMPool.cpp:

(JSC::FreeListEntry::FreeListEntry):
(JSC::AVLTreeAbstractorForFreeList::get_less):
(JSC::AVLTreeAbstractorForFreeList::set_less):
(JSC::AVLTreeAbstractorForFreeList::get_greater):
(JSC::AVLTreeAbstractorForFreeList::set_greater):
(JSC::AVLTreeAbstractorForFreeList::get_balance_factor):
(JSC::AVLTreeAbstractorForFreeList::set_balance_factor):
(JSC::AVLTreeAbstractorForFreeList::null):
(JSC::AVLTreeAbstractorForFreeList::compare_key_key):
(JSC::AVLTreeAbstractorForFreeList::compare_key_node):
(JSC::AVLTreeAbstractorForFreeList::compare_node_node):
(JSC::reverseSortFreeListEntriesByPointer):
(JSC::reverseSortCommonSizedAllocations):
(JSC::FixedVMPoolAllocator::release):
(JSC::FixedVMPoolAllocator::reuse):
(JSC::FixedVMPoolAllocator::addToFreeList):
(JSC::FixedVMPoolAllocator::coalesceFreeSpace):
(JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
(JSC::FixedVMPoolAllocator::alloc):
(JSC::FixedVMPoolAllocator::free):
(JSC::FixedVMPoolAllocator::isValid):
(JSC::FixedVMPoolAllocator::allocInternal):
(JSC::FixedVMPoolAllocator::isWithinVMPool):
(JSC::FixedVMPoolAllocator::addToCommittedByteCount):
(JSC::ExecutableAllocator::committedByteCount):
(JSC::maybeModifyVMPoolSize):
(JSC::ExecutableAllocator::isValid):
(JSC::ExecutableAllocator::underMemoryPressure):
(JSC::ExecutablePool::systemAlloc):
(JSC::ExecutablePool::systemRelease):

  • wtf/PageReservation.h:

(WTF::PageReservation::PageReservation):
(WTF::PageReservation::commit):
(WTF::PageReservation::decommit):

10:19 AM Changeset in webkit [77089] by Simon Fraser
  • 4 edits
    4 adds in trunk

2011-01-29 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

CSS3 gradients with em-based stops fail to repaint when font size changes
​https://bugs.webkit.org/show_bug.cgi?id=51845

Mark as uncacheable gradidients whose color stops depend on font size,
and don't attempt to put these into CSSImageGeneratorValue's image cache.
This means we return a new gradient each time, which is fairly cheap, and
fixes repaint issues under changing font size.

Test: fast/repaint/gradients-em-stops-repaint.html

  • css/CSSGradientValue.cpp: (WebCore::CSSGradientValue::image): (WebCore::CSSGradientValue::isCacheable):
  • css/CSSGradientValue.h:
5:21 AM Changeset in webkit [77088] by Csaba Osztrogonác
  • 5 edits in trunk

Unreviewed.

[Qt][WK2] Buildfix.

Source/WebKit2:

  • UIProcess/API/qt/qwkhistory.h:
  • UIProcess/API/qt/qwkpage.h:

Tools:

  • MiniBrowser/qt/MiniBrowser.pro:
3:54 AM Changeset in webkit [77087] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-30 Leo Yang <​leo.yang@torchmobile.com.cn>

Reviewed by Daniel Bates.

Code style issue in JavaScriptCore/wtf/CurrentTime.h
​https://bugs.webkit.org/show_bug.cgi?id=53394

According to rule #3 at ​http://webkit.org/coding/coding-style.html,
This patch fix style issue in CurrentTime.h.

No functionality change, no new tests.

  • wtf/CurrentTime.h: (WTF::currentTimeMS): (WTF::getLocalTime):
2:40 AM Changeset in webkit [77086] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-30 Benjamin Poulain <​ikipou@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] JavaScriptCore does not link on Mac if building WebKit 2
​https://bugs.webkit.org/show_bug.cgi?id=53377

The option "-whole-archive" is not availabe with the libtool of Mac OS X,
instead, we can use "-all_load" on Mac.

12:30 AM Changeset in webkit [77085] by mjs@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-01-29 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Geoffrey Garen.

Add WKPageCopyPendingAPIRequestURL API
​https://bugs.webkit.org/show_bug.cgi?id=53383

This API returns the last URL requested for load via API, if neither that load nor any
other load subsequently reaches the provisional state.


This is useful to be able to track loads initiated via the API


  • UIProcess/API/C/WKPage.cpp: (WKPageCopyPendingAPIRequestURL): Retrieve the pending URL.
  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::loadURL): Set pending URL. (WebKit::WebPageProxy::loadURLRequest): ditto (WebKit::WebPageProxy::reload): ditto (WebKit::WebPageProxy::goForward): ditto (WebKit::WebPageProxy::goBack): ditto (WebKit::WebPageProxy::estimatedProgress): Assume the initial progress value when there is a pending URL. (WebKit::WebPageProxy::didStartProvisionalLoadForFrame): Clear pending URL; clients should look at the provisional URL now. (WebKit::WebPageProxy::decidePolicyForNavigationAction): Clear pending URL if it doesn't match the policy URL; this means we were interrupted by another load.
  • UIProcess/WebPageProxy.h: (WebKit::WebPageProxy::pendingAPIRequestURL): Helper function. (WebKit::WebPageProxy::clearPendingAPIRequestURL): ditto (WebKit::WebPageProxy::setPendingAPIRequestURL): ditto

Jan 29, 2011:

10:48 PM Changeset in webkit [77084] by mitz@apple.com
  • 2312 edits in trunk/LayoutTests/platform

Set the svn:mime-type property of some PNG files to image/png

10:43 PM Changeset in webkit [77083] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Sorry Leopard bot -- I committed a change by accident.

10:23 PM Changeset in webkit [77082] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

2011-01-29 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Cameron Zwarich.

Simplified Heap iteration
​https://bugs.webkit.org/show_bug.cgi?id=53393

  • runtime/CollectorHeapIterator.h: (JSC::CollectorHeapIterator::isValid): (JSC::CollectorHeapIterator::isLive): (JSC::CollectorHeapIterator::advance): Removed "max" argument to advance because it's a constant. (JSC::LiveObjectIterator::LiveObjectIterator): (JSC::LiveObjectIterator::operator++): (JSC::DeadObjectIterator::DeadObjectIterator): (JSC::DeadObjectIterator::operator++): (JSC::ObjectIterator::ObjectIterator): (JSC::ObjectIterator::operator++): Factored out common checks into two helper functions -- isValid() for "Am I past the end?" and isLive() for "Is the cell I'm pointing to live?".
  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::freeBlock): (JSC::MarkedSpace::sweep): Always sweep from the beginning of the heap to the end, to avoid making sweep subtly reliant on internal Heap state. (JSC::MarkedSpace::primaryHeapBegin): (JSC::MarkedSpace::primaryHeapEnd): Always be explicit about where iteration begins.
10:11 PM Changeset in webkit [77081] by ggaren@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

2011-01-29 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Cameron Zwarich.

Simplified heap destruction
​https://bugs.webkit.org/show_bug.cgi?id=53392

  • JavaScriptCore.exp:
  • runtime/Heap.cpp: (JSC::Heap::destroy):
  • runtime/Heap.h:
  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::destroy):
  • runtime/MarkedSpace.h: Don't go out of our way to destroy GC-protected cells last -- the difficult contortions required to do so just don't seem justified. We make no guarantees about GC protection after the client throws away JSGlobalData, and it doesn't seem like any meaningful guarantee is even possible.
9:58 PM Changeset in webkit [77080] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-01-29 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Switched heap to use the Bitmap class and removed CollectorBitmap
​https://bugs.webkit.org/show_bug.cgi?id=53391


SunSpider says 1.005x as fast. Seems like a fluke.

  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::allocate): Updated for rename and returning a value rather than taking a value by reference.
  • runtime/MarkedSpace.h: Code reuse is good.
  • wtf/Bitmap.h: (WTF::::testAndSet): Added, since this is the one thing Bitmap was missing which CollectorBitmap had. (Renamed from the less conventional "getset".)

(WTF::::nextPossiblyUnset): Renamed and changed to return a value for
clarity. It's all the same with inlining.

8:17 PM Changeset in webkit [77079] by ggaren@apple.com
  • 2 edits in trunk/Source/WebCore

Undo try to fix the Qt build.

My guess didn't work.

  • WebCore.pro:
8:04 PM Changeset in webkit [77078] by ggaren@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix the Qt build.

  • WebCore.pro: Added platform/text/CharacterNames.h.
7:32 PM Changeset in webkit [77077] by ggaren@apple.com
  • 14 edits in trunk/Source

2011-01-28 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Some more Heap cleanup.
​https://bugs.webkit.org/show_bug.cgi?id=53357


  • runtime/Heap.cpp: (JSC::Heap::reportExtraMemoryCostSlowCase): Renamed recordExtraCost to reportExtraMemoryCostSlowCase to match our naming conventions.

(JSC::Heap::capacity): Renamed size to capacity because this function
returns the capacity of the heap, including unused portions.

  • runtime/Heap.h: (JSC::Heap::globalData): (JSC::Heap::markedSpace): (JSC::Heap::machineStackMarker): (JSC::Heap::reportExtraMemoryCost): Moved statics to the top of the file. Moved ctor and dtor to the beginning of the class definition. Grouped functions by purpose.
  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::capacity): Renamed size to capacity because this function returns the capacity of the heap, including unused portions.
  • runtime/MarkedSpace.h: Removed statistics and the Statistics class because the same information can be gotten just by calling size() and capacity().
  • runtime/MemoryStatistics.cpp:
  • runtime/MemoryStatistics.h: Ditto.

2011-01-28 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Some more Heap cleanup.
​https://bugs.webkit.org/show_bug.cgi?id=53357

Updated for JavaScriptCore changes.

  • Misc/WebCoreStatistics.mm: (+[WebCoreStatistics memoryStatistics]):

2011-01-28 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Some more Heap cleanup.
​https://bugs.webkit.org/show_bug.cgi?id=53357


Updated for JavaScriptCore changes.

  • bindings/js/ScriptGCEvent.cpp: (WebCore::ScriptGCEvent::getHeapSize):
6:39 PM Changeset in webkit [77076] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-01-29 Adam Barth <​abarth@webkit.org>

Reviewed by Daniel Bates.

Fix XSSFilter crash when extracting the source for a token twice
​https://bugs.webkit.org/show_bug.cgi?id=53368

Previously, it was unsafe to extract the source for the same token
twice because the HTMLSourceTracker would advance its internal
representation of the SegmentedString. This patch introduces a cache
to make calling HTMLSourceTracker::sourceForToken multiple times safe.

  • html/parser/HTMLSourceTracker.cpp: (WebCore::HTMLSourceTracker::end): (WebCore::HTMLSourceTracker::sourceForToken):
  • html/parser/HTMLSourceTracker.h:
4:22 PM Changeset in webkit [77075] by mjs@apple.com
  • 2 edits in trunk/Source/WebCore

2011-01-29 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Dan Bernstein.

Fix fat build for both 32-bit and 64-bit under llvm-gcc 4.2
​https://bugs.webkit.org/show_bug.cgi?id=53386

  • platform/mac/ScrollAnimatorMac.mm: (WebCore::elasticDeltaForReboundDelta): (WebCore::scrollWheelMultiplier): (WebCore::ScrollAnimatorMac::smoothScrollWithEvent): (WebCore::ScrollAnimatorMac::beginScrollGesture): (WebCore::roundTowardZero): (WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
3:21 PM Changeset in webkit [77074] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed fix for last commit.

Remove stray slash in previous commit.

  • platform/mac-wk2/Skipped:
3:14 PM Changeset in webkit [77073] by dbates@webkit.org
  • 4 edits in trunk

2011-01-29 Daniel Bates <​dbates@rim.com>

Reviewed by Maciej Stachowiak.

Remove reference to ${CMAKE_SOURCE_DIR}/Source in CMake files
​https://bugs.webkit.org/show_bug.cgi?id=53382

Our file system hierarchy ensures that CMAKE_SOURCE_DIR is defined to be /Source.
So, ${CMAKE_SOURCE_DIR}/Source evaluates to the non-existent directory /Source/Source.
Therefore, we should remove such references.

  • Source/cmake/OptionsCommon.cmake:

2011-01-29 Daniel Bates <​dbates@rim.com>

Reviewed by Maciej Stachowiak.

Remove reference to ${CMAKE_SOURCE_DIR}/Source in CMake files
​https://bugs.webkit.org/show_bug.cgi?id=53382

Our file system hierarchy ensures that CMAKE_SOURCE_DIR is defined to be /Source.
So, ${CMAKE_SOURCE_DIR}/Source evaluates to the non-existent directory /Source/Source.
Therefore, we should remove such references.

  • CMakeLists.txt:
3:10 PM Changeset in webkit [77072] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2011-01-29 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Daniel Bates.

Skip a test that uses unimplemented DRT API
​https://bugs.webkit.org/show_bug.cgi?id=53381

  • platform/mac-wk2/Skipped:
2:19 PM Changeset in webkit [77071] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix 32-bit build on the Mac.

Reviewed by Jon Honeycutt.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::roundTowardZero):
(WebCore::roundToDevicePixelTowardZero):
Use floats instead of doubles to avoid double-to-float conversion
issues.

2:17 PM Changeset in webkit [77070] by dbates@webkit.org
  • 6 edits
    1 add
    1 delete in trunk

2011-01-29 Daniel Bates <​dbates@rim.com>

Reviewed by Eric Seidel.

Move wince/mt19937ar.c to ThirdParty and make it a policy choice
​https://bugs.webkit.org/show_bug.cgi?id=53253

Move implementation of Mersenne Twister pseudorandom number generator to
ThirdParty since it is a third party library.

  • Source/ThirdParty/mt19937ar.c: Copied from Source/JavaScriptCore/wtf/wince/mt19937ar.c.

2011-01-29 Daniel Bates <​dbates@rim.com>

Reviewed by Eric Seidel.

Move wince/mt19937ar.c to ThirdParty and make it a policy choice
​https://bugs.webkit.org/show_bug.cgi?id=53253

Make inclusion of MT19937 a policy decision.

Currently, we hardcoded to use MT19937 when building for
Windows CE. Instead, we should make this a policy decision
with the Windows CE port using this by default.

  • JavaScriptCore.pri: Append Source/ThirdParty to the end of the list include directories.
  • wtf/CMakeLists.txt: Ditto.
  • wtf/Platform.h: Defined WTF_USE_MERSENNE_TWISTER_19937 when building for Windows CE.
  • wtf/RandomNumber.cpp: (WTF::randomNumber): Substituted USE(MERSENNE_TWISTER_19937) for OS(WINCE).
2:00 PM Changeset in webkit [77069] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-29 Gustavo Noronha Silva <Gustavo Noronha Silva>

[GTK] REGRESSION: http/tests/media/video-{cookie,referer}.html failing
​https://bugs.webkit.org/show_bug.cgi?id=53379

Skip tests failing likely by the usage of a newer version of soup.

  • platform/gtk/Skipped:
12:47 PM Changeset in webkit [77068] by rniwa@webkit.org
  • 3 edits
    10 adds in trunk/LayoutTests

2011-01-29 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed Chromium rebaselines.

  • platform/chromium-linux/fast/block/positioning/001-expected.checksum: Added.
  • platform/chromium-linux/fast/block/positioning/001-expected.png: Added.
  • platform/chromium-linux/svg/clip-path/clip-in-mask-objectBoundingBox-expected.checksum: Added.
  • platform/chromium-linux/svg/clip-path/clip-in-mask-objectBoundingBox-expected.png: Added.
  • platform/chromium-linux/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.checksum: Added.
  • platform/chromium-linux/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.png: Added.
  • platform/chromium-win/svg/clip-path/clip-in-mask-objectBoundingBox-expected.checksum: Added.
  • platform/chromium-win/svg/clip-path/clip-in-mask-objectBoundingBox-expected.png: Added.
  • platform/chromium-win/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.checksum: Added.
  • platform/chromium-win/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.png: Added.
  • platform/chromium-win/svg/custom/missing-xlink-expected.txt:
  • platform/chromium/test_expectations.txt:
12:31 PM Changeset in webkit [77067] by cwzwarich@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Bug 53374 - Remove uses of unsafe string functions in debugging code
​https://bugs.webkit.org/show_bug.cgi?id=53374

Reviewed by David Kilzer.

  • runtime/RegExp.cpp:

(JSC::RegExp::printTraceData):

12:27 PM Changeset in webkit [77066] by cwzwarich@webkit.org
  • 1 edit in trunk/Source/JavaScriptCore/ChangeLog

Fix ChangeLog date.

12:18 PM Changeset in webkit [77065] by cwzwarich@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

JavaScriptCoreUseJIT environment variable broken
​https://bugs.webkit.org/show_bug.cgi?id=53372

Reviewed by Oliver Hunt.

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData): Check the actual value in the string returned
by getenv() rather than just doing a NULL check on the return value.

11:43 AM Changeset in webkit [77064] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

2011-01-28 Simon Fraser <Simon Fraser>

Reviewed by Adam Barth.

Use clampToInteger() functions in a few places
​https://bugs.webkit.org/show_bug.cgi?id=53363

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Use clampToInteger() for z-index. (WebCore::CSSStyleSelector::createTransformOperations): Use clampToPositiveInteger().
  • platform/graphics/transforms/PerspectiveTransformOperation.cpp: Ditto. (WebCore::PerspectiveTransformOperation::blend): Ditto.
10:50 AM Changeset in webkit [77063] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-29 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed Chromium test expectation update; removed http/tests/appcache/online-whitelist.html
from the test expectation, because it has been passing on Chromium Windows.

  • platform/chromium/test_expectations.txt:
9:04 AM Changeset in webkit [77062] by Patrick Gansterer
  • 56 edits
    2 adds
    1 delete in trunk/Source

2011-01-29 Patrick Gansterer <Patrick Gansterer>

Reviewed by David Kilzer.

Move CharacterNames.h into WTF directory
​https://bugs.webkit.org/show_bug.cgi?id=49618

  • GNUmakefile.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/unicode/CharacterNames.h: Renamed from WebCore/platform/text/CharacterNames.h.
  • wtf/unicode/UTF8.cpp:

2011-01-29 Patrick Gansterer <Patrick Gansterer>

Reviewed by David Kilzer.

Move CharacterNames.h into WTF directory
​https://bugs.webkit.org/show_bug.cgi?id=49618

  • ForwardingHeaders/wtf/unicode/CharacterNames.h: Added.
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AccessibilityObject.cpp:
  • accessibility/AccessibilityRenderObject.cpp:
  • bindings/cpp/WebDOMHTMLDocumentCustom.cpp:
  • bindings/js/JSHTMLDocumentCustom.cpp:
  • dom/Position.cpp:
  • dom/SelectElement.cpp:
  • editing/CompositeEditCommand.cpp:
  • editing/Editor.cpp:
  • editing/HTMLInterchange.cpp:
  • editing/InsertTextCommand.cpp:
  • editing/MarkupAccumulator.cpp:
  • editing/TextIterator.cpp:
  • editing/VisibleSelection.cpp:
  • editing/htmlediting.cpp:
  • editing/htmlediting.h:
  • editing/markup.cpp:
  • html/FTPDirectoryDocument.cpp:
  • html/HTMLFormControlElement.cpp:
  • html/parser/HTMLTreeBuilder.cpp:
  • loader/appcache/ManifestParser.cpp:
  • platform/chromium/PopupMenuChromium.cpp:
  • platform/graphics/Font.h:
  • platform/graphics/FontFastPath.cpp:
  • platform/graphics/GlyphPageTreeNode.cpp:
  • platform/graphics/StringTruncator.cpp:
  • platform/graphics/mac/ComplexTextController.cpp:
  • platform/graphics/mac/ComplexTextControllerATSUI.cpp:
  • platform/graphics/wince/GraphicsContextWinCE.cpp:
  • platform/mac/PasteboardMac.mm:
  • platform/text/TextCodecICU.cpp:
  • platform/text/mac/TextCodecMac.cpp:
  • platform/text/transcoder/FontTranscoder.cpp:
  • rendering/RenderBlockLineLayout.cpp:
  • rendering/RenderFlexibleBox.cpp:
  • rendering/RenderListMarker.cpp:
  • rendering/RenderText.cpp:
  • rendering/RenderTextControl.cpp:
  • rendering/RenderTreeAsText.cpp:
  • rendering/break_lines.cpp:
  • rendering/mathml/RenderMathMLOperator.h:
  • websockets/WebSocketHandshake.cpp:
  • wml/WMLTableElement.cpp:

2011-01-29 Patrick Gansterer <Patrick Gansterer>

Reviewed by David Kilzer.

Move CharacterNames.h into WTF directory
​https://bugs.webkit.org/show_bug.cgi?id=49618

  • src/ChromeClientImpl.cpp:
3:39 AM Changeset in webkit [77061] by commit-queue@webkit.org
  • 11 edits in trunk

2011-01-29 Dan Winship <​danw@gnome.org>

Reviewed by Xan Lopez.

[GTK] Require the latest glib and libsoup, and remove conditional
support for older versions
​https://bugs.webkit.org/show_bug.cgi?id=50675

  • autotools/webkit.m4: use AM_PATH_GLIB_2_0 rather than doing basically the same work by hand
  • configure.ac:

2011-01-29 Dan Winship <​danw@gnome.org>

Reviewed by Xan Lopez.

[GTK] Remove HAVE_LIBSOUP_2_29_90 conditionals; we depend on
libsoup 2.33.1 now.
​https://bugs.webkit.org/show_bug.cgi?id=50675

  • platform/network/soup/CookieJarSoup.cpp: (WebCore::defaultCookieJar): (WebCore::setCookies):
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::prepareForURL): (WebCore::restartedCallback): (WebCore::startHttp):
  • platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::updateSoupMessage): (WebCore::ResourceRequest::toSoupMessage): (WebCore::ResourceRequest::updateFromSoupMessage):

2011-01-29 Dan Winship <​danw@gnome.org>

Reviewed by Xan Lopez.

[GTK] Remove HAVE_LIBSOUP_2_29_90 conditionals; we depend on
libsoup 2.33.1 now.
​https://bugs.webkit.org/show_bug.cgi?id=50675

  • ewk/ewk_cookies.cpp: (ewk_cookies_file_set): (ewk_cookies_policy_set): (ewk_cookies_policy_get):

2011-01-29 Dan Winship <​danw@gnome.org>

Reviewed by Xan Lopez.

[GTK] Remove HAVE_LIBSOUP_2_29_90 and HAVE_GSETTINGS conditionals;
we depend on glib 2.27.4 and libsoup 2.33.1 now.
​https://bugs.webkit.org/show_bug.cgi?id=50675

  • GNUmakefile.am:
  • WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::storeSetting):
  • webkit/webkitprivate.cpp: (inspectorGSettings):
  • webkit/webkitprivate.h:
1:22 AM Changeset in webkit [77060] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-29 Adam Barth <​abarth@webkit.org>

Reviewed by Daniel Bates.

XSSFilter should replace URLs with about:blank instead of the empty string
​https://bugs.webkit.org/show_bug.cgi?id=53370

Using the empty string will make the URL complete to the current
document's URL, which isn't really what we want. Instead, we want to
use about:blank, which is safe.

  • html/parser/XSSFilter.cpp: (WebCore::XSSFilter::filterObjectToken): (WebCore::XSSFilter::filterEmbedToken):
1:20 AM Changeset in webkit [77059] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-29 Adam Barth <​abarth@webkit.org>

Reviewed by Daniel Bates.

XSSFilter should pass xssAuditor/script-tag-addslashes*
​https://bugs.webkit.org/show_bug.cgi?id=53365

We need to canonicalize strings to avoid being tricked by addslashes.

  • html/parser/XSSFilter.cpp: (WebCore::HTMLNames::isNonCanonicalCharacter):
    • This function is copied from the XSSAuditor (with some tweaks). We'll eventually remove the XSSAuditor once we've got XSSFilter working properly.

(WebCore::HTMLNames::canonicalize):
(WebCore::HTMLNames::decodeURL):
(WebCore::XSSFilter::isContainedInRequest):

1:19 AM Changeset in webkit [77058] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-01-29 Adam Barth <​abarth@webkit.org>

Reviewed by Daniel Bates.

XSSFilter should pass xssAuditor/script-tag-with-source-same-host.html
and xssAuditor/script-tag-post-*
​https://bugs.webkit.org/show_bug.cgi?id=53364

We're supposed to allow loading same-origin resources even if they
appear as part of the request.

Also, we're supposed to look at the POST data too. :)

  • html/parser/XSSFilter.cpp: (WebCore::XSSFilter::eraseAttributeIfInjected): (WebCore::XSSFilter::isSameOriginResource):
    • Copy/paste from XSSAuditor::isSameOriginResource. We'll eventually remove the XSSAuditor version when XSSFilter is done.
  • html/parser/XSSFilter.h:
1:17 AM Changeset in webkit [77057] by abarth@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-01-29 Adam Barth <​abarth@webkit.org>

Reviewed by Daniel Bates.

XSSFilter should pass 16 of the xssAuditor/script-tag* tests
​https://bugs.webkit.org/show_bug.cgi?id=53362

Turns out we need to replace the src attribute of script tags with
about:blank to avoid loading the main document URL as a script. Also,
move misplaced return statement that was triggering the console message
too often.

  • html/parser/HTMLToken.h: (WebCore::HTMLToken::appendToAttributeValue):
  • html/parser/XSSFilter.cpp: (WebCore::XSSFilter::filterScriptToken): (WebCore::XSSFilter::eraseAttributeIfInjected):
  • html/parser/XSSFilter.h:
1:11 AM Changeset in webkit [77056] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-29 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed Chromium test expectation update.

  • platform/chromium/test_expectations.txt:
12:34 AM Changeset in webkit [77055] by jhoneycutt@apple.com
  • 13 edits
    2 adds in trunk/Source

Downloads in WK2 on Windows should write resume data to bundle
​https://bugs.webkit.org/show_bug.cgi?id=53282
<rdar://problem/8753077>

Reviewed by Alice Liu.

Source/WebCore:

  • WebCore.vcproj/WebCore.vcproj:

Added new files to project.

  • platform/network/cf/DownloadBundle.h: Added.
  • platform/network/win/DownloadBundleWin.cpp: Added.

(WebCore::DownloadBundle::magicNumber):
Moved from WebKit's WebDownload so that WebKit and WebKit2 can share
it.
(WebCore::DownloadBundle::fileExtension):
Ditto.
(WebCore::DownloadBundle::appendResumeData):
Ditto - but modified to return bool rather than HRESULT and to clean up
whitespace.
(WebCore::DownloadBundle::extractResumeData):
Ditto - modified to clean up whitespace.

Source/WebKit/win:

  • WebDownload.cpp:

(WebDownload::bundlePathForTargetPath):
Use the new WebCore::DownloadBundle function.
(WebDownload::request):

  • WebDownload.h:

Removed declarations for functions that were moved to a new location.

  • WebDownloadCFNet.cpp:

(WebDownload::initToResumeWithBundle):
Use the new WebCore::DownloadBundle function.
(WebDownload::cancelForResume):
Fix a leak of the resume data CFDataRef by using adoptCF(). Use the new
WebCore::DownloadBundle function.

Source/WebKit2:

  • WebProcess/Downloads/Download.cpp:

(WebKit::Download::decideDestinationWithSuggestedFilename):
Call didDecideDestination(), now that the destination is decided.

  • WebProcess/Downloads/Download.h:

Declare didDecideDestination(). Added member variables to hold the
destination file path and the download bundle path.
(WebKit::Download::destination):
Return the path to the final destination for this download.

  • WebProcess/Downloads/cf/DownloadCFNet.cpp:

(WebKit::Download::start):
Remove the name of an unused param.
(WebKit::Download::startWithHandle):
Ditto.
(WebKit::Download::cancel):
Tell CFNetwork not to delete the file upon failure, and tell it to
cancel the download. Copy the resume data for the download, and append
it to the download bundle. Call didCancel() with an empty
DataReference, since we have written our own resume data.
(WebKit::decideDestinationWithSuggestedObjectNameCallback):
Remove some unused param names. Removed the call to
CFURLDownloadSetDestination() - this is now handled in
Download::didDecideDestination().
(WebKit::didCreateDestinationCallback):
Report that the final destination was created, rather than the download
bundle, matching old WebKit.
(WebKit::Download::didDecideDestination):
Store the final destination and the download bundle paths, and call
CFURLDownloadSetDestination(), passing the path to the download bundle.

  • WebProcess/Downloads/curl/DownloadCurl.cpp:

(WebKit::Download::didDecideDestination):
Stubbed.

  • WebProcess/Downloads/mac/DownloadMac.mm:

(WebKit::Download::didDecideDestination):
Stubbed - unneeded on the Mac.

  • WebProcess/Downloads/qt/DownloadQt.cpp:

(WebKit::Download::didDecideDestination):
Stubbed.

12:27 AM Changeset in webkit [77054] by commit-queue@webkit.org
  • 9 edits in trunk/Source/WebKit2

2011-01-29 Jeff Miller <​jeffm@apple.com>

Reviewed by Anders Carlsson.

Support find bouncy in WebKit2 on Windows
​https://bugs.webkit.org/show_bug.cgi?id=53329
<rdar://problem/8565843>
The Mac implements the find bouncy inside of WebKit in the UI process for WebKit2, but we need to do this inside Safari for WebKit2 on Windows.
Add infrastructure to call back into the app when the find indicator changes.

  • UIProcess/API/C/win/WKView.cpp: Cleanup some code style violations. (WKViewSetFindIndicatorCallback): Added. (WKViewGetFindIndicatorCallback): Added.
  • UIProcess/API/C/win/WKView.h: Cleanup some code style violations.
  • UIProcess/FindIndicator.cpp: (WebKit::FindIndicator::create): (WebKit::FindIndicator::FindIndicator): (WebKit::FindIndicator::frameRect): (WebKit::FindIndicator::draw): Rename m_selectionRect to m_selectionRectInWindowCoordinates and m_textRects to m_textRectsInSelectionRectCoordinates (along with similarly named local variables) to be more explict about the coordinate system.
  • UIProcess/FindIndicator.h: (WebKit::FindIndicator::selectionRectInWindowCoordinates): Added. (WebKit::FindIndicator::textRects): Rename m_textRects to m_textRectsInSelectionRectCoordinates.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setFindIndicator): Rename selectionRect to selectionRectInWindowCoordinates and textRects to textRectsInSelectionRectCoordinates to be more explict about the coordinate system.
  • UIProcess/WebPageProxy.h: Ditto.
  • UIProcess/win/WebView.cpp: (WebKit::WebView::WebView): (WebKit::WebView::setFindIndicator): Added. (WebKit::WebView::setFindIndicatorCallback): Added. (WebKit::WebView::getFindIndicatorCallback): Added.
  • UIProcess/win/WebView.h:
12:23 AM Changeset in webkit [77053] by rniwa@webkit.org
  • 4 edits
    2 deletes in trunk

2011-01-29 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r77050.
​http://trac.webkit.org/changeset/77050
​https://bugs.webkit.org/show_bug.cgi?id=53371

Caused a crash in Chromium's test_shell_tests (Requested by
rniwa on #webkit).

  • resources/performance-test.js: Removed.
  • tiny-innerHTML.html: Removed.

2011-01-29 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r77050.
​http://trac.webkit.org/changeset/77050
​https://bugs.webkit.org/show_bug.cgi?id=53371

Caused a crash in Chromium's test_shell_tests (Requested by
rniwa on #webkit).

  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::FragmentParsingContext::FragmentParsingContext): (WebCore::HTMLTreeBuilder::FragmentParsingContext::document): (WebCore::HTMLTreeBuilder::FragmentParsingContext::finished):
  • html/parser/HTMLTreeBuilder.h:
12:13 AM Changeset in webkit [77052] by rniwa@webkit.org
  • 2 edits
    3 adds in trunk/LayoutTests

2011-01-29 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed rebaselines and test expectation updates for Chromium Linux.

  • platform/chromium-linux/fast/forms/select-dirty-parent-pref-widths-expected.checksum: Added.
  • platform/chromium-linux/fast/forms/select-dirty-parent-pref-widths-expected.png: Added.
  • platform/chromium-linux/fast/forms/select-dirty-parent-pref-widths-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
Note: See TracTimeline for information about the timeline view.