⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 31, 2011:

11:54 PM Changeset in webkit [77223] by mrowe@apple.com
  • 5 edits
    3 adds in branches/safari-533.20-branch

Merge r71724.

11:44 PM Changeset in webkit [77222] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.20-branch

Merge r71686.

11:41 PM Changeset in webkit [77221] by mrowe@apple.com
  • 11 edits in branches/safari-533.20-branch/WebCore

Merge r71641.

9:53 PM Changeset in webkit [77220] by ap@apple.com
  • 4 edits in trunk/Source

Reviewed by Maciej Stachowiak.

​https://bugs.webkit.org/show_bug.cgi?id=53466
Move WebKit2 to printing via API methods

Also fixes <rdar://problem/8933724> REGRESSION: Wrong pages are printed when not printing from page 1

Also fixes horizontal tiling (no bug filed).

The main idea here is that we don't force AppKit to use a different scaling factor when
a Web view can't be resized to exact page size, and scale when drawing instead.

  • UIProcess/API/mac/WKPrintingView.mm: (-[WKPrintingView _firstPrintedPageNumber]): Factored out into a separate method. (-[WKPrintingView _lastPrintedPageNumber]): Ditto. (pageDidDrawToPDF): Avoid crashing if data is null. (-[WKPrintingView _preparePDFDataForPrintingOnSecondaryThread]): Use -_firstPrintedPageNumber and -_lastPrintedPageNumber. (pageDidComputePageRects): Set frame size to what it would have been for a normal NSView that's been asked to resize. (-[WKPrintingView _pageForRect:]): Check x(), because several pages can be at the same y() when tiling horizontally. (-[WKPrintingView _drawPDFDocument:page:atPoint:]): Point to draw at and frame size are now using different units, translate as appropriate. (-[WKPrintingView _drawPreview:]): Scale the rect to WebCore units. (-[WKPrintingView drawRect:]): Correctly calculate page number when the first page to print isn't page 1. (-[WKPrintingView rectForPage:]): Scale the rect to AppKit units.
9:51 PM Changeset in webkit [77219] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-31 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed Chromium test expectation updates.

Removed media/controls-strict.html and svg/custom/clip-path-referencing-use2.svg (Mac)
since it has been passing since r77171 and r77172-r77173 respectively.

Also removed http/tests/media/reload-after-dialog.html because it has been passing for a while.

  • platform/chromium/test_expectations.txt:
9:50 PM Changeset in webkit [77218] by mrowe@apple.com
  • 5 edits in branches/safari-533.20-branch

Versioning.

9:50 PM Changeset in webkit [77217] by mrowe@apple.com
  • 1 copy in tags/Safari-533.20.20

New tag.

9:40 PM Changeset in webkit [77216] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-01-31 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Remove obsolete comment after r41871
​https://bugs.webkit.org/show_bug.cgi?id=53406

  • dom/Document.h:
9:33 PM Changeset in webkit [77215] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

2011-01-31 Simon Fraser <Simon Fraser>

Fix according to reviewer comments: can just use Color::black now.

  • platform/graphics/ShadowBlur.cpp: (WebCore::ShadowBlur::drawInsetShadow): (WebCore::ShadowBlur::drawRectShadowWithoutTiling):
9:31 PM Changeset in webkit [77214] by mrowe@apple.com
  • 3 edits in branches/safari-533.20-branch/WebCore

Build fix.

9:19 PM Changeset in webkit [77213] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

2011-01-31 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig.

Clean up ShadowBlur
​https://bugs.webkit.org/show_bug.cgi?id=53472

Some minor ShadowBlur cleanup.

  • platform/graphics/ShadowBlur.h:
  • platform/graphics/ShadowBlur.cpp: (WebCore::ShadowBlur::ShadowBlur): Use m_blurRadius rather than the radius paramter. (WebCore::ShadowBlur::adjustBlurRadius): Renamed from adjustBlurDistance. (WebCore::ShadowBlur::calculateLayerBoundingRect): Rename layerFloatRect to layerRect. Make frameSize a float. (WebCore::ShadowBlur::beginShadowLayer): This now takes a precomputed layerRect rather than calling calculateLayerBoundingRect() to compute it itself, since we were calling calculateLayerBoundingRect() twice. (WebCore::ShadowBlur::drawRectShadow): Optimize to call calculateLayerBoundingRect() only once. The shadowRect variable was unused, so two return paths could be collapsed into one. (WebCore::ShadowBlur::drawInsetShadow): Call calculateLayerBoundingRect() before beginShadowLayer() now. (WebCore::ShadowBlur::drawRectShadowWithoutTiling): The layerRect gets passed in. We always used alpha=1, so no need to pass that in. (WebCore::ShadowBlur::drawRectShadowWithTiling): We always used alpha=1, so no need to pass that in. Move shadowRect down to first use. ShadowBlur::clipBounds() was unused.
8:34 PM Changeset in webkit [77212] by noam.rosenthal@nokia.com
  • 4 edits in trunk/Source

2011-01-31 No'am Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QWebElements example from QtWebKit Bridge documentation does not work at all
​https://bugs.webkit.org/show_bug.cgi?id=46748

This problem disappears when we register QWebElement using qRegisterMetaType, which we now do in QtInstance.
Added a regression test to tst_QWebFrame.

  • bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::QtInstance):

2011-01-31 No'am Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QWebElements example from QtWebKit Bridge documentation does not work at all
​https://bugs.webkit.org/show_bug.cgi?id=46748

Problem was that we need to register QWebElement's variant-type to Qt's meta type system at some point.
This wasn't caught by previous tests inside tst_QWebFrame because it only appears when there's also a QWebElement property.
Added a regression test to tst_QWebFrame.

  • tests/qwebframe/tst_qwebframe.cpp: (MyWebElementSlotOnlyObject::doSomethingWithWebElement): (MyWebElementSlotOnlyObject::tagName):
8:05 PM Changeset in webkit [77211] by morrita@google.com
  • 8 edits in trunk/Source/WebCore

2011-01-27 MORITA Hajime <​morrita@google.com>

Reviewed by Dimitri Glazkov.

Convert <progress> shadow DOM to a DOM-based shadow.
​https://bugs.webkit.org/show_bug.cgi?id=50660

  • Removed RenderProgress::m_valuePart, moved the shadow node to the shadow root of HTMLProgressElement.
  • Removed hard-coded pseudo ID for -webkit-progress-bar-value. ProgressBarValueElement is defined only for overriding shadowPseudoId().

No new tests. No behavioral change.

  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): (WebCore::nameToPseudoTypeMap): (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h:
  • html/HTMLProgressElement.cpp: (WebCore::ProgressBarValueElement::ProgressBarValueElement): (WebCore::ProgressBarValueElement::shadowPseudoId): (WebCore::ProgressBarValueElement::create): (WebCore::ProgressBarValueElement::detach): (WebCore::HTMLProgressElement::parseMappedAttribute): (WebCore::HTMLProgressElement::attach): (WebCore::HTMLProgressElement::valuePart): (WebCore::HTMLProgressElement::didElementStateChange): (WebCore::HTMLProgressElement::createShadowSubtreeIfNeeded):
  • html/HTMLProgressElement.h:
  • rendering/RenderProgress.cpp: (WebCore::RenderProgress::~RenderProgress): (WebCore::RenderProgress::updateFromElement): (WebCore::RenderProgress::layoutParts): (WebCore::RenderProgress::shouldHaveParts): (WebCore::RenderProgress::valuePart):
  • rendering/RenderProgress.h:
  • rendering/style/RenderStyleConstants.h:
8:04 PM Changeset in webkit [77210] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-31 Charlie Reis <​creis@chromium.org>

Reviewed by Mihai Parparita.

Add sanity check to help diagnose bug 52819
​https://bugs.webkit.org/show_bug.cgi?id=53402

Crash early if the children of fromItem look invalid.

  • loader/HistoryController.cpp:
7:56 PM Changeset in webkit [77209] by rniwa@webkit.org
  • 1 edit in trunk/LayoutTests/ChangeLog

Fix the change log entry order.

7:54 PM Changeset in webkit [77208] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

2011-01-31 Emil A Eklund <​eae@chromium.org>

Reviewed by Darin Adler.

Setting "selected" attribute to false should have no effect in single line <select>
​https://bugs.webkit.org/show_bug.cgi?id=52436

Add test for changing the selection in a one-line select element using\
the option.selected property.

  • fast/dom/HTMLSelectElement/selected-false-expected.txt: Added.
  • fast/dom/HTMLSelectElement/selected-false.html: Added.
7:46 PM Changeset in webkit [77207] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-01-31 Kalle Vahlman <​kalle.vahlman@movial.com>

Reviewed by Andreas Kling.

[Qt] canvas.drawImage(HTMLVideoElement) doesn't work with Qt Multimedia backend
​https://bugs.webkit.org/show_bug.cgi?id=53325

Reimplement paintCurrentFrameInContext() rather than delegate the
rendering to paint() to make sure we really do get the video frame
content into the GraphicsContext, regardless of accelerated
compositing and the video scene state.

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivateQt::paintCurrentFrameInContext):
  • platform/graphics/qt/MediaPlayerPrivateQt.h:
7:45 PM Changeset in webkit [77206] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-01-31 Emil A Eklund <​eae@chromium.org>

Reviewed by Darin Adler.

Setting "selected" attribute to false should have no effect in single line <select>
​https://bugs.webkit.org/show_bug.cgi?id=52436

Add test for changing the selection in a one-line select element using\
the option.selected property.

  • fast/dom/HTMLSelectElement/selected-false-expected.txt: Added.
  • fast/dom/HTMLSelectElement/selected-false.html: Added.

2011-01-31 Emil A Eklund <​eae@chromium.org>

Reviewed by Darin Adler.

Setting "selected" attribute to false should have no effect in single line <select>
​https://bugs.webkit.org/show_bug.cgi?id=52436

Change SelectElement::setSelectedIndex to select the first selectable
option when the select state of all options is set to false as required
by the HTML5 specification.

Test: fast/dom/HTMLSelectElement/selected-false.html

  • dom/SelectElement.cpp: (WebCore::SelectElement::setSelectedIndex):
7:27 PM Changeset in webkit [77205] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-31 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Console source references need a left-margin
​https://bugs.webkit.org/show_bug.cgi?id=53308

  • inspector/front-end/inspector.css: (.console-message-url): Added a 4px margin on the left.
7:19 PM Changeset in webkit [77204] by mrowe@apple.com
  • 2 edits in branches/safari-533.20-branch/WebCore

Merge r73937.

7:19 PM Changeset in webkit [77203] by mrowe@apple.com
  • 5 edits
    2 adds in branches/safari-533.20-branch

Merge r73927.

7:08 PM Changeset in webkit [77202] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.20-branch

Merge r59357.

6:54 PM Changeset in webkit [77201] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.20-branch

Merge r72833.

6:54 PM Changeset in webkit [77200] by mrowe@apple.com
  • 11 edits
    9 adds in branches/safari-533.20-branch

Merge r72590.

6:54 PM Changeset in webkit [77199] by mrowe@apple.com
  • 2 edits in branches/safari-533.20-branch/LayoutTests

Merge r72353.

6:54 PM Changeset in webkit [77198] by mrowe@apple.com
  • 2 edits in branches/safari-533.20-branch/WebCore

Merge r72348.

6:54 PM Changeset in webkit [77197] by mrowe@apple.com
  • 9 edits
    8 adds in branches/safari-533.20-branch

Merge r72344.

6:53 PM Changeset in webkit [77196] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.20-branch

Merge r72301.

6:53 PM Changeset in webkit [77195] by mrowe@apple.com
  • 4 edits in branches/safari-533.20-branch/WebCore

Merge r71947.

6:53 PM Changeset in webkit [77194] by mrowe@apple.com
  • 2 edits in branches/safari-533.20-branch/WebCore

Merge r71684.

6:53 PM Changeset in webkit [77193] by mrowe@apple.com
  • 4 edits
    4 adds in branches/safari-533.20-branch

Merge r72924.

6:53 PM Changeset in webkit [77192] by mrowe@apple.com
  • 4 edits
    4 adds in branches/safari-533.20-branch

Merge r72819.

6:36 PM Changeset in webkit [77191] by carol.szabo@nokia.com
  • 4 edits in trunk/Source/WebCore

2011-01-31 Carol Szabo <​carol.szabo@nokia.com>

Reviewed by David Hyatt.

Code Changes only.

It is needlessly expensive to find the generating node from an anonymous renderer of a pseudoelement.
​https://bugs.webkit.org/show_bug.cgi?id=53024

No new tests. No change in functionality

  • rendering/RenderObject.h: (WebCore::RenderObject::before): (WebCore::RenderObject::after): (WebCore::RenderObject::generatingNode): Added new accessors for the use of the CSS 2.1 counters code (mainlyly)
  • rendering/RenderObjectChildList.cpp: (WebCore::beforeAfterContainer): (WebCore::RenderObjectChildList::invalidateCounters): (WebCore::RenderObjectChildList::before): (WebCore::RenderObjectChildList::after): Refactored the code to take advantage of the new accessors. (WebCore::RenderObjectChildList::updateBeforeAfterContent): Changed to store the generating node in the :before and :after renderers.
  • rendering/RenderObjectChildList.h:
6:09 PM Changeset in webkit [77190] by rniwa@webkit.org
  • 7 edits in trunk/LayoutTests

2011-01-31 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed Chromium rebaselines for r77173.

  • platform/chromium-mac/fast/text/justify-ideograph-complex-expected.checksum:
  • platform/chromium-mac/fast/text/justify-ideograph-complex-expected.png:
  • platform/chromium-mac/fast/text/justify-ideograph-simple-expected.checksum:
  • platform/chromium-mac/fast/text/justify-ideograph-simple-expected.png:
  • platform/chromium-mac/fast/text/justify-ideograph-vertical-expected.checksum:
  • platform/chromium-mac/fast/text/justify-ideograph-vertical-expected.png:
6:00 PM Changeset in webkit [77189] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.20-branch

Merge r75548.

5:49 PM Changeset in webkit [77188] by mrowe@apple.com
  • 2 edits in branches/safari-533.20-branch/WebCore

Merge r67634.

5:46 PM Changeset in webkit [77187] by mrowe@apple.com
  • 4 edits
    2 adds in branches/safari-533.20-branch

Merge r70594.

5:45 PM Changeset in webkit [77186] by commit-queue@webkit.org
  • 7 edits in trunk

2011-01-31 Krithigassree Sambamurthy <​krithigassree.sambamurthy@nokia.com>

Reviewed by David Hyatt.

Add background-clip to background shorthand
​https://bugs.webkit.org/show_bug.cgi?id=52080

Added test cases to check whether webkitMaskClip is correctly set when
declared as a shorthand.

  • fast/backgrounds/multiple-backgrounds-computed-style-expected.txt:
  • fast/backgrounds/script-tests/multiple-backgrounds-computed-style.js:

Added test cases to check whether background-clip is set correctly when
declared as a shorthand.

  • fast/css/background-clip-text-expected.txt:
  • fast/css/script-tests/background-clip-text.js: (test):

2011-01-31 Krithigassree Sambamurthy <​krithigassree.sambamurthy@nokia.com>

Reviewed by David Hyatt.

Add background-clip to background shorthand
​https://bugs.webkit.org/show_bug.cgi?id=52080

Added background-clip to background-shorthand. Also made changes to
include webkitMaskClip to the mask shorthand to keep both in sync.

  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseFillShorthand):
5:43 PM Changeset in webkit [77185] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.20-branch

Merge r74045.

5:40 PM Changeset in webkit [77184] by mrowe@apple.com
  • 7 edits
    3 adds in branches/safari-533.20-branch

Merge r67568.

5:27 PM Changeset in webkit [77183] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-01-31 Srikumar Bonda <​srikumar.b@gmail.com>

Reviewed by Andreas Kling.

[Qt] ContextMenuClientQt.cpp has coding-style errors
"RefCounted.h" header inclusion style changed to <wtf/RefCounted.h>
​https://bugs.webkit.org/show_bug.cgi?id=40243

  • WebCoreSupport/ContextMenuClientQt.cpp:
5:20 PM Changeset in webkit [77182] by Darin Adler
  • 4 edits in trunk/Source

2011-01-31 Darin Adler <Darin Adler>

Reviewed by Adele Peterson.

WKView should support scrollPageDown:, scrollPageUp:, scrollToBeg and other similar selectors
​https://bugs.webkit.org/show_bug.cgi?id=53460

  • editing/EditorCommand.cpp: (WebCore::executeScrollPageBackward): Added. (WebCore::executeScrollPageForward): Added. (WebCore::executeScrollToBeginningOfDocument): Added. (WebCore::executeScrollToEndOfDocument): Added. (WebCore::createCommandMap): Added the four commands above to the map.

2011-01-31 Darin Adler <Darin Adler>

Reviewed by Adele Peterson.

WKView should support scrollPageDown:, scrollPageUp:, scrollToBeg and other similar selectors
​https://bugs.webkit.org/show_bug.cgi?id=53460

  • UIProcess/API/mac/WKView.mm: Added WEBCORE_COMMAND macro for lots of editor commands that are implemented in WebCore so they will get forwarded. Many of these will probably work without any further changes required. Added comments about the methods that we do not yet forward. (createSelectorExceptionMap): Map scrollPageDown: to ScrollPageForward and scrollPageUp: to ScrollPageBackward because we want the page up and page down keys to follow the document logical order, not physical order. This is equivalent to what we do in WebPage::performDefaultBehaviorForKeyEvent.
5:19 PM Changeset in webkit [77181] by mrowe@apple.com
  • 2 edits in branches/safari-533.20-branch/WebCore

Merge r59477.

5:14 PM Changeset in webkit [77180] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.20-branch

Merge r72639.

5:10 PM Changeset in webkit [77179] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.20-branch

Merge r72685.

5:02 PM Changeset in webkit [77178] by mrowe@apple.com
  • 3 edits
    3 adds in branches/safari-533.20-branch

Merge r69051.

5:00 PM Changeset in webkit [77177] by mrowe@apple.com
  • 3 edits
    4 adds in branches/safari-533.20-branch

Merge r74155.

4:57 PM Changeset in webkit [77176] by commit-queue@webkit.org
  • 1 edit in trunk/ChangeLog

2010-01-28 Commit Queue <​commit-queue@webkit.org>

Unreviewed. Test commit for ​commit-queue@webkit.org.

4:50 PM Changeset in webkit [77175] by mrowe@apple.com
  • 5 edits in branches/safari-533.20-branch/LayoutTests

Merge r72166.

4:50 PM Changeset in webkit [77174] by mrowe@apple.com
  • 2 edits in branches/safari-533.20-branch/WebCore

Merge r72163.

4:44 PM BuildingQtOnOSX edited by andreas.kling@nokia.com
(diff)
4:30 PM Changeset in webkit [77173] by mitz@apple.com
  • 11 edits in trunk

Inter-ideograph justification should apply to hiragana and katakana as well
​https://bugs.webkit.org/show_bug.cgi?id=53464

Reviewed by Adele Peterson.

Source/WebCore:

Changed the test for expansion opportunities from isCJKIdeograph() to isCJKIdeographOrSymbol().

  • platform/graphics/Font.cpp:

(WebCore::Font::expansionOpportunityCount):

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::advance):

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::adjustGlyphsAndAdvances):

LayoutTests:

  • platform/mac/fast/text/justify-ideograph-complex-expected.checksum:
  • platform/mac/fast/text/justify-ideograph-complex-expected.png:
  • platform/mac/fast/text/justify-ideograph-simple-expected.checksum:
  • platform/mac/fast/text/justify-ideograph-simple-expected.png:
  • platform/mac/fast/text/justify-ideograph-vertical-expected.checksum:
  • platform/mac/fast/text/justify-ideograph-vertical-expected.png:
4:20 PM Changeset in webkit [77172] by mihaip@chromium.org
  • 2 edits in trunk/Tools

2011-01-31 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Tony Chang.

[Chromium] Switch chromium-mac to use ChromiumDriver
​https://bugs.webkit.org/show_bug.cgi?id=53461

For the sake of consistency with the other Chromium platforms (and so
that chromium-mac picks up special flags like --enable-hardware-gpu),
switch chromium-mac from the WebKitDriver to ChromiumDriver.

  • Scripts/webkitpy/layout_tests/port/chromium.py:
3:54 PM Changeset in webkit [77171] by Dimitri Glazkov
  • 2 edits in trunk/Source/WebCore

2011-01-31 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by James Robinson.

REGRESSION(r76951): Appearance of media controls changed slightly on Qt/Chromium ports
​https://bugs.webkit.org/show_bug.cgi?id=53314

Fixes media/controls-strict.html on Chromium.

  • css/mediaControlsChromium.css: (audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):

Added proper box-sizing to avoid differences between strict/quirks mode.

3:50 PM Changeset in webkit [77170] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-31 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Validation message bubble shouldn't inherit text-security style
​https://bugs.webkit.org/show_bug.cgi?id=53457

No new tests because the validation message feature depends on timers
and is enabled only in Chromium port.

  • css/html.css: (::-webkit-validation-bubble): Reset -webkit-text-security.
3:44 PM Changeset in webkit [77169] by mrowe@apple.com
  • 5 edits in branches/safari-533.20-branch/WebCore

Merge r74759.

3:44 PM Changeset in webkit [77168] by mrowe@apple.com
  • 5 edits
    5 adds in branches/safari-533.20-branch

Merge r74716.

3:44 PM Changeset in webkit [77167] by mrowe@apple.com
  • 5 edits in branches/safari-533.20-branch/WebCore

Merge r62016.

3:42 PM Changeset in webkit [77166] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-31 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed Chromium test expectation update.

  • platform/chromium/test_expectations.txt:
3:11 PM Changeset in webkit [77165] by oliver@apple.com
  • 3 edits
    3 adds in trunk

2011-01-31 Oliver Hunt <​oliver@apple.com>

Reviewed by Sam Weinig.

Bogus callframe during stack unwinding
​https://bugs.webkit.org/show_bug.cgi?id=53454

Add test

  • fast/js/invalid-callframe-during-unwind-expected.txt: Added.
  • fast/js/invalid-callframe-during-unwind.html: Added.
  • fast/js/script-tests/invalid-callframe-during-unwind.js: Added. (testUnwind):

2011-01-31 Oliver Hunt <​oliver@apple.com>

Reviewed by Sam Weinig.

Bogus callframe during stack unwinding
​https://bugs.webkit.org/show_bug.cgi?id=53454

Trying to access a callframe's globalData after destroying its
ScopeChain is not a good thing. While we could access the
globalData directly through the (known valid) scopechain we're
holding on to, it feels fragile. Instead we push the valid
ScopeChain onto the callframe again to ensure that the callframe
itself remains valid.

  • interpreter/Interpreter.cpp: (JSC::Interpreter::unwindCallFrame):
2:59 PM BuildingQtOnOSX edited by Dimitri Glazkov
(diff)
2:59 PM Changeset in webkit [77164] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit/win

Fix the clean Windows build.

Reviewed by Adam Roben.

  • WebKitGraphics.cpp:

(WebDrawText):

2:59 PM Changeset in webkit [77163] by dpranke@chromium.org
  • 16 edits in trunk/Tools

2011-01-31 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Mihai Parparita.

The current modifier parsing code in test_expectations is
fragile and hard-coded, so it's not easy to understand the logic
or easily add new types of modifiers (like GPU vs. CPU testing
for graphics tests, or 32-bit vs. 64-bit differences).

This is the first of two patches that will add in more generic
support and then eliminate the GPU-specific test expectations
files for Chromium.

This patch adds two standalone objects for handling modifiers. The
rules for interpreting modifiers, precedence, and conflicts are
given in the docstring to the ModifierMatcher class, which
returns ModifierMatchResult objects.

This patch also adds routines to the Port interface and a
default set of values in the base object, in order to obtain the
values needed on a given test run. These values are then passed
to the expectation parser. This also allows us to clean up the
logic used to lint all of the different configurations in a
single test_expectations.txt file.

The next patch will merge in the separate GPU expectations file.

​https://bugs.webkit.org/show_bug.cgi?id=51222

  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Tools/Scripts/webkitpy/style/checkers/test_expectations.py:
  • Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2:56 PM Changeset in webkit [77162] by crogers@google.com
  • 2 edits in trunk/Source/WebKit/chromium

2011-01-31 Chris Rogers <​crogers@google.com>

Reviewed by Jeremy Orlow.

Improve audio latency on Mac OS X for chromium port
​https://bugs.webkit.org/show_bug.cgi?id=53452

  • src/AudioDestinationChromium.cpp:
2:32 PM Changeset in webkit [77161] by dbates@webkit.org
  • 4 edits
    1 add in trunk

2011-01-31 Scott Cameron <​sccameron@rim.com>

Reviewed by Daniel Bates.

update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment
​https://bugs.webkit.org/show_bug.cgi?id=50036

This will add an Apache2.2 configuration file and modifies scripts to allow
running an httpd server in an MSYS environment.

The default Apache2.2 installation path has been preserved and PHP5 modules disabled
in order to allow for simple installation/execution. Simply install the latest
Apache2.2 version with OpenSSL from ​http://httpd.apache.org/download.cgi#apache22 to
be able to execute run-webkit-httpd.


  • http/conf/apache2-msys-httpd.conf: Added.

2011-01-31 Scott Cameron <​sccameron@rim.com>

Reviewed by Daniel Bates.

update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment
​https://bugs.webkit.org/show_bug.cgi?id=50036

This will add an Apache2.2 configuration file and modifies scripts to allow
running an httpd server in an MSYS environment.

The default Apache2.2 installation path has been preserved and PHP5 modules disabled
in order to allow for simple installation/execution. Simply install the latest
Apache2.2 version with OpenSSL from ​http://httpd.apache.org/download.cgi#apache22 to
be able to execute run-webkit-httpd.


  • Scripts/run-webkit-httpd:
  • Scripts/webkitperl/httpd.pm:
2:27 PM Changeset in webkit [77160] by rniwa@webkit.org
  • 2 edits
    4 adds in trunk/LayoutTests

2011-01-31 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed Chromium Mac rebaselines for r77153; also rebaseline Kusa-Makura-background-canvas.html

  • platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.png: Added.
  • platform/chromium-mac/fast/text/international/text-combine-image-test-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/text-combine-image-test-expected.png: Added.
  • platform/chromium/test_expectations.txt:
2:24 PM Changeset in webkit [77159] by msaboff@apple.com
  • 5 edits in trunk/Source

Rolling back in the changes for ​https://bugs.webkit.org/show_bug.cgi?id=53271.

1:39 PM Changeset in webkit [77158] by hyatt@apple.com
  • 1 edit in trunk/Source/WebCore/rendering/RenderCombineText.cpp

Fix 32-bit build bustage.

1:29 PM Changeset in webkit [77157] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-31 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed Chromium test expectation update.

  • platform/chromium/test_expectations.txt:
1:05 PM Changeset in webkit [77156] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-01-31 Andreas Kling <​kling@webkit.org>

Unbreak Qt build after r77151.

  • bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::removeCachedMethod): (JSC::Bindings::QtInstance::markAggregate):
12:51 PM Changeset in webkit [77155] by alex
  • 1 edit
    6 adds in trunk/LayoutTests

2011-01-31 Alejandro G. Castro <​alex@igalia.com>

Unreviewed added new expected results for GTK+.

  • platform/gtk/fast/box-shadow/box-shadow-radius-expected.txt: Added.
  • platform/gtk/fast/box-shadow/box-shadow-transformed-expected.txt: Added.
  • platform/gtk/fast/box-shadow/inset-box-shadow-radius-expected.txt: Added.
  • platform/gtk/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.txt: Added.
  • platform/gtk/fast/repaint/gradients-em-stops-repaint-expected.txt: Added.
  • platform/gtk/fast/repaint/select-option-background-color-expected.txt: Added.
12:48 PM Changeset in webkit [77154] by chang.shu@nokia.com
  • 2 edits
    1 add
    13 deletes in trunk/LayoutTests

2011-01-31 Chang Shu <​chang.shu@nokia.com>

Reviewed by Ryosuke Niwa.

Convert the test case to dumpAsText test so the expected result is cross-platform.
​https://bugs.webkit.org/show_bug.cgi?id=53437

  • editing/deleting/5168598-expected.txt: Added.
  • editing/deleting/5168598.html:
  • platform/chromium-linux/editing/deleting/5168598-expected.checksum: Removed.
  • platform/chromium-linux/editing/deleting/5168598-expected.png: Removed.
  • platform/chromium-win/editing/deleting/5168598-expected.checksum: Removed.
  • platform/chromium-win/editing/deleting/5168598-expected.png: Removed.
  • platform/chromium-win/editing/deleting/5168598-expected.txt: Removed.
  • platform/mac-leopard/editing/deleting/5168598-expected.checksum: Removed.
  • platform/mac-leopard/editing/deleting/5168598-expected.png: Removed.
  • platform/mac/editing/deleting/5168598-expected.checksum: Removed.
  • platform/mac/editing/deleting/5168598-expected.png: Removed.
  • platform/mac/editing/deleting/5168598-expected.txt: Removed.
  • platform/qt/editing/deleting/5168598-expected.checksum: Removed.
  • platform/qt/editing/deleting/5168598-expected.png: Removed.
  • platform/qt/editing/deleting/5168598-expected.txt: Removed.
12:39 PM Changeset in webkit [77153] by hyatt@apple.com
  • 47 edits
    7 adds in trunk

Implement text-combine rendering code
​https://bugs.webkit.org/show_bug.cgi?id=50621

Patch by takano takumi <​takano@apple.com> on 2011-01-31
Reviewed by Dave Hyatt.

Source/WebCore:

Test: fast/text/international/text-combine-image-test.html

  • Android.mk: Added RenderCombineText.cpp/h
  • CMakeLists.txt: Added RenderCombineText.cpp/h
  • GNUmakefile.am: Added RenderCombineText.cpp/h
  • WebCore.exp.in:
  • WebCore.gypi: Added RenderCombineText.cpp/h
  • WebCore.pro: Added RenderCombineText.cpp/h
  • WebCore.vcproj/WebCore.vcproj: Added RenderCombineText.cpp/h
  • WebCore.xcodeproj/project.pbxproj: Added RenderCombineText.cpp/h
  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData):

  • Added fontDescription.widthVariant to SimpleFontData creation.
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • Changed to set "Unique" flag to RenderStyle in case of TextCombine.
  • dom/Text.cpp:

(WebCore::Text::createRenderer):

  • Changed to create RenderCombineText in case of TextCombine.
  • loader/cache/CachedFont.cpp:

(WebCore::CachedFont::platformDataFromCustomData):

  • Added FontWidthVariant as an argument for FontPlatformData creation.
  • loader/cache/CachedFont.h:
  • Ditto.
  • platform/graphics/Font.h:

(WebCore::Font::widthVariant):

  • The accessor to FontWidthVariant member variable.
  • platform/graphics/FontCache.cpp:
  • Made cache to incorporate FontWidthVariant value.

(WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
(WebCore::FontPlatformDataCacheKey::operator==):
(WebCore::computeHash):
(WebCore::FontCache::getCachedFontPlatformData):

  • platform/graphics/FontDescription.h:
  • Add a member variable that holds a width variant - none, half-width, third-width, and quarter-width.

(WebCore::FontDescription::FontDescription):
(WebCore::FontDescription::widthVariant):
(WebCore::FontDescription::setWidthVariant):
(WebCore::FontDescription::operator==):

  • platform/graphics/FontWidthVariant.h: Added.
  • platform/graphics/cairo/FontCustomPlatformData.h:
  • Changed to carry FontWidthVariant value.
  • platform/graphics/cocoa/FontPlatformData.h:
  • Changed to carry FontWidthVariant value.

(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::widthVariant):
(WebCore::FontPlatformData::hash):
(WebCore::FontPlatformData::operator==):

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::FontPlatformData):

  • Changed to carry FontWidthVariant value.

(WebCore::FontPlatformData::operator=):

  • Ditto.

(WebCore::mapFontWidthVariantToCTFeatureSelector):

  • A function to map a FontWidthVariant value to a CoreText's text spacing feature selector.

(WebCore::FontPlatformData::ctFont):

  • Changed to create CTFont with text spacing variant based on FontWidthVariant.
  • platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • Changed to carry FontWidthVariant value.
  • platform/graphics/haiku/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • Changed to carry FontWidthVariant value.
  • platform/graphics/haiku/FontCustomPlatformData.h:
  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::FontCache::createFontPlatformData):

  • Changed to carry FontWidthVariant value.
  • platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • Changed to carry FontWidthVariant value.
  • platform/graphics/mac/FontCustomPlatformData.h:
  • Ditto.
  • platform/graphics/mac/GlyphPageTreeNodeMac.cpp:

(WebCore::shouldUseCoreText):

  • Changed to skip CT path when width variant is specified.
  • platform/graphics/pango/FontCustomPlatformDataPango.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • Ditto.
  • platform/graphics/qt/FontCustomPlatformData.h:
  • Ditto.
  • platform/graphics/qt/FontCustomPlatformDataQt.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • Ditto.
  • platform/graphics/skia/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • Ditto.
  • platform/graphics/skia/FontCustomPlatformData.h:
  • Ditto.
  • platform/graphics/win/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • Ditto.
  • platform/graphics/win/FontCustomPlatformData.h:
  • Ditto.
  • platform/graphics/win/FontCustomPlatformDataCairo.cpp:
  • Ditto.

(WebCore::FontCustomPlatformData::fontPlatformData):

  • Ditto.
  • platform/graphics/win/FontCustomPlatformDataCairo.h:
  • Ditto.
  • platform/graphics/wince/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • Ditto.
  • platform/graphics/wince/FontCustomPlatformData.h:
  • Ditto.
  • platform/graphics/wx/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • Ditto.
  • platform/graphics/wx/FontCustomPlatformData.h:
  • Ditto.
  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint):

  • In case of RenderCombineText, we don't rotate text even in vertical writing. Also, we render original text

instead of text returned from text().

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):

  • Made to call RenderCombinedText's prepareTextCombine() here.
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::textWidth):

  • Made to always use the render object's width() in case of TextCombine.

(WebCore::RenderBlock::findNextLineBreak):

  • Made to call RenderCombinedText's prepareTextCombine() here.
  • rendering/RenderCombineText.cpp: Added. A subclass of RenderText.

(WebCore::RenderCombineText::RenderCombineText):
(WebCore::RenderCombineText::styleDidChange):

  • Clear the flag that indicated the font has been prepared for combining. The font will be reinitialized in

the next call of RenderBlock::findNextLineBreak().
(WebCore::RenderCombineText::setTextInternal):

  • Ditto.

(WebCore::RenderCombineText::width):

  • Returns 1-em width in case of font combine.

(WebCore::RenderCombineText::adjustTextOrigin):

  • Adjust drawing origin point in case of font combine.

(WebCore::RenderCombineText::charactersToRender):

  • Return original text instead of current text in case of font combine.

(WebCore::RenderCombineText::combineText):

  • This function tries to pack passed text with; 1) the current font as is, 2) the font created

from the descriptor with half-width variant specified, 3) the font with third-width variant, 4) the font
with quarter-width variant.

  • If a suitable font successfully found, replace the current font with the new font. If no appropriate font found,

we give up text-combine as the CSS spec describes.

  • If a new font found, we replace the text with 0xFFFC. This is needed for a combined text block to be able to

behave like a single character against text decorations.

  • rendering/RenderCombineText.h: Added.

(WebCore::RenderCombineText::isCombined):
(WebCore::RenderCombineText::combinedTextWidth):

  • Returns 1-em width in case of font combine.

(WebCore::RenderCombineText::renderName):
(WebCore::toRenderCombineText):

  • rendering/RenderText.cpp:

(WebCore::RenderText::widthFromCache):

  • Made to call RenderCombineText's combinedTextWidth when the text is combined.
  • rendering/RenderingAllInOne.cpp: Added RenderCombineText.cpp
  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::hasTextCombine):

  • Added for a quick test of TextCombine.

LayoutTests:

  • fast/text/international/text-combine-image-test.html: Added.
  • platform/mac/fast/text/international/text-combine-image-test-expected.checksum: Added.
  • platform/mac/fast/text/international/text-combine-image-test-expected.png: Added.
  • platform/mac/fast/text/international/text-combine-image-test-expected.txt: Added.
12:15 PM Changeset in webkit [77152] by jberlin@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

[Windows 7 Release Tests] fast/forms/select-writing-direction-natural.html failing since r77046
​https://bugs.webkit.org/show_bug.cgi?id=53443

Checking in failing expected results for Windows to get the bots green. Ureviewed.

  • platform/win/fast/forms/select-writing-direction-natural-expected.txt: Added.
12:07 PM Changeset in webkit [77151] by oliver@apple.com
  • 126 edits
    2 adds in trunk/Source

2011-01-31 Oliver Hunt <​oliver@apple.com>

Convert markstack to a slot visitor API
​https://bugs.webkit.org/show_bug.cgi?id=53219

rolling r77098, r77099, r77100, r77109, and
r77111 back in, along with a few more Qt fix attempts.

12:04 PM Changeset in webkit [77150] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-31 Ryosuke Niwa <​rniwa@webkit.org>

Another unreviewed Chromium test expectation update.

  • platform/chromium/test_expectations.txt:
11:57 AM Changeset in webkit [77149] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-31 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed Chromium test expectation update.

  • platform/chromium/test_expectations.txt:
11:37 AM Changeset in webkit [77148] by kov@webkit.org
  • 5 edits in trunk/Source

2011-01-31 Dan Winship <​danw@gnome.org>

Reviewed by Gustavo Noronha Silva.

wss (websockets ssl) support for gtk via new gio TLS support
​https://bugs.webkit.org/show_bug.cgi?id=50344

Add a GPollableOutputStream typedef for TLS WebSockets support

  • wtf/gobject/GTypedefs.h:

2011-01-31 Dan Winship <​danw@gnome.org>

Reviewed by Gustavo Noronha Silva.

wss (websockets ssl) support for gtk via new gio TLS support
​https://bugs.webkit.org/show_bug.cgi?id=50344

Update to use GPollableOutputStream and GTlsConnection to
implement wss URLs

  • platform/network/soup/SocketStreamHandle.h:
  • platform/network/soup/SocketStreamHandleSoup.cpp: (WebCore::SocketStreamHandle::SocketStreamHandle): (WebCore::SocketStreamHandle::connected): (WebCore::SocketStreamHandle::platformSend): (WebCore::SocketStreamHandle::beginWaitingForSocketWritability): (WebCore::writeReadyCallback):
11:25 AM Changeset in webkit [77147] by jberlin@webkit.org
  • 3 edits
    2 adds in trunk/Source/WebKit2

WebKit2: the cookies used by the WebKit2 Web Process should not go in a top-level
directory.
​https://bugs.webkit.org/show_bug.cgi?id=53278

Reviewed by Steve Falkenburg.

Use the name WebKit2WebProcess since the default location for the cookies is determined
based on the process name (which is WebKit2WebProcess.exe on Windows).

  • win/WebKit2.make:

Copy the WebKit2WebProcess.resources directory into the AppleInternal bin.

  • win/WebKit2WebProcess.resources: Added.
  • win/WebKit2WebProcess.resources/Info.plist: Added.

Copied from the WebKit version of Info.plist.

  • win/WebKit2WebProcessPostBuild.cmd:

Copy the WebKit2WebProcess.resources directory into the WebKitOutPutDir's bin.

11:08 AM Changeset in webkit [77146] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-31 Tony Chang <​tony@chromium.org>

Unreviewed, update chromium mac layout test results after r77138.
fast/blockflow/Kusa-Makura-background-canvas.html and fast/multicol/vertical-rl/float-paginate-complex.html
match upstream text results now.

  • platform/chromium/test_expectations.txt:
11:02 AM Changeset in webkit [77145] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=53352
Heavy external fragmentation in FixedVMPoolAllocator can lead to a CRASH().

Reviewed by Geoff Garen.

The FixedVMPoolAllocator currently uses a best fix policy -
switch to first fit, this is less prone to external fragmentation.

  • jit/ExecutableAllocatorFixedVMPool.cpp:

(JSC::AllocationTableSizeClass::AllocationTableSizeClass):
(JSC::AllocationTableSizeClass::blockSize):
(JSC::AllocationTableSizeClass::blockCount):
(JSC::AllocationTableSizeClass::blockAlignment):
(JSC::AllocationTableSizeClass::size):
(JSC::AllocationTableLeaf::AllocationTableLeaf):
(JSC::AllocationTableLeaf::~AllocationTableLeaf):
(JSC::AllocationTableLeaf::allocate):
(JSC::AllocationTableLeaf::free):
(JSC::AllocationTableLeaf::isEmpty):
(JSC::AllocationTableLeaf::isFull):
(JSC::AllocationTableLeaf::size):
(JSC::AllocationTableLeaf::classForSize):
(JSC::AllocationTableLeaf::dump):
(JSC::LazyAllocationTable::LazyAllocationTable):
(JSC::LazyAllocationTable::~LazyAllocationTable):
(JSC::LazyAllocationTable::allocate):
(JSC::LazyAllocationTable::free):
(JSC::LazyAllocationTable::isEmpty):
(JSC::LazyAllocationTable::isFull):
(JSC::LazyAllocationTable::size):
(JSC::LazyAllocationTable::dump):
(JSC::LazyAllocationTable::classForSize):
(JSC::AllocationTableDirectory::AllocationTableDirectory):
(JSC::AllocationTableDirectory::~AllocationTableDirectory):
(JSC::AllocationTableDirectory::allocate):
(JSC::AllocationTableDirectory::free):
(JSC::AllocationTableDirectory::isEmpty):
(JSC::AllocationTableDirectory::isFull):
(JSC::AllocationTableDirectory::size):
(JSC::AllocationTableDirectory::classForSize):
(JSC::AllocationTableDirectory::dump):
(JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
(JSC::FixedVMPoolAllocator::alloc):
(JSC::FixedVMPoolAllocator::free):
(JSC::FixedVMPoolAllocator::allocated):
(JSC::FixedVMPoolAllocator::isValid):
(JSC::FixedVMPoolAllocator::classForSize):
(JSC::FixedVMPoolAllocator::offsetToPointer):
(JSC::FixedVMPoolAllocator::pointerToOffset):
(JSC::ExecutableAllocator::committedByteCount):
(JSC::ExecutableAllocator::isValid):
(JSC::ExecutableAllocator::underMemoryPressure):
(JSC::ExecutablePool::systemAlloc):
(JSC::ExecutablePool::systemRelease):

  • wtf/PageReservation.h:

(WTF::PageReservation::PageReservation):
(WTF::PageReservation::commit):
(WTF::PageReservation::decommit):
(WTF::PageReservation::committed):

11:00 AM Changeset in webkit [77144] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2011-01-31 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dimitri Glazkov.

Check the textarea node still exists in document before casting
it to HTMLTextAreaElement.
​https://bugs.webkit.org/show_bug.cgi?id=53429

Test: fast/forms/textarea-node-removed-from-document-crash.html

  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::~RenderTextControlMultiLine):

2011-01-31 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dimitri Glazkov.

Tests that we do not crash when destructing textarea renderer when its
node is already removed from document.
​https://bugs.webkit.org/show_bug.cgi?id=53429

  • fast/forms/textarea-node-removed-from-document-crash-expected.txt: Added.
  • fast/forms/textarea-node-removed-from-document-crash.html: Added.
10:56 AM Changeset in webkit [77143] by mitz@apple.com
  • 1 edit
    6 deletes in trunk/LayoutTests

Remove expected results in mac-wk2 and win that are equal to the mac results after r77138.

  • platform/mac-wk2/fast/blockflow/Kusa-Makura-background-canvas-expected.txt: Removed.
  • platform/mac-wk2/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt: Removed.
  • platform/mac-wk2/fast/multicol/vertical-rl/float-paginate-complex-expected.txt: Removed.
  • platform/win/fast/block/basic/truncation-rtl-expected.txt: Removed.
  • platform/win/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt: Removed.
  • platform/win/fast/multicol/vertical-rl/float-paginate-complex-expected.txt: Removed.
10:28 AM Changeset in webkit [77142] by inferno@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

2011-01-31 Cris Neckar <​cdn@chromium.org>

Reviewed by Eric Seidel.

Tests for crash when cloning elements that reference counter nodes.
​https://bugs.webkit.org/show_bug.cgi?id=53344

  • http/tests/css/counter-crash-expected.txt: Added.
  • http/tests/css/counter-crash.html: Added.
  • http/tests/css/resources/counter-crash-frame-src.html: Added.
10:23 AM Changeset in webkit [77141] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2011-01-27 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dave Hyatt.

Tests that we do not crash when adding a child in a table
where the before child is not a table section.
​https://bugs.webkit.org/show_bug.cgi?id=53276

  • fast/table/before-child-non-table-section-add-table-crash-expected.txt: Added.
  • fast/table/before-child-non-table-section-add-table-crash.html: Added.

2011-01-27 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dave Hyatt.

If beforeChild is wrapped in an anonymous table section, we need to
go the parent to find it and use it before adding childs to table.
​https://bugs.webkit.org/show_bug.cgi?id=53276

We need to make sure that beforeChild's parent is "this" before calling
RenderBox::addChild. The previous condition in while is too restrictive
and fails to calculate the right beforeChild value when its display
style is table caption.
Test: fast/table/before-child-non-table-section-add-table-crash.html

  • rendering/RenderTable.cpp: (WebCore::RenderTable::addChild):
10:11 AM Changeset in webkit [77140] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

2011-01-31 Shane Stephens <​shanestephens@google.com>

Reviewed by Simon Fraser.

AffineTransform::translateRight incorrectly computes a translateLeft.
​https://bugs.webkit.org/show_bug.cgi?id=52551

Removed translateRight and converted all uses to perform standard
matrix multiplication.

No new tests because patch doesn't modify functionality.

  • platform/graphics/transforms/AffineTransform.cpp:
  • platform/graphics/transforms/AffineTransform.h: (WebCore::AffineTransform::translation):
  • rendering/svg/RenderSVGResourceMarker.cpp: (WebCore::RenderSVGResourceMarker::localToParentTransform):
  • rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::localToRepaintContainerTransform): (WebCore::RenderSVGRoot::localToParentTransform):
  • rendering/svg/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::localToParentTransform):
  • rendering/svg/SVGTextLayoutEngine.cpp: (WebCore::SVGTextLayoutEngine::finalizeTransformMatrices):
10:08 AM Changeset in webkit [77139] by andersca@apple.com
  • 7 edits
    1 add in trunk/Source/WebKit2

2011-01-31 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam Roben.

Make LayerTreeHost an abstract base class and make LayerTreeHostMac inherit from it
​https://bugs.webkit.org/show_bug.cgi?id=53432

  • WebKit2.xcodeproj/project.pbxproj: Add LayerTreeHostMac.h.
  • WebProcess/WebPage/DrawingAreaImpl.cpp:
  • WebProcess/WebPage/DrawingAreaImpl.h: Make m_layerTreeHost an OwnPtr and initialize/destroy it appropriately.
  • WebProcess/WebPage/LayerTreeHost.cpp: (WebKit::LayerTreeHost::create): On Mac, create a LayerTreeHostMac instance.

(WebKit::LayerTreeHost::~LayerTreeHost):
No need to call platformInvalidate anymore.

  • WebProcess/WebPage/LayerTreeHost.h:
  • WebProcess/WebPage/mac/LayerTreeHostMac.h: Added.
  • WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::~LayerTreeHostMac): Invalidate the run loop observer here instead of in platformInvalidate.

(WebKit::LayerTreeHostMac::scheduleLayerFlush):
(WebKit::LayerTreeHostMac::flushPendingLayerChangesRunLoopObserverCallback):
These are now members of LayerTreeHostMac.

10:06 AM Changeset in webkit [77138] by tony@chromium.org
  • 7 edits in trunk

2011-01-31 Tony Chang <​tony@chromium.org>

Reviewed by Eric Seidel.

mac DRT should report RTL scroll offset relative to top right corner
​https://bugs.webkit.org/show_bug.cgi?id=53324

Remove scroll offsets since these are at the origin.

  • platform/mac/fast/block/basic/truncation-rtl-expected.txt:
  • platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:
  • platform/mac/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt:
  • platform/mac/fast/multicol/vertical-rl/float-paginate-complex-expected.txt:

2011-01-31 Tony Chang <​tony@chromium.org>

Reviewed by Eric Seidel.

mac DRT should report RTL scroll offset relative to top right corner
​https://bugs.webkit.org/show_bug.cgi?id=53324

  • DumpRenderTree/mac/DumpRenderTree.mm: (dumpFrameScrollPosition):
9:57 AM Changeset in webkit [77137] by mario@webkit.org
  • 4 edits in trunk/Source

2011-01-31 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Martin Robinson.

[Gtk] atk_text_set_caret_offset returns True even when it is unsuccessful
​https://bugs.webkit.org/show_bug.cgi?id=53389

Return FALSE when not able to set the caret at the specified offset.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_set_caret_offset): Return FALSE when the range created is NULL and adjust offset to account for list markers.

2011-01-31 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Martin Robinson.

[Gtk] atk_text_set_caret_offset returns True even when it is unsuccessful
​https://bugs.webkit.org/show_bug.cgi?id=53389

New unit test to check the fix for this bug.

  • tests/testatk.c: (testWebkitAtkCaretOffsets): New. (main): Add new test.
9:37 AM Changeset in webkit [77136] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-31 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Mark some tests as having wrong image results on Mac.

  • platform/chromium/test_expectations.txt:
9:18 AM Changeset in webkit [77135] by ager@chromium.org
  • 11 edits in trunk/LayoutTests

2011-01-31 Mads Ager <​ager@chromium.org>

Reviewed by Pavel Feldman.

[V8] Update V8 specific layout test expectations
​https://bugs.webkit.org/show_bug.cgi?id=53423

Error formatting has changed in V8. Updating chromium specific
layout test expectations accordingly.

  • platform/chromium-mac/fast/js/array-every-expected.txt:
  • platform/chromium-mac/fast/js/instance-of-immediates-expected.txt:
  • platform/chromium-mac/fast/js/property-getters-and-setters-expected.txt:
  • platform/chromium-mac/storage/transaction-error-callback-expected.txt:
  • platform/chromium-mac/svg/dom/svgpath-out-of-bounds-getPathSeg-expected.txt:
  • platform/chromium-win/fast/js/array-every-expected.txt:
  • platform/chromium-win/fast/js/instance-of-immediates-expected.txt:
  • platform/chromium-win/fast/js/property-getters-and-setters-expected.txt:
  • platform/chromium-win/storage/transaction-error-callback-expected.txt:
  • platform/chromium-win/svg/dom/svgpath-out-of-bounds-getPathSeg-expected.txt:
9:14 AM Changeset in webkit [77134] by alex
  • 2 edits in trunk/LayoutTests

2011-01-31 Alejandro G. Castro <​alex@igalia.com>

Unreviewed skipped favicon-as-image.html test, it is flaky and it
was unskipped after r76555.

  • platform/gtk/Skipped:
9:05 AM Changeset in webkit [77133] by mnaganov@chromium.org
  • 1 edit in branches/chromium/648/Source/WebCore/inspector/front-end/NetworkPanel.js

Merge 77128 - 2011-01-28 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: copy HAR to clipboard instead of saving blob on export.
​https://bugs.webkit.org/show_bug.cgi?id=53328

  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._exportAll): (WebInspector.NetworkPanel.prototype._exportResource):

TBR=​pfeldman@chromium.org
Review URL: ​http://codereview.chromium.org/6312032

8:35 AM Changeset in webkit [77132] by Simon Fraser
  • 3 edits in trunk/LayoutTests

2011-01-31 Simon Fraser <Simon Fraser>

Update a pixel resuls after r77101.

  • platform/mac/fast/css/color-correction-on-box-shadow-expected.checksum:
  • platform/mac/fast/css/color-correction-on-box-shadow-expected.png:
8:03 AM Changeset in webkit [77131] by yurys@chromium.org
  • 3 edits
    2 adds in trunk/LayoutTests

2011-01-31 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

  • platform/chromium-mac/fast/css/color-correction-on-box-shadow-expected.checksum: Added.
  • platform/chromium-mac/fast/css/color-correction-on-box-shadow-expected.png: Added.
  • platform/chromium-mac/fast/transforms/shadows-expected.checksum:
  • platform/chromium-mac/fast/transforms/shadows-expected.png:
7:39 AM Changeset in webkit [77130] by zoltan@webkit.org
  • 3 edits in trunk/Tools

[Qt] Add Take Screen Shot action to MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=53422

Reviewed by Andreas Kling.

Add Take Screen Shot action to MiniBrowser's view menu.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::screenshot):

  • MiniBrowser/qt/BrowserWindow.h:
7:29 AM Changeset in webkit [77129] by kbr@google.com
  • 3 edits
    3 deletes in trunk/LayoutTests

2011-01-31 Kenneth Russell <​kbr@google.com>

Unreviewed, test and expectations update. Stop reporting the precise
pixel value for tests that are supposed to be within a certain range.
Remove now-unneeded Chromium expectations.

  • fast/canvas/webgl/gl-teximage-expected.txt:
  • fast/canvas/webgl/gl-teximage.html:
  • platform/chromium-linux/fast/canvas/webgl/gl-teximage-expected.txt: Removed.
  • platform/chromium-mac/fast/canvas/webgl/gl-teximage-expected.txt: Removed.
  • platform/chromium-win/fast/canvas/webgl/gl-teximage-expected.txt: Removed.
7:18 AM Changeset in webkit [77128] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-28 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: copy HAR to clipboard instead of saving blob on export.
​https://bugs.webkit.org/show_bug.cgi?id=53328

  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._exportAll): (WebInspector.NetworkPanel.prototype._exportResource):
6:43 AM Changeset in webkit [77127] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-01-30 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: speed up network panel rendering.
​https://bugs.webkit.org/show_bug.cgi?id=53397

  • inspector/front-end/DataGrid.js: (WebInspector.DataGrid.prototype.get scrollContainer):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.elementsToRestoreScrollPositionsFor): (WebInspector.NetworkPanel.prototype._positionSummaryBar): (WebInspector.NetworkPanel.prototype._createTable): (WebInspector.NetworkPanel.prototype._exportResource): (WebInspector.NetworkPanel.prototype._onScroll):
  • inspector/front-end/networkPanel.css: (.network-sidebar .data-grid.small tr.offscreen): (.network-sidebar .data-grid tr.offscreen): (.network-sidebar .data-grid tr.offscreen td):
6:34 AM Changeset in webkit [77126] by pvarga@webkit.org
  • 4 edits
    1 delete in trunk/Source/WebCore

2011-01-31 Peter Varga <​pvarga@webkit.org>

Reviewed by Andreas Kling.

Remove wrec from WebCore
​https://bugs.webkit.org/show_bug.cgi?id=53298

No new tests needed.

  • Android.jscbindings.mk:
  • ForwardingHeaders/wrec/WREC.h: Removed.
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/copyForwardingHeaders.cmd:
6:26 AM Changeset in webkit [77125] by commit-queue@webkit.org
  • 5 edits in trunk/Source

2011-01-31 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r76969.
​http://trac.webkit.org/changeset/76969
​https://bugs.webkit.org/show_bug.cgi?id=53418

"It is causing crashes in GTK+ and Leopard bots" (Requested by
alexg on #webkit).

  • runtime/WeakGCMap.h:

2011-01-31 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r76969.
​http://trac.webkit.org/changeset/76969
​https://bugs.webkit.org/show_bug.cgi?id=53418

"It is causing crashes in GTK+ and Leopard bots" (Requested by
alexg on #webkit).

  • bridge/runtime_root.cpp: (JSC::Bindings::RootObject::invalidate): (JSC::Bindings::RootObject::addRuntimeObject): (JSC::Bindings::RootObject::removeRuntimeObject):
  • bridge/runtime_root.h:
6:23 AM Changeset in webkit [77124] by yurys@chromium.org
  • 3 edits
    17 adds
    4 deletes in trunk/LayoutTests

2011-01-31 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

  • platform/chromium-mac/fast/blockflow/box-shadow-horizontal-bt-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/box-shadow-horizontal-bt-expected.png: Added.
  • platform/chromium-mac/fast/blockflow/box-shadow-vertical-lr-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/box-shadow-vertical-lr-expected.png: Added.
  • platform/chromium-mac/fast/blockflow/box-shadow-vertical-rl-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/box-shadow-vertical-rl-expected.png: Added.
  • platform/chromium-mac/fast/borders/border-radius-split-inline-expected.checksum: Added.
  • platform/chromium-mac/fast/borders/border-radius-split-inline-expected.png: Added.
  • platform/chromium-mac/fast/box-shadow/box-shadow-transformed-expected.checksum: Added.
  • platform/chromium-mac/fast/box-shadow/box-shadow-transformed-expected.png: Added.
  • platform/chromium-mac/fast/repaint/box-shadow-h-expected.checksum:
  • platform/chromium-mac/fast/repaint/box-shadow-h-expected.png:
  • platform/chromium-mac/fast/repaint/box-shadow-v-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/box-shadow-v-expected.png: Added.
  • platform/chromium-mac/fast/repaint/gradients-em-stops-repaint-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/gradients-em-stops-repaint-expected.png: Added.
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.checksum: Removed.
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Removed.
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.checksum: Removed.
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.png: Removed.
  • platform/chromium-mac/fast/transforms/shadows-expected.checksum: Added.
  • platform/chromium-mac/fast/transforms/shadows-expected.png: Added.
5:59 AM Changeset in webkit [77123] by kov@webkit.org
  • 7 edits in trunk

2011-01-31 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] REGRESSION: http/tests/media/video-{cookie,referer}.html failing
​https://bugs.webkit.org/show_bug.cgi?id=53379

Remove left over mentions of HAVE_SOUP_2_29_90, and apply the
dependency on newer soup to efl as well.

  • Source/cmake/OptionsEfl.cmake:

2011-01-31 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] REGRESSION: http/tests/media/video-{cookie,referer}.html failing
​https://bugs.webkit.org/show_bug.cgi?id=53379

Unskip tests that pass again.

  • platform/gtk/Skipped:

2011-01-31 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] REGRESSION: http/tests/media/video-{cookie,referer}.html failing
​https://bugs.webkit.org/show_bug.cgi?id=53379

Remove left over #ifdef's. I thought all of the conditional code
had been freed from the condition, but I forgot to check DRT.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setAlwaysAcceptCookies):
5:36 AM Changeset in webkit [77122] by mnaganov@chromium.org
  • 3 edits
    5 copies in branches/chromium/648

Merge 76429 - 2011-01-21 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Adam Barth.

Regression: new window.onerror() implementation leaks cross-origin Javascript errors
​https://bugs.webkit.org/show_bug.cgi?id=52903

In case of an exception in a script from different domain only generic message
will be passed to window.onerror hander.

Tests: http/tests/security/cross-origin-script-window-onerror-redirected.html

http/tests/security/cross-origin-script-window-onerror.html

  • bindings/js/CachedScriptSourceProvider.h: use URL from the resource response to make sure we do all cross origin checks agains real script URL, not the original URL which may have resulted in a sequence of redirects to different domains. (WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider):
  • bindings/v8/ScriptSourceCode.h: same for v8. (WebCore::ScriptSourceCode::url):
  • dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::dispatchErrorEvent): in case the error occurred in a script we cannot access provide concise "Script error." message without any information about the error source. This is what Firefox does in this case.

2011-01-21 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Adam Barth.

Regression: new window.onerror() implementation leaks cross-origin Javascript errors
​https://bugs.webkit.org/show_bug.cgi?id=52903

A couple of tests to check that window.onerror won't reveal any content of the resource
from a different domain if the latter is referenced via <script src=...>

  • http/tests/security/cross-origin-script-window-onerror-expected.txt: Added.
  • http/tests/security/cross-origin-script-window-onerror-redirected-expected.txt: Added.
  • http/tests/security/cross-origin-script-window-onerror-redirected.html: Added.
  • http/tests/security/cross-origin-script-window-onerror.html: Added.
  • http/tests/security/resources/cross-origin-script.txt: Added.

TBR=​abarth@webkit.org
Review URL: ​http://codereview.chromium.org/6409009

3:56 AM Changeset in webkit [77121] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Not reviewed.

Spelling.

  • css/CSSSelectorList.h:

(WebCore::CSSSelectorList::next):

3:45 AM Changeset in webkit [77120] by yurys@chromium.org
  • 1 edit
    5 adds in trunk/LayoutTests

2011-01-31 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Update Chromium test expectations after r77108

  • platform/chromium-linux/fast/canvas/webgl/gl-teximage-expected.txt: Added.
  • platform/chromium-mac/fast/canvas/webgl/gl-teximage-expected.txt: Added.
  • platform/chromium-win/fast/canvas/webgl/gl-teximage-expected.txt: Added.
3:10 AM Changeset in webkit [77119] by yurys@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-01-31 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Fix Chromium compilation on Linux.

  • platform/graphics/ShadowBlur.cpp: added PLATFORM(CHROMIUM) guard
  • platform/graphics/ShadowBlur.h: added missing ColorSpace.h header include
2:55 AM Changeset in webkit [77118] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-31 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Fix Chromium compilation on Mac broken by r77101.

  • WebCore.gypi: add ShadowBlur.{h,cpp} to the gypi file.
2:51 AM Changeset in webkit [77117] by yurys@chromium.org
  • 1 edit
    16 adds in trunk/LayoutTests

2011-01-31 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Update Chromium test expectations after r77101

  • platform/chromium-linux/fast/box-shadow/box-shadow-transformed-expected.checksum: Added.
  • platform/chromium-linux/fast/box-shadow/box-shadow-transformed-expected.png: Added.
  • platform/chromium-linux/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.checksum: Added.
  • platform/chromium-linux/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Added.
  • platform/chromium-win/fast/box-shadow/box-shadow-radius-expected.checksum: Added.
  • platform/chromium-win/fast/box-shadow/box-shadow-radius-expected.png: Added.
  • platform/chromium-win/fast/box-shadow/box-shadow-radius-expected.txt: Added.
  • platform/chromium-win/fast/box-shadow/box-shadow-transformed-expected.checksum: Added.
  • platform/chromium-win/fast/box-shadow/box-shadow-transformed-expected.png: Added.
  • platform/chromium-win/fast/box-shadow/box-shadow-transformed-expected.txt: Added.
  • platform/chromium-win/fast/box-shadow/inset-box-shadow-radius-expected.checksum: Added.
  • platform/chromium-win/fast/box-shadow/inset-box-shadow-radius-expected.png: Added.
  • platform/chromium-win/fast/box-shadow/inset-box-shadow-radius-expected.txt: Added.
  • platform/chromium-win/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.checksum: Added.
  • platform/chromium-win/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Added.
  • platform/chromium-win/fast/repaint/gradients-em-stops-repaint-expected.txt: Added.
2:44 AM Changeset in webkit [77116] by mnaganov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-01-31 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: Change button title from "Clear CPU profiles" to "Clear all profiles".

​https://bugs.webkit.org/show_bug.cgi?id=53309

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel):
2:35 AM Changeset in webkit [77115] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebCore

2011-01-31 Carlos Garcia Campos <​cgarcia@igalia.com>

Unreviewed, fix the build with current GTK+ 3.x.

  • plugins/gtk/gtk2xtbin.c:
  • plugins/gtk/gtk2xtbin.h:

Jan 30, 2011:

11:18 PM Changeset in webkit [77114] by tkent@chromium.org
  • 7 edits
    2 adds in trunk

2011-01-30 Kenichi Ishibashi <​bashi@google.com>

Reviewed by Kent Tamura.

Dangling form associated elements should not be registered on the document
​https://bugs.webkit.org/show_bug.cgi?id=53223

Adds insertedIntoDocument() and remvoedFromDocument() to
FormAssociatedElement class to register the element on the document
if and only if it actually inserted into (removed from) the document.

Test: fast/forms/dangling-form-element-crash.html

  • html/FormAssociatedElement.cpp: (WebCore::FormAssociatedElement::insertedIntoDocument): Added. (WebCore::FormAssociatedElement::removedFromDocument): Ditto. (WebCore::FormAssociatedElement::insertedIntoTree): Don't register the element to a document. (WebCore::FormAssociatedElement::removedFromTree): Don't unregister the element from a document.
  • html/FormAssociatedElement.h:
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::insertedIntoDocument): Added. (WebCore::HTMLFormControlElement::removedFromDocument): Ditto.
  • html/HTMLFormControlElement.h:
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::insertedIntoDocument): Calls FormAssociatedElement::insertedIntoDocument(). (WebCore::HTMLObjectElement::removedFromDocument): Calls FormAssociatedElement::removedFromDocument().

2011-01-30 Kenichi Ishibashi <​bashi@google.com>

Reviewed by Kent Tamura.

Dangling form associated elements should not be registered on the document
​https://bugs.webkit.org/show_bug.cgi?id=53223

Adds a test that ensures dangling form associated elements are not
registered on the document.

  • fast/forms/dangling-form-element-crash-expected.txt: Added.
  • fast/forms/dangling-form-element-crash.html: Added.
10:56 PM Changeset in webkit [77113] by Csaba Osztrogonác
  • 127 edits
    2 deletes in trunk/Source

2011-01-30 Csaba Osztrogonác <Csaba Osztrogonác>

Unreviewed, rolling out r77098, r77099, r77100, r77109, and
r77111.
​http://trac.webkit.org/changeset/77098
​http://trac.webkit.org/changeset/77099
​http://trac.webkit.org/changeset/77100
​http://trac.webkit.org/changeset/77109
​http://trac.webkit.org/changeset/77111
​https://bugs.webkit.org/show_bug.cgi?id=53219

Qt build is broken

  • API/JSCallbackObject.h: (JSC::JSCallbackObjectData::setPrivateProperty): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::getPrivateProperty): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::setPrivateProperty): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::markChildren): (JSC::JSCallbackObject::setPrivateProperty):
  • API/JSCallbackObjectFunctions.h: (JSC::::put): (JSC::::staticFunctionGetter):
  • API/JSObjectRef.cpp: (JSObjectMakeConstructor): (JSObjectSetPrivateProperty):
  • API/JSWeakObjectMapRefInternal.h:
  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::markAggregate):
  • bytecode/CodeBlock.h: (JSC::CodeBlock::globalObject):
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): (JSC::BytecodeGenerator::emitJumpIfNotFunctionCall): (JSC::BytecodeGenerator::emitJumpIfNotFunctionApply): (JSC::BytecodeGenerator::findScopedProperty):
  • debugger/Debugger.cpp: (JSC::evaluateInGlobalCallFrame):
  • debugger/DebuggerActivation.cpp: (JSC::DebuggerActivation::DebuggerActivation): (JSC::DebuggerActivation::markChildren):
  • debugger/DebuggerActivation.h:
  • debugger/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::evaluate):
  • interpreter/CallFrame.h: (JSC::ExecState::exception):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::resolve): (JSC::Interpreter::resolveSkip): (JSC::Interpreter::resolveGlobal): (JSC::Interpreter::resolveGlobalDynamic): (JSC::Interpreter::resolveBaseAndProperty): (JSC::Interpreter::unwindCallFrame): (JSC::appendSourceToError): (JSC::Interpreter::execute): (JSC::Interpreter::tryCacheGetByID): (JSC::Interpreter::privateExecute):
  • jit/JITStubs.cpp: (JSC::JITThunks::tryCacheGetByID): (JSC::DEFINE_STUB_FUNCTION):
  • jsc.cpp: (GlobalObject::GlobalObject):
  • runtime/ArgList.cpp: (JSC::MarkedArgumentBuffer::markLists):
  • runtime/Arguments.cpp: (JSC::Arguments::markChildren): (JSC::Arguments::getOwnPropertySlot): (JSC::Arguments::getOwnPropertyDescriptor): (JSC::Arguments::put):
  • runtime/Arguments.h: (JSC::Arguments::setActivation): (JSC::Arguments::Arguments):
  • runtime/ArrayConstructor.cpp: (JSC::ArrayConstructor::ArrayConstructor): (JSC::constructArrayWithSizeQuirk):
  • runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncSplice):
  • runtime/BatchedTransitionOptimizer.h: (JSC::BatchedTransitionOptimizer::BatchedTransitionOptimizer): (JSC::BatchedTransitionOptimizer::~BatchedTransitionOptimizer):
  • runtime/BooleanConstructor.cpp: (JSC::BooleanConstructor::BooleanConstructor): (JSC::constructBoolean): (JSC::constructBooleanFromImmediateBoolean):
  • runtime/BooleanPrototype.cpp: (JSC::BooleanPrototype::BooleanPrototype):
  • runtime/ConservativeSet.cpp: (JSC::ConservativeSet::grow):
  • runtime/ConservativeSet.h: (JSC::ConservativeSet::~ConservativeSet): (JSC::ConservativeSet::mark):
  • runtime/DateConstructor.cpp: (JSC::DateConstructor::DateConstructor):
  • runtime/DateInstance.cpp: (JSC::DateInstance::DateInstance):
  • runtime/DatePrototype.cpp: (JSC::dateProtoFuncSetTime): (JSC::setNewValueFromTimeArgs): (JSC::setNewValueFromDateArgs): (JSC::dateProtoFuncSetYear):
  • runtime/ErrorConstructor.cpp: (JSC::ErrorConstructor::ErrorConstructor):
  • runtime/ErrorInstance.cpp: (JSC::ErrorInstance::ErrorInstance):
  • runtime/ErrorPrototype.cpp: (JSC::ErrorPrototype::ErrorPrototype):
  • runtime/FunctionConstructor.cpp: (JSC::FunctionConstructor::FunctionConstructor):
  • runtime/FunctionPrototype.cpp: (JSC::FunctionPrototype::FunctionPrototype):
  • runtime/GetterSetter.cpp: (JSC::GetterSetter::markChildren):
  • runtime/GetterSetter.h: (JSC::GetterSetter::GetterSetter): (JSC::GetterSetter::getter): (JSC::GetterSetter::setGetter): (JSC::GetterSetter::setter): (JSC::GetterSetter::setSetter):
  • runtime/GlobalEvalFunction.cpp: (JSC::GlobalEvalFunction::GlobalEvalFunction): (JSC::GlobalEvalFunction::markChildren):
  • runtime/GlobalEvalFunction.h: (JSC::GlobalEvalFunction::cachedGlobalObject):
  • runtime/Heap.cpp: (JSC::Heap::markProtectedObjects): (JSC::Heap::markTempSortVectors): (JSC::Heap::markRoots):
  • runtime/InternalFunction.cpp: (JSC::InternalFunction::InternalFunction):
  • runtime/JSAPIValueWrapper.h: (JSC::JSAPIValueWrapper::value): (JSC::JSAPIValueWrapper::JSAPIValueWrapper):
  • runtime/JSActivation.cpp: (JSC::JSActivation::markChildren): (JSC::JSActivation::put):
  • runtime/JSArray.cpp: (JSC::JSArray::JSArray): (JSC::JSArray::getOwnPropertySlot): (JSC::JSArray::getOwnPropertyDescriptor): (JSC::JSArray::put): (JSC::JSArray::putSlowCase): (JSC::JSArray::deleteProperty): (JSC::JSArray::increaseVectorLength): (JSC::JSArray::setLength): (JSC::JSArray::pop): (JSC::JSArray::push): (JSC::JSArray::unshiftCount): (JSC::JSArray::sort): (JSC::JSArray::fillArgList): (JSC::JSArray::copyToRegisters): (JSC::JSArray::compactForSorting):
  • runtime/JSArray.h: (JSC::JSArray::getIndex): (JSC::JSArray::setIndex): (JSC::JSArray::uncheckedSetIndex): (JSC::JSArray::markChildrenDirect):
  • runtime/JSByteArray.cpp: (JSC::JSByteArray::JSByteArray):
  • runtime/JSCell.h: (JSC::JSCell::JSValue::toThisObject): (JSC::JSCell::MarkStack::append):
  • runtime/JSFunction.cpp: (JSC::JSFunction::JSFunction): (JSC::JSFunction::getOwnPropertySlot):
  • runtime/JSGlobalData.h:
  • runtime/JSGlobalObject.cpp: (JSC::markIfNeeded): (JSC::JSGlobalObject::reset): (JSC::JSGlobalObject::resetPrototype): (JSC::JSGlobalObject::markChildren):
  • runtime/JSGlobalObject.h: (JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData): (JSC::JSGlobalObject::regExpConstructor): (JSC::JSGlobalObject::errorConstructor): (JSC::JSGlobalObject::evalErrorConstructor): (JSC::JSGlobalObject::rangeErrorConstructor): (JSC::JSGlobalObject::referenceErrorConstructor): (JSC::JSGlobalObject::syntaxErrorConstructor): (JSC::JSGlobalObject::typeErrorConstructor): (JSC::JSGlobalObject::URIErrorConstructor): (JSC::JSGlobalObject::evalFunction): (JSC::JSGlobalObject::objectPrototype): (JSC::JSGlobalObject::functionPrototype): (JSC::JSGlobalObject::arrayPrototype): (JSC::JSGlobalObject::booleanPrototype): (JSC::JSGlobalObject::stringPrototype): (JSC::JSGlobalObject::numberPrototype): (JSC::JSGlobalObject::datePrototype): (JSC::JSGlobalObject::regExpPrototype): (JSC::JSGlobalObject::methodCallDummy): (JSC::Structure::prototypeForLookup): (JSC::constructArray):
  • runtime/JSONObject.cpp: (JSC::Stringifier::Holder::object): (JSC::Stringifier::markAggregate): (JSC::Stringifier::stringify): (JSC::Stringifier::Holder::appendNextProperty): (JSC::Walker::callReviver): (JSC::Walker::walk):
  • runtime/JSObject.cpp: (JSC::JSObject::defineGetter): (JSC::JSObject::defineSetter): (JSC::JSObject::removeDirect): (JSC::JSObject::putDirectFunction): (JSC::JSObject::putDirectFunctionWithoutTransition): (JSC::putDescriptor): (JSC::JSObject::defineOwnProperty):
  • runtime/JSObject.h: (JSC::JSObject::getDirectOffset): (JSC::JSObject::putDirectOffset): (JSC::JSObject::flattenDictionaryObject): (JSC::JSObject::putDirectInternal): (JSC::JSObject::putDirect): (JSC::JSObject::putDirectFunction): (JSC::JSObject::putDirectWithoutTransition): (JSC::JSObject::putDirectFunctionWithoutTransition): (JSC::JSValue::putDirect): (JSC::JSObject::allocatePropertyStorageInline): (JSC::JSObject::markChildrenDirect):
  • runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::JSPropertyNameIterator): (JSC::JSPropertyNameIterator::get):
  • runtime/JSPropertyNameIterator.h:
  • runtime/JSStaticScopeObject.cpp: (JSC::JSStaticScopeObject::markChildren):
  • runtime/JSString.cpp: (JSC::StringObject::create):
  • runtime/JSValue.h:
  • runtime/JSWrapperObject.cpp: (JSC::JSWrapperObject::markChildren):
  • runtime/JSWrapperObject.h: (JSC::JSWrapperObject::internalValue): (JSC::JSWrapperObject::setInternalValue):
  • runtime/LiteralParser.cpp: (JSC::LiteralParser::parse):
  • runtime/Lookup.cpp: (JSC::setUpStaticFunctionSlot):
  • runtime/Lookup.h: (JSC::lookupPut):
  • runtime/MarkStack.h: (JSC::MarkStack::appendValues):
  • runtime/MathObject.cpp: (JSC::MathObject::MathObject):
  • runtime/NativeErrorConstructor.cpp: (JSC::NativeErrorConstructor::NativeErrorConstructor):
  • runtime/NativeErrorPrototype.cpp: (JSC::NativeErrorPrototype::NativeErrorPrototype):
  • runtime/NumberConstructor.cpp: (JSC::NumberConstructor::NumberConstructor): (JSC::constructWithNumberConstructor):
  • runtime/NumberObject.cpp: (JSC::constructNumber):
  • runtime/NumberPrototype.cpp: (JSC::NumberPrototype::NumberPrototype):
  • runtime/ObjectConstructor.cpp: (JSC::ObjectConstructor::ObjectConstructor): (JSC::objectConstructorGetOwnPropertyDescriptor):
  • runtime/Operations.h: (JSC::normalizePrototypeChain): (JSC::resolveBase):
  • runtime/PrototypeFunction.cpp: (JSC::PrototypeFunction::PrototypeFunction):
  • runtime/PutPropertySlot.h: (JSC::PutPropertySlot::setExistingProperty): (JSC::PutPropertySlot::setNewProperty): (JSC::PutPropertySlot::base):
  • runtime/RegExpConstructor.cpp: (JSC::RegExpConstructor::RegExpConstructor):
  • runtime/ScopeChain.cpp: (JSC::ScopeChainNode::print):
  • runtime/ScopeChain.h: (JSC::ScopeChainNode::~ScopeChainNode): (JSC::ScopeChainIterator::operator*): (JSC::ScopeChainIterator::operator->): (JSC::ScopeChain::top):
  • runtime/ScopeChainMark.h: (JSC::ScopeChain::markAggregate):
  • runtime/SmallStrings.cpp: (JSC::isMarked): (JSC::SmallStrings::markChildren):
  • runtime/SmallStrings.h: (JSC::SmallStrings::emptyString): (JSC::SmallStrings::singleCharacterString): (JSC::SmallStrings::singleCharacterStrings):
  • runtime/StringConstructor.cpp: (JSC::StringConstructor::StringConstructor):
  • runtime/StringObject.cpp: (JSC::StringObject::StringObject):
  • runtime/StringObject.h:
  • runtime/StringPrototype.cpp: (JSC::StringPrototype::StringPrototype):
  • runtime/Structure.cpp: (JSC::Structure::Structure): (JSC::Structure::addPropertyTransition): (JSC::Structure::toDictionaryTransition): (JSC::Structure::flattenDictionaryStructure):
  • runtime/Structure.h: (JSC::Structure::storedPrototype):
  • runtime/WeakGCMap.h: (JSC::WeakGCMap::uncheckedGet): (JSC::WeakGCMap::isValid): (JSC::::get): (JSC::::take): (JSC::::set): (JSC::::uncheckedRemove):
  • runtime/WriteBarrier.h: Removed.

2011-01-30 Csaba Osztrogonác <Csaba Osztrogonác>

Unreviewed, rolling out r77098, r77099, r77100, r77109, and
r77111.
​http://trac.webkit.org/changeset/77098
​http://trac.webkit.org/changeset/77099
​http://trac.webkit.org/changeset/77100
​http://trac.webkit.org/changeset/77109
​http://trac.webkit.org/changeset/77111
​https://bugs.webkit.org/show_bug.cgi?id=53219

Qt build is broken

  • JSValueWrapper.cpp: (JSValueWrapper::JSObjectMark):

2011-01-30 Csaba Osztrogonác <Csaba Osztrogonác>

Unreviewed, rolling out r77098, r77099, r77100, r77109, and
r77111.
​http://trac.webkit.org/changeset/77098
​http://trac.webkit.org/changeset/77099
​http://trac.webkit.org/changeset/77100
​http://trac.webkit.org/changeset/77109
​http://trac.webkit.org/changeset/77111
​https://bugs.webkit.org/show_bug.cgi?id=53219

Qt build is broken

  • ForwardingHeaders/runtime/WriteBarrier.h: Removed.
  • WebCore.exp.in:
  • bindings/js/DOMWrapperWorld.h:
  • bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::JSAudioConstructor):
  • bindings/js/JSDOMBinding.cpp: (WebCore::markDOMNodesForDocument): (WebCore::markDOMObjectWrapper): (WebCore::markDOMNodeWrapper):
  • bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::markChildren): (WebCore::JSDOMGlobalObject::setInjectedScript): (WebCore::JSDOMGlobalObject::injectedScript):
  • bindings/js/JSDOMGlobalObject.h: (WebCore::JSDOMGlobalObject::JSDOMGlobalObjectData::JSDOMGlobalObjectData): (WebCore::getDOMConstructor):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation): (WebCore::DialogHandler::dialogCreated):
  • bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::JSDOMWindowShell): (WebCore::JSDOMWindowShell::setWindow): (WebCore::JSDOMWindowShell::markChildren): (WebCore::JSDOMWindowShell::unwrappedObject):
  • bindings/js/JSDOMWindowShell.h: (WebCore::JSDOMWindowShell::window): (WebCore::JSDOMWindowShell::setWindow):
  • bindings/js/JSDeviceMotionEventCustom.cpp: (WebCore::createAccelerationObject): (WebCore::createRotationRateObject):
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::JSEventListener): (WebCore::JSEventListener::markJSFunction):
  • bindings/js/JSEventListener.h: (WebCore::JSEventListener::jsFunction):
  • bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::setAll):
  • bindings/js/JSImageConstructor.cpp: (WebCore::JSImageConstructor::JSImageConstructor):
  • bindings/js/JSImageDataCustom.cpp: (WebCore::toJS):
  • bindings/js/JSJavaScriptCallFrameCustom.cpp: (WebCore::JSJavaScriptCallFrame::scopeChain): (WebCore::JSJavaScriptCallFrame::scopeType):
  • bindings/js/JSNodeFilterCondition.cpp: (WebCore::JSNodeFilterCondition::markAggregate): (WebCore::JSNodeFilterCondition::acceptNode):
  • bindings/js/JSNodeFilterCondition.h:
  • bindings/js/JSNodeFilterCustom.cpp:
  • bindings/js/JSOptionConstructor.cpp: (WebCore::JSOptionConstructor::JSOptionConstructor):
  • bindings/js/JSSQLResultSetRowListCustom.cpp: (WebCore::JSSQLResultSetRowList::item):
  • bindings/js/ScriptCachedFrameData.cpp: (WebCore::ScriptCachedFrameData::restore):
  • bindings/js/ScriptObject.cpp: (WebCore::ScriptGlobalObject::set):
  • bindings/js/SerializedScriptValue.cpp: (WebCore::CloneDeserializer::putProperty):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::QtInstance): (JSC::Bindings::QtInstance::removeCachedMethod): (JSC::Bindings::QtInstance::markAggregate):
  • bridge/qt/qt_instance.h:
  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtRuntimeMetaMethod::QtRuntimeMetaMethod): (JSC::Bindings::QtRuntimeMetaMethod::markChildren): (JSC::Bindings::QtRuntimeMetaMethod::connectGetter): (JSC::Bindings::QtRuntimeMetaMethod::disconnectGetter):
  • bridge/qt/qt_runtime.h:
  • bridge/runtime_root.cpp: (JSC::Bindings::RootObject::invalidate):
  • bridge/runtime_root.h:
  • dom/Document.h:

2011-01-30 Csaba Osztrogonác <Csaba Osztrogonác>

Unreviewed, rolling out r77098, r77099, r77100, r77109, and
r77111.
​http://trac.webkit.org/changeset/77098
​http://trac.webkit.org/changeset/77099
​http://trac.webkit.org/changeset/77100
​http://trac.webkit.org/changeset/77109
​http://trac.webkit.org/changeset/77111
​https://bugs.webkit.org/show_bug.cgi?id=53219

Qt build is broken

  • WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame scopeChain]):
10:18 PM Changeset in webkit [77112] by Simon Fraser
  • 8 edits in trunk/Source/WebCore

2011-01-30 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r77107.
​http://trac.webkit.org/changeset/77107
​https://bugs.webkit.org/show_bug.cgi?id=53412

Caused 5 new form-related test crashes (Requested by smfr on
#webkit).

  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): (WebCore::nameToPseudoTypeMap): (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h:
  • html/HTMLProgressElement.cpp: (WebCore::HTMLProgressElement::parseMappedAttribute): (WebCore::HTMLProgressElement::attach):
  • html/HTMLProgressElement.h:
  • rendering/RenderProgress.cpp: (WebCore::RenderProgress::~RenderProgress): (WebCore::RenderProgress::updateFromElement): (WebCore::RenderProgress::layoutParts): (WebCore::RenderProgress::shouldHaveParts):
  • rendering/RenderProgress.h:
  • rendering/style/RenderStyleConstants.h:
10:05 PM Changeset in webkit [77111] by Simon Fraser
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-30 Simon Fraser <Simon Fraser>

Build fix the build fix. I assume Oliver meant m_cell, not m_value.

  • runtime/WriteBarrier.h: (JSC::WriteBarrierBase::clear):
10:02 PM Changeset in webkit [77110] by Simon Fraser
  • 10 edits
    4 adds in trunk

2011-01-30 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig.

Enhance ShadowBlur to render inset box shadows
​https://bugs.webkit.org/show_bug.cgi?id=51567

Use ShadowBlur for inset box-shadows with CG. It
currently lacks a tiled version, but is still much
faster than CG shadows.

Test: fast/box-shadow/inset-box-shadow-radius.html

  • platform/graphics/ShadowBlur.cpp:
  • platform/graphics/ShadowBlur.h: New method for inset shadows. (WebCore::ShadowBlur::drawInsetShadow):
  • platform/graphics/GraphicsContext.cpp: #ifdef out fillRectWithRoundedHole() for CG.
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillRectWithRoundedHole): If there's a shadow with a radius > 0, use ShadowBlur.
9:54 PM Changeset in webkit [77109] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

More Qt build fixes

9:11 PM Changeset in webkit [77108] by kbr@google.com
  • 5 edits
    1 add in trunk

2011-01-28 Kenneth Russell <​kbr@google.com>

Reviewed by Chris Marrin.

WebGL shows PNG Textures with indexed colors too dark
​https://bugs.webkit.org/show_bug.cgi?id=47477

Added test case for upload of indexed PNG images to
gl-teximage.html in the Khronos WebGL conformance tests.
Synchronized this test with the Khronos repository.

  • fast/canvas/webgl/gl-teximage-expected.txt:
  • fast/canvas/webgl/gl-teximage.html:
  • fast/canvas/webgl/resources/red-indexed.png: Added.

2011-01-28 Kenneth Russell <​kbr@google.com>

Reviewed by Chris Marrin.

WebGL shows PNG Textures with indexed colors too dark
​https://bugs.webkit.org/show_bug.cgi?id=47477

Properly handle indexed PNG images by re-rendering them as RGBA
images before upload. Verified with this layout test and the test
cases from bugs 47477 and 53269.

  • platform/graphics/cg/GraphicsContext3DCG.cpp: (WebCore::GraphicsContext3D::getImageData):
8:39 PM Changeset in webkit [77107] by morrita@google.com
  • 8 edits in trunk/Source/WebCore

2011-01-27 MORITA Hajime <​morrita@google.com>

Reviewed by Dimitri Glazkov.

Convert <progress> shadow DOM to a DOM-based shadow.
​https://bugs.webkit.org/show_bug.cgi?id=50660

  • Removed RenderProgress::m_valuePart, moved the shadow node to the shadow root of HTMLProgressElement.
  • Removed hard-coded pseudo ID for -webkit-progress-bar-value. ProgressBarValueElement is defined only for overriding shadowPseudoId().

No new tests. No behavioral change.

  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): (WebCore::nameToPseudoTypeMap): (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h:
  • html/HTMLProgressElement.cpp: (WebCore::ProgressBarValueElement::ProgressBarValueElement): (WebCore::ProgressBarValueElement::shadowPseudoId): (WebCore::ProgressBarValueElement::create): (WebCore::HTMLProgressElement::parseMappedAttribute): (WebCore::HTMLProgressElement::attach): (WebCore::HTMLProgressElement::valuePart): (WebCore::HTMLProgressElement::didElementStateChange): (WebCore::HTMLProgressElement::createShadowSubtreeIfNeeded):
  • html/HTMLProgressElement.h:
  • rendering/RenderProgress.cpp: (WebCore::RenderProgress::~RenderProgress): (WebCore::RenderProgress::updateFromElement): (WebCore::RenderProgress::layoutParts): (WebCore::RenderProgress::shouldHaveParts): (WebCore::RenderProgress::valuePart):
  • rendering/RenderProgress.h:
  • rendering/style/RenderStyleConstants.h:
8:26 PM Changeset in webkit [77106] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

2011-01-30 Simon Fraser <Simon Fraser>

Reviewed by Ariya Hidayat.

Enhance ShadowBlur to render inset box shadows; Part 1.
​https://bugs.webkit.org/show_bug.cgi?id=51567

Add a new method to GraphicsContext to render a rect with a rounded hole,
for use by inset box-shadow code. Knowledge that we're rendering a rounded
hole will enable ShadowBlur to be used here in future.

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::fillRectWithRoundedHole):
  • platform/graphics/GraphicsContext.h:
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBoxShadow):
8:23 PM Changeset in webkit [77105] by morrita@google.com
  • 3 edits
    4 adds in trunk

2011-01-23 MORITA Hajime <​morrita@google.com>

Reviewed by Eric Seidel.

REGRESSION: Inset shadow with too large border radius misses rounded corner.
​https://bugs.webkit.org/show_bug.cgi?id=52800

  • fast/box-shadow/inset-with-extraordinary-radii-and-border.html: Added.
  • platform/mac/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.checksum: Added.
  • platform/mac/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Added.
  • platform/mac/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.txt: Added.

2011-01-23 MORITA Hajime <​morrita@google.com>

Reviewed by Eric Seidel.

REGRESSION: Inset shadow with too large border radius misses rounded corner.
​https://bugs.webkit.org/show_bug.cgi?id=52800

The refactoring on r76083 broke the invariant between border
IntRect and its radii because RoundedIntRect::setRect() is called
after getRoundedInnerBorderWithBorderWidths(), which enforces the
invariant. Th rounded-rect clipping code verifies the invariant,
and discard the invalid radii, that results broken paintings.

This change moved setRect() before
getRoundedInnerBorderWithBorderWidths() not to modify the valid
RoundedIntRect value.

Test: fast/box-shadow/inset-with-extraordinary-radii-and-border.html

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBoxShadow):
8:06 PM Changeset in webkit [77104] by ggaren@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-01-30 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.

[Take 2!]
Fixed crash on window close (maybe crash on launch?) due to missing frame null checks
​https://bugs.webkit.org/show_bug.cgi?id=53408

  • UIProcess/WebContext.cpp: (WebKit::WebContext::didNavigateWithNavigationData): (WebKit::WebContext::didPerformClientRedirect): (WebKit::WebContext::didPerformServerRedirect): (WebKit::WebContext::didUpdateHistoryTitle): Use MESSAGE_CHECK because we don't think we should be able to reach this state under normal conditions.
8:05 PM Changeset in webkit [77103] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

2011-01-30 Simon Fraser <Simon Fraser>

Attempt to fix Windows build by adding ShadowBlur.cpp/h to the
vcproj.

  • WebCore.vcproj/WebCore.vcproj:
7:36 PM Changeset in webkit [77102] by ggaren@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-01-30 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Fixed crash on window close (maybe crash on launch?) due to missing
frame null checks
​https://bugs.webkit.org/show_bug.cgi?id=53408

  • UIProcess/WebContext.cpp: (WebKit::WebContext::didNavigateWithNavigationData): (WebKit::WebContext::didPerformClientRedirect): (WebKit::WebContext::didPerformServerRedirect): (WebKit::WebContext::didUpdateHistoryTitle): Check for NULL, since we're calling a function that can return it.
7:36 PM Changeset in webkit [77101] by Simon Fraser
  • 32 edits
    1 move
    7 adds
    6 deletes in trunk

2011-01-30 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

-webkit-box-shadow causes awful scroll/resize/redraw performance
​https://bugs.webkit.org/show_bug.cgi?id=22102

Use ShadowBlur for CG, whe rendering shadows on rects and
rounded rects outside of canvas.

CG shadows with a radius of more than 8px do not render
correctly. We preserve this incorrect rendering by compensating
for it when rending -webkit-box-shadow. Calls that should use
this deprecated radius behavior now use setLegacyShadow().

Test: fast/box-shadow/box-shadow-transformed.html

  • html/canvas/CanvasRenderingContext2D.cpp: Use setLegacyShadow() for canvas, to indicate that it should use the deprecated radius behavior. (WebCore::CanvasRenderingContext2D::setAllAttributesToDefault): Ditto. (WebCore::CanvasRenderingContext2D::setShadow): Ditto. (WebCore::CanvasRenderingContext2D::applyShadow): Ditto.
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setLegacyShadow): Set the m_state.shadowsUseLegacyRadius bit.
  • platform/graphics/GraphicsContext.h: (WebCore::GraphicsContextState::GraphicsContextState): Add a shadowsUseLegacyRadius bit to the state.
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::radiusToLegacyRadius): Map from the actual radius to one that approximates CG behavior. (WebCore::hasBlurredShadow): Helper that returns true if we have a shadow with a non-zero blur radius. (WebCore::GraphicsContext::fillRect): Use ShadowBlur if not canvas. (WebCore::GraphicsContext::fillRoundedRect): Ditto. (WebCore::GraphicsContext::setPlatformShadow): Comment.
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBoxShadow): Call setLegacyShadow() for -webkit-box-shadow.
  • platform/graphics/ShadowBlur.cpp: (WebCore::ShadowBlur::calculateLayerBoundingRect): Fix some pixel crack issues by rounding up the blur radius. (WebCore::ShadowBlur::drawRectShadow): Ditto (WebCore::ShadowBlur::drawRectShadowWithTiling): Ditto.
7:11 PM Changeset in webkit [77100] by oliver@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix Qt build (again).

5:35 PM Changeset in webkit [77099] by oliver@apple.com
  • 3 edits in trunk/Source/WebCore

Try to fix Qt build.

5:13 PM Changeset in webkit [77098] by oliver@apple.com
  • 125 edits
    2 adds in trunk/Source

Convert markstack to a slot visitor API
​https://bugs.webkit.org/show_bug.cgi?id=53219

rolling r77006 and r77020 back in.

4:44 PM Changeset in webkit [77097] by Simon Fraser
  • 6 edits
    2 adds in trunk/Source/WebCore

2011-01-30 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig.

Make ContextShadow code cross-platform
​https://bugs.webkit.org/show_bug.cgi?id=51312

Add a new class, ShadowBlur, that contains most of the
code from ContextShadow, but is fully cross-platform.
It depends on one new method, GraphicsContext::clipBounds(),
which platforms will have to implement.

Add ShadowBlur to the Mac Xcode project, but don't use it
anywhere yet.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::clipBounds):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/ShadowBlur.cpp: Added. (WebCore::roundUpToMultipleOf32): (WebCore::ScratchBuffer::ScratchBuffer): (WebCore::ScratchBuffer::getScratchBuffer): (WebCore::ScratchBuffer::scheduleScratchBufferPurge): (WebCore::ScratchBuffer::timerFired): (WebCore::ScratchBuffer::clearScratchBuffer): (WebCore::ScratchBuffer::shared): (WebCore::ShadowBlur::ShadowBlur): (WebCore::ShadowBlur::blurLayerImage): (WebCore::ShadowBlur::adjustBlurDistance): (WebCore::ShadowBlur::calculateLayerBoundingRect): (WebCore::ShadowBlur::beginShadowLayer): (WebCore::ShadowBlur::endShadowLayer): (WebCore::ShadowBlur::drawRectShadow): (WebCore::ShadowBlur::drawRectShadowWithoutTiling): (WebCore::ShadowBlur::drawRectShadowWithTiling): (WebCore::ShadowBlur::clipBounds):
  • platform/graphics/ShadowBlur.h: Added. (WebCore::ShadowBlur::setShadowsIgnoreTransforms): (WebCore::ShadowBlur::shadowsIgnoreTransforms):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::clipBounds):
3:32 PM Changeset in webkit [77096] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-01-30 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, build fix.

Fix regression introduced in r77093 - path.rsplit() doesn't
take keyword arguments.

​https://bugs.webkit.org/show_bug.cgi?id=53326

  • Scripts/webkitpy/common/system/filesystem_mock.py:
3:16 PM Changeset in webkit [77095] by dpranke@chromium.org
  • 5 edits
    3 copies in trunk/Tools

2011-01-30 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Mihai Parparita.

Add more unit tests for rebaseline-chromium-webkit-tests. This
change involves restructuring a bunch of r-c-w-t code to make it
more testable as well. We also add wrapper classes for handling
testing zip files and fetching URLs.

​https://bugs.webkit.org/show_bug.cgi?id=53040

  • Scripts/webkitpy/common/system/urlfetcher.py:
  • Scripts/webkitpy/common/system/urlfetcher_mock.py:
  • Scripts/webkitpy/common/system/zipfileset_mock.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
3:07 PM Changeset in webkit [77094] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

2011-01-30 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Filter all Heap collection through a common reset function, in
preparation for adding features triggered by collection.
​https://bugs.webkit.org/show_bug.cgi?id=53396


SunSpider reports no change.

  • runtime/Heap.cpp: (JSC::Heap::reportExtraMemoryCostSlowCase): When we're over the extraCost limit, just call collectAllGarbage() instead of rolling our own special way of resetting the heap. In theory, this may be slower in some cases, but it also fixes cases of pathological heap growth that we've seen, where the only objects being allocated are temporary and huge (<rdar://problem/8885843>).

(JSC::Heap::allocate):
(JSC::Heap::collectAllGarbage): Use the shared reset function.

(JSC::Heap::reset):

  • runtime/Heap.h: Carved a new shared reset function out of the old collectAllGarbage.
3:07 PM Changeset in webkit [77093] by dpranke@chromium.org
  • 9 edits in trunk/Tools

2011-01-30 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

Clean up of the filesystem-related modules used in webkitpy.
I've added relpath() to the filesystem interface, modified
ospath.relpath() so that it could work with the filesystem
interface, and modified the fileset* routines to use the
filesystem interface consistently.

This patch also adds a close() routine to the fileset routines
to indicate that the caller is done with the fileset. This
allows zipfileset to clean up after itself when it creates
tempfiles to store downloads.

​https://bugs.webkit.org/show_bug.cgi?id=53326

  • Scripts/webkitpy/common/system/directoryfileset.py:
  • Scripts/webkitpy/common/system/fileset.py:
  • Scripts/webkitpy/common/system/filesystem.py:
  • Scripts/webkitpy/common/system/filesystem_mock.py:
  • Scripts/webkitpy/common/system/filesystem_unittest.py:
  • Scripts/webkitpy/common/system/ospath.py:
  • Scripts/webkitpy/common/system/zipfileset.py:
  • Scripts/webkitpy/common/system/zipfileset_unittest.py:
12:25 PM Changeset in webkit [77092] by kbalazs@webkit.org
  • 6 edits in trunk

2011-01-30 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt][WK2]REGRESSION (r76991): Fix build errors
​https://bugs.webkit.org/show_bug.cgi?id=53400

Revert the temporary build fix (​http://trac.webkit.org/changeset/77088)
and remove WebKit2Prefix.h from the build.

  • UIProcess/API/qt/qwkhistory.h:
  • UIProcess/API/qt/qwkpage.h:
  • WebKit2.pro:

2011-01-30 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt][WK2]REGRESSION (r76991): Fix build errors
​https://bugs.webkit.org/show_bug.cgi?id=53400

Revert the temporary build fix (​http://trac.webkit.org/changeset/77088)
and remove WebKit2Prefix.h from the build.

  • MiniBrowser/qt/MiniBrowser.pro:
12:04 PM Changeset in webkit [77091] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-01-30 Jeff Miller <​jeffm@apple.com>

Reviewed by Dan Bernstein.

FindController::updateFindIndicator() crashes if selection isn't visible
​https://bugs.webkit.org/show_bug.cgi?id=53399

  • WebProcess/WebPage/FindController.cpp: (WebKit::FindController::updateFindIndicator): Return false if ShareableBitmap::createShareable() returns null (typically because the selection rect is empty).
11:54 AM Changeset in webkit [77090] by Csaba Osztrogonác
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r77025.
​http://trac.webkit.org/changeset/77025
​https://bugs.webkit.org/show_bug.cgi?id=53401

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-01-30
It made js1_5/Regress/regress-159334.js fail on 64 bit Linux
(Requested by Ossy on #webkit).

  • jit/ExecutableAllocatorFixedVMPool.cpp:

(JSC::FreeListEntry::FreeListEntry):
(JSC::AVLTreeAbstractorForFreeList::get_less):
(JSC::AVLTreeAbstractorForFreeList::set_less):
(JSC::AVLTreeAbstractorForFreeList::get_greater):
(JSC::AVLTreeAbstractorForFreeList::set_greater):
(JSC::AVLTreeAbstractorForFreeList::get_balance_factor):
(JSC::AVLTreeAbstractorForFreeList::set_balance_factor):
(JSC::AVLTreeAbstractorForFreeList::null):
(JSC::AVLTreeAbstractorForFreeList::compare_key_key):
(JSC::AVLTreeAbstractorForFreeList::compare_key_node):
(JSC::AVLTreeAbstractorForFreeList::compare_node_node):
(JSC::reverseSortFreeListEntriesByPointer):
(JSC::reverseSortCommonSizedAllocations):
(JSC::FixedVMPoolAllocator::release):
(JSC::FixedVMPoolAllocator::reuse):
(JSC::FixedVMPoolAllocator::addToFreeList):
(JSC::FixedVMPoolAllocator::coalesceFreeSpace):
(JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
(JSC::FixedVMPoolAllocator::alloc):
(JSC::FixedVMPoolAllocator::free):
(JSC::FixedVMPoolAllocator::isValid):
(JSC::FixedVMPoolAllocator::allocInternal):
(JSC::FixedVMPoolAllocator::isWithinVMPool):
(JSC::FixedVMPoolAllocator::addToCommittedByteCount):
(JSC::ExecutableAllocator::committedByteCount):
(JSC::maybeModifyVMPoolSize):
(JSC::ExecutableAllocator::isValid):
(JSC::ExecutableAllocator::underMemoryPressure):
(JSC::ExecutablePool::systemAlloc):
(JSC::ExecutablePool::systemRelease):

  • wtf/PageReservation.h:

(WTF::PageReservation::PageReservation):
(WTF::PageReservation::commit):
(WTF::PageReservation::decommit):

10:19 AM Changeset in webkit [77089] by Simon Fraser
  • 4 edits
    4 adds in trunk

2011-01-29 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

CSS3 gradients with em-based stops fail to repaint when font size changes
​https://bugs.webkit.org/show_bug.cgi?id=51845

Mark as uncacheable gradidients whose color stops depend on font size,
and don't attempt to put these into CSSImageGeneratorValue's image cache.
This means we return a new gradient each time, which is fairly cheap, and
fixes repaint issues under changing font size.

Test: fast/repaint/gradients-em-stops-repaint.html

  • css/CSSGradientValue.cpp: (WebCore::CSSGradientValue::image): (WebCore::CSSGradientValue::isCacheable):
  • css/CSSGradientValue.h:
5:21 AM Changeset in webkit [77088] by Csaba Osztrogonác
  • 5 edits in trunk

Unreviewed.

[Qt][WK2] Buildfix.

Source/WebKit2:

  • UIProcess/API/qt/qwkhistory.h:
  • UIProcess/API/qt/qwkpage.h:

Tools:

  • MiniBrowser/qt/MiniBrowser.pro:
3:54 AM Changeset in webkit [77087] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-30 Leo Yang <​leo.yang@torchmobile.com.cn>

Reviewed by Daniel Bates.

Code style issue in JavaScriptCore/wtf/CurrentTime.h
​https://bugs.webkit.org/show_bug.cgi?id=53394

According to rule #3 at ​http://webkit.org/coding/coding-style.html,
This patch fix style issue in CurrentTime.h.

No functionality change, no new tests.

  • wtf/CurrentTime.h: (WTF::currentTimeMS): (WTF::getLocalTime):
2:40 AM Changeset in webkit [77086] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-30 Benjamin Poulain <​ikipou@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] JavaScriptCore does not link on Mac if building WebKit 2
​https://bugs.webkit.org/show_bug.cgi?id=53377

The option "-whole-archive" is not availabe with the libtool of Mac OS X,
instead, we can use "-all_load" on Mac.

12:30 AM Changeset in webkit [77085] by mjs@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-01-29 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Geoffrey Garen.

Add WKPageCopyPendingAPIRequestURL API
​https://bugs.webkit.org/show_bug.cgi?id=53383

This API returns the last URL requested for load via API, if neither that load nor any
other load subsequently reaches the provisional state.


This is useful to be able to track loads initiated via the API


  • UIProcess/API/C/WKPage.cpp: (WKPageCopyPendingAPIRequestURL): Retrieve the pending URL.
  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::loadURL): Set pending URL. (WebKit::WebPageProxy::loadURLRequest): ditto (WebKit::WebPageProxy::reload): ditto (WebKit::WebPageProxy::goForward): ditto (WebKit::WebPageProxy::goBack): ditto (WebKit::WebPageProxy::estimatedProgress): Assume the initial progress value when there is a pending URL. (WebKit::WebPageProxy::didStartProvisionalLoadForFrame): Clear pending URL; clients should look at the provisional URL now. (WebKit::WebPageProxy::decidePolicyForNavigationAction): Clear pending URL if it doesn't match the policy URL; this means we were interrupted by another load.
  • UIProcess/WebPageProxy.h: (WebKit::WebPageProxy::pendingAPIRequestURL): Helper function. (WebKit::WebPageProxy::clearPendingAPIRequestURL): ditto (WebKit::WebPageProxy::setPendingAPIRequestURL): ditto
Note: See TracTimeline for information about the timeline view.