Timeline
Feb 2, 2011:
- 10:21 PM Changeset in webkit [77468] by
-
- 3 edits2 adds in trunk
2011-02-02 Chris Evans <cevans@chromium.org>
Reviewed by Darin Fisher.
window.find() can fail when switching case sensitivity
https://bugs.webkit.org/show_bug.cgi?id=53654
The test coverage for this area is very poor, so I took the liberty
of adding a more general test than is needed.
- fast/text/find-window.html: Added.
- fast/text/find-window-expected.txt: Added.
2011-02-02 Chris Evans <cevans@chromium.org>
Reviewed by Darin Fisher.
window.find() can fail when switching case sensitivity
https://bugs.webkit.org/show_bug.cgi?id=53654
Reset the pattern to a safe one when done, to avoid usearch_reset()
indirectly touching the old, stale text pointer.
Test: fast/text/find-window.html
- editing/TextIterator.cpp: (WebCore::SearchBuffer::~SearchBuffer): leave a safe pattern buffer when done.
- 9:45 PM Changeset in webkit [77467] by
-
- 5 edits in trunk/Source/WebCore
2011-02-02 Adam Barth <abarth@webkit.org>
Reviewed by Daniel Bates.
Teach XSSFilter that <param> elements can contain URLs
https://bugs.webkit.org/show_bug.cgi?id=53652
When loading plugins for the <object> tag, we're "smart" enough to
reach into the <param> elements and pull out the URL in some cases.
This patch teaches the XSSFilter how to block injections into those
sorts of param elements.
Fixes:
http/tests/security/xssAuditor/object-*
- html/HTMLParamElement.cpp: (WebCore::HTMLParamElement::isURLParameter): (WebCore::HTMLParamElement::isURLAttribute): (WebCore::HTMLParamElement::addSubresourceAttributeURLs):
- html/HTMLParamElement.h:
- Add a helper function so that HTMLParamElement can share the ground truth for these names with the XSSFilter.
- html/parser/XSSFilter.cpp: (WebCore::XSSFilter::filterTokenInitial): (WebCore::XSSFilter::filterParamToken):
- html/parser/XSSFilter.h:
- 9:41 PM Changeset in webkit [77466] by
-
- 6 edits in trunk/Source/WebKit2
Fix license block issues pointed out by Daniel Bates.
- Shared/API/c/WKGraphicsContext.cpp:
- Shared/API/c/WKGraphicsContext.h:
- Shared/API/c/cg/WKGraphicsContextCG.cpp:
- Shared/API/c/cg/WKGraphicsContextCG.h:
- Shared/WebGraphicsContext.cpp:
- 9:17 PM Changeset in webkit [77465] by
-
- 3 edits1 delete in trunk/LayoutTests
2011-02-02 Martin Robinson <mrobinson@igalia.com>
Rebaseline two tests after import of editing test results for GTK+.
Also remove a platform-specific baseline for a test which is now passing.
- platform/gtk/editing/pasteboard/emacs-ctrl-a-k-y-expected.txt:
- platform/gtk/editing/selection/find-yensign-and-backslash-expected.txt: Removed.
- platform/gtk/fast/dom/52776-expected.txt:
- 8:40 PM Changeset in webkit [77464] by
-
- 2 edits in trunk/Source/WebCore
2011-02-02 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by David Levin.
GCC compiler on ARM issues bogus warnings and fails to compile.
https://bugs.webkit.org/show_bug.cgi?id=53620
Despite warnings explicitly being disallowed (-Wno-uninitialized),
gcc (Ubuntu 4.4.3-4ubuntu5) 4.4.3 throws up the warnings like:
"error: 'colorTransparent.unstatic.4909' may be used uninitialized in this function"
The fix is to add an extra condition, which somehow pacifies the compiler.
- css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::createColor): Added workaround conditions.
- 8:35 PM Changeset in webkit [77463] by
-
- 3 edits in trunk/Source/WebCore
2011-02-02 Adam Barth <abarth@webkit.org>
Reviewed by Daniel Bates.
Teach XSSFilter about X-XSS-Protection
https://bugs.webkit.org/show_bug.cgi?id=53640
This patch causes us to pass:
http/tests/security/xssAuditor/full-block-*
http/tests/security/xssAuditor/no-protection-script-tag.html
- html/parser/XSSFilter.cpp: (WebCore::XSSFilter::XSSFilter): (WebCore::XSSFilter::init): (WebCore::XSSFilter::filterToken):
- html/parser/XSSFilter.h:
- 8:23 PM Changeset in webkit [77462] by
-
- 2 edits in trunk/Source/WebCore
2011-02-02 Adam Barth <abarth@webkit.org>
Reviewed by Daniel Bates.
When XSSFilter blocks JavaScript URLs, use a safe JavaScript URL
instead of the empty string
https://bugs.webkit.org/show_bug.cgi?id=53643
In a URL context, the empty string completes to the URL of the current
page, which causes these tests to go into an infinite loop. Instead,
we should use a "safe" JavaScript URL that does nothing.
Fixes:
http/tests/security/xssAuditor/javascript-link*
- html/parser/XSSFilter.cpp: (WebCore::XSSFilter::eraseDangerousAttributesIfInjected):
- 8:13 PM Changeset in webkit [77461] by
-
- 3 edits4 adds in trunk
<rdar://problem/8380506> REGRESSION (r61921): RTL text in <b> tag doesn't display in WebKit under certain conditions
https://bugs.webkit.org/show_bug.cgi?id=44942
Reviewed by Sam Weinig.
Source/WebCore:
Test: fast/text/bidi-embedding-pop-and-push-same-2.html
- platform/text/BidiResolver.h:
(WebCore::::commitExplicitEmbedding): Changed to return a boolean indicating whether there was
a change to embedding levels.
(WebCore::::createBidiRunsForLine): If embedding levels did not change as a result of committing
the explicit embedding sequence, then runs were not added, and we should continue normally.
LayoutTests:
- fast/text/bidi-embedding-pop-and-push-same-2-expected.checksum: Added.
- fast/text/bidi-embedding-pop-and-push-same-2-expected.png: Added.
- fast/text/bidi-embedding-pop-and-push-same-2-expected.txt: Added.
- fast/text/bidi-embedding-pop-and-push-same-2.html: Added.
- 7:46 PM Changeset in webkit [77460] by
-
- 5 edits in trunk/Source/WebKit2
Add WKBundleFrameGetVisibleContentBoundsExcludingScrollbars API for WebKit2.
Reviewed by Dan Bernstein.
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameGetContentBounds):
(WKBundleFrameGetVisibleContentBounds):
(WKBundleFrameGetVisibleContentBoundsExcludingScrollbars):
(WKBundleFrameGetScrollOffset):
- WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::contentBounds):
(WebKit::WebFrame::visibleContentBounds):
(WebKit::WebFrame::visibleContentBoundsExcludingScrollbars):
(WebKit::WebFrame::scrollOffset):
- WebProcess/WebPage/WebFrame.h:
Move implementation of frame geometry to the implementation file
instead of keeping it in the API file.
- 7:45 PM Changeset in webkit [77459] by
-
- 2 edits in trunk/Source/WebCore
Fix miscalculation of the overhang area used for painting. We were
not correctly accounting for scrollbars resulting in an non-negative
overhang even when we weren't over the edge.
Reviewed by Dan Bernstein.
- platform/ScrollView.cpp:
(WebCore::ScrollView::calculateOverhangAreasForPainting):
- 7:01 PM Changeset in webkit [77458] by
-
- 3 edits in trunk/LayoutTests
2011-02-02 Kenneth Russell <kbr@google.com>
Reviewed by Mihai Parparita.
gl-teximage.html failing on some WebKit bots
https://bugs.webkit.org/show_bug.cgi?id=53633
- fast/canvas/webgl/gl-teximage.html:
- Synced with upstream test; detect when running in DRT and avoid printing the specific pixel value when the test will pass.
- fast/canvas/webgl/resources/red-indexed.png:
- Stripped gamma and other colorspace information.
- 6:39 PM Changeset in webkit [77457] by
-
- 2 edits in trunk/Tools
'update-webkit' should handle OpenSource and Internal using different
VCSs.
Reviewed by Mark Rowe.
- Scripts/update-webkit: Re-check the VCS type when updating Apple's
Internal directory.
- 6:24 PM Changeset in webkit [77456] by
-
- 5 edits in trunk/Source/WebCore
2011-02-02 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
IDBTransaction and IDBRequest can be deleted while ScriptExecutionContext is iterating....which is bad
https://bugs.webkit.org/show_bug.cgi?id=52722
The solution is to change ScriptExecutionContext's destructor to iterate over
the list in a way that handles the mutations. This new method is destructive,
but that's OK since the object is going away. I've also added a several asserts.
There should be no behavior change.
- dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::ScriptExecutionContext): (WebCore::ScriptExecutionContext::~ScriptExecutionContext): (WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects): (WebCore::ScriptExecutionContext::suspendActiveDOMObjects): (WebCore::ScriptExecutionContext::resumeActiveDOMObjects): (WebCore::ScriptExecutionContext::stopActiveDOMObjects): (WebCore::ScriptExecutionContext::createdActiveDOMObject): (WebCore::ScriptExecutionContext::destroyedActiveDOMObject):
- dom/ScriptExecutionContext.h:
- storage/IDBTransaction.cpp: (WebCore::IDBTransaction::contextDestroyed):
- storage/IDBTransaction.h:
- 6:11 PM Changeset in webkit [77455] by
-
- 3 edits in trunk/Source/WebCore
Build fix.
- WebCore.exp.in: Remove some bogus symbols from the .exp.in file.
- platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::unregisterScrollbar): Look the object
up in the HashMap rather than relying on a local variable that doesn't
exist.
- 6:04 PM Changeset in webkit [77454] by
-
- 3 edits in trunk/Source/WebCore
2011-02-02 Adam Barth <abarth@webkit.org>
Reviewed by Daniel Bates.
Teach XSSFilter about JavaScript URLs
https://bugs.webkit.org/show_bug.cgi?id=53635
This patch teaches the XSSFilter to check for JavaScript URLs in
attribute values. If this approach has too many false positives, we
can restrict which attribute names we examine.
Fixes these tests:
http/tests/security/xssAuditor/anchor-url-dom-write-location-javascript-URL.html
http/tests/security/xssAuditor/dom-write-location-javascript-URL.html
http/tests/security/xssAuditor/iframe-javascript-url*
- html/parser/XSSFilter.cpp: (WebCore::HTMLNames::containsJavaScriptURL): (WebCore::XSSFilter::filterTokenInitial): (WebCore::XSSFilter::eraseDangerousAttributesIfInjected):
- html/parser/XSSFilter.h:
- 6:00 PM Changeset in webkit [77453] by
-
- 2 edits277 adds in trunk/LayoutTests
2011-02-02 Martin Robinson <mrobinson@igalia.com>
Unskip the last batch of editing tests needing GTK+ results.
- platform/gtk/Skipped: Unskip last batch of tests.
- 5:58 PM Changeset in webkit [77452] by
-
- 2 edits in trunk/Source/WebKit2
https://bugs.webkit.org/show_bug.cgi?id=53361
<rdar://problem/8921729> REGRESSION: Membuster accumulates 1GB+ memory due to autorelease
pools not being drained.
Call into AppKit to add observers that push and pop autorelease pools on entry
and exit from the CFRunLoop. This will prevent memory from accumulating.
Reviewed by Geoff Garen.
- WebProcess/mac/WebProcessMainMac.mm:
(WebKit::WebProcessMain):
- 5:55 PM Changeset in webkit [77451] by
-
- 2 edits in trunk/Source/WebCore
Build fix.
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
- 5:54 PM Changeset in webkit [77450] by
-
- 2 edits290 adds in trunk/LayoutTests
2011-02-02 Martin Robinson <mrobinson@igalia.com>
Add one more set of missing editing layout test results for GTK.
- platform/gtk/Skipped: Unskip more editing tests.
- 5:51 PM Changeset in webkit [77449] by
-
- 3 edits in trunk/Source/WebKit2
Make null WTF::String objects turn into 0 pointers for WKStringRef and WKURLRef.
rdar://problem/8948688
Reviewed by Sam Weinig.
- Shared/API/c/WKSharedAPICast.h:
(WebKit::toAPI): Return 0 if the passed in string is 0.
(WebKit::toCopiedAPI): Ditto.
(WebKit::toURLRef): Ditto. Old code was trying to do this but was missing a return.
(WebKit::toCopiedURLAPI): Ditto. Old code was trying to do this but had incorrect
nll check.
- Shared/WebString.h: Removed isNull function. It can never return true.
Removed constructor code that turns the null string into the empty string.
Instead assert that the passed in string is not null.
- 5:48 PM Changeset in webkit [77448] by
-
- 2 edits in trunk/Source/JavaScriptCore
Windows build fix.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 5:36 PM Changeset in webkit [77447] by
-
- 4 edits in trunk/Source
<rdar://problem/8928367> Crash when loading canvas pages inside HTMLCanvasElement::createImageBuffer().
Reviewed by Beth Dakin.
Source/WebKit/mac:
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Add some missing initializers.
Source/WebKit2:
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Add some missing initializers.
- 5:36 PM Changeset in webkit [77446] by
-
- 3 edits in trunk/Source/WebCore
<rdar://problem/8952012> Crash on launch inside scrollbar code.
Reviewed by Beth Dakin.
We need to ensure that we remove ourselves as the delegates of objects when we're going
away as failing to do this can lead to crashes if the lifetime of the other objects
is longer than ours.
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
- platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::unregisterScrollbar):
- 5:36 PM Changeset in webkit [77445] by
-
- 2 edits in trunk/Source/JavaScriptCore
oops, build fix!
- wtf/Assertions.cpp:
- 5:35 PM Changeset in webkit [77444] by
-
- 2 edits288 adds in trunk/LayoutTests
2011-02-02 Martin Robinson <mrobinson@igalia.com>
Continue importing new editing layout test results for GTK.
- platform/gtk/Skipped: Unskip more editing tests.
- 5:31 PM Changeset in webkit [77443] by
-
- 4 edits in trunk/Source/JavaScriptCore
Bug 53650 - Add a BACKTRACE macro to Assertions.h
Reviewed by Sam Weinig.
Add a BACKTRACE macro to Assertions.h, which will print a backtrace on
debug Mac builds, make CRASH (and thus ASSERT) automatically call this.
- JavaScriptCore.exp:
- wtf/Assertions.cpp:
- wtf/Assertions.h:
- 5:29 PM Changeset in webkit [77442] by
-
- 2 edits in trunk/Source/WebCore
Build fix.
- WebCore.exp.in:
- 5:22 PM Changeset in webkit [77441] by
-
- 1 copy in releases/WebKitGTK/webkit-1.3.11
Add 1.3.11 WebKitGTK+ release
- 5:20 PM Changeset in webkit [77440] by
-
- 2 edits283 adds in trunk/LayoutTests
2011-02-02 Martin Robinson <mrobinson@igalia.com>
Begin importing missing editing directory test results.
- platform/gtk/Skipped: Unskip tests with results and classify failures.
- 5:17 PM Changeset in webkit [77439] by
-
- 5 edits in trunk
2011-02-02 Michael Saboff <msaboff@apple.com>
Reviewed by Gavin Barraclough.
Improper backtrack of nested non-capturing greedy paren to prior paren
https://bugs.webkit.org/show_bug.cgi?id=53261
A paren that follows a non-capturing greedy paren nested within a
non-capturing fixed paren was back tracking to the last paren
processed instead of the immediately prior paren.
Refactored default backtracking of parens to prior paren to work for
both nested (within) and immediately prior (after) parens.
- yarr/YarrJIT.cpp: (JSC::Yarr::YarrGenerator::GenerationState::addParenthesesTail): (JSC::Yarr::YarrGenerator::TermGenerationState::TermGenerationState): (JSC::Yarr::YarrGenerator::TermGenerationState::setJumpListToPriorParen): (JSC::Yarr::YarrGenerator::TermGenerationState::getJumpListToPriorParen): (JSC::Yarr::YarrGenerator::ParenthesesTail::ParenthesesTail): (JSC::Yarr::YarrGenerator::ParenthesesTail::generateCode): (JSC::Yarr::YarrGenerator::generateParenthesesDisjunction): (JSC::Yarr::YarrGenerator::generateParenthesesSingle): (JSC::Yarr::YarrGenerator::generateDisjunction):
2011-02-02 Michael Saboff <msaboff@apple.com>
Reviewed by Gavin Barraclough.
Improper backtrack of nested non-capturing greedy paren to prior paren
https://bugs.webkit.org/show_bug.cgi?id=53261
New tests to validate change.
- fast/regex/parentheses-expected.txt:
- fast/regex/script-tests/parentheses.js:
- 5:14 PM Changeset in webkit [77438] by
-
- 2 edits in trunk/Source/WebCore
2011-02-02 Patrick Gansterer <Patrick Gansterer>
Unreviewed WinCE build fix for r77397.
- page/wince/FrameWinCE.cpp: (WebCore::computePageRectsForFrame):
- 5:04 PM Changeset in webkit [77437] by
-
- 6 edits in trunk/Source
2011-02-02 Patrick Gansterer <Patrick Gansterer>
Unreviewed WinCE build fix for r77398.
- platform/graphics/wince/PlatformPathWinCE.cpp: (WebCore::containsPoint): (WebCore::inflateRectToContainPoint): (WebCore::PlatformPath::addRect):
- platform/graphics/wince/SharedBitmap.cpp: (WebCore::SharedBitmap::drawPattern):
- rendering/RenderThemeWinCE.cpp: (WebCore::RenderThemeWinCE::paintMenuListButton): (WebCore::RenderThemeWinCE::paintSearchFieldCancelButton): (WebCore::RenderThemeWinCE::paintSliderTrack): (WebCore::RenderThemeWinCE::paintMediaMuteButton): (WebCore::RenderThemeWinCE::paintMediaPlayButton): (WebCore::RenderThemeWinCE::paintMediaSeekBackButton): (WebCore::RenderThemeWinCE::paintMediaSeekForwardButton):
2011-02-02 Patrick Gansterer <Patrick Gansterer>
Unreviewed WinCE build fix for r77398.
- WebView.cpp: (WebView::paint):
- 4:55 PM Changeset in webkit [77436] by
-
- 2 edits in trunk/PerformanceTests/Parser
2011-02-02 Eric Seidel <eric@webkit.org>
Unreviewed. Just fixing an exception seen in Firefox.
HTML5 TreeBuilder regressed a Peacekeeper DOM test by 40%
https://bugs.webkit.org/show_bug.cgi?id=48719
Make the benchmarks work in Firefox/Opera.
- resources/runner.js: (log):
- 4:55 PM Changeset in webkit [77435] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-02-02 Evan Martin <evan@chromium.org>
Unreviewed, DEPS change.
- DEPS: update to pick up newer Skia.
- 4:52 PM Changeset in webkit [77434] by
-
- 6 edits in trunk
2011-02-02 Dirk Pranke <dpranke@chromium.org>
Reviewed by Mihai Parparita.
new-run-webkit-tests: hardcode the directories to scan for tests
for GPU bots instead of SKIPping them. See bug 53562 for some
context, but we will now hard-code the list of directories to
use by default instead of skipping over directories in the
expectations file. We do this so that we will be able to merge
the expectations files without getting conflicting SKIP
directives. Note that this change will reduce the # of tests
being run on the Mac GPU bots, because we're accidentally
including some today.
- platform/chromium-gpu/test_expectations.txt:
2011-02-02 Dirk Pranke <dpranke@chromium.org>
Reviewed by Mihai Parparita.
new-run-webkit-tests: hardcode the directories to scan for tests
for GPU bots instead of SKIPping them. See bug 53562 for some
context, but we will now hard-code the list of directories to
use by default instead of skipping over directories in the
expectations file. We do this so that we will be able to merge
the expectations files without getting conflicting SKIP
directives. Note that this change will reduce the # of tests
being run on the Mac GPU bots, because we're accidentally
including some today.
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
- Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
- 4:52 PM Changeset in webkit [77433] by
-
- 5 edits in trunk
[V8] Accessing DataView with index of -1 returns 0, doesn't throw
https://bugs.webkit.org/show_bug.cgi?id=53559
Reviewed by Kenneth Russell.
Source/WebCore:
Added test cases to cover this in fast/canvas/webgl/data-view-test.html.
- html/canvas/DataView.h:
(WebCore::DataView::beyondRange):
LayoutTests:
- fast/canvas/webgl/data-view-test-expected.txt:
- fast/canvas/webgl/data-view-test.html:
- 4:44 PM Changeset in webkit [77432] by
-
- 23 edits6 adds in trunk
Add ChromeClient function to paint custom overhang areas.
https://bugs.webkit.org/show_bug.cgi?id=53639
Reviewed by Beth Dakin.
Source/WebCore:
- page/Chrome.cpp:
(WebCore::ChromeClient::paintCustomOverhangArea):
- page/ChromeClient.h:
Add ChromeClient function.
- page/FrameView.cpp:
(WebCore::FrameView::paintOverhangAreas):
- page/FrameView.h:
Call out the the ChromeClient, call ScrollView base implementation
if the ChromeClient returns false.
- platform/ScrollView.cpp:
(WebCore::ScrollView::paintOverhangAreas):
- platform/ScrollView.h:
Add dirty rect for use when painting overhang areas.
Source/WebKit2:
- Shared/API/c/WKBase.h:
- Shared/API/c/WKGraphicsContext.cpp: Added.
(WKGraphicsContextGetTypeID):
- Shared/API/c/WKGraphicsContext.h: Added.
- Shared/API/c/WKSharedAPICast.h:
- Shared/API/c/cg/WKGraphicsContextCG.cpp: Added.
(WKGraphicsContextGetCGContext):
- Shared/API/c/cg/WKGraphicsContextCG.h: Added.
- Shared/APIObject.h:
- Shared/WebGraphicsContext.cpp: Added.
(WebKit::WebGraphicsContext::WebGraphicsContext):
- Shared/WebGraphicsContext.h: Added.
(WebKit::WebGraphicsContext::create):
(WebKit::WebGraphicsContext::platformContext):
(WebKit::WebGraphicsContext::type):
Add WebGraphicsContext API type.
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
(WebKit::InjectedBundlePageUIClient::pageDidScroll):
(WebKit::InjectedBundlePageUIClient::shouldPaintCustomOverhangArea):
(WebKit::InjectedBundlePageUIClient::paintCustomOverhangArea):
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::paintCustomOverhangArea):
- WebProcess/WebCoreSupport/WebChromeClient.h:
Pipe paintCustomOverhangArea to the InjectedBundlePageUIClient.
- UIProcess/API/C/WebKit2.h:
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
- win/WebKit2Generated.make:
Add new files.
Tools:
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
Stub out new callback.
- 4:33 PM Changeset in webkit [77431] by
-
- 3 edits in trunk/Tools
2011-02-02 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
new-run-webkit-tests: support chromium code paths in mock_drt
- Scripts/webkitpy/layout_tests/port/mock_drt.py:
- Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
- 4:16 PM Changeset in webkit [77430] by
-
- 2 edits in trunk/Source/WebKit2
2011-02-02 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Work towards making the layer tree host be in charge of all painting
https://bugs.webkit.org/show_bug.cgi?id=53636
Make sure that DrawingAreaImpl::display is never called when in accelerated compositing mode,
since the layer tree host is supposed to handle all drawing in that case.
- WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::scroll): (WebKit::DrawingAreaImpl::setRootCompositingLayer): (WebKit::DrawingAreaImpl::setSize): (WebKit::DrawingAreaImpl::didUpdate):
- 3:58 PM Changeset in webkit [77429] by
-
- 7 edits in trunk/Source/WebCore
Not reviewed, build fix.
Fix compile after r77427.
https://bugs.webkit.org/show_bug.cgi?id=53455
- platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::internalHandleCurrentImage):
- platform/image-decoders/ImageDecoder.cpp:
(WebCore::ImageFrame::operator=):
- platform/image-decoders/bmp/BMPImageReader.cpp:
(WebCore::BMPImageReader::decodeBMP):
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::JPEGImageDecoder::outputScanlines):
- platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::PNGImageDecoder::rowAvailable):
- platform/image-decoders/webp/WEBPImageDecoder.cpp:
(WebCore::WEBPImageDecoder::decode):
- 3:39 PM Changeset in webkit [77428] by
-
- 2 edits in trunk/Source/WebKit2
Fix the 32-bit build.
- WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::computeFakeWindowBoundsRect):
- 3:34 PM Changeset in webkit [77427] by
-
- 10 edits in trunk/Source/WebCore
2011-02-02 Peter Kasting <pkasting@google.com>
Reviewed by David Levin.
Clean up ImageDecoder's comments (remove/trim/clarify).
https://bugs.webkit.org/show_bug.cgi?id=53455
This also renames or eliminates a couple of functions for clarity, and
switches a couple erroneous strncmp() calls to memcmp().
- platform/image-decoders/ImageDecoder.cpp: (WebCore::ImageDecoder::create): (WebCore::ImageFrame::clearPixelData): (WebCore::ImageFrame::zeroFillPixelData): (WebCore::ImageFrame::setSize):
- platform/image-decoders/ImageDecoder.h: (WebCore::ImageFrame::originalFrameRect): (WebCore::ImageFrame::setOriginalFrameRect): (WebCore::ImageDecoder::ImageDecoder): (WebCore::ImageDecoder::~ImageDecoder): (WebCore::ImageDecoder::isSizeAvailable): (WebCore::ImageDecoder::size): (WebCore::ImageDecoder::setIgnoreGammaAndColorProfile): (WebCore::ImageDecoder::clearFrameBufferCache): (WebCore::ImageDecoder::isOverSize):
- platform/image-decoders/bmp/BMPImageReader.cpp: (WebCore::BMPImageReader::processNonRLEData):
- platform/image-decoders/cg/ImageDecoderCG.cpp: (WebCore::ImageFrame::setSize):
- platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::clearFrameBufferCache): (WebCore::GIFImageDecoder::frameComplete): (WebCore::GIFImageDecoder::initFrameBuffer):
- platform/image-decoders/jpeg/JPEGImageDecoder.h:
- platform/image-decoders/qt/ImageFrameQt.cpp: (WebCore::ImageFrame::operator=): (WebCore::ImageFrame::clearPixelData): (WebCore::ImageFrame::zeroFillPixelData): (WebCore::ImageFrame::setSize):
- platform/image-decoders/skia/ImageDecoderSkia.cpp: (WebCore::ImageFrame::operator=): (WebCore::ImageFrame::clearPixelData): (WebCore::ImageFrame::zeroFillPixelData): (WebCore::ImageFrame::setSize):
- platform/image-decoders/webp/WEBPImageDecoder.h:
- 3:32 PM Changeset in webkit [77426] by
-
- 1 edit1 add in trunk/PerformanceTests/Parser
2011-01-27 Eric Seidel <eric@webkit.org>
Reviewed by Darin Adler.
HTML5 TreeBuilder regressed a Peacekeeper DOM test by 40%
https://bugs.webkit.org/show_bug.cgi?id=48719
It's unclear exactly what the Peacekeeper benchmark is testing,
because I haven't found a way to run it myself.
However, I constructed a benchmark which shows at least one possible slow point.
The HTML5 spec talks about creating a new document for every time we use
the fragment parsing algorithm. Document() it turns out, it a huge bloated
mess, and the constructor and destructor do a huge amount of work.
- benchmarks/parser/tiny-innerHTML.html: Added.
- 3:08 PM Changeset in webkit [77425] by
-
- 8 edits in trunk/Source/WebCore
2011-02-02 Vangelis Kokkevis <vangelis@chromium.org>
[chromium] Adding support for reflections to the accelerated
compositing path.
https://bugs.webkit.org/show_bug.cgi?id=53179
All layout tests in compositing/reflections generate correct
results with the exception of:
- nested-reflection-anchor-point.html : There appears to be some issue with the layer transform math that I haven't been able to track down yet.
- reflection-opacity.html : The current implementation applies opacity before doing the reflection which makes this test produce incorrect results. This will affect reflected layers with opacity that overlap their original layer. FIXME comment added in the code.
Tests: Covered by existing layout tests in compositing/reflections.
Please see above for exceptions.
- platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::setReplicatedByLayer): (WebCore::GraphicsLayerChromium::updateAnchorPoint):
- platform/graphics/chromium/GraphicsLayerChromium.h:
- platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::LayerChromium):
- platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::setReplicaLayer): (WebCore::LayerChromium::replicaLayer):
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updateLayersRecursive): (WebCore::LayerRendererChromium::drawLayer):
- platform/graphics/chromium/RenderSurfaceChromium.cpp: (WebCore::RenderSurfaceChromium::drawableContentRect): (WebCore::RenderSurfaceChromium::drawSurface): (WebCore::RenderSurfaceChromium::draw):
- platform/graphics/chromium/RenderSurfaceChromium.h: (WebCore::RenderSurfaceChromium::drawTransform):
- 2:45 PM Changeset in webkit [77424] by
-
- 2 edits in trunk/Source/WebCore
2011-02-02 Xiyuan Xia <xiyuan@chromium.org>
Reviewed by Tony Chang.
[Chromium] Select popup with padding has white strip on right
https://bugs.webkit.org/show_bug.cgi?id=53602
No new tests as this change restores old behavior.
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::layout):
- 2:45 PM Changeset in webkit [77423] by
-
- 2 edits in trunk/Source/WebKit2
Make sure that we don't try to call display() when in accelerated compositing mode
https://bugs.webkit.org/show_bug.cgi?id=53629
Reviewed by Sam Weinig.
When in accelerated compositing mode, the layer tree host should handle all painting, so make sure that display() is never called.
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::setNeedsDisplay):
(WebKit::DrawingAreaImpl::setRootCompositingLayer):
(WebKit::DrawingAreaImpl::display):
- 2:43 PM Changeset in webkit [77422] by
-
- 2 edits in trunk/Source/WebCore
Fix for <rdar://problem/8950343> CrashTracer: [USER]
1 crash in WebProcess at com.apple.WebCore:
WebCore::ScrollbarThemeMac::unregisterScrollbar + 22
Reviewed by Mark Rowe.
It is possible for a Scrollbar's ScrollableArea to be null,
so we must null check.
- platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::unregisterScrollbar):
- 2:39 PM Changeset in webkit [77421] by
-
- 5 edits in trunk
2011-02-02 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
bufferData and bufferSubData should generate INVALID_VALUE with negative input
https://bugs.webkit.org/show_bug.cgi?id=53626
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::bufferData): (WebCore::WebGLRenderingContext::bufferSubData):
2011-02-02 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
bufferData and bufferSubData should generate INVALID_VALUE with negative input
https://bugs.webkit.org/show_bug.cgi?id=53626
- fast/canvas/webgl/buffer-data-array-buffer-expected.txt:
- fast/canvas/webgl/buffer-data-array-buffer.html:
- 2:34 PM Changeset in webkit [77420] by
-
- 4 edits in trunk/Source
Add DerivedSources.make to some Visual Studio projects
https://bugs.webkit.org/show_bug.cgi?id=53607
Patch by Jeff Miller <jeffm@apple.com> on 2011-02-02
Reviewed by Darin Adler and Steve Falkenburg.
Source/JavaScriptCore:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj: Add DerivedSources.make.
Source/WebCore:
- WebCore.vcproj/WebCoreGenerated.vcproj: Add DerivedSources.make.
- 2:33 PM Changeset in webkit [77419] by
-
- 4 edits in trunk/Source/WebKit2
Assert WebBackForwardList's current index is valid to help catch errors
Hopefully this will help catch a crash I saw once but haven't yet been able to reproduce.
Fixes <http://webkit.org/b/53622>.
Reviewed by Brady Eidson.
- UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::WebBackForwardList):
(WebKit::WebBackForwardList::addItem):
(WebKit::WebBackForwardList::goToItem):
(WebKit::WebBackForwardList::currentItem):
(WebKit::WebBackForwardList::backItem):
(WebKit::WebBackForwardList::forwardItem):
(WebKit::WebBackForwardList::itemAtIndex):
(WebKit::WebBackForwardList::backListCount):
(WebKit::WebBackForwardList::forwardListCount):
(WebKit::WebBackForwardList::backListAsImmutableArrayWithLimit):
(WebKit::WebBackForwardList::forwardListAsImmutableArrayWithLimit):
(WebKit::WebBackForwardList::clear):
- UIProcess/cf/WebBackForwardListCF.cpp:
(WebKit::WebBackForwardList::createCFDictionaryRepresentation):
(WebKit::WebBackForwardList::restoreFromCFDictionaryRepresentation):
Assert that m_current is valid.
- UIProcess/WebBackForwardList.h: Moved the NoCurrentItemIndex to a static data member so
that it can be used from WebBackForwardListCF.cpp.
- 2:25 PM Changeset in webkit [77418] by
-
- 6 edits2 adds in trunk
2011-02-02 Cris Neckar <cdn@chromium.org>
Reviewed by James Robinson.
Tests for crash when a domwindow is removed within a device orientation event.
https://bugs.webkit.org/show_bug.cgi?id=53623
- fast/events/device-orientation-crash-expected.txt: Added.
- fast/events/device-orientation-crash.html: Added.
2011-02-02 Cris Neckar <cdn@chromium.org>
Reviewed by James Robinson.
Refcount domwindows when dispatching device orientation events.
https://bugs.webkit.org/show_bug.cgi?id=53623
Test: fast/events/device-orientation-crash.html
- dom/DeviceMotionController.cpp: (WebCore::DeviceMotionController::timerFired): (WebCore::DeviceMotionController::didChangeDeviceMotion):
- dom/DeviceMotionController.h:
- dom/DeviceOrientationController.cpp: (WebCore::DeviceOrientationController::timerFired): (WebCore::DeviceOrientationController::didChangeDeviceOrientation):
- dom/DeviceOrientationController.h:
- 2:13 PM Changeset in webkit [77417] by
-
- 7 edits in trunk
2011-02-02 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
A deleted object should never been bound again
https://bugs.webkit.org/show_bug.cgi?id=53604
- fast/canvas/webgl/object-deletion-behaviour-expected.txt:
- fast/canvas/webgl/object-deletion-behaviour.html: Add test cases for object binding and deletion.
2011-02-02 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
A deleted object should never been bound again
https://bugs.webkit.org/show_bug.cgi?id=53604
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::checkObjectToBeBound): Helper function to bind* and useProgram. (WebCore::WebGLRenderingContext::bindBuffer): Use checkObjectToBeBound. (WebCore::WebGLRenderingContext::bindFramebuffer): Ditto. (WebCore::WebGLRenderingContext::bindRenderbuffer): Ditto. (WebCore::WebGLRenderingContext::bindTexture): Ditto, also check the target matching. (WebCore::WebGLRenderingContext::deleteObject): Helper funtion to delete*. (WebCore::WebGLRenderingContext::deleteBuffer): Use deleteObject. (WebCore::WebGLRenderingContext::deleteFramebuffer): Ditto. (WebCore::WebGLRenderingContext::deleteProgram): Ditto. (WebCore::WebGLRenderingContext::deleteRenderbuffer): Ditto. (WebCore::WebGLRenderingContext::deleteShader): Ditto. (WebCore::WebGLRenderingContext::deleteTexture): Ditto. (WebCore::WebGLRenderingContext::useProgram): Use checkObjectToBeBound.
- html/canvas/WebGLRenderingContext.h:
- html/canvas/WebGLTexture.h: (WebCore::WebGLTexture::getTarget): Accessor to cached target.
- 2:06 PM Changeset in webkit [77416] by
-
- 2 edits in trunk/Source/WebCore
2011-02-02 Alejandro G. Castro <alex@igalia.com>
Unreviewed Efl buildfix after r77399.
- CMakeListsEfl.txt:
- 1:59 PM Changeset in webkit [77415] by
-
- 3 edits in trunk/Tools
2011-02-02 Adam Klein <adamk@chromium.org>
Reviewed by Tony Chang.
Update new-run-webkit-tests --chromium to put output under Source/...
https://bugs.webkit.org/show_bug.cgi?id=53612
- BuildSlaveSupport/test-result-archive:
- Scripts/webkitpy/layout_tests/port/chromium.py:
- 1:49 PM Changeset in webkit [77414] by
-
- 4 edits in trunk
2011-02-02 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
Update the NEWS file in preparation for the 1.3.11 release.
- NEWS: Update the NEWS.
2011-02-02 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
Bump the WebKitGTK+ versions in preparation for development release.
- configure.ac: Bump the library, libtool and user agent version.
- 1:49 PM Changeset in webkit [77413] by
-
- 3 edits in trunk/Source/WebKit2
2011-02-02 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
The drawing area proxy should keep track of the accelerated compositing state
https://bugs.webkit.org/show_bug.cgi?id=53624
- UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl): Initialize m_isInAcceleratedCompositingMode to false.
(WebKit::DrawingAreaProxyImpl::paint):
Don't try to paint if we're in accelerated compositing mode.
(WebKit::DrawingAreaProxyImpl::didSetSize):
Bail if we're in accelerated compositing mode.
(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
Set m_isInAcceleratedCompositingMode to true, null out the backing store.
(WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode):
Set m_isInAcceleratedCompositingMode back to false.
(WebKit::DrawingAreaProxyImpl::incorporateUpdate):
Assert that we're not in accelerated compositing mode.
- UIProcess/DrawingAreaProxyImpl.h:
- 1:37 PM Changeset in webkit [77412] by
-
- 31 edits in trunk
2011-02-02 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
Rename Typed Array subset to subarray
https://bugs.webkit.org/show_bug.cgi?id=53618
- fast/canvas/webgl/array-setters.html:
- fast/canvas/webgl/array-unit-tests-expected.txt:
- fast/canvas/webgl/array-unit-tests.html:
- fast/canvas/webgl/draw-elements-out-of-bounds-expected.txt:
- fast/canvas/webgl/draw-elements-out-of-bounds.html:
- fast/canvas/webgl/webgl-array-invalid-ranges-expected.txt:
- fast/canvas/webgl/webgl-array-invalid-ranges.html:
2011-02-02 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
Rename Typed Array subset to subarray
https://bugs.webkit.org/show_bug.cgi?id=53618
- html/canvas/Float32Array.cpp: (WebCore::Float32Array::subarray):
- html/canvas/Float32Array.h:
- html/canvas/Float32Array.idl:
- html/canvas/Int16Array.cpp: (WebCore::Int16Array::subarray):
- html/canvas/Int16Array.h:
- html/canvas/Int16Array.idl:
- html/canvas/Int32Array.cpp: (WebCore::Int32Array::subarray):
- html/canvas/Int32Array.h:
- html/canvas/Int32Array.idl:
- html/canvas/Int8Array.cpp: (WebCore::Int8Array::subarray):
- html/canvas/Int8Array.h:
- html/canvas/Int8Array.idl:
- html/canvas/TypedArrayBase.h: (WebCore::TypedArrayBase::subarrayImpl):
- html/canvas/Uint16Array.cpp: (WebCore::Uint16Array::subarray):
- html/canvas/Uint16Array.h:
- html/canvas/Uint16Array.idl:
- html/canvas/Uint32Array.cpp: (WebCore::Uint32Array::subarray):
- html/canvas/Uint32Array.h:
- html/canvas/Uint32Array.idl:
- html/canvas/Uint8Array.cpp: (WebCore::Uint8Array::subarray):
- html/canvas/Uint8Array.h:
- html/canvas/Uint8Array.idl:
- 1:30 PM Changeset in webkit [77411] by
-
- 8 edits2 adds in trunk/Source/WebCore
2011-02-02 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add an empty file for Content Security Policy
https://bugs.webkit.org/show_bug.cgi?id=53573
Posting this as a separate patch because editing the build files is so
painful.
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- 1:23 PM Changeset in webkit [77410] by
-
- 8 edits in trunk/Tools
2011-01-28 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
[chromium] remove --use-test-shell from NRWT
https://bugs.webkit.org/show_bug.cgi?id=53346
I've already started removing some of the bindings like eventSender so
this already doesn't work isn't useful. Also updated some comments to
refer to DRT instead of test_shell.
- Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/chromium_linux.py:
- Scripts/webkitpy/layout_tests/port/chromium_mac.py:
- Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
- Scripts/webkitpy/layout_tests/port/chromium_win.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- Scripts/webkitpy/layout_tests/test_types/text_diff.py:
- 1:19 PM Changeset in webkit [77409] by
-
- 2 edits in trunk/Source/WebKit2
Give the Web Process access to the Safari RSS preferences.
<rdar://problem/8916870> Sandbox violation related to RSS during initial
page load with WebKit2 (prevents RSS from working)
Reviewed by Darin Adler.
- WebProcess/com.apple.WebProcess.sb:
- 1:19 PM Changeset in webkit [77408] by
-
- 2 edits in trunk/Source/WebCore
2011-02-02 Dan Winship <danw@gnome.org>
Reviewed by Martin Robinson.
[GTK] remove old data: URI handler, fix the SoupRequest-based one
to pass tests
https://bugs.webkit.org/show_bug.cgi?id=50885
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::sendRequestCallback): Do content-type sniffing here for non-HTTP requests. (WebCore::startHTTPRequest): Rename to match WebKit style. (WebCore::ResourceHandle::start): Pass everything except HTTP to startNonHTTPRequest, letting the SoupRequester decide whether it's supported or not. (WebCore::startNonHTTPRequest): Remove some old pre-SoupRequester code that was a no-op for file: URIs, but would break some data: URIs.
- 1:18 PM Changeset in webkit [77407] by
-
- 2 edits in trunk/Source/WebCore
2011-02-02 Dimitri Glazkov <Dimitri Glazkov>
Update even more references to right() and bottom() in Chromium. Sheesh.
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::getFramebufferPixels): Replaced bottom/right with maxY/maxX.
- 1:12 PM Changeset in webkit [77406] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-02-02 Dimitri Glazkov <Dimitri Glazkov>
Update more references to right() and bottom() in Chromium.
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::doPixelReadbackToCanvas): Replaced bottom/right with maxY/maxX.
- 1:03 PM Changeset in webkit [77405] by
-
- 2 edits in trunk/Source/WebCore
2011-02-02 Alejandro G. Castro <alex@igalia.com>
Unreviewed Gtk3 buildfix after r77286.
https://bugs.webkit.org/show_bug.cgi?id=53520
Remove the physical terminology from IntRect and FloatRect.
- platform/gtk/RenderThemeGtk3.cpp: (WebCore::RenderThemeGtk::paintMenuList):
- 1:01 PM Changeset in webkit [77404] by
-
- 2 edits in trunk/Source/WebCore
Fix build.
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::pinnedInDirection):
- 12:59 PM Changeset in webkit [77403] by
-
- 3 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=53619
Reviewed by Dan Bernstein.
Floats should not use physical terminology for their rects. Replace left/top with x/y and right/bottom
with maxX/maxY. This matches IntRect.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addOverflowFromFloats):
(WebCore::RenderBlock::flipFloatForWritingMode):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::addIntrudingFloats):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::adjustForBorderFit):
- rendering/RenderBlock.h:
(WebCore::RenderBlock::FloatingObject::x):
(WebCore::RenderBlock::FloatingObject::maxX):
(WebCore::RenderBlock::FloatingObject::y):
(WebCore::RenderBlock::FloatingObject::maxY):
(WebCore::RenderBlock::FloatingObject::setX):
(WebCore::RenderBlock::FloatingObject::setY):
(WebCore::RenderBlock::logicalTopForFloat):
(WebCore::RenderBlock::logicalBottomForFloat):
(WebCore::RenderBlock::logicalLeftForFloat):
(WebCore::RenderBlock::logicalRightForFloat):
(WebCore::RenderBlock::setLogicalTopForFloat):
(WebCore::RenderBlock::setLogicalLeftForFloat):
(WebCore::RenderBlock::xPositionForFloatIncludingMargin):
(WebCore::RenderBlock::yPositionForFloatIncludingMargin):
- 12:54 PM Changeset in webkit [77402] by
-
- 5 edits in trunk/Source
2011-02-02 Dimitri Glazkov <Dimitri Glazkov>
Update more references to right() and bottom() in Chromium Win.
- platform/graphics/chromium/TransparencyWin.cpp: (WebCore::TransparencyWin::compositeOpaqueComposite): Replaced bottom/right with maxY/maxX. (WebCore::TransparencyWin::compositeTextComposite): Ditto.
- rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::paintMenuList): Ditto.
2011-02-02 Dimitri Glazkov <Dimitri Glazkov>
Update more references to right() and bottom() in Chromium Win.
- tests/TransparencyWinTest.cpp: (WebCore::TEST): Replaced bottom/right with maxY/maxX.
- 12:33 PM Changeset in webkit [77401] by
-
- 3 edits in trunk/Source/WebCore
Encode/decode FormData and FormDataElement objects consistently
Fixes <http://webkit.org/b/53615> <rdar://problem/8943346> WebKit2: Restoring session state
that contains form data fails (asserts in Debug build)
To prevent this from interfering with WebKit2 testing, it's useful to get this into a build
now, even though we don't have an automated test for it yet. Writing a test is covered by
<http://webkit.org/b/53616>.
Reviewed by Darin Adler.
- history/HistoryItem.cpp: Bump the encoding version, since this patch changes how we encode
FormData objects.
- platform/network/FormData.cpp:
(WebCore::decode): Decode the type from the Decoder, rather than getting it from the
default-constructed FormDataElement. Failing to do this meant that all future uses of the
Decoder would be reading from an unexpected part of the buffer (i.e., the next decode would
start by reading the uint32_t that we forgot to decode here, and so on). We already had code
to correctly set the FormDataElement's type based on this decoded type later in the
function.
(WebCore::FormData::encodeForBackForward): Encode m_identifier as an int64_t, since that
matches its type and how we decode it.
- 12:25 PM Changeset in webkit [77400] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-02-02 Matthew Vosburgh <maf@chromium.org>
Reviewed by Kenneth Russell.
Some favicons not correctly decoded by Chromium/Mac
https://bugs.webkit.org/show_bug.cgi?id=53448
- src/WebImageCG.cpp: (WebKit::WebImage::fromData):
- 12:24 PM Changeset in webkit [77399] by
-
- 6 edits17 deletes in trunk/Source
2011-02-02 Dan Winship <danw@gnome.org>
Reviewed by Martin Robinson.
[GTK] drop soup cache stuff, which has been moved to libsoup
https://bugs.webkit.org/show_bug.cgi?id=50747
Use libsoup-based cache/requester API and remove the WebCore version
of this functionality. This has been pushed upstream fully.
No new tests because this should not change functionality.
- GNUmakefile.am: Update for removed files.
- platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal): Update type names, drop m_requester.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ensureSessionIsInitialized): Add a SoupRequester to the session. (WebCore::parseDataUrl): (WebCore::startHttp): Get the requester from the session rather than using m_requester. (WebCore::sendRequestCallback): (WebCore::ResourceHandle::platformSetDefersLoading): (WebCore::readCallback): (WebCore::startGio): Update type names.
- platform/network/soup/cache/soup-directory-input-stream.c: Removed.
- platform/network/soup/cache/soup-directory-input-stream.h: Removed.
- platform/network/soup/cache/soup-http-input-stream.c: Removed.
- platform/network/soup/cache/soup-http-input-stream.h: Removed.
- platform/network/soup/cache/soup-request-data.c: Removed.
- platform/network/soup/cache/soup-request-data.h: Removed.
- platform/network/soup/cache/soup-request-file.c: Removed.
- platform/network/soup/cache/soup-request-file.h: Removed.
- platform/network/soup/cache/soup-request-http.c: Removed.
- platform/network/soup/cache/soup-request-http.h: Removed.
- platform/network/soup/cache/soup-request.c: Removed.
- platform/network/soup/cache/soup-request.h: Removed.
- platform/network/soup/cache/soup-requester.c: Removed.
- platform/network/soup/cache/soup-requester.h: Removed.
- platform/network/soup/cache/webkit/soup-cache-private.h: Removed.
- platform/network/soup/cache/webkit/soup-cache.c: Removed.
- platform/network/soup/cache/webkit/soup-cache.h: Removed.
2011-02-02 Dan Winship <danw@gnome.org>
Reviewed by Martin Robinson.
[GTK] drop soup cache stuff, which has been moved to libsoup
https://bugs.webkit.org/show_bug.cgi?id=50747
- GNUmakefile.am: Remove old cache files.
- 12:20 PM Changeset in webkit [77398] by
-
- 4 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=53520
Reviewed by Darin Adler.
Remove physical accessors from IntRect and FloatRect.
- page/FrameView.cpp:
(WebCore::FrameView::adjustPageHeightDeprecated):
- platform/graphics/FloatRect.h:
- platform/graphics/IntRect.h:
- 12:19 PM Changeset in webkit [77397] by
-
- 15 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=53614
Reviewed by Dan Bernstein.
Remove physical terminology from overflow. Replace with minX/maxX/minY/maxY.
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::addBoxShadowVisualOverflow):
(WebCore::InlineFlowBox::addTextBoxVisualOverflow):
- rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::minYLayoutOverflow):
(WebCore::InlineFlowBox::maxYLayoutOverflow):
(WebCore::InlineFlowBox::minXLayoutOverflow):
(WebCore::InlineFlowBox::maxXLayoutOverflow):
(WebCore::InlineFlowBox::logicalLeftLayoutOverflow):
(WebCore::InlineFlowBox::logicalRightLayoutOverflow):
(WebCore::InlineFlowBox::logicalTopLayoutOverflow):
(WebCore::InlineFlowBox::logicalBottomLayoutOverflow):
(WebCore::InlineFlowBox::minYVisualOverflow):
(WebCore::InlineFlowBox::maxYVisualOverflow):
(WebCore::InlineFlowBox::minXVisualOverflow):
(WebCore::InlineFlowBox::maxXVisualOverflow):
(WebCore::InlineFlowBox::logicalLeftVisualOverflow):
(WebCore::InlineFlowBox::logicalRightVisualOverflow):
(WebCore::InlineFlowBox::logicalminYVisualOverflow):
(WebCore::InlineFlowBox::logicalmaxYVisualOverflow):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustLinePositionForPagination):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::beforeSideVisualOverflowForLine):
(WebCore::RenderBlock::afterSideVisualOverflowForLine):
(WebCore::RenderBlock::beforeSideLayoutOverflowForLine):
(WebCore::RenderBlock::afterSideLayoutOverflowForLine):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::scrollWidth):
(WebCore::RenderBox::scrollHeight):
- rendering/RenderBox.h:
(WebCore::RenderBox::minYLayoutOverflow):
(WebCore::RenderBox::maxYLayoutOverflow):
(WebCore::RenderBox::minXLayoutOverflow):
(WebCore::RenderBox::maxXLayoutOverflow):
(WebCore::RenderBox::logicalLeftLayoutOverflow):
(WebCore::RenderBox::logicalRightLayoutOverflow):
(WebCore::RenderBox::minYVisualOverflow):
(WebCore::RenderBox::maxYVisualOverflow):
(WebCore::RenderBox::minXVisualOverflow):
(WebCore::RenderBox::maxXVisualOverflow):
(WebCore::RenderBox::logicalLeftVisualOverflow):
(WebCore::RenderBox::logicalRightVisualOverflow):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::linesVisualOverflowBoundingBox):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::ensureRootPlatformLayer):
- rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::anyLineIntersectsRect):
(WebCore::RenderLineBoxList::lineIntersectsDirtyRect):
(WebCore::RenderLineBoxList::paint):
(WebCore::RenderLineBoxList::hitTest):
- rendering/RenderMarquee.cpp:
(WebCore::RenderMarquee::computePosition):
- rendering/RenderOverflow.h:
(WebCore::RenderOverflow::RenderOverflow):
(WebCore::RenderOverflow::minYLayoutOverflow):
(WebCore::RenderOverflow::maxYLayoutOverflow):
(WebCore::RenderOverflow::minXLayoutOverflow):
(WebCore::RenderOverflow::maxXLayoutOverflow):
(WebCore::RenderOverflow::minYVisualOverflow):
(WebCore::RenderOverflow::maxYVisualOverflow):
(WebCore::RenderOverflow::minXVisualOverflow):
(WebCore::RenderOverflow::maxXVisualOverflow):
(WebCore::RenderOverflow::setminYVisualOverflow):
(WebCore::RenderOverflow::visualOverflowRect):
(WebCore::RenderOverflow::move):
(WebCore::RenderOverflow::addVisualOverflow):
(WebCore::RenderOverflow::setVisualOverflow):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::shouldPaint):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::layout):
(WebCore::RenderTable::paint):
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
- rendering/RenderTreeAsText.cpp:
(WebCore::writeLayers):
- rendering/RenderView.cpp:
(WebCore::RenderView::docTop):
- 12:07 PM Changeset in webkit [77396] by
-
- 2 edits in trunk/LayoutTests
2011-02-02 Dimitri Glazkov <Dimitri Glazkov>
Added GPU fails from bots.
- platform/chromium-gpu/test_expectations.txt: Added.
- 11:58 AM Changeset in webkit [77395] by
-
- 3 edits in trunk/Source/WebKit/chromium
2011-02-02 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Dave Hyatt.
Remove remaining references to right() and bottom() from Chromium build.
https://bugs.webkit.org/show_bug.cgi?id=53613
- src/DragScrollTimer.cpp: (WebKit::distanceToRect): Replaced right/bottom with maxX/maxY.
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::doPixelReadbackToCanvas): Ditto.
- 11:56 AM Changeset in webkit [77394] by
-
- 26 edits in trunk
2011-02-02 Steve Lacey <sjl@chromium.org>
Reviewed by Eric Carlson.
Implement basic media statistics on media elements.
https://bugs.webkit.org/show_bug.cgi?id=53322
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
2011-02-02 Steve Lacey <sjl@chromium.org>
Reviewed by Eric Carlson.
Implement basic media statistics on media elements.
https://bugs.webkit.org/show_bug.cgi?id=53322
- configure.ac:
2011-02-02 Steve Lacey <sjl@chromium.org>
Reviewed by Eric Carlson.
Implement basic media statistics on media elements.
https://bugs.webkit.org/show_bug.cgi?id=53322
- Scripts/build-webkit:
2011-02-02 Steve Lacey <sjl@chromium.org>
Reviewed by Eric Carlson.
Implement basic media statistics on media elements.
https://bugs.webkit.org/show_bug.cgi?id=53322
- Configurations/FeatureDefines.xcconfig:
2011-02-02 Steve Lacey <sjl@chromium.org>
Reviewed by Eric Carlson.
Implement basic media statistics on media elements.
https://bugs.webkit.org/show_bug.cgi?id=53322
- Configurations/FeatureDefines.xcconfig:
2011-02-02 Steve Lacey <sjl@chromium.org>
Reviewed by Eric Carlson.
Implement basic media statistics on media elements.
https://bugs.webkit.org/show_bug.cgi?id=53322
- Configurations/FeatureDefines.xcconfig:
- GNUmakefile.am:
- features.pri:
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::webkitAudioBytesDecoded): (WebCore::HTMLMediaElement::webkitVideoBytesDecoded):
- html/HTMLMediaElement.h:
- html/HTMLMediaElement.idl:
- html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::webkitDecodedFrames): (WebCore::HTMLVideoElement::webkitDroppedFrames):
- html/HTMLVideoElement.h:
- html/HTMLVideoElement.idl:
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::decodedFrames): (WebCore::MediaPlayer::droppedFrames): (WebCore::MediaPlayer::audioBytesDecoded): (WebCore::MediaPlayer::videoBytesDecoded):
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::decodedFrames): (WebCore::MediaPlayerPrivateInterface::droppedFrames): (WebCore::MediaPlayerPrivateInterface::audioBytesDecoded): (WebCore::MediaPlayerPrivateInterface::videoBytesDecoded):
2011-02-02 Steve Lacey <sjl@chromium.org>
Reviewed by Eric Carlson.
Implement basic media statistics on media elements.
https://bugs.webkit.org/show_bug.cgi?id=53322
- Configurations/FeatureDefines.xcconfig:
- 11:40 AM Changeset in webkit [77393] by
-
- 3 edits in trunk/Source/WebCore
2011-02-02 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by David Hyatt.
More conversion from right()/bottom() to maxX()/maxY().
- page/qt/FrameQt.cpp: (WebCore::Frame::dragImageForSelection):
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::roundToDevicePixels):
- 11:34 AM Changeset in webkit [77392] by
-
- 21 edits in trunk
[wx] Build fixes for wxWebKit.
- 11:21 AM Changeset in webkit [77391] by
-
- 15 edits1 copy1 add in trunk/Source/JavaScriptCore
2011-02-01 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
A little more Heap refactoring
https://bugs.webkit.org/show_bug.cgi?id=53577
SunSpider reports no change.
Split out MarkedBlock into its own file / class.
Did the following renames:
isCellMarked => isMarked
checkMarkCell => testAndSetMarked
markCell => setMarked
cellOffset => cellNumber
collectorBlock => blockFor
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- JavaScriptCore.gypi:
- JavaScriptCore.pro:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/Heap.cpp: (JSC::WeakGCHandlePool::update):
- runtime/Heap.h: (JSC::Heap::isMarked): (JSC::Heap::testAndSetMarked): (JSC::Heap::setMarked):
- runtime/JSArray.h: (JSC::MarkStack::markChildren): (JSC::MarkStack::drain):
- runtime/JSCell.h: (JSC::JSCell::MarkStack::internalAppend):
- runtime/MarkedBlock.cpp: Added.
- runtime/MarkedBlock.h: Added. (JSC::MarkedBlock::blockFor): (JSC::MarkedBlock::cellNumber): (JSC::MarkedBlock::isMarked): (JSC::MarkedBlock::testAndSetMarked): (JSC::MarkedBlock::setMarked): (JSC::MarkedBlock::isCellAligned): (JSC::MarkedBlock::isPossibleCell):
- runtime/MarkedSpace.h: (JSC::MarkedSpace::isMarked): (JSC::MarkedSpace::testAndSetMarked): (JSC::MarkedSpace::setMarked):
- runtime/SmallStrings.cpp: (JSC::isMarked):
- runtime/WeakGCMap.h: (JSC::WeakGCMap::isValid): (JSC::::get): (JSC::::take): (JSC::::set):
- 11:13 AM Changeset in webkit [77390] by
-
- 2 edits in trunk/Source/WebCore
More right()/bottom() to maxX()/maxY() conversion.
Reviewed by Darin Adler.
- page/chromium/FrameChromium.cpp:
(WebCore::Frame::nodeImage):
(WebCore::Frame::dragImageForSelection):
- 11:00 AM Changeset in webkit [77389] by
-
- 4 edits in trunk/Source
Fix windows clean build.
- DerivedSources.make:
../WebCore:
- DerivedSources.make:
- 10:56 AM Changeset in webkit [77388] by
-
- 2 edits1 add in trunk/LayoutTests
2011-02-02 Martin Robinson <mrobinson@igalia.com>
Unskip a test that just needs platform-specific results. Re-classify
two other failures with more pertinent information.
- platform/gtk/Skipped: Organize the skipped list a bit. Unskip a test. Remove obsolete comments.
- platform/gtk/editing/inserting/5994480-2-expected.txt: Added.
- 10:55 AM Changeset in webkit [77387] by
-
- 5 edits in trunk/Source/WebCore
2011-02-02 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Landing detailed heap snapshots, part 2.
Display progress while taking a snapshot, and hints while loading
and parsing. This is needed because taking detailed heap snapshots
takes time.
- English.lproj/localizedStrings.js:
- inspector/front-end/DetailedHeapshotView.js: (WebInspector.DetailedHeapshotProfileType.prototype.buttonClicked):
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype._reset): (WebInspector.ProfilesPanel.prototype._addProfileHeader): (WebInspector.ProfilesPanel.prototype.getProfiles): (WebInspector.ProfilesPanel.prototype.loadHeapSnapshot): (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.doParse): (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot): (WebInspector.ProfilesPanel.prototype.takeHeapSnapshot): (WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress):
- inspector/front-end/SidebarTreeElement.js: (WebInspector.SidebarTreeElement.prototype.refreshTitles):
- 10:51 AM Changeset in webkit [77386] by
-
- 7 edits in trunk/Source/WebKit2
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=53561
<rdar://problem/8900228> Stepping through print previews in WebKit2 mode steps in and out of
printing mode a lot
Disable NSView autodisplay, so that -[WKView drawRect:] isn't called (other than when
resizing the window), so that we don't have to switch modes all the time.
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::setAutodisplay):
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setAutodisplay):
- UIProcess/WebPageProxy.h: Pipe the call from WKPrintingView down to WKView.
- UIProcess/API/mac/WKPrintingView.mm: (-[WKPrintingView beginDocument]): Added. We don't want to autodisplay WKView while printing, because layout is changed to print at the time, and drawing to screen requires relayout.
(-[WKPrintingView endDocument]): When not printing, turn autodisplay back on. Also, call
-[super endDocument] for unknown but definitive good (oops!).
- 10:35 AM Changeset in webkit [77385] by
-
- 2 edits in trunk/Source/WebCore
More conversion from right()/bottom() to maxX()/maxY().
Reviewed by Darin Adler.
- platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::calculatePositionAndSize):
(WebCore::PopupMenuWin::paint):
- 10:32 AM Changeset in webkit [77384] by
-
- 20 edits in trunk/Source/WebCore
Removal of right()/bottom(). Replace with maxX() and maxY(). Still converting. Haven't removed yet.
Reviewed by Darin Adler.
- platform/chromium/PopupMenuChromium.cpp:
(WebCore::PopupContainer::layoutAndCalculateWidgetRect):
(WebCore::PopupListBox::scrollToRevealRow):
(WebCore::PopupListBox::layout):
- platform/graphics/FloatRect.h:
- platform/graphics/IntRect.h:
- platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::getImageData):
(WebCore::putImageData):
- platform/graphics/chromium/GLES2Canvas.cpp:
(WebCore::GLES2Canvas::drawTexturedRect):
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::verticalScrollbarRect):
(WebCore::LayerRendererChromium::horizontalScrollbarRect):
(WebCore::LayerRendererChromium::setScissorToRect):
(WebCore::LayerRendererChromium::setDrawViewportRect):
- platform/graphics/chromium/LayerTilerChromium.cpp:
(WebCore::LayerTilerChromium::contentRectToTileIndices):
(WebCore::LayerTilerChromium::growLayerToContain):
- platform/graphics/gpu/TilingData.cpp:
(WebCore::TilingData::tileBoundsWithBorder):
(WebCore::TilingData::overlappedTileIndices):
- platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::getImageData):
(WebCore::putImageData):
- platform/graphics/skia/FloatRectSkia.cpp:
(WebCore::FloatRect::operator SkRect):
- platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::getImageData):
(WebCore::putImageData):
- platform/graphics/skia/IntRectSkia.cpp:
(WebCore::IntRect::operator SkIRect):
(WebCore::IntRect::operator SkRect):
- platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::beginLayerClippedToImage):
- platform/graphics/win/GraphicsContextWin.cpp:
(WebCore::GraphicsContextPlatformPrivate::clip):
- platform/graphics/win/IntRectWin.cpp:
(WebCore::IntRect::operator RECT):
- platform/graphics/win/UniscribeController.cpp:
(WebCore::UniscribeController::shapeAndPlaceItem):
- platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::roundRect):
(WebCore::mapRect):
(WebCore::TransparentLayerDC::TransparentLayerDC):
(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::drawEllipse):
(WebCore::GraphicsContext::strokeArc):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::strokeRect):
- platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::initFrameBuffer):
- platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::calculatePositionAndSize):
(WebCore::PopupMenuWin::paint):
- plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::invalidateRect):
- rendering/RenderThemeSafari.cpp:
(WebCore::RenderThemeSafari::paintMenuListButtonGradients):
(WebCore::RenderThemeSafari::paintMenuListButton):
(WebCore::RenderThemeSafari::paintSliderTrack):
- rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::paintInnerSpinButton):
(WebCore::RenderThemeWin::paintMenuListButton):
- 10:30 AM Changeset in webkit [77383] by
-
- 6 edits2 adds in trunk/Source/WebKit/chromium
2011-02-01 Darin Fisher <darin@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Avoid #ifdefs in code that constructs a GraphicsContext by
adding a helper class.
https://bugs.webkit.org/show_bug.cgi?id=53575
- WebKit.gyp:
- src/WebFontImpl.cpp: (WebKit::WebFontImpl::drawText):
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::printPage): (WebKit::WebFrameImpl::paint):
- src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::paint):
- src/WebScrollbarImpl.cpp: (WebKit::WebScrollbarImpl::paint):
- src/painting: Added.
- src/painting/GraphicsContextBuilder.h: Added. (WebKit::GraphicsContextBuilder::GraphicsContextBuilder): (WebKit::GraphicsContextBuilder::context):
- 10:30 AM Changeset in webkit [77382] by
-
- 8 edits in trunk/Source/WebKit
Removal of right()/bottom(), converting to maxX()/maxY().
Reviewed by Darin Adler.
../WebKit/gtk:
- webkit/webkitwebview.cpp:
(webkit_web_view_popup_menu_handler):
../WebKit/win:
- DOMHTMLClasses.cpp:
(DOMHTMLInputElement::rectOnScreen):
- WebCoreSupport/EmbeddedWidget.cpp:
(EmbeddedWidget::frameRectsChanged):
- WebFrame.cpp:
(WebFrame::computePageRects):
- WebScrollBar.cpp:
(WebScrollBar::frameRect):
- WebView.cpp:
(WebView::addToDirtyRegion):
(WebView::visibleContentRect):
(WebView::prepareCandidateWindow):
- 10:29 AM Changeset in webkit [77381] by
-
- 4 edits in trunk/Source/WebKit2
Conversion of right()/bottom() to maxX()/maxY() as part of the removal of those accessors.
Reviewed by Darin Adler.
- UIProcess/win/WebPopupMenuProxyWin.cpp:
(WebKit::WebPopupMenuProxyWin::calculatePositionAndSize):
- UIProcess/win/WebView.cpp:
(WebKit::WebView::prepareCandidateWindow):
- WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
(WebKit::NetscapePlugin::platformGeometryDidChange):
- 10:06 AM Changeset in webkit [77380] by
-
- 2 edits in trunk/Source/WebKit/gtk/po
2011-02-02 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] po files path update after the code moved to Source
https://bugs.webkit.org/show_bug.cgi?id=53599
- POTFILES: Add Source to the path of the files.
- 10:05 AM Changeset in webkit [77379] by
-
- 2 edits3 adds in trunk
2011-02-01 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: add test for OPTIONS requests caused by CORS preflight checking to appear in Network panel
https://bugs.webkit.org/show_bug.cgi?id=53501
- http/tests/inspector/network-preflight-options-expected.txt: Added.
- http/tests/inspector/network-preflight-options.html: Added.
- http/tests/inspector/resources/cors-target.php: Added.
- 9:59 AM Changeset in webkit [77378] by
-
- 2 edits in trunk/Source/WebKit2
2011-02-01 Darin Adler <Darin Adler>
Reviewed by Anders Carlsson.
Overflow in WebKit2 argument decoder buffer checking
https://bugs.webkit.org/show_bug.cgi?id=53536
- Platform/CoreIPC/ArgumentDecoder.cpp: (CoreIPC::roundUpToAlignment): Tweak code a bit for clarity and to replace C casts with C++ casts. (CoreIPC::ArgumentDecoder::alignBufferPosition): Rearrange buffer calculation so we don't do any math with the passed-in size, because that could overflow. (CoreIPC::ArgumentDecoder::bufferIsLargeEnoughToContain): Ditto.
- 9:00 AM Changeset in webkit [77377] by
-
- 2 edits in trunk/LayoutTests
2011-02-02 Martin Robinson <mrobinson@igalia.com>
Skip another test that uses modal dialogs.
- platform/gtk/Skipped: Skip modal dialog test and update bug in the skipped list.
- 7:00 AM Changeset in webkit [77376] by
-
- 3 edits in trunk/Source/WebCore
Use Vector instead of a linked list for rules in CSSStyleSelector
https://bugs.webkit.org/show_bug.cgi?id=53581
Reviewed by Maciej Stachowiak.
- eliminate CSSRuleDataList, replace with Vector<RuleData>
- rename CSSRuleData -> RuleData and CSSRuleSet -> RuleSet (these are selector internal classes, CSS prefix is better reserved for public ones).
- constify a bit
- shrink the vectors to fit after collecting the rules
- css/CSSStyleSelector.cpp:
(WebCore::RuleData::RuleData):
(WebCore::RuleData::position):
(WebCore::RuleData::rule):
(WebCore::RuleData::selector):
(WebCore::RuleSet::disableAutoShrinkToFit):
(WebCore::RuleSet::getIDRules):
(WebCore::RuleSet::getClassRules):
(WebCore::RuleSet::getTagRules):
(WebCore::RuleSet::getPseudoRules):
(WebCore::RuleSet::getUniversalRules):
(WebCore::RuleSet::getPageRules):
(WebCore::collectSiblingRulesInDefaultStyle):
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::loadFullDefaultStyle):
(WebCore::loadSimpleDefaultStyle):
(WebCore::loadViewSourceStyle):
(WebCore::CSSStyleSelector::matchRules):
(WebCore::CSSStyleSelector::matchRulesForList):
(WebCore::operator >):
(WebCore::operator <=):
(WebCore::CSSStyleSelector::sortMatchedRules):
(WebCore::CSSStyleSelector::matchUARules):
(WebCore::RuleSet::RuleSet):
(WebCore::RuleSet::~RuleSet):
(WebCore::RuleSet::addToRuleSet):
(WebCore::RuleSet::addRule):
(WebCore::RuleSet::addPageRule):
(WebCore::RuleSet::addRulesFromSheet):
(WebCore::RuleSet::addStyleRule):
(WebCore::collectIdsAndSiblingRulesFromList):
(WebCore::RuleSet::collectIdsAndSiblingRules):
(WebCore::shrinkMapVectorsToFit):
(WebCore::RuleSet::shrinkToFit):
(WebCore::CSSStyleSelector::matchPageRules):
(WebCore::CSSStyleSelector::matchPageRulesForList):
- css/CSSStyleSelector.h:
(WebCore::CSSStyleSelector::addMatchedRule):
- 6:08 AM Changeset in webkit [77375] by
-
- 4 edits in trunk/Source/WebCore
2011-02-02 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: Use DIVs instead of TABLE in TextViewer
https://bugs.webkit.org/show_bug.cgi?id=53299
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._createTextViewer): (WebInspector.SourceFrame.prototype._mouseDown):
- inspector/front-end/TextViewer.js: (WebInspector.TextViewer): (WebInspector.TextViewer.prototype.set mimeType): (WebInspector.TextViewer.prototype.revealLine): (WebInspector.TextViewer.prototype.addDecoration): (WebInspector.TextViewer.prototype.removeDecoration): (WebInspector.TextViewer.prototype.markAndRevealRange): (WebInspector.TextViewer.prototype.highlightLine): (WebInspector.TextViewer.prototype.clearLineHighlight): (WebInspector.TextViewer.prototype.freeCachedElements): (WebInspector.TextViewer.prototype._handleKeyDown): (WebInspector.TextViewer.prototype.editLine.finishEditing): (WebInspector.TextViewer.prototype.editLine): (WebInspector.TextViewer.prototype.beginUpdates): (WebInspector.TextViewer.prototype.endUpdates): (WebInspector.TextViewer.prototype.resize): (WebInspector.TextViewer.prototype._textChanged): (WebInspector.TextViewer.prototype._updatePanelOffsets): (WebInspector.TextViewer.prototype._syncScroll): (WebInspector.TextViewer.prototype._syncDecorationsForLine): (WebInspector.TextEditorChunkedPanel): (WebInspector.TextEditorChunkedPanel.prototype.set syncScrollListener): (WebInspector.TextEditorChunkedPanel.prototype.get textModel): (WebInspector.TextEditorChunkedPanel.prototype.addDecoration): (WebInspector.TextEditorChunkedPanel.prototype.removeDecoration): (WebInspector.TextEditorChunkedPanel.prototype.revealLine): (WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk): (WebInspector.TextEditorChunkedPanel.prototype.textChanged): (WebInspector.TextEditorChunkedPanel.prototype.beginUpdates): (WebInspector.TextEditorChunkedPanel.prototype.endUpdates): (WebInspector.TextEditorChunkedPanel.prototype.resize): (WebInspector.TextEditorChunkedPanel.prototype._scroll): (WebInspector.TextEditorChunkedPanel.prototype._scheduleRepaintAll): (WebInspector.TextEditorChunkedPanel.prototype._buildChunks): (WebInspector.TextEditorChunkedPanel.prototype._repaintAll): (WebInspector.TextEditorChunkedPanel.prototype._chunkNumberForLine): (WebInspector.TextEditorChunkedPanel.prototype._chunkForLine): (WebInspector.TextEditorGutterPanel): (WebInspector.TextEditorGutterPanel.prototype.freeCachedElements): (WebInspector.TextEditorGutterPanel.prototype._createNewChunk): (WebInspector.TextEditorGutterPanel.prototype._expandChunks): (WebInspector.TextEditorGutterChunk): (WebInspector.TextEditorGutterChunk.prototype.get expanded): (WebInspector.TextEditorGutterChunk.prototype.set expanded): (WebInspector.TextEditorGutterChunk.prototype.get height): (WebInspector.TextEditorGutterChunk.prototype._createRow): (WebInspector.TextEditorMainPanel): (WebInspector.TextEditorMainPanel.prototype.set syncDecorationsForLine): (WebInspector.TextEditorMainPanel.prototype.set mimeType): (WebInspector.TextEditorMainPanel.prototype.markAndRevealRange): (WebInspector.TextEditorMainPanel.prototype.highlightLine): (WebInspector.TextEditorMainPanel.prototype.clearLineHighlight): (WebInspector.TextEditorMainPanel.prototype.freeCachedElements): (WebInspector.TextEditorMainPanel.prototype._buildChunks): (WebInspector.TextEditorMainPanel.prototype._createNewChunk): (WebInspector.TextEditorMainPanel.prototype._expandChunks): (WebInspector.TextEditorMainPanel.prototype._highlightDataReady): (WebInspector.TextEditorMainPanel.prototype._paintLines): (WebInspector.TextEditorMainPanel.prototype._paintLine): (WebInspector.TextEditorMainPanel.prototype._releaseLinesHighlight): (WebInspector.TextEditorMainPanel.prototype._getSelection): (WebInspector.TextEditorMainPanel.prototype._restoreSelection): (WebInspector.TextEditorMainPanel.prototype._selectionToPosition): (WebInspector.TextEditorMainPanel.prototype._positionToSelection): (WebInspector.TextEditorMainPanel.prototype._appendTextNode): (WebInspector.TextEditorMainPanel.prototype._handleDomUpdates): (WebInspector.TextEditorMainChunk): (WebInspector.TextEditorMainChunk.prototype.addDecoration): (WebInspector.TextEditorMainChunk.prototype.set expanded): (WebInspector.TextEditorMainChunk.prototype.get height): (WebInspector.TextEditorMainChunk.prototype.getExpandedLineRow): (WebInspector.TextEditorMainChunk.prototype._createRow): (WebInspector):
- inspector/front-end/textViewer.css: (.text-editor-lines): (.text-editor-contents): (.text-editor-editable): (.webkit-line-decorations): (.webkit-line-number): (.webkit-execution-line.webkit-line-content): (.diff-container .webkit-added-line.webkit-line-content): (.diff-container .webkit-removed-line.webkit-line-content): (.diff-container .webkit-changed-line.webkit-line-content): (.webkit-highlighted-line.webkit-line-content):
- 6:07 AM Changeset in webkit [77374] by
-
- 10 edits in branches/chromium/648/LayoutTests/platform
Merge 77135 - 2011-01-31 Mads Ager <ager@chromium.org>
Reviewed by Pavel Feldman.
[V8] Update V8 specific layout test expectations
https://bugs.webkit.org/show_bug.cgi?id=53423
Error formatting has changed in V8. Updating chromium specific
layout test expectations accordingly.
- platform/chromium-mac/fast/js/array-every-expected.txt:
- platform/chromium-mac/fast/js/instance-of-immediates-expected.txt:
- platform/chromium-mac/fast/js/property-getters-and-setters-expected.txt:
- platform/chromium-mac/storage/transaction-error-callback-expected.txt:
- platform/chromium-mac/svg/dom/svgpath-out-of-bounds-getPathSeg-expected.txt:
- platform/chromium-win/fast/js/array-every-expected.txt:
- platform/chromium-win/fast/js/instance-of-immediates-expected.txt:
- platform/chromium-win/fast/js/property-getters-and-setters-expected.txt:
- platform/chromium-win/storage/transaction-error-callback-expected.txt:
- platform/chromium-win/svg/dom/svgpath-out-of-bounds-getPathSeg-expected.txt:
TBR=ager@chromium.org
Review URL: http://codereview.chromium.org/6349048
- 5:55 AM Changeset in webkit [77373] by
-
- 2 edits in trunk/LayoutTests
2011-02-02 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Removed some custom Chromium test expectations.
- platform/chromium/test_expectations.txt:
- 3:57 AM Changeset in webkit [77372] by
-
- 1 edit in branches/chromium/648/Source/WebCore/inspector/InspectorProfilerAgent.cpp
Merge 77254 - 2011-02-01 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Fix profiles reset to avoid clearing heap profiles in Chromium.
- inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::resetFrontendProfiles):
TBR=mnaganov@chromium.org
Review URL: http://codereview.chromium.org/6246044
- 2:10 AM Changeset in webkit [77371] by
-
- 15 edits2 adds in trunk
2011-02-02 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Implement support for cursor updates
https://bugs.webkit.org/show_bug.cgi?id=53421
Layout test for cursor updates.
- storage/indexeddb/cursor-update-expected.txt: Added.
- storage/indexeddb/cursor-update.html: Added.
2011-02-02 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Implement support for cursor updates
https://bugs.webkit.org/show_bug.cgi?id=53421
Implement support for cursor updates using the same pattern as cursor
deletes: forward the calls to the IDBObjectStoreBackend::put().
The put() function's signature needs to be changed to allow for a
"cursor update mode". This makes the signature more clear anyway,
since it replaces the boolean parameter.
Test: storage/indexeddb/cursor-update.html
- storage/IDBCursor.idl:
- storage/IDBCursorBackendImpl.cpp: (WebCore::IDBCursorBackendImpl::key): (WebCore::IDBCursorBackendImpl::update):
- storage/IDBCursorBackendImpl.h:
- storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::add): (WebCore::IDBObjectStore::put):
- storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::put): (WebCore::IDBObjectStoreBackendImpl::putInternal):
- storage/IDBObjectStoreBackendImpl.h:
- storage/IDBObjectStoreBackendInterface.h:
2011-02-02 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Implement support for cursor updates
https://bugs.webkit.org/show_bug.cgi?id=53421
Mirror the update to the IDBObjectStoreInterface::put() signature in
the WebKit layer wrappers.
- public/WebIDBObjectStore.h: (WebKit::WebIDBObjectStore::put):
- src/IDBObjectStoreProxy.cpp: (WebCore::IDBObjectStoreProxy::put):
- src/IDBObjectStoreProxy.h:
- src/WebIDBObjectStoreImpl.cpp: (WebKit::WebIDBObjectStoreImpl::put):
- src/WebIDBObjectStoreImpl.h:
- 12:50 AM Changeset in webkit [77370] by
-
- 3 edits in trunk/Source/WebCore
2011-02-02 Naoki Takano <takano.naoki@gmail.com>
Reviewed by Kent Tamura.
Fix popup menu RTL bug introduced by Changeset 75982.
https://bugs.webkit.org/show_bug.cgi?id=53567
PopupMenuChromium::layout() calculates X position according to RTL or not. So Change the X position calculation in layoutAndCalculateWidgetRect().
No new tests. However we can check manually with select_dropdown_box_alignment.html, autofill_alignment.html, select_alignment.html, select_dropdown_box_alignment.html, autofill-popup-width-and-item-direction.html
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::layoutAndCalculateWidgetRect): Fix calculation of x position, because layout() considers RTL. And change the parameter from both X and Y positions to only Y position. (WebCore::PopupContainer::showPopup): Change the passing parameter. (WebCore::PopupContainer::refresh): Change the passing parameter.
- platform/chromium/PopupMenuChromium.h: Change the parameter declaration.
- 12:49 AM Changeset in webkit [77369] by
-
- 4 edits in trunk/Source
2011-02-02 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] Fix dist compilation
https://bugs.webkit.org/show_bug.cgi?id=53579
- GNUmakefile.am: Added WriteBarrier.h to the sources, it was added in r77151
2011-02-02 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] Fix dist compilation
https://bugs.webkit.org/show_bug.cgi?id=53579
- GNUmakefile.am: Added FontWidthVariant.h to the sources, it was added in r77153.
- 12:24 AM Changeset in webkit [77368] by
-
- 14 edits in trunk/Source/WebCore
2011-02-02 Dai Mikurube <dmikurube@google.com>
Reviewed by David Levin.
Make mime type lookup in File::create(path) thread-safe
https://bugs.webkit.org/show_bug.cgi?id=47700
This patch introduces a new function MIMETypeRegistry::getMIMETypeForExtensionThreadSafe().
The function is to be called as a thread-safe version of getMIMETypeForExtension() when
both FILE_SYSTEM and WORKERS are enabled.
No tests for this patch. This patch itself doesn't change the behaviors.
For Chromium, it runs in the same way with getMIMETypeForExtensionThreadSafe().
For the other platforms, it causes compilation error in case of enabled FILE_SYSTEM and WORKERS.
The compilation error would be a signal to implement getMIMETypeForExtensionThreadSafe() in these
platforms. Currently it doesn't happen since FILE_SYSTEM is not available in the other platforms.
- platform/MIMETypeRegistry.cpp: Defined generic getMIMETypeForExtension() calling getMIMETypeForExtensionThreadSafe() for enabled FILE_SYSTEM and WORKERS. (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
- platform/MIMETypeRegistry.h: Declared getMIMETypeForExtensionThreadSafe() which should be implemented for each platform.
- platform/android/TemporaryLinkStubs.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
- platform/brew/MIMETypeRegistryBrew.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
- platform/chromium/MIMETypeRegistryChromium.cpp: Defined getMIMETypeForExtensionThreadSafe() for the case when FILE_SYSTEM and WORKERS are enabled. (WebCore::MIMETypeRegistry::getMIMETypeForExtensionThreadSafe):
- platform/efl/MIMETypeRegistryEfl.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
- platform/gtk/MIMETypeRegistryGtk.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
- platform/haiku/MIMETypeRegistryHaiku.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
- platform/mac/MIMETypeRegistryMac.mm: (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
- platform/qt/MIMETypeRegistryQt.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
- platform/win/MIMETypeRegistryWin.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
- platform/wince/MIMETypeRegistryWinCE.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
- platform/wx/MimeTypeRegistryWx.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
- 12:13 AM Changeset in webkit [77367] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-02-02 Chris Evans <cevans@chromium.org>
Reviewed by Adam Barth.
[Chromium] Propagate the accurate gesture status when calling into FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=53571
- src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::loadFrameRequest): FrameLoader might decide the target is a new window, so make such the UserGestureIndicator is fully accurate before calling into it.
- 12:00 AM Changeset in webkit [77366] by
-
- 10 edits in trunk/Source/WebCore
2011-02-01 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Improve readability of updateWidget by converting bool parameter to an enum
https://bugs.webkit.org/show_bug.cgi?id=53576
As requested on webkit-dev.
- html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::updateWidget):
- html/HTMLEmbedElement.h:
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::updateWidget):
- html/HTMLMediaElement.h:
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::updateWidget):
- html/HTMLObjectElement.h:
- html/HTMLPlugInImageElement.cpp: (WebCore::HTMLPlugInImageElement::updateWidgetIfNecessary):
- html/HTMLPlugInImageElement.h:
- page/FrameView.cpp: (WebCore::FrameView::updateWidget):
Feb 1, 2011:
- 11:06 PM Changeset in webkit [77365] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed.
Fix Qt build after r77339.
- UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::enterAcceleratedCompositingMode):
(QWKPagePrivate::exitAcceleratedCompositingMode):
- UIProcess/API/qt/qwkpage_p.h:
- 11:02 PM Changeset in webkit [77364] by
-
- 4 edits in trunk
2011-02-01 James Robinson <jamesr@chromium.org>
Reviewed by Adam Barth.
[v8] Increase V8 native->js recursion limit to match document.write() recursion limit
https://bugs.webkit.org/show_bug.cgi?id=53566
Unskip test that we now pass.
- platform/chromium/test_expectations.txt:
2011-02-01 James Robinson <jamesr@chromium.org>
Reviewed by Adam Barth.
[v8] Increase V8 native->js recursion limit to match document.write() recursion limit
https://bugs.webkit.org/show_bug.cgi?id=53566
A recursion limit of 22 is necessary to pass fast/dom/Document/document-write-recursion.html.
Other than being large enough for this one test case, this limit is arbitrary.
- bindings/v8/V8Proxy.h:
- 10:00 PM Changeset in webkit [77363] by
-
- 3 edits in trunk/Websites/bugs.webkit.org
2011-02-01 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
make draft comments focusable
https://bugs.webkit.org/show_bug.cgi?id=53554
Makes frozen draft comments focusable. The ones that are currently being edited are not.
I'm on the fence whether they should be, but this seems good enough for now.
- code-review.js:
- 9:17 PM Changeset in webkit [77362] by
-
- 3 edits in trunk/Websites/bugs.webkit.org
2011-02-01 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
avoid jitter when loading the comments to a patch
https://bugs.webkit.org/show_bug.cgi?id=53570
- code-review.js:
- 9:13 PM Changeset in webkit [77361] by
-
- 2 edits in trunk/Source/WebCore
2011-02-01 Adam Barth <abarth@webkit.org>
Reviewed by Andreas Kling.
Remove useless comment
https://bugs.webkit.org/show_bug.cgi?id=53549
The reason for this parameter is captured in
plugins/netscape-plugin-setwindow-size.html, which is a better place to
capture it than in this comment (which otherwise just re-iterates the
name of the parameter).
- html/HTMLPlugInImageElement.cpp: (WebCore::HTMLPlugInImageElement::updateWidgetIfNecessary):
- 9:05 PM Changeset in webkit [77360] by
-
- 11 edits in trunk/Source/JavaScriptCore
2011-02-01 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r77297.
http://trac.webkit.org/changeset/77297
https://bugs.webkit.org/show_bug.cgi?id=53538
caused leopard crashes (Requested by paroga on #webkit).
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- wtf/text/AtomicString.cpp: (WTF::AtomicString::fromUTF8):
- wtf/unicode/UTF8.cpp: (WTF::Unicode::calculateStringHashFromUTF8):
- wtf/unicode/UTF8.h:
- 7:42 PM Changeset in webkit [77359] by
-
- 1 copy in tags/Safari-533.20.21
New tag.
- 7:28 PM EFLWebKit edited by
- Root CMakeLists.txt was moved to Source directory. (diff)
- 7:02 PM Changeset in webkit [77358] by
-
- 2 edits in trunk/LayoutTests
2011-02-01 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change.
fast/css/box-shadow.html was removed in r77101 but there was
still a reference to it in the expectations file.
- platform/chromium/test_expectations.txt:
- 6:57 PM Changeset in webkit [77357] by
-
- 3 edits in trunk/Source/WebCore
2011-02-01 James Simonsen <simonjam@chromium.org>
Reviewed by Tony Gentilcore.
[WebTiming] Remove asserts that verify timestamp order
https://bugs.webkit.org/show_bug.cgi?id=53548
Covered by existing tests.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): Remove assert.
- page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchTimedEvent): Ditto.
- 6:50 PM Changeset in webkit [77356] by
-
- 2 edits in trunk/Source/WebCore
2011-02-01 Dimitri Glazkov <Dimitri Glazkov>
Add the 'default_targets' enclosure to the flags.
- WebCore.gyp/WebCore.gyp: Did it.
- 6:39 PM Changeset in webkit [77355] by
-
- 7 edits2 adds in trunk
2011-02-01 Mihai Parparita <mihaip@chromium.org>
Reviewed by James Robinson.
Async event handlers should not fire within a modal dialog
https://bugs.webkit.org/show_bug.cgi?id=53202
Add tests for a scroll event triggered right before a modal dialog is
shown.
- fast/events/scroll-event-during-modal-dialog-expected.txt: Added.
- fast/events/scroll-event-during-modal-dialog.html: Added.
2011-02-01 Mihai Parparita <mihaip@chromium.org>
Reviewed by James Robinson.
Async event handlers should not fire within a modal dialog
https://bugs.webkit.org/show_bug.cgi?id=53202
Asychronous events that use EventQueue would currently fire while a
modal dialog (e.g. window.alert()) was up. Change EventQueue to use a
SuspendableTimer (which automatically gets suspended while dialogs are
up and in other cases where JS execution is not allowed).
Test: fast/events/scroll-event-during-modal-dialog.html
- dom/Document.cpp: (WebCore::Document::Document):
- dom/EventQueue.cpp: (WebCore::EventQueueTimer::EventQueueTimer): (WebCore::EventQueueTimer::fired): (WebCore::EventQueue::EventQueue): (WebCore::EventQueue::enqueueEvent): (WebCore::EventQueue::pendingEventTimerFired):
- dom/EventQueue.h: (WebCore::EventQueue::create):
- page/SuspendableTimer.cpp: (WebCore::SuspendableTimer::SuspendableTimer): (WebCore::SuspendableTimer::suspend): (WebCore::SuspendableTimer::resume):
- page/SuspendableTimer.h:
- 6:35 PM Changeset in webkit [77354] by
-
- 1 edit in branches/chromium/597/WebCore/bindings/v8/V8NPUtils.cpp
Merge 76264
BUG=69970
- 6:32 PM Changeset in webkit [77353] by
-
- 3 edits in trunk/Tools
2011-02-01 Dirk Pranke <dpranke@chromium.org>
Reviewed by Mihai Parparita.
new-run-webkit-tests: stop skipping so many tests
r77163 introduced a regression where we weren't resetting test
expectations properly and were skipping too many tests as a
result. This patch fixes that and adds a test for it.
- Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
- Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
- 6:23 PM Changeset in webkit [77352] by
-
- 2 edits in branches/chromium/597/WebCore/rendering
Merge 75810
BUG=69556
- 6:18 PM Changeset in webkit [77351] by
-
- 2 edits in trunk/Source/WebCore
2011-02-01 Patrick Gansterer <Patrick Gansterer>
Reviewed by Andreas Kling.
Change wrong PLATFORM(WIN) to USE(WININET)
https://bugs.webkit.org/show_bug.cgi?id=53547
- platform/network/ResourceHandle.h:
- 6:05 PM Changeset in webkit [77350] by
-
- 2 edits in trunk/Source/WebCore
32-bit build fix.
- platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPainterControllerDelegate contentAreaRectForScrollerImpPair:]):
- 6:04 PM Changeset in webkit [77349] by
-
- 7 edits in branches/safari-533.20-branch
Build fix.
- 6:04 PM Changeset in webkit [77348] by
-
- 4 edits in branches/chromium/597/WebCore
Merge 76990
BUG=68120
- 5:53 PM Changeset in webkit [77347] by
-
- 4 edits in trunk
2011-02-01 Kent Tamura <tkent@chromium.org>
Reviewed by Tony Chang.
[Chromium] Roll Chromium revision for the WebKitWeightWatcher change
https://bugs.webkit.org/show_bug.cgi?id=53563
- platform/chromium/test_expectations.txt: fast/css/font-weight-1.html is expected to fail.
2011-02-01 Kent Tamura <tkent@chromium.org>
Reviewed by Tony Chang.
[Chromium] Roll Chromium revision for the WebKitWeightWatcher change
https://bugs.webkit.org/show_bug.cgi?id=53563
- DEPS: Roll to crrev.com/73378 to have the WebKitWeightWatcher change of webkit_support.
- 5:49 PM Changeset in webkit [77346] by
-
- 2 edits in trunk/LayoutTests
2011-02-01 Dimitri Glazkov <Dimitri Glazkov>
Marking test, added in r77333 as skipped, because it is
reaching V8 recursion limits faster than those on Document.
- platform/chromium/test_expectations.txt: See above.
- 5:45 PM Changeset in webkit [77345] by
-
- 4 edits in trunk/Source/WebKit2
2011-02-01 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Attach the layer tree in the UI process
https://bugs.webkit.org/show_bug.cgi?id=53560
- UIProcess/API/mac/WKView.mm: (-[WKView _enterAcceleratedCompositingMode:]): Make a render layer and add it as a sublayer of our root layer.
- WebProcess/WebPage/mac/LayerTreeHostMac.h: Make LayerTreeHostMac a GraphicsLayerClient.
- WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::LayerTreeHostMac): Create a root layer, add the layer subtree as a child of the root layer.
(WebKit::LayerTreeHostMac::~LayerTreeHostMac):
Assert that m_rootLayer is null.
(WebKit::LayerTreeHostMac::invalidate):
Null out m_rootLayer.
(WebKit::LayerTreeHostMac::notifyAnimationStarted):
(WebKit::LayerTreeHostMac::notifySyncRequired):
(WebKit::LayerTreeHostMac::paintContents):
Add stubs.
(WebKit::LayerTreeHostMac::showDebugBorders):
(WebKit::LayerTreeHostMac::showRepaintCounter):
Return the correct settings.
(WebKit::LayerTreeHostMac::flushPendingLayerChanges):
Flush the root layer changes.
- 5:41 PM Changeset in webkit [77344] by
-
- 1 edit in branches/chromium/597/WebCore/rendering/RenderBox.cpp
Merge 75823
BUG=67968
- 5:31 PM Changeset in webkit [77343] by
-
- 4 edits in trunk
2011-01-25 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Two tests crash after r76555
https://bugs.webkit.org/show_bug.cgi?id=53057
- platform/gtk/Skipped: Unskip tests which are no longer crashing.
2011-01-25 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Two tests crash after r76555
https://bugs.webkit.org/show_bug.cgi?id=53057
Instead of creating synchronous ResourceHandles manually, use the ::create factory.
This ensures that ::start() is not called when there is a scheduled failure and also
reduces code duplication.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::loadResourceSynchronously): Use the ::create factory method.
- 5:25 PM Changeset in webkit [77342] by
-
- 1 edit in branches/chromium/597/WebCore/page/animation/AnimationController.cpp
Merge 76708
BUG=67234
- 5:16 PM Changeset in webkit [77341] by
-
- 3 edits1 add in trunk/Tools
2011-02-01 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
new-run-webkit-tests: add first stub of test_runner2. This
will add support for the 'inline', 'threads', and 'processes'
flags to --worker-model, but for now the implementatios just
fall back on the old ones.
- Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 5:12 PM Changeset in webkit [77340] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
2011-02-01 Ojan Vafai <ojan@chromium.org>
Reviewed by Mihai Parparita.
[codereviewtool] extra space at the beginning of lines in side-by-side view
https://bugs.webkit.org/show_bug.cgi?id=53550
The newline between the spans turns into user-visible space in side-by-side mode.
- PrettyPatch/PrettyPatch.rb:
- 5:11 PM Changeset in webkit [77339] by
-
- 3 edits in trunk/Source/WebKit2
Fix Windows build.
- UIProcess/win/WebView.cpp:
(WebKit::WebView::enterAcceleratedCompositingMode):
(WebKit::WebView::exitAcceleratedCompositingMode):
- UIProcess/win/WebView.h:
- 5:09 PM Changeset in webkit [77338] by
-
- 2 edits in trunk/Source/WebKit2
2011-02-01 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Add a layer backed NSView for accelerated content
https://bugs.webkit.org/show_bug.cgi?id=53555
Rename the current _layerHostingView to _oldLayerHostingView and
add a new _layerHostingView to be used with the new drawing area.
- UIProcess/API/mac/WKView.mm: (-[WKView hitTest:]): (-[WKView _startAcceleratedCompositing:]): (-[WKView _stopAcceleratedCompositing]): (-[WKView _enterAcceleratedCompositingMode:]): (-[WKView _exitAcceleratedCompositingMode]):
- 5:04 PM Changeset in webkit [77337] by
-
- 2 edits in trunk/Source/WebCore
2011-02-01 Martin Robinson <mrobinson@igalia.com>
Reviewed by Eric Seidel.
[GTK] GObject DOM bindings do no support the CallWith attribute
https://bugs.webkit.org/show_bug.cgi?id=53331
Disable building GObject DOM bindings for IndexedDB because we do not support
the CallWith attribute at this time.
- bindings/gobject/GNUmakefile.am: Disable building bindings for the IndexedDB API.
- 5:01 PM Changeset in webkit [77336] by
-
- 3 edits in trunk/Source/WebCore
2011-02-01 Darin Adler <Darin Adler>
Reviewed by Brady Eidson.
Fix a couple loose ends from the back/forward tree encode/decode work
https://bugs.webkit.org/show_bug.cgi?id=53537
- history/HistoryItem.cpp: (WebCore::HistoryItem::encodeBackForwardTreeNode): Remove extra copy of original URL string; no need to encode it twice. (WebCore::HistoryItem::decodeBackForwardTree): Ditto.
- history/HistoryItem.h: Removed declaration for function that is no longer defined nor used.
- 4:55 PM Changeset in webkit [77335] by
-
- 2 edits in trunk/Source/WebCore
2011-02-01 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] disable arm uninitialized variable warnings
https://bugs.webkit.org/show_bug.cgi?id=53553
We just got another error:
third_party/WebKit/Source/WebCore/css/CSSPrimitiveValue.cpp:123:error:
'colorTransparent.unstatic.4879' may be used uninitialized in this
function
- WebCore.gyp/WebCore.gyp:
- 4:48 PM Changeset in webkit [77334] by
-
- 9 edits in trunk/Source/WebKit2
2011-02-01 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Pass enter/exit accelerated compositing mode to the WKView
https://bugs.webkit.org/show_bug.cgi?id=53552
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::enterAcceleratedCompositingMode): (WebKit::PageClientImpl::exitAcceleratedCompositingMode):
- UIProcess/API/mac/WKView.mm: (-[WKView _enterAcceleratedCompositingMode:]): (-[WKView _exitAcceleratedCompositingMode]):
- UIProcess/API/mac/WKViewInternal.h:
- UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode): (WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode):
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::enterAcceleratedCompositingMode): (WebKit::WebPageProxy::exitAcceleratedCompositingMode):
- UIProcess/WebPageProxy.h:
- 4:22 PM Changeset in webkit [77333] by
-
- 4 edits6 adds in trunk
2011-02-01 chris reiss <christopher.reiss@nokia.com>
Reviewed by Adam Barth.
Self-replicating code makes Safari hang and eventually crash
https://bugs.webkit.org/show_bug.cgi?id=15123
- fast/dom/Document/document-close-iframe-load-expected.txt: Added.
- fast/dom/Document/document-close-iframe-load.html: Added.
- fast/dom/Document/document-close-nested-iframe-load-expected.txt: Added.
- fast/dom/Document/document-close-nested-iframe-load.html: Added.
- fast/dom/Document/document-write-recursion-expected.txt: Added.
- fast/dom/Document/document-write-recursion.html: Added.
2011-02-01 chris reiss <christopher.reiss@nokia.com>
Reviewed by Adam Barth.
Self-replicating code makes Safari hang and eventually crash
https://bugs.webkit.org/show_bug.cgi?id=15123
Here we are replicating the Firefox safeguard against
recursive document.write( ) 's.
See https://bug197052.bugzilla.mozilla.org/attachment.cgi?id=293907 in bug
https://bugzilla.mozilla.org/show_bug.cgi?id=197052 . Firefox does two things -
a) imposes a recursion limit of 20 on document.write( ) and
b) once that limit is passed, panics all the way the call stack (rather than just returning one level.)
To see why this is necessary, consider the script :
<script>
var t = document.body.innerHTML;
document.write(t);
</script>
This will create a tree both broad and deep as the script keeps appending itself to the text. If
we just return one level after the recursion limit is reached, we still allow millions of copies to
duplicate (and execute).
The recursion is fortunately depth-first, so as soon as we cross this limit, we panic up the callstack
to prevent this situation. (IE apparently does the same thing, with a lower recursion limit.)
Test: fast/dom/Document/document-write-recursion.html
Test: fast/dom/Document/document-close-iframe-load.html
Test: fast/dom/Document/document-close-nested-iframe-load.html
- dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::write):
- dom/Document.h:
- 4:12 PM Changeset in webkit [77332] by
-
- 2 edits in trunk/LayoutTests
2011-02-01 Dimitri Glazkov <Dimitri Glazkov>
Updated text expectations to avoid conflict.
- platform/chromium/test_expectations.txt: Tweaked.
- 4:05 PM Changeset in webkit [77331] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
2011-02-01 Ojan Vafai <ojan@chromium.org>
Increment version number to cache-bust code-review.js.
- PrettyPatch/PrettyPatch.rb:
- 4:00 PM Changeset in webkit [77330] by
-
- 2 edits1 add in trunk/Websites/bugs.webkit.org
2011-01-31 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
Store draft comments in localStorage
https://bugs.webkit.org/show_bug.cgi?id=52866
- code-review.js:
- code-review-test.html
- 3:52 PM Changeset in webkit [77329] by
-
- 3 edits2 adds in trunk
2011-02-01 Johnny Ding <jnd@chromium.org>
Reviewed by Darin Adler.
Don't set user gesture in HTMLAnchorElement's click handler because the click handler can be triggered by untrusted event.
https://bugs.webkit.org/show_bug.cgi?id=53424
- fast/events/popup-blocked-from-untrusted-click-event-on-anchor-expected.txt: Added.
- fast/events/popup-blocked-from-untrusted-click-event-on-anchor.html: Added.
2011-02-01 Johnny Ding <jnd@chromium.org>
Reviewed by Darin Adler.
Don't set user gesture in HTMLAnchorElement's click handler because the click handler can be triggered by untrusted event.
https://bugs.webkit.org/show_bug.cgi?id=53424
Test: fast/events/popup-blocked-from-untrusted-click-event-on-anchor.html
- html/HTMLAnchorElement.cpp: (WebCore::handleLinkClick):
- 3:50 PM Changeset in webkit [77328] by
-
- 6 edits in trunk/Source
Unreviewed Qt buildfix after r77286.
https://bugs.webkit.org/show_bug.cgi?id=53520
Remove the physical terminology from IntRect and FloatRect.
Source/WebCore:
- platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::createTiles):
Source/WebKit/qt:
- WebCoreSupport/PopupMenuQt.cpp:
(WebCore::PopupMenuQt::show):
Source/WebKit2:
- UIProcess/qt/ChunkedUpdateDrawingAreaProxyQt.cpp:
(WebKit::ChunkedUpdateDrawingAreaProxy::drawUpdateChunkIntoBackingStore):
- 3:46 PM Changeset in webkit [77327] by
-
- 2 edits in trunk/LayoutTests
2011-02-01 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectations update.
- platform/chromium/test_expectations.txt:
- 3:41 PM Changeset in webkit [77326] by
-
- 2 edits in branches/safari-533.20-branch/WebCore
Merge r71769.
- 3:41 PM Changeset in webkit [77325] by
-
- 17 edits8 adds4 deletes in branches/safari-533.20-branch
Merge r71767.
- 3:32 PM Changeset in webkit [77324] by
-
- 5 edits in trunk/Source/JavaScriptCore
2011-02-01 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r77297.
http://trac.webkit.org/changeset/77297
https://bugs.webkit.org/show_bug.cgi?id=53538
caused leopard crashes (Requested by paroga on #webkit).
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- wtf/text/AtomicString.cpp: (WTF::AtomicString::fromUTF8):
- wtf/unicode/UTF8.cpp: (WTF::Unicode::calculateStringHashFromUTF8):
- wtf/unicode/UTF8.h:
- 3:26 PM Changeset in webkit [77323] by
-
- 10 edits in trunk/LayoutTests
2011-02-01 Dimitri Glazkov <Dimitri Glazkov>
Updated baselines after switching input-derived parts of HTMLMediaElement
to use shadow DOM.
https://bugs.webkit.org/show_bug.cgi?id=53314
- platform/chromium-linux/media/video-zoom-controls-expected.checksum: Updated.
- platform/chromium-linux/media/video-zoom-controls-expected.png: Updated.
- platform/chromium-mac/media/video-zoom-controls-expected.checksum: Updated.
- platform/chromium-mac/media/video-zoom-controls-expected.png: Updated.
- platform/chromium-mac/media/video-zoom-controls-expected.txt: Updated.
- platform/chromium-win/media/video-zoom-controls-expected.checksum: Updated.
- platform/chromium-win/media/video-zoom-controls-expected.png: Updated.
- platform/chromium-win/media/video-zoom-controls-expected.txt: Updated.
- platform/chromium/test_expectations.txt: Expectation of failure removed.
- 3:20 PM Changeset in webkit [77322] by
-
- 7 edits in trunk/Source
Fix Mac production builds.
- JavaScriptCore.xcodeproj/project.pbxproj:
../WebCore:
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- platform/mac/ScrollAnimatorMac.h:
- platform/mac/ScrollbarThemeMac.h:
- 3:05 PM Changeset in webkit [77321] by
-
- 2 edits1 add in trunk/LayoutTests
2011-02-01 Abhishek Arya <inferno@chromium.org>
Unreviewed.
Test not crashing on chromium, was crashing earlier because of
some build issues. Also, rebaselining chromium mac since it matches
rest of chromium and is not same as mac leopard.
https://bugs.webkit.org/show_bug.cgi?id=53516
- platform/chromium-mac/fast/css/stylesheet-candidate-nodes-crash-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 3:04 PM Changeset in webkit [77320] by
-
- 4 edits in trunk/Source/WebKit/chromium
2011-02-01 Darin Fisher <darin@chromium.org>
Reviewed by David Levin.
- [chromium] Remove unnecessary WebCore
- prefixing in a few places and fix-up some indentation. https://bugs.webkit.org/show_bug.cgi?id=53523
- src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::attach): (WebKit::WebDevToolsAgentImpl::inspectNode): (WebKit::WebDevToolsAgentImpl::inspectorController): (WebKit::WebDevToolsAgentImpl::mainFrame): (WebKit::WebDevToolsAgentImpl::identifierForInitialRequest): (WebKit::WebDevToolsAgentImpl::sendMessageToFrontend): (WebKit::WebDevToolsAgentImpl::updateInspectorStateCookie): (WebKit::WebDevToolsAgent::interruptAndDispatch): (WebKit::WebDevToolsAgent::processPendingMessages):
- src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::resize):
- src/WebScrollbarImpl.cpp: (WebKit::WebScrollbarImpl::setLocation): (WebKit::WebScrollbarImpl::setValue): (WebKit::WebScrollbarImpl::onMouseWheel): (WebKit::WebScrollbarImpl::onKeyDown): (WebKit::WebScrollbarImpl::scrollPosition): (WebKit::WebScrollbarImpl::setScrollOffset): (WebKit::WebScrollbarImpl::invalidateScrollbarRect): (WebKit::WebScrollbarImpl::getTickmarks):
- 3:02 PM Changeset in webkit [77319] by
-
- 3 edits2 adds in branches/safari-533.20-branch
Merge r73620.
- 2:59 PM Changeset in webkit [77318] by
-
- 5 edits2 adds in branches/safari-533.20-branch
Merge r73559.
- 2:56 PM Changeset in webkit [77317] by
-
- 1 edit in trunk/Source/WebKit2/UIProcess/qt/TiledDrawingAreaTileQt.cpp
Fix Qt bustage.
- 2:52 PM Changeset in webkit [77316] by
-
- 1 edit in trunk/Source/WebKit/qt/Api/qwebframe.cpp
Fix Qt bustage.
- 2:51 PM Changeset in webkit [77315] by
-
- 8 edits2 adds in trunk/Source/WebKit2
2011-02-01 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
Send messages when entering/exiting accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=53534
- Shared/LayerTreeContext.h: Added.
- Shared/mac/LayerTreeContextMac.mm: Added. Add new LayerTreeContext which holds all information needed to enter accelerated compositing mode.
- UIProcess/DrawingAreaProxy.h: (WebKit::DrawingAreaProxy::enterAcceleratedCompositingMode): (WebKit::DrawingAreaProxy::exitAcceleratedCompositingMode): Add empty stubs.
- UIProcess/DrawingAreaProxy.messages.in: Add new messgaes.
- UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode): (WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode):
- UIProcess/DrawingAreaProxyImpl.h: Add empty stubs.
- WebKit2.xcodeproj/project.pbxproj: Add new files.
- WebProcess/WebPage/mac/LayerTreeHostMac.h:
- WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::LayerTreeHostMac): (WebKit::LayerTreeHostMac::invalidate): Send messages.
- 2:49 PM Changeset in webkit [77314] by
-
- 6 edits2 adds in branches/safari-533.20-branch
Merge r71431.
- 2:49 PM Changeset in webkit [77313] by
-
- 6 edits2 adds in trunk
2011-02-01 Darin Adler <Darin Adler>
Reviewed by Chris Fleizach.
REGRESSION: Removing focus from area element causes unwanted scrolling
https://bugs.webkit.org/show_bug.cgi?id=50169
Test: fast/images/imagemap-scroll.html
- html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::setFocus): Added override. Calls the new RenderImage::areaElementFocusChanged function. (WebCore::HTMLAreaElement::updateFocusAppearance): Removed the code here that calls setNeedsLayout on the image's renderer. This was an attempt to cause repaint of the renderer, but this function does not need to do that. Also changed this to use the imageElement function to avoid repeating code.
- html/HTMLAreaElement.h: Updated for above changes.
- rendering/RenderImage.cpp: (WebCore::RenderImage::paint): Updated for name change. (WebCore::RenderImage::paintAreaElementFocusRing): Renamed this from paintFocusRing, because it only paints area focus rings, and should not be confused with paintFocusRing functions in other classes. Also removed the unused style argument. Removed the code that used an HTMLCollection to see if the focused area element is for this image and instead just call imageElement on the area element. (WebCore::RenderImage::areaElementFocusChanged): Added. Calls repaint.
- rendering/RenderImage.h: Added a public areaElementFocusChanged function for HTMLAreaElement to call. Made the paintFocusRing function private, renamed it to paintAreaElementFocusRing, and removed its unused style argument.
2011-02-01 Darin Adler <Darin Adler>
Reviewed by Chris Fleizach.
REGRESSION: Removing focus from area element causes unwanted scrolling
https://bugs.webkit.org/show_bug.cgi?id=50169
- fast/images/imagemap-scroll-expected.txt: Added.
- fast/images/imagemap-scroll.html: Added.
- 2:48 PM Changeset in webkit [77312] by
-
- 1 edit in trunk/Source/WebCore/platform/graphics/TiledBackingStore.cpp
Fix Qt bustage.
- 2:42 PM Changeset in webkit [77311] by
-
- 5 edits2 adds in trunk
2011-02-01 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
getUniform should support SAMPLER_2D or SAMPLER_CUBE
https://bugs.webkit.org/show_bug.cgi?id=52190
- fast/canvas/webgl/gl-object-get-calls-expected.txt:
- fast/canvas/webgl/gl-object-get-calls.html: Test getUniform with sampler2D and samplerCube uniforms.
- fast/canvas/webgl/resources/noopUniformShader.vert: Added.
- fast/canvas/webgl/resources/samplerUniformShader.frag: Added.
2011-02-01 Patrick Gansterer <Patrick Gansterer>
Unreviewed WinCE build fix for r77286.
- platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::TransparentLayerDC::TransparentLayerDC):
- 2:42 PM Changeset in webkit [77310] by
-
- 7 edits2 adds in branches/safari-533.20-branch
Merge r70792.
- 2:39 PM Changeset in webkit [77309] by
-
- 2 edits in trunk/Source/WebCore
2011-02-01 Patrick Gansterer <Patrick Gansterer>
Unreviewed WinCE build fix for r77286.
- platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::TransparentLayerDC::TransparentLayerDC):
- 2:37 PM Changeset in webkit [77308] by
-
- 6 edits2 adds in trunk
AX: AXPosition of AXScrollArea is wrong
https://bugs.webkit.org/show_bug.cgi?id=53511
Reviewed by Darin Adler.
Source/WebCore:
AccessibilityScrollView needed to return a valid documentFrameView() object.
At the same time, the code from document() should be consolidated in
AccessibilityObject, so all objects can use it.
Test: platform/mac/accessibility/webkit-scrollarea-position.html
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::document):
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityScrollView.cpp:
(WebCore::AccessibilityScrollView::accessibilityHitTest):
(WebCore::AccessibilityScrollView::documentFrameView):
- accessibility/AccessibilityScrollView.h:
LayoutTests:
- platform/mac/accessibility/webkit-scrollarea-position-expected.txt: Added.
- platform/mac/accessibility/webkit-scrollarea-position.html: Added.
- 2:33 PM Changeset in webkit [77307] by
-
- 7 edits2 adds in branches/safari-533.20-branch
Merge r69033.
- 2:30 PM Changeset in webkit [77306] by
-
- 2 edits in trunk/Source/WebKit2
Reviewed by Dan Bernstein and Darin Adler.
<rdar://problem/8830594> Printed page is sometimes shifted down, making footer invisible
- UIProcess/API/mac/WKPrintingView.mm: (-[WKPrintingView locationOfPrintRect:]): Instead of letting AppKit compute content position on page, make the view provide it. We can do this because WK(Printing)Views are always printed on their own, not as part of other views.
- 2:29 PM Changeset in webkit [77305] by
-
- 2 edits in trunk/Source/WebCore
2011-02-01 Zhenyao Mo <zmo@google.com>
Reviewed by Darin Adler.
Fix the incorrect usage of RetainPtr cases in GraphicsContext3DCG.cpp
https://bugs.webkit.org/show_bug.cgi?id=53531
With this fix, running WebGL conformance tests should no longer crash randomly.
- platform/graphics/cg/GraphicsContext3DCG.cpp: (WebCore::GraphicsContext3D::getImageData):
- 2:23 PM Changeset in webkit [77304] by
-
- 15 edits5 adds in branches/safari-533.20-branch
Merge r70335.
- 2:21 PM Changeset in webkit [77303] by
-
- 8 edits2 adds in branches/safari-533.20-branch
Merge r68541.
- 2:14 PM Changeset in webkit [77302] by
-
- 2 edits in trunk/Source/WebCore
2011-02-01 Dimitri Glazkov <Dimitri Glazkov>
One more Chromium build fix after r77286.
- platform/chromium/ScrollbarThemeChromiumMac.mm: (WebCore::ScrollbarThemeChromiumMac::paint): Changed to not use topLeft().
- 2:12 PM Changeset in webkit [77301] by
-
- 2 edits in trunk/Source/JavaScriptCore
Try to fix the windows build.
- DerivedSources.make:
- 2:11 PM Changeset in webkit [77300] by
-
- 1 edit in trunk/Source/WebKit2/UIProcess/TiledDrawingAreaProxy.cpp
Fix Qt bustage.
- 2:07 PM Changeset in webkit [77299] by
-
- 14 edits1 add in branches/safari-533.20-branch
Merge r74524.
- 2:04 PM Changeset in webkit [77298] by
-
- 2 edits in trunk/Source/WebCore
Fix the build for Beth.
- platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPainterControllerDelegate inLiveResizeForScrollerImpPair:]):
- 2:03 PM Changeset in webkit [77297] by
-
- 5 edits in trunk/Source/JavaScriptCore
2011-02-01 Patrick Gansterer <Patrick Gansterer>
Reviewed by Darin Adler.
Avoid strlen() in AtomicString::fromUTF8
https://bugs.webkit.org/show_bug.cgi?id=50516
Add an overload to calculateStringHashFromUTF8 to get
strlen() of the input data with only one call.
This change shows about 3% performance win on the xml-parser benchmark.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- wtf/text/AtomicString.cpp: (WTF::AtomicString::fromUTF8):
- wtf/unicode/UTF8.cpp: (WTF::Unicode::calculateStringHashAndLengthFromUTF8Internal): (WTF::Unicode::calculateStringHashFromUTF8): (WTF::Unicode::calculateStringHashAndLengthFromUTF8):
- wtf/unicode/UTF8.h:
- 2:02 PM Changeset in webkit [77296] by
-
- 2 edits2 copies in branches/safari-533.20-branch/LayoutTests
Merge r66796.
- 2:02 PM Changeset in webkit [77295] by
-
- 4 edits2 adds in branches/safari-533.20-branch
Merge r66795.
- 2:02 PM Changeset in webkit [77294] by
-
- 15 edits in branches/safari-533.20-branch/WebCore
Merge r66115.
- 1:57 PM Changeset in webkit [77293] by
-
- 7 edits in trunk/Source/WebKit2
2011-02-01 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
Make LayerTreeHost ref counted
https://bugs.webkit.org/show_bug.cgi?id=53530
LayerTreeHostMac will soon be able to trigger layout, which could cause
the page to leave accelerated compositing mode and free the LayerTreeHostMac object.
Making LayerTreeHost ref counted will let LayerTreeHostMac protect itself while triggering layout.
- WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::setRootCompositingLayer):
- WebProcess/WebPage/DrawingAreaImpl.h:
- WebProcess/WebPage/LayerTreeHost.cpp: (WebKit::LayerTreeHost::create):
- WebProcess/WebPage/LayerTreeHost.h:
- WebProcess/WebPage/mac/LayerTreeHostMac.h:
- WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::create): (WebKit::LayerTreeHostMac::LayerTreeHostMac): (WebKit::LayerTreeHostMac::~LayerTreeHostMac): (WebKit::LayerTreeHostMac::invalidate):
- 1:56 PM Changeset in webkit [77292] by
-
- 1 edit in trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp
Fix chromium bustage.
- 1:51 PM Changeset in webkit [77291] by
-
- 1 edit in trunk/Source/WebCore/platform/qt/RenderThemeQt.cpp
Fix Qt build bustage.
- 1:50 PM Changeset in webkit [77290] by
-
- 3 edits2 adds in branches/safari-533.20-branch
Merge r75882.
- 1:50 PM Changeset in webkit [77289] by
-
- 3 edits2 adds in branches/safari-533.20-branch
- 1:47 PM Changeset in webkit [77288] by
-
- 2 edits in trunk/LayoutTests
2011-02-01 Dimitri Glazkov <Dimitri Glazkov>
Added yet another expectations of flakiness.
https://bugs.webkit.org/show_bug.cgi?id=53527
- platform/chromium/test_expectations.txt: Flakiness abound.
- 1:45 PM Changeset in webkit [77287] by
-
- 13 edits in trunk/Source
Part 2 for <rdar://problem/8492788>
Adopt WKScrollbarPainterController
Reviewed by Beth Dakin.
Use header detection to define scrollbar painting controller #define.
Source/JavaScriptCore:
- DerivedSources.make:
- JavaScriptCore.xcodeproj/project.pbxproj:
Source/WebCore:
- WebCore.exp.in:
- platform/mac/ScrollAnimatorMac.h:
- platform/mac/ScrollbarThemeMac.h:
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
Source/WebKit/mac:
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
Source/WebKit2:
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
- 1:39 PM Changeset in webkit [77286] by
-
- 67 edits in trunk/Source
https://bugs.webkit.org/show_bug.cgi?id=53520
Reviewed by Oliver Hunt.
Remove the physical terminology from IntRect and FloatRect.
Now that we have flipped RenderBlocks for vertical-rl and horizontal-bt writing modes,
we need to update our terminology to be more accurate.
I'm borrowing a page from AppKit here (which also supports flipped NSViews) and
renaming right() and bottom() to maxX() and maxY(). These terms remain accurate
even for flipped rectangles.
../WebCore:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::boundsForVisiblePositionRange):
- accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper position]):
- dom/ClientRect.h:
(WebCore::ClientRect::right):
(WebCore::ClientRect::bottom):
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::convertLogicalToDevice):
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::normalizeRect):
- inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::drawElementTitle):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::adjustWindowRect):
- page/DragController.cpp:
(WebCore::dragLocForSelectionDrag):
- page/EventHandler.cpp:
(WebCore::EventHandler::sendContextMenuEventForKey):
- page/PrintContext.cpp:
(WebCore::PrintContext::computePageRectsWithPageSizeInternal):
(WebCore::PrintContext::pageNumberForElement):
- page/SpatialNavigation.cpp:
(WebCore::end):
(WebCore::areRectsFullyAligned):
(WebCore::areRectsMoreThanFullScreenApart):
(WebCore::below):
(WebCore::rightOf):
(WebCore::isRectInDirection):
(WebCore::entryAndExitPointsForDirection):
(WebCore::virtualRectForDirection):
- page/WindowFeatures.cpp:
(WebCore::WindowFeatures::WindowFeatures):
- platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
- platform/Scrollbar.cpp:
(WebCore::Scrollbar::setFrameRect):
- platform/ScrollbarThemeComposite.cpp:
(WebCore::ScrollbarThemeComposite::splitTrack):
- platform/chromium/ScrollbarThemeChromium.cpp:
(WebCore::ScrollbarThemeChromium::paintTickmarks):
- platform/graphics/FloatQuad.h:
(WebCore::FloatQuad::FloatQuad):
- platform/graphics/FloatRect.cpp:
(WebCore::FloatRect::intersects):
(WebCore::FloatRect::contains):
(WebCore::FloatRect::intersect):
(WebCore::FloatRect::unite):
(WebCore::enclosingIntRect):
- platform/graphics/FloatRect.h:
(WebCore::FloatRect::maxX):
(WebCore::FloatRect::maxY):
(WebCore::FloatRect::contains):
- platform/graphics/IntRect.cpp:
(WebCore::IntRect::intersects):
(WebCore::IntRect::contains):
(WebCore::IntRect::intersect):
(WebCore::IntRect::unite):
- platform/graphics/IntRect.h:
(WebCore::IntRect::maxX):
(WebCore::IntRect::maxY):
(WebCore::IntRect::shiftXEdgeTo):
(WebCore::IntRect::shiftMaxXEdgeTo):
(WebCore::IntRect::shiftYEdgeTo):
(WebCore::IntRect::shiftMaxYEdgeTo):
(WebCore::IntRect::contains):
- platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::advance):
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::fillRect):
- platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::getImageData):
(WebCore::putImageData):
- platform/graphics/cg/ImageCG.cpp:
(WebCore::BitmapImage::draw):
- platform/graphics/filters/FilterEffect.cpp:
(WebCore::FilterEffect::copyImageBytes):
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):
- platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformBoundsForGlyph):
- platform/graphics/transforms/AffineTransform.cpp:
(WebCore::AffineTransform::mapRect):
- platform/graphics/win/FontCGWin.cpp:
(WebCore::drawGDIGlyphs):
- platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
(WebCore::MediaPlayerPrivate::paint):
- platform/gtk/RenderThemeGtk.cpp:
(WebCore::centerRectVerticallyInParentInputElement):
- platform/mac/WidgetMac.mm:
(WebCore::Widget::paint):
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::addBoxShadowVisualOverflow):
(WebCore::InlineFlowBox::addTextBoxVisualOverflow):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::selectionRect):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::positionForOffset):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addOverflowFromChildren):
(WebCore::RenderBlock::paintChildren):
(WebCore::RenderBlock::paintEllipsisBoxes):
(WebCore::RenderBlock::inlineSelectionGaps):
(WebCore::RenderBlock::adjustPointToColumnContents):
(WebCore::RenderBlock::flipForWritingModeIncludingColumns):
(WebCore::RenderBlock::adjustForColumns):
- rendering/RenderBlock.h:
(WebCore::RenderBlock::FloatingObject::right):
(WebCore::RenderBlock::FloatingObject::bottom):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::reflectedRect):
(WebCore::RenderBox::localCaretRect):
(WebCore::RenderBox::addShadowOverflow):
(WebCore::RenderBox::addLayoutOverflow):
(WebCore::RenderBox::visualOverflowRectForPropagation):
(WebCore::RenderBox::layoutOverflowRectForPropagation):
(WebCore::RenderBox::flipForWritingMode):
- rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::paintColumnBorder):
(WebCore::RenderFrameSet::paintRowBorder):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::paintOutlineForLine):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::getRectToExpose):
(WebCore::cornerRect):
(WebCore::RenderLayer::positionOverflowControls):
(WebCore::RenderLayer::overflowBottom):
(WebCore::RenderLayer::overflowRight):
(WebCore::RenderLayer::paintResizer):
- rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::rangeIntersectsRect):
(WebCore::RenderLineBoxList::paint):
- rendering/RenderListItem.cpp:
(WebCore::RenderListItem::positionListMarker):
- rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::paint):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintAfterLayoutIfNeeded):
- rendering/RenderOverflow.h:
(WebCore::RenderOverflow::RenderOverflow):
(WebCore::RenderOverflow::addLayoutOverflow):
(WebCore::RenderOverflow::addVisualOverflow):
(WebCore::RenderOverflow::setLayoutOverflow):
(WebCore::RenderOverflow::setVisualOverflow):
(WebCore::RenderOverflow::resetLayoutOverflow):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::shouldPaint):
- rendering/RenderScrollbarTheme.cpp:
(WebCore::RenderScrollbarTheme::constrainTrackRectToTrackPieces):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::paint):
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paint):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::paintObject):
- rendering/RenderText.cpp:
(WebCore::RenderText::absoluteQuads):
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::forwardEvent):
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMenuListButtonGradients):
(WebCore::RenderThemeMac::paintMenuListButton):
(WebCore::RenderThemeMac::paintSliderTrack):
- rendering/RenderView.cpp:
(WebCore::RenderView::computeRectForRepaint):
(WebCore::RenderView::docBottom):
(WebCore::RenderView::docRight):
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::paddedLayoutOverflowRect):
- rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::localCaretRect):
../WebKit/mac:
- WebView/WebHTMLView.mm:
(setNeedsDisplayInRect):
../WebKit2:
- Platform/Region.cpp:
(WebKit::Region::Shape::Shape):
- UIProcess/API/mac/WKPrintingView.mm:
(pageDidComputePageRects):
- UIProcess/FindIndicator.cpp:
(WebKit::FindIndicator::draw):
- UIProcess/TiledDrawingAreaProxy.cpp:
(WebKit::TiledDrawingAreaProxy::invalidate):
(WebKit::TiledDrawingAreaProxy::paint):
(WebKit::TiledDrawingAreaProxy::createTiles):
- UIProcess/mac/ChunkedUpdateDrawingAreaProxyMac.mm:
(WebKit::ChunkedUpdateDrawingAreaProxy::drawUpdateChunkIntoBackingStore):
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::callSetWindow):
- 1:38 PM Changeset in webkit [77285] by
-
- 1 edit2 adds in trunk/LayoutTests
2011-02-01 Abhishek Arya <inferno@chromium.org>
Unreviewed.
Rebaseline my test for QT, Leopard from r77262 due
to minor comment error differences.
- platform/mac-leopard/fast/css/stylesheet-candidate-nodes-crash-expected.txt: Added.
- platform/qt/fast/css/stylesheet-candidate-nodes-crash-expected.txt: Added.
- 1:36 PM Changeset in webkit [77284] by
-
- 16 edits2 adds in branches/safari-533.20-branch
Merge r72230.
- 1:36 PM Changeset in webkit [77283] by
-
- 3 edits in branches/safari-533.20-branch/WebCore
Merge r69125.
- 1:34 PM Changeset in webkit [77282] by
-
- 5 edits in trunk/Source/WebKit2
2011-02-01 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
Move flushPendingLayerChanges to LayerTreeHostMac
https://bugs.webkit.org/show_bug.cgi?id=53525
In preparation for adding more Mac specific code to flushPendingLayerChanges.
- WebProcess/WebPage/LayerTreeHost.cpp:
- WebProcess/WebPage/LayerTreeHost.h:
- WebProcess/WebPage/mac/LayerTreeHostMac.h:
- WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::flushPendingLayerChanges):
- 1:28 PM Changeset in webkit [77281] by
-
- 1 edit8 adds in trunk/LayoutTests
2011-02-01 Xiaomei Ji <xji@chromium.org>
Unreviewed.
Rebaseline after r77267.
- platform/chromium-linux/fast/dom/34176-expected.checksum: Added.
- platform/chromium-linux/fast/dom/34176-expected.png: Added.
- platform/chromium-mac/fast/dom/34176-expected.checksum: Added.
- platform/chromium-mac/fast/dom/34176-expected.png: Added.
- platform/chromium-win/fast/dom/34176-expected.checksum: Added.
- platform/chromium-win/fast/dom/34176-expected.png: Added.
- platform/chromium-win/fast/dom/34176-expected.txt: Added.
- platform/win/fast/dom/34176-expected.txt: Added.
- 1:26 PM Changeset in webkit [77280] by
-
- 5 edits7 adds in branches/safari-533.20-branch
Merge r74854.
- 1:15 PM Changeset in webkit [77279] by
-
- 2 edits in trunk/Tools
2011-02-01 Mihai Parparita <mihaip@chromium.org>
Reviewed by James Robinson.
[Chromium] run-chromium-webkit-unit-tests looks for binaries in the wrong place
https://bugs.webkit.org/show_bug.cgi?id=53522
- Scripts/run-chromium-webkit-unit-tests:
- 12:50 PM Changeset in webkit [77278] by
-
- 2 edits in trunk/LayoutTests
2011-02-01 Xiaomei Ji <xji@chromium.org>
Unreviewed.
- fast/dom/34176.html: Removed properties svn:executable and svn:mime-type.
- 12:44 PM Changeset in webkit [77277] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-02-01 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
REGRESSION(77082): GC-related crashes seen: on WebKit2 bot; on GTK 32bit
bot; loading trac pages; typing in search field
https://bugs.webkit.org/show_bug.cgi?id=53519
The crashes were all caused by failure to run an object's destructor.
- runtime/CollectorHeapIterator.h: (JSC::ObjectIterator::ObjectIterator): Don't skip forward upon construction. The iterator class used to do that when it was designed for prior-to-beginning initialization. I forgot to remove this line of code when I changed the iterator to normal initialization.
Skipping forward upon construction was causing the heap to skip running
the destructor for the very first object in a block when destroying the
block. This usually did not crash, since block destruction is rare and
most objects have pretty trivial destructors. However, in the rare case
when the heap would destroy a block whose first object was a global
object or a DOM node, BOOM.
- 12:39 PM Changeset in webkit [77276] by
-
- 2 edits in trunk/LayoutTests
2011-02-01 Dimitri Glazkov <Dimitri Glazkov>
Remove expectations of failure for passing tests.
- platform/chromium/test_expectations.txt: Fewer fails.
- 12:35 PM Changeset in webkit [77275] by
-
- 2 edits in trunk/Tools
2011-02-01 Adam Barth <abarth@webkit.org>
Reviewed by Mihai Parparita.
Using Control-C to cancel webkit-patch or other python tools causes
unpleasant traceback console spew
https://bugs.webkit.org/show_bug.cgi?id=53462
Catch the exception and don't print the stack trace.
- Scripts/webkit-patch:
- 12:35 PM Changeset in webkit [77274] by
-
- 27 edits in trunk/Source
Fix for <rdar://problem/8492788> Adopt WKScrollbarPainterController
Reviewed by Sam Weinig.
Source/WebCore:
Lots of new WebCoreSystemInterface functions to export.
- WebCore.exp.in:
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
Let the scrollAnimator know when the mouse has
moved anywhere inside the page, and when the mouse
has moved in or out of the window.
- page/EventHandler.cpp:
(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::updateMouseEventTargetNode):
Let the scrollAnimator know when the window has become
active or inactive.
- page/FocusController.cpp:
(WebCore::FocusController::setActive):
Let the scrollAnimator know when all of these things
are happening.
- page/FrameView.cpp:
(WebCore::FrameView::setContentsSize):
(WebCore::FrameView::didMoveOnscreen):
(WebCore::FrameView::willMoveOffscreen):
(WebCore::FrameView::currentMousePosition):
(WebCore::FrameView::contentsResized):
New functions called through WebKit2 that allow the
scrollAnimator to know when a live resize starts and ends.
(WebCore::FrameView::willStartLiveResize):
(WebCore::FrameView::willEndLiveResize):
- page/FrameView.h:
New functions on ScrollAnimator that pass information
to the WKPainterController when we're using one.
- platform/ScrollAnimator.h:
(WebCore::ScrollAnimator::scrollableArea):
(WebCore::ScrollAnimator::contentAreaWillPaint):
(WebCore::ScrollAnimator::mouseEnteredContentArea):
(WebCore::ScrollAnimator::mouseExitedContentArea):
(WebCore::ScrollAnimator::mouseMovedInContentArea):
(WebCore::ScrollAnimator::willStartLiveResize):
(WebCore::ScrollAnimator::contentsResized):
(WebCore::ScrollAnimator::willEndLiveResize):
(WebCore::ScrollAnimator::contentAreaDidShow):
(WebCore::ScrollAnimator::contentAreaDidHide):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::scrollbarPainterDelegate):
(WebCore::ScrollAnimatorMac::setPainterForPainterController):
(WebCore::ScrollAnimatorMac::removePainterFromPainterController):
(WebCore::ScrollAnimatorMac::notityPositionChanged):
(WebCore::ScrollAnimatorMac::contentAreaWillPaint):
(WebCore::ScrollAnimatorMac::mouseEnteredContentArea):
(WebCore::ScrollAnimatorMac::mouseExitedContentArea):
(WebCore::ScrollAnimatorMac::mouseMovedInContentArea):
(WebCore::ScrollAnimatorMac::willStartLiveResize):
(WebCore::ScrollAnimatorMac::contentsResized):
(WebCore::ScrollAnimatorMac::willEndLiveResize):
(WebCore::ScrollAnimatorMac::contentAreaDidShow):
(WebCore::ScrollAnimatorMac::contentAreaDidHide):
Let the scrollAnimator know when this is happening.
- platform/ScrollView.cpp:
(WebCore::ScrollView::paint):
New function lets the scrollAnimator get the current
mouse position.
- platform/ScrollView.h:
(WebCore::ScrollView::currentMousePosition):
New function that returns the scrollAnimator when needed.
- platform/ScrollableArea.h:
(WebCore::ScrollableArea::scrollAnimator):
Keep track of if we're in a live resize using a new memeber
variable.
- platform/mac/ScrollAnimatorMac.h:
(WebCore::ScrollAnimatorMac::inLiveResize):
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::view):
New delegates for the WKPainter and WKPainterController
(-[ScrollbarPainterControllerDelegate initWithScrollAnimator:WebCore::]):
(-[ScrollbarPainterControllerDelegate contentAreaRectForScrollerImpPair:]):
(-[ScrollbarPainterControllerDelegate inLiveResizeForScrollerImpPair:]):
(-[ScrollbarPainterControllerDelegate mouseLocationInContentAreaForScrollerImpPair:]):
(-[ScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]):
(-[ScrollbarPainterControllerDelegate scrollerImpPair:setContentAreaNeedsDisplayInRect:]):
(-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]):
(-[ScrollKnobAnimation initWithScrollbarPainter:forScrollAnimator:WebCore::animateKnobAlphaTo:duration:]):
(-[ScrollKnobAnimation setCurrentProgress:]):
(-[ScrollbarPainterDelegate initWithScrollAnimator:WebCore::]):
(-[ScrollbarPainterDelegate convertRectToBacking:]):
(-[ScrollbarPainterDelegate convertRectFromBacking:]):
(-[ScrollbarPainterDelegate layer]):
(-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:animateKnobAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:overlayScrollerStateChangedTo:]):
Get the WKScrollbarPainterRefs to synch up with the
WKScrollbarPainterControllerRefs when appropriate
- platform/mac/ScrollbarThemeMac.h:
- platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::unregisterScrollbar):
(WebCore::ScrollbarThemeMac::setNewPainterForScrollbar):
(WebCore::ScrollbarThemeMac::usesOverlayScrollbars):
Implement ScrollableArea's virtual function contentsSize() for access
through the scrollAnimator.
- rendering/RenderLayer.h:
(WebCore::RenderLayer::contentsSize):
Source/WebKit/mac:
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
Source/WebKit2:
Implement NSView's viewWillStartLiveResize and
viewDidEndLiveResize and propagate the messages down
to WebCore.
- UIProcess/API/mac/WKView.mm:
(-[WKView viewWillStartLiveResize]):
(-[WKView viewDidEndLiveResize]):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::viewWillStartLiveResize):
(WebKit::WebPageProxy::viewWillEndLiveResize):
- UIProcess/WebPageProxy.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::viewWillStartLiveResize):
(WebKit::WebPage::viewWillEndLiveResize):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
A bunch of new WebKitSystemInterface functions.
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
- 12:28 PM Changeset in webkit [77273] by
-
- 3 edits2 adds in trunk
2011-02-01 Carol Szabo <carol.szabo@nokia.com>
Reviewed by David Hyatt.
layoutTestController.counterValueForElementById does not return the correct value
https://bugs.webkit.org/show_bug.cgi?id=53037
- fast/css/counters/deep-before-expected.txt: Added.
- fast/css/counters/deep-before.html: Added. This tests whether DumpRenderTree properly retrieves counters and whether counters are properly set when the before pseudo element's renderer is not a direct child of the generating element's renderer.
2011-02-01 Carol Szabo <carol.szabo@nokia.com>
Reviewed by David Hyatt.
layoutTestController.counterValueForElementById does not return the correct value
https://bugs.webkit.org/show_bug.cgi?id=53037
Test: fast/css/counters/deep-before.html
- rendering/RenderTreeAsText.cpp: (WebCore::counterValueForElement): Modified to use the newly available RenderObject::beforePseudoElement() and RenderObject::afterPseudoElement() instead of the old imperfect algorithm to find the before and after pseudo elements.
- 12:27 PM Changeset in webkit [77272] by
-
- 2 edits in trunk/Source/WebCore
2011-02-01 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
Allow access for security origin same as this.
https://bugs.webkit.org/show_bug.cgi?id=53440
Hard to test as newly added path currently is never hit.
- page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::canAccess): allow access if this == other
- 12:25 PM Changeset in webkit [77271] by
-
- 2 edits in trunk/LayoutTests
2011-02-01 Dimitri Glazkov <Dimitri Glazkov>
Added more flakiness expectations from bots.
- platform/chromium/test_expectations.txt: Another one bites or doesn't bite the dust.
- 12:21 PM Changeset in webkit [77270] by
-
- 3 edits2 adds in branches/safari-533.20-branch
Merge r73801.
- 12:17 PM Changeset in webkit [77269] by
-
- 31 edits in trunk/Source
2011-01-31 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Update JSObject storage for new marking API
https://bugs.webkit.org/show_bug.cgi?id=53467
JSObject no longer uses EncodedJSValue for its property storage.
This produces a stream of mechanical changes to PropertySlot and
anonymous storage APIs.
- JavaScriptCore.exp:
- runtime/ArrayPrototype.cpp: (JSC::ArrayPrototype::ArrayPrototype):
- runtime/BooleanConstructor.cpp: (JSC::constructBoolean): (JSC::constructBooleanFromImmediateBoolean):
- runtime/BooleanObject.cpp: (JSC::BooleanObject::BooleanObject):
- runtime/BooleanObject.h:
- runtime/BooleanPrototype.cpp: (JSC::BooleanPrototype::BooleanPrototype):
- runtime/DateInstance.cpp: (JSC::DateInstance::DateInstance):
- runtime/DatePrototype.cpp: (JSC::DatePrototype::DatePrototype):
- runtime/JSActivation.cpp: (JSC::JSActivation::getOwnPropertySlot):
- runtime/JSArray.cpp: (JSC::JSArray::getOwnPropertySlot):
- runtime/JSFunction.cpp: (JSC::JSFunction::getOwnPropertySlot):
- runtime/JSGlobalObject.h: (JSC::JSGlobalObject::JSGlobalObject):
- runtime/JSObject.cpp: (JSC::JSObject::fillGetterPropertySlot):
- runtime/JSObject.h: (JSC::JSObject::getDirectLocation): (JSC::JSObject::offsetForLocation): (JSC::JSObject::putAnonymousValue): (JSC::JSObject::clearAnonymousValue): (JSC::JSObject::getAnonymousValue): (JSC::JSObject::putThisToAnonymousValue): (JSC::JSObject::locationForOffset): (JSC::JSObject::inlineGetOwnPropertySlot):
- runtime/JSObjectWithGlobalObject.cpp: (JSC::JSObjectWithGlobalObject::JSObjectWithGlobalObject):
- runtime/JSWrapperObject.h: (JSC::JSWrapperObject::JSWrapperObject): (JSC::JSWrapperObject::setInternalValue):
- runtime/Lookup.cpp: (JSC::setUpStaticFunctionSlot):
- runtime/NumberConstructor.cpp: (JSC::constructWithNumberConstructor):
- runtime/NumberObject.cpp: (JSC::NumberObject::NumberObject): (JSC::constructNumber):
- runtime/NumberObject.h:
- runtime/NumberPrototype.cpp: (JSC::NumberPrototype::NumberPrototype):
- runtime/PropertySlot.h: (JSC::PropertySlot::getValue): (JSC::PropertySlot::setValue): (JSC::PropertySlot::setRegisterSlot):
- runtime/StringObject.cpp: (JSC::StringObject::StringObject):
- runtime/StringPrototype.cpp: (JSC::StringPrototype::StringPrototype):
- runtime/WriteBarrier.h: (JSC::WriteBarrierBase::setWithoutWriteBarrier):
2011-01-31 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Update JSObject storage for new marking API
https://bugs.webkit.org/show_bug.cgi?id=53467
Update WebCore to handle new anonymous slot behaviour.
- bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::setWindow):
- bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::initScript):
- bindings/scripts/CodeGeneratorJS.pm:
- 12:05 PM Changeset in webkit [77268] by
-
- 2 edits in trunk/LayoutTests
2011-02-01 Dimitri Glazkov <Dimitri Glazkov>
https://bugs.webkit.org/show_bug.cgi?id=53516
Test introduced in r77262 is crashing.
- platform/chromium/test_expectations.txt: Added expectation to crash
while the fix is worked on.
- 12:02 PM Changeset in webkit [77267] by
-
- 3 edits4 adds in trunk
2011-02-01 Xiaomei Ji <xji@chromium.org>
Reviewed by David Hyatt.
Fix a text rendering problem when enclosing block is RTL and text runs
are in different directionality.
https://bugs.webkit.org/show_bug.cgi?id=34176
The problem happens in the following example scenario (ABC represents
Hebrew characters):
<div dir=rtl>this is a <span><span>test <span>ABC</span></span></span></div>
The line consists of 3 text runs -- TextRun1 TextRun2 TextRun3. In which
TextRun1 and TextRun2's bidi level are 2, and TextRun3's bidi level is 1.
TextRun2 and TextRun3's least common ancestor is not a sibling of TextRun1.
The visual bidi run order of the text runs is TextRun3 TextRun1 TextRun2.
Inside RenderBlock::constructLine(), when RenderBlock::createLineBoxes()
creates InlineFlowBox for TextRun2, it should check an InlineFlowBox for
the run's render object's ancestor (not only its parent) has already
been constructed or has something following it on the line, in which
case, create a new box for TextRun2 instead of sharing the same box with
TextRun3.
In other words, the following 2 div should render the same results
(ABC represents Hebrew characters).
<div dir=rtl>this is a <span><span>test <span>ABC</span></span></span></div>
<div dir=rtl>this is a <span>Test <span>ABC</span></span></div>
Test: fast/dom/34176.html
- rendering/RenderBlockLineLayout.cpp: (WebCore::parentIsConstructedOrHaveNext): (WebCore::RenderBlock::createLineBoxes):
2011-02-01 Xiaomei Ji <xji@chromium.org>
Reviewed by David Hyatt.
Fix a text rendering problem when enclosing block is RTL and text runs
are in different directionality.
https://bugs.webkit.org/show_bug.cgi?id=34176
The problem happens in the following example scenario (ABC represents
Hebrew characters):
<div dir=rtl>this is a <span><span>test <span>ABC</span></span></span></div>
The line consists of 3 text runs -- TextRun1 TextRun2 TextRun3. In which
TextRun1 and TextRun2's bidi level are 2, and TextRun3's bidi level is 1.
TextRun2 and TextRun3's least common ancestor is not a sibling of TextRun1.
The visual bidi run order of the text runs is TextRun3 TextRun1 TextRun2.
Inside RenderBlock::constructLine(), when RenderBlock::createLineBoxes()
creates InlineFlowBox for TextRun2, it should check an InlineFlowBox for
the run's render object's ancestor (not only its parent) has already
been constructed or has something following it on the line, in which
case, create a new box for TextRun2 instead of sharing the same box with
TextRun3.
In other words, the following 2 div should render the same results
(ABC represents Hebrew characters).
<div dir=rtl>this is a <span><span>test <span>ABC</span></span></span></div>
<div dir=rtl>this is a <span>Test <span>ABC</span></span></div>
- fast/dom/34176.html: Added.
- platform/mac/fast/dom/34176-expected.checksum: Added.
- platform/mac/fast/dom/34176-expected.png: Added.
- platform/mac/fast/dom/34176-expected.txt: Added.
- 11:39 AM Changeset in webkit [77266] by
-
- 1 edit in trunk/LayoutTests/platform/mac/printing/setPrinting-expected.txt
Update printing layout test for the ceiling->floor change.
- 11:37 AM Changeset in webkit [77265] by
-
- 5 edits in branches/chromium/648
Merge 76557 - 2011-01-24 Peter Kasting <pkasting@google.com>
Reviewed by Darin Adler.
Roll back r67261 ("Don't fire onclick on middle clicks") due to
regressions.
https://bugs.webkit.org/show_bug.cgi?id=46733
- fast/events/mouse-click-events-expected.txt:
- fast/events/script-tests/mouse-click-events.js:
2011-01-24 Peter Kasting <pkasting@google.com>
Reviewed by Darin Adler.
Roll back r67261 ("Don't fire onclick on middle clicks") due to
regressions.
https://bugs.webkit.org/show_bug.cgi?id=46733
- html/HTMLAnchorElement.cpp: (WebCore::isLinkClick):
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::preDispatchEventHandler): (WebCore::HTMLInputElement::postDispatchEventHandler): (WebCore::HTMLInputElement::defaultEventHandler):
- page/EventHandler.cpp: (WebCore::EventHandler::handleMouseDoubleClickEvent): (WebCore::EventHandler::handleMouseReleaseEvent):
TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/6250083
- 11:22 AM Changeset in webkit [77264] by
-
- 2 edits in trunk/Tools
2011-02-01 Scott Cameron <sccameron@rim.com>
Reviewed by Daniel Bates.
Use Windows format for MinGW HTTPD path.
https://bugs.webkit.org/show_bug.cgi?id=53503
- Scripts/webkitperl/httpd.pm:
- Use single-quotes around MySys value for $httpdPath in getHTTPDPath() so that we don't have to escape the space characters in the path. Also, changed path to Windows-style path and removed FIXME comment.
- 11:21 AM Changeset in webkit [77263] by
-
- 2 edits in trunk/LayoutTests
2011-02-01 Mihai Parparita <mihaip@chromium.org>
Unreviewed. Include actual values in fast/canvas/webgl/gl-teximage.html
(removed by r77129) in the case of failure.
- fast/canvas/webgl/gl-teximage.html:
- 11:16 AM Changeset in webkit [77262] by
-
- 3 edits2 adds in trunk
2011-01-31 Abhishek Arya <inferno@chromium.org>
Reviewed by Dan Bernstein.
Tests that a removed svg style element is not accessed again in document's
style recalc code and does not result in crash.
https://bugs.webkit.org/show_bug.cgi?id=53441
- fast/css/stylesheet-candidate-nodes-crash-expected.txt: Added.
- fast/css/stylesheet-candidate-nodes-crash.xhtml: Added.
2011-02-01 Abhishek Arya <inferno@chromium.org>
Reviewed by Dan Bernstein.
Do not add a node in the document's stylesheet candidate node list if the
node is already removed from document.
https://bugs.webkit.org/show_bug.cgi?id=53441
Test: fast/css/stylesheet-candidate-nodes-crash.xhtml
- dom/Document.cpp: (WebCore::Document::addStyleSheetCandidateNode):
- 11:09 AM Changeset in webkit [77261] by
-
- 2 edits in trunk/LayoutTests
2011-02-01 Dimitri Glazkov <Dimitri Glazkov>
More flakiness updates.
- platform/chromium/test_expectations.txt: Moar flakiness recorded.
- 10:50 AM Changeset in webkit [77260] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-02-01 Daniel Bates <dbates@rim.com>
Reviewed by Antonio Gomes.
Modify RandomNumberSeed.h to use USE(MERSENNE_TWISTER_19937)
https://bugs.webkit.org/show_bug.cgi?id=53506
Currently, use of the Mersenne Twister pseudorandom number generator
is hardcoded to the Windows CE port. With the passing of bug #53253,
we can generalize support for this PRNG to all ports that use srand(3)
and rand(3), including Windows CE.
- wtf/RandomNumberSeed.h: (WTF::initializeRandomNumberGenerator):
- 10:49 AM Changeset in webkit [77259] by
-
- 1 edit in trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
Land Webpage.cpp for previous patch. Change was lost after conflict resolution from a merge.
- 10:46 AM Changeset in webkit [77258] by
-
- 1 edit in trunk/Source/WebKit2/Platform/CoreIPC/Connection.cpp
Back out accidental commit of Connection.cpp
- 10:44 AM Changeset in webkit [77257] by
-
- 17 edits in trunk/Source
https://bugs.webkit.org/show_bug.cgi?id=46422, make printing and pagination work
with vertical text.
Reviewed by Darin Adler.
../WebCore:
Change printing functions to check writing-mode and properly swap width and height
as needed.
Fix the setScrollOrigin function so that the origin doesn't cause
scroll spasming during printing (this is only partially successful, but it's better
than it was).
Rewrite computePageRects to handle both RTL documents properly as well as vertical
text documents properly.
- WebCore.exp.in:
- page/FrameView.cpp:
(WebCore::FrameView::adjustViewSize):
(WebCore::FrameView::forceLayoutForPagination):
- page/PrintContext.cpp:
(WebCore::PrintContext::computePageRects):
(WebCore::PrintContext::computePageRectsWithPageSizeInternal):
(WebCore::PrintContext::computeAutomaticScaleFactor):
(WebCore::PrintContext::spoolPage):
(WebCore::PrintContext::spoolRect):
- page/PrintContext.h:
- page/mac/WebCoreFrameView.h:
- platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
- platform/ScrollView.h:
- platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::platformSetScrollOrigin):
- rendering/RenderView.cpp:
(WebCore::RenderView::layout):
../WebKit/mac:
Change printing functions to check writing-mode and properly swap width and height
as needed.
- WebView/WebDynamicScrollBarsView.mm:
(-[WebDynamicScrollBarsView setScrollOrigin:updatePositionAtAll:immediately:]):
- WebView/WebFrame.mm:
(-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]):
- WebView/WebFrameInternal.h:
- WebView/WebHTMLView.mm:
(-[WebHTMLView _web_setPrintingModeRecursive]):
(-[WebHTMLView _web_clearPrintingModeRecursive]):
(-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]):
(-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumPageWidth:]):
(-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]):
(-[WebHTMLView _endPrintMode]):
(-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]):
(-[WebHTMLView _endScreenPaginationMode]):
(-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]):
(-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:maximumPageLogicalWidth:adjustViewSize:paginateScreenContent:]):
(-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
(-[WebHTMLView _scaleFactorForPrintOperation:]):
(-[WebHTMLView setPageWidthForPrinting:]):
(-[WebHTMLView knowsPageRange:]):
../WebKit2:
Change printing functions to check writing-mode and properly swap width and height
as needed.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::computePagesForPrinting):
- 10:29 AM Changeset in webkit [77256] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-02-01 Mihai Parparita <mihaip@chromium.org>
Unreviewed roll of Chromium deps to r73306. This picks up a fix to get
the WebKit root dir correctly after the move to Source/. This allows
tests like http/tests/security/frame-loading-via-document-write.html
(which use LayoutTestController.pathToLocalResource) to pass with the
Chromium DRT.
- DEPS:
- 9:57 AM Changeset in webkit [77255] by
-
- 2 edits in trunk/LayoutTests
2011-02-01 Dimitri Glazkov <Dimitri Glazkov>
Updated flaky test expectations according to build bot results.
- platform/chromium/test_expectations.txt: Flakiness recorded.
- 9:22 AM Changeset in webkit [77254] by
-
- 2 edits in trunk/Source/WebCore
2011-02-01 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Fix profiles reset to avoid clearing heap profiles in Chromium.
- inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::resetFrontendProfiles):
- 9:09 AM Changeset in webkit [77253] by
-
- 6 edits in trunk/Tools
2011-02-01 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Andreas Kling.
[Qt][WK2] Add a way to use shared process model in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=53090
- MiniBrowser/qt/BrowserView.cpp: (BrowserView::BrowserView): Removed the m_context member. From now the context is guaranteed to be non-null and we don't need to store that in the object.
- MiniBrowser/qt/BrowserView.h:
- MiniBrowser/qt/BrowserWindow.cpp: Added static bool to determine that new windows need to be created with their own context or not. Use the same context and web process by default to be inilne with the other ports. (BrowserWindow::BrowserWindow): (BrowserWindow::newWindow):
- MiniBrowser/qt/BrowserWindow.h:
- MiniBrowser/qt/main.cpp: (main): Added command line switch to be able to use the non-shared process model. Simplify the handling of the command line switches a little bit.
- 8:59 AM Changeset in webkit [77252] by
-
- 4 edits in trunk/Source/WebCore
2011-02-01 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Landing detailed heap snapshots, part 1.
Adding code for accessing heap snapshot data and
performing graph calculations.
- English.lproj/localizedStrings.js:
- inspector/front-end/HeapSnapshot.js: (WebInspector.HeapSnapshotArraySlice): Helper class to avoid array contents copying. (WebInspector.HeapSnapshotEdge): Wrapper for accessing graph edge properties. (WebInspector.HeapSnapshotEdgeIterator): (WebInspector.HeapSnapshotNode): Wrapper for accessing graph node properties. (WebInspector.HeapSnapshotNodeIterator): (WebInspector.HeapSnapshot): Wrapper for the heap snapshot. (WebInspector.HeapSnapshotFilteredOrderedIterator): (WebInspector.HeapSnapshotEdgesProvider): (WebInspector.HeapSnapshotNodesProvider): (WebInspector.HeapSnapshotPathFinder):
- inspector/front-end/HeapSnapshotView.js: (WebInspector.HeapSnapshotView.prototype._convertSnapshot):
- 7:46 AM Changeset in webkit [77251] by
-
- 2 edits in trunk/Source/WebCore
Fix linker warnings in Release_LTCG builds
- WebCore.vcproj/WebCore.vcproj: Exclude EventNames.cpp and EventTarget.cpp from all
configurations, since they get pulled in via DOMAllInOne.cpp.
- 6:57 AM Changeset in webkit [77250] by
-
- 3 edits in trunk/Tools
[Qt] Add Window menu and Toggle FullScreen action to MiniBrowser.
https://bugs.webkit.org/show_bug.cgi?id=53491
Reviewed by Andreas Kling.
- MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
(BrowserWindow::toggleFullScreenMode):
- MiniBrowser/qt/BrowserWindow.h:
- 6:53 AM Changeset in webkit [77249] by
-
- 6 edits in trunk/Source
2011-02-01 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [Chromium] Wrongly labelled context-menu item for links in Web Inspector's side-pane
https://bugs.webkit.org/show_bug.cgi?id=53482
- English.lproj/localizedStrings.js:
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.populateHrefContextMenu):
- inspector/front-end/inspector.js: (WebInspector.resourceForURL): (WebInspector.openLinkExternallyLabel):
2011-02-01 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [Chromium] Wrongly labelled context-menu item for links in Web Inspector's side-pane
https://bugs.webkit.org/show_bug.cgi?id=53482
- src/js/DevTools.js: (WebInspector.openLinkExternallyLabel): Override to customize a context menu item label
- 6:40 AM Changeset in webkit [77248] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-02-01 Dave Tapuska <dtapuska@rim.com>
Reviewed by Gavin Barraclough.
MacroAssemblerARM would generate code that did 32bit loads
on addresses that were not aligned. More specifically it would
generate a ldr r8,[r1, #7] which isn't valid on ARMv5 and lower.
The intended instruction really is ldrb r8,[r1, #7]; ensure we
call load8 instead of load32.
- assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::set32Test32): (JSC::MacroAssemblerARM::set32Test8):
- 6:38 AM Changeset in webkit [77247] by
-
- 1 edit1 copy in trunk/LayoutTests
Unreviewed.
fast/loader/onload-policy-ignore-for-frame.html fails on Qt bot
https://bugs.webkit.org/show_bug.cgi?id=53490
Add Qt specific expected result.
- platform/qt/fast/loader/onload-policy-ignore-for-frame-expected.txt: Copied from LayoutTests/fast/loader/onload-policy-ignore-for-frame-expected.txt.
- 6:35 AM Changeset in webkit [77246] by
-
- 2 edits in trunk/Source/WebCore
2011-02-01 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
Propagate parent document security origin to newly create Document XML response
https://bugs.webkit.org/show_bug.cgi?id=53444
Covered by the existing tests.
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::responseXML):
- 5:32 AM Changeset in webkit [77245] by
-
- 3 edits in trunk/Tools
[Qt] Add Toggle Frame Flattening, Auto Load Images and Disable JavaScript actions to MiniBrowser.
https://bugs.webkit.org/show_bug.cgi?id=53489
Reviewed by Andreas Kling.
Add Toggle Frame Flattening action to Develop menu. Add Auto Load Images and Disable JavaScript actions
to Settings menu.
- MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
(BrowserWindow::toggleFrameFlattening):
(BrowserWindow::toggleDisableJavaScript):
(BrowserWindow::toggleAutoLoadImages):
- MiniBrowser/qt/BrowserWindow.h:
- 5:07 AM Changeset in webkit [77244] by
-
- 3 edits in branches/chromium/648/Source/WebCore/inspector/front-end
Merge 77127 - 2011-01-30 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: speed up network panel rendering.
https://bugs.webkit.org/show_bug.cgi?id=53397
- inspector/front-end/DataGrid.js: (WebInspector.DataGrid.prototype.get scrollContainer):
- inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.elementsToRestoreScrollPositionsFor): (WebInspector.NetworkPanel.prototype._positionSummaryBar): (WebInspector.NetworkPanel.prototype._createTable): (WebInspector.NetworkPanel.prototype._exportResource): (WebInspector.NetworkPanel.prototype._onScroll):
- inspector/front-end/networkPanel.css: (.network-sidebar .data-grid.small tr.offscreen): (.network-sidebar .data-grid tr.offscreen): (.network-sidebar .data-grid tr.offscreen td):
TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/6409044
- 4:42 AM Changeset in webkit [77243] by
-
- 3 edits in trunk/Source/WebKit/efl
2011-02-01 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Antonio Gomes.
[EFL] Add an API to get proxy address.
https://bugs.webkit.org/show_bug.cgi?id=52990
Gets the proxy URI from network backend. This API returns a proxy URI
which is set up by ewk_settings_proxy_uri_set(). But, it only implements
this API for libsoup backend.
- ewk/ewk_settings.cpp: (ewk_settings_proxy_uri_get):
- ewk/ewk_settings.h:
- 4:42 AM Changeset in webkit [77242] by
-
- 9 edits in trunk/Source
2011-02-01 Darin Fisher <darin@chromium.org>
Reviewed by Eric Seidel.
Fix some Visual Studio compiler warnings.
https://bugs.webkit.org/show_bug.cgi?id=53476
- wtf/MathExtras.h: (clampToInteger): (clampToPositiveInteger):
- wtf/ThreadingWin.cpp: (WTF::absoluteTimeToWaitTimeoutInterval):
2011-02-01 Darin Fisher <darin@chromium.org>
Reviewed by Eric Seidel.
Fix some Visual Studio compiler warnings.
https://bugs.webkit.org/show_bug.cgi?id=53476
- src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas):
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::forms):
- src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::repaint):
- src/WebScrollbarImpl.cpp: (WebKit::WebScrollbarImpl::setValue):
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::doPixelReadbackToCanvas): (WebKit::WebViewImpl::setZoomLevel): (WebKit::WebViewImplScrollbarPaintInterface::paint):
- 4:16 AM Changeset in webkit [77241] by
-
- 5 edits2 deletes in trunk
2011-02-01 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Rollout r77230 which caused many layout tests
crashes on Chromium Debug bots.
Async event handlers should not fire within a modal dialog
https://bugs.webkit.org/show_bug.cgi?id=53202
- dom/Document.cpp: (WebCore::Document::Document):
- dom/EventQueue.cpp: (WebCore::EventQueue::EventQueue): (WebCore::EventQueue::enqueueEvent): (WebCore::EventQueue::pendingEventTimerFired):
- dom/EventQueue.h:
2011-02-01 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Rollout r77230 which caused many layout tests
crashes on Chromium Debug bots.
Async event handlers should not fire within a modal dialog
https://bugs.webkit.org/show_bug.cgi?id=53202
- fast/events/scroll-event-during-modal-dialog-expected.txt: Removed.
- fast/events/scroll-event-during-modal-dialog.html: Removed.
- 2:48 AM Changeset in webkit [77240] by
-
- 15 edits in trunk/Source/WebCore
LightElement changes does not require relayout.
https://bugs.webkit.org/show_bug.cgi?id=53232
Reviewed by Dirk Schulze.
When an attribute of a LightElement changes, it
send an update message to the lighting filters
to update its corresponding LightSource objects,
and repaint the filters.
Duplicated 'id' attributes removed from svg-filter-animation.svg.
Existing dynamic-update tests covers this feature.
5x speedup on manual-tests/svg-filter-animation.svg
- manual-tests/svg-filter-animation.svg:
- platform/graphics/filters/DistantLightSource.h:
- platform/graphics/filters/FEDiffuseLighting.cpp:
(WebCore::FEDiffuseLighting::setLightingColor):
(WebCore::FEDiffuseLighting::setSurfaceScale):
(WebCore::FEDiffuseLighting::setDiffuseConstant):
(WebCore::FEDiffuseLighting::setKernelUnitLengthX):
(WebCore::FEDiffuseLighting::setKernelUnitLengthY):
- platform/graphics/filters/FEDiffuseLighting.h:
- platform/graphics/filters/LightSource.cpp:
(WebCore::PointLightSource::setX):
(WebCore::PointLightSource::setY):
(WebCore::PointLightSource::setZ):
(WebCore::SpotLightSource::setX):
(WebCore::SpotLightSource::setY):
(WebCore::SpotLightSource::setZ):
(WebCore::SpotLightSource::setPointsAtX):
(WebCore::SpotLightSource::setPointsAtY):
(WebCore::SpotLightSource::setPointsAtZ):
(WebCore::SpotLightSource::setSpecularExponent):
(WebCore::SpotLightSource::setLimitingConeAngle):
(WebCore::DistantLightSource::setAzimuth):
(WebCore::DistantLightSource::setElevation):
(WebCore::LightSource::setAzimuth):
(WebCore::LightSource::setElevation):
(WebCore::LightSource::setX):
(WebCore::LightSource::setY):
(WebCore::LightSource::setZ):
(WebCore::LightSource::setPointsAtX):
(WebCore::LightSource::setPointsAtY):
(WebCore::LightSource::setPointsAtZ):
(WebCore::LightSource::setSpecularExponent):
(WebCore::LightSource::setLimitingConeAngle):
- platform/graphics/filters/LightSource.h:
- platform/graphics/filters/PointLightSource.h:
- platform/graphics/filters/SpotLightSource.h:
- rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::primitiveAttributeChanged):
- svg/SVGFEDiffuseLightingElement.cpp:
(WebCore::SVGFEDiffuseLightingElement::setFilterEffectAttribute):
(WebCore::SVGFEDiffuseLightingElement::lightElementAttributeChanged):
(WebCore::SVGFEDiffuseLightingElement::build):
(WebCore::SVGFEDiffuseLightingElement::findLightElement):
(WebCore::SVGFEDiffuseLightingElement::findLight):
- svg/SVGFEDiffuseLightingElement.h:
- svg/SVGFELightElement.cpp:
(WebCore::SVGFELightElement::svgAttributeChanged):
- svg/SVGFilterPrimitiveStandardAttributes.cpp:
(WebCore::SVGFilterPrimitiveStandardAttributes::setFilterEffectAttribute):
- svg/SVGFilterPrimitiveStandardAttributes.h:
- 2:41 AM Changeset in webkit [77239] by
-
- 11 edits2 adds in trunk/Source/WebCore
2011-02-01 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Dimitri Glazkov.
Bug 53289 - DOM: Move DocumentOrderedMap from Document into separate files
https://bugs.webkit.org/show_bug.cgi?id=53289
Moving the nested class DocumentOrderedMap from Document into separate files,
updating code where necessary.
No new tests. (refactoring)
- Android.mk:
- CMakeLists.txt:
- GNUMakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/Document.cpp: (WebCore::Document::getElementById): (WebCore::Document::getImageMap):
- dom/Document.h:
- dom/DocumentOrderedMap.cpp: Added. (WebCore::keyMatchesId): (WebCore::keyMatchesMapName): (WebCore::keyMatchesLowercasedMapName): (WebCore::DocumentOrderedMap::clear): (WebCore::DocumentOrderedMap::add): (WebCore::DocumentOrderedMap::remove): (WebCore::DocumentOrderedMap::get): (WebCore::DocumentOrderedMap::getElementById): (WebCore::DocumentOrderedMap::getElementByMapName): (WebCore::DocumentOrderedMap::getElementByLowercasedMapName):
- dom/DocumentOrderedMap.h: Added. (WebCore::DocumentOrderedMap::contains): (WebCore::DocumentOrderedMap::containsMultiple):
- dom/DOMAllInOne.cpp:
- 2:32 AM Changeset in webkit [77238] by
-
- 1 edit in trunk/ChangeLog
2010-01-28 Commit Queue <commit-queue@webkit.org>
Unreviewed. Test commit for commit-queue@webkit.org.
- 2:27 AM Changeset in webkit [77237] by
-
- 1 edit in trunk/ChangeLog
2010-01-28 Commit Queue <commit-queue@webkit.org>
Unreviewed. Test commit for commit-queue@webkit.org.
- 2:18 AM Changeset in webkit [77236] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-02-01 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
Chromium: remove WebIDBCallbacks::onSucces()
https://bugs.webkit.org/show_bug.cgi?id=53415
Remove un-used function.
- public/WebIDBCallbacks.h:
- 1:58 AM Changeset in webkit [77235] by
-
- 4 edits in trunk/Source
2011-02-01 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[Gtk] atk_text_set_caret_offset fails for list items
https://bugs.webkit.org/show_bug.cgi?id=53388
Allow using text ranges across list items.
- accessibility/gtk/AccessibilityObjectAtk.cpp: (WebCore::AccessibilityObject::allowsTextRanges): Add list items to the list of accessibility objects supporting text ranges.
2011-02-01 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[Gtk] atk_text_set_caret_offset fails for list items
https://bugs.webkit.org/show_bug.cgi?id=53388
Update unit test to check the fix for this bug.
- tests/testatk.c: (testWebkitAtkCaretOffsets): Ensure setting the caret in a list item through the AtkText interface is possible.
- 1:54 AM Changeset in webkit [77234] by
-
- 4 edits in trunk/Source
2011-02-01 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[GTK] character range extents is off when the end of a wrapped line is included
https://bugs.webkit.org/show_bug.cgi?id=53323
Fixed wrong calculation getting the range extents.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_get_range_extents): Removed '+1' since the requested interval shouldn't include the last character.
2011-02-01 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[GTK] character range extents is off when the end of a wrapped line is included
https://bugs.webkit.org/show_bug.cgi?id=53323
Update unit test to check the fix for this bug.
- tests/testatk.c: (testWebkitAtkGetExtents): Check that the extent for a full line are the same height than for a partial section of the same line.
- 1:49 AM Changeset in webkit [77233] by
-
- 4 edits in trunk/Source
2011-02-01 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Caret Offset is one off at the end of wrapped lines
https://bugs.webkit.org/show_bug.cgi?id=53300
Consider linebreaks as special cases.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (objectAndOffsetUnignored): In order to avoid getting wrong values when around linebreaks, we need to workaround this by explicitly avoiding those '\n' text nodes from affecting the result of calling to TextIterator:rangeLength().
2011-02-01 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Caret Offset is one off at the end of wrapped lines
https://bugs.webkit.org/show_bug.cgi?id=53300
Update unit test to check the fix for this bug.
- tests/testatk.c: (testWebkitAtkCaretOffsetsAndExtranousWhiteSpaces): Set and get the caret offset at the edge of the line.
- 1:37 AM Changeset in webkit [77232] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-02-01 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Fix Chromium Debug compilation broken by r77228.
[Chromium] Autofill should work with HTML5 form elements
https://bugs.webkit.org/show_bug.cgi?id=51809
- src/WebInputElement.cpp: (WebKit::toWebInputElement):
- 1:32 AM Changeset in webkit [77231] by
-
- 11 edits2 deletes in trunk/Source/WebCore
2011-02-01 Roland Steiner <rolandsteiner@chromium.org>
Unreviewed, rolling out r77229.
http://trac.webkit.org/changeset/77229
https://bugs.webkit.org/show_bug.cgi?id=53289
revert mysterious build breakage
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/DOMAllInOne.cpp:
- dom/Document.cpp: (WebCore::Document::DocumentOrderedMap::clear): (WebCore::Document::DocumentOrderedMap::add): (WebCore::Document::DocumentOrderedMap::remove): (WebCore::Document::DocumentOrderedMap::get): (WebCore::keyMatchesId): (WebCore::Document::getElementById): (WebCore::keyMatchesMapName): (WebCore::keyMatchesLowercasedMapName): (WebCore::Document::getImageMap):
- dom/Document.h: (WebCore::Document::DocumentOrderedMap::contains): (WebCore::Document::DocumentOrderedMap::containsMultiple):
- dom/DocumentOrderedMap.cpp: Removed.
- dom/DocumentOrderedMap.h: Removed.
- 1:20 AM Changeset in webkit [77230] by
-
- 5 edits2 adds in trunk
2011-02-01 Mihai Parparita <mihaip@chromium.org>
Reviewed by James Robinson.
Async event handlers should not fire within a modal dialog
https://bugs.webkit.org/show_bug.cgi?id=53202
Add tests for a scroll event triggered right before a modal dialog is
shown.
- fast/events/scroll-event-during-modal-dialog-expected.txt: Added.
- fast/events/scroll-event-during-modal-dialog.html: Added.
2011-02-01 Mihai Parparita <mihaip@chromium.org>
Reviewed by James Robinson.
Async event handlers should not fire within a modal dialog
https://bugs.webkit.org/show_bug.cgi?id=53202
Asychronous events that use EventQueue would currently fire while a
modal dialog (e.g. window.alert()) was up. Change EventQueue to use a
SuspendableTimer (which automatically gets suspended while dialogs are
up and in other cases where JS execution is not allowed).
Test: fast/events/scroll-event-during-modal-dialog.html
- dom/Document.cpp: (WebCore::Document::Document):
- dom/EventQueue.cpp: (WebCore::EventQueueTimer::EventQueueTimer): (WebCore::EventQueueTimer::fired): (WebCore::EventQueue::EventQueue): (WebCore::EventQueue::enqueueEvent): (WebCore::EventQueue::pendingEventTimerFired):
- dom/EventQueue.h: (WebCore::EventQueue::create):
- 1:11 AM Changeset in webkit [77229] by
-
- 11 edits2 adds in trunk/Source/WebCore
2011-01-28 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by NOBODY (OOPS!).
Bug 53289 - DOM: Move DocumentOrderedMap from Document into separate files
https://bugs.webkit.org/show_bug.cgi?id=53289
Moving the nested class DocumentOrderedMap from Document into separate files,
updating code where necessary.
No new tests. (refactoring)
- Android.mk:
- CMakeLists.txt:
- GNUMakefile.am
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/Document.cpp: (WebCore::Document::getElementById): (WebCore::Document::getImageMap):
- dom/Document.h:
- dom/DocumentOrderedMap.cpp: Added. (WebCore::keyMatchesId): (WebCore::keyMatchesMapName): (WebCore::keyMatchesLowercasedMapName): (WebCore::DocumentOrderedMap::clear): (WebCore::DocumentOrderedMap::add): (WebCore::DocumentOrderedMap::remove): (WebCore::DocumentOrderedMap::get): (WebCore::DocumentOrderedMap::getElementById): (WebCore::DocumentOrderedMap::getElementByMapName): (WebCore::DocumentOrderedMap::getElementByLowercasedMapName):
- dom/DocumentOrderedMap.h: Added. (WebCore::DocumentOrderedMap::contains): (WebCore::DocumentOrderedMap::containsMultiple):
- dom/DOMAllInOne.cpp:
- 12:54 AM Changeset in webkit [77228] by
-
- 9 edits in trunk/Source
2011-02-01 Naoki Takano <takano.naoki@gmail.com>
Reviewed by Darin Fisher.
[Chromium] Autofill should work with HTML5 form elements
https://bugs.webkit.org/show_bug.cgi?id=51809
http://crbug.com/65654
No new tests, because this fix is for Chromium project and hard to test only in WebKit project.
- html/InputType.h: Insert comment for canSetSuggestedValue().
- html/TextFieldInputType.cpp: (WebCore::TextFieldInputType::canSetSuggestedValue): Implemented to return always true for that all text filed inputs can be completed.
- html/TextFieldInputType.h: Declare canSetSuggestedValue().
- html/TextInputType.cpp: Delete canSetSuggestedValue() not to return true anymore.
- html/TextInputType.h: Delete canSetSuggestedValue() not to return true anymore.
2011-02-01 Naoki Takano <takano.naoki@gmail.com>
Reviewed by Darin Fisher.
[Chromium] Autofill should work with HTML5 form elements
https://bugs.webkit.org/show_bug.cgi?id=51809
http://crbug.com/65654
No new tests, because this fix is for Chromium project and hard to test only in WebKit project.
- public/WebInputElement.h: Added toWebInputElement() declarations and implemented const version of toWebInputElement().
- src/WebInputElement.cpp: (WebKit::WebInputElement::toWebInputElement): Implemented a convert function to cast no-const WebElement* to no-const WebInputElement*. Because Chrome needs safe cast for autofill completion.
- 12:32 AM Changeset in webkit [77227] by
-
- 5 edits in branches/safari-533.20-branch
Merge r74788.
- 12:32 AM Changeset in webkit [77226] by
-
- 3 edits3 adds in branches/safari-533.20-branch
Merge r68307.
- 12:22 AM Changeset in webkit [77225] by
-
- 6 edits4 adds in branches/safari-533.20-branch
- 12:05 AM Changeset in webkit [77224] by
-
- 5 edits in trunk
REGRESSION (r65062): Safari loops forever under WebCore::plainTextToMallocAllocatedBuffer()
https://bugs.webkit.org/show_bug.cgi?id=53272
Reviewed by Dan Bernstein.
Source/WebCore:
- editing/TextIterator.cpp:
(WebCore::TextIterator::handleTextBox): Pass the appropriate renderer to emitText().
LayoutTests:
- fast/dom/inner-text-first-letter.html:
- Add a new test case reproducing the bug.
- Remove unnecessary text output.
- fast/dom/inner-text-first-letter-expected.txt:
