⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 5, 2011:

10:05 PM Changeset in webkit [77762] by mrowe@apple.com
  • 5 edits in branches/safari-533.20-branch

Versioning.

10:05 PM Changeset in webkit [77761] by mrowe@apple.com
  • 1 copy in tags/Safari-533.20.25

New tag.

10:00 PM Changeset in webkit [77760] by mrowe@apple.com
  • 1 edit in branches/safari-533.20-branch/WebKit/win/WebCoreSupport/WebContextMenuClient.cpp

Build fix.

9:24 PM Changeset in webkit [77759] by mjs@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-05 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Dan Bernstein.

REGRESSION: New drawing area is causing some WebProcess crashes in layout tests
​https://bugs.webkit.org/show_bug.cgi?id=53865
<rdar://problem/8963148>


  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode): Handle the case where this is called repeatedly without exiting accelerated composting mode first. (WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode): Handle the case of being called more than once.
9:05 PM Changeset in webkit [77758] by Dimitri Glazkov
  • 1 edit
    2 adds in trunk/LayoutTests

2011-02-05 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Add baselines for the test added in r77690.

  • platform/chromium-mac/media/video-frame-accurate-seek-expected.checksum: Added.
  • platform/chromium-mac/media/video-frame-accurate-seek-expected.png: Added.
6:58 PM Changeset in webkit [77757] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-02-05 Dimitri Glazkov <Dimitri Glazkov>

Remove passing canvas tests from expectations.

  • platform/chromium/test_expectations.txt: Removed passing tests.
6:44 PM Changeset in webkit [77756] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-02-05 Dimitri Glazkov <Dimitri Glazkov>

Remove passing tests whose results match mac/ and mac-leopard.

  • platform/chromium/test_expectations.txt: Removed passing tests.
6:07 PM Changeset in webkit [77755] by abarth@webkit.org
  • 8 edits in trunk/Source/WebCore

2011-02-05 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove unused parameter related to XSSAuditor
​https://bugs.webkit.org/show_bug.cgi?id=53862

  • WebCore.exp.in:
  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeScript): (WebCore::ScriptController::executeIfJavaScriptURL):
  • bindings/ScriptControllerBase.h:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld): (WebCore::ScriptController::evaluate): (WebCore::ScriptController::executeScriptInWorld):
  • bindings/js/ScriptController.h:
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluate):
  • bindings/v8/ScriptController.h:
4:54 PM Changeset in webkit [77754] by Dimitri Glazkov
  • 1 edit
    125 deletes in trunk/LayoutTests

2011-02-05 Dimitri Glazkov <Dimitri Glazkov>

Remove results for failing SVG tests. I will add the new ones after the
bots tell me which ones aren't matching mac/ or mac-leopard/.

3:02 PM Changeset in webkit [77753] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-05 Adam Barth <​abarth@webkit.org>

Fix Qt build.

  • WebCore.pro:
2:55 PM Changeset in webkit [77752] by abarth@webkit.org
  • 20 edits
    2 deletes in trunk/Source/WebCore

2011-02-05 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Delete XSSAuditor
​https://bugs.webkit.org/show_bug.cgi?id=53859

The job of the XSSAuditor is now done by the XSSFilter. In the future,
we might rename XSSFilter to XSSAuditor.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):
  • bindings/ScriptControllerBase.h:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::evaluateInWorld):
  • bindings/js/ScriptController.h:
  • bindings/js/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::evaluate):
  • bindings/v8/ScriptController.h:
  • bindings/v8/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
  • dom/Document.cpp: (WebCore::Document::implicitOpen): (WebCore::Document::processBaseElement):
  • dom/ScriptableDocumentParser.cpp: (WebCore::ScriptableDocumentParser::ScriptableDocumentParser):
  • dom/ScriptableDocumentParser.h:
  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::shouldLoadExternalScriptFromSrc):
  • loader/SubframeLoader.cpp: (WebCore::SubframeLoader::requestObject): (WebCore::SubframeLoader::loadMediaPlayerProxyPlugin):
  • page/XSSAuditor.cpp: Removed.
  • page/XSSAuditor.h: Removed.
2:28 PM Changeset in webkit [77751] by andersca@apple.com
  • 18 edits in trunk/Source

2011-02-05 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler.

Need a way to resize and scroll the page at the same time
​https://bugs.webkit.org/show_bug.cgi?id=53814
<rdar://problem/8498008>

Export a function needed by WebKit2.

  • WebCore.exp.in:

2011-02-05 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler.

Need a way to resize and scroll the page at the same time
​https://bugs.webkit.org/show_bug.cgi?id=53814
<rdar://problem/8498008>

Add -[WKView setFrame:andScrollBy:].

  • UIProcess/API/mac/WKView.h:
  • UIProcess/API/mac/WKView.mm: (-[WKView setFrame:andScrollBy:]): Stash away the scroll offset and call setFrame:.

(-[WKView _switchToDrawingAreaTypeIfNecessary:DrawingAreaInfo::]):
(-[WKView _setDrawingAreaSize:]):

  • UIProcess/API/qt/qwkpage.cpp: (QWKPage::setViewportSize): DrawingAreaProxy::setSize now takes a scroll offset.
  • UIProcess/DrawingAreaProxy.cpp: (WebKit::DrawingAreaProxy::setSize): This now takes a scroll offset and stores it in m_scrollOffset.
  • UIProcess/DrawingAreaProxy.h:
  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::sendSetSize): Send along the scroll offset and set it back to zero.
  • UIProcess/LayerBackedDrawingAreaProxy.cpp: (WebKit::LayerBackedDrawingAreaProxy::didSetSize):
  • UIProcess/TiledDrawingAreaProxy.cpp: (WebKit::TiledDrawingAreaProxy::didSetSize):
  • UIProcess/win/WebView.cpp: (WebKit::WebView::onSizeEvent): (WebKit::WebView::switchToDrawingAreaTypeIfNecessary): DrawingAreaProxy::setSize now takes a scroll offset.


  • WebProcess/WebPage/DrawingArea.h: (WebKit::DrawingArea::setSize): Add a scrollOffset parameter.
  • WebProcess/WebPage/DrawingArea.messages.in: Add a scroll offset parameter to the SetSize message.
  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::setSize): Call WebPage::scrollMainFrameIfNotAtMaxScrollPosition.
  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::scrollMainFrameIfNotAtMaxScrollPosition): Compute a scroll offset and call setScrollPosition on the main frame view.
12:34 PM Changeset in webkit [77750] by Patrick Gansterer
  • 6 edits in trunk/Source/WebCore

2011-02-05 Patrick Gansterer <Patrick Gansterer>

Reviewed by Alexey Proskuryakov.

Use Document::encoding() instead of DocumentWriter::encoding()
​https://bugs.webkit.org/show_bug.cgi?id=53398

This change makes the code more readable, when a subresource
inherits the character encoding of the document.

  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet):
  • dom/ScriptElement.cpp: (WebCore::ScriptElement::scriptCharset):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
  • loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::requestPreload):
  • platform/network/FormDataBuilder.cpp: (WebCore::FormDataBuilder::encodingFromAcceptCharset):
12:30 PM Changeset in webkit [77749] by Patrick Gansterer
  • 7 edits
    1 add in trunk/LayoutTests

2011-02-05 Patrick Gansterer <Patrick Gansterer>

Reviewed by Alexey Proskuryakov.

Add addition test for inherited encoding
​https://bugs.webkit.org/show_bug.cgi?id=53398

Check if the right encoding is used, after document.charset was set.

  • fast/dom/Document/document-charset.html: Added doctype to make it pass in IE9 out of the box.
  • fast/encoding/css-charset-default-expected.txt:
  • fast/encoding/css-charset-default.xhtml:
  • fast/encoding/external-script-charset-expected.txt:
  • fast/encoding/external-script-charset-koi-8.js: Added.
  • fast/encoding/external-script-charset.js:
  • fast/encoding/external-script-charset.xhtml:
12:21 PM Changeset in webkit [77748] by abarth@webkit.org
  • 6 edits
    1 add in trunk/Source/WebCore

2011-02-05 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Introduce URLString to represent a canonicalized URL represented by a string
​https://bugs.webkit.org/show_bug.cgi?id=53847

Instead of using String all over the codebase to represent a URL,
instead we should have a type to represent a canonicalized URL in the
form of a string. This patch introduces that type.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/KURL.cpp: (WebCore::KURL::KURL):
  • platform/KURL.h: (WebCore::KURL::urlString):
10:26 AM Changeset in webkit [77747] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2011-02-05 Martin Robinson <​mrobinson@igalia.com>

JSC::Bindings m_rootObject->isValid() assert fails when running layout tests
​https://bugs.webkit.org/show_bug.cgi?id=53716

  • platform/gtk/Skipped: Skip a test hitting this assertion.
9:55 AM Changeset in webkit [77746] by robert@webkit.org
  • 4 edits in trunk

2011-02-05 Robert Hogan <​robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Style widgets not rendering
​https://bugs.webkit.org/show_bug.cgi?id=53849

  • platform/qt/Skipped: Unskip plugins/application-plugins-plugins-disabled.html

2011-02-05 Robert Hogan <​robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Style widgets not rendering
​https://bugs.webkit.org/show_bug.cgi?id=53849

  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::hasValidClassId): x-qt-styled-widget is a valid class id too
9:19 AM Changeset in webkit [77745] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-02-05 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r77720.
​http://trac.webkit.org/changeset/77720
​https://bugs.webkit.org/show_bug.cgi?id=53854

"Broke nrwt on Chromium win." (Requested by dglazkov|away on
#webkit).

  • Scripts/webkitpy/common/system/executive.py:
5:00 AM Changeset in webkit [77744] by Nikolas Zimmermann
  • 168 edits in trunk/LayoutTests

2011-02-04 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

small text which is scaled to be large renders pixelated
​https://bugs.webkit.org/show_bug.cgi?id=12448

Update Snow Leopard SVG pixel test baseline after r77485.

  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png:

...

4:48 AM Changeset in webkit [77743] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2011-02-05 Eric Seidel <​eric@webkit.org>

Unreviewed.

Safari should lowercase schemes in cannonicalized urls to match every other browser
​https://bugs.webkit.org/show_bug.cgi?id=53848

Checkin results I forgot to update in my previous commit. All progressions.

  • fast/dom/anchor-origin-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:
3:52 AM Changeset in webkit [77742] by jochen@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-02-05 Jochen Eisinger <​jochen@chromium.org>

Reviewed by Adam Barth.

Add ContentSecurityPolicy object to Document and pass the X-WebKit-CSP header from the MainResourceLoader.
​https://bugs.webkit.org/show_bug.cgi?id=53685

  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.h: (WebCore::Document::contentSecurityPolicy):
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didReceiveResponse):
  • page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::didReceiveHeader):
  • page/ContentSecurityPolicy.h:
3:43 AM Changeset in webkit [77741] by eric@webkit.org
  • 8 edits in trunk

2011-02-05 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Safari should lowercase schemes in cannonicalized urls to match every other browser
​https://bugs.webkit.org/show_bug.cgi?id=53848

Update our results now that we pass more tests.

  • fast/url/file-expected.txt:
  • fast/url/file-http-base-expected.txt:
  • fast/url/path-url-expected.txt:
  • fast/url/relative-expected.txt:
  • fast/url/scheme-expected.txt:

2011-02-05 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Safari should lowercase schemes in cannonicalized urls to match every other browser
​https://bugs.webkit.org/show_bug.cgi?id=53848

We're clearly the odd man out here. See results from every browser at:
​https://github.com/abarth/url-spec/blob/master/tests/gurl-results/by-browser.txt

  • platform/KURL.cpp: (WebCore::KURL::parse):
    • Just lowercase the scheme when copying.
3:23 AM Changeset in webkit [77740] by Antti Koivisto
  • 4 edits in trunk/Source/WebCore

Optimize matching of descendant selectors
​https://bugs.webkit.org/show_bug.cgi?id=49876
<rdar://problem/8772822>

Reviewed by Dave Hyatt.

During style recalculation, maintain a filter of tags, ids and classes seen in ancestor elements.
Use the filter to quickly reject descendant and child selectors when doing style matching.

This speeds up style recalculations 3-6x on many major web sites.

  • css/CSSStyleSelector.cpp:

(WebCore::RuleData::RuleData):
(WebCore::RuleData::descendantSelectorIdentifierHashes):
(WebCore::collectElementIdentifiers):
(WebCore::CSSStyleSelector::pushParent):
(WebCore::CSSStyleSelector::popParent):
(WebCore::CSSStyleSelector::fastRejectSelector):
(WebCore::CSSStyleSelector::matchRulesForList):
(WebCore::RuleData::collectDescendantSelectorIdentifierHashes):

  • css/CSSStyleSelector.h:

(WebCore::CSSStyleSelector::ParentStackFrame::ParentStackFrame):

  • dom/Element.cpp:

(WebCore::StyleSelectorParentPusher::StyleSelectorParentPusher):
(WebCore::StyleSelectorParentPusher::push):
(WebCore::StyleSelectorParentPusher::~StyleSelectorParentPusher):
(WebCore::Element::attach):
(WebCore::Element::recalcStyle):

3:12 AM Changeset in webkit [77739] by eric@webkit.org
  • 1 edit
    3 adds in trunk/PerformanceTests

2011-02-05 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add performance tests for URL parsing
​https://bugs.webkit.org/show_bug.cgi?id=53845

The final-url-en URL corpus is from:
​http://corpus.leeds.ac.uk/internet.html

There are also other language corpuses which we may want to use in the future.

The usage instructions were as follows:
"URL lists and other resources: you can freely use them in your research
provided that you supply a link to this website: ​http://corpus.leeds.ac.uk/."
Done.

  • Parser/simple-url.html: Added. On my machine: Firefox: 255ms TOT WebKit: 378ms Chrome: 286ms Opera: 2830ms (no, that is not a typo)
  • Parser/url-parser.html: Added. Firefox: 381ms TOT WebKit: 216ms Chrome: 131ms Opera: 1383ms (again, not a typo)
  • Parser/resources/final-url-en: Added.
2:37 AM Changeset in webkit [77738] by Nate Chapin
  • 5 edits in trunk/Source/WebCore

2011-02-05 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Refactor: NotificationCenter shouldn't hold its own copy of the ScriptExecutionContext*
when it inherits one from ActiveDOMObject.
​https://bugs.webkit.org/show_bug.cgi?id=53815

  • bindings/js/JSDesktopNotificationsCustom.cpp: (WebCore::JSNotificationCenter::requestPermission):
  • bindings/v8/custom/V8NotificationCenterCustom.cpp: (WebCore::V8NotificationCenter::requestPermissionCallback):
  • notifications/NotificationCenter.cpp: (WebCore::NotificationCenter::NotificationCenter): (WebCore::NotificationCenter::checkPermission): (WebCore::NotificationCenter::requestPermission): (WebCore::NotificationCenter::disconnectFrame):
  • notifications/NotificationCenter.h: (WebCore::NotificationCenter::createHTMLNotification): (WebCore::NotificationCenter::createNotification):
12:02 AM Changeset in webkit [77737] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

2011-02-05 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r77725.
​http://trac.webkit.org/changeset/77725
​https://bugs.webkit.org/show_bug.cgi?id=53844

It broke Qt minimal build (Requested by Ossy_ on #webkit).

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::createChrome):
  • QtTestBrowser/launcherwindow.h: (WindowOptions::WindowOptions):
  • QtTestBrowser/main.cpp: (LauncherApplication::handleUserOptions):

Feb 4, 2011:

11:38 PM Changeset in webkit [77736] by mihaip@chromium.org
  • 6 edits
    2 copies in branches/chromium/648

Merge 77705 - 2011-02-04 Charlie Reis <​creis@chromium.org>

Reviewed by Mihai Parparita.

Crash in WebCore::HistoryController::itemsAreClones
​https://bugs.webkit.org/show_bug.cgi?id=52819

Tests that navigating back and forward between hash items works.

  • fast/history/history-back-forward-within-subframe-hash.html: Added.
  • fast/history/history-back-forward-within-subframe-hash-expected.txt: Added.

2011-02-04 Charlie Reis <​creis@chromium.org>

Reviewed by Mihai Parparita.

Crash in WebCore::HistoryController::itemsAreClones
​https://bugs.webkit.org/show_bug.cgi?id=52819

Avoids deleting the current HistoryItem while it is still in use.
Ensures that provisional items are committed for same document navigations.
Ensures that error pages are committed on back/forward navigations.
Also removes unneeded sanity checks used for diagnosing the problem.

  • loader/HistoryController.cpp:
  • loader/HistoryController.h:

2011-02-04 Charlie Reis <​creis@chromium.org>

Reviewed by Mihai Parparita.

Crash in WebCore::HistoryController::itemsAreClones
​https://bugs.webkit.org/show_bug.cgi?id=52819

Removes unneeded sanity checks used for diagnosing a memory error.

  • src/WebFrameImpl.cpp:

BUG=70315
TBR=​creis@webkit.org
Review URL: ​http://codereview.chromium.org/6250180

11:35 PM Changeset in webkit [77735] by jer.noble@apple.com
  • 2 edits in trunk/LayoutTests

2011-02-04 Jer Noble <​jer.noble@apple.com>

Adding test to Qt Skipped list.

[Qt] media/video-frame-accurate-seek.html fails
​https://bugs.webkit.org/show_bug.cgi?id=53843

  • platform/qt/Skipped:
10:25 PM Changeset in webkit [77734] by joone.hur@collabora.co.uk
  • 2 edits in trunk/Source/WebKit/gtk

2011-02-04 Joone Hur <​joone.hur@collabora.co.uk>

Unreviewed, Fix compilation warning.

Constructor initialization list should follow the declaration order.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::FrameLoaderClient): m_hasRepresentation is moved to the last position in the initialization list.
10:24 PM Changeset in webkit [77733] by mrowe@apple.com
  • 20 edits in tags/Safari-534.18

Revert r77588 to work around <rdar://problem/8963096>.

10:03 PM Changeset in webkit [77732] by mrowe@apple.com
  • 5 edits in trunk/Source

Versioning.

10:01 PM Changeset in webkit [77731] by mrowe@apple.com
  • 1 copy in tags/Safari-534.18

New tag.

9:17 PM Changeset in webkit [77730] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

2011-02-04 Adam Barth <​abarth@webkit.org>

Reviewed by Maciej Stachowiak.

Crash in WebCore::TextEncoding::decode below XSSFilter::init
​https://bugs.webkit.org/show_bug.cgi?id=53837

Test that we can successfully execute a JavaScript URL when it isn't
blocked by the filter.

  • http/tests/security/xssAuditor/non-block-javascript-url-frame-expected.txt: Added.
  • http/tests/security/xssAuditor/non-block-javascript-url-frame.html: Added.

2011-02-04 Adam Barth <​abarth@webkit.org>

Reviewed by Maciej Stachowiak.

Crash in WebCore::TextEncoding::decode below XSSFilter::init
​https://bugs.webkit.org/show_bug.cgi?id=53837

Add missing null check.

Test: http/tests/security/xssAuditor/non-block-javascript-url-frame.html

  • html/parser/XSSFilter.cpp: (WebCore::XSSFilter::init):
8:56 PM Changeset in webkit [77729] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

2011-02-04 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Crashes in ShadowBlur via WebKit2 FindController
​https://bugs.webkit.org/show_bug.cgi?id=53830

Fix a crash cause by re-entering ShadowBlur, and add assertions to
detect when it happens.

The re-entrancy occurred when drawRectShadowWithTiling() filled
the interior of the shadow with fillRect() on the context
which still had the shadow state set. This would make another ShadowBlur
on the stack and call into the code again, potentially blowing away
the image buffer.

Fix by turning off shadows in the destination context while we're
drawing the tiled shadow. The non-tiled code path already did this.

Not testable because CSS shadows clip out the inside of the rect
being shadowed, and SVG uses fillPath, even for rects.

  • platform/graphics/ShadowBlur.cpp: (WebCore::ScratchBuffer::ScratchBuffer): (WebCore::ScratchBuffer::getScratchBuffer): (WebCore::ScratchBuffer::scheduleScratchBufferPurge): (WebCore::ShadowBlur::ShadowBlur): (WebCore::ShadowBlur::drawRectShadowWithTiling):
8:54 PM Changeset in webkit [77728] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2011-02-04 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Adam Barth.

Skip a new test that uses EventSender
​https://bugs.webkit.org/show_bug.cgi?id=53841

  • platform/mac-wk2/Skipped:
8:17 PM Changeset in webkit [77727] by commit-queue@webkit.org
  • 4 edits in trunk

2011-02-04 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Adam Barth.

[GTK] plugins/plugin-document-back-forward.html fails
​https://bugs.webkit.org/show_bug.cgi?id=53833

  • platform/gtk/Skipped: Unskip test which is now passing.

2011-02-04 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Adam Barth.

[GTK] plugins/plugin-document-back-forward.html fails
​https://bugs.webkit.org/show_bug.cgi?id=53833

Add the new "alert on load" functionality for the Unix version of the
test plugin. This functionality was originally introduced in r77706.

  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_instance): Add new plugin fuctionality.
7:37 PM Changeset in webkit [77726] by Martin Robinson
  • 17 edits in trunk

2011-02-04 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

Update expected results reflecting the change to search icon rendering.

  • platform/gtk/fast/css/input-search-padding-expected.checksum:
  • platform/gtk/fast/css/input-search-padding-expected.png:
  • platform/gtk/fast/css/input-search-padding-expected.txt:
  • platform/gtk/fast/forms/search-styled-expected.checksum:
  • platform/gtk/fast/forms/search-styled-expected.png:
  • platform/gtk/fast/forms/search-styled-expected.txt:
  • platform/gtk/fast/forms/search-vertical-alignment-expected.checksum:
  • platform/gtk/fast/forms/search-vertical-alignment-expected.png:
  • platform/gtk/fast/forms/search-zoomed-expected.checksum:
  • platform/gtk/fast/forms/search-zoomed-expected.png:
  • platform/gtk/fast/forms/search-zoomed-expected.txt:
  • platform/gtk/fast/forms/searchfield-heights-expected.checksum:
  • platform/gtk/fast/forms/searchfield-heights-expected.png:
  • platform/gtk/fast/forms/searchfield-heights-expected.txt:

2011-02-04 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Don't use a fixed size for search field icons
​https://bugs.webkit.org/show_bug.cgi?id=50624

Use the parent input content box to make sure the icon fits in the
search field, scaling it down when needed.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::paintGdkPixbuf): (WebCore::getIconSizeForPixelSize): (WebCore::adjustSearchFieldIconStyle): (WebCore::RenderThemeGtk::adjustSearchFieldResultsDecorationStyle): (WebCore::centerRectVerticallyInParentInputElement): (WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration): (WebCore::RenderThemeGtk::adjustSearchFieldCancelButtonStyle): (WebCore::RenderThemeGtk::paintSearchFieldCancelButton): (WebCore::RenderThemeGtk::paintCapsLockIndicator): (WebCore::RenderThemeGtk::paintMediaButton):
7:11 PM Changeset in webkit [77725] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

2011-02-04 Kundu Suchismita <​suchi.kundu@nokia.com>

Reviewed by Andreas Kling.

Local Storage settings can be enable/disable from "Develop" menu
​https://bugs.webkit.org/show_bug.cgi?id=52296

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::createChrome): (LauncherWindow::toggleLocalStorage): (LauncherWindow::toggleOfflineStorageDatabase): (LauncherWindow::toggleOfflineWebApplicationCache): (LauncherWindow::setOfflineStorageDefaultQuota):
  • QtTestBrowser/launcherwindow.h: (WindowOptions::WindowOptions):
  • QtTestBrowser/main.cpp: (LauncherApplication::handleUserOptions):
7:05 PM Changeset in webkit [77724] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

2011-02-04 Hironori Bono <​hbono@chromium.org>

Reviewed by Adam Barth.

[chromium] JPEG corruption
​https://bugs.webkit.org/show_bug.cgi?id=53250

This change adds a new script test that we can render a CMYK JPEG with a
color profile correctly, i.e. we can render it without color corruption.

  • fast/images/cmyk-jpeg-with-color-profile-expected.txt: Added.
  • fast/images/cmyk-jpeg-with-color-profile.html: Added.
  • fast/images/resources/cmyk-jpeg.jpg: Added.
  • fast/images/script-tests/cmyk-jpeg-with-color-profile.js: Added. (image.onload):

2011-02-04 Hironori Bono <​hbono@chromium.org>

Reviewed by Adam Barth.

[chromium] JPEG corruption
​https://bugs.webkit.org/show_bug.cgi?id=53250

Same as gray-scale JPEGs, we convert the colors of CMYK JPEGs with color
profiles from CMYK to RGB twice and it causes color corruption. This
change suppresses the color profiles for CMYK JPEGs same as gray-scale
ones.

Test: fast/images/cmyk-jpeg-with-color-profile.html

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageReader::decode):
6:57 PM Changeset in webkit [77723] by Martin Robinson
  • 254 edits
    15 adds in trunk/LayoutTests

2011-02-04 Martin Robinson <​mrobinson@igalia.com>

Update pixel results for the fast/forms directory in preparation for landing
fixes to input type=search icon sizing. Also add some missing results. These
results are out of date because of changes to font hinting some time ago.

  • platform/gtk/fast/forms/
  • platform/gtk/fast/forms/input-placeholder-visibility-1-expected.checksum: Added.
  • platform/gtk/fast/forms/input-placeholder-visibility-1-expected.png: Added.
  • platform/gtk/fast/forms/input-placeholder-visibility-1-expected.txt: Added.
  • platform/gtk/fast/forms/input-placeholder-visibility-2-expected.checksum: Added.
  • platform/gtk/fast/forms/input-placeholder-visibility-2-expected.png: Added.
  • platform/gtk/fast/forms/input-placeholder-visibility-2-expected.txt: Added.
  • platform/gtk/fast/forms/input-placeholder-visibility-3-expected.checksum: Added.
  • platform/gtk/fast/forms/input-placeholder-visibility-3-expected.png: Added.
  • platform/gtk/fast/forms/input-placeholder-visibility-3-expected.txt: Added.
  • platform/gtk/fast/forms/textarea-placeholder-visibility-1-expected.checksum: Added.
  • platform/gtk/fast/forms/textarea-placeholder-visibility-1-expected.png: Added.
  • platform/gtk/fast/forms/textarea-placeholder-visibility-1-expected.txt: Added.
  • platform/gtk/fast/forms/textarea-placeholder-visibility-2-expected.checksum: Added.
  • platform/gtk/fast/forms/textarea-placeholder-visibility-2-expected.png: Added.
  • platform/gtk/fast/forms/textarea-placeholder-visibility-2-expected.txt: Added.
6:55 PM Changeset in webkit [77722] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-04 Adam Barth <​abarth@webkit.org>

[Windows 7 Release Tests] plugins/plugin-document-back-forward.html failing since introduction in r77706
​https://bugs.webkit.org/show_bug.cgi?id=53831

Stop dumping the child frames because that's not needed for this test
and cause extra output on Windows.

  • plugins/plugin-document-back-forward.html:
6:50 PM Changeset in webkit [77721] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-04 Adam Barth <​abarth@webkit.org>

[GTK] plugins/plugin-document-back-forward.html fails
​https://bugs.webkit.org/show_bug.cgi?id=53833

Add plugins/plugin-document-back-forward.html to skipped list while we
investigate the issue.

  • platform/gtk/Skipped:
6:39 PM Changeset in webkit [77720] by tony@chromium.org
  • 2 edits in trunk/Tools

2011-02-04 Tony Chang <​tony@chromium.org>

Reviewed by Eric Seidel.

get test-webkitpy running on win32 python
​https://bugs.webkit.org/show_bug.cgi?id=53822

The test harness crashes with a WindowsError because it can't find
'svn' when using subprocess.Popen. This gets us past the error
so we can see the failing tests on the Chromium Win Release Tests
bot.

  • Scripts/webkitpy/common/system/executive.py:
6:37 PM Changeset in webkit [77719] by mdelaney@apple.com
  • 1 edit
    51 moves
    3 adds in trunk/LayoutTests

2011-02-04 Matthew Delaney <​mdelaney@apple.com>

Reviewed by Dan Bernstein.

Move canvas layout test expectations into more appropriate locations
​https://bugs.webkit.org/show_bug.cgi?id=53145

  • platform/mac-snowleopard/canvas/philip/tests/2d.drawImage.broken-expected.txt: Removed.
  • ...
  • platform/mac-snowleopard/canvas/philip/tests/type.prototype-expected.txt: Removed.
  • platform/mac/canvas: Added.
  • platform/mac/canvas/philip: Added.
  • platform/mac/canvas/philip/tests: Added.
  • platform/mac/canvas/philip/tests/2d.drawImage.broken-expected.txt: Copied from platform/mac-snowleopard/canvas/philip/tests/2d.drawImage.broken-expected.txt.
  • ...
  • platform/mac/canvas/philip/tests/type.prototype-expected.txt: Copied from platform/mac-snowleopard/canvas/philip/tests/type.prototype-expected.txt.
6:30 PM Changeset in webkit [77718] by jberlin@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

[Windows 7 Release Tests] plugins/plugin-document-back-forward.html failing since
introduction in r77706.
​https://bugs.webkit.org/show_bug.cgi?id=53831

Unreviewed. Add expected (failing?) results to get the Windows 7 Release Test bots green.

  • platform/win/plugins/plugin-document-back-forward-expected.txt: Added.
6:26 PM Changeset in webkit [77717] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2011-02-04 Martin Robinson <​mrobinson@igalia.com>

Unskip some tests which should now be passing.

  • platform/gtk/Skipped: Unskip tests.
6:19 PM Changeset in webkit [77716] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-04 Xiyuan Xia <​xiyuan@chromium.org>

Reviewed by Tony Chang.

[Chromium] Option text in select popup does not align with menulist button text
​https://bugs.webkit.org/show_bug.cgi?id=53632

This makes clientPaddingLeft and clientPaddingRight return
the additional m_innerBlock's padding so that the popup item text
aligns with the menulist button text.

  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::clientPaddingLeft): (WebCore::RenderMenuList::clientPaddingRight):
6:18 PM Changeset in webkit [77715] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

REGRESSION: Horizontal scrollbar thumbs leave artifacts over page content when scrolling vertically
<rdar://problem/8962457>

Reviewed by Sam Weinig and Beth Dakin.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::scrollContents):
Subtract scrollbars from the scroll view rect if overlay scrollers are enabled.

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::setScrollOffsetFromAnimation):
Make sure to invalidate both scrollbars if overlay scrollers are enabled.

6:11 PM Changeset in webkit [77714] by Martin Robinson
  • 4 edits in trunk

2011-02-04 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] WebKitWebFrame can return a stale frame name when calling webkit_web_frame_get_name
​https://bugs.webkit.org/show_bug.cgi?id=53797

  • platform/gtk/Skipped: Unskip a test which is now passing.

2011-02-04 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] WebKitWebFrame can return a stale frame name when calling webkit_web_frame_get_name
​https://bugs.webkit.org/show_bug.cgi?id=53797

When the frame name changes between different calls to webkit_web_frame_get_name
on the same frame, return the new frame name instead of the one valid during the
previous call.

  • webkit/webkitwebframe.cpp: (webkit_web_frame_init): Initialize the frame name to 0. (webkit_web_frame_get_name): Check the current frame name first before returning the cached value.
6:04 PM Changeset in webkit [77713] by bweinstein@apple.com
  • 2 edits in trunk/Source/WebKit2

WebKit2: Crash when InjectedBundlePageLoaderClient::willSendRequestForFrame returns a null WKURLRequestRef
​https://bugs.webkit.org/show_bug.cgi?id=53829

Reviewed by Maciej Stachowiak.

Store the result of m_client.willSendRequestForFrame in a RefPtr, and null check it before
calling resourceRequest() on it.

  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::willSendRequestForFrame):

5:58 PM Changeset in webkit [77712] by Martin Robinson
  • 7 edits
    1 add in trunk/LayoutTests

2011-02-04 Martin Robinson <​mrobinson@igalia.com>

Rebaseline a few tests after r77665 and add a GTK-specific baseline
after r77690.

  • platform/gtk/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:
  • platform/gtk/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt:
  • platform/gtk/fast/blockflow/japanese-ruby-vertical-lr-expected.txt:
  • platform/gtk/fast/blockflow/japanese-ruby-vertical-rl-expected.txt:
  • platform/gtk/fast/ruby/nested-ruby-expected.txt:
  • platform/gtk/fast/text/emphasis-avoid-ruby-expected.txt:
  • platform/gtk/media/video-frame-accurate-seek-expected.txt: Added.
5:45 PM Changeset in webkit [77711] by jberlin@webkit.org
  • 16 edits in trunk/LayoutTests

[Windows 7 Release Tests] 5 ruby tests failing on Windows after r77665
​https://bugs.webkit.org/show_bug.cgi?id=53820

Unreviewed. Landing expected results that are probably correct (given that the change in
77665 was to make the default ruby text size smaller by default).

  • platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum:
  • platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
  • platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:
  • platform/win/fast/blockflow/japanese-ruby-horizontal-bt-expected.checksum:
  • platform/win/fast/blockflow/japanese-ruby-horizontal-bt-expected.png:
  • platform/win/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt:
  • platform/win/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum:
  • platform/win/fast/blockflow/japanese-ruby-vertical-lr-expected.png:
  • platform/win/fast/blockflow/japanese-ruby-vertical-lr-expected.txt:
  • platform/win/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum:
  • platform/win/fast/blockflow/japanese-ruby-vertical-rl-expected.png:
  • platform/win/fast/blockflow/japanese-ruby-vertical-rl-expected.txt:
  • platform/win/fast/ruby/nested-ruby-expected.checksum:
  • platform/win/fast/ruby/nested-ruby-expected.png:
  • platform/win/fast/ruby/nested-ruby-expected.txt:
5:41 PM Changeset in webkit [77710] by Martin Robinson
  • 8 edits in trunk

2011-02-04 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] fast/events/pagehide-timeout.html fails
​https://bugs.webkit.org/show_bug.cgi?id=53771

  • platform/gtk/Skipped: Unskip a test which is now passing.

2011-02-04 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] fast/events/pagehide-timeout.html fails
​https://bugs.webkit.org/show_bug.cgi?id=53771

Add the document browser cache model. This model is optimized for viewing
a series of local files, while the document viewer is optimized for only
viewing one local file. Improve the documentation on the mapping of these
enum values to actual cache settings.

  • webkit/webkitglobals.cpp: (webkit_set_cache_model): Add support for the document browser cache model and improve comments in this section better explaining where the magic numbers come from.
  • webkit/webkitglobals.h: Added an enum value for the document browser cache model.

2011-02-04 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] fast/events/pagehide-timeout.html fails
​https://bugs.webkit.org/show_bug.cgi?id=53771

Add knowledge of the document browser cache model the DRT. When resetting
WebKit settings to consistent values between tests, default to the document
browser cache model.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): Reset the cache model to the document browser cache model between tests.
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setCacheModel): An int value of 2 here corresponds to the document browser cache model.
5:33 PM Changeset in webkit [77709] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix build.

  • WebProcess/mac/WebProcessMac.mm:
5:32 PM Changeset in webkit [77708] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-04 Anders Carlsson <​andersca@apple.com>

Reviewed by Mark Rowe.

Link opened in background tab fails to paint when activated if it completes loading before tab is selected
​https://bugs.webkit.org/show_bug.cgi?id=53827
<rdar://problem/8962355>

  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::resumePainting): Invalidate the entire page.
5:23 PM Changeset in webkit [77707] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix <rdar://problem/8961227> WebKit2 does not work with symlinked home directories.

Reviewed by Sam Weinig.

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::platformSetCacheModel):
Don't adopt an autoreleased pointer, this would lead to a crash.

(WebKit::appendSandboxParameterPath):
(WebKit::appendSandboxParameterConfPath):
(WebKit::initializeSandbox):
Clean up the sandbox parameter code and make sure that realpath is called for all parameters.

4:50 PM Changeset in webkit [77706] by abarth@webkit.org
  • 7 edits
    2 adds in trunk

2011-02-04 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

PluginDocuments don't create widgets for plugins on back/forward
​https://bugs.webkit.org/show_bug.cgi?id=53474

Test that plugin loads when in a plugin document on back-forward.

  • plugins/plugin-document-back-forward-expected.txt: Added.
  • plugins/plugin-document-back-forward.html: Added.

2011-02-04 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

PluginDocuments don't create widgets for plugins on back/forward
​https://bugs.webkit.org/show_bug.cgi?id=53474

Long ago, PluginDocument always caused the HTMLEmbedElement to create
its widget synchronously during a post-layout task. Recently, however,
some changes to the HistroyController caused layout on back/forward to
become slightly more complicated (and added an extra level of recursion
to layout). This extra level of recursion triggered the "I've recursed
too many times" condition in the post-layout task queue, causing the
FrameView to run the remainder of the tasks asynchronously.
Unfortunately, that broke PluginDocument because it needs its the
HTMLEmbedElement's updateWidget task to run synchronously.

This patch adds a mechanism for "kicking off" the pending post-layout
tasks synchronously (instead of waiting for the timer to fire).
PluginDocument then uses that facility to ensure that the
HTMLEmbedElement's updateWidget task happens.

Test: plugins/plugin-document-back-forward.html

  • html/PluginDocument.cpp: (WebCore::PluginDocumentParser::appendBytes):
  • page/FrameView.cpp: (WebCore::FrameView::flushAnyPendingPostLayoutTasks):
  • page/FrameView.h:

2011-02-04 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

PluginDocuments don't create widgets for plugins on back/forward
​https://bugs.webkit.org/show_bug.cgi?id=53474

Teach the test plugin how to call alert on load.

  • DumpRenderTree/TestNetscapePlugIn/main.cpp: (NPP_New):
4:48 PM Changeset in webkit [77705] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

2011-02-04 Charlie Reis <​creis@chromium.org>

Reviewed by Mihai Parparita.

Crash in WebCore::HistoryController::itemsAreClones
​https://bugs.webkit.org/show_bug.cgi?id=52819

Tests that navigating back and forward between hash items works.

  • fast/history/history-back-forward-within-subframe-hash.html: Added.
  • fast/history/history-back-forward-within-subframe-hash-expected.txt: Added.

2011-02-04 Charlie Reis <​creis@chromium.org>

Reviewed by Mihai Parparita.

Crash in WebCore::HistoryController::itemsAreClones
​https://bugs.webkit.org/show_bug.cgi?id=52819

Avoids deleting the current HistoryItem while it is still in use.
Ensures that provisional items are committed for same document navigations.
Ensures that error pages are committed on back/forward navigations.
Also removes unneeded sanity checks used for diagnosing the problem.

  • loader/HistoryController.cpp:
  • loader/HistoryController.h:

2011-02-04 Charlie Reis <​creis@chromium.org>

Reviewed by Mihai Parparita.

Crash in WebCore::HistoryController::itemsAreClones
​https://bugs.webkit.org/show_bug.cgi?id=52819

Removes unneeded sanity checks used for diagnosing a memory error.

  • src/WebFrameImpl.cpp:
4:38 PM Changeset in webkit [77704] by Dimitri Glazkov
  • 2 edits
    3 adds in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Add expectations for the test, added in r77690.

  • platform/chromium-win/media/video-frame-accurate-seek-expected.checksum: Added.
  • platform/chromium-win/media/video-frame-accurate-seek-expected.png: Added.
  • platform/chromium-win/media/video-frame-accurate-seek-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
4:30 PM Changeset in webkit [77703] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Sandbox violations when visiting a site using HTTP authentication
<rdar://problem/8951079>

Reviewed by Mark Rowe.

  • WebProcess/com.apple.WebProcess.sb:
4:28 PM Changeset in webkit [77702] by carol.szabo@nokia.com
  • 6 edits
    2 adds in trunk

2011-02-04 Carol Szabo <​carol.szabo@nokia.com>

Reviewed by David Hyatt.

Code Changes.

CSS 2.1 failure: content-*
​https://bugs.webkit.org/show_bug.cgi?id=52126

  • fast/css/counters/content-021-expected.txt: Added.
  • fast/css/counters/content-021.html: Added. This is a copy of the test with the same name from the official css test suite, adapted for DumpRenderTree.

2011-02-04 Carol Szabo <​carol.szabo@nokia.com>

Reviewed by David Hyatt.

Code Changes.

CSS 2.1 failure: content-*
​https://bugs.webkit.org/show_bug.cgi?id=52126

Test: fast/css/counters/content-021.html

  • rendering/CounterNode.cpp: (showCounterTree): Made parameter const because it is supposed to be so.
  • rendering/RenderCounter.cpp: (WebCore::previousInPreOrder): (WebCore::previousSiblingOrParent): (WebCore::parentElement): (WebCore::areRenderersElementsSiblings): (WebCore::nextInPreOrder): Added these local helper functions to help navigate the DOM tree enriched with :before and :after pseudo elements. (WebCore::planCounter): Fixed bug that would create a repeat counter for second and subsequent renderers associated with the same DOM element. (WebCore::findPlaceForCounter): (WebCore::makeCounterNode): Changed to use the new tree navigation functions described above instead of the Renderer Tree navigation functions. (WebCore::RenderCounter::rendererSubtreeAttached): (WebCore::RenderCounter::rendererStyleChanged): Optimized to not bother about counters until the renderers are finally attached. (showRendererTree): (showNodeTree): Debug helper functions used to debug Counter bugs.
4:28 PM Changeset in webkit [77701] by ap@apple.com
  • 5 edits in trunk/Source/WebKit2

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=53823
Print layout sometimes seen on screen

<rdar://problem/8948742> REGRESSION (WebKit2) - When I print a page, I visually see it re-layout
<rdar://problem/8899389> REGRESSION(WebKit2): Wrong content can appear when print dialog is up

  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::setAutodisplay): Removed a branch that didn't do anything useful.
  • UIProcess/API/mac/WKPrintingView.h:
  • UIProcess/API/mac/WKPrintingView.mm: (-[WKPrintingView _suspendAutodisplay]): (-[WKPrintingView _delayedResumeAutodisplayTimerFired]): (-[WKPrintingView _delayedResumeAutodisplay]): (-[WKPrintingView knowsPageRange:]): (-[WKPrintingView beginDocument]): (-[WKPrintingView endDocument]): When page setup changes, or when going from print preview to actual printing, AppKit calls -endDocument just to begin it again. Delay resuming autodisplay until the next run loop iteration.
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::invalidateContentsAndWindow): (WebKit::WebChromeClient::invalidateContentsForSlowScroll): Tightened it up from other side - we should never send pixels to UI process while in printing mode. This is not 100% reliable, because relayout doesn't happen immediately, and we can still have print layout in screen mode - but it helps.
4:26 PM Changeset in webkit [77700] by Dimitri Glazkov
  • 1 edit
    6 deletes in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Removed Chromium-specific baselines that are no longer necessary.

  • platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Removed.
  • platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum: Removed.
  • platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.png: Removed.
4:20 PM Changeset in webkit [77699] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

2011-02-04 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Rolled back in r77612 with ASSERT/crash fixed.
​https://bugs.webkit.org/show_bug.cgi?id=53759


Don't shrink the heap to 0 unconditionally. Instead, shrink to 1 if
necessary. For now, the heap assumes that it always has at least one
block live.

  • runtime/Heap.cpp: (JSC::Heap::Heap): (JSC::Heap::reset):
  • runtime/Heap.h:
  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::allocate): (JSC::MarkedSpace::shrinkBlocks): (JSC::MarkedSpace::sweep): (JSC::MarkedSpace::reset):
  • runtime/MarkedSpace.h: (JSC::MarkedSpace::highWaterMark): (JSC::MarkedSpace::setHighWaterMark):
4:18 PM Changeset in webkit [77698] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Typo fix.

  • html/parser/XSSFilter.cpp:

(WebCore::HTMLNames::containsJavaScriptURL):

4:17 PM Changeset in webkit [77697] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Make an infinite loop introduced in r77454 finite.

Reviewed by Anders Carlsson.

  • html/parser/XSSFilter.cpp:

(WebCore::HTMLNames::containsJavaScriptURL):

4:16 PM Changeset in webkit [77696] by Dimitri Glazkov
  • 5 edits in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

Update Leopard pixel results for fast/box-shadow.

  • platform/mac-leopard/fast/box-shadow/basic-shadows-expected.checksum:
  • platform/mac-leopard/fast/box-shadow/basic-shadows-expected.png:
  • platform/mac-leopard/fast/box-shadow/inset-expected.checksum:
  • platform/mac-leopard/fast/box-shadow/inset-expected.png:
4:11 PM Changeset in webkit [77695] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix for <rdar://problem/8961580>.
Work around for <rdar://problem/8957845>.

Reviewed by Mark Rowe.

  • WebProcess/com.apple.WebProcess.sb:
4:11 PM Changeset in webkit [77694] by Darin Adler
  • 9 edits in trunk/Source/WebKit2

2011-02-04 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

WebKit2 doesn't hide mouse pointer on keypress
​https://bugs.webkit.org/show_bug.cgi?id=53821
rdar://problem/8630895

  • UIProcess/PageClient.h: Renamed didNotHandleKeyEvent to doneWithKeyEvent and added a bool wasEventHandled argument.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didReceiveEvent): Changed code to call doneWithKeyEvent and call even if event was handled.
  • UIProcess/API/mac/PageClientImpl.h: Updated for above change.
  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::doneWithKeyEvent): Ditto. But also call [NSCursor setHiddenUntilMouseMoves:YES] when a key down event was handled. This matches what -[WebHTMLView keyDown:] does.
  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::doneWithKeyEvent): Ditto.
  • UIProcess/API/qt/qwkpage_p.h: Ditto.
  • UIProcess/win/WebView.cpp: (WebKit::WebView::doneWithKeyEvent): Ditto.
  • UIProcess/win/WebView.h: Ditto.
3:49 PM Changeset in webkit [77693] by mrowe@apple.com
  • 5 edits in branches/safari-533.20-branch

Versioning.

3:49 PM Changeset in webkit [77692] by mrowe@apple.com
  • 1 copy in tags/Safari-533.20.24

New tag.

3:49 PM Changeset in webkit [77691] by mrowe@apple.com
  • 2 edits in branches/safari-533.20-branch/WebKit/win

Build fix.

3:48 PM Changeset in webkit [77690] by jer.noble@apple.com
  • 5 edits
    6 adds in trunk

2011-02-04 Jer Noble <​jer.noble@apple.com>

Reviewed by Eric Carlson.

Frame accurate seeking isn't always accurate
​https://bugs.webkit.org/show_bug.cgi?id=52697

New pixel test that seeks to specific currentTimes and records the rendered frame.

  • media/content/test-25fps.mp4: Added.
  • media/content/test-25fps.ogv: Added.
  • media/video-frame-accurate-seek-expected.txt: Added.
  • media/video-frame-accurate-seek.html: Added.
  • platform/mac/media/video-frame-accurate-seek-expected.checksum: Added.
  • platform/mac/media/video-frame-accurate-seek-expected.png: Added.

2011-02-04 Jer Noble <​jer.noble@apple.com>

Reviewed by Eric Carlson.

Frame accurate seeking isn't always accurate
​https://bugs.webkit.org/show_bug.cgi?id=52697

Test: media/video-frame-accurate-seek.html

Make seeking slightly more accurate by rounding instead of truncating
when converting from seconds-in-float to time/timeScale.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivateQTKit::createQTTime):
  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: (WebCore::MediaPlayerPrivateQuickTimeVisualContext::mediaTimeForTimeValue):
  • platform/graphics/win/QTMovie.cpp: (QTMovie::setCurrentTime):
3:45 PM Changeset in webkit [77689] by jorlow@chromium.org
  • 15 edits
    2 adds in trunk

2011-02-04 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Nate Chapin.

Second IndexedDB events overhaul patch
​https://bugs.webkit.org/show_bug.cgi?id=53813

  • storage/indexeddb/request-event-propagation-expected.txt: Added.
  • storage/indexeddb/request-event-propagation.html: Added.

2011-02-04 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Nate Chapin.

Second IndexedDB events overhaul patch
​https://bugs.webkit.org/show_bug.cgi?id=53813

If an IDBRequest has a IDBTransaction, it should propogate
events through it. In order to do this, IDBRequest needs to
hold a transaction frontend object rather than a backend one.

Test: storage/indexeddb/request-event-propagation.html

  • storage/IDBCursor.cpp: (WebCore::IDBCursor::IDBCursor):
  • storage/IDBCursor.h: (WebCore::IDBCursor::create):
  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::setSetVersionTransaction): (WebCore::IDBDatabase::createObjectStore): (WebCore::IDBDatabase::deleteObjectStore):
  • storage/IDBDatabase.h:
  • storage/IDBIndex.cpp: (WebCore::IDBIndex::IDBIndex): (WebCore::IDBIndex::openCursor): (WebCore::IDBIndex::openKeyCursor): (WebCore::IDBIndex::get): (WebCore::IDBIndex::getKey):
  • storage/IDBIndex.h: (WebCore::IDBIndex::create):
  • storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::IDBObjectStore): (WebCore::IDBObjectStore::get): (WebCore::IDBObjectStore::add): (WebCore::IDBObjectStore::put): (WebCore::IDBObjectStore::deleteFunction): (WebCore::IDBObjectStore::createIndex): (WebCore::IDBObjectStore::deleteIndex): (WebCore::IDBObjectStore::openCursor):
  • storage/IDBObjectStore.h: (WebCore::IDBObjectStore::create):
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::create): (WebCore::IDBRequest::IDBRequest): (WebCore::IDBRequest::resetReadyState): (WebCore::IDBRequest::onSuccess): (WebCore::IDBRequest::dispatchEvent):
  • storage/IDBRequest.h:
  • storage/IDBTransaction.cpp: (WebCore::IDBTransaction::IDBTransaction): (WebCore::IDBTransaction::objectStore): (WebCore::IDBTransaction::contextDestroyed): (WebCore::IDBTransaction::enqueueEvent):
  • storage/IDBTransaction.h:
  • storage/IDBTransaction.idl:
3:43 PM Changeset in webkit [77688] by jorlow@chromium.org
  • 29 edits
    1 copy
    1 add in trunk

2011-02-04 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Nate Chapin.

First step towards event propogation within IndexedDB
​https://bugs.webkit.org/show_bug.cgi?id=53795

This is the first step towards implementing
​http://www.w3.org/Bugs/Public/show_bug.cgi?id=11348
within IndexedDB. I've created a method that knows how
to capture and bubble (based on Node's dispatchGenericEvent).
I've then changed IDBRequest to use it.

The only functional change is that preventDefault now must
be called in error events to prevent the transaction from
being aborted. The tests reflect this change and there's one
specific test to look at this behavior.

  • storage/indexeddb/cursor-index-delete-expected.txt:
  • storage/indexeddb/cursor-index-delete.html:
  • storage/indexeddb/database-quota-expected.txt:
  • storage/indexeddb/database-quota.html:
  • storage/indexeddb/duplicates-expected.txt:
  • storage/indexeddb/duplicates.html:
  • storage/indexeddb/error-causes-abort-by-default-expected.txt: Copied from LayoutTests/storage/indexeddb/cursor-index-delete-expected.txt.
  • storage/indexeddb/error-causes-abort-by-default.html: Added.
  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics.html:
  • storage/indexeddb/objectstore-autoincrement-expected.txt:
  • storage/indexeddb/objectstore-autoincrement.html:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:

2011-02-04 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Nate Chapin.

First step towards event propogation within IndexedDB
​https://bugs.webkit.org/show_bug.cgi?id=53795

This is the first step towards implementing
​http://www.w3.org/Bugs/Public/show_bug.cgi?id=11348
within IndexedDB. I've created a method that knows how
to capture and bubble (based on Node's dispatchGenericEvent).
I've then changed IDBRequest to use it.

The only functional change is that preventDefault now must
be called in error events to prevent the transaction from
being aborted. The tests reflect this change and there's one
specific test to look at this behavior.

Test: storage/indexeddb/error-causes-abort-by-default.html

  • storage/IDBAbortEvent.cpp: (WebCore::IDBAbortEvent::create): (WebCore::IDBAbortEvent::IDBAbortEvent):
  • storage/IDBAbortEvent.h:
  • storage/IDBCompleteEvent.cpp: (WebCore::IDBCompleteEvent::create): (WebCore::IDBCompleteEvent::IDBCompleteEvent):
  • storage/IDBCompleteEvent.h:
  • storage/IDBErrorEvent.cpp: (WebCore::IDBErrorEvent::IDBErrorEvent):
  • storage/IDBEvent.cpp: (WebCore::IDBEvent::IDBEvent): (WebCore::IDBEvent::dispatch):
  • storage/IDBEvent.h:
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::dispatchEvent):
  • storage/IDBRequest.h:
  • storage/IDBSuccessEvent.cpp: (WebCore::IDBSuccessEvent::IDBSuccessEvent):
  • storage/IDBTransaction.cpp: (WebCore::IDBTransaction::onAbort): (WebCore::IDBTransaction::onComplete):
  • storage/IDBTransaction.h: (WebCore::IDBTransaction::backend):
  • storage/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::taskTimerFired):
3:36 PM Changeset in webkit [77687] by dcheng@chromium.org
  • 13 edits in trunk/Source

2011-02-04 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Dmitry Titov.

Clone WebClipboard to be frame-specific.
​https://bugs.webkit.org/show_bug.cgi?id=53727

For drop operations, Chrome currently snapshots the data and copies it
into the renderer process. As we add more supported drag data types, the
copy will become increasingly expensive. Instead, we'd like to snapshot
data in the browser to reduce the amount of data copied and to support
Blob in DataTransferItem. In order to allow this, we associated
WebClipboard with a frame so it can correctly route its IPCs to the
corresponding Chromium host.

No new tests because no new functionality.

  • platform/chromium/ChromiumDataObject.cpp: (WebCore::ChromiumDataObject::createReadable):
  • platform/chromium/ChromiumDataObject.h:
  • platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::create):
  • platform/chromium/PlatformBridge.h:
  • platform/chromium/ReadableDataObject.cpp: (WebCore::ReadableDataObject::create): (WebCore::ReadableDataObject::ReadableDataObject): (WebCore::ReadableDataObject::getData): (WebCore::ReadableDataObject::urlTitle): (WebCore::ReadableDataObject::htmlBaseUrl): (WebCore::ReadableDataObject::filenames): (WebCore::ReadableDataObject::ensureTypeCacheInitialized):
  • platform/chromium/ReadableDataObject.h:

2011-02-04 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Dmitry Titov.

Clone WebClipboard to be frame-specific.
​https://bugs.webkit.org/show_bug.cgi?id=53727

For drop operations, Chrome currently snapshots the data and copies it
into the renderer process. As we add more supported drag data types, the
copy will become increasingly expensive. Instead, we'd like to snapshot
data in the browser to reduce the amount of data copied and to support
Blob in DataTransferItem. In order to allow this, we associated
WebClipboard with a frame so it can correctly route its IPCs to the
corresponding Chromium host.

  • public/WebFrameClient.h: (WebKit::WebFrameClient::clipboard):
  • src/PlatformBridge.cpp: (WebCore::getClipboard): (WebCore::PlatformBridge::clipboardReadAvailableTypes): (WebCore::PlatformBridge::clipboardReadData): (WebCore::PlatformBridge::clipboardReadFilenames):
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::fromFrame):
  • src/WebFrameImpl.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::dragTargetDragEnterNew):
3:34 PM Changeset in webkit [77686] by Dimitri Glazkov
  • 1 edit
    6 deletes in trunk/LayoutTests

[Chromium] Remove Chromium-specific baselines that we no longer need.

  • platform/chromium-mac-leopard/fast/ruby/nested-ruby-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/ruby/nested-ruby-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/ruby/ruby-beforeafter-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/ruby/ruby-beforeafter-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/ruby/ruby-run-break-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/ruby/ruby-run-break-expected.png: Removed.
3:33 PM Changeset in webkit [77685] by jorlow@chromium.org
  • 29 edits
    2 deletes in trunk

2011-02-04 Jeremy Orlow <​jorlow@chromium.org>

Revert ​https://bugs.webkit.org/show_bug.cgi?id=53795

  • storage/indexeddb/cursor-index-delete-expected.txt:
  • storage/indexeddb/cursor-index-delete.html:
  • storage/indexeddb/cursor-update-expected.txt:
  • storage/indexeddb/cursor-update.html:
  • storage/indexeddb/database-quota-expected.txt:
  • storage/indexeddb/database-quota.html:
  • storage/indexeddb/duplicates-expected.txt:
  • storage/indexeddb/duplicates.html:
  • storage/indexeddb/error-causes-abort-by-default-expected.txt: Removed.
  • storage/indexeddb/error-causes-abort-by-default.html: Removed.
  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics.html:
  • storage/indexeddb/objectstore-autoincrement-expected.txt:
  • storage/indexeddb/objectstore-autoincrement.html:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:

2011-02-04 Jeremy Orlow <​jorlow@chromium.org>

Revert ​https://bugs.webkit.org/show_bug.cgi?id=53795

  • storage/IDBAbortEvent.cpp: (WebCore::IDBAbortEvent::create): (WebCore::IDBAbortEvent::IDBAbortEvent):
  • storage/IDBAbortEvent.h:
  • storage/IDBCompleteEvent.cpp: (WebCore::IDBCompleteEvent::create): (WebCore::IDBCompleteEvent::IDBCompleteEvent):
  • storage/IDBCompleteEvent.h:
  • storage/IDBErrorEvent.cpp: (WebCore::IDBErrorEvent::IDBErrorEvent):
  • storage/IDBEvent.cpp: (WebCore::IDBEvent::IDBEvent):
  • storage/IDBEvent.h:
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::dispatchEvent):
  • storage/IDBRequest.h:
  • storage/IDBSuccessEvent.cpp: (WebCore::IDBSuccessEvent::IDBSuccessEvent):
  • storage/IDBTransaction.cpp: (WebCore::IDBTransaction::onAbort): (WebCore::IDBTransaction::onComplete):
  • storage/IDBTransaction.h:
  • storage/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::taskTimerFired):
3:19 PM Changeset in webkit [77684] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Marked test, added in r77680 as failing due to lighttpd.

  • platform/chromium/test_expectations.txt: Marked.
3:08 PM Changeset in webkit [77683] by Dimitri Glazkov
  • 8 edits
    6 deletes in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

Update Leopard baselines for fast/blockflow, this time correctly.

  • platform/mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum:
  • platform/mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
  • platform/mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.txt: Removed.
  • platform/mac-leopard/fast/blockflow/fieldsets-expected.png:
  • platform/mac-leopard/fast/blockflow/japanese-ruby-horizontal-bt-expected.checksum: Removed.
  • platform/mac-leopard/fast/blockflow/japanese-ruby-horizontal-bt-expected.png: Removed.
  • platform/mac-leopard/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt: Removed.
  • platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum:
  • platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.png:
  • platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.txt: Removed.
  • platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum:
  • platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.png:
  • platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.txt: Removed.
2:54 PM Changeset in webkit [77682] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-04 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Merge in some GPU expectations that got dropped in r77666, get lint to pass.

  • platform/chromium/test_expectations.txt:
2:49 PM Changeset in webkit [77681] by Dimitri Glazkov
  • 33 edits
    4 adds in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

Add Leopard-specific pixel results for fast/ruby.

  • platform/mac-leopard/fast/ruby/nested-ruby-expected.checksum: Added.
  • platform/mac-leopard/fast/ruby/nested-ruby-expected.png: Added.
  • platform/mac-leopard/fast/ruby/ruby-beforeafter-expected.checksum: Added.
  • platform/mac-leopard/fast/ruby/ruby-beforeafter-expected.png: Added.
  • platform/mac-leopard/fast/ruby/ruby-empty-rt-expected.checksum:
  • platform/mac-leopard/fast/ruby/ruby-empty-rt-expected.png:
  • platform/mac-leopard/fast/ruby/ruby-length-expected.checksum:
  • platform/mac-leopard/fast/ruby/ruby-length-expected.png:
  • platform/mac-leopard/fast/ruby/ruby-run-break-expected.checksum:
  • platform/mac-leopard/fast/ruby/ruby-run-break-expected.png:
  • platform/mac-leopard/fast/ruby/ruby-runs-expected.checksum:
  • platform/mac-leopard/fast/ruby/ruby-runs-expected.png:
  • platform/mac-leopard/fast/ruby/ruby-runs-spans-expected.checksum:
  • platform/mac-leopard/fast/ruby/ruby-runs-spans-expected.png:
  • platform/mac-leopard/fast/ruby/ruby-simple-expected.checksum:
  • platform/mac-leopard/fast/ruby/ruby-simple-expected.png:
  • platform/mac-leopard/fast/ruby/ruby-simple-rp-expected.checksum:
  • platform/mac-leopard/fast/ruby/ruby-simple-rp-expected.png:
  • platform/mac-leopard/fast/ruby/ruby-trailing-expected.checksum:
  • platform/mac-leopard/fast/ruby/ruby-trailing-expected.png:
  • platform/mac-leopard/fast/ruby/rubyDOM-insert-rt-expected.checksum:
  • platform/mac-leopard/fast/ruby/rubyDOM-insert-rt-expected.png:
  • platform/mac-leopard/fast/ruby/rubyDOM-insert-text1-expected.checksum:
  • platform/mac-leopard/fast/ruby/rubyDOM-insert-text1-expected.png:
  • platform/mac-leopard/fast/ruby/rubyDOM-insert-text2-expected.checksum:
  • platform/mac-leopard/fast/ruby/rubyDOM-insert-text2-expected.png:
  • platform/mac-leopard/fast/ruby/rubyDOM-insert-text3-expected.checksum:
  • platform/mac-leopard/fast/ruby/rubyDOM-insert-text3-expected.png:
  • platform/mac-leopard/fast/ruby/rubyDOM-remove-rt1-expected.checksum:
  • platform/mac-leopard/fast/ruby/rubyDOM-remove-rt1-expected.png:
  • platform/mac-leopard/fast/ruby/rubyDOM-remove-rt2-expected.checksum:
  • platform/mac-leopard/fast/ruby/rubyDOM-remove-rt2-expected.png:
  • platform/mac-leopard/fast/ruby/rubyDOM-remove-text1-expected.checksum:
  • platform/mac-leopard/fast/ruby/rubyDOM-remove-text1-expected.png:
  • platform/mac-leopard/fast/ruby/rubyDOM-remove-text2-expected.checksum:
  • platform/mac-leopard/fast/ruby/rubyDOM-remove-text2-expected.png:
2:41 PM Changeset in webkit [77680] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

2011-02-04 Martin Galpin <​martin@66laps.com>

Reviewed by David Levin.

CORS origin header not set on GET when a preflight request is required.
​https://bugs.webkit.org/show_bug.cgi?id=50773

  • http/tests/xmlhttprequest/cross-origin-preflight-get-expected.txt: Added.
  • http/tests/xmlhttprequest/cross-origin-preflight-get.html: Added.
  • http/tests/xmlhttprequest/resources/cross-origin-preflight-get.php: Added.

2011-02-04 Martin Galpin <​martin@66laps.com>

Reviewed by David Levin.

CORS origin header not set on GET when a preflight request is required.
​https://bugs.webkit.org/show_bug.cgi?id=50773

Test: http/tests/xmlhttprequest/cross-origin-preflight-get.html

  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::preflightSuccess): Explicitly set the request origin after a preflight request succeeds.
2:38 PM Changeset in webkit [77679] by jorlow@chromium.org
  • 29 edits
    1 copy
    1 add in trunk

2011-02-04 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Nate Chapin.

First step towards event propogation within IndexedDB
​https://bugs.webkit.org/show_bug.cgi?id=53795

This is the first step towards implementing
​http://www.w3.org/Bugs/Public/show_bug.cgi?id=11348
within IndexedDB. I've created a method that knows how
to capture and bubble (based on Node's dispatchGenericEvent).
I've then changed IDBRequest to use it.

The only functional change is that preventDefault now must
be called in error events to prevent the transaction from
being aborted. The tests reflect this change and there's one
specific test to look at this behavior.

  • storage/indexeddb/cursor-index-delete-expected.txt:
  • storage/indexeddb/cursor-index-delete.html:
  • storage/indexeddb/database-quota-expected.txt:
  • storage/indexeddb/database-quota.html:
  • storage/indexeddb/duplicates-expected.txt:
  • storage/indexeddb/duplicates.html:
  • storage/indexeddb/error-causes-abort-by-default-expected.txt: Copied from LayoutTests/storage/indexeddb/cursor-index-delete-expected.txt.
  • storage/indexeddb/error-causes-abort-by-default.html: Added.
  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics.html:
  • storage/indexeddb/objectstore-autoincrement-expected.txt:
  • storage/indexeddb/objectstore-autoincrement.html:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:

2011-02-04 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Nate Chapin.

First step towards event propogation within IndexedDB
​https://bugs.webkit.org/show_bug.cgi?id=53795

This is the first step towards implementing
​http://www.w3.org/Bugs/Public/show_bug.cgi?id=11348
within IndexedDB. I've created a method that knows how
to capture and bubble (based on Node's dispatchGenericEvent).
I've then changed IDBRequest to use it.

The only functional change is that preventDefault now must
be called in error events to prevent the transaction from
being aborted. The tests reflect this change and there's one
specific test to look at this behavior.

Test: storage/indexeddb/error-causes-abort-by-default.html

  • storage/IDBAbortEvent.cpp: (WebCore::IDBAbortEvent::create): (WebCore::IDBAbortEvent::IDBAbortEvent):
  • storage/IDBAbortEvent.h:
  • storage/IDBCompleteEvent.cpp: (WebCore::IDBCompleteEvent::create): (WebCore::IDBCompleteEvent::IDBCompleteEvent):
  • storage/IDBCompleteEvent.h:
  • storage/IDBErrorEvent.cpp: (WebCore::IDBErrorEvent::IDBErrorEvent):
  • storage/IDBEvent.cpp: (WebCore::IDBEvent::IDBEvent): (WebCore::IDBEvent::dispatch):
  • storage/IDBEvent.h:
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::dispatchEvent):
  • storage/IDBRequest.h:
  • storage/IDBSuccessEvent.cpp: (WebCore::IDBSuccessEvent::IDBSuccessEvent):
  • storage/IDBTransaction.cpp: (WebCore::IDBTransaction::onAbort): (WebCore::IDBTransaction::onComplete):
  • storage/IDBTransaction.h: (WebCore::IDBTransaction::backend):
  • storage/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::taskTimerFired):
2:37 PM Changeset in webkit [77678] by sfalken@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-02-04 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam Roben.

WebKit2 clients fail to launch on Windows if client exe is in a different directory from WebKit
​https://bugs.webkit.org/show_bug.cgi?id=53810
<rdar://problem/8946085>


If WebKit2WebProcess.exe is in a different directory from the client process, and that
client process uses CreateProcess to launch WebKit2WebProcess, the DLL search path may
end up excluding the directory containing WebKit. To address this, we use SetDllDirectory
to explicitly include the WebKit directory in the DLL search path.

  • win/MainWin.cpp: (wWinMain): Use SetDllDirectory and LoadLibrary to load WebKit.dll from WebKit2WebProcess.exe
  • win/WebKit2WebProcessCommon.vsprops: Don't link directly to WebKit. Link against shlwapi.
2:31 PM Changeset in webkit [77677] by sfalken@apple.com
  • 2 edits in trunk/WebKitLibraries

2011-02-04 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam Roben.

Bump Windows minimum system requirement to XPSP2
​https://bugs.webkit.org/show_bug.cgi?id=53807

  • win/tools/vsprops/common.vsprops:
2:29 PM Changeset in webkit [77676] by Dimitri Glazkov
  • 104 edits in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Updated Win and Linux baselines after r77665.

2:08 PM Changeset in webkit [77675] by xji@chromium.org
  • 7 edits in trunk/LayoutTests

2011-02-04 Xiaomei Ji <​xji@chromium.org>

Unreviewed.

Rebaseline chromium after r77654.
text-align attribute in <select> is ignored both in button text and drop-down
items.

  • platform/chromium-linux/fast/text/international/bidi-menulist-expected.checksum:
  • platform/chromium-linux/fast/text/international/bidi-menulist-expected.png:
  • platform/chromium-linux/fast/text/international/bidi-menulist-expected.txt:
  • platform/chromium-win/fast/text/international/bidi-menulist-expected.checksum:
  • platform/chromium-win/fast/text/international/bidi-menulist-expected.png:
  • platform/chromium-win/fast/text/international/bidi-menulist-expected.txt:
2:05 PM Changeset in webkit [77674] by Dimitri Glazkov
  • 1 edit
    34 adds in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

Add Leopard-specific pixel results for fast/blockflow.

  • platform/mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum: Added.
  • platform/mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.png: Added.
  • platform/mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.txt: Added.
  • platform/mac-leopard/fast/blockflow/block-level-images-expected.checksum: Added.
  • platform/mac-leopard/fast/blockflow/block-level-images-expected.png: Added.
  • platform/mac-leopard/fast/blockflow/border-vertical-lr-expected.checksum: Added.
  • platform/mac-leopard/fast/blockflow/border-vertical-lr-expected.png: Added.
  • platform/mac-leopard/fast/blockflow/english-bt-text-expected.checksum: Added.
  • platform/mac-leopard/fast/blockflow/english-bt-text-expected.png: Added.
  • platform/mac-leopard/fast/blockflow/english-lr-text-expected.checksum: Added.
  • platform/mac-leopard/fast/blockflow/english-lr-text-expected.png: Added.
  • platform/mac-leopard/fast/blockflow/japanese-lr-selection-expected.checksum: Added.
  • platform/mac-leopard/fast/blockflow/japanese-lr-selection-expected.png: Added.
  • platform/mac-leopard/fast/blockflow/japanese-lr-text-expected.checksum: Added.
  • platform/mac-leopard/fast/blockflow/japanese-lr-text-expected.png: Added.
  • platform/mac-leopard/fast/blockflow/japanese-rl-selection-expected.checksum: Added.
  • platform/mac-leopard/fast/blockflow/japanese-rl-selection-expected.png: Added.
  • platform/mac-leopard/fast/blockflow/japanese-rl-text-expected.checksum: Added.
  • platform/mac-leopard/fast/blockflow/japanese-rl-text-expected.png: Added.
  • platform/mac-leopard/fast/blockflow/japanese-ruby-horizontal-bt-expected.checksum: Added.
  • platform/mac-leopard/fast/blockflow/japanese-ruby-horizontal-bt-expected.png: Added.
  • platform/mac-leopard/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt: Added.
  • platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum: Added.
  • platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Added.
  • platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.txt: Added.
  • platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum: Added.
  • platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Added.
  • platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.txt: Added.
  • platform/mac-leopard/fast/blockflow/vertical-align-table-baseline-expected.checksum: Added.
  • platform/mac-leopard/fast/blockflow/vertical-align-table-baseline-expected.png: Added.
  • platform/mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.checksum: Added.
  • platform/mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.png: Added.
  • platform/mac-leopard/fast/blockflow/vertical-font-fallback-expected.checksum: Added.
  • platform/mac-leopard/fast/blockflow/vertical-font-fallback-expected.png: Added.
1:53 PM Changeset in webkit [77673] by Dimitri Glazkov
  • 2 edits
    6 deletes in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

Remove platform-specific baselines, since we match platform/mac here.

  • platform/chromium-mac/fast/blockflow/box-shadow-horizontal-bt-expected.checksum: Removed.
  • platform/chromium-mac/fast/blockflow/box-shadow-horizontal-bt-expected.png: Removed.
  • platform/chromium-mac/fast/blockflow/box-shadow-vertical-lr-expected.checksum: Removed.
  • platform/chromium-mac/fast/blockflow/box-shadow-vertical-lr-expected.png: Removed.
  • platform/chromium-mac/fast/blockflow/box-shadow-vertical-rl-expected.checksum: Removed.
  • platform/chromium-mac/fast/blockflow/box-shadow-vertical-rl-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
1:50 PM Changeset in webkit [77672] by Adam Roben
  • 7 edits
    2 adds in trunk

Add a test case for encode/decode of FormData/FormDataElement

If the fix made in r77401 is broken, this new test will crash.

Fixes <​http://webkit.org/b/53616> <rdar://problem/8949883>.

Reviewed by Sam Weinig.

Tools:

  • TestWebKitAPI/Test.h: Moved the bulk of TEST_ASSERT into a new _TEST_ASSERT_HELPER macro.

Added a new TEST_ASSERT_RETURN macro that can be used in functions with a return value.

  • TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp: Added.

(TestWebKitAPI::didFinishLoadForFrame): Record that the load is finished.
(TestWebKitAPI::setPageLoaderClient): Hook up the loader client.
(TestWebKitAPI::createSessionStateContainingFormData): Load simple-form.html, submit the
form, an return the session state data.
(TestWebKitAPI::TEST): Create some session state that contains form data from one WKPage,
and restore it into another WKPage.

  • TestWebKitAPI/Tests/WebKit2/simple-form.html: Added.
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:
  • TestWebKitAPI/win/copy-resources.cmd:

Added new files.

Source/WebKit2:

Allow passing a null filter callback to WKPageCopySessionState

  • UIProcess/cf/WebBackForwardListCF.cpp:

(WebKit::WebBackForwardList::createCFDictionaryRepresentation): Check if the filter is null
before calling it.

1:50 PM Changeset in webkit [77671] by Adam Roben
  • 4 edits
    2 adds in trunk/Tools

Move code to run JavaScript tests into its own files

This will allow other tests to use this mechanism.

Fixes <​http://webkit.org/b/53806> SpacebarScrolling should share its JavaScript-fu with the
world

Reviewed by Sam Weinig.

  • TestWebKitAPI/JavaScriptTest.cpp: Added.
  • TestWebKitAPI/JavaScriptTest.h: Added.

Moved code here...

  • TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: ...from here.
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:

Added the new files.

1:48 PM Changeset in webkit [77670] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Update mac expectations.

  • platform/chromium/test_expectations.txt: Updated.
1:43 PM Changeset in webkit [77669] by Dimitri Glazkov
  • 4 edits in trunk

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Csaba Osztrogonác.

[Qt]REGRESSION(r76951): media/controls-without-preload.html fails
​https://bugs.webkit.org/show_bug.cgi?id=53674

  • platform/qt/Skipped:

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Csaba Osztrogonác.

[Qt]REGRESSION(r76951): media/controls-without-preload.html fails
​https://bugs.webkit.org/show_bug.cgi?id=53674

  • css/mediaControlsQt.css:
1:27 PM Changeset in webkit [77668] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-04 Mihai Parparita <​mihaip@chromium.org>

Unreviewed GTK expectations update.

Unskip fast/history/timed-refresh-in-cached-frame.html, it should pass
with ​http://trac.webkit.org/changeset/77559.

  • platform/gtk/Skipped:
1:25 PM Changeset in webkit [77667] by bweinstein@apple.com
  • 8 edits in trunk/Source/WebKit2

WebKit2: DidInitiateLoadForResource needs to know if the resource is being loaded by a committed or provisional frame
​https://bugs.webkit.org/show_bug.cgi?id=53794

Reviewed by John Sullivan.

When we navigate from one page to another, there can be multiple subresource requests between when
the new page has started its provisional load and when it has committed the load.

There can be:

  • The main resource load of the provisional page
  • Synchronous XHR from the unload event of the loaded page.


WebKit clients need to be able to differentiate between these loads.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didInitiateLoadForResource): Pass whether or not the page is provisionally loading

to the client.

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in: Add a new parameter to DidInitiateLoadForResource.
  • UIProcess/WebResourceLoadClient.cpp:

(WebKit::WebResourceLoadClient::didInitiateLoadForResource): a new parameter to didInitiateLoadForResource.

  • UIProcess/WebResourceLoadClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::assignIdentifierToInitialRequest): Pass whether or not the page is currently

in a provisional load (checked by seeing if the DocumentLoader matches the FrameLoader's provisionalDocumentLoader)
to the UI Process.

1:21 PM Changeset in webkit [77666] by dpranke@chromium.org
  • 7 edits
    1 delete in trunk

2011-02-04 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Mihai Parparita.

merge test expectations for chromium, chromium-gpu. From
now on, we will track GPU-specific expectations with the
"GPU" modifier in the main file, rather than in a separate
file (and non-GPU-specific expectations with the "CPU"
modifier.

​https://bugs.webkit.org/show_bug.cgi?id=53562

  • platform/chromium-gpu/test_expectations.txt: Removed.
  • platform/chromium/test_expectations.txt:

2011-02-04 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Mihai Parparita.

merge test expectations for chromium, chromium-gpu. The
chromium-gpu port will no longer maintain its own
test expectations file.

Also add in a graphics_type() call on the port object to
determine what graphics type to use in the test configuration,
and log the configuration as a config setting.

​https://bugs.webkit.org/show_bug.cgi?id=53562

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1:18 PM Changeset in webkit [77665] by mitz@apple.com
  • 78 edits in trunk

<rdar://problem/8902704> Make ruby text size 50% by default
​https://bugs.webkit.org/show_bug.cgi?id=53723

Reviewed by Darin Adler and Dave Hyatt.

Source/WebCore:

  • css/html.css:

(ruby > rt): Changed the font-size from 60% to 50%.

LayoutTests:

  • fast/text/emphasis-avoid-ruby-expected.checksum:
  • fast/text/emphasis-avoid-ruby-expected.png:
  • fast/text/emphasis-avoid-ruby-expected.txt:
  • platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum:
  • platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
  • platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:
  • platform/mac/fast/blockflow/box-shadow-horizontal-bt-expected.checksum:
  • platform/mac/fast/blockflow/box-shadow-horizontal-bt-expected.png:
  • platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.checksum:
  • platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.png:
  • platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.checksum:
  • platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.png:
  • platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.checksum:
  • platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.png:
  • platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt:
  • platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum:
  • platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.png:
  • platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.txt:
  • platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum:
  • platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.png:
  • platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.txt:
  • platform/mac/fast/ruby/nested-ruby-expected.checksum:
  • platform/mac/fast/ruby/nested-ruby-expected.png:
  • platform/mac/fast/ruby/nested-ruby-expected.txt:
  • platform/mac/fast/ruby/ruby-beforeafter-expected.checksum:
  • platform/mac/fast/ruby/ruby-beforeafter-expected.png:
  • platform/mac/fast/ruby/ruby-beforeafter-expected.txt:
  • platform/mac/fast/ruby/ruby-empty-rt-expected.checksum:
  • platform/mac/fast/ruby/ruby-empty-rt-expected.png:
  • platform/mac/fast/ruby/ruby-empty-rt-expected.txt:
  • platform/mac/fast/ruby/ruby-length-expected.checksum:
  • platform/mac/fast/ruby/ruby-length-expected.png:
  • platform/mac/fast/ruby/ruby-length-expected.txt:
  • platform/mac/fast/ruby/ruby-run-break-expected.checksum:
  • platform/mac/fast/ruby/ruby-run-break-expected.png:
  • platform/mac/fast/ruby/ruby-run-break-expected.txt:
  • platform/mac/fast/ruby/ruby-runs-expected.checksum:
  • platform/mac/fast/ruby/ruby-runs-expected.png:
  • platform/mac/fast/ruby/ruby-runs-expected.txt:
  • platform/mac/fast/ruby/ruby-runs-spans-expected.checksum:
  • platform/mac/fast/ruby/ruby-runs-spans-expected.png:
  • platform/mac/fast/ruby/ruby-runs-spans-expected.txt:
  • platform/mac/fast/ruby/ruby-simple-expected.checksum:
  • platform/mac/fast/ruby/ruby-simple-expected.png:
  • platform/mac/fast/ruby/ruby-simple-expected.txt:
  • platform/mac/fast/ruby/ruby-simple-rp-expected.checksum:
  • platform/mac/fast/ruby/ruby-simple-rp-expected.png:
  • platform/mac/fast/ruby/ruby-simple-rp-expected.txt:
  • platform/mac/fast/ruby/ruby-trailing-expected.checksum:
  • platform/mac/fast/ruby/ruby-trailing-expected.png:
  • platform/mac/fast/ruby/ruby-trailing-expected.txt:
  • platform/mac/fast/ruby/rubyDOM-insert-rt-expected.checksum:
  • platform/mac/fast/ruby/rubyDOM-insert-rt-expected.png:
  • platform/mac/fast/ruby/rubyDOM-insert-rt-expected.txt:
  • platform/mac/fast/ruby/rubyDOM-insert-text1-expected.checksum:
  • platform/mac/fast/ruby/rubyDOM-insert-text1-expected.png:
  • platform/mac/fast/ruby/rubyDOM-insert-text1-expected.txt:
  • platform/mac/fast/ruby/rubyDOM-insert-text2-expected.checksum:
  • platform/mac/fast/ruby/rubyDOM-insert-text2-expected.png:
  • platform/mac/fast/ruby/rubyDOM-insert-text2-expected.txt:
  • platform/mac/fast/ruby/rubyDOM-insert-text3-expected.checksum:
  • platform/mac/fast/ruby/rubyDOM-insert-text3-expected.png:
  • platform/mac/fast/ruby/rubyDOM-insert-text3-expected.txt:
  • platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.checksum:
  • platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.png:
  • platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.txt:
  • platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.checksum:
  • platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.png:
  • platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.txt:
  • platform/mac/fast/ruby/rubyDOM-remove-text1-expected.checksum:
  • platform/mac/fast/ruby/rubyDOM-remove-text1-expected.png:
  • platform/mac/fast/ruby/rubyDOM-remove-text1-expected.txt:
  • platform/mac/fast/ruby/rubyDOM-remove-text2-expected.checksum:
  • platform/mac/fast/ruby/rubyDOM-remove-text2-expected.png:
  • platform/mac/fast/ruby/rubyDOM-remove-text2-expected.txt:
1:16 PM Changeset in webkit [77664] by Antti Koivisto
  • 3 edits
    4 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=53610
Regression: adjacent sibling selector not working as expected
<rdar://problem/8960033>

Reviewed by Dimitri Glazkov.

Source/WebCore:

​https://bugs.webkit.org/show_bug.cgi?id=53574
REGRESSION (r76012): :last-child:after not working as expected
<rdar://problem/8948643>

Test for additional conditions in parent style that prevent sharing.

Tests: fast/selectors/style-sharing-adjacent-selector.html

fast/selectors/style-sharing-last-child.html

  • css/CSSStyleSelector.cpp:

(WebCore::parentStylePreventsSharing):
(WebCore::CSSStyleSelector::locateSharedStyle):

LayoutTests:

​https://bugs.webkit.org/show_bug.cgi?id=53574
REGRESSION (r76012): :last-child:after not working as expected
<rdar://problem/8948643>

  • fast/selectors/style-sharing-adjacent-selector-expected.txt: Added.
  • fast/selectors/style-sharing-adjacent-selector.html: Added.
  • fast/selectors/style-sharing-last-child-expected.txt: Added.
  • fast/selectors/style-sharing-last-child.html: Added.
1:11 PM Changeset in webkit [77663] by dpranke@chromium.org
  • 2 edits
    1 add in trunk/Source/WebCore

2011-02-04 Mark Mentovai <​mark@chromium.org>

Reviewed by Dimitri Glazkov.


Chromium GYP build fix.


When various settings were moved to webcore_prerequisites in r66364,
things that should have been direct_dependent_settings were not marked
as such. GYP 'defines', for example, make no sense on a 'none'-type
target such as webcore_prerequisites. It appears that it was intended
for these settings to be pushed to direct dependents, which would make
direct_dependent_settings correct.


Losing the ChromiumWebCoreObjC defines on the Mac, for example, caused
​http://crbug.com/71537, which at best causes Mac console log spew, and
at worst may result in Chromium's copy of WebCore using system
definitions of certain Objective-C classes at runtime, or vice-versa.


The build now includes a postbuild step to prevent
​http://crbug.com/71537 from regressing again. The build will fail upon
regression.


​https://bugs.webkit.org/show_bug.cgi?id=53630


  • WebCore.gyp/WebCore.gyp: Move things in webcore_prerequisites into direct_dependent_settings as needed, add the check_objc_rename postbuild step.
  • WebCore.gyp/mac/check_objc_rename.sh: Added.


1:09 PM Changeset in webkit [77662] by ddkilzer@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

BUILD FIX: REALLY remove the last vestiges of JSVALUE32!

<rdar://problem/8957409> Remove last vestiges of JSVALUE32
<​http://webkit.org/b/53779>

  • DerivedSources.make: Removed dependency on

JavaScriptCore.JSVALUE32.exp.

1:04 PM Changeset in webkit [77661] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-04 Anders Carlsson <​andersca@apple.com>

Reviewed by Mark Rowe.

Mac WebKit2 should use the new drawing area
​https://bugs.webkit.org/show_bug.cgi?id=53802
<rdar://problem/7881419>
<rdar://problem/7881447>
<rdar://problem/8252632>
<rdar://problem/8479422>
<rdar://problem/8633813>
<rdar://problem/8734512>
<rdar://problem/8787660>

  • UIProcess/API/mac/WKView.mm: (useNewDrawingArea): Return true. Eventually this function should be removed, but let's keep it for now so we can go back to the old drawing area if necessary.
12:49 PM Changeset in webkit [77660] by robert@webkit.org
  • 8 edits
    2 adds in trunk

2011-02-04 Robert Hogan <​robert@webkit.org>

Reviewed by Darin Fisher.

Move chromium iframe shim code to cross-platform file.
​https://bugs.webkit.org/show_bug.cgi?id=52594

  • platform/qt/Skipped: Unskip plugins/iframe-shims.html

2011-02-04 Robert Hogan <​robert@webkit.org>

Reviewed by Darin Fisher.

Move chromium iframe shim code to cross-platform file
​https://bugs.webkit.org/show_bug.cgi?id=52594

Move Chromium code for identifying and cutting out
iframe shims from plugins to cross-platform utility file
IFrameShimSupport.cpp.
Amend PluginViewQt to use this code to handle shims correctly.

  • WebCore.gypi: Add Chromium support for IFrameShimSupport.cpp
  • WebCore.pro: Add Qt support for IFrameShimSupport.cpp
  • plugins/IFrameShimSupport.cpp: Added. (WebCore::getObjectStack): (WebCore::iframeIsAbovePlugin): (WebCore::getPluginOcclusions):
  • plugins/IFframeShimSupport.h: Added.
  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::setNPWindowIfNeeded):

2011-02-04 Robert Hogan <​robert@webkit.org>

Reviewed by Darin Fisher.

Move chromium iframe shim code to cross-platform file
​https://bugs.webkit.org/show_bug.cgi?id=52594

  • src/WebPluginContainerImpl.cpp: Move code to WebCore/plugin/IFrameShimSupport.cpp
12:47 PM Changeset in webkit [77659] by mjs@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-04 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Anders Carlsson.

WebKit2: Crash in WebPageProxy::setPendingAPIRequestURL after web process crashed
​https://bugs.webkit.org/show_bug.cgi?id=53799
<rdar://problem/8943956>

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::reload):
12:45 PM Changeset in webkit [77658] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-04 Anders Carlsson <​andersca@apple.com>

Reviewed by Maciej Stachowiak.

Fix a shared memory leak
​https://bugs.webkit.org/show_bug.cgi?id=53800

Move the send right representing the shared memory.

  • Platform/mac/SharedMemoryMac.cpp: (WebKit::SharedMemory::Handle::encode):
12:38 PM Changeset in webkit [77657] by beidson@apple.com
  • 7 edits
    2 adds in trunk

<rdar://problem/8636239> and ​https://bugs.webkit.org/show_bug.cgi?id=53785
WebKit2: Pages with dynamically inserted iframes can add extraneous back/forward items.

Reviewed by Anders Carlsson.

Source/WebKit2:

WebCore doesn't gracefully handle the case where the decidePolicyForNavigationAction callback
does not occur synchronously. Let's make it synchronous.

Change WebPageProxy to handle this message reply synchronously:

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in: Make the navigation policy action message be synchronous.
  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::callMemberFunction): Add a 6-argument varient

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Send the message synchronously.

LayoutTests:

  • fast/loader/dynamic-iframe-extra-back-forward-item-expected.txt: Added.
  • fast/loader/dynamic-iframe-extra-back-forward-item.html: Added.
12:35 PM Changeset in webkit [77656] by sfalken@apple.com
  • 2 edits in trunk/Source/WebKit2

Windows build fix.
Correct prebuild build-stopping rule to allow project only rebuilds.

  • win/WebKit2WebProcessPreBuild.cmd:
12:33 PM Changeset in webkit [77655] by bweinstein@apple.com
  • 2 edits in trunk/Source/WebKit2

Assertion failure in WebInspectorProxy::platformClose closing main window when inspecting a popup
window, or when running regression tests.
​https://bugs.webkit.org/show_bug.cgi?id=53798
<rdar://problem/8814364>

Reviewed by Adam Roben.

Only assert about the state of m_inspectorWindow and m_inspectorView if the inspector is visible.
Also, only call ::DestroyWindow if the HWND is non-null, just to be safe.

  • UIProcess/win/WebInspectorProxyWin.cpp:

(WebKit::WebInspectorProxy::platformClose):

12:30 PM Changeset in webkit [77654] by xji@chromium.org
  • 6 edits in trunk/Source

2011-02-04 Xiaomei Ji <​xji@chromium.org>

Reviewed by David Levin.

Implement "<option> should implement the dir attribute" for chromium port after r76983.
​https://bugs.webkit.org/show_bug.cgi?id=50969

  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::selectItemAlignmentFollowsMenuWritingDirection): Override as true.
  • src/WebViewImpl.cpp: Remove directionality hint from autofill drop-down setting.

2011-02-04 Xiaomei Ji <​xji@chromium.org>

Reviewed by David Levin.

Implement "<option> should implement the dir attribute" for chromium port after r76983.
​https://bugs.webkit.org/show_bug.cgi?id=50969

Use manual test Source/WebCore/manual-tests/pop-up-alignment-and-direction.html
added in r76983.

  • platform/chromium/PopupMenuChromium.cpp: Remove directionality hint from <select> drop-down setting. (WebCore::PopupListBox::paintRow): Use <option>'s directionality to paint items in drop-down and pass-in bidi override flag when creating text run.
  • platform/chromium/PopupMenuChromium.h: Remove directionalityHint from PopupContainerSettings.
12:23 PM Changeset in webkit [77653] by Dimitri Glazkov
  • 1 edit
    10 adds in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

Add platform/mac-leopard baselines for tests added in r77639. The text rendering is
different enough for them to be different from mac-snowleopard.

  • platform/mac-leopard/fast/forms/input-placeholder-visibility-1-expected.checksum: Added.
  • platform/mac-leopard/fast/forms/input-placeholder-visibility-1-expected.png: Added.
  • platform/mac-leopard/fast/forms/input-placeholder-visibility-2-expected.checksum: Added.
  • platform/mac-leopard/fast/forms/input-placeholder-visibility-2-expected.png: Added.
  • platform/mac-leopard/fast/forms/input-placeholder-visibility-3-expected.checksum: Added.
  • platform/mac-leopard/fast/forms/input-placeholder-visibility-3-expected.png: Added.
  • platform/mac-leopard/fast/forms/textarea-placeholder-visibility-1-expected.checksum: Added.
  • platform/mac-leopard/fast/forms/textarea-placeholder-visibility-1-expected.png: Added.
  • platform/mac-leopard/fast/forms/textarea-placeholder-visibility-2-expected.checksum: Added.
  • platform/mac-leopard/fast/forms/textarea-placeholder-visibility-2-expected.png: Added.
12:10 PM Changeset in webkit [77652] by jorlow@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-04 Jeremy Orlow <​jorlow@chromium.org>

Build fix from merge mistake.

  • storage/IDBTransaction.cpp: (WebCore::IDBTransaction::ensureEventTargetData):
11:57 AM Changeset in webkit [77651] by leviw@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-04 Levi Weintraub <​leviw@chromium.org>

Reviewed by Darin Adler.

Remove unneeded function declarations in comments in EditorClient.h
​https://bugs.webkit.org/show_bug.cgi?id=53745

Removing unused commented out function declarations. No tests since this is just cleanup.

  • page/EditorClient.h:
11:50 AM Changeset in webkit [77650] by jorlow@chromium.org
  • 8 edits in trunk/Source/WebCore

2011-02-03 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Nate Chapin.

Refactor IDBRequest and IDBTransaction a bit
​https://bugs.webkit.org/show_bug.cgi?id=53565

There were a lot of subtle issues with the way IDBTransaction
and IDBRequest used to be written. This cleans a lot of them up
and largely simplifies the logic. Using EventQueue rather than
timers is one example of the simplification.

  • bindings/scripts/CodeGeneratorV8.pm:
  • dom/EventQueue.cpp: (WebCore::EventQueue::enqueueEvent): (WebCore::EventQueue::dispatchEvent):
  • storage/IDBCursor.cpp: (WebCore::IDBCursor::continueFunction):
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::create): (WebCore::IDBRequest::IDBRequest): (WebCore::IDBRequest::resetReadyState): (WebCore::IDBRequest::onError): (WebCore::IDBRequest::onSuccess): (WebCore::IDBRequest::dispatchEvent): (WebCore::IDBRequest::enqueueEvent): (WebCore::IDBRequest::eventTargetData): (WebCore::IDBRequest::ensureEventTargetData):
  • storage/IDBRequest.h: (WebCore::IDBRequest::dispatchEvent):
  • storage/IDBTransaction.cpp: (WebCore::IDBTransaction::create): (WebCore::IDBTransaction::IDBTransaction): (WebCore::IDBTransaction::objectStore): (WebCore::IDBTransaction::abort): (WebCore::IDBTransaction::onAbort): (WebCore::IDBTransaction::onComplete): (WebCore::IDBTransaction::onTimeout): (WebCore::IDBTransaction::canSuspend): (WebCore::IDBTransaction::stop): (WebCore::IDBTransaction::enqueueEvent): (WebCore::IDBTransaction::eventTargetData): (WebCore::IDBTransaction::ensureEventTargetData):
  • storage/IDBTransaction.h:
11:38 AM Changeset in webkit [77649] by Dimitri Glazkov
  • 1 edit
    7 adds in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Add baselines for tests, added in r77644.

  • platform/chromium-linux/fast/repaint/slider-thumb-drag-release-expected.checksum: Added.
  • platform/chromium-linux/fast/repaint/slider-thumb-drag-release-expected.png: Added.
  • platform/chromium-mac/fast/repaint/slider-thumb-drag-release-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/slider-thumb-drag-release-expected.png: Added.
  • platform/chromium-win/fast/repaint/slider-thumb-drag-release-expected.checksum: Added.
  • platform/chromium-win/fast/repaint/slider-thumb-drag-release-expected.png: Added.
  • platform/chromium-win/fast/repaint/slider-thumb-drag-release-expected.txt: Added.
11:31 AM Changeset in webkit [77648] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Temporarily add tests added in r77639 as failing, because
we can't see the baselines for these tests (they are in platform/mac-snowleopard).

  • platform/chromium/test_expectations.txt: Added.
11:22 AM Changeset in webkit [77647] by jorlow@chromium.org
  • 27 edits
    2 deletes in trunk

2011-02-01 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Nate Chapin.

Remove the timeout event from IndexedDB
​https://bugs.webkit.org/show_bug.cgi?id=53521

  • storage/indexeddb/tutorial.html:

2011-02-01 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Nate Chapin.

Remove the timeout event from IndexedDB
​https://bugs.webkit.org/show_bug.cgi?id=53521

Remove timeout and ontimeout from IDBTransaction per the spec.

  • WebCore.gypi:
  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::transaction):
  • storage/IDBDatabase.h: (WebCore::IDBDatabase::transaction):
  • storage/IDBDatabase.idl:
  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::setVersion): (WebCore::IDBDatabaseBackendImpl::transaction):
  • storage/IDBDatabaseBackendImpl.h:
  • storage/IDBDatabaseBackendInterface.h:
  • storage/IDBTimeoutEvent.cpp: Removed.
  • storage/IDBTimeoutEvent.h: Removed.
  • storage/IDBTransaction.cpp: (WebCore::IDBTransaction::IDBTransaction): (WebCore::IDBTransaction::onAbort): (WebCore::IDBTransaction::onComplete):
  • storage/IDBTransaction.h:
  • storage/IDBTransaction.idl:
  • storage/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::create): (WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
  • storage/IDBTransactionBackendImpl.h:
  • storage/IDBTransactionCallbacks.h:

2011-02-01 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Nate Chapin.

Remove the timeout event from IndexedDB
​https://bugs.webkit.org/show_bug.cgi?id=53521

  • public/WebIDBDatabase.h: (WebKit::WebIDBDatabase::transaction):
  • public/WebIDBTransactionCallbacks.h:
  • src/IDBDatabaseProxy.cpp: (WebCore::IDBDatabaseProxy::transaction):
  • src/IDBDatabaseProxy.h:
  • src/IDBTransactionCallbacksProxy.cpp:
  • src/IDBTransactionCallbacksProxy.h:
  • src/WebIDBDatabaseImpl.cpp: (WebKit::WebIDBDatabaseImpl::transaction):
  • src/WebIDBDatabaseImpl.h:
  • src/WebIDBTransactionCallbacksImpl.cpp:
  • src/WebIDBTransactionCallbacksImpl.h:
11:16 AM Changeset in webkit [77646] by Dimitri Glazkov
  • 2 edits
    25 adds in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Add baselines for tests, added in r77639.

  • platform/chromium-linux/fast/forms/input-placeholder-visibility-1-expected.checksum: Added.
  • platform/chromium-linux/fast/forms/input-placeholder-visibility-1-expected.png: Added.
  • platform/chromium-linux/fast/forms/input-placeholder-visibility-2-expected.checksum: Added.
  • platform/chromium-linux/fast/forms/input-placeholder-visibility-2-expected.png: Added.
  • platform/chromium-linux/fast/forms/input-placeholder-visibility-3-expected.checksum: Added.
  • platform/chromium-linux/fast/forms/input-placeholder-visibility-3-expected.png: Added.
  • platform/chromium-linux/fast/forms/textarea-placeholder-visibility-1-expected.checksum: Added.
  • platform/chromium-linux/fast/forms/textarea-placeholder-visibility-1-expected.png: Added.
  • platform/chromium-linux/fast/forms/textarea-placeholder-visibility-2-expected.checksum: Added.
  • platform/chromium-linux/fast/forms/textarea-placeholder-visibility-2-expected.png: Added.
  • platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.checksum: Added.
  • platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.png: Added.
  • platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.txt: Added.
  • platform/chromium-win/fast/forms/input-placeholder-visibility-2-expected.checksum: Added.
  • platform/chromium-win/fast/forms/input-placeholder-visibility-2-expected.png: Added.
  • platform/chromium-win/fast/forms/input-placeholder-visibility-2-expected.txt: Added.
  • platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.checksum: Added.
  • platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.png: Added.
  • platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.txt: Added.
  • platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.checksum: Added.
  • platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.png: Added.
  • platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.txt: Added.
  • platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.checksum: Added.
  • platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.png: Added.
  • platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
10:47 AM Changeset in webkit [77645] by Chris Fleizach
  • 2 edits in trunk/Source/WebCore

AX: Can't set accessibility overridden attributes on web objects
​https://bugs.webkit.org/show_bug.cgi?id=53725

Reviewed by Darin Adler.

accessibilitySetOverriddenValue does not work on AX objects from WebCore because
the right method needed to be overridden (accessibilitySupportsOverriddenAttributes).
Unfortunately, there's no way to test this from DRT, since AppKit returns the overridden
attribute only when an AX client asks for it through the AX frameworks.

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilitySupportsOverriddenAttributes]):

10:42 AM Changeset in webkit [77644] by Dimitri Glazkov
  • 3 edits
    4 adds in trunk

2011-02-03 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Kent Tamura.

REGRESSION(r76147): Slider thumb is not repainted when let go outside of the slider track.
​https://bugs.webkit.org/show_bug.cgi?id=53691

  • fast/repaint/slider-thumb-drag-release.html: Added.
  • platform/mac/fast/repaint/slider-thumb-drag-release-expected.checksum: Added.
  • platform/mac/fast/repaint/slider-thumb-drag-release-expected.png: Added.
  • platform/mac/fast/repaint/slider-thumb-drag-release-expected.txt: Added.

2011-02-03 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Kent Tamura.

REGRESSION(r76147): Slider thumb is not repainted when let go outside of the slider track.
​https://bugs.webkit.org/show_bug.cgi?id=53691

Test: fast/repaint/slider-thumb-drag-release.html

  • html/shadow/SliderThumbElement.cpp: (WebCore::SliderThumbElement::stopDragging): Added dirtying the layout bit to ensure

that the thumb is repainted.

10:32 AM Changeset in webkit [77643] by mnaganov@chromium.org
  • 7 edits
    2 adds in trunk/Source/WebCore

2011-02-04 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Add "show more" data grid node and waiting message UI components.
​https://bugs.webkit.org/show_bug.cgi?id=53763

  • "show more" data grid node is used for on-demand population of data grid contents (similar to DOM tree capability for limiting displayed nodes count);
  • waiting message is used for informing user about long lasting operations (with a possibility to cancel them).
  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/PleaseWaitMessage.js: Added. (WebInspector.PleaseWaitMessage):
  • inspector/front-end/ShowMoreDataGridNode.js: Added. (WebInspector.ShowMoreDataGridNode):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css: (.data-grid button): (.please-wait-msg):
  • inspector/front-end/inspector.html:
10:32 AM Changeset in webkit [77642] by Dimitri Glazkov
  • 16 edits in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

Update mac baselines. They pixel-rotted.

  • platform/mac-leopard/fast/backgrounds/background-clip-text-expected.png:
  • platform/mac-leopard/fast/backgrounds/quirks-mode-line-box-backgrounds-expected.png:
  • platform/mac-leopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.checksum:
  • platform/mac-leopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
  • platform/mac-leopard/fast/backgrounds/size/backgroundSize15-expected.png:
  • platform/mac-leopard/fast/backgrounds/size/backgroundSize22-expected.checksum:
  • platform/mac-leopard/fast/backgrounds/size/backgroundSize22-expected.png:
  • platform/mac/fast/backgrounds/animated-svg-as-background-expected.checksum:
  • platform/mac/fast/backgrounds/animated-svg-as-background-expected.png:
  • platform/mac/fast/backgrounds/animated-svg-as-mask-expected.checksum:
  • platform/mac/fast/backgrounds/animated-svg-as-mask-expected.png:
  • platform/mac/fast/backgrounds/size/contain-and-cover-expected.checksum:
  • platform/mac/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/mac/fast/backgrounds/svg-as-background-4-expected.checksum:
  • platform/mac/fast/backgrounds/svg-as-background-4-expected.png:
10:27 AM Changeset in webkit [77641] by mnaganov@chromium.org
  • 2 edits in trunk/Tools

2011-02-04 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: fix processing Unicode literals from .js sources in check-inspector-strings.
​https://bugs.webkit.org/show_bug.cgi?id=53781

  • Scripts/check-inspector-strings:
10:25 AM Changeset in webkit [77640] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-04 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Go out of accelerated compositing mode when the drawing area is destroyed
​https://bugs.webkit.org/show_bug.cgi?id=53788

This fixes a crash in the UI process if a web process crashes while in accelerated compositing mode.

  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::~DrawingAreaProxyImpl):
10:18 AM Changeset in webkit [77639] by adele@apple.com
  • 6 edits
    36 adds
    4 deletes in trunk

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=53740
<rdar://problem/8503629> Allow platforms to specify if the placeholder should be visible when text controls are focused

Reviewed by Dan Bernstein.

Tests:
fast/forms/textarea-placeholder-visibility-1.html
fast/forms/textarea-placeholder-visibility-2.html
fast/forms/input-placeholder-visibility-1.html
fast/forms/input-placeholder-visibility-2.html
fast/forms/input-placeholder-visibility-3.html

  • html/HTMLFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible):

Add a check for shouldShowPlaceholderWhenFocused.

  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::updateValue):

Whenever the value is updated, we should also update placeholder visibility.

  • rendering/RenderTheme.h: (WebCore::RenderTheme::shouldShowPlaceholderWhenFocused):

Make the default the same as the existing behavior.

  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::shouldShowPlaceholderWhenFocused):

Show placeholder when appropriate.

10:13 AM Changeset in webkit [77638] by ddkilzer@apple.com
  • 4 edits
    1 delete in trunk/Source/JavaScriptCore

<rdar://problem/8957409> Remove last vestiges of JSVALUE32
<​http://webkit.org/b/53779>

Reviewed by Darin Adler.

Support for JSVALUE32 was originaly removed in r70111.

  • Configurations/JavaScriptCore.xcconfig: Changed armv6 to use

JavaScriptCore.JSVALUE32_64.exp and ppc64 to use
JavaScriptCore.JSVALUE64.exp to match Platform.h.

  • DerivedSources.make: Removed rule for

JavaScriptCore.JSVALUE32.exp.

to JavaScriptCore.JSVALUE32only.exp.

10:02 AM Changeset in webkit [77637] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Tweak expectations for passing tests.

  • platform/chromium/test_expectations.txt: More tweakage.
10:01 AM Changeset in webkit [77636] by Adam Roben
  • 2 edits in trunk/Tools

Include the crashing function in the link to a crash log on Mac

Fixes <​http://webkit.org/b/53780> Crash log links in results.html should include the
function that crashed on Mac

Reviewed by David Kilzer.

  • Scripts/old-run-webkit-tests:

(crashLocation): Moved all the Windows code inside an if instead of using an early return,
but didn't otherwise change it. Added an if for Mac that parses the crashing function out of
the crash log.

9:31 AM Changeset in webkit [77635] by ddkilzer@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Use static_cast and other style cleanup in YarrInterpreter.cpp
<​http://webkit.org/b/53772>

Reviewed by John Sullivan.

  • yarr/YarrInterpreter.cpp:

(JSC::Yarr::Interpreter::InputStream::readChecked): Use
static_cast.
(JSC::Yarr::Interpreter::InputStream::checkInput): Remove
unnecessary else block.
(JSC::Yarr::Interpreter::matchAssertionEOL): Ditto.
(JSC::Yarr::Interpreter::backtrackBackReference): Ditto.
(JSC::Yarr::ByteCompiler::emitDisjunction): Use static_cast.

9:20 AM Changeset in webkit [77634] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Remove more passing tests.

  • platform/chromium/test_expectations.txt: Even more passages removed.
9:07 AM Changeset in webkit [77633] by Adam Roben
  • 2 edits in trunk/Tools

Link to Mac crash logs from results.html

Fixes <​http://webkit.org/b/14861> run-webkit-tests should link to Mac crash logs in
results.html

Reviewed by David Kilzer.

  • Scripts/old-run-webkit-tests:

(captureSavedCrashLog): Added a case for Apple's Mac port. We get the crash log out of
~/Library/Logs/CrashReporter, and wait for ReportCrash to exit before trying to get the log.

9:05 AM Changeset in webkit [77632] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Removed passing tests.

  • platform/chromium/test_expectations.txt: Passages removed.
8:38 AM Changeset in webkit [77631] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-04 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: evaluate on hover does not work on a breakpoint.
​https://bugs.webkit.org/show_bug.cgi?id=53768

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._mouseHover):
8:28 AM Changeset in webkit [77630] by loislo@chromium.org
  • 23 edits
    2 adds
    4 deletes in trunk/Source

2011-02-04 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r77625 and r77626.
​http://trac.webkit.org/changeset/77625
​http://trac.webkit.org/changeset/77626
​https://bugs.webkit.org/show_bug.cgi?id=53765

It broke Windows builds (Requested by Ossy_ on #webkit).

  • Android.jscbindings.mk:
  • CMakeLists.txt:
  • ForwardingHeaders/pcre/pcre.h: Added.
  • ForwardingHeaders/yarr/Yarr.h: Removed.
  • ForwardingHeaders/yarr/YarrInterpreter.h: Removed.
  • ForwardingHeaders/yarr/YarrPattern.h: Removed.
  • WebCore.gyp/WebCore.gyp:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/copyForwardingHeaders.cmd:
  • platform/text/RegularExpression.cpp: (WebCore::RegularExpression::Private::regexp): (WebCore::RegularExpression::Private::compile): (WebCore::RegularExpression::Private::Private): (WebCore::RegularExpression::Private::create): (WebCore::RegularExpression::Private::~Private): (WebCore::RegularExpression::match):

2011-02-04 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r77625 and r77626.
​http://trac.webkit.org/changeset/77625
​http://trac.webkit.org/changeset/77626
​https://bugs.webkit.org/show_bug.cgi?id=53765

It broke Windows builds (Requested by Ossy_ on #webkit).

8:24 AM Changeset in webkit [77629] by mnaganov@chromium.org
  • 1 edit in branches/chromium/648/Source/WebCore/inspector/front-end/NetworkPanel.js

Merge 77623 - 2011-02-04 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Network panel filtering is broken.
​https://bugs.webkit.org/show_bug.cgi?id=53764

  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._sortItems): (WebInspector.NetworkPanel.prototype._sortByTimeline): (WebInspector.NetworkPanel.prototype._filter): (WebInspector.NetworkPanel.prototype._updateOffscreenRows): (WebInspector.NetworkDataGridNode.prototype.isFilteredOut): (WebInspector.NetworkDataGridNode.prototype.get selectable): (WebInspector.NetworkTotalGridNode.prototype.isFilteredOut): (WebInspector.NetworkTotalGridNode.prototype.get selectable):

TBR=​pfeldman@chromium.org
Review URL: ​http://codereview.chromium.org/6286112

7:51 AM Changeset in webkit [77628] by jberlin@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix. Unreviewed.

7:21 AM Changeset in webkit [77627] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

[Windows 7 Release Tests] transitions/transition-end-event-multiple-04.html flakey
​https://bugs.webkit.org/show_bug.cgi?id=53332

Unreviewed, attempt to get the Windows 7 Release bots uniformly green.

  • platform/win/Skipped:
6:54 AM Changeset in webkit [77626] by pvarga@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-04 Peter Varga <​pvarga@webkit.org>

Rubber-stamped by Csaba Osztrogonác.

Replace PCRE with Yarr in WebCore
​https://bugs.webkit.org/show_bug.cgi?id=53496

Speculative windows build fix.

No new tests needed.

  • platform/text/RegularExpression.cpp:
6:29 AM Changeset in webkit [77625] by pvarga@webkit.org
  • 23 edits
    5 adds
    1 delete in trunk/Source

2011-02-04 Peter Varga <​pvarga@webkit.org>

Reviewed by Gavin Barraclough.

Replace PCRE with Yarr in WebCore
​https://bugs.webkit.org/show_bug.cgi?id=53496

2011-02-04 Peter Varga <​pvarga@webkit.org>

Reviewed by Gavin Barraclough.

Replace PCRE with Yarr in WebCore
​https://bugs.webkit.org/show_bug.cgi?id=53496

No new tests needed.

  • Android.jscbindings.mk:
  • CMakeLists.txt:
  • ForwardingHeaders/pcre/pcre.h: Removed.
  • ForwardingHeaders/yarr/Yarr.h: Added.
  • ForwardingHeaders/yarr/YarrInterpreter.h: Added.
  • ForwardingHeaders/yarr/YarrPattern.h: Added.
  • WebCore.gyp/WebCore.gyp:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/copyForwardingHeaders.cmd:
  • platform/text/RegularExpression.cpp: (WebCore::RegularExpression::Private::create): (WebCore::RegularExpression::Private::Private): (WebCore::RegularExpression::Private::compile): (WebCore::RegularExpression::match):
6:27 AM Changeset in webkit [77624] by loislo@chromium.org
  • 1 edit
    8 adds in trunk/LayoutTests

2011-02-04 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed.

Rebaseline. The problem was introduced at r77601.

  • platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.png: Added.
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Added.
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.png: Added.
  • platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.png: Added.
6:22 AM Changeset in webkit [77623] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-04 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Network panel filtering is broken.
​https://bugs.webkit.org/show_bug.cgi?id=53764

  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._sortItems): (WebInspector.NetworkPanel.prototype._sortByTimeline): (WebInspector.NetworkPanel.prototype._filter): (WebInspector.NetworkPanel.prototype._updateOffscreenRows): (WebInspector.NetworkDataGridNode.prototype.isFilteredOut): (WebInspector.NetworkDataGridNode.prototype.get selectable): (WebInspector.NetworkTotalGridNode.prototype.isFilteredOut): (WebInspector.NetworkTotalGridNode.prototype.get selectable):
5:47 AM Changeset in webkit [77622] by loislo@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

2011-02-04 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed.

Rebaseline image for fast/box-shadow/shadow-tiling-artifact.html
The problem was introduced at r77601.

  • platform/chromium-linux/fast/box-shadow/shadow-tiling-artifact-expected.checksum: Added.
  • platform/chromium-linux/fast/box-shadow/shadow-tiling-artifact-expected.png: Added.
  • platform/chromium-win/fast/box-shadow/shadow-tiling-artifact-expected.checksum: Added.
  • platform/chromium-win/fast/box-shadow/shadow-tiling-artifact-expected.png: Added.
5:32 AM Changeset in webkit [77621] by sergio@webkit.org
  • 1 edit
    10 adds in trunk/LayoutTests

2011-02-04 Sergio Villar Senin <​svillar@igalia.com>

Unreviewed.

New test expectations.

  • platform/gtk/fast/box-shadow/shadow-tiling-artifact-expected.txt: Added.
  • platform/gtk/fast/dom/HTMLInputElement/input-slider-update-expected.txt: Added.
  • platform/gtk/svg/text/font-size-below-point-five-2-expected.txt: Added.
  • platform/gtk/svg/text/font-size-below-point-five-expected.txt: Added.
  • platform/gtk/svg/text/scaled-font-expected.txt: Added.
  • platform/gtk/svg/text/small-fonts-2-expected.txt: Added.
  • platform/gtk/svg/text/small-fonts-3-expected.txt: Added.
  • platform/gtk/svg/text/small-fonts-expected.txt: Added.
  • platform/gtk/svg/text/small-fonts-in-html5-expected.txt: Added.
5:25 AM Changeset in webkit [77620] by caseq@chromium.org
  • 8 edits in trunk

2011-02-04 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: support overriding user agent strings
​https://bugs.webkit.org/show_bug.cgi?id=51485

Test: http/tests/inspector/extensions-useragent.html

  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::setUserAgentOverride): (WebCore::InspectorController::userAgentOverride):
  • inspector/InspectorController.h:
  • inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI.InspectedWindow.prototype.reload):
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onReload):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::userAgent): (WebCore::FrameLoader::applyUserAgent):

2011-02-04 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: support overriding user agent strings
​https://bugs.webkit.org/show_bug.cgi?id=51485

  • http/tests/inspector/extensions-useragent-expected.txt: Added.
  • http/tests/inspector/extensions-useragent.html: Added.
5:03 AM Changeset in webkit [77619] by loislo@chromium.org
  • 5 edits in trunk/Source/JavaScriptCore

2011-02-04 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed rollout two patches r77614 and r77612.

REGRESSION: Snow Leopard Intell Release anumber of failing tests.

  • runtime/Heap.cpp: (JSC::Heap::Heap): (JSC::Heap::reset):
  • runtime/Heap.h:
  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::allocate): (JSC::MarkedSpace::sweep): (JSC::MarkedSpace::reset):
  • runtime/MarkedSpace.h:
4:40 AM Changeset in webkit [77618] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-04 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: scripts panel displays wrong file name after reload.
​https://bugs.webkit.org/show_bug.cgi?id=53761

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._resourceLoadingFinished):
3:34 AM Changeset in webkit [77617] by yurys@chromium.org
  • 27 edits in trunk/Source

2011-02-03 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove settings related methods from InspectorClient
​https://bugs.webkit.org/show_bug.cgi?id=53686

  • WebCore.exp.in:
  • inspector/CodeGeneratorInspector.pm:
  • inspector/InspectorClient.h:
  • inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal): (WebCore::InspectorFrontendClientLocal::changeAttachedWindowHeight): (WebCore::InspectorFrontendClientLocal::restoreAttachedWindowHeight):
  • inspector/InspectorFrontendClientLocal.h: ports that provide in-process implementation of the inspector front-end can provide platform-specific settings accessor. (WebCore::InspectorFrontendClientLocal::Settings::Settings): (WebCore::InspectorFrontendClientLocal::Settings::~Settings): (WebCore::InspectorFrontendClientLocal::Settings::inspectorAttachedHeight): (WebCore::InspectorFrontendClientLocal::Settings::storeInspectorAttachedHeight):
  • loader/EmptyClients.h:

2011-02-03 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove settings related methods from InspectorClient
​https://bugs.webkit.org/show_bug.cgi?id=53686

  • WebCoreSupport/WebInspectorClientCF.cpp: (populateSetting): (storeSetting): (WebInspectorClient::createFrontendSettings):

2011-02-03 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove settings related methods from InspectorClient
​https://bugs.webkit.org/show_bug.cgi?id=53686

  • WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorFrontendClient::InspectorFrontendClient):
  • WebCoreSupport/InspectorClientGtk.h:

2011-02-03 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove settings related methods from InspectorClient
​https://bugs.webkit.org/show_bug.cgi?id=53686

  • WebCoreSupport/WebInspectorClient.h:
  • WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::openInspectorFrontend): (WebInspectorFrontendClient::WebInspectorFrontendClient):

2011-02-03 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove settings related methods from InspectorClient
​https://bugs.webkit.org/show_bug.cgi?id=53686

  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorFrontendClientQt::InspectorFrontendClientQt):
  • WebCoreSupport/InspectorClientQt.h:

2011-02-03 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove settings related methods from InspectorClient
​https://bugs.webkit.org/show_bug.cgi?id=53686

  • WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::openInspectorFrontend): (WebInspectorFrontendClient::WebInspectorFrontendClient):
  • WebCoreSupport/WebInspectorClient.h:

2011-02-03 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove settings related methods from InspectorClient
​https://bugs.webkit.org/show_bug.cgi?id=53686

  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp: (WebKit::WebInspectorFrontendClient::WebInspectorFrontendClient):
2:32 AM Changeset in webkit [77616] by sergio@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-04 Sergio Villar Senin <​svillar@igalia.com>

Unreviewed.

Skipping fast/events/pagehide-timeout.html that is failing on GTK
bots. See ​https://bugs.webkit.org/show_bug.cgi?id=53733

  • platform/gtk/Skipped: skip fast/events/pagehide-timeout.html
12:49 AM Changeset in webkit [77615] by loislo@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-02-04 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed.

Roll chromium to 73764.

  • DEPS:
12:12 AM Changeset in webkit [77614] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Try to fix 32bit build.

  • runtime/Heap.cpp:

(JSC::Heap::reset): Use an explicit cast to avoid shortening warnings,
since 1.5 is double (64bit), and the result is size_t (32bit).

Note: See TracTimeline for information about the timeline view.