⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 6, 2011:

11:20 PM Changeset in webkit [77791] by mjs@apple.com
  • 2 edits in trunk/Tools

2011-02-06 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Daniel Bates.

Add WebKit2 bot to list of expected builders in Python regression test results.
​https://bugs.webkit.org/show_bug.cgi?id=53905

  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
10:49 PM Changeset in webkit [77790] by mjs@apple.com
  • 2 edits in trunk/Tools

2011-02-06 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Ryosuke Niwa.

Update test expectations for new core builder
​https://bugs.webkit.org/show_bug.cgi?id=53904

  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
10:20 PM Changeset in webkit [77789] by mjs@apple.com
  • 2 edits in trunk/Tools

2011-02-06 Maciej Stachowiak <​mjs@apple.com>

Reviewed by David Levin.

Add WebKit2 test bot to core builders
​https://bugs.webkit.org/show_bug.cgi?id=53901

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:
9:47 PM Changeset in webkit [77788] by rniwa@webkit.org
  • 2 edits in trunk/Tools

2011-02-06 Ryosuke Niwa <​rniwa@webkit.org>

Another unreviewed Chromium build fix.

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::pathToLocalResource):
9:29 PM Changeset in webkit [77787] by rniwa@webkit.org
  • 4 edits in trunk

2011-02-06 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed Chromium build fix.

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::pathToLocalResource):

2011-02-06 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed; speculative Qt build fix.

  • WebKit2.pro:
9:19 PM Changeset in webkit [77786] by rniwa@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-06 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed; speculative Qt build fix.

9:01 PM Changeset in webkit [77785] by rniwa@webkit.org
  • 44 edits
    3 deletes in trunk

2011-02-06 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
​https://bugs.webkit.org/show_bug.cgi?id=52867

  • DumpRenderTree/chromium/ImageDiff.cpp: (Image::craeteFromStdin): Call adoptArrayPtr.

2011-02-06 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
​https://bugs.webkit.org/show_bug.cgi?id=52867

Removed LOOSE_OWN_ARRAY_PTR and OwnArrayPtr<T>::set. Replaced all calls to OwnArrayPtr::set
and loose instantiation of OwnArrayPtr by calls to operator= and adoptArrayPtr. Also removed
OwnArrayPtrCommon.h since PassOwnArrayPtr.h needs to include OwnArrayPtr.h and there is
no point in putting deleteOwnedArrayPtr into a separate header.


Note: if this patch breaks build, the code is either instiantiating OwnArrayPtr
without calling adoptArrayPtr or calling set on ArrayOwnPtr instead of operator=.

No tests are added since this is a refactoring.

  • API/JSStringRefCF.cpp: (JSStringCreateWithCFString): Calls adoptArrayPtr.
  • GNUmakefile.am: Removed OwnArrayPtrCommon.h
  • JavaScriptCore.vcproj/WTF/WTF.vcproj: Ditto.
  • JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
  • runtime/Arguments.cpp: (JSC::Arguments::deleteProperty): Calls adoptArrayPtr.
  • runtime/Arguments.h: (JSC::Arguments::copyRegisters): Ditto.
  • runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::JSPropertyNameIterator): Ditto.
  • runtime/JSVariableObject.h: (JSC::JSVariableObject::setRegisters): Calls operator= instead of set.
  • runtime/StructureChain.cpp: (JSC::StructureChain::StructureChain): Ditto.
  • wtf/CMakeLists.txt:
  • wtf/DateMath.h: (JSC::GregorianDateTime::GregorianDateTime): No longer instnatiates OwnArrayPtr with a null pointer.
  • wtf/OwnArrayPtr.h:
  • wtf/OwnArrayPtrCommon.h: Removed.
  • wtf/PassOwnArrayPtr.h: No longer includes OwnArrayCommon.h (WTF::deleteOwnedArrayPtr): Moved from OwnArrayPtrCommon.h

2011-02-06 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
​https://bugs.webkit.org/show_bug.cgi?id=52867

  • ForwardingHeaders/wtf/OwnArrayPtrCommon.h: Removed.

2011-02-06 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
​https://bugs.webkit.org/show_bug.cgi?id=52867

  • WebHistory.cpp: (WebHistory::orderedLastVisitedDays): Calls adoptArrayPtr.
  • WebPreferences.cpp: (WebPreferences::copyWebKitPreferencesToCFPreferences): Ditto.

2011-02-06 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
​https://bugs.webkit.org/show_bug.cgi?id=52867

  • ForwardingHeaders/wtf/OwnArrayPtrCommon.h: Removed.
  • bindings/v8/NPV8Object.cpp: (WebCore::createValueListFromVariantArgs): Returns PassOwnArrayPtr<v8::Handle<v8::Value>> instead of v8::Handle<v8::Value>*. (_NPN_Invoke): Calls createValueListFromVariantArgs. (_NPN_InvokeDefault): createValueListFromVariantArgs. (_NPN_Construct): createValueListFromVariantArgs.
  • bindings/v8/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::call): Calls adoptArrayPtr. (WebCore::ScriptFunctionCall::construct): Ditto. (WebCore::ScriptCallback::call):
  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::createNewContext): Ditto.
  • bindings/v8/V8NPObject.cpp: (WebCore::npObjectInvokeImpl): Ditto
  • bindings/v8/V8NodeFilterCondition.cpp: (WebCore::V8NodeFilterCondition::acceptNode): Ditto,
  • html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::parseMappedAttribute): Calls newCoordsArray.
  • html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::parseMappedAttribute): Calls newLengthArray.
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getAttachedShaders): Calls adoptArraYptr. (WebCore::WebGLRenderingContext::simulateVertexAttrib0): Ditto. (WebCore::WebGLRenderingContext::LRUImageBufferCache::LRUImageBufferCache): Dito.
  • platform/Length.cpp: (WebCore::newCoordsArray): Returns PassOwnArrayPtr<Length> instead of Length*. (WebCore::newLengthArray): Returns PassOwnArrayPtr<Length> instead of Length*.
  • platform/Length.h: Prototype changes.
  • platform/graphics/ANGLEWebKitBridge.cpp: (WebCore::ANGLEWebKitBridge::validateShaderSource): Calls adoptArrayPtr.
  • platform/graphics/ca/win/CACFLayerTreeHost.cpp: (WebCore::getDirtyRects): Ditto.
  • platform/graphics/chromium/ComplexTextControllerLinux.cpp: (WebCore::ComplexTextController::getNormalizedTextRun): Ditto.
  • platform/graphics/chromium/HarfbuzzSkia.cpp: (WebCore::glyphsToAdvances): Ditto. (WebCore::canRender): Ditto.
  • platform/graphics/gpu/Texture.cpp: (WebCore::Texture::updateSubRect): Ditto.
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: (WebCore::GraphicsContext3D::paintRenderingResultsToCanvas): Ditto.
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::readbackHardwareToSoftware): Ditto.
  • platform/graphics/wince/SharedBitmap.cpp: (WebCore::SharedBitmap::to16bit): Ditto.
  • platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::getContextMenuItems): Ditto.
  • platform/win/LoggingWin.cpp: (WebCore::initializeWithUserDefault): Ditto.
  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::fetchInfo): Ditto.

2011-02-06 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
​https://bugs.webkit.org/show_bug.cgi?id=52867

  • Shared/Plugins/Netscape/win/NetscapePluginModuleWin.cpp: (WebKit::NetscapePluginModule::getPluginInfo): Calls adoptArrayPtr.
8:54 PM Changeset in webkit [77784] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-06 Kent Tamura <​tkent@chromium.org>

Unreviewed.

  • WebCore.xcodeproj/project.pbxproj: Run sort-xcode-project-file.
8:08 PM Changeset in webkit [77783] by Patrick Gansterer
  • 2 edits in trunk/Source/WebKit/wince

2011-02-06 Patrick Gansterer <Patrick Gansterer>

Reviewed by Martin Robinson.

[WINCE] FrameLoaderClient calls loadURLInChildFrame on the child's frame loader
​https://bugs.webkit.org/show_bug.cgi?id=53896

  • WebView.cpp: (WebView::createFrame): Use coreFrame instead of childFrame.
6:20 PM Changeset in webkit [77782] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-02-06 MORITA Hajime <​morrita@google.com>

Unreviewed, unskip the html5lib test again which fails for another reason. (See Bug 53030)

  • platform/qt/Skipped:
5:40 PM Changeset in webkit [77781] by morrita@google.com
  • 13 edits in trunk

2011-02-06 Dominic Cooney <​dominicc@google.com>

Reviewed by Dimitri Glazkov.

Convert <keygen> option elements to a shadow DOM
​https://bugs.webkit.org/show_bug.cgi?id=51379

  • html5lib/runner-expected.txt: Two more tests pass.
  • platform/mac/fast/html/keygen-expected.txt: Shadow render tree.
  • platform/mac/fast/invalid/residual-style-expected.txt:

2011-02-03 Dominic Cooney <​dominicc@google.com>

Reviewed by Dimitri Glazkov.

Convert <keygen> option elements to a shadow DOM
​https://bugs.webkit.org/show_bug.cgi?id=51379

Covered by existing tests e.g. fast/html/keygen.html,
html5lib/runner.html, etc.

  • css/html.css: (form): Cleanup. (keygen, select): Border radii should match so focus ring looks good. (keygen::-webkit-keygen-select): No margin on the shadow element. (select): Hoisting border radius to keygen, select rule.
  • dom/SelectElement.cpp: (WebCore::toSelectElement): keygen is no longer a select element.
  • html/HTMLKeygenElement.cpp: Implements keygen shadow. (WebCore::KeygenSelectElement::create): (WebCore::KeygenSelectElement::shadowPseudoId): (WebCore::KeygenSelectElement::KeygenSelectElement): (WebCore::HTMLKeygenElement::HTMLKeygenElement): (WebCore::HTMLKeygenElement::parseMappedAttribute): (WebCore::HTMLKeygenElement::appendFormData): (WebCore::HTMLKeygenElement::formControlType): (WebCore::HTMLKeygenElement::reset): (WebCore::HTMLKeygenElement::selectShadow):
  • html/HTMLKeygenElement.h: keygen is no longer a select on C++ side. (WebCore::HTMLKeygenElement::canStartSelection): (WebCore::HTMLKeygenElement::isEnumeratable): (WebCore::HTMLKeygenElement::isResettable):
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::ownerSelectElement): Only owned by selects.
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::HTMLSelectElement): Only 'select' tag name.
5:00 PM Changeset in webkit [77780] by commit-queue@webkit.org
  • 1 edit
    5 adds in trunk/Tools

2011-02-06 James Kozianski <​koz@chromium.org>

Reviewed by Ojan Vafai.

Add classes for representing test outputs.
​https://bugs.webkit.org/show_bug.cgi?id=52136

These classes will make it easier to write scripts that deal with test
outputs such as rebaselining and deduping scripts. The intent is that
eventually we will be have buildbot return TestOutputs for a
particular build which can be compared with TestOutputs derived from a
local LayoutTests directory.

  • Scripts/webkitpy/common/net/testoutput.py: Added.
  • Scripts/webkitpy/common/net/testoutput_unittest.py: Added.
  • Scripts/webkitpy/common/net/testoutputset.py: Added.
  • Scripts/webkitpy/common/net/testoutputset_unittest.py: Added.
  • Scripts/webkitpy/common/system/zip_mock.py: Added.
3:48 PM Changeset in webkit [77779] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-06 Benjamin Poulain <​ikipou@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix coding style errors in ClipboardQt.h
​https://bugs.webkit.org/show_bug.cgi?id=43520

Fix coding style: order of header and indentation.

  • platform/qt/ClipboardQt.h: (WebCore::ClipboardQt::create): (WebCore::ClipboardQt::clipboardData): (WebCore::ClipboardQt::invalidateWritableData):
2:16 PM Changeset in webkit [77778] by Patrick Gansterer
  • 1 edit
    6 deletes in trunk/LayoutTests

2011-02-06 Patrick Gansterer <Patrick Gansterer>

Reviewed by Oliver Hunt.

Remove empty svg test
​https://bugs.webkit.org/show_bug.cgi?id=53887

This files are empty. Empty tests are pretty useless.

  • platform/chromium-win/svg/custom/use-infinite-recursion-expected.png: Removed.
  • platform/mac/svg/custom/use-infinite-recursion-expected.checksum: Removed.
  • platform/mac/svg/custom/use-infinite-recursion-expected.png: Removed.
  • platform/mac/svg/custom/use-infinite-recursion-expected.txt: Removed.
  • platform/qt/svg/custom/use-infinite-recursion-expected.txt: Removed.
  • svg/custom/use-infinite-recursion.svg: Removed.
12:43 PM Changeset in webkit [77777] by Antti Koivisto
  • 8 edits
    2 adds in trunk/Source

Use bloom filter for descendant selector filtering
​https://bugs.webkit.org/show_bug.cgi?id=53880

Reviewed by Maciej Stachowiak.

Source/JavaScriptCore:

Implement a bloom filter with k=2 and 8 bit counting.

(WTF::BloomFilter::maximumCount):
(WTF::BloomFilter::BloomFilter):
(WTF::BloomFilter::mayContain):
(WTF::BloomFilter::add):
(WTF::BloomFilter::remove):
(WTF::BloomFilter::firstSlot):
(WTF::BloomFilter::secondSlot):
(WTF::::add):
(WTF::::remove):
(WTF::::clear):
(WTF::::likelyEmpty):
(WTF::::isClear):

Source/WebCore:

Bloom filter is faster than a hash set in this kind of use.

Shark thinks this speeds up style matching by ~30% on sites
with lots of descendant selectors.

  • ForwardingHeaders/wtf/BloomFilter.h: Added.
  • css/CSSStyleSelector.cpp:

(WebCore::collectElementIdentifierHashes):
(WebCore::CSSStyleSelector::pushParent):
(WebCore::CSSStyleSelector::popParent):
(WebCore::CSSStyleSelector::fastRejectSelector):
(WebCore::RuleData::collectDescendantSelectorIdentifierHashes):

  • css/CSSStyleSelector.h:
12:05 PM Changeset in webkit [77776] by mjs@apple.com
  • 2 edits in trunk/Source/WebCore

2011-02-06 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Antti Koivisto.

media/video-document-types.html sometimes crashes the WebProcess
​https://bugs.webkit.org/show_bug.cgi?id=53884

No new tests. Already covered by media/video-document-types.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::userCancelledLoad): Stop the load timer when cancelling the load.
10:52 AM Changeset in webkit [77775] by Patrick Gansterer
  • 15 edits in trunk/Source/WebCore

2011-02-06 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

[WIN] Use WCHAR instead of TCHAR
​https://bugs.webkit.org/show_bug.cgi?id=53863

We always use the UNICODE versions of windows functions, so
the usage of TCHAR makes no sense and mixing them is bad style.

  • platform/graphics/win/IconWin.cpp: (WebCore::Icon::createIconForFiles):
  • platform/graphics/win/QTMovie.cpp:
  • platform/graphics/win/QTMovieGWorld.cpp: (QTMovieGWorld::fullscreenWndProc): (QTMovieGWorld::enterFullscreen):
  • platform/graphics/win/SimpleFontDataCGWin.cpp: (WebCore::SimpleFontData::platformInit):
  • platform/graphics/win/SimpleFontDataCairoWin.cpp:
  • platform/graphics/win/SimpleFontDataWin.cpp:
  • platform/graphics/wince/SimpleFontDataWinCE.cpp:
  • platform/win/BString.cpp:
  • platform/win/ClipboardWin.cpp: (WebCore::filesystemPathFromUrlOrTitle): (WebCore::createGlobalHDropContent): (WebCore::createGlobalImageFileDescriptor):
  • platform/win/ContextMenuWin.cpp:
  • platform/win/CursorWin.cpp: (WebCore::loadSharedCursor):
  • platform/win/FileChooserWin.cpp: (WebCore::FileChooser::basenameForWidth):
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenuWin::popupClassName): (WebCore::PopupMenuWin::show):
  • platform/win/PopupMenuWin.h:
10:44 AM Changeset in webkit [77774] by Patrick Gansterer
  • 9 edits in trunk/Source/WebCore

2011-02-06 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

Replace FLT_MAX with std::numeric_limits
​https://bugs.webkit.org/show_bug.cgi?id=53861

Also move EFL's userIdleTime from TemporaryLinkStubs into SystemTimeEfl.

  • html/NumberInputType.cpp:
  • html/parser/HTMLParserIdioms.cpp: (WebCore::parseToDoubleForNumberType):
  • platform/brew/SystemTimeBrew.cpp: (WebCore::userIdleTime):
  • platform/efl/SystemTimeEfl.cpp: (WebCore::userIdleTime):
  • platform/efl/TemporaryLinkStubs.cpp:
  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::setupAnimation):
  • platform/win/SystemTimeWin.cpp: (WebCore::userIdleTime):
  • platform/wx/SystemTimeWx.cpp: (WebCore::userIdleTime):
10:39 AM Notes on Content Security Policies edited by abarth@webkit.org
(diff)
10:38 AM Notes on Content Security Policies created by abarth@webkit.org
10:31 AM Changeset in webkit [77773] by robert@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-02-06 Robert Hogan <​robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Remove unnecessary QRect assignment
​https://bugs.webkit.org/show_bug.cgi?id=53873

  • Api/qwebframe.cpp: (QWebFramePrivate::renderRelativeCoords):
10:18 AM Changeset in webkit [77772] by robert@webkit.org
  • 4 edits in trunk

2011-02-06 Robert Hogan <​robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Clear page's groupName even when not in DRT
​https://bugs.webkit.org/show_bug.cgi?id=53874

Matches behaviour of other ports.

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::closeWindowSoon):

2011-02-06 Robert Hogan <​robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Clear page's groupName even when not in DRT
​https://bugs.webkit.org/show_bug.cgi?id=53874

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::windowCloseRequested):
9:47 AM Changeset in webkit [77771] by Patrick Gansterer
  • 6 edits in trunk

2011-02-06 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[CMake] Add dependencies for Visual Studio projects
​https://bugs.webkit.org/show_bug.cgi?id=53773

Add a JavaScriptCore dependecy to WebCore, so CMake can
generate the correct build order for the solution.

  • CMakeLists.txt:

2011-02-06 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[CMake] Add dependencies for Visual Studio projects
​https://bugs.webkit.org/show_bug.cgi?id=53773

Add a WebCore dependecy to WebKit, so CMake can
generate the correct build order for the solution.

Remove JavaScriptCore dependecy, since WebCore already depends on it.

  • CMakeLists.txt:

2011-02-06 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[CMake] Add dependencies for Visual Studio projects
​https://bugs.webkit.org/show_bug.cgi?id=53773

Add a WebKit dependecy to WinCELauncher, so CMake can
generate the correct build order for the solution.

  • CMakeListsWinCE.txt:
9:14 AM Changeset in webkit [77770] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-02-06 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[CMake] Unify ENABLE_SVG sections
​https://bugs.webkit.org/show_bug.cgi?id=53778

  • CMakeLists.txt:
9:08 AM Changeset in webkit [77769] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2011-02-06 Martin Robinson <​mrobinson@igalia.com>

Reclassify a failing test and unskip another which should be passing now.

  • platform/gtk/Skipped: Update the skipped list.
8:22 AM Changeset in webkit [77768] by andreas.kling@nokia.com
  • 5 edits in trunk/Source/WebCore

2011-02-06 Andreas Kling <​kling@webkit.org>

Reviewed by Dirk Schulze.

Refactor Font::normalizeSpaces() to avoid an extra String copy.
​https://bugs.webkit.org/show_bug.cgi?id=53871

Have normalizeSpaces() take UChar*,length arguments instead of a
String, since all call sites were creating temporaries from these
components anyway.

Font::normalizeSpaces() now always makes 1 String copy,
instead of 1 in the best case and 2 in the worst case.

  • platform/graphics/Font.cpp: (WebCore::Font::normalizeSpaces):
  • platform/graphics/Font.h:
  • platform/graphics/qt/FontQt.cpp: (WebCore::drawTextCommon): (WebCore::Font::floatWidthForSimpleText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForSimpleText): (WebCore::Font::offsetForPositionForComplexText): (WebCore::Font::selectionRectForSimpleText): (WebCore::Font::selectionRectForComplexText):
  • svg/SVGFont.cpp: (WebCore::SVGTextRunWalker::walk):
7:19 AM Changeset in webkit [77767] by andreas.kling@nokia.com
  • 4 edits in trunk/Tools

2011-02-06 Andreas Kling <​kling@webkit.org>

Reviewed by Antonio Gomes.

[Qt] MiniBrowser: Clean up handling of titleChanged() signal
​https://bugs.webkit.org/show_bug.cgi?id=53869

  • MiniBrowser/qt/BrowserView.cpp: (BrowserView::BrowserView): Remove unnecessary titleChanged() handling.
  • MiniBrowser/qt/BrowserWindow.cpp: (BrowserWindow::BrowserWindow): Connect titleChanged() directly to setWindowTitle().
  • MiniBrowser/qt/BrowserWindow.h:
6:35 AM Changeset in webkit [77766] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-02-06 Andreas Kling <​kling@webkit.org>

Reviewed by Dirk Schulze.

Fix potential buffer overrun in SVGTextRunWalker::walk()
​https://bugs.webkit.org/show_bug.cgi?id=53870

A new String was created from a UChar* with a 'length' argument
that could be greater than the number of UChars available.

  • svg/SVGFont.cpp: (WebCore::SVGTextRunWalker::walk):
5:23 AM Changeset in webkit [77765] by commit-queue@webkit.org
  • 11 edits in trunk/Source/WebKit2

2011-02-06 Benjamin Poulain <​ikipou@gmail.com>

Reviewed by Andreas Kling.

[Qt] WebKit does not build on Mac with WebKit 2
​https://bugs.webkit.org/show_bug.cgi?id=53380

  • Platform/CoreIPC/qt/ConnectionQt.cpp: Use fcntl() to set close on exec so we do not rely on recent kernel. (CoreIPC::Connection::readyReadHandler):
  • Platform/qt/SharedMemoryQt.cpp: ditto (WebKit::SharedMemory::create): (WebKit::SharedMemory::createHandle):
  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp: Guard prctl() since it is a Linux specific function. (WebKit::QtWebProcess::setupChildProcess):
  • UIProcess/DrawingAreaProxy.h: Differentiate between building on Mac and the Mac port.
  • UIProcess/DrawingAreaProxyImpl.cpp: ditto
  • UIProcess/WebPageProxy.cpp: ditto (WebKit::WebPageProxy::didReceiveMessage):
  • WebProcess/WebPage/DrawingArea.cpp: ditto (WebKit::DrawingArea::create):
  • WebProcess/WebPage/DrawingArea.h:
  • WebProcess/WebPage/DrawingAreaImpl.cpp: ditto
  • WebProcess/WebPage/WebPage.cpp: ditto (WebKit::WebPage::didReceiveMessage):
2:46 AM Changeset in webkit [77764] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-06 Robert Hogan <​robert@webkit.org>

Unreviewed, skip failing test on Qt bot.

[Qt] fast/notifications/notifications-document-close-crash.html fails after r77738
​https://bugs.webkit.org/show_bug.cgi?id=53868

  • platform/qt/Skipped: Skip fast/notifications/notifications-document-close-crash.html
2:35 AM Changeset in webkit [77763] by mjs@apple.com
  • 8 edits in trunk

2011-02-06 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Dan Bernstein.

WebKitTestRunner needs layoutTestController.setWillSendRequestReturnsNull
​https://bugs.webkit.org/show_bug.cgi?id=42690
<rdar://problem/8213851>

  • platform/mac-wk2/Skipped: Unskip tests that now pass, except for the ones that mysteriously fail.

2011-02-06 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Dan Bernstein.

WebKitTestRunner needs layoutTestController.setWillSendRequestReturnsNull
​https://bugs.webkit.org/show_bug.cgi?id=42690
<rdar://problem/8213851>

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::willSendRequestForFrame):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::LayoutTestController):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h: (WTR::LayoutTestController::willSendRequestReturnsNull): (WTR::LayoutTestController::setWillSendRequestReturnsNull):

Feb 5, 2011:

10:05 PM Changeset in webkit [77762] by mrowe@apple.com
  • 5 edits in branches/safari-533.20-branch

Versioning.

10:05 PM Changeset in webkit [77761] by mrowe@apple.com
  • 1 copy in tags/Safari-533.20.25

New tag.

10:00 PM Changeset in webkit [77760] by mrowe@apple.com
  • 1 edit in branches/safari-533.20-branch/WebKit/win/WebCoreSupport/WebContextMenuClient.cpp

Build fix.

9:24 PM Changeset in webkit [77759] by mjs@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-05 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Dan Bernstein.

REGRESSION: New drawing area is causing some WebProcess crashes in layout tests
​https://bugs.webkit.org/show_bug.cgi?id=53865
<rdar://problem/8963148>


  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode): Handle the case where this is called repeatedly without exiting accelerated composting mode first. (WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode): Handle the case of being called more than once.
9:05 PM Changeset in webkit [77758] by Dimitri Glazkov
  • 1 edit
    2 adds in trunk/LayoutTests

2011-02-05 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Add baselines for the test added in r77690.

  • platform/chromium-mac/media/video-frame-accurate-seek-expected.checksum: Added.
  • platform/chromium-mac/media/video-frame-accurate-seek-expected.png: Added.
6:58 PM Changeset in webkit [77757] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-02-05 Dimitri Glazkov <Dimitri Glazkov>

Remove passing canvas tests from expectations.

  • platform/chromium/test_expectations.txt: Removed passing tests.
6:44 PM Changeset in webkit [77756] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-02-05 Dimitri Glazkov <Dimitri Glazkov>

Remove passing tests whose results match mac/ and mac-leopard.

  • platform/chromium/test_expectations.txt: Removed passing tests.
6:07 PM Changeset in webkit [77755] by abarth@webkit.org
  • 8 edits in trunk/Source/WebCore

2011-02-05 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove unused parameter related to XSSAuditor
​https://bugs.webkit.org/show_bug.cgi?id=53862

  • WebCore.exp.in:
  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeScript): (WebCore::ScriptController::executeIfJavaScriptURL):
  • bindings/ScriptControllerBase.h:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld): (WebCore::ScriptController::evaluate): (WebCore::ScriptController::executeScriptInWorld):
  • bindings/js/ScriptController.h:
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluate):
  • bindings/v8/ScriptController.h:
4:54 PM Changeset in webkit [77754] by Dimitri Glazkov
  • 1 edit
    125 deletes in trunk/LayoutTests

2011-02-05 Dimitri Glazkov <Dimitri Glazkov>

Remove results for failing SVG tests. I will add the new ones after the
bots tell me which ones aren't matching mac/ or mac-leopard/.

3:02 PM Changeset in webkit [77753] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-05 Adam Barth <​abarth@webkit.org>

Fix Qt build.

  • WebCore.pro:
2:55 PM Changeset in webkit [77752] by abarth@webkit.org
  • 20 edits
    2 deletes in trunk/Source/WebCore

2011-02-05 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Delete XSSAuditor
​https://bugs.webkit.org/show_bug.cgi?id=53859

The job of the XSSAuditor is now done by the XSSFilter. In the future,
we might rename XSSFilter to XSSAuditor.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):
  • bindings/ScriptControllerBase.h:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::evaluateInWorld):
  • bindings/js/ScriptController.h:
  • bindings/js/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::evaluate):
  • bindings/v8/ScriptController.h:
  • bindings/v8/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
  • dom/Document.cpp: (WebCore::Document::implicitOpen): (WebCore::Document::processBaseElement):
  • dom/ScriptableDocumentParser.cpp: (WebCore::ScriptableDocumentParser::ScriptableDocumentParser):
  • dom/ScriptableDocumentParser.h:
  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::shouldLoadExternalScriptFromSrc):
  • loader/SubframeLoader.cpp: (WebCore::SubframeLoader::requestObject): (WebCore::SubframeLoader::loadMediaPlayerProxyPlugin):
  • page/XSSAuditor.cpp: Removed.
  • page/XSSAuditor.h: Removed.
2:28 PM Changeset in webkit [77751] by andersca@apple.com
  • 18 edits in trunk/Source

2011-02-05 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler.

Need a way to resize and scroll the page at the same time
​https://bugs.webkit.org/show_bug.cgi?id=53814
<rdar://problem/8498008>

Export a function needed by WebKit2.

  • WebCore.exp.in:

2011-02-05 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler.

Need a way to resize and scroll the page at the same time
​https://bugs.webkit.org/show_bug.cgi?id=53814
<rdar://problem/8498008>

Add -[WKView setFrame:andScrollBy:].

  • UIProcess/API/mac/WKView.h:
  • UIProcess/API/mac/WKView.mm: (-[WKView setFrame:andScrollBy:]): Stash away the scroll offset and call setFrame:.

(-[WKView _switchToDrawingAreaTypeIfNecessary:DrawingAreaInfo::]):
(-[WKView _setDrawingAreaSize:]):

  • UIProcess/API/qt/qwkpage.cpp: (QWKPage::setViewportSize): DrawingAreaProxy::setSize now takes a scroll offset.
  • UIProcess/DrawingAreaProxy.cpp: (WebKit::DrawingAreaProxy::setSize): This now takes a scroll offset and stores it in m_scrollOffset.
  • UIProcess/DrawingAreaProxy.h:
  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::sendSetSize): Send along the scroll offset and set it back to zero.
  • UIProcess/LayerBackedDrawingAreaProxy.cpp: (WebKit::LayerBackedDrawingAreaProxy::didSetSize):
  • UIProcess/TiledDrawingAreaProxy.cpp: (WebKit::TiledDrawingAreaProxy::didSetSize):
  • UIProcess/win/WebView.cpp: (WebKit::WebView::onSizeEvent): (WebKit::WebView::switchToDrawingAreaTypeIfNecessary): DrawingAreaProxy::setSize now takes a scroll offset.


  • WebProcess/WebPage/DrawingArea.h: (WebKit::DrawingArea::setSize): Add a scrollOffset parameter.
  • WebProcess/WebPage/DrawingArea.messages.in: Add a scroll offset parameter to the SetSize message.
  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::setSize): Call WebPage::scrollMainFrameIfNotAtMaxScrollPosition.
  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::scrollMainFrameIfNotAtMaxScrollPosition): Compute a scroll offset and call setScrollPosition on the main frame view.
12:34 PM Changeset in webkit [77750] by Patrick Gansterer
  • 6 edits in trunk/Source/WebCore

2011-02-05 Patrick Gansterer <Patrick Gansterer>

Reviewed by Alexey Proskuryakov.

Use Document::encoding() instead of DocumentWriter::encoding()
​https://bugs.webkit.org/show_bug.cgi?id=53398

This change makes the code more readable, when a subresource
inherits the character encoding of the document.

  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet):
  • dom/ScriptElement.cpp: (WebCore::ScriptElement::scriptCharset):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
  • loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::requestPreload):
  • platform/network/FormDataBuilder.cpp: (WebCore::FormDataBuilder::encodingFromAcceptCharset):
12:30 PM Changeset in webkit [77749] by Patrick Gansterer
  • 7 edits
    1 add in trunk/LayoutTests

2011-02-05 Patrick Gansterer <Patrick Gansterer>

Reviewed by Alexey Proskuryakov.

Add addition test for inherited encoding
​https://bugs.webkit.org/show_bug.cgi?id=53398

Check if the right encoding is used, after document.charset was set.

  • fast/dom/Document/document-charset.html: Added doctype to make it pass in IE9 out of the box.
  • fast/encoding/css-charset-default-expected.txt:
  • fast/encoding/css-charset-default.xhtml:
  • fast/encoding/external-script-charset-expected.txt:
  • fast/encoding/external-script-charset-koi-8.js: Added.
  • fast/encoding/external-script-charset.js:
  • fast/encoding/external-script-charset.xhtml:
12:21 PM Changeset in webkit [77748] by abarth@webkit.org
  • 6 edits
    1 add in trunk/Source/WebCore

2011-02-05 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Introduce URLString to represent a canonicalized URL represented by a string
​https://bugs.webkit.org/show_bug.cgi?id=53847

Instead of using String all over the codebase to represent a URL,
instead we should have a type to represent a canonicalized URL in the
form of a string. This patch introduces that type.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/KURL.cpp: (WebCore::KURL::KURL):
  • platform/KURL.h: (WebCore::KURL::urlString):
10:26 AM Changeset in webkit [77747] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2011-02-05 Martin Robinson <​mrobinson@igalia.com>

JSC::Bindings m_rootObject->isValid() assert fails when running layout tests
​https://bugs.webkit.org/show_bug.cgi?id=53716

  • platform/gtk/Skipped: Skip a test hitting this assertion.
9:55 AM Changeset in webkit [77746] by robert@webkit.org
  • 4 edits in trunk

2011-02-05 Robert Hogan <​robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Style widgets not rendering
​https://bugs.webkit.org/show_bug.cgi?id=53849

  • platform/qt/Skipped: Unskip plugins/application-plugins-plugins-disabled.html

2011-02-05 Robert Hogan <​robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Style widgets not rendering
​https://bugs.webkit.org/show_bug.cgi?id=53849

  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::hasValidClassId): x-qt-styled-widget is a valid class id too
9:19 AM Changeset in webkit [77745] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-02-05 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r77720.
​http://trac.webkit.org/changeset/77720
​https://bugs.webkit.org/show_bug.cgi?id=53854

"Broke nrwt on Chromium win." (Requested by dglazkov|away on
#webkit).

  • Scripts/webkitpy/common/system/executive.py:
5:00 AM Changeset in webkit [77744] by Nikolas Zimmermann
  • 168 edits in trunk/LayoutTests

2011-02-04 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

small text which is scaled to be large renders pixelated
​https://bugs.webkit.org/show_bug.cgi?id=12448

Update Snow Leopard SVG pixel test baseline after r77485.

  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png:

...

4:48 AM Changeset in webkit [77743] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2011-02-05 Eric Seidel <​eric@webkit.org>

Unreviewed.

Safari should lowercase schemes in cannonicalized urls to match every other browser
​https://bugs.webkit.org/show_bug.cgi?id=53848

Checkin results I forgot to update in my previous commit. All progressions.

  • fast/dom/anchor-origin-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:
3:52 AM Changeset in webkit [77742] by jochen@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-02-05 Jochen Eisinger <​jochen@chromium.org>

Reviewed by Adam Barth.

Add ContentSecurityPolicy object to Document and pass the X-WebKit-CSP header from the MainResourceLoader.
​https://bugs.webkit.org/show_bug.cgi?id=53685

  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.h: (WebCore::Document::contentSecurityPolicy):
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didReceiveResponse):
  • page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::didReceiveHeader):
  • page/ContentSecurityPolicy.h:
3:43 AM Changeset in webkit [77741] by eric@webkit.org
  • 8 edits in trunk

2011-02-05 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Safari should lowercase schemes in cannonicalized urls to match every other browser
​https://bugs.webkit.org/show_bug.cgi?id=53848

Update our results now that we pass more tests.

  • fast/url/file-expected.txt:
  • fast/url/file-http-base-expected.txt:
  • fast/url/path-url-expected.txt:
  • fast/url/relative-expected.txt:
  • fast/url/scheme-expected.txt:

2011-02-05 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Safari should lowercase schemes in cannonicalized urls to match every other browser
​https://bugs.webkit.org/show_bug.cgi?id=53848

We're clearly the odd man out here. See results from every browser at:
​https://github.com/abarth/url-spec/blob/master/tests/gurl-results/by-browser.txt

  • platform/KURL.cpp: (WebCore::KURL::parse):
    • Just lowercase the scheme when copying.
3:23 AM Changeset in webkit [77740] by Antti Koivisto
  • 4 edits in trunk/Source/WebCore

Optimize matching of descendant selectors
​https://bugs.webkit.org/show_bug.cgi?id=49876
<rdar://problem/8772822>

Reviewed by Dave Hyatt.

During style recalculation, maintain a filter of tags, ids and classes seen in ancestor elements.
Use the filter to quickly reject descendant and child selectors when doing style matching.

This speeds up style recalculations 3-6x on many major web sites.

  • css/CSSStyleSelector.cpp:

(WebCore::RuleData::RuleData):
(WebCore::RuleData::descendantSelectorIdentifierHashes):
(WebCore::collectElementIdentifiers):
(WebCore::CSSStyleSelector::pushParent):
(WebCore::CSSStyleSelector::popParent):
(WebCore::CSSStyleSelector::fastRejectSelector):
(WebCore::CSSStyleSelector::matchRulesForList):
(WebCore::RuleData::collectDescendantSelectorIdentifierHashes):

  • css/CSSStyleSelector.h:

(WebCore::CSSStyleSelector::ParentStackFrame::ParentStackFrame):

  • dom/Element.cpp:

(WebCore::StyleSelectorParentPusher::StyleSelectorParentPusher):
(WebCore::StyleSelectorParentPusher::push):
(WebCore::StyleSelectorParentPusher::~StyleSelectorParentPusher):
(WebCore::Element::attach):
(WebCore::Element::recalcStyle):

3:12 AM Changeset in webkit [77739] by eric@webkit.org
  • 1 edit
    3 adds in trunk/PerformanceTests

2011-02-05 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add performance tests for URL parsing
​https://bugs.webkit.org/show_bug.cgi?id=53845

The final-url-en URL corpus is from:
​http://corpus.leeds.ac.uk/internet.html

There are also other language corpuses which we may want to use in the future.

The usage instructions were as follows:
"URL lists and other resources: you can freely use them in your research
provided that you supply a link to this website: ​http://corpus.leeds.ac.uk/."
Done.

  • Parser/simple-url.html: Added. On my machine: Firefox: 255ms TOT WebKit: 378ms Chrome: 286ms Opera: 2830ms (no, that is not a typo)
  • Parser/url-parser.html: Added. Firefox: 381ms TOT WebKit: 216ms Chrome: 131ms Opera: 1383ms (again, not a typo)
  • Parser/resources/final-url-en: Added.
2:37 AM Changeset in webkit [77738] by Nate Chapin
  • 5 edits in trunk/Source/WebCore

2011-02-05 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Refactor: NotificationCenter shouldn't hold its own copy of the ScriptExecutionContext*
when it inherits one from ActiveDOMObject.
​https://bugs.webkit.org/show_bug.cgi?id=53815

  • bindings/js/JSDesktopNotificationsCustom.cpp: (WebCore::JSNotificationCenter::requestPermission):
  • bindings/v8/custom/V8NotificationCenterCustom.cpp: (WebCore::V8NotificationCenter::requestPermissionCallback):
  • notifications/NotificationCenter.cpp: (WebCore::NotificationCenter::NotificationCenter): (WebCore::NotificationCenter::checkPermission): (WebCore::NotificationCenter::requestPermission): (WebCore::NotificationCenter::disconnectFrame):
  • notifications/NotificationCenter.h: (WebCore::NotificationCenter::createHTMLNotification): (WebCore::NotificationCenter::createNotification):
12:02 AM Changeset in webkit [77737] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

2011-02-05 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r77725.
​http://trac.webkit.org/changeset/77725
​https://bugs.webkit.org/show_bug.cgi?id=53844

It broke Qt minimal build (Requested by Ossy_ on #webkit).

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::createChrome):
  • QtTestBrowser/launcherwindow.h: (WindowOptions::WindowOptions):
  • QtTestBrowser/main.cpp: (LauncherApplication::handleUserOptions):
Note: See TracTimeline for information about the timeline view.