Context Navigation

(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar): Remove some extraneous characters.
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar): Ditto.

11:07 PM Changeset in webkit [77909] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

2011-02-07 Kenji Imasaki <imasaki@chromium.org>

Reviewed by David Levin.

[Chromium] Remove non-Flaky media layout tests and update bugs that
are associated with media layout tests
https://bugs.webkit.org/show_bug.cgi?id=53948

platform/chromium/test_expectations.txt:

11:07 PM Changeset in webkit [77908] by mjs@apple.com

16 edits
2 adds in trunk

2011-02-07 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

Add resource load client for injected bundle and move willSendRequest there
https://bugs.webkit.org/show_bug.cgi?id=53972

GNUmakefile.am:
WebKit2.pro:
WebKit2.xcodeproj/project.pbxproj:
WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePageSetPageLoaderClient): (WKBundlePageSetResourceLoadClient):
WebProcess/InjectedBundle/API/c/WKBundlePage.h:
WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.cpp: Added. (WebKit::InjectedBundlePageResourceLoadClient::didInitiateLoadForResource): (WebKit::InjectedBundlePageResourceLoadClient::willSendRequestForFrame): (WebKit::InjectedBundlePageResourceLoadClient::didReceiveResponseForResource): (WebKit::InjectedBundlePageResourceLoadClient::didReceiveContentLengthForResource): (WebKit::InjectedBundlePageResourceLoadClient::didFinishLoadForResource): (WebKit::InjectedBundlePageResourceLoadClient::didFailLoadForResource):
WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.h: Added.
WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::assignIdentifierToInitialRequest): (WebKit::WebFrameLoaderClient::dispatchWillSendRequest): (WebKit::WebFrameLoaderClient::dispatchDidReceiveResponse): (WebKit::WebFrameLoaderClient::dispatchDidReceiveContentLength): (WebKit::WebFrameLoaderClient::dispatchDidFinishLoading): (WebKit::WebFrameLoaderClient::dispatchDidFailLoading):
WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::initializeInjectedBundleResourceLoadClient):
WebProcess/WebPage/WebPage.h: (WebKit::WebPage::injectedBundleResourceLoadClient):
win/WebKit2.vcproj:

2011-02-07 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

Add resource load client for injected bundle and move willSendRequest there
https://bugs.webkit.org/show_bug.cgi?id=53972

MiniBrowser/mac/WebBundle/WebBundleMain.m: (didCreatePage):
WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage): (WTR::InjectedBundlePage::didInitiateLoadForResource): (WTR::InjectedBundlePage::didReceiveResponseForResource): (WTR::InjectedBundlePage::didReceiveContentLengthForResource): (WTR::InjectedBundlePage::didFinishLoadForResource): (WTR::InjectedBundlePage::didFailLoadForResource): (WTR::InjectedBundlePage::willSendRequestForFrame):
WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:

11:07 PM Changeset in webkit [77907] by commit-queue@webkit.org

2 edits
1 add in trunk/Source/WebCore

2011-02-07 Xiyuan Xia <xiyuan@chromium.org>

Reviewed by Tony Chang.

[Chromium] Select popup box does not align with select button when appearance is not "menulist".
https://bugs.webkit.org/show_bug.cgi?id=53942

Added manual test select_webkit_appearance_off_popup_alignment.html.

manual-tests/select_webkit_appearance_off_popup_alignment.html: Added.
platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::layout):

10:59 PM Changeset in webkit [77906] by commit-queue@webkit.org

4 edits in trunk/Source

2011-02-07 Aparna Nandyal <aparna.nand@wipro.com>

Reviewed by Andreas Kling.

[Qt] - Context menu needs "Copy" as well when the selected text is a link.
https://bugs.webkit.org/show_bug.cgi?id=40983

Added copy option for Qt platform if selection is a link.
Added a test in tst_qwebpage.cpp.

page/ContextMenuController.cpp: (WebCore::ContextMenuController::populate):

2011-02-07 Aparna Nandyal <aparna.nand@wipro.com>

Reviewed by Andreas Kling.

[Qt] - Context menu needs "Copy" as well when the selected text is a link.
https://bugs.webkit.org/show_bug.cgi?id=40983

Added a test case to create a context sensitive menu.
A check is made if it has Copy menu item when user
selects a link and opens context menu.

tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::contextMenuCopy):

10:48 PM Changeset in webkit [77905] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

2011-02-07 Mike Reed <reed@google.com>

Reviewed by Kenneth Russell.

Add compile-time flag ENABLE(SKIA_GPU) to use Skia's gpu backend
when drawing <canvas>. Disabled by default.

No new tests. existing canvas layouttests apply

platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::publishToPlatformLayer):
platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::GetGlobalGrContext): (WebCore::PlatformContextSkia::isPrinting): (WebCore::PlatformContextSkia::setSharedGraphicsContext3D): (WebCore::PlatformContextSkia::syncSoftwareCanvas):

10:45 PM Changeset in webkit [77904] by jcivelli@chromium.org

3 edits in trunk/Source/WebCore

2011-02-07 Jay Civelli <jcivelli@chromium.org>

Reviewed by Darin Fisher.

Removing unused code from PopupMenuChromium.
https://bugs.webkit.org/show_bug.cgi?id=53866

platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::layout): (WebCore::PopupMenuChromium::show):
- platform/chromium/PopupMenuChromium.h:

10:39 PM Changeset in webkit [77903] by ojan@chromium.org

2 edits in trunk/Websites/bugs.webkit.org

2011-02-07 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

bring back diff context lines into the review tool
https://bugs.webkit.org/show_bug.cgi?id=53974

code-review.js:

10:30 PM Changeset in webkit [77902] by commit-queue@webkit.org

3 edits
2 adds in trunk

2011-02-07 Kenichi Ishibashi <bashi@google.com>

Reviewed by Andreas Kling.

HTMLOutputElement::childrenChanged() should call its base class childrenChanged()
https://bugs.webkit.org/show_bug.cgi?id=53791

Test that a live list is updated after the child of an HTMLOutputElement was removed.

fast/dom/HTMLOutputElement/htmloutputelement-children-removed-expected.txt: Added.
fast/dom/HTMLOutputElement/htmloutputelement-children-removed.html: Added.

2011-02-07 Kenichi Ishibashi <bashi@chromium.org>

Reviewed by Andreas Kling.

HTMLOutputElement::childrenChanged() should call its base class childrenChanged()
https://bugs.webkit.org/show_bug.cgi?id=53791

Calls HTMLFormControlElement::childrenChanged() in HTMLOutputElement::childrenChanged().

Test: fast/dom/HTMLOutputElement/htmloutputelement-children-removed.html

html/HTMLOutputElement.cpp: (WebCore::HTMLOutputElement::childrenChanged): Calls super class's childrenChanged().

10:27 PM Changeset in webkit [77901] by commit-queue@webkit.org

6 edits in trunk/Source

2011-02-07 Benjamin Poulain <ikipou@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] cookiesEnabled could create the cookieJar on the wrong thread.
https://bugs.webkit.org/show_bug.cgi?id=52289

Use the QtNAMThreadSafeProxy to make sure the cookie jar is created
in the same thread as the QNetworkAccessManager.

platform/network/qt/QtNAMThreadSafeProxy.cpp: (WebCore::QtNAMThreadSafeProxy::QtNAMThreadSafeProxy): (WebCore::QtNAMThreadSafeProxy::hasCookieJar):
platform/network/qt/QtNAMThreadSafeProxy.h:
platform/qt/CookieJarQt.cpp: (WebCore::cookiesEnabled):

2011-02-07 Benjamin Poulain <ikipou@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] cookiesEnabled could create the cookieJar on the wrong thread.
https://bugs.webkit.org/show_bug.cgi?id=52289

Test if the cookie jar is created in the right thread when accessed from
the navigator object.

tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::navigatorCookieEnabledForNetworkAccessManagerOnDifferentThread):

10:25 PM Changeset in webkit [77900] by commit-queue@webkit.org

9 edits in trunk/Source

2011-02-07 Alexey Marinichev <amarinichev@chromium.org>

Reviewed by Kenneth Russell.

Hook up WebGraphicsContext3D::setContextLostCallback.
https://bugs.webkit.org/show_bug.cgi?id=53722

Test: fast/canvas/webgl/context-lost.html, comment out the line with
extension.loseContext() and kill the GPU process "Lose context"
message shows up.

html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContextLostCallback::WebGLRenderingContextLostCallback): (WebCore::WebGLRenderingContextLostCallback::onContextLost): (WebCore::WebGLRenderingContextLostCallback::~WebGLRenderingContextLostCallback): (WebCore::WebGLRenderingContext::initializeNewContext): (WebCore::WebGLRenderingContext::~WebGLRenderingContext):
platform/graphics/GraphicsContext3D.h: (WebCore::GraphicsContext3D::ContextLostCallback::~ContextLostCallback):
platform/graphics/mac/GraphicsContext3DMac.mm: (WebCore::GraphicsContext3D::setContextLostCallback): stub
platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::setContextLostCallback): stub

2011-02-07 Alexey Marinichev <amarinichev@chromium.org>

Reviewed by Kenneth Russell.

Hook up WebGraphicsContext3D::setContextLostCallback.
https://bugs.webkit.org/show_bug.cgi?id=53722

Test: fast/canvas/webgl/context-lost.html, comment out the line with
extension.loseContext() and kill the GPU process "Lose context"
message shows up.

public/WebGraphicsContext3D.h: (WebKit::WebGraphicsContext3D::WebGraphicsContextLostCallback::~WebGraphicsContextLostCallback):
src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContextLostCallbackAdapter::~GraphicsContextLostCallbackAdapter): (WebCore::GraphicsContextLostCallbackAdapter::GraphicsContextLostCallbackAdapter): (WebCore::GraphicsContextLostCallbackAdapter::onContextLost): (WebCore::GraphicsContextLostCallbackAdapter::create): (WebCore::GraphicsContext3DInternal::setContextLostCallback):
src/GraphicsContext3DInternal.h:

10:24 PM Changeset in webkit [77899] by mrowe@apple.com

2 edits in trunk/Source/WebKit2

Fix the 32-bit build.

UIProcess/cf/WebBackForwardListCF.cpp:

(WebKit::WebBackForwardList::restoreFromCFDictionaryRepresentation): Add some casts
to prevent warnings about mixing signed and unsigned comparisons.

10:11 PM Changeset in webkit [77898] by abarth@webkit.org

3 edits in trunk/Tools

2011-02-07 Adam Barth <abarth@webkit.org>

Add Leopard Debug back to the core builders.

Scripts/webkitpy/common/net/buildbot/buildbot.py:
Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

10:08 PM Changeset in webkit [77897] by commit-queue@webkit.org

4 edits in trunk/LayoutTests

2011-02-07 Ami Fischman <fischman@google.com>

Reviewed by Eric Seidel.

Re-baseline media/video-zoom.html for http://crbug.com/70252 aka
https://bugs.webkit.org/show_bug.cgi?id=53737 to account for (very)
slightly different scrollbar shading.
This test isn't flaky on LINUX or MAC according to
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&showAllRuns=true&master=ChromiumWebkit&tests=media%2Fvideo-zoom.html
so take it out of test_expectations.txt; it passes 100% on LINUX and
fails 100% on MAC, and should pass 100% on MAC with this new
baseline.

platform/chromium-mac/media/video-zoom-expected.checksum:
platform/chromium-mac/media/video-zoom-expected.png:
platform/chromium/test_expectations.txt:

10:05 PM Changeset in webkit [77896] by commit-queue@webkit.org

5 edits in trunk

2011-02-07 Adam Klein <adamk@chromium.org>

Reviewed by Jian Li.

[chromium] Remove deprecated method WebNotification::dir
https://bugs.webkit.org/show_bug.cgi?id=53735

public/WebNotification.h:
src/WebNotification.cpp:

2011-02-07 Adam Klein <adamk@chromium.org>

Reviewed by Jian Li.

[chromium] Remove deprecated method WebNotification::dir
https://bugs.webkit.org/show_bug.cgi?id=53735

DumpRenderTree/chromium/NotificationPresenter.cpp: (NotificationPresenter::show):

10:02 PM Changeset in webkit [77895] by Patrick Gansterer

2 edits in trunk/Source/WebCore

2011-02-07 Patrick Gansterer <Patrick Gansterer>

Reviewed by Eric Seidel.

Add missing PaintInfo include in RenderThemeWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=53885

rendering/RenderThemeWin.cpp:

9:39 PM Changeset in webkit [77894] by jamesr@google.com

1 edit
3 moves in trunk/LayoutTests

2011-02-07 James Robinson <jamesr@chromium.org>

Move sputnik expectations to match test movement.

platform/gtk/fast/js/sputnik: Removed.
platform/gtk/fast/js/sputnik/Unicode: Removed.
platform/gtk/fast/js/sputnik/Unicode/Unicode_510: Removed.
platform/gtk/fast/js/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt: Removed.
platform/gtk/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt: Removed.
platform/gtk/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt: Removed.
platform/gtk/sputnik: Copied from LayoutTests/platform/gtk/fast/js/sputnik.
platform/mac-leopard/fast/js/sputnik: Removed.
platform/mac-leopard/fast/js/sputnik/Unicode: Removed.
platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_500: Removed.
platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_500/S7.6_A3.1-expected.txt: Removed.
platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_500/S7.6_A3.2-expected.txt: Removed.
platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_500/S7.6_A5.3_T1-expected.txt: Removed.
platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_500/S7.6_A5.3_T2-expected.txt: Removed.
platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510: Removed.
platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S15.5.4.16_A1-expected.txt: Removed.
platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S15.5.4.18_A1-expected.txt: Removed.
platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A1.1_T1-expected.txt: Removed.
platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A1.1_T2-expected.txt: Removed.
platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A1.1_T4-expected.txt: Removed.
platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A2.2_T1-expected.txt: Removed.
platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A2.2_T2-expected.txt: Removed.
platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A2.3-expected.txt: Removed.
platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T1-expected.txt: Removed.
platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T2-expected.txt: Removed.
platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T4-expected.txt: Removed.
platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T7-expected.txt: Removed.
platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T8-expected.txt: Removed.
platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T9-expected.txt: Removed.
platform/mac-leopard/sputnik: Copied from LayoutTests/platform/mac-leopard/fast/js/sputnik.
platform/win/fast/js/sputnik: Removed.
platform/win/fast/js/sputnik/Conformance: Removed.
platform/win/fast/js/sputnik/Conformance/11_Expressions: Removed.
platform/win/fast/js/sputnik/Conformance/11_Expressions/11.5_Multiplicative_Operators: Removed.
platform/win/fast/js/sputnik/Conformance/11_Expressions/11.5_Multiplicative_Operators/11.5.3_Percent: Removed.
platform/win/fast/js/sputnik/Conformance/11_Expressions/11.5_Multiplicative_Operators/11.5.3_Percent/S11.5.3_A4_T6-expected.txt: Removed.
platform/win/fast/js/sputnik/Unicode: Removed.
platform/win/fast/js/sputnik/Unicode/Unicode_510: Removed.
platform/win/fast/js/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt: Removed.
platform/win/fast/js/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt: Removed.
platform/win/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt: Removed.
platform/win/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt: Removed.
platform/win/sputnik: Copied from LayoutTests/platform/win/fast/js/sputnik.

9:37 PM Changeset in webkit [77893] by commit-queue@webkit.org

37 edits
38 deletes in trunk/LayoutTests

2011-02-07 Ami Fischman <fischman@google.com>

Reviewed by Eric Carlson.

Removed two of the three almost-duplicate test expectations
between {media,platform/chromium-{mac,win}} by excluding file
extensions from the emitted output.
Removed outdated test_expectation for deleted test.
http://crbug.com/28993

media/controls-right-click-on-timebar-expected.txt:
media/controls-right-click-on-timebar.html:
media/media-file.js: (stripExtension):
media/media-startTime-expected.txt:
media/media-startTime.html:
media/video-append-source-expected.txt:
media/video-append-source.html:
media/video-canvas-source-expected.txt:
media/video-canvas-source.html:
media/video-dom-src-expected.txt:
media/video-dom-src.html:
media/video-load-networkState-expected.txt:
media/video-load-networkState.html:
media/video-played-reset-expected.txt:
media/video-played-reset.html:
media/video-seek-past-end-paused-expected.txt:
media/video-seek-past-end-paused.html:
media/video-seek-past-end-playing-expected.txt:
media/video-seek-past-end-playing.html:
media/video-source-expected.txt:
media/video-source-type-expected.txt:
media/video-source-type-params-expected.txt:
media/video-source-type-params.html:
media/video-source-type.html:
media/video-source.html:
media/video-src-change-expected.txt:
media/video-src-change.html:
media/video-src-expected.txt:
media/video-src-remove-expected.txt:
media/video-src-remove.html:
media/video-src-set-expected.txt:
media/video-src-set.html:
media/video-src-source-expected.txt:
media/video-src-source.html:
media/video-src.html:
media/video-test.js: (enableFullTestDetailsPrinting): (test): (testExpected): (waitForEvent._eventCallback): (waitForEvent): (waitForEventAndTest._eventCallback): (waitForEventAndTest): (testException): (endTest):
platform/chromium-mac/media/controls-right-click-on-timebar-expected.txt: Removed.
platform/chromium-mac/media/media-startTime-expected.txt: Removed.
platform/chromium-mac/media/video-append-source-expected.txt: Removed.
platform/chromium-mac/media/video-canvas-source-expected.txt: Removed.
platform/chromium-mac/media/video-dom-src-expected.txt: Removed.
platform/chromium-mac/media/video-load-networkState-expected.txt: Removed.
platform/chromium-mac/media/video-played-reset-expected.txt: Removed.
platform/chromium-mac/media/video-seek-past-end-paused-expected.txt: Removed.
platform/chromium-mac/media/video-seek-past-end-playing-expected.txt: Removed.
platform/chromium-mac/media/video-source-add-src-expected.txt: Removed.
platform/chromium-mac/media/video-source-error-expected.txt: Removed.
platform/chromium-mac/media/video-source-expected.txt: Removed.
platform/chromium-mac/media/video-source-type-expected.txt: Removed.
platform/chromium-mac/media/video-source-type-params-expected.txt: Removed.
platform/chromium-mac/media/video-src-change-expected.txt: Removed.
platform/chromium-mac/media/video-src-expected.txt: Removed.
platform/chromium-mac/media/video-src-remove-expected.txt: Removed.
platform/chromium-mac/media/video-src-set-expected.txt: Removed.
platform/chromium-mac/media/video-src-source-expected.txt: Removed.
platform/chromium-win/media/controls-right-click-on-timebar-expected.txt: Removed.
platform/chromium-win/media/media-startTime-expected.txt: Removed.
platform/chromium-win/media/video-append-source-expected.txt: Removed.
platform/chromium-win/media/video-canvas-source-expected.txt: Removed.
platform/chromium-win/media/video-dom-src-expected.txt: Removed.
platform/chromium-win/media/video-load-networkState-expected.txt: Removed.
platform/chromium-win/media/video-played-reset-expected.txt: Removed.
platform/chromium-win/media/video-seek-past-end-paused-expected.txt: Removed.
platform/chromium-win/media/video-seek-past-end-playing-expected.txt: Removed.
platform/chromium-win/media/video-source-add-src-expected.txt: Removed.
platform/chromium-win/media/video-source-error-expected.txt: Removed.
platform/chromium-win/media/video-source-expected.txt: Removed.
platform/chromium-win/media/video-source-type-expected.txt: Removed.
platform/chromium-win/media/video-source-type-params-expected.txt: Removed.
platform/chromium-win/media/video-src-change-expected.txt: Removed.
platform/chromium-win/media/video-src-expected.txt: Removed.
platform/chromium-win/media/video-src-remove-expected.txt: Removed.
platform/chromium-win/media/video-src-set-expected.txt: Removed.
platform/chromium-win/media/video-src-source-expected.txt: Removed.
platform/chromium/test_expectations.txt:

9:37 PM Changeset in webkit [77892] by commit-queue@webkit.org

14 edits in trunk/Source

2011-02-07 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Andreas Kling.

[Qt] enum QWebPage::WebAction doesn't have value QWebPage::CopyImageUrl
https://bugs.webkit.org/show_bug.cgi?id=52974

Add ContextMenuItemTagCopyImageUrlToClipboard into standard action but Qt platform specific.

page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): (WebCore::ContextMenuController::populate): (WebCore::ContextMenuController::checkOrEnableIfNeeded):
platform/ContextMenuItem.h:
platform/LocalizationStrategy.h:
platform/LocalizedStrings.cpp: (WebCore::contextMenuItemTagCopyImageUrlToClipboard):
platform/LocalizedStrings.h:

2011-02-07 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Andreas Kling.

[Qt] enum QWebPage::WebAction doesn't have value QWebPage::CopyImageUrl
https://bugs.webkit.org/show_bug.cgi?id=52974

Add QWebPage::CopyImageUrlToClipboard into QWebPage::WebAction.

Api/qwebpage.cpp: (webActionForContextMenuAction): (QWebPage::triggerAction): (QWebPage::action):
Api/qwebpage.h:
WebCoreSupport/WebPlatformStrategies.cpp: (WebPlatformStrategies::contextMenuItemTagCopyImageUrlToClipboard):
WebCoreSupport/WebPlatformStrategies.h:

2011-02-07 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Andreas Kling.

[Qt] enum QWebPage::WebAction doesn't have value QWebPage::CopyImageUrl
https://bugs.webkit.org/show_bug.cgi?id=52974

Add ContextMenuItemTagCopyImageUrlToClipboard into standard action but Qt platform specific.

WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::WebPlatformStrategies::contextMenuItemTagCopyImageUrlToClipboard):
WebProcess/WebCoreSupport/WebPlatformStrategies.h:

9:28 PM Changeset in webkit [77891] by tkent@chromium.org

4 edits
2 adds in trunk

2011-02-07 Kenichi Ishibashi <bashi@chromium.org>

Reviewed by Kent Tamura.

HTMLFormElement::formElementIndex() returns a bad index into a vector of form associated elements
https://bugs.webkit.org/show_bug.cgi?id=53970

Adds HTMLObjectElement::virtualForm() to make HTMLObjectElement::form()
return the right value.

Test: fast/dom/HTMLObjectElement/form/nested-form-element.html

html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::virtualForm): Added.
html/HTMLObjectElement.h: Added virtualForm().

2011-02-07 Kenichi Ishibashi <bashi@chromium.org>

Reviewed by Kent Tamura.

HTMLFormElement::formElementIndex() returns a bad index into a vector of form associated elements
https://bugs.webkit.org/show_bug.cgi?id=53970

Adds a test that ensures WebKit parses successfully a page that
contains object elements which are in nested and defective form
elements.

fast/dom/HTMLObjectElement/form/nested-form-element-expected.txt: Added.
fast/dom/HTMLObjectElement/form/nested-form-element.html: Added.

8:39 PM Changeset in webkit [77890] by abarth@webkit.org

3 edits in trunk/Tools

2011-02-07 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove Leopard Debug as a core builder
https://bugs.webkit.org/show_bug.cgi?id=53971

The Leopard Debug builder has been failing to compile for several days.
My understanding is that folks are working on fixing the build, but for
the time being we should probably remove it from the list of core
builders so that the core waterfall can be green. We can certainly add
it back once the build is fixed.

Also, I've removed the Tiger builders because those no longer appear to
be attached to the buildbot master.

Scripts/webkitpy/common/net/buildbot/buildbot.py:
Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

8:29 PM Changeset in webkit [77889] by ojan@chromium.org

5 edits in trunk

2011-02-01 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Roben.

include svn revisions in git diffs for the code review tool to use
https://bugs.webkit.org/show_bug.cgi?id=53569

Scripts/webkitpy/common/checkout/scm.py:
Scripts/webkitpy/common/checkout/scm_unittest.py:

2011-02-01 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Roben.

include svn revisions in git diffs for the code review tool to use
https://bugs.webkit.org/show_bug.cgi?id=53569

PrettyPatch/PrettyPatch.rb:

8:27 PM Changeset in webkit [77888] by rniwa@webkit.org

3 edits in trunk/Source/WebCore

2011-02-07 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Leopard build fix.

WebCore.xcodeproj/project.pbxproj: let XCode have developmentRegion.
platform/mac/DragImageMac.mm: (WebCore::webkit_CGCeiling): Cast the return value of ceil to CGFloat.

8:21 PM Changeset in webkit [77887] by yuzo@google.com

2 edits in trunk/LayoutTests

2011-02-07 Yuzo Fujishima <yuzo@google.com>

Unreviewed attempt to fix a flaky test.
https://bugs.webkit.org/show_bug.cgi?id=51757

fast/css/font-face-download-error.html:

8:07 PM Changeset in webkit [77886] by zmo@google.com

2 edits in trunk/LayoutTests

2011-02-07 Zhenyao Mo <zmo@google.com>

Unreviewed, test expectations update.

platform/chromium/test_expectations.txt:

7:55 PM Changeset in webkit [77885] by jamesr@google.com

8 edits
1 move in trunk/LayoutTests

2011-02-07 James Robinson <jamesr@chromium.org>

Reviewed by Dan Bernstein.

Move the sputnik test suite out of fast/js/
https://bugs.webkit.org/show_bug.cgi?id=53954

The sputnik suite shouldn't go in fast/js/ because it is not fast and
it is an imported test suite. This moves it to LayoutTests/sputnik
and updates references in skipped lists / expectations.

platform/chromium/test_expectations.txt:
platform/gtk/Skipped:
platform/mac-tiger/Skipped:
platform/mac-wk2/Skipped:
platform/qt-wk2/Skipped:
platform/qt/Skipped:
platform/win/Skipped:

7:37 PM Changeset in webkit [77884] by rniwa@webkit.org

1 edit in trunk/Source/JavaScriptCore/ChangeLog

Fixing the change log entry.

7:34 PM Changeset in webkit [77883] by rniwa@webkit.org

5 edits in trunk/Source/JavaScriptCore

2011-02-07 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Removed some dead code from Heap
https://bugs.webkit.org/show_bug.cgi?id=53969

SunSpider reports no change.

runtime/MarkedSpace.cpp: (JSC::MarkedSpace::shrink): (JSC::MarkedSpace::sweep):
runtime/MarkedSpace.h: Removed resizeBlocks and growBlocks, and renamed shrinkBlocks to shrink, making it unconditionally shrink as much as possible.

7:13 PM Changeset in webkit [77882] by enrica@apple.com

4 edits in trunk/Source

Source/WebCore: Fixing a build break on Mac caused by http://trac.webkit.org/changeset/77874

Reviewed by Sam Weinig.

When moving code from WebKit to WebCore we needed to move some additional
functions previously in NSStringExtras.

WebCore.xcodeproj/project.pbxproj:
platform/mac/DragImageMac.mm:

(WebCore::fontFromNSFont):
(WebCore::canUseFastRenderer):
(WebCore::widthWithFont):
(WebCore::webkit_CGCeiling):
(WebCore::drawAtPoint):
(WebCore::drawDoubledAtPoint):
(WebCore::createDragImageForLink):

Source/WebKit2: Fixing a build break on Mac caused by http://trac.webkit.org/changeset/77874

Reviewed by Sam Weinig.

Removed unused static function.

WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

7:08 PM Changeset in webkit [77881] by ggaren@apple.com

3 edits in trunk/Source/JavaScriptCore

2011-02-07 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Removed some dead code from Heap
https://bugs.webkit.org/show_bug.cgi?id=53969

SunSpider reports no change.

runtime/MarkedSpace.cpp: (JSC::MarkedSpace::shrink): (JSC::MarkedSpace::sweep):
runtime/MarkedSpace.h: Removed resizeBlocks and growBlocks, and renamed shrinkBlocks to shrink, making it unconditionally shrink as much as possible.

6:21 PM Changeset in webkit [77880] by andersca@apple.com

2 edits in trunk/Source/WebKit2

<rdar://problem/8969888>
The WebProcess should set LSFileQuarantineEnabled to true

Reviewed by Sam Weinig.

WebProcess/Info.plist:

6:13 PM Changeset in webkit [77879] by zmo@google.com

2 edits in trunk/LayoutTests

2011-02-07 Zhenyao Mo <zmo@google.com>

Unreviewed, test expectations update.

platform/chromium/test_expectations.txt:

6:04 PM Changeset in webkit [77878] by Lucas Forschler

3 edits in trunk/Source/WebCore

2011-02-07 Lucas Forschler <Lucas Forschler>

Reviewed by Geoff Garen.

Tr #2, Fix the Leopard 32bit debug build.

No new tests required.

WebCore.xcodeproj/project.pbxproj:
accessibility/AccessibilityAllInOne.cpp:

5:58 PM Changeset in webkit [77877] by ggaren@apple.com

2 edits in trunk/Source/JavaScriptCore

2011-02-07 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Simplified the marked space's mark invariant
https://bugs.webkit.org/show_bug.cgi?id=53968

SunSpider reports no change.

runtime/MarkedSpace.cpp: (JSC::MarkedSpace::allocate): Mark objects when allocating them. This means that, at all times other than the mark phase, an object is live if and only if it is marked.

(JSC::MarkedSpace::containsSlowCase): Use the new mark invariant to
simplify testing whether an object is live.

5:53 PM Changeset in webkit [77876] by Beth Dakin

3 edits in trunk/Source/WebCore

Fix for <rdar://problem/8946961> Fix repaint problems
with WKScrollbarPainter scrollers while resizing the window

Reviewed by Sam Weinig.

Remove setPainterForPainterController() and
removePainterFromPainterController() since they aren't
used anymore.

platform/mac/ScrollAnimatorMac.h:

Return early if they alpha hasn't changed.

platform/mac/ScrollAnimatorMac.mm:

(-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):

If we're in a live resize, restore alpha to 1.
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):

5:47 PM Changeset in webkit [77875] by morrita@google.com

15 edits
4 adds in trunk

2011-02-03 MORITA Hajime <morrita@google.com>

Reviewed by Darin Fisher.

[Chromium] Should implement EditorClientImpl::requestCheckingOfString()
https://bugs.webkit.org/show_bug.cgi?id=51013

Unskipped passed test.

platform/chromium/test_expectations.txt:

2011-02-03 MORITA Hajime <morrita@google.com>

Reviewed by Darin Fisher.

[Chromium] Should implement EditorClientImpl::requestCheckingOfString()
https://bugs.webkit.org/show_bug.cgi?id=51013

Added WebTextCheckingCompletion to receive the checked result asynchronously.
Added WebViewClient::requestCheckingOfText() and related classes.
Implemented EditorClientImpl::requestCheckingOfString().

WebKit.gyp:
public/WebSettings.h:
public/WebTextCheckingCompletion.h: Added. (WebKit::WebTextCheckingCompletion::~WebTextCheckingCompletion):
public/WebTextCheckingResult.h: Added. (WebKit::WebTextCheckingResult::error): (WebKit::WebTextCheckingResult::position): (WebKit::WebTextCheckingResult::length): (WebKit::WebTextCheckingResult::WebTextCheckingResult):
public/WebViewClient.h: (WebKit::WebViewClient::requestCheckingOfText): Gave an implementation
src/AssertMatchingEnums.cpp:
src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::requestCheckingOfString):
src/EditorClientImpl.h:
src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setAsynchronousSpellCheckingEnabled):
src/WebSettingsImpl.h:
src/WebTextCheckingCompletionImpl.cpp: Added. (WebKit::toCoreResults): (WebKit::WebTextCheckingCompletionImpl::didFinishCheckingText):
src/WebTextCheckingCompletionImpl.h: Added. (WebKit::WebTextCheckingCompletionImpl::WebTextCheckingCompletionImpl):

2011-02-03 MORITA Hajime <morrita@google.com>

Reviewed by Darin Fisher.

[Chromium] Should implement EditorClientImpl::requestCheckingOfString()
https://bugs.webkit.org/show_bug.cgi?id=51013

Gave DRT implementation for requestTextCheck().

DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setAsynchronousSpellCheckingEnabled): Implemented.
DumpRenderTree/chromium/WebViewHost.cpp: (invokeFinishLastTextCheck): Added. (WebViewHost::requestTextCheck): Added. (WebViewHost::finishLastTextCheck): Added.
DumpRenderTree/chromium/WebViewHost.h:

5:44 PM Changeset in webkit [77874] by andersca@apple.com

8 edits in trunk/Source/WebKit2

2011-02-07 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Crash in web process after the connection had been closed
https://bugs.webkit.org/show_bug.cgi?id=51115
<rdar://problem/8964255>

Remove didCloseOnConnectionWorkQueue from Connection::Client and add
Connection::setDidCloseOnConnectionWorkQueueCallback which takes a static
function, eliminating the race condition in connectionDidClose where m_client could be
nulled out in the client thread right before we try to dereference it.

Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::Connection): Initialize m_didCloseOnConnectionWorkQueueCallback.

(CoreIPC::Connection::setDidCloseOnConnectionWorkQueueCallback):
Update m_didCloseOnConnectionWorkQueueCallback.

(CoreIPC::Connection::connectionDidClose):
Call m_didCloseOnConnectionWorkQueueCallback.

Platform/WorkQueue.h: Make WorkQueue noncopyable.

PluginProcess/PluginProcess.cpp: (WebKit::PluginProcess::initializeConnection): Call setDidCloseOnConnectionWorkQueueCallback.

Shared/ChildProcess.cpp: (WebKit::ChildProcess::didCloseOnConnectionWorkQueue):
Shared/ChildProcess.h: didCloseOnConnectionWorkQueue is now a static member function.

WebProcess/WebProcess.cpp: (WebKit::WebProcess::initialize): Call setDidCloseOnConnectionWorkQueueCallback.

5:39 PM Changeset in webkit [77873] by Martin Robinson

2 edits
59 adds in trunk/LayoutTests

2011-02-07 Martin Robinson <mrobinson@igalia.com>

Classify tests failing in the fast directory on GTK+. Add results for
tests that just need platform expectations.

platform/gtk/Skipped: Update the skipped list.
platform/gtk/fast/backgrounds/background-clip-text-expected.checksum: Added.
platform/gtk/fast/backgrounds/background-clip-text-expected.png: Added.
platform/gtk/fast/backgrounds/background-clip-text-expected.txt: Added.
platform/gtk/fast/canvas/canvas-zoom-expected.txt: Added.
platform/gtk/fast/css/css1_forward_compatible_parsing-expected.checksum: Added.
platform/gtk/fast/css/css1_forward_compatible_parsing-expected.png: Added.
platform/gtk/fast/css/css1_forward_compatible_parsing-expected.txt: Added.
platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Added.
platform/gtk/fast/css/invalid-percentage-property-expected.checksum: Added.
platform/gtk/fast/css/invalid-percentage-property-expected.png: Added.
platform/gtk/fast/css/invalid-percentage-property-expected.txt: Added.
platform/gtk/fast/css/text-align-expected.checksum: Added.
platform/gtk/fast/css/text-align-expected.png: Added.
platform/gtk/fast/css/text-align-expected.txt: Added.
platform/gtk/fast/dom/Element/getBoundingClientRect-expected.txt: Added.
platform/gtk/fast/dom/Range/getBoundingClientRect-expected.txt: Added.
platform/gtk/fast/dom/Range/getClientRects-expected.txt: Added.
platform/gtk/fast/dom/Window/webkitConvertPoint-expected.txt: Added.
platform/gtk/fast/dom/null-document-location-put-crash-expected.txt: Added.
platform/gtk/fast/dom/tabindex-clamp-expected.txt: Added.
platform/gtk/fast/events/js-keyboard-event-creation-expected.txt: Added.
platform/gtk/fast/events/offsetX-offsetY-expected.txt: Added.
platform/gtk/fast/events/pointer-events-2-expected.checksum: Added.
platform/gtk/fast/events/pointer-events-2-expected.png: Added.
platform/gtk/fast/events/pointer-events-2-expected.txt: Added.
platform/gtk/fast/fast-mobile-scrolling/fixed-position-element-expected.checksum: Added.
platform/gtk/fast/fast-mobile-scrolling/fixed-position-element-expected.png: Added.
platform/gtk/fast/fast-mobile-scrolling/fixed-position-element-expected.txt: Added.
platform/gtk/fast/fast-mobile-scrolling/no-fixed-position-elements-expected.checksum: Added.
platform/gtk/fast/fast-mobile-scrolling/no-fixed-position-elements-expected.png: Added.
platform/gtk/fast/fast-mobile-scrolling/no-fixed-position-elements-expected.txt: Added.
platform/gtk/fast/forms/listbox-hit-test-zoomed-expected.checksum: Added.
platform/gtk/fast/forms/listbox-hit-test-zoomed-expected.png: Added.
platform/gtk/fast/forms/listbox-hit-test-zoomed-expected.txt: Added.
platform/gtk/fast/html/tab-order-expected.txt: Added.
platform/gtk/fast/replaced/table-percent-height-expected.txt: Added.
platform/gtk/fast/selectors/lang-inheritance-expected.checksum: Added.
platform/gtk/fast/selectors/lang-inheritance-expected.png: Added.
platform/gtk/fast/selectors/lang-inheritance-expected.txt: Added.
platform/gtk/fast/selectors/lang-inheritance2-expected.checksum: Added.
platform/gtk/fast/selectors/lang-inheritance2-expected.png: Added.
platform/gtk/fast/selectors/lang-inheritance2-expected.txt: Added.
platform/gtk/fast/selectors/lang-vs-xml-lang-expected.checksum: Added.
platform/gtk/fast/selectors/lang-vs-xml-lang-expected.png: Added.
platform/gtk/fast/selectors/lang-vs-xml-lang-expected.txt: Added.
platform/gtk/fast/selectors/lang-vs-xml-lang-xhtml-expected.checksum: Added.
platform/gtk/fast/selectors/lang-vs-xml-lang-xhtml-expected.png: Added.
platform/gtk/fast/selectors/lang-vs-xml-lang-xhtml-expected.txt: Added.
platform/gtk/fast/text/international/danda-space-expected.checksum: Added.
platform/gtk/fast/text/international/danda-space-expected.png: Added.
platform/gtk/fast/text/international/danda-space-expected.txt: Added.
platform/gtk/fast/text/international/thai-baht-space-expected.checksum: Added.
platform/gtk/fast/text/international/thai-baht-space-expected.png: Added.
platform/gtk/fast/text/international/thai-baht-space-expected.txt: Added.

5:38 PM Changeset in webkit [77872] by zmo@google.com

2 edits in trunk/LayoutTests

2011-02-07 Zhenyao Mo <zmo@google.com>

Unreviewed, test expectations update.

platform/chromium/test_expectations.txt:

5:35 PM Changeset in webkit [77871] by Beth Dakin

4 edits in trunk/Source

Fix for https://bugs.webkit.org/show_bug.cgi?id=53950
USE_WK_SCROLLBAR_PAINTER in ScrollbarThemeMac should be in
Platform.h instead

Reviewed by Eric Seidel.

../JavaScriptCore:

wtf/Platform.h:

../WebCore:

Use hot new USE(WK_SCROLLBAR_PAINTER) from Platform.h rather
than the silly, old in-file #define.

platform/mac/ScrollbarThemeMac.mm:

(+[ScrollbarPrefsObserver appearancePrefsChanged:]):
(WebCore::updateArrowPlacement):
(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::scrollbarThickness):
(WebCore::ScrollbarThemeMac::usesOverlayScrollbars):
(WebCore::ScrollbarThemeMac::hasThumb):
(WebCore::ScrollbarThemeMac::minimumThumbLength):
(WebCore::ScrollbarThemeMac::paint):

5:34 PM Changeset in webkit [77870] by enrica@apple.com

47 edits
3 adds in trunk/Source

Reviewed Adam Roben and Darin Adler.

Source/WebCore:

WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775
<rdar://problem/8514409>

loader/EmptyClients.h: Removed createDragImageFromLink.
page/DragClient.h: Ditto.
page/DragController.cpp:

(WebCore::DragController::startDrag): changed call to createDragImageFromLink.

platform/DragImage.h:
platform/mac/DragImageMac.mm:

(WebCore::createDragImageForLink): Moved from DragClient.

platform/win/ClipboardUtilitiesWin.cpp: Added a series of functions

to de-serialize the drag data from the map into an IDataObject.
(WebCore::getWebLocData):
(WebCore::texthtmlFormat):
(WebCore::createGlobalData):
(WebCore::getFullCFHTML):
(WebCore::urlWFormat):
(WebCore::urlFormat):
(WebCore::filenameWFormat):
(WebCore::filenameFormat):
(WebCore::htmlFormat):
(WebCore::smartPasteFormat):
(WebCore::getURL):
(WebCore::getPlainText):
(WebCore::getTextHTML):
(WebCore::ClipboardDataItem::ClipboardDataItem):
(WebCore::getStringData):
(WebCore::getUtf8Data):
(WebCore::getCFData):
(WebCore::setUCharData):
(WebCore::setCharData):
(WebCore::setCFData):
(WebCore::getClipboardMap):
(WebCore::getClipboardData):
(WebCore::setClipboardData):

platform/win/ClipboardUtilitiesWin.h:
platform/win/DragImageWin.cpp: Moved createDragImageForLink from DragClient

to a platform specific file in WebCore. It makes a lot more sense here, since
the drag image is always created in WebCore for all the other content types
except for links.
(WebCore::dragLabelFont):
(WebCore::createDragImageForLink):

platform/win/WCDataObject.cpp: Added new way to

construct a WCDataObject from a DragDataMap.
(WebCore::WCDataObject::createInstance):
(WebCore::WCDataObject::clearData):

platform/win/WCDataObject.h:

Source/WebKit/chromium:

WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775