⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 9, 2011:

11:13 PM Changeset in webkit [78176] by mrowe@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

<rdar://problem/8805364> Malloc zone enumeration code should be safe in the face of errors from the memory reader.

Reviewed by Sam Weinig.

  • wtf/FastMalloc.cpp:

(WTF::PageHeapAllocator::recordAdministrativeRegions): Use the new helper function to walk the linked list safely.
(WTF::TCMalloc_ThreadCache_FreeList::enumerateFreeObjects): Ditto.
(WTF::TCMalloc_Central_FreeList::enumerateFreeObjects): Ditto.
(WTF::TCMallocStats::PageMapFreeObjectFinder::visit): Bail out if the span could not be read.
(WTF::TCMallocStats::PageMapMemoryUsageRecorder::visit): Ditto.

  • wtf/MallocZoneSupport.h:

(WTF::RemoteMemoryReader::operator()): Remove an assert that is not valid.
(WTF::RemoteMemoryReader::nextEntryInLinkedList): Add a helper function for retrieving the next entry in
a linked list. It maps a failed read of the remote memory in to a null pointer, which all callers can
handle gracefully.

9:31 PM Changeset in webkit [78175] by hayato@chromium.org
  • 3 edits in trunk/Tools

2011-02-09 Hayato Ito <​hayato@chromium.org>

Reviewed by Tony Chang.

[NRWT] Remove encoding parameters where we can assume data can be
written in binary mode.

​https://bugs.webkit.org/show_bug.cgi?id=54066

  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
9:21 PM Changeset in webkit [78174] by barraclough@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Bug 54164 - Optimize global_var accesses on JSVALUE64

Reviewed by Sam Weinig.

Directly embed the pointer to d->registers, optimize out the load
from the variable object, as we do already in JSVALUE32_64.

This is a ~1.5% win on sunspidey.

  • jit/JIT.cpp:
  • jit/JIT.h:
  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_get_global_var):
(JSC::JIT::emit_op_put_global_var):
(JSC::JIT::emit_op_get_scoped_var):
(JSC::JIT::emit_op_put_scoped_var):

9:15 PM Changeset in webkit [78173] by Simon Fraser
  • 3 edits
    4 adds in trunk

2011-02-09 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

REGRESSION (r77101) box-shadow sometimes renders incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=54160

Fix an issue when ShadowBlur had a cached image buffer
that was larger than that of the current shadow being drawn,
and the current shadow was partially clipped out.

In that situation endShadowLayer() would clip to the image
buffer, using the size of the buffer (as it must), but failed
to take into account the fact that we'd only cleared and painted
into a smaller section of the buffer. So we need to additionally
constrain the clip to cover only the valid part of the buffer.

Test: fast/box-shadow/shadow-buffer-partial.html

  • platform/graphics/ShadowBlur.cpp: (WebCore::ShadowBlur::endShadowLayer):
7:37 PM Changeset in webkit [78172] by rniwa@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

2011-02-09 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed; removed Windows port's expected result for r78104.

  • platform/win/editing/undo/undo-paste-when-caret-is-not-in-range-expected.txt: Removed.
7:07 PM Changeset in webkit [78171] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

Fix for <rdar://problem/8977051> CrashTracer: 8 crashes
in WebProcess at com.apple.WebCore:
-[ScrollbarPartAnimation setCurrentProgress:] + 364

Reviewed by Maciej Stachowiak.

The ScrollbarPartAnimation must be sent by reference!

  • platform/mac/ScrollAnimatorMac.mm:

(-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):

6:21 PM Changeset in webkit [78170] by ggaren@apple.com
  • 1 edit in trunk/Source/JavaScriptCore/ChangeLog

Fixed up ChangeLog after my last commit

6:20 PM Changeset in webkit [78169] by ggaren@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

2011-02-09 Adam Barth <​abarth@webkit.org>

Another attempt to fix the Qt Windows build.

  • config.h:
  • wtf/OSRandomSource.cpp: (WTF::randomValuesFromOS):
6:14 PM Changeset in webkit [78168] by rniwa@webkit.org
  • 5 edits
    2 adds in trunk

2011-02-09 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

REGRESSION(r76107): Crash in VisibleSelection::toNormalizedRange
​https://bugs.webkit.org/show_bug.cgi?id=54053

The bug was caused by RenderBlock::positionForPoint's improperly returning a shadow node inside
RenderFileUploadControl for hit testing and VisibleSelection::toNormalizedRange's always assuming
the position variable "s" is not null.

Fixed the bug by always returning a null position from RenderFileUploadControl::positionForPoint,
and also exiting early when either "s" or "e" is null in VisibleSelection::toNormalizedRange.

Test: fast/forms/file-input-hit-test.html

  • editing/VisibleSelection.cpp: (WebCore::VisibleSelection::toNormalizedRange):
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::positionForPoint):
  • rendering/RenderFileUploadControl.h:

2011-02-09 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

REGRESSION(r76107): Crash in VisibleSelection::toNormalizedRange
​https://bugs.webkit.org/show_bug.cgi?id=54053

Added a test to ensure WebKit does not crash when a user clicks on a region immediately after a file
upload control.

  • fast/forms/file-input-hit-test-expected.txt: Added.
  • fast/forms/file-input-hit-test.html: Added.
5:55 PM Changeset in webkit [78167] by weinig@apple.com
  • 3 edits in trunk/Source/WebCore

Overlay scrollbars crash used with a RenderListBox.

Reviewed by Beth Dakin.

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::layout):
(WebCore::RenderListBox::contentsSize):
(WebCore::RenderListBox::currentMousePosition):
(WebCore::RenderListBox::setHasVerticalScrollbar):

  • rendering/RenderListBox.h:

Implement enough of the ScrollableArea interface to get things generally
working.

5:30 PM Changeset in webkit [78166] by tkent@chromium.org
  • 4 edits
    2 adds in branches/chromium/597

Merge r77114

2011-01-30 Kenichi Ishibashi <​bashi@google.com>

Reviewed by Kent Tamura.

Dangling form associated elements should not be registered on the document
​https://bugs.webkit.org/show_bug.cgi?id=53223

Adds insertedIntoDocument() and remvoedFromDocument() to
FormAssociatedElement class to register the element on the document
if and only if it actually inserted into (removed from) the document.

Test: fast/forms/dangling-form-element-crash.html

  • html/FormAssociatedElement.cpp: (WebCore::FormAssociatedElement::insertedIntoDocument): Added. (WebCore::FormAssociatedElement::removedFromDocument): Ditto. (WebCore::FormAssociatedElement::insertedIntoTree): Don't register the element to a document. (WebCore::FormAssociatedElement::removedFromTree): Don't unregister the element from a document.
  • html/FormAssociatedElement.h:
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::insertedIntoDocument): Added. (WebCore::HTMLFormControlElement::removedFromDocument): Ditto.
  • html/HTMLFormControlElement.h:
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::insertedIntoDocument): Calls FormAssociatedElement::insertedIntoDocument(). (WebCore::HTMLObjectElement::removedFromDocument): Calls FormAssociatedElement::removedFromDocument().

2011-01-30 Kenichi Ishibashi <​bashi@google.com>

Reviewed by Kent Tamura.

Dangling form associated elements should not be registered on the document
​https://bugs.webkit.org/show_bug.cgi?id=53223

Adds a test that ensures dangling form associated elements are not
registered on the document.

  • fast/forms/dangling-form-element-crash-expected.txt: Added.
  • fast/forms/dangling-form-element-crash.html: Added.

BUG=crbug.com/70078
TBR=​inferno@chromium.org

5:28 PM Changeset in webkit [78165] by bweinstein@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix a typo in WebSecurityOrigin::protocol.

Rubber-stamped by Sam Weinig.

  • Shared/WebSecurityOrigin.h:

(WebKit::WebSecurityOrigin::protocol): This should return the protocol, not the domain.

5:26 PM Changeset in webkit [78164] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2011-02-09 Zhenyao Mo <​zmo@google.com>

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
5:17 PM Changeset in webkit [78163] by weinig@apple.com
  • 5 edits in trunk/Source/WebKit2

File uploads do not work within the sandbox
<rdar://problem/8950518>
​https://bugs.webkit.org/show_bug.cgi?id=54154

Reviewed by Darin Adler.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didChooseFilesForOpenPanel):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::extendSandboxForFileFromOpenPanel):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
4:28 PM Changeset in webkit [78162] by Beth Dakin
  • 8 edits in trunk/Source/WebCore

Fix for <rdar://problem/8966868> ScrollbarPainterDelegate
must return a layer if layer-backed to avoid crashing

Reviewed by Simon Fraser.

New virtual function scrollbarWillRenderIntoCompositingLayer()
on ScrollableArea.

  • page/FrameView.h:
  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::scrollbarWillRenderIntoCompositingLayer):

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::scrollbarWillRenderIntoCompositingLayer):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::scrollbarWillRenderIntoCompositingLayer):

  • rendering/RenderListBox.h:

Clean up unnecessary method declarations and call
scrollbarWillRenderIntoCompositingLayer() to deterine if
we need to return a layer.

  • platform/mac/ScrollAnimatorMac.mm:

(-[ScrollbarPainterDelegate layer]):

4:24 PM Changeset in webkit [78161] by ap@apple.com
  • 3 edits in trunk/Source/WebKit2

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=54148
<rdar://problem/8973887> REGRESSION (WebKit2): Opening two print dialogs causes havoc

  • UIProcess/API/mac/WKPrintingView.h: Moved _isForcingPreviewUpdate into a static variable, because dispatching a notification affects all WKPrintingViews at once.
  • UIProcess/API/mac/WKPrintingView.mm: (-[WKPrintingView _updatePreview]): Updated for new variable name. (-[WKPrintingView knowsPageRange:]): Don't break if the method is called twice in a row (we already had this logic when printing from separate thread, but not for preview). (-[WKPrintingView drawRect:]): Changed all LOG messages to have view object address for easier matching. (-[WKPrintingView rectForPage:]): Ditto. (-[WKPrintingView beginDocument]): Ditto. (-[WKPrintingView endDocument]): Ditto.
4:24 PM Changeset in webkit [78160] by Martin Robinson
  • 5 edits in trunk/LayoutTests

2011-02-09 Martin Robinson <​mrobinson@igalia.com>

Rebaseline a few tests which differ on the bots. Skip a test which is
timing out intermittently.

  • platform/gtk/Skipped: Skip a test timing out.
  • platform/gtk/fast/block/float/marquee-shrink-to-avoid-floats-expected.txt:
  • platform/gtk/fast/dom/52776-expected.txt:
  • platform/gtk/fast/text/stroking-decorations-expected.txt:
4:09 PM Changeset in webkit [78159] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-02-09 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Tony Chang.

nrwt multiprocessing: minor cleanup prior to implementing the new worker

This patch renames AbstractManager to ManagerConnection and
changes some argument names to be more consistent between
manager_worker_broker and message_broker. It also fixes a couple
of typos in message_broker. These changes will be tested by code
introduced in the next patch.

​https://bugs.webkit.org/show_bug.cgi?id=54067

  • Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
  • Scripts/webkitpy/layout_tests/layout_package/message_broker2.py:
3:53 PM Changeset in webkit [78158] by abarth@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-02-09 Adam Barth <​abarth@webkit.org>

Another attempt to fix the Qt Windows build.

  • config.h:
  • wtf/OSRandomSource.cpp: (WTF::randomValuesFromOS):
3:47 PM Changeset in webkit [78157] by andersca@apple.com
  • 7 edits
    3 adds in trunk

2011-02-09 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Repro crash with Sony Google TV ad at Gizmodo
​https://bugs.webkit.org/show_bug.cgi?id=54150

Since PluginView::evaluate can cause the plug-in element to go away, we need to protect it.

  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::~PluginView): Null out m_pluginElement here so we'll catch crashes earlier.

(WebKit::PluginView::evaluate):
Add a plug-in protector.

2011-02-09 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Repro crash with Sony Google TV ad at Gizmodo
​https://bugs.webkit.org/show_bug.cgi?id=54150
<rdar://problem/8782346>

Add test.

  • plugins/npruntime/evaluate-js-destroying-plugin-from-destroy-stream-expected.txt: Added.
  • plugins/npruntime/evaluate-js-destroying-plugin-from-destroy-stream.html: Added.

2011-02-09 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Repro crash with Sony Google TV ad at Gizmodo
​https://bugs.webkit.org/show_bug.cgi?id=54150
<rdar://problem/8782346>

Add a new plug-in test that runs JavaScript that destroys the plug-in from within its NPN_DestroyStream callback.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSDestroyingPluginFromDestroyStream.cpp: Added. (EvaluateJSDestroyingPluginFromDestroyStream::EvaluateJSDestroyingPluginFromDestroyStream): (EvaluateJSDestroyingPluginFromDestroyStream::NPP_Destroy): (EvaluateJSDestroyingPluginFromDestroyStream::NPP_DestroyStream):
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3:35 PM Changeset in webkit [78156] by abarth@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-09 Adam Barth <​abarth@webkit.org>

Attempt to fix the Qt Windows build.

  • wtf/OSRandomSource.cpp: (WTF::randomValuesFromOS):
3:33 PM Changeset in webkit [78155] by inferno@chromium.org
  • 5 edits
    2 copies in branches/chromium/648

Merge 77114

BUG=70078
Review URL: ​http://codereview.chromium.org/6476015

3:25 PM Changeset in webkit [78154] by Martin Robinson
  • 2 edits
    2 deletes in trunk/LayoutTests

2011-02-09 Martin Robinson <​mrobinson@igalia.com>

Clean up the skipped list a bit and unskip a few tests which are passing.

  • platform/gtk/Skipped: Clean up the skipped list.
  • platform/gtk/editing/selection/extend-after-mouse-selection-expected.txt: Removed.
  • platform/gtk/fast/dom/Window/window-properties-expected.txt: Removed.
3:23 PM Changeset in webkit [78153] by inferno@chromium.org
  • 2 edits
    2 copies in branches/chromium/648

Merge 76732

BUG=70779
Review URL: ​http://codereview.chromium.org/6471009

3:17 PM Changeset in webkit [78152] by inferno@chromium.org
  • 3 edits
    2 adds in branches/chromium/597

Merge 77468, crbug 69640

3:14 PM Changeset in webkit [78151] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/648

Merge 77468

BUG=69640
Review URL: ​http://codereview.chromium.org/6483007

3:13 PM Changeset in webkit [78150] by yael.aharon@nokia.com
  • 31 edits in trunk/Source/WebCore

2011-02-09 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Darin Adler.

Replace static_cast<HTMLElement*> with toHTMLElement
​https://bugs.webkit.org/show_bug.cgi?id=54117

No new tests since no new functionality was introduced.

  • accessibility/AccessibilityListBox.cpp: (WebCore::AccessibilityListBox::addChildren):
  • accessibility/AccessibilityMenuListPopup.cpp: (WebCore::AccessibilityMenuListPopup::addChildren):
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::accessibleNameForNode): (WebCore::AccessibilityRenderObject::accessibilityDescription):
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_name): (webkit_accessible_get_description):
  • bindings/gobject/WebKitDOMBinding.cpp: (WebKit::createWrapper): (WebKit::kit):
  • bindings/js/JSElementCustom.cpp: (WebCore::toJSNewlyCreated):
  • bindings/js/JSHTMLFrameSetElementCustom.cpp: (WebCore::JSHTMLFrameSetElement::nameGetter):
  • bindings/js/JSNodeCustom.cpp: (WebCore::createWrapperInline):
  • bindings/v8/custom/V8ElementCustom.cpp: (WebCore::toV8):
  • dom/Document.cpp: (WebCore::Document::body):
  • dom/Element.cpp: (WebCore::Element::deprecatedCreateContextualFragment):
  • dom/Range.cpp: (WebCore::Range::createContextualFragment):
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyBlockStyle): (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): (WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi): (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): (WebCore::ApplyStyleCommand::highestAncestorWithConflictingInlineStyle): (WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): (WebCore::ApplyStyleCommand::removeInlineStyle): (WebCore::ApplyStyleCommand::shouldSplitTextElement): (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
  • editing/DeleteButtonController.cpp: (WebCore::enclosingDeletableElement): (WebCore::DeleteButtonController::show):
  • editing/Editor.cpp: (WebCore::Editor::setBaseWritingDirection):
  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::mergeWithNeighboringLists):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::negateStyleRulesThatAffectAppearance): (WebCore::ReplaceSelectionCommand::handleStyleSpans): (WebCore::ReplaceSelectionCommand::copyStyleToChildren):
  • editing/SelectionController.cpp: (WebCore::scanForForm): (WebCore::SelectionController::currentForm):
  • editing/htmlediting.cpp: (WebCore::enclosingList): (WebCore::enclosingListChild): (WebCore::embeddedSublist): (WebCore::appendedSublist):
  • editing/markup.cpp: (WebCore::StyledMarkupAccumulator::appendElement):
  • html/HTMLCollection.cpp: (WebCore::HTMLCollection::checkForNameMatch): (WebCore::HTMLCollection::updateNameCache):
  • html/HTMLElement.cpp: (WebCore::HTMLElement::setOuterHTML): (WebCore::HTMLElement::shadowAncestorOwnerForm):
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formElementIndex):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setOption): (WebCore::HTMLSelectElement::setLength):
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getOuterHTML): (WebCore::InspectorDOMAgent::setOuterHTML):
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseMoveEvent):
  • rendering/RenderMeter.cpp: (WebCore::RenderMeter::createPart):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::createSubtreeIfNeeded):
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded):
3:11 PM Changeset in webkit [78149] by abarth@webkit.org
  • 10 edits
    4 adds in trunk/Source/JavaScriptCore

2011-02-09 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add WTF::cryptographicallyRandomNumber
​https://bugs.webkit.org/show_bug.cgi?id=54083

Introduce a cryptographically strong random number generator to WTF.
The random number generator is based on arc4random as found in:

​http://www.openbsd.org/cgi-bin/cvsweb/src/lib/libc/crypt/arc4random.c?rev=1.22

I've changed to source to WebKit style and abstracted the operating
system interaction to OSRandomSource. We'll use this functionality to
expose a cryptographically strong random number generator to
JavaScript.

  • Android.mk:
  • Android.v8.wtf.mk:
  • GNUmakefile.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • config.h:
  • wtf/CMakeLists.txt:
  • wtf/CryptographicallyRandomNumber.cpp: Added. (WTF::initMutexIfNeeded): (WTF::init): (WTF::addRandomData): (WTF::stir): (WTF::stirIfNeeded): (WTF::getByte): (WTF::getWord): (WTF::cryptographicallyRandomNumber): (WTF::cryptographicallyRandomValues):
  • wtf/CryptographicallyRandomNumber.h: Added.
  • wtf/OSRandomSource.cpp: Added. (WTF::randomValuesFromOS):
  • wtf/OSRandomSource.h: Added.
  • wtf/wtf.pri:
3:10 PM Changeset in webkit [78148] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-09 Mike Reed <​reed@google.com>

Reviewed by Kenneth Russell.

Use Skia's device->readPixels() when its bitmap claims to have no pixels, as this
handles the case when the device is backed by the GPU.
Patch developed by ​bsalomon@google.com

No new tests. Existing canvas tests suffice
e.g. LayoutTests/canvas/philip/...

  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::getImageData): (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::putImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):
3:07 PM Changeset in webkit [78147] by abarth@webkit.org
  • 8 edits
    10 adds in trunk

2011-02-09 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

document.close shouldn't affect non-script-created parsers
​https://bugs.webkit.org/show_bug.cgi?id=53689

Tests for various cases involving document.open/write/close. Not all
of them are related to this patch, but they were helpful to me in
working through this patch, so I've added them in case they're useful
in the future.

  • fast/frames/document-write-in-iframe-onload-3-expected.txt: Added.
  • fast/frames/document-write-in-iframe-onload-3.html: Added.
  • fast/parser/iframe-onload-document-close-with-external-script-2-expected.txt: Added.
  • fast/parser/iframe-onload-document-close-with-external-script-2.html: Added.
  • fast/parser/iframe-onload-document-close-with-external-script-3-expected.txt: Added.
  • fast/parser/iframe-onload-document-close-with-external-script-3.html: Added.
  • fast/parser/iframe-onload-document-close-with-external-script-expected.txt: Added.
  • fast/parser/iframe-onload-document-close-with-external-script.html: Added.
  • fast/parser/setTimeout-open-expected.txt: Added.
  • fast/parser/setTimeout-open.html: Added.

2011-02-09 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

document.close shouldn't affect non-script-created parsers
​https://bugs.webkit.org/show_bug.cgi?id=53689

Tests: fast/frames/document-write-in-iframe-onload-3.html

fast/parser/iframe-onload-document-close-with-external-script-2.html
fast/parser/iframe-onload-document-close-with-external-script-3.html
fast/parser/iframe-onload-document-close-with-external-script.html
fast/parser/setTimeout-open.html

Move our implementation of document.close closer to the spec by
introducing the notion of a script-created parser. This area of our
code is somewhat hairy. It might take a few more iterations before we
fully come up to spec.

  • dom/Document.cpp: (WebCore::Document::setContent): (WebCore::Document::open): (WebCore::Document::cancelParsing): (WebCore::Document::close):
    • Over time, this method should converge to the spec.

(WebCore::Document::explicitClose):

  • I'm not in love with this name. Somehow we want to differentiate between Document closing itself and the document.close DOM method.

(WebCore::Document::removePendingSheet):

  • dom/Document.h:
  • dom/ScriptableDocumentParser.cpp: (WebCore::ScriptableDocumentParser::ScriptableDocumentParser):
  • dom/ScriptableDocumentParser.h: (WebCore::ScriptableDocumentParser::setWasCreatedByScript): (WebCore::ScriptableDocumentParser::wasCreatedByScript):
    • General nonsense to keep track of whether the parser was created by script.
  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::hasInsertionPoint):
    • I'm not sure whether this part of the change is 100% correct. I think our notion of the EOF character might be subtly different from the notion in the spec.
  • html/parser/HTMLInputStream.h: (WebCore::HTMLInputStream::hasInsertionPoint):
    • Remove FIXME because we're fixing that!
3:03 PM Changeset in webkit [78146] by Martin Robinson
  • 2 edits
    339 adds in trunk/LayoutTests

2011-02-09 Martin Robinson <​mrobinson@igalia.com>

Import the last set of GTK+ baselines in the fast directory.

  • platform/gtk/Skipped: Unskip test which now have results.
3:02 PM Changeset in webkit [78145] by weinig@apple.com
  • 3 edits in trunk/Source/WebKit2

Google Maps says it has horizontal scrollbars when it doesn't
<rdar://problem/8978005>

Reviewed by Maciej Stachowiak.

We were updating the main frame's scrollbar state for changes to
frames other than the main frame.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::contentsSizeChanged):

  • WebProcess/WebCoreSupport/WebChromeClient.h:

(WebKit::WebChromeClient::WebChromeClient):
Change to bail out early if we are not looking at the main frame. Also
fix some silly typos and rename the variables to be more specific.

2:53 PM Changeset in webkit [78144] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-02-09 David Holloway <​dhollowa@chromium.org>

Reviewed by Darin Fisher.

Removes deprecated interface WebAutoFillClient::didAcceptAutocompleteSuggestion(). This interface has been replaced by the more general WebAutoFillClient::didAcceptAutoFillSuggestion() method.
​https://bugs.webkit.org/show_bug.cgi?id=54125

  • public/WebAutoFillClient.h:
  • src/EditorClientImpl.cpp:
  • src/EditorClientImpl.h:
2:41 PM Changeset in webkit [78143] by inferno@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-09 Abhishek Arya <​inferno@chromium.org>

Reviewed by James Robinson.

[Chromium] Issue 72387: Integer bounds crash in LayerTilerChromium::resizeLayer
​https://bugs.webkit.org/show_bug.cgi?id=54132


  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::resizeLayer):
2:40 PM Changeset in webkit [78142] by Martin Robinson
  • 2 edits
    996 adds in trunk/LayoutTests

2011-02-09 Martin Robinson <​mrobinson@igalia.com>

Continue importing new GTK+ results for tests in the fast directory.

  • platform/gtk/Skipped: Unskip test which now have results.
2:39 PM Changeset in webkit [78141] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/648

Merge 77914

BUG=70442
Review URL: ​http://codereview.chromium.org/6480008

2:37 PM Changeset in webkit [78140] by inferno@chromium.org
  • 4 edits
    2 copies in branches/chromium/648

Merge 76652

BUG=70442
Review URL: ​http://codereview.chromium.org/6482007

2:36 PM Changeset in webkit [78139] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-02-09 Ilya Sherman <​isherman@chromium.org>

Reviewed by Darin Fisher.

Export WebInputElement::defaultMaxLength as a function rather than a constant.
Needed because the order of initialization of static constants
is not guaranteed across compilation units.
​https://bugs.webkit.org/show_bug.cgi?id=54056

  • public/WebInputElement.h:
  • src/WebInputElement.cpp: (WebKit::WebInputElement::defaultMaxLength): Now a static function.
2:25 PM Changeset in webkit [78138] by Csaba Osztrogonác
  • 1 edit
    3 deletes in trunk/LayoutTests

Unreviewed.

Remove unnecessary Qt specific expected results after r78104.

  • platform/qt/editing/undo/undo-paste-when-caret-is-not-in-range-expected.checksum: Removed.
  • platform/qt/editing/undo/undo-paste-when-caret-is-not-in-range-expected.png: Removed.
  • platform/qt/editing/undo/undo-paste-when-caret-is-not-in-range-expected.txt: Removed.
2:23 PM Changeset in webkit [78137] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-09 Xiyuan Xia <​xiyuan@chromium.org>

Reviewed by Tony Chang.

[Chromium] Use #f7f7f7 for select popup background on chromium/linux
​https://bugs.webkit.org/show_bug.cgi?id=54115

No new tests since no behavior change.

  • css/themeChromiumLinux.css: (select[size="1"] option):
2:18 PM Changeset in webkit [78136] by inferno@chromium.org
  • 3 edits
    2 adds in branches/chromium/597

Merge r77548, crbug 71296

2:16 PM Changeset in webkit [78135] by robert@webkit.org
  • 3 edits in trunk/Source/WebKit/qt

2011-02-09 Robert Hogan <​robert@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] REGRESSION (r73535): tst_QWebPage fails
​https://bugs.webkit.org/show_bug.cgi?id=51331

Since r73535 a ContextMenu is only created when a context menu
event is received, so QWebPage::updatePositionDependentActions()
can't depend on one being there if it is called directly by
the client. QtWebKit itself only ever calls updatePositionDependentActions()
when a context menu event has been received.

Update tst_QWebPage:contextMenuCrash to create a context menu.
Add tst_QWebPage:updatePositionDependentActionsCrash to test for this crash.

There doesn't seem to be a good reason for creating a context menu if
clients call QWebPage::updatePositionDependentActions() when no
context menu event has ever been received.

  • Api/qwebpage.cpp: (QWebPagePrivate::createContextMenu):
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::contextMenuCrash):
2:16 PM Changeset in webkit [78134] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/648

Merge 77548

BUG=71296
Review URL: ​http://codereview.chromium.org/6483004

2:13 PM Changeset in webkit [78133] by inferno@chromium.org
  • 3 edits
    2 adds in branches/chromium/597

Merge r77565, r77573, crbug 71855

2:13 PM Changeset in webkit [78132] by zmo@google.com
  • 2 edits
    1 delete in trunk/LayoutTests

2011-02-09 Zhenyao Mo <​zmo@google.com>

Unreviewed, test expectations update.

  • platform/chromium-win/editing/undo/undo-paste-when-caret-is-not-in-range-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
2:10 PM Changeset in webkit [78131] by inferno@chromium.org
  • 1 edit in branches/chromium/648/Source/WebCore/rendering/RenderBlock.cpp

Merge 77573

BUG=71855
Review URL: ​http://codereview.chromium.org/6482006

2:09 PM Changeset in webkit [78130] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/648

Merge 77565

BUG=71855
Review URL: ​http://codereview.chromium.org/6480006

2:04 PM Changeset in webkit [78129] by zmo@google.com
  • 2 edits
    1 add in trunk/LayoutTests

2011-02-09 Zhenyao Mo <​zmo@google.com>

Unreviewed, rebaseline.

  • platform/chromium-win/editing/undo/undo-paste-when-caret-is-not-in-range-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
2:02 PM Changeset in webkit [78128] by Martin Robinson
  • 2 edits
    876 adds in trunk/LayoutTests

2011-02-09 Martin Robinson <​mrobinson@igalia.com>

Continue importing new GTK+ results for tests in the fast directory.

  • platform/gtk/Skipped: Unskip test which now have results.
1:53 PM Changeset in webkit [78127] by abarth@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-02-09 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

REGRESSION(HTML 5): HTMLDocumentParser does not report html parse errors to the console
​https://bugs.webkit.org/show_bug.cgi?id=41187

Wire up a basic HTML parse error message. There's a lot of room for
improvement in this area, but this is a start.

No tests! See ​https://bugs.webkit.org/show_bug.cgi?id=54134

  • html/parser/HTMLDocumentParser.h:
  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::parseError):
  • html/parser/HTMLTreeBuilder.h:
1:36 PM Changeset in webkit [78126] by ike@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-09 Ivan Krstić <​ike@apple.com>

Reviewed by Sam Weinig.

Allow read-only access to mouse preferences from sandboxed WebProcess.
<rdar://problem/8975279>

  • WebProcess/com.apple.WebProcess.sb:
1:36 PM Changeset in webkit [78125] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/648

Merge 77141

BUG=71114
Review URL: ​http://codereview.chromium.org/6478004

1:23 PM Changeset in webkit [78124] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2011-02-09 Zhenyao Mo <​zmo@google.com>

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
1:17 PM Changeset in webkit [78123] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/648

Merge 77262

BUG=71386
Review URL: ​http://codereview.chromium.org/6476009

1:15 PM Changeset in webkit [78122] by Martin Robinson
  • 2 edits
    595 adds in trunk/LayoutTests

2011-02-09 Martin Robinson <​mrobinson@igalia.com>

Continue importing new GTK+ results for tests in the fast directory.
Skip some tests that are obvious failures.

  • platform/gtk/Skipped: Unskip test with results. Classify failures.
1:15 PM Changeset in webkit [78121] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/648

Merge 77144

BUG=71388
Review URL: ​http://codereview.chromium.org/6480004

1:09 PM Changeset in webkit [78120] by inferno@chromium.org
  • 3 edits in branches/chromium/648

Merge 77433

BUG=71734
Review URL: ​http://codereview.chromium.org/6469012

1:06 PM Changeset in webkit [78119] by sfalken@apple.com
  • 3 edits in tags/Safari-534.18.1/Source/WebKit2

Merge r78116.

1:05 PM Changeset in webkit [78118] by inferno@chromium.org
  • 4 edits
    2 copies in branches/chromium/648

Merge 77418

BUG=71595
Review URL: ​http://codereview.chromium.org/6476007

1:02 PM Changeset in webkit [78117] by inferno@chromium.org
  • 4 edits
    2 copies in branches/chromium/648

Merge 76990

BUG=68120
Review URL: ​http://codereview.chromium.org/6469011

12:59 PM Changeset in webkit [78116] by sfalken@apple.com
  • 2 edits in trunk/Source/WebKit2

Build fix.

  • win/MainWin.cpp:

(wWinMain):

12:59 PM Changeset in webkit [78115] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/648

Merge 76708

BUG=67234
Review URL: ​http://codereview.chromium.org/6483002

12:57 PM Changeset in webkit [78114] by Dimitri Glazkov
  • 5 edits in branches/chromium/648

Merge 78077 - 2011-02-08 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

REGRESSION(r71934): Shadow DOM nodes leak via relatedTarget
​https://bugs.webkit.org/show_bug.cgi?id=52065

  • fast/events/shadow-boundary-crossing.html: Added relatedTarget retargeting test.

2011-02-08 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

REGRESSION(r71934): Shadow DOM nodes leak via relatedTarget
​https://bugs.webkit.org/show_bug.cgi?id=52065

  • dom/Node.cpp: (WebCore::pullOutOfShadow): Added a helper to move a node to the outermost

boundary of shadow DOM.

(WebCore::Node::dispatchMouseEvent): Changed to use pullOutOfShadow.

TBR=Dimitri Glazkov
Review URL: ​http://codereview.chromium.org/6469009

12:56 PM Changeset in webkit [78113] by inferno@chromium.org
  • 1 edit
    3 copies in branches/chromium/648

Merge 76915

BUG=71115
Review URL: ​http://codereview.chromium.org/6471003

12:52 PM Changeset in webkit [78112] by inferno@chromium.org
  • 2 edits
    2 copies in branches/chromium/648

Merge 76828

BUG=68741
Review URL: ​http://codereview.chromium.org/6469008

12:50 PM Changeset in webkit [78111] by zmo@google.com
  • 2 edits
    5 adds in trunk/LayoutTests

2011-02-09 Zhenyao Mo <​zmo@google.com>

Unreviewed, rebaseline.

  • platform/chromium-linux/fast/box-shadow/inset-box-shadows-expected.checksum: Added.
  • platform/chromium-linux/fast/box-shadow/inset-box-shadows-expected.png: Added.
  • platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.checksum: Added.
  • platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.png: Added.
  • platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
12:50 PM Changeset in webkit [78110] by inferno@chromium.org
  • 6 edits
    2 copies in branches/chromium/648

Merge 76728

BUG=68263
Review URL: ​http://codereview.chromium.org/6483001

12:46 PM Changeset in webkit [78109] by inferno@chromium.org
  • 1 edit in branches/chromium/648/Source/WebCore/svg/SVGFont.cpp

Merge 77766

BUG=72134
Review URL: ​http://codereview.chromium.org/6471002

12:22 PM Changeset in webkit [78108] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Try to fix the build.

  • wtf/Bitmap.h: Include string.h for memset. Not sure why this started

failing now.

12:15 PM Changeset in webkit [78107] by abarth@webkit.org
  • 1 edit
    1 move in trunk

2011-02-09 Adam Barth <​abarth@webkit.org>

Reviewed by Steve Block.

Move Android.mk into Source
​https://bugs.webkit.org/show_bug.cgi?id=53751

A somewhat blind attempt to move Android.mk into the Source directory.
I'm sure I've goofed this up in some way. The Android folks have
kindly volunteered to fix this up once they merge past this revision.

  • Android.mk: Removed.
  • Source/Android.mk: Copied from Android.mk.
12:15 PM Changeset in webkit [78106] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-02-09 Sailesh Agrawal <​sail@chromium.org>

Reviewed by Tony Chang.

Search/replace references to gfx/* with ui/gfx/*

  • public/WebPoint.h:
  • public/WebRect.h:
  • public/WebSize.h:
12:09 PM Changeset in webkit [78105] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-02-09 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.

A tiny bit of encapsulation for MarkedBlock: made its heap data member private
​https://bugs.webkit.org/show_bug.cgi?id=54129

  • runtime/MarkedBlock.h: (JSC::MarkedBlock::isCellAligned): (JSC::MarkedBlock::MarkedBlock): (JSC::MarkedBlock::heap): Made the heap data member private, and provided a constructor and an accessor.
  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::allocateBlock):
  • runtime/MarkedSpace.h: (JSC::MarkedSpace::heap): Use the constructor and accessor.
12:08 PM Changeset in webkit [78104] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

2011-02-09 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

VisibleSelection::setWithoutValidation() should allow caret selection.
​https://bugs.webkit.org/show_bug.cgi?id=53943

Fixed the new test introduced in the previous patch for the same bug. Previous test isn't platform independent, and fails on all platforms other than Mac OS X with WebKit 1.

  • editing/undo/undo-paste-when-caret-is-not-in-range-expected.txt:
  • editing/undo/undo-paste-when-caret-is-not-in-range.html:
12:06 PM Changeset in webkit [78103] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-09 Naoki Takano <​takano.naoki@gmail.com>

Reviewed by Kenneth Russell.

[Chromium] Issue 58536: Fix Layout Test canvas/philip/tests/2d.imageData.put.alpha.html with --accelerated-2d-canvas.
​https://bugs.webkit.org/show_bug.cgi?id=53757

This fix is for 2d.imageData.put.alpha.html with --accelerated-2d-canvas. No new tests.

  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::putUnmultipliedImageData): needs to call syncSoftwareCanvas() to sync between hardware and software. (WebCore::ImageBuffer::putPremultipliedImageData): needs to call syncSoftwareCanvas() to sync between hardware and software.
12:03 PM Changeset in webkit [78102] by crogers@google.com
  • 6 edits in trunk/Source/WebCore

2011-02-09 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

Fix scaling and thread safety of FFTFrameFFTW
​https://bugs.webkit.org/show_bug.cgi?id=54045

No new tests since audio API is not yet implemented.

  • platform/audio/FFTFrame.h:
  • platform/audio/fftw/FFTFrameFFTW.cpp: (WebCore::FFTFrame::FFTFrame): (WebCore::FFTFrame::doFFT): (WebCore::FFTFrame::doInverseFFT): (WebCore::FFTFrame::initialize): (WebCore::FFTFrame::cleanup): (WebCore::FFTFrame::realData): (WebCore::FFTFrame::imagData): (WebCore::FFTFrame::fftwPlanForSize):
  • platform/audio/mac/FFTFrameMac.cpp: (WebCore::FFTFrame::initialize):
  • platform/audio/mkl/FFTFrameMKL.cpp: (WebCore::FFTFrame::initialize):
  • webaudio/AudioContext.cpp: (WebCore::AudioContext::AudioContext):
11:57 AM Changeset in webkit [78101] by inferno@chromium.org
  • 8 edits
    2 adds in branches/chromium/597

Merge r76728, crbug 68263

11:54 AM Changeset in webkit [78100] by levin@chromium.org
  • 3 edits in trunk/Tools

2011-02-09 David Levin <​levin@chromium.org>

Reviewed by Eric Seidel.

check-webkit-style: The error message about NULL should be more clear for comments.
​https://bugs.webkit.org/show_bug.cgi?id=53786

  • Scripts/webkitpy/style/checkers/cpp.py: Clarified the error message.
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Fixed the corresponding test.
11:52 AM Changeset in webkit [78099] by inferno@chromium.org
  • 3 edits
    2 adds in branches/chromium/597

Merge 77141, crbug 71114

11:49 AM Changeset in webkit [78098] by Chris Fleizach
  • 3 edits in trunk/Source/WebCore

AX: accessibilityShouldUseUniqueId doesn't need to be in the core AX object
​https://bugs.webkit.org/show_bug.cgi?id=54126

Reviewed by Darin Adler.

This is a Mac-only accessibility API concept and doesn't belong in the core AX object.

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::node):

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityShouldUseUniqueId]):

11:48 AM Changeset in webkit [78097] by Martin Robinson
  • 2 edits
    589 adds in trunk/LayoutTests

2011-02-09 Martin Robinson <​mrobinson@igalia.com>

Continue importing new GTK+ results for tests in the fast directory.
Skip some tests that are obvious failures.

  • platform/gtk/Skipped: Unskip some tests that now have results.
11:46 AM Changeset in webkit [78096] by inferno@chromium.org
  • 3 edits
    2 adds in branches/chromium/597

Merge r77262, crbug 71386

11:43 AM Changeset in webkit [78095] by commit-queue@webkit.org
  • 16 edits
    3 adds in trunk

2011-02-09 Nebojsa Ciric <​cira@chromium.org>

Reviewed by Darin Fisher.

Implements Locale object of JavaScript internationalization API proposal, as an
v8 extension. Extension code is hosted in v8 project (src/extensions/experimental/i18n-extension.{cc,h})
and in this patch we just provide flags, tests and build rules for chromium port.
​https://bugs.webkit.org/show_bug.cgi?id=49414

  • fast/js/i18n-bindings-locale-expected.txt: Added.
  • fast/js/i18n-bindings-locale.html: Added.
  • fast/js/script-tests/i18n-bindings-locale.js: Added. (reportResult): (localeTests.this.defaultLocale): (localeTests.this.baseLocale): (localeTests.this.languageScriptLocale): (localeTests.this.languageScriptRegionLocale): (localeTests.this.languageScriptRegionExtensionLocale): (localeTests.this.languageScriptRegionDashUExtensionLocale): (localeTests.this.availableLocales): (localeTests.this.maximizedLocale): (localeTests.this.maximizedLocaleWithExtension): (localeTests.this.minimizedLocale): (localeTests.this.minimizedLocaleWithExtension): (localeTests.this.displayForBaseLocale): (localeTests.this.displayInSameLocale): (localeTests.this.displayInDifferentLocale): (localeTests.this.displayInCyrillicScript): (localeTests.this.displayInHebrewScript): (localeTests):
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-02-09 Nebojsa Ciric <​cira@chromium.org>

Reviewed by Darin Fisher.

Implements Locale object of JavaScript internationalization API proposal, as an
v8 extension. Extension code is hosted in v8 project (src/extensions/experimental/i18n-extension.{cc,h})
and in this patch we just provide flags, tests and build rules for chromium port.
​https://bugs.webkit.org/show_bug.cgi?id=49414

Test: fast/js/i18n-bindings-locale.html

  • WebCore.gyp/WebCore.gyp:
  • bindings/generic/RuntimeEnabledFeatures.cpp: (WebCore::RuntimeEnabledFeatures::experimentalI18NAPIEnabled):
  • bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setExperimentalI18NAPIEnabled):
  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::createNewContext):

2011-02-09 Nebojsa Ciric <​cira@chromium.org>

Reviewed by Darin Fisher.

Implements Locale object of JavaScript internationalization API proposal, as an
v8 extension. Extension code is hosted in v8 project (src/extensions/experimental/i18n-extension.{cc,h})
and in this patch we just provide flags, tests and build rules for chromium port.
​https://bugs.webkit.org/show_bug.cgi?id=49414

  • features.gypi:
  • public/WebRuntimeFeatures.h:
  • src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableExperimentalI18NAPI): (WebKit::WebRuntimeFeatures::isExperimentalI18NAPIEnabled):

2011-02-09 Nebojsa Ciric <​cira@chromium.org>

Reviewed by Darin Fisher.

Implements Locale object of JavaScript internationalization API proposal, as an
v8 extension. Extension code is hosted in v8 project (src/extensions/experimental/i18n-extension.{cc,h})
and in this patch we just provide flags, tests and build rules for chromium port.
​https://bugs.webkit.org/show_bug.cgi?id=49414

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell):
11:42 AM Changeset in webkit [78094] by inferno@chromium.org
  • 3 edits
    2 adds in branches/chromium/597

Merge r77144, crbug 71388

11:38 AM Changeset in webkit [78093] by inferno@chromium.org
  • 5 edits in branches/chromium/597

Merge r77433, crbug 71734

11:35 AM Changeset in webkit [78092] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2011-02-09 Zhenyao Mo <​zmo@google.com>

Unreviewed, fix a bug in test_expectations.txt.

  • platform/chromium/test_expectations.txt:
11:32 AM Changeset in webkit [78091] by inferno@chromium.org
  • 2 edits in branches/chromium/597/WebCore

Merge r77766, crbug 72134

11:27 AM Changeset in webkit [78090] by inferno@chromium.org
  • 6 edits
    2 adds in branches/chromium/597

Merge r77418, crbug 71595

11:23 AM Changeset in webkit [78089] by xji@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

2011-02-09 Xiaomei Ji <​xji@chromium.org>

Unreviewed.

Rebaseline for chromium-mac after r77952.
Added chromium-mac baseline due to fallback sequence.

  • platform/chromium-mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
11:19 AM Changeset in webkit [78088] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2011-02-09 Zhenyao Mo <​zmo@google.com>

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
11:15 AM Changeset in webkit [78087] by inferno@chromium.org
  • 3 edits
    2 adds in branches/chromium/597

Merge r76915, crbug 71115

11:09 AM Changeset in webkit [78086] by inferno@chromium.org
  • 2 adds in branches/chromium/597/LayoutTests/fast/css

Merge r76828, bug 68741, layouttests

11:06 AM Changeset in webkit [78085] by yael.aharon@nokia.com
  • 3 edits
    1 delete in trunk/LayoutTests

2011-02-09 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Martin Robinson.

frames/flattening/iframe-flattening-crash.html fails on GTK.
​https://bugs.webkit.org/show_bug.cgi?id=54106

Modify the test to be more consistent with other frame flattening tests.

  • fast/frames/flattening/iframe-flattening-crash.html:
  • fast/frames/flattening/resources/iframe-flattening-crash.html: Removed.
  • platform/gtk/Skipped:
11:05 AM Changeset in webkit [78084] by inferno@chromium.org
  • 4 edits in branches/chromium/597

Merge r76828, bug 68741

10:54 AM Changeset in webkit [78083] by sfalken@apple.com
  • 2 edits in tags/Safari-534.18.1/Source/WebCore

Merge r78045.

10:50 AM Changeset in webkit [78082] by bweinstein@apple.com
  • 1 edit
    3 adds in trunk/LayoutTests

Add failing Windows expected results for tests that were added recently and have failed since
they were added.

​https://bugs.webkit.org/show_bug.cgi?id=54120 tracks editing/undo/undo-paste-when-caret-is-not-in-range.html
​https://bugs.webkit.org/show_bug.cgi?id=54122 tracks plugins/invalidate_rect.html

  • platform/win/editing/undo: Added.
  • platform/win/editing/undo/undo-paste-when-caret-is-not-in-range-expected.txt: Added.
  • platform/win/plugins/invalidate_rect-expected.txt: Added.
10:48 AM Changeset in webkit [78081] by sfalken@apple.com
  • 5 edits in tags/Safari-534.18.1/Source

Versioning.

10:41 AM Changeset in webkit [78080] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2011-02-09 Zhenyao Mo <​zmo@google.com>

Unreviewed, test expectations.

  • platform/chromium/test_expectations.txt:
10:38 AM Changeset in webkit [78079] by Martin Robinson
  • 3 edits
    445 adds in trunk

2011-02-09 Martin Robinson <​mrobinson@igalia.com>

Add more results for many tests in the fast directory missing results.

  • platform/gtk/Skipped: Unskip more tests.
10:04 AM Changeset in webkit [78078] by sfalken@apple.com
  • 1 copy in tags/Safari-534.18.1

New tag.

10:03 AM Changeset in webkit [78077] by Dimitri Glazkov
  • 5 edits in trunk

2011-02-08 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

REGRESSION(r71934): Shadow DOM nodes leak via relatedTarget
​https://bugs.webkit.org/show_bug.cgi?id=52065

  • fast/events/shadow-boundary-crossing.html: Added relatedTarget retargeting test.

2011-02-08 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

REGRESSION(r71934): Shadow DOM nodes leak via relatedTarget
​https://bugs.webkit.org/show_bug.cgi?id=52065

  • dom/Node.cpp: (WebCore::pullOutOfShadow): Added a helper to move a node to the outermost

boundary of shadow DOM.

(WebCore::Node::dispatchMouseEvent): Changed to use pullOutOfShadow.

10:03 AM Changeset in webkit [78076] by Martin Robinson
  • 2 edits
    448 adds in trunk/LayoutTests

2011-02-09 Martin Robinson <​mrobinson@igalia.com>

Add more results for many tests in the fast directory missing results.

  • platform/gtk/Skipped: Unskip tests that now have results.
10:00 AM Changeset in webkit [78075] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2011-02-09 Zhenyao Mo <​zmo@google.com>

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt
9:52 AM Changeset in webkit [78074] by alex
  • 3 edits
    1 copy in trunk/Source/WebKit2

2011-02-09 Amruth Raj <​amruthraj@motorola.com> and Ravi Phaneendra Kasibhatla <​ravi.kasibhatla@motorola.com>

Reviewed by Martin Robinson.

[GTK] Implement Module class for WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=48510

  • GNUmakefile.am:
  • Platform/Module.h: Added GModule handle for GTK port.
  • Platform/gtk/ModuleGtk.cpp: Initial code using GModule calls. (WebKit::Module::load): (WebKit::Module::unload): (WebKit::Module::platformFunctionPointer):
9:46 AM Changeset in webkit [78073] by yael.aharon@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-02-09 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Darin Adler.

Add convenience method toHTMLElement(Node*)
​https://bugs.webkit.org/show_bug.cgi?id=54105

No new tests since no new functionality introduced.

  • html/HTMLElement.h: (WebCore::toHTMLElement):
9:45 AM Changeset in webkit [78072] by alex
  • 4 edits
    5 adds in trunk/Source/WebKit2

2011-02-09 Chandra Vallala <​chandra.vallala@motorola.com> and Alejandro G. Castro <​alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Implement WKBaseGtk API for Webkit2
​https://bugs.webkit.org/show_bug.cgi?id=54081

  • GNUmakefile.am: Added new files to compilation.
  • Shared/API/c/WKBase.h: Included WKBaseGtk.h in this file.
  • Shared/API/c/gtk: Added.
  • Shared/API/c/gtk/WKBaseGtk.h: Added. Declaration of WKViewRef for GTK port.
  • UIProcess/API/C/WKAPICast.h: Included WKAPICastGtk.h in this file.
  • UIProcess/API/C/gtk: Added.
  • UIProcess/API/C/gtk/WKAPICastGtk.h: Added. Type definition template for WKViewRef to WebView and vice-versa.
  • UIProcess/API/C/gtk/WKView.cpp: Added. Implementation of WKView API interface. (WKViewCreate): (WKViewGetWindow): (WKViewGetPage): (WKURLCreateWithURL):
  • UIProcess/API/C/gtk/WKView.h: Added. Declaration of WKView API interface.
9:41 AM Changeset in webkit [78071] by Martin Robinson
  • 2 edits
    300 adds in trunk/LayoutTests

2011-02-09 Martin Robinson <​mrobinson@igalia.com>

Add test results for many tests in the fast directory missing results.

  • platform/gtk/Skipped: Unskip tests with results.
9:35 AM Changeset in webkit [78070] by christian@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk/po

Unreviewed translation file.

Update Simplified Chinese (zh_CN) translation of WebKitGtk
​https://bugs.webkit.org/show_bug.cgi?id=42496

  • zh_CN.po: Updated.
9:33 AM Changeset in webkit [78069] by alex
  • 4 edits
    2 copies
    1 add in trunk/Source/WebKit2

2011-02-09 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Add WebGraphicsContext stub to the compilation
​https://bugs.webkit.org/show_bug.cgi?id=54078

  • GNUmakefile.am:
  • Shared/API/c/gtk/WKGraphicsContextGtk.cpp: Added stub just for compilation. (WKGraphicsContextGetGtkContext):
  • Shared/API/c/gtk/WKGraphicsContextGtk.h: Added stub just for compilation.
  • Shared/WebGraphicsContext.cpp: (WebKit::WebGraphicsContext::WebGraphicsContext):
  • Shared/WebGraphicsContext.h: (WebKit::WebGraphicsContext::platformContext):
9:30 AM Changeset in webkit [78068] by christian@webkit.org
  • 1 edit
    1 add in trunk/Source/WebKit/gtk/po

Please add Greek translation of WebkitGTK+
​https://bugs.webkit.org/show_bug.cgi?id=34482

  • gr.po: Added.
9:27 AM Changeset in webkit [78067] by christian@webkit.org
  • 1 edit
    1 add in trunk/Source/WebKit/gtk/po

Unreviewed translation file.

Arabic translation
​https://bugs.webkit.org/show_bug.cgi?id=36340

  • ar.po: Added.
9:25 AM Changeset in webkit [78066] by weinig@apple.com
  • 4 edits in trunk/Source/WebCore

Fixed positioned elements at very top or bottom of page remain fixed but clip during rubber-banding
<rdar://problem/7615997>
​https://bugs.webkit.org/show_bug.cgi?id=54054

Reviewed by Dan Bernstein.

Take the overhang into account when calculating position for elements with position: fixed.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::scrollXForFixedPosition):
(WebCore::ScrollView::scrollYForFixedPosition):
(WebCore::ScrollView::scrollOffsetForFixedPosition):

  • platform/ScrollView.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::mapLocalToContainer):
(WebCore::RenderView::mapAbsoluteToLocalPoint):
(WebCore::RenderView::computeRectForRepaint):

9:24 AM Changeset in webkit [78065] by alex
  • 2 edits in trunk/Source/WebKit2

2011-02-09 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Add geolocation support to the webkit2 compilation
​https://bugs.webkit.org/show_bug.cgi?id=54077

Add Geolocation files to the GTK compilation.

  • GNUmakefile.am:
9:21 AM Changeset in webkit [78064] by christian@webkit.org
  • 1 edit
    1 add in trunk/Source/WebKit/gtk/po

Unreviewed translation file.

Attached is the Bulgarian translation of WebKit Gtk
​https://bugs.webkit.org/show_bug.cgi?id=44400

  • bg.po: Added.
9:17 AM Changeset in webkit [78063] by christian@webkit.org
  • 1 edit
    1 add in trunk/Source/WebKit/gtk/po

Unreviewed translation file.

[l10n] Indonesian translation
​https://bugs.webkit.org/show_bug.cgi?id=46455

  • id.po: Added.
9:13 AM Changeset in webkit [78062] by Simon Fraser
  • 8 edits
    4 adds in trunk

2011-02-09 Simon Fraser <Simon Fraser>

Reviewed by Dirk Schulze.

Enhance ShadowBlur to tile inset box shadows
​https://bugs.webkit.org/show_bug.cgi?id=51567

Add a tiling code path to ShadowBlur for rendering inset
box-shadows.

Test: fast/box-shadow/inset-box-shadows.html

  • platform/graphics/ShadowBlur.cpp: (WebCore::computeSliceSizesFromRadii): Compute the slice sizes for the eight-piece shadow template. (WebCore::ShadowBlur::templateSize): Compute the size of the template, given the slice sizes. (WebCore::ShadowBlur::drawRectShadow): Bail early if layerRect is empty (which probably means we're clipped out). Call templateSize() and use the result to decide whether to tile. (WebCore::ShadowBlur::drawInsetShadow): New method for inset shadows. (WebCore::ShadowBlur::drawRectShadowWithoutTiling): Code moved. (WebCore::ShadowBlur::drawInsetShadowWithoutTiling): The non-tiling code path for inset shadows. (WebCore::ShadowBlur::drawInsetShadowWithTiling): Fill the shadow template buffer, paint the non-blurred area of the destination, and then call drawLayerPieces() to paint the eight-piece template image. (WebCore::ShadowBlur::drawRectShadowWithTiling): Refactored code, now shares the blurring code via blurAndColorShadowBuffer(), and the tiled template drawing via drawLayerPieces(). (WebCore::ShadowBlur::drawLayerPieces): Draw an eight-piece image from the shadow template to the destination. (WebCore::ShadowBlur::blurAndColorShadowBuffer): Blur the pixels in the image buffer, and colorize them using the CompositeSourceIn operation.
  • platform/graphics/ShadowBlur.h:
9:13 AM Changeset in webkit [78061] by Laszlo Gombos
  • 2 edits in trunk/Tools

2011-02-09 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove UiTools dependency from MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=54096

  • MiniBrowser/qt/MiniBrowser.pro:
9:12 AM Changeset in webkit [78060] by christian@webkit.org
  • 1 edit
    1 add in trunk/Source/WebKit/gtk/po

Unreviewed translation file.

[l10n] Polish translation of WebKitGTK+
​https://bugs.webkit.org/show_bug.cgi?id=46567

  • pl.po: Added.
9:06 AM Changeset in webkit [78059] by christian@webkit.org
  • 1 edit
    1 add in trunk/Source/WebKit/gtk/po

Unreviewed translation file.

[Gtk] Please add Hungarian translation
​https://bugs.webkit.org/show_bug.cgi?id=34543

  • hu.po: Added.
9:03 AM Changeset in webkit [78058] by jochen@chromium.org
  • 8 edits
    15 adds in trunk

2011-02-09 Jochen Eisinger <​jochen@chromium.org>

Reviewed by Adam Barth.

Disable script elements when a CSP header is present
​https://bugs.webkit.org/show_bug.cgi?id=53867

  • http/tests/security/contentSecurityPolicy/no-policy-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/no-policy.html: Added.
  • http/tests/security/contentSecurityPolicy/resources/echo-iframe.pl: Added.
  • http/tests/security/contentSecurityPolicy/resources/echo-script-src.pl: Added.
  • http/tests/security/contentSecurityPolicy/resources/redir.php: Added.
  • http/tests/security/contentSecurityPolicy/resources/script-src.html: Added.
  • http/tests/security/contentSecurityPolicy/resources/script.js: Added.
  • http/tests/security/contentSecurityPolicy/script-src-in-iframe-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/script-src-in-iframe.html: Added.
  • http/tests/security/contentSecurityPolicy/script-src-none-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/script-src-none.html: Added.
  • http/tests/security/contentSecurityPolicy/script-src-redirect-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/script-src-redirect.html: Added.

2011-02-09 Jochen Eisinger <​jochen@chromium.org>

Reviewed by Adam Barth.

Disable script elements when a CSP header is present
​https://bugs.webkit.org/show_bug.cgi?id=53867

Tests: http/tests/security/contentSecurityPolicy/no-policy.html

http/tests/security/contentSecurityPolicy/script-src-in-iframe.html
http/tests/security/contentSecurityPolicy/script-src-none.html
http/tests/security/contentSecurityPolicy/script-src-redirect.html

  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::shouldLoadExternalScriptFromSrc):
  • html/parser/HTMLScriptRunner.cpp: (WebCore::HTMLScriptRunner::requestPendingScript):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::didBeginDocument):
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didReceiveResponse):
  • page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::ContentSecurityPolicy): (WebCore::ContentSecurityPolicy::didReceiveHeader): (WebCore::ContentSecurityPolicy::canLoadExternalScriptFromSrc):
  • page/ContentSecurityPolicy.h:
8:56 AM Changeset in webkit [78057] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-02-09 Patrick Gansterer <Patrick Gansterer>

Unreviewed WinCE build fix for r78047.

ContextMenu.cpp and ContextMenuItem.cpp have a USE(CROSS_PLATFORM_CONTEXT_MENUS),
so they shouldn't cause problems with correct preprocessor defines.

  • CMakeLists.txt:
8:32 AM Changeset in webkit [78056] by loislo@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-02-09 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: InspectorAgent should know nothing about InspectorController instance.

​https://bugs.webkit.org/show_bug.cgi?id=54100

  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::restoreInspectorStateFromCookie): (WebCore::InspectorAgent::disconnectFrontend):
  • inspector/InspectorAgent.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::restoreInspectorStateFromCookie):
7:48 AM Changeset in webkit [78055] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-02-09 Andras Becsi <​abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt][WK2] Don't generate superfluous forwarding header for config.h.

  • Scripts/generate-forwarding-headers.pl:
7:45 AM Changeset in webkit [78054] by Adam Roben
  • 2 edits in trunk/Source/WebKit2

Hide the ugly details of WebView::m_window initialization from WebPageProxy, and make it less ugly

WebView::WebView was initially creating a hidden window, then showing it. It would tell
WebPageProxy about the window while it was still hidden, and then have to inform
WebPageProxy that the window had become shown. This resulted in WebPageProxy sending
unnecessary messages to the web process, and confused code that assumed that the window
would be in the same state after WebView's constructor exited as it was when WebPageProxy
first found out about the window.

We now don't hide the window when creating it, which simplifies the code, and only tell
WebPageProxy about the window after we're done modifying it, which fixes the bug.

Fixes <​http://webkit.org/b/53878> <rdar://problem/8977306> Assertion failure in
DrawingAreaImpl::resumePainting after window.open or when opening Web Inspector

Reviewed by Anders Carlsson.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::WebView): Changed ::CreateWindowEx to ::CreateWindowExW, to match other
Win32 API calls in WebKit2. Pass WS_VISIBLE to ::CreateWindowExW rather than waiting until
later to show the window. Added an assertion that m_isVisible matches the window's visible
state. Don't even create our WebPageProxy, or tell it about our window, until we're done
initializing our window, so that it doesn't get informed about our window's internal state
changes that happen beneath ::CreateWindowExW.
(WebKit::WebView::onSizeEvent): Null-check m_page since we can receive this message beneath
::CreateWindowExW.
(WebKit::WebView::onShowWindowEvent): Ditto. Replaced one FIXME with another. Always set
handled to false so that ::DefWindowProcW can do its thing. (MSDN says this is when it
actually shows/hides the window, though I couldn't find any consequences of not calling
::DefWindowProcW here.)

7:28 AM Changeset in webkit [78053] by podivilov@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-02-09 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: source frame scroll position is not restored.
​https://bugs.webkit.org/show_bug.cgi?id=54101

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._scriptSourceChanged):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.show): (WebInspector.SourceFrame.prototype.hide): (WebInspector.SourceFrame.prototype.get scrollTop): (WebInspector.SourceFrame.prototype.set scrollTop):
  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype.get scrollTop): (WebInspector.TextViewer.prototype.set scrollTop): (WebInspector.TextViewer.prototype.get scrollLeft): (WebInspector.TextViewer.prototype.set scrollLeft):
6:48 AM Changeset in webkit [78052] by pfeldman@chromium.org
  • 13 edits in trunk/Source

2011-02-09 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: follow up on InspectorAgent split -
removing unnecessary methods from InspectorController.
​https://bugs.webkit.org/show_bug.cgi?id=54093

  • WebCore.exp.in:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::stopUserInitiatedProfiling): (WebCore::InspectorAgent::showAndEnableDebugger): (WebCore::InspectorAgent::enabled): (WebCore::InspectorAgent::showConsole):
  • inspector/InspectorAgent.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::didClearWindowObjectInWorld): (WebCore::InspectorController::showConsole): (WebCore::InspectorController::enabled): (WebCore::InspectorController::inspectedPage):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontendClientLocal.cpp:

2011-02-09 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: follow up on InspectorAgent split -
removing unnecessary methods from InspectorController.
​https://bugs.webkit.org/show_bug.cgi?id=54093

2011-02-09 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: follow up on InspectorAgent split -
removing unnecessary methods from InspectorController.
​https://bugs.webkit.org/show_bug.cgi?id=54093

  • WebInspector.cpp: (WebInspector::showConsole): (WebInspector::toggleProfilingJavaScript):

2011-02-09 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: follow up on InspectorAgent split -
removing unnecessary methods from InspectorController.
​https://bugs.webkit.org/show_bug.cgi?id=54093

  • WebProcess/WebPage/WebInspector.cpp: (WebKit::WebInspector::showConsole): (WebKit::WebInspector::stopJavaScriptProfiling):
6:09 AM Changeset in webkit [78051] by cmarrin@apple.com
  • 5 edits in trunk/Source/WebCore

2011-02-07 Chris Marrin <​cmarrin@apple.com>

Reviewed by Simon Fraser.

LayoutTests/animations/play-state.html has wrong behavior with accelerated compositing
​https://bugs.webkit.org/show_bug.cgi?id=53513

The PlatformCAAnimation::create() function which took a pointer to another
PlatformCAAnimation was supposed to make a copy of that passed object.
But it was doing completely the wrong thing on Mac and was leaking an object
to boot. And the notion of copying an object using a static creation function
is wrong in the first place. So I changed it to a member copy() function
which would create a new PlatformCAAnimation which was a copy of 'this' and
return it. I changed the implementation on both Mac and Win to match.

This problem was not caught by DRT, even there is a specific test for it.
That test just verifies that the higher level logic is working
properly, which it is. There's no practical way to find out if the
layer is currently animating. There is no logic which probes that
deeply into the layer mechanics.


  • platform/graphics/ca/GraphicsLayerCA.cpp:
  • platform/graphics/ca/PlatformCAAnimation.h:
  • platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
  • platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
6:07 AM Changeset in webkit [78050] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-09 Shinichiro Hamaji <​hamaji@chromium.org>

Chromium expectations update.

fast/dom/HTMLAnchorElement/set-href-attribute-hash.html is failing.

  • platform/chromium/test_expectations.txt:
5:59 AM Changeset in webkit [78049] by pfeldman@chromium.org
  • 1 edit in branches/chromium/648/Source/WebCore/inspector/InspectorController.cpp

DevTools: fix poor merge that resulted in calling into setDocument twice.
I am not doing it using drover since InspectorController has been renamed since the branch point.

BUG=72422
TBR=yurys

5:55 AM Changeset in webkit [78048] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-09 Shinichiro Hamaji <​hamaji@chromium.org>

Chromium: update expectations

plugins/invalidate_rect is failing on linux and win, too.

plugins/invalidate_rect.html fails on chromium-mac
​https://bugs.webkit.org/show_bug.cgi?id=54051

  • platform/chromium/test_expectations.txt:
5:51 AM Changeset in webkit [78047] by demarchi@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-09 Lucas De Marchi <​lucas.demarchi@profusion.mobi>

Unreviewed build fix.

[EFL] Remove double definition of ContextMenu.
​https://bugs.webkit.org/show_bug.cgi?id=50762

When building with SHARED_CORE enabled, the symbols of ContextMenu
were both in webkit and webcore. This removes them from webcore and
shall be put back once the CROSS_PLATFORM_CONTEXT_MENUS is implemented
in EFL port.

No new tests because no new functionality.

  • CMakeLists.txt:
4:40 AM Changeset in webkit [78046] by loislo@chromium.org
  • 4 edits in trunk/LayoutTests

2011-02-09 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed.

Chromium: Create expectations for residual-style.html see r77781.

  • platform/chromium-linux/fast/invalid/residual-style-expected.txt:
  • platform/chromium-win/fast/invalid/residual-style-expected.txt:
  • platform/chromium/test_expectations.txt:
4:27 AM Changeset in webkit [78045] by Adam Roben
  • 2 edits in trunk/Source/WebCore

Windows Production build fix

  • WebCore.vcproj/QTMovieWinCommon.vsprops: Link against

WebKitSystemInterface$(WebKitConfigSuffix).lib, not just WebKitSystemInterface.lib, so we
pick up the _debug variant when appropriate.

4:13 AM Changeset in webkit [78044] by eric@webkit.org
  • 9 edits in trunk

2011-02-09 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Hostnames should cannonicalize to lowercase (to match every other browser)
​https://bugs.webkit.org/show_bug.cgi?id=54084

Pretty obvious change. KURL is the odd man out here.

  • fast/url/host-expected.txt:
  • fast/url/ipv4-expected.txt:
  • fast/url/ipv6-expected.txt:
  • fast/url/relative-expected.txt:
  • fast/url/relative-unix-expected.txt:
  • fast/url/standard-url-expected.txt:

2011-02-09 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Hostnames should cannonicalize to lowercase (to match every other browser)
​https://bugs.webkit.org/show_bug.cgi?id=54084

  • platform/KURL.cpp: (WebCore::KURL::parse):
4:04 AM Changeset in webkit [78043] by sergio@webkit.org
  • 2 edits
    7 adds in trunk/LayoutTests

2011-02-09 Sergio Villar Senin <​svillar@igalia.com>

Unreviewed.

Added new text expectations for GTK port. They should be actually
valid for any port using the libsoup backend. We need different
results because as stated here
​https://bugs.webkit.org/show_bug.cgi?id=3812#c6, the original test
results were designed for NSURLConnection which adds the
"Content-Length: 0" header for null message bodies. That does not
happen in libsoup, so instead of artificially add that header we
better generate different results.

Also take into account that for HEAD and GET requests the body is
not included so we should expect always a null for them.

  • platform/gtk/Skipped:
  • platform/gtk/http/tests/xmlhttprequest/methods-async-expected.txt: Added.
  • platform/gtk/http/tests/xmlhttprequest/methods-expected.txt: Added.
  • platform/gtk/http/tests/xmlhttprequest/workers/methods-async-expected.txt: Added.
  • platform/gtk/http/tests/xmlhttprequest/workers/methods-expected.txt: Added.
  • platform/gtk/http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt: Added.
  • platform/gtk/http/tests/xmlhttprequest/workers/shared-worker-methods-expected.txt: Added.
4:00 AM Changeset in webkit [78042] by pvarga@webkit.org
  • 24 edits
    4 adds
    1 delete in trunk/Source

Replace PCRE with Yarr in WebCore
​https://bugs.webkit.org/show_bug.cgi?id=53496

Reviewed by Gavin Barraclough.

Rollback r77626 with windows build fix.

Source/JavaScriptCore:

Source/WebCore:

No new tests needed.

  • Android.jscbindings.mk:
  • CMakeLists.txt:
  • ForwardingHeaders/pcre/pcre.h: Removed.
  • ForwardingHeaders/yarr/Yarr.h: Added.
  • ForwardingHeaders/yarr/YarrInterpreter.h: Added.
  • ForwardingHeaders/yarr/YarrPattern.h: Added.
  • WebCore.gyp/WebCore.gyp:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/copyForwardingHeaders.cmd:
  • platform/text/RegularExpression.cpp:

(WebCore::RegularExpression::Private::create):
(WebCore::RegularExpression::Private::Private):
(WebCore::RegularExpression::Private::compile):
(WebCore::RegularExpression::match):

3:54 AM Changeset in webkit [78041] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/Source/WebCore

2011-02-09 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Eric Seidel.

[EFL] Add dummy functions for HTML5 Video's control UI
​https://bugs.webkit.org/show_bug.cgi?id=53906

In WebKit EFL, there are no implementations for HTML5 control UI.
First, dummy functions are added.

  • platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::extraMediaControlsStyleSheet): (WebCore::RenderThemeEfl::formatMediaControlsCurrentTime): (WebCore::RenderThemeEfl::paintMediaFullscreenButton): (WebCore::RenderThemeEfl::paintMediaMuteButton): (WebCore::RenderThemeEfl::paintMediaPlayButton): (WebCore::RenderThemeEfl::paintMediaSeekBackButton): (WebCore::RenderThemeEfl::paintMediaSeekForwardButton): (WebCore::RenderThemeEfl::paintMediaSliderTrack): (WebCore::RenderThemeEfl::paintMediaSliderThumb): (WebCore::RenderThemeEfl::paintMediaVolumeSliderContainer): (WebCore::RenderThemeEfl::paintMediaVolumeSliderTrack): (WebCore::RenderThemeEfl::paintMediaVolumeSliderThumb): (WebCore::RenderThemeEfl::paintMediaCurrentTime):
  • platform/efl/RenderThemeEfl.h:
3:53 AM Changeset in webkit [78040] by eric@webkit.org
  • 10 edits in trunk

2011-02-09 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Make WebKit's fragment cannonicalization match other browsers
​https://bugs.webkit.org/show_bug.cgi?id=53850

  • fast/dom/HTMLAnchorElement/set-href-attribute-hash.html: Updated to match IE/Chrome
  • fast/dom/HTMLAnchorElement/set-href-attribute-hash-expected.txt: Updated to match IE/Chrome.
  • fast/url/anchor-expected.txt:
    • "hello world": Our new behavior here matches IE and Chrome, but diverges from FF.
    • The last two tests involving #, we were the odd man out. Now match all browsers.
  • fast/url/segments-expected.txt:
    • Don't percent encode spaces in fragments (to match other browsers)
    • WebKit was the only engine encoding # in fragments.
  • fast/url/segments-from-data-url-expected.txt:

2011-02-09 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Make WebKit's fragment cannonicalization match other browsers
​https://bugs.webkit.org/show_bug.cgi?id=53850

This doesn't make us match perfectly, but it brings us closer.

  • platform/KURL.cpp: (WebCore::appendEscapingBadChars): (WebCore::escapeAndAppendFragment): (WebCore::KURL::parse):
3:37 AM Changeset in webkit [78039] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] Fix crashes in QMetaObject::metacall
​https://bugs.webkit.org/show_bug.cgi?id=53912

One more attempt to make Qt buildbot happier and make sheriffbot
not to spam innocent people because of this flakey crash.

  • platform/qt/Skipped: Add websocket directory instead of individual tests until fix.
3:20 AM Changeset in webkit [78038] by Csaba Osztrogonác
  • 3 edits in trunk/Source/WebKit/qt

[Qt] fast/dom/nodesFromRect-links-and-text.html crashes in debug mode
​https://bugs.webkit.org/show_bug.cgi?id=53921

Patch by Robert Hogan <​robert@webkit.org> on 2011-02-09
Reviewed by Antonio Gomes.

QDRTNode needs a copy constructor and an operator= in order to keep
proper refcounts.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(:m_node):
(QDRTNode::operator=):
(DumpRenderTreeSupportQt::nodesFromRect):

  • WebCoreSupport/DumpRenderTreeSupportQt.h:
2:58 AM Changeset in webkit [78037] by loislo@chromium.org
  • 3 edits in trunk/LayoutTests

2011-02-09 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed.

Chromium: Rebaseline html5lib/runner.html expectations after r77781.

  • platform/chromium/html5lib/runner-expected.txt:
  • platform/chromium/test_expectations.txt:
2:37 AM Changeset in webkit [78036] by apavlov@chromium.org
  • 1 edit
    1 add in trunk/Websites/webkit.org

2011-02-09 Alexander Pavlov <​apavlov@chromium.org>

Unreviewed. Add Web Inspector stylesheet resource diff screenshot.

  • blog-files/inspector/css_rule_diff.png: Added.
2:33 AM Changeset in webkit [78035] by hans@chromium.org
  • 4 edits
    2 adds in trunk

2011-02-09 Hans Wennborg <​hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Cursors should skip deleted entries
​https://bugs.webkit.org/show_bug.cgi?id=53690

Cursors should skip over entries that have been deleted
since the cursor was opened.

  • storage/indexeddb/cursor-skip-deleted-expected.txt: Added.
  • storage/indexeddb/cursor-skip-deleted.html: Added.

2011-02-09 Hans Wennborg <​hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Cursors should skip deleted entries
​https://bugs.webkit.org/show_bug.cgi?id=53690

Add test to check that the cursor skips deleted entries.

Test: storage/indexeddb/cursor-skip-deleted.html

  • storage/IDBCursorBackendImpl.cpp: (WebCore::IDBCursorBackendImpl::currentRowExists): (WebCore::IDBCursorBackendImpl::continueFunctionInternal):
  • storage/IDBCursorBackendImpl.h:
2:12 AM Changeset in webkit [78034] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-08 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: script formatter should not create a worker for each script.
​https://bugs.webkit.org/show_bug.cgi?id=54010

  • inspector/front-end/ScriptFormatter.js: (WebInspector.ScriptFormatter): (WebInspector.ScriptFormatter.prototype._formatScript): (WebInspector.ScriptFormatter.prototype._handleMessage): (WebInspector.ScriptFormatter.prototype._handleError):
2:05 AM Changeset in webkit [78033] by morrita@google.com
  • 2 edits in trunk/Source/WebKit/chromium

2011-02-09 MORITA Hajime <​morrita@google.com>

Reviewed by Shinichiro Hamaji.

[Chromium] WebTextCheckingResult should have a default constructor.
​https://bugs.webkit.org/show_bug.cgi?id=54075

Gave default parameters to WebTextCheckingResult constructor.

  • public/WebTextCheckingResult.h: (WebKit::WebTextCheckingResult::WebTextCheckingResult):
2:00 AM Changeset in webkit [78032] by podivilov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-02-08 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: sync uglifyjs parser files.
​https://bugs.webkit.org/show_bug.cgi?id=54003

  • inspector/front-end/UglifyJS/parse-js.js:
  • inspector/front-end/UglifyJS/process.js:
1:53 AM Changeset in webkit [78031] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-09 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed.

Chromium: update expectations for some canvas/philip tests which are failing on MAC.

  • platform/chromium/test_expectations.txt:
12:23 AM Changeset in webkit [78030] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2011-02-09 Martin Robinson <​mrobinson@igalia.com>

Skip some failing tests.

  • platform/gtk/Skipped: Skip plugins/invalidate_rect.html and fast/frames/flattening/iframe-flattening-crash.html
12:09 AM Changeset in webkit [78029] by Csaba Osztrogonác
  • 1 edit
    1 copy
    2 adds in trunk/LayoutTests

Unreviewed.

[Qt] Qt platform has a different editing delegates for several tests
​https://bugs.webkit.org/show_bug.cgi?id=43082

editing/undo/undo-paste-when-caret-is-not-in-range.html introduced in r77995, but fails on Qt.
Add platform specific expected result until fix.

  • platform/qt/editing/undo/undo-paste-when-caret-is-not-in-range-expected.checksum: Added.
  • platform/qt/editing/undo/undo-paste-when-caret-is-not-in-range-expected.png: Added.
  • platform/qt/editing/undo/undo-paste-when-caret-is-not-in-range-expected.txt: Copied from LayoutTests/editing/undo/undo-paste-when-caret-is-not-in-range-expected.txt.
12:03 AM Changeset in webkit [78028] by alex
  • 3 edits in trunk/Source/WebKit2

2011-02-09 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Avoid WebProcessMain compilation, we are used a gtk specific main
​https://bugs.webkit.org/show_bug.cgi?id=54015

Avoided the compilation of the general WebProcessMain, and added
soup initialization to WebProcessMainGtk.cpp.

  • GNUmakefile.am:
  • WebProcess/gtk/WebProcessMainGtk.cpp: (WebKit::WebProcessMainGtk):

Feb 8, 2011:

11:59 PM WebKitGTK/KeepingTheTreeGreen edited by alex
(diff)
11:58 PM Changeset in webkit [78027] by alex
  • 2 edits in trunk/Source/WebKit2

2011-02-08 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Incorrect assertion in WorkQueueGtk, we need to register
more than one handle
​https://bugs.webkit.org/show_bug.cgi?id=54014

Fixed assertion condition we need to register more than one
handler for the same file descriptor.

  • Platform/gtk/WorkQueueGtk.cpp: (WorkQueue::registerEventSourceHandler):
11:58 PM Changeset in webkit [78026] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt]Missing layoutTestController.displayInvalidatedRegion()

plugins/invalidate_rect.html introduced in r78010, but unfortunately
Qt DRT doesn't have layoutTestController.displayInvalidatedRegion().

  • platform/qt/Skipped: Add plugins/invalidate_rect.html.
11:43 PM Changeset in webkit [78025] by alex
  • 2 edits in trunk/Source/WebKit2

2011-02-08 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Martin Robinson.

Fix typo in the include guards name in ChunkedUpdateDrawingAreaProxy.h
​https://bugs.webkit.org/show_bug.cgi?id=54013

  • UIProcess/ChunkedUpdateDrawingAreaProxy.h:
11:42 PM Changeset in webkit [78024] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit/mac

<rdar://problem/8959420> Find in Mail no longer cycles around

Reviewed by Jon Honeycutt and Maciej Stachowiak.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Set
the wrap option according to the flag.

11:30 PM Changeset in webkit [78023] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2011-02-08 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Kent Tamura.

Skip a freshly added test that depends on newly added DRT functionality
​https://bugs.webkit.org/show_bug.cgi?id=54069

  • platform/mac-wk2/Skipped:
11:25 PM Changeset in webkit [78022] by alex
  • 2 edits in trunk/Source/WebKit2

2011-02-08 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Fix after r77874, m_isConnected is initialized before the
socket is opened
​https://bugs.webkit.org/show_bug.cgi?id=54011

Fixed connection breakage after r77874, we have to wait until open
the socket to open the connection.

  • Platform/CoreIPC/gtk/ConnectionGtk.cpp: (CoreIPC::Connection::platformInitialize): (CoreIPC::Connection::open):
11:21 PM Changeset in webkit [78021] by alex
  • 2 edits in trunk/Source/WebKit2

2011-02-08 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Martin Robinson.

[WK2] LayerTreeContext is used outside the ACCELERATED_COMPOSITING
guards but not defined in DrawingAreaProxy.h
​https://bugs.webkit.org/show_bug.cgi?id=54009

Removed the guards in the forward declaration, this will fail if
the class is finally used in the function, but it works for the
moment.

  • UIProcess/DrawingAreaProxy.h:
11:16 PM Changeset in webkit [78020] by alex
  • 5 edits in trunk

2011-02-08 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Martin Robinson.

WebKit2 GTK Fails to Build #include nested too deeply
​https://bugs.webkit.org/show_bug.cgi?id=52219

  • GNUmakefile.am: Removed the commands to create the directories for the forwarding headers, the script already does it for us.
  • config.h: Removed the config.h inclusion and added the autotoolsconfig.h directly, also added a condition to share the defines with QT.

2011-02-08 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Martin Robinson.

WebKit2 GTK Fails to Build #include nested too deeply
​https://bugs.webkit.org/show_bug.cgi?id=52219

Removed the STDC_FORMAT_MACROS definition, it is already defined
in the file where PRIxx64 is used before the inclusion so we are
safe.

  • configure.ac:
10:42 PM Changeset in webkit [78019] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

2011-02-08 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

fix toolbar anchoring in the code review tool
​https://bugs.webkit.org/show_bug.cgi?id=54058

Avoid the anchoring cycle of doom when on the cusp
of whether the toolbar needs to be anchored and
speculatively avoid the Firefox crash when resizing.

  • PrettyPatch/PrettyPatch.rb:
  • code-review.js:
10:09 PM Changeset in webkit [78018] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-08 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.

Removed some dead code from Heap
​https://bugs.webkit.org/show_bug.cgi?id=54064

  • runtime/MarkedSpace.cpp: Removed some now-unused constants and declarations.

(JSC::MarkedSpace::allocate): Removed some ASSERTs that are also ASSERTed
by our caller. Removed redundant typedefs.

9:59 PM Changeset in webkit [78017] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-02-08 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.

Use a vector to track blocks in the Heap, instead of hand-rolled vector-like code
​https://bugs.webkit.org/show_bug.cgi?id=54062


SunSpider reports no change.

  • runtime/CollectorHeapIterator.h: (JSC::CollectorHeapIterator::isValid): (JSC::CollectorHeapIterator::isLive): Updated for new mark invariant: To know if an object is live, you just need to test its mark bit.
  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::MarkedSpace): Moved waterMark and highWaterMark from CollectorHeap into MarkedSpace, since they're global state. Removed call to memset since CollectorHeap is a true class with its own constructor now.

(JSC::MarkedSpace::destroy): Change uses of m_heap.usedBlocks to
m_heap.blocks.size(), and m_heap.numBlocks to m_heap.blocks.capacity().

(JSC::MarkedSpace::allocateBlock):
(JSC::MarkedSpace::freeBlock): No need to manage our vector manually anymore.

(JSC::MarkedSpace::allocate):
(JSC::MarkedSpace::shrink):
(JSC::MarkedSpace::clearMarkBits):
(JSC::MarkedSpace::markedCells):
(JSC::MarkedSpace::sweep):
(JSC::MarkedSpace::objectCount):
(JSC::MarkedSpace::capacity):
(JSC::MarkedSpace::reset):
(JSC::MarkedSpace::primaryHeapEnd):

  • runtime/MarkedSpace.h: (JSC::CollectorHeap::CollectorHeap): (JSC::MarkedSpace::highWaterMark): (JSC::MarkedSpace::setHighWaterMark): (JSC::MarkedSpace::contains): Same as above.
9:46 PM Changeset in webkit [78016] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2011-02-08 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Mark Rowe.

Skip some tests that fail in WebKit2 for obvious reasons
​https://bugs.webkit.org/show_bug.cgi?id=54055

  • platform/mac-wk2/Skipped:
9:40 PM Changeset in webkit [78015] by mjs@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-08 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Mark Rowe.

Crash when going back/forward when back/forward list is in a bad state.
​https://bugs.webkit.org/show_bug.cgi?id=54059
<rdar://problem/8975244>


  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::goForward): Add a null check. (WebKit::WebPageProxy::goBack): ditto
9:33 PM Changeset in webkit [78014] by hayato@chromium.org
  • 5 edits in trunk/Tools

2011-02-08 Hayato Ito <​hayato@chromium.org>

Reviewed by Tony Chang.

[NRWT] Pull up rebaseline code from compare_output() function defined
in text_diff.py and image_diff.py into a SingleTestRunner.

This patch is a first step for eliminating test_type/* classes.

​https://bugs.webkit.org/show_bug.cgi?id=53071

  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
8:34 PM Changeset in webkit [78013] by commit-queue@webkit.org
  • 2 edits in trunk

2011-02-08 Kristian Amlie <​kristian.amlie@nokia.com>

Reviewed by Eric Seidel.

Added include paths for QtScript.

WebKit patches required to work with a modularized version of Qt
​https://bugs.webkit.org/show_bug.cgi?id=53916

  • Source/WebKit.pri:
8:32 PM Changeset in webkit [78012] by ojan@chromium.org
  • 6 edits in trunk/Tools

2011-02-07 Ojan Vafai <​ojan@chromium.org>

Reviewed by Mihai Parparita.

stop generating results.json files
​https://bugs.webkit.org/show_bug.cgi?id=53977

We've only used incremental_results.json for a while now
and there are plans to start generating a results.json file that matches
the format of unexpected_results.json.

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
8:17 PM Changeset in webkit [78011] by rniwa@webkit.org
  • 5 edits
    2 adds in trunk

2011-02-08 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

REGRESSION(71556,68059): queryCommandValue screws up background color at collapsed cursor
​https://bugs.webkit.org/show_bug.cgi?id=53196

The bug was caused by Editor::selectionComputedStyle's modifying typing style without making a copy,
and its removing non-inheritable properties from the typing style. Fixed the bug by making a copy
before making the modification and not removing non-inheritable properties.

Also fixed a bug in selectionStartCSSPropertyValue that it doesn't handle xx-small to -webkit-xxx-large
by extracting a function from StyleChange::extractTextStyles and calling it in both extractTextStyles
and selectionStartCSSPropertyValue.

Test: editing/style/query-typing-style.html

  • editing/ApplyStyleCommand.cpp: (WebCore::legacyFontSizeFromCSSValue): Extracted from StyleChange::extractTextStyles. (WebCore::StyleChange::extractTextStyles): Calls legacyFontSizeFromCSSValue; this fixes the bug that CSS values from xx-small through -webkit-xxx-large are not accounted.
  • editing/ApplyStyleCommand.h:
  • editing/Editor.cpp: (WebCore::Editor::selectionStartCSSPropertyValue): Calls legacyFontSizeFromCSSValue. (WebCore::Editor::selectionComputedStyle): Makes a copy before modifying typing style. No longer calls removeNonEditingProperties on the copied typing style so that background-color property is included when merged into the style.

2011-02-08 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

REGRESSION(71556,68059): queryCommandValue screws up background color at collapsed cursor
​https://bugs.webkit.org/show_bug.cgi?id=53196

Added a test to ensure calling queryCommandValue returns the correct value for backColor
and fontSize from typing style.

  • editing/style/query-typing-style-expected.txt: Added.
  • editing/style/query-typing-style.html: Added.
7:30 PM Changeset in webkit [78010] by commit-queue@webkit.org
  • 11 edits
    2 adds in trunk

2011-02-08 Sailesh Agrawal <​sail@chromium.org>

Reviewed by Kenneth Russell.

Invalidate rect doesn't work for windowless plugins on Chromium
​https://bugs.webkit.org/show_bug.cgi?id=53117

Added a test to make sure that NPN_InvalidateRect() works correctly for windowless plugins.

  • plugins/invalidate_rect-expected.txt: Added.
  • plugins/invalidate_rect.html: Added.

2011-02-08 Sailesh Agrawal <​sail@chromium.org>

Reviewed by Kenneth Russell.

Invalidate rect doesn't work for windowless plugins on Chromium
​https://bugs.webkit.org/show_bug.cgi?id=53117

Invalidate rect for windowless plugins wasn't working if the web page was composited.

The problem was that the invalidate call was causing simply dirtying the LayerChromium layers. Since the plugin was windowless this didn't cause the plugin to be repainted.

Fix was to copy the invalidate code from WebCore/plugins/PluginView.cpp/PluginView::invalidateWindowlessPluginRect() which does the correct thing.

Tested my fix on Windows and Mac and verified that the movie on ​http://apple.com/appltv correctly plays. Verified that windowed plugins still correctly draw as well.

  • src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::invalidateRect):

2011-02-08 Sailesh Agrawal <​sail@chromium.org>

Reviewed by Kenneth Russell.

Invalidate rect doesn't work for windowless plugins on Chromium
​https://bugs.webkit.org/show_bug.cgi?id=53117

Added two new utility methods.

  • layoutTestController.displayInvalidatedRegion() does a paint of any area that has been invalidated. This is different from layoutTestController.display() which explicitly invalidates the entire page then paints.
  • plugin.invalidateRect(left, top, right, bottom) - invalidates the given rect This is used to test that invalidating a rect correctly causes a repaint of the plugin.
  • DumpRenderTree/LayoutTestController.cpp: (displayInvalidatedRegionCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: (invalidateRect): (pluginInvoke):
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::displayInvalidatedRegion):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
6:59 PM Changeset in webkit [78009] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r76831): Subframes are printed blank
<rdar://problem/8945867>

Reviewed by Maciej Stachowiak.

  • page/FrameView.cpp:

(WebCore::FrameView::paintOverhangAreas):
Don't paint overhangs when printing.

6:43 PM Changeset in webkit [78008] by mihaip@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

2011-02-08 Mihai Parparita <​mihaip@chromium.org>

Unreviewed. Remove chromium-gpu-win baseline that has a failing result,
since we now pass the test.

  • platform/chromium-gpu-win/compositing/animation/animated-composited-inside-hidden-expected.txt: Removed.
6:39 PM Changeset in webkit [78007] by mihaip@chromium.org
  • 20 edits
    1 copy
    99 adds in trunk/LayoutTests

2011-02-08 Mihai Parparita <​mihaip@chromium.org>

Unreviewed chromium-gpu-win rebaseline.

  • platform/chromium-gpu-win/compositing/direct-image-compositing-expected.txt:
  • platform/chromium-gpu-win/compositing/geometry/composited-html-size-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/geometry/composited-html-size-expected.png: Copied from LayoutTests/platform/chromium-gpu-win/fast/canvas/canvas-transform-skewed-expected.png.
  • platform/chromium-gpu-win/compositing/geometry/composited-html-size-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.checksum:
  • platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.txt:
  • platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.checksum:
  • platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-deep-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
  • platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-deep-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-expected.png: Added.
  • platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-switch-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/geometry/tall-page-composited-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/geometry/tall-page-composited-expected.png: Added.
  • platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.checksum:
  • platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.txt:
  • platform/chromium-gpu-win/compositing/iframes/composited-iframe-scroll-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/iframes/composited-iframe-scroll-expected.png: Added.
  • platform/chromium-gpu-win/compositing/iframes/composited-iframe-scroll-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/iframes/composited-parent-iframe-expected.txt:
  • platform/chromium-gpu-win/compositing/images/direct-svg-image-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/images/direct-svg-image-expected.png: Added.
  • platform/chromium-gpu-win/compositing/masks/masked-ancestor-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/masks/masked-ancestor-expected.png: Added.
  • platform/chromium-gpu-win/compositing/masks/masked-ancestor-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/masks/simple-composited-mask-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/masks/simple-composited-mask-expected.png: Added.
  • platform/chromium-gpu-win/compositing/masks/simple-composited-mask-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.checksum:
  • platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.png:
  • platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.txt:
  • platform/chromium-gpu-win/compositing/reflections/animation-inside-reflection-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/reflections/animation-inside-reflection-expected.png: Added.
  • platform/chromium-gpu-win/compositing/reflections/animation-inside-reflection-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/reflections/compositing-change-inside-reflection-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/reflections/compositing-change-inside-reflection-expected.png: Added.
  • platform/chromium-gpu-win/compositing/reflections/compositing-change-inside-reflection-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/reflections/deeply-nested-reflections-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/reflections/deeply-nested-reflections-expected.png: Added.
  • platform/chromium-gpu-win/compositing/reflections/deeply-nested-reflections-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/reflections/masked-reflection-on-composited-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/reflections/masked-reflection-on-composited-expected.png: Added.
  • platform/chromium-gpu-win/compositing/reflections/masked-reflection-on-composited-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-animated-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-animated-expected.png: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-animated-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-expected.png: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-mask-change-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-mask-change-expected.png: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-mask-change-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-on-overflow-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-on-overflow-expected.png: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-on-overflow-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-opacity-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-opacity-expected.png: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-opacity-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-size-change-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-size-change-expected.png: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-size-change-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed-expected.png: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed2-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed2-expected.png: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed2-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-transition-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-transition-expected.png: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-transition-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/reflections/reflection-on-composited-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/reflections/reflection-on-composited-expected.png: Added.
  • platform/chromium-gpu-win/compositing/reflections/reflection-on-composited-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/reflections/reflection-ordering-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/reflections/reflection-ordering-expected.png: Added.
  • platform/chromium-gpu-win/compositing/reflections/reflection-ordering-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/reflections/reflection-positioning-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/reflections/reflection-positioning-expected.png: Added.
  • platform/chromium-gpu-win/compositing/reflections/reflection-positioning-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/reflections/reflection-positioning2-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/reflections/reflection-positioning2-expected.png: Added.
  • platform/chromium-gpu-win/compositing/reflections/reflection-positioning2-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/reflections/remove-add-reflection-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/reflections/remove-add-reflection-expected.png: Added.
  • platform/chromium-gpu-win/compositing/reflections/simple-composited-reflections-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/reflections/simple-composited-reflections-expected.png: Added.
  • platform/chromium-gpu-win/compositing/reflections/simple-composited-reflections-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/reflections/transform-inside-reflection-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/reflections/transform-inside-reflection-expected.png: Added.
  • platform/chromium-gpu-win/compositing/reflections/transform-inside-reflection-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/repaint/content-into-overflow-expected.txt:
  • platform/chromium-gpu-win/compositing/repaint/overflow-into-content-expected.txt:
  • platform/chromium-gpu-win/compositing/text-on-large-layer-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/text-on-large-layer-expected.png: Added.
  • platform/chromium-gpu-win/compositing/text-on-large-layer-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/tiling/huge-layer-add-remove-child-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/tiling/huge-layer-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/tiling/huge-layer-with-layer-children-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/transitions/scale-transition-no-start-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/transitions/scale-transition-no-start-expected.png: Added.
  • platform/chromium-gpu-win/compositing/transitions/scale-transition-no-start-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/webgl/webgl-reflection-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/webgl/webgl-reflection-expected.png: Added.
  • platform/chromium-gpu-win/compositing/webgl/webgl-reflection-expected.txt: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-composite-expected.checksum:
  • platform/chromium-gpu-win/fast/canvas/canvas-composite-expected.png:
  • platform/chromium-gpu-win/fast/canvas/canvas-transform-skewed-expected.checksum:
  • platform/chromium-gpu-win/fast/canvas/canvas-transform-skewed-expected.png:
6:27 PM Changeset in webkit [78006] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2011-02-08 Zhenyao Mo <​zmo@google.com>

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt
6:14 PM Changeset in webkit [78005] by jorlow@chromium.org
  • 19 edits
    2 adds in trunk

2011-02-07 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Nate Chapin.

Events should propagate through IDBDatabase (for IDBRequest and IDBTransaction)
​https://bugs.webkit.org/show_bug.cgi?id=53975

  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/request-event-propagation-expected.txt:
  • storage/indexeddb/request-event-propagation.html:
  • storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
  • storage/indexeddb/transaction-and-objectstore-calls.html:
  • storage/indexeddb/transaction-basics.html:
  • storage/indexeddb/transaction-event-propagation-expected.txt: Added.
  • storage/indexeddb/transaction-event-propagation.html: Added.

2011-02-07 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Nate Chapin.

Events should propagate through IDBDatabase (for IDBRequest and IDBTransaction)
​https://bugs.webkit.org/show_bug.cgi?id=53975

The third change in the series of overhauling IndexedDB's event model to match
the spec (at least the version in our heads and bugs).

Test: storage/indexeddb/transaction-event-propagation.html

  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
  • dom/Event.cpp: (WebCore::Event::isIDBAbortEvent): (WebCore::Event::isIDBCompleteEvent):
  • dom/Event.h:
  • dom/EventTarget.cpp: (WebCore::EventTarget::toIDBDatabase):
  • dom/EventTarget.h:
  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::create): (WebCore::IDBDatabase::IDBDatabase): (WebCore::IDBDatabase::scriptExecutionContext): (WebCore::IDBDatabase::eventTargetData): (WebCore::IDBDatabase::ensureEventTargetData):
  • storage/IDBDatabase.h: (WebCore::IDBDatabase::toIDBDatabase): (WebCore::IDBDatabase::refEventTarget): (WebCore::IDBDatabase::derefEventTarget):
  • storage/IDBDatabase.idl:
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::onSuccess): (WebCore::IDBRequest::dispatchEvent):
  • storage/IDBTransaction.cpp: (WebCore::IDBTransaction::backend): (WebCore::IDBTransaction::db): (WebCore::IDBTransaction::objectStore): (WebCore::IDBTransaction::scriptExecutionContext): (WebCore::IDBTransaction::dispatchEvent): (WebCore::IDBTransaction::enqueueEvent):
  • storage/IDBTransaction.h: (WebCore::IDBTransaction::dispatchEvent):
6:10 PM Changeset in webkit [78004] by scherkus@chromium.org
  • 3 edits in branches/chromium/648/Source/WebCore

Merge 77608 - 2011-02-03 Victoria Kirst <​vrk@google.com>

Reviewed by James Robinson.

Replaces float literals with uniform values in shader code
so that buggy drivers unable to parse float values in different
locales will not produce a pink video.

[chromium] Fix pink video bug with gpu-acceleration enabled
​https://bugs.webkit.org/show_bug.cgi?id=53568

  • platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::SharedValues::SharedValues): (WebCore::VideoLayerChromium::drawYUV):
  • platform/graphics/chromium/VideoLayerChromium.h: (WebCore::VideoLayerChromium::SharedValues::signAdjLocation):

TBR=​commit-queue@webkit.org
Review URL: ​http://codereview.chromium.org/6460020

6:08 PM Changeset in webkit [78003] by scherkus@chromium.org
  • 3 edits in branches/chromium/648/Source/WebKit/chromium

Merge 77599 - 2011-02-03 Victoria Kirst <​vrk@google.com>

Reviewed by James Robinson.

[chromium] Fix redundant video frame paint on CSS LayerChromium for <video>
​https://bugs.webkit.org/show_bug.cgi?id=52868

  • src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::paint): (WebKit::WebMediaPlayerClientImpl::paintCurrentFrameInContext): (WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse):
  • src/WebMediaPlayerClientImpl.h:

TBR=​commit-queue@webkit.org
Review URL: ​http://codereview.chromium.org/6465012

6:02 PM Changeset in webkit [78002] by kbr@google.com
  • 1 edit
    2 adds in trunk/Source/WebCore

2011-02-08 Kenneth Russell <​kbr@google.com>

Reviewed by James Robinson.

Add cache for GPU-accelerated path processing results
​https://bugs.webkit.org/show_bug.cgi?id=45519

Adding a cache which holds the results of processing a path into
interior and exterior triangle meshes, according to the path
rendering algorithm from GPU Gems 3. No tests yet; will be tested
in conjunction with later code.

  • platform/graphics/gpu/LoopBlinnPathCache.cpp: Added. (WebCore::LoopBlinnPathCache::LoopBlinnPathCache): (WebCore::LoopBlinnPathCache::~LoopBlinnPathCache): (WebCore::LoopBlinnPathCache::addVertex): (WebCore::LoopBlinnPathCache::clear): (WebCore::LoopBlinnPathCache::addInteriorVertex): (WebCore::LoopBlinnPathCache::numberOfInteriorEdgeVertices): (WebCore::LoopBlinnPathCache::interiorEdgeVertices): (WebCore::LoopBlinnPathCache::addInteriorEdgeVertex):
  • platform/graphics/gpu/LoopBlinnPathCache.h: Added. (WebCore::LoopBlinnPathCache::numberOfVertices): (WebCore::LoopBlinnPathCache::vertices): (WebCore::LoopBlinnPathCache::texcoords): (WebCore::LoopBlinnPathCache::numberOfInteriorVertices): (WebCore::LoopBlinnPathCache::interiorVertices):
5:55 PM Changeset in webkit [78001] by beidson@apple.com
  • 1 edit in trunk/Source/WebCore/ChangeLog

Nevermind

5:54 PM Changeset in webkit [78000] by beidson@apple.com
  • 1 edit in trunk/Source/WebCore/ChangeLog

80,000

5:46 PM Changeset in webkit [77999] by zmo@google.com
  • 4 edits in trunk/Source/WebCore

2011-02-08 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

Rename GraphicsContext3D::WebGLEnumType
​https://bugs.webkit.org/show_bug.cgi?id=45708

  • html/canvas/WebGLProgram.cpp: (WebCore::WebGLProgram::getAttachedShader):
  • html/canvas/WebGLProgram.h:
  • platform/graphics/GraphicsContext3D.h:
5:17 PM Changeset in webkit [77998] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-02-08 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Tony Chang.

new-run-webkit-tests: move the logic that starts and stops the
servers from dump_render_tree_thread into single_test_runner
so that we can reuse it in the new multiprocessing worker class
as well.

​https://bugs.webkit.org/show_bug.cgi?id=53840

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
5:04 PM Changeset in webkit [77997] by leviw@chromium.org
  • 26 edits in trunk/Source

2011-02-08 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r77980.
​http://trac.webkit.org/changeset/77980
​https://bugs.webkit.org/show_bug.cgi?id=54043

"Crashes on Windows and Linux..." (Requested by leviw on
#webkit).

  • WebView/WebFrame.mm: (-[WebFrame _caretRectAtNode:offset:affinity:]):
  • WebView/WebFrameInternal.h:
  • WebView/WebTextCompletionController.mm: (-[WebTextCompletionController doCompletion]):

2011-02-08 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r77980.
​http://trac.webkit.org/changeset/77980
​https://bugs.webkit.org/show_bug.cgi?id=54043

"Crashes on Windows and Linux..." (Requested by leviw on
#webkit).

  • WebCore.exp.in:
  • accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::visiblePositionForTextMarkerData):
  • accessibility/AccessibilityObject.cpp: (WebCore::startOfStyleRange): (WebCore::endOfStyleRange):
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::visiblePositionForIndex):
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (objectAndOffsetUnignored):
  • dom/Position.cpp: (WebCore::Position::upstream): (WebCore::Position::downstream):
  • dom/Range.cpp: (WebCore::Range::editingStartPosition):
  • editing/Editor.cpp: (WebCore::Editor::canDeleteRange):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
  • editing/SelectionController.cpp: (WebCore::SelectionController::selectFrameElementInParentIfFullySelected): (WebCore::SelectionController::setSelectedRange):
  • editing/TextIterator.cpp: (WebCore::TextIterator::shouldRepresentNodeOffsetZero):
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed):
  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::VisiblePosition): (WebCore::VisiblePosition::leftVisuallyDistinctCandidate): (WebCore::VisiblePosition::rightVisuallyDistinctCandidate): (WebCore::VisiblePosition::canonicalPosition): (WebCore::VisiblePosition::characterAfter): (WebCore::VisiblePosition::localCaretRect): (WebCore::makeRange): (WebCore::startVisiblePosition): (WebCore::endVisiblePosition): (WebCore::setStart): (WebCore::setEnd): (WebCore::isFirstVisiblePositionInNode): (WebCore::isLastVisiblePositionInNode):
  • editing/VisiblePosition.h:
  • editing/htmlediting.cpp: (WebCore::firstInSpecialElement): (WebCore::lastInSpecialElement): (WebCore::visiblePositionBeforeNode): (WebCore::visiblePositionAfterNode):
  • editing/visible_units.cpp: (WebCore::startPositionForLine): (WebCore::endPositionForLine): (WebCore::previousLinePosition): (WebCore::nextLinePosition): (WebCore::startOfParagraph): (WebCore::endOfParagraph): (WebCore::endOfBlock): (WebCore::startOfDocument): (WebCore::endOfDocument): (WebCore::logicalStartPositionForLine): (WebCore::logicalEndPositionForLine):
  • page/DOMSelection.cpp: (WebCore::DOMSelection::collapse): (WebCore::DOMSelection::setBaseAndExtent): (WebCore::DOMSelection::setPosition): (WebCore::DOMSelection::extend):
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEventSingleClick):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::createVisiblePosition):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::visiblePositionForIndex):
  • svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::selectSubString):
5:00 PM Changeset in webkit [77996] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

2011-02-08 Anders Carlsson <​andersca@apple.com>

Reviewed by Beth Dakin.

Assertion failure !isInAcceleratedCompositingMode() in DrawingAreaProxyImpl::incorporateUpdate()
​https://bugs.webkit.org/show_bug.cgi?id=54046
<rdar://problem/8973960>

DrawingAreaImpl::setRootCompositingLayer can be called with a new layer even when already
in accelerated compositing mode. Similarly, it can be called with a null layer even when not
in accelerated compositing mode. Make the drawing area and layer tree host handle both these cases.

  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::setRootCompositingLayer): Only call enterAcceleratedCompositingMode if there is no layer tree host, otherwise just call LayerTreeHost::setRootCompositingLayer.

(WebKit::DrawingAreaImpl::setSize):
Add an assert.

(WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode):
Assert that we don't have a layer tree host.

(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
Assert that we do have a layer tree host.

(WebKit::DrawingAreaImpl::display):
If the call to display caused the page to enter accelerated compositing mode, we don't
want to send back an Update message.

  • WebProcess/WebPage/LayerTreeHost.cpp: (WebKit::LayerTreeHost::create):
  • WebProcess/WebPage/LayerTreeHost.h: Create no longer takes a graphics layer.
  • WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::create): (WebKit::LayerTreeHostMac::LayerTreeHostMac): Create no longer takes a graphics layer.


(WebKit::LayerTreeHostMac::setRootCompositingLayer):
Set the new root compositing layer.

4:55 PM Changeset in webkit [77995] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-02-08 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

VisibleSelection::setWithoutValidation() should allow caret selection.
​https://bugs.webkit.org/show_bug.cgi?id=53943

  • editing/undo/undo-paste-when-caret-is-not-in-range-expected.txt: Added.
  • editing/undo/undo-paste-when-caret-is-not-in-range.html: Added.

2011-02-08 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

VisibleSelection::setWithoutValidation() should allow caret selection.
​https://bugs.webkit.org/show_bug.cgi?id=53943

Test: editing/undo/undo-paste-when-caret-is-not-in-range.html

  • editing/VisibleSelection.cpp: (WebCore::VisibleSelection::setWithoutValidation):
4:48 PM Changeset in webkit [77994] by dpranke@chromium.org
  • 3 edits
    2 adds in trunk/Tools

2011-02-08 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Mihai Parparita.

new-run-webkit-tests: split out thread stack logging code into a sharable module

This patch splits out the code used to find and log thread
stacks from NRWT-specific packages to something generic and
shareable by other python modules. It will be shared in the near
future by the manager_worker_broker module, for example.

​https://bugs.webkit.org/show_bug.cgi?id=53656

  • Scripts/webkitpy/common/system/stack_utils.py: Added.
  • Scripts/webkitpy/common/system/stack_utils_unittest.py: Added.
  • Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
  • Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
4:45 PM Changeset in webkit [77993] by Martin Robinson
  • 7 edits
    2 deletes in trunk/Source/WebCore

2011-02-08 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Remove the last remnants of the Mozilla theme drawing code
​https://bugs.webkit.org/show_bug.cgi?id=54035

Remove all Mozilla theme drawing code.

No new tests. This change only removes dead code.

  • GNUmakefile.am: Remove Mozilla files from the source list.
  • platform/gtk/RenderThemeGtk.h: Remove Mozilla-theme-drawing-related methods and add m_colormap to hold the current colormap of the widgets.
  • platform/gtk/RenderThemeGtk2.cpp: Remove Mozilla code. (WebCore::RenderThemeGtk::platformInit): Ditto. (WebCore::RenderThemeGtk::~RenderThemeGtk): Ditto. (WebCore::RenderThemeGtk::gtkContainer): Ditto.
  • platform/gtk/ScrollbarThemeGtk2.cpp: Ditto.
  • platform/gtk/WidgetRenderingContext.cpp: Ditto. (WebCore::WidgetRenderingContext::WidgetRenderingContext): Ditto.
  • platform/gtk/WidgetRenderingContext.h: Ditto.
  • platform/gtk/gtk2drawing.c: Removed.
  • platform/gtk/gtkdrawing.h: Removed.
4:40 PM Changeset in webkit [77992] by dpranke@chromium.org
  • 4 edits in trunk/Tools

2011-02-08 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Tony Chang.

new-run-webkit-tests: move a bunch of testing logic out of
dump_render_tree_thread and into single_test_runner so that we
will be able to reuse it in the new multiprocessing worker class as well.

​https://bugs.webkit.org/show_bug.cgi?id=53838

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
4:37 PM Changeset in webkit [77991] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-02-08 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: remove no longer needed WatchableThread
class.

​https://bugs.webkit.org/show_bug.cgi?id=53839

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
4:33 PM Changeset in webkit [77990] by dpranke@chromium.org
  • 1 edit
    2 adds in trunk/Tools

2011-02-08 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Tony Chang.

new-run-webkit-tests: add stubs for the Manager objects that
will abstract the concurrency implementation (inline / threads /
processes). These classes do nothing yet and are not wired up to
anything.

​https://bugs.webkit.org/show_bug.cgi?id=53477

  • Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py: Added.
  • Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py: Added.
4:31 PM Changeset in webkit [77989] by dpranke@chromium.org
  • 1 edit
    2 adds in trunk/Tools

2011-02-08 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Tony Chang.

new-run-webkit-tests: add simplified message broker for new-style
messaging. This change adds a very simple message broker that
will be used to shuttle messages between the TestRunner2 manager
thread and the Worker threads. For now the class is not used by
anything, but the eventual usage can be seen in the patches
attached to bug 49566.

​https://bugs.webkit.org/show_bug.cgi?id=53158

  • Scripts/webkitpy/layout_tests/layout_package/message_broker2.py: Added.
  • Scripts/webkitpy/layout_tests/layout_package/message_broker2_unittest.py: Added.
4:25 PM Changeset in webkit [77988] by yael.aharon@nokia.com
  • 3 edits
    5 adds in trunk

2011-02-08 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Antti Koivisto.

Crash when logging into gmail.com with frame flattening turned on.
​https://bugs.webkit.org/show_bug.cgi?id=52449

  • fast/frames/flattening/iframe-flattening-crash-expected.txt: Added.
  • fast/frames/flattening/iframe-flattening-crash.html: Added.
  • fast/frames/flattening/iframe-flattening-selection-crash-expected.txt: Added.
  • fast/frames/flattening/iframe-flattening-selection-crash.html: Added.
  • fast/frames/flattening/resources/iframe-flattening-crash.html: Added.

2011-02-08 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Antti Koivisto.

Crash when logging into gmail.com with frame flattening turned on.
​https://bugs.webkit.org/show_bug.cgi?id=52449

Frame flattening algorithm requires that layout always starts from the main frame, since layout of
subframes impacts the layout of their parents.
There are places in the code that call view->layout() not on the main frame.
Instead of changing all the callsites, I changed FrameView::layout()
to force layout from the main frame if frame flattening is enabled.
In addition, postLayoutTasks can trigger relayout, so make it use the timer even more.
Move the call to SelectionController::updateAppearance() to performPostLayoutTasks(),
because calling the from layout() leads to a crash in pages that have a selection in an iframe.

Tests: fast/frames/flattening/iframe-flattening-crash.html

fast/frames/flattening/iframe-flattening-selection-crash.html

  • page/FrameView.cpp: (WebCore::FrameView::layout): (WebCore::FrameView::performPostLayoutTasks):
4:25 PM Changeset in webkit [77987] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-02-08 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

chromium-win builder shouldn't run python or perl tests
​https://bugs.webkit.org/show_bug.cgi?id=54032

These tests don't pass on this builder because the builder isn't
running in cygwin. There isn't really any point in running them and
making the bot red forever.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
4:07 PM Changeset in webkit [77986] by aestes@apple.com
  • 2 edits in trunk

Add Radar URLs to a recent ChangeLog entry.

3:59 PM Changeset in webkit [77985] by aestes@apple.com
  • 5 edits in trunk

2011-02-08 Andy Estes <​aestes@apple.com>

Reviewed by Darin Adler.

REGRESSION (r76301): 'plaintext-only' must be a supported contentEditable mode.
​https://bugs.webkit.org/show_bug.cgi?id=54041

  • html/HTMLElement.cpp: (WebCore::HTMLElement::setContentEditable): Setting the contentEditable attribute to 'plaintext-only' should not throw an exception.

2011-02-08 Andy Estes <​aestes@apple.com>

Reviewed by Darin Adler.

REGRESSION (r76301): 'plaintext-only' must be a supported contentEditable mode.
​https://bugs.webkit.org/show_bug.cgi?id=54041

  • fast/dom/HTMLElement/set-value-caseinsensitive-expected.txt:
  • fast/dom/HTMLElement/set-value-caseinsensitive.html:
3:51 PM Changeset in webkit [77984] by mitz@apple.com
  • 3 edits in trunk/Source/WebCore

RenderRubyRun::m_beingDestroyed is redundant
​https://bugs.webkit.org/show_bug.cgi?id=54042

Reviewed by Simon Fraser.

  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::RenderRubyRun): Removed intialization of m_beingDestroyed.
(WebCore::RenderRubyRun::removeChild): Use the base class beingDestroyed().

  • rendering/RenderRubyRun.h:
3:34 PM Changeset in webkit [77983] by Adam Roben
  • 3 edits in trunk/Source/WebKit2

Implement WorkQueue::scheduleWorkAfterDelay on Windows

Each WorkQueue now owns its own timer queue. When scheduleWorkAfterDelay is called, we
create a timer-queue timer with the given delay. When the timer fires, we schedule the work
on the queue and clean up the timer.

Fixes <​http://webkit.org/b/54040> <rdar://problem/8974230> Web process sticks around forever
if it's hung when UI process goes away

Reviewed by Anders Carlsson.

  • Platform/WorkQueue.h: Added timerCallback and m_timerQueue.
  • Platform/win/WorkQueueWin.cpp:

(WorkQueue::platformInitialize): Initialize m_timerQueue.
(WorkQueue::platformInvalidate): Clean up m_timerQueue.
(TimerContext::TimerContext): Added this helper object to hold the context needed by the
timer callback.
(WorkQueue::timerCallback): Added. Schedules the WorkItem on the WorkQueue and cleans up the
timer.
(WorkQueue::scheduleWorkAfterDelay): Create a timer-queue timer on our timer queue that will
fire after the given delay. Pass a new TimerContext object to the timer callback that
contains the information it needs.

3:15 PM Changeset in webkit [77982] by Martin Robinson
  • 4 edits in trunk/LayoutTests

2011-02-08 Martin Robinson <​mrobinson@igalia.com>

Unskip a series of tests that seem to be passing locally. Also unskip
a test that was mistakenly reskipped in r77979 due to what looks like a
merge issue. Rebaseline two of these test which have results originating
from long ago.

  • platform/gtk/Skipped: Unskip some tests.
  • platform/gtk/editing/selection/14971-expected.txt:
  • platform/gtk/editing/selection/inline-closest-leaf-child-expected.txt:
3:14 PM Changeset in webkit [77981] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-02-08 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Rename PluginProcess::initializeConnection to PluginProcess::initialize
​https://bugs.webkit.org/show_bug.cgi?id=54039

  • PluginProcess/PluginProcess.cpp: (WebKit::PluginProcess::initialize):
  • PluginProcess/PluginProcess.h:
  • PluginProcess/mac/PluginProcessMainMac.mm: (WebKit::PluginProcessMain):
  • WebProcess/WebProcess.h:
3:13 PM Changeset in webkit [77980] by leviw@chromium.org
  • 26 edits in trunk/Source

2011-02-08 Levi Weintraub <​leviw@chromium.org>

Reviewed by Ryosuke Niwa.

Stop instantiating legacy editing Positions in VisiblePosition
​https://bugs.webkit.org/show_bug.cgi?id=52919

Changing usage of legacy VisiblePosition constructor. Since we were dealing
with positions from DOM Ranges, we're guaranteed a parent-anchored position.

  • WebView/WebFrame.mm: (-[WebFrame _caretRectAtPosition:affinity:]):
  • WebView/WebFrameInternal.h:
  • WebView/WebTextCompletionController.mm: (-[WebTextCompletionController doCompletion]):

2011-02-08 Levi Weintraub <​leviw@chromium.org>

Reviewed by Ryosuke Niwa.

Stop instantiating legacy editing Positions in VisiblePosition
​https://bugs.webkit.org/show_bug.cgi?id=52919

Changing VisiblePosition completely away from legacy positions.

No new tests since this is functionaly equivalent.

  • WebCore.exp.in: Removing the legacy VisiblePosition constructor and adding the PositionIsOffsetInAnchor symbol. If we must create VisiblePositions outside of WebCore, they should be parent anchored.
  • accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::visiblePositionForTextMarkerData):
  • accessibility/AccessibilityObject.cpp: (WebCore::startOfStyleRange): (WebCore::endOfStyleRange):
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::visiblePositionForIndex):
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (objectAndOffsetUnignored):
  • dom/Position.cpp: (WebCore::Position::upstream): Fixed to correctly respect PositionIsAfterAnchor (WebCore::Position::downstream): ditto
  • dom/Range.cpp: (WebCore::Range::editingStartPosition):
  • editing/Editor.cpp: (WebCore::Editor::canDeleteRange):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
  • editing/SelectionController.cpp: (WebCore::SelectionController::selectFrameElementInParentIfFullySelected): (WebCore::SelectionController::setSelectedRange):
  • editing/TextIterator.cpp: (WebCore::TextIterator::shouldRepresentNodeOffsetZero):
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed):
  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::leftVisuallyDistinctCandidate): (WebCore::VisiblePosition::rightVisuallyDistinctCandidate): (WebCore::VisiblePosition::canonicalPosition): (WebCore::VisiblePosition::characterAfter): (WebCore::VisiblePosition::localCaretRect): (WebCore::makeRange): (WebCore::startVisiblePosition): (WebCore::endVisiblePosition): (WebCore::setStart): (WebCore::setEnd): (WebCore::isFirstVisiblePositionInNode): (WebCore::isLastVisiblePositionInNode):
  • editing/VisiblePosition.h: (WebCore::VisiblePosition::VisiblePosition):
  • editing/htmlediting.cpp: (WebCore::firstInSpecialElement): (WebCore::lastInSpecialElement): (WebCore::visiblePositionBeforeNode): (WebCore::visiblePositionAfterNode):
  • editing/visible_units.cpp: (WebCore::startPositionForLine): (WebCore::endPositionForLine): (WebCore::previousLinePosition): (WebCore::nextLinePosition): (WebCore::startOfParagraph): (WebCore::endOfParagraph): (WebCore::endOfBlock): (WebCore::startOfDocument): (WebCore::endOfDocument): (WebCore::logicalStartPositionForLine): (WebCore::logicalEndPositionForLine):
  • page/DOMSelection.cpp: (WebCore::DOMSelection::collapse): (WebCore::DOMSelection::setBaseAndExtent): (WebCore::DOMSelection::setPosition): (WebCore::DOMSelection::extend):
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEventSingleClick):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::createVisiblePosition):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::visiblePositionForIndex):
  • svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::selectSubString):
3:09 PM Changeset in webkit [77979] by msaboff@apple.com
  • 5 edits in trunk

2011-02-08 Michael Saboff <​msaboff@apple.com>

JSC::Bindings m_rootObject->isValid() assert fails when running layout tests
​https://bugs.webkit.org/show_bug.cgi?id=53716

Changed ASSERT to be an if for the case where the RuntimeObject was
GC'ed before RootObject::invalidate is called. In that case there is
no need to remove the RuntimeObject from the RootObject. The isValid()
call will be false in this case, but the RuntimeObject has already
been removed from the RootObject. Added similar defensive code
in RootObject::removeRuntimeObject().

  • bridge/jsc/BridgeJSC.cpp: (JSC::Bindings::Instance::willDestroyRuntimeObject):
  • bridge/runtime_root.cpp: (JSC::Bindings::RootObject::removeRuntimeObject):

2011-02-08 Michael Saboff <​msaboff@apple.com>

Reviewed by Darin Adler.

JSC::Bindings m_rootObject->isValid() assert fails when running layout tests
​https://bugs.webkit.org/show_bug.cgi?id=53716

Re-enabled tests that are fixed with the corresponding change in
WebCore.

  • platform/gtk/Skipped:
3:07 PM Changeset in webkit [77978] by beidson@apple.com
  • 9 edits in trunk

<rdar://problem/8972913> and ​https://bugs.webkit.org/show_bug.cgi?id=54036
didChangeBackForwardList should include some context about what changed

Reviewed by Darin Adler.

Source/WebKit2:

Update the implementation of this API to include the new item (if any) and removed items (if any):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::didChangeBackForwardList):

  • UIProcess/WebLoaderClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didChangeBackForwardList):

  • UIProcess/WebPageProxy.h:

Have WebBackForwardList pass the new items and/or removed items when calling the notifier:

  • UIProcess/WebBackForwardList.cpp:

(WebKit::WebBackForwardList::addItem):
(WebKit::WebBackForwardList::goToItem):
(WebKit::WebBackForwardList::clear):

Tools:

  • MiniBrowser/mac/BrowserWindowController.m:

(didChangeBackForwardList):

3:03 PM Changeset in webkit [77977] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-02-08 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin Adler.

Give each MarkedBlock enough mark bits to cover the whole block
​https://bugs.webkit.org/show_bug.cgi?id=54029


SunSpider reports no change.

This simplifies access to mark bits, since any cell-aligned pointer
into a block now has a valid mark bit to test.


  • runtime/MarkedBlock.h: Changed CELLS_PER_BLOCK to account for the extra mark bits. This happens not to change its actual value. (JSC::MarkedBlock::cellNumber): (JSC::MarkedBlock::isMarked): (JSC::MarkedBlock::testAndSetMarked): (JSC::MarkedBlock::setMarked): Changed const JSCell* to const void* to remove a cast from our caller, and to more accurately reflect the fact that MarkedBlock is agnostic about the types pointed to by the pointers you pass to it.

(JSC::MarkedBlock::isPossibleCell): Removed a null check. We now consider
the null pointer to be a possible cell with a 0 (impossible) block. This
removes a null check from marking.

  • runtime/MarkedSpace.cpp:
  • runtime/MarkedSpace.h: (JSC::MarkedSpace::contains): Simplified the contains check, and inlined the whole thing, now that it's so simple.
3:02 PM Changeset in webkit [77976] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Sandbox violations visiting MobileMe.
<rdar://problem/8961330>

Reviewed by Anders Carlsson.

  • WebProcess/com.apple.WebProcess.sb:
2:52 PM Changeset in webkit [77975] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-02-08 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Rename PluginProcess::initialize to PluginProcess::initializePluginProcess
​https://bugs.webkit.org/show_bug.cgi?id=54037

Rename PluginProcess::initialize to PluginProcess::initializePluginProcess to better
match the WebProcess initialization code, in preparation of sharing more code.

  • PluginProcess/PluginProcess.cpp: (WebKit::PluginProcess::initializePluginProcess):
  • PluginProcess/PluginProcess.h:
  • PluginProcess/PluginProcess.messages.in:
  • UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::didFinishLaunching):
2:48 PM Changeset in webkit [77974] by weinig@apple.com
  • 26 edits
    6 adds in trunk

WK2: Add ability to pass context to policy delegate methods
​https://bugs.webkit.org/show_bug.cgi?id=54031

Reviewed by Anders Carlsson.

Source/WebKit2:

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::callMemberFunction):
(CoreIPC::handleMessageVariadic):

  • Scripts/webkit2/messages.py:

Add ability to pass variadic messages to sync messages.

  • Shared/API/c/WKBase.h:
  • Shared/APIObject.h:

Add WKBundleNavigation type.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
(WebKit::WebPageProxy::decidePolicyForMIMEType):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebPolicyClient.cpp:

(WebKit::WebPolicyClient::decidePolicyForNavigationAction):
(WebKit::WebPolicyClient::decidePolicyForNewWindowAction):
(WebKit::WebPolicyClient::decidePolicyForMIMEType):

  • UIProcess/WebPolicyClient.h:

Update policy client for new data.

  • WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
  • WebProcess/InjectedBundle/API/c/WKBundleNavigationAction.cpp: Added.

(WKBundleNavigationActionGetTypeID):
(WKBundleNavigationActionGetNavigationType):
(WKBundleNavigationActionGetEventModifiers):
(WKBundleNavigationActionGetEventMouseButton):
(WKBundleNavigationActionCopyHitTestResult):
(WKBundleNavigationActionCopyFormElement):

  • WebProcess/InjectedBundle/API/c/WKBundleNavigationAction.h: Added.
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageSetPolicyClient):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp: Added.

(WebKit::mouseEventForNavigationAction):
(WebKit::mouseButtonForMouseEvent):
(WebKit::InjectedBundleNavigationAction::modifiersForNavigationAction):
(WebKit::InjectedBundleNavigationAction::mouseButtonForNavigationAction):
(WebKit::InjectedBundleNavigationAction::create):
(WebKit::InjectedBundleNavigationAction::InjectedBundleNavigationAction):

  • WebProcess/InjectedBundle/InjectedBundleNavigationAction.h: Added.

(WebKit::InjectedBundleNavigationAction::navigationType):
(WebKit::InjectedBundleNavigationAction::modifiers):
(WebKit::InjectedBundleNavigationAction::mouseButton):
(WebKit::InjectedBundleNavigationAction::hitTestResult):
(WebKit::InjectedBundleNavigationAction::formElement):
(WebKit::InjectedBundleNavigationAction::type):

  • WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.cpp: Added.

(WebKit::InjectedBundlePagePolicyClient::decidePolicyForNavigationAction):
(WebKit::InjectedBundlePagePolicyClient::decidePolicyForNewWindowAction):
(WebKit::InjectedBundlePagePolicyClient::decidePolicyForMIMEType):

  • WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.h: Added.
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::createWindow):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::initializeInjectedBundlePolicyClient):

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::injectedBundlePolicyClient):
Pipe the policy client through the bundle to allow setting user data.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:

Add new files.

Tools:

  • MiniBrowser/mac/BrowserWindowController.m:

(decidePolicyForNavigationAction):
(decidePolicyForNewWindowAction):
(decidePolicyForMIMEType):

  • TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:

(TestWebKitAPI::decidePolicyForNavigationAction):
(TestWebKitAPI::decidePolicyForNewWindowAction):
(TestWebKitAPI::decidePolicyForMIMEType):
Update policy client for new API.

2:33 PM Changeset in webkit [77973] by xji@chromium.org
  • 4 edits
    1 delete in trunk/LayoutTests

2011-02-08 Xiaomei Ji <​xji@chromium.org>

Unreviewed.

Rebaseline for chromium-mac after r77952.
Not sure why the previous rebase did not get the right results.
​https://bugs.webkit.org/show_bug.cgi?id=54026

  • platform/chromium-mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum:
  • platform/chromium-mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png:
  • platform/chromium-mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
2:31 PM Changeset in webkit [77972] by dbates@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-02-08 Daniel Bates <​dbates@rim.com>

Rubber-stamped by Martin Robinson.

Rename enum ProtectionSeting [sic] to ProtectionSetting.

  • jit/ExecutableAllocator.cpp: (JSC::ExecutableAllocator::reprotectRegion):
  • jit/ExecutableAllocator.h:
2:25 PM Changeset in webkit [77971] by Martin Robinson
  • 10 edits in trunk

2011-02-08 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] DRT needs an implementation of LayoutTestController.setIconDatabaseEnabled
​https://bugs.webkit.org/show_bug.cgi?id=54033

  • platform/gtk/Skipped: Unskip a test that is now passing.

2011-02-08 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] DRT needs an implementation of LayoutTestController.setIconDatabaseEnabled
​https://bugs.webkit.org/show_bug.cgi?id=54033

Add a DumpRenderTreeSupportGtk method for turning the icon database on and off.
This is a likely candidate for a new API point.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::setIconDatabaseEnabled): Added.
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:
  • webkit/webkitglobals.cpp: (webkitInit): Call setIconDatabaseEnabled(true) on startup, instead of initializing the database manually. (WebKit::setIconDatabaseEnabled): Added.
  • webkit/webkitglobalsprivate.h: Added declarations.

2011-02-08 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] DRT needs an implementation of LayoutTestController.setIconDatabaseEnabled
​https://bugs.webkit.org/show_bug.cgi?id=54033

Add an implementation of LayoutTestController.setIconDatabaseEnabled that just
call DumpRenderTreeSupportGtk. Turn off the icon database between tests.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): Turn off the icon database.
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setIconDatabaseEnabled): Call the appropriate DumpRenderTreeSupportGtk method.
2:11 PM Changeset in webkit [77970] by Beth Dakin
  • 3 edits in trunk/Source/WebCore

Fix for <rdar://problem/8953365> CrashTracer: 14
crashes in WebProcess at com.apple.WebCore:
-[ScrollKnobAnimation setCurrentProgress:] + 258

Reviewed by Darin Adler.

This crash seems to happen when the animation is running
and a window is closed. If the ScrollAnimator is destroyed,
delegate calls for the animation can still run, so we have
to make sure we inform the delegates when the ScrollAnimator
is gone, and then we have to null-check it before we do
anything with it.

Remove scrollbarPainterDelegate() since it's not used anymore.

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:


Add null-checks for _animator
(-[ScrollbarPartAnimation setCurrentProgress:]):
(-[ScrollbarPartAnimation scrollAnimatorDestroyed]):
(-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:overlayScrollerStateChangedTo:]):

New function to inform the delegates that the ScrollAnimator
is being destroyed.
(-[ScrollbarPainterDelegate scrollAnimatorDestroyed]):
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):

2:00 PM Changeset in webkit [77969] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2011-02-08 Zhenyao Mo <​zmo@google.com>

Unreviewed, typo fix.

  • platform/chromium/test_expectations.txt
1:51 PM Changeset in webkit [77968] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-02-08 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Crash calling -setFrame:andScrollBy: in windowDidResize
​https://bugs.webkit.org/show_bug.cgi?id=54030
<rdar://problem/8969760>

  • Platform/mac/SharedMemoryMac.cpp: (WebKit::SharedMemory::create): Assert that size is not zero here; we never want to try to create shared memory with a zero size.


  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::setSize): Always invalidate the entire visible page when resizing.
1:09 PM Changeset in webkit [77967] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2011-02-08 Martin Robinson <​mrobinson@igalia.com>

Unskip some inspector tests that are passing locally. The bugs are
missing test diffs, so we can either reskip them and get more information
or have passing tests. Classify another failure.

  • platform/gtk/Skipped: Clean up the skipped list.
1:06 PM Changeset in webkit [77966] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2011-02-08 Zhenyao Mo <​zmo@google.com>

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt
12:54 PM Changeset in webkit [77965] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-08 Kenji Imasaki <​imasaki@chromium.org>

Reviewed by Jian Li.

[Chromium] Remove non-Flaky media tests from test expectation file
​https://bugs.webkit.org/show_bug.cgi?id=54021

  • platform/chromium/test_expectations.txt:
12:19 PM Changeset in webkit [77964] by xji@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-08 Xiaomei Ji <​xji@chromium.org>

Unreviewed. Fix typo in rebaseline in r77961.

  • platform/mac-leopard/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
12:17 PM Changeset in webkit [77963] by abarth@webkit.org
  • 29 edits in trunk/Source

2011-02-08 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove orphan code from old parser
​https://bugs.webkit.org/show_bug.cgi?id=53984

This code appears to be unused.

  • html/HTMLParserErrorCodes.cpp:
  • html/HTMLParserErrorCodes.h:
  • html/HTMLParserQuirks.h:
  • loader/EmptyClients.h:
  • page/ChromeClient.h:

2011-02-08 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove orphan code from old parser
​https://bugs.webkit.org/show_bug.cgi?id=53984

  • src/ChromeClientImpl.h:

2011-02-08 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove orphan code from old parser
​https://bugs.webkit.org/show_bug.cgi?id=53984

  • WebCoreSupport/ChromeClientEfl.h:

2011-02-08 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove orphan code from old parser
​https://bugs.webkit.org/show_bug.cgi?id=53984

  • WebCoreSupport/ChromeClientGtk.h:

2011-02-08 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove orphan code from old parser
​https://bugs.webkit.org/show_bug.cgi?id=53984

  • WebCoreSupport/ChromeClientHaiku.cpp:
  • WebCoreSupport/ChromeClientHaiku.h:

2011-02-08 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove orphan code from old parser
​https://bugs.webkit.org/show_bug.cgi?id=53984

  • WebCoreSupport/WebChromeClient.h:

2011-02-08 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove orphan code from old parser
​https://bugs.webkit.org/show_bug.cgi?id=53984

  • WebCoreSupport/ChromeClientQt.h:

2011-02-08 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove orphan code from old parser
​https://bugs.webkit.org/show_bug.cgi?id=53984

  • WebCoreSupport/WebChromeClient.h:

2011-02-08 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove orphan code from old parser
​https://bugs.webkit.org/show_bug.cgi?id=53984

  • WebCoreSupport/ChromeClientWinCE.cpp:
  • WebCoreSupport/ChromeClientWinCE.h:

2011-02-08 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove orphan code from old parser
​https://bugs.webkit.org/show_bug.cgi?id=53984

  • WebKitSupport/ChromeClientWx.h:

2011-02-08 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove orphan code from old parser
​https://bugs.webkit.org/show_bug.cgi?id=53984

  • WebProcess/WebCoreSupport/WebChromeClient.cpp
  • WebProcess/WebCoreSupport/WebChromeClient.h
11:36 AM Changeset in webkit [77962] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-08 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

UI process crashes if web process crashes while web inspector is focused
​https://bugs.webkit.org/show_bug.cgi?id=53965
<rdar://problem/8961633>

Make sure to close the web inspector web page proxy before calling platformClose, since
platformClose can cause the web page proxy to try to send messages (such as SetActive)
to the web process while it's in a bad state.

The original fix, ​http://trac.webkit.org/changeset/77866, put the call to m_page->close() in
WebInspectorProxy::didClose, which was wrong and lead to crashes. The right place to close the page
is in WebInspectorProxy::invalidate.

  • UIProcess/WebInspectorProxy.cpp: (WebKit::WebInspectorProxy::invalidate):
11:25 AM Changeset in webkit [77961] by xji@chromium.org
  • 2 edits
    11 adds in trunk/LayoutTests

2011-02-08 Xiaomei Ji <​xji@chromium.org>

Unreviewed.

Rebaseline after r77952.

  • platform/chromium-linux/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum: Added.
  • platform/chromium-linux/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Added.
  • platform/chromium-linux/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Added.
  • platform/chromium-mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Added.
  • platform/chromium-mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Added.
  • platform/chromium-win/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum: Added.
  • platform/chromium-win/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Added.
  • platform/chromium-win/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac-leopard/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Added.
  • platform/win/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Added.
11:15 AM Changeset in webkit [77960] by Martin Robinson
  • 7 edits in trunk/Source/WebCore

2011-02-08 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Move scrollbar rendering out of gtk2drawing.c
​https://bugs.webkit.org/show_bug.cgi?id=52836

Replace gtk2drawing.c scrollbar rendering with our own version. This
is the last use of the Mozilla theme drawing code.

No new tests. This should not change the rendering of the default
theme.

  • platform/gtk/GtkVersioning.h: Add some more backported allocation setters.
  • platform/gtk/RenderThemeGtk.h: Add a getter for the scrollbar widgets.
  • platform/gtk/RenderThemeGtk2.cpp: Initialize and add getters for scrollbar widgets. (WebCore::RenderThemeGtk::platformInit): Ditto. (WebCore::RenderThemeGtk::gtkHScrollbar): Ditto. (WebCore::RenderThemeGtk::gtkVScrollbar): Ditto.
  • platform/gtk/ScrollbarThemeGtk.cpp: (WebCore::ScrollbarThemeGtk::paint): We only repaint the scrolled window background if we are repainting a button or the thumb. In that case also repaint the track rect.
  • platform/gtk/ScrollbarThemeGtk2.cpp: Port to WidgetRenderingContext. (WebCore::ScrollbarThemeGtk::ScrollbarThemeGtk): Ditto. (WebCore::ScrollbarThemeGtk::updateThemeProperties): Ditto. (WebCore::getWidgetForScrollbar): Ditto. (WebCore::ScrollbarThemeGtk::paintTrackBackground): Ditto. (WebCore::ScrollbarThemeGtk::paintScrollbarBackground): Ditto. (WebCore::ScrollbarThemeGtk::paintThumb): Ditto. (WebCore::ScrollbarThemeGtk::paintButton): Ditto.
  • platform/gtk/WidgetRenderingContext.cpp: Ditto. (WebCore::WidgetRenderingContext::gtkPaintBox): Added an option which also adjusts a widget allocation according to the paint rect. This is necessary to properly draw scrollbar buttons.
  • platform/gtk/WidgetRenderingContext.h: Ditto.
11:12 AM Changeset in webkit [77959] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2011-02-08 Zhenyao Mo < ​zmo@google.com>

Unreviewed, test expectations update.

  • LauoutTests/platform/chromium/test_expectations.txt
10:57 AM Changeset in webkit [77958] by Simon Fraser
  • 3 edits
    4 adds in trunk

2011-02-08 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Inset shadow with large offset renders incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=53882

Fix an issue with inset shadows, when the shadow offset
was larger than the box size. In this case we'd fail to
fill the box with the shadow color.

Test: fast/box-shadow/inset-shadow-large-offset.html

  • rendering/RenderBoxModelObject.cpp: (WebCore::areaCastingShadowInHole): Return a rect that covers the area which contributes to the inset shadow.

(WebCore::RenderBoxModelObject::paintBoxShadow): Use areaCastingShadowInHole()
to compute the outerRect.

10:56 AM Changeset in webkit [77957] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-02-08 Tony Chang <​tony@chromium.org>

Unreviewed, build fix for clobber builds of DRT on mac/linux.

This file moved in chromium r73530 and this path wasn't changed.

  • WebKit.gyp:
10:47 AM Changeset in webkit [77956] by zmo@google.com
  • 5 edits in trunk

2011-02-08 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

drawElements should check if a buffer is bound to ELEMENT_ARRAY_BUFFER
​https://bugs.webkit.org/show_bug.cgi?id=54017

  • fast/canvas/webgl/draw-elements-out-of-bounds-expected.txt:
  • fast/canvas/webgl/draw-elements-out-of-bounds.html:

2011-02-08 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

drawElements should check if a buffer is bound to ELEMENT_ARRAY_BUFFER
​https://bugs.webkit.org/show_bug.cgi?id=54017

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::drawElements):
10:37 AM Changeset in webkit [77955] by xji@chromium.org
  • 4 edits in trunk/LayoutTests

2011-02-08 Xiaomei Ji <​xji@chromium.org>

Unreviewed. after r77952,
skip pop-up-button-text-alignment-and-direction.html in qt and gtk as bidi-menulist.html.
set it as expect to fail in chromium.

  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
10:35 AM Changeset in webkit [77954] by Dimitri Glazkov
  • 12 edits in trunk/Source/WebCore

2011-01-28 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Change the rest of HTMLMediaElement shadow DOM parts to use shadowPseudoId.
​https://bugs.webkit.org/show_bug.cgi?id=53190

This is the second part of refactoring the HTMLMediaElement to use new
shadow DOM. The changes are mainly mechanical, except for needing to
add a new method to RenderTheme, which indicates whether or not status
display is being used by it. Previously, we relied on existence of a cached
pseudo style.

Refactoring, covered by existing tests.

  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): Removed now-unused enum values. (WebCore::nameToPseudoTypeMap): Ditto. (WebCore::CSSSelector::extractPseudoType): Ditto.
  • css/CSSSelector.h: Ditto.
  • html/shadow/MediaControls.cpp: (WebCore::MediaControls::createPanel): Changed to use the newly-added MediaControlPanelElement. (WebCore::MediaControls::createCurrentTimeDisplay): Changed to use the newly-added

MediaControlCurrentTimeDisplayElement.

(WebCore::MediaControls::createTimeRemainingDisplay): Changed to use the newly-added

MediaControlTimeRemainingDisplayElement.

  • rendering/MediaControlElements.cpp: (WebCore::MediaControlShadowRootElement::updateStyle): Changed to use the

standard style resolution.

(WebCore::MediaControlShadowRootElement::shadowPseudoId): Added.
(WebCore::MediaControlElement::MediaControlElement): Removed the switch statement

that is no longer necessary.

(WebCore::MediaControlElement::styleForElement): Changed to use the standard

style resolution.

(WebCore::MediaControlPanelElement::MediaControlPanelElement): Added.
(WebCore::MediaControlPanelElement::create): Added.
(WebCore::MediaControlPanelElement::displayType): Added.
(WebCore::MediaControlPanelElement::shadowPseudoId): Added.
(WebCore::MediaControlTimelineContainerElement::MediaControlTimelineContainerElement):

Removed PseudoId constructor arg.

(WebCore::MediaControlTimelineContainerElement::rendererIsNeeded):

Changed to use the newly-plumbed usesMediaControlStatusDisplay helper.

(WebCore::MediaControlTimelineContainerElement::displayType): Added.
(WebCore::MediaControlTimelineContainerElement::shadowPseudoId): Added.
(WebCore::MediaControlVolumeSliderContainerElement::MediaControlVolumeSliderContainerElement):

Removed PseudoId constructor arg.

(WebCore::MediaControlVolumeSliderContainerElement::displayType): Added.
(WebCore::MediaControlVolumeSliderContainerElement::shadowPseudoId): Added.
(WebCore::MediaControlStatusDisplayElement::MediaControlStatusDisplayElement):

Removed PseudoId constructor arg.

(WebCore::MediaControlStatusDisplayElement::rendererIsNeeded): Changed to

use the newly-plumbed usesMediaControlStatusDisplay helper.

(WebCore::MediaControlStatusDisplayElement::displayType): Added.
(WebCore::MediaControlStatusDisplayElement::shadowPseudoId): Added.
(WebCore::MediaControlTimeDisplayElement::MediaControlTimeDisplayElement):

Removed PseudoId constructor arg.

(WebCore::MediaControlTimeRemainingDisplayElement::create): Added.
(WebCore::MediaControlTimeRemainingDisplayElement::MediaControlTimeRemainingDisplayElement): Added.
(WebCore::MediaControlTimeRemainingDisplayElement::displayType): Added.
(WebCore::MediaControlTimeRemainingDisplayElement::shadowPseudoId): Added.
(WebCore::MediaControlCurrentTimeDisplayElement::create): Added.
(WebCore::MediaControlCurrentTimeDisplayElement::MediaControlCurrentTimeDisplayElement): Added.
(WebCore::MediaControlCurrentTimeDisplayElement::displayType): Added.
(WebCore::MediaControlCurrentTimeDisplayElement::shadowPseudoId): Added.

  • rendering/MediaControlElements.h: Added/changed defs accordingly.
  • rendering/RenderTheme.h: (WebCore::RenderTheme::usesMediaControlStatusDisplay): Added.
  • rendering/RenderThemeMac.h: Added def.
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::usesMediaControlStatusDisplay): Added.
  • rendering/style/RenderStyleConstants.h: Removed now-unused enum values.
10:32 AM Changeset in webkit [77953] by hyatt@apple.com
  • 3 edits in trunk/Source/WebKit/win

<rdar://problem/8932077> REGRESSION (5.0.3-ToT): United boarding pass has wrong layout when printed

Reviewed by Adam Roben.

Windows never got patched to pass in the page height to WebCore, so when WebCore's pagination got re-written to depend on this
value, Windows got broken. Patch setPrinting to be identical to WebKit1 on OS X and to have it take an extra minimum page height
argument.

  • WebFrame.cpp:

(WebFrame::setPrinting):
(WebFrame::setInPrintingMode):

  • WebFrame.h:
10:22 AM Changeset in webkit [77952] by xji@chromium.org
  • 3 edits
    4 adds in trunk

2011-02-08 Xiaomei Ji <​xji@chromium.org>

Reviewed by Dan Bernstein.

Fix pop-up button text not rendered correctly according to its direction
in <option>.
​https://bugs.webkit.org/show_bug.cgi?id=53642


In adjustInnerStyle(), if m_innerBlock's direction or unicode-bidi
changes, set it needs layout.

  • fast/text/international/pop-up-button-text-alignment-and-direction.html: Added.
  • platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum: Added.
  • platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Added.
  • platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Added.

2011-02-08 Xiaomei Ji <​xji@chromium.org>

Reviewed by Dan Bernstein.

Fix pop-up button text not rendered correctly according to its direction
in <option>.
​https://bugs.webkit.org/show_bug.cgi?id=53642


In adjustInnerStyle(), if m_innerBlock's direction or unicode-bidi
changes, set it needs layout.

Test: fast/text/international/pop-up-button-text-alignment-and-direction.html

  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::adjustInnerStyle):
10:01 AM Changeset in webkit [77951] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-08 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed build fix for Qt-minimal.

  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::hasFrontend):
9:32 AM Changeset in webkit [77950] by loislo@chromium.org
  • 25 edits in trunk/Source

2011-02-02 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.

​https://bugs.webkit.org/show_bug.cgi?id=53169

All the Inspector API for WebCore has two parts.
The first one is InspectorInstrumentation for WebCore.
The second is InspectorController for WebKit.
InspectorAgent was produced by renaming original InspectorController.
This patch extracts WebKit related methods from InspectorAgent to InspectorController.

  • WebCore.exp.in:
  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::createParser):
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::~InspectorAgent): (WebCore::InspectorAgent::restoreInspectorStateFromCookie): (WebCore::InspectorAgent::inspect): (WebCore::InspectorAgent::handleMousePress): (WebCore::InspectorAgent::didClearWindowObjectInWorld): (WebCore::InspectorAgent::setFrontend): (WebCore::InspectorAgent::disconnectFrontend): (WebCore::InspectorAgent::resourceAgent): (WebCore::InspectorAgent::createFrontendLifetimeAgents): (WebCore::InspectorAgent::releaseFrontendLifetimeAgents): (WebCore::InspectorAgent::populateScriptObjects): (WebCore::InspectorAgent::pushDataCollectedOffline): (WebCore::InspectorAgent::restoreProfiler): (WebCore::InspectorAgent::startTimelineProfiler): (WebCore::PostWorkerNotificationToFrontendTask::performTask): (WebCore::InspectorAgent::didOpenDatabase): (WebCore::InspectorAgent::didUseDOMStorage): (WebCore::InspectorAgent::showAndEnableDebugger): (WebCore::InspectorAgent::enableDebugger): (WebCore::InspectorAgent::enabled):
  • inspector/InspectorAgent.h: (WebCore::InspectorAgent::frontend):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::setInspectorFrontendClient): (WebCore::InspectorController::hasInspectorFrontendClient): (WebCore::InspectorController::didClearWindowObjectInWorld): (WebCore::InspectorController::startTimelineProfiler): (WebCore::InspectorController::stopTimelineProfiler): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::disconnectFrontendImpl): (WebCore::InspectorController::show): (WebCore::InspectorController::close): (WebCore::InspectorController::restoreInspectorStateFromCookie): (WebCore::InspectorController::evaluateForTestInFrontend): (WebCore::InspectorController::drawNodeHighlight): (WebCore::InspectorController::inspect): (WebCore::InspectorController::enabled): (WebCore::InspectorController::showPanel): (WebCore::InspectorController::frontendLoaded): (WebCore::InspectorController::timelineProfilerEnabled): (WebCore::InspectorController::enableProfiler): (WebCore::InspectorController::disableProfiler): (WebCore::InspectorController::profilerEnabled): (WebCore::InspectorController::debuggerEnabled): (WebCore::InspectorController::showAndEnableDebugger): (WebCore::InspectorController::disableDebugger): (WebCore::InspectorController::startUserInitiatedProfiling): (WebCore::InspectorController::stopUserInitiatedProfiling): (WebCore::InspectorController::isRecordingUserInitiatedProfile): (WebCore::InspectorController::setInspectorExtensionAPI): (WebCore::InspectorController::resume): (WebCore::InspectorController::hideHighlight): (WebCore::InspectorController::dispatchMessageFromFrontend):
  • inspector/InspectorController.h: (WebCore::InspectorController::inspectorClient): (WebCore::InspectorController::inspectedPage): (WebCore::InspectorController::hasFrontend):
  • inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorFrontendClientLocal::sendMessageToBackend):
  • inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::setExtensionAPI):
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl): (WebCore::InspectorInstrumentation::profilerEnabledImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::hasFrontend):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):

2011-02-02 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.

​https://bugs.webkit.org/show_bug.cgi?id=53169

Minor change enforced by major changes in WebCore/inspector/InspectorController.

  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::dispatchOnInspectorBackend):
  • src/WebViewImpl.h:

2011-02-02 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.

​https://bugs.webkit.org/show_bug.cgi?id=53169

Minor change enforced by major changes in WebCore/inspector/InspectorController.

  • WebCoreSupport/InspectorClientGtk.cpp:
  • webkit/webkitwebinspector.cpp: (webkit_web_inspector_get_property):

2011-02-02 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.

​https://bugs.webkit.org/show_bug.cgi?id=53169

Minor change enforced by major changes in WebCore/inspector/InspectorController.

2011-02-02 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.

​https://bugs.webkit.org/show_bug.cgi?id=53169

Minor change enforced by major changes in WebCore/inspector/InspectorController.

  • WebInspector.cpp: (WebInspector::isTimelineProfilingEnabled):
9:30 AM Changeset in webkit [77949] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-08 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Martin Robinson.

editing/selection/end-of-document.html is failing in the GTK 64-bit debug bot
​https://bugs.webkit.org/show_bug.cgi?id=53995

Ensure to wait for the body to be loaded before running the test.

  • editing/selection/end-of-document.html: Call runEditingTest() on the body.onload event.
9:27 AM Changeset in webkit [77948] by kbalazs@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-08 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Andreas Kling.

[Qt] Should not always define USE_SYSTEM_MALLOC
​https://bugs.webkit.org/show_bug.cgi?id=54007

  • wtf/Platform.h:
9:21 AM Changeset in webkit [77947] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

2011-02-08 Kundu Suchismita <​suchi.kundu@nokia.com>

Reviewed by Laszlo Gombos.

Local Storage settings can be enable/disable from "Develop" menu
​https://bugs.webkit.org/show_bug.cgi?id=52296

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::createChrome): (LauncherWindow::toggleLocalStorage): (LauncherWindow::toggleOfflineStorageDatabase): (LauncherWindow::toggleOfflineWebApplicationCache): (LauncherWindow::setOfflineStorageDefaultQuota):
  • QtTestBrowser/launcherwindow.h: (WindowOptions::WindowOptions):
  • QtTestBrowser/main.cpp: (LauncherApplication::handleUserOptions):
9:16 AM Changeset in webkit [77946] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-08 George Wright <​gwright@rim.com>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=53949

Ensure that we pack the colour byte order correctly for Skia using
Skia's SkPackARGB32 function.

  • platform/image-decoders/ImageDecoder.h: (WebCore::ImageFrame::setRGBA):
9:05 AM Changeset in webkit [77945] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-08 George Wright <​gwright@rim.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=53951

Ensure we do not pass (-1, -1) sized rects to ImageBuffer but instead
pass the full image dimensions.

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawImageBuffer):
8:50 AM Changeset in webkit [77944] by Patrick Gansterer
  • 3 edits in trunk/Source/WebCore

2011-02-08 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

[WIN] Add missing includes and forward declarations for DownloadBundle
​https://bugs.webkit.org/show_bug.cgi?id=53881

  • platform/network/cf/DownloadBundle.h:
  • platform/network/win/DownloadBundleWin.cpp: (WebCore::DownloadBundle::appendResumeData):
8:47 AM Changeset in webkit [77943] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-02-08 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

[WIN] Add missing include in WKCAImageQueue
​https://bugs.webkit.org/show_bug.cgi?id=53890

  • platform/graphics/win/WKCAImageQueue.cpp:
8:28 AM Changeset in webkit [77942] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebKit2

ASSERTION FAILURE: ASSERT_NOT_REACHED() in Connection::writeEventHandler() after the Web
Process crashes.
​https://bugs.webkit.org/show_bug.cgi?id=54005

Reviewed by Adam Roben.

  • Platform/CoreIPC/win/ConnectionWin.cpp:

(CoreIPC::Connection::writeEventHandler):
Handle ERROR_BROKEN_PIPE by calling connectionDidClose() and returning early.

8:17 AM Changeset in webkit [77941] by Patrick Gansterer
  • 2 edits in trunk/WebKitLibraries

2011-02-08 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

[WIN] Add missing forward declarations in WebKitSystemInterface.h
​https://bugs.webkit.org/show_bug.cgi?id=53889

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
8:08 AM Changeset in webkit [77940] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2011-02-08 Martin Robinson <​mrobinson@igalia.com>

Unskip a bunch of tests that are passing locally and move one
timeout with the other timeouts.

  • platform/gtk/Skipped: Unskip some passing tests.
8:03 AM Changeset in webkit [77939] by Adam Roben
  • 2 edits in trunk/Source/WebKit2

Handle WM_TIMER messages for stopped timers

Whenever we stop a timer, we call ::KillTimer to cancel any future firings of the timer. But
::KillTimer doesn't do anything about WM_TIMER messages that have already been posted to the
message queue. We need to handle those, too.

Fixes <​http://webkit.org/b/53999> Occasional assertion failures in
RunLoop::TimerBase::timerFired

Reviewed by Darin Adler.

  • Platform/win/RunLoopWin.cpp:

(RunLoop::TimerBase::timerFired): Just bail if the timer has already been stopped.

8:01 AM Changeset in webkit [77938] by Adam Roben
  • 2 edits in trunk/Source/WebKit2

Don't mark a Connection as connected until open() is called on Windows

This matches Mac. Even though the Connection's pipe is connected before open() is called,
the Connection itself isn't really connected to the pipe until then, and we won't actually
read any data from before that point.

Fixes <​http://webkit.org/b/53998> <rdar://problem/8971207> REGRESSION (r77874): Assertion
failure on launch in Connection::setDidCloseOnConnectionWorkQueueCallback on Windows

Reviewed by Darin Adler.

  • Platform/CoreIPC/win/ConnectionWin.cpp:

(CoreIPC::Connection::platformInitialize): Moved code to set m_isConnected from here to
open.
(CoreIPC::Connection::platformInvalidate): Unset m_isConnected, to match Mac. (This isn't
part of the bug fix, but seemed worthwhile.)
(CoreIPC::Connection::open): Set m_isConnected now that we're going to listen on the pipe.

7:58 AM Changeset in webkit [77937] by Patrick Gansterer
  • 7 edits in trunk/Source/WebCore

2011-02-08 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

[WIN] Add missing includes and forward declarations for CFNetwork
​https://bugs.webkit.org/show_bug.cgi?id=53883

  • platform/network/cf/DNSCFNet.cpp:
  • platform/network/cf/LoaderRunLoopCF.cpp:
  • platform/network/cf/LoaderRunLoopCF.h:
  • platform/network/cf/ProxyServerCFNet.cpp:
  • platform/network/cf/SocketStreamHandle.h:
  • platform/network/cf/SocketStreamHandleCFNet.cpp:
7:57 AM Changeset in webkit [77936] by Martin Robinson
  • 4 edits in trunk

2011-02-08 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] EventSender.keyDown does not support non-array modifier arguments
​https://bugs.webkit.org/show_bug.cgi?id=53962

  • platform/gtk/Skipped: Unskip a test which is now passing.

2011-02-08 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] EventSender.keyDown does not support non-array modifier arguments
​https://bugs.webkit.org/show_bug.cgi?id=53962

Support handling either an array or a string for the modifier argument
to EventSender.keyDown.

  • DumpRenderTree/gtk/EventSender.cpp: (gdkModifierFromJSValue): Added this helper which factors out the string comparison bits. (gdkModifersFromJSValue): Test up front whether the value is a string, to handle it specially.
7:51 AM Changeset in webkit [77935] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-02-08 Patrick Gansterer <Patrick Gansterer>

Unreviewed WinCE build fix for r77870.

  • platform/DragImage.cpp: Compile createDragImageForLink on WinCE.
7:48 AM Changeset in webkit [77934] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-08 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Removing inspector tests from Skipped on [win].
Resource tracking has been removed since then, maybe it'll help.

  • platform/win/Skipped:
7:46 AM Changeset in webkit [77933] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2011-02-08 Martin Robinson <​mrobinson@igalia.com>

Clean up the skipped list slightly and unskip a test which should now be passing.

  • platform/gtk/Skipped: Clean up.
7:40 AM Changeset in webkit [77932] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-08 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: open network resource url in new tab upon double click.
​https://bugs.webkit.org/show_bug.cgi?id=53930

  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkDataGridNode.prototype.createCells): (WebInspector.NetworkDataGridNode.prototype._openInNewTab):
7:34 AM Changeset in webkit [77931] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-08 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: $x: any node should work in optional context parameter.
​https://bugs.webkit.org/show_bug.cgi?id=50138

  • inspector/InjectedScriptSource.js:
7:30 AM Changeset in webkit [77930] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-02-08 Patrick Gansterer <Patrick Gansterer>

Unreviewed WinCE build fix for r77870.

Remove the global namespace prefix from GlobalLock/GlobalUnlock.

  • platform/win/ClipboardUtilitiesWin.cpp:
7:27 AM Changeset in webkit [77929] by pfeldman@chromium.org
  • 5 edits
    2 adds in trunk

2011-02-08 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: re-apply r77924.

Test: inspector/console-api-on-call-frame.html

  • inspector/InjectedScriptSource.js:
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
7:08 AM Changeset in webkit [77928] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-02-08 Andreas Kling <​kling@webkit.org>

Reviewed by Tor Arne Vestbø.

REGRESSION(r77312): Unbreak TiledBackingStore.

Due to an off-by-one error, we were no longer rendering the
rightmost column and bottom row of tiles.

Covered by tst_QGraphicsWebView::widgetsRenderingThroughCache().

  • platform/graphics/TiledBackingStore.cpp: (WebCore::TiledBackingStore::invalidate): (WebCore::TiledBackingStore::updateTileBuffers): (WebCore::TiledBackingStore::paint): (WebCore::TiledBackingStore::createTiles):
6:26 AM Changeset in webkit [77927] by commit-queue@webkit.org
  • 3 edits
    2 deletes in trunk

2011-02-08 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r77924.
​http://trac.webkit.org/changeset/77924
​https://bugs.webkit.org/show_bug.cgi?id=53997

Breaks inspector tests. (Requested by pfeldman on #webkit).

  • inspector/console-api-on-call-frame-expected.txt: Removed.
  • inspector/console-api-on-call-frame.html: Removed.

2011-02-08 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r77924.
​http://trac.webkit.org/changeset/77924
​https://bugs.webkit.org/show_bug.cgi?id=53997

Breaks inspector tests. (Requested by pfeldman on #webkit).

  • inspector/InjectedScriptSource.js: (.): ():
6:04 AM Changeset in webkit [77926] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-02-08 Benjamin Poulain <​ikipou@gmail.com>

Reviewed by Csaba Osztrogonác.

openDatabaseSync() stop responding after too many call
​https://bugs.webkit.org/show_bug.cgi?id=53945

Reset the database quota to a known state between each test.

Define a quota for the known origins at each test run and delete
all the databases.
This way, the database related test do not depend on previous
allocations.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): (WebCore::DumpRenderTree::dumpDatabaseQuota):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset):
5:42 AM Changeset in webkit [77925] by caseq@chromium.org
  • 16 edits in trunk/Source/WebCore

2011-02-04 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [refacotring] merge InspectorAgent::willSendRequest() into InspectorResourceAgent
​https://bugs.webkit.org/show_bug.cgi?id=53789

  • perform UserAgent override via InspectorInstrumentation
  • move adding extra request headers to InspectorResourceAgent
  • simplified things in InspectorState
  • inspector/Inspector.idl:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::disconnectFrontend): (WebCore::InspectorAgent::applyUserAgentOverride):
  • inspector/InspectorAgent.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::applyUserAgentOverrideImpl): (WebCore::InspectorInstrumentation::willSendRequestImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::applyUserAgentOverride):
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::setExtraHeaders): (WebCore::InspectorResourceAgent::willSendRequest):
  • inspector/InspectorResourceAgent.h:
  • inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState): (WebCore::InspectorState::restoreFromInspectorCookie): (WebCore::InspectorState::updateCookie): (WebCore::InspectorState::setValue): (WebCore::InspectorState::getBoolean): (WebCore::InspectorState::getString): (WebCore::InspectorState::getLong): (WebCore::InspectorState::getObject):
  • inspector/InspectorState.h: (WebCore::InspectorState::setObject):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::userAgent):
5:29 AM Changeset in webkit [77924] by pfeldman@chromium.org
  • 3 edits
    2 adds in trunk

2011-02-08 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: do not hide scope variables with command line api.
​https://bugs.webkit.org/show_bug.cgi?id=53497

  • inspector/console-api-on-call-frame-expected.txt: Added.
  • inspector/console-api-on-call-frame.html: Added.

2011-02-08 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: do not hide scope variables with command line api.
​https://bugs.webkit.org/show_bug.cgi?id=53497

Test: inspector/console-api-on-call-frame.html

  • inspector/InjectedScriptSource.js:
5:03 AM Changeset in webkit [77923] by demarchi@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

2011-02-08 Lucas De Marchi <​lucas.demarchi@profusion.mobi>

Unreviewed build fix.

[EFL] Fix when building with curl backend.

  • ewk/ewk_settings.cpp: (ewk_settings_proxy_uri_get):
4:57 AM Changeset in webkit [77922] by pfeldman@chromium.org
  • 11 edits
    1 delete in trunk

2011-02-07 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: ignore cache upon reload via Ctrl(Cmd)+Shift+R.
​https://bugs.webkit.org/show_bug.cgi?id=53914

  • http/tests/inspector/inspector-test2.js: (initialize_InspectorTest.InspectorTest.reloadPage):
  • inspector/audits-panel-functional.html:

2011-02-07 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: ignore cache upon reload via Ctrl(Cmd)+Shift+R.
​https://bugs.webkit.org/show_bug.cgi?id=53914

  • inspector/Inspector.idl:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::reloadPage):
  • inspector/InspectorAgent.h:
  • inspector/front-end/AuditsPanel.js: (WebInspector.AuditsPanel.prototype._reloadResources):
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onReload):
  • inspector/front-end/inspector.js: (WebInspector.documentKeyDown):
4:45 AM Changeset in webkit [77921] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-08 Mario Sanchez Prada <​msanchez@igalia.com>

Unreviewed, skipping test timing out on GTK 32-bit debug bot.

fast/loader/onload-willSendRequest-null-for-frame.html times out in GTK 32-bit debug bot
​https://bugs.webkit.org/show_bug.cgi?id=53992

  • platform/gtk/Skipped: Skipped test.
3:26 AM Changeset in webkit [77920] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-08 Mario Sanchez Prada <​msanchez@igalia.com>

Unreviewed, skipping flaky test on GTK debug bots.

fast/frames/sandboxed-iframe-storage.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=53991

  • platform/gtk/Skipped: Skipped test.
2:52 AM Changeset in webkit [77919] by Antti Koivisto
  • 3 edits in trunk/Source/WebCore

Skip over sibling selectors when collecting descendant selector hashes
​https://bugs.webkit.org/show_bug.cgi?id=53987

Reviewed by Cameron Zwarich.

Skip instead of bailing out. This will allow optimizing some sibling selector cases.

  • css/CSSStyleSelector.cpp:

(WebCore::RuleData::RuleData):
(WebCore::RuleData::collectIdentifierHashes):
(WebCore::RuleData::collectDescendantSelectorIdentifierHashes):

  • css/CSSStyleSelector.h:
2:50 AM Changeset in webkit [77918] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-08 Mario Sanchez Prada <​msanchez@igalia.com>

Unreviewed, skipping flaky test on GTK debug bots.

svg/custom/use-multiple-on-nested-disallowed-font.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=53989

  • platform/gtk/Skipped: Skipped test.
2:20 AM Changeset in webkit [77917] by Carlos Garcia Campos
  • 8 edits
    2 adds in trunk

2011-02-08 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] DRT's TextInputController is unimplemented on GTK
​https://bugs.webkit.org/show_bug.cgi?id=52997

  • platform/gtk/Skipped: Unskip several tests that pass now that we have TextInputController.

2011-02-08 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] DRT's TextInputController is unimplemented on GTK
​https://bugs.webkit.org/show_bug.cgi?id=52997

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::setComposition): (DumpRenderTreeSupportGtk::confirmComposition): (DumpRenderTreeSupportGtk::firstRectForCharacterRange): (DumpRenderTreeSupportGtk::selectedRange): New methods needed by TextInputController.
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

2011-02-08 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] DRT's TextInputController is unimplemented on GTK
​https://bugs.webkit.org/show_bug.cgi?id=52997

Initial implementation of TextInputController for GTK port.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewWindowObjectCleared):
  • DumpRenderTree/gtk/TextInputController.cpp: Added. (setMarkedTextCallback): (insertTextCallback): (unmarkTextCallback): (firstRectForCharacterRangeCallback): (selectedRangeCallback): (getClass): (makeTextInputController):
  • DumpRenderTree/gtk/TextInputController.h: Added.
  • GNUmakefile.am:
1:18 AM Changeset in webkit [77916] by mitz@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

LLVM Compiler build fix.

Reviewed by Maciej Stachowiak.

  • runtime/WriteBarrier.h:

(JSC::WriteBarrier::WriteBarrier):

12:49 AM Changeset in webkit [77915] by mjs@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-08 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r77866.
​http://trac.webkit.org/changeset/77866
​https://bugs.webkit.org/show_bug.cgi?id=53981

caused all WebKit2 inspector tests to crash (Requested by
othermaciej on #webkit).

  • UIProcess/WebInspectorProxy.cpp: (WebKit::WebInspectorProxy::didClose):
Note: See TracTimeline for information about the timeline view.