⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 12, 2011:

8:01 PM Changeset in webkit [78426] by ap@apple.com
  • 11 edits in trunk/Source/WebKit2

Reviewed by Anders Carlsson.

​https://bugs.webkit.org/show_bug.cgi?id=54335
<rdar://problem/8895141> Make window.print() work with WebKit2

  • Platform/CoreIPC/Connection.h: Corrected a typo in FIXME comment.
  • UIProcess/ChunkedUpdateDrawingAreaProxy.cpp: (WebKit::ChunkedUpdateDrawingAreaProxy::setPageIsVisible): (WebKit::ChunkedUpdateDrawingAreaProxy::update): (WebKit::ChunkedUpdateDrawingAreaProxy::sendSetSize):
  • UIProcess/TiledDrawingAreaProxy.cpp: (WebKit::TiledDrawingAreaProxy::sizeDidChange): (WebKit::TiledDrawingAreaProxy::setPageIsVisible): (WebKit::TiledDrawingAreaProxy::takeSnapshot): (WebKit::TiledDrawingAreaProxy::removeTile):
  • UIProcess/LayerBackedDrawingAreaProxy.cpp: (WebKit::LayerBackedDrawingAreaProxy::sizeDidChange): (WebKit::LayerBackedDrawingAreaProxy::setPageIsVisible): (WebKit::LayerBackedDrawingAreaProxy::update):
  • UIProcess/WebContext.cpp: (WebKit::WebContext::ensureWebProcess): (WebKit::WebContext::postMessageToInjectedBundle): Updated for send() -> deprecatedSend() rename.
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::WebPageProxy): Added a flag that's true while serving window.print(). (WebKit::WebPageProxy::printFrame): Set and unset m_isPerformingDOMPrintOperation. (WebKit::WebPageProxy::beginPrinting): Force message processing in web process when serving window.print(). (WebKit::WebPageProxy::endPrinting): Ditto. (WebKit::WebPageProxy::computePagesForPrinting): Ditto. (WebKit::WebPageProxy::drawRectToPDF): Ditto. (WebKit::WebPageProxy::drawPagesToPDF): Ditto.
  • UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::~WebProcessProxy): (WebKit::WebProcessProxy::sendMessage): (WebKit::WebProcessProxy::didFinishLaunching): When waiting for a web process to launch, store message flags, too. This is not practically important for DispatchMessageEvenWhenWaitingForSyncReply, but it's easier to store flags than to remember about this pitfall.
  • UIProcess/WebProcessProxy.h: (WebKit::WebProcessProxy::send): Added a flags argument, matching Connection::send(). (WebKit::WebProcessProxy::deprecatedSend): Renamed one of send() overloads, because it was conflicting with the other one after adding a flags argument. This matches a change previously made to CoreIPC::Connection.
4:18 PM Changeset in webkit [78425] by cmarrin@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-02-12 Chris Marrin <​cmarrin@apple.com>

Reviewed by Dan Bernstein.

Crash in RenderLayerCompositor::updateCompositingLayers when loading some sites
​https://bugs.webkit.org/show_bug.cgi?id=54345

Some sites flip between composited and non-comosited state while loading. When the timing is
right, when we flip out of compositing we will need to do a display while tossing all the
compositing layers. This causes us to reenter RenderLayerCompositor::computeCompositingRequirements()
while we are in the middle of tossing layers, which leads to a crash.

The solution is to defer the logic of exiting compositing mode until the DrawingArea is finished
doing its display, using a timer.

  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::DrawingAreaImpl): (WebKit::DrawingAreaImpl::setRootCompositingLayer): (WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode): (WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode): (WebKit::DrawingAreaImpl::exitAcceleratedCompositingModeSoon):
  • WebProcess/WebPage/DrawingAreaImpl.h:
3:31 PM Changeset in webkit [78424] by weinig@apple.com
  • 7 edits in trunk/Source/WebCore

WK2: Extra scrolling required when scrolling with a scroll wheel (Mighty Mouse)
<rdar://problem/8984760>

Reviewed by Dan Bernstein.

When going down the smooth scroll path, constrained scrolls (such as those from a
Mighty Mouse) were being correctly constrained at the ScrollView level, but the
duplicate values being stored by the animator were not being constrained correctly.

In order to implement the constraint at this level, more of the ScrollableArea's API
needed to be filled in for RenderLayer and RenderListBox.

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::scrollToOffsetWithoutAnimation): Call immediateScrollToPoint to stay
consistent and get the desired behavior.

(WebCore::ScrollAnimatorMac::adjustScrollXPositionIfNecessary):
(WebCore::ScrollAnimatorMac::adjustScrollYPositionIfNecessary):
(WebCore::ScrollAnimatorMac::adjustScrollPositionIfNecessary):
(WebCore::ScrollAnimatorMac::immediateScrollToPoint):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaX):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaY):
Ensure that the scroll animators view of the current scroll position is the
same as the scrollable areas by correctly clamping the value.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::contentsSize): Correct implementation
to use the scroll size, not the visible size.
(WebCore::RenderLayer::visibleHeight):
(WebCore::RenderLayer::visibleWidth):

  • rendering/RenderLayer.h:
  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::visibleHeight):
(WebCore::RenderListBox::visibleWidth):

  • rendering/RenderListBox.h:

Add implementations for visibleHeight/visibleWidth.

2:42 PM Changeset in webkit [78423] by kdecker@apple.com
  • 2 edits in trunk/Source/WebKit2

Reviewed by Dan Bernstein.

Follow up fix to:
​https://bugs.webkit.org/show_bug.cgi?id=54341 - optionally scale snapshots in document view coordinates

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::scaledSnapshotInDocumentCoordinates): Fixed the order of the scale and translate.
2:13 PM Changeset in webkit [78422] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

2011-02-12 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

crypto.getRandomValues should support all integer array types
​https://bugs.webkit.org/show_bug.cgi?id=54342

Test which types of arrays work with crypto.getRandomValues.

  • security/crypto-random-values-types-expected.txt: Added.
  • security/crypto-random-values-types.html: Added.

2011-02-12 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

crypto.getRandomValues should support all integer array types
​https://bugs.webkit.org/show_bug.cgi?id=54342

As discussed on whatwg, we should support all the integer array types.

Test: security/crypto-random-values-types.html

  • page/Crypto.cpp: (WebCore::Crypto::getRandomValues):
1:35 PM Changeset in webkit [78421] by abarth@webkit.org
  • 5 edits in trunk/Source

2011-02-12 Adam Barth <​abarth@webkit.org>

Reviewed by Mark Rowe.

Use /dev/urandom as the OSRandomSource on OS(DARWIN)
​https://bugs.webkit.org/show_bug.cgi?id=54279

I'm not sure it makes much of a difference whether we use arc4random or
/dev/urandom on Mac. However, there's some aesthetic benefit to using
the same underlying API on as many platforms as reasonable.

  • config.h:
  • wtf/OSRandomSource.cpp: (WTF::cryptographicallyRandomValuesFromOS):

2011-02-12 Adam Barth <​abarth@webkit.org>

Reviewed by Mark Rowe.

Use /dev/urandom as the OSRandomSource on OS(DARWIN)
​https://bugs.webkit.org/show_bug.cgi?id=54279

Update the ifdef. OS(UNIX) includes OS(DARWIN), so this change is
should be a NOP.

  • config.h:
1:10 PM Changeset in webkit [78420] by chang.shu@nokia.com
  • 2 edits in trunk/Tools

2011-02-12 Chang Shu <​cshu@webkit.org>

Unreviewed.

Update my own email addresses and IRC nickname.

  • Scripts/webkitpy/common/config/committers.py:
12:46 PM Changeset in webkit [78419] by zmo@google.com
  • 8 edits in trunk/Source

2011-02-11 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

[chromium] Allow turning off multisampling through web preference settings
​https://bugs.webkit.org/show_bug.cgi?id=54321

  • public/WebSettings.h: Add a flag for multisampling setting.
  • src/WebSettingsImpl.cpp: Ditto. (WebKit::WebSettingsImpl::setOpenGLMultisamplingEnabled):
  • src/WebSettingsImpl.h: Ditto.

2011-02-11 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

[chromium] Allow turning off multisampling through web preference settings
​https://bugs.webkit.org/show_bug.cgi?id=54321

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::create): Disable multisampling in WebGL if web reference says so.
  • page/Settings.cpp: Add a flag for multisampling preference. (WebCore::Settings::Settings): (WebCore::Settings::setOpenGLMultisamplingEnabled):
  • page/Settings.h: Ditto. (WebCore::Settings::openGLMultisamplingEnabled):
12:32 PM Changeset in webkit [78418] by kdecker@apple.com
  • 5 edits in trunk/Source/WebKit2

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=54341 - optionally scale snapshots in document view coordinates
<rdar://problem/8990069>


  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePageCreateScaledSnapshotInDocumentCoordinates): Added.
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h: Added above new function.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::scaledSnapshotInDocumentCoordinates): Added. (WebKit::WebPage::snapshotInDocumentCoordinates): Call scaledSnapshotInDocumentCoordinates with a scale of 1.
  • WebProcess/WebPage/WebPage.h: Added scaledSnapshotInDocumentCoordinates().
4:37 AM Changeset in webkit [78417] by rniwa@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-02-12 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

Deploy EditingStyle in applyBlockStyle and applyInlineStyle
​https://bugs.webkit.org/show_bug.cgi?id=53911

Deployed EditingStyle in ApplyStyleCommand::applyBlockStyle and ApplyStyleCommand::applyInlineStyle.
Extracted EditingStyle::extractAndRemoveTextDirection from applyInlineStyle.
Also added propertiesToInclude to the argument list of EditingStyle's constructor that takes Node*
so that splitAncestorsWithUnicodeBidi can call EditingStyle::textDirection to obtain the text direction.

No new tests are added since this is a refactoring.

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::doApply): Passes EditingStyle* to applyBlockStyle and applyInlineStyle. (WebCore::ApplyStyleCommand::applyBlockStyle): Takes EditingStyle*. (WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi): Changed the type of allowedDirection from int to WritingDirection. Uses EditingStyle's textDirection to obtain the writing direction. (WebCore::ApplyStyleCommand::applyInlineStyle): Takes EditingStyle*. (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Allows style to be null; exit early instead. (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): Asserts that style is not null. (WebCore::ApplyStyleCommand::removeInlineStyle): Allows style to be null.
  • editing/ApplyStyleCommand.h: Includes WritingDirection.h; prototype changes.
  • editing/EditingStyle.cpp: (WebCore::EditingStyle::EditingStyle): Added PropertiesToInclude to the argument. (WebCore::EditingStyle::init): Supports PropertiesToInclude. (WebCore::EditingStyle::extractAndRemoveTextDirection): Extracted from applyInlineStyle.
  • editing/EditingStyle.h: (WebCore::EditingStyle::create): Supports PropertiesToInclude.
3:56 AM Changeset in webkit [78416] by jochen@chromium.org
  • 13 edits
    2 adds in trunk

2011-02-12 Jochen Eisinger <​jochen@chromium.org>

Reviewed by Jeremy Orlow.

Implement IDBObjectStore::clear
​https://bugs.webkit.org/show_bug.cgi?id=54193

  • storage/indexeddb/objectstore-clear-expected.txt: Added.
  • storage/indexeddb/objectstore-clear.html: Added.

2011-02-12 Jochen Eisinger <​jochen@chromium.org>

Reviewed by Jeremy Orlow.

Implement IDBObjectStore::clear
​https://bugs.webkit.org/show_bug.cgi?id=54193

Test: storage/indexeddb/objectstore-clear.html

  • storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::clear):
  • storage/IDBObjectStore.h:
  • storage/IDBObjectStore.idl:
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::clear): (WebCore::doDelete): (WebCore::IDBObjectStoreBackendImpl::clearInternal):
  • storage/IDBObjectStoreBackendImpl.h:
  • storage/IDBObjectStoreBackendInterface.h:

2011-02-12 Jochen Eisinger <​jochen@chromium.org>

Reviewed by Jeremy Orlow.

Implement IDBObjectStore::clear
​https://bugs.webkit.org/show_bug.cgi?id=54193

  • src/IDBObjectStoreProxy.cpp: (WebCore::IDBObjectStoreProxy::clear):
  • src/IDBObjectStoreProxy.h:
  • src/WebIDBObjectStoreImpl.cpp: (WebKit::WebIDBObjectStoreImpl::clear):
  • src/WebIDBObjectStoreImpl.h:
2:13 AM Changeset in webkit [78415] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-12 Adam Barth <​abarth@webkit.org>

Another attempt to fix the EFL build. Looks like we're missing one
more file.

  • CMakeLists.txt:
2:01 AM Changeset in webkit [78414] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-12 Adam Barth <​abarth@webkit.org>

Attempt to fix the EFL build. Apparently the CMake build had no
concept of ArrayBuffers.

  • CMakeLists.txt:
1:39 AM Changeset in webkit [78413] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-12 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed build fix.

  • dom/Range.cpp: (WebCore::lengthOfContentsInNode): Replaced static const unsigned LengthOfContentsInNode. (WebCore::Range::processContents): (WebCore::Range::processContentsBetweenOffsets):
1:36 AM Changeset in webkit [78412] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-12 Adam Barth <​abarth@webkit.org>

CPP files belong in SOURCES not in HEADERS. There are more errors like
this for other disabled features, but I'm not fixing them in this
patch.

  • WebCore.pro:
1:29 AM Changeset in webkit [78411] by abarth@webkit.org
  • 5 edits in trunk/LayoutTests

2011-02-12 Adam Barth <​abarth@webkit.org>

Update test expectations on Windows to account for ArrayBuffers being
on by default.

  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
  • platform/win/fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer-expected.txt:
  • platform/win/http/tests/xmlhttprequest/send-array-buffer-expected.txt:
1:18 AM Changeset in webkit [78410] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-12 Adam Barth <​abarth@webkit.org>

Apparently lines in .pro files need to be \-terminated.

  • WebCore.pro:
1:10 AM Changeset in webkit [78409] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-02-11 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

Extract a function to process contents for one node from Range::processContents
​https://bugs.webkit.org/show_bug.cgi?id=54282

Extracted Range::processContentsBetweenOffsets, which process contents of a node
between two offsets. This function is used for the simple case where the start
and the end containers are of the same node, and to process start and end containers
in the complex case.

When the function takes a non-null fragment (simple case), it appends the processed
contents to the fragment; character data and processing instruction's contents are copied
between the offsets, and descendants are copied for node of other types (not node itself).

When the fragment is null (complex case), the function copies contents of character data,
processing instruction, and node of other types (including node itself).

No new tests are added since this is a refactoring.

  • dom/Range.cpp: (WebCore::highestAncestorUnderCommonRoot): Added. (WebCore::Range::processContents): Calls highestAncestorUnderCommonRoot and processContentsBetweenOffsets. (WebCore::Range::processContentsBetweenOffsets): Added.
  • dom/Range.h:
1:07 AM Changeset in webkit [78408] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-12 Adam Barth <​abarth@webkit.org>

Attempt to fix the Qt Windows build.

  • WebCore.pro:
12:24 AM Changeset in webkit [78407] by abarth@webkit.org
  • 54 edits
    3 deletes in trunk

2011-02-12 Adam Barth <​abarth@webkit.org>

Reviewed by Kenneth Russell.

Enable ArrayBuffers by default
​https://bugs.webkit.org/show_bug.cgi?id=54310

Export the required functions.

2011-02-12 Adam Barth <​abarth@webkit.org>

Reviewed by Kenneth Russell.

Enable ArrayBuffers by default
​https://bugs.webkit.org/show_bug.cgi?id=54310

As discussed on webkit-dev, ArrayBuffers are used by a bunch of
different APIs, implemented by Firefox, and appear to be stable.
Keeping them conditional is a large mantainance burden than it's worth.

  • DerivedSources.cpp:
  • WebCore.vcproj/WebCore.vcproj:
  • bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setWebGLEnabled):
  • bindings/js/JSArrayBufferCustom.cpp:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSDOMWindowCustom.cpp:
  • bindings/js/JSDataViewCustom.cpp:
  • bindings/js/JSFloat32ArrayCustom.cpp:
  • bindings/js/JSInt16ArrayCustom.cpp:
  • bindings/js/JSInt32ArrayCustom.cpp:
  • bindings/js/JSInt8ArrayCustom.cpp:
  • bindings/js/JSUint16ArrayCustom.cpp:
  • bindings/js/JSUint32ArrayCustom.cpp:
  • bindings/js/JSUint8ArrayCustom.cpp:
  • bindings/v8/custom/V8ArrayBufferCustom.cpp:
  • bindings/v8/custom/V8ArrayBufferViewCustom.h:
  • bindings/v8/custom/V8DataViewCustom.cpp:
  • bindings/v8/custom/V8Float32ArrayCustom.cpp:
  • bindings/v8/custom/V8Int16ArrayCustom.cpp:
  • bindings/v8/custom/V8Int32ArrayCustom.cpp:
  • bindings/v8/custom/V8Int8ArrayCustom.cpp:
  • bindings/v8/custom/V8Uint16ArrayCustom.cpp:
  • bindings/v8/custom/V8Uint32ArrayCustom.cpp:
  • bindings/v8/custom/V8Uint8ArrayCustom.cpp:
  • html/canvas/ArrayBuffer.cpp:
  • html/canvas/ArrayBuffer.idl:
  • html/canvas/ArrayBufferView.cpp:
  • html/canvas/ArrayBufferView.idl:
  • html/canvas/DataView.cpp:
  • html/canvas/DataView.idl:
  • html/canvas/Float32Array.cpp:
  • html/canvas/Float32Array.idl:
  • html/canvas/Int16Array.cpp:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.cpp:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.cpp:
  • html/canvas/Int8Array.idl:
  • html/canvas/Uint16Array.cpp:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.cpp:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.cpp:
  • html/canvas/Uint8Array.idl:
  • page/Crypto.cpp: (WebCore::Crypto::getRandomValues):
  • page/Crypto.h:
  • page/Crypto.idl:
  • page/DOMWindow.idl:
  • workers/WorkerContext.idl:

2011-02-12 Adam Barth <​abarth@webkit.org>

Reviewed by Kenneth Russell.

Enable ArrayBuffers by default
​https://bugs.webkit.org/show_bug.cgi?id=54310

Revert incorrect expectations from
​http://trac.webkit.org/changeset/78337. These results were cased by
ArrayBuffers not beign enabled on Windows previous to this patch.

  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/js/global-function-resolve-expected.txt: Removed.
  • platform/win/fast/js/var-declarations-shadowing-expected.txt: Removed.
  • platform/win/security: Removed.
  • platform/win/security/crypto-random-values-expected.txt: Removed.

Feb 11, 2011:

8:57 PM Changeset in webkit [78406] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-02-11 David Grogan <​dgrogan@chromium.org>

Reviewed by Jeremy Orlow.

indexeddb: add onBlocked to WebKit::WebIDBCallbacks
​https://bugs.webkit.org/show_bug.cgi?id=54329

  • public/WebIDBCallbacks.h: (WebKit::WebIDBCallbacks::onBlocked):
7:16 PM Changeset in webkit [78405] by andersca@apple.com
  • 9 edits in trunk/Source/WebKit2

2011-02-11 Anders Carlsson <​andersca@apple.com>

Reviewed by Maciej Stachowiak.

Can’t open local files on reload or navigation from the back/forward cache
​https://bugs.webkit.org/show_bug.cgi?id=54332
<rdar://problem/8903076>

  • UIProcess/WebInspectorProxy.cpp: (WebKit::WebInspectorProxy::isInspectorPage):
  • UIProcess/WebInspectorProxy.h: Check whether the given page is a web inspector page.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::initializeSandboxExtensionHandle): If this is a web inspector page, we don't want to make a sandbox extension.

(WebKit::WebPageProxy::reattachToWebProcessWithItem):
(WebKit::WebPageProxy::goForward):
(WebKit::WebPageProxy::goBack):
(WebKit::WebPageProxy::goToBackForwardItem):
Pass a sandbox extension along when sending the message.

  • UIProcess/WebPageProxy.h: Make initializeSandboxExtensionHandle a member function.
  • UIProcess/cf/WebPageProxyCF.cpp: (WebKit::WebPageProxy::restoreFromSessionStateData): Pass a sandbox extension along.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::goForward): (WebKit::WebPage::goBack): (WebKit::WebPage::goToBackForwardItem): Hand the sandbox extension to the sandbox extension tracker.

(WebKit::WebPage::restoreSessionAndNavigateToCurrentItem):
Pass the sandbox extension to goToBackForwardItem.

(WebKit::shouldReuseCommittedSandboxExtension):
New function that checks whether a committed sandbox extension should be re-used. We
do this for page reloads, as well as regular page navigations when both the committed
and provisional documents have file URLs.

(WebKit::WebPage::SandboxExtensionTracker::didStartProvisionalLoad):
Reuse the committed sandbox extension if necessary.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
7:09 PM Changeset in webkit [78404] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Fix Snow Leopard build.

  • PluginProcess/PluginProcess.cpp:

(WebKit::PluginProcess::didFailToSendSyncMessage):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::didFailToSendSyncMessage):

6:50 PM Changeset in webkit [78403] by yael.aharon@nokia.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed Qt webkit2 build fix after r78392.

  • WebProcess/WebProcess.h:
6:42 PM Changeset in webkit [78402] by dbates@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-11 Daniel Bates <​dbates@rim.com>

Reviewed by Geoffrey Garen.

Remove explicit disable ENABLE_ASSEMBLER_WX_EXCLUSIVE on non-iOS ports
​https://bugs.webkit.org/show_bug.cgi?id=54107


It is unnecessary to explicitly disable ENABLE_ASSEMBLER_WX_EXCLUSIVE
by the definition of ENABLE().

  • wtf/Platform.h:
6:05 PM Changeset in webkit [78401] by pkasting@chromium.org
  • 1 edit
    1 move
    1 delete in trunk/LayoutTests

Unreviewed, Chromium test expectations update.

Unify identical expectation files in chromium/ and update for r78383.

  • platform/chromium-mac/fast/url/port-expected.txt: Removed.
  • platform/chromium-win/fast/url/port-expected.txt: Removed.
  • platform/chromium/fast/url/port-expected.txt: Copied from platform/chromium-win/fast/url/port-expected.txt.
5:49 PM Changeset in webkit [78400] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-11 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

WebProcess hung communicating with the plug-in process
​https://bugs.webkit.org/show_bug.cgi?id=54328
<rdar://problem/8854075>

  • UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::createWebProcessConnection): Add the DispatchMessageEvenWhenWaitingForSyncReply message send flag when sending the PluginProcess::CreateWebProcessConnection message, since the plug-in process can be busy waiting for a sync reply from the web process.
5:45 PM Changeset in webkit [78399] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-02-11 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Incoming synchronous messages should always be processed regardless of connection waiting for a reply
​https://bugs.webkit.org/show_bug.cgi?id=54326

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::SyncMessageState::getOrCreate): Assert that the map has a non-null SyncMessageState object.

(CoreIPC::Connection::SyncMessageState::SyncMessageState):
Initialize m_waitForSyncReplyCount.

(CoreIPC::Connection::SyncMessageState::beginWaitForSyncReply):
Increment m_waitForSyncReplyCount.

(CoreIPC::Connection::SyncMessageState::endWaitForSyncReply):
Decrement m_waitForSyncReplyCount. If it's 0, enqueue any incoming sync messages.

(CoreIPC::Connection::SyncMessageState::processIncomingMessage):
If this is a message that needs to be dispatched, add it to the queue and wake up the client run loop.

(CoreIPC::Connection::SyncMessageState::dispatchMessages):
Go through the queue of incoming messages and dispatch them.

(CoreIPC::Connection::sendSyncMessage):
call beginWaitForSyncReply/endWaitForSyncReply.

(CoreIPC::Connection::waitForSyncReply):
Dispatch messages.

(CoreIPC::Connection::processIncomingMessage):
Call SyncMessageState::processIncomingMessage.

(CoreIPC::Connection::enqueueIncomingMessage):
Add helper function for enqueuing an incoming message.

  • Platform/CoreIPC/Connection.h: (CoreIPC::Connection::Message::destinationID):
5:42 PM Changeset in webkit [78398] by dpranke@chromium.org
  • 7 edits in trunk/Tools

2011-02-11 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Tony Chang.

This patch adds to NRWT most of the support needed to run the new
message-based workers in separate threads or processes. The code
isn't fully complete yet because we don't support cancel() or
is_alive().

​https://bugs.webkit.org/show_bug.cgi?id=54070

  • Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
  • Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/mock_drt.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
5:36 PM Changeset in webkit [78397] by weinig@apple.com
  • 3 edits in trunk/Source/WebKit2

WebKit2: Going to Ars Technica crashes WebProcess in WebCore::ResourceRequestBase::url() const + 9
<rdar://problem/8978832>

Reviewed by Maciej Stachowiak.

Speculative fix for crash accessing a bad ResourceRequest in policy
client code. Remove early returns from dispatchDecidePolicyForMIMEType
and dispatchDecidePolicyForNavigationAction that are not present in the WebKit1
equivalent code. This should be safe, now that the IPC calls are synchronous.

Also removes some invalid assertions in WebFrameProxy that were getting hit. It is okay
for the url to empty.

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::didReceiveServerRedirectForProvisionalLoad):
(WebKit::WebFrameProxy::didFailProvisionalLoad):
(WebKit::WebFrameProxy::didFailLoad):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

5:34 PM Changeset in webkit [78396] by yael.aharon@nokia.com
  • 3 edits
    19 adds in trunk

2011-02-11 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Darin Adler.

Background image positioning on RTL text
​https://bugs.webkit.org/show_bug.cgi?id=32862

  • fast/inline/inline-box-background-long-image.html: Added.
  • fast/inline/inline-box-background-repeat-x.html: Added.
  • fast/inline/inline-box-background-repeat-y.html: Added.
  • fast/inline/inline-box-background.html: Added.
  • fast/inline/resources: Added.
  • fast/inline/resources/checker.png: Added.
  • fast/inline/resources/gradient.png: Added.
  • platform/mac/fast/inline/inline-box-background-expected.checksum: Added.
  • platform/mac/fast/inline/inline-box-background-expected.png: Added.
  • platform/mac/fast/inline/inline-box-background-expected.txt: Added.
  • platform/mac/fast/inline/inline-box-background-long-image-expected.checksum: Added.
  • platform/mac/fast/inline/inline-box-background-long-image-expected.png: Added.
  • platform/mac/fast/inline/inline-box-background-long-image-expected.txt: Added.
  • platform/mac/fast/inline/inline-box-background-repeat-x-expected.checksum: Added.
  • platform/mac/fast/inline/inline-box-background-repeat-x-expected.png: Added.
  • platform/mac/fast/inline/inline-box-background-repeat-x-expected.txt: Added.
  • platform/mac/fast/inline/inline-box-background-repeat-y-expected.checksum: Added.
  • platform/mac/fast/inline/inline-box-background-repeat-y-expected.png: Added.
  • platform/mac/fast/inline/inline-box-background-repeat-y-expected.txt: Added.

2011-02-11 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Darin Adler.

Background image positioning on RTL text
​https://bugs.webkit.org/show_bug.cgi?id=32862

When the style of InlineFlowBox is right-to-left, the strips should be rearranged in reverse order.

Tests: fast/inline/inline-box-background-long-image.html

fast/inline/inline-box-background-repeat-x.html
fast/inline/inline-box-background-repeat-y.html
fast/inline/inline-box-background.html

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintFillLayer):
5:17 PM Changeset in webkit [78395] by commit-queue@webkit.org
  • 9 edits in trunk

2011-02-11 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r78044.
​http://trac.webkit.org/changeset/78044
​https://bugs.webkit.org/show_bug.cgi?id=54318

Broke Safari extensions (Requested by eseidel on #webkit).

  • fast/url/host-expected.txt:
  • fast/url/ipv4-expected.txt:
  • fast/url/ipv6-expected.txt:
  • fast/url/relative-expected.txt:
  • fast/url/relative-unix-expected.txt:
  • fast/url/standard-url-expected.txt:

2011-02-11 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r78044.
​http://trac.webkit.org/changeset/78044
​https://bugs.webkit.org/show_bug.cgi?id=54318

Broke Safari extensions (Requested by eseidel on #webkit).

  • platform/KURL.cpp: (WebCore::KURL::parse):
5:07 PM Changeset in webkit [78394] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

Fix for <rdar://problem/8976456> Scrollbars for overflow
areas never appear for WKScrollbarPainter scrollers

Reviewed by Sam Weinig.

Call ScrollableArea::didAddVerticalScrollbar() and
ScrollableArea::willRemoveVerticalScrollbar() when
appropriate for RenderLayers.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::setHasHorizontalScrollbar):
(WebCore::RenderLayer::setHasVerticalScrollbar):

4:57 PM Changeset in webkit [78393] by pkasting@chromium.org
  • 3 edits
    2 moves in trunk/LayoutTests

Unreviewed, Chromium test expectations update.

Also moved a test that's not Linux-specific and other platforms seem to
pass from chromium-linux/ to chromium/.

  • platform/chromium-linux/fast/text/international/complex-text-rectangle-expected.txt: Removed.
  • platform/chromium-linux/fast/text/international/complex-text-rectangle.html: Removed.
  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
  • platform/chromium/fast/text/international/complex-text-rectangle-expected.txt: Copied from platform/chromium-linux/fast/text/international/complex-text-rectangle-expected.txt.
  • platform/chromium/fast/text/international/complex-text-rectangle.html: Copied from platform/chromium-linux/fast/text/international/complex-text-rectangle.html.
  • platform/chromium/test_expectations.txt:
4:24 PM Changeset in webkit [78392] by ap@apple.com
  • 7 edits in trunk/Source/WebKit2

Reviewed by Darin Adler and Anders Carlsson.

​https://bugs.webkit.org/show_bug.cgi?id=53593
<rdar://problem/8948380> Crash beneath HistoryController::recursiveSetProvisionalItem in web
process (preceded by assertion failure) if UI process exits while
Messages::WebPage::RestoreSessionAndNavigateToCurrentItem is being handled

Can't test exiting the UI process.

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::sendSyncMessage):
  • Platform/CoreIPC/Connection.h: (CoreIPC::Connection::Client::didFailToSendSyncMessage): Notify connection client when the connection fails to send a sync message.
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::didFailToSendSyncMessage):
  • WebProcess/WebProcess.h: Quit the web process immediately if it tried to send a sync message to a dead UI process. It never needs to continue and handle an unexpected null "reply".
  • PluginProcess/PluginProcess.cpp: (WebKit::PluginProcess::didFailToSendSyncMessage):
  • PluginProcess/PluginProcess.h: Ditto. There is no need for a plug-in to keep running even briefly if it couldn't get a reply to a sync message.
4:17 PM Changeset in webkit [78391] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-11 Mihai Parparita <​mihaip@chromium.org>

Unrevied chromium-gpu expectations update. Update expectations for
chromium-gpu-mac (it often has image diffs only, since it can use the
text results from the mac port).

  • platform/chromium/test_expectations.txt:
4:16 PM Changeset in webkit [78390] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Not reviewed.

Randomly touch some build files in the hopes of fixing the Qt build.

4:13 PM Changeset in webkit [78389] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Garbage collection timer cycles forever, even when nothing is happening
​https://bugs.webkit.org/show_bug.cgi?id=54320

Reviewed by Sam Weinig.

(Rolling back in r78386 with the build fixed.)

  • runtime/GCActivityCallbackCF.cpp:

(JSC::DefaultGCActivityCallbackPlatformData::trigger): Be sure to make
our timer inert after forcing a GC, to avoid GC'ing repeatedly.

4:10 PM Changeset in webkit [78388] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-11 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update. Mark tests that fail only on
Snow Leopard, so that we can begin to have green Snow Leopard bots.

  • platform/chromium/test_expectations.txt:
4:06 PM Changeset in webkit [78387] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Not reviewed.

Used svn merge -r78386:78385 to roll out r78386 because it broke the build.

  • runtime/GCActivityCallbackCF.cpp:

(JSC::DefaultGCActivityCallbackPlatformData::trigger):

3:58 PM Changeset in webkit [78386] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-11 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.

Garbage collection timer cycles forever, even when nothing is happening
​https://bugs.webkit.org/show_bug.cgi?id=54320

  • runtime/GCActivityCallbackCF.cpp: (JSC::DefaultGCActivityCallbackPlatformData::trigger): Be sure to make our timer inert after forcing a GC, to avoid GC'ing repeatedly.
3:49 PM Changeset in webkit [78385] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-02-11 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Add a way to send async messages that can't get out of order with sync ones
​https://bugs.webkit.org/show_bug.cgi?id=54319
<rdar://problem/8894844>

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::sendMessage): sendMessage now takes a messageSendFlags. Update the messageID if the messageSendFlags contain DispatchMessageEvenWhenWaitingForSyncReply.

(CoreIPC::Connection::waitForSyncReply):
Process asynchronous messages as well.

(CoreIPC::Connection::processIncomingMessage):
Check if a message should be dispatched even when we're waiting for a
synchronous reply.

  • Platform/CoreIPC/Connection.h: (CoreIPC::Connection::send): Send now takes a messageSendFlags parameter.
  • Platform/CoreIPC/MessageID.h: (CoreIPC::MessageID::messageIDWithAddedFlags): Return a new MessageID object with the given flags added.

(CoreIPC::MessageID::shouldDispatchMessageWhenWaitingForSyncReply):
Add getter.

3:48 PM Changeset in webkit [78384] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Try to fix the Windows build: added an exported symbol.

3:47 PM Changeset in webkit [78383] by eric@webkit.org
  • 12 edits in trunk

2011-02-11 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

KURL should remove default port numbers when cannonicalizing urls (to match every other browser)
​https://bugs.webkit.org/show_bug.cgi?id=54090

Added a new test to show that we are intentionally removing
a colon after a host name. ​http://foo.com:/ -> ​http://foo.com/

  • fast/url/port-expected.txt:
  • fast/url/relative-unix-expected.txt:
  • fast/url/segments-expected.txt:
  • fast/url/segments-from-data-url-expected.txt:
  • fast/url/standard-url-expected.txt:

2011-02-11 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

KURL should remove default port numbers when cannonicalizing urls (to match every other browser)
​https://bugs.webkit.org/show_bug.cgi?id=54090

  • platform/KURL.cpp: (WebCore::isDefaultPortForScheme): (WebCore::KURL::parse):
3:31 PM Changeset in webkit [78382] by ggaren@apple.com
  • 18 edits
    1 delete in trunk/Source

2011-02-11 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

A little more encapsulation for the heap: Removed CollectorHeapIterator
​https://bugs.webkit.org/show_bug.cgi?id=54298


CollectorHeapIterator is a God object that knows the internals of each
of the pieces of the heap. This undermines the encapsulation I'm trying
to achieve by splitting concepts into different classes.


As an alternative, I've given each class a forEach iteration function,
which takes a functor as an argument. Now, each class just needs to
know how to iterate the things it knows about.

  • debugger/Debugger.cpp: (JSC::Recompiler::Recompiler): (JSC::Recompiler::~Recompiler): (JSC::Recompiler::operator()): (JSC::Debugger::recompileAllJSFunctions): Updated to use forEach interface instead of an iterator.
  • runtime/CollectorHeapIterator.h: Removed.
  • runtime/Heap.cpp: (JSC::TypeCounter::TypeCounter): (JSC::TypeCounter::typeName): (JSC::TypeCounter::operator()): (JSC::TypeCounter::take): (JSC::Heap::protectedObjectTypeCounts): (JSC::Heap::objectTypeCounts): Added forEach and removed iterator.
  • runtime/Heap.h: (JSC::Heap::forEach):
  • runtime/JSGlobalData.cpp: (JSC::Recompiler::operator()): (JSC::JSGlobalData::recompileAllJSFunctions):
  • runtime/MarkedBlock.h: (JSC::MarkedBlock::forEach): Added forEach. Removed friend declaration for CollectorHeapIterator. Now, we can make all our data private and change it without breaking any other classes.
  • runtime/MarkedSpace.cpp:
  • runtime/MarkedSpace.h: (JSC::MarkedSpace::forEach): Added forEach and removed iterator.

2011-02-11 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

A little more encapsulation for the heap: Removed CollectorHeapIterator
​https://bugs.webkit.org/show_bug.cgi?id=54298

  • WebCoreStatistics.cpp: (WebCoreStatistics::javaScriptProtectedObjectTypeCounts):

2011-02-11 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

A little more encapsulation for the heap: Removed CollectorHeapIterator
​https://bugs.webkit.org/show_bug.cgi?id=54298

  • Misc/WebCoreStatistics.mm: (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]): (+[WebCoreStatistics javaScriptObjectTypeCounts]): Updated for new typedef.
3:16 PM Changeset in webkit [78381] by weinig@apple.com
  • 5 edits in trunk/Source/WebKit2

Crash with dynamic popup menu use
<rdar://problem/8716952>

Reviewed by Anders Carlsson.

Invalidate popup menus when forcing them closed, since they might still be
in their tracking loop.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showPopupMenu):
(WebKit::WebPageProxy::hidePopupMenu):

  • UIProcess/WebPopupMenuProxy.h:

(WebKit::WebPopupMenuProxy::invalidate):

  • UIProcess/mac/WebPopupMenuProxyMac.mm:

(WebKit::WebPopupMenuProxyMac::showPopupMenu):

  • UIProcess/win/WebPopupMenuProxyWin.cpp:

(WebKit::WebPopupMenuProxyWin::showPopupMenu):
(WebKit::WebPopupMenuProxyWin::setFocusedIndex):

3:13 PM Changeset in webkit [78380] by inferno@chromium.org
  • 2 deletes in branches/chromium/597/LayoutTests/fast/canvas/webgl

remove accidently added .orig files

3:12 PM Changeset in webkit [78379] by inferno@chromium.org
  • 5 edits
    2 adds in branches/chromium/597

Merge 77956, crbug 71717

3:09 PM Changeset in webkit [78378] by inferno@chromium.org
  • 6 edits in branches/chromium/597/WebCore

Revert 78366 - Revert 78101 - Merge r76728, crbug 68263

Review URL: ​http://codereview.chromium.org/6508005

3:05 PM Changeset in webkit [78377] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-11 Mike Reed <​reed@google.com>

Reviewed by James Robinson.

Need makeContextCurrent() called in prepareForSoftwareDraw(), in the case that skia's backend
is the gpu. This matches the pattern in GraphicsContext3DOpenGL.cpp

No new tests. All existing canvas layouttests exercise this code path

  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::prepareForSoftwareDraw):
2:56 PM Changeset in webkit [78376] by inferno@chromium.org
  • 4 edits in branches/chromium/597/WebCore

Revert 78354 - Revert 78236 - Merge r76205, crbug 54262
Review URL: ​http://codereview.chromium.org/6500005

Review URL: ​http://codereview.chromium.org/6510003

2:56 PM Changeset in webkit [78375] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Actually initialize m_syncMessageState.

Reviewed by Adam Roben.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::Connection):

2:46 PM Changeset in webkit [78374] by mihaip@chromium.org
  • 3 edits in trunk/LayoutTests

2011-02-11 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Darin Adler.

compositing/reflections/reflection-opacity.html has a JS exception
​https://bugs.webkit.org/show_bug.cgi?id=54314

The JS code that the test was running was producing an error, and in
any case it didn't seem to be doing anything, since we don't define a
"moved" class (copy-and-paste error?).

  • compositing/reflections/reflection-opacity.html:
  • platform/mac/compositing/reflections/reflection-opacity-expected.txt:
2:45 PM Changeset in webkit [78373] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-11 Mihai Parparita <​mihaip@chromium.org>

Unrevied chromium-gpu expectations update. Remove failing expectations
for tests that now pass on the chromium-gpu-win bot.

  • platform/chromium/test_expectations.txt:
2:38 PM Changeset in webkit [78372] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-02-11 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam Roben.

Move the binary semaphore into SyncMessageState
​https://bugs.webkit.org/show_bug.cgi?id=54311

With this change, all connections that belong to the same run loop will use same binary semaphore.
This is in preparation for making any connection be able to wakeup the client run loop.

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::SyncMessageState::wakeUpClientRunLoop): (CoreIPC::Connection::SyncMessageState::wait): (CoreIPC::Connection::waitForSyncReply): (CoreIPC::Connection::processIncomingMessage): (CoreIPC::Connection::connectionDidClose):
  • Platform/CoreIPC/Connection.h:
2:26 PM Changeset in webkit [78371] by inferno@chromium.org
  • 4 edits
    2 deletes in branches/chromium/597

Revert 78166 - Merge r77114

Review URL: ​http://codereview.chromium.org/6508002

2:21 PM Changeset in webkit [78370] by Martin Robinson
  • 2 edits
    5 deletes in trunk/LayoutTests

2011-02-11 Martin Robinson <​mrobinson@igalia.com>

Explicitly skip webarchive tests on GTK+, because we do not
support them. Remove all GTK+-specific webarchive expected results.

  • platform/gtk/Skipped: Explicitly skip all webarchive tests.
  • platform/gtk/http/tests/webarchive/cross-origin-stylesheet-crash-expected.txt: Removed.
  • platform/gtk/http/tests/webarchive/test-css-url-encoding-expected.txt: Removed.
  • platform/gtk/http/tests/webarchive/test-css-url-encoding-shift-jis-expected.txt: Removed.
  • platform/gtk/http/tests/webarchive/test-css-url-encoding-utf-8-expected.txt: Removed.
  • platform/gtk/http/tests/webarchive/test-preload-resources-expected.txt: Removed.
2:14 PM Changeset in webkit [78369] by Martin Robinson
  • 2 edits
    150 adds in trunk/LayoutTests

2011-02-11 Martin Robinson <​mrobinson@igalia.com>

Add the next batch of GTK+ SVG test results.

  • platform/gtk/Skipped: Unskip tests which now have results.
2:03 PM Changeset in webkit [78368] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-02-11 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam Roben.

Add a SyncMessageState class to CoreIPC::Connection
​https://bugs.webkit.org/show_bug.cgi?id=54309

SyncMessageState objects are shared between all connections scheduled on
a given run loop. It will be used to keep track of state when waiting
for replies for a synchronous message.

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::SyncMessageState::syncMessageStateMap): (CoreIPC::Connection::SyncMessageState::syncMessageStateMapMutex): Add a global RunLoop -> SyncMessageState map and a mutex for locking.

(CoreIPC::Connection::SyncMessageState::getOrCreate):
Look in the map for an existing SyncMessageState object and create a new
one if none is found.

(CoreIPC::Connection::SyncMessageState::SyncMessageState):
Initialize m_runLoop.

(CoreIPC::Connection::SyncMessageState::~SyncMessageState):
Remove the object from the map.

2:03 PM Changeset in webkit [78367] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-11 Adam Klein <​adamk@chromium.org>

Reviewed by Darin Adler.

Check for empty scheme before accessing URLSchemeMaps in SchemeRegistry
​https://bugs.webkit.org/show_bug.cgi?id=54304

This avoids potential crashes in HashMap, as WTF's StringHash doesn't
accept empty Strings.

  • platform/SchemeRegistry.cpp: (WebCore::SchemeRegistry::shouldTreatURLSchemeAsNoAccess): (WebCore::SchemeRegistry::shouldTreatURLSchemeAsSecure): (WebCore::SchemeRegistry::shouldLoadURLSchemeAsEmptyDocument):
1:56 PM Changeset in webkit [78366] by inferno@chromium.org
  • 6 edits
    2 deletes in branches/chromium/597

Revert 78101 - Merge r76728, crbug 68263

Review URL: ​http://codereview.chromium.org/6474050

1:51 PM Changeset in webkit [78365] by mihaip@chromium.org
  • 4 edits
    3 adds in trunk/LayoutTests

2011-02-11 Mihai Parparita <​mihaip@chromium.org>

Unreviewed chromium-gpu expectations update. Add more fine-grained
expectations for compositing on Windows (instead of the whole directory
being marked PASS FAIL). Also replace all FAIL GPU expectations with
more specific ones (e.g. TEXT or IMAGE+TEXT).

  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-animated-expected.checksum:
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-animated-expected.png:
  • platform/chromium-gpu/compositing/iframes/nested-iframe-scrolling-expected.checksum: Added.
  • platform/chromium-gpu/compositing/iframes/nested-iframe-scrolling-expected.png: Added.
  • platform/chromium/test_expectations.txt:
1:41 PM Changeset in webkit [78364] by jberlin@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

plugins/invalidate_rect.html failing on Windows
​https://bugs.webkit.org/show_bug.cgi?id=54122

This test was fixed on Windows in ​http://trac.webkit.org/changeset/78359. Remove the failing
expected results. Unreviewed.

  • platform/win/plugins/invalidate_rect-expected.txt: Removed.
1:39 PM Changeset in webkit [78363] by enrica@apple.com
  • 2 edits in trunk/Source/WebKit2

crashes in WebProcess at WebCore::Range::startPosition const + 16
​https://bugs.webkit.org/show_bug.cgi?id=54294
<rdar://problem/8982710>

Reviewed by Darin Adler.

I don't have a repro case for this bugs, but the side-by-side
comparison of the IME support implementation in WebKit and WebKi2
shows a missing null check on a Range that could very well explain
this crash.
I tried running platform/mac/editing/input tests with a version of WebKit
without the null check and I can reproduce a crash with the same signature.
These tests are not yet enabled for WebKit2.

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::firstRectForCharacterRange):

1:39 PM Changeset in webkit [78362] by commit-queue@webkit.org
  • 22 edits
    11 adds in trunk

2011-02-11 Adam Klein <​adamk@chromium.org>

Reviewed by Darin Fisher.

[fileapi] Add support for filesystem: URI handling
​https://bugs.webkit.org/show_bug.cgi?id=53529

Tests for filesystem: URIs, testing both their security origin
properties and the existence of the Entry.toURI method.

  • fast/filesystem/directory-entry-to-uri-expected.txt: Added.
  • fast/filesystem/directory-entry-to-uri.html: Added.
  • fast/filesystem/file-entry-to-uri-expected.txt: Added.
  • fast/filesystem/file-entry-to-uri.html: Added.
  • fast/filesystem/filesystem-uri-origin-expected.txt: Added.
  • fast/filesystem/filesystem-uri-origin.html: Added.
  • fast/filesystem/resources/directory-entry-to-uri.js: Added. (errorCallback): (entryToURI): (createTestDirectory): ():
  • fast/filesystem/resources/file-entry-to-uri.js: Added. (errorCallback): (entryToURI): (createTestFile): ():
  • http/tests/security/filesystem-iframe-from-remote-expected.txt: Added.
  • http/tests/security/filesystem-iframe-from-remote.html: Added.
  • http/tests/security/resources/create-filesystem-file.html: Added.

2011-02-11 Adam Klein <​adamk@chromium.org>

Reviewed by Darin Fisher.

[fileapi] Add support for filesystem: URI handling
​https://bugs.webkit.org/show_bug.cgi?id=53529

There are two major parts to this patch: one is to add an
implementation of Entry.toURI to the FileSystem API.
The other is to implement security origin checking for this
new scheme.

All changes are guarded by the FILE_SYSTEM feature. An accompanying
Chromium change, to support loading of filesystem: URIs, has recently
been submitted as Chromium r74082.

Spec:

​http://dev.w3.org/2009/dap/file-system/file-dir-sys.html#methods-2

Proposed URI format, and discussion of security origin issues:

​http://lists.w3.org/Archives/Public/public-webapps/2011JanMar/0218.html

Tests: fast/filesystem/directory-entry-to-uri.html

fast/filesystem/file-entry-to-uri.html
fast/filesystem/filesystem-uri-origin.html
http/tests/security/filesystem-iframe-from-remote.html

  • fileapi/Entry.cpp: (WebCore::Entry::toURI):
  • fileapi/Entry.h:
  • fileapi/Entry.idl:
  • Added toURI method to the IDL, omitting the MIME type argument specified in the spec as it will soon be removed.
  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::SecurityOrigin):
  • crack the filesystem: URI to get at the origin of the site (WebCore::SecurityOrigin::canDisplay):
  • canDisplay for filesystem: URIs is equivalent to canRequest
  • platform/AsyncFileSystem.cpp: (WebCore::AsyncFileSystem::create): (WebCore::AsyncFileSystem::openFileSystem):
  • platform/AsyncFileSystem.h: (WebCore::AsyncFileSystem::type):
  • Exposed filesystem type to allow toURI to use it as part of the path. (WebCore::AsyncFileSystem::AsyncFileSystem):
  • platform/SchemeRegistry.cpp: (WebCore::canDisplayOnlyIfCanRequestSchemes): (WebCore::SchemeRegistry::canDisplayOnlyIfCanRequest): (WebCore::SchemeRegistry::registerAsCanDisplayOnlyIfCanRequest):
  • Generalized canDisplayOnlyIfCanRequest as it applies to both filesystem: and blob: URIs.
  • platform/SchemeRegistry.h:

2011-02-11 Adam Klein <​adamk@chromium.org>

Reviewed by Darin Fisher.

[fileapi] Add support for filesystem: URI handling
​https://bugs.webkit.org/show_bug.cgi?id=53529

Changes to Chromium WebKit API required to expose
the FileSystem type to WebCore's fileapi code, since the
type is part of the filesystem URI.

  • src/AsyncFileSystemChromium.cpp: (WebCore::AsyncFileSystemChromium::AsyncFileSystemChromium):
  • src/AsyncFileSystemChromium.h: (WebCore::AsyncFileSystemChromium::create):
  • src/LocalFileSystemChromium.cpp: (WebCore::LocalFileSystem::readFileSystem): (WebCore::LocalFileSystem::requestFileSystem):
  • src/WebFileSystemCallbacksImpl.cpp: (WebKit::WebFileSystemCallbacksImpl::WebFileSystemCallbacksImpl): (WebKit::WebFileSystemCallbacksImpl::didOpenFileSystem):
  • src/WebFileSystemCallbacksImpl.h:
  • src/WorkerAsyncFileSystemChromium.cpp: (WebCore::WorkerAsyncFileSystemChromium::WorkerAsyncFileSystemChromium):
  • src/WorkerAsyncFileSystemChromium.h: (WebCore::WorkerAsyncFileSystemChromium::create):
1:21 PM Changeset in webkit [78361] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

Fix for <rdar://problem/8961061> CrashTracer: [USER]
1 crash at com.apple.WebCore:
-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:] + 62

Reviewed by Darin Adler.

Must check for null _animator.

  • platform/mac/ScrollAnimatorMac.mm:

(-[ScrollbarPainterControllerDelegate scrollAnimatorDestroyed]):
(-[ScrollbarPainterControllerDelegate contentAreaRectForScrollerImpPair:]):
(-[ScrollbarPainterControllerDelegate inLiveResizeForScrollerImpPair:]):
(-[ScrollbarPainterControllerDelegate mouseLocationInContentAreaForScrollerImpPair:]):
(-[ScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]):
(-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]):
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):

12:52 PM Changeset in webkit [78360] by crogers@google.com
  • 5 edits in trunk/Source/WebCore

2011-02-11 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

Throw exception when AudioContext's createBuffer() fails to properly decode audio file data
​https://bugs.webkit.org/show_bug.cgi?id=54158

No new tests since audio API is not yet implemented.

  • bindings/js/JSAudioContextCustom.cpp: (WebCore::JSAudioContextConstructor::constructJSAudioContext): (WebCore::JSAudioContext::createBuffer):
  • bindings/v8/custom/V8AudioContextCustom.cpp: (WebCore::V8AudioContext::createBufferCallback):
  • platform/audio/chromium/AudioBusChromium.cpp: (WebCore::createBusFromInMemoryAudioFile):
  • webaudio/AudioContext.idl:
12:41 PM Changeset in webkit [78359] by commit-queue@webkit.org
  • 6 edits in trunk

2011-02-11 Sailesh Agrawal <​sail@chromium.org>

Reviewed by Kenneth Russell.

plugins/invalidate_rect.html fails on chromium-mac
​https://bugs.webkit.org/show_bug.cgi?id=54051

invalidate_rect.html should now pass on Windows. Removing skip.

  • platform/chromium/test_expectations.txt:

2011-02-11 Sailesh Agrawal <​sail@chromium.org>

Reviewed by Kenneth Russell.

plugins/invalidate_rect.html fails on chromium-mac
​https://bugs.webkit.org/show_bug.cgi?id=54051

This change fixes the invalidate_rect.html test failure on Windows.

There were two problems. First, the test specified that the plugin was window less by doing <embed ... windowedPlugin="false"></embed>. The windowedPlugin parameter was never being read by the plugin. Fix was to simply set the NPPVpluginWindowBool variable based on the parameter.

The second problem was that the plugin never handled paint events on Windows. Fix was to simply copy the Mac code to handle paint events.

This change also updates the build path in chromium_win.py to use the new Source directory.

  • DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: (invalidateRect):
  • DumpRenderTree/TestNetscapePlugIn/main.cpp: (NPP_New): (handleEventWin): (NPP_HandleEvent):
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
12:24 PM Changeset in webkit [78358] by Martin Robinson
  • 2 edits
    150 adds in trunk/LayoutTests

2011-02-11 Martin Robinson <​mrobinson@igalia.com>

Add another batch of GTK+ SVG test results.

  • platform/gtk/Skipped: Unskip tests which now have results.
12:19 PM Changeset in webkit [78357] by Martin Robinson
  • 2 edits
    148 adds in trunk/LayoutTests

2011-02-11 Martin Robinson <​mrobinson@igalia.com>

Add the next batch of GTK+ SVG test results.

  • platform/gtk/Skipped: Unskip tests which now have results.
12:10 PM Changeset in webkit [78356] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-11 Mike Reed <​reed@google.com>

Reviewed by James Robinson.

Fix toDataURL() to use device->readPixels() if need be, rather than always dereferencing
the address returned by getPixels() (as the device may not be backed by a CPU bitmap)
​https://bugs.webkit.org/show_bug.cgi?id=54224

No new tests. Existing canvas tests exercise this...
fast/canvas/script-tests/canvas-createPattern-fillRect-shadow.html

  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::toDataURL):
11:53 AM Changeset in webkit [78355] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-02-11 Andrew Wason <​rectalogic@rectalogic.com>

Reviewed by David Levin.

Files missing ENABLE_VIDEO #ifdef
​https://bugs.webkit.org/show_bug.cgi?id=53390

No new tests.

  • html/canvas/WebGLRenderingContext.cpp:
  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebGLRenderingContext.idl: Wrap methods and declarations that use HTMLVideoElement with #if ENABLE(VIDEO).
11:44 AM Changeset in webkit [78354] by inferno@chromium.org
  • 5 edits in branches/chromium/597/WebCore

Revert 78236 - Merge r76205, crbug 54262
Review URL: ​http://codereview.chromium.org/6500005

11:41 AM Changeset in webkit [78353] by Martin Robinson
  • 2 edits
    142 adds in trunk/LayoutTests

2011-02-11 Martin Robinson <​mrobinson@igalia.com>

Add the next batch of GTK+ SVG test results.

  • platform/gtk/Skipped: Unskip tests which now have results.
11:37 AM Changeset in webkit [78352] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-02-11 Viatcheslav Ostapenko <​ostapenko.viatcheslav@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] wmode gets overridden even if already windowless in QGraphicsWebView
Do not override wmode if it is not set to "window".
​https://bugs.webkit.org/show_bug.cgi?id=50495

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createPlugin):
11:23 AM Changeset in webkit [78351] by jeffm@apple.com
  • 2 edits in trunk/Source/WebKit2

Eliminate /DELAYLOAD:msimg32.dll ignored warning when building WebKit project
​https://bugs.webkit.org/show_bug.cgi?id=54296

Reviewed by Steve Falkenburg.

  • win/WebKit2Common.vsprops: Remove msimg32.dll from the list of DelayLoadDLLs.
11:16 AM Changeset in webkit [78350] by alex
  • 5 edits
    4 adds in trunk/Source/WebKit2

2011-02-11 Chandra Vallala <​chandra.vallala@motorola.com> and Alejandro G. Castro <​alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Implement UpdateChunk, ChunkedUpdateDrawingArea/Proxy
classes for WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=54080

  • GNUmakefile.am:
  • Shared/gtk/UpdateChunk.cpp: Added. (WebKit::UpdateChunk::UpdateChunk): (WebKit::UpdateChunk::~UpdateChunk): (WebKit::UpdateChunk::encode): (WebKit::UpdateChunk::decode): (WebKit::UpdateChunk::createImage):
  • Shared/gtk/UpdateChunk.h: Added. (WebKit::UpdateChunk::rect): (WebKit::UpdateChunk::isEmpty): (WebKit::UpdateChunk::size):
  • UIProcess/ChunkedUpdateDrawingAreaProxy.cpp: (WebKit::ChunkedUpdateDrawingAreaProxy::ChunkedUpdateDrawingAreaProxy): Initialize the surface.
  • UIProcess/ChunkedUpdateDrawingAreaProxy.h:
  • UIProcess/DrawingAreaProxy.h: Added cairo variables.
  • UIProcess/gtk/ChunkedUpdateDrawingAreaProxyGtk.cpp: Added. (WebKit::ChunkedUpdateDrawingAreaProxy::page): (WebKit::ChunkedUpdateDrawingAreaProxy::ensureBackingStore): (WebKit::ChunkedUpdateDrawingAreaProxy::invalidateBackingStore): (WebKit::ChunkedUpdateDrawingAreaProxy::platformPaint): (WebKit::ChunkedUpdateDrawingAreaProxy::drawUpdateChunkIntoBackingStore):
  • WebProcess/WebPage/gtk/ChunkedUpdateDrawingAreaGtk.cpp: Added. (WebKit::ChunkedUpdateDrawingArea::paintIntoUpdateChunk):
11:03 AM Changeset in webkit [78349] by sergio@webkit.org
  • 5 edits
    2 deletes in trunk

2011-02-11 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r78331.
​http://trac.webkit.org/changeset/78331
​https://bugs.webkit.org/show_bug.cgi?id=54295

This patch broke 11 tests in GTK bots (Requested by svillar on
#webkit).

  • platform/gtk/accessibility/document-reload-events-expected.txt: Removed.
  • platform/gtk/accessibility/document-reload-events.html: Removed.

2011-02-11 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r78331.
​http://trac.webkit.org/changeset/78331
​https://bugs.webkit.org/show_bug.cgi?id=54295

This patch broke 11 tests in GTK bots (Requested by svillar on
#webkit).

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_name): (webkit_accessible_detach):

2011-02-11 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r78331.
​http://trac.webkit.org/changeset/78331
​https://bugs.webkit.org/show_bug.cgi?id=54295

This patch broke 11 tests in GTK bots (Requested by svillar on
#webkit).

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::notifyStatus):
10:42 AM Changeset in webkit [78348] by Martin Robinson
  • 2 edits
    461 adds in trunk/LayoutTests

2011-02-11 Martin Robinson <​mrobinson@igalia.com>

Generate more GTK+ results for many SVG tests missing them.

  • platform/gtk/Skipped: Unskip tests which now have results.
10:21 AM Changeset in webkit [78347] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

[Windows XP Debug Tests] media/audio-mpeg4-supported.html timing out since introduction in
r76621.
​https://bugs.webkit.org/show_bug.cgi?id=54291

Unreviewed, adding this test to the Windows XP skip list in order to get the bots green.

  • platform/win-xp/Skipped:
10:11 AM Changeset in webkit [78346] by kov@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-02-11 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GDOM] Video element needs proper wrapping
​https://bugs.webkit.org/show_bug.cgi?id=54231

Use the same strategy as the one used for the audio tag to wrap
video as well. No layout tests because this only adds API.

  • bindings/gobject/GNUmakefile.am:
  • bindings/gobject/WebKitHTMLElementWrapperFactory.cpp: (WebKit::createVideoWrapper): (WebKit::createHTMLElementWrapper):
10:00 AM Changeset in webkit [78345] by krit@webkit.org
  • 59 edits in trunk/Source/WebCore

2011-02-11 Dirk Schulze <​krit@webkit.org>

Reviewed by Andreas Kling.

SVGStyledElement::fillAttributeToPropertyTypeMap triggers a clang warning (-Woverloaded-virtual)
​https://bugs.webkit.org/show_bug.cgi?id=54259

Renamed fillAttributeToPropertyTypeMap with passed map to fillPassedAttributeToPropertyTypeMap to
avoid overloading a virtual function.

No change of functionality. Just fixing a build warning, so no new tests.

  • svg/SVGAElement.cpp: (WebCore::SVGAElement::fillAttributeToPropertyTypeMap):
  • svg/SVGAltGlyphElement.cpp: (WebCore::SVGAltGlyphElement::fillAttributeToPropertyTypeMap):
  • svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::fillAttributeToPropertyTypeMap):
  • svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::fillAttributeToPropertyTypeMap):
  • svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFEComponentTransferElement.cpp: (WebCore::SVGFEComponentTransferElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFEConvolveMatrixElement.cpp: (WebCore::SVGFEConvolveMatrixElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFEMergeElement.cpp: (WebCore::SVGFEMergeElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFEOffsetElement.cpp: (WebCore::SVGFEOffsetElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFETileElement.cpp: (WebCore::SVGFETileElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFilterPrimitiveStandardAttributes.cpp: (WebCore::SVGFilterPrimitiveStandardAttributes::fillPassedAttributeToPropertyTypeMap):
  • svg/SVGFilterPrimitiveStandardAttributes.h:
  • svg/SVGFontElement.cpp: (WebCore::SVGFontElement::fillAttributeToPropertyTypeMap):
  • svg/SVGForeignObjectElement.cpp: (WebCore::SVGForeignObjectElement::fillAttributeToPropertyTypeMap):
  • svg/SVGGlyphElement.cpp: (WebCore::SVGGlyphElement::fillAttributeToPropertyTypeMap):
  • svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::fillPassedAttributeToPropertyTypeMap):
  • svg/SVGGradientElement.h:
  • svg/SVGImageElement.cpp: (WebCore::SVGImageElement::fillAttributeToPropertyTypeMap):
  • svg/SVGLineElement.cpp: (WebCore::SVGLineElement::fillAttributeToPropertyTypeMap):
  • svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::fillAttributeToPropertyTypeMap):
  • svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::fillAttributeToPropertyTypeMap):
  • svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::fillAttributeToPropertyTypeMap):
  • svg/SVGMissingGlyphElement.cpp: (WebCore::SVGMissingGlyphElement::fillAttributeToPropertyTypeMap):
  • svg/SVGPathElement.cpp: (WebCore::SVGPathElement::fillAttributeToPropertyTypeMap):
  • svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::fillAttributeToPropertyTypeMap):
  • svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::fillAttributeToPropertyTypeMap):
  • svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::fillAttributeToPropertyTypeMap):
  • svg/SVGRectElement.cpp: (WebCore::SVGRectElement::fillAttributeToPropertyTypeMap):
  • svg/SVGStopElement.cpp: (WebCore::SVGStopElement::fillAttributeToPropertyTypeMap):
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::fillPassedAttributeToPropertyTypeMap):
  • svg/SVGStyledElement.h:
  • svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::fillPassedAttributeToPropertyTypeMap):
  • svg/SVGStyledTransformableElement.h:
  • svg/SVGSwitchElement.cpp: (WebCore::SVGSwitchElement::fillAttributeToPropertyTypeMap):
  • svg/SVGSymbolElement.cpp: (WebCore::SVGSymbolElement::fillAttributeToPropertyTypeMap):
  • svg/SVGTRefElement.cpp: (WebCore::SVGTRefElement::fillAttributeToPropertyTypeMap):
  • svg/SVGTSpanElement.cpp: (WebCore::SVGTSpanElement::fillAttributeToPropertyTypeMap):
  • svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::fillPassedAttributeToPropertyTypeMap):
  • svg/SVGTextContentElement.h:
  • svg/SVGTextElement.cpp: (WebCore::SVGTextElement::fillAttributeToPropertyTypeMap):
  • svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::fillAttributeToPropertyTypeMap):
  • svg/SVGTextPositioningElement.cpp: (WebCore::SVGTextPositioningElement::fillPassedAttributeToPropertyTypeMap):
  • svg/SVGTextPositioningElement.h:
  • svg/SVGTitleElement.cpp: (WebCore::SVGTitleElement::fillAttributeToPropertyTypeMap):
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::fillAttributeToPropertyTypeMap):
  • svg/SVGViewElement.cpp: (WebCore::SVGViewElement::fillAttributeToPropertyTypeMap):
9:54 AM Changeset in webkit [78344] by jberlin@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add Windows XP specific results for fast/dom/52776.html to get the bot green. Unreviewed.
​https://bugs.webkit.org/show_bug.cgi?id=52776

  • platform/win-xp/fast/dom: Added.
  • platform/win-xp/fast/dom/52776-expected.txt: Added.
9:43 AM Changeset in webkit [78343] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-02-11 Andrey Adaikin <​aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] click on error message in console doesn't scroll into view
​https://bugs.webkit.org/show_bug.cgi?id=54089

9:28 AM Changeset in webkit [78342] by Nate Chapin
  • 32 edits in trunk/Source

2011-02-10 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Make DocumentWriter a member of DocumentLoader
instead of FrameLoader.
​https://bugs.webkit.org/show_bug.cgi?id=50489

Refactor, no new tests.

  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::explicitClose): (WebCore::Document::lastModified): (WebCore::Document::initSecurityContext): (WebCore::Document::updateURLForPushOrReplaceState):
  • dom/Document.h: (WebCore::Document::setDocumentLoader): (WebCore::Document::loader):
  • html/MediaDocument.cpp: (WebCore::MediaDocument::replaceMediaElementTimerFired):
  • html/PluginDocument.cpp: (WebCore::PluginDocumentParser::createDocumentStructure):
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::finishedLoading): (WebCore::DocumentLoader::commitData): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::setFrame):
  • loader/DocumentLoader.h: (WebCore::DocumentLoader::writer):
  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::begin):
  • loader/DocumentWriter.h: (WebCore::DocumentWriter::setFrame):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::init): (WebCore::FrameLoader::clear): (WebCore::FrameLoader::receivedFirstData): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::open): (WebCore::FrameLoader::finishedLoadingDocument): (WebCore::FrameLoader::addExtraFieldsToRequest):
  • loader/FrameLoader.h: (WebCore::FrameLoader::notifier):
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
9:16 AM Changeset in webkit [78341] by sergio@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-11 Sergio Villar Senin <​svillar@igalia.com>

Unreviewed.

Added two tests to the skipped file that started to fail only in
64-bit debug bot. Rounding issues are most likely the source of
differences between 32 and 64bit bots.

  • platform/gtk/Skipped: added svg/W3C-SVG-1.1-SE/types-dom-02-f.svg and svg/W3C-SVG-1.1-SE/types-dom-05-b.svg
8:48 AM ApplicationsGtk edited by christian@webkit.org
(diff)
8:47 AM ApplicationsGtk edited by christian@webkit.org
(diff)
8:36 AM Changeset in webkit [78340] by ager@chromium.org
  • 1 edit
    3 deletes in trunk/LayoutTests

2011-02-11 Mads Ager <​ager@chromium.org>

Reviewed by Dimitri Glazkov.

Remove unnecessary chromium layout test rebaselines
​https://bugs.webkit.org/show_bug.cgi?id=54278

  • platform/chromium/fast/js/ToNumber-expected.txt: Removed.
  • platform/chromium/fast/js/parseFloat-expected.txt: Removed.
  • platform/chromium/fast/js/regexp-look-ahead-empty-expected.txt: Removed.
8:24 AM Changeset in webkit [78339] by pfeldman@chromium.org
  • 3 edits in trunk/LayoutTests

2011-02-11 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: unflake inspector test (2).

  • inspector/command-line-api.html:
  • inspector/elements-tests2.js: (initialize_ElementTest.InspectorTest.selectElementAndRun):
7:47 AM Changeset in webkit [78338] by pfeldman@chromium.org
  • 3 edits in trunk/LayoutTests

2011-02-11 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: unflake inspector test.

  • inspector/command-line-api-expected.txt:
  • inspector/command-line-api.html:
7:42 AM Changeset in webkit [78337] by jberlin@webkit.org
  • 2 edits
    4 adds in trunk/LayoutTests

[Windows 7 Release Tests] fast/dom/Window/window-property-descriptors.html,
fast/js/global-function-resolve.html,
fast/js/var-declarations-shadowing.html,
and security/crypto-random-values.html failing since r78321.
​https://bugs.webkit.org/show_bug.cgi?id=54285

Unreviewed, landing expected failing results to get the bots green.

  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/js/global-function-resolve-expected.txt: Added.
  • platform/win/fast/js/var-declarations-shadowing-expected.txt: Added.
  • platform/win/security: Added.
  • platform/win/security/crypto-random-values-expected.txt: Added.
7:23 AM Changeset in webkit [78336] by pfeldman@chromium.org
  • 21 edits in trunk/Source/WebCore

2011-02-10 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: make InspectorAgent own sub-agents, align agent creation/deletion routines.
​https://bugs.webkit.org/show_bug.cgi?id=54227

  • dom/Document.cpp: (WebCore::Document::finishedParsing):
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::restoreInspectorStateFromCookie): (WebCore::InspectorAgent::setFrontend): (WebCore::InspectorAgent::disconnectFrontend): (WebCore::InspectorAgent::releaseFrontendLifetimeAgents): (WebCore::InspectorAgent::didCommitLoad): (WebCore::InspectorAgent::domContentLoadedEventFired): (WebCore::InspectorAgent::loadEventFired): (WebCore::InspectorAgent::startTimelineProfiler): (WebCore::InspectorAgent::stopTimelineProfiler):
  • inspector/InspectorAgent.h:
  • inspector/InspectorCSSAgent.cpp:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::InspectorDOMAgent): (WebCore::InspectorDOMAgent::startListening): (WebCore::InspectorDOMAgent::stopListening): (WebCore::InspectorDOMAgent::mainDOMContentLoaded): (WebCore::InspectorDOMAgent::loadEventFired):
  • inspector/InspectorDOMAgent.h: (WebCore::InspectorDOMAgent::create):
  • inspector/InspectorDOMStorageAgent.cpp: (WebCore::InspectorDOMStorageAgent::~InspectorDOMStorageAgent):
  • inspector/InspectorDOMStorageAgent.h: (WebCore::InspectorDOMStorageAgent::create):
  • inspector/InspectorDOMStorageResource.h:
  • inspector/InspectorDatabaseAgent.cpp: (WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent): (WebCore::InspectorDatabaseAgent::executeSQL): (WebCore::InspectorDatabaseAgent::selectDatabase): (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
  • inspector/InspectorDatabaseAgent.h: (WebCore::InspectorDatabaseAgent::FrontendProvider::create): (WebCore::InspectorDatabaseAgent::FrontendProvider::~FrontendProvider): (WebCore::InspectorDatabaseAgent::FrontendProvider::frontend): (WebCore::InspectorDatabaseAgent::FrontendProvider::clearFrontend): (WebCore::InspectorDatabaseAgent::FrontendProvider::FrontendProvider): (WebCore::InspectorDatabaseAgent::create):
  • inspector/InspectorDatabaseResource.cpp: (WebCore::InspectorDatabaseResource::InspectorDatabaseResource): (WebCore::InspectorDatabaseResource::bind):
  • inspector/InspectorDatabaseResource.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl): (WebCore::InspectorInstrumentation::loadEventFiredImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::domContentLoadedEventFired): (WebCore::InspectorInstrumentation::loadEventFired):
  • inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState): (WebCore::InspectorState::mute): (WebCore::InspectorState::updateCookie):
  • inspector/InspectorState.h: (WebCore::InspectorState::~InspectorState):
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::restore): (WebCore::InspectorTimelineAgent::~InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::didCommitLoad): (WebCore::InspectorTimelineAgent::setFrontend): (WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
  • inspector/InspectorTimelineAgent.h: (WebCore::InspectorTimelineAgent::create):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchLoadEvent):
6:54 AM Changeset in webkit [78335] by pfeldman@chromium.org
  • 5 edits in trunk

2011-02-11 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: command line API $0 regressed.
​https://bugs.webkit.org/show_bug.cgi?id=54283

  • inspector/command-line-api-expected.txt:
  • inspector/command-line-api.html:

2011-02-11 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: command line API $0 regressed.
​https://bugs.webkit.org/show_bug.cgi?id=54283

  • inspector/InjectedScriptSource.js:
6:21 AM Changeset in webkit [78334] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[Qt] Increase the timeout of Qt API tests to 120 seconds.

Reviewed by Andreas Kling.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
5:25 AM Changeset in webkit [78333] by abarth@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-11 Adam Barth <​abarth@webkit.org>

Reviewed by Andreas Kling.

CryptographicRandomNumber has its threading ifdefs backwards
​https://bugs.webkit.org/show_bug.cgi?id=54280

Turns out we want the mutex when thread is enabled. :)

  • wtf/CryptographicallyRandomNumber.cpp: (WTF::ARC4Stream::ARC4RandomNumberGenerator::randomNumber): (WTF::ARC4Stream::ARC4RandomNumberGenerator::randomValues):
5:19 AM Changeset in webkit [78332] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-11 Janne Koskinen <​janne.p.koskinen@digia.com>

Reviewed by Andreas Kling.

[Qt][S60] Vertical borders of buttons and frames are misaligned
​https://bugs.webkit.org/show_bug.cgi?id=51169

Force anti-aliasing for lines and rects when using OpenVG backend on Symbian.
OpenVG cannot guarantee rendering to be on pixel in floating point co-ordinates
without anti-aliasing. Patch idea by Laszlo Agocs.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
4:53 AM Changeset in webkit [78331] by mario@webkit.org
  • 5 edits
    2 adds in trunk

2011-02-11 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Xan Lopez.

[GTK] events missing when a document is (re)loaded
​https://bugs.webkit.org/show_bug.cgi?id=25831

Added new layout test to check the right signals are emitted.

  • platform/gtk/accessibility/document-reload-events-expected.txt: Added.
  • platform/gtk/accessibility/document-reload-events.html: Added.

2011-02-11 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Xan Lopez.

[GTK] events missing when a document is (re)loaded
​https://bugs.webkit.org/show_bug.cgi?id=25831

Make sure webArea returns a proper name and that a signal
'state-change::defunct' is emitted when detaching the wrapper.

Test: platform/gtk/accessibility/document-reload-events.html

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_name): Returns the current document's title as fallback mechanism for webArea objects. (webkit_accessible_detach): Emit 'state-change::defunct' function as soon as the wrapper is detached from the related core object.

2011-02-11 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Xan Lopez.

[GTK] events missing when a document is (re)loaded
​https://bugs.webkit.org/show_bug.cgi?id=25831

Emit the right signals when reloading a document.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::notifyAccessibilityStatus): New function, to make sure the signals involved in reloading a document are properly emitted. (WebKit::notifyStatus): Also notify accessibility if enabled.
3:19 AM Changeset in webkit [78330] by abarth@webkit.org
  • 2 edits
    1 delete in trunk/LayoutTests

2011-02-11 Adam Barth <​abarth@webkit.org>

Turns out that expectation isn't Qt specific.

  • http/tests/security/cross-frame-access-put-expected.txt:
  • platform/qt/http/tests/security/cross-frame-access-put-expected.txt: Removed.
2:53 AM Changeset in webkit [78329] by abarth@webkit.org
  • 3 edits
    1 add in trunk/LayoutTests

2011-02-11 Adam Barth <​abarth@webkit.org>

Update Qt expected results for window.crypto.

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/http/tests/security/cross-frame-access-put-expected.txt: Added.
2:50 AM Changeset in webkit [78328] by pfeldman@chromium.org
  • 4 edits
    2 adds in trunk

2011-02-11 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: command line's API inspect() is broken.
​https://bugs.webkit.org/show_bug.cgi?id=54275

  • http/tests/inspector/inspector-test2.js: (initialize_InspectorTest.InspectorTest.evaluateInConsoleAndDump):
  • inspector/command-line-api-expected.txt: Added.
  • inspector/command-line-api.html: Added.

2011-02-11 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: command line's API inspect() is broken.
​https://bugs.webkit.org/show_bug.cgi?id=54275

Test: inspector/command-line-api.html

  • inspector/InjectedScriptSource.js:
2:31 AM Changeset in webkit [78327] by abarth@webkit.org
  • 7 edits in trunk

2011-02-11 Adam Barth <​abarth@webkit.org>

Turns out window.crypto is supposed to be readonly.

  • page/DOMWindow.idl:

2011-02-11 Adam Barth <​abarth@webkit.org>

Update test expectations to show window.crypto.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • http/tests/security/cross-frame-access-put-expected.txt:
2:10 AM Changeset in webkit [78326] by sergio@webkit.org
  • 1 edit
    15 adds in trunk/LayoutTests

2011-02-11 Sergio Villar Senin <​svillar@igalia.com>

Unreviewed.

Added new test expectations for the GTK port.

  • platform/gtk/fast/box-shadow/inset-box-shadows-expected.checksum: Added.
  • platform/gtk/fast/box-shadow/inset-box-shadows-expected.png: Added.
  • platform/gtk/fast/box-shadow/inset-box-shadows-expected.txt: Added.
  • platform/gtk/fast/box-shadow/shadow-buffer-partial-expected.checksum: Added.
  • platform/gtk/fast/box-shadow/shadow-buffer-partial-expected.png: Added.
  • platform/gtk/fast/box-shadow/shadow-buffer-partial-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1/linking-a-01-b-expected.checksum: Added.
  • platform/gtk/svg/W3C-SVG-1.1/linking-a-01-b-expected.png: Added.
  • platform/gtk/svg/W3C-SVG-1.1/linking-a-01-b-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1/linking-a-02-b-expected.checksum: Added.
  • platform/gtk/svg/W3C-SVG-1.1/linking-a-02-b-expected.png: Added.
  • platform/gtk/svg/W3C-SVG-1.1/linking-a-02-b-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1/linking-a-03-b-expected.checksum: Added.
  • platform/gtk/svg/W3C-SVG-1.1/linking-a-03-b-expected.png: Added.
  • platform/gtk/svg/W3C-SVG-1.1/linking-a-03-b-expected.txt: Added.
1:34 AM Changeset in webkit [78325] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-11 Adam Barth <​abarth@webkit.org>

Actually add Crypto.cpp to the Windows build. I'm terrible.

  • WebCore.vcproj/WebCore.vcproj:
1:21 AM Changeset in webkit [78324] by abarth@webkit.org
  • 1 edit in trunk/Source/WebCore/page/Crypto.h

Fix typo

1:12 AM Changeset in webkit [78323] by abarth@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-02-11 Adam Barth <​abarth@webkit.org>

Attempt to fix the Windows build. Apparently we don't support
conditional attributes on functions. This patch makes the whole Crypto
interface conditional on ArrayBuffer support.

  • page/DOMWindow.idl:
  • page/Crypto.cpp:
  • page/Crypto.h:
  • page/Crypto.idl:
12:57 AM Changeset in webkit [78322] by Antti Koivisto
  • 6 edits in trunk/Source/WebCore

Enable ancestor identifier filtering for tree building
​https://bugs.webkit.org/show_bug.cgi?id=54241

Reviewed by Dave Hyatt.

Call CSSStyleSelector::push/popParent() during tree building too, fix up the parent
element stack as needed.

This roughly halves the remaining time in style matching over a typical page load.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::pushParentStackFrame):
(WebCore::CSSStyleSelector::popParentStackFrame):
(WebCore::CSSStyleSelector::pushParent):
(WebCore::CSSStyleSelector::popParent):

  • css/CSSStyleSelector.h:

(WebCore::CSSStyleSelector::ParentStackFrame::ParentStackFrame):

  • dom/Document.h:

(WebCore::Document::styleSelectorIfExists):

  • dom/Element.cpp:

(WebCore::Element::beginParsingChildren):
(WebCore::Element::finishParsingChildren):

  • dom/Element.h:
12:37 AM Changeset in webkit [78321] by abarth@webkit.org
  • 21 edits
    6 adds in trunk

2011-02-10 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

WebKit should have a cryptographic RNG
​https://bugs.webkit.org/show_bug.cgi?id=22049

Test crypto.getRandomValues API. It's pretty hard to write a
deterministic API for a randomized API, but this test should catch some
regressions.

  • security/crypto-random-values-expected.txt: Added.
  • security/crypto-random-values.html: Added.

2011-02-10 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

WebKit should have a cryptographic RNG
​https://bugs.webkit.org/show_bug.cgi?id=22049

Teach JavaScriptCore how to export this function.

2011-02-10 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

WebKit should have a cryptographic RNG
​https://bugs.webkit.org/show_bug.cgi?id=22049

Add crypto.getRandomValues. Yes, all these diffs are required to
expose a single function to the DOM.

Test: security/crypto-random-values.html

  • Android.mk:
  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • ForwardingHeaders/wtf/CryptographicallyRandomNumber.h: Added.
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMWindowCustom.cpp:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • config.h:
  • page/Crypto.cpp: Added. (WebCore::Crypto::Crypto): (WebCore::Crypto::getRandomValues):
  • page/Crypto.h: Added. (WebCore::Crypto::create):
  • page/Crypto.idl: Added.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::clear): (WebCore::DOMWindow::crypto):
  • page/DOMWindow.h: (WebCore::DOMWindow::optionalCrypto):
  • page/DOMWindow.idl:
12:26 AM Changeset in webkit [78320] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-11 Ryuan Choi <​ryuan.choi@samsung.com>

Unreviewed build fix.

[GTK] Build break with 2.18.3
​https://bugs.webkit.org/show_bug.cgi?id=54057

  • platform/gtk/ScrollbarThemeGtk2.cpp: Include GtkVersioning.h
12:14 AM Changeset in webkit [78319] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-02-11 Cosmin Truta <​ctruta@chromium.org>

Reviewed by Adam Barth.

Templatize KURLGooglePrivate::init
​https://bugs.webkit.org/show_bug.cgi?id=53749

No new tests. Refactoring.

  • platform/KURLGoogle.cpp: (WebCore::KURLGooglePrivate::init):
  • platform/KURLGooglePrivate.h:
Note: See TracTimeline for information about the timeline view.