⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 13, 2011:

11:58 PM Changeset in webkit [78456] by hayato@chromium.org
  • 2 edits in trunk

2011-02-13 Hayato Ito <​hayato@chromium.org>

Reviewed by Kent Tamura.

Update .gitignore to ignore files which Ninja build system generates.

​https://bugs.webkit.org/show_bug.cgi?id=54378

  • .gitignore:
9:01 PM WebKit Team edited by jhanssen@gmail.com
Add myself to the committer list (diff)
8:22 PM Changeset in webkit [78455] by tkent@chromium.org
  • 4 edits
    2 copies in branches/chromium/597

The second attempt to merge r77114.
(It was merged by r78166 and reverted by r78381)

HTMLFormControlElement::insertedIntoDocument() and removedFromDocument()
should call HTMLElement::insertedIntoDocument() and removedFromDocument().

2011-01-30 Kenichi Ishibashi <​bashi@google.com>

Reviewed by Kent Tamura.

Dangling form associated elements should not be registered on the document
​https://bugs.webkit.org/show_bug.cgi?id=53223

Adds insertedIntoDocument() and remvoedFromDocument() to
FormAssociatedElement class to register the element on the document
if and only if it actually inserted into (removed from) the document.

Test: fast/forms/dangling-form-element-crash.html

  • html/FormAssociatedElement.cpp: (WebCore::FormAssociatedElement::insertedIntoDocument): Added. (WebCore::FormAssociatedElement::removedFromDocument): Ditto. (WebCore::FormAssociatedElement::insertedIntoTree): Don't register the element to a document. (WebCore::FormAssociatedElement::removedFromTree): Don't unregister the element from a document.
  • html/FormAssociatedElement.h:
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::insertedIntoDocument): Added. (WebCore::HTMLFormControlElement::removedFromDocument): Ditto.
  • html/HTMLFormControlElement.h:
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::insertedIntoDocument): Calls FormAssociatedElement::insertedIntoDocument(). (WebCore::HTMLObjectElement::removedFromDocument): Calls FormAssociatedElement::removedFromDocument().

2011-01-30 Kenichi Ishibashi <​bashi@google.com>

Reviewed by Kent Tamura.

Dangling form associated elements should not be registered on the document
​https://bugs.webkit.org/show_bug.cgi?id=53223

Adds a test that ensures dangling form associated elements are not
registered on the document.

  • fast/forms/dangling-form-element-crash-expected.txt: Added.
  • fast/forms/dangling-form-element-crash.html: Added.

BUG=crbug.com/70078
TBR=​inferno@chromium.org

8:12 PM WebKit Team edited by helder@sencha.com
(diff)
8:02 PM Changeset in webkit [78454] by Simon Fraser
  • 3 edits in trunk/LayoutTests

2011-02-13 Simon Fraser <Simon Fraser>

Change previous test to dump as text, with pixel output, to fix
Qt failure.

  • fast/gradients/css3-repeating-end-fill-expected.txt:
  • fast/gradients/css3-repeating-end-fill.html:
8:00 PM Changeset in webkit [78453] by mrowe@apple.com
  • 5 edits in trunk/Source

Versioning.

7:56 PM Changeset in webkit [78452] by mrowe@apple.com
  • 1 copy in tags/Safari-534.20

New tag.

7:28 PM Changeset in webkit [78451] by Darin Adler
  • 6 edits in trunk/Source/WebCore

2011-02-12 Darin Adler <Darin Adler>

Reviewed by Alexey Proskuryakov.

Add built-in decoder for UTF-8 for improved performance
​https://bugs.webkit.org/show_bug.cgi?id=53898

Covered by existing tests; not adding new tests at this time.

This patch now handles errors in the same way the existing codecs do,
and so passes our tests. The previous version failed some tests because
of incorrect error handling.

  • platform/text/TextCodecICU.cpp: (WebCore::create): Renamed from newTextCodecICU, made a static member function, and added a call to adoptPtr. (WebCore::TextCodecICU::registerEncodingNames): Renamed from registerExtendedEncodingNames since this class is no longer used for base codecs. Removed aliases for UTF-8; now handled by TextCodecUTF8. (WebCore::TextCodecICU::registerCodecs): Renamed. (WebCore::fallbackForGBK): Renamed to conform to our current style.
  • platform/text/TextCodecICU.h: Updated for above changes. Changed indentation. Made most functions private, including virtual function overrides. Marked ICUConverterWrapper noncopyable.
  • platform/text/TextCodecUTF8.cpp: (WebCore::TextCodecUTF8::registerEncodingNames): Added the UTF-8 aliases that were formerly added by TextCodecICU. (WebCore::nonASCIISequenceLength): Fixed bug where this would return 4 for bytes F5-FF instead of failing. (WebCore::decodeNonASCIISequence): Tweaked coding style. (WebCore::appendCharacter): Added. Makes it easier to share code between the partial-character handling and main loop. (WebCore::TextCodecUTF8::decode): Fixed buffer size computation for case where there is a partial sequence. Fixed partial sequence handling so that goto is no longer needed, since compilers sometimes make poor code when goto is involved. Added a loop for partial sequences since we consume only one byte when a partial sequence is invalid. Fixed logic in main decoding loop so goto is not needed. Used early-exit style in both loops so the main flow is not nested inside if statements. Added correct error handling for flush when a partial sequence remains, which involved wrapping the function in yet another loop.
  • platform/text/TextCodecUTF8.h: Made virtual function overrides private.
  • platform/text/TextEncodingRegistry.cpp: (WebCore::buildBaseTextCodecMaps): Added calls to TextCodecUTF8. Removed calls to TextCodecICU. Added FIXMEs for other codecs that no longer need to be included here. (WebCore::extendTextCodecMaps): Updated for the name change of the TextCodecICU functions.
6:50 PM Changeset in webkit [78450] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

<rdar://problem/8995490> WebCoreAuthenticationClientAsChallengeSender doesn't implement some necessary methods.

Reviewed by Maciej Stachowiak.

  • platform/network/mac/AuthenticationMac.mm:

(-[WebCoreAuthenticationClientAsChallengeSender performDefaultHandlingForAuthenticationChallenge:]):
(-[WebCoreAuthenticationClientAsChallengeSender rejectProtectionSpaceAndContinueWithChallenge:]):

6:09 PM Changeset in webkit [78449] by Simon Fraser
  • 3 edits
    4 adds in trunk

2011-02-13 Simon Fraser <Simon Fraser>

Reviewed by Andreas Kling.

Repeating gradients drawn incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=53502

The 'forward-fill' logic for repeating gradients used the wrong
starting stop index (0 rather than the original first index), which
resulted in incorrect gradients if backwards-fill had already been
applied.

Test: fast/gradients/css3-repeating-end-fill.html

  • css/CSSGradientValue.cpp: (WebCore::CSSGradientValue::addStops):
5:19 PM Changeset in webkit [78448] by benjamin.poulain@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-02-13 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Andreas Kling.

Unused variable result in RenderBlock::addOverflowFromFloats()
​https://bugs.webkit.org/show_bug.cgi?id=54363

Remove the unused variable.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::addOverflowFromFloats):
4:14 PM Changeset in webkit [78447] by cwzwarich@webkit.org
  • 2 edits in trunk/Source/WebCore

Reviewed by Anders Carlsson.

WebCore fails to build with Clang's -Woverloaded-virtual
​https://bugs.webkit.org/show_bug.cgi?id=54367

  • loader/PingLoader.h:

(WebCore::PingLoader::didReceiveData): Change the method signature to match the signature
in the base class.

4:12 PM Changeset in webkit [78446] by andreas.kling@nokia.com
  • 1 edit
    2 deletes in trunk/LayoutTests

2011-02-13 Andreas Kling <​kling@webkit.org>

Unreviewed, remove unnecessary platform expectations for now-passing test.

  • platform/chromium/canvas/philip/tests/2d.fillStyle.parse.system-expected.txt: Removed.
  • platform/mac/canvas/philip/tests/2d.fillStyle.parse.system-expected.txt: Removed.
4:09 PM Changeset in webkit [78445] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Speculative fix for

Reviewed by Maciej Stachowiak.

<rdar://problem/8995361>
CrashTracer: [USER] 47 crashes in WebProcess at com.apple.WebKit2: WebKit::WebPage::layoutIfNeeded + 4

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::~DrawingAreaImpl):
Invalidate the layer tree host.

3:19 PM Changeset in webkit [78444] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

2011-02-13 Nico Weber <​thakis@chromium.org>

Reviewed by Anders Carlsson.

RenderBR::width() tries but fails to override RenderText::width()
​https://bugs.webkit.org/show_bug.cgi?id=54301

The superclass method's signature changed, e.g. in
​http://trac.webkit.org/changeset/57215, but the subclass was not
updated.

  • rendering/RenderBR.h: (WebCore::RenderBR::width):
3:11 PM Changeset in webkit [78443] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-13 Shinichiro Hamaji <​hamaji@chromium.org>

Fix chromium's test_expectations

  • fast/inline/inline-box-background-* should be IMAGE instead of IMAGE+TEXTfor Mac
  • fast/css/test-setting-canvas-color.html is failing
  • platform/chromium/test_expectations.txt:
1:41 PM Changeset in webkit [78442] by andreas.kling@nokia.com
  • 10 edits
    2 adds in trunk

2011-02-13 Andreas Kling <​kling@webkit.org>

Reviewed by Dirk Schulze.

Canvas: 2d.fillStyle.parse.system.html fails
​https://bugs.webkit.org/show_bug.cgi?id=39168

Based on previous work by Julien Chaffraix <​jchaffraix@codeaurora.org>
and Jan Erik Hanssen <​jhanssen@sencha.com>

  • css/CSSParser.cpp: (WebCore::CSSParser::parseColor): Changed the function to better match our early return policy. Also we now return false when we don't parse the color. This is needed for createFromString to fallback to using parseSystemColor.

(WebCore::CSSParser::parseSystemColor): Made use of the RenderTheme to get
the system colors.

  • css/CSSParser.h: Added the new parseSystemColor method.
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setStrokeColor): Pass the document to createFromString. (WebCore::CanvasRenderingContext2D::setFillColor): Ditto.
  • html/canvas/CanvasStyle.cpp: (WebCore::parseColor): (WebCore::parseColorOrCurrentColor): (WebCore::CanvasStyle::createFromString): Try to parse the color using CSSParser::parseColor and fall back to parseSystemColor if it did not work.
  • html/canvas/CanvasStyle.h: Added the new Document* parameter to createFromString.

2011-02-13 Andreas Kling <​kling@webkit.org>

Reviewed by Dirk Schulze.

Canvas: 2d.fillStyle.parse.system.html fails
​https://bugs.webkit.org/show_bug.cgi?id=39168

  • fast/css/test-setting-canvas-color-expected.txt: Added.
  • fast/css/test-setting-canvas-color.html: Added.
  • platform/gtk/Skipped:
  • platform/mac-leopard/Skipped:
  • platform/qt/Skipped:
1:39 PM Changeset in webkit [78441] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-02-13 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

The plug-in process heap should be executable by default
​https://bugs.webkit.org/show_bug.cgi?id=54364
<rdar://problem/8990563>

  • UIProcess/Launcher/ProcessLauncher.h: Add executableHeap flag.


  • UIProcess/Launcher/mac/ProcessLauncherMac.mm: (WebKit::ProcessLauncher::launchProcess): Set the right posix_spawn flag if executableHeap is true.
  • UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::PluginProcessProxy): Initialize executableHeap to true.
  • UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::connect): Initialize executableHeap to false.
1:21 PM Changeset in webkit [78440] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-13 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Messages waited on are never dispatched
​https://bugs.webkit.org/show_bug.cgi?id=54362
<rdar://problem/8995051>

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::processIncomingMessage): Get the argument encoder from the incoming message.
12:28 PM Changeset in webkit [78439] by jeremy@chromium.org
  • 16 edits in trunk/Source

2011-02-13 Jeremy Moskovich <​jeremy@chromium.org>

Reviewed by Adam Barth.

Add a compile-time option to completely disable WebArchive support.
​https://bugs.webkit.org/show_bug.cgi?id=52712

Add an ENABLE(WEB_ARCHIVE) compile-time setting and use it for all WebArchive code.
Ports Affected:

WebArchive support is currently enabled for all ports that define PLATFORM(CF) apart from Qt.
This patch preserves this behavior except that it also disables support in the Chromium port.

  • wtf/Platform.h: Add ENABLE_WEB_ARCHIVE definition and turn it off explicitly for Qt & Chromium ports.

2011-02-13 Jeremy Moskovich <​jeremy@chromium.org>

Reviewed by Adam Barth.

Add a compile-time option to completely disable WebArchive support.
​https://bugs.webkit.org/show_bug.cgi?id=52712

Add an ENABLE(WEB_ARCHIVE) compile-time setting and use it for all WebArchive code.

ArchiveResource and ArchiveResourceCollection are notably still compiled in. They are used
in Safari for functionality such as "Save Image As" and Image copy & paste independent of
WebArchive support.

Ports Affected:

WebArchive support is currently enabled for all ports that define PLATFORM(CF) apart from Qt.
This patch preserves this behavior except that it also disables support in the Chromium port.

No behavior changes so no new tests.

  • WebCore.gyp/WebCore.gyp: Don't compile LegacyWebArchive.cpp and friends.
  • WebCore.pro: Don't compile ArchiveFactory.cpp in Qt port.
  • loader/DocumentLoader.cpp: Surround WebArchive code with #ifdef. (WebCore::DocumentLoader::commitLoad): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::archiveResourceForURL):
  • loader/DocumentLoader.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURLIntoChildFrame): (WebCore::FrameLoader::stopAllLoaders): (WebCore::FrameLoader::finishedLoadingDocument):
  • loader/FrameLoader.h:
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::start):
  • loader/archive/ArchiveFactory.cpp: Remove #ifdef since feature is now enabled/disabled wholesale. (WebCore::archiveMIMETypes):
  • page/Settings.cpp:
  • page/Settings.h:
  • platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedNonImageMimeTypes):

2011-02-13 Jeremy Moskovich <​jeremy@chromium.org>

Reviewed by Adam Barth.

Add a compile-time option to completely disable WebArchive support.
​https://bugs.webkit.org/show_bug.cgi?id=52712

Add an ENABLE(WEB_ARCHIVE) compile-time setting and use it for all WebArchive code.

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences):
12:04 PM Changeset in webkit [78438] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-02-13 Aparna Nandyal <​aparna.nand@wipro.com>

Reviewed by Andreas Kling.

[Qt] QtWebKit does not properly handle D&D of a percent-encoded URL.
​https://bugs.webkit.org/show_bug.cgi?id=53320

The encoding that was done is corrected in the fix.
Replaced the KURL encoding function with QUrl API.

  • platform/qt/DragDataQt.cpp: (WebCore::DragData::asURL):
11:33 AM Changeset in webkit [78437] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-13 Leo Yang <​leo.yang.c@gmail.com>

Reviewed by Andreas Kling.

Unnecessary call of containingBlock() in RenderBoxModelObject::relativePositionOffsetX()
​https://bugs.webkit.org/show_bug.cgi?id=54351

We were calling containingBlock() twice if the left is not auto. We only need to call it
once because we can use 'cb' variable in the following line.

No functionality change, no new tests.

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::relativePositionOffsetX):
11:23 AM Changeset in webkit [78436] by commit-queue@webkit.org
  • 10 edits
    6 adds
    2 deletes in trunk

2011-02-13 Jarred Nicholls <​jarred@sencha.com>

Reviewed by Simon Fraser.

getComputedStyle returns wrong value for margin-right
​https://bugs.webkit.org/show_bug.cgi?id=13343

Matching IE, Firefox, and Opera behavior by returning the computed margin
values as specified, rather than the used/auto values (calculated via RenderBox).
Also CSS 2.1+ compliant by returning margin percentage as specified, if applicable.
Note: Firefox and Opera return calculated fixed lengths for percentage margins, IE
returns the specified percentage.

  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-mac/fast/css/computed-style-without-renderer-expected.txt
  • platform/chromium-win/fast/css/computed-style-without-renderer-expected.txt
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
  • platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
  • fast/css/getComputedStyle/getComputedStyle-margin-auto-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle/marginComputedStyle-expected.txt.
  • fast/css/getComputedStyle/getComputedStyle-margin-auto.html: Copied from LayoutTests/fast/css/getComputedStyle/marginComputedStyle.html.
  • fast/css/getComputedStyle/getComputedStyle-margin-length-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-margin-length.html: Copied from LayoutTests/fast/css/getComputedStyle/marginComputedStyle.html.
  • fast/css/getComputedStyle/getComputedStyle-margin-percentage-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-margin-percentage.html: Renamed from LayoutTests/fast/css/getComputedStyle/marginComputedStyle.html.

2011-02-13 Jarred Nicholls <​jarred@sencha.com>

Reviewed by Simon Fraser.

getComputedStyle returns wrong value for margin-right
​https://bugs.webkit.org/show_bug.cgi?id=13343

Matching IE, Firefox, and Opera behavior by returning the computed margin
values as specified, rather than the used/auto values (calculated via RenderBox).
Also CSS 2.1+ compliant by returning margin percentage as specified, if applicable.
Note: Firefox and Opera return calculated fixed lengths for percentage margins, IE
returns the specified percentage.

Tests: fast/css/getComputedStyle/getComputedStyle-margin-auto.html

fast/css/getComputedStyle/getComputedStyle-margin-length.html
fast/css/getComputedStyle/getComputedStyle-margin-percentage.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
11:10 AM Changeset in webkit [78435] by abarth@webkit.org
  • 4 edits in trunk

2011-02-13 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

crypto.getRandomValues should throw TYPE_MISMATCH_ERR
​https://bugs.webkit.org/show_bug.cgi?id=54346

  • security/crypto-random-values-types-expected.txt:

2011-02-13 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

crypto.getRandomValues should throw TYPE_MISMATCH_ERR
​https://bugs.webkit.org/show_bug.cgi?id=54346

As requested by Sam.

  • page/Crypto.cpp: (WebCore::Crypto::getRandomValues):
11:06 AM Changeset in webkit [78434] by ap@apple.com
  • 4 edits in trunk/Source/WebCore

2011-02-13 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=54349
Inline some accessors in PrintContext

No change in behavior, so no tests.

  • WebCore.exp.in:
  • page/PrintContext.cpp:
  • page/PrintContext.h: (WebCore::PrintContext::pageCount): (WebCore::PrintContext::pageRect): Inline pageCount() and pageRect() to match pageRects().
11:05 AM Changeset in webkit [78433] by weinig@apple.com
  • 7 edits in trunk/Source/WebCore

Roll r78424 [Extra scrolling required when scrolling with a scroll wheel (Mighty Mouse)] back
in with fixes to make it work with render layers.

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorMac::adjustScrollXPositionIfNecessary):
(WebCore::ScrollAnimatorMac::adjustScrollYPositionIfNecessary):
(WebCore::ScrollAnimatorMac::adjustScrollPositionIfNecessary):
(WebCore::ScrollAnimatorMac::immediateScrollToPoint):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaX):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaY):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::contentsSize):
(WebCore::RenderLayer::visibleHeight):
(WebCore::RenderLayer::visibleWidth):
(WebCore::RenderLayer::updateScrollInfoAfterLayout):

  • rendering/RenderLayer.h:
  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::visibleHeight):
(WebCore::RenderListBox::visibleWidth):

  • rendering/RenderListBox.h:
11:03 AM Changeset in webkit [78432] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-13 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=54348
Crash when printing a document with no pages

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::drawPagesToPDF): Don't fail on a fake page that computePagesForPrinting() added to a pageless document.
10:46 AM Changeset in webkit [78431] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Some Scrollbar functions assume an attached ScrollableArea but can be called without one
​https://bugs.webkit.org/show_bug.cgi?id=54262

Reviewed by Dan Bernstein.

Make sure that all calls to the scrollable area are null checked.

  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::autoscrollPressedPart):
(WebCore::Scrollbar::moveThumb):
(WebCore::Scrollbar::mouseMoved):

10:35 AM Changeset in webkit [78430] by weinig@apple.com
  • 7 edits in trunk/Source/WebCore

Roll out r78424. It broke a bunch of tests.

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorMac::immediateScrollToPoint):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaX):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaY):

  • rendering/RenderLayer.cpp:
  • rendering/RenderLayer.h:

(WebCore::RenderLayer::contentsSize):

  • rendering/RenderListBox.cpp:
  • rendering/RenderListBox.h:
9:39 AM Changeset in webkit [78429] by weinig@apple.com
  • 13 edits in trunk/Source/WebKit2

Reviewed and landed by Sam Weinig.

Patch by Chris Fleizach <Chris Fleizach> on 2011-02-13
AX: Update WK2 usage of remote accessibility api
​https://bugs.webkit.org/show_bug.cgi?id=54220

Rename some of the remote accessibility methods to be more accurate.
Make sure to unregister the AccessibilityWebPageObject on dealloc.
Send the window remote token along with the WKView remote token.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::accessibilityWebProcessTokenReceived):

  • UIProcess/API/mac/WKView.mm:

(-[WKView _updateRemoteAccessibilityRegistration:]):
(-[WKView initWithFrame:contextRef:pageGroupRef:]):
(-[WKView viewDidMoveToWindow]):
(-[WKView _processDidCrash]):
(-[WKView _pageClosed]):
(-[WKView _setAccessibilityWebProcessToken:]):

  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::registerWebProcessAccessibilityToken):
(WebKit::WebPageProxy::registerUIProcessAccessibilityTokens):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/mac/AccessibilityWebPageObject.mm:

(-[AccessibilityWebPageObject dealloc]):

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::platformInitialize):
(WebKit::WebPage::registerUIProcessAccessibilityTokens):

2:12 AM Changeset in webkit [78428] by cwzwarich@webkit.org
  • 8 edits in trunk/Source

Reviewed by Dan Bernstein.

Bug 53760 - JSC fails to build with TOT Clang
​https://bugs.webkit.org/show_bug.cgi?id=53760

Fix -Woverloaded-virtual warnings. This is also a 6% speedup on the v8 raytrace
benchmark; it is nothing-to-noise on everything else.

JavaScriptCore:

  • API/JSCallbackObject.h: Remove pointlessly overloaded method.
  • API/JSCallbackObjectFunctions.h: Ditto.
  • runtime/Arguments.cpp:

(JSC::Arguments::put): Change signature to match the base class. This implementation
was no longer being called by anyone. This wasn't noticed because it is merely an
optimization of the base class' implementation.

  • runtime/Arguments.h: Ditto.

JavaScriptGlue:

  • UserObjectImp.cpp:

(UserObjectImp::toPrimitive): Use PreferredPrimitiveType instead of JSType to
match the base class.

  • UserObjectImp.h:
2:02 AM Changeset in webkit [78427] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-13 Shinichiro Hamaji <​hamaji@chromium.org>

Update chromium's test expectations for fast/inline/inline-box-background-*

  • platform/chromium/test_expectations.txt:

Feb 12, 2011:

8:01 PM Changeset in webkit [78426] by ap@apple.com
  • 11 edits in trunk/Source/WebKit2

Reviewed by Anders Carlsson.

​https://bugs.webkit.org/show_bug.cgi?id=54335
<rdar://problem/8895141> Make window.print() work with WebKit2

  • Platform/CoreIPC/Connection.h: Corrected a typo in FIXME comment.
  • UIProcess/ChunkedUpdateDrawingAreaProxy.cpp: (WebKit::ChunkedUpdateDrawingAreaProxy::setPageIsVisible): (WebKit::ChunkedUpdateDrawingAreaProxy::update): (WebKit::ChunkedUpdateDrawingAreaProxy::sendSetSize):
  • UIProcess/TiledDrawingAreaProxy.cpp: (WebKit::TiledDrawingAreaProxy::sizeDidChange): (WebKit::TiledDrawingAreaProxy::setPageIsVisible): (WebKit::TiledDrawingAreaProxy::takeSnapshot): (WebKit::TiledDrawingAreaProxy::removeTile):
  • UIProcess/LayerBackedDrawingAreaProxy.cpp: (WebKit::LayerBackedDrawingAreaProxy::sizeDidChange): (WebKit::LayerBackedDrawingAreaProxy::setPageIsVisible): (WebKit::LayerBackedDrawingAreaProxy::update):
  • UIProcess/WebContext.cpp: (WebKit::WebContext::ensureWebProcess): (WebKit::WebContext::postMessageToInjectedBundle): Updated for send() -> deprecatedSend() rename.
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::WebPageProxy): Added a flag that's true while serving window.print(). (WebKit::WebPageProxy::printFrame): Set and unset m_isPerformingDOMPrintOperation. (WebKit::WebPageProxy::beginPrinting): Force message processing in web process when serving window.print(). (WebKit::WebPageProxy::endPrinting): Ditto. (WebKit::WebPageProxy::computePagesForPrinting): Ditto. (WebKit::WebPageProxy::drawRectToPDF): Ditto. (WebKit::WebPageProxy::drawPagesToPDF): Ditto.
  • UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::~WebProcessProxy): (WebKit::WebProcessProxy::sendMessage): (WebKit::WebProcessProxy::didFinishLaunching): When waiting for a web process to launch, store message flags, too. This is not practically important for DispatchMessageEvenWhenWaitingForSyncReply, but it's easier to store flags than to remember about this pitfall.
  • UIProcess/WebProcessProxy.h: (WebKit::WebProcessProxy::send): Added a flags argument, matching Connection::send(). (WebKit::WebProcessProxy::deprecatedSend): Renamed one of send() overloads, because it was conflicting with the other one after adding a flags argument. This matches a change previously made to CoreIPC::Connection.
4:18 PM Changeset in webkit [78425] by cmarrin@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-02-12 Chris Marrin <​cmarrin@apple.com>

Reviewed by Dan Bernstein.

Crash in RenderLayerCompositor::updateCompositingLayers when loading some sites
​https://bugs.webkit.org/show_bug.cgi?id=54345

Some sites flip between composited and non-comosited state while loading. When the timing is
right, when we flip out of compositing we will need to do a display while tossing all the
compositing layers. This causes us to reenter RenderLayerCompositor::computeCompositingRequirements()
while we are in the middle of tossing layers, which leads to a crash.

The solution is to defer the logic of exiting compositing mode until the DrawingArea is finished
doing its display, using a timer.

  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::DrawingAreaImpl): (WebKit::DrawingAreaImpl::setRootCompositingLayer): (WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode): (WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode): (WebKit::DrawingAreaImpl::exitAcceleratedCompositingModeSoon):
  • WebProcess/WebPage/DrawingAreaImpl.h:
3:31 PM Changeset in webkit [78424] by weinig@apple.com
  • 7 edits in trunk/Source/WebCore

WK2: Extra scrolling required when scrolling with a scroll wheel (Mighty Mouse)
<rdar://problem/8984760>

Reviewed by Dan Bernstein.

When going down the smooth scroll path, constrained scrolls (such as those from a
Mighty Mouse) were being correctly constrained at the ScrollView level, but the
duplicate values being stored by the animator were not being constrained correctly.

In order to implement the constraint at this level, more of the ScrollableArea's API
needed to be filled in for RenderLayer and RenderListBox.

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::scrollToOffsetWithoutAnimation): Call immediateScrollToPoint to stay
consistent and get the desired behavior.

(WebCore::ScrollAnimatorMac::adjustScrollXPositionIfNecessary):
(WebCore::ScrollAnimatorMac::adjustScrollYPositionIfNecessary):
(WebCore::ScrollAnimatorMac::adjustScrollPositionIfNecessary):
(WebCore::ScrollAnimatorMac::immediateScrollToPoint):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaX):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaY):
Ensure that the scroll animators view of the current scroll position is the
same as the scrollable areas by correctly clamping the value.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::contentsSize): Correct implementation
to use the scroll size, not the visible size.
(WebCore::RenderLayer::visibleHeight):
(WebCore::RenderLayer::visibleWidth):

  • rendering/RenderLayer.h:
  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::visibleHeight):
(WebCore::RenderListBox::visibleWidth):

  • rendering/RenderListBox.h:

Add implementations for visibleHeight/visibleWidth.

2:42 PM Changeset in webkit [78423] by kdecker@apple.com
  • 2 edits in trunk/Source/WebKit2

Reviewed by Dan Bernstein.

Follow up fix to:
​https://bugs.webkit.org/show_bug.cgi?id=54341 - optionally scale snapshots in document view coordinates

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::scaledSnapshotInDocumentCoordinates): Fixed the order of the scale and translate.
2:13 PM Changeset in webkit [78422] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

2011-02-12 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

crypto.getRandomValues should support all integer array types
​https://bugs.webkit.org/show_bug.cgi?id=54342

Test which types of arrays work with crypto.getRandomValues.

  • security/crypto-random-values-types-expected.txt: Added.
  • security/crypto-random-values-types.html: Added.

2011-02-12 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

crypto.getRandomValues should support all integer array types
​https://bugs.webkit.org/show_bug.cgi?id=54342

As discussed on whatwg, we should support all the integer array types.

Test: security/crypto-random-values-types.html

  • page/Crypto.cpp: (WebCore::Crypto::getRandomValues):
1:35 PM Changeset in webkit [78421] by abarth@webkit.org
  • 5 edits in trunk/Source

2011-02-12 Adam Barth <​abarth@webkit.org>

Reviewed by Mark Rowe.

Use /dev/urandom as the OSRandomSource on OS(DARWIN)
​https://bugs.webkit.org/show_bug.cgi?id=54279

I'm not sure it makes much of a difference whether we use arc4random or
/dev/urandom on Mac. However, there's some aesthetic benefit to using
the same underlying API on as many platforms as reasonable.

  • config.h:
  • wtf/OSRandomSource.cpp: (WTF::cryptographicallyRandomValuesFromOS):

2011-02-12 Adam Barth <​abarth@webkit.org>

Reviewed by Mark Rowe.

Use /dev/urandom as the OSRandomSource on OS(DARWIN)
​https://bugs.webkit.org/show_bug.cgi?id=54279

Update the ifdef. OS(UNIX) includes OS(DARWIN), so this change is
should be a NOP.

  • config.h:
1:10 PM Changeset in webkit [78420] by chang.shu@nokia.com
  • 2 edits in trunk/Tools

2011-02-12 Chang Shu <​cshu@webkit.org>

Unreviewed.

Update my own email addresses and IRC nickname.

  • Scripts/webkitpy/common/config/committers.py:
12:46 PM Changeset in webkit [78419] by zmo@google.com
  • 8 edits in trunk/Source

2011-02-11 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

[chromium] Allow turning off multisampling through web preference settings
​https://bugs.webkit.org/show_bug.cgi?id=54321

  • public/WebSettings.h: Add a flag for multisampling setting.
  • src/WebSettingsImpl.cpp: Ditto. (WebKit::WebSettingsImpl::setOpenGLMultisamplingEnabled):
  • src/WebSettingsImpl.h: Ditto.

2011-02-11 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

[chromium] Allow turning off multisampling through web preference settings
​https://bugs.webkit.org/show_bug.cgi?id=54321

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::create): Disable multisampling in WebGL if web reference says so.
  • page/Settings.cpp: Add a flag for multisampling preference. (WebCore::Settings::Settings): (WebCore::Settings::setOpenGLMultisamplingEnabled):
  • page/Settings.h: Ditto. (WebCore::Settings::openGLMultisamplingEnabled):
12:32 PM Changeset in webkit [78418] by kdecker@apple.com
  • 5 edits in trunk/Source/WebKit2

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=54341 - optionally scale snapshots in document view coordinates
<rdar://problem/8990069>


  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePageCreateScaledSnapshotInDocumentCoordinates): Added.
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h: Added above new function.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::scaledSnapshotInDocumentCoordinates): Added. (WebKit::WebPage::snapshotInDocumentCoordinates): Call scaledSnapshotInDocumentCoordinates with a scale of 1.
  • WebProcess/WebPage/WebPage.h: Added scaledSnapshotInDocumentCoordinates().
4:37 AM Changeset in webkit [78417] by rniwa@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-02-12 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

Deploy EditingStyle in applyBlockStyle and applyInlineStyle
​https://bugs.webkit.org/show_bug.cgi?id=53911

Deployed EditingStyle in ApplyStyleCommand::applyBlockStyle and ApplyStyleCommand::applyInlineStyle.
Extracted EditingStyle::extractAndRemoveTextDirection from applyInlineStyle.
Also added propertiesToInclude to the argument list of EditingStyle's constructor that takes Node*
so that splitAncestorsWithUnicodeBidi can call EditingStyle::textDirection to obtain the text direction.

No new tests are added since this is a refactoring.

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::doApply): Passes EditingStyle* to applyBlockStyle and applyInlineStyle. (WebCore::ApplyStyleCommand::applyBlockStyle): Takes EditingStyle*. (WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi): Changed the type of allowedDirection from int to WritingDirection. Uses EditingStyle's textDirection to obtain the writing direction. (WebCore::ApplyStyleCommand::applyInlineStyle): Takes EditingStyle*. (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Allows style to be null; exit early instead. (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): Asserts that style is not null. (WebCore::ApplyStyleCommand::removeInlineStyle): Allows style to be null.
  • editing/ApplyStyleCommand.h: Includes WritingDirection.h; prototype changes.
  • editing/EditingStyle.cpp: (WebCore::EditingStyle::EditingStyle): Added PropertiesToInclude to the argument. (WebCore::EditingStyle::init): Supports PropertiesToInclude. (WebCore::EditingStyle::extractAndRemoveTextDirection): Extracted from applyInlineStyle.
  • editing/EditingStyle.h: (WebCore::EditingStyle::create): Supports PropertiesToInclude.
3:56 AM Changeset in webkit [78416] by jochen@chromium.org
  • 13 edits
    2 adds in trunk

2011-02-12 Jochen Eisinger <​jochen@chromium.org>

Reviewed by Jeremy Orlow.

Implement IDBObjectStore::clear
​https://bugs.webkit.org/show_bug.cgi?id=54193

  • storage/indexeddb/objectstore-clear-expected.txt: Added.
  • storage/indexeddb/objectstore-clear.html: Added.

2011-02-12 Jochen Eisinger <​jochen@chromium.org>

Reviewed by Jeremy Orlow.

Implement IDBObjectStore::clear
​https://bugs.webkit.org/show_bug.cgi?id=54193

Test: storage/indexeddb/objectstore-clear.html

  • storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::clear):
  • storage/IDBObjectStore.h:
  • storage/IDBObjectStore.idl:
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::clear): (WebCore::doDelete): (WebCore::IDBObjectStoreBackendImpl::clearInternal):
  • storage/IDBObjectStoreBackendImpl.h:
  • storage/IDBObjectStoreBackendInterface.h:

2011-02-12 Jochen Eisinger <​jochen@chromium.org>

Reviewed by Jeremy Orlow.

Implement IDBObjectStore::clear
​https://bugs.webkit.org/show_bug.cgi?id=54193

  • src/IDBObjectStoreProxy.cpp: (WebCore::IDBObjectStoreProxy::clear):
  • src/IDBObjectStoreProxy.h:
  • src/WebIDBObjectStoreImpl.cpp: (WebKit::WebIDBObjectStoreImpl::clear):
  • src/WebIDBObjectStoreImpl.h:
2:13 AM Changeset in webkit [78415] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-12 Adam Barth <​abarth@webkit.org>

Another attempt to fix the EFL build. Looks like we're missing one
more file.

  • CMakeLists.txt:
2:01 AM Changeset in webkit [78414] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-12 Adam Barth <​abarth@webkit.org>

Attempt to fix the EFL build. Apparently the CMake build had no
concept of ArrayBuffers.

  • CMakeLists.txt:
1:39 AM Changeset in webkit [78413] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-12 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed build fix.

  • dom/Range.cpp: (WebCore::lengthOfContentsInNode): Replaced static const unsigned LengthOfContentsInNode. (WebCore::Range::processContents): (WebCore::Range::processContentsBetweenOffsets):
1:36 AM Changeset in webkit [78412] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-12 Adam Barth <​abarth@webkit.org>

CPP files belong in SOURCES not in HEADERS. There are more errors like
this for other disabled features, but I'm not fixing them in this
patch.

  • WebCore.pro:
1:29 AM Changeset in webkit [78411] by abarth@webkit.org
  • 5 edits in trunk/LayoutTests

2011-02-12 Adam Barth <​abarth@webkit.org>

Update test expectations on Windows to account for ArrayBuffers being
on by default.

  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
  • platform/win/fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer-expected.txt:
  • platform/win/http/tests/xmlhttprequest/send-array-buffer-expected.txt:
1:18 AM Changeset in webkit [78410] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-12 Adam Barth <​abarth@webkit.org>

Apparently lines in .pro files need to be \-terminated.

  • WebCore.pro:
1:10 AM Changeset in webkit [78409] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-02-11 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

Extract a function to process contents for one node from Range::processContents
​https://bugs.webkit.org/show_bug.cgi?id=54282

Extracted Range::processContentsBetweenOffsets, which process contents of a node
between two offsets. This function is used for the simple case where the start
and the end containers are of the same node, and to process start and end containers
in the complex case.

When the function takes a non-null fragment (simple case), it appends the processed
contents to the fragment; character data and processing instruction's contents are copied
between the offsets, and descendants are copied for node of other types (not node itself).

When the fragment is null (complex case), the function copies contents of character data,
processing instruction, and node of other types (including node itself).

No new tests are added since this is a refactoring.

  • dom/Range.cpp: (WebCore::highestAncestorUnderCommonRoot): Added. (WebCore::Range::processContents): Calls highestAncestorUnderCommonRoot and processContentsBetweenOffsets. (WebCore::Range::processContentsBetweenOffsets): Added.
  • dom/Range.h:
1:07 AM Changeset in webkit [78408] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-12 Adam Barth <​abarth@webkit.org>

Attempt to fix the Qt Windows build.

  • WebCore.pro:
12:24 AM Changeset in webkit [78407] by abarth@webkit.org
  • 54 edits
    3 deletes in trunk

2011-02-12 Adam Barth <​abarth@webkit.org>

Reviewed by Kenneth Russell.

Enable ArrayBuffers by default
​https://bugs.webkit.org/show_bug.cgi?id=54310

Export the required functions.

2011-02-12 Adam Barth <​abarth@webkit.org>

Reviewed by Kenneth Russell.

Enable ArrayBuffers by default
​https://bugs.webkit.org/show_bug.cgi?id=54310

As discussed on webkit-dev, ArrayBuffers are used by a bunch of
different APIs, implemented by Firefox, and appear to be stable.
Keeping them conditional is a large mantainance burden than it's worth.

  • DerivedSources.cpp:
  • WebCore.vcproj/WebCore.vcproj:
  • bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setWebGLEnabled):
  • bindings/js/JSArrayBufferCustom.cpp:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSDOMWindowCustom.cpp:
  • bindings/js/JSDataViewCustom.cpp:
  • bindings/js/JSFloat32ArrayCustom.cpp:
  • bindings/js/JSInt16ArrayCustom.cpp:
  • bindings/js/JSInt32ArrayCustom.cpp:
  • bindings/js/JSInt8ArrayCustom.cpp:
  • bindings/js/JSUint16ArrayCustom.cpp:
  • bindings/js/JSUint32ArrayCustom.cpp:
  • bindings/js/JSUint8ArrayCustom.cpp:
  • bindings/v8/custom/V8ArrayBufferCustom.cpp:
  • bindings/v8/custom/V8ArrayBufferViewCustom.h:
  • bindings/v8/custom/V8DataViewCustom.cpp:
  • bindings/v8/custom/V8Float32ArrayCustom.cpp:
  • bindings/v8/custom/V8Int16ArrayCustom.cpp:
  • bindings/v8/custom/V8Int32ArrayCustom.cpp:
  • bindings/v8/custom/V8Int8ArrayCustom.cpp:
  • bindings/v8/custom/V8Uint16ArrayCustom.cpp:
  • bindings/v8/custom/V8Uint32ArrayCustom.cpp:
  • bindings/v8/custom/V8Uint8ArrayCustom.cpp:
  • html/canvas/ArrayBuffer.cpp:
  • html/canvas/ArrayBuffer.idl:
  • html/canvas/ArrayBufferView.cpp:
  • html/canvas/ArrayBufferView.idl:
  • html/canvas/DataView.cpp:
  • html/canvas/DataView.idl:
  • html/canvas/Float32Array.cpp:
  • html/canvas/Float32Array.idl:
  • html/canvas/Int16Array.cpp:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.cpp:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.cpp:
  • html/canvas/Int8Array.idl:
  • html/canvas/Uint16Array.cpp:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.cpp:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.cpp:
  • html/canvas/Uint8Array.idl:
  • page/Crypto.cpp: (WebCore::Crypto::getRandomValues):
  • page/Crypto.h:
  • page/Crypto.idl:
  • page/DOMWindow.idl:
  • workers/WorkerContext.idl:

2011-02-12 Adam Barth <​abarth@webkit.org>

Reviewed by Kenneth Russell.

Enable ArrayBuffers by default
​https://bugs.webkit.org/show_bug.cgi?id=54310

Revert incorrect expectations from
​http://trac.webkit.org/changeset/78337. These results were cased by
ArrayBuffers not beign enabled on Windows previous to this patch.

  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/js/global-function-resolve-expected.txt: Removed.
  • platform/win/fast/js/var-declarations-shadowing-expected.txt: Removed.
  • platform/win/security: Removed.
  • platform/win/security/crypto-random-values-expected.txt: Removed.
Note: See TracTimeline for information about the timeline view.