⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 14, 2011:

9:53 PM Changeset in webkit [78531] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-02-14 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

allow for modifying comments without the mouse
​https://bugs.webkit.org/show_bug.cgi?id=54433

Use n/p to navigate the comments.
Enter to begin editing a comment.
Escape to finish editing a comment.

  • code-review.js:
9:46 PM Changeset in webkit [78530] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-02-14 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

improve line selection in the code review tool
​https://bugs.webkit.org/show_bug.cgi?id=54430

-shift+click now extends the comment context
-selecting outside of a diff section no longer clears the selected lines.

Instead it just restricts the selected lines to that diff section.

  • code-review.js:
7:04 PM WebKit Team edited by kalman@chromium.org
Add myself to committers list (diff)
6:30 PM Changeset in webkit [78529] by mihaip@chromium.org
  • 10 edits in branches/chromium/648/Source/WebCore

Roll out r74807 (in the 648 branch only).

BUG=68516
TBR=​kerz@chromium.org

6:23 PM Changeset in webkit [78528] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-02-14 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, build fix.

Fix minor regression introduced in r78522. For some reason, Python
provides a platform.mac_ver() routine on Linux, so we need to
check to make sure it's returning something in addition to
checking for its existence.

  • Scripts/webkitpy/layout_tests/port/mac.py:
5:49 PM Changeset in webkit [78527] by jorlow@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-14 Jeremy Orlow <​jorlow@chromium.org>

efl build fix

  • CMakeLists.txt:
5:38 PM Changeset in webkit [78526] by andersca@apple.com
  • 8 edits in trunk/Source/WebKit2

2011-02-14 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Add WKPageSetMemoryCacheClientCallsEnabled API
​https://bugs.webkit.org/show_bug.cgi?id=54422

  • UIProcess/API/C/WKPage.cpp: (WKPageSetMemoryCacheClientCallsEnabled):
  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setMemoryCacheClientCallsEnabled):
  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::setMemoryCacheMessagesEnabled):
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
5:18 PM Changeset in webkit [78525] by jorlow@chromium.org
  • 81 edits
    2 moves
    11 deletes in trunk

2011-02-11 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Nate Chapin.

Finish up implementing the new event model in IndexedDB
​https://bugs.webkit.org/show_bug.cgi?id=54331

Make the requried changes + s/result/request/g (where it should
have always been that way) + remove the verify functions (since
these days they mostly just add noise) + get rid of the callback
in the delete object store funciton.

  • storage/indexeddb/basics-expected.txt:
  • storage/indexeddb/basics.html:
  • storage/indexeddb/create-and-remove-object-store-expected.txt:
  • storage/indexeddb/create-and-remove-object-store.html:
  • storage/indexeddb/create-object-store-options-expected.txt:
  • storage/indexeddb/create-object-store-options.html:
  • storage/indexeddb/cursor-delete-expected.txt:
  • storage/indexeddb/cursor-delete.html:
  • storage/indexeddb/cursor-index-delete-expected.txt:
  • storage/indexeddb/cursor-index-delete.html:
  • storage/indexeddb/cursor-skip-deleted-expected.txt:
  • storage/indexeddb/cursor-skip-deleted.html:
  • storage/indexeddb/cursor-update-expected.txt:
  • storage/indexeddb/cursor-update.html:
  • storage/indexeddb/data-corruption-expected.txt:
  • storage/indexeddb/data-corruption.html:
  • storage/indexeddb/database-basics-expected.txt:
  • storage/indexeddb/database-basics.html:
  • storage/indexeddb/database-quota-expected.txt:
  • storage/indexeddb/database-quota.html:
  • storage/indexeddb/duplicates-expected.txt:
  • storage/indexeddb/duplicates.html:
  • storage/indexeddb/error-causes-abort-by-default-expected.txt:
  • storage/indexeddb/error-causes-abort-by-default.html:
  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics.html:
  • storage/indexeddb/index-cursor-expected.txt:
  • storage/indexeddb/index-cursor.html:
  • storage/indexeddb/objectstore-autoincrement-expected.txt:
  • storage/indexeddb/objectstore-autoincrement.html:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/objectstore-cursor-expected.txt:
  • storage/indexeddb/objectstore-cursor.html:
  • storage/indexeddb/objectstore-removeobjectstore-expected.txt:
  • storage/indexeddb/objectstore-removeobjectstore.html:
  • storage/indexeddb/open-cursor-expected.txt:
  • storage/indexeddb/open-cursor.html:
  • storage/indexeddb/queued-commands-expected.txt:
  • storage/indexeddb/queued-commands.html:
  • storage/indexeddb/request-event-propagation-expected.txt:
  • storage/indexeddb/request-event-propagation.html:
  • storage/indexeddb/resources/shared.js: (unexpectedSuccessCallback): (unexpectedErrorCallback): (unexpectedAbortCallback): (unexpectedCompleteCallback): (evalAndExpectException): (deleteAllObjectStores):
  • storage/indexeddb/transaction-after-close-expected.txt:
  • storage/indexeddb/transaction-after-close.html:
  • storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
  • storage/indexeddb/transaction-and-objectstore-calls.html:
  • storage/indexeddb/transaction-basics-expected.txt:
  • storage/indexeddb/transaction-basics.html:
  • storage/indexeddb/transaction-crash-on-abort-expected.txt:
  • storage/indexeddb/transaction-crash-on-abort.html:
  • storage/indexeddb/transaction-event-propagation-expected.txt:
  • storage/indexeddb/transaction-event-propagation.html:
  • storage/indexeddb/transaction-read-only-expected.txt:
  • storage/indexeddb/transaction-read-only.html:
  • storage/indexeddb/tutorial.html:

2011-02-11 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Nate Chapin.

Finish up implementing the new event model in IndexedDB
​https://bugs.webkit.org/show_bug.cgi?id=54331

We shouldn't have our own event subclasses. Instead, we
should just fire Event's with the proper type and bubble
settings. All the attributes on the events before should
just be on the request. IDBRequest should throw if they're
accessed before the success event fires.

  • WebCore.gypi:
  • bindings/generic/RuntimeEnabledFeatures.h:
  • bindings/js/JSEventCustom.cpp: (WebCore::toJS):
  • bindings/v8/custom/V8EventCustom.cpp: (WebCore::toV8):
  • dom/Event.cpp:
  • dom/Event.h:
  • page/DOMWindow.idl:
  • storage/IDBAbortEvent.h: Removed.
  • storage/IDBCompleteEvent.cpp: Removed.
  • storage/IDBCompleteEvent.h: Removed.
  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::~IDBDatabase):
  • storage/IDBDatabaseException.h:
  • storage/IDBDatabaseException.idl:
  • storage/IDBErrorEvent.cpp: Removed.
  • storage/IDBErrorEvent.h: Removed.
  • storage/IDBErrorEvent.idl: Removed.
  • storage/IDBEvent.h: Removed.
  • storage/IDBEvent.idl: Removed.
  • storage/IDBEventDispatcher.cpp: (WebCore::IDBEventDispatcher::dispatch):
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::IDBRequest): (WebCore::IDBRequest::result): (WebCore::IDBRequest::errorCode): (WebCore::IDBRequest::webkitErrorMessage): (WebCore::IDBRequest::source): (WebCore::IDBRequest::transaction): (WebCore::IDBRequest::readyState): (WebCore::IDBRequest::resetReadyState): (WebCore::IDBRequest::onError): (WebCore::createSuccessEvent): (WebCore::IDBRequest::onSuccess): (WebCore::IDBRequest::dispatchEvent):
  • storage/IDBRequest.h:
  • storage/IDBRequest.idl:
  • storage/IDBSuccessEvent.cpp: Removed.
  • storage/IDBSuccessEvent.h: Removed.
  • storage/IDBSuccessEvent.idl: Removed.
  • storage/IDBTransaction.cpp: (WebCore::IDBTransaction::onAbort): (WebCore::IDBTransaction::onComplete): (WebCore::IDBTransaction::dispatchEvent):
5:14 PM Changeset in webkit [78524] by kalman@chromium.org
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Unreviewed. Add myself to the list of committers.

4:03 PM Changeset in webkit [78523] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

WebKit2: View not updated completely when coming back from a cached back/forward navigation
<rdar://problem/8787264>
​https://bugs.webkit.org/show_bug.cgi?id=54419

Reviewed by Anders Carlsson.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::restoreViewState): Invalidate the entire page
when completing a restore from the back/forward cache.

4:03 PM Changeset in webkit [78522] by dpranke@chromium.org
  • 16 edits in trunk/Tools

2011-02-14 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Mihai Parparita.

Clean up the way we handle platform names in
new-run-webkit-tests. Previously, if you specified
'--platform mac' or '--platform chromium-mac' on the command
line, it would use that platform name to determine baseline search
paths, etc. This is almost never the right thing to do, because
it ignores the existence of version-specific baselines.

So, I changed this so that ports that support versions must
always use a version, and the version should default to the
version of the operating system that the port is being run on
(e.g., if you're running on Leopard, then passing '--platform
mac' will default to the 'mac-leopard' port). This means that
port.name() should always include a version-specific suffix if
the port supports versions.

However, we still support things like '--platform mac' as input
so that the user doesn't have to explicitly specify a version,
both for convenience and so we don't have to make buildbot
configs more complicated than they already are.

Also, I cleaned up how the baselines were being searched
on the chromium-mac port (this is one of the two bugs that
prompted this refactoring), and made the logic easier to follow
and more consistent across the mac and chromium ports

Lastly, I added a port.get_all_names() method that could be used
to get the names of all of the ports to search, rather than having
to guess (incorrectly) from the list of directories under
LayoutTests/platform (this last thing was necessary because the
deduplicate_tests unittest broke as the fallback dirs changed).

​https://bugs.webkit.org/show_bug.cgi?id=54248

  • Scripts/webkitpy/layout_tests/deduplicate_tests.py:
  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/port/factory_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
4:01 PM Changeset in webkit [78521] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, Chromium test expectations update.

​https://bugs.webkit.org/show_bug.cgi?id=54418
Fix a Linux expectation, mark another test as expected-failing.

  • platform/chromium/test_expectations.txt:
3:59 PM Changeset in webkit [78520] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-02-14 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Adam Barth.

update-webkit hangs in a git-only checkout

Previously it would hang forever trying to do a 'git svn
rebase'. Now, it will default to a 'git pull' if the
svn-remote.svn.fetch variable isn't set, and bail out if it
doesn't know where to pull from.

​https://bugs.webkit.org/show_bug.cgi?id=54265

  • Scripts/update-webkit:
  • Scripts/VCSUtils.pm:
3:51 PM Changeset in webkit [78519] by alex
  • 2 edits in trunk/Source/WebKit/gtk

2011-02-14 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Xan Lopez.

[GTK] testwebdatasource test fails in the bots
​https://bugs.webkit.org/show_bug.cgi?id=54414

Changed the uri we check, added www to avoid the rewrite that we
get when we as the uri to the request in case it finishes.

  • tests/testwebdatasource.c: (notify_load_status_cb):
3:46 PM Changeset in webkit [78518] by alex
  • 10 edits in trunk/LayoutTests

2011-02-14 Alejandro G. Castro <​alex@igalia.com>

Unreviewed, rolling out r78516.
​http://trac.webkit.org/changeset/78516

The rebaseline was previously done

  • platform/gtk/fast/css/rtl-ordering-expected.checksum:
  • platform/gtk/fast/css/rtl-ordering-expected.png:
  • platform/gtk/fast/css/rtl-ordering-expected.txt:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.checksum:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.png:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
  • platform/gtk/fast/forms/visual-hebrew-text-field-expected.checksum:
  • platform/gtk/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/gtk/fast/forms/visual-hebrew-text-field-expected.txt:
3:35 PM Changeset in webkit [78517] by enrica@apple.com
  • 2 edits in trunk/Source/WebCore

Copy/paste from a WebKit window to a TextEdit window loses fonts.
<rdar://problem/8623090>
​https://bugs.webkit.org/show_bug.cgi?id=54416

Reviewed by Dan Bernstein.

We don't have the complete solution that fixes this problem for WebKit2 yet.
This patch fixes the regression in WebKit.

  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::writeSelection): For WebKit2 use only plain text,
for WebKit use the original API to create the NSAttributedString.

3:29 PM Changeset in webkit [78516] by alex
  • 10 edits in trunk/LayoutTests

2011-02-14 Alejandro G. Castro <​alex@igalia.com>

Unreviewed. Rebaseline GTK test results after r78491.

  • platform/gtk/fast/css/rtl-ordering-expected.checksum:
  • platform/gtk/fast/css/rtl-ordering-expected.png:
  • platform/gtk/fast/css/rtl-ordering-expected.txt:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.checksum:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.png:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
  • platform/gtk/fast/forms/visual-hebrew-text-field-expected.checksum:
  • platform/gtk/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/gtk/fast/forms/visual-hebrew-text-field-expected.txt:
3:15 PM Changeset in webkit [78515] by leviw@chromium.org
  • 17 edits
    3 adds in trunk

2011-02-14 Levi Weintraub <​leviw@chromium.org>

Reviewed by Alexey Proskuryakov.

Strikethrough disappears when posting a message on odnoklassniki.ru
​https://bugs.webkit.org/show_bug.cgi?id=53475

Changing the behavior of the strikethrough execCommand when styleWithCSS
is false. We formerly created <s> tags, which was different than both IE
and FF and caused problems with some rich text editors that would strip
out unexpected tags such as <s>.

Test: editing/execCommand/strikethrough-uses-strike-tag.html

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):

2011-02-14 Levi Weintraub <​leviw@chromium.org>

Reviewed by Alexey Proskuryakov.

Strikethrough disappears when posting a message on odnoklassniki.ru
​https://bugs.webkit.org/show_bug.cgi?id=53475

Updating test expectations and creating a test in an attempt to prevent the
uninformed WebKit dev from switching back to using <s> tags for strikethrough.
As explained in the bug, this is bad for compatibility with various rich text
editors.

  • editing/execCommand/query-text-decoration-with-typing-style-expected.txt:
  • editing/execCommand/script-tests/strikethrough-uses-strike-tag.js: Added. (test):
  • editing/execCommand/script-tests/toggle-style-2.js:
  • editing/execCommand/strikethrough-uses-strike-tag-expected.txt: Added.
  • editing/execCommand/strikethrough-uses-strike-tag.html: Added.
  • editing/execCommand/strikethroughSelection-expected.txt:
  • editing/execCommand/toggle-style-2-expected.txt:
  • editing/style/inline-style-container-expected.txt:
  • editing/style/inline-style-extend-run-expected.txt:
  • editing/style/push-down-implicit-styles-around-list-expected.txt:
  • editing/style/push-down-implicit-styles-expected.txt:
  • editing/style/script-tests/inline-style-container.js:
  • editing/style/script-tests/inline-style-extend-run.js:
  • editing/style/script-tests/push-down-implicit-styles-around-list.js:
  • editing/style/script-tests/push-down-implicit-styles.js:
  • editing/style/style-text-node-without-editable-parent-expected.txt:
3:02 PM Changeset in webkit [78514] by enrica@apple.com
  • 1 edit in trunk/Source/WebCore/WebCore.exp.in

Build fix. Unreviewed.

3:01 PM Changeset in webkit [78513] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-02-14 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Shared memory should be made shared immediately
​https://bugs.webkit.org/show_bug.cgi?id=54413
<rdar://problem/8972153>

Under some circumstances, mach_make_memory_entry_64 may only return parts of a
memory allocation. Work around this by creating a mach port representing the shared memory
right away. Also, hand out this mach port in createHandle when using the default memory protection.

  • Platform/SharedMemory.h:
  • Platform/mac/SharedMemoryMac.cpp: (WebKit::SharedMemory::create): (WebKit::SharedMemory::~SharedMemory): (WebKit::SharedMemory::createHandle):
2:58 PM Changeset in webkit [78512] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-02-14 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Mihai Parparita.

This patch modifies NRWT's Worker clas to use the new
WorkerMixin class to actually run tests. With this patch, the
multiprocess version of NRWT is fully functional and just needs
the values for --worker-model and --child-processes to be corrected
in the port/* classes to start using the new code by default.

​https://bugs.webkit.org/show_bug.cgi?id=54082

  • Scripts/webkitpy/layout_tests/layout_package/worker.py:
2:56 PM Changeset in webkit [78511] by dpranke@chromium.org
  • 3 edits
    1 add in trunk/Tools

2011-02-14 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Mihai Parparita.

This patch shuffles code out of dump_render_tree_thread and
single_test_runner and into a new worker_mixin class that will
be shared by both TestShellThread and Worker. This change
restores single_test_runner to its state as of r77606 - it is
stateless again. It also prunes TestShellThread to pretty much
just the logic used for the original shared-memory access.

​https://bugs.webkit.org/show_bug.cgi?id=54079

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py: Added.
2:56 PM Changeset in webkit [78510] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, Chromium test expectations update.

Try using the right syntax this time.

  • platform/chromium/test_expectations.txt:
2:26 PM Changeset in webkit [78509] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, Chromium test expectations update.

  • platform/chromium/test_expectations.txt:
2:20 PM Changeset in webkit [78508] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

Remove dead code in FormDataStreamCFNet.cpp
​https://bugs.webkit.org/show_bug.cgi?id=54401

Reviewed by Darin Adler.

The static functions in this file are no longer reachable. We added a conditional branch to
use new CFNetwork functions in r30329 and later made that code path permanent in r41517
which made these functions unreachable.

  • platform/network/cf/FormDataStreamCFNet.cpp:
2:15 PM Changeset in webkit [78507] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-02-14 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Ojan Vafai.

This patch updates NRWT to add per-worker and per-shard test stats
into TestRunner2, bringing it to parity with TestRunner.

​https://bugs.webkit.org/show_bug.cgi?id=54074

  • Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
2:13 PM Changeset in webkit [78506] by dpranke@chromium.org
  • 5 edits in trunk/Tools

2011-02-14 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Tony Chang.

nrwt multiprocessing: add code to handle interrupts and wedged
threads.
​https://bugs.webkit.org/show_bug.cgi?id=54072

  • Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py: Adds the cancel(), is_alive(), join(), and log_wedged_worker() methods to the WorkerConnection class
  • Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
  • Scripts/webkitpy/layout_tests/layout_package/worker.py: Adds the cancel() method to the Worker class
2:08 PM Changeset in webkit [78505] by pkasting@chromium.org
  • 2 edits in branches/chromium/648/Source/WebCore

Merge 78431 - Some Scrollbar functions assume an attached ScrollableArea but can be called without one
​https://bugs.webkit.org/show_bug.cgi?id=54262

Reviewed by Dan Bernstein.

Make sure that all calls to the scrollable area are null checked.

  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::autoscrollPressedPart):
(WebCore::Scrollbar::moveThumb):
(WebCore::Scrollbar::mouseMoved):

TBR=​weinig@apple.com
Review URL: ​http://codereview.chromium.org/6523001

1:55 PM Changeset in webkit [78504] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, Chromium test expectations update.

​https://bugs.webkit.org/show_bug.cgi?id=54409
Mark tests as failing due to r78484.

  • platform/chromium/test_expectations.txt:
1:54 PM Changeset in webkit [78503] by andreas.kling@nokia.com
  • 4 edits in trunk/Source/WebCore

2011-02-14 Andreas Kling <​kling@webkit.org>

Reviewed by Darin Adler.

GraphicsContext: Add clip(IntRect) overload for Qt
​https://bugs.webkit.org/show_bug.cgi?id=54365

Qt has special code paths for clipping to integer rectangles.
Add a GraphicsContext::clip() overload to allow us to take
advantage of the optimized code.

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::clip):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::clip):
1:48 PM Changeset in webkit [78502] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-02-14 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Tony Chang.

update the NRWT multiprocessing code to spawn multiple workers
instead of just using one.

​https://bugs.webkit.org/show_bug.cgi?id=54071

  • Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
1:44 PM QtWebKit edited by andreas.kling@nokia.com
(diff)
1:29 PM Changeset in webkit [78501] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Some MarkedBlock refactoring.

Rubber-stamped by Gavin Barraclough.

Made cells private.

Renamed cells => m_cells

marked => m_marks.

  • runtime/JSCell.h:

(JSC::JSCell::MarkedBlock::allocate):

  • runtime/MarkedBlock.cpp:

(JSC::MarkedBlock::destroy):
(JSC::MarkedBlock::MarkedBlock):
(JSC::MarkedBlock::sweep):

  • runtime/MarkedBlock.h:

(JSC::MarkedBlock::isEmpty):
(JSC::MarkedBlock::clearMarks):
(JSC::MarkedBlock::markCount):
(JSC::MarkedBlock::isMarked):
(JSC::MarkedBlock::testAndSetMarked):
(JSC::MarkedBlock::setMarked):
(JSC::MarkedBlock::forEach):

1:28 PM Webkit2Innards edited by siddharth.mathur@nokia.com
(diff)
1:27 PM Changeset in webkit [78500] by xji@chromium.org
  • 10 edits in trunk/LayoutTests

2011-02-14 Xiaomei Ji <​xji@chromium.org>

Unreviewed.
Rebaseline after r78491. Since select-visual-hebrew.html and visual-hebrew-text-field.html
are marked as FAIL in Chromium WIN and LINUX, rebaseline for them are done manually and
only changed the part related to r78491.

  • platform/chromium-linux/fast/css/rtl-ordering-expected.txt:
  • platform/chromium-linux/fast/forms/select-visual-hebrew-expected.txt:
  • platform/chromium-linux/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/chromium-win/fast/css/rtl-ordering-expected.txt:
  • platform/chromium-win/fast/forms/select-visual-hebrew-expected.txt:
  • platform/chromium-win/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/gtk/fast/css/rtl-ordering-expected.txt:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
  • platform/gtk/fast/forms/visual-hebrew-text-field-expected.txt:
1:23 PM Changeset in webkit [78499] by Darin Adler
  • 6 edits in trunk/Source/WebCore

2011-02-14 Darin Adler <Darin Adler>

Reviewed by Alexey Proskuryakov.

Add built-in decoder for UTF-8 for improved performance
​https://bugs.webkit.org/show_bug.cgi?id=53898

Covered by existing tests; not adding new tests at this time.

This patch now handles errors in the same way the existing codecs do,
and so passes our tests. The first version failed some tests because
of incorrect error handling. The second version was missing one line
of code that made it decode incomplete sequences at the end of the
buffer twice.

  • platform/text/TextCodecICU.cpp: (WebCore::create): Renamed from newTextCodecICU, made a static member function, and added a call to adoptPtr. (WebCore::TextCodecICU::registerEncodingNames): Renamed from registerExtendedEncodingNames since this class is no longer used for base codecs. Removed aliases for UTF-8; now handled by TextCodecUTF8. (WebCore::TextCodecICU::registerCodecs): Renamed. (WebCore::fallbackForGBK): Renamed to conform to our current style.
  • platform/text/TextCodecICU.h: Updated for above changes. Changed indentation. Made most functions private, including virtual function overrides. Marked ICUConverterWrapper noncopyable.
  • platform/text/TextCodecUTF8.cpp: (WebCore::TextCodecUTF8::registerEncodingNames): Added the UTF-8 aliases that were formerly added by TextCodecICU. (WebCore::nonASCIISequenceLength): Fixed bug where this would return 4 for bytes F5-FF instead of failing. (WebCore::decodeNonASCIISequence): Tweaked coding style. (WebCore::appendCharacter): Added. Makes it easier to share code between the partial-character handling and main loop. (WebCore::TextCodecUTF8::decode): Fixed buffer size computation for case where there is a partial sequence. Fixed partial sequence handling so that goto is no longer needed, since compilers sometimes make poor code when goto is involved. Added a loop for partial sequences since we consume only one byte when a partial sequence is invalid. Fixed logic in main decoding loop so goto is not needed. Used early-exit style in both loops so the main flow is not nested inside if statements. Added correct error handling for flush when a partial sequence remains, which involved wrapping the function in yet another loop.
  • platform/text/TextCodecUTF8.h: Made virtual function overrides private.
  • platform/text/TextEncodingRegistry.cpp: (WebCore::buildBaseTextCodecMaps): Added calls to TextCodecUTF8. Removed calls to TextCodecICU. Added FIXMEs for other codecs that no longer need to be included here. (WebCore::extendTextCodecMaps): Updated for the name change of the TextCodecICU functions.
1:13 PM Changeset in webkit [78498] by bweinstein@apple.com
  • 5 edits in trunk/Source/WebKit/win

Need WebKit API to determine whether we have a site icon for a given URL
​https://bugs.webkit.org/show_bug.cgi?id=54400

Reviewed by Brady Eidson.

This patch implements IWebIconDatabase::hasIconForURL which tells us whether or not
we have a site icon for the given URL.

  • Interfaces/IWebIconDatabase.idl: Added new function.
  • Interfaces/WebKit.idl: Touched to make sure Interfaces rebuilds.
  • WebIconDatabase.cpp:

(WebIconDatabase::hasIconForURL): Call IconDatabase::iconForPageURL to make sure we

load the icon from disk, and call iconURLForPageURL to determine whether or not
we actually have an icon.

  • WebIconDatabase.h:
12:48 PM Changeset in webkit [78497] by abarth@webkit.org
  • 5 edits in trunk/Source

2011-02-14 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add basic parser for Content Security Policy
​https://bugs.webkit.org/show_bug.cgi?id=54379

Add a constructor for copying a Vector into a String. I suspect there
are a number of call sites that are doing this manually that would
benefit from being moved to this API.

  • wtf/text/WTFString.h: (WTF::String::String):

2011-02-14 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add basic parser for Content Security Policy
​https://bugs.webkit.org/show_bug.cgi?id=54379

The parser in this patch is very basic. It just segments the CSP
header into directives. The exactly syntax will likely change a bit as
we discuss the details in public-web-security, but this parser will
allow us to make progress.

Sadly, this patch does not contain any tests. That's because CSP
policies do not have any observable effects yet. Hopefully we'll get
enough sketched out in the next couple patches to begin writing tests.

  • page/ContentSecurityPolicy.cpp: (WebCore::CSPDirective::CSPDirective): (WebCore::CSPDirective::name): (WebCore::CSPDirective::value): (WebCore::ContentSecurityPolicy::~ContentSecurityPolicy): (WebCore::ContentSecurityPolicy::didReceiveHeader): (WebCore::ContentSecurityPolicy::parse):
  • page/ContentSecurityPolicy.h:
12:19 PM Webkit2Innards edited by siddharth.mathur@nokia.com
(diff)
12:03 PM Changeset in webkit [78496] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-14 Tony Chang <​tony@chromium.org>

Unreviewed, updating chromium test expectations, missed a test
in my last checkin.

  • platform/chromium/test_expectations.txt:
11:48 AM Changeset in webkit [78495] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk/Source/WebCore

2011-02-14 Andrew Wason <​rectalogic@rectalogic.com>

Reviewed by Kenneth Russell.

[Qt] WebKit fails to compile for Qt when WebGL enabled
​https://bugs.webkit.org/show_bug.cgi?id=53431

No new tests.

  • WebCore.pro: Add source and header files and include directory to Qt project.
  • html/canvas/WebGLRenderingContext.cpp: File uses 'emit' which is a Qt keyword - #undef emit.
  • platform/graphics/gpu/qt: Added.
  • platform/graphics/gpu/qt/DrawingBufferQt.cpp: Added. Partial implementation of DrawingBuffer for Qt. (WebCore::DrawingBuffer::DrawingBuffer): (WebCore::DrawingBuffer::~DrawingBuffer): (WebCore::DrawingBuffer::didReset): (WebCore::DrawingBuffer::platformLayer): (WebCore::DrawingBuffer::platformColorBuffer):
  • platform/graphics/qt/Extensions3DQt.cpp: Noop implementation for pure virtual methods added to Extensions3D.h (WebCore::Extensions3DQt::blitFramebuffer): (WebCore::Extensions3DQt::renderbufferStorageMultisample):
  • platform/graphics/qt/Extensions3DQt.h: Declare new methods added to Extensions3D.h
  • platform/graphics/qt/GraphicsContext3DQt.cpp: Remove method implementations no longer in GraphicsContext3D.h. Change m_syntheticErrors to use unsigned int to match new GC3Denum type. (WebCore::GraphicsContext3D::create): Change return type to match GraphicsContext3D.h (WebCore::GraphicsContext3D::lineWidth): Change argument type to GC3Dfloat to match GraphicsContext3D.h (WebCore::GraphicsContext3D::getUniformLocation): Change return type to GC3Dfloat to match GraphicsContext3D.h (WebCore::GraphicsContext3D::getExtensions): Need to call get() on OwnPtr. (WebCore::GraphicsContext3D::getImageData): Rename enum values to match declarations in GraphicsContext3D.h
11:45 AM Changeset in webkit [78494] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-02-14 Jay Soffian <​jaysoffian@gmail.com>

Reviewed by Darin Fisher.

Expose checked field of HTMLInputElement to Chromium API
​https://bugs.webkit.org/show_bug.cgi?id=54333

  • public/WebInputElement.h:
  • src/WebInputElement.cpp:
11:40 AM Changeset in webkit [78493] by tony@chromium.org
  • 8 edits in trunk

2011-02-14 Tony Chang <​tony@chromium.org>

Reviewed by Dimitri Glazkov.

<select> elements don't honor border:0px in chromium-linux
​https://bugs.webkit.org/show_bug.cgi?id=51152

No new tests, covered by existing pixel results (fast/forms/basic-selects.html
convers lots of cases).

2011-02-14 Tony Chang <​tony@chromium.org>

Reviewed by Dimitri Glazkov.

<select> elements don't honor border:0px in chromium-linux
​https://bugs.webkit.org/show_bug.cgi?id=51152

  • public/linux/WebThemeEngine.h:
  • src/PlatformBridge.cpp: (WebCore::GetWebThemeExtraParams):
11:25 AM Changeset in webkit [78492] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, Chromium test expectations update.

​http://code.google.com/p/v8/issues/detail?id=1154
Temporarily mark a test as failing due to a new V8 version.

  • platform/chromium/test_expectations.txt:
11:21 AM Changeset in webkit [78491] by xji@chromium.org
  • 7 edits
    2 adds in trunk

2011-02-14 Xiaomei Ji <​xji@chromium.org>

Reviewed by Dan Bernstein.

Fix rendering of ISO-8859-8 when dir="rtl".
​https://bugs.webkit.org/show_bug.cgi?id=52128

Test: fast/text/international/iso-8859-8.html

  • platform/text/BidiResolver.h: Add VisualDirectionOverride enum. (WebCore::::createBidiRunsForLine): For lines with visual direction override, create bidi runs without resolving bidi levels (one run per render object), set bidi level as 0 or 1 depending on LTR or RTL override, and reverse runs for RTL override.
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::constructLine): Set inline box bidi level the same as BidiRun's bidi level without special handling of VisualDirectionOverride. (WebCore::RenderBlock::layoutInlineChildren): Pass in VisualDirectionOverride to createBidiRunsForLine().

2011-02-14 Xiaomei Ji <​xji@chromium.org>

Reviewed by Dan Bernstein.

Fix rendering of ISO-8859-8 when dir="rtl".
​https://bugs.webkit.org/show_bug.cgi?id=52128

  • fast/text/international/iso-8859-8-expected.txt: Added.
  • fast/text/international/iso-8859-8.html: Added.
  • platform/mac/fast/css/rtl-ordering-expected.txt:
  • platform/mac/fast/forms/select-visual-hebrew-expected.txt:
  • platform/mac/fast/forms/visual-hebrew-text-field-expected.txt:
11:02 AM Webkit2Innards edited by siddharth.mathur@nokia.com
(diff)
10:52 AM Changeset in webkit [78490] by commit-queue@webkit.org
  • 4 edits in trunk/Source

2011-02-14 Alexis Menard <​alexis.menard@nokia.com>

Reviewed by Andreas Kling.

[Qt] Crash on application exit after constructing and destroying a QWebView twice
​https://bugs.webkit.org/show_bug.cgi?id=54000

Check the value is valid before use it.

  • platform/qt/SharedTimerQt.cpp: (WebCore::SharedTimerQt::~SharedTimerQt):

2011-02-14 Alexis Menard <​alexis.menard@nokia.com>

Reviewed by Andreas Kling.

[Qt] Crash on application exit after constructing and destroying a QWebView twice
​https://bugs.webkit.org/show_bug.cgi?id=54000

Test case to cover the crash.

  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::deleteQWebViewTwice):
10:29 AM Webkit2Innards edited by siddharth.mathur@nokia.com
(diff)
10:28 AM Webkit2Innards created by siddharth.mathur@nokia.com
10:25 AM Changeset in webkit [78489] by Adam Roben
  • 2 edits in trunk/Source/WebKit2

React to accelerated compositing changes and allocation failures in DrawingAreaImpl::display

Fixes <​http://webkit.org/b/54398> DrawingAreaImpl::display handles error cases poorly.

Reviewed by Darin Adler and Anders Carlsson.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::display): Bail out if the layout we perform puts us into
accelerated compositing mode. Moved the layout earlier in this function so we can bail
before doing other work that would be unnecessary in this case. Moved the allocation of the
ShareableBitmap earlier so we will leave our state (e.g., dirty region) intact even if the
allocation fails.

10:24 AM Changeset in webkit [78488] by Adam Roben
  • 14 edits in trunk/Source/WebKit2

Add a way to flash backing store and view updates

The new WKPageSetDebugPaintFlags SPI can be used to control whether backing store and/or
view updates are flashed. A blueish color is used for view updates, and a purpleish color is
used for backing store updates. The flashing currently only works on Windows.

Fixes <​http://webkit.org/b/54303>.

Reviewed by Anders Carlsson.

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetDebugPaintFlags):
(WKPageGetDebugPaintFlags):

  • UIProcess/API/C/WKPagePrivate.h:

Added. These call through to WebPageProxy.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::flashBackingStoreUpdates):

  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::flashBackingStoreUpdates):

  • UIProcess/API/qt/qwkpage_p.h:

Stubbed out new PageClient functions.

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::incorporateUpdate): Tell the WebPageProxy to flash the
backing store updates we're performing.

  • UIProcess/PageClient.h: Added flashBackingStoreUpdates.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::flashBackingStoreUpdates): Call through to the PageClient.
(WebKit::WebPageProxy::viewUpdatesFlashColor): Return the blueish color used for view
updates.
(WebKit::WebPageProxy::backingStoreUpdatesFlashColor): Return the purpleish color used for
backing store updates.

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::setDebugPaintFlags):
(WebKit::WebPageProxy::debugPaintFlags):
Added these simple accessors.

  • UIProcess/win/WebView.cpp:

(WebKit::flashRects):
(WebKit::createBrush):
New helper functions.

(WebKit::WebView::onPaintEvent): Flash the dirty region if requested.
(WebKit::WebView::flashBackingStoreUpdates): Added. Calls through to flashRects.

  • UIProcess/win/WebView.h: Added flashBackingStoreUpdates.
  • win/WebKit2Generated.make: Export WKPagePrivate.h so clients can use it.
10:13 AM Changeset in webkit [78487] by pfeldman@chromium.org
  • 4 edits in trunk/LayoutTests

2011-02-14 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: unflake inspector/styles-iframe.html

  • inspector/resources/styles-iframe-data.html:
  • inspector/styles-iframe-expected.txt:
  • inspector/styles-iframe.html:
9:54 AM Changeset in webkit [78486] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-14 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: 304 Not Modified responses have a yellow icon in Web Inspector Resources panel
​https://bugs.webkit.org/show_bug.cgi?id=33220

  • inspector/front-end/ResourceHeadersView.js: (WebInspector.ResourceHeadersView.prototype._refreshHTTPInformation):
9:53 AM Changeset in webkit [78485] by inferno@chromium.org
  • 7 edits
    4 copies in branches/chromium/648

Merge 77563

BUG=70336
Review URL: ​http://codereview.chromium.org/6519013

9:29 AM Changeset in webkit [78484] by enne@google.com
  • 8 edits in trunk/Source/WebCore

2011-02-14 Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

[chromium] Modify LayerTilerChromium to use TilingData.
​https://bugs.webkit.org/show_bug.cgi?id=54143

Most of the previous data in LayerTilerChromium is now calculated
from TilingData. TilingData was modified to allow for a dynamic
tile size and page size. LayerTilerChromium also gets its own
shader with a texture transform to handle drawing from a texture
that is larger than a tile.

  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::updateAndDrawRootLayer): (WebCore::LayerRendererChromium::initializeSharedObjects): (WebCore::LayerRendererChromium::cleanupSharedObjects):
  • platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::tilerSharedValues):
  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::create): (WebCore::LayerTilerChromium::LayerTilerChromium): (WebCore::LayerTilerChromium::setTileSize): (WebCore::LayerTilerChromium::reset): (WebCore::LayerTilerChromium::contentRectToTileIndices): (WebCore::LayerTilerChromium::tileIndex): (WebCore::LayerTilerChromium::tileContentRect): (WebCore::LayerTilerChromium::tileLayerRect): (WebCore::LayerTilerChromium::layerSize): (WebCore::LayerTilerChromium::layerTileSize): (WebCore::LayerTilerChromium::invalidateEntireLayer): (WebCore::LayerTilerChromium::draw): (WebCore::LayerTilerChromium::resizeLayer): (WebCore::LayerTilerChromium::growLayerToContain): (WebCore::LayerTilerChromium::drawTexturedQuad): (WebCore::LayerTilerChromium::SharedValues::SharedValues): (WebCore::LayerTilerChromium::SharedValues::~SharedValues):
  • platform/graphics/chromium/LayerTilerChromium.h: (WebCore::LayerTilerChromium::SharedValues::tilerShaderProgram): (WebCore::LayerTilerChromium::SharedValues::shaderSamplerLocation): (WebCore::LayerTilerChromium::SharedValues::shaderMatrixLocation): (WebCore::LayerTilerChromium::SharedValues::shaderAlphaLocation): (WebCore::LayerTilerChromium::SharedValues::shaderTexTransformLocation): (WebCore::LayerTilerChromium::SharedValues::initialized):
  • platform/graphics/gpu/TilingData.cpp: (WebCore::computeNumTiles): (WebCore::TilingData::TilingData): (WebCore::TilingData::setTotalSize): (WebCore::TilingData::setMaxTextureSize): (WebCore::TilingData::tileSizeX): (WebCore::TilingData::tileSizeY): (WebCore::TilingData::textureOffset): (WebCore::TilingData::recomputeNumTiles):
  • platform/graphics/gpu/TilingData.h:
9:18 AM QtWebKit edited by siddharth.mathur@nokia.com
(diff)
9:18 AM QtWebKit edited by siddharth.mathur@nokia.com
(diff)
9:17 AM QtWebKit edited by siddharth.mathur@nokia.com
(diff)
9:17 AM Changeset in webkit [78483] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-14 Andrey Adaikin <​aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: [Text editor] First implementation of the editable TextViewer without optimization
​https://bugs.webkit.org/show_bug.cgi?id=54388

  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype.set readOnly): (WebInspector.TextEditorChunkedPanel): (WebInspector.TextEditorChunkedPanel.prototype._buildChunks): (WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk): (WebInspector.TextEditorChunkedPanel.prototype.beginDomUpdates): (WebInspector.TextEditorChunkedPanel.prototype.endDomUpdates): (WebInspector.TextEditorChunkedPanel.prototype._repaintAll): (WebInspector.TextEditorGutterChunk.prototype.set expanded): (WebInspector.TextEditorMainPanel): (WebInspector.TextEditorMainPanel.prototype.set readOnly): (WebInspector.TextEditorMainPanel.prototype._buildChunks): (WebInspector.TextEditorMainPanel.prototype._highlightDataReady): (WebInspector.TextEditorMainPanel.prototype._paintLine): (WebInspector.TextEditorMainPanel.prototype.textChanged): (WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates.return): (WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates): (WebInspector.TextEditorMainPanel.prototype._handleDOMSubtreeModified): (WebInspector.TextEditorMainPanel.prototype._applyDomUpdates): (WebInspector.TextEditorMainPanel.prototype._collectLinesFromDiv): (WebInspector.TextEditorMainChunk.prototype.addDecoration): (WebInspector.TextEditorMainChunk.prototype.removeDecoration): (WebInspector.TextEditorMainChunk.prototype.set expanded):
8:40 AM Changeset in webkit [78482] by podivilov@chromium.org
  • 17 edits in trunk

2011-02-14 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: use call frame column to determine execution line in source frame.
​https://bugs.webkit.org/show_bug.cgi?id=54001

  • http/tests/inspector/debugger-test.js: (initialize_DebuggerTest.InspectorTest.captureStackTrace):

2011-02-14 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: use call frame column to determine execution line in source frame.
​https://bugs.webkit.org/show_bug.cgi?id=54001

  • wtf/text/TextPosition.h: (WTF::ZeroBasedNumber::convertAsOneBasedInt):

2011-02-14 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: use call frame column to determine execution line in source frame.
​https://bugs.webkit.org/show_bug.cgi?id=54001

  • Make call frame line and column zero based
  • Set execution line in source frame based on call frame line:column
  • Determine currently hit breakpoint based on call frame line:column
  • bindings/js/JavaScriptCallFrame.cpp: (WebCore::JavaScriptCallFrame::JavaScriptCallFrame):
  • bindings/js/JavaScriptCallFrame.h: (WebCore::JavaScriptCallFrame::create): (WebCore::JavaScriptCallFrame::line): (WebCore::JavaScriptCallFrame::column): (WebCore::JavaScriptCallFrame::update):
  • bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::createCallFrameAndPauseIfNeeded): (WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):
  • bindings/v8/DebuggerScript.js: ():
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._debuggerPaused):
  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.update):
  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.continueToLocation): (WebInspector.DebuggerModel.prototype._pausedScript): (WebInspector.DebuggerModel.prototype._breakpointForCallFrame):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._debuggerPaused): (WebInspector.ScriptsPanel.prototype._clearCurrentExecutionLine): (WebInspector.ScriptsPanel.prototype._callFrameSelected):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._setTextViewerDecorations): (WebInspector.SourceFrame.prototype.setExecutionLocation): (WebInspector.SourceFrame.prototype.clearExecutionLocation): (WebInspector.SourceFrame.prototype._setExecutionLocation): (WebInspector.SourceFrame.prototype._breakpointAdded): (WebInspector.SourceFrame.prototype._continueToLine): (WebInspector.SourceFrame.prototype._originalLocationToTextViewerLineNumber):

2011-02-14 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: use call frame column to determine execution line in source frame.
​https://bugs.webkit.org/show_bug.cgi?id=54001

  • src/js/Tests.js: (.TestSuite.prototype._checkExecutionLine):
8:34 AM Changeset in webkit [78481] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-14 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: chromium expectations update.

  • platform/chromium/inspector/timeline-network-resource-expected.txt:
8:31 AM Changeset in webkit [78480] by christian@webkit.org
  • 2 edits in trunk/Source/WebCore

Regression: Back, Forward, Reload hidden in context menu
​https://bugs.webkit.org/show_bug.cgi?id=54393

Reviewed by Gustavo Noronha Silva.

  • page/ContextMenuController.cpp: Always show Back, Forward,

Reload and Stop context menu items for the GTK+ port.

8:12 AM Changeset in webkit [78479] by Adam Roben
  • 3 edits in trunk/Source/WebKit2

Add some .messages.in and script files to WebKit2 projects

This is just for convenience. It doesn't affect the build.

  • win/WebKit2.vcproj: Also let VS resort some files.
  • win/WebKit2Generated.vcproj:
8:04 AM Changeset in webkit [78478] by jnd@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-14 Johnny Ding <​jnd@chromium.org>

Reviewed by Andreas Kling.

Move the finiteness check into common code.

Test covered by canvas/philip/tests/2d.path.isPointInPath.nonfinite.html

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::isPointInPath):
7:43 AM Changeset in webkit [78477] by pfeldman@chromium.org
  • 30 edits
    2 adds
    2 deletes in trunk/LayoutTests

2011-02-14 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: move timeline and highlighter tests to the new harness.
​https://bugs.webkit.org/show_bug.cgi?id=54390

  • inspector/cookie-resource-match.html:
  • inspector/elements-panel-search.html:
  • inspector/evaluate-in-frontend-expected.txt: Removed.
  • inspector/evaluate-in-frontend.html: Removed.
  • inspector/inspected-objects-not-overriden.html:
  • inspector/resources/timeline-iframe-data.html:
  • inspector/syntax-highlight-css.html:
  • inspector/syntax-highlight-html.html:
  • inspector/syntax-highlight-javascript-expected.txt:
  • inspector/syntax-highlight-javascript.html:
  • inspector/syntax-highlight.js: (initialize_SyntaxHighlight.InspectorTest.dumpSyntaxHighlight): (initialize_SyntaxHighlight):
  • inspector/timeline-enum-stability-expected.txt:
  • inspector/timeline-enum-stability.html:
  • inspector/timeline-event-dispatch.html:
  • inspector/timeline-layout-expected.txt:
  • inspector/timeline-layout.html:
  • inspector/timeline-mark-timeline.html:
  • inspector/timeline-network-resource-expected.txt:
  • inspector/timeline-network-resource.html:
  • inspector/timeline-network-resource.js:
  • inspector/timeline-paint.html:
  • inspector/timeline-parse-html-expected.txt:
  • inspector/timeline-parse-html.html:
  • inspector/timeline-recalculate-styles-expected.txt:
  • inspector/timeline-recalculate-styles.html:
  • inspector/timeline-script-tag-1-expected.txt:
  • inspector/timeline-script-tag-1.html:
  • inspector/timeline-script-tag-2-expected.txt:
  • inspector/timeline-script-tag-2.html:
  • inspector/timeline-script-tag-2.js:
  • inspector/timeline-test.js: (initialize_Timeline.InspectorTest.performActionsAndPrint.step1): (initialize_Timeline.InspectorTest.performActionsAndPrint.step2): (initialize_Timeline.InspectorTest.performActionsAndPrint.step3): (initialize_Timeline.InspectorTest.performActionsAndPrint): (initialize_Timeline.InspectorTest.printTimelineRecords): (initialize_Timeline.InspectorTest._timelineResults): (initialize_Timeline.InspectorTest.dumpTimelineRecord): (initialize_Timeline.InspectorTest.dumpTimelineRecords): (initialize_Timeline.InspectorTest.printTimelineRecordProperties): (initialize_Timeline.InspectorTest._timelineAgentTypeToString): (initialize_Timeline):
  • inspector/timeline-trivial.html:
7:29 AM Changeset in webkit [78476] by pfeldman@chromium.org
  • 3 edits in trunk/LayoutTests

2011-02-14 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: update chromium expectation for inspector test.

  • inspector/console-uncaught-exception-in-eval.html:
  • platform/chromium/inspector/console-uncaught-exception-in-eval-expected.txt:
6:27 AM Changeset in webkit [78475] by pfeldman@chromium.org
  • 6 edits
    1 move
    3 deletes in trunk/LayoutTests

2011-02-14 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: chromium expectations update.

  • platform/chromium-win/inspector/console-format-expected.txt: Removed.
  • platform/chromium-win/inspector/console-uncaught-exception-expected.txt: Removed.
  • platform/chromium-win/inspector/debugger-expand-scope-expected.txt: Removed.
  • platform/chromium/inspector/console-dir-global-expected.txt: Renamed from LayoutTests/platform/chromium-win/inspector/console-dir-global-expected.txt.
  • platform/chromium/inspector/console-format-collections-expected.txt:
  • platform/chromium/inspector/console-format-expected.txt:
  • platform/chromium/inspector/console-trace-in-eval-expected.txt:
  • platform/chromium/inspector/console-uncaught-exception-expected.txt:
  • platform/chromium/inspector/debugger-expand-scope-expected.txt:
6:23 AM Changeset in webkit [78474] by alex
  • 2 edits in trunk/LayoutTests

2011-02-14 Alejandro G. Castro <​alex@igalia.com>

Unreviewed, skipped some tests that were causing problems just in
one of the bots, apparently rounding issues.
​https://bugs.webkit.org/show_bug.cgi?id=39022

  • platform/gtk/Skipped:
6:08 AM Changeset in webkit [78473] by rolandsteiner@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-14 Roland Steiner <​rolandsteiner@chromium.org>

Reviewed by Kent Tamura.

Bug 54377 - Clean up RenderTextControlSingleLine::createSubtreeIfNeeded()
​https://bugs.webkit.org/show_bug.cgi?id=54377

Rearranged the condition blocks, removed superfluous conditions:
.) if-statements where it's already clear that a search field is being generated
.) testing for spin-buttons on field types that can never have them.

createInnerBlockStyle(): only search fields create an inner block, and
these can never have spin buttons.

No new tests. (Refactoring - covered by existing tests)

  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::createInnerBlockStyle): (WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded):
6:06 AM Changeset in webkit [78472] by podivilov@chromium.org
  • 7 edits in trunk/Source/WebCore

2011-02-10 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: refactoring, extract SourceMapping from SourceFrameContent.
​https://bugs.webkit.org/show_bug.cgi?id=54195

Add SourceMapping interface with two implementations - IdenticalSourceMapping and SourceMappingForFormattedScript.
Rewrite SourceFrameContent based on SourceMapping. Make SourceFrame unaware of source mapping details.

  • inspector/front-end/ResourceView.js: (WebInspector.SourceFrameContentProviderForResource.prototype.requestContent):
  • inspector/front-end/ScriptFormatter.js: (WebInspector.ScriptFormatter.locationToPosition): (WebInspector.ScriptFormatter.positionToLocation): (WebInspector.ScriptFormatter.prototype.formatContent.didFormatChunks): (WebInspector.ScriptFormatter.prototype.formatContent): (WebInspector.ScriptFormatter.prototype._splitContentIntoChunks): (WebInspector.SourceMappingForFormattedScript): (WebInspector.SourceMappingForFormattedScript.prototype.fromScriptLocation): (WebInspector.SourceMappingForFormattedScript.prototype.toScriptLocation): (WebInspector.SourceMappingForFormattedScript.prototype.originalPositionToFormattedLocation): (WebInspector.SourceMappingForFormattedScript.prototype._convertPosition):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.SourceFrameContentProviderForScript.prototype.requestContent):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._createTextViewer): (WebInspector.SourceFrame.prototype._shouldDisplayBreakpoint): (WebInspector.SourceFrame.prototype.setExecutionLine): (WebInspector.SourceFrame.prototype.clearExecutionLine): (WebInspector.SourceFrame.prototype._breakpointAdded): (WebInspector.SourceFrame.prototype.formatSource.didFormat): (WebInspector.SourceFrame.prototype.formatSource): (WebInspector.SourceFrame.prototype._continueToLine): (WebInspector.SourceFrame.prototype._setBreakpoint): (WebInspector.SourceFrame.prototype._findBreakpoint): (WebInspector.SourceFrameContentProvider.prototype.requestContent):
  • inspector/front-end/SourceFrameContent.js: (WebInspector.SourceFrameContent): (WebInspector.SourceFrameContent.prototype.sourceFrameLineNumberToScriptLocation): (WebInspector.SourceFrameContent.prototype.scriptLocationToSourceFrameLineNumber): (WebInspector.SourceFrameContent.prototype._sourceIDForSourceFrameLineNumber): (WebInspector.SourceMapping): (WebInspector.SourceMapping.prototype.fromScriptLocation): (WebInspector.SourceMapping.prototype.toScriptLocation): (WebInspector.IdenticalSourceMapping): (WebInspector.IdenticalSourceMapping.prototype.fromScriptLocation): (WebInspector.IdenticalSourceMapping.prototype.toScriptLocation):
  • inspector/front-end/utilities.js: (String.prototype.lineEndings):
6:00 AM Changeset in webkit [78471] by alex
  • 2 edits in trunk/LayoutTests

2011-02-14 Alejandro G. Castro <​alex@igalia.com>

Unreviewed, skipped generated-content-inside-table.htm test, it
fails in the bots, opened bug:
​https://bugs.webkit.org/show_bug.cgi?id=54389

  • platform/gtk/Skipped:
5:20 AM Changeset in webkit [78470] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-02-14 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [REGRESSION introduced in r77950] Develop -> Start Debugging JavaScript does not open Web Inspector.
​https://bugs.webkit.org/show_bug.cgi?id=54277

  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::populateScriptObjects): (WebCore::InspectorAgent::stopUserInitiatedProfiling): (WebCore::InspectorAgent::showAndEnableDebugger): (WebCore::InspectorAgent::showPanel):
  • inspector/InspectorAgent.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::showAndEnableDebugger): (WebCore::InspectorController::stopUserInitiatedProfiling):
5:13 AM Changeset in webkit [78469] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-02-14 Kenichi Ishibashi <​bashi@chromium.org>

Reviewed by Andreas Kling.

css style="max-width:none" works wrong
​https://bugs.webkit.org/show_bug.cgi?id=53743

Adds a test to ensure style 'max-width: none' works correctly.

  • fast/css/max-width-none-expected.txt: Added.
  • fast/css/max-width-none.html: Added.

2011-02-14 Kenichi Ishibashi <​bashi@chromium.org>

Reviewed by Andreas Kling.

css style="max-width:none" works wrong
​https://bugs.webkit.org/show_bug.cgi?id=53743

Fix a bug that "max-width:none" works wrong.
See also: ​http://trac.webkit.org/changeset/13462

Test: fast/css/max-width-none.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): For max-width of none, set it to Length(undefinedLength, Fixed), which is the correct value.
5:13 AM Changeset in webkit [78468] by Antti Koivisto
  • 3 edits in trunk/Source/WebCore

REGRESSION (r77834): Assertion failing in svg/custom/use-multiple-on-nested-disallowed-font.svg
​https://bugs.webkit.org/show_bug.cgi?id=54344

Reviewed by Andreas Kling.

Intead of recomputing, just mark style selector dirty if it is invalidated in the middle of a style recalc.

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::recalcStyle):
(WebCore::Document::recalcStyleSelector):

  • dom/Document.h:
5:11 AM Changeset in webkit [78467] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-02-14 Naoki Takano <​takano.naoki@gmail.com>

Reviewed by Kent Tamura.

[Chromium] Fix wrong popup position for RTL(again)
​https://bugs.webkit.org/show_bug.cgi?id=54375

Fix right position bug introduce by ​https://bugs.webkit.org/show_bug.cgi?id=53567, because the previous fix was correct for the current behaviour, but not good for ​http://crbug.com/60427. To calculate the correct right offset value and apply to the position, change WebCore::PopupContainer::layout() to return right offset value and use the returned value to calculate position.

No new tests. However we can check manually with select_dropdown_box_alignment.html, autofill_alignment.html, select_alignment.html, select_dropdown_box_alignment.html, autofill-popup-width-and-item-direction.html

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::layoutAndCalculateWidgetRect): Change the input parameter to take popupInitialCoordinate again. And calculate correct right position with returned right offset from layoutAndGetRightOffset(). (WebCore::PopupContainer::showPopup): Change the passing parameter to layoutAndCalculateWidgetRect(). (WebCore::PopupContainer::layoutAndGetRightOffset): Change the name from layout() and to return rightOffset value. (WebCore::PopupContainer::refresh): Change the passing parameter to layoutAndCalculateWidgetRect().
  • platform/chromium/PopupMenuChromium.h: Change the function name and parameters.
5:06 AM Changeset in webkit [78466] by pfeldman@chromium.org
  • 3 edits in trunk/LayoutTests

2011-02-14 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: follow up to r78460 with more expectation updates.

  • inspector/styles-iframe-expected.txt:
  • inspector/styles-iframe.html:
4:31 AM Changeset in webkit [78465] by alex
  • 6 edits in trunk/Source/WebCore

2011-02-14 Alejandro G. Castro <​alex@igalia.com>

Unreviewed, rolling out r78451.
​http://trac.webkit.org/changeset/78451
​https://bugs.webkit.org/show_bug.cgi?id=53898

It is causing crashes in some bots

  • platform/text/TextCodecICU.cpp: (WebCore::newTextCodecICU): (WebCore::TextCodecICU::registerBaseEncodingNames): (WebCore::TextCodecICU::registerBaseCodecs): (WebCore::TextCodecICU::registerExtendedEncodingNames): (WebCore::TextCodecICU::registerExtendedCodecs): (WebCore::ErrorCallbackSetter::~ErrorCallbackSetter): (WebCore::getGbkEscape): (WebCore::urlEscapedEntityCallback): (WebCore::gbkCallbackEscape): (WebCore::gbkUrlEscapedEntityCallack): (WebCore::gbkCallbackSubstitute):
  • platform/text/TextCodecICU.h: (WebCore::ICUConverterWrapper::ICUConverterWrapper):
  • platform/text/TextCodecUTF8.cpp: (WebCore::TextCodecUTF8::registerEncodingNames): (WebCore::nonASCIISequenceLength): (WebCore::decodeNonASCIISequence): (WebCore::TextCodecUTF8::decode):
  • platform/text/TextCodecUTF8.h:
  • platform/text/TextEncodingRegistry.cpp: (WebCore::buildBaseTextCodecMaps): (WebCore::extendTextCodecMaps):
3:32 AM Changeset in webkit [78464] by hamaji@chromium.org
  • 4 edits
    2 adds in trunk/LayoutTests

2011-02-14 Shinichiro Hamaji <​hamaji@chromium.org>

Rebaseline chromium's test expectations for SVG tests.

  • platform/chromium-mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.png: Added.
  • platform/chromium-mac/svg/text/text-intro-05-t-expected.checksum:
  • platform/chromium-mac/svg/text/text-intro-05-t-expected.png:
  • platform/chromium/test_expectations.txt:
3:29 AM Changeset in webkit [78463] by pfeldman@chromium.org
  • 4 edits in trunk/LayoutTests

2011-02-14 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: follow up to r78460 with expectation updates.

  • inspector/styles-iframe-expected.txt:
  • platform/mac-leopard/http/tests/inspector/console-websocket-error-expected.txt:
  • platform/mac/http/tests/inspector/console-websocket-error-expected.txt:
3:22 AM Changeset in webkit [78462] by hamaji@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-02-14 Shinichiro Hamaji <​hamaji@chromium.org>

Rebaseline chromium's test expectation for ​http://trac.webkit.org/changeset/78449

  • platform/chromium-win/fast/gradients/css3-repeating-end-fill-expected.txt: Added.
3:14 AM Changeset in webkit [78461] by hamaji@chromium.org
  • 2 edits
    29 adds in trunk/LayoutTests

2011-02-14 Shinichiro Hamaji <​hamaji@chromium.org>

Rebaseline chromium's test expectations for inline-box-background-*

  • platform/chromium-linux/fast/inline/inline-box-background-expected.checksum: Added.
  • platform/chromium-linux/fast/inline/inline-box-background-expected.png: Added.
  • platform/chromium-linux/fast/inline/inline-box-background-long-image-expected.checksum: Added.
  • platform/chromium-linux/fast/inline/inline-box-background-long-image-expected.png: Added.
  • platform/chromium-linux/fast/inline/inline-box-background-repeat-x-expected.checksum: Added.
  • platform/chromium-linux/fast/inline/inline-box-background-repeat-x-expected.png: Added.
  • platform/chromium-linux/fast/inline/inline-box-background-repeat-y-expected.checksum: Added.
  • platform/chromium-linux/fast/inline/inline-box-background-repeat-y-expected.png: Added.
  • platform/chromium-mac/fast/inline/inline-box-background-expected.checksum: Added.
  • platform/chromium-mac/fast/inline/inline-box-background-expected.png: Added.
  • platform/chromium-mac/fast/inline/inline-box-background-long-image-expected.checksum: Added.
  • platform/chromium-mac/fast/inline/inline-box-background-long-image-expected.png: Added.
  • platform/chromium-mac/fast/inline/inline-box-background-repeat-x-expected.checksum: Added.
  • platform/chromium-mac/fast/inline/inline-box-background-repeat-x-expected.png: Added.
  • platform/chromium-mac/fast/inline/inline-box-background-repeat-y-expected.checksum: Added.
  • platform/chromium-mac/fast/inline/inline-box-background-repeat-y-expected.png: Added.
  • platform/chromium-win/fast/inline/inline-box-background-expected.checksum: Added.
  • platform/chromium-win/fast/inline/inline-box-background-expected.png: Added.
  • platform/chromium-win/fast/inline/inline-box-background-expected.txt: Added.
  • platform/chromium-win/fast/inline/inline-box-background-long-image-expected.checksum: Added.
  • platform/chromium-win/fast/inline/inline-box-background-long-image-expected.png: Added.
  • platform/chromium-win/fast/inline/inline-box-background-long-image-expected.txt: Added.
  • platform/chromium-win/fast/inline/inline-box-background-repeat-x-expected.checksum: Added.
  • platform/chromium-win/fast/inline/inline-box-background-repeat-x-expected.png: Added.
  • platform/chromium-win/fast/inline/inline-box-background-repeat-x-expected.txt: Added.
  • platform/chromium-win/fast/inline/inline-box-background-repeat-y-expected.checksum: Added.
  • platform/chromium-win/fast/inline/inline-box-background-repeat-y-expected.png: Added.
  • platform/chromium-win/fast/inline/inline-box-background-repeat-y-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
2:58 AM Changeset in webkit [78460] by pfeldman@chromium.org
  • 83 edits
    3 moves
    1 add
    4 deletes in trunk/LayoutTests

2011-02-13 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [layout tests] get rid of elements-tests.js in favor of elements-tests2.js
​https://bugs.webkit.org/show_bug.cgi?id=54354

  • http/tests/inspector/console-resource-errors.html:
  • http/tests/inspector/console-test.js: Renamed from LayoutTests/http/tests/inspector/console-tests2.js.
  • http/tests/inspector/console-tests.js: Removed.
  • http/tests/inspector/console-websocket-error.html:
  • http/tests/inspector/console-xhr-logging-expected.txt:
  • http/tests/inspector/console-xhr-logging.html:
  • http/tests/inspector/debugger-test.js: Renamed from LayoutTests/http/tests/inspector/debugger-test2.js.
  • http/tests/inspector/elements-test.js: Added.
  • http/tests/inspector/inspector-test2.js:
  • http/tests/inspector/resource-har-conversion-expected.txt:
  • http/tests/inspector/resource-har-conversion.html:
  • http/tests/inspector/resource-parameters-expected.txt:
  • http/tests/inspector/resource-parameters.html:
  • http/tests/inspector/resource-tests.js: Removed.
  • http/tests/inspector/resources-test.js: Renamed from LayoutTests/http/tests/inspector/resource-test2.js.
  • inspector/command-line-api.html:
  • inspector/console-api-on-call-frame.html:
  • inspector/console-assert.html:
  • inspector/console-clear.html:
  • inspector/console-command-clear-expected.txt:
  • inspector/console-command-clear.html:
  • inspector/console-dir-global.html:
  • inspector/console-dir.html:
  • inspector/console-dirxml.html:
  • inspector/console-eval-global.html:
  • inspector/console-eval.html:
  • inspector/console-format-collections-expected.txt:
  • inspector/console-format-collections.html:
  • inspector/console-format-expected.txt:
  • inspector/console-format.html:
  • inspector/console-log-before-inspector-open.html:
  • inspector/console-log-syntax-error.html:
  • inspector/console-object-constructor-name.html:
  • inspector/console-tests.html:
  • inspector/console-trace-in-eval.html:
  • inspector/console-trace.html:
  • inspector/console-uncaught-exception-in-eval.html:
  • inspector/console-uncaught-exception.html:
  • inspector/debugger-autocontinue-on-syntax-error.html:
  • inspector/debugger-breakpoints-not-activated-on-reload.html:
  • inspector/debugger-cyclic-ref.html:
  • inspector/debugger-eval-on-call-frame.html:
  • inspector/debugger-eval-while-paused.html:
  • inspector/debugger-expand-scope.html:
  • inspector/debugger-no-nested-pause.html:
  • inspector/debugger-pause-in-eval-script.html:
  • inspector/debugger-pause-on-breakpoint.html:
  • inspector/debugger-pause-on-debugger-statement.html:
  • inspector/debugger-pause-on-exception.html:
  • inspector/debugger-proto-property.html:
  • inspector/debugger-scripts.html:
  • inspector/debugger-step-in.html:
  • inspector/debugger-step-out.html:
  • inspector/debugger-step-over.html:
  • inspector/debugger-suspend-active-dom-objects.html:
  • inspector/dom-breakpoints.html:
  • inspector/elements-delete-inline-style.html:
  • inspector/elements-img-tooltip-expected.txt:
  • inspector/elements-img-tooltip.html:
  • inspector/elements-panel-limited-children-expected.txt:
  • inspector/elements-panel-limited-children.html:
  • inspector/elements-panel-rewrite-href-expected.txt:
  • inspector/elements-panel-rewrite-href.html:
  • inspector/elements-panel-selection-on-refresh-expected.txt:
  • inspector/elements-panel-selection-on-refresh.html:
  • inspector/elements-panel-structure-expected.txt:
  • inspector/elements-panel-structure.html:
  • inspector/elements-panel-styles.html:
  • inspector/elements-panel-xhtml-structure-expected.txt:
  • inspector/elements-panel-xhtml-structure.xhtml:
  • inspector/elements-tests.js: Removed.
  • inspector/elements-tests2.js: Removed.
  • inspector/resources/elements-panel-styles.css:
  • inspector/resources/styles-iframe-data.html:
  • inspector/storage-panel-dom-storage.html:
  • inspector/styles-add-blank-property.html:
  • inspector/styles-computed-trace.html:
  • inspector/styles-disable-inherited.html:
  • inspector/styles-disable-then-change.html:
  • inspector/styles-disable-then-delete.html:
  • inspector/styles-disable-then-enable.html:
  • inspector/styles-iframe-expected.txt:
  • inspector/styles-iframe.html:
  • inspector/styles-new-API.html:
  • inspector/styles-source-lines-expected.txt:
  • inspector/styles-source-lines-inline.html:
  • inspector/styles-source-lines.html:
  • inspector/styles-source-offsets.html:
  • inspector/styles-url-linkify.html:
2:54 AM Changeset in webkit [78459] by hamaji@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

2011-02-14 Shinichiro Hamaji <​hamaji@chromium.org>

Rebaseline chromium's test_expectations.

  • platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.checksum: Added.
  • platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.png: Added.
  • platform/chromium/test_expectations.txt:
1:28 AM Changeset in webkit [78458] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-02-14 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Need implementation of ResourceRequest and ResourceResponse serialization
​https://bugs.webkit.org/show_bug.cgi?id=54339

Add dummy implementation with FIXME and let the core go with it for now.

  • Shared/qt/WebCoreArgumentCodersQt.cpp: (CoreIPC::decodeResourceRequest): (CoreIPC::decodeResourceResponse):
12:05 AM Changeset in webkit [78457] by Antti Koivisto
  • 3 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=54376
Make sorting of matched rules faster

Reviewed by Dan Bernstein.

  • use std::sort
  • cache specificity, it is slow to compute
  • inline compare function
  • css/CSSStyleSelector.cpp:

(WebCore::RuleData::specificity):
(WebCore::CSSStyleSelector::matchRules):
(WebCore::compareRules):
(WebCore::CSSStyleSelector::sortMatchedRules):
(WebCore::RuleData::RuleData):
(WebCore::CSSStyleSelector::matchPageRules):

  • css/CSSStyleSelector.h:

Feb 13, 2011:

11:58 PM Changeset in webkit [78456] by hayato@chromium.org
  • 2 edits in trunk

2011-02-13 Hayato Ito <​hayato@chromium.org>

Reviewed by Kent Tamura.

Update .gitignore to ignore files which Ninja build system generates.

​https://bugs.webkit.org/show_bug.cgi?id=54378

  • .gitignore:
9:01 PM WebKit Team edited by jhanssen@gmail.com
Add myself to the committer list (diff)
8:22 PM Changeset in webkit [78455] by tkent@chromium.org
  • 4 edits
    2 copies in branches/chromium/597

The second attempt to merge r77114.
(It was merged by r78166 and reverted by r78381)

HTMLFormControlElement::insertedIntoDocument() and removedFromDocument()
should call HTMLElement::insertedIntoDocument() and removedFromDocument().

2011-01-30 Kenichi Ishibashi <​bashi@google.com>

Reviewed by Kent Tamura.

Dangling form associated elements should not be registered on the document
​https://bugs.webkit.org/show_bug.cgi?id=53223

Adds insertedIntoDocument() and remvoedFromDocument() to
FormAssociatedElement class to register the element on the document
if and only if it actually inserted into (removed from) the document.

Test: fast/forms/dangling-form-element-crash.html

  • html/FormAssociatedElement.cpp: (WebCore::FormAssociatedElement::insertedIntoDocument): Added. (WebCore::FormAssociatedElement::removedFromDocument): Ditto. (WebCore::FormAssociatedElement::insertedIntoTree): Don't register the element to a document. (WebCore::FormAssociatedElement::removedFromTree): Don't unregister the element from a document.
  • html/FormAssociatedElement.h:
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::insertedIntoDocument): Added. (WebCore::HTMLFormControlElement::removedFromDocument): Ditto.
  • html/HTMLFormControlElement.h:
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::insertedIntoDocument): Calls FormAssociatedElement::insertedIntoDocument(). (WebCore::HTMLObjectElement::removedFromDocument): Calls FormAssociatedElement::removedFromDocument().

2011-01-30 Kenichi Ishibashi <​bashi@google.com>

Reviewed by Kent Tamura.

Dangling form associated elements should not be registered on the document
​https://bugs.webkit.org/show_bug.cgi?id=53223

Adds a test that ensures dangling form associated elements are not
registered on the document.

  • fast/forms/dangling-form-element-crash-expected.txt: Added.
  • fast/forms/dangling-form-element-crash.html: Added.

BUG=crbug.com/70078
TBR=​inferno@chromium.org

8:12 PM WebKit Team edited by helder@sencha.com
(diff)
8:02 PM Changeset in webkit [78454] by Simon Fraser
  • 3 edits in trunk/LayoutTests

2011-02-13 Simon Fraser <Simon Fraser>

Change previous test to dump as text, with pixel output, to fix
Qt failure.

  • fast/gradients/css3-repeating-end-fill-expected.txt:
  • fast/gradients/css3-repeating-end-fill.html:
8:00 PM Changeset in webkit [78453] by mrowe@apple.com
  • 5 edits in trunk/Source

Versioning.

7:56 PM Changeset in webkit [78452] by mrowe@apple.com
  • 1 copy in tags/Safari-534.20

New tag.

7:28 PM Changeset in webkit [78451] by Darin Adler
  • 6 edits in trunk/Source/WebCore

2011-02-12 Darin Adler <Darin Adler>

Reviewed by Alexey Proskuryakov.

Add built-in decoder for UTF-8 for improved performance
​https://bugs.webkit.org/show_bug.cgi?id=53898

Covered by existing tests; not adding new tests at this time.

This patch now handles errors in the same way the existing codecs do,
and so passes our tests. The previous version failed some tests because
of incorrect error handling.

  • platform/text/TextCodecICU.cpp: (WebCore::create): Renamed from newTextCodecICU, made a static member function, and added a call to adoptPtr. (WebCore::TextCodecICU::registerEncodingNames): Renamed from registerExtendedEncodingNames since this class is no longer used for base codecs. Removed aliases for UTF-8; now handled by TextCodecUTF8. (WebCore::TextCodecICU::registerCodecs): Renamed. (WebCore::fallbackForGBK): Renamed to conform to our current style.
  • platform/text/TextCodecICU.h: Updated for above changes. Changed indentation. Made most functions private, including virtual function overrides. Marked ICUConverterWrapper noncopyable.
  • platform/text/TextCodecUTF8.cpp: (WebCore::TextCodecUTF8::registerEncodingNames): Added the UTF-8 aliases that were formerly added by TextCodecICU. (WebCore::nonASCIISequenceLength): Fixed bug where this would return 4 for bytes F5-FF instead of failing. (WebCore::decodeNonASCIISequence): Tweaked coding style. (WebCore::appendCharacter): Added. Makes it easier to share code between the partial-character handling and main loop. (WebCore::TextCodecUTF8::decode): Fixed buffer size computation for case where there is a partial sequence. Fixed partial sequence handling so that goto is no longer needed, since compilers sometimes make poor code when goto is involved. Added a loop for partial sequences since we consume only one byte when a partial sequence is invalid. Fixed logic in main decoding loop so goto is not needed. Used early-exit style in both loops so the main flow is not nested inside if statements. Added correct error handling for flush when a partial sequence remains, which involved wrapping the function in yet another loop.
  • platform/text/TextCodecUTF8.h: Made virtual function overrides private.
  • platform/text/TextEncodingRegistry.cpp: (WebCore::buildBaseTextCodecMaps): Added calls to TextCodecUTF8. Removed calls to TextCodecICU. Added FIXMEs for other codecs that no longer need to be included here. (WebCore::extendTextCodecMaps): Updated for the name change of the TextCodecICU functions.
6:50 PM Changeset in webkit [78450] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

<rdar://problem/8995490> WebCoreAuthenticationClientAsChallengeSender doesn't implement some necessary methods.

Reviewed by Maciej Stachowiak.

  • platform/network/mac/AuthenticationMac.mm:

(-[WebCoreAuthenticationClientAsChallengeSender performDefaultHandlingForAuthenticationChallenge:]):
(-[WebCoreAuthenticationClientAsChallengeSender rejectProtectionSpaceAndContinueWithChallenge:]):

6:09 PM Changeset in webkit [78449] by Simon Fraser
  • 3 edits
    4 adds in trunk

2011-02-13 Simon Fraser <Simon Fraser>

Reviewed by Andreas Kling.

Repeating gradients drawn incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=53502

The 'forward-fill' logic for repeating gradients used the wrong
starting stop index (0 rather than the original first index), which
resulted in incorrect gradients if backwards-fill had already been
applied.

Test: fast/gradients/css3-repeating-end-fill.html

  • css/CSSGradientValue.cpp: (WebCore::CSSGradientValue::addStops):
5:19 PM Changeset in webkit [78448] by benjamin.poulain@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-02-13 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Andreas Kling.

Unused variable result in RenderBlock::addOverflowFromFloats()
​https://bugs.webkit.org/show_bug.cgi?id=54363

Remove the unused variable.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::addOverflowFromFloats):
4:14 PM Changeset in webkit [78447] by cwzwarich@webkit.org
  • 2 edits in trunk/Source/WebCore

Reviewed by Anders Carlsson.

WebCore fails to build with Clang's -Woverloaded-virtual
​https://bugs.webkit.org/show_bug.cgi?id=54367

  • loader/PingLoader.h:

(WebCore::PingLoader::didReceiveData): Change the method signature to match the signature
in the base class.

4:12 PM Changeset in webkit [78446] by andreas.kling@nokia.com
  • 1 edit
    2 deletes in trunk/LayoutTests

2011-02-13 Andreas Kling <​kling@webkit.org>

Unreviewed, remove unnecessary platform expectations for now-passing test.

  • platform/chromium/canvas/philip/tests/2d.fillStyle.parse.system-expected.txt: Removed.
  • platform/mac/canvas/philip/tests/2d.fillStyle.parse.system-expected.txt: Removed.
4:09 PM Changeset in webkit [78445] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Speculative fix for

Reviewed by Maciej Stachowiak.

<rdar://problem/8995361>
CrashTracer: [USER] 47 crashes in WebProcess at com.apple.WebKit2: WebKit::WebPage::layoutIfNeeded + 4

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::~DrawingAreaImpl):
Invalidate the layer tree host.

3:19 PM Changeset in webkit [78444] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

2011-02-13 Nico Weber <​thakis@chromium.org>

Reviewed by Anders Carlsson.

RenderBR::width() tries but fails to override RenderText::width()
​https://bugs.webkit.org/show_bug.cgi?id=54301

The superclass method's signature changed, e.g. in
​http://trac.webkit.org/changeset/57215, but the subclass was not
updated.

  • rendering/RenderBR.h: (WebCore::RenderBR::width):
3:11 PM Changeset in webkit [78443] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-13 Shinichiro Hamaji <​hamaji@chromium.org>

Fix chromium's test_expectations

  • fast/inline/inline-box-background-* should be IMAGE instead of IMAGE+TEXTfor Mac
  • fast/css/test-setting-canvas-color.html is failing
  • platform/chromium/test_expectations.txt:
1:41 PM Changeset in webkit [78442] by andreas.kling@nokia.com
  • 10 edits
    2 adds in trunk

2011-02-13 Andreas Kling <​kling@webkit.org>

Reviewed by Dirk Schulze.

Canvas: 2d.fillStyle.parse.system.html fails
​https://bugs.webkit.org/show_bug.cgi?id=39168

Based on previous work by Julien Chaffraix <​jchaffraix@codeaurora.org>
and Jan Erik Hanssen <​jhanssen@sencha.com>

  • css/CSSParser.cpp: (WebCore::CSSParser::parseColor): Changed the function to better match our early return policy. Also we now return false when we don't parse the color. This is needed for createFromString to fallback to using parseSystemColor.

(WebCore::CSSParser::parseSystemColor): Made use of the RenderTheme to get
the system colors.

  • css/CSSParser.h: Added the new parseSystemColor method.
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setStrokeColor): Pass the document to createFromString. (WebCore::CanvasRenderingContext2D::setFillColor): Ditto.
  • html/canvas/CanvasStyle.cpp: (WebCore::parseColor): (WebCore::parseColorOrCurrentColor): (WebCore::CanvasStyle::createFromString): Try to parse the color using CSSParser::parseColor and fall back to parseSystemColor if it did not work.
  • html/canvas/CanvasStyle.h: Added the new Document* parameter to createFromString.

2011-02-13 Andreas Kling <​kling@webkit.org>

Reviewed by Dirk Schulze.

Canvas: 2d.fillStyle.parse.system.html fails
​https://bugs.webkit.org/show_bug.cgi?id=39168

  • fast/css/test-setting-canvas-color-expected.txt: Added.
  • fast/css/test-setting-canvas-color.html: Added.
  • platform/gtk/Skipped:
  • platform/mac-leopard/Skipped:
  • platform/qt/Skipped:
1:39 PM Changeset in webkit [78441] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-02-13 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

The plug-in process heap should be executable by default
​https://bugs.webkit.org/show_bug.cgi?id=54364
<rdar://problem/8990563>

  • UIProcess/Launcher/ProcessLauncher.h: Add executableHeap flag.


  • UIProcess/Launcher/mac/ProcessLauncherMac.mm: (WebKit::ProcessLauncher::launchProcess): Set the right posix_spawn flag if executableHeap is true.
  • UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::PluginProcessProxy): Initialize executableHeap to true.
  • UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::connect): Initialize executableHeap to false.
1:21 PM Changeset in webkit [78440] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-13 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Messages waited on are never dispatched
​https://bugs.webkit.org/show_bug.cgi?id=54362
<rdar://problem/8995051>

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::processIncomingMessage): Get the argument encoder from the incoming message.
12:28 PM Changeset in webkit [78439] by jeremy@chromium.org
  • 16 edits in trunk/Source

2011-02-13 Jeremy Moskovich <​jeremy@chromium.org>

Reviewed by Adam Barth.

Add a compile-time option to completely disable WebArchive support.
​https://bugs.webkit.org/show_bug.cgi?id=52712

Add an ENABLE(WEB_ARCHIVE) compile-time setting and use it for all WebArchive code.
Ports Affected:

WebArchive support is currently enabled for all ports that define PLATFORM(CF) apart from Qt.
This patch preserves this behavior except that it also disables support in the Chromium port.

  • wtf/Platform.h: Add ENABLE_WEB_ARCHIVE definition and turn it off explicitly for Qt & Chromium ports.

2011-02-13 Jeremy Moskovich <​jeremy@chromium.org>

Reviewed by Adam Barth.

Add a compile-time option to completely disable WebArchive support.
​https://bugs.webkit.org/show_bug.cgi?id=52712

Add an ENABLE(WEB_ARCHIVE) compile-time setting and use it for all WebArchive code.

ArchiveResource and ArchiveResourceCollection are notably still compiled in. They are used
in Safari for functionality such as "Save Image As" and Image copy & paste independent of
WebArchive support.

Ports Affected:

WebArchive support is currently enabled for all ports that define PLATFORM(CF) apart from Qt.
This patch preserves this behavior except that it also disables support in the Chromium port.

No behavior changes so no new tests.

  • WebCore.gyp/WebCore.gyp: Don't compile LegacyWebArchive.cpp and friends.
  • WebCore.pro: Don't compile ArchiveFactory.cpp in Qt port.
  • loader/DocumentLoader.cpp: Surround WebArchive code with #ifdef. (WebCore::DocumentLoader::commitLoad): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::archiveResourceForURL):
  • loader/DocumentLoader.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURLIntoChildFrame): (WebCore::FrameLoader::stopAllLoaders): (WebCore::FrameLoader::finishedLoadingDocument):
  • loader/FrameLoader.h:
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::start):
  • loader/archive/ArchiveFactory.cpp: Remove #ifdef since feature is now enabled/disabled wholesale. (WebCore::archiveMIMETypes):
  • page/Settings.cpp:
  • page/Settings.h:
  • platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedNonImageMimeTypes):

2011-02-13 Jeremy Moskovich <​jeremy@chromium.org>

Reviewed by Adam Barth.

Add a compile-time option to completely disable WebArchive support.
​https://bugs.webkit.org/show_bug.cgi?id=52712

Add an ENABLE(WEB_ARCHIVE) compile-time setting and use it for all WebArchive code.

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences):
12:04 PM Changeset in webkit [78438] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-02-13 Aparna Nandyal <​aparna.nand@wipro.com>

Reviewed by Andreas Kling.

[Qt] QtWebKit does not properly handle D&D of a percent-encoded URL.
​https://bugs.webkit.org/show_bug.cgi?id=53320

The encoding that was done is corrected in the fix.
Replaced the KURL encoding function with QUrl API.

  • platform/qt/DragDataQt.cpp: (WebCore::DragData::asURL):
11:33 AM Changeset in webkit [78437] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-13 Leo Yang <​leo.yang.c@gmail.com>

Reviewed by Andreas Kling.

Unnecessary call of containingBlock() in RenderBoxModelObject::relativePositionOffsetX()
​https://bugs.webkit.org/show_bug.cgi?id=54351

We were calling containingBlock() twice if the left is not auto. We only need to call it
once because we can use 'cb' variable in the following line.

No functionality change, no new tests.

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::relativePositionOffsetX):
11:23 AM Changeset in webkit [78436] by commit-queue@webkit.org
  • 10 edits
    6 adds
    2 deletes in trunk

2011-02-13 Jarred Nicholls <​jarred@sencha.com>

Reviewed by Simon Fraser.

getComputedStyle returns wrong value for margin-right
​https://bugs.webkit.org/show_bug.cgi?id=13343

Matching IE, Firefox, and Opera behavior by returning the computed margin
values as specified, rather than the used/auto values (calculated via RenderBox).
Also CSS 2.1+ compliant by returning margin percentage as specified, if applicable.
Note: Firefox and Opera return calculated fixed lengths for percentage margins, IE
returns the specified percentage.

  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-mac/fast/css/computed-style-without-renderer-expected.txt
  • platform/chromium-win/fast/css/computed-style-without-renderer-expected.txt
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
  • platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
  • fast/css/getComputedStyle/getComputedStyle-margin-auto-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle/marginComputedStyle-expected.txt.
  • fast/css/getComputedStyle/getComputedStyle-margin-auto.html: Copied from LayoutTests/fast/css/getComputedStyle/marginComputedStyle.html.
  • fast/css/getComputedStyle/getComputedStyle-margin-length-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-margin-length.html: Copied from LayoutTests/fast/css/getComputedStyle/marginComputedStyle.html.
  • fast/css/getComputedStyle/getComputedStyle-margin-percentage-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-margin-percentage.html: Renamed from LayoutTests/fast/css/getComputedStyle/marginComputedStyle.html.

2011-02-13 Jarred Nicholls <​jarred@sencha.com>

Reviewed by Simon Fraser.

getComputedStyle returns wrong value for margin-right
​https://bugs.webkit.org/show_bug.cgi?id=13343

Matching IE, Firefox, and Opera behavior by returning the computed margin
values as specified, rather than the used/auto values (calculated via RenderBox).
Also CSS 2.1+ compliant by returning margin percentage as specified, if applicable.
Note: Firefox and Opera return calculated fixed lengths for percentage margins, IE
returns the specified percentage.

Tests: fast/css/getComputedStyle/getComputedStyle-margin-auto.html

fast/css/getComputedStyle/getComputedStyle-margin-length.html
fast/css/getComputedStyle/getComputedStyle-margin-percentage.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
11:10 AM Changeset in webkit [78435] by abarth@webkit.org
  • 4 edits in trunk

2011-02-13 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

crypto.getRandomValues should throw TYPE_MISMATCH_ERR
​https://bugs.webkit.org/show_bug.cgi?id=54346

  • security/crypto-random-values-types-expected.txt:

2011-02-13 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

crypto.getRandomValues should throw TYPE_MISMATCH_ERR
​https://bugs.webkit.org/show_bug.cgi?id=54346

As requested by Sam.

  • page/Crypto.cpp: (WebCore::Crypto::getRandomValues):
11:06 AM Changeset in webkit [78434] by ap@apple.com
  • 4 edits in trunk/Source/WebCore

2011-02-13 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=54349
Inline some accessors in PrintContext

No change in behavior, so no tests.

  • WebCore.exp.in:
  • page/PrintContext.cpp:
  • page/PrintContext.h: (WebCore::PrintContext::pageCount): (WebCore::PrintContext::pageRect): Inline pageCount() and pageRect() to match pageRects().
11:05 AM Changeset in webkit [78433] by weinig@apple.com
  • 7 edits in trunk/Source/WebCore

Roll r78424 [Extra scrolling required when scrolling with a scroll wheel (Mighty Mouse)] back
in with fixes to make it work with render layers.

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorMac::adjustScrollXPositionIfNecessary):
(WebCore::ScrollAnimatorMac::adjustScrollYPositionIfNecessary):
(WebCore::ScrollAnimatorMac::adjustScrollPositionIfNecessary):
(WebCore::ScrollAnimatorMac::immediateScrollToPoint):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaX):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaY):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::contentsSize):
(WebCore::RenderLayer::visibleHeight):
(WebCore::RenderLayer::visibleWidth):
(WebCore::RenderLayer::updateScrollInfoAfterLayout):

  • rendering/RenderLayer.h:
  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::visibleHeight):
(WebCore::RenderListBox::visibleWidth):

  • rendering/RenderListBox.h:
11:03 AM Changeset in webkit [78432] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-13 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=54348
Crash when printing a document with no pages

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::drawPagesToPDF): Don't fail on a fake page that computePagesForPrinting() added to a pageless document.
10:46 AM Changeset in webkit [78431] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Some Scrollbar functions assume an attached ScrollableArea but can be called without one
​https://bugs.webkit.org/show_bug.cgi?id=54262

Reviewed by Dan Bernstein.

Make sure that all calls to the scrollable area are null checked.

  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::autoscrollPressedPart):
(WebCore::Scrollbar::moveThumb):
(WebCore::Scrollbar::mouseMoved):

10:35 AM Changeset in webkit [78430] by weinig@apple.com
  • 7 edits in trunk/Source/WebCore

Roll out r78424. It broke a bunch of tests.

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorMac::immediateScrollToPoint):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaX):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaY):

  • rendering/RenderLayer.cpp:
  • rendering/RenderLayer.h:

(WebCore::RenderLayer::contentsSize):

  • rendering/RenderListBox.cpp:
  • rendering/RenderListBox.h:
9:39 AM Changeset in webkit [78429] by weinig@apple.com
  • 13 edits in trunk/Source/WebKit2

Reviewed and landed by Sam Weinig.

Patch by Chris Fleizach <Chris Fleizach> on 2011-02-13
AX: Update WK2 usage of remote accessibility api
​https://bugs.webkit.org/show_bug.cgi?id=54220

Rename some of the remote accessibility methods to be more accurate.
Make sure to unregister the AccessibilityWebPageObject on dealloc.
Send the window remote token along with the WKView remote token.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::accessibilityWebProcessTokenReceived):

  • UIProcess/API/mac/WKView.mm:

(-[WKView _updateRemoteAccessibilityRegistration:]):
(-[WKView initWithFrame:contextRef:pageGroupRef:]):
(-[WKView viewDidMoveToWindow]):
(-[WKView _processDidCrash]):
(-[WKView _pageClosed]):
(-[WKView _setAccessibilityWebProcessToken:]):

  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::registerWebProcessAccessibilityToken):
(WebKit::WebPageProxy::registerUIProcessAccessibilityTokens):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/mac/AccessibilityWebPageObject.mm:

(-[AccessibilityWebPageObject dealloc]):

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::platformInitialize):
(WebKit::WebPage::registerUIProcessAccessibilityTokens):

2:12 AM Changeset in webkit [78428] by cwzwarich@webkit.org
  • 8 edits in trunk/Source

Reviewed by Dan Bernstein.

Bug 53760 - JSC fails to build with TOT Clang
​https://bugs.webkit.org/show_bug.cgi?id=53760

Fix -Woverloaded-virtual warnings. This is also a 6% speedup on the v8 raytrace
benchmark; it is nothing-to-noise on everything else.

JavaScriptCore:

  • API/JSCallbackObject.h: Remove pointlessly overloaded method.
  • API/JSCallbackObjectFunctions.h: Ditto.
  • runtime/Arguments.cpp:

(JSC::Arguments::put): Change signature to match the base class. This implementation
was no longer being called by anyone. This wasn't noticed because it is merely an
optimization of the base class' implementation.

  • runtime/Arguments.h: Ditto.

JavaScriptGlue:

  • UserObjectImp.cpp:

(UserObjectImp::toPrimitive): Use PreferredPrimitiveType instead of JSType to
match the base class.

  • UserObjectImp.h:
2:02 AM Changeset in webkit [78427] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-13 Shinichiro Hamaji <​hamaji@chromium.org>

Update chromium's test expectations for fast/inline/inline-box-background-*

  • platform/chromium/test_expectations.txt:
Note: See TracTimeline for information about the timeline view.