⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 20, 2011:

11:26 PM Changeset in webkit [79192] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-02-20 MORITA Hajime <​morrita@google.com>

Unreviewed expectation update.

  • platform/chromium/test_expectations.txt:
11:21 PM Changeset in webkit [79191] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

2011-02-16 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

keyboard support for extending/shrinking comment context
​https://bugs.webkit.org/show_bug.cgi?id=54612

ctrl+shift+up/down will extend/shrink the comment context when
a comment is focused or when one is being edited.

Also, switch over to using keydown instead of keypress events.
This lets us share code for handling escape and other key events.
Also, keypress is evil and should die.

  • code-review.js:
11:09 PM Changeset in webkit [79190] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-02-20 Ojan Vafai <​ojan@chromium.org>

Recommit accidental revert.
r79180 accidentally revereted r79178.

  • code-review.js:
11:04 PM Changeset in webkit [79189] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-02-20 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

[codereviewtool] add more help information
​https://bugs.webkit.org/show_bug.cgi?id=54847

  • code-review.js:
10:53 PM Changeset in webkit [79188] by Lucas Forschler
  • 5 edits in branches/safari-534.20-branch/Source

Versioning.

10:48 PM Changeset in webkit [79187] by Lucas Forschler
  • 1 move in tags/Safari-534.20.7

Renaming tag

10:46 PM Changeset in webkit [79186] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

2011-02-20 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

[codereviewtool] use 'r' to focus the review select element
​https://bugs.webkit.org/show_bug.cgi?id=54845

This allows for quick keyboard access to the toolbar items.
Hit r to get to the review select element. Then you can
tab to the cq/preview/publish elements.

  • code-review.js:
10:41 PM Changeset in webkit [79185] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-02-20 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

[codereviewtool] don't let lines/diffblocks be mouse focusable
​https://bugs.webkit.org/show_bug.cgi?id=54851

Unfortunately, this will only work once ​https://bugs.webkit.org/show_bug.cgi?id=54727
is committed. In the interim, it won't break anything.

  • code-review.js:
10:40 PM Changeset in webkit [79184] by Lucas Forschler
  • 1 copy in tags/Safari-534.20.8

New tag.

10:39 PM Changeset in webkit [79183] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-02-20 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

[codereviewtool] use keydown instead of keypress
​https://bugs.webkit.org/show_bug.cgi?id=54849

There is no functional change. This is just a cleanup
to make future patches (e.g. ​https://bugs.webkit.org/show_bug.cgi?id=54612)
cleaner.

  • code-review.js:
10:37 PM Changeset in webkit [79182] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-02-20 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

[codereviewtool] fix layout nit
​https://bugs.webkit.org/show_bug.cgi?id=54848

There is occasionally an off-by-one in the 50% width
calculation. This ensures that the add lines always
line up with the shared context lines.

  • PrettyPatch/PrettyPatch.rb:
9:48 PM Changeset in webkit [79181] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-02-20 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Ojan Vafai.

test-webkitpy: stop skipping a bunch of tests on win32
​https://bugs.webkit.org/show_bug.cgi?id=54788

  • Scripts/webkitpy/common/net/testoutputset_unittest.py:
  • Scripts/webkitpy/test/main.py:
9:44 PM Changeset in webkit [79180] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-02-20 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

[codereviewtool] make escape hide the preview form
​https://bugs.webkit.org/show_bug.cgi?id=54844

  • code-review.js:
9:37 PM Changeset in webkit [79179] by barraclough@apple.com
  • 5 edits in trunk/Source/WebCore

Build fix (remove includes).

  • bindings/js/JSDOMBinding.cpp:
  • bindings/js/JSDOMWindowCustom.cpp:
  • bindings/js/JSHistoryCustom.cpp:
  • bindings/js/JSLocationCustom.cpp:
9:37 PM Changeset in webkit [79178] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-02-20 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

[codereviewtool] make enter work when an individual line is focused
​https://bugs.webkit.org/show_bug.cgi?id=54843

  • code-review.js:
9:18 PM Changeset in webkit [79177] by barraclough@apple.com
  • 51 edits
    5 deletes in trunk/Source

​https://bugs.webkit.org/show_bug.cgi?id=54839
Remove PrototypeFunction, NativeFunctionWrapper, and GlobalEvalFunction.

Reviewed by Oliver Hunt.

Historically, Native functions used to be represented by PrototypeFunctions, however
since introducing call optimizations to the JIT this has used JSFunctions for host
calls too. At the point this change was made, the interpreter continued to use
PrototypeFunctions, however since fallback from the JIT to interpreter was introduced
the interpreter has had to be able to run using host functions represented using
JSFunctions - leading to an unnecessary and redundant divergence in behaviour between
interpreter only builds, and situations where the JIT has fallen back to interpreting.

NativeFunctionWrapper only existed to select between PrototypeFunction and JSFunction
for wrappers for host functions, and as such can also be removed.

GlobalEvalFunction is a redundant wrapper that happens to be derived from
PrototypeFunction. It existed to hold a reference to the global object - but since all
functions how derive from JSObjectWithGlobalObject, this no longer requires an
additional class to provide this functionality.

Source/JavaScriptCore:

Removed symbols / references to files.

  • runtime/GlobalEvalFunction.cpp: Removed.
  • runtime/GlobalEvalFunction.h: Removed.
  • runtime/NativeFunctionWrapper.h: Removed.
  • runtime/PrototypeFunction.cpp: Removed.
  • runtime/PrototypeFunction.h: Removed.

Removed.

  • runtime/Executable.cpp:

(JSC::NativeExecutable::~NativeExecutable):

  • runtime/Executable.h:

(JSC::NativeExecutable::create):
(JSC::NativeExecutable::NativeExecutable):
(JSC::JSFunction::nativeFunction):

  • runtime/JSFunction.cpp:

(JSC::callHostFunctionAsConstructor):
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::getCallData):

  • runtime/JSFunction.h:
  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::getHostFunction):

  • runtime/JSGlobalData.h:

(JSC::JSGlobalData::getCTIStub):

Added interpreter-friendly constructors for NativeExecutables.

  • bytecompiler/BytecodeGenerator.cpp:
  • interpreter/Interpreter.cpp:
  • jit/JITStubs.cpp:
  • jsc.cpp:
  • runtime/ArrayConstructor.cpp:
  • runtime/BooleanPrototype.cpp:
  • runtime/BooleanPrototype.h:
  • runtime/CallData.h:
  • runtime/DateConstructor.cpp:
  • runtime/DateConstructor.h:
  • runtime/ErrorPrototype.cpp:
  • runtime/ErrorPrototype.h:
  • runtime/FunctionPrototype.cpp:
  • runtime/FunctionPrototype.h:
  • runtime/JSGlobalObject.cpp:
  • runtime/JSGlobalObject.h:
  • runtime/JSGlobalObjectFunctions.cpp:
  • runtime/Lookup.cpp:
  • runtime/NumberPrototype.cpp:
  • runtime/NumberPrototype.h:
  • runtime/ObjectConstructor.cpp:
  • runtime/ObjectConstructor.h:
  • runtime/ObjectPrototype.cpp:
  • runtime/ObjectPrototype.h:
  • runtime/RegExpPrototype.cpp:
  • runtime/RegExpPrototype.h:
  • runtime/SmallStrings.h:
  • runtime/StringConstructor.cpp:
  • runtime/StringConstructor.h:

Removed use of redundant classes.

Source/WebCore:

  • bindings/js/JSDOMBinding.cpp:
  • bindings/js/JSDOMWindowCustom.cpp:
  • bindings/js/JSHistoryCustom.cpp:
  • bindings/js/JSLocationCustom.cpp:

Removed use of redundant classes.

9:07 PM Changeset in webkit [79176] by dpranke@chromium.org
  • 8 edits in trunk/Tools

2011-02-20 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Ojan Vafai.

Fix various bugs related to handling of dir separators and real
vs. fake filesystems that were causing test-webkitpy to fail
tests on win32. These bugs have a variety of causes but are
lumped together because they should be easy to review.

​https://bugs.webkit.org/show_bug.cgi?id=54700

  • Scripts/webkitpy/common/net/testoutput.py: Here we were using os.path.sep but not escaping it prior to using in a regexp, which caused bad things on win32.
  • Scripts/webkitpy/common/net/testoutput_unittest.py: Same here.
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Here we were using the native filesystem instead of the mock filesystem, making some tests unnecessarily platform dependent. Also we weren't setting the default configuration for the TestChromiumWinPort.
  • Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py: Here we *shouldn't* use os.path.join(), just so the code becomes less platform dependent.
  • Scripts/webkitpy/style/checker.py: Here we should be using os.path.sep instead of "/"; the tests require the native filesystem.
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Here the underlying code is using os.path.sep, so we probably should as well.
  • Scripts/webkitpy/style/test_expectations_unittest.py: Here we should be using the filesystem hanging of the port object (which is the mocked filesystem) rather than the native one.
8:59 PM Changeset in webkit [79175] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-02-20 MORITA Hajime <​morrita@google.com>

Unreviewed expectation update.

  • platform/chromium/test_expectations.txt:
8:37 PM Changeset in webkit [79174] by tkent@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-02-20 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r79169.
​http://trac.webkit.org/changeset/79169
​https://bugs.webkit.org/show_bug.cgi?id=54846

Made unexpected results for tests without CJK characters
(Requested by tkent on #webkit).

  • platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::FontCache::createFontPlatformData):
  • platform/graphics/chromium/FontPlatformDataChromiumWin.cpp: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::operator=):
  • platform/graphics/chromium/FontPlatformDataChromiumWin.h: (WebCore::FontPlatformData::orientation):
  • platform/graphics/skia/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData):
8:28 PM Changeset in webkit [79173] by Lucas Forschler
  • 2 edits in branches/safari-534.20-branch/Source/WebKit2

Merge r79170.

8:20 PM Changeset in webkit [79172] by Lucas Forschler
  • 7 edits
    2 copies in branches/safari-534.20-branch

Merge r79167.

7:58 PM Changeset in webkit [79171] by gyuyoung.kim@samsung.com
  • 5 edits in trunk/Source/WebKit/efl

2011-02-20 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Kent Tamura.

[EFL] Fix coding style errors in tiled BS and ewk_window_feature.h
​https://bugs.webkit.org/show_bug.cgi?id=54842

Fix style errors in ewk files.

  • ewk/ewk_tiled_backing_store.h:
  • ewk/ewk_tiled_matrix.h:
  • ewk/ewk_tiled_model.h:
  • ewk/ewk_window_features.h:
7:43 PM Changeset in webkit [79170] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Crash in WebProcess at com.apple.WebCore: WebCore::Page::goToItem + 46
<rdar://problem/8942726>

Reviewed by Dan Bernstein.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::goForward):
(WebKit::WebPage::goBack):
(WebKit::WebPage::goToBackForwardItem):
Defend agains null HistoryItems.

7:28 PM Changeset in webkit [79169] by tkent@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-02-20 Chun-Lung Huang <​alvincl.huang@gmail.com>

Reviewed by Kent Tamura.

On Chromium Windows, glyphs in vertical text tests are rotated 90
degrees clockwise. ​https://bugs.webkit.org/show_bug.cgi?id=51450

This platform dependent patch makes Chromium Windows show the
vertical writing text correctly. Job was done by adding a prefix '@'
in front of the font family name (Windows Only). No new tests added.

  • platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::FontCache::createFontPlatformData):
  • platform/graphics/chromium/FontPlatformDataChromiumWin.cpp: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::operator=):
  • platform/graphics/chromium/FontPlatformDataChromiumWin.h: (WebCore::FontPlatformData::orientation):
  • platform/graphics/skia/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData):
7:26 PM Changeset in webkit [79168] by Simon Fraser
  • 3 edits
    4 adds in trunk

2011-02-20 Simon Fraser <Simon Fraser>

Reviewed by Dirk Schulze.

REGRESSION (r73369-r73405): transform animation interpolates incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=54793

After the refactoring in r73380, the ending state for some types of
accelerated animations was computed incorrectly, because the TransformationMatrix
wasn't reset to identity before the ending value transformations were applied.

Fix by cleaning up the code to use explicit, separate values for
starting and ending values. Only matrix-type animations had this
issue, but cleaned up other clauses similarly.

Test: animations/3d/matrix-transform-type-animation.html

  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::setTransformAnimationEndpoints):
7:06 PM Changeset in webkit [79167] by mitz@apple.com
  • 7 edits
    2 adds in trunk

<rdar://problem/9028929> REGRESSION (r75897): Scaling applied twice to an iframe with a transformed ancestor

Reviewed by Maciej Stachowiak.

Source/WebCore:

Test: fast/frames/iframe-scale-applied-twice.html

  • page/FrameView.cpp:

(WebCore::FrameView::create): Set the initial bounds of the view to match the
frame size.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::visibleContentRect): Based on bounds, not frame size.
(WebCore::ScrollView::updateScrollbars): Ditto.
(WebCore::ScrollView::setFrameRect): Moved code that really handles bounds size
change to setBoundsSize().
(WebCore::ScrollView::setBoundsSize): Added.
(WebCore::ScrollView::setInitialBoundsSize): Added. Sets the bounds size but does
not update anything.
(WebCore::ScrollView::frameRectsChanged): Based on bounds, not frame size.
(WebCore::ScrollView::scrollbarCornerPresent): Ditto.

  • platform/ScrollView.h:

(WebCore::ScrollView::boundsSize): Added this getter.

  • platform/Widget.h:

(WebCore::Widget::resize): Set the bounds size to the frame size.

  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::paint): Fixed an error in the indirect drawing code
path where the buffer rect was resized to capture only the damaged part, but was
still drawn in the original location.

LayoutTests:

  • fast/frames/iframe-scale-applied-twice-expected.txt: Added.
  • fast/frames/iframe-scale-applied-twice.html: Added.
6:45 PM Changeset in webkit [79166] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

2011-02-17 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

use shift+j/k to focus next/previous line
​https://bugs.webkit.org/show_bug.cgi?id=54723

Tested on a large Hyatt change to confirm it performed fine.
(​https://bugs.webkit.org/attachment.cgi?id=82533&action=review)

  • code-review.js:
6:38 PM Changeset in webkit [79165] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-02-17 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

fix escape handling in code review tool
​https://bugs.webkit.org/show_bug.cgi?id=54722

This broke with ​http://trac.webkit.org/changeset/78948.
Apparently jquery events get a wrapped object that
does not expose keyIdentifier.

  • code-review.js:
6:36 PM Changeset in webkit [79164] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-02-17 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

create comments when hitting enter with a focused diff
​https://bugs.webkit.org/show_bug.cgi?id=54719

  • code-review.js:
6:29 PM Changeset in webkit [79163] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

2011-02-17 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

use actual browser focus in the code review tool
​https://bugs.webkit.org/show_bug.cgi?id=54726

This makes keyboard handling play better with focusable element
(i.e. links/textareas/buttons). Also, in theory, this makes
the review tool more amenable to screen readers (I think).

  • PrettyPatch/PrettyPatch.rb:
  • code-review.js:
6:24 PM Changeset in webkit [79162] by Lucas Forschler
  • 4 edits in branches/safari-534.20-branch/Source/WebKit2

Merge 79165.

6:20 PM Changeset in webkit [79161] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

2011-02-20 Ami Fischman <​fischman@chromium.org>

Reviewed by Kent Tamura.

Remove flakiness from media/video-poster.html by using event callbacks
instead of 100ms timeouts and hoping that states have transitioned in
time (!).
Removed seemingly-outdated BUG_DRT annotation from test_expectation.

​https://bugs.webkit.org/show_bug.cgi?id=54685
​http://crbug.com/60845

  • media/video-poster.html:
  • platform/chromium/test_expectations.txt:
5:35 PM Changeset in webkit [79160] by kalman@chromium.org
  • 4 edits in trunk/LayoutTests

2011-02-21 Benjamin Kalman <​kalman@chromium.org>

Reviewed by Ryosuke Niwa.

Make editing/selection/extend-selection tests more human readable and hand-runnable
​https://bugs.webkit.org/show_bug.cgi?id=54712

Three changes to achieve this:

  • Column-align the "right:", "left:", "forward:", and "backward:" labels in the output.
  • Add buttons to switch between LTR and RTL (the test will switch everything to RTL but LTR is useful).
  • Fix typo causing failing tests to have a js error (rather than layout error).

Expected results need to change due to column alignment.

  • editing/selection/extend-selection-character-expected.txt:
  • editing/selection/extend-selection-word-expected.txt:
  • editing/selection/resources/extend-selection.js: (logMismatchingPositions): (runSelectionTestsWithGranularity): (getTestNodeContainer.createButton.button.onmousedown): (getTestNodeContainer.createButton): (getTestNodeContainer.createButtonToSwitchDirection): (getTestNodeContainer): (createNode):
5:07 PM Changeset in webkit [79159] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Reviewed by Eric Seidel.

Tighten up access permissions by using libxslt API
​https://bugs.webkit.org/show_bug.cgi?id=52688
<rdar://problem/8909191>

  • xml/XSLTProcessorLibxslt.cpp: (WebCore::XSLTProcessor::transformToString): We are only interested in a string result, so let libxslt know about that.
4:35 PM Changeset in webkit [79158] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-02-20 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r79104.
​http://trac.webkit.org/changeset/79104
​https://bugs.webkit.org/show_bug.cgi?id=54835

Might have caused flaky canaries (Requested by tonyg-cr on
#webkit).

  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::canTakeNextToken): (WebCore::HTMLDocumentParser::pumpTokenizer):
  • html/parser/HTMLParserScheduler.cpp: (WebCore::isLayoutTimerActive):
  • html/parser/HTMLParserScheduler.h: (WebCore::HTMLParserScheduler::checkForYieldBeforeToken):
  • page/FrameView.h:
4:09 PM Changeset in webkit [79157] by andersca@apple.com
  • 11 edits
    3 adds in trunk

2011-02-20 Anders Carlsson <​andersca@apple.com>

Reviewed by Maciej Stachowiak.

Crash when a plug-in requests a javascript: url that destroys the plug-in
​https://bugs.webkit.org/show_bug.cgi?id=54837
<rdar://problem/9005475>

Add new plug-in test.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: (PluginTest::NPN_GetURL):
  • DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
  • DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURLDestroyingPlugin.cpp: Added. (GetURLWithJavaScriptURLDestroyingPlugin::GetURLWithJavaScriptURLDestroyingPlugin): (GetURLWithJavaScriptURLDestroyingPlugin::NPP_New):
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:

2011-02-20 Anders Carlsson <​andersca@apple.com>

Reviewed by Maciej Stachowiak.

Crash when a plug-in requests a javascript: url that destroys the plug-in
​https://bugs.webkit.org/show_bug.cgi?id=54837
<rdar://problem/9005475>

Add test.

  • plugins/get-url-with-javascript-destroying-plugin-expected.txt: Added.
  • plugins/get-url-with-javascript-destroying-plugin.html: Added.

2011-02-20 Anders Carlsson <​andersca@apple.com>

Reviewed by Maciej Stachowiak.

Crash when a plug-in requests a javascript: url that destroys the plug-in
​https://bugs.webkit.org/show_bug.cgi?id=54837
<rdar://problem/9005475>

  • WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::destroy): Null out m_pluginController.
  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::performJavaScriptURLRequest): Don't access the frame through m_pluginElement since it will be nulled out when the plug-in is destroyed.
3:04 PM Changeset in webkit [79156] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-02-20 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Fix another crash when a plug-in is destroyed when evaluating JavaScript
​https://bugs.webkit.org/show_bug.cgi?id=54834
<rdar://problem/9013384>

This contains three separate fixes:

  • In unprotectPluginFromDestruction we can't just destroy the plug-in once the count reaches zero, because the plug-in might still have code executing on the stack. To fix this we use a zero-delay timer to defer destruction of the plug-in.
  • Trying to get the NPObject for the window using NPN_GetValue would return NPERR_NO_ERROR, even if the returned NPObject was null. Fix this to return NPERR_GENERIC_ERROR instead.
  • Protect the plug-in from destruction anytime an NPAPI call that sends a synchronous IPC message is made.
  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::PluginControllerProxy): (WebKit::PluginControllerProxy::destroy): (WebKit::PluginControllerProxy::unprotectPluginFromDestruction):
  • PluginProcess/PluginControllerProxy.h:
  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::PluginDestructionProtector::PluginDestructionProtector): (WebKit::NPN_GetValue): (WebKit::NPN_Evaluate): (WebKit::NPN_GetProperty): (WebKit::NPN_SetProperty): (WebKit::NPN_RemoveProperty): (WebKit::NPN_HasProperty): (WebKit::NPN_HasMethod): (WebKit::NPN_Enumerate): (WebKit::NPN_Construct): (WebKit::NPN_GetValueForURL): (WebKit::NPN_SetValueForURL):
2:27 PM Changeset in webkit [79155] by krit@webkit.org
  • 18 edits
    3 adds in trunk

2011-02-20 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG animation - analyze attribute type for animation
​https://bugs.webkit.org/show_bug.cgi?id=54542

Check dynamic update of attributeName. The test fails at the moment, because of some wrong
internal mapping. Tested update manually with gdb. Working on a fix to get this test pass
as well.

  • svg/animations/animate-dynamic-update-attributeName-expected.txt: Added.
  • svg/animations/animate-dynamic-update-attributeName.html: Added.
  • svg/animations/script-tests/animate-dynamic-update-attributeName.js: Added. (sample1): (sample2): (sample3): (executeTest):

2011-02-20 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG animation - analyze attribute type for animation
​https://bugs.webkit.org/show_bug.cgi?id=54542

Analyze animated attribute type to determine the kind of animation. Removed enum PropertyType and replace it
with AnimatedAttributeType instead. More cleanup of the animation code.
Added missing fillAttributeToPropertyTypeMap() for SVGGElement.

Use QualifiedName instead of AtomicStrings for attribute names. This makes it easier to handle animated attributes
from a different namespace like xlink:href. The rest of the SVG code is using QualifiedNames as well.

No change of functionality on the animation code. The changes for the <g>-element affect animateTransform. Sadly
animateTransform is not supported by our SVG animation test script at the moment. Can still be tested manually
with the W3C test suite in trunk.

The change on SVGUseElement gets covered by animate-elem-39-t.svg

Test: svg/animations/animate-dynamic-update-attributeName.html

  • svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::SVGAnimateElement): (WebCore::SVGAnimateElement::hasValidAttributeType): (WebCore::SVGAnimateElement::determineAnimatedAttributeType): (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::inheritsFromProperty): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::calculateFromAndByValues): (WebCore::SVGAnimateElement::resetToBaseValue): (WebCore::SVGAnimateElement::applyResultsToTarget): (WebCore::SVGAnimateElement::calculateDistance):
  • svg/SVGAnimateElement.h:
  • svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::hasValidAttributeType): (WebCore::parsePoint): (WebCore::SVGAnimateMotionElement::resetToBaseValue): (WebCore::SVGAnimateMotionElement::calculateAnimatedValue): (WebCore::SVGAnimateMotionElement::calculateDistance):
  • svg/SVGAnimateMotionElement.h:
  • svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::hasValidAttributeType): (WebCore::SVGAnimateTransformElement::determineAnimatedAttributeType): (WebCore::SVGAnimateTransformElement::resetToBaseValue): (WebCore::SVGAnimateTransformElement::calculateAnimatedValue): (WebCore::SVGAnimateTransformElement::calculateFromAndByValues): (WebCore::SVGAnimateTransformElement::applyResultsToTarget): (WebCore::SVGAnimateTransformElement::calculateDistance):
  • svg/SVGAnimateTransformElement.h:
  • svg/SVGAnimationElement.cpp: (WebCore::parseKeyTimes): (WebCore::parseKeySplines): (WebCore::SVGAnimationElement::isTargetAttributeCSSProperty): (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue): (WebCore::SVGAnimationElement::calculateKeyTimesForCalcModePaced): (WebCore::solveEpsilon): (WebCore::SVGAnimationElement::calculatePercentFromKeyPoints): (WebCore::SVGAnimationElement::currentValuesFromKeyPoints): (WebCore::SVGAnimationElement::currentValuesForValuesAnimation): (WebCore::SVGAnimationElement::startedActiveInterval):
  • svg/SVGAnimationElement.h:
  • svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::fillAttributeToPropertyTypeMap):
  • svg/SVGGElement.cpp: (WebCore::SVGGElement::attributeToPropertyTypeMap): (WebCore::SVGGElement::fillAttributeToPropertyTypeMap): Added to fill the animated attribute map for this element.
  • svg/SVGGElement.h:
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::fillAttributeToPropertyTypeMap): Changed attribute type to AnimatedString for xlink:href.
  • svg/animation/SMILTimeContainer.cpp: (WebCore::SMILTimeContainer::baseValueFor): (WebCore::SMILTimeContainer::updateAnimations):
  • svg/animation/SMILTimeContainer.h:
  • svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::SVGSMILElement): (WebCore::constructQualifiedName): Create a QualifiedName from a attribute name. (WebCore::SVGSMILElement::insertedIntoDocument): Update local varaible of attribute name. (WebCore::SVGSMILElement::removedFromDocument): Ditto. (WebCore::SVGSMILElement::attributeChanged): Ditto.
  • svg/animation/SVGSMILElement.h: (WebCore::SVGSMILElement::attributeName):
1:16 PM Changeset in webkit [79154] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

BUILD FIX: Add missing UNUSED_PARAM() when !ENABLE(FULLSCREEN_API)

Not reviewed.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForFullScreen):

3:20 AM Changeset in webkit [79153] by Lucas Forschler
  • 5 edits in branches/safari-534.20-branch/Source

Versioning.

3:14 AM Changeset in webkit [79152] by Lucas Forschler
  • 1 copy in tags/Safari-534.20.6

New tag.

1:28 AM Changeset in webkit [79151] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

2011-02-20 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Implement PlatformKeyboardEvent::getCurrentModifierState()
​https://bugs.webkit.org/show_bug.cgi?id=52880

  • platform/gtk/KeyEventGtk.cpp: (WebCore::PlatformKeyboardEvent::getCurrentModifierState):
1:22 AM Changeset in webkit [79150] by Carlos Garcia Campos
  • 2 edits in trunk

2011-02-20 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Bump GTK+3 dependency to 3.0
​https://bugs.webkit.org/show_bug.cgi?id=54394

  • configure.ac:
12:50 AM Changeset in webkit [79149] by mitz@apple.com
  • 815 edits in trunk/LayoutTests/platform

Set the svn:mime-type property of some PNG files to image/png

12:11 AM Changeset in webkit [79148] by Lucas Forschler
  • 5 edits in branches/safari-534.20-branch/Source

Versioning.

Feb 19, 2011:

11:33 PM Changeset in webkit [79147] by Lucas Forschler
  • 1 copy in tags/Safari-534.20.5

New tag.

10:20 PM Changeset in webkit [79146] by Lucas Forschler
  • 2 edits in branches/safari-534.20-branch/Source/WebKit2

Merge r79133.

7:10 PM Changeset in webkit [79145] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-02-19 Andreas Kling <​kling@webkit.org>

Reviewed by Oliver Hunt.

DragController should use Color::serialized() when passing colors to CSSStyleDeclaration
​https://bugs.webkit.org/show_bug.cgi?id=54545

  • page/DragController.cpp: (WebCore::DragController::concludeEditDrag):
5:00 PM Changeset in webkit [79144] by Laszlo Gombos
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-19 Laszlo Gombos <Laszlo Gombos>

Unreviewed build fix for Symbian.

[Symbian] Revert the removal of linking
against hal after r79126.

Dependency on the hal library can not be removed
as it is still used (e.g. in MarkStackSymbian.cpp).

4:44 PM Changeset in webkit [79143] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

2011-02-19 Lukasz Slachciak <​l.slachciak@samsung.com>

Reviewed by Andreas Kling.

[EFL] Eliminated error when .webkit directory doesn't exist.
​https://bugs.webkit.org/show_bug.cgi?id=54813

  • ewk/ewk_main.cpp: (_ewk_init_body):
4:05 PM Changeset in webkit [79142] by barraclough@apple.com
  • 12 edits in trunk/Source/JavaScriptCore

Interpreter build fix.

  • runtime/ArrayConstructor.cpp:
  • runtime/BooleanPrototype.cpp:
  • runtime/DateConstructor.cpp:
  • runtime/ErrorPrototype.cpp:
  • runtime/FunctionPrototype.cpp:
  • runtime/Lookup.cpp:
  • runtime/NumberPrototype.cpp:
  • runtime/ObjectConstructor.cpp:
  • runtime/ObjectPrototype.cpp:
  • runtime/RegExpPrototype.cpp:
  • runtime/StringConstructor.cpp:
3:59 PM Changeset in webkit [79141] by weinig@apple.com
  • 9 edits in trunk/Source

Add phase in addition to momentumPhase to platform wheel events
Part of <rdar://problem/8945362>

Reviewed by Anders Carlsson.

Rename existing phase to momentumPhase.

../WebCore:

  • platform/PlatformWheelEvent.h:

(WebCore::PlatformWheelEvent::PlatformWheelEvent):
(WebCore::PlatformWheelEvent::momentumPhase):

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::handleWheelEvent):
(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):

  • platform/mac/WheelEventMac.mm:

(WebCore::momentumPhaseForEvent):
(WebCore::phaseForEvent):
(WebCore::PlatformWheelEvent::PlatformWheelEvent):

../WebKit2:

  • Shared/WebEvent.h:

(WebKit::WebWheelEvent::momentumPhase):

  • Shared/WebEventConversion.cpp:

(WebKit::WebKit2PlatformWheelEvent::WebKit2PlatformWheelEvent):

  • Shared/WebWheelEvent.cpp:

(WebKit::WebWheelEvent::WebWheelEvent):
(WebKit::WebWheelEvent::encode):
(WebKit::WebWheelEvent::decode):

  • Shared/mac/WebEventFactory.mm:

(WebKit::phaseForEvent):
(WebKit::momentumPhaseForEvent):
(WebKit::WebEventFactory::createWebWheelEvent):

2:41 PM Changeset in webkit [79140] by barraclough@apple.com
  • 2 edits in trunk/Source/WebCore

Qt build fix.

  • bridge/runtime_method.h:

(JSC::RuntimeMethod::createStructure):

2:32 PM Changeset in webkit [79139] by barraclough@apple.com
  • 3 edits in trunk/Source/WebCore

Qt build fix.

  • bridge/qt/qt_instance.cpp:
  • bridge/qt/qt_pixmapruntime.cpp:
2:27 PM Changeset in webkit [79138] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Build fix!!

2:24 PM Changeset in webkit [79137] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix!!

2:18 PM Changeset in webkit [79136] by barraclough@apple.com
  • 3 edits in trunk/Source/WebCore

Qt build fix.

  • bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtInstance::getMethod):

  • bridge/qt/qt_pixmapruntime.cpp:

(JSC::Bindings::QtPixmapInstance::getMethod):

2:12 PM Changeset in webkit [79135] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix!

2:04 PM Changeset in webkit [79134] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Build fix!

1:57 PM Changeset in webkit [79133] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-19 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Crash when trying to take a snapshot of an uninitialized plug-in
​https://bugs.webkit.org/show_bug.cgi?id=54812

  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::notifyWidget): Don't try to create a snapshot of the plug-in if it hasn't been initialized.
1:55 PM Changeset in webkit [79132] by barraclough@apple.com
  • 159 edits in trunk/Source

Bug 54786 - Devirtualize JSCell::classInfo()

Reviewed by Sam Weinig.

Instead of making a virtual function call, add a pointer to the ClassInfo
onto Structure.

This removes a virtual function call, and paves the way towards removing all
the createStructure methods, and StructureFlags/AnonymousSlotCount properties
(these should be able to move onto ClassInfo).

Calls to Structure::create must now pass a pointer to the ClassInfo for the
structure. All objects now have a ClassInfo pointer, non-object cell types
still do not.

Changes are most mechanical, involving three steps:

  • Remove virtual classInfo() methods.
  • Add &s_info parameter to calls to Structure::create.
  • Rename ClassInfo static members on classes from 'info' to 's_info', for consistency.

Source/JavaScriptCore:

  • API/JSCallbackConstructor.cpp:
  • API/JSCallbackConstructor.h:
  • API/JSCallbackFunction.cpp:
  • API/JSCallbackFunction.h:
  • API/JSCallbackObject.cpp:
  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h:
  • API/JSObjectRef.cpp:
  • API/JSValueRef.cpp:
  • API/JSWeakObjectMapRefPrivate.cpp:
  • JavaScriptCore.exp:
  • debugger/Debugger.cpp:
  • debugger/DebuggerActivation.h:
  • debugger/DebuggerCallFrame.cpp:
  • interpreter/Interpreter.cpp:
  • jit/JITCall32_64.cpp:
  • jit/JITOpcodes.cpp:
  • jit/JITStubs.cpp:
  • profiler/Profiler.cpp:
  • runtime/Arguments.cpp:
  • runtime/Arguments.h:
  • runtime/ArrayConstructor.cpp:
  • runtime/ArrayPrototype.cpp:
  • runtime/ArrayPrototype.h:
  • runtime/BooleanObject.cpp:
  • runtime/BooleanObject.h:
  • runtime/BooleanPrototype.cpp:
  • runtime/DateConstructor.cpp:
  • runtime/DateInstance.cpp:
  • runtime/DateInstance.h:
  • runtime/DatePrototype.cpp:
  • runtime/DatePrototype.h:
  • runtime/ErrorInstance.cpp:
  • runtime/ErrorInstance.h:
  • runtime/ErrorPrototype.cpp:
  • runtime/FunctionPrototype.cpp:
  • runtime/FunctionPrototype.h:
  • runtime/GetterSetter.h:
  • runtime/GlobalEvalFunction.h:
  • runtime/InternalFunction.cpp:
  • runtime/InternalFunction.h:
  • runtime/JSAPIValueWrapper.h:
  • runtime/JSActivation.cpp:
  • runtime/JSActivation.h:
  • runtime/JSArray.cpp:
  • runtime/JSArray.h:
  • runtime/JSByteArray.cpp:
  • runtime/JSByteArray.h:
  • runtime/JSCell.cpp:
  • runtime/JSCell.h:
  • runtime/JSFunction.cpp:
  • runtime/JSFunction.h:
  • runtime/JSGlobalData.cpp:
  • runtime/JSGlobalObject.cpp:
  • runtime/JSGlobalObject.h:
  • runtime/JSNotAnObject.h:
  • runtime/JSONObject.cpp:
  • runtime/JSONObject.h:
  • runtime/JSObject.cpp:
  • runtime/JSObject.h:
  • runtime/JSObjectWithGlobalObject.h:
  • runtime/JSPropertyNameIterator.h:
  • runtime/JSStaticScopeObject.h:
  • runtime/JSString.h:
  • runtime/JSVariableObject.h:
  • runtime/JSWrapperObject.h:
  • runtime/JSZombie.cpp:
  • runtime/JSZombie.h:
  • runtime/Lookup.cpp:
  • runtime/MathObject.cpp:
  • runtime/MathObject.h:
  • runtime/NativeErrorConstructor.cpp:
  • runtime/NativeErrorConstructor.h:
  • runtime/NumberConstructor.cpp:
  • runtime/NumberConstructor.h:
  • runtime/NumberObject.cpp:
  • runtime/NumberObject.h:
  • runtime/NumberPrototype.cpp:
  • runtime/ObjectConstructor.cpp:
  • runtime/ObjectPrototype.cpp:
  • runtime/RegExpConstructor.cpp:
  • runtime/RegExpConstructor.h:
  • runtime/RegExpObject.cpp:
  • runtime/RegExpObject.h:
  • runtime/RegExpPrototype.cpp:
  • runtime/ScopeChain.cpp:
  • runtime/StringConstructor.cpp:
  • runtime/StringObject.cpp:
  • runtime/StringObject.h:
  • runtime/StringObjectThatMasqueradesAsUndefined.h:
  • runtime/StringPrototype.cpp:
  • runtime/StringPrototype.h:
  • runtime/Structure.cpp:
  • runtime/Structure.h:

Source/JavaScriptGlue:

  • JSUtils.cpp:

(KJSValueToJSObject):
(KJSValueToCFTypeInternal):

  • UserObjectImp.cpp:
  • UserObjectImp.h:

(UserObjectImp::createStructure):

Source/WebCore:

  • WebCore.exp.in:
  • bindings/js/JSAudioConstructor.cpp:
  • bindings/js/JSAudioConstructor.h:
  • bindings/js/JSDOMBinding.cpp:
  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMGlobalObject.cpp:
  • bindings/js/JSDOMGlobalObject.h:
  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSDOMWindowShell.cpp:
  • bindings/js/JSDOMWindowShell.h:
  • bindings/js/JSGeolocationCustom.cpp:
  • bindings/js/JSImageConstructor.cpp:
  • bindings/js/JSImageConstructor.h:
  • bindings/js/JSImageDataCustom.cpp:
  • bindings/js/JSOptionConstructor.cpp:
  • bindings/js/JSOptionConstructor.h:
  • bindings/js/JSWorkerContextBase.cpp:
  • bindings/js/JSWorkerContextBase.h:
  • bindings/js/SerializedScriptValue.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/c/CRuntimeObject.cpp:
  • bridge/c/CRuntimeObject.h:
  • bridge/c/c_instance.cpp:
  • bridge/jni/jsc/JNIUtilityPrivate.cpp:
  • bridge/jni/jsc/JavaInstanceJSC.cpp:
  • bridge/jni/jsc/JavaRuntimeObject.cpp:
  • bridge/jni/jsc/JavaRuntimeObject.h:
  • bridge/jsc/BridgeJSC.cpp:
  • bridge/objc/ObjCRuntimeObject.h:
  • bridge/objc/ObjCRuntimeObject.mm:
  • bridge/objc/objc_instance.mm:
  • bridge/objc/objc_runtime.h:
  • bridge/objc/objc_runtime.mm:
  • bridge/runtime_array.cpp:
  • bridge/runtime_array.h:
  • bridge/runtime_method.cpp:
  • bridge/runtime_method.h:
  • bridge/runtime_object.cpp:
  • bridge/runtime_object.h:

Source/WebKit/mac:

  • Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):
(WebKit::ProxyRuntimeMethod::createStructure):

  • Plugins/Hosted/ProxyRuntimeObject.h:

(WebKit::ProxyRuntimeObject::createStructure):

  • Plugins/Hosted/ProxyRuntimeObject.mm:

(WebKit::ProxyRuntimeObject::ProxyRuntimeObject):

  • WebView/WebView.mm:

(aeDescFromJSValue):

Source/WebKit2:

  • WebProcess/Plugins/Netscape/JSNPMethod.cpp:

(WebKit::JSNPMethod::JSNPMethod):

  • WebProcess/Plugins/Netscape/JSNPMethod.h:

(WebKit::JSNPMethod::createStructure):

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::JSNPObject):

  • WebProcess/Plugins/Netscape/JSNPObject.h:

(WebKit::JSNPObject::createStructure):

1:15 PM Changeset in webkit [79131] by ddkilzer@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

<​http://webkit.org/b/54808> Change jsc target to build directly into JavaScriptCore.framework/Resources/jsc

Reviewed by Dan Bernstein.

  • Configurations/Base.xcconfig: Added

JAVASCRIPTCORE_FRAMEWORKS_DIR variable.

  • Configurations/JavaScriptCore.xcconfig: Used

JAVASCRIPTCORE_FRAMEWORKS_DIR to define INSTALL_PATH.

for Production configuration of jsc target.
(Copy Into Framework): Removed old build phase.
(Fix Framework Reference): Renamed build phase to "Copy Into
Framework". Added "set -x" call to make the script print the
commands it is running. Added code to exit early for Production
builds since this was never intended for them. Added code to
copy jsc into the JavaScriptCore.framework/Resources directory.

1:06 PM Changeset in webkit [79130] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

2011-02-19 Ryuan Choi <​ryuan.choi@samsung.com>

Reviewed by Martin Robinson.

[GTK] Remove mandatory Enchant dependency
​https://bugs.webkit.org/show_bug.cgi?id=51587

Add enable-spellcheck option which decides whether to use enchant.
If disabled, WebKitGTK+ will not use enchant library.

  • configure.ac:

2011-02-19 Ryuan Choi <​ryuan.choi@samsung.com>

Reviewed by Martin Robinson.

[GTK] Remove mandatory Enchant dependency
​https://bugs.webkit.org/show_bug.cgi?id=51587

Extract TextCheckerClientEnchant From EditorClientGtk and remove
enchant dependency from other files.

  • GNUmakefile.am:
  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::EditorClient):
  • WebCoreSupport/EditorClientGtk.h: (WebKit::EditorClient::textChecker):
  • WebCoreSupport/TextCheckerClientEnchant.cpp: Added. (WebKit::TextCheckerClientEnchant::TextCheckerClientEnchant): (WebKit::TextCheckerClientEnchant::~TextCheckerClientEnchant): (WebKit::TextCheckerClientEnchant::ignoreWordInSpellDocument): (WebKit::TextCheckerClientEnchant::learnWord): (WebKit::TextCheckerClientEnchant::checkSpellingOfString): (WebKit::TextCheckerClientEnchant::getAutoCorrectSuggestionForMisspelledWord): (WebKit::TextCheckerClientEnchant::checkGrammarOfString): (WebKit::TextCheckerClientEnchant::getGuessesForWord): (WebKit::getAvailableDictionariesCallback): (WebKit::TextCheckerClientEnchant::updateSpellCheckingLanguage): (WebKit::TextCheckerClientEnchant::freeSpellCheckingLanguage):
  • WebCoreSupport/TextCheckerClientEnchant.h: Added. (WebKit::TextCheckerClientEnchant::requestCheckingOfString):
  • webkit/webkitwebsettings.cpp: (webkit_web_settings_finalize): (webkit_web_settings_set_property):
  • webkit/webkitwebview.cpp: (webkit_web_view_settings_notify):
12:28 PM Changeset in webkit [79129] by commit-queue@webkit.org
  • 4 edits in trunk

2011-02-19 Zan Dobersek <​zandobersek@gmail.com>

Reviewed by Martin Robinson.

[cairo][canvas] Drawing from/into float rectangles with width or height in range 0 to 1 fails
​https://bugs.webkit.org/show_bug.cgi?id=54491

Enable another passing test after fixing float values rounding.

  • platform/gtk/Skipped:

2011-02-19 Zan Dobersek <​zandobersek@gmail.com>

Reviewed by Martin Robinson.

[cairo][canvas] Drawing from/into float rectangles with width or height in range 0 to 1 fails
​https://bugs.webkit.org/show_bug.cgi?id=54491

When width or height in float rectangle are in range (0, 0.5) or (-0.5, 0)
and would round to 0, alter the behaviour to ensure that width or height are
at least 1 pixel in size in these cases.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::roundToDevicePixels):
12:12 PM Changeset in webkit [79128] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

LLVM Compiler build fix.

  • platform/graphics/ShadowBlur.cpp:

(WebCore::ShadowBlur::blurLayerImage): Eliminated a file static that generated
a global initializer since the compiler does not evaluate sqrtf at compile time.

11:05 AM Changeset in webkit [79127] by weinig@apple.com
  • 3 edits in trunk/Source/WebKit2

Rename performLookupAtCurrentMouseLocation to performDictionaryLookupAtCurrentMouseLocation

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKView.mm:

(-[WKView performDictionaryLookupAtCurrentMouseLocation]):

  • UIProcess/API/mac/WKViewPrivate.h:
10:05 AM Changeset in webkit [79126] by commit-queue@webkit.org
  • 5 edits
    1 add in trunk/Source/JavaScriptCore

2011-02-19 Siddharth Mathur <​siddharth.mathur@nokia.com>

Reviewed by Laszlo Gombos.

[Symbian] OSAllocator implementation for Symbian OS.
Manages both data and code region requests. V8 and Sunspider tested
OK with interpreter. Not tested with JSC JIT yet as it has unrelated
failures. Also no thread safety yet.
​https://bugs.webkit.org/show_bug.cgi?id=51128

  • JavaScriptCore.pri: removed HAL linkage
  • wtf/Bitmap.h: (WTF::::findRunOfZeros): find run of zeros in a bitmap. quick n dirty
  • wtf/OSAllocator.h: (WTF::OSAllocator::decommitAndRelease): decommit explicitly
  • wtf/OSAllocatorSymbian.cpp: Impl. of OSAllocator interface (WTF::allocateCodeChunk): utility for code chunks (WTF::deallocateCodeChunk): utility for code chunks (WTF::dataAllocatorInstance): getter for data allocator instance (WTF::OSAllocator::reserveUncommitted): (WTF::OSAllocator::releaseDecommitted): (WTF::OSAllocator::commit): (WTF::OSAllocator::decommit): (WTF::OSAllocator::reserveAndCommit): (WTF::PageAllocatorSymbian::PageAllocatorSymbian): maps requests to one underlying Symbian chunk (WTF::PageAllocatorSymbian::~PageAllocatorSymbian): (WTF::PageAllocatorSymbian::reserve): (WTF::PageAllocatorSymbian::release): (WTF::PageAllocatorSymbian::commit): (WTF::PageAllocatorSymbian::decommit): (WTF::PageAllocatorSymbian::contains):
  • wtf/PageAllocatorSymbian.h: Added. (WTF::SymbianChunk::SymbianChunk): wrapper around RChunk (WTF::SymbianChunk::~SymbianChunk): (WTF::SymbianChunk::contains):
8:06 AM Changeset in webkit [79125] by alex
  • 2 edits in trunk/LayoutTests

2011-02-19 Alejandro G. Castro <​alex@igalia.com>

Unreviewed, fixed typo in the GTK+ skipped file.

  • platform/gtk/Skipped:
8:06 AM Changeset in webkit [79124] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-02-19 Yong Li <​yoli@rim.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=54687
When being built with armcc, "int" bit fields are treated as
unsigned integers, which will fail the comparisons like "m_offset == -1".
Using "signed" fixes the problem.

  • assembler/ARMAssembler.h:
  • assembler/ARMv7Assembler.h:
7:56 AM Changeset in webkit [79123] by commit-queue@webkit.org
  • 8 edits in trunk/Source

2011-02-19 Brian Ryner <​bryner@chromium.org>

Reviewed by Adam Barth.

Replace the #include of DocumentLoader.h in Document.h with a
forward declaration, and add a missing #include now that this
transitive include is gone.
​https://bugs.webkit.org/show_bug.cgi?id=50489

No new tests required.

  • bindings/ScriptControllerBase.cpp:
  • dom/Document.h:

2011-02-19 Brian Ryner <​bryner@chromium.org>

Reviewed by Adam Barth.

Add missing #includes of DocumentLoader.h, needed since the transitive
include through Document.h is removed.
​https://bugs.webkit.org/show_bug.cgi?id=50489

  • src/WebPageSerializerImpl.cpp:
  • src/WebSearchableFormData.cpp:

2011-02-19 Brian Ryner <​bryner@chromium.org>

Reviewed by Adam Barth.

Add missing #include of DocumentLoader.h, needed since the transitive
include through Document.h is removed.
​https://bugs.webkit.org/show_bug.cgi?id=50489

  • WebView/WebFrame.mm:
7:53 AM Changeset in webkit [79122] by Patrick Gansterer
  • 1 edit
    1 copy in trunk/Source/WebCore

2011-02-19 Patrick Gansterer <Patrick Gansterer>

Reviewed by Antonio Gomes.

[EFL] Remove WebCore::currentTime()
​https://bugs.webkit.org/show_bug.cgi?id=53886

There is no declaration for it and we use WTF::currentTime() everywhere.

  • platform/efl/SystemTimeEfl.cpp:
7:45 AM Changeset in webkit [79121] by Patrick Gansterer
  • 2 edits
    1 move in trunk/Source/WebCore

2011-02-19 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

Move KeygenWinCE from wince into win directory
​https://bugs.webkit.org/show_bug.cgi?id=54804

Move this file into the win directory, since it can be used on all windows platforms.

  • CMakeListsWinCE.txt:
  • platform/win/SSLKeyGeneratorWin.cpp: Renamed from platform/wince/KeygenWinCE.cpp.
7:17 AM Changeset in webkit [79120] by Patrick Gansterer
  • 3 edits in trunk/Tools

2011-02-19 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

Make WinCE a core builder
​https://bugs.webkit.org/show_bug.cgi?id=54801

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
6:38 AM Changeset in webkit [79119] by Patrick Gansterer
  • 3 edits
    1 delete in trunk/Source/WebCore

2011-02-19 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

Make FileChooserWin.cpp more portable and use it on WinCE
​https://bugs.webkit.org/show_bug.cgi?id=54803

  • CMakeListsWinCE.txt:
  • platform/win/FileChooserWin.cpp: (WebCore::FileChooser::basenameForWidth):
  • platform/wince/FileChooserWinCE.cpp: Removed.
5:30 AM Changeset in webkit [79118] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-19 Benjamin Poulain <​ikipou@gmail.com>

Reviewed by Andreas Kling.

[Qt] Enable the skipped tests combining workers and database
​https://bugs.webkit.org/show_bug.cgi?id=54802

Enable the tests that do not seem to be flaky anymore.

  • platform/qt/Skipped:
2:01 AM Changeset in webkit [79117] by Lucas Forschler
  • 5 edits in branches/safari-534.20-branch/Source

Versioning again

1:49 AM Changeset in webkit [79116] by Lucas Forschler
  • 1 edit in branches/safari-534.20-branch/Source/WebKit2/ChangeLog

Versioning.

1:45 AM Changeset in webkit [79115] by Lucas Forschler
  • 6 edits in branches/safari-534.20-branch/Source

Versioning.

1:39 AM Changeset in webkit [79114] by simonjam@chromium.org
  • 13 edits in trunk

2011-02-19 James Simonsen <​simonjam@chromium.org>

Reviewed by Adam Barth.

Make ScriptElement match the HTML5 spec
​https://bugs.webkit.org/show_bug.cgi?id=54676

This implements the "prepare a script" section of the HTML5 spec in ScriptElement::prepareScript().
​http://www.whatwg.org/specs/web-apps/current-work/multipage/scripting-1.html#prepare-a-script

There are a couple of things missing from the spec that would be new functionality. These will be added later.

  • Support for async=false
  • Empty src attribute should dispatch an error.

There are a couple of slight behavioral changes to match the spec.

  • An XHTML script that is loaded then copied will not fire load on the copy.
  • If onbeforeload moves the script to a different document, then it will not try to execute again because wasAlreadyStarted is true.

The parsers were updated to use the new API, but not rewritten to look like the spec. That will be done separately.

  • fast/dom/HTMLScriptElement/move-in-beforeload.html: Original author says test was only meant to check for crashes. Beforeload is not specified by HTML5. Test was modified to assume moved script wouldn't execute because wasAlreadyStarted is set.
  • fast/dom/script-clone-rerun-src.xhtml: According to HTML5 spec, load should only fire after a script executes. Test was modified to match that. The old broken behavior was that load fired on the cloned element, even though it didn't execute.

2011-02-19 James Simonsen <​simonjam@chromium.org>

Reviewed by Adam Barth.

Make ScriptElement match the HTML5 spec
​https://bugs.webkit.org/show_bug.cgi?id=54676

This implements the "prepare a script" section of the HTML5 spec in ScriptElement::prepareScript().
​http://www.whatwg.org/specs/web-apps/current-work/multipage/scripting-1.html#prepare-a-script

There are a couple of things missing from the spec that would be new functionality. These will be added later.

  • Support for async=false
  • Empty src attribute should dispatch an error.

There are a couple of slight behavioral changes to match the spec.

  • An XHTML script that is loaded then copied will not fire load on the copy.
  • If onbeforeload moves the script to a different document, then it will not try to execute again because wasAlreadyStarted is true.

The parsers were updated to use the new API, but not rewritten to look like the spec. That will be done separately.

Test: All existing tests.

  • dom/ScriptElement.cpp: Rewritten to match HTML5 spec. (WebCore::ScriptElement::ScriptElement): (WebCore::ScriptElement::insertedIntoDocument): Logic moved to prepareScript. (WebCore::ScriptElement::childrenChanged): Logic moved to prepareScript. (WebCore::ScriptElement::handleSourceAttribute): Logic moved to prepareScript. (WebCore::isLegacySupportedJavaScriptLanguage): Added to support old script types in layout tests. (WebCore::ScriptElement::isScriptTypeSupported): Derived from old shouldExecuteAsJavaScript(). (WebCore::ScriptElement::prepareScript): START HERE. Main change. Should read exactly like HTML5's "prepare a script." Legacy type support needed for layout tests using XML parser. (WebCore::ScriptElement::requestScript): Most logic moved to prepareScript. Check security settings here. (WebCore::ScriptElement::executeScript): Combined evaluateScript() and executeScript() from old code. Logic moved to prepareScript. (WebCore::ScriptElement::stopLoadRequest): Ignore parser executed scripts. (WebCore::ScriptElement::execute): Renamed executeScript. (WebCore::ScriptElement::notifyFinished): We should only listen for non-parser executed scripts. (WebCore::ScriptElement::ignoresLoadRequest): New variable names. (WebCore::ScriptElement::childrenAreCommentsOrEmptyText): Added for HTML5 compliance. (WebCore::ScriptElement::scriptCharset): Use HTML5 variables.
  • dom/ScriptElement.h: (WebCore::ScriptElement::willBeParserExecuted): Added. (WebCore::ScriptElement::readyToBeParserExecuted): Added. (WebCore::ScriptElement::willExecuteWhenDocumentFinishedParsing): Added. (WebCore::ScriptElement::cachedScript): prepareScript() is the only place that should load scripts. This accessor lets the parsers listen for when loads finish. (WebCore::ScriptElement::isParserInserted): Added.
  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::endElementNs): Should behave the same. Offloads much of its work to prepareScript().
  • dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::parseEndElement): Identical to libxml2 changes.
  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::insertedIntoDocument): No longer needs url. (WebCore::HTMLScriptElement::hasSourceAttribute): Added.
  • html/HTMLScriptElement.h:
  • html/parser/HTMLScriptRunner.cpp: (WebCore::HTMLScriptRunner::requestPendingScript): Requesting scripts offloaded to ScriptElement. (WebCore::HTMLScriptRunner::runScript): Should behave the same. Offloads much of its work to prepareScript().
  • svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::svgAttributeChanged): New ScriptElement function names. (WebCore::SVGScriptElement::insertedIntoDocument): No longer needs url. (WebCore::SVGScriptElement::finishParsingChildren): ScriptElement::finishParsingChildren is gone. (WebCore::SVGScriptElement::hasSourceAttribute): Added. (WebCore::SVGScriptElement::dispatchLoadEvent): New ScriptElement function names.
  • svg/SVGScriptElement.h:
1:35 AM Styling Form Controls edited by tkent@chromium.org
Mention validation messages (diff)
1:17 AM Changeset in webkit [79113] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

2011-02-19 Lukasz Slachciak <​l.slachciak@samsung.com>

Unreviewed build fix.

SoupSession build break fix
​https://bugs.webkit.org/show_bug.cgi?id=54796

  • ewk/ewk_settings.cpp: (ewk_settings_proxy_uri_set):
12:58 AM Changeset in webkit [79112] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-19 Marc-Antoine Ruel <​maruel@chromium.org>

Reviewed by James Robinson.

Split webcore_rendering off webcore_remaining to reduce its size for WPO builds
​https://bugs.webkit.org/show_bug.cgi?id=54789

  • WebCore.gyp/WebCore.gyp:
12:46 AM Changeset in webkit [79111] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Updated test expectations (more fallout from r78846).

  • platform/chromium/test_expectations.txt:
12:39 AM Changeset in webkit [79110] by commit-queue@webkit.org
  • 4 edits
    1 copy in trunk/Source/WebCore

2011-02-19 Bill Budge <​bbudge@chromium.org>

Reviewed by David Levin.

ThreadableLoaderClient needs willSendRequest method
​https://bugs.webkit.org/show_bug.cgi?id=54688

No new tests. Exposes no new functionality

  • WebCore.gypi:
  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::willSendRequest): (WebCore::DocumentThreadableLoader::didReceiveData): (WebCore::DocumentThreadableLoader::didReceiveCachedMetadata):
  • loader/DocumentThreadableLoaderClient.h: Added. (WebCore::DocumentThreadableLoaderClient::isDocumentThreadableLoaderClient): (WebCore::DocumentThreadableLoaderClient::willSendRequest):
  • loader/ThreadableLoaderClient.h: (WebCore::ThreadableLoaderClient::isDocumentThreadableLoaderClient):
12:33 AM Changeset in webkit [79109] by Lucas Forschler
  • 1 copy in tags/Safari-534.20.4

New tag.

12:31 AM Changeset in webkit [79108] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

2011-02-19 Lukasz Slachciak <​l.slachciak@samsung.com>

Reviewed by Andreas Kling.

[EFL] Use standard WebCore::homeDirectoryPath method instead of reimplementing it
​https://webkit.org/b/54781

  • ewk/ewk_main.cpp: (_ewk_init_body):
12:29 AM Changeset in webkit [79107] by commit-queue@webkit.org
  • 39 edits
    3 adds in trunk

2011-02-19 Charlie Reis <​creis@chromium.org>

Reviewed by Mihai Parparita.

Ensure loading has stopped in HistoryController::goToItem
​https://bugs.webkit.org/show_bug.cgi?id=54517

Tests that going forward within the same document does not stop loading.

  • http/tests/navigation/forward-to-fragment-fires-onload.html: Added.
  • http/tests/navigation/forward-to-fragment-fires-onload-expected.txt: Added.
  • http/tests/navigation/resources/forward-to-fragment-fires-onload-2.html: Added.

2011-02-19 Charlie Reis <​creis@chromium.org>

Reviewed by Mihai Parparita.

Ensure loading has stopped in HistoryController::goToItem
​https://bugs.webkit.org/show_bug.cgi?id=54517

Avoid stopping all loaders in goToItem for same document navigations
or pseudo-back-forward URLs. Make HistoryController::goToItem private
to force callers to go through Page::goToItem. Also add a callback to
FrameLoaderClient to let clients decide whether to stop loading first.

Test: http/tests/navigation/forward-to-fragment-fires-onload.html

  • loader/EmptyClients.h:
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/HistoryController.cpp:
  • loader/HistoryController.h:
  • page/Page.cpp:

2011-02-19 Charlie Reis <​creis@chromium.org>

Reviewed by Mihai Parparita.

Ensure loading has stopped in HistoryController::goToItem
​https://bugs.webkit.org/show_bug.cgi?id=54517

Call Page::goToItem instead of HistoryController::goToItem, so that
FrameLoader::stopAllLoaders is called first. Also adds a callback in
FrameLoaderClient for checking for pseudo-back-forward URLs.

Test: http/tests/navigation/forward-to-fragment-fires-onload.html

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::shouldStopLoadingForHistoryItem): Added.
  • src/FrameLoaderClientImpl.h:
  • src/WebFrameImpl.cpp:

2011-02-19 Charlie Reis <​creis@chromium.org>

Reviewed by Mihai Parparita.

Ensure loading has stopped in HistoryController::goToItem
​https://bugs.webkit.org/show_bug.cgi?id=54517

Add a FrameLoaderClient callback for whether to stop loading before goToItem.

Test: http/tests/navigation/forward-to-fragment-fires-onload.html

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::shouldStopLoadingForHistoryItem): Added.
  • WebCoreSupport/FrameLoaderClientEfl.h:

2011-02-19 Charlie Reis <​creis@chromium.org>

Reviewed by Mihai Parparita.

Ensure loading has stopped in HistoryController::goToItem
​https://bugs.webkit.org/show_bug.cgi?id=54517

Add a FrameLoaderClient callback for whether to stop loading before goToItem.

Test: http/tests/navigation/forward-to-fragment-fires-onload.html

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClientGtk::shouldStopLoadingForHistoryItem): Added.
  • WebCoreSupport/FrameLoaderClientGtk.h:

2011-02-19 Charlie Reis <​creis@chromium.org>

Reviewed by Mihai Parparita.

Ensure loading has stopped in HistoryController::goToItem
​https://bugs.webkit.org/show_bug.cgi?id=54517

Add a FrameLoaderClient callback for whether to stop loading before goToItem.

Test: http/tests/navigation/forward-to-fragment-fires-onload.html

  • WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::shouldStopLoadingForHistoryItem): Added.
  • WebCoreSupport/FrameLoaderClientHaiku.h:

2011-02-19 Charlie Reis <​creis@chromium.org>

Reviewed by Mihai Parparita.

Ensure loading has stopped in HistoryController::goToItem
​https://bugs.webkit.org/show_bug.cgi?id=54517

Add a FrameLoaderClient callback for whether to stop loading before goToItem.

Test: http/tests/navigation/forward-to-fragment-fires-onload.html

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::shouldStopLoadingForHistoryItem): Added.
  • WebCoreSupport/WebFrameLoaderClient.h:

2011-02-19 Charlie Reis <​creis@chromium.org>

Reviewed by Mihai Parparita.

Ensure loading has stopped in HistoryController::goToItem
​https://bugs.webkit.org/show_bug.cgi?id=54517

Add a FrameLoaderClient callback for whether to stop loading before goToItem.

Test: http/tests/navigation/forward-to-fragment-fires-onload.html

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::shouldStopLoadingForHistoryItem): Added.
  • WebCoreSupport/FrameLoaderClientQt.h:

2011-02-19 Charlie Reis <​creis@chromium.org>

Reviewed by Mihai Parparita.

Ensure loading has stopped in HistoryController::goToItem
​https://bugs.webkit.org/show_bug.cgi?id=54517

Add a FrameLoaderClient callback for whether to stop loading before goToItem.

Test: http/tests/navigation/forward-to-fragment-fires-onload.html

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::shouldStopLoadingForHistoryItem): Added.
  • WebCoreSupport/WebFrameLoaderClient.h:

2011-02-19 Charlie Reis <​creis@chromium.org>

Reviewed by Mihai Parparita.

Ensure loading has stopped in HistoryController::goToItem
​https://bugs.webkit.org/show_bug.cgi?id=54517

Add a FrameLoaderClient callback for whether to stop loading before goToItem.

Test: http/tests/navigation/forward-to-fragment-fires-onload.html

  • WebCoreSupport/FrameLoaderClientWinCE.cpp: (WebKit::FrameLoaderClientWinCE::shouldStopLoadingForHistoryItem): Added.
  • WebCoreSupport/FrameLoaderClientWinCE.h:

2011-02-19 Charlie Reis <​creis@chromium.org>

Reviewed by Mihai Parparita.

Ensure loading has stopped in HistoryController::goToItem
​https://bugs.webkit.org/show_bug.cgi?id=54517

Add a FrameLoaderClient callback for whether to stop loading before goToItem.

Test: http/tests/navigation/forward-to-fragment-fires-onload.html

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::shouldStopLoadingForHistoryItem): Added.
  • WebKitSupport/FrameLoaderClientWx.h:

2011-02-19 Charlie Reis <​creis@chromium.org>

Reviewed by Mihai Parparita.

Ensure loading has stopped in HistoryController::goToItem
​https://bugs.webkit.org/show_bug.cgi?id=54517

Add a FrameLoaderClient callback for whether to stop loading before goToItem.

Test: http/tests/navigation/forward-to-fragment-fires-onload.html

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::shouldStopLoadingForHistoryItem): Added.
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
12:12 AM Changeset in webkit [79106] by abarth@webkit.org
  • 5 edits in trunk

2011-02-19 Adam Barth <​abarth@webkit.org>

Reviewed by Daniel Bates.

Fix xssAuditor/iframe-injection.html
​https://bugs.webkit.org/show_bug.cgi?id=54591

Update expected results to show that we pass.

  • http/tests/security/xssAuditor/iframe-injection-expected.txt:

2011-02-19 Adam Barth <​abarth@webkit.org>

Reviewed by Daniel Bates.

Fix xssAuditor/iframe-injection.html
​https://bugs.webkit.org/show_bug.cgi?id=54591

We should block the iframe src attribute. Although this technically
can't be used to run script, it's a pretty easy vector for stealing
passwords.

  • html/parser/XSSFilter.cpp: (WebCore::XSSFilter::filterTokenInitial): (WebCore::XSSFilter::filterIframeToken):
  • html/parser/XSSFilter.h:
12:07 AM Changeset in webkit [79105] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-02-19 Lukasz Slachciak <​l.slachciak@samsung.com>

Reviewed by Andreas Kling.

Fixed problem with launching EWebLauncher with "run-launcher --efl". Incorrect path referring to non-existing .libs directory ws set.
​https://webkit.org/b/54778

  • Scripts/webkitdirs.pm:
Note: See TracTimeline for information about the timeline view.