Timeline
Feb 21, 2011:
- 11:42 PM Changeset in webkit [79296] by
-
- 60 edits1 delete in trunk/Source/WebKit2
notImplemented() should behave identical in WebCore and WebKit2 https://bugs.webkit.org/show_bug.cgi?id=54449
Reviewed by Anders Carlsson.
Use NotImplemented.h from WebCore. Initialize logging channels.
Remove the WebKit2 concept of notImplemented().
- Platform/gtk/SharedMemoryGtk.cpp:
- Platform/gtk/WorkQueueGtk.cpp:
- Platform/qt/WorkQueueQt.cpp:
- Platform/win/WorkQueueWin.cpp:
- Shared/NotImplemented.h: Removed.
- Shared/Plugins/NPIdentifierData.cpp:
- Shared/Plugins/NPRemoteObjectMap.cpp:
- Shared/Plugins/NPVariantData.cpp:
- Shared/cairo/ShareableBitmapCairo.cpp:
- Shared/gtk/ShareableBitmapGtk.cpp:
- Shared/gtk/WebCoreArgumentCodersGtk.cpp:
- Shared/qt/WebCoreArgumentCodersQt.cpp:
- Shared/win/LayerTreeContextWin.cpp:
- UIProcess/API/qt/qwkpage.cpp:
- UIProcess/Launcher/gtk/ThreadLauncherGtk.cpp:
- UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
- UIProcess/Plugins/gtk/PluginInfoStoreGtk.cpp:
- UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
- UIProcess/WebInspectorProxy.cpp:
- UIProcess/gtk/TextCheckerGtk.cpp:
- UIProcess/gtk/WebInspectorGtk.cpp:
- UIProcess/gtk/WebPreferencesGtk.cpp:
- UIProcess/qt/TextCheckerQt.cpp:
- UIProcess/qt/WebInspectorProxyQt.cpp:
- UIProcess/win/TextCheckerWin.cpp:
- UIProcess/win/WebContextMenuProxyWin.cpp:
- WebKit2.pro:
- WebProcess/Downloads/cf/DownloadCFNet.cpp:
- WebProcess/Downloads/curl/DownloadCurl.cpp:
- WebProcess/Downloads/mac/DownloadMac.mm:
- WebProcess/Downloads/qt/DownloadQt.cpp:
- WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp:
- WebProcess/Plugins/Netscape/JSNPMethod.cpp:
- WebProcess/Plugins/Netscape/NPJSObject.cpp:
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
- WebProcess/Plugins/Netscape/gtk/NetscapePluginGtk.cpp:
- WebProcess/Plugins/Netscape/qt/NetscapePluginQt.cpp:
- WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
- WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
- WebProcess/WebCoreSupport/WebDragClient.cpp:
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
- WebProcess/WebCoreSupport/WebInspectorClient.cpp:
- WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
- WebProcess/WebCoreSupport/gtk/WebContextMenuClientGtk.cpp:
- WebProcess/WebCoreSupport/gtk/WebPopupMenuGtk.cpp:
- WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
- WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
- WebProcess/WebCoreSupport/qt/WebContextMenuClientQt.cpp:
- WebProcess/WebPage/gtk/WebInspectorGtk.cpp:
- WebProcess/WebPage/qt/WebInspectorQt.cpp:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
- WebProcess/gtk/WebProcessGtk.cpp:
- 11:21 PM Changeset in webkit [79295] by
-
- 4 edits in trunk
2011-02-21 Lukasz Slachciak <l.slachciak@samsung.com>
Reviewed by Antonio Gomes.
[EFL] Fixed missing spatial navigation setting initialization. Doxygen comments added.
https://bugs.webkit.org/show_bug.cgi?id=54806
- ewk/ewk_view.cpp: (_ewk_view_priv_new): spatial navigation setting initialization added
2011-02-21 Lukasz Slachciak <l.slachciak@samsung.com>
Reviewed by Antonio Gomes.
[EFL] Restored spatial navigation option in EWebLauncher since #18662 bug is closed
https://bugs.webkit.org/show_bug.cgi?id=54806
- EWebLauncher/main.c: (on_key_down): calling ewk_view_setting_spatial_navigation_set when "F12" pressed added.
- 11:05 PM Changeset in webkit [79294] by
-
- 5 edits in trunk/Source
2011-02-21 Nico Weber <thakis@chromium.org>
Reviewed by James Robinson.
[chromium] PopupContainer::show() confuses clang's -Woverloaded-virtual
https://bugs.webkit.org/show_bug.cgi?id=54923
Rename PopupContainer::show() to showInRect(), to make it obvious it's
not an override of ScrollView::show().
No intended functionality change.
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::showInRect): (WebCore::PopupMenuChromium::show):
- platform/chromium/PopupMenuChromium.h:
2011-02-21 Nico Weber <thakis@chromium.org>
Reviewed by James Robinson.
[chromium] PopupContainer::show() confuses clang's -Woverloaded-virtual
https://bugs.webkit.org/show_bug.cgi?id=54923
Rename PopupContainer::show() to showInRect(), to make it obvious it's
not an override of ScrollView::show().
No intended functionality change.
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::applyAutoFillSuggestions):
- 10:48 PM Changeset in webkit [79293] by
-
- 3 edits in trunk/Source/WebCore
2011-02-21 Julien Chaffraix <jchaffraix@codeaurora.org>
Reviewed by Antti Koivisto.
Improve the local{SharedStyle,CousinList} algorithm
https://bugs.webkit.org/show_bug.cgi?id=45507
This change improves the algorithm to find shared styles: the old
algorithm would stop the search after the first cousin, even if
the search threshold is not met. As such, the algorithm would
systematically miss sharings across second cousins and beyond.
The new algorithm continues the search, as long as threshold is
not met. It also separates the threshold for sibling/cousins
search, from that on the levels of search, which is easier to
optimize.
The new algorithm finds up to 30% more sharings on some sites
(e.g. amazon.com and rakuten.co.jp) with no noticeable slowdown.
No new test, refactoring only.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::locateCousinList): (WebCore::CSSStyleSelector::locateSharedStyle): While changing the algorithm, cleaned up the style of those 2 methods (use early return, renamed some variables).
- css/CSSStyleSelector.h:
- 10:46 PM Changeset in webkit [79292] by
-
- 4 edits in trunk/Source/WebCore
2011-02-21 Nico Weber <thakis@chromium.org>
Reviewed by Adam Barth.
RenderTableCell::baselinePosition() confuses clang's -Woverloaded-virtual
https://bugs.webkit.org/show_bug.cgi?id=54922
RenderTableCell::baselinePosition() has the same name as a virtual
method in superclass RenderBlock. Rename the subclass method to make
it clear it's not an attempted override.
No intended functionality change.
- rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::cellBaselinePosition):
- rendering/RenderTableCell.h:
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::calcRowLogicalHeight): (WebCore::RenderTableSection::layoutRows):
- 10:45 PM Changeset in webkit [79291] by
-
- 2 edits in trunk/LayoutTests
2011-02-21 MORITA Hajime <morrita@google.com>
Unreviewed test_expectation.txt update.
r79285 removes too much lines. recover failed one.
- platform/chromium/test_expectations.txt:
- 10:24 PM Changeset in webkit [79290] by
-
- 5 edits in trunk
2011-02-21 Benjamin Kalman <kalman@chromium.org>
Reviewed by Ryosuke Niwa.
Extending selection by a boundary granularity (LineBoundary/ParagraphBoundary/DocumentBoundary) sets incorrect
start/end of selection for RTL
https://bugs.webkit.org/show_bug.cgi?id=54724
Augment extend-left-by-lineboundary test to extend the selection twice, which triggered the bug.
- editing/selection/extend-left-right-by-lineboundary-expected.txt:
- editing/selection/extend-left-right-by-lineboundary.html:
2011-02-21 Benjamin Kalman <kalman@chromium.org>
Reviewed by Ryosuke Niwa.
Extending selection by a boundary granularity (LineBoundary/ParagraphBoundary/DocumentBoundary) sets incorrect
start/end of selection for RTL
https://bugs.webkit.org/show_bug.cgi?id=54724
On mac, the selection should always grow when extending by a boundary granularity (line/paragraph/document).
This is achieved by extending from the start for the "left" direction (e.g. pressing left arrow key), or
extending from the end when for the "right" direction (e.g. pressing right arrow key).
However, this has a bug for RTL text, which should actually extend from the *end* when extending left (since
direction is obviously reversed) and likewise extend from the start when extending right.
- editing/SelectionController.cpp: (WebCore::SelectionController::modify):
- 10:19 PM Changeset in webkit [79289] by
-
- 10 edits in trunk/LayoutTests
2011-02-21 MORITA Hajime <morrita@google.com>
Unreviewed expectation rebaseline for r79284.
- platform/chromium-linux/fast/forms/placeholder-position-expected.checksum:
- platform/chromium-linux/fast/forms/placeholder-position-expected.png:
- platform/chromium-linux/fast/forms/search-styled-expected.checksum:
- platform/chromium-linux/fast/forms/search-styled-expected.png:
- platform/chromium-win/fast/forms/placeholder-position-expected.checksum:
- platform/chromium-win/fast/forms/placeholder-position-expected.png:
- platform/chromium-win/fast/forms/placeholder-position-expected.txt:
- platform/chromium-win/fast/forms/search-styled-expected.checksum:
- platform/chromium-win/fast/forms/search-styled-expected.png:
- 10:10 PM Changeset in webkit [79288] by
-
- 3 edits in trunk/Source/WebCore
2011-02-21 Nico Weber <thakis@chromium.org>
Reviewed by Adam Barth.
ImageDocument::imageChanged() confuses clang's -Woverride-virtual
https://bugs.webkit.org/show_bug.cgi?id=54924
Rename ImageDocument::imageChanged() to imageUpdated() to make clear
that it's not an override of CachedResourceClient::imageChanged().
- html/ImageDocument.cpp: (WebCore::ImageDocumentParser::appendBytes): (WebCore::ImageDocumentParser::finish): (WebCore::ImageDocument::imageUpdated):
- html/ImageDocument.h:
- 9:58 PM Changeset in webkit [79287] by
-
- 3 edits in trunk/Source/WebCore
2011-02-21 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Kent Tamura.
Bug 54934 - Sort the WebCore project file(s)
https://bugs.webkit.org/show_bug.cgi?id=54934
No new tests. (no code affected)
- GNUmakefile.am:
- WebCore.xcodeproj/project.pbxproj:
- 9:51 PM Changeset in webkit [79286] by
-
- 5 edits in trunk/Source/WebCore
2011-02-21 Nico Weber <thakis@chromium.org>
Reviewed by Adam Barth.
canAccommodateEllipsis() confuses clang's -Woverloaded-virtual
https://bugs.webkit.org/show_bug.cgi?id=54909
Rename the overload in RootInlineBox to lineCanAccomodateEllipsis() to
unconfuse clang. No intended functionality change.
- rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::checkLinesForTextOverflow):
- rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::applyLineClamp):
- rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::lineCanAccommodateEllipsis):
- rendering/RootInlineBox.h:
- 9:14 PM Changeset in webkit [79285] by
-
- 2 edits in trunk/LayoutTests
2011-02-21 MORITA Hajime <morrita@google.com>
Unreviewed test_expectation.txt update.
Removed BUGWK54736 lines which are no longer failed.
- platform/chromium/test_expectations.txt:
- 8:56 PM Changeset in webkit [79284] by
-
- 7 edits in trunk
Source/WebCore: Fix for for https://bugs.webkit.org/show_bug.cgi?id=54402
REGRESSION (r72052): Placeholder text doesn't have the right padding for search fields on Windows
Reviewed by Dan Bernstein.
Test: updated fast/forms/placeholder-position.html and tested manually
Consider padding and margin for the results and cancel buttons. This is important for the Windows
theme which uses padding to correctly position those buttons. This change fixes the placeholder
position, and also better aligns the results popup list with the actual text you type.
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::clientPaddingLeft):
(WebCore::RenderTextControlSingleLine::clientPaddingRight):
LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=54402
REGRESSION (r72052): Placeholder text doesn't have the right padding for search fields on Windows
Reviewed by Dan Bernstein.
Unfortunately, this doesn't test the Windows theme, since DRT uses the Safari theme, but I also tested this change manually on Windows and Mac.
- fast/forms/placeholder-position.html: Added a case for a search field with the results button.
- platform/mac/fast/forms/placeholder-position-expected.checksum:
- platform/mac/fast/forms/placeholder-position-expected.png:
- platform/mac/fast/forms/placeholder-position-expected.txt:
- 7:59 PM Changeset in webkit [79283] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
2011-02-21 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
[codereviewtool] focus comment on accept
https://bugs.webkit.org/show_bug.cgi?id=54930
- code-review.js:
- 7:57 PM Changeset in webkit [79282] by
-
- 3 edits in trunk/Source/WebCore
2011-02-21 Nico Weber <thakis@chromium.org>
Reviewed by Kent Tamura.
GIFImageDecoder::setSize() tries to override the superclass method but fails
https://bugs.webkit.org/show_bug.cgi?id=54305
The superclass uses unsigned instead of int for its parameters, so
GIFImageDecoder::setSize() was an overload, not an override.
- platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::setSize):
- platform/image-decoders/gif/GIFImageDecoder.h:
- 7:44 PM Changeset in webkit [79281] by
-
- 3 edits in trunk/LayoutTests
2011-02-21 Dirk Pranke <dpranke@chromium.org>
Reviewed by Ojan Vafai.
This patch changes a test to work around a bug in PrettyPatch where
it will crash if lines starting with "--" are missing from the actual
output. The actual fix needed to PrettyPatch is described in the
bug.
- platform/mac/fast/objc/dom-html-select-activate-expected.txt:
- platform/mac/fast/objc/dom-html-select-activate.html:
- 7:38 PM Changeset in webkit [79280] by
-
- 3 edits in trunk/Websites/bugs.webkit.org
2011-02-20 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
[codereviewtool] avoid overriding ctrl/cmd + r
https://bugs.webkit.org/show_bug.cgi?id=54852
- code-review.js:
- 7:31 PM Changeset in webkit [79279] by
-
- 5 edits in trunk/Tools
2011-02-21 Dirk Pranke <dpranke@chromium.org>
Reviewed by Kent Tamura.
nrwt: revert behavior on 10.5 to "old-threads". It's possible
that r79062 has introduced a bunch of flakiness, although I
can't explain why right now. This change should restore the
old behavior, and then we can look at the build logs to see
if the tests stop timing out or being flaky.
- Scripts/webkitpy/layout_tests/port/chromium_mac.py:
- Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
- Scripts/webkitpy/layout_tests/port/mac.py:
- Scripts/webkitpy/layout_tests/port/mac_unittest.py:
- 6:28 PM Changeset in webkit [79278] by
-
- 6 edits in trunk/Source/WebCore
2011-02-21 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Deploy EditingStyle more in ApplyStyleCommand and do some cleanup
https://bugs.webkit.org/show_bug.cgi?id=54528
- editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::init): Allows style to be a null pointer. (WebCore::ApplyStyleCommand::applyInlineStyle): Overrides the value of text-decoration property by that of -webkit-text-decorations-in-effect and remove the latter property when present. This allows removeImplicitlyStyledElement to ignore -webkit-text-decorations-in-effect. Also uses the return value of EditingStyle::textDirection to determine whether or not we need to apply unicode-bidi / direction instead of directly checking the value of unicode-bidi property. (WebCore::ApplyStyleCommand::fixRangeAndApplyInlineStyle): Takes EditingStyle* instead of CSSMutableStyleDeclaration*. (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): Ditto. (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): Ditto. (WebCore::ApplyStyleCommand::removeCSSStyle): Ditto. (WebCore::ApplyStyleCommand::highestAncestorWithConflictingInlineStyle): Ditto. (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Ditto. (WebCore::ApplyStyleCommand::removeInlineStyle): Ditto; no longer collapse text decoration properties because ApplyStyleCommand::applyInlineStyle already does it.
- editing/ApplyStyleCommand.h:
- editing/EditingStyle.cpp: (WebCore::EditingStyle::textDirection): Exits early when m_mutableStyle is null. (WebCore::EditingStyle::collapseTextDecorationProperties): Extracted from ApplyStyleCommand::removeInlineStyle.
- editing/EditingStyle.h:
- 6:14 PM Changeset in webkit [79277] by
-
- 2 edits in trunk/Source/WebCore
<http://webkit.org/b/54919> / <rdar://problem/7689300> WebCore should retrieve unclamped frame delays from ImageIO
Reviewed by Darin Adler and Alexey Proskuryakov.
- platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::frameDurationAtIndex): Look for the unclamped frame delay in the
frame properties dictionary and use that if it exists. If it does not exist in the
dictionary then fall back to using the clamped frame delay.
- 6:08 PM Changeset in webkit [79276] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-02-21 Nico Weber <thakis@chromium.org>
Reviewed by Kent Tamura.
[chromium] ChromePluginPrintContext::begin() fails to override superclass method
https://bugs.webkit.org/show_bug.cgi?id=54914
Update subclass method signature to match superclass again. This
regressed in http://trac.webkit.org/changeset/71964
- src/WebFrameImpl.cpp: (WebKit::ChromePluginPrintContext::begin):
- 6:07 PM Changeset in webkit [79275] by
-
- 2 edits in trunk/LayoutTests
2011-02-21 MORITA Hajime <morrita@google.com>
Unreviewed test_expectation.txt update.
Disabled "BUGWK54322 MAC SNOWLEOPARD" lines, which sesms no longer needed.
- platform/chromium/test_expectations.txt:
- 6:01 PM Changeset in webkit [79274] by
-
- 1 edit in trunk/Source/WebKit2/UIProcess/win/WebInspectorProxyWin.cpp
Fix Windows build.
- 5:43 PM Changeset in webkit [79273] by
-
- 11 edits in trunk/Source/WebKit2
Set and update the window title for the Web Inspector in WebKit2.
https://webkit.org/b/50945
rdar://problem/8762410
Reviewed by Adam Roben.
- UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::inspectedURLChanged): Added. Call platformInspectedURLChanged.
- UIProcess/WebInspectorProxy.h:
- UIProcess/WebInspectorProxy.messages.in: Added InspectedURLChanged.
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformInspectedURLChanged): Added. Set the window title.
- UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::platformInspectedURLChanged): Added. Set the window title.
- UIProcess/gtk/WebInspectorGtk.cpp:
(WebKit::WebInspectorProxy::platformInspectedURLChanged): Added. Not implemented.
- UIProcess/qt/WebInspectorProxyQt.cpp:
(WebKit::WebInspectorProxy::platformInspectedURLChanged): Added. Not implemented.
- WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
(WebKit::WebInspectorFrontendClient::inspectedURLChanged): Call WebInspector::inspectedURLChanged.
- WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::inspectedURLChanged): Added. Send the InspectedURLChanged message.
- WebProcess/WebPage/WebInspector.h:
- 5:40 PM Changeset in webkit [79272] by
-
- 2 edits in trunk/LayoutTests
2011-02-21 MORITA Hajime <morrita@google.com>
Unreviewed test_expectation.txt clenaup.
Removed disabled lines which I commented out.
- platform/chromium/test_expectations.txt:
- 5:32 PM Changeset in webkit [79271] by
-
- 5 edits in branches/safari-534.20-branch/Source
Versioning.
- 5:28 PM Changeset in webkit [79270] by
-
- 1 copy in tags/Safari-534.20.8
New tag.
- 5:27 PM Changeset in webkit [79269] by
-
- 6 edits2 adds in trunk
2011-02-21 James Kozianski <koz@chromium.org>
Reviewed by Kent Tamura.
Causes elements to be unfocusable after tabindex property is removed.
https://bugs.webkit.org/show_bug.cgi?id=54727
- fast/html/tabindex-removal-expected.txt: Added.
- fast/html/tabindex-removal.html: Added.
2011-02-21 James Kozianski <koz@chromium.org>
Reviewed by Kent Tamura.
Causes elements to be unfocusable after tabindex property is removed.
https://bugs.webkit.org/show_bug.cgi?id=54727
Test: fast/html/tabindex-removal.html
- dom/Node.cpp: (WebCore::Node::clearTabIndexExplicitly):
- dom/Node.h:
- dom/NodeRareData.h: (WebCore::NodeRareData::clearTabIndexExplicitly):
- html/HTMLElement.cpp: (WebCore::HTMLElement::parseMappedAttribute):
- 5:23 PM Changeset in webkit [79268] by
-
- 2 edits in branches/safari-534.20-branch/Source/WebKit2
Merge r78673.
- 5:23 PM Changeset in webkit [79267] by
-
- 2 edits in trunk/Source/WebCore
Reviewed by Mark Rowe.
<rdar://problem/8995483> Remove stubs of unneeded NSURLAuthenticationChallengeSender methods
- platform/network/mac/AuthenticationMac.mm: Remove the stubs that are no longer needed.
- 5:22 PM Changeset in webkit [79266] by
-
- 2 edits in trunk/LayoutTests
2011-02-21 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed Chromium test expectations update.
Removed fast/js/kde/math.html because it has been passing since r79246.
Removed fast/text/capitalize-boundaries.html on Mac and Windows because it has been steadily passing.
- platform/chromium/test_expectations.txt:
- 5:18 PM Changeset in webkit [79265] by
-
- 2 edits in trunk/Source/WebCore
2011-02-21 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Overhang areas need to be invalidated on scroll
<rdar://problem/9032194>
https://bugs.webkit.org/show_bug.cgi?id=54917
- platform/ScrollView.cpp: (WebCore::ScrollView::scrollContents): We need to explicitly invalidate the overhang areas when we scroll the contents of a ScrollView, since they could contain arbitrary content that cannot be blitted.
- 5:06 PM Changeset in webkit [79264] by
-
- 3 edits2 copies in branches/chromium/648
Merge 78168 - 2011-02-09 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
REGRESSION(r76107): Crash in VisibleSelection::toNormalizedRange
https://bugs.webkit.org/show_bug.cgi?id=54053
The bug was caused by RenderBlock::positionForPoint's improperly returning a shadow node inside
RenderFileUploadControl for hit testing and VisibleSelection::toNormalizedRange's always assuming
the position variable "s" is not null.
Fixed the bug by always returning a null position from RenderFileUploadControl::positionForPoint,
and also exiting early when either "s" or "e" is null in VisibleSelection::toNormalizedRange.
Test: fast/forms/file-input-hit-test.html
- editing/VisibleSelection.cpp: (WebCore::VisibleSelection::toNormalizedRange):
- rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::positionForPoint):
- rendering/RenderFileUploadControl.h:
2011-02-09 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
REGRESSION(r76107): Crash in VisibleSelection::toNormalizedRange
https://bugs.webkit.org/show_bug.cgi?id=54053
Added a test to ensure WebKit does not crash when a user clicks on a region immediately after a file
upload control.
- fast/forms/file-input-hit-test-expected.txt: Added.
- fast/forms/file-input-hit-test.html: Added.
TBR=rniwa@webkit.org
Review URL: http://codereview.chromium.org/6542053
- 5:01 PM Changeset in webkit [79263] by
-
- 1 edit in trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
- 4:56 PM Changeset in webkit [79262] by
-
- 1 edit in trunk/Source/WebCore/ChangeLog
Fix the Leopard Debug build by incorporating the RenderSVGAllInOne.cpp
Reviewed by Stephanie Lewis.
No new tests required.
- WebCore.xcodeproj/project.pbxproj:
- 4:13 PM Changeset in webkit [79261] by
-
- 2 edits in trunk/Source/WebCore
Remove global initializer in CookieStorageCFNet.cpp
https://bugs.webkit.org/show_bug.cgi?id=54905
Reviewed by Darin Adler.
- platform/network/cf/CookieStorageCFNet.cpp:
(WebCore::currentCookieStorage):
(WebCore::setCurrentCookieStorage):
(WebCore::setCookieStoragePrivateBrowsingEnabled):
- 3:57 PM Changeset in webkit [79260] by
-
- 2 edits in trunk/Source/WebKit2
Can't paste from 3rd party text editor into WebKit2 window.
<rdar://problem/8978624>
Reviewed by Anders Carlsson.
- WebProcess/com.apple.WebProcess.sb:
- 3:47 PM Changeset in webkit [79259] by
-
- 2 edits in trunk/Source/WebCore
2011-02-18 Jer Noble <jer.noble@apple.com>
Reviewed by Sam Weinig.
WebKit2: Media document videos play only sound, no video (affects trailers.apple.com)
https://bugs.webkit.org/show_bug.cgi?id=54771
Now that video is accelerated, we no longer need to special case
video playing within a media document.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivateQTKit::preferredRenderingMode): (WebCore::MediaPlayerPrivateQTKit::supportsAcceleratedRendering):
- 3:42 PM Changeset in webkit [79258] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix linker warning on Windows
r79135 tried to export JSObject::s_info by adding it to JavaScriptCore.def. This is the
obvious way (since it's how we export functions), but unfortunately it doesn't work correct.
r79222 made us export it the right way (using the JS_EXPORTDATA macro), but forgot to remove
it from JavaScriptCore.def. This caused us to get linker warnings about exporting the symbol
multiple times.
Rubber-stamped by Anders Carlsson.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Removed JSObject::s_info.
- 3:34 PM Changeset in webkit [79257] by
-
- 1 edit2 adds in trunk/LayoutTests
2011-02-21 Ami Fischman <fischman@chromium.org>
Reviewed by Eric Carlson.
Add regression test for clean shutdown during video playback.
DumpRenderTree used to crash if the test was ended while a video
was still playing. (http://crbug.com/72730).
https://bugs.webkit.org/show_bug.cgi?id=54888
- media/video-plays-past-end-of-test-expected.txt: Added.
- media/video-plays-past-end-of-test.html: Added.
- 3:29 PM Changeset in webkit [79256] by
-
- 2 edits in trunk/Source/WebKit2
2011-02-21 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Initialize DrawingAreaProxy::m_size
https://bugs.webkit.org/show_bug.cgi?id=54913
This was removed in r76962 since it caused flashes when switching drawing areas due to
entering and exiting composited mode, but since we no longer switch drawing areas we can
put it back.
- UIProcess/DrawingAreaProxy.cpp: (WebKit::DrawingAreaProxy::DrawingAreaProxy):
- 3:21 PM Changeset in webkit [79255] by
-
- 2 edits in trunk/Source/WebKit2
Add some assertions about the state IDs we receive from the web process
Rubber-stamped by Anders Carlsson.
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::update):
(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
(WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode):
Assert that the state ID the web process sent us is no newer than our own state ID.
- 3:20 PM Changeset in webkit [79254] by
-
- 9 edits in trunk/Source/WebKit2
Rename DrawingArea[Proxy]Impl's "sequence number" concept to "state ID".
As explained in r79251, DrawingAreaProxyImpl has some state that, when it changes, causes
all operations performed before that state change to become invalid. Currently, this state
consists of a single piece of data: the view's size. Eventually it will encompass more data
(e.g., the backing store we're drawing into; when we start throwing away the backing store
to save memory, our state will have changed, and any operations that were intended for the
old backing store will have become invalid). r79251 effectively transformed
DrawingArea[Proxy]Impl's "sequence number," which incremented every time DrawingAreaImpl
sent DrawingAreaProxyImpl a message, to a "state ID," which only increments when the view's
size changes.
This patch is just a set of simple renames to reflect the transformation that r79251
effected. It should not introduce any changes in behavior. The renames are:
- Messages::DrawingArea::SetSize -> UpdateState
- Messages::DrawingAreaProxy::DidSetSize -> DidUpdateState
- DrawingAreaProxyImpl::m_lastDidSetSizeSequenceNumber -> m_currentStateID
- DrawingAreaProxyImpl::m_isWaitingForDidSetSize -> m_isWaitingForDidUpdateState
- DrawingAreaProxyImpl::waitForAndDispatchDidSetSize -> waitForAndDispatchDidUpdateState
- DrawingAreaImpl::m_inSetSize -> m_inUpdateState
- generateSequenceNumber -> generateStateID
- sequenceNumber -> stateID
Fixes <http://webkit.org/b/54911> DrawingArea[Proxy]Impl's "sequence number" concept should
be renamed to "state ID"
Reviewed by Anders Carlsson.
- UIProcess/DrawingAreaProxy.h:
- UIProcess/DrawingAreaProxy.messages.in:
- UIProcess/DrawingAreaProxyImpl.cpp:
- UIProcess/DrawingAreaProxyImpl.h:
- WebProcess/WebPage/DrawingArea.h:
- WebProcess/WebPage/DrawingArea.messages.in:
- WebProcess/WebPage/DrawingAreaImpl.cpp:
- WebProcess/WebPage/DrawingAreaImpl.h:
Performed the renames described above.
- 2:47 PM Changeset in webkit [79253] by
-
- 19 edits in trunk/Source
Reviewed by Adam Roben.
REGRESSION (WebKit2): HTTP requests time out after 60 seconds
https://bugs.webkit.org/show_bug.cgi?id=54755
<rdar://problem/9006592>
WebCore:
It's now possible to set a default timeout to be used at ResourceRequest creation. If one
hasn't been set, ResourceRequest will behave as before (use NSURLRequest default on Mac,
or use INT_MAX on other platforms).
- WebCore.exp.in:
- platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::defaultTimeoutInterval): Get the ResourceRequest notion of default timeout interval (may be 0 if using NSURLRequest default). (WebCore::ResourceRequestBase::setDefaultTimeoutInterval): Set the static member variable. (WebCore::ResourceRequestBase::updatePlatformRequest): Added an assertion that resource request is updated. Plaform code often calls updateResourceRequest() indirectly from this function, and that must obviously be a no-op. (WebCore::ResourceRequestBase::updateResourceRequest): Added an assertion in the opposite direction.
- platform/network/ResourceRequestBase.h: Changed "unspecifiedTimeoutInterval" to "defaultTimeoutInterval". It has been used as default by most platforms anyway. (WebCore::ResourceRequestBase::ResourceRequestBase):
- platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdatePlatformRequest): Now zero is the magic value, not INT_MAX. We'll use NSURLRequest default if neither setTimeoutInterval() nor setDefaultTimeoutInterval() has been called.
WebKit2:
- Shared/API/c/WKURLRequest.cpp: (WKURLRequestSetDefaultTimeoutInterval):
- Shared/API/c/WKURLRequest.h: Added an API to set a default timeout interval for requests created from URLs. The API affects both the UI process and requests created internally by the Web process. Requests created from NSURLRequest or CFURLRequest take timeout from those.
- Shared/WebURLRequest.cpp: (WebKit::WebURLRequest::setDefaultTimeoutInterval):
- Shared/WebURLRequest.h: Pipe the default timeout interval from WKURLRequest down to actual implementation. Since WebURLRequest is currently implemented with WebCore::ResourceRequest, it automatically respects NSURLRequest default timeout interval.
- UIProcess/WebProcessManager.cpp: (WebKit::WebProcessManager::getAllWebProcessContexts):
- UIProcess/WebProcessManager.h: Added a way to enumerate all contexts running in separate processes.
- Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::WebProcessCreationParameters): (WebKit::WebProcessCreationParameters::encode): (WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h: (WebKit::WebContext::ensureWebProcess): (WebKit::WebContext::setDefaultRequestTimeoutInterval):
- UIProcess/WebContext.h:
- WebProcess/WebProcess.cpp: (WebKit::WebProcess::initializeWebProcess): (WebKit::WebProcess::setDefaultRequestTimeoutInterval):
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in: Use UI process default timeout interval in separate process contexts, too.
- 2:26 PM Changeset in webkit [79252] by
-
- 13 edits2 adds in trunk
Source/JavaScriptCore: WebResourceCacheManager should be responsible for managing the CFURLCache as well
as the WebCore memory cache.
https://bugs.webkit.org/show_bug.cgi?id=54886
Part of <rdar://problem/8971738>
Reviewed by Adam Roben.
Add a new use flag for using the CFURLCache.
- wtf/Platform.h:
Source/WebKit2: WebResourceCacheManager should be responsible for managing the CFURLCache as well
as the WebCore memory cache.
https://bugs.webkit.org/show_bug.cgi?id=54886
Part of <rdar://problem/8971738>
Reviewed by Adam Roben.
- WebProcess/ResourceCache/WebResourceCacheManager.cpp:
(WebKit::WebResourceCacheManager::getCacheOrigins): Call through to cFURLCacheHostNames, and add
create SecurityOrigin's for them and add them to the set of SecurityOrigins with cache.
(WebKit::WebResourceCacheManager::clearCacheForOrigin): Call through to clear the CFURLCache for
the origin's hostname.
- WebProcess/ResourceCache/WebResourceCacheManager.h:
- WebProcess/ResourceCache/cf: Added.
- WebProcess/ResourceCache/cf/WebResourceCacheManagerCFNet.cpp: Added.
(WebKit::WebResourceCacheManager::cfURLCacheHostNames): Call through to WebKitSystemInterface.
(WebKit::WebResourceCacheManager::clearCFURLCacheForHostNames): Ditto.
- win/WebKit2.vcproj: Added new file.
- WebKit2.xcodeproj/project.pbxproj: Ditto.
WebKitLibraries: WebResourceCacheManager should be responsible for managing the CFURLCache as well
as the WebCore memory cache.
https://bugs.webkit.org/show_bug.cgi?id=54886
Part of <rdar://problem/8971738>
Reviewed by Adam Roben.
Update WebKitSystemInterface headers and libraries with new functions.
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- win/include/WebKitSystemInterface/WebKitSystemInterface.h:
- win/lib/WebKitSystemInterface.lib:
- 2:21 PM Changeset in webkit [79251] by
-
- 6 edits in trunk/Source/WebKit2
Move control of the sequence number from DrawingAreaImpl to DrawingAreaProxyImpl
DrawingAreaProxyImpl has some state that, when it changes, causes all operations performed
before that state change to become invalid. When painting, we need to have performed at
least one Update for the most recent state; otherwise, we'll be painting old/incorrect bits
into the view.
Currently, this state consists of a single piece of data: the view's size. Whenever the
state (i.e., size) changes, we tell the web process via the SetSize message, and the web
process lets us know that it has updated to match the new state (i.e., size) via the
DidSetSize message.
When it's time to paint, if we're waiting for the web process to update to match our current
state (i.e., size), we block for a little while hoping to receive a DidSetSize message so
that we can paint up-to-date bits into the window. This can cause us to receive messages
out-of-order; the DidSetSize message will be processed immediately, and any messages that
were sent before the DidSetSize message will be processed later. Since the messages from
before the DidSetSize message correspond to an old state (i.e., size), they are no longer
useful (e.g., they contain bits of the page that are drawn at the wrong size/location), so
we discard them.
The way we identify and discard these messages is by keeping track of a sequence number.
Currently, DrawingAreaImpl sends a monotonically-increasing sequence number to
DrawingAreaProxyImpl with every message. Whenever DrawingAreaProxyImpl receives a DidSetSize
message, it records the sequence number that came along with it. If we then later receive
any messages that have a lower sequence number, we know they correspond to an old state
(i.e., size) and can discard them.
This patch moves control of the sequence number to DrawingAreaProxyImpl.
DrawingAreaProxyImpl now sends a monotonically-increasing sequence number in the SetSize
message. DrawingAreaImpl records this sequence number when it receives the SetSize message,
and sends it back to DrawingAreaProxyImpl in every message. Otherwise the logic is the same
as before.
This should cause no changes in behavior, but will allow DrawingAreaProxyImpl to request a
full backing store update (by incrementing the sequence number) at times other than when the
view's size changes (e.g., after it has thrown away its backing store in order to save
memory).
Fixes <http://webkit.org/b/54907> DrawingAreaProxyImpl should tell DrawingAreaImpl what
sequence number to use
Reviewed by Anders Carlsson.
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::generateSequenceNumber): Moved here from DrawingAreaImpl.cpp.
(WebKit::DrawingAreaProxyImpl::sendSetSize): Changed to pass a new sequence number in the
SetSize message.
(WebKit::DrawingAreaProxyImpl::waitForAndDispatchDidSetSize): Added a FIXME about a
potential improvement.
- WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::setSize): Updated to match the message's new parameters.
- WebProcess/WebPage/DrawingArea.messages.in: Added a sequenceNumber parameter to SetSize.
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::DrawingAreaImpl): Initialize m_sequenceNumber.
(WebKit::DrawingAreaImpl::setSize): Record the new sequence number from the UI process.
(WebKit::DrawingAreaImpl::layerHostDidFlushLayers):
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
(WebKit::DrawingAreaImpl::display):
Send m_sequenceNumber, instead of a new sequence number, back to the UI process.
- WebProcess/WebPage/DrawingAreaImpl.h: Added m_sequenceNumber, updated setSize function to
match the base class.
- 2:02 PM Changeset in webkit [79250] by
-
- 2 edits in trunk/WebKitLibraries
Update WebKitSystemInterface.h on Mac. The header that was in the tree didn't
match the current WebKitSystemInterface.h.
Rubber-stamped by Dan Bernstein.
- WebKitSystemInterface.h:
- 1:35 PM Changeset in webkit [79249] by
-
- 5 edits in trunk
2011-02-21 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] editing/pasteboard/dataTransfer-setData-getData.html fails
https://bugs.webkit.org/show_bug.cgi?id=54895
Update the results for this test which now includes a few more passing
lines. We maintain separate results, because we seem to pass more tests
than other platforms.
- platform/gtk/Skipped: Unskip a test which is now passing.
- platform/gtk/editing/pasteboard/dataTransfer-setData-getData-expected.txt:
2011-02-21 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] editing/pasteboard/dataTransfer-setData-getData.html fails
https://bugs.webkit.org/show_bug.cgi?id=54895
Correct the GTK+ clipboard implementation to know that "text" is an alias
for "text/html" data. This corrects the failing test.
- platform/gtk/ClipboardGtk.cpp: (WebCore::dataObjectTypeFromHTMLClipboardType): Accept "text" as well as "Text". (WebCore::ClipboardGtk::types): Advertise "text" as well as "Text".
- 1:23 PM Changeset in webkit [79248] by
-
- 2 edits in trunk/Tools
2011-02-21 Dirk Pranke <dpranke@chromium.org>
Reviewed by Dimitri Glazkov.
nrwt: fix typo causing us to try and repeatedly shut down the servers
https://bugs.webkit.org/show_bug.cgi?id=54904
- Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
- 1:14 PM Changeset in webkit [79247] by
-
- 4 edits in trunk/Source/JavaScriptCore
2011-02-21 Xan Lopez <xlopez@igalia.com>
Reviewed by Gavin Barraclough.
Use ASSERT_JIT_OFFSET in JITPropertyAccess32_64.cpp
https://bugs.webkit.org/show_bug.cgi?id=54901
- jit/JIT.h: swap actual and expected values in message, they were reversed.
- jit/JITCall32_64.cpp: (JSC::JIT::compileOpCall): use ASSERT_JIT_OFFSET instead of a simple ASSERT.
- jit/JITPropertyAccess32_64.cpp: (JSC::JIT::emit_op_method_check): ditto. (JSC::JIT::compileGetByIdHotPath): ditto. (JSC::JIT::compileGetByIdSlowCase): ditto. (JSC::JIT::emit_op_put_by_id): ditto.
- 12:46 PM Changeset in webkit [79246] by
-
- 5 edits in trunk
Ruber stamped by Sam Weinig
Bug 54899 - Math.LOG10E should be 0.4342944819032518
This value is quoted in section 15.8.1.5 of the spec.
Source/JavaScriptCore:
- runtime/MathObject.cpp:
(JSC::MathObject::MathObject):
LayoutTests:
- fast/js/kde/math-expected.txt:
- fast/js/kde/script-tests/math.js:
- 12:30 PM Changeset in webkit [79245] by
-
- 2 edits4 adds1 delete in trunk/LayoutTests
2011-02-21 Anna Cavender <annacc@timberline.sea.corp.google.com>
Reviewed by Eric Carlson.
new baselines for video-transformed.html on mac
https://bugs.webkit.org/show_bug.cgi?id=54765
- platform/chromium-mac-leopard/media/video-transformed-expected.checksum: Added.
- platform/chromium-mac-leopard/media/video-transformed-expected.png: Renamed from LayoutTests/platform/chromium-mac/media/video-transformed-expected.png.
- platform/chromium-mac-snowleopard/media/video-transformed-expected.checksum: Added.
- platform/chromium-mac-snowleopard/media/video-transformed-expected.png: Added.
- platform/chromium-mac/media/video-transformed-expected.checksum: Removed.
- platform/chromium/test_expectations.txt:
- 11:58 AM Changeset in webkit [79244] by
-
- 3 edits in trunk/Source/WebCore
2011-02-21 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
ProcessingInstruction should provide a way to know if it is of CSS type.
https://bugs.webkit.org/show_bug.cgi?id=54868
- dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::ProcessingInstruction): (WebCore::ProcessingInstruction::checkStyleSheet): (WebCore::ProcessingInstruction::setCSSStyleSheet):
- dom/ProcessingInstruction.h: (WebCore::ProcessingInstruction::isCSS):
- 11:55 AM Changeset in webkit [79243] by
-
- 2 edits in trunk/Source/WebCore
2011-02-21 Simon Fraser <Simon Fraser>
Put JSDOMImplementationCustom.cpp where it belongs in the project.
- WebCore.xcodeproj/project.pbxproj:
- 11:49 AM Changeset in webkit [79242] by
-
- 2 edits in trunk/LayoutTests
2011-02-21 Alejandro G. Castro <alex@igalia.com>
Unreviewed, skip
editing/pasteboard/dataTransfer-setData-getData.html. Added bug:
https://bugs.webkit.org/show_bug.cgi?id=54895
- platform/gtk/Skipped:
- 11:33 AM Changeset in webkit [79241] by
-
- 542 edits1083 adds in trunk/LayoutTests
Unreviewed.
[Qt] Add Qt specific expected results for passing tables/mozilla tests.
- platform/qt/Skipped: Unskip passing tests.
- platform/qt/tables/mozilla [...] : Added.
- 11:31 AM Changeset in webkit [79240] by
-
- 35 edits in trunk/Source
Bug 54894 - Make inheritance structure described by ClassInfo match C++ class hierarchy.
Reviewed by Sam Weinig.
The ClassInfo objects describe an inheritance hierarchy, with each ClassInfo instance
containing a pointer to its parent class. These links should reflect the inheritance
hierarchy of C++ classes below JSObject. For the large part it does, but in some cases
entries in the C++ hierarchy are skipped over. This presently likely doesn't matter,
since intervening C++ classes may not have ClassInfo - but would be a potential bug
were ClassInfo were to be added.
Source/JavaScriptCore:
- API/JSCallbackConstructor.cpp:
- API/JSCallbackFunction.cpp:
- API/JSCallbackObjectFunctions.h:
- runtime/Arguments.h:
- runtime/ArrayPrototype.cpp:
- runtime/BooleanObject.cpp:
- runtime/DateInstance.cpp:
- runtime/DatePrototype.cpp:
- runtime/ErrorInstance.cpp:
- runtime/InternalFunction.cpp:
- runtime/JSActivation.cpp:
- runtime/JSArray.cpp:
- runtime/JSFunction.cpp:
- runtime/JSONObject.cpp:
- runtime/JSObject.h:
- runtime/JSZombie.h:
- runtime/MathObject.cpp:
- runtime/NativeErrorConstructor.cpp:
- runtime/NumberConstructor.cpp:
- runtime/NumberObject.cpp:
- runtime/RegExpConstructor.cpp:
- runtime/RegExpObject.cpp:
- runtime/StringObject.cpp:
- runtime/StringPrototype.cpp:
Source/WebCore:
- bindings/js/JSAudioConstructor.cpp:
- bindings/js/JSDOMGlobalObject.cpp:
- bindings/js/JSImageConstructor.cpp:
- bindings/js/JSOptionConstructor.cpp:
- bindings/scripts/CodeGeneratorJS.pm:
- bridge/objc/objc_runtime.mm:
- bridge/runtime_object.cpp:
Source/WebKit2:
- WebProcess/Plugins/Netscape/JSNPObject.cpp:
- 11:16 AM Changeset in webkit [79239] by
-
- 2 edits in trunk/LayoutTests
2011-02-21 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: skip new inspector test on wk2.
- platform/mac-wk2/Skipped:
- 11:07 AM Changeset in webkit [79238] by
-
- 1 edit in trunk/Source/WebKit2/ChangeLog
Fix radar url.
- 11:06 AM Changeset in webkit [79237] by
-
- 2 edits in trunk/Tools
2011-02-21 Alejandro G. Castro <alex@igalia.com>
Reviewed by Csaba Osztrogonác.
REGRESSION(r79157):
plugins/get-url-with-javascript-destroying-plugin.html make the
next test crash
https://bugs.webkit.org/show_bug.cgi?id=54863
- GNUmakefile.am:
- 10:45 AM Changeset in webkit [79236] by
-
- 2 edits in trunk/LayoutTests
2011-02-21 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
Skip WebKit2 tests that need EventSender
https://bugs.webkit.org/show_bug.cgi?id=54890
These tests fail because EventSender is missing.
- platform/mac-wk2/Skipped:
- 10:40 AM Changeset in webkit [79235] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
REGRESSION(r79157): plugins/get-url-with-javascript-destroying-plugin.html make the next test crash
https://bugs.webkit.org/show_bug.cgi?id=54863
Bug was fixed by http://trac.webkit.org/changeset/79231.
- platform/qt/Skipped: Unskip plugins/get-url-with-javascript-destroying-plugin.html.
- 10:29 AM Changeset in webkit [79234] by
-
- 5 edits2 adds in trunk
2011-02-21 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: navigation does not work after reopening frontend.
https://bugs.webkit.org/show_bug.cgi?id=54879
Test: http/tests/inspector-enabled/open-close-open.html
- inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::setFrontend):
- inspector/InspectorState.cpp: (WebCore::InspectorState::unmute):
- inspector/InspectorState.h:
- 10:03 AM Changeset in webkit [79233] by
-
- 2 edits18 adds in trunk/LayoutTests
2011-02-21 Martin Robinson <mrobinson@igalia.com>
Add results for tests missing results and unskip a test that
is passing locally and when run manually on the bots.
- platform/gtk/Skipped: Unskip tests that are now passing.
- platform/gtk/editing/deleting/non-smart-delete-expected.checksum: Added.
- platform/gtk/editing/deleting/non-smart-delete-expected.png: Added.
- platform/gtk/editing/deleting/non-smart-delete-expected.txt: Added.
- platform/gtk/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.checksum: Added.
- platform/gtk/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.png: Added.
- platform/gtk/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.txt: Added.
- platform/gtk/fast/runin/generated2-expected.checksum: Added.
- platform/gtk/fast/runin/generated2-expected.png: Added.
- platform/gtk/fast/runin/generated2-expected.txt: Added.
- platform/gtk/fast/runin/generated3-expected.checksum: Added.
- platform/gtk/fast/runin/generated3-expected.png: Added.
- platform/gtk/fast/runin/generated3-expected.txt: Added.
- platform/gtk/fast/runin/generated4-expected.checksum: Added.
- platform/gtk/fast/runin/generated4-expected.png: Added.
- platform/gtk/fast/runin/generated4-expected.txt: Added.
- platform/gtk/media/video-aspect-ratio-expected.checksum: Added.
- platform/gtk/media/video-aspect-ratio-expected.png: Added.
- platform/gtk/media/video-aspect-ratio-expected.txt: Added.
- 10:01 AM Changeset in webkit [79232] by
-
- 2 edits in trunk/LayoutTests
2011-02-21 Alejandro G. Castro <alex@igalia.com>
Unreviewed added more tests with pixel differences between bots.
- platform/gtk/Skipped:
- 9:48 AM Changeset in webkit [79231] by
-
- 2 edits in trunk/Source/WebCore
Protect the PluginView when evaluating javascript: URLs
Fixes <http://webkit.org/b/54884> <rdar://problem/9030864>
plugins/get-url-with-javascript-destroying-plugin.html crashing on Windows since it was
added
Reviewed by Sam Weinig.
- plugins/PluginView.cpp:
(WebCore::PluginView::performRequest): Protect the PluginView, not just its parent frame,
when evaluating javascript: URLs.
- 9:44 AM Changeset in webkit [79230] by
-
- 2 edits in trunk/Source/WebCore
2011-02-21 Martin Robinson <mrobinson@igalia.com>
Fix GTK+ build after r79223.
- GNUmakefile.am: Add file missing from the source list.
- 9:35 AM Changeset in webkit [79229] by
-
- 2 edits in trunk/Source/WebCore
2011-02-14 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: audits should not warn about gzip compression for 304s
https://bugs.webkit.org/show_bug.cgi?id=54343
Do not run compression-related audits on 304 resources.
Drive-by: handle multi-encoding resources (Content-Encoding: sdhc,gzip) correctly.
- inspector/front-end/AuditRules.js: (WebInspector.AuditRules.GzipRule.prototype.doRun): (WebInspector.AuditRules.GzipRule.prototype._isCompressed):
- 9:25 AM Changeset in webkit [79228] by
-
- 2 edits in trunk/LayoutTests
Unreviewed expectations change to mark tests as timing out.
Many tests started timing out on the chrome mac canaries around r79035
https://bugs.webkit.org/show_bug.cgi?id=54885
- platform/chromium/test_expectations.txt:
- 8:36 AM Changeset in webkit [79227] by
-
- 2 edits in trunk/LayoutTests
Unreviewed expectations change - ignore styles-update-from-js.html failures on chromium-win.
Web Inspector: inspector/styles/styles-update-from-js.html is sporadically failing on chromium win bots
https://bugs.webkit.org/show_bug.cgi?id=54882
- platform/chromium/test_expectations.txt:
- 8:36 AM Changeset in webkit [79226] by
-
- 1 edit in trunk/Source/WebCore/WebCore.pro
Another followup to 79223: correct QT project file
- 8:18 AM Changeset in webkit [79225] by
-
- 1 add in trunk/Source/WebCore/bindings/js/JSDOMImplementationCustom.cpp
Followup to 79223: forgotten file
- 8:13 AM Changeset in webkit [79224] by
-
- 2 edits in trunk/Source/WebKit2
2011-02-21 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Implement WorkQueue::sheduleWorkAfterDelay
https://bugs.webkit.org/show_bug.cgi?id=54878
- Platform/qt/WorkQueueQt.cpp: (WorkQueue::scheduleWorkAfterDelay):
- 8:01 AM Changeset in webkit [79223] by
-
- 17 edits in trunk
2011-02-08 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth and Alexey Proskuryakov.
Propagate security origin of parent document into HTML documents created with DOMImplementation
https://bugs.webkit.org/show_bug.cgi?id=53611
This restores invariant that JS wrappers residing in the same JS context should come
from the same security origin.
Absence of regressions is covered by the current tests. Different security origin of
DOMImplementation is difficult to check with layout tests as DOMImplementation
resides in the same JS context as parent document and therefore there are no security origin checks.
This is observable however in C++.
- Android.jscbindings.mk:
- CMakeLists.txt:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/v8/V8GCController.cpp: (WebCore::NodeGrouperVisitor::visitDOMWrapper):
- dom/DOMImplementation.cpp: (WebCore::DOMImplementation::DOMImplementation): (WebCore::DOMImplementation::createDocument):
- dom/DOMImplementation.h: (WebCore::DOMImplementation::create): (WebCore::DOMImplementation::documentDestroyed): (WebCore::DOMImplementation::parentDocument):
- dom/DOMImplementation.idl:
- dom/Document.cpp: (WebCore::Document::~Document): (WebCore::Document::implementation):
- dom/Document.h:
2011-02-21 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth and Alexey Proskuryakov.
Propagate security origin of parent document into HTML documents created with DOMImplementation
https://bugs.webkit.org/show_bug.cgi?id=53611
Additional test which checks case when parent document can be collected while
its implementation is alive.
- fast/dom/gc-9.html:
- 7:55 AM Changeset in webkit [79222] by
-
- 2 edits in trunk/Source/JavaScriptCore
Export JSObject::s_info from JavaScriptCore.dll
This matches what we do for all other ClassInfo objects that WebCore needs access to.
Fixes <http://webkit.org/b/54881> REGRESSION (r79132): Lots of tests crashing in
JSCell::inherits on Windows
Reviewed by Sam Weinig.
- runtime/JSObject.h: Added JS_EXPORTDATA to s_info.
- 7:03 AM Changeset in webkit [79221] by
-
- 2 edits in trunk/Source/WebCore
2011-02-21 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: [Text editor] Optimize editing updates in gutter panel
https://bugs.webkit.org/show_bug.cgi?id=54866
- inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype.set startEditingListener): (WebInspector.TextViewer.prototype.set endEditingListener): (WebInspector.TextViewer.prototype.endUpdates): (WebInspector.TextViewer.prototype._enterInternalTextChangeMode): (WebInspector.TextViewer.prototype._exitInternalTextChangeMode): (WebInspector.TextEditorChunkedPanel.prototype._chunkNumberForLine): (WebInspector.TextEditorGutterPanel.prototype._expandChunks): (WebInspector.TextEditorGutterPanel.prototype.textChanged): (WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
- 6:44 AM Changeset in webkit [79220] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Fixed the change log entry for r79219.
- 6:42 AM Changeset in webkit [79219] by
-
- 2 edits in trunk/LayoutTests
2011-02-21 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [Audits] Image dimensions in inline style not checked
https://bugs.webkit.org/show_bug.cgi?id=54738
- inspector/audits/audits-panel-functional-expected.txt:
- inspector/audits/audits-panel-functional.html:
- 6:40 AM Changeset in webkit [79218] by
-
- 5 edits in trunk
2011-02-21 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [Audits] Image dimensions in inline style not checked
https://bugs.webkit.org/show_bug.cgi?id=54738
- inspector/audits/audits-panel-functional-expected.txt:
- inspector/audits/audits-panel-functional.html:
2011-02-21 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [Audits] Image dimensions in inline style not checked
https://bugs.webkit.org/show_bug.cgi?id=54738
- inspector/front-end/AuditRules.js: (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
- 6:38 AM Changeset in webkit [79217] by
-
- 14 edits1 add in trunk/Source/WebCore
2011-02-21 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: create and destroy DOM agent along with InspectorAgent
https://bugs.webkit.org/show_bug.cgi?id=54875
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- inspector/InstrumentingAgents.h: Added. Agents that want to instrument WebCore should register themselve on this object. (WebCore::InstrumentingAgents::InstrumentingAgents): (WebCore::InstrumentingAgents::~InstrumentingAgents): (WebCore::InstrumentingAgents::inspectorBrowserDebuggerAgent): (WebCore::InstrumentingAgents::setInspectorBrowserDebuggerAgent): (WebCore::InstrumentingAgents::inspectorConsoleAgent): (WebCore::InstrumentingAgents::setInspectorConsoleAgent): (WebCore::InstrumentingAgents::inspectorDOMAgent): (WebCore::InstrumentingAgents::setInspectorDOMAgent): (WebCore::InstrumentingAgents::inspectorDOMStorageAgent): (WebCore::InstrumentingAgents::setInspectorDOMStorageAgent): (WebCore::InstrumentingAgents::inspectorDatabaseAgent): (WebCore::InstrumentingAgents::setInspectorDatabaseAgent): (WebCore::InstrumentingAgents::inspectorDebuggerAgent): (WebCore::InstrumentingAgents::setInspectorDebuggerAgent): (WebCore::InstrumentingAgents::inspectorProfilerAgent): (WebCore::InstrumentingAgents::setInspectorProfilerAgent): (WebCore::InstrumentingAgents::inspectorResourceAgent): (WebCore::InstrumentingAgents::setInspectorResourceAgent): (WebCore::InstrumentingAgents::inspectorRuntimeAgent): (WebCore::InstrumentingAgents::setInspectorRuntimeAgent): (WebCore::InstrumentingAgents::inspectorStorageAgent): (WebCore::InstrumentingAgents::setInspectorStorageAgent): (WebCore::InstrumentingAgents::inspectorTimelineAgent): (WebCore::InstrumentingAgents::setInspectorTimelineAgent):
- inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::setFrontend): (WebCore::InspectorAgent::disconnectFrontend): (WebCore::InspectorAgent::createFrontendLifetimeAgents): (WebCore::InspectorAgent::releaseFrontendLifetimeAgents): (WebCore::InspectorAgent::didCommitLoad): (WebCore::InspectorAgent::domContentLoadedEventFired): (WebCore::InspectorAgent::loadEventFired):
- inspector/InspectorAgent.h:
- inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::InspectorCSSAgent): (WebCore::InspectorCSSAgent::~InspectorCSSAgent):
- inspector/InspectorCSSAgent.h:
- inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::InspectorConsoleAgent): (WebCore::InspectorConsoleAgent::~InspectorConsoleAgent): (WebCore::InspectorConsoleAgent::clearConsoleMessages): (WebCore::InspectorConsoleAgent::clearFrontend): (WebCore::InspectorConsoleAgent::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorConsoleAgent::setMonitoringXHREnabled): (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled): (WebCore::InspectorConsoleAgent::addConsoleMessage):
- inspector/InspectorConsoleAgent.h:
- inspector/InspectorDOMAgent.cpp: DOM agent now lives even when the front-end is not attached. (WebCore::InspectorDOMAgent::InspectorDOMAgent): (WebCore::InspectorDOMAgent::setFrontend): Add DOM agent to the set of active agents when the front-end is attached. (WebCore::InspectorDOMAgent::clearFrontend):
- inspector/InspectorDOMAgent.h: (WebCore::InspectorDOMAgent::create):
- 6:33 AM Changeset in webkit [79216] by
-
- 1 edit1 delete in trunk/LayoutTests
2011-02-21 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r79029.
http://trac.webkit.org/changeset/79029
https://bugs.webkit.org/show_bug.cgi?id=54869
Revert unnecessary Chromium rebaseline (Requested by apavlov
on #webkit).
- platform/chromium-win/inspector/styles-update-from-js-expected.txt: Removed.
- 6:29 AM Changeset in webkit [79215] by
-
- 3 edits in trunk/Source/WebKit/gtk
2011-02-21 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
[GTK] [REGRESSION] After r79130, spell tests did not work
https://bugs.webkit.org/show_bug.cgi?id=54860
- WebCoreSupport/TextCheckerClientEnchant.cpp: (WebKit::TextCheckerClientEnchant::checkSpellingOfString): Avoided freeing the default PangoLanguage.
- webkit/webkitwebview.cpp: (webkit_web_view_update_settings): Initialized list of dictionaries.
- 6:16 AM Changeset in webkit [79214] by
-
- 2 edits in trunk/LayoutTests
2011-02-21 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed; Skip fast/events/menu-keydown-on-hidden-element.html on Mac WebKit 2 since it requires EventSender.
- platform/mac-wk2/Skipped:
- 6:07 AM Changeset in webkit [79213] by
-
- 2 edits in trunk/LayoutTests
2011-02-21 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed; Remove incorrect Chromium test expectations.
- platform/chromium/test_expectations.txt:
- 5:27 AM Changeset in webkit [79212] by
-
- 2 edits in trunk/LayoutTests
2011-02-21 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed; Skip fast/events/selectionchange-user-initiated.html added by r79208 on Mac WebKit 2.
- platform/mac-wk2/Skipped:
- 5:10 AM Changeset in webkit [79211] by
-
- 3 edits in trunk/Source/JavaScriptCore
2011-02-21 Kristian Amlie <kristian.amlie@nokia.com>
Reviewed by Andreas Kling.
Switched to compiler based detection, where the error actually is.
It is not the platform that needs the workaround, it is the compiler.
QtWebKit fails to compile on Windows XP with msvc-2008
https://bugs.webkit.org/show_bug.cgi?id=54746
- bytecode/CodeBlock.h:
- runtime/RegExpObject.h:
- 5:05 AM Changeset in webkit [79210] by
-
- 2 edits in trunk/Source/WebCore
[Qt][V8]REGRESSION(r79157): Fix build
https://bugs.webkit.org/show_bug.cgi?id=54871
Reviewed by Andreas Kling.
- bridge/npruntime_internal.h: Add one more undef because of evil X11 macro.
- 3:49 AM Changeset in webkit [79209] by
-
- 5 edits in trunk
2011-02-16 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Mihai Parparita.
[V8] SerializedScriptValue: fix JS exception handling.
https://bugs.webkit.org/show_bug.cgi?id=54555
Added checks for exceptions and empty handles:
- bindings/v8/SerializedScriptValue.cpp: (WebCore::Serializer::Serializer): (WebCore::Serializer::serialize): (WebCore::Serializer::checkException): (WebCore::Serializer::reportFailure): (WebCore::Serializer::ArrayState::advance): (WebCore::Serializer::AbstractObjectState::AbstractObjectState): (WebCore::Serializer::AbstractObjectState::advance): (WebCore::Serializer::push): (WebCore::Serializer::handleError): (WebCore::Serializer::newObjectState): (WebCore::Serializer::doSerialize): (WebCore::SerializedScriptValue::SerializedScriptValue):
2011-02-16 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Mihai Parparita.
[V8] SerializedScriptValue: fix JS exception handling.
https://bugs.webkit.org/show_bug.cgi?id=54555
Added an exception throwing test case:
- fast/dom/Window/window-postmessage-clone-expected.txt:
- fast/dom/Window/window-postmessage-clone.html:
- 3:24 AM Changeset in webkit [79208] by
-
- 9 edits4 adds in trunk
2011-02-21 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
Add selectionchange event
https://bugs.webkit.org/show_bug.cgi?id=45712
Added a test to ensure WebKit fires selectionchange event for the correct document
when the document has an iframe, and a test to ensure selectionchange events are fired
on user-initiated events.
- fast/events/selectionchange-iframe-expected.txt: Added.
- fast/events/selectionchange-iframe.html: Added.
- fast/events/selectionchange-user-initiated-expected.txt: Added.
- fast/events/selectionchange-user-initiated.html: Added.
2011-02-21 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
Add selectionchange event
https://bugs.webkit.org/show_bug.cgi?id=45712
Added the support for asynchronous selectionchange event, which is fired whenever selection is changed.
This event is not cancelable and does not bubble. An event listener can be attached to a document by
body element's onselectionchange attribute or via document's onselectionchange property.
Note that WebKit's implementation fires the event asynchronously whereas Internet Explorer's implementation
fires it synchronously. This implies that a script that modify selection (e.g. via selection's addRange)
will not observe the event before the control returns to JavaScript.
See also: http://msdn.microsoft.com/en-us/library/ms536968(VS.85).aspx
Tests: fast/events/selectionchange-iframe.html
fast/events/selectionchange-user-initiated.html
- dom/Document.cpp: (WebCore::Document::enqueueDocumentEvent): Added.
- dom/Document.h: Added selectionchange event listener.
- dom/Document.idl: Added onselectionchagne attribute.
- dom/EventNames.h: Added selectionchange
- editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): Fires selectionchange event.
- html/HTMLAttributeNames.in: Added onselectionchange.
- html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::parseMappedAttribute): Handles onselectionchange attribute.
- 3:20 AM Changeset in webkit [79207] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
REGRESSION(r79157): plugins/get-url-with-javascript-destroying-plugin.html make the next test crash
https://bugs.webkit.org/show_bug.cgi?id=54863
- platform/qt/Skipped: Unskip the innocent plugins/get-user-agent-with-null-npp-from-npp-new.html
and skip the real culprit plugins/get-url-with-javascript-destroying-plugin.html until fix.
- 3:16 AM Changeset in webkit [79206] by
-
- 2 edits in trunk/Source/WebCore
2011-02-21 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: protocol error messages are dumping incorrectly in Layout tests.
https://bugs.webkit.org/show_bug.cgi?id=54859
- inspector/CodeGeneratorInspector.pm:
- 3:12 AM Changeset in webkit [79205] by
-
- 18 edits in trunk/LayoutTests
2011-02-21 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [Chromium] inspector/debugger/dom-breakpoints.html TIMEOUTs
https://bugs.webkit.org/show_bug.cgi?id=54638
- http/tests/inspector/change-iframe-src.html:
- http/tests/inspector/debugger-test.js: (initialize_DebuggerTest.InspectorTest.startDebuggerTest.startTest): (initialize_DebuggerTest.InspectorTest.startDebuggerTest): (initialize_DebuggerTest.InspectorTest.completeDebuggerTest.disableDebugger): (initialize_DebuggerTest.InspectorTest.runDebuggerTestSuite.runner): (initialize_DebuggerTest.InspectorTest.runDebuggerTestSuite): (initialize_DebuggerTest.InspectorTest.waitUntilPaused): (initialize_DebuggerTest.InspectorTest.waitUntilPausedAndDumpStack.step1): (initialize_DebuggerTest.InspectorTest.waitUntilPausedAndDumpStack): (initialize_DebuggerTest.InspectorTest.waitUntilResumed): (initialize_DebuggerTest.InspectorTest.resumeExecution): (initialize_DebuggerTest.InspectorTest.showScriptSource): (initialize_DebuggerTest.InspectorTest._showScriptSource): (initialize_DebuggerTest.InspectorTest.expandProperties.expandNextPath): (initialize_DebuggerTest.InspectorTest.expandProperties):
- http/tests/inspector/elements-test.js: (initialize_ElementTest.InspectorTest.nodeWithId.processChildren): (initialize_ElementTest.InspectorTest.nodeWithId): (initialize_ElementTest.InspectorTest.selectNodeWithId.mycallback): (initialize_ElementTest.InspectorTest.selectNodeWithId): (initialize_ElementTest.InspectorTest.expandElementsTree.mycallback): (initialize_ElementTest.InspectorTest.expandElementsTree): (initialize_ElementTest):
- http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.evaluateInConsole): (initialize_InspectorTest.InspectorTest.evaluateInConsoleAndDump.mycallback): (initialize_InspectorTest.InspectorTest.evaluateInConsoleAndDump): (initialize_InspectorTest.InspectorTest.evaluateInPage.mycallback): (initialize_InspectorTest.InspectorTest.evaluateInPage): (initialize_InspectorTest.InspectorTest.evaluateInPageWithTimeout): (initialize_InspectorTest.InspectorTest.reloadPage): (initialize_InspectorTest.InspectorTest.runAfterPendingDispatches): (initialize_InspectorTest.InspectorTest.runTestSuite.runner): (initialize_InspectorTest.InspectorTest.runTestSuite): (initialize_InspectorTest.InspectorTest.safeWrap):
- http/tests/inspector/resource-parameters.html:
- inspector/console/console-assert.html:
- inspector/console/console-trace-in-eval.html:
- inspector/console/console-trace.html:
- inspector/debugger/dom-breakpoints-expected.txt:
- inspector/debugger/dom-breakpoints.html:
- inspector/extensions/extensions-audits-tests.js: (initialize_ExtensionsAuditsTest.InspectorTest.startExtensionAudits): (initialize_ExtensionsAuditsTest):
- inspector/styles/styles-iframe.html:
- inspector/styles/styles-update-from-js.html:
- inspector/timeline/timeline-network-resource.html:
- inspector/timeline/timeline-script-tag-1.html:
- inspector/timeline/timeline-script-tag-2.html:
- platform/chromium/test_expectations.txt:
- 3:03 AM Changeset in webkit [79204] by
-
- 2 edits in trunk/Source/WebCore
2011-02-21 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: generate protocol documentation based on IDL.
https://bugs.webkit.org/show_bug.cgi?id=54822
- inspector/CodeGeneratorInspector.pm:
- 2:55 AM Changeset in webkit [79203] by
-
- 2 edits in trunk/LayoutTests
2011-02-21 Alejandro G. Castro <alex@igalia.com>
Fixed typo in gtk Skipped list.
- platform/gtk/Skipped:
- 2:40 AM Changeset in webkit [79202] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
[Qt]REGRESSION(r79157): plugins/get-user-agent-with-null-npp-from-npp-new.html crashes
https://bugs.webkit.org/show_bug.cgi?id=54863
Paper over one more regression to make Qt buildbot happy and green.
- platform/qt/Skipped: Add plugins/get-user-agent-with-null-npp-from-npp-new.html until fix.
- 2:19 AM Changeset in webkit [79201] by
-
- 2 edits in trunk/LayoutTests
2011-02-18 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
[GTK] media/audio-delete-while-slider-thumb-clicked.html still flaky
https://bugs.webkit.org/show_bug.cgi?id=54747
- media/audio-delete-while-slider-thumb-clicked.html: Autoplay the media element and trigger the seek after playback started.
- 2:12 AM Changeset in webkit [79200] by
-
- 2 edits in trunk/Source/WebCore
2011-02-21 Andoni Morales Alastruey <amorales@flumotion.com>
Reviewed by Martin Robinson.
[GStreamer] Add URI queries support in webkitwebsrc
https://bugs.webkit.org/show_bug.cgi?id=54627
This allow replying to URI queries from downstream elements
with the uri currently set in the source element.
No new tests, this feature is dedicated to internal GStreamer use,
such as the upcoming HTTP Live Streaming element.
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: (webKitWebSrcQuery):
- 2:11 AM Changeset in webkit [79199] by
-
- 1 edit7 adds in trunk/LayoutTests
2011-02-21 MORITA Hajime <morrita@google.com>
Unreviewed expectation update.
- platform/chromium-linux/animations/3d/matrix-transform-type-animation-expected.checksum: Added.
- platform/chromium-linux/animations/3d/matrix-transform-type-animation-expected.png: Added.
- platform/chromium-mac/animations/3d/matrix-transform-type-animation-expected.checksum: Added.
- platform/chromium-mac/animations/3d/matrix-transform-type-animation-expected.png: Added.
- platform/chromium-win/animations/3d/matrix-transform-type-animation-expected.checksum: Added.
- platform/chromium-win/animations/3d/matrix-transform-type-animation-expected.png: Added.
- platform/chromium-win/animations/3d/matrix-transform-type-animation-expected.txt: Added.
- 1:58 AM Changeset in webkit [79198] by
-
- 2 edits3 deletes in trunk/LayoutTests
Unreviewed.
[Qt] Possible DRT bug revealed by r72003
https://bugs.webkit.org/show_bug.cgi?id=49538
After r79103 we don't need Qt specific expected results
$for these tests because of whitespace differences.
- platform/qt/fast/forms/formaction-attribute-expected.txt: Removed.
- platform/qt/fast/forms/formmethod-attribute-button-html-expected.txt: Removed.
- platform/qt/fast/forms/formtarget-attribute-button-html-expected.txt: Removed.
- platform/qt/fast/forms/mailto/formenctype-attribute-button-html-expected.txt: Updated.
- 1:33 AM Changeset in webkit [79197] by
-
- 2 edits in trunk/Source/WebCore
2011-02-21 Andoni Morales Alastruey <amorales@flumotion.com>
Reviewed by Martin Robinson.
[GStreamer] Add 'location' property in webkitwebsrc
https://bugs.webkit.org/show_bug.cgi?id=54628
No new tests, this feature is dedicated to internal GStreamer use,
such as the upcoming HTTP Live Streaming element.
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: (webkit_web_src_class_init): (webKitWebSrcSetProperty): (webKitWebSrcGetProperty):
- 1:28 AM Changeset in webkit [79196] by
-
- 55 edits in trunk/Source
2011-02-17 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
Rename Position::node() to Position::deprecatedNode()
https://bugs.webkit.org/show_bug.cgi?id=54622
Done the rename. All calls to node() are replaced by calls to deprecatedNode().
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::setComposition): Check the nullity of startContainer() instead of startPosition()->node(). (WebKit::WebViewImpl::confirmComposition): Ditto. (WebKit::WebViewImpl::textInputType): (WebKit::WebViewImpl::caretOrSelectionBounds):
2011-02-17 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
Rename Position::node() to Position::deprecatedNode()
https://bugs.webkit.org/show_bug.cgi?id=54622
Replaced the call to node() by a call to containerNode() because the returned node is
used to determine whether or not the selected contents are editable and such a check
must be done against the container node.
- WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleKeyboardEvent):
2011-02-17 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
Rename Position::node() to Position::deprecatedNode()
https://bugs.webkit.org/show_bug.cgi?id=54622
Done the rename. All calls to node() are replaced by calls to deprecatedNode().
- webkit/webkitwebview.cpp: (webkit_web_view_popup_menu_handler):
2011-02-17 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
Rename Position::node() to Position::deprecatedNode()
https://bugs.webkit.org/show_bug.cgi?id=54622
- WebView/WebFrame.mm: (-[WebFrame _smartDeleteRangeForProposedRange:]):
2011-02-17 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
Rename Position::node() to Position::deprecatedNode()
https://bugs.webkit.org/show_bug.cgi?id=54622
Replaced the call to node() by a call to containerNode() because the returned node is
used to determine whether or not the selected contents are editable and such a check
must be done against the container node.
- WebCoreSupport/EditorClientHaiku.cpp: (WebCore::EditorClientHaiku::handleKeyboardEvent):
2011-02-17 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
Rename Position::node() to Position::deprecatedNode()
https://bugs.webkit.org/show_bug.cgi?id=54622
Done the rename. All calls to node() are replaced by calls to deprecatedNode() except when
calls were of the form node()->document() and node()->inDocument() in which case they were
replaced by anchorNode()->document() and anchorNode()->inDocument() respectively.
- WebCore.exp.in: Added Position::containerNode.
The rest abbreviated for simplicity. Please see svn log.
- 1:00 AM Changeset in webkit [79195] by
-
- 2 edits in trunk/LayoutTests
2011-02-21 MORITA Hajime <morrita@google.com>
Another unreviewed attempt to expectation update.
- platform/chromium/test_expectations.txt:
- 12:16 AM Changeset in webkit [79194] by
-
- 2 edits in trunk/Source/WebKit2
2011-02-20 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] Add WebResourceCacheDataManager to the compilation after r78848
https://bugs.webkit.org/show_bug.cgi?id=54732
Added resource cache manager API to GTK+ compilation after r78848.
- GNUmakefile.am:
- 12:12 AM Changeset in webkit [79193] by
-
- 2 edits in trunk/LayoutTests
2011-02-21 MORITA Hajime <morrita@google.com>
Unreviewed expectation update. (Removes invalid lines.)
- platform/chromium/test_expectations.txt:
Feb 20, 2011:
- 11:26 PM Changeset in webkit [79192] by
-
- 2 edits in trunk/LayoutTests
2011-02-20 MORITA Hajime <morrita@google.com>
Unreviewed expectation update.
- platform/chromium/test_expectations.txt:
- 11:21 PM Changeset in webkit [79191] by
-
- 3 edits in trunk/Websites/bugs.webkit.org
2011-02-16 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
keyboard support for extending/shrinking comment context
https://bugs.webkit.org/show_bug.cgi?id=54612
ctrl+shift+up/down will extend/shrink the comment context when
a comment is focused or when one is being edited.
Also, switch over to using keydown instead of keypress events.
This lets us share code for handling escape and other key events.
Also, keypress is evil and should die.
- code-review.js:
- 11:09 PM Changeset in webkit [79190] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
2011-02-20 Ojan Vafai <ojan@chromium.org>
Recommit accidental revert.
r79180 accidentally revereted r79178.
- code-review.js:
- 11:04 PM Changeset in webkit [79189] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
2011-02-20 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
[codereviewtool] add more help information
https://bugs.webkit.org/show_bug.cgi?id=54847
- code-review.js:
- 10:53 PM Changeset in webkit [79188] by
-
- 5 edits in branches/safari-534.20-branch/Source
Versioning.
- 10:48 PM Changeset in webkit [79187] by
-
- 1 move in tags/Safari-534.20.7
Renaming tag
- 10:46 PM Changeset in webkit [79186] by
-
- 3 edits in trunk/Websites/bugs.webkit.org
2011-02-20 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
[codereviewtool] use 'r' to focus the review select element
https://bugs.webkit.org/show_bug.cgi?id=54845
This allows for quick keyboard access to the toolbar items.
Hit r to get to the review select element. Then you can
tab to the cq/preview/publish elements.
- code-review.js:
- 10:41 PM Changeset in webkit [79185] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
2011-02-20 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
[codereviewtool] don't let lines/diffblocks be mouse focusable
https://bugs.webkit.org/show_bug.cgi?id=54851
Unfortunately, this will only work once https://bugs.webkit.org/show_bug.cgi?id=54727
is committed. In the interim, it won't break anything.
- code-review.js:
- 10:40 PM Changeset in webkit [79184] by
-
- 1 copy in tags/Safari-534.20.8
New tag.
- 10:39 PM Changeset in webkit [79183] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
2011-02-20 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
[codereviewtool] use keydown instead of keypress
https://bugs.webkit.org/show_bug.cgi?id=54849
There is no functional change. This is just a cleanup
to make future patches (e.g. https://bugs.webkit.org/show_bug.cgi?id=54612)
cleaner.
- code-review.js:
- 10:37 PM Changeset in webkit [79182] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
2011-02-20 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
[codereviewtool] fix layout nit
https://bugs.webkit.org/show_bug.cgi?id=54848
There is occasionally an off-by-one in the 50% width
calculation. This ensures that the add lines always
line up with the shared context lines.
- PrettyPatch/PrettyPatch.rb:
- 9:48 PM Changeset in webkit [79181] by
-
- 3 edits in trunk/Tools
2011-02-20 Dirk Pranke <dpranke@chromium.org>
Reviewed by Ojan Vafai.
test-webkitpy: stop skipping a bunch of tests on win32
https://bugs.webkit.org/show_bug.cgi?id=54788
- Scripts/webkitpy/common/net/testoutputset_unittest.py:
- Scripts/webkitpy/test/main.py:
- 9:44 PM Changeset in webkit [79180] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
2011-02-20 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
[codereviewtool] make escape hide the preview form
https://bugs.webkit.org/show_bug.cgi?id=54844
- code-review.js:
- 9:37 PM Changeset in webkit [79179] by
-
- 5 edits in trunk/Source/WebCore
Build fix (remove includes).
- bindings/js/JSDOMBinding.cpp:
- bindings/js/JSDOMWindowCustom.cpp:
- bindings/js/JSHistoryCustom.cpp:
- bindings/js/JSLocationCustom.cpp:
- 9:37 PM Changeset in webkit [79178] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
2011-02-20 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
[codereviewtool] make enter work when an individual line is focused
https://bugs.webkit.org/show_bug.cgi?id=54843
- code-review.js:
- 9:18 PM Changeset in webkit [79177] by
-
- 51 edits5 deletes in trunk/Source
https://bugs.webkit.org/show_bug.cgi?id=54839
Remove PrototypeFunction, NativeFunctionWrapper, and GlobalEvalFunction.
Reviewed by Oliver Hunt.
Historically, Native functions used to be represented by PrototypeFunctions, however
since introducing call optimizations to the JIT this has used JSFunctions for host
calls too. At the point this change was made, the interpreter continued to use
PrototypeFunctions, however since fallback from the JIT to interpreter was introduced
the interpreter has had to be able to run using host functions represented using
JSFunctions - leading to an unnecessary and redundant divergence in behaviour between
interpreter only builds, and situations where the JIT has fallen back to interpreting.
NativeFunctionWrapper only existed to select between PrototypeFunction and JSFunction
for wrappers for host functions, and as such can also be removed.
GlobalEvalFunction is a redundant wrapper that happens to be derived from
PrototypeFunction. It existed to hold a reference to the global object - but since all
functions how derive from JSObjectWithGlobalObject, this no longer requires an
additional class to provide this functionality.
Source/JavaScriptCore:
- JavaScriptCore.JSVALUE32_64only.exp:
- JavaScriptCore.JSVALUE64only.exp:
- JavaScriptCore.xcodeproj/project.pbxproj:
Removed symbols / references to files.
- runtime/GlobalEvalFunction.cpp: Removed.
- runtime/GlobalEvalFunction.h: Removed.
- runtime/NativeFunctionWrapper.h: Removed.
- runtime/PrototypeFunction.cpp: Removed.
- runtime/PrototypeFunction.h: Removed.
Removed.
- runtime/Executable.cpp:
(JSC::NativeExecutable::~NativeExecutable):
- runtime/Executable.h:
(JSC::NativeExecutable::create):
(JSC::NativeExecutable::NativeExecutable):
(JSC::JSFunction::nativeFunction):
- runtime/JSFunction.cpp:
(JSC::callHostFunctionAsConstructor):
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::getCallData):
- runtime/JSFunction.h:
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::getHostFunction):
- runtime/JSGlobalData.h:
(JSC::JSGlobalData::getCTIStub):
Added interpreter-friendly constructors for NativeExecutables.
- bytecompiler/BytecodeGenerator.cpp:
- interpreter/Interpreter.cpp:
- jit/JITStubs.cpp:
- jsc.cpp:
- runtime/ArrayConstructor.cpp:
- runtime/BooleanPrototype.cpp:
- runtime/BooleanPrototype.h:
- runtime/CallData.h:
- runtime/DateConstructor.cpp:
- runtime/DateConstructor.h:
- runtime/ErrorPrototype.cpp:
- runtime/ErrorPrototype.h:
- runtime/FunctionPrototype.cpp:
- runtime/FunctionPrototype.h:
- runtime/JSGlobalObject.cpp:
- runtime/JSGlobalObject.h:
- runtime/JSGlobalObjectFunctions.cpp:
- runtime/Lookup.cpp:
- runtime/NumberPrototype.cpp:
- runtime/NumberPrototype.h:
- runtime/ObjectConstructor.cpp:
- runtime/ObjectConstructor.h:
- runtime/ObjectPrototype.cpp:
- runtime/ObjectPrototype.h:
- runtime/RegExpPrototype.cpp:
- runtime/RegExpPrototype.h:
- runtime/SmallStrings.h:
- runtime/StringConstructor.cpp:
- runtime/StringConstructor.h:
Removed use of redundant classes.
Source/WebCore:
- bindings/js/JSDOMBinding.cpp:
- bindings/js/JSDOMWindowCustom.cpp:
- bindings/js/JSHistoryCustom.cpp:
- bindings/js/JSLocationCustom.cpp:
Removed use of redundant classes.
- 9:07 PM Changeset in webkit [79176] by
-
- 8 edits in trunk/Tools
2011-02-20 Dirk Pranke <dpranke@chromium.org>
Reviewed by Ojan Vafai.
Fix various bugs related to handling of dir separators and real
vs. fake filesystems that were causing test-webkitpy to fail
tests on win32. These bugs have a variety of causes but are
lumped together because they should be easy to review.
- Scripts/webkitpy/common/net/testoutput.py: Here we were using os.path.sep but not escaping it prior to using in a regexp, which caused bad things on win32.
- Scripts/webkitpy/common/net/testoutput_unittest.py: Same here.
- Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Here we were using the native filesystem instead of the mock filesystem, making some tests unnecessarily platform dependent. Also we weren't setting the default configuration for the TestChromiumWinPort.
- Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py: Here we *shouldn't* use os.path.join(), just so the code becomes less platform dependent.
- Scripts/webkitpy/style/checker.py: Here we should be using os.path.sep instead of "/"; the tests require the native filesystem.
- Scripts/webkitpy/style/checkers/cpp_unittest.py: Here the underlying code is using os.path.sep, so we probably should as well.
- Scripts/webkitpy/style/test_expectations_unittest.py: Here we should be using the filesystem hanging of the port object (which is the mocked filesystem) rather than the native one.
- 8:59 PM Changeset in webkit [79175] by
-
- 2 edits in trunk/LayoutTests
2011-02-20 MORITA Hajime <morrita@google.com>
Unreviewed expectation update.
- platform/chromium/test_expectations.txt:
- 8:37 PM Changeset in webkit [79174] by
-
- 5 edits in trunk/Source/WebCore
2011-02-20 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r79169.
http://trac.webkit.org/changeset/79169
https://bugs.webkit.org/show_bug.cgi?id=54846
Made unexpected results for tests without CJK characters
(Requested by tkent on #webkit).
- platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::FontCache::createFontPlatformData):
- platform/graphics/chromium/FontPlatformDataChromiumWin.cpp: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::operator=):
- platform/graphics/chromium/FontPlatformDataChromiumWin.h: (WebCore::FontPlatformData::orientation):
- platform/graphics/skia/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData):
- 8:28 PM Changeset in webkit [79173] by
-
- 2 edits in branches/safari-534.20-branch/Source/WebKit2
Merge r79170.
- 8:20 PM Changeset in webkit [79172] by
-
- 7 edits2 copies in branches/safari-534.20-branch
Merge r79167.
- 7:58 PM Changeset in webkit [79171] by
-
- 5 edits in trunk/Source/WebKit/efl
2011-02-20 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Kent Tamura.
[EFL] Fix coding style errors in tiled BS and ewk_window_feature.h
https://bugs.webkit.org/show_bug.cgi?id=54842
Fix style errors in ewk files.
- ewk/ewk_tiled_backing_store.h:
- ewk/ewk_tiled_matrix.h:
- ewk/ewk_tiled_model.h:
- ewk/ewk_window_features.h:
- 7:43 PM Changeset in webkit [79170] by
-
- 2 edits in trunk/Source/WebKit2
Crash in WebProcess at com.apple.WebCore: WebCore::Page::goToItem + 46
<rdar://problem/8942726>
Reviewed by Dan Bernstein.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::goForward):
(WebKit::WebPage::goBack):
(WebKit::WebPage::goToBackForwardItem):
Defend agains null HistoryItems.
- 7:28 PM Changeset in webkit [79169] by
-
- 5 edits in trunk/Source/WebCore
2011-02-20 Chun-Lung Huang <alvincl.huang@gmail.com>
Reviewed by Kent Tamura.
On Chromium Windows, glyphs in vertical text tests are rotated 90
degrees clockwise. https://bugs.webkit.org/show_bug.cgi?id=51450
This platform dependent patch makes Chromium Windows show the
vertical writing text correctly. Job was done by adding a prefix '@'
in front of the font family name (Windows Only). No new tests added.
- platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::FontCache::createFontPlatformData):
- platform/graphics/chromium/FontPlatformDataChromiumWin.cpp: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::operator=):
- platform/graphics/chromium/FontPlatformDataChromiumWin.h: (WebCore::FontPlatformData::orientation):
- platform/graphics/skia/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData):
- 7:26 PM Changeset in webkit [79168] by
-
- 3 edits4 adds in trunk
2011-02-20 Simon Fraser <Simon Fraser>
Reviewed by Dirk Schulze.
REGRESSION (r73369-r73405): transform animation interpolates incorrectly
https://bugs.webkit.org/show_bug.cgi?id=54793
After the refactoring in r73380, the ending state for some types of
accelerated animations was computed incorrectly, because the TransformationMatrix
wasn't reset to identity before the ending value transformations were applied.
Fix by cleaning up the code to use explicit, separate values for
starting and ending values. Only matrix-type animations had this
issue, but cleaned up other clauses similarly.
Test: animations/3d/matrix-transform-type-animation.html
- platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::setTransformAnimationEndpoints):
- 7:06 PM Changeset in webkit [79167] by
-
- 7 edits2 adds in trunk
<rdar://problem/9028929> REGRESSION (r75897): Scaling applied twice to an iframe with a transformed ancestor
Reviewed by Maciej Stachowiak.
Source/WebCore:
Test: fast/frames/iframe-scale-applied-twice.html
- page/FrameView.cpp:
(WebCore::FrameView::create): Set the initial bounds of the view to match the
frame size.
- platform/ScrollView.cpp:
(WebCore::ScrollView::visibleContentRect): Based on bounds, not frame size.
(WebCore::ScrollView::updateScrollbars): Ditto.
(WebCore::ScrollView::setFrameRect): Moved code that really handles bounds size
change to setBoundsSize().
(WebCore::ScrollView::setBoundsSize): Added.
(WebCore::ScrollView::setInitialBoundsSize): Added. Sets the bounds size but does
not update anything.
(WebCore::ScrollView::frameRectsChanged): Based on bounds, not frame size.
(WebCore::ScrollView::scrollbarCornerPresent): Ditto.
- platform/ScrollView.h:
(WebCore::ScrollView::boundsSize): Added this getter.
- platform/Widget.h:
(WebCore::Widget::resize): Set the bounds size to the frame size.
- platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::paint): Fixed an error in the indirect drawing code
path where the buffer rect was resized to capture only the damaged part, but was
still drawn in the original location.
LayoutTests:
- fast/frames/iframe-scale-applied-twice-expected.txt: Added.
- fast/frames/iframe-scale-applied-twice.html: Added.
- 6:45 PM Changeset in webkit [79166] by
-
- 3 edits in trunk/Websites/bugs.webkit.org
2011-02-17 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
use shift+j/k to focus next/previous line
https://bugs.webkit.org/show_bug.cgi?id=54723
Tested on a large Hyatt change to confirm it performed fine.
(https://bugs.webkit.org/attachment.cgi?id=82533&action=review)
- code-review.js:
- 6:38 PM Changeset in webkit [79165] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
2011-02-17 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
fix escape handling in code review tool
https://bugs.webkit.org/show_bug.cgi?id=54722
This broke with http://trac.webkit.org/changeset/78948.
Apparently jquery events get a wrapped object that
does not expose keyIdentifier.
- code-review.js:
- 6:36 PM Changeset in webkit [79164] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
2011-02-17 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
create comments when hitting enter with a focused diff
https://bugs.webkit.org/show_bug.cgi?id=54719
- code-review.js:
- 6:29 PM Changeset in webkit [79163] by
-
- 3 edits in trunk/Websites/bugs.webkit.org
2011-02-17 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
use actual browser focus in the code review tool
https://bugs.webkit.org/show_bug.cgi?id=54726
This makes keyboard handling play better with focusable element
(i.e. links/textareas/buttons). Also, in theory, this makes
the review tool more amenable to screen readers (I think).
- PrettyPatch/PrettyPatch.rb:
- code-review.js:
- 6:24 PM Changeset in webkit [79162] by
-
- 4 edits in branches/safari-534.20-branch/Source/WebKit2
Merge 79165.
- 6:20 PM Changeset in webkit [79161] by
-
- 3 edits in trunk/LayoutTests
2011-02-20 Ami Fischman <fischman@chromium.org>
Reviewed by Kent Tamura.
Remove flakiness from media/video-poster.html by using event callbacks
instead of 100ms timeouts and hoping that states have transitioned in
time (!).
Removed seemingly-outdated BUG_DRT annotation from test_expectation.
https://bugs.webkit.org/show_bug.cgi?id=54685
http://crbug.com/60845
- media/video-poster.html:
- platform/chromium/test_expectations.txt:
- 5:35 PM Changeset in webkit [79160] by
-
- 4 edits in trunk/LayoutTests
2011-02-21 Benjamin Kalman <kalman@chromium.org>
Reviewed by Ryosuke Niwa.
Make editing/selection/extend-selection tests more human readable and hand-runnable
https://bugs.webkit.org/show_bug.cgi?id=54712
Three changes to achieve this:
- Column-align the "right:", "left:", "forward:", and "backward:" labels in the output.
- Add buttons to switch between LTR and RTL (the test will switch everything to RTL but LTR is useful).
- Fix typo causing failing tests to have a js error (rather than layout error).
Expected results need to change due to column alignment.
- editing/selection/extend-selection-character-expected.txt:
- editing/selection/extend-selection-word-expected.txt:
- editing/selection/resources/extend-selection.js: (logMismatchingPositions): (runSelectionTestsWithGranularity): (getTestNodeContainer.createButton.button.onmousedown): (getTestNodeContainer.createButton): (getTestNodeContainer.createButtonToSwitchDirection): (getTestNodeContainer): (createNode):
- 5:07 PM Changeset in webkit [79159] by
-
- 2 edits in trunk/Source/WebCore
Reviewed by Eric Seidel.
Tighten up access permissions by using libxslt API
https://bugs.webkit.org/show_bug.cgi?id=52688
<rdar://problem/8909191>
- xml/XSLTProcessorLibxslt.cpp: (WebCore::XSLTProcessor::transformToString): We are only interested in a string result, so let libxslt know about that.
- 4:35 PM Changeset in webkit [79158] by
-
- 5 edits in trunk/Source/WebCore
2011-02-20 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r79104.
http://trac.webkit.org/changeset/79104
https://bugs.webkit.org/show_bug.cgi?id=54835
Might have caused flaky canaries (Requested by tonyg-cr on
#webkit).
- html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::canTakeNextToken): (WebCore::HTMLDocumentParser::pumpTokenizer):
- html/parser/HTMLParserScheduler.cpp: (WebCore::isLayoutTimerActive):
- html/parser/HTMLParserScheduler.h: (WebCore::HTMLParserScheduler::checkForYieldBeforeToken):
- page/FrameView.h:
- 4:09 PM Changeset in webkit [79157] by
-
- 11 edits3 adds in trunk
2011-02-20 Anders Carlsson <andersca@apple.com>
Reviewed by Maciej Stachowiak.
Crash when a plug-in requests a javascript: url that destroys the plug-in
https://bugs.webkit.org/show_bug.cgi?id=54837
<rdar://problem/9005475>
Add new plug-in test.
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: (PluginTest::NPN_GetURL):
- DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
- DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURLDestroyingPlugin.cpp: Added. (GetURLWithJavaScriptURLDestroyingPlugin::GetURLWithJavaScriptURLDestroyingPlugin): (GetURLWithJavaScriptURLDestroyingPlugin::NPP_New):
- DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
- DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2011-02-20 Anders Carlsson <andersca@apple.com>
Reviewed by Maciej Stachowiak.
Crash when a plug-in requests a javascript: url that destroys the plug-in
https://bugs.webkit.org/show_bug.cgi?id=54837
<rdar://problem/9005475>
Add test.
- plugins/get-url-with-javascript-destroying-plugin-expected.txt: Added.
- plugins/get-url-with-javascript-destroying-plugin.html: Added.
2011-02-20 Anders Carlsson <andersca@apple.com>
Reviewed by Maciej Stachowiak.
Crash when a plug-in requests a javascript: url that destroys the plug-in
https://bugs.webkit.org/show_bug.cgi?id=54837
<rdar://problem/9005475>
- WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::destroy): Null out m_pluginController.
- WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::performJavaScriptURLRequest): Don't access the frame through m_pluginElement since it will be nulled out when the plug-in is destroyed.
- 3:04 PM Changeset in webkit [79156] by
-
- 4 edits in trunk/Source/WebKit2
2011-02-20 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Fix another crash when a plug-in is destroyed when evaluating JavaScript
https://bugs.webkit.org/show_bug.cgi?id=54834
<rdar://problem/9013384>
This contains three separate fixes:
- In unprotectPluginFromDestruction we can't just destroy the plug-in once the count reaches zero, because the plug-in might still have code executing on the stack. To fix this we use a zero-delay timer to defer destruction of the plug-in.
- Trying to get the NPObject for the window using NPN_GetValue would return NPERR_NO_ERROR, even if the returned NPObject was null. Fix this to return NPERR_GENERIC_ERROR instead.
- Protect the plug-in from destruction anytime an NPAPI call that sends a synchronous IPC message is made.
- PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::PluginControllerProxy): (WebKit::PluginControllerProxy::destroy): (WebKit::PluginControllerProxy::unprotectPluginFromDestruction):
- PluginProcess/PluginControllerProxy.h:
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::PluginDestructionProtector::PluginDestructionProtector): (WebKit::NPN_GetValue): (WebKit::NPN_Evaluate): (WebKit::NPN_GetProperty): (WebKit::NPN_SetProperty): (WebKit::NPN_RemoveProperty): (WebKit::NPN_HasProperty): (WebKit::NPN_HasMethod): (WebKit::NPN_Enumerate): (WebKit::NPN_Construct): (WebKit::NPN_GetValueForURL): (WebKit::NPN_SetValueForURL):
- 2:27 PM Changeset in webkit [79155] by
-
- 18 edits3 adds in trunk
2011-02-20 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG animation - analyze attribute type for animation
https://bugs.webkit.org/show_bug.cgi?id=54542
Check dynamic update of attributeName. The test fails at the moment, because of some wrong
internal mapping. Tested update manually with gdb. Working on a fix to get this test pass
as well.
- svg/animations/animate-dynamic-update-attributeName-expected.txt: Added.
- svg/animations/animate-dynamic-update-attributeName.html: Added.
- svg/animations/script-tests/animate-dynamic-update-attributeName.js: Added. (sample1): (sample2): (sample3): (executeTest):
2011-02-20 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG animation - analyze attribute type for animation
https://bugs.webkit.org/show_bug.cgi?id=54542
Analyze animated attribute type to determine the kind of animation. Removed enum PropertyType and replace it
with AnimatedAttributeType instead. More cleanup of the animation code.
Added missing fillAttributeToPropertyTypeMap() for SVGGElement.
Use QualifiedName instead of AtomicStrings for attribute names. This makes it easier to handle animated attributes
from a different namespace like xlink:href. The rest of the SVG code is using QualifiedNames as well.
No change of functionality on the animation code. The changes for the <g>-element affect animateTransform. Sadly
animateTransform is not supported by our SVG animation test script at the moment. Can still be tested manually
with the W3C test suite in trunk.
The change on SVGUseElement gets covered by animate-elem-39-t.svg
Test: svg/animations/animate-dynamic-update-attributeName.html
- svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::SVGAnimateElement): (WebCore::SVGAnimateElement::hasValidAttributeType): (WebCore::SVGAnimateElement::determineAnimatedAttributeType): (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::inheritsFromProperty): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::calculateFromAndByValues): (WebCore::SVGAnimateElement::resetToBaseValue): (WebCore::SVGAnimateElement::applyResultsToTarget): (WebCore::SVGAnimateElement::calculateDistance):
- svg/SVGAnimateElement.h:
- svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::hasValidAttributeType): (WebCore::parsePoint): (WebCore::SVGAnimateMotionElement::resetToBaseValue): (WebCore::SVGAnimateMotionElement::calculateAnimatedValue): (WebCore::SVGAnimateMotionElement::calculateDistance):
- svg/SVGAnimateMotionElement.h:
- svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::hasValidAttributeType): (WebCore::SVGAnimateTransformElement::determineAnimatedAttributeType): (WebCore::SVGAnimateTransformElement::resetToBaseValue): (WebCore::SVGAnimateTransformElement::calculateAnimatedValue): (WebCore::SVGAnimateTransformElement::calculateFromAndByValues): (WebCore::SVGAnimateTransformElement::applyResultsToTarget): (WebCore::SVGAnimateTransformElement::calculateDistance):
- svg/SVGAnimateTransformElement.h:
- svg/SVGAnimationElement.cpp: (WebCore::parseKeyTimes): (WebCore::parseKeySplines): (WebCore::SVGAnimationElement::isTargetAttributeCSSProperty): (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue): (WebCore::SVGAnimationElement::calculateKeyTimesForCalcModePaced): (WebCore::solveEpsilon): (WebCore::SVGAnimationElement::calculatePercentFromKeyPoints): (WebCore::SVGAnimationElement::currentValuesFromKeyPoints): (WebCore::SVGAnimationElement::currentValuesForValuesAnimation): (WebCore::SVGAnimationElement::startedActiveInterval):
- svg/SVGAnimationElement.h:
- svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::fillAttributeToPropertyTypeMap):
- svg/SVGGElement.cpp: (WebCore::SVGGElement::attributeToPropertyTypeMap): (WebCore::SVGGElement::fillAttributeToPropertyTypeMap): Added to fill the animated attribute map for this element.
- svg/SVGGElement.h:
- svg/SVGUseElement.cpp: (WebCore::SVGUseElement::fillAttributeToPropertyTypeMap): Changed attribute type to AnimatedString for xlink:href.
- svg/animation/SMILTimeContainer.cpp: (WebCore::SMILTimeContainer::baseValueFor): (WebCore::SMILTimeContainer::updateAnimations):
- svg/animation/SMILTimeContainer.h:
- svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::SVGSMILElement): (WebCore::constructQualifiedName): Create a QualifiedName from a attribute name. (WebCore::SVGSMILElement::insertedIntoDocument): Update local varaible of attribute name. (WebCore::SVGSMILElement::removedFromDocument): Ditto. (WebCore::SVGSMILElement::attributeChanged): Ditto.
- svg/animation/SVGSMILElement.h: (WebCore::SVGSMILElement::attributeName):
- 1:16 PM Changeset in webkit [79154] by
-
- 2 edits in trunk/Source/WebCore
BUILD FIX: Add missing UNUSED_PARAM() when !ENABLE(FULLSCREEN_API)
Not reviewed.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForFullScreen):
- 3:20 AM Changeset in webkit [79153] by
-
- 5 edits in branches/safari-534.20-branch/Source
Versioning.
- 3:14 AM Changeset in webkit [79152] by
-
- 1 copy in tags/Safari-534.20.6
New tag.
- 1:28 AM Changeset in webkit [79151] by
-
- 2 edits in trunk/Source/WebCore
2011-02-20 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Implement PlatformKeyboardEvent::getCurrentModifierState()
https://bugs.webkit.org/show_bug.cgi?id=52880
- platform/gtk/KeyEventGtk.cpp: (WebCore::PlatformKeyboardEvent::getCurrentModifierState):
- 1:22 AM Changeset in webkit [79150] by
-
- 2 edits in trunk
2011-02-20 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Bump GTK+3 dependency to 3.0
https://bugs.webkit.org/show_bug.cgi?id=54394
- configure.ac:
- 12:50 AM Changeset in webkit [79149] by
-
- 815 edits in trunk/LayoutTests/platform
Set the svn:mime-type property of some PNG files to image/png
- 12:11 AM Changeset in webkit [79148] by
-
- 5 edits in branches/safari-534.20-branch/Source
Versioning.
