Timeline
Feb 22, 2011:
- 11:49 PM Changeset in webkit [79413] by
-
- 144 edits29 adds in trunk/LayoutTests
2011-02-22 MORITA Hajime <morrita@google.com>
Unreviewed, added or updated more Leopard-specific expectations for Chromium.
- platform/chromium-mac-leopard/css1/text_properties/text_align-expected.checksum:
- platform/chromium-mac-leopard/css1/text_properties/text_align-expected.png:
- platform/chromium-mac-leopard/css2.1/t0805-c5518-brdr-t-01-e-expected.checksum:
- platform/chromium-mac-leopard/css2.1/t0805-c5518-brdr-t-01-e-expected.png:
- platform/chromium-mac-leopard/css2.1/t1202-counter-03-b-expected.checksum:
- platform/chromium-mac-leopard/css2.1/t1202-counter-03-b-expected.png:
- platform/chromium-mac-leopard/css2.1/t1202-counter-04-b-expected.checksum:
- platform/chromium-mac-leopard/css2.1/t1202-counter-04-b-expected.png:
- platform/chromium-mac-leopard/css2.1/t1202-counter-04-b-expected.txt: Added.
- platform/chromium-mac-leopard/css2.1/t1202-counters-03-b-expected.checksum:
- platform/chromium-mac-leopard/css2.1/t1202-counters-03-b-expected.png:
- platform/chromium-mac-leopard/css2.1/t1202-counters-04-b-expected.checksum:
- platform/chromium-mac-leopard/css2.1/t1202-counters-04-b-expected.png:
- platform/chromium-mac-leopard/css2.1/t1202-counters-04-b-expected.txt: Added.
- platform/chromium-mac-leopard/css2.1/t1602-c43-center-00-d-ag-expected.checksum: Added.
- platform/chromium-mac-leopard/css2.1/t1602-c43-center-00-d-ag-expected.png: Added.
- platform/chromium-mac-leopard/css2.1/t1602-c546-txt-align-00-b-expected.checksum:
- platform/chromium-mac-leopard/css2.1/t1602-c546-txt-align-00-b-expected.png: Added.
- platform/chromium-mac-leopard/editing/deleting/delete-tab-003-expected.txt: Added.
- platform/chromium-mac-leopard/editing/deleting/delete-ws-fixup-001-expected.txt: Added.
- platform/chromium-mac-leopard/editing/inserting/insert-tab-003-expected.txt: Added.
- platform/chromium-mac-leopard/editing/selection/4397952-expected.checksum:
- platform/chromium-mac-leopard/editing/selection/4397952-expected.png:
- platform/chromium-mac-leopard/editing/selection/caret-rtl-2-expected.checksum:
- platform/chromium-mac-leopard/editing/selection/caret-rtl-2-expected.png:
- platform/chromium-mac-leopard/editing/selection/caret-rtl-2-left-expected.checksum:
- platform/chromium-mac-leopard/editing/selection/caret-rtl-2-left-expected.png:
- platform/chromium-mac-leopard/editing/selection/caret-rtl-expected.checksum:
- platform/chromium-mac-leopard/editing/selection/caret-rtl-expected.png:
- platform/chromium-mac-leopard/editing/selection/caret-rtl-right-expected.checksum:
- platform/chromium-mac-leopard/editing/selection/caret-rtl-right-expected.png:
- platform/chromium-mac-leopard/editing/selection/extend-selection-bidi-expected.checksum:
- platform/chromium-mac-leopard/editing/selection/extend-selection-bidi-expected.png:
- platform/chromium-mac-leopard/editing/selection/select-from-textfield-outwards-expected.txt: Added.
- platform/chromium-mac-leopard/fast/block/margin-collapse/103-expected.checksum:
- platform/chromium-mac-leopard/fast/block/margin-collapse/103-expected.png:
- platform/chromium-mac-leopard/fast/blockflow/border-vertical-lr-expected.checksum:
- platform/chromium-mac-leopard/fast/blockflow/border-vertical-lr-expected.png:
- platform/chromium-mac-leopard/fast/blockflow/border-vertical-lr-expected.txt: Added.
- platform/chromium-mac-leopard/fast/blockflow/japanese-lr-selection-expected.checksum:
- platform/chromium-mac-leopard/fast/blockflow/japanese-lr-selection-expected.png:
- platform/chromium-mac-leopard/fast/blockflow/japanese-lr-text-expected.checksum:
- platform/chromium-mac-leopard/fast/blockflow/japanese-lr-text-expected.png:
- platform/chromium-mac-leopard/fast/blockflow/japanese-rl-selection-expected.checksum:
- platform/chromium-mac-leopard/fast/blockflow/japanese-rl-selection-expected.png:
- platform/chromium-mac-leopard/fast/blockflow/japanese-rl-text-expected.checksum: Added.
- platform/chromium-mac-leopard/fast/blockflow/japanese-rl-text-expected.png: Added.
- platform/chromium-mac-leopard/fast/blockflow/vertical-align-table-baseline-expected.checksum:
- platform/chromium-mac-leopard/fast/blockflow/vertical-align-table-baseline-expected.png:
- platform/chromium-mac-leopard/fast/blockflow/vertical-font-fallback-expected.checksum:
- platform/chromium-mac-leopard/fast/blockflow/vertical-font-fallback-expected.png:
- platform/chromium-mac-leopard/fast/css/beforeSelectorOnCodeElement-expected.checksum:
- platform/chromium-mac-leopard/fast/css/beforeSelectorOnCodeElement-expected.png:
- platform/chromium-mac-leopard/fast/css/rtl-ordering-expected.checksum:
- platform/chromium-mac-leopard/fast/css/rtl-ordering-expected.png:
- platform/chromium-mac-leopard/fast/css/text-input-with-webkit-border-radius-expected.checksum:
- platform/chromium-mac-leopard/fast/css/text-input-with-webkit-border-radius-expected.png: Added.
- platform/chromium-mac-leopard/fast/css/text-overflow-ellipsis-bidi-expected.checksum:
- platform/chromium-mac-leopard/fast/css/text-overflow-ellipsis-bidi-expected.png:
- platform/chromium-mac-leopard/fast/css/text-security-expected.checksum:
- platform/chromium-mac-leopard/fast/css/text-security-expected.png:
- platform/chromium-mac-leopard/fast/forms/basic-selects-expected.checksum:
- platform/chromium-mac-leopard/fast/forms/basic-selects-expected.png:
- platform/chromium-mac-leopard/fast/forms/basic-selects-expected.txt: Added.
- platform/chromium-mac-leopard/fast/forms/file-input-direction-expected.checksum:
- platform/chromium-mac-leopard/fast/forms/file-input-direction-expected.png:
- platform/chromium-mac-leopard/fast/forms/file-input-direction-expected.txt: Added.
- platform/chromium-mac-leopard/fast/forms/input-button-sizes-expected.checksum:
- platform/chromium-mac-leopard/fast/forms/input-button-sizes-expected.png: Added.
- platform/chromium-mac-leopard/fast/forms/input-file-re-render-expected.checksum:
- platform/chromium-mac-leopard/fast/forms/input-file-re-render-expected.png:
- platform/chromium-mac-leopard/fast/forms/menulist-option-wrap-expected.checksum:
- platform/chromium-mac-leopard/fast/forms/menulist-option-wrap-expected.png:
- platform/chromium-mac-leopard/fast/forms/menulist-restrict-line-height-expected.checksum:
- platform/chromium-mac-leopard/fast/forms/menulist-restrict-line-height-expected.png:
- platform/chromium-mac-leopard/fast/forms/menulist-style-color-expected.checksum:
- platform/chromium-mac-leopard/fast/forms/menulist-style-color-expected.png:
- platform/chromium-mac-leopard/fast/forms/placeholder-position-expected.checksum:
- platform/chromium-mac-leopard/fast/forms/placeholder-position-expected.png:
- platform/chromium-mac-leopard/fast/forms/search-transformed-expected.checksum:
- platform/chromium-mac-leopard/fast/forms/search-transformed-expected.png:
- platform/chromium-mac-leopard/fast/forms/select-baseline-expected.checksum:
- platform/chromium-mac-leopard/fast/forms/select-baseline-expected.png:
- platform/chromium-mac-leopard/fast/forms/select-visual-hebrew-expected.checksum:
- platform/chromium-mac-leopard/fast/forms/select-visual-hebrew-expected.png:
- platform/chromium-mac-leopard/fast/forms/text-style-color-expected.checksum:
- platform/chromium-mac-leopard/fast/forms/text-style-color-expected.png:
- platform/chromium-mac-leopard/fast/forms/visual-hebrew-text-field-expected.checksum:
- platform/chromium-mac-leopard/fast/forms/visual-hebrew-text-field-expected.png:
- platform/chromium-mac-leopard/fast/multicol/float-avoidance-expected.checksum:
- platform/chromium-mac-leopard/fast/multicol/float-avoidance-expected.png: Added.
- platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-clear-expected.checksum:
- platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-clear-expected.png:
- platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-repaint-expected.checksum:
- platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-repaint-expected.png:
- platform/chromium-mac-leopard/fast/repaint/repaint-across-writing-mode-boundary-expected.checksum:
- platform/chromium-mac-leopard/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
- platform/chromium-mac-leopard/fast/replaced/width100percent-textarea-expected.checksum:
- platform/chromium-mac-leopard/fast/replaced/width100percent-textarea-expected.png:
- platform/chromium-mac-leopard/fast/text/atsui-negative-spacing-features-expected.checksum:
- platform/chromium-mac-leopard/fast/text/atsui-negative-spacing-features-expected.png:
- platform/chromium-mac-leopard/fast/text/atsui-spacing-features-expected.checksum:
- platform/chromium-mac-leopard/fast/text/atsui-spacing-features-expected.png: Added.
- platform/chromium-mac-leopard/fast/text/bidi-embedding-pop-and-push-same-expected.checksum:
- platform/chromium-mac-leopard/fast/text/bidi-embedding-pop-and-push-same-expected.png:
- platform/chromium-mac-leopard/fast/text/in-rendered-text-rtl-expected.checksum:
- platform/chromium-mac-leopard/fast/text/in-rendered-text-rtl-expected.png:
- platform/chromium-mac-leopard/fast/text/international/bidi-AN-after-L-expected.checksum:
- platform/chromium-mac-leopard/fast/text/international/bidi-AN-after-L-expected.png:
- platform/chromium-mac-leopard/fast/text/international/bidi-AN-after-L-expected.txt: Added.
- platform/chromium-mac-leopard/fast/text/international/bidi-L2-run-reordering-expected.checksum:
- platform/chromium-mac-leopard/fast/text/international/bidi-L2-run-reordering-expected.png:
- platform/chromium-mac-leopard/fast/text/international/bidi-LDB-2-CSS-expected.checksum:
- platform/chromium-mac-leopard/fast/text/international/bidi-LDB-2-CSS-expected.png:
- platform/chromium-mac-leopard/fast/text/international/bidi-LDB-2-HTML-expected.checksum:
- platform/chromium-mac-leopard/fast/text/international/bidi-LDB-2-HTML-expected.png:
- platform/chromium-mac-leopard/fast/text/international/bidi-LDB-2-formatting-characters-expected.checksum:
- platform/chromium-mac-leopard/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
- platform/chromium-mac-leopard/fast/text/international/bidi-european-terminators-expected.checksum:
- platform/chromium-mac-leopard/fast/text/international/bidi-european-terminators-expected.png:
- platform/chromium-mac-leopard/fast/text/international/bidi-ignored-for-first-child-inline-expected.checksum:
- platform/chromium-mac-leopard/fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
- platform/chromium-mac-leopard/fast/text/international/bidi-innertext-expected.checksum:
- platform/chromium-mac-leopard/fast/text/international/bidi-innertext-expected.png:
- platform/chromium-mac-leopard/fast/text/international/bidi-layout-across-linebreak-expected.checksum: Added.
- platform/chromium-mac-leopard/fast/text/international/bidi-layout-across-linebreak-expected.png: Added.
- platform/chromium-mac-leopard/fast/text/international/bidi-linebreak-001-expected.checksum:
- platform/chromium-mac-leopard/fast/text/international/bidi-linebreak-001-expected.png:
- platform/chromium-mac-leopard/fast/text/international/bidi-linebreak-002-expected.checksum:
- platform/chromium-mac-leopard/fast/text/international/bidi-linebreak-002-expected.png:
- platform/chromium-mac-leopard/fast/text/international/bidi-linebreak-003-expected.checksum:
- platform/chromium-mac-leopard/fast/text/international/bidi-linebreak-003-expected.png:
- platform/chromium-mac-leopard/fast/text/international/bidi-listbox-atsui-expected.checksum:
- platform/chromium-mac-leopard/fast/text/international/bidi-listbox-atsui-expected.png:
- platform/chromium-mac-leopard/fast/text/international/bidi-listbox-expected.checksum:
- platform/chromium-mac-leopard/fast/text/international/bidi-listbox-expected.png:
- platform/chromium-mac-leopard/fast/text/international/bidi-mirror-he-ar-expected.checksum:
- platform/chromium-mac-leopard/fast/text/international/bidi-mirror-he-ar-expected.png:
- platform/chromium-mac-leopard/fast/text/international/bidi-mirror-he-ar-expected.txt:
- platform/chromium-mac-leopard/fast/text/international/bidi-neutral-run-expected.checksum: Added.
- platform/chromium-mac-leopard/fast/text/international/bidi-neutral-run-expected.png: Added.
- platform/chromium-mac-leopard/fast/text/international/bidi-neutral-run-expected.txt:
- platform/chromium-mac-leopard/fast/text/international/bidi-override-expected.checksum:
- platform/chromium-mac-leopard/fast/text/international/bidi-override-expected.png:
- platform/chromium-mac-leopard/fast/text/international/hebrew-vowels-expected.checksum:
- platform/chromium-mac-leopard/fast/text/international/hebrew-vowels-expected.png:
- platform/chromium-mac-leopard/fast/text/international/hindi-spacing-expected.checksum:
- platform/chromium-mac-leopard/fast/text/international/hindi-spacing-expected.png:
- platform/chromium-mac-leopard/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum: Added.
- platform/chromium-mac-leopard/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Added.
- platform/chromium-mac-leopard/fast/text/international/rtl-caret-expected.checksum:
- platform/chromium-mac-leopard/fast/text/international/rtl-caret-expected.png:
- platform/chromium-mac-leopard/fast/text/international/rtl-white-space-pre-wrap-expected.checksum: Added.
- platform/chromium-mac-leopard/fast/text/international/rtl-white-space-pre-wrap-expected.png: Added.
- platform/chromium-mac-leopard/fast/text/justified-selection-at-edge-expected.checksum:
- platform/chromium-mac-leopard/fast/text/justified-selection-at-edge-expected.png: Added.
- platform/chromium-mac-leopard/svg/custom/inline-svg-in-xhtml-expected.checksum:
- platform/chromium-mac-leopard/svg/custom/inline-svg-in-xhtml-expected.png:
- platform/chromium-mac-leopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.checksum:
- platform/chromium-mac-leopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/chromium-mac-leopard/svg/zoom/page/zoom-hixie-mixed-008-expected.checksum: Added.
- platform/chromium-mac-leopard/tables/mozilla/marvin/x_tbody_align_justify-expected.checksum:
- platform/chromium-mac-leopard/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/marvin/x_td_align_justify-expected.checksum:
- platform/chromium-mac-leopard/tables/mozilla/marvin/x_td_align_justify-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/marvin/x_tfoot_align_justify-expected.checksum:
- platform/chromium-mac-leopard/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/marvin/x_th_align_justify-expected.checksum:
- platform/chromium-mac-leopard/tables/mozilla/marvin/x_th_align_justify-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/marvin/x_tr_align_justify-expected.checksum:
- platform/chromium-mac-leopard/tables/mozilla/marvin/x_tr_align_justify-expected.png:
- platform/chromium/test_expectations.txt:
- 11:13 PM Changeset in webkit [79412] by
-
- 2 edits in trunk/Source/WebKit/qt
2011-02-22 Fabrizio Machado <fabrizio.machado@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Don't fall through case in variantToSetting() if qvariant.type() is Bool
https://bugs.webkit.org/show_bug.cgi?id=54976
Test not needed.
- WebCoreSupport/InspectorClientQt.cpp:
- 11:06 PM Changeset in webkit [79411] by
-
- 2 edits1 add in trunk/Source/WebCore
2011-02-22 Jia Pu <jpu@apple.com>
Reviewed by Dan Bernstein.
On Mac OS X, English contractions are marked misspelled with certain user preference setting.
https://bugs.webkit.org/show_bug.cgi?id=54975
manual test: manual-tests/autocorrection/spellcheck-on-contraction-when-autocorrection-is-off.html
Without this patch, we check for contraction only when autocorrection or other type of auto-
substituation is on. And we failed to check for contraction if only spellchecking is turned on.
This patch implements the desired behavior, checking for contraction when either correction/substitution,
or spellchecking, is on.
- editing/Editor.cpp: (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
- manual-tests/autocorrection/spellcheck-on-contraction-when-autocorrection-is-off.html: Added.
- 10:58 PM Changeset in webkit [79410] by
-
- 8 edits in trunk/Source/WebCore
2011-02-22 Charlie Reis <creis@chromium.org>
Reviewed by Darin Fisher.
Remove DatabasePolicy from FrameLoaderTypes
https://bugs.webkit.org/show_bug.cgi?id=54968
The DatabasePolicy enum is no longer needed now that we avoid stopping
loaders on same-document navigations.
Existing test: storage/hash-change-with-xhr.html
- WebCore.exp.in:
- loader/DocumentLoader.cpp:
- loader/DocumentLoader.h:
- loader/FrameLoader.cpp:
- loader/FrameLoader.h:
- loader/FrameLoaderTypes.h:
- workers/WorkerThread.cpp:
- 10:54 PM Changeset in webkit [79409] by
-
- 4 edits in trunk/Source
2011-02-22 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Andreas Kling.
[Qt] QWebView ignores a palette set with QWebView::setPalette()
https://bugs.webkit.org/show_bug.cgi?id=31742
Use custom QWebView palette if the view provides one.
Modified version of a patch made by Fabrizio Machado.
- platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeQt::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeQt::platformActiveSelectionForegroundColor): (WebCore::RenderThemeQt::platformInactiveSelectionForegroundColor): (WebCore::RenderThemeQt::platformFocusRingColor):
2011-02-22 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Andreas Kling.
[Qt] QWebView ignores a palette set with QWebView::setPalette()
https://bugs.webkit.org/show_bug.cgi?id=31742
Test case to check that the palette sets on the QWebView is taken
into account.
- tests/qwebview/tst_qwebview.cpp: (tst_QWebView::setPalette_data): (tst_QWebView::setPalette):
- 10:48 PM Changeset in webkit [79408] by
-
- 2 edits in trunk/Source/WebCore
2011-02-22 Brian Salomon <bsalomon@google.com>
Reviewed by Kenneth Russell.
Don't disable accelerated canvas when using the skia gpu backend.
No new tests are required.
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setGlobalCompositeOperation):
- 10:41 PM Changeset in webkit [79407] by
-
- 2 edits in trunk/Source/WebCore
2011-02-22 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] <select>s on http://www.ryanair.com render wrong
https://bugs.webkit.org/show_bug.cgi?id=29647
Reducing padding in <select> elements to improve its rendering and introducing a
rendering adjustment specific to QMacStyle.
- platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::setPopupPadding): (WebCore::RenderThemeQt::paintMenuList):
- 10:38 PM Changeset in webkit [79406] by
-
- 2 edits in trunk/LayoutTests
2011-02-22 MORITA Hajime <morrita@google.com>
Unreviewed test_expectations.txt update.
- platform/chromium/test_expectations.txt:
- 10:04 PM Changeset in webkit [79405] by
-
- 2 edits102 adds in trunk/LayoutTests
2011-02-22 MORITA Hajime <morrita@google.com>
Unreviewed, added Leopard-specific expectations for Chromium.
- platform/chromium-mac-leopard/css1/box_properties/clear_float-expected.checksum: Added.
- platform/chromium-mac-leopard/css1/box_properties/clear_float-expected.png: Added.
- platform/chromium-mac-leopard/css1/box_properties/float_elements_in_series-expected.checksum: Added.
- platform/chromium-mac-leopard/css1/box_properties/float_elements_in_series-expected.png: Added.
- platform/chromium-mac-leopard/css1/box_properties/float_on_text_elements-expected.checksum: Added.
- platform/chromium-mac-leopard/css1/box_properties/float_on_text_elements-expected.png: Added.
- platform/chromium-mac-leopard/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum: Added.
- platform/chromium-mac-leopard/css2.1/t0905-c5525-fltcont-00-d-g-expected.png: Added.
- platform/chromium-mac-leopard/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum: Added.
- platform/chromium-mac-leopard/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png: Added.
- platform/chromium-mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.checksum: Added.
- platform/chromium-mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.png: Added.
- platform/chromium-mac-leopard/fast/css/font-face-default-font-expected.checksum: Added.
- platform/chromium-mac-leopard/fast/css/font-face-default-font-expected.png: Added.
- platform/chromium-mac-leopard/fast/dom/52776-expected.txt: Added.
- platform/chromium-mac-leopard/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.checksum: Added.
- platform/chromium-mac-leopard/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png: Added.
- platform/chromium-mac-leopard/fast/dynamic/008-expected.checksum: Added.
- platform/chromium-mac-leopard/fast/dynamic/008-expected.png: Added.
- platform/chromium-mac-leopard/fast/events/context-no-deselect-expected.checksum: Added.
- platform/chromium-mac-leopard/fast/events/context-no-deselect-expected.png: Added.
- platform/chromium-mac-leopard/fast/forms/basic-buttons-expected.checksum: Added.
- platform/chromium-mac-leopard/fast/forms/basic-buttons-expected.png: Added.
- platform/chromium-mac-leopard/fast/forms/button-sizes-expected.checksum: Added.
- platform/chromium-mac-leopard/fast/forms/button-sizes-expected.png: Added.
- platform/chromium-mac-leopard/fast/forms/input-appearance-bkcolor-expected.checksum: Added.
- platform/chromium-mac-leopard/fast/forms/input-appearance-bkcolor-expected.png: Added.
- platform/chromium-mac-leopard/fast/html/keygen-expected.checksum: Added.
- platform/chromium-mac-leopard/fast/html/keygen-expected.png: Added.
- platform/chromium-mac-leopard/fast/inline/inline-box-background-expected.checksum: Added.
- platform/chromium-mac-leopard/fast/inline/inline-box-background-expected.png: Added.
- platform/chromium-mac-leopard/fast/inline/inline-box-background-long-image-expected.checksum: Added.
- platform/chromium-mac-leopard/fast/inline/inline-box-background-long-image-expected.png: Added.
- platform/chromium-mac-leopard/fast/inline/inline-box-background-repeat-x-expected.checksum: Added.
- platform/chromium-mac-leopard/fast/inline/inline-box-background-repeat-x-expected.png: Added.
- platform/chromium-mac-leopard/fast/inline/inline-box-background-repeat-y-expected.checksum: Added.
- platform/chromium-mac-leopard/fast/inline/inline-box-background-repeat-y-expected.png: Added.
- platform/chromium-mac-leopard/fast/lists/dynamic-marker-crash-expected.checksum: Added.
- platform/chromium-mac-leopard/fast/lists/dynamic-marker-crash-expected.png: Added.
- platform/chromium-mac-leopard/fast/multicol/shadow-breaking-expected.checksum: Added.
- platform/chromium-mac-leopard/fast/multicol/shadow-breaking-expected.png: Added.
- platform/chromium-mac-leopard/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.checksum: Added.
- platform/chromium-mac-leopard/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png: Added.
- platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-1-expected.checksum: Added.
- platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-1-expected.png: Added.
- platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-10-expected.checksum: Added.
- platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-10-expected.png: Added.
- platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-2-expected.checksum: Added.
- platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-2-expected.png: Added.
- platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-3-expected.checksum: Added.
- platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-3-expected.png: Added.
- platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-4-expected.checksum: Added.
- platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-4-expected.png: Added.
- platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-5-expected.checksum: Added.
- platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-5-expected.png: Added.
- platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-6-expected.checksum: Added.
- platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-6-expected.png: Added.
- platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-7-expected.checksum: Added.
- platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-7-expected.png: Added.
- platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-8-expected.checksum: Added.
- platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-8-expected.png: Added.
- platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-9-expected.checksum: Added.
- platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-9-expected.png: Added.
- platform/chromium-mac-leopard/fast/text/international/text-combine-image-test-expected.checksum: Added.
- platform/chromium-mac-leopard/fast/text/international/text-combine-image-test-expected.png: Added.
- platform/chromium-mac-leopard/fast/text/international/text-combine-image-test-expected.txt: Added.
- platform/chromium-mac-leopard/fast/text/justify-ideograph-simple-expected.checksum: Added.
- platform/chromium-mac-leopard/fast/text/justify-ideograph-simple-expected.png: Added.
- platform/chromium-mac-leopard/fast/text/justify-ideograph-vertical-expected.checksum: Added.
- platform/chromium-mac-leopard/fast/text/justify-ideograph-vertical-expected.png: Added.
- platform/chromium-mac-leopard/fast/text/justify-nbsp-expected.checksum: Added.
- platform/chromium-mac-leopard/fast/text/justify-nbsp-expected.png: Added.
- platform/chromium-mac-leopard/fonts/sans-serif-expected.checksum: Added.
- platform/chromium-mac-leopard/fonts/sans-serif-expected.png: Added.
- platform/chromium-mac-leopard/svg/custom/animate-path-discrete-expected.checksum: Added.
- platform/chromium-mac-leopard/svg/custom/animate-path-discrete-expected.png: Added.
- platform/chromium-mac-leopard/svg/custom/svg-fonts-in-html-expected.checksum: Added.
- platform/chromium-mac-leopard/svg/custom/svg-fonts-in-html-expected.png:
- platform/chromium-mac-leopard/svg/custom/text-dom-01-f-expected.checksum: Added.
- platform/chromium-mac-leopard/svg/custom/text-dom-01-f-expected.png: Added.
- platform/chromium-mac-leopard/svg/hixie/mixed/003-expected.checksum: Added.
- platform/chromium-mac-leopard/svg/hixie/mixed/003-expected.png: Added.
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug113424-expected.checksum: Added.
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug113424-expected.png: Added.
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug1188-expected.checksum: Added.
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug1188-expected.png: Added.
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug1318-expected.checksum: Added.
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug1318-expected.png: Added.
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-2-expected.checksum: Added.
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-2-expected.png: Added.
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug4527-expected.checksum: Added.
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug4527-expected.png: Added.
- platform/chromium-mac-leopard/tables/mozilla/core/bloomberg-expected.checksum: Added.
- platform/chromium-mac-leopard/tables/mozilla/core/bloomberg-expected.png: Added.
- platform/chromium-mac-leopard/tables/mozilla/core/misc-expected.checksum: Added.
- platform/chromium-mac-leopard/tables/mozilla/core/misc-expected.png: Added.
- platform/chromium-mac-leopard/tables/mozilla/marvin/x_thead_align_justify-expected.checksum: Added.
- platform/chromium-mac-leopard/tables/mozilla/marvin/x_thead_align_justify-expected.png: Added.
- 10:01 PM Changeset in webkit [79404] by
-
- 3 edits in trunk/Source/WebKit2
LLVM Compiler build fix.
- Scripts/webkit2/messages.py:
- WebProcess/ApplicationCache/WebApplicationCacheManager.h:
- 9:54 PM Changeset in webkit [79403] by
-
- 8 edits in trunk/Tools
2011-02-22 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
DumpRenderTree should dump as text if test path contains "dumpAsText/"
https://bugs.webkit.org/show_bug.cgi?id=54873
- DumpRenderTree/chromium/LayoutTestController.h: (LayoutTestController::setShouldDumpAsText): (LayoutTestController::setShouldGeneratePixelResults):
- DumpRenderTree/chromium/TestShell.cpp: (TestShell::runFileTest):
- DumpRenderTree/gtk/DumpRenderTree.cpp: (shouldDumpAsText): (dump): (runTest):
- DumpRenderTree/mac/DumpRenderTree.mm: (shouldDumpAsText): (runTest):
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::isDumpAsTextTest): (WebCore::DumpRenderTree::open):
- DumpRenderTree/win/DumpRenderTree.cpp: (shouldDumpAsText): (runTest):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::dump):
- 9:53 PM Changeset in webkit [79402] by
-
- 2 edits in trunk/Source/WebCore
2011-02-22 Andreas Kling <kling@webkit.org>
Reviewed by Dan Bernstein.
FontCache: Make cTargetInactiveFontData an int instead of float.
https://bugs.webkit.org/show_bug.cgi?id=54963
- platform/graphics/FontCache.cpp:
- 9:51 PM Changeset in webkit [79401] by
-
- 2 edits in trunk/LayoutTests
2011-02-22 Anna Cavender <annacc@chromium.org>
Reviewed by Eric Carlson.
Fix for media/video-replaces-poster.html. The test was failing because it assumes the results of a seek will be immediately available, when in fact the seek is asynchronous. I did not remove the line in test-expectations because rebaselines for many (all?) platforms will likely be needed after this patch lands. See also, http://code.google.com/p/chromium/issues/detail?id=60244
https://bugs.webkit.org/show_bug.cgi?id=54910
- media/video-replaces-poster.html:
- 9:49 PM Changeset in webkit [79400] by
-
- 3 edits in trunk/LayoutTests
2011-02-22 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed; second attempt to land Windows 7 expected failure results for new tests from r79318
http://webkit.org/b/54966 tracks the failure.
- platform/win/media/audio-repaint-expected.txt:
- platform/win/media/media-document-audio-repaint-expected.txt:
- 9:39 PM Changeset in webkit [79399] by
-
- 3 edits in trunk/Websites/bugs.webkit.org
2011-02-21 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
[codereviewtool] focus first visible node if no node is focused
https://bugs.webkit.org/show_bug.cgi?id=54935
Now hitting j/k/n/p will focus the first/last visible node
if no other node is focused. Also tweaked the scroll into view
logic a bit to avoid scrolling in this case.
- code-review.js:
- 9:35 PM Changeset in webkit [79398] by
-
- 10 edits in trunk/Source/WebCore
2011-02-22 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Make Editor::selectionComputedStyle return EditingStyle
https://bugs.webkit.org/show_bug.cgi?id=54933
Renamed selectionComputedStyle to selectionStartStyle and changed the return type to EditingStyle.
It also no longer takes a boolean shouldUseFixedFontDefaultSize.
Also added EditingStyle::mergeTypingStyle which replaced old editingStyleIncludingTypingStyle. This function
doesn't extract inheritable properties prior to merge because this turned out be a bug, which was revealed
by an existing layout test only after the code was shared with selectionStartStyle.
No tests are added since this is a refactoring.
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): Calls EditingStyle::create and EditingStyle::mergeTypingStyle. (WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Ditto.
- editing/EditingStyle.cpp: Removed editingStyleIncludingTypingStyle. (WebCore::EditingStyle::mergeTypingStyle): Added.
- editing/EditingStyle.h: (WebCore::EditingStyle::shouldUseFixedDefaultFontSize): Added.
- editing/Editor.cpp: (WebCore::Editor::selectionStartHasStyle): Calls selectionStartStyle. (WebCore::Editor::selectionHasStyle): Ditto. (WebCore::Editor::selectionStartCSSPropertyValue): Ditto. (WebCore::Editor::selectionStartStyle): Renamed from selectionComputedStyle; returns EditingStyle.
- editing/Editor.h:
- editing/EditorCommand.cpp: (WebCore::executeToggleStyleInList): Calls selectionStartStyle.
- editing/InsertLineBreakCommand.cpp:
- editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::calculateStyleBeforeInsertion): Calls EditingStyle::create and EditingStyle::mergeTypingStyle.
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Ditto.
- 9:30 PM Changeset in webkit [79397] by
-
- 2 edits in trunk/Source/WebCore
2011-02-22 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] painting of windowed plugins faulty on certain scroll events
Invalidate the pluginview's relative rect rather then the frameRect(). This is because QWebFrame::renderRelativeCoords()
imitates ScrollView and adds the scroll offset back on to the rect we damage here (making the co-ordinates absolute
to the frame again) before passing it to FrameView.
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::updatePluginWidget):
- 9:29 PM Changeset in webkit [79396] by
-
- 22 edits2 adds in trunk
2011-02-22 Laszlo Gombos <Laszlo Gombos>
Reviewed by Alexey Proskuryakov.
Drop the language tag part from the User Agent string
https://bugs.webkit.org/show_bug.cgi?id=54560
- http/tests/navigation/useragent-expected.txt: Added.
- http/tests/navigation/useragent.php: Added.
2011-02-22 Laszlo Gombos <Laszlo Gombos>
Reviewed by Alexey Proskuryakov.
Drop the language tag part from the User Agent string
https://bugs.webkit.org/show_bug.cgi?id=54560
- StringsNotToBeLocalized.txt: Change the User Agent string template.
2011-02-22 Laszlo Gombos <Laszlo Gombos>
Reviewed by Alexey Proskuryakov.
Drop the language tag part from the User Agent string
https://bugs.webkit.org/show_bug.cgi?id=54560
- WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::composeUserAgent):
- ewk/ewk_settings.cpp: (ewk_settings_default_user_agent_get):
2011-02-22 Laszlo Gombos <Laszlo Gombos>
Reviewed by Alexey Proskuryakov.
Drop the language tag part from the User Agent string
https://bugs.webkit.org/show_bug.cgi?id=54560
- webkit/webkitwebsettings.cpp: (webkitUserAgent):
2011-02-22 Laszlo Gombos <Laszlo Gombos>
Reviewed by Alexey Proskuryakov.
Drop the language tag part from the User Agent string
https://bugs.webkit.org/show_bug.cgi?id=54560
- WebView/WebView.mm: (+[WebView _standardUserAgentWithApplicationName:]): Drop the language tag part.
2011-02-22 Laszlo Gombos <Laszlo Gombos>
Reviewed by Alexey Proskuryakov.
Drop the language tag part from the User Agent string
https://bugs.webkit.org/show_bug.cgi?id=54560
- Api/qwebpage.cpp: (QWebPage::userAgentForUrl):
- tests/qwebpage/tst_qwebpage.cpp: Remove the userAgentLocaleChange test.
2011-02-22 Laszlo Gombos <Laszlo Gombos>
Reviewed by Alexey Proskuryakov.
Drop the language tag part from the User Agent string
https://bugs.webkit.org/show_bug.cgi?id=54560
- WebView.cpp: (WebView::standardUserAgentWithApplicationName):
2011-02-22 Laszlo Gombos <Laszlo Gombos>
Reviewed by Alexey Proskuryakov.
Drop the language tag part from the User Agent string
https://bugs.webkit.org/show_bug.cgi?id=54560
- WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::userAgent):
2011-02-22 Laszlo Gombos <Laszlo Gombos>
Reviewed by Alexey Proskuryakov.
Drop the language tag part from the User Agent string
https://bugs.webkit.org/show_bug.cgi?id=54560
- UIProcess/gtk/WebPageProxyGtk.cpp: (WebKit::WebPageProxy::standardUserAgent):
- UIProcess/mac/WebPageProxyMac.mm: (WebKit::WebPageProxy::standardUserAgent):
- UIProcess/qt/WebPageProxyQt.cpp: (WebKit::WebPageProxy::standardUserAgent):
- UIProcess/win/WebPageProxyWin.cpp: (WebKit::WebPageProxy::standardUserAgent): Drop the language tag part and fix style.
- 9:27 PM Changeset in webkit [79395] by
-
- 2 edits in trunk/LayoutTests
2011-02-22 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium expectations update. Update Snow Leopard
expectations (some SVG tests now pass thanks to patches for bug 54474,
others now fail).
- platform/chromium/test_expectations.txt:
- 9:22 PM Changeset in webkit [79394] by
-
- 2 edits in trunk/Source/WebCore
2011-02-22 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
Minimal build broken
https://bugs.webkit.org/show_bug.cgi?id=54743
Moved the code of setInspectorExtensionAPI and
dispatchMessageFromFrontend out of #if
ENABLE(JAVASCRIPT_DEBUGGER) to fix link error of the minimal build.
- inspector/InspectorController.cpp: (WebCore::InspectorController::setInspectorExtensionAPI): (WebCore::InspectorController::dispatchMessageFromFrontend):
- 8:49 PM Changeset in webkit [79393] by
-
- 1 edit3 adds in trunk/Source/JavaScriptGlue
2011-02-22 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add a GYP project for JavaScriptGlue
https://bugs.webkit.org/show_bug.cgi?id=55019
This is really just a proof-of-concept. The Xcode project file it
produces is able to build JavaScriptGlue, but it's not 100% correct.
Also, the GYP declarations aren't properly structured to allow for
multiple projects or ports. That should get better as we add
proof-of-concepts for other projects and ports.
This build system is not used currently.
- gyp: Added.
- gyp/JavaScriptGlue.gyp: Added.
- gyp/JavaScriptGlue.gypi: Added.
- 8:45 PM Changeset in webkit [79392] by
-
- 3 edits3 adds in trunk/LayoutTests
2011-02-22 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed; fixed Windows expected failure results added by r79328 for new tests from r79318
http://webkit.org/b/54966 tracks the failure.
- platform/win-xp/media: Added.
- platform/win-xp/media/audio-repaint-expected.txt: Added.
- platform/win-xp/media/media-document-audio-repaint-expected.txt: Added.
- platform/win/media/audio-repaint-expected.txt:
- platform/win/media/media-document-audio-repaint-expected.txt:
- 7:35 PM Changeset in webkit [79391] by
-
- 11 edits1 add in trunk/Source/WebKit2
Add WebKit2 API to force a repaint with an invalidation
https://bugs.webkit.org/show_bug.cgi?id=55015
Reviewed by Anders Carlsson.
- Shared/ForceRepaintFlags.h: Added.
- UIProcess/API/C/WKPage.cpp:
(WKPageForceRepaint):
(WKPageForceRepaintWithInvalidation):
- UIProcess/API/C/WKPage.h:
Add WKPageForceRepaintWithInvalidation which does the same thing WKPageForceRepaint
but also calls setNeedsDisplay on the entire bounds of the page.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::forceRepaint):
- UIProcess/WebPageProxy.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::forceRepaint):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
Pipe the flag down to the WebProcess.
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
Add ForceRepaintFlags.h.
- 7:31 PM Changeset in webkit [79390] by
-
- 12 edits3 deletes in trunk/Source
2011-02-22 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r79367.
http://trac.webkit.org/changeset/79367
https://bugs.webkit.org/show_bug.cgi?id=55012
all layout tests are crashing on Snow Leopard (Requested by
rniwa on #webkit).
- GNUmakefile.am:
- JavaScriptCore.gypi:
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/MarkedBlock.cpp: (JSC::MarkedBlock::MarkedBlock):
- runtime/MarkedBlock.h:
- runtime/MarkedSpace.cpp: (JSC::MarkedSpace::destroy): (JSC::MarkedSpace::allocateBlock): (JSC::MarkedSpace::freeBlock): (JSC::MarkedSpace::allocate): (JSC::MarkedSpace::shrink): (JSC::MarkedSpace::reset):
- runtime/MarkedSpace.h: (JSC::CollectorHeap::collectorBlock):
- wtf/CMakeLists.txt:
- wtf/DoublyLinkedList.h: Removed.
2011-02-22 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r79367.
http://trac.webkit.org/changeset/79367
https://bugs.webkit.org/show_bug.cgi?id=55012
all layout tests are crashing on Snow Leopard (Requested by
rniwa on #webkit).
- ForwardingHeaders/wtf/DoublyLinkedList.h: Removed.
2011-02-22 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r79367.
http://trac.webkit.org/changeset/79367
https://bugs.webkit.org/show_bug.cgi?id=55012
all layout tests are crashing on Snow Leopard (Requested by
rniwa on #webkit).
- ForwardingHeaders/wtf/DoublyLinkedList.h: Removed.
- 7:30 PM Changeset in webkit [79389] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
2011-02-21 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
[codereviewtool] remove patch fuzzing
https://bugs.webkit.org/show_bug.cgi?id=54940
This code is buggy and not as necessary now that we
include svn revision numbers in uploaded patches.
- code-review.js:
- 7:25 PM Changeset in webkit [79388] by
-
- 2 edits in trunk/LayoutTests
2011-02-22 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium expectations update. Uncomment SNOWLEOPARD
expectations, since we still fail all those tests on Snow Leopard
(lines were commented out by r79275).
- platform/chromium/test_expectations.txt:
- 7:23 PM Changeset in webkit [79387] by
-
- 4 edits in trunk
2011-02-22 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
Many tests started timing out on the chrome mac canaries around r79035
https://bugs.webkit.org/show_bug.cgi?id=54885
Revert the code changes, but not the Chromium DEPS roll, from
r79038 to see whether this clears up the timing-out tests. Was not
able to reproduce the timeouts locally with a Release mode build
of DRT (on Snow Leopard).
- src/WebKit.cpp: (WebKit::initialize):
2011-02-22 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
Many tests started timing out on the chrome mac canaries around r79035
https://bugs.webkit.org/show_bug.cgi?id=54885
Revert the code changes, but not the Chromium DEPS roll, from
r79038 to see whether this clears up the timing-out tests. Was not
able to reproduce the timeouts locally with a Release mode build
of DRT (on Snow Leopard).
- DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::reset):
- 7:11 PM Changeset in webkit [79386] by
-
- 5 edits in trunk/Source
Versioning.
- 7:07 PM Changeset in webkit [79385] by
-
- 1 copy in tags/Safari-534.21
New tag.
- 6:36 PM Changeset in webkit [79384] by
-
- 2 edits in trunk/LayoutTests
Marked tests as failing (image + text) on chromium, to reflect now-deleted rebaselines.
- platform/chromium/test_expectations.txt:
- 6:31 PM Changeset in webkit [79383] by
-
- 2 edits in trunk/Source/WebKit2
2011-02-22 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
<rdar://problem/9039670>
Make sure that we set the accelerateDrawing property on the LayerTreeHosts's
non-composited content layer if the preference is set.
- WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::LayerTreeHostMac):
- 6:22 PM Changeset in webkit [79382] by
-
- 5 edits in trunk/Source/WebCore
2011-02-22 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Deploy EditingStyle in removeInlineStyleFromElement and removeCSSStyle
https://bugs.webkit.org/show_bug.cgi?id=54944
Deployed EditingStyle in removeInlineStyleFromElement and removeCSSStyle.
Also extracted EditingStyle::conflictsWithInlineStyleOfElement from ApplyStyleCommand::removeCSSStyle,
which returns true iff the specified element has inline style that conflicts or matches the editing style.
It also appends conflicting property IDs to the vector of property IDs if one is specified.
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyBlockStyle): Calls removeCSSStyle. (WebCore::ApplyStyleCommand::applyInlineStyle): Calls shouldSplitTextElement. (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): Calls removeInlineStyleFromElement. (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Takes EditingStyle* instead of CSSMutableStyleDeclaration*. (WebCore::ApplyStyleCommand::removeCSSStyle): Ditto; extracted the logic to decide properties to remove as conflictsWithInlineStyleOfElement. (WebCore::ApplyStyleCommand::highestAncestorWithConflictingInlineStyle): Calls shouldRemoveInlineStyleFromElement. (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Calls removeInlineStyleFromElement. (WebCore::ApplyStyleCommand::removeInlineStyle): Ditto. (WebCore::ApplyStyleCommand::shouldSplitTextElement): Takes EditingStyle* instead of CSSMutableStyleDeclaration*.
- editing/ApplyStyleCommand.h: (WebCore::ApplyStyleCommand::shouldRemoveInlineStyleFromElement): Ditto.
- editing/EditingStyle.cpp: (WebCore::EditingStyle::conflictsWithInlineStyleOfElement): Extracted from ApplyStyleCommand::removeCSSStyle.
- editing/EditingStyle.h: (WebCore::EditingStyle::conflictsWithInlineStyleOfElement): Added.
- 6:15 PM Changeset in webkit [79381] by
-
- 18 edits6 adds in trunk/LayoutTests
Unreviewed chromium-gpu expectations update.
- platform/chromium-gpu-linux/compositing/masks/masked-ancestor-expected.checksum:
- platform/chromium-gpu-linux/compositing/masks/masked-ancestor-expected.png:
- platform/chromium-gpu-linux/compositing/masks/simple-composited-mask-expected.checksum:
- platform/chromium-gpu-linux/compositing/masks/simple-composited-mask-expected.png:
- platform/chromium-gpu-linux/compositing/overflow/fixed-position-ancestor-clip-expected.checksum:
- platform/chromium-gpu-linux/compositing/overflow/fixed-position-ancestor-clip-expected.png:
- platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.checksum:
- platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png:
- platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.checksum:
- platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.png:
- platform/chromium-gpu-mac/compositing/masks/masked-ancestor-expected.checksum: Added.
- platform/chromium-gpu-mac/compositing/masks/masked-ancestor-expected.png: Added.
- platform/chromium-gpu-mac/compositing/masks/simple-composited-mask-expected.checksum: Added.
- platform/chromium-gpu-mac/compositing/masks/simple-composited-mask-expected.png: Added.
- platform/chromium-gpu-mac/compositing/overflow/fixed-position-ancestor-clip-expected.checksum: Added.
- platform/chromium-gpu-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png: Added.
- platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.checksum:
- platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.png:
- platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.checksum:
- platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.png:
- platform/chromium-gpu-win/fast/canvas/image-object-in-canvas-expected.checksum:
- platform/chromium-gpu-win/fast/canvas/image-object-in-canvas-expected.png:
- platform/chromium/test_expectations.txt:
- 6:09 PM Changeset in webkit [79380] by
-
- 3 edits in trunk/Tools
2011-02-22 Dirk Pranke <dpranke@chromium.org>
Reviewed by James Robinson.
nrwt: --platform chromium-gpu doesn't work with --worker-model=processes
https://bugs.webkit.org/show_bug.cgi?id=55009
- Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
- 6:08 PM Changeset in webkit [79379] by
-
- 1 edit6 adds in trunk/LayoutTests
2011-02-22 Martin Robinson <mrobinson@igalia.com>
Add missing files from r79351. These are expected results for new media tests.
- platform/gtk/media/audio-repaint-expected.checksum: Added.
- platform/gtk/media/audio-repaint-expected.png: Added.
- platform/gtk/media/audio-repaint-expected.txt: Added.
- platform/gtk/media/media-document-audio-repaint-expected.checksum: Added.
- platform/gtk/media/media-document-audio-repaint-expected.png: Added.
- platform/gtk/media/media-document-audio-repaint-expected.txt: Added.
- 5:51 PM Changeset in webkit [79378] by
-
- 7 edits3 adds in trunk/LayoutTests
Unreviewed expectations change for chromium.
- platform/chromium-gpu-linux/compositing/reflections/deeply-nested-reflections-expected.checksum:
- platform/chromium-gpu-linux/compositing/reflections/deeply-nested-reflections-expected.png:
- platform/chromium-gpu-mac/compositing/reflections/deeply-nested-reflections-expected.checksum: Added.
- platform/chromium-gpu-mac/compositing/reflections/deeply-nested-reflections-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/deeply-nested-reflections-expected.checksum:
- platform/chromium-gpu-win/compositing/reflections/deeply-nested-reflections-expected.png:
- platform/chromium-gpu-win/compositing/reflections/deeply-nested-reflections-expected.txt:
- platform/chromium/test_expectations.txt:
- 5:37 PM Changeset in webkit [79377] by
-
- 4 edits in trunk/Source
2011-02-22 Chang Shu <cshu@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] editing/deleting/5408255.html fails
https://bugs.webkit.org/show_bug.cgi?id=54964
Move WebCore resource file to QtWebKit since they are referred in WebKit.
- QtWebKit.pro:
2011-02-22 Chang Shu <cshu@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] editing/deleting/5408255.html fails
https://bugs.webkit.org/show_bug.cgi?id=54964
Move WebCore resource file to QtWebKit since they are referred in WebKit.
- WebCore.pro:
- 5:25 PM Changeset in webkit [79376] by
-
- 2 edits in trunk/Source/WebKit2
Fix it Windows-style.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::getSitesWithPluginData):
(WebKit::WebProcess::clearPluginSiteData):
- 5:21 PM Changeset in webkit [79375] by
-
- 17 edits2 deletes in trunk/LayoutTests
2011-02-22 MORITA Hajime <morrita@google.com>
Unreviewed expectation update to catch up r79359.
- platform/chromium-linux/media/audio-repaint-expected.checksum:
- platform/chromium-linux/media/audio-repaint-expected.png:
- platform/chromium-linux/media/audio-repaint-expected.txt: Removed.
- platform/chromium-linux/media/media-document-audio-repaint-expected.checksum:
- platform/chromium-linux/media/media-document-audio-repaint-expected.png:
- platform/chromium-linux/media/media-document-audio-repaint-expected.txt: Removed.
- platform/chromium-mac/media/audio-repaint-expected.checksum:
- platform/chromium-mac/media/audio-repaint-expected.png:
- platform/chromium-mac/media/audio-repaint-expected.txt:
- platform/chromium-mac/media/media-document-audio-repaint-expected.checksum:
- platform/chromium-mac/media/media-document-audio-repaint-expected.png:
- platform/chromium-mac/media/media-document-audio-repaint-expected.txt:
- platform/chromium-win/media/audio-repaint-expected.checksum:
- platform/chromium-win/media/audio-repaint-expected.png:
- platform/chromium-win/media/audio-repaint-expected.txt:
- platform/chromium-win/media/media-document-audio-repaint-expected.checksum:
- platform/chromium-win/media/media-document-audio-repaint-expected.png:
- platform/chromium-win/media/media-document-audio-repaint-expected.txt:
- 4:58 PM Changeset in webkit [79374] by
-
- 2 edits in trunk/LayoutTests
Remove no-longer-necessary test expectation (LINUX video-cancel-load)
https://bugs.webkit.org/show_bug.cgi?id=55003
Patch by Ami Fischman <fischman@chromium.org> on 2011-02-22
Reviewed by Peter Kasting.
- platform/chromium/test_expectations.txt:
- 4:48 PM Changeset in webkit [79373] by
-
- 111 edits16 adds442 deletes in trunk/LayoutTests
Revert "Unreviewed rebaselines for Chromium." because the baselines were put in the wrong directory.
This partially reverts r79034 (we keep test_expectations the same as it is currently to avoid breaking the canaries).
- 4:42 PM Changeset in webkit [79372] by
-
- 8 edits in trunk/Source/WebKit2
2011-02-22 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Rename WebProcess::shutdownIfPossible to WebProcess::terminateIfPossible
https://bugs.webkit.org/show_bug.cgi?id=55008
- WebProcess/Downloads/DownloadManager.cpp: (WebKit::DownloadManager::downloadFinished):
- WebProcess/WebProcess.cpp: (WebKit::WebProcess::removeWebPage): (WebKit::WebProcess::terminateIfPossible): (WebKit::WebProcess::getSitesWithPluginData):
- WebProcess/WebProcess.h:
- WebProcess/gtk/WebProcessGtk.cpp: (WebKit::WebProcess::platformTerminate):
- WebProcess/mac/WebProcessMac.mm: (WebKit::WebProcess::platformTerminate):
- WebProcess/qt/WebProcessQt.cpp: (WebKit::WebProcess::platformTerminate):
- WebProcess/win/WebProcessWin.cpp: (WebKit::WebProcess::platformTerminate):
- 4:30 PM Changeset in webkit [79371] by
-
- 2 edits in trunk/Source/WebKit2
Windows build-fix attempt.
- win/WebKit2Generated.make:
- 4:14 PM Changeset in webkit [79370] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed.
<rdar://problem/8762042> and https://bugs.webkit.org/show_bug.cgi?id=54514
API to view and delete Application Cache data by origin.
[Qt][WK2] Buildfix after r79364.
- DerivedSources.pro:
- WebKit2.pri:
- 4:14 PM Changeset in webkit [79369] by
-
- 39 edits3 copies in branches/chromium/648
Merge 79107 - 2011-02-19 Charlie Reis <creis@chromium.org>
Reviewed by Mihai Parparita.
Ensure loading has stopped in HistoryController::goToItem
https://bugs.webkit.org/show_bug.cgi?id=54517
Tests that going forward within the same document does not stop loading.
- http/tests/navigation/forward-to-fragment-fires-onload.html: Added.
- http/tests/navigation/forward-to-fragment-fires-onload-expected.txt: Added.
- http/tests/navigation/resources/forward-to-fragment-fires-onload-2.html: Added.
2011-02-19 Charlie Reis <creis@chromium.org>
Reviewed by Mihai Parparita.
Ensure loading has stopped in HistoryController::goToItem
https://bugs.webkit.org/show_bug.cgi?id=54517
Avoid stopping all loaders in goToItem for same document navigations
or pseudo-back-forward URLs. Make HistoryController::goToItem private
to force callers to go through Page::goToItem. Also add a callback to
FrameLoaderClient to let clients decide whether to stop loading first.
Test: http/tests/navigation/forward-to-fragment-fires-onload.html
- loader/EmptyClients.h:
- loader/FrameLoader.h:
- loader/FrameLoaderClient.h:
- loader/HistoryController.cpp:
- loader/HistoryController.h:
- page/Page.cpp:
2011-02-19 Charlie Reis <creis@chromium.org>
Reviewed by Mihai Parparita.
Ensure loading has stopped in HistoryController::goToItem
https://bugs.webkit.org/show_bug.cgi?id=54517
Call Page::goToItem instead of HistoryController::goToItem, so that
FrameLoader::stopAllLoaders is called first. Also adds a callback in
FrameLoaderClient for checking for pseudo-back-forward URLs.
Test: http/tests/navigation/forward-to-fragment-fires-onload.html
- src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::shouldStopLoadingForHistoryItem): Added.
- src/FrameLoaderClientImpl.h:
- src/WebFrameImpl.cpp:
2011-02-19 Charlie Reis <creis@chromium.org>
Reviewed by Mihai Parparita.
Ensure loading has stopped in HistoryController::goToItem
https://bugs.webkit.org/show_bug.cgi?id=54517
Add a FrameLoaderClient callback for whether to stop loading before goToItem.
Test: http/tests/navigation/forward-to-fragment-fires-onload.html
- WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::shouldStopLoadingForHistoryItem): Added.
- WebCoreSupport/FrameLoaderClientEfl.h:
2011-02-19 Charlie Reis <creis@chromium.org>
Reviewed by Mihai Parparita.
Ensure loading has stopped in HistoryController::goToItem
https://bugs.webkit.org/show_bug.cgi?id=54517
Add a FrameLoaderClient callback for whether to stop loading before goToItem.
Test: http/tests/navigation/forward-to-fragment-fires-onload.html
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClientGtk::shouldStopLoadingForHistoryItem): Added.
- WebCoreSupport/FrameLoaderClientGtk.h:
2011-02-19 Charlie Reis <creis@chromium.org>
Reviewed by Mihai Parparita.
Ensure loading has stopped in HistoryController::goToItem
https://bugs.webkit.org/show_bug.cgi?id=54517
Add a FrameLoaderClient callback for whether to stop loading before goToItem.
Test: http/tests/navigation/forward-to-fragment-fires-onload.html
- WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::shouldStopLoadingForHistoryItem): Added.
- WebCoreSupport/FrameLoaderClientHaiku.h:
2011-02-19 Charlie Reis <creis@chromium.org>
Reviewed by Mihai Parparita.
Ensure loading has stopped in HistoryController::goToItem
https://bugs.webkit.org/show_bug.cgi?id=54517
Add a FrameLoaderClient callback for whether to stop loading before goToItem.
Test: http/tests/navigation/forward-to-fragment-fires-onload.html
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::shouldStopLoadingForHistoryItem): Added.
- WebCoreSupport/WebFrameLoaderClient.h:
2011-02-19 Charlie Reis <creis@chromium.org>
Reviewed by Mihai Parparita.
Ensure loading has stopped in HistoryController::goToItem
https://bugs.webkit.org/show_bug.cgi?id=54517
Add a FrameLoaderClient callback for whether to stop loading before goToItem.
Test: http/tests/navigation/forward-to-fragment-fires-onload.html
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::shouldStopLoadingForHistoryItem): Added.
- WebCoreSupport/FrameLoaderClientQt.h:
2011-02-19 Charlie Reis <creis@chromium.org>
Reviewed by Mihai Parparita.
Ensure loading has stopped in HistoryController::goToItem
https://bugs.webkit.org/show_bug.cgi?id=54517
Add a FrameLoaderClient callback for whether to stop loading before goToItem.
Test: http/tests/navigation/forward-to-fragment-fires-onload.html
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::shouldStopLoadingForHistoryItem): Added.
- WebCoreSupport/WebFrameLoaderClient.h:
2011-02-19 Charlie Reis <creis@chromium.org>
Reviewed by Mihai Parparita.
Ensure loading has stopped in HistoryController::goToItem
https://bugs.webkit.org/show_bug.cgi?id=54517
Add a FrameLoaderClient callback for whether to stop loading before goToItem.
Test: http/tests/navigation/forward-to-fragment-fires-onload.html
- WebCoreSupport/FrameLoaderClientWinCE.cpp: (WebKit::FrameLoaderClientWinCE::shouldStopLoadingForHistoryItem): Added.
- WebCoreSupport/FrameLoaderClientWinCE.h:
2011-02-19 Charlie Reis <creis@chromium.org>
Reviewed by Mihai Parparita.
Ensure loading has stopped in HistoryController::goToItem
https://bugs.webkit.org/show_bug.cgi?id=54517
Add a FrameLoaderClient callback for whether to stop loading before goToItem.
Test: http/tests/navigation/forward-to-fragment-fires-onload.html
- WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::shouldStopLoadingForHistoryItem): Added.
- WebKitSupport/FrameLoaderClientWx.h:
2011-02-19 Charlie Reis <creis@chromium.org>
Reviewed by Mihai Parparita.
Ensure loading has stopped in HistoryController::goToItem
https://bugs.webkit.org/show_bug.cgi?id=54517
Add a FrameLoaderClient callback for whether to stop loading before goToItem.
Test: http/tests/navigation/forward-to-fragment-fires-onload.html
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::shouldStopLoadingForHistoryItem): Added.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
BUG=73444
TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/6541090
- 4:10 PM Changeset in webkit [79368] by
-
- 2 edits in trunk/Source/WebCore
<rdar://problem/8762042> and https://bugs.webkit.org/show_bug.cgi?id=54514
API to view and delete Application Cache data by origin.
Reviewed by Anders Carlsson.
Implement these to be used by WK2 API:
- loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::ApplicationCacheStorage::getOriginsWithCache):
(WebCore::ApplicationCacheStorage::deleteEntriesForOrigin):
- 3:23 PM Changeset in webkit [79367] by
-
- 12 edits2 copies1 add in trunk/Source
2011-02-22 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Manage MarkedBlocks in a linked list instead of a vector, so arbitrary removal is O(1)
https://bugs.webkit.org/show_bug.cgi?id=54999
SunSpider reports no change.
- GNUmakefile.am:
- JavaScriptCore.gypi:
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj: So many build systems, so little time.
- wtf/CMakeLists.txt:
- runtime/MarkedBlock.cpp: (JSC::MarkedBlock::MarkedBlock):
- runtime/MarkedBlock.h: (JSC::MarkedBlock::setPrev): (JSC::MarkedBlock::setNext): (JSC::MarkedBlock::prev): (JSC::MarkedBlock::next): Added linked list data members and accessors.
- runtime/MarkedSpace.cpp: (JSC::MarkedSpace::destroy): (JSC::MarkedSpace::allocateBlock): Stop using vector, since it doesn't exist anymore.
(JSC::MarkedSpace::freeBlocks): New helper function for updating relevant
data structures when freeing blocks.
(JSC::MarkedSpace::allocate): Updated for nextBlock being a pointer and
not a vector index.
(JSC::MarkedSpace::shrink): Construct a temporary list of empties and
then free them, to avoid modifying our hash table while iterating it.
This wasn't a concern before because we were using indirect array
indexing, not direct pointer indexing.
(JSC::MarkedSpace::reset): Updated for nextBlock being a pointer and
not a vector index.
- runtime/MarkedSpace.h: (JSC::CollectorHeap::CollectorHeap): Changed data type from vector to linked list.
- wtf/DoublyLinkedList.h: Added. New linked list class. (WTF::::DoublyLinkedList): (WTF::::isEmpty): (WTF::::head): (WTF::::append): (WTF::::remove):
2011-02-22 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Manage MarkedBlocks in a linked list instead of a vector, so arbitrary removal is O(1)
https://bugs.webkit.org/show_bug.cgi?id=54999
New WTF header.
- ForwardingHeaders/wtf/DoublyLinkedList.h: Copied from ForwardingHeaders/wtf/FixedArray.h.
2011-02-22 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Manage MarkedBlocks in a linked list instead of a vector, so arbitrary removal is O(1)
https://bugs.webkit.org/show_bug.cgi?id=54999
New WTF header.
- ForwardingHeaders/wtf/DoublyLinkedList.h: Copied from ForwardingHeaders/wtf/FixedArray.h.
- 3:22 PM Changeset in webkit [79366] by
-
- 9 edits2 deletes in trunk/Source/WebKit2
2011-02-22 Brady Eidson <beidson@apple.com>
Reviewed by Anders Carlsson and looked over by Brian Weinstein.
<rdar://problem/8762042> and https://bugs.webkit.org/show_bug.cgi?id=54514
API to view and delete Application Cache data by origin.
I couldn't help myself - I also re-alphabetized WebResourceCacheManager in many places where
it's sorting was wrong due to a last minute name change.
Project file changes:
- GNUmakefile.am:
- win/WebKit2.vcproj:
- win/WebKit2Common.vsprops:
- win/WebKit2Generated.make:
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
WK2 build-system and API paperwork:
- DerivedSources.make:
- Platform/CoreIPC/MessageID.h:
- Shared/API/c/WKBase.h:
- Shared/APIObject.h:
- UIProcess/API/C/WKAPICast.h:
Add a helper to perform an ArrayCallback with a Vector of SecurityOriginDatas:
- Shared/SecurityOriginData.cpp: (WebKit::performAPICallbackWithSecurityOriginDataVector):
- Shared/SecurityOriginData.h:
- UIProcess/WebResourceCacheManagerProxy.cpp: (WebKit::WebResourceCacheManagerProxy::didGetCacheOrigins): Use performAPICallbackWithSecurityOriginDataVector here.
Add an ApplicationCacheManagerProxy to the context and invalidate it at the appropriate times:
- UIProcess/WebContext.cpp: (WebKit::WebContext::WebContext): (WebKit::WebContext::~WebContext): (WebKit::WebContext::processDidClose): (WebKit::WebContext::didReceiveMessage): Route messages to the right proxy.
- UIProcess/WebContext.h: (WebKit::WebContext::applicationCacheManagerProxy): (WebKit::WebContext::resourceCacheManagerProxy):
Add API to get the ApplicationCacheManager for a context:
- UIProcess/API/C/WKContext.cpp: (WKContextGetApplicationCacheManager): (WKContextGetResourceCacheManager):
- UIProcess/API/C/WKContext.h:
Route messages to the right place:
- UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::didReceiveMessage):
- WebProcess/WebProcess.cpp: (WebKit::WebProcess::didReceiveMessage):
Add the API object, which wraps to WebApplicationCacheManagerProxy:
- UIProcess/API/C/WKApplicationCacheManager.cpp: Added. (WKApplicationCacheManagerGetTypeID): (WKApplicationCacheManagerGetApplicationCacheOrigins): (WKApplicationCacheManagerDeleteEntriesForOrigin): (WKApplicationCacheManagerDeleteAllEntries):
- UIProcess/API/C/WKApplicationCacheManager.h: Added.
The UIProcess implementation of the manager to send messages to the WebProcess and pipe a callback back up to the client:
- UIProcess/WebApplicationCacheManagerProxy.cpp: Added. (WebKit::WebApplicationCacheManagerProxy::create): (WebKit::WebApplicationCacheManagerProxy::WebApplicationCacheManagerProxy): (WebKit::WebApplicationCacheManagerProxy::~WebApplicationCacheManagerProxy): (WebKit::WebApplicationCacheManagerProxy::invalidate): (WebKit::WebApplicationCacheManagerProxy::didReceiveMessage): (WebKit::WebApplicationCacheManagerProxy::getApplicationCacheOrigins): (WebKit::WebApplicationCacheManagerProxy::didGetApplicationCacheOrigins): Use performAPICallbackWithSecurityOriginDataVector here. (WebKit::WebApplicationCacheManagerProxy::deleteEntriesForOrigin): (WebKit::WebApplicationCacheManagerProxy::deleteAllEntries):
- UIProcess/WebApplicationCacheManagerProxy.h: Added. (WebKit::WebApplicationCacheManagerProxy::clearContext): (WebKit::WebApplicationCacheManagerProxy::type):
- UIProcess/WebApplicationCacheManagerProxy.messages.in: Added.
The WebProcess implementation to response to UIProcess messages and actually do the dirty-work in WebCore:
- WebProcess/ApplicationCache: Added.
- WebProcess/ApplicationCache/WebApplicationCacheManager.cpp: Added. (WebKit::WebApplicationCacheManager::shared): (WebKit::WebApplicationCacheManager::WebApplicationCacheManager): (WebKit::WebApplicationCacheManager::didReceiveMessage): (WebKit::WebApplicationCacheManager::getApplicationCacheOrigins): (WebKit::WebApplicationCacheManager::deleteEntriesForOrigin): (WebKit::WebApplicationCacheManager::deleteAllEntries):
- WebProcess/ApplicationCache/WebApplicationCacheManager.h: Added.
- WebProcess/ApplicationCache/WebApplicationCacheManager.messages.in: Added.
- 3:01 PM Changeset in webkit [79365] by
-
- 2 edits in trunk/LayoutTests
Unreviewed; neglected to update an expected result after changing some
boilerplate text at the top of the test.
- media/audio-repaint-expected.txt:
- 2:52 PM Changeset in webkit [79364] by
-
- 21 edits9 adds in trunk/Source/WebKit2
<rdar://problem/8762042> and https://bugs.webkit.org/show_bug.cgi?id=54514
API to view and delete Application Cache data by origin.
Reviewed by Anders Carlsson and looked over by Brian Weinstein.
I couldn't help myself - I also re-alphabetized WebResourceCacheManager in many places where
it's sorting was wrong due to a last minute name change.
Project file changes:
- GNUmakefile.am:
- win/WebKit2.vcproj:
- win/WebKit2Common.vsprops:
- win/WebKit2Generated.make:
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
WK2 build-system and API paperwork:
- DerivedSources.make:
- Platform/CoreIPC/MessageID.h:
- Shared/API/c/WKBase.h:
- Shared/APIObject.h:
- UIProcess/API/C/WKAPICast.h:
Add a helper to perform an ArrayCallback with a Vector of SecurityOriginDatas:
- Shared/SecurityOriginData.cpp:
(WebKit::performAPICallbackWithSecurityOriginDataVector):
- Shared/SecurityOriginData.h:
- UIProcess/WebResourceCacheManagerProxy.cpp:
(WebKit::WebResourceCacheManagerProxy::didGetCacheOrigins): Use performAPICallbackWithSecurityOriginDataVector here.
Add an ApplicationCacheManagerProxy to the context and invalidate it at the appropriate times:
- UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
(WebKit::WebContext::processDidClose):
(WebKit::WebContext::didReceiveMessage): Route messages to the right proxy.
- UIProcess/WebContext.h:
(WebKit::WebContext::applicationCacheManagerProxy):
(WebKit::WebContext::resourceCacheManagerProxy):
Add API to get the ApplicationCacheManager for a context:
- UIProcess/API/C/WKContext.cpp:
(WKContextGetApplicationCacheManager):
(WKContextGetResourceCacheManager):
- UIProcess/API/C/WKContext.h:
Route messages to the right place:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didReceiveMessage):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didReceiveMessage):
Add the API object, which wraps to WebApplicationCacheManagerProxy:
- UIProcess/API/C/WKApplicationCacheManager.cpp: Added.
(WKApplicationCacheManagerGetTypeID):
(WKApplicationCacheManagerGetApplicationCacheOrigins):
(WKApplicationCacheManagerDeleteEntriesForOrigin):
(WKApplicationCacheManagerDeleteAllEntries):
- UIProcess/API/C/WKApplicationCacheManager.h: Added.
The UIProcess implementation of the manager to send messages to the WebProcess and pipe a callback back up to the client:
- UIProcess/WebApplicationCacheManagerProxy.cpp: Added.
(WebKit::WebApplicationCacheManagerProxy::create):
(WebKit::WebApplicationCacheManagerProxy::WebApplicationCacheManagerProxy):
(WebKit::WebApplicationCacheManagerProxy::~WebApplicationCacheManagerProxy):
(WebKit::WebApplicationCacheManagerProxy::invalidate):
(WebKit::WebApplicationCacheManagerProxy::didReceiveMessage):
(WebKit::WebApplicationCacheManagerProxy::getApplicationCacheOrigins):
(WebKit::WebApplicationCacheManagerProxy::didGetApplicationCacheOrigins): Use performAPICallbackWithSecurityOriginDataVector here.
(WebKit::WebApplicationCacheManagerProxy::deleteEntriesForOrigin):
(WebKit::WebApplicationCacheManagerProxy::deleteAllEntries):
- UIProcess/WebApplicationCacheManagerProxy.h: Added.
(WebKit::WebApplicationCacheManagerProxy::clearContext):
(WebKit::WebApplicationCacheManagerProxy::type):
- UIProcess/WebApplicationCacheManagerProxy.messages.in: Added.
The WebProcess implementation to response to UIProcess messages and actually do the dirty-work in WebCore:
- WebProcess/ApplicationCache: Added.
- WebProcess/ApplicationCache/WebApplicationCacheManager.cpp: Added.
(WebKit::WebApplicationCacheManager::shared):
(WebKit::WebApplicationCacheManager::WebApplicationCacheManager):
(WebKit::WebApplicationCacheManager::didReceiveMessage):
(WebKit::WebApplicationCacheManager::getApplicationCacheOrigins):
(WebKit::WebApplicationCacheManager::deleteEntriesForOrigin):
(WebKit::WebApplicationCacheManager::deleteAllEntries):
- WebProcess/ApplicationCache/WebApplicationCacheManager.h: Added.
- WebProcess/ApplicationCache/WebApplicationCacheManager.messages.in: Added.
- 2:34 PM Changeset in webkit [79363] by
-
- 2 edits in trunk/LayoutTests
2011-02-22 Ami Fischman <fischman@chromium.org>
Reviewed by Eric Carlson.
Second attempt at removing flakiness from media/video-poster.html (in
service of http://crbug.com/60845). First attempt (r79161)
relied on load & error events firing on the video element for
poster-related events, which the standard does not specify (and
are thus a bug). This change instead relies on a 20ms sleep loop to
observe the new expected dimensions (and relies on the test
runner to time out if the expectations fail to be met).
- media/video-poster.html:
- 2:29 PM Changeset in webkit [79362] by
-
- 6 edits in trunk/Source/WebKit2
2011-02-22 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Get rid of WebProcessManager::getAllWebProcessContexts
https://bugs.webkit.org/show_bug.cgi?id=55000
- Shared/WebURLRequest.cpp: (WebKit::WebURLRequest::setDefaultTimeoutInterval): Call WebContext::allContexts instead.
- UIProcess/WebContext.cpp:
- UIProcess/WebContext.h: Add a vector of WebContext objects. Update it when creating and destroying contexts.
- UIProcess/WebProcessManager.cpp:
- UIProcess/WebProcessManager.h: Remove WebProcessManager::getAllWebProcessContexts.
- 2:29 PM Changeset in webkit [79361] by
-
- 2 edits in trunk/LayoutTests
2011-02-22 Andrew Wilson <atwilson@chromium.org>
Unreviewed, rolling out r79339.
http://trac.webkit.org/changeset/79339
https://bugs.webkit.org/show_bug.cgi?id=54974
Baselines were put in the wrong directory, so we need to
continue to ignore failures
- platform/chromium/test_expectations.txt:
- 2:28 PM Changeset in webkit [79360] by
-
- 10 edits in trunk/Source/WebCore
Fix for https://bugs.webkit.org/show_bug.cgi?id=54991
Scrollbar::nativeTheme()->usesOverlayScrollbars() should not be consulted for CSS
Scrollbars
-and corresponding-
<rdar://problem/9034318>
Reviewed by Sam Weinig.
Instead of consulting the theme directly, callers should ask the Scrollbar or
ScrollableArea if the scrollbars are overlay or not.
- platform/ScrollView.cpp:
(WebCore::ScrollView::visibleContentRect):
(WebCore::ScrollView::scrollContents):
(WebCore::ScrollView::wheelEvent):
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::setScrollOffsetFromAnimation):
(WebCore::ScrollableArea::hasOverlayScrollbars):
- platform/ScrollableArea.h:
- platform/Scrollbar.cpp:
(WebCore::Scrollbar::isOverlayScrollbar):
- platform/Scrollbar.h:
- rendering/RenderBox.cpp:
(WebCore::RenderBox::includeVerticalScrollbarSize):
(WebCore::RenderBox::includeHorizontalScrollbarSize):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::verticalScrollbarWidth):
(WebCore::RenderLayer::horizontalScrollbarHeight):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::verticalScrollbarWidth):
- rendering/RenderScrollbar.h:
(WebCore::RenderScrollbar::isOverlayScrollbar):
- 2:09 PM Changeset in webkit [79359] by
-
- 9 edits1 add in trunk/LayoutTests
2011-02-22 Jer Noble <jer.noble@apple.com>
Reviewed by Eric Carlson.
media/audio-repaint.html flakey.
https://bugs.webkit.org/show_bug.cgi?id=54970
Audio repaint tests flakey, as they took a snapshot 1.5s into a 7s file. Tests
modified to test against a 1s file, and will trigger a snapshot when the audio
finishes seeking to the 1/2way point.
- media/audio-repaint-expected.txt:
- media/audio-repaint.html:
- media/content/silence.wav: Added.
- media/media-document-audio-repaint-expected.txt:
- media/media-document-audio-repaint.html:
- platform/mac/media/audio-repaint-expected.checksum:
- platform/mac/media/audio-repaint-expected.png:
- platform/mac/media/media-document-audio-repaint-expected.checksum:
- platform/mac/media/media-document-audio-repaint-expected.png:
- 2:09 PM Changeset in webkit [79358] by
-
- 2 edits in trunk/Source/WebKit2
Re-add early bail out in dispatchDecidePolicyForNavigationAction with prevents
a crash running fast/loader/empty-embed-src-attribute.html. This matches a
bail out in the default policy delegate in WebKit1.
Reviewed by Anders Carlsson.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
- 2:00 PM Changeset in webkit [79357] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
[Qt] New fails caused by change(s) between r79317-r79320.
- platform/qt/Skipped: Skip tests until fix.
- 1:55 PM Changeset in webkit [79356] by
-
- 2 edits in trunk/Source/JavaScriptCore
Windows build fix.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 1:49 PM Changeset in webkit [79355] by
-
- 6 edits in trunk/Source/JavaScriptCore
Bug 54988 - Re-create StructureTransitionTable class, encapsulate transition table
Reviewed by Sam Weinig.
The Structure class keeps a table of transitions to derived Structure types. Since
this table commonly contains a single entry we employ an optimization where instead
of holding a map, we may hold a pointer directly to a single instance of the mapped
type. We use an additional bit of data to flag whether the pointer is currently
pointing to a table of transitions, or a singleton transition. Previously we had
commonly used a pattern of storing data in the low bits of pointers, but had moved
away from this since it causes false leaks to be reported by the leaks tool. However
in this case, the entries in the map are weak links - this pointer will never be
responsible for keeping an object alive. As such we can use this approach provided
that the bit is set when a table is not in use (otherwise the table would appear to
be leaked).
Additionally, the transition table currently allows two entries to exist for a given
key - one specialized to a particular value, and one not specialized. This is
unnecessary, wasteful, and a little inconsistent. (If you create an entry for a
specialized value, then a non-specialized entry, both will exist. If you create an
entry for a non-specialized value, then try to create a specialized entry, only a
non-specialized form will be allowed.)
This shows a small progression on v8.
- JavaScriptCore.exp:
- runtime/JSObject.h:
(JSC::JSObject::putDirectInternal):
- runtime/Structure.cpp:
(JSC::StructureTransitionTable::contains):
(JSC::StructureTransitionTable::get):
(JSC::StructureTransitionTable::remove):
(JSC::StructureTransitionTable::add):
(JSC::Structure::dumpStatistics):
(JSC::Structure::Structure):
(JSC::Structure::~Structure):
(JSC::Structure::addPropertyTransitionToExistingStructure):
(JSC::Structure::addPropertyTransition):
- runtime/Structure.h:
(JSC::Structure::get):
- runtime/StructureTransitionTable.h:
(JSC::StructureTransitionTable::Hash::hash):
(JSC::StructureTransitionTable::Hash::equal):
(JSC::StructureTransitionTable::HashTraits::emptyValue):
(JSC::StructureTransitionTable::HashTraits::constructDeletedValue):
(JSC::StructureTransitionTable::HashTraits::isDeletedValue):
(JSC::StructureTransitionTable::StructureTransitionTable):
(JSC::StructureTransitionTable::~StructureTransitionTable):
(JSC::StructureTransitionTable::isUsingSingleSlot):
(JSC::StructureTransitionTable::map):
(JSC::StructureTransitionTable::setMap):
(JSC::StructureTransitionTable::singleTransition):
(JSC::StructureTransitionTable::setSingleTransition):
- 1:45 PM Changeset in webkit [79354] by
-
- 5 edits in trunk/Source/WebKit/chromium
2011-02-21 Nico Weber <thakis@chromium.org>
Reviewed by James Robinson.
[chromium] WebWorkerBase::openFileSystem confuses clang's -Woverloaded-virtual
https://bugs.webkit.org/show_bug.cgi?id=54920
Rename WebWorkerBase::openFileSystem() to openFileSystemForWorker() to
make it obvious it's not an override of
WebFrameClient::openFileSystem().
Remove a failed attempt to override it in WebWorkerClientImpl (the
override didn't change the behavior).
No intended functionality change.
- src/LocalFileSystemChromium.cpp: (WebCore::LocalFileSystem::requestFileSystem): Call new name.
- src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::openFileSystemForWorker): Rename openFileSystem() to openFileSystemForWorker().
- src/WebWorkerBase.h: Rename openFileSystem() to openFileSystemForWorker().
- src/WebWorkerClientImpl.h: (WebKit::WebWorkerClientImpl::allowDatabase): Remove unsuccessful (and pointless) override.
- 1:35 PM Changeset in webkit [79353] by
-
- 2 edits18 adds in trunk/LayoutTests
Unreviewed expectations change.
[Chromium] Generate results for media/audio-repaint.html and media/media-document-audio-repaint.html
https://bugs.webkit.org/show_bug.cgi?id=54983
- platform/chromium-linux/media/audio-repaint-expected.checksum: Added.
- platform/chromium-linux/media/audio-repaint-expected.png: Added.
- platform/chromium-linux/media/audio-repaint-expected.txt: Added.
- platform/chromium-linux/media/media-document-audio-repaint-expected.checksum: Added.
- platform/chromium-linux/media/media-document-audio-repaint-expected.png: Added.
- platform/chromium-linux/media/media-document-audio-repaint-expected.txt: Added.
- platform/chromium-mac/media/audio-repaint-expected.checksum: Added.
- platform/chromium-mac/media/audio-repaint-expected.png: Added.
- platform/chromium-mac/media/audio-repaint-expected.txt: Added.
- platform/chromium-mac/media/media-document-audio-repaint-expected.checksum: Added.
- platform/chromium-mac/media/media-document-audio-repaint-expected.png: Added.
- platform/chromium-mac/media/media-document-audio-repaint-expected.txt: Added.
- platform/chromium-win/media/audio-repaint-expected.checksum: Added.
- platform/chromium-win/media/audio-repaint-expected.png: Added.
- platform/chromium-win/media/audio-repaint-expected.txt: Added.
- platform/chromium-win/media/media-document-audio-repaint-expected.checksum: Added.
- platform/chromium-win/media/media-document-audio-repaint-expected.png: Added.
- platform/chromium-win/media/media-document-audio-repaint-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 1:19 PM Changeset in webkit [79352] by
-
- 4 edits in trunk/Source
[Qt] Redesign the build system
https://bugs.webkit.org/show_bug.cgi?id=51339
Reviewed by Csaba Osztrogonác.
Move inspector's resource files into the final build step to fix the layout test regression.
Source/WebCore:
No new tests needed.
- WebCore.pro: Move inspector's resource files into QtWebKit.pro.
Source/WebKit/qt:
- QtWebKit.pro: Add inspector's reaource files.
- 1:15 PM Changeset in webkit [79351] by
-
- 2 edits in trunk/LayoutTests
2011-02-22 Martin Robinson <mrobinson@igalia.com>
Add some GTK+-specific expectations for new media tests.
- platform/gtk/Skipped: Unskip tests which now have results.
- 1:06 PM Changeset in webkit [79350] by
-
- 2 edits in trunk/Source/WebCore
2011-02-22 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] fast/frames/iframe-scale-applied-twice.html fails after r79167
https://bugs.webkit.org/show_bug.cgi?id=54990
No new tests. This will cause fast/events/scroll-after-click-on-tab-index.html
to start passing again.
- platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::visibleContentRect): Update this method to match the original in the parent class.
- 1:01 PM Changeset in webkit [79349] by
-
- 6 edits in trunk
2011-01-17 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] fast/events/scroll-after-click-on-tab-index has been failing on the bots
https://bugs.webkit.org/show_bug.cgi?id=49177
- platform/gtk/Skipped: Unskip passing test.
2011-01-17 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] fast/events/scroll-after-click-on-tab-index has been failing on the bots
https://bugs.webkit.org/show_bug.cgi?id=49177
- platform/ScrollView.cpp: Remove the GTK+ guards around the implementation of platformAddChild and platformRemoveChild. This code can be shared.
- platform/gtk/MainFrameScrollbarGtk.cpp: (MainFrameScrollbarGtk::attachAdjustment): Prevent re-attaching an already attached adjustment. Connect the adjustment value-changed signal handler after resetting the adjustment. This prevents the rest from stomping on pre-existing WebCore values. (MainFrameScrollbarGtk::gtkValueChanged): If the scrollbar is no longer attached to a scrollview do not listing for value changes. These scrollbars are defunct.
- platform/gtk/ScrollViewGtk.cpp: Remove duplicated empty methods.
- 1:01 PM Changeset in webkit [79348] by
-
- 11 edits in trunk/Source/WebKit2
2011-02-22 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Grammar correction from Spelling & Grammar window doesn't work
https://bugs.webkit.org/show_bug.cgi?id=54982
<rdar://problem/8940918>
- UIProcess/API/mac/WKView.mm: (-[WKView isGrammarCheckingEnabled]): (-[WKView setGrammarCheckingEnabled:]): Call down to the text checker.
- UIProcess/TextChecker.h: Add updateSpellingUIWithGrammarString.
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::updateSpellingUIWithGrammarString): Call TextChecker::updateSpellingUIWithGrammarString.
- UIProcess/WebPageProxy.messages.in: Add UpdateSpellingUIWithGrammarString message.
- UIProcess/gtk/TextCheckerGtk.cpp: (WebKit::TextChecker::updateSpellingUIWithGrammarString):
- UIProcess/qt/TextCheckerQt.cpp: (WebKit::TextChecker::updateSpellingUIWithGrammarString):
- UIProcess/win/TextCheckerWin.cpp: (WebKit::TextChecker::updateSpellingUIWithGrammarString): Add stubs.
- UIProcess/mac/TextCheckerMac.mm: (WebKit::TextChecker::updateSpellingUIWithGrammarString): Update the spelling panel.
- WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::updateSpellingUIWithGrammarString): Send an UpdateSpellingUIWithGrammarString message to the UI process.
- 12:42 PM Changeset in webkit [79347] by
-
- 3 edits in trunk/Source/WebKit/gtk
2011-02-22 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] position:fixed elements flicker while scrolling after r74196
https://bugs.webkit.org/show_bug.cgi?id=54981
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::ChromeClient): Initialize the new m_pendingScrollInvalidations boolean to false. (WebKit::ChromeClient::invalidateWindow): If this is an immediate invalidation and we having pending scrolling invalidations, instruct GDK to process updates now. (WebKit::ChromeClient::scroll): Remove the call to gdk_window_process_updates. Set m_pendingScrollInvalidations to true to force it to happen in invalidateWindow instead.
- WebCoreSupport/ChromeClientGtk.h: Add new boolean member.
- 12:40 PM Changeset in webkit [79346] by
-
- 4 edits in trunk/LayoutTests
Unreviewed, adding new pixel tests to the skipped list of various platforms.
media/audio-repaint.html flakey.
https://bugs.webkit.org/show_bug.cgi?id=54970
- platform/chromium/test_expectations.txt:
- platform/gtk/Skipped:
- platform/qt/Skipped:
- 12:18 PM Changeset in webkit [79345] by
-
- 20 edits in trunk
2011-02-22 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: refactor InjectedScript : InspectorDOMAgent interaction.
https://bugs.webkit.org/show_bug.cgi?id=54954
- bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::toNode): (WebCore::JSInjectedScriptHost::inspect):
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::toNode): (WebCore::V8InjectedScriptHost::inspectCallback):
- inspector/CodeGeneratorInspector.pm:
- inspector/InjectedScript.cpp: (WebCore::InjectedScript::nodeForObjectId):
- inspector/InjectedScript.h:
- inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::inspect):
- inspector/InjectedScriptHost.h:
- inspector/InjectedScriptHost.idl:
- inspector/InjectedScriptSource.js: (.):
- inspector/Inspector.idl:
- inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::focusNode):
- inspector/InspectorAgent.h:
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::inspect): (WebCore::InspectorDOMAgent::pushNodeToFrontend):
- inspector/InspectorDOMAgent.h:
- inspector/front-end/AuditRules.js: (WebInspector.AuditRules.evaluateInTargetWindow): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.receivedImages): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.pushImageNodes):
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions):
- inspector/front-end/DOMAgent.js: (WebInspector.DOMDispatcher.prototype.childNodeRemoved): (WebInspector.DOMDispatcher.prototype.inspectElementRequested):
- inspector/front-end/RemoteObject.js: (WebInspector.RemoteObject.prototype.pushNodeToFrontend):
- 11:38 AM Changeset in webkit [79344] by
-
- 6 edits in trunk/Source
Part of <rdar://problem/8762042> and https://bugs.webkit.org/show_bug.cgi?id=54514
API to view and delete Application Cache data by origin.
Reviewed by Anders Carlsson.
../WebCore:
Stub these out for now:
- loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::ApplicationCacheStorage::getOriginsWithCache):
(WebCore::ApplicationCacheStorage::deleteEntriesForOrigin):
(WebCore::ApplicationCacheStorage::deleteAllEntries): Moved implementation here from WebKit/Mac
- loader/appcache/ApplicationCacheStorage.h:
Export the new symbols:
- WebCore.exp.in:
../WebKit/mac:
- WebCoreSupport/WebApplicationCache.mm:
(+[WebApplicationCache deleteAllApplicationCaches]): Move this implementation into WebCore itself.
- 11:36 AM Changeset in webkit [79343] by
-
- 2 edits in trunk/Source/WebCore
Fix debug build.
- WebCore.exp.in:
- 11:28 AM Changeset in webkit [79342] by
-
- 2 edits5 deletes in trunk/LayoutTests
2011-02-22 Andrew Wilson <atwilson@chromium.org>
Unreviewed, rolling out r79337.
http://trac.webkit.org/changeset/79337
GPU-only test should have GPU baselines
- platform/chromium-linux/compositing/reflections/deeply-nested-reflections-expected.checksum: Removed.
- platform/chromium-linux/compositing/reflections/deeply-nested-reflections-expected.png: Removed.
- platform/chromium-win/compositing/reflections/deeply-nested-reflections-expected.checksum: Removed.
- platform/chromium-win/compositing/reflections/deeply-nested-reflections-expected.png: Removed.
- platform/chromium-win/compositing/reflections/deeply-nested-reflections-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- 11:19 AM Changeset in webkit [79341] by
-
- 1 copy in releases/WebKitGTK/webkit-1.3.12
Branching for WebKitGTK+ release
- 10:59 AM Changeset in webkit [79340] by
-
- 16 edits in trunk/LayoutTests
2011-02-22 Adrienne Walker <enne@google.com>
Unreviewed rebaseline of some GPU tests.
This cleans up the rest of the BUGWK54409 expectations after r79084.
- platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.checksum:
- platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/fixed-position-expected.checksum:
- platform/chromium-gpu-linux/compositing/geometry/fixed-position-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.checksum:
- platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.checksum:
- platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.png:
- platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.checksum:
- platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.png:
- platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.checksum:
- platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.png:
- platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.checksum:
- platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.png:
- platform/chromium/test_expectations.txt:
- 10:56 AM Changeset in webkit [79339] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Prospectively removing test_expectations entries for some tests that seem to be passing now on the canaries.
- platform/chromium/test_expectations.txt:
- 10:53 AM Changeset in webkit [79338] by
-
- 2 edits in trunk/LayoutTests
Skip a flaky Inspector test on Windows
<http://webkit.org/b/54974> tracks the failure.
- platform/win/Skipped: Added inspector/extensions/extensions-events.html.
- 10:51 AM Changeset in webkit [79337] by
-
- 2 edits8 adds in trunk/LayoutTests
Unreviewed expectations update for deeply-nested-reflections.html
- platform/chromium-linux/compositing/reflections/deeply-nested-reflections-expected.checksum: Added.
- platform/chromium-linux/compositing/reflections/deeply-nested-reflections-expected.png: Added.
- platform/chromium-win/compositing/reflections/deeply-nested-reflections-expected.checksum: Added.
- platform/chromium-win/compositing/reflections/deeply-nested-reflections-expected.png: Added.
- platform/chromium-win/compositing/reflections/deeply-nested-reflections-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 10:47 AM Changeset in webkit [79336] by
-
- 2 edits in trunk/Tools
2011-02-18 Mihai Parparita <mihaip@chromium.org>
Reviewed by Ojan Vafai.
Default to 500 for --exit-after-n-failures
https://bugs.webkit.org/show_bug.cgi?id=54773
Make 500 the default value for --exit-after-n-failures (ORWT bots
already default to this as of r75726). Similarly, change the default for
--exit-after-n-crashes-or-timeouts to 20.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 10:45 AM Changeset in webkit [79335] by
-
- 62 edits1 delete in trunk/Source
notImplemented() should behave identical in WebCore and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=54449
Reviewed by Anders Carlsson.
Source/WebCore:
No functional change so no new tests.
- WebCore.xcodeproj/project.pbxproj: Add NotImplemented.h as private header
to be able to use it in WebKit2.
Source/WebKit2:
Use NotImplemented.h from WebCore. Initialize logging channels.
Remove the WebKit2 concept of notImplemented().
- Platform/gtk/SharedMemoryGtk.cpp:
- Platform/gtk/WorkQueueGtk.cpp:
- Platform/qt/WorkQueueQt.cpp:
- Platform/win/WorkQueueWin.cpp:
- Shared/NotImplemented.h: Removed.
- Shared/Plugins/NPIdentifierData.cpp:
- Shared/Plugins/NPRemoteObjectMap.cpp:
- Shared/Plugins/NPVariantData.cpp:
- Shared/cairo/ShareableBitmapCairo.cpp:
- Shared/gtk/ShareableBitmapGtk.cpp:
- Shared/gtk/WebCoreArgumentCodersGtk.cpp:
- Shared/qt/WebCoreArgumentCodersQt.cpp:
- Shared/win/LayerTreeContextWin.cpp:
- UIProcess/API/mac/PageClientImpl.mm:
- UIProcess/API/qt/qwkpage.cpp:
- UIProcess/Launcher/gtk/ThreadLauncherGtk.cpp:
- UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
- UIProcess/Plugins/gtk/PluginInfoStoreGtk.cpp:
- UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
- UIProcess/WebInspectorProxy.cpp:
- UIProcess/gtk/TextCheckerGtk.cpp:
- UIProcess/gtk/WebInspectorGtk.cpp:
- UIProcess/gtk/WebPreferencesGtk.cpp:
- UIProcess/qt/TextCheckerQt.cpp:
- UIProcess/qt/WebInspectorProxyQt.cpp:
- UIProcess/win/TextCheckerWin.cpp:
- UIProcess/win/WebContextMenuProxyWin.cpp:
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/Downloads/cf/DownloadCFNet.cpp:
- WebProcess/Downloads/curl/DownloadCurl.cpp:
- WebProcess/Downloads/mac/DownloadMac.mm:
- WebProcess/Downloads/qt/DownloadQt.cpp:
- WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp:
- WebProcess/Plugins/Netscape/JSNPMethod.cpp:
- WebProcess/Plugins/Netscape/NPJSObject.cpp:
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
- WebProcess/Plugins/Netscape/gtk/NetscapePluginGtk.cpp:
- WebProcess/Plugins/Netscape/qt/NetscapePluginQt.cpp:
- WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
- WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
- WebProcess/WebCoreSupport/WebDragClient.cpp:
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
- WebProcess/WebCoreSupport/WebInspectorClient.cpp:
- WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
- WebProcess/WebCoreSupport/gtk/WebContextMenuClientGtk.cpp:
- WebProcess/WebCoreSupport/gtk/WebPopupMenuGtk.cpp:
- WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
- WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
- WebProcess/WebCoreSupport/qt/WebContextMenuClientQt.cpp:
- WebProcess/WebPage/gtk/WebInspectorGtk.cpp:
- WebProcess/WebPage/qt/WebInspectorQt.cpp:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
- WebProcess/gtk/WebProcessGtk.cpp:
- config.h:
- win/WebKit2.vcproj:
- 10:41 AM Changeset in webkit [79334] by
-
- 5 edits in trunk/Source
[Qt] Redesign the build system
https://bugs.webkit.org/show_bug.cgi?id=51339
Reviewed by Laszlo Gombos.
Rubber-stamped by Csaba Osztrogonác.
The patch landed in r79320 didn't contain the cleanup
which was already addressed in the last attachment.
Source/WebCore:
No new tests needed.
- WebCore.pri: Add common LIB and CONFIG options.
- WebCore.pro: Add accidentally moved sections.
Source/WebKit/qt:
- QtWebKit.pro: Move common LIB and CONFIG options to WebCore.pri.
- 10:26 AM Changeset in webkit [79333] by
-
- 3 edits in trunk
2011-02-22 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
[GTK] 1.3.12 release preparation
https://bugs.webkit.org/show_bug.cgi?id=54967
Version bump for 1.3.12 and updated NEWS file with release notes.
Also bumped libsoup requirement to 2.33.6 as agreed with Sergio
and Martin.
- Source/WebKit/gtk/NEWS:
- configure.ac:
- 10:24 AM Changeset in webkit [79332] by
-
- 3 edits2 deletes in trunk
2011-02-22 Philippe Normand <pnormand@igalia.com>
Unreviewed, rolling out r79321.
http://trac.webkit.org/changeset/79321
https://bugs.webkit.org/show_bug.cgi?id=53146
Regresses fast/forms/listbox-typeahead-cyrillic.html and fast
/spatial-navigation/snav-single-select.html on GTK
- platform/gtk/accessibility/combo-box-collapsed-selection-changed-expected.txt: Removed.
- platform/gtk/accessibility/combo-box-collapsed-selection-changed.html: Removed.
2011-02-22 Philippe Normand <pnormand@igalia.com>
Unreviewed, rolling out r79321.
http://trac.webkit.org/changeset/79321
https://bugs.webkit.org/show_bug.cgi?id=53146
Regresses fast/forms/listbox-typeahead-cyrillic.html and fast
/spatial-navigation/snav-single-select.html on GTK
- accessibility/gtk/AXObjectCacheAtk.cpp: (WebCore::notifyChildrenSelectionChange): (WebCore::AXObjectCache::postPlatformNotification):
- 10:19 AM Changeset in webkit [79331] by
-
- 2 edits in trunk/Source/WebKit2
Invalidate the WebResourceCacheManagerProxy in WebContext::processDidClose.
Rubber-stamped by Brady Eidson.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::processDidClose):
- 9:45 AM Changeset in webkit [79330] by
-
- 2 edits in trunk
Unreviewed, revert the duplicate ChangeLog entries added in r79307, r79312, r79313 and r79314
- 9:39 AM Changeset in webkit [79329] by
-
- 9 edits in trunk
2011-02-02 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] DRT needs an implementation of LayoutTestController.setSelectTrailingWhitespace
https://bugs.webkit.org/show_bug.cgi?id=53603
- platform/gtk/Skipped: Unskip passing tests.
2011-02-02 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] DRT needs an implementation of LayoutTestController.setSelectTrailingWhitespace
https://bugs.webkit.org/show_bug.cgi?id=53603
Add setSelectTrailingWhitespaceEnabled and selectTrailingWhitespaceEnabled which allow
setting and querying the selectTrailingWhitespaceEnabled setting. EditorClient just
listens to this value during DRT runs. Perhaps later we can expose this to the public
API.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::setSelectTrailingWhitespaceEnabled): Added (DumpRenderTreeSupportGtk::selectTrailingWhitespaceEnabled): Added
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::isSelectTrailingWhitespaceEnabled): Ask DRTSupportGtk for the appropriate return value.
2011-02-02 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] DRT needs an implementation of LayoutTestController.setSelectTrailingWhitespace
https://bugs.webkit.org/show_bug.cgi?id=53603
Add support for LayoutTestController.setSelectTrailingWhitespace by calling through
to DumpRenderTreeSupportGtk for this functionality.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): Always call LayoutTestController.setSelectTrailingWhitespace to false when reseting values between tests.
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setSelectTrailingWhitespaceEnabled): Call LayoutTestController.setSelectTrailingWhitespace with the appropriate value.
- 9:16 AM Changeset in webkit [79328] by
-
- 1 edit2 adds in trunk/LayoutTests
Add Windows expected failure results for new tests from r79318
<http://webkit.org/b/54966> tracks the failure.
- platform/win/media/audio-repaint-expected.txt: Added.
- platform/win/media/media-document-audio-repaint-expected.txt: Added.
- 8:08 AM Changeset in webkit [79327] by
-
- 3 edits in trunk/Tools
Don't trigger a Windows build when the top-level ChangeLog changes
r79320 is an example of a change that shouldn't have built on Windows, but did, because of
this bug.
Fixes <http://webkit.org/b/54957> Windows bots build when top-level ChangeLog changes, but
shouldn't
Reviewed by Anders Carlsson.
- Scripts/webkitpy/common/config/build.py:
(_should_file_trigger_build): Modified the ChangeLog pattern to match the top-level
ChangeLog, and re-sorted it in the list.
- Scripts/webkitpy/common/config/build_unittest.py:
(ShouldBuildTest): Added a test that ChangeLogs don't trigger builds.
- 8:07 AM Changeset in webkit [79326] by
-
- 3 edits in trunk/Source/WebKit2
Make DrawingAreaProxyImpl keep track of the most recent state ID it sent to the web process
This will be useful for sending repeated messages for the same state ID to the web process.
We don't do this currently, but will need to if we're asked to paint after we've thrown away
our backing store to save memory.
Fixes <http://webkit.org/b/54916> DrawingAreaProxyImpl should keep track of the state ID it
last sent to the web process
Reviewed by Anders Carlsson.
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl): Initialize m_requestedStateID, and
reordered member initialization to match the new declaration order.
(WebKit::DrawingAreaProxyImpl::didUpdateState): Added an assertion that the stateID we got
from the web process is no newer than the most recent one we requested.
(WebKit::DrawingAreaProxyImpl::sendUpdateState): Changed to increment and send
m_requestedStateID instead of a new global stateID.
- UIProcess/DrawingAreaProxyImpl.h: Added m_requestedStateID, and moved the state IDs before
other data members. Also beefed the comment explaining m_currentStateID.
- 8:01 AM Changeset in webkit [79325] by
-
- 3 edits in trunk/Source/WebCore
2011-02-22 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Inspector.IDL change. rename attribute notify -> event.
https://bugs.webkit.org/show_bug.cgi?id=54958
- inspector/CodeGeneratorInspector.pm:
- inspector/Inspector.idl:
- 7:44 AM Changeset in webkit [79324] by
-
- 3 edits in trunk/Tools
2011-02-22 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r78691.
http://trac.webkit.org/changeset/78691
https://bugs.webkit.org/show_bug.cgi?id=54956
Leopard Debug is successfully building again (Requested by
aroben on #webkit).
- Scripts/webkitpy/common/net/buildbot/buildbot.py:
- Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
- 7:32 AM Changeset in webkit [79323] by
-
- 16 edits in trunk
2011-02-22 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Timeline agent should have same lifetime as InspectorAgent
https://bugs.webkit.org/show_bug.cgi?id=54951
- inspector/timeline/timeline-network-resource.html:
- inspector/timeline/timeline-script-tag-1.html:
- inspector/timeline/timeline-script-tag-2.html:
- inspector/timeline/timeline-test.js: (initialize_Timeline.InspectorTest.performActionsAndPrint.step2):
- inspector/timeline/timeline-trivial.html:
2011-02-22 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Timeline agent should have same lifetime as InspectorAgent
https://bugs.webkit.org/show_bug.cgi?id=54951
- inspector/CodeGeneratorInspector.pm:
- inspector/Inspector.idl:
- inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::restoreInspectorStateFromCookie): (WebCore::InspectorAgent::setFrontend): (WebCore::InspectorAgent::disconnectFrontend): (WebCore::InspectorAgent::releaseFrontendLifetimeAgents): (WebCore::InspectorAgent::didCommitLoad): (WebCore::InspectorAgent::domContentLoadedEventFired): (WebCore::InspectorAgent::loadEventFired):
- inspector/InspectorAgent.h:
- inspector/InspectorController.cpp: (WebCore::InspectorController::startTimelineProfiler): (WebCore::InspectorController::stopTimelineProfiler): (WebCore::InspectorController::timelineProfilerEnabled):
- inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::retrieveTimelineAgent):
- inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::~InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::setFrontend): (WebCore::InspectorTimelineAgent::clearFrontend): (WebCore::InspectorTimelineAgent::restore): (WebCore::InspectorTimelineAgent::startTimelineProfiler): (WebCore::InspectorTimelineAgent::stopTimelineProfiler): (WebCore::InspectorTimelineAgent::timelineProfilerStarted): (WebCore::InspectorTimelineAgent::didCommitLoad): (WebCore::InspectorTimelineAgent::InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::clearRecordStack):
- inspector/InspectorTimelineAgent.h: (WebCore::InspectorTimelineAgent::create):
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked):
- 7:28 AM Changeset in webkit [79322] by
-
- 14 edits2 deletes in trunk
2011-02-22 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by NOBODY (OOPS!).
Web Inspector: flakyness of inspector tests.
https://bugs.webkit.org/show_bug.cgi?id=54729
As far as we have the protocol with sequence numbers we can simplify test harness support
and drop out chomium specific methods.
Source/WebCore:
- inspector/CodeGeneratorInspector.pm:
- inspector/front-end/TestController.js: (WebInspector.TestController): (WebInspector.TestController.prototype.notifyDone): (WebInspector.TestController.prototype.runAfterPendingDispatches): (WebInspector.TestController.prototype._evaluateForTestInFrontend):
- inspector/front-end/inspector.js: (WebInspector.dispatch):
Source/WebKit/chromium:
- src/js/DevTools.js:
LayoutTests:
- http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.runAfterPendingDispatches):
Tools:
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/chromium/DRTDevToolsAgent.cpp: (DRTDevToolsAgent::sendMessageToInspectorFrontend): (DRTDevToolsAgent::runtimePropertyChanged): (DRTDevToolsAgent::asyncCall): (DRTDevToolsAgent::call):
- DumpRenderTree/chromium/DRTDevToolsAgent.h:
- DumpRenderTree/chromium/DRTDevToolsCallArgs.cpp: Removed.
- DumpRenderTree/chromium/DRTDevToolsCallArgs.h: Removed.
- DumpRenderTree/chromium/DRTDevToolsClient.cpp: (DRTDevToolsClient::sendMessageToBackend): (DRTDevToolsClient::asyncCall): (DRTDevToolsClient::call):
- DumpRenderTree/chromium/DRTDevToolsClient.h:
- 7:26 AM Changeset in webkit [79321] by
-
- 3 edits2 adds in trunk
2011-02-22 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Combo boxes should emit object:selection-changed even when collapsed
https://bugs.webkit.org/show_bug.cgi?id=53146
New GTK-specific layout test to check the right signals are emitted.
- platform/gtk/accessibility/combo-box-collapsed-selection-changed-expected.txt: Added.
- platform/gtk/accessibility/combo-box-collapsed-selection-changed.html: Added.
2011-02-22 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Combo boxes should emit object:selection-changed even when collapsed
https://bugs.webkit.org/show_bug.cgi?id=53146
Emit the selection-changed signals when the menu list value has changed
Test: platform/gtk/accessibility/combo-box-collapsed-selection-changed.html
- accessibility/gtk/AXObjectCacheAtk.cpp: (WebCore::getListObject): New, return the right list object for menu lists and list boxes. (WebCore::notifyChildrenSelectionChange): Support menu lists. (WebCore::AXObjectCache::postPlatformNotification): Call function notifyChildrenSelectionChange for AXMenuListValueChanged.
- 7:14 AM Changeset in webkit [79320] by
-
- 14 edits1 add in trunk
2011-02-22 Andras Becsi <abecsi@webkit.org>
Reviewed by Laszlo Gombos.
[Qt] Redesign the build system
https://bugs.webkit.org/show_bug.cgi?id=51339
Part 2.
Build WebCore as a static library, compile the WebKit API and WebKit2 API
in a final step and link to WebKit2, WebCore and JSC libraries to fix
linking issues resulting from stripped away symbols.
- Source/WebKit.pri: Add common include paths
- Source/WebKit.pro: Add new project file to SUBDIRS
2011-02-22 Andras Becsi <abecsi@webkit.org>
Reviewed by Laszlo Gombos.
[Qt] Redesign the build system
https://bugs.webkit.org/show_bug.cgi?id=51339
Part 2.
Build WebCore as a static library, compile the WebKit API and WebKit2 API
in a final step and link to WebKit2, WebCore and JSC libraries to fix
linking issues resulting from stripped away symbols.
- WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Remove superfluous includepaths.
2011-02-22 Andras Becsi <abecsi@webkit.org>
Reviewed by Laszlo Gombos.
[Qt] Redesign the build system
https://bugs.webkit.org/show_bug.cgi?id=51339
Part 2.
Build WebCore as a static library, compile the WebKit API and WebKit2 API
in a final step and link to WebKit2, WebCore and JSC libraries to fix
linking issues resulting from stripped away symbols.
- JavaScriptCore.pri: Remove the workaround.
2011-02-22 Andras Becsi <abecsi@webkit.org>
Reviewed by Laszlo Gombos.
[Qt] Redesign the build system
https://bugs.webkit.org/show_bug.cgi?id=51339
Part 2.
Build WebCore as a static library, compile the WebKit API and WebKit2 API
in a final step and link to WebKit2, WebCore and JSC libraries to fix
linking issues resulting from stripped away symbols.
- QtWebKit.pro: Added. Project file for the final build step.
2011-02-22 Andras Becsi <abecsi@webkit.org>
Reviewed by Laszlo Gombos.
[Qt] Redesign the build system
https://bugs.webkit.org/show_bug.cgi?id=51339
Part 2.
Build WebCore as a static library, compile the WebKit API and WebKit2 API
in a final step and link to WebKit2, WebCore and JSC libraries to fix
linking issues resulting from stripped away symbols.
No new tests needed.
- WebCore.pri: Add needed rules for handling the static library.
- WebCore.pro: Reorganize API and linker options to QtWebKit.pro.
2011-02-22 Andras Becsi <abecsi@webkit.org>
Reviewed by Laszlo Gombos.
[Qt] Redesign the build system
https://bugs.webkit.org/show_bug.cgi?id=51339
Part 2.
Build WebCore as a static library, compile the WebKit API and WebKit2 API
in a final step and link to WebKit2, WebCore and JSC libraries to fix
linking issues resulting from stripped away symbols.
- WebKit2.pri: Add include paths.
- WebKit2.pro: Move include paths to WebKit2.pri and move the API source to WebKit/qt/QtWebKit.pro
- 7:09 AM Changeset in webkit [79319] by
-
- 4 edits in trunk/Source/WebCore
2011-02-22 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [REGRESSION] navigation does not work when inspector is opened.
https://bugs.webkit.org/show_bug.cgi?id=54947
- inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
- inspector/InspectorState.cpp: (WebCore::InspectorState::loadFromCookie):
- inspector/InspectorState.h:
- 7:07 AM Changeset in webkit [79318] by
-
- 3 edits8 adds in trunk
2011-02-15 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
Built-in HTML5 <audio> (and sometimes <video>) UI doesn't update playhead location or time displays
https://bugs.webkit.org/show_bug.cgi?id=46142
Added a repaint test which ensures the timeline controls repaint in an audio-only MediaDocument. Since
the change also affects in-page audio, also added a repaint test for those cases as well.
Other platforms will need to have results generated.
- media/audio-repaint.html: Added.
- media/media-document-audio-repaint-expected.txt: Added.
- media/media-document-audio-repaint.html: Added.
- platform/mac/media/audio-repaint-expected.checksum: Added.
- platform/mac/media/audio-repaint-expected.png: Added.
- platform/mac/media/audio-repaint-expected.txt: Added.
- platform/mac/media/media-document-audio-repaint-expected.checksum: Added.
- platform/mac/media/media-document-audio-repaint-expected.png: Added.
2011-02-15 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
Built-in HTML5 <audio> (and sometimes <video>) UI doesn't update playhead location or time displays
https://bugs.webkit.org/show_bug.cgi?id=46142
Push a LayoutStateMaintainer in RenderMedia::layout() before calling layout() on the
container elements. This is necessary because, during layout(), the child renderers
query the current LayoutState to determine where they will be repainting. If a new
LayoutState is not pushed here, child renderers will attempt to repaint relative to
their grandparent's origin instead of their parents', and repaint operations will fail.
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::layout):
- 6:49 AM Changeset in webkit [79317] by
-
- 2 edits in trunk/Source/WebCore
2011-02-22 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Cleaning: remove a overzealous check for the pointer "files" from Chrome::setToolTip()
https://bugs.webkit.org/show_bug.cgi?id=54952
Remove the unnecessary condition from the if(), HTMLInputElement::files() always return
a valid reference for the input type FileInputType.
- page/Chrome.cpp: (WebCore::Chrome::setToolTip):
- 5:25 AM Changeset in webkit [79316] by
-
- 6 edits in trunk/Source/WebKit2
2011-02-22 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] [WK2] Improve the memory handling of the context menu for WebKit 2
https://bugs.webkit.org/show_bug.cgi?id=54902
Refactor the context menu handling of Qt to make it simpler to manage memory.
WebContextMenuProxyQt uses smart pointer for all the references to menu so
there is no need to delete it explicitely.
Passing the QMenu from QWKPage to the client of the signal now uses a QSharedPointer so
the client can choose to handle the memory, but there is no leak if it does not.
- UIProcess/API/qt/qgraphicswkview.cpp: (QGraphicsWKView::QGraphicsWKView): (QGraphicsWKView::showContextMenu):
- UIProcess/API/qt/qgraphicswkview.h:
- UIProcess/API/qt/qwkpage.h:
- UIProcess/qt/WebContextMenuProxyQt.cpp: (WebKit::WebContextMenuProxyQt::showContextMenu): (WebKit::WebContextMenuProxyQt::createContextMenu):
- UIProcess/qt/WebContextMenuProxyQt.h:
- 5:20 AM Changeset in webkit [79315] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
2011-02-22 Philippe Normand <pnormand@igalia.com>
Unreviewed, skip crashing inspector test on GTK
- platform/gtk/Skipped: Skip http/tests/inspector-enabled/open-close-open.html
- 5:20 AM Changeset in webkit [79314] by
-
- 1 edit in trunk/Source/WebCore/ChangeLog
2011-02-22 Philippe Normand <pnormand@igalia.com>
Reviewed by Xan Lopez.
[GTK] make distcheck fails
https://bugs.webkit.org/show_bug.cgi?id=54943
Added new headers and removed references to deleted files.
- GNUmakefile.am:
2011-02-22 Philippe Normand <pnormand@igalia.com>
Reviewed by Xan Lopez.
[GTK] make distcheck fails
https://bugs.webkit.org/show_bug.cgi?id=54943
Removed reference to NotImplemented.h which was removed.
- GNUmakefile.am:
- 5:20 AM Changeset in webkit [79313] by
-
- 1 edit in trunk/Source/WebCore/ChangeLog
2011-02-22 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: provide a button to expand inspector toolbar when not all panel buttons fit
https://bugs.webkit.org/show_bug.cgi?id=54671
- factored toolbar handling out of inspector.js
- added toolbar dropdown
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onCreatePanel):
- inspector/front-end/Panel.js: (WebInspector.Panel.prototype.get toolbarItem):
- inspector/front-end/Toolbar.js: Added. (WebInspector.Toolbar): (WebInspector.Toolbar.prototype.resize): (WebInspector.Toolbar.prototype.addPanel): (WebInspector.Toolbar.prototype._toolbarDragStart): (WebInspector.Toolbar.prototype._toolbarDragEnd): (WebInspector.Toolbar.prototype._toolbarDrag): (WebInspector.Toolbar.prototype._onClose): (WebInspector.Toolbar.prototype._setDropdownVisible): (WebInspector.Toolbar.prototype._toggleDropdown): (WebInspector.Toolbar.prototype._updateDropdownButtonAndHideDropdown): (WebInspector.Toolbar.createPanelToolbarItem.onToolbarItemClicked): (WebInspector.Toolbar.createPanelToolbarItem): (WebInspector.ToolbarDropdown): (WebInspector.ToolbarDropdown.prototype.show): (WebInspector.ToolbarDropdown.prototype.hide): (WebInspector.ToolbarDropdown.prototype.get visible): (WebInspector.ToolbarDropdown.prototype._populate): (WebInspector.ToolbarDropdown.prototype._onKeyDown):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.css: (#toolbar): (.toolbar-item): (.toolbar-item.toggleable): (.toolbar-item.toggleable.toggled-on): (#toolbar-dropdown .toolbar-icon): (#toolbar-dropdown .toolbar-label): (#toolbar-controls): (#toolbar-dropdown-arrow): (body.attached #toolbar-dropdown-arrow): (#toolbar-dropdown-arrow.dropdown-visible): (#toolbar-dropdown-arrow:hover): (#toolbar-dropdown-arrow:active): (#toolbar-dropdown): (body.detached.platform-mac-snowleopard #toolbar-dropdown): (#toolbar-dropdown .scrollable-content): (#toolbar-dropdown .toolbar-item): (#toolbar-dropdown .toolbar-item.toggleable.toggled-on): (#toolbar-dropdown .toolbar-icon): (#toolbar-dropdown .toolbar-label): (#toolbar-controls): (#toolbar-dropdown-arrow): (body.attached #toolbar-dropdown-arrow): (#toolbar-dropdown-arrow.dropdown-visible): (#toolbar-dropdown-arrow:hover): (#toolbar-dropdown-arrow:active): (#toolbar-dropdown): (body.detached.platform-mac-snowleopard #toolbar-dropdown): (#toolbar-dropdown .scrollable-content): (#toolbar-dropdown .toolbar-item): (#toolbar-dropdown .toolbar-item.toggleable.toggled-on): (#toolbar-dropdown .toolbar-item:hover): (#toolbar-dropdown .toolbar-item.toggleable.toggled-on:hover): (#toolbar-dropdown .toolbar-item:active .toolbar-icon): (.scrollable-content): (.scrollable-content::-webkit-scrollbar): (.scrollable-content::-webkit-resizer): (.scrollable-content::-webkit-scrollbar-thumb:vertical): (.scrollable-content::-webkit-scrollbar-thumb:vertical:active): (.scrollable-content::-webkit-scrollbar-track:vertical): (.toolbar-search-item): (#search): (body.attached #search): (#search-results-matches): (#close-button-left, #close-button-right): (.close-left):
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js: (WebInspector.set attached): (WebInspector.addPanel): (WebInspector.windowResize):
- 5:20 AM Changeset in webkit [79312] by
-
- 2 edits in trunk
Unreviewed.
[Qt] Add Qt specific expected results for passing tables/mozilla tests.
- platform/qt/Skipped: Unskip passing tests.
- platform/qt/tables/mozilla [...] : Added.
- 5:17 AM Changeset in webkit [79311] by
-
- 11 edits3 adds in trunk
2011-02-21 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: move source mapping from SourceFrame to ScriptsPanel.
https://bugs.webkit.org/show_bug.cgi?id=54645
- http/tests/inspector/debugger-test.js: (initialize_DebuggerTest.InspectorTest.runDebuggerTestSuite.createWrapper.return.try): (initialize_DebuggerTest.InspectorTest.runDebuggerTestSuite): (initialize_DebuggerTest.InspectorTest.showScriptSource):
- inspector/debugger/source-frame-expected.txt: Added.
- inspector/debugger/source-frame.html: Added.
2011-02-21 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: extract source mapping from SourceFrame to DebuggerPresentationModel.
https://bugs.webkit.org/show_bug.cgi?id=54645
This is needed to map one script to several source files.
Test: inspector/debugger/source-frame.html
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/DebuggerPresentationModel.js: Added. (WebInspector.DebuggerPresentationModel): (WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceName): (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded): (WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved): (WebInspector.DebuggerPresentationModel.prototype._breakpointResolved): (WebInspector.DebuggerPresentationModel.prototype._encodeSourceLocation): (WebInspector.DebuggerPresentationModel.prototype._actualLocationToSourceLocation):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._breakpointAdded): (WebInspector.ScriptsPanel.prototype._breakpointRemoved): (WebInspector.ScriptsPanel.prototype._sourceFrameForResource): (WebInspector.ScriptsPanel.prototype._sourceFrameForScript): (WebInspector.ScriptsPanel.prototype._addSourceFrame): (WebInspector.ScriptsPanel.prototype._removeSourceFrame): (WebInspector.ScriptsPanel.prototype._sourceFrameLoaded): (WebInspector.ScriptsPanel.prototype._clearCurrentExecutionLine): (WebInspector.ScriptsPanel.prototype._callFrameSelected): (WebInspector.SourceFrameContentProviderForScript.prototype._buildSource):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.get loaded): (WebInspector.SourceFrame.prototype._createTextViewer): (WebInspector.SourceFrame.prototype._setTextViewerDecorations): (WebInspector.SourceFrame.prototype.setExecutionLine): (WebInspector.SourceFrame.prototype.clearExecutionLine): (WebInspector.SourceFrame.prototype.addBreakpoint): (WebInspector.SourceFrame.prototype.removeBreakpoint): (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint.didEditBreakpointCondition): (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint): (WebInspector.SourceFrame.prototype._findBreakpoint.filter): (WebInspector.SourceFrame.prototype._findBreakpoint):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
2011-02-21 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: move source mapping from SourceFrame to ScriptsPanel.
https://bugs.webkit.org/show_bug.cgi?id=54645
- src/js/Tests.js: (.TestSuite.prototype._checkExecutionLine):
- 5:11 AM Changeset in webkit [79310] by
-
- 2 edits in trunk/LayoutTests
2011-02-22 Philippe Normand <pnormand@igalia.com>
Unreviewed, GTK rebaseline of fast/forms/placeholder-position.html
- platform/gtk/fast/forms/placeholder-position-expected.txt:
- 5:08 AM Changeset in webkit [79309] by
-
- 2 edits in trunk/LayoutTests
2011-02-22 Philippe Normand <pnormand@igalia.com>
Unreviewed, GTK rebaseline of media/video-aspect-ratio.html
- platform/gtk/media/video-aspect-ratio-expected.txt:
- 5:06 AM Changeset in webkit [79308] by
-
- 2 edits in trunk/LayoutTests
2011-02-22 Philippe Normand <pnormand@igalia.com>
Unreviewed, skip crashing inspector test on GTK
- platform/gtk/Skipped: Skip http/tests/inspector-enabled/open-close-open.html
- 5:05 AM Changeset in webkit [79307] by
-
- 1 edit in trunk/Source/WebCore/ChangeLog
2011-02-22 Philippe Normand <pnormand@igalia.com>
Reviewed by Xan Lopez.
[GTK] make distcheck fails
https://bugs.webkit.org/show_bug.cgi?id=54943
Added new headers and removed references to deleted files.
- GNUmakefile.am:
2011-02-22 Philippe Normand <pnormand@igalia.com>
Reviewed by Xan Lopez.
[GTK] make distcheck fails
https://bugs.webkit.org/show_bug.cgi?id=54943
Removed reference to NotImplemented.h which was removed.
- GNUmakefile.am:
- 4:16 AM Changeset in webkit [79306] by
-
- 9 edits1 add in trunk/Source/WebCore
2011-02-22 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: provide a button to expand inspector toolbar when not all panel buttons fit
https://bugs.webkit.org/show_bug.cgi?id=54671
- factored toolbar handling out of inspector.js
- added toolbar dropdown
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onCreatePanel):
- inspector/front-end/Panel.js: (WebInspector.Panel.prototype.get toolbarItem):
- inspector/front-end/Toolbar.js: Added. (WebInspector.Toolbar): (WebInspector.Toolbar.prototype.resize): (WebInspector.Toolbar.prototype.addPanel): (WebInspector.Toolbar.prototype._toolbarDragStart): (WebInspector.Toolbar.prototype._toolbarDragEnd): (WebInspector.Toolbar.prototype._toolbarDrag): (WebInspector.Toolbar.prototype._onClose): (WebInspector.Toolbar.prototype._setDropdownVisible): (WebInspector.Toolbar.prototype._toggleDropdown): (WebInspector.Toolbar.prototype._updateDropdownButtonAndHideDropdown): (WebInspector.Toolbar.createPanelToolbarItem.onToolbarItemClicked): (WebInspector.Toolbar.createPanelToolbarItem): (WebInspector.ToolbarDropdown): (WebInspector.ToolbarDropdown.prototype.show): (WebInspector.ToolbarDropdown.prototype.hide): (WebInspector.ToolbarDropdown.prototype.get visible): (WebInspector.ToolbarDropdown.prototype._populate): (WebInspector.ToolbarDropdown.prototype._onKeyDown):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.css: (#toolbar): (.toolbar-item): (.toolbar-item.toggleable): (.toolbar-item.toggleable.toggled-on): (#toolbar-dropdown .toolbar-icon): (#toolbar-dropdown .toolbar-label): (#toolbar-controls): (#toolbar-dropdown-arrow): (body.attached #toolbar-dropdown-arrow): (#toolbar-dropdown-arrow.dropdown-visible): (#toolbar-dropdown-arrow:hover): (#toolbar-dropdown-arrow:active): (#toolbar-dropdown): (body.detached.platform-mac-snowleopard #toolbar-dropdown): (#toolbar-dropdown .scrollable-content): (#toolbar-dropdown .toolbar-item): (#toolbar-dropdown .toolbar-item.toggleable.toggled-on): (#toolbar-dropdown .toolbar-icon): (#toolbar-dropdown .toolbar-label): (#toolbar-controls): (#toolbar-dropdown-arrow): (body.attached #toolbar-dropdown-arrow): (#toolbar-dropdown-arrow.dropdown-visible): (#toolbar-dropdown-arrow:hover): (#toolbar-dropdown-arrow:active): (#toolbar-dropdown): (body.detached.platform-mac-snowleopard #toolbar-dropdown): (#toolbar-dropdown .scrollable-content): (#toolbar-dropdown .toolbar-item): (#toolbar-dropdown .toolbar-item.toggleable.toggled-on): (#toolbar-dropdown .toolbar-item:hover): (#toolbar-dropdown .toolbar-item.toggleable.toggled-on:hover): (#toolbar-dropdown .toolbar-item:active .toolbar-icon): (.scrollable-content): (.scrollable-content::-webkit-scrollbar): (.scrollable-content::-webkit-resizer): (.scrollable-content::-webkit-scrollbar-thumb:vertical): (.scrollable-content::-webkit-scrollbar-thumb:vertical:active): (.scrollable-content::-webkit-scrollbar-track:vertical): (.toolbar-search-item): (#search): (body.attached #search): (#search-results-matches): (#close-button-left, #close-button-right): (.close-left):
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js: (WebInspector.set attached): (WebInspector.addPanel): (WebInspector.windowResize):
- 4:12 AM Changeset in webkit [79305] by
-
- 359 edits737 adds in trunk/LayoutTests
Unreviewed.
[Qt] Add Qt specific expected results for passing tables/mozilla tests.
- platform/qt/Skipped: Unskip passing tests.
- platform/qt/tables/mozilla [...] : Added.
- 3:11 AM Changeset in webkit [79304] by
-
- 4 edits in trunk/Source
2011-02-22 Philippe Normand <pnormand@igalia.com>
Reviewed by Xan Lopez.
[GTK] make distcheck fails
https://bugs.webkit.org/show_bug.cgi?id=54943
Added new headers and removed references to deleted files.
- GNUmakefile.am:
2011-02-22 Philippe Normand <pnormand@igalia.com>
Reviewed by Xan Lopez.
[GTK] make distcheck fails
https://bugs.webkit.org/show_bug.cgi?id=54943
Removed reference to NotImplemented.h which was removed.
- GNUmakefile.am:
- 1:34 AM Changeset in webkit [79303] by
-
- 8 edits in trunk/Source/WebCore
2011-02-21 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: make DOM storage and Database agents have the same lifetime as InspectorAgent
https://bugs.webkit.org/show_bug.cgi?id=54891
- inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::setFrontend): (WebCore::InspectorAgent::disconnectFrontend): (WebCore::InspectorAgent::createFrontendLifetimeAgents): (WebCore::InspectorAgent::releaseFrontendLifetimeAgents): (WebCore::InspectorAgent::didCommitLoad):
- inspector/InspectorAgent.h: (WebCore::InspectorAgent::instrumentingAgents):
- inspector/InspectorDOMStorageAgent.cpp: (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent): (WebCore::InspectorDOMStorageAgent::~InspectorDOMStorageAgent): (WebCore::InspectorDOMStorageAgent::setFrontend): (WebCore::InspectorDOMStorageAgent::clearFrontend): (WebCore::InspectorDOMStorageAgent::selectDOMStorage): (WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId): (WebCore::InspectorDOMStorageAgent::didUseDOMStorage): (WebCore::InspectorDOMStorageAgent::clearResources):
- inspector/InspectorDOMStorageAgent.h: (WebCore::InspectorDOMStorageAgent::create):
- inspector/InspectorDatabaseAgent.cpp: (WebCore::InspectorDatabaseAgent::didOpenDatabase): (WebCore::InspectorDatabaseAgent::clearResources): (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent): (WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent): (WebCore::InspectorDatabaseAgent::setFrontend): (WebCore::InspectorDatabaseAgent::clearFrontend): (WebCore::InspectorDatabaseAgent::databaseForId): (WebCore::InspectorDatabaseAgent::selectDatabase):
- inspector/InspectorDatabaseAgent.h: (WebCore::InspectorDatabaseAgent::create):
- inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didOpenDatabaseImpl): (WebCore::InspectorInstrumentation::didUseDOMStorageImpl):
- 1:12 AM Changeset in webkit [79302] by
-
- 2 edits in trunk/Source/WebKit2
2011-02-22 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] QtWebProcess should be installed with 'make install'
https://bugs.webkit.org/show_bug.cgi?id=44100
Follow the standard in other project files and allow install
location to be changed with INSTALL_BINS variable.
- WebProcess.pro: Install QtWebProcess.
- 1:03 AM Changeset in webkit [79301] by
-
- 10 edits in trunk/Source/WebCore
2011-02-22 Steve Lacey <sjl@chromium.org>
Reviewed by Darin Fisher.
Rename new media statistics apis to better names
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::webkitAudioDecodedByteCount): (WebCore::HTMLMediaElement::webkitVideoDecodedByteCount):
- html/HTMLMediaElement.h:
- html/HTMLMediaElement.idl:
- html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::webkitDecodedFrameCount): (WebCore::HTMLVideoElement::webkitDroppedFrameCount):
- html/HTMLVideoElement.h:
- html/HTMLVideoElement.idl:
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::decodedFrameCount): (WebCore::MediaPlayer::droppedFrameCount): (WebCore::MediaPlayer::audioDecodedByteCount): (WebCore::MediaPlayer::videoDecodedByteCount):
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::decodedFrameCount): (WebCore::MediaPlayerPrivateInterface::droppedFrameCount): (WebCore::MediaPlayerPrivateInterface::audioDecodedByteCount): (WebCore::MediaPlayerPrivateInterface::videoDecodedByteCount):
- 12:41 AM Changeset in webkit [79300] by
-
- 2 edits in trunk/LayoutTests
2011-02-22 MORITA Hajime <morrita@google.com>
Unreviewed test_expectation.txt update.
Removed more BUGWK54736 lines which are no longer failed.
- platform/chromium/test_expectations.txt:
- 12:32 AM Changeset in webkit [79299] by
-
- 2 edits in trunk/LayoutTests
2011-02-22 MORITA Hajime <morrita@google.com>
Unreviewed test_expectation.txt update.
Mark styles-update-from-js.html as flaky.
- platform/chromium/test_expectations.txt:
- 12:23 AM Changeset in webkit [79298] by
-
- 2 edits in trunk/Source/WebCore
2011-02-21 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Kent Tamura.
Bug 54435 - Simplify CSSStyleSelector::canShareStyleWithElement
https://bugs.webkit.org/show_bug.cgi?id=54435
Changed the function to a series of early-exit 'if's,
removed most temporary variables.
No new tests. (refactoring)
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithElement):
- 12:18 AM Changeset in webkit [79297] by
-
- 60 edits1 copy in trunk/Source/WebKit2
Unreviewed, rolling out r79296.
http://trac.webkit.org/changeset/79296
https://bugs.webkit.org/show_bug.cgi?id=54941
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-02-22
Breaks compilation on SnowLeapard Intel Release (Requested by
kbalazs_ on #webkit).
- Platform/gtk/SharedMemoryGtk.cpp:
- Platform/gtk/WorkQueueGtk.cpp:
- Platform/qt/WorkQueueQt.cpp:
- Platform/win/WorkQueueWin.cpp:
- Shared/NotImplemented.h: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
- Shared/Plugins/NPIdentifierData.cpp:
- Shared/Plugins/NPRemoteObjectMap.cpp:
- Shared/Plugins/NPVariantData.cpp:
- Shared/cairo/ShareableBitmapCairo.cpp:
- Shared/gtk/ShareableBitmapGtk.cpp:
- Shared/gtk/WebCoreArgumentCodersGtk.cpp:
- Shared/qt/WebCoreArgumentCodersQt.cpp:
- Shared/win/LayerTreeContextWin.cpp:
- UIProcess/API/mac/PageClientImpl.mm:
- UIProcess/API/qt/qwkpage.cpp:
- UIProcess/Launcher/gtk/ThreadLauncherGtk.cpp:
- UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
- UIProcess/Plugins/gtk/PluginInfoStoreGtk.cpp:
- UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
- UIProcess/WebInspectorProxy.cpp:
- UIProcess/gtk/TextCheckerGtk.cpp:
- UIProcess/gtk/WebInspectorGtk.cpp:
- UIProcess/gtk/WebPreferencesGtk.cpp:
- UIProcess/qt/TextCheckerQt.cpp:
- UIProcess/qt/WebInspectorProxyQt.cpp:
- UIProcess/win/TextCheckerWin.cpp:
- UIProcess/win/WebContextMenuProxyWin.cpp:
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/Downloads/cf/DownloadCFNet.cpp:
- WebProcess/Downloads/curl/DownloadCurl.cpp:
- WebProcess/Downloads/mac/DownloadMac.mm:
- WebProcess/Downloads/qt/DownloadQt.cpp:
- WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp:
- WebProcess/Plugins/Netscape/JSNPMethod.cpp:
- WebProcess/Plugins/Netscape/NPJSObject.cpp:
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
- WebProcess/Plugins/Netscape/gtk/NetscapePluginGtk.cpp:
- WebProcess/Plugins/Netscape/qt/NetscapePluginQt.cpp:
- WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
- WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
- WebProcess/WebCoreSupport/WebDragClient.cpp:
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
- WebProcess/WebCoreSupport/WebInspectorClient.cpp:
- WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
- WebProcess/WebCoreSupport/gtk/WebContextMenuClientGtk.cpp:
- WebProcess/WebCoreSupport/gtk/WebPopupMenuGtk.cpp:
- WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
- WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
- WebProcess/WebCoreSupport/qt/WebContextMenuClientQt.cpp:
- WebProcess/WebPage/gtk/WebInspectorGtk.cpp:
- WebProcess/WebPage/qt/WebInspectorQt.cpp:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
- WebProcess/gtk/WebProcessGtk.cpp:
- config.h:
- win/WebKit2.vcproj:
Feb 21, 2011:
- 11:42 PM Changeset in webkit [79296] by
-
- 60 edits1 delete in trunk/Source/WebKit2
notImplemented() should behave identical in WebCore and WebKit2 https://bugs.webkit.org/show_bug.cgi?id=54449
Reviewed by Anders Carlsson.
Use NotImplemented.h from WebCore. Initialize logging channels.
Remove the WebKit2 concept of notImplemented().
- Platform/gtk/SharedMemoryGtk.cpp:
- Platform/gtk/WorkQueueGtk.cpp:
- Platform/qt/WorkQueueQt.cpp:
- Platform/win/WorkQueueWin.cpp:
- Shared/NotImplemented.h: Removed.
- Shared/Plugins/NPIdentifierData.cpp:
- Shared/Plugins/NPRemoteObjectMap.cpp:
- Shared/Plugins/NPVariantData.cpp:
- Shared/cairo/ShareableBitmapCairo.cpp:
- Shared/gtk/ShareableBitmapGtk.cpp:
- Shared/gtk/WebCoreArgumentCodersGtk.cpp:
- Shared/qt/WebCoreArgumentCodersQt.cpp:
- Shared/win/LayerTreeContextWin.cpp:
- UIProcess/API/qt/qwkpage.cpp:
- UIProcess/Launcher/gtk/ThreadLauncherGtk.cpp:
- UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
- UIProcess/Plugins/gtk/PluginInfoStoreGtk.cpp:
- UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
- UIProcess/WebInspectorProxy.cpp:
- UIProcess/gtk/TextCheckerGtk.cpp:
- UIProcess/gtk/WebInspectorGtk.cpp:
- UIProcess/gtk/WebPreferencesGtk.cpp:
- UIProcess/qt/TextCheckerQt.cpp:
- UIProcess/qt/WebInspectorProxyQt.cpp:
- UIProcess/win/TextCheckerWin.cpp:
- UIProcess/win/WebContextMenuProxyWin.cpp:
- WebKit2.pro:
- WebProcess/Downloads/cf/DownloadCFNet.cpp:
- WebProcess/Downloads/curl/DownloadCurl.cpp:
- WebProcess/Downloads/mac/DownloadMac.mm:
- WebProcess/Downloads/qt/DownloadQt.cpp:
- WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp:
- WebProcess/Plugins/Netscape/JSNPMethod.cpp:
- WebProcess/Plugins/Netscape/NPJSObject.cpp:
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
- WebProcess/Plugins/Netscape/gtk/NetscapePluginGtk.cpp:
- WebProcess/Plugins/Netscape/qt/NetscapePluginQt.cpp:
- WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
- WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
- WebProcess/WebCoreSupport/WebDragClient.cpp:
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
- WebProcess/WebCoreSupport/WebInspectorClient.cpp:
- WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
- WebProcess/WebCoreSupport/gtk/WebContextMenuClientGtk.cpp:
- WebProcess/WebCoreSupport/gtk/WebPopupMenuGtk.cpp:
- WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
- WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
- WebProcess/WebCoreSupport/qt/WebContextMenuClientQt.cpp:
- WebProcess/WebPage/gtk/WebInspectorGtk.cpp:
- WebProcess/WebPage/qt/WebInspectorQt.cpp:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
- WebProcess/gtk/WebProcessGtk.cpp:
- 11:21 PM Changeset in webkit [79295] by
-
- 4 edits in trunk
2011-02-21 Lukasz Slachciak <l.slachciak@samsung.com>
Reviewed by Antonio Gomes.
[EFL] Fixed missing spatial navigation setting initialization. Doxygen comments added.
https://bugs.webkit.org/show_bug.cgi?id=54806
- ewk/ewk_view.cpp: (_ewk_view_priv_new): spatial navigation setting initialization added
2011-02-21 Lukasz Slachciak <l.slachciak@samsung.com>
Reviewed by Antonio Gomes.
[EFL] Restored spatial navigation option in EWebLauncher since #18662 bug is closed
https://bugs.webkit.org/show_bug.cgi?id=54806
- EWebLauncher/main.c: (on_key_down): calling ewk_view_setting_spatial_navigation_set when "F12" pressed added.
- 11:05 PM Changeset in webkit [79294] by
-
- 5 edits in trunk/Source
2011-02-21 Nico Weber <thakis@chromium.org>
Reviewed by James Robinson.
[chromium] PopupContainer::show() confuses clang's -Woverloaded-virtual
https://bugs.webkit.org/show_bug.cgi?id=54923
Rename PopupContainer::show() to showInRect(), to make it obvious it's
not an override of ScrollView::show().
No intended functionality change.
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::showInRect): (WebCore::PopupMenuChromium::show):
- platform/chromium/PopupMenuChromium.h:
2011-02-21 Nico Weber <thakis@chromium.org>
Reviewed by James Robinson.
[chromium] PopupContainer::show() confuses clang's -Woverloaded-virtual
https://bugs.webkit.org/show_bug.cgi?id=54923
Rename PopupContainer::show() to showInRect(), to make it obvious it's
not an override of ScrollView::show().
No intended functionality change.
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::applyAutoFillSuggestions):
- 10:48 PM Changeset in webkit [79293] by
-
- 3 edits in trunk/Source/WebCore
2011-02-21 Julien Chaffraix <jchaffraix@codeaurora.org>
Reviewed by Antti Koivisto.
Improve the local{SharedStyle,CousinList} algorithm
https://bugs.webkit.org/show_bug.cgi?id=45507
This change improves the algorithm to find shared styles: the old
algorithm would stop the search after the first cousin, even if
the search threshold is not met. As such, the algorithm would
systematically miss sharings across second cousins and beyond.
The new algorithm continues the search, as long as threshold is
not met. It also separates the threshold for sibling/cousins
search, from that on the levels of search, which is easier to
optimize.
The new algorithm finds up to 30% more sharings on some sites
(e.g. amazon.com and rakuten.co.jp) with no noticeable slowdown.
No new test, refactoring only.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::locateCousinList): (WebCore::CSSStyleSelector::locateSharedStyle): While changing the algorithm, cleaned up the style of those 2 methods (use early return, renamed some variables).
- css/CSSStyleSelector.h:
- 10:46 PM Changeset in webkit [79292] by
-
- 4 edits in trunk/Source/WebCore
2011-02-21 Nico Weber <thakis@chromium.org>
Reviewed by Adam Barth.
RenderTableCell::baselinePosition() confuses clang's -Woverloaded-virtual
https://bugs.webkit.org/show_bug.cgi?id=54922
RenderTableCell::baselinePosition() has the same name as a virtual
method in superclass RenderBlock. Rename the subclass method to make
it clear it's not an attempted override.
No intended functionality change.
- rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::cellBaselinePosition):
- rendering/RenderTableCell.h:
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::calcRowLogicalHeight): (WebCore::RenderTableSection::layoutRows):
- 10:45 PM Changeset in webkit [79291] by
-
- 2 edits in trunk/LayoutTests
2011-02-21 MORITA Hajime <morrita@google.com>
Unreviewed test_expectation.txt update.
r79285 removes too much lines. recover failed one.
- platform/chromium/test_expectations.txt:
- 10:24 PM Changeset in webkit [79290] by
-
- 5 edits in trunk
2011-02-21 Benjamin Kalman <kalman@chromium.org>
Reviewed by Ryosuke Niwa.
Extending selection by a boundary granularity (LineBoundary/ParagraphBoundary/DocumentBoundary) sets incorrect
start/end of selection for RTL
https://bugs.webkit.org/show_bug.cgi?id=54724
Augment extend-left-by-lineboundary test to extend the selection twice, which triggered the bug.
- editing/selection/extend-left-right-by-lineboundary-expected.txt:
- editing/selection/extend-left-right-by-lineboundary.html:
2011-02-21 Benjamin Kalman <kalman@chromium.org>
Reviewed by Ryosuke Niwa.
Extending selection by a boundary granularity (LineBoundary/ParagraphBoundary/DocumentBoundary) sets incorrect
start/end of selection for RTL
https://bugs.webkit.org/show_bug.cgi?id=54724
On mac, the selection should always grow when extending by a boundary granularity (line/paragraph/document).
This is achieved by extending from the start for the "left" direction (e.g. pressing left arrow key), or
extending from the end when for the "right" direction (e.g. pressing right arrow key).
However, this has a bug for RTL text, which should actually extend from the *end* when extending left (since
direction is obviously reversed) and likewise extend from the start when extending right.
- editing/SelectionController.cpp: (WebCore::SelectionController::modify):
- 10:19 PM Changeset in webkit [79289] by
-
- 10 edits in trunk/LayoutTests
2011-02-21 MORITA Hajime <morrita@google.com>
Unreviewed expectation rebaseline for r79284.
- platform/chromium-linux/fast/forms/placeholder-position-expected.checksum:
- platform/chromium-linux/fast/forms/placeholder-position-expected.png:
- platform/chromium-linux/fast/forms/search-styled-expected.checksum:
- platform/chromium-linux/fast/forms/search-styled-expected.png:
- platform/chromium-win/fast/forms/placeholder-position-expected.checksum:
- platform/chromium-win/fast/forms/placeholder-position-expected.png:
- platform/chromium-win/fast/forms/placeholder-position-expected.txt:
- platform/chromium-win/fast/forms/search-styled-expected.checksum:
- platform/chromium-win/fast/forms/search-styled-expected.png:
- 10:10 PM Changeset in webkit [79288] by
-
- 3 edits in trunk/Source/WebCore
2011-02-21 Nico Weber <thakis@chromium.org>
Reviewed by Adam Barth.
ImageDocument::imageChanged() confuses clang's -Woverride-virtual
https://bugs.webkit.org/show_bug.cgi?id=54924
Rename ImageDocument::imageChanged() to imageUpdated() to make clear
that it's not an override of CachedResourceClient::imageChanged().
- html/ImageDocument.cpp: (WebCore::ImageDocumentParser::appendBytes): (WebCore::ImageDocumentParser::finish): (WebCore::ImageDocument::imageUpdated):
- html/ImageDocument.h:
- 9:58 PM Changeset in webkit [79287] by
-
- 3 edits in trunk/Source/WebCore
2011-02-21 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Kent Tamura.
Bug 54934 - Sort the WebCore project file(s)
https://bugs.webkit.org/show_bug.cgi?id=54934
No new tests. (no code affected)
- GNUmakefile.am:
- WebCore.xcodeproj/project.pbxproj:
- 9:51 PM Changeset in webkit [79286] by
-
- 5 edits in trunk/Source/WebCore
2011-02-21 Nico Weber <thakis@chromium.org>
Reviewed by Adam Barth.
canAccommodateEllipsis() confuses clang's -Woverloaded-virtual
https://bugs.webkit.org/show_bug.cgi?id=54909
Rename the overload in RootInlineBox to lineCanAccomodateEllipsis() to
unconfuse clang. No intended functionality change.
- rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::checkLinesForTextOverflow):
- rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::applyLineClamp):
- rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::lineCanAccommodateEllipsis):
- rendering/RootInlineBox.h:
- 9:14 PM Changeset in webkit [79285] by
-
- 2 edits in trunk/LayoutTests
2011-02-21 MORITA Hajime <morrita@google.com>
Unreviewed test_expectation.txt update.
Removed BUGWK54736 lines which are no longer failed.
- platform/chromium/test_expectations.txt:
- 8:56 PM Changeset in webkit [79284] by
-
- 7 edits in trunk
Source/WebCore: Fix for for https://bugs.webkit.org/show_bug.cgi?id=54402
REGRESSION (r72052): Placeholder text doesn't have the right padding for search fields on Windows
Reviewed by Dan Bernstein.
Test: updated fast/forms/placeholder-position.html and tested manually
Consider padding and margin for the results and cancel buttons. This is important for the Windows
theme which uses padding to correctly position those buttons. This change fixes the placeholder
position, and also better aligns the results popup list with the actual text you type.
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::clientPaddingLeft):
(WebCore::RenderTextControlSingleLine::clientPaddingRight):
LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=54402
REGRESSION (r72052): Placeholder text doesn't have the right padding for search fields on Windows
Reviewed by Dan Bernstein.
Unfortunately, this doesn't test the Windows theme, since DRT uses the Safari theme, but I also tested this change manually on Windows and Mac.
- fast/forms/placeholder-position.html: Added a case for a search field with the results button.
- platform/mac/fast/forms/placeholder-position-expected.checksum:
- platform/mac/fast/forms/placeholder-position-expected.png:
- platform/mac/fast/forms/placeholder-position-expected.txt:
- 7:59 PM Changeset in webkit [79283] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
2011-02-21 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
[codereviewtool] focus comment on accept
https://bugs.webkit.org/show_bug.cgi?id=54930
- code-review.js:
- 7:57 PM Changeset in webkit [79282] by
-
- 3 edits in trunk/Source/WebCore
2011-02-21 Nico Weber <thakis@chromium.org>
Reviewed by Kent Tamura.
GIFImageDecoder::setSize() tries to override the superclass method but fails
https://bugs.webkit.org/show_bug.cgi?id=54305
The superclass uses unsigned instead of int for its parameters, so
GIFImageDecoder::setSize() was an overload, not an override.
- platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::setSize):
- platform/image-decoders/gif/GIFImageDecoder.h:
- 7:44 PM Changeset in webkit [79281] by
-
- 3 edits in trunk/LayoutTests
2011-02-21 Dirk Pranke <dpranke@chromium.org>
Reviewed by Ojan Vafai.
This patch changes a test to work around a bug in PrettyPatch where
it will crash if lines starting with "--" are missing from the actual
output. The actual fix needed to PrettyPatch is described in the
bug.
- platform/mac/fast/objc/dom-html-select-activate-expected.txt:
- platform/mac/fast/objc/dom-html-select-activate.html:
- 7:38 PM Changeset in webkit [79280] by
-
- 3 edits in trunk/Websites/bugs.webkit.org
2011-02-20 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
[codereviewtool] avoid overriding ctrl/cmd + r
https://bugs.webkit.org/show_bug.cgi?id=54852
- code-review.js:
- 7:31 PM Changeset in webkit [79279] by
-
- 5 edits in trunk/Tools
2011-02-21 Dirk Pranke <dpranke@chromium.org>
Reviewed by Kent Tamura.
nrwt: revert behavior on 10.5 to "old-threads". It's possible
that r79062 has introduced a bunch of flakiness, although I
can't explain why right now. This change should restore the
old behavior, and then we can look at the build logs to see
if the tests stop timing out or being flaky.
- Scripts/webkitpy/layout_tests/port/chromium_mac.py:
- Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
- Scripts/webkitpy/layout_tests/port/mac.py:
- Scripts/webkitpy/layout_tests/port/mac_unittest.py:
- 6:28 PM Changeset in webkit [79278] by
-
- 6 edits in trunk/Source/WebCore
2011-02-21 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Deploy EditingStyle more in ApplyStyleCommand and do some cleanup
https://bugs.webkit.org/show_bug.cgi?id=54528
- editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::init): Allows style to be a null pointer. (WebCore::ApplyStyleCommand::applyInlineStyle): Overrides the value of text-decoration property by that of -webkit-text-decorations-in-effect and remove the latter property when present. This allows removeImplicitlyStyledElement to ignore -webkit-text-decorations-in-effect. Also uses the return value of EditingStyle::textDirection to determine whether or not we need to apply unicode-bidi / direction instead of directly checking the value of unicode-bidi property. (WebCore::ApplyStyleCommand::fixRangeAndApplyInlineStyle): Takes EditingStyle* instead of CSSMutableStyleDeclaration*. (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): Ditto. (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): Ditto. (WebCore::ApplyStyleCommand::removeCSSStyle): Ditto. (WebCore::ApplyStyleCommand::highestAncestorWithConflictingInlineStyle): Ditto. (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Ditto. (WebCore::ApplyStyleCommand::removeInlineStyle): Ditto; no longer collapse text decoration properties because ApplyStyleCommand::applyInlineStyle already does it.
- editing/ApplyStyleCommand.h:
- editing/EditingStyle.cpp: (WebCore::EditingStyle::textDirection): Exits early when m_mutableStyle is null. (WebCore::EditingStyle::collapseTextDecorationProperties): Extracted from ApplyStyleCommand::removeInlineStyle.
- editing/EditingStyle.h:
- 6:14 PM Changeset in webkit [79277] by
-
- 2 edits in trunk/Source/WebCore
<http://webkit.org/b/54919> / <rdar://problem/7689300> WebCore should retrieve unclamped frame delays from ImageIO
Reviewed by Darin Adler and Alexey Proskuryakov.
- platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::frameDurationAtIndex): Look for the unclamped frame delay in the
frame properties dictionary and use that if it exists. If it does not exist in the
dictionary then fall back to using the clamped frame delay.
- 6:08 PM Changeset in webkit [79276] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-02-21 Nico Weber <thakis@chromium.org>
Reviewed by Kent Tamura.
[chromium] ChromePluginPrintContext::begin() fails to override superclass method
https://bugs.webkit.org/show_bug.cgi?id=54914
Update subclass method signature to match superclass again. This
regressed in http://trac.webkit.org/changeset/71964
- src/WebFrameImpl.cpp: (WebKit::ChromePluginPrintContext::begin):
- 6:07 PM Changeset in webkit [79275] by
-
- 2 edits in trunk/LayoutTests
2011-02-21 MORITA Hajime <morrita@google.com>
Unreviewed test_expectation.txt update.
Disabled "BUGWK54322 MAC SNOWLEOPARD" lines, which sesms no longer needed.
- platform/chromium/test_expectations.txt:
- 6:01 PM Changeset in webkit [79274] by
-
- 1 edit in trunk/Source/WebKit2/UIProcess/win/WebInspectorProxyWin.cpp
Fix Windows build.
- 5:43 PM Changeset in webkit [79273] by
-
- 11 edits in trunk/Source/WebKit2
Set and update the window title for the Web Inspector in WebKit2.
https://webkit.org/b/50945
rdar://problem/8762410
Reviewed by Adam Roben.
- UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::inspectedURLChanged): Added. Call platformInspectedURLChanged.
- UIProcess/WebInspectorProxy.h:
- UIProcess/WebInspectorProxy.messages.in: Added InspectedURLChanged.
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformInspectedURLChanged): Added. Set the window title.
- UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::platformInspectedURLChanged): Added. Set the window title.
- UIProcess/gtk/WebInspectorGtk.cpp:
(WebKit::WebInspectorProxy::platformInspectedURLChanged): Added. Not implemented.
- UIProcess/qt/WebInspectorProxyQt.cpp:
(WebKit::WebInspectorProxy::platformInspectedURLChanged): Added. Not implemented.
- WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
(WebKit::WebInspectorFrontendClient::inspectedURLChanged): Call WebInspector::inspectedURLChanged.
- WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::inspectedURLChanged): Added. Send the InspectedURLChanged message.
- WebProcess/WebPage/WebInspector.h:
- 5:40 PM Changeset in webkit [79272] by
-
- 2 edits in trunk/LayoutTests
2011-02-21 MORITA Hajime <morrita@google.com>
Unreviewed test_expectation.txt clenaup.
Removed disabled lines which I commented out.
- platform/chromium/test_expectations.txt:
- 5:32 PM Changeset in webkit [79271] by
-
- 5 edits in branches/safari-534.20-branch/Source
Versioning.
- 5:28 PM Changeset in webkit [79270] by
-
- 1 copy in tags/Safari-534.20.8
New tag.
- 5:27 PM Changeset in webkit [79269] by
-
- 6 edits2 adds in trunk
2011-02-21 James Kozianski <koz@chromium.org>
Reviewed by Kent Tamura.
Causes elements to be unfocusable after tabindex property is removed.
https://bugs.webkit.org/show_bug.cgi?id=54727
- fast/html/tabindex-removal-expected.txt: Added.
- fast/html/tabindex-removal.html: Added.
2011-02-21 James Kozianski <koz@chromium.org>
Reviewed by Kent Tamura.
Causes elements to be unfocusable after tabindex property is removed.
https://bugs.webkit.org/show_bug.cgi?id=54727
Test: fast/html/tabindex-removal.html
- dom/Node.cpp: (WebCore::Node::clearTabIndexExplicitly):
- dom/Node.h:
- dom/NodeRareData.h: (WebCore::NodeRareData::clearTabIndexExplicitly):
- html/HTMLElement.cpp: (WebCore::HTMLElement::parseMappedAttribute):
- 5:23 PM Changeset in webkit [79268] by
-
- 2 edits in branches/safari-534.20-branch/Source/WebKit2
Merge r78673.
- 5:23 PM Changeset in webkit [79267] by
-
- 2 edits in trunk/Source/WebCore
Reviewed by Mark Rowe.
<rdar://problem/8995483> Remove stubs of unneeded NSURLAuthenticationChallengeSender methods
- platform/network/mac/AuthenticationMac.mm: Remove the stubs that are no longer needed.
- 5:22 PM Changeset in webkit [79266] by
-
- 2 edits in trunk/LayoutTests
2011-02-21 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed Chromium test expectations update.
Removed fast/js/kde/math.html because it has been passing since r79246.
Removed fast/text/capitalize-boundaries.html on Mac and Windows because it has been steadily passing.
- platform/chromium/test_expectations.txt:
- 5:18 PM Changeset in webkit [79265] by
-
- 2 edits in trunk/Source/WebCore
2011-02-21 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Overhang areas need to be invalidated on scroll
<rdar://problem/9032194>
https://bugs.webkit.org/show_bug.cgi?id=54917
- platform/ScrollView.cpp: (WebCore::ScrollView::scrollContents): We need to explicitly invalidate the overhang areas when we scroll the contents of a ScrollView, since they could contain arbitrary content that cannot be blitted.
- 5:06 PM Changeset in webkit [79264] by
-
- 3 edits2 copies in branches/chromium/648
Merge 78168 - 2011-02-09 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
REGRESSION(r76107): Crash in VisibleSelection::toNormalizedRange
https://bugs.webkit.org/show_bug.cgi?id=54053
The bug was caused by RenderBlock::positionForPoint's improperly returning a shadow node inside
RenderFileUploadControl for hit testing and VisibleSelection::toNormalizedRange's always assuming
the position variable "s" is not null.
Fixed the bug by always returning a null position from RenderFileUploadControl::positionForPoint,
and also exiting early when either "s" or "e" is null in VisibleSelection::toNormalizedRange.
Test: fast/forms/file-input-hit-test.html
- editing/VisibleSelection.cpp: (WebCore::VisibleSelection::toNormalizedRange):
- rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::positionForPoint):
- rendering/RenderFileUploadControl.h:
2011-02-09 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
REGRESSION(r76107): Crash in VisibleSelection::toNormalizedRange
https://bugs.webkit.org/show_bug.cgi?id=54053
Added a test to ensure WebKit does not crash when a user clicks on a region immediately after a file
upload control.
- fast/forms/file-input-hit-test-expected.txt: Added.
- fast/forms/file-input-hit-test.html: Added.
TBR=rniwa@webkit.org
Review URL: http://codereview.chromium.org/6542053
- 5:01 PM Changeset in webkit [79263] by
-
- 1 edit in trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
- 4:56 PM Changeset in webkit [79262] by
-
- 1 edit in trunk/Source/WebCore/ChangeLog
Fix the Leopard Debug build by incorporating the RenderSVGAllInOne.cpp
Reviewed by Stephanie Lewis.
No new tests required.
- WebCore.xcodeproj/project.pbxproj:
- 4:13 PM Changeset in webkit [79261] by
-
- 2 edits in trunk/Source/WebCore
Remove global initializer in CookieStorageCFNet.cpp
https://bugs.webkit.org/show_bug.cgi?id=54905
Reviewed by Darin Adler.
- platform/network/cf/CookieStorageCFNet.cpp:
(WebCore::currentCookieStorage):
(WebCore::setCurrentCookieStorage):
(WebCore::setCookieStoragePrivateBrowsingEnabled):
- 3:57 PM Changeset in webkit [79260] by
-
- 2 edits in trunk/Source/WebKit2
Can't paste from 3rd party text editor into WebKit2 window.
<rdar://problem/8978624>
Reviewed by Anders Carlsson.
- WebProcess/com.apple.WebProcess.sb:
- 3:47 PM Changeset in webkit [79259] by
-
- 2 edits in trunk/Source/WebCore
2011-02-18 Jer Noble <jer.noble@apple.com>
Reviewed by Sam Weinig.
WebKit2: Media document videos play only sound, no video (affects trailers.apple.com)
https://bugs.webkit.org/show_bug.cgi?id=54771
Now that video is accelerated, we no longer need to special case
video playing within a media document.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivateQTKit::preferredRenderingMode): (WebCore::MediaPlayerPrivateQTKit::supportsAcceleratedRendering):
- 3:42 PM Changeset in webkit [79258] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix linker warning on Windows
r79135 tried to export JSObject::s_info by adding it to JavaScriptCore.def. This is the
obvious way (since it's how we export functions), but unfortunately it doesn't work correct.
r79222 made us export it the right way (using the JS_EXPORTDATA macro), but forgot to remove
it from JavaScriptCore.def. This caused us to get linker warnings about exporting the symbol
multiple times.
Rubber-stamped by Anders Carlsson.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Removed JSObject::s_info.
- 3:34 PM Changeset in webkit [79257] by
-
- 1 edit2 adds in trunk/LayoutTests
2011-02-21 Ami Fischman <fischman@chromium.org>
Reviewed by Eric Carlson.
Add regression test for clean shutdown during video playback.
DumpRenderTree used to crash if the test was ended while a video
was still playing. (http://crbug.com/72730).
https://bugs.webkit.org/show_bug.cgi?id=54888
- media/video-plays-past-end-of-test-expected.txt: Added.
- media/video-plays-past-end-of-test.html: Added.
- 3:29 PM Changeset in webkit [79256] by
-
- 2 edits in trunk/Source/WebKit2
2011-02-21 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Initialize DrawingAreaProxy::m_size
https://bugs.webkit.org/show_bug.cgi?id=54913
This was removed in r76962 since it caused flashes when switching drawing areas due to
entering and exiting composited mode, but since we no longer switch drawing areas we can
put it back.
- UIProcess/DrawingAreaProxy.cpp: (WebKit::DrawingAreaProxy::DrawingAreaProxy):
- 3:21 PM Changeset in webkit [79255] by
-
- 2 edits in trunk/Source/WebKit2
Add some assertions about the state IDs we receive from the web process
Rubber-stamped by Anders Carlsson.
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::update):
(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
(WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode):
Assert that the state ID the web process sent us is no newer than our own state ID.
- 3:20 PM Changeset in webkit [79254] by
-
- 9 edits in trunk/Source/WebKit2
Rename DrawingArea[Proxy]Impl's "sequence number" concept to "state ID".
As explained in r79251, DrawingAreaProxyImpl has some state that, when it changes, causes
all operations performed before that state change to become invalid. Currently, this state
consists of a single piece of data: the view's size. Eventually it will encompass more data
(e.g., the backing store we're drawing into; when we start throwing away the backing store
to save memory, our state will have changed, and any operations that were intended for the
old backing store will have become invalid). r79251 effectively transformed
DrawingArea[Proxy]Impl's "sequence number," which incremented every time DrawingAreaImpl
sent DrawingAreaProxyImpl a message, to a "state ID," which only increments when the view's
size changes.
This patch is just a set of simple renames to reflect the transformation that r79251
effected. It should not introduce any changes in behavior. The renames are:
- Messages::DrawingArea::SetSize -> UpdateState
- Messages::DrawingAreaProxy::DidSetSize -> DidUpdateState
- DrawingAreaProxyImpl::m_lastDidSetSizeSequenceNumber -> m_currentStateID
- DrawingAreaProxyImpl::m_isWaitingForDidSetSize -> m_isWaitingForDidUpdateState
- DrawingAreaProxyImpl::waitForAndDispatchDidSetSize -> waitForAndDispatchDidUpdateState
- DrawingAreaImpl::m_inSetSize -> m_inUpdateState
- generateSequenceNumber -> generateStateID
- sequenceNumber -> stateID
Fixes <http://webkit.org/b/54911> DrawingArea[Proxy]Impl's "sequence number" concept should
be renamed to "state ID"
Reviewed by Anders Carlsson.
- UIProcess/DrawingAreaProxy.h:
- UIProcess/DrawingAreaProxy.messages.in:
- UIProcess/DrawingAreaProxyImpl.cpp:
- UIProcess/DrawingAreaProxyImpl.h:
- WebProcess/WebPage/DrawingArea.h:
- WebProcess/WebPage/DrawingArea.messages.in:
- WebProcess/WebPage/DrawingAreaImpl.cpp:
- WebProcess/WebPage/DrawingAreaImpl.h:
Performed the renames described above.
- 2:47 PM Changeset in webkit [79253] by
-
- 19 edits in trunk/Source
Reviewed by Adam Roben.
REGRESSION (WebKit2): HTTP requests time out after 60 seconds
https://bugs.webkit.org/show_bug.cgi?id=54755
<rdar://problem/9006592>
WebCore:
It's now possible to set a default timeout to be used at ResourceRequest creation. If one
hasn't been set, ResourceRequest will behave as before (use NSURLRequest default on Mac,
or use INT_MAX on other platforms).
- WebCore.exp.in:
- platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::defaultTimeoutInterval): Get the ResourceRequest notion of default timeout interval (may be 0 if using NSURLRequest default). (WebCore::ResourceRequestBase::setDefaultTimeoutInterval): Set the static member variable. (WebCore::ResourceRequestBase::updatePlatformRequest): Added an assertion that resource request is updated. Plaform code often calls updateResourceRequest() indirectly from this function, and that must obviously be a no-op. (WebCore::ResourceRequestBase::updateResourceRequest): Added an assertion in the opposite direction.
- platform/network/ResourceRequestBase.h: Changed "unspecifiedTimeoutInterval" to "defaultTimeoutInterval". It has been used as default by most platforms anyway. (WebCore::ResourceRequestBase::ResourceRequestBase):
- platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdatePlatformRequest): Now zero is the magic value, not INT_MAX. We'll use NSURLRequest default if neither setTimeoutInterval() nor setDefaultTimeoutInterval() has been called.
WebKit2:
- Shared/API/c/WKURLRequest.cpp: (WKURLRequestSetDefaultTimeoutInterval):
- Shared/API/c/WKURLRequest.h: Added an API to set a default timeout interval for requests created from URLs. The API affects both the UI process and requests created internally by the Web process. Requests created from NSURLRequest or CFURLRequest take timeout from those.
- Shared/WebURLRequest.cpp: (WebKit::WebURLRequest::setDefaultTimeoutInterval):
- Shared/WebURLRequest.h: Pipe the default timeout interval from WKURLRequest down to actual implementation. Since WebURLRequest is currently implemented with WebCore::ResourceRequest, it automatically respects NSURLRequest default timeout interval.
- UIProcess/WebProcessManager.cpp: (WebKit::WebProcessManager::getAllWebProcessContexts):
- UIProcess/WebProcessManager.h: Added a way to enumerate all contexts running in separate processes.
- Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::WebProcessCreationParameters): (WebKit::WebProcessCreationParameters::encode): (WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h: (WebKit::WebContext::ensureWebProcess): (WebKit::WebContext::setDefaultRequestTimeoutInterval):
- UIProcess/WebContext.h:
- WebProcess/WebProcess.cpp: (WebKit::WebProcess::initializeWebProcess): (WebKit::WebProcess::setDefaultRequestTimeoutInterval):
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in: Use UI process default timeout interval in separate process contexts, too.
- 2:26 PM Changeset in webkit [79252] by
-
- 13 edits2 adds in trunk
Source/JavaScriptCore: WebResourceCacheManager should be responsible for managing the CFURLCache as well
as the WebCore memory cache.
https://bugs.webkit.org/show_bug.cgi?id=54886
Part of <rdar://problem/8971738>
Reviewed by Adam Roben.
Add a new use flag for using the CFURLCache.
- wtf/Platform.h:
Source/WebKit2: WebResourceCacheManager should be responsible for managing the CFURLCache as well
as the WebCore memory cache.
https://bugs.webkit.org/show_bug.cgi?id=54886
Part of <rdar://problem/8971738>
Reviewed by Adam Roben.
- WebProcess/ResourceCache/WebResourceCacheManager.cpp:
(WebKit::WebResourceCacheManager::getCacheOrigins): Call through to cFURLCacheHostNames, and add
create SecurityOrigin's for them and add them to the set of SecurityOrigins with cache.
(WebKit::WebResourceCacheManager::clearCacheForOrigin): Call through to clear the CFURLCache for
the origin's hostname.
- WebProcess/ResourceCache/WebResourceCacheManager.h:
- WebProcess/ResourceCache/cf: Added.
- WebProcess/ResourceCache/cf/WebResourceCacheManagerCFNet.cpp: Added.
(WebKit::WebResourceCacheManager::cfURLCacheHostNames): Call through to WebKitSystemInterface.
(WebKit::WebResourceCacheManager::clearCFURLCacheForHostNames): Ditto.
- win/WebKit2.vcproj: Added new file.
- WebKit2.xcodeproj/project.pbxproj: Ditto.
WebKitLibraries: WebResourceCacheManager should be responsible for managing the CFURLCache as well
as the WebCore memory cache.
https://bugs.webkit.org/show_bug.cgi?id=54886
Part of <rdar://problem/8971738>
Reviewed by Adam Roben.
Update WebKitSystemInterface headers and libraries with new functions.
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- win/include/WebKitSystemInterface/WebKitSystemInterface.h:
- win/lib/WebKitSystemInterface.lib:
- 2:21 PM Changeset in webkit [79251] by
-
- 6 edits in trunk/Source/WebKit2
Move control of the sequence number from DrawingAreaImpl to DrawingAreaProxyImpl
DrawingAreaProxyImpl has some state that, when it changes, causes all operations performed
before that state change to become invalid. When painting, we need to have performed at
least one Update for the most recent state; otherwise, we'll be painting old/incorrect bits
into the view.
Currently, this state consists of a single piece of data: the view's size. Whenever the
state (i.e., size) changes, we tell the web process via the SetSize message, and the web
process lets us know that it has updated to match the new state (i.e., size) via the
DidSetSize message.
When it's time to paint, if we're waiting for the web process to update to match our current
state (i.e., size), we block for a little while hoping to receive a DidSetSize message so
that we can paint up-to-date bits into the window. This can cause us to receive messages
out-of-order; the DidSetSize message will be processed immediately, and any messages that
were sent before the DidSetSize message will be processed later. Since the messages from
before the DidSetSize message correspond to an old state (i.e., size), they are no longer
useful (e.g., they contain bits of the page that are drawn at the wrong size/location), so
we discard them.
The way we identify and discard these messages is by keeping track of a sequence number.
Currently, DrawingAreaImpl sends a monotonically-increasing sequence number to
DrawingAreaProxyImpl with every message. Whenever DrawingAreaProxyImpl receives a DidSetSize
message, it records the sequence number that came along with it. If we then later receive
any messages that have a lower sequence number, we know they correspond to an old state
(i.e., size) and can discard them.
This patch moves control of the sequence number to DrawingAreaProxyImpl.
DrawingAreaProxyImpl now sends a monotonically-increasing sequence number in the SetSize
message. DrawingAreaImpl records this sequence number when it receives the SetSize message,
and sends it back to DrawingAreaProxyImpl in every message. Otherwise the logic is the same
as before.
This should cause no changes in behavior, but will allow DrawingAreaProxyImpl to request a
full backing store update (by incrementing the sequence number) at times other than when the
view's size changes (e.g., after it has thrown away its backing store in order to save
memory).
Fixes <http://webkit.org/b/54907> DrawingAreaProxyImpl should tell DrawingAreaImpl what
sequence number to use
Reviewed by Anders Carlsson.
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::generateSequenceNumber): Moved here from DrawingAreaImpl.cpp.
(WebKit::DrawingAreaProxyImpl::sendSetSize): Changed to pass a new sequence number in the
SetSize message.
(WebKit::DrawingAreaProxyImpl::waitForAndDispatchDidSetSize): Added a FIXME about a
potential improvement.
- WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::setSize): Updated to match the message's new parameters.
- WebProcess/WebPage/DrawingArea.messages.in: Added a sequenceNumber parameter to SetSize.
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::DrawingAreaImpl): Initialize m_sequenceNumber.
(WebKit::DrawingAreaImpl::setSize): Record the new sequence number from the UI process.
(WebKit::DrawingAreaImpl::layerHostDidFlushLayers):
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
(WebKit::DrawingAreaImpl::display):
Send m_sequenceNumber, instead of a new sequence number, back to the UI process.
- WebProcess/WebPage/DrawingAreaImpl.h: Added m_sequenceNumber, updated setSize function to
match the base class.
- 2:02 PM Changeset in webkit [79250] by
-
- 2 edits in trunk/WebKitLibraries
Update WebKitSystemInterface.h on Mac. The header that was in the tree didn't
match the current WebKitSystemInterface.h.
Rubber-stamped by Dan Bernstein.
- WebKitSystemInterface.h:
- 1:35 PM Changeset in webkit [79249] by
-
- 5 edits in trunk
2011-02-21 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] editing/pasteboard/dataTransfer-setData-getData.html fails
https://bugs.webkit.org/show_bug.cgi?id=54895
Update the results for this test which now includes a few more passing
lines. We maintain separate results, because we seem to pass more tests
than other platforms.
- platform/gtk/Skipped: Unskip a test which is now passing.
- platform/gtk/editing/pasteboard/dataTransfer-setData-getData-expected.txt:
2011-02-21 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] editing/pasteboard/dataTransfer-setData-getData.html fails
https://bugs.webkit.org/show_bug.cgi?id=54895
Correct the GTK+ clipboard implementation to know that "text" is an alias
for "text/html" data. This corrects the failing test.
- platform/gtk/ClipboardGtk.cpp: (WebCore::dataObjectTypeFromHTMLClipboardType): Accept "text" as well as "Text". (WebCore::ClipboardGtk::types): Advertise "text" as well as "Text".
- 1:23 PM Changeset in webkit [79248] by
-
- 2 edits in trunk/Tools
2011-02-21 Dirk Pranke <dpranke@chromium.org>
Reviewed by Dimitri Glazkov.
nrwt: fix typo causing us to try and repeatedly shut down the servers
https://bugs.webkit.org/show_bug.cgi?id=54904
- Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
- 1:14 PM Changeset in webkit [79247] by
-
- 4 edits in trunk/Source/JavaScriptCore
2011-02-21 Xan Lopez <xlopez@igalia.com>
Reviewed by Gavin Barraclough.
Use ASSERT_JIT_OFFSET in JITPropertyAccess32_64.cpp
https://bugs.webkit.org/show_bug.cgi?id=54901
- jit/JIT.h: swap actual and expected values in message, they were reversed.
- jit/JITCall32_64.cpp: (JSC::JIT::compileOpCall): use ASSERT_JIT_OFFSET instead of a simple ASSERT.
- jit/JITPropertyAccess32_64.cpp: (JSC::JIT::emit_op_method_check): ditto. (JSC::JIT::compileGetByIdHotPath): ditto. (JSC::JIT::compileGetByIdSlowCase): ditto. (JSC::JIT::emit_op_put_by_id): ditto.
- 12:46 PM Changeset in webkit [79246] by
-
- 5 edits in trunk
Ruber stamped by Sam Weinig
Bug 54899 - Math.LOG10E should be 0.4342944819032518
This value is quoted in section 15.8.1.5 of the spec.
Source/JavaScriptCore:
- runtime/MathObject.cpp:
(JSC::MathObject::MathObject):
LayoutTests:
- fast/js/kde/math-expected.txt:
- fast/js/kde/script-tests/math.js:
- 12:30 PM Changeset in webkit [79245] by
-
- 2 edits4 adds1 delete in trunk/LayoutTests
2011-02-21 Anna Cavender <annacc@timberline.sea.corp.google.com>
Reviewed by Eric Carlson.
new baselines for video-transformed.html on mac
https://bugs.webkit.org/show_bug.cgi?id=54765
- platform/chromium-mac-leopard/media/video-transformed-expected.checksum: Added.
- platform/chromium-mac-leopard/media/video-transformed-expected.png: Renamed from LayoutTests/platform/chromium-mac/media/video-transformed-expected.png.
- platform/chromium-mac-snowleopard/media/video-transformed-expected.checksum: Added.
- platform/chromium-mac-snowleopard/media/video-transformed-expected.png: Added.
- platform/chromium-mac/media/video-transformed-expected.checksum: Removed.
- platform/chromium/test_expectations.txt:
- 11:58 AM Changeset in webkit [79244] by
-
- 3 edits in trunk/Source/WebCore
2011-02-21 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
ProcessingInstruction should provide a way to know if it is of CSS type.
https://bugs.webkit.org/show_bug.cgi?id=54868
- dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::ProcessingInstruction): (WebCore::ProcessingInstruction::checkStyleSheet): (WebCore::ProcessingInstruction::setCSSStyleSheet):
- dom/ProcessingInstruction.h: (WebCore::ProcessingInstruction::isCSS):
- 11:55 AM Changeset in webkit [79243] by
-
- 2 edits in trunk/Source/WebCore
2011-02-21 Simon Fraser <Simon Fraser>
Put JSDOMImplementationCustom.cpp where it belongs in the project.
- WebCore.xcodeproj/project.pbxproj:
- 11:49 AM Changeset in webkit [79242] by
-
- 2 edits in trunk/LayoutTests
2011-02-21 Alejandro G. Castro <alex@igalia.com>
Unreviewed, skip
editing/pasteboard/dataTransfer-setData-getData.html. Added bug:
https://bugs.webkit.org/show_bug.cgi?id=54895
- platform/gtk/Skipped:
- 11:33 AM Changeset in webkit [79241] by
-
- 542 edits1083 adds in trunk/LayoutTests
Unreviewed.
[Qt] Add Qt specific expected results for passing tables/mozilla tests.
- platform/qt/Skipped: Unskip passing tests.
- platform/qt/tables/mozilla [...] : Added.
- 11:31 AM Changeset in webkit [79240] by
-
- 35 edits in trunk/Source
Bug 54894 - Make inheritance structure described by ClassInfo match C++ class hierarchy.
Reviewed by Sam Weinig.
The ClassInfo objects describe an inheritance hierarchy, with each ClassInfo instance
containing a pointer to its parent class. These links should reflect the inheritance
hierarchy of C++ classes below JSObject. For the large part it does, but in some cases
entries in the C++ hierarchy are skipped over. This presently likely doesn't matter,
since intervening C++ classes may not have ClassInfo - but would be a potential bug
were ClassInfo were to be added.
Source/JavaScriptCore:
- API/JSCallbackConstructor.cpp:
- API/JSCallbackFunction.cpp:
- API/JSCallbackObjectFunctions.h:
- runtime/Arguments.h:
- runtime/ArrayPrototype.cpp:
- runtime/BooleanObject.cpp:
- runtime/DateInstance.cpp:
- runtime/DatePrototype.cpp:
- runtime/ErrorInstance.cpp:
- runtime/InternalFunction.cpp:
- runtime/JSActivation.cpp:
- runtime/JSArray.cpp:
- runtime/JSFunction.cpp:
- runtime/JSONObject.cpp:
- runtime/JSObject.h:
- runtime/JSZombie.h:
- runtime/MathObject.cpp:
- runtime/NativeErrorConstructor.cpp:
- runtime/NumberConstructor.cpp:
- runtime/NumberObject.cpp:
- runtime/RegExpConstructor.cpp:
- runtime/RegExpObject.cpp:
- runtime/StringObject.cpp:
- runtime/StringPrototype.cpp:
Source/WebCore:
- bindings/js/JSAudioConstructor.cpp:
- bindings/js/JSDOMGlobalObject.cpp:
- bindings/js/JSImageConstructor.cpp:
- bindings/js/JSOptionConstructor.cpp:
- bindings/scripts/CodeGeneratorJS.pm:
- bridge/objc/objc_runtime.mm:
- bridge/runtime_object.cpp:
Source/WebKit2:
- WebProcess/Plugins/Netscape/JSNPObject.cpp:
- 11:16 AM Changeset in webkit [79239] by
-
- 2 edits in trunk/LayoutTests
2011-02-21 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: skip new inspector test on wk2.
- platform/mac-wk2/Skipped:
- 11:07 AM Changeset in webkit [79238] by
-
- 1 edit in trunk/Source/WebKit2/ChangeLog
Fix radar url.
- 11:06 AM Changeset in webkit [79237] by
-
- 2 edits in trunk/Tools
2011-02-21 Alejandro G. Castro <alex@igalia.com>
Reviewed by Csaba Osztrogonác.
REGRESSION(r79157):
plugins/get-url-with-javascript-destroying-plugin.html make the
next test crash
https://bugs.webkit.org/show_bug.cgi?id=54863
- GNUmakefile.am:
- 10:45 AM Changeset in webkit [79236] by
-
- 2 edits in trunk/LayoutTests
2011-02-21 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
Skip WebKit2 tests that need EventSender
https://bugs.webkit.org/show_bug.cgi?id=54890
These tests fail because EventSender is missing.
- platform/mac-wk2/Skipped:
- 10:40 AM Changeset in webkit [79235] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
REGRESSION(r79157): plugins/get-url-with-javascript-destroying-plugin.html make the next test crash
https://bugs.webkit.org/show_bug.cgi?id=54863
Bug was fixed by http://trac.webkit.org/changeset/79231.
- platform/qt/Skipped: Unskip plugins/get-url-with-javascript-destroying-plugin.html.
- 10:29 AM Changeset in webkit [79234] by
-
- 5 edits2 adds in trunk
2011-02-21 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: navigation does not work after reopening frontend.
https://bugs.webkit.org/show_bug.cgi?id=54879
Test: http/tests/inspector-enabled/open-close-open.html
- inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::setFrontend):
- inspector/InspectorState.cpp: (WebCore::InspectorState::unmute):
- inspector/InspectorState.h:
- 10:03 AM Changeset in webkit [79233] by
-
- 2 edits18 adds in trunk/LayoutTests
2011-02-21 Martin Robinson <mrobinson@igalia.com>
Add results for tests missing results and unskip a test that
is passing locally and when run manually on the bots.
- platform/gtk/Skipped: Unskip tests that are now passing.
- platform/gtk/editing/deleting/non-smart-delete-expected.checksum: Added.
- platform/gtk/editing/deleting/non-smart-delete-expected.png: Added.
- platform/gtk/editing/deleting/non-smart-delete-expected.txt: Added.
- platform/gtk/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.checksum: Added.
- platform/gtk/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.png: Added.
- platform/gtk/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.txt: Added.
- platform/gtk/fast/runin/generated2-expected.checksum: Added.
- platform/gtk/fast/runin/generated2-expected.png: Added.
- platform/gtk/fast/runin/generated2-expected.txt: Added.
- platform/gtk/fast/runin/generated3-expected.checksum: Added.
- platform/gtk/fast/runin/generated3-expected.png: Added.
- platform/gtk/fast/runin/generated3-expected.txt: Added.
- platform/gtk/fast/runin/generated4-expected.checksum: Added.
- platform/gtk/fast/runin/generated4-expected.png: Added.
- platform/gtk/fast/runin/generated4-expected.txt: Added.
- platform/gtk/media/video-aspect-ratio-expected.checksum: Added.
- platform/gtk/media/video-aspect-ratio-expected.png: Added.
- platform/gtk/media/video-aspect-ratio-expected.txt: Added.
- 10:01 AM Changeset in webkit [79232] by
-
- 2 edits in trunk/LayoutTests
2011-02-21 Alejandro G. Castro <alex@igalia.com>
Unreviewed added more tests with pixel differences between bots.
- platform/gtk/Skipped:
- 9:48 AM Changeset in webkit [79231] by
-
- 2 edits in trunk/Source/WebCore
Protect the PluginView when evaluating javascript: URLs
Fixes <http://webkit.org/b/54884> <rdar://problem/9030864>
plugins/get-url-with-javascript-destroying-plugin.html crashing on Windows since it was
added
Reviewed by Sam Weinig.
- plugins/PluginView.cpp:
(WebCore::PluginView::performRequest): Protect the PluginView, not just its parent frame,
when evaluating javascript: URLs.
- 9:44 AM Changeset in webkit [79230] by
-
- 2 edits in trunk/Source/WebCore
2011-02-21 Martin Robinson <mrobinson@igalia.com>
Fix GTK+ build after r79223.
- GNUmakefile.am: Add file missing from the source list.
- 9:35 AM Changeset in webkit [79229] by
-
- 2 edits in trunk/Source/WebCore
2011-02-14 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: audits should not warn about gzip compression for 304s
https://bugs.webkit.org/show_bug.cgi?id=54343
Do not run compression-related audits on 304 resources.
Drive-by: handle multi-encoding resources (Content-Encoding: sdhc,gzip) correctly.
- inspector/front-end/AuditRules.js: (WebInspector.AuditRules.GzipRule.prototype.doRun): (WebInspector.AuditRules.GzipRule.prototype._isCompressed):
- 9:25 AM Changeset in webkit [79228] by
-
- 2 edits in trunk/LayoutTests
Unreviewed expectations change to mark tests as timing out.
Many tests started timing out on the chrome mac canaries around r79035
https://bugs.webkit.org/show_bug.cgi?id=54885
- platform/chromium/test_expectations.txt:
- 8:36 AM Changeset in webkit [79227] by
-
- 2 edits in trunk/LayoutTests
Unreviewed expectations change - ignore styles-update-from-js.html failures on chromium-win.
Web Inspector: inspector/styles/styles-update-from-js.html is sporadically failing on chromium win bots
https://bugs.webkit.org/show_bug.cgi?id=54882
- platform/chromium/test_expectations.txt:
- 8:36 AM Changeset in webkit [79226] by
-
- 1 edit in trunk/Source/WebCore/WebCore.pro
Another followup to 79223: correct QT project file
- 8:18 AM Changeset in webkit [79225] by
-
- 1 add in trunk/Source/WebCore/bindings/js/JSDOMImplementationCustom.cpp
Followup to 79223: forgotten file
- 8:13 AM Changeset in webkit [79224] by
-
- 2 edits in trunk/Source/WebKit2
2011-02-21 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Implement WorkQueue::sheduleWorkAfterDelay
https://bugs.webkit.org/show_bug.cgi?id=54878
- Platform/qt/WorkQueueQt.cpp: (WorkQueue::scheduleWorkAfterDelay):
- 8:01 AM Changeset in webkit [79223] by
-
- 17 edits in trunk
2011-02-08 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth and Alexey Proskuryakov.
Propagate security origin of parent document into HTML documents created with DOMImplementation
https://bugs.webkit.org/show_bug.cgi?id=53611
This restores invariant that JS wrappers residing in the same JS context should come
from the same security origin.
Absence of regressions is covered by the current tests. Different security origin of
DOMImplementation is difficult to check with layout tests as DOMImplementation
resides in the same JS context as parent document and therefore there are no security origin checks.
This is observable however in C++.
- Android.jscbindings.mk:
- CMakeLists.txt:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/v8/V8GCController.cpp: (WebCore::NodeGrouperVisitor::visitDOMWrapper):
- dom/DOMImplementation.cpp: (WebCore::DOMImplementation::DOMImplementation): (WebCore::DOMImplementation::createDocument):
- dom/DOMImplementation.h: (WebCore::DOMImplementation::create): (WebCore::DOMImplementation::documentDestroyed): (WebCore::DOMImplementation::parentDocument):
- dom/DOMImplementation.idl:
- dom/Document.cpp: (WebCore::Document::~Document): (WebCore::Document::implementation):
- dom/Document.h:
2011-02-21 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth and Alexey Proskuryakov.
Propagate security origin of parent document into HTML documents created with DOMImplementation
https://bugs.webkit.org/show_bug.cgi?id=53611
Additional test which checks case when parent document can be collected while
its implementation is alive.
- fast/dom/gc-9.html:
- 7:55 AM Changeset in webkit [79222] by
-
- 2 edits in trunk/Source/JavaScriptCore
Export JSObject::s_info from JavaScriptCore.dll
This matches what we do for all other ClassInfo objects that WebCore needs access to.
Fixes <http://webkit.org/b/54881> REGRESSION (r79132): Lots of tests crashing in
JSCell::inherits on Windows
Reviewed by Sam Weinig.
- runtime/JSObject.h: Added JS_EXPORTDATA to s_info.
- 7:03 AM Changeset in webkit [79221] by
-
- 2 edits in trunk/Source/WebCore
2011-02-21 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: [Text editor] Optimize editing updates in gutter panel
https://bugs.webkit.org/show_bug.cgi?id=54866
- inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype.set startEditingListener): (WebInspector.TextViewer.prototype.set endEditingListener): (WebInspector.TextViewer.prototype.endUpdates): (WebInspector.TextViewer.prototype._enterInternalTextChangeMode): (WebInspector.TextViewer.prototype._exitInternalTextChangeMode): (WebInspector.TextEditorChunkedPanel.prototype._chunkNumberForLine): (WebInspector.TextEditorGutterPanel.prototype._expandChunks): (WebInspector.TextEditorGutterPanel.prototype.textChanged): (WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
- 6:44 AM Changeset in webkit [79220] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Fixed the change log entry for r79219.
- 6:42 AM Changeset in webkit [79219] by
-
- 2 edits in trunk/LayoutTests
2011-02-21 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [Audits] Image dimensions in inline style not checked
https://bugs.webkit.org/show_bug.cgi?id=54738
- inspector/audits/audits-panel-functional-expected.txt:
- inspector/audits/audits-panel-functional.html:
- 6:40 AM Changeset in webkit [79218] by
-
- 5 edits in trunk
2011-02-21 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [Audits] Image dimensions in inline style not checked
https://bugs.webkit.org/show_bug.cgi?id=54738
- inspector/audits/audits-panel-functional-expected.txt:
- inspector/audits/audits-panel-functional.html:
2011-02-21 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [Audits] Image dimensions in inline style not checked
https://bugs.webkit.org/show_bug.cgi?id=54738
- inspector/front-end/AuditRules.js: (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
- 6:38 AM Changeset in webkit [79217] by
-
- 14 edits1 add in trunk/Source/WebCore
2011-02-21 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: create and destroy DOM agent along with InspectorAgent
https://bugs.webkit.org/show_bug.cgi?id=54875
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- inspector/InstrumentingAgents.h: Added. Agents that want to instrument WebCore should register themselve on this object. (WebCore::InstrumentingAgents::InstrumentingAgents): (WebCore::InstrumentingAgents::~InstrumentingAgents): (WebCore::InstrumentingAgents::inspectorBrowserDebuggerAgent): (WebCore::InstrumentingAgents::setInspectorBrowserDebuggerAgent): (WebCore::InstrumentingAgents::inspectorConsoleAgent): (WebCore::InstrumentingAgents::setInspectorConsoleAgent): (WebCore::InstrumentingAgents::inspectorDOMAgent): (WebCore::InstrumentingAgents::setInspectorDOMAgent): (WebCore::InstrumentingAgents::inspectorDOMStorageAgent): (WebCore::InstrumentingAgents::setInspectorDOMStorageAgent): (WebCore::InstrumentingAgents::inspectorDatabaseAgent): (WebCore::InstrumentingAgents::setInspectorDatabaseAgent): (WebCore::InstrumentingAgents::inspectorDebuggerAgent): (WebCore::InstrumentingAgents::setInspectorDebuggerAgent): (WebCore::InstrumentingAgents::inspectorProfilerAgent): (WebCore::InstrumentingAgents::setInspectorProfilerAgent): (WebCore::InstrumentingAgents::inspectorResourceAgent): (WebCore::InstrumentingAgents::setInspectorResourceAgent): (WebCore::InstrumentingAgents::inspectorRuntimeAgent): (WebCore::InstrumentingAgents::setInspectorRuntimeAgent): (WebCore::InstrumentingAgents::inspectorStorageAgent): (WebCore::InstrumentingAgents::setInspectorStorageAgent): (WebCore::InstrumentingAgents::inspectorTimelineAgent): (WebCore::InstrumentingAgents::setInspectorTimelineAgent):
- inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::setFrontend): (WebCore::InspectorAgent::disconnectFrontend): (WebCore::InspectorAgent::createFrontendLifetimeAgents): (WebCore::InspectorAgent::releaseFrontendLifetimeAgents): (WebCore::InspectorAgent::didCommitLoad): (WebCore::InspectorAgent::domContentLoadedEventFired): (WebCore::InspectorAgent::loadEventFired):
- inspector/InspectorAgent.h:
- inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::InspectorCSSAgent): (WebCore::InspectorCSSAgent::~InspectorCSSAgent):
- inspector/InspectorCSSAgent.h:
- inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::InspectorConsoleAgent): (WebCore::InspectorConsoleAgent::~InspectorConsoleAgent): (WebCore::InspectorConsoleAgent::clearConsoleMessages): (WebCore::InspectorConsoleAgent::clearFrontend): (WebCore::InspectorConsoleAgent::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorConsoleAgent::setMonitoringXHREnabled): (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled): (WebCore::InspectorConsoleAgent::addConsoleMessage):
- inspector/InspectorConsoleAgent.h:
- inspector/InspectorDOMAgent.cpp: DOM agent now lives even when the front-end is not attached. (WebCore::InspectorDOMAgent::InspectorDOMAgent): (WebCore::InspectorDOMAgent::setFrontend): Add DOM agent to the set of active agents when the front-end is attached. (WebCore::InspectorDOMAgent::clearFrontend):
- inspector/InspectorDOMAgent.h: (WebCore::InspectorDOMAgent::create):
- 6:33 AM Changeset in webkit [79216] by
-
- 1 edit1 delete in trunk/LayoutTests
2011-02-21 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r79029.
http://trac.webkit.org/changeset/79029
https://bugs.webkit.org/show_bug.cgi?id=54869
Revert unnecessary Chromium rebaseline (Requested by apavlov
on #webkit).
- platform/chromium-win/inspector/styles-update-from-js-expected.txt: Removed.
- 6:29 AM Changeset in webkit [79215] by
-
- 3 edits in trunk/Source/WebKit/gtk
2011-02-21 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
[GTK] [REGRESSION] After r79130, spell tests did not work
https://bugs.webkit.org/show_bug.cgi?id=54860
- WebCoreSupport/TextCheckerClientEnchant.cpp: (WebKit::TextCheckerClientEnchant::checkSpellingOfString): Avoided freeing the default PangoLanguage.
- webkit/webkitwebview.cpp: (webkit_web_view_update_settings): Initialized list of dictionaries.
- 6:16 AM Changeset in webkit [79214] by
-
- 2 edits in trunk/LayoutTests
2011-02-21 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed; Skip fast/events/menu-keydown-on-hidden-element.html on Mac WebKit 2 since it requires EventSender.
- platform/mac-wk2/Skipped:
- 6:07 AM Changeset in webkit [79213] by
-
- 2 edits in trunk/LayoutTests
2011-02-21 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed; Remove incorrect Chromium test expectations.
- platform/chromium/test_expectations.txt:
- 5:27 AM Changeset in webkit [79212] by
-
- 2 edits in trunk/LayoutTests
2011-02-21 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed; Skip fast/events/selectionchange-user-initiated.html added by r79208 on Mac WebKit 2.
- platform/mac-wk2/Skipped:
- 5:10 AM Changeset in webkit [79211] by
-
- 3 edits in trunk/Source/JavaScriptCore
2011-02-21 Kristian Amlie <kristian.amlie@nokia.com>
Reviewed by Andreas Kling.
Switched to compiler based detection, where the error actually is.
It is not the platform that needs the workaround, it is the compiler.
QtWebKit fails to compile on Windows XP with msvc-2008
https://bugs.webkit.org/show_bug.cgi?id=54746
- bytecode/CodeBlock.h:
- runtime/RegExpObject.h:
- 5:05 AM Changeset in webkit [79210] by
-
- 2 edits in trunk/Source/WebCore
[Qt][V8]REGRESSION(r79157): Fix build
https://bugs.webkit.org/show_bug.cgi?id=54871
Reviewed by Andreas Kling.
- bridge/npruntime_internal.h: Add one more undef because of evil X11 macro.
- 3:49 AM Changeset in webkit [79209] by
-
- 5 edits in trunk
2011-02-16 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Mihai Parparita.
[V8] SerializedScriptValue: fix JS exception handling.
https://bugs.webkit.org/show_bug.cgi?id=54555
Added checks for exceptions and empty handles:
- bindings/v8/SerializedScriptValue.cpp: (WebCore::Serializer::Serializer): (WebCore::Serializer::serialize): (WebCore::Serializer::checkException): (WebCore::Serializer::reportFailure): (WebCore::Serializer::ArrayState::advance): (WebCore::Serializer::AbstractObjectState::AbstractObjectState): (WebCore::Serializer::AbstractObjectState::advance): (WebCore::Serializer::push): (WebCore::Serializer::handleError): (WebCore::Serializer::newObjectState): (WebCore::Serializer::doSerialize): (WebCore::SerializedScriptValue::SerializedScriptValue):
2011-02-16 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Mihai Parparita.
[V8] SerializedScriptValue: fix JS exception handling.
https://bugs.webkit.org/show_bug.cgi?id=54555
Added an exception throwing test case:
- fast/dom/Window/window-postmessage-clone-expected.txt:
- fast/dom/Window/window-postmessage-clone.html:
- 3:24 AM Changeset in webkit [79208] by
-
- 9 edits4 adds in trunk
2011-02-21 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
Add selectionchange event
https://bugs.webkit.org/show_bug.cgi?id=45712
Added a test to ensure WebKit fires selectionchange event for the correct document
when the document has an iframe, and a test to ensure selectionchange events are fired
on user-initiated events.
- fast/events/selectionchange-iframe-expected.txt: Added.
- fast/events/selectionchange-iframe.html: Added.
- fast/events/selectionchange-user-initiated-expected.txt: Added.
- fast/events/selectionchange-user-initiated.html: Added.
2011-02-21 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
Add selectionchange event
https://bugs.webkit.org/show_bug.cgi?id=45712
Added the support for asynchronous selectionchange event, which is fired whenever selection is changed.
This event is not cancelable and does not bubble. An event listener can be attached to a document by
body element's onselectionchange attribute or via document's onselectionchange property.
Note that WebKit's implementation fires the event asynchronously whereas Internet Explorer's implementation
fires it synchronously. This implies that a script that modify selection (e.g. via selection's addRange)
will not observe the event before the control returns to JavaScript.
See also: http://msdn.microsoft.com/en-us/library/ms536968(VS.85).aspx
Tests: fast/events/selectionchange-iframe.html
fast/events/selectionchange-user-initiated.html
- dom/Document.cpp: (WebCore::Document::enqueueDocumentEvent): Added.
- dom/Document.h: Added selectionchange event listener.
- dom/Document.idl: Added onselectionchagne attribute.
- dom/EventNames.h: Added selectionchange
- editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): Fires selectionchange event.
- html/HTMLAttributeNames.in: Added onselectionchange.
- html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::parseMappedAttribute): Handles onselectionchange attribute.
- 3:20 AM Changeset in webkit [79207] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
REGRESSION(r79157): plugins/get-url-with-javascript-destroying-plugin.html make the next test crash
https://bugs.webkit.org/show_bug.cgi?id=54863
- platform/qt/Skipped: Unskip the innocent plugins/get-user-agent-with-null-npp-from-npp-new.html
and skip the real culprit plugins/get-url-with-javascript-destroying-plugin.html until fix.
- 3:16 AM Changeset in webkit [79206] by
-
- 2 edits in trunk/Source/WebCore
2011-02-21 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: protocol error messages are dumping incorrectly in Layout tests.
https://bugs.webkit.org/show_bug.cgi?id=54859
- inspector/CodeGeneratorInspector.pm:
- 3:12 AM Changeset in webkit [79205] by
-
- 18 edits in trunk/LayoutTests
2011-02-21 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [Chromium] inspector/debugger/dom-breakpoints.html TIMEOUTs
https://bugs.webkit.org/show_bug.cgi?id=54638
- http/tests/inspector/change-iframe-src.html:
- http/tests/inspector/debugger-test.js: (initialize_DebuggerTest.InspectorTest.startDebuggerTest.startTest): (initialize_DebuggerTest.InspectorTest.startDebuggerTest): (initialize_DebuggerTest.InspectorTest.completeDebuggerTest.disableDebugger): (initialize_DebuggerTest.InspectorTest.runDebuggerTestSuite.runner): (initialize_DebuggerTest.InspectorTest.runDebuggerTestSuite): (initialize_DebuggerTest.InspectorTest.waitUntilPaused): (initialize_DebuggerTest.InspectorTest.waitUntilPausedAndDumpStack.step1): (initialize_DebuggerTest.InspectorTest.waitUntilPausedAndDumpStack): (initialize_DebuggerTest.InspectorTest.waitUntilResumed): (initialize_DebuggerTest.InspectorTest.resumeExecution): (initialize_DebuggerTest.InspectorTest.showScriptSource): (initialize_DebuggerTest.InspectorTest._showScriptSource): (initialize_DebuggerTest.InspectorTest.expandProperties.expandNextPath): (initialize_DebuggerTest.InspectorTest.expandProperties):
- http/tests/inspector/elements-test.js: (initialize_ElementTest.InspectorTest.nodeWithId.processChildren): (initialize_ElementTest.InspectorTest.nodeWithId): (initialize_ElementTest.InspectorTest.selectNodeWithId.mycallback): (initialize_ElementTest.InspectorTest.selectNodeWithId): (initialize_ElementTest.InspectorTest.expandElementsTree.mycallback): (initialize_ElementTest.InspectorTest.expandElementsTree): (initialize_ElementTest):
- http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.evaluateInConsole): (initialize_InspectorTest.InspectorTest.evaluateInConsoleAndDump.mycallback): (initialize_InspectorTest.InspectorTest.evaluateInConsoleAndDump): (initialize_InspectorTest.InspectorTest.evaluateInPage.mycallback): (initialize_InspectorTest.InspectorTest.evaluateInPage): (initialize_InspectorTest.InspectorTest.evaluateInPageWithTimeout): (initialize_InspectorTest.InspectorTest.reloadPage): (initialize_InspectorTest.InspectorTest.runAfterPendingDispatches): (initialize_InspectorTest.InspectorTest.runTestSuite.runner): (initialize_InspectorTest.InspectorTest.runTestSuite): (initialize_InspectorTest.InspectorTest.safeWrap):
- http/tests/inspector/resource-parameters.html:
- inspector/console/console-assert.html:
- inspector/console/console-trace-in-eval.html:
- inspector/console/console-trace.html:
- inspector/debugger/dom-breakpoints-expected.txt:
- inspector/debugger/dom-breakpoints.html:
- inspector/extensions/extensions-audits-tests.js: (initialize_ExtensionsAuditsTest.InspectorTest.startExtensionAudits): (initialize_ExtensionsAuditsTest):
- inspector/styles/styles-iframe.html:
- inspector/styles/styles-update-from-js.html:
- inspector/timeline/timeline-network-resource.html:
- inspector/timeline/timeline-script-tag-1.html:
- inspector/timeline/timeline-script-tag-2.html:
- platform/chromium/test_expectations.txt:
- 3:03 AM Changeset in webkit [79204] by
-
- 2 edits in trunk/Source/WebCore
2011-02-21 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: generate protocol documentation based on IDL.
https://bugs.webkit.org/show_bug.cgi?id=54822
- inspector/CodeGeneratorInspector.pm:
- 2:55 AM Changeset in webkit [79203] by
-
- 2 edits in trunk/LayoutTests
2011-02-21 Alejandro G. Castro <alex@igalia.com>
Fixed typo in gtk Skipped list.
- platform/gtk/Skipped:
- 2:40 AM Changeset in webkit [79202] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
[Qt]REGRESSION(r79157): plugins/get-user-agent-with-null-npp-from-npp-new.html crashes
https://bugs.webkit.org/show_bug.cgi?id=54863
Paper over one more regression to make Qt buildbot happy and green.
- platform/qt/Skipped: Add plugins/get-user-agent-with-null-npp-from-npp-new.html until fix.
- 2:19 AM Changeset in webkit [79201] by
-
- 2 edits in trunk/LayoutTests
2011-02-18 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
[GTK] media/audio-delete-while-slider-thumb-clicked.html still flaky
https://bugs.webkit.org/show_bug.cgi?id=54747
- media/audio-delete-while-slider-thumb-clicked.html: Autoplay the media element and trigger the seek after playback started.
- 2:12 AM Changeset in webkit [79200] by
-
- 2 edits in trunk/Source/WebCore
2011-02-21 Andoni Morales Alastruey <amorales@flumotion.com>
Reviewed by Martin Robinson.
[GStreamer] Add URI queries support in webkitwebsrc
https://bugs.webkit.org/show_bug.cgi?id=54627
This allow replying to URI queries from downstream elements
with the uri currently set in the source element.
No new tests, this feature is dedicated to internal GStreamer use,
such as the upcoming HTTP Live Streaming element.
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: (webKitWebSrcQuery):
- 2:11 AM Changeset in webkit [79199] by
-
- 1 edit7 adds in trunk/LayoutTests
2011-02-21 MORITA Hajime <morrita@google.com>
Unreviewed expectation update.
- platform/chromium-linux/animations/3d/matrix-transform-type-animation-expected.checksum: Added.
- platform/chromium-linux/animations/3d/matrix-transform-type-animation-expected.png: Added.
- platform/chromium-mac/animations/3d/matrix-transform-type-animation-expected.checksum: Added.
- platform/chromium-mac/animations/3d/matrix-transform-type-animation-expected.png: Added.
- platform/chromium-win/animations/3d/matrix-transform-type-animation-expected.checksum: Added.
- platform/chromium-win/animations/3d/matrix-transform-type-animation-expected.png: Added.
- platform/chromium-win/animations/3d/matrix-transform-type-animation-expected.txt: Added.
- 1:58 AM Changeset in webkit [79198] by
-
- 2 edits3 deletes in trunk/LayoutTests
Unreviewed.
[Qt] Possible DRT bug revealed by r72003
https://bugs.webkit.org/show_bug.cgi?id=49538
After r79103 we don't need Qt specific expected results
$for these tests because of whitespace differences.
- platform/qt/fast/forms/formaction-attribute-expected.txt: Removed.
- platform/qt/fast/forms/formmethod-attribute-button-html-expected.txt: Removed.
- platform/qt/fast/forms/formtarget-attribute-button-html-expected.txt: Removed.
- platform/qt/fast/forms/mailto/formenctype-attribute-button-html-expected.txt: Updated.
- 1:33 AM Changeset in webkit [79197] by
-
- 2 edits in trunk/Source/WebCore
2011-02-21 Andoni Morales Alastruey <amorales@flumotion.com>
Reviewed by Martin Robinson.
[GStreamer] Add 'location' property in webkitwebsrc
https://bugs.webkit.org/show_bug.cgi?id=54628
No new tests, this feature is dedicated to internal GStreamer use,
such as the upcoming HTTP Live Streaming element.
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: (webkit_web_src_class_init): (webKitWebSrcSetProperty): (webKitWebSrcGetProperty):
- 1:28 AM Changeset in webkit [79196] by
-
- 55 edits in trunk/Source
2011-02-17 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
Rename Position::node() to Position::deprecatedNode()
https://bugs.webkit.org/show_bug.cgi?id=54622
Done the rename. All calls to node() are replaced by calls to deprecatedNode().
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::setComposition): Check the nullity of startContainer() instead of startPosition()->node(). (WebKit::WebViewImpl::confirmComposition): Ditto. (WebKit::WebViewImpl::textInputType): (WebKit::WebViewImpl::caretOrSelectionBounds):
2011-02-17 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
Rename Position::node() to Position::deprecatedNode()
https://bugs.webkit.org/show_bug.cgi?id=54622
Replaced the call to node() by a call to containerNode() because the returned node is
used to determine whether or not the selected contents are editable and such a check
must be done against the container node.
- WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleKeyboardEvent):
2011-02-17 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
Rename Position::node() to Position::deprecatedNode()
https://bugs.webkit.org/show_bug.cgi?id=54622
Done the rename. All calls to node() are replaced by calls to deprecatedNode().
- webkit/webkitwebview.cpp: (webkit_web_view_popup_menu_handler):
2011-02-17 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
Rename Position::node() to Position::deprecatedNode()
https://bugs.webkit.org/show_bug.cgi?id=54622
- WebView/WebFrame.mm: (-[WebFrame _smartDeleteRangeForProposedRange:]):
2011-02-17 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
Rename Position::node() to Position::deprecatedNode()
https://bugs.webkit.org/show_bug.cgi?id=54622
Replaced the call to node() by a call to containerNode() because the returned node is
used to determine whether or not the selected contents are editable and such a check
must be done against the container node.
- WebCoreSupport/EditorClientHaiku.cpp: (WebCore::EditorClientHaiku::handleKeyboardEvent):
2011-02-17 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
Rename Position::node() to Position::deprecatedNode()
https://bugs.webkit.org/show_bug.cgi?id=54622
Done the rename. All calls to node() are replaced by calls to deprecatedNode() except when
calls were of the form node()->document() and node()->inDocument() in which case they were
replaced by anchorNode()->document() and anchorNode()->inDocument() respectively.
- WebCore.exp.in: Added Position::containerNode.
The rest abbreviated for simplicity. Please see svn log.
- 1:00 AM Changeset in webkit [79195] by
-
- 2 edits in trunk/LayoutTests
2011-02-21 MORITA Hajime <morrita@google.com>
Another unreviewed attempt to expectation update.
- platform/chromium/test_expectations.txt:
- 12:16 AM Changeset in webkit [79194] by
-
- 2 edits in trunk/Source/WebKit2
2011-02-20 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] Add WebResourceCacheDataManager to the compilation after r78848
https://bugs.webkit.org/show_bug.cgi?id=54732
Added resource cache manager API to GTK+ compilation after r78848.
- GNUmakefile.am:
- 12:12 AM Changeset in webkit [79193] by
-
- 2 edits in trunk/LayoutTests
2011-02-21 MORITA Hajime <morrita@google.com>
Unreviewed expectation update. (Removes invalid lines.)
- platform/chromium/test_expectations.txt:
