⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 26, 2011:

10:53 PM Changeset in webkit [79816] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-26 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

<input value="type=submit"> throws a warning (“HTML parse error”)
​https://bugs.webkit.org/show_bug.cgi?id=55120

This patch removes parse error messages from the HTML parser. These
messages are displayed at the wrong times, aren't tested, and aren't
helpful. We'll try again with some more informative messages and
better testing.

  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::parseError):
7:38 PM Changeset in webkit [79815] by Patrick Gansterer
  • 4 edits in trunk/Source/WebCore

2011-02-26 Patrick Gansterer <Patrick Gansterer>

Reviewed by Alexey Proskuryakov.

Remove registerBaseEncodingNames and registerBaseCodecs from TextCodecBrew
​https://bugs.webkit.org/show_bug.cgi?id=55309

This functions are obsolete, since r78499 added TextCodecUTF8.

  • platform/text/TextEncodingRegistry.cpp: (WebCore::buildBaseTextCodecMaps):
  • platform/text/brew/TextCodecBrew.cpp:
  • platform/text/brew/TextCodecBrew.h:
7:28 PM Changeset in webkit [79814] by commit-queue@webkit.org
  • 2 edits in trunk

2011-02-26 Dihan Wickremasuriya <​dihan.wickremasuriya@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] [Symbian] Disable dependency to a specific version of a Qt package for
non-production builds.
​https://bugs.webkit.org/show_bug.cgi?id=55313

  • Source/WebKit.pri:
6:45 PM Changeset in webkit [79813] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-02-26 Dominic Mazzoni <​dmazzoni@google.com>

Reviewed by Adam Barth.

m_dumpAccessibilityNotifications should be initialized.
​https://bugs.webkit.org/show_bug.cgi?id=54874

  • DumpRenderTree/chromium/AccessibilityController.cpp: (AccessibilityController::AccessibilityController):
3:03 PM Changeset in webkit [79812] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-26 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

Add support for DragonFly BSD
​https://bugs.webkit.org/show_bug.cgi?id=54407

DragonFly BSD is based on FreeBSD, so handle it like FreeBSD.

  • wtf/Platform.h:
2:55 PM Changeset in webkit [79811] by inferno@chromium.org
  • 3 edits in trunk/LayoutTests

2011-02-26 Abhishek Arya <​inferno@chromium.org>

Unreviewed.

Skip the test on QT, GTK until we can figure out the plugin load problem.
​https://bugs.webkit.org/show_bug.cgi?id=55307

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
2:40 PM Changeset in webkit [79810] by jschuh@chromium.org
  • 3 edits
    2 adds in trunk

2011-02-26 Justin Schuh <​jschuh@chromium.org>

Reviewed by Darin Adler.

Delay firing of mutation events while setting attribute values
​https://bugs.webkit.org/show_bug.cgi?id=55199

  • fast/dom/attribute-change-on-mutate-expected.txt: Added.
  • fast/dom/attribute-change-on-mutate.html: Added.

2011-02-26 Justin Schuh <​jschuh@chromium.org>

Reviewed by Darin Adler.

Delay firing of mutation events while setting attribute values
​https://bugs.webkit.org/show_bug.cgi?id=55199

Test: fast/dom/attribute-change-on-mutate.html

  • dom/Attr.cpp: (WebCore::Attr::setValue):
2:38 PM Changeset in webkit [79809] by yi.4.shen@nokia.com
  • 3 edits in trunk/Source/WebCore

2011-02-26 Yi Shen <​yi.4.shen@nokia.com>

Reviewed by Andreas Kling.

[Qt] Notify HTMLMediaElement when MediaPlayerPrivateQt's playback state gets changed
​https://bugs.webkit.org/show_bug.cgi?id=55252

Need to invoke a callback function to notify the HTMLMediaElement
when MediaPlayerPrivateQt's playback state gets changed.

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt): Set a flag to ignore the playback state change for pre-roll (WebCore::MediaPlayerPrivateQt::commitLoad): Call playbackStateChanged() to notify HTMLMediaElement (WebCore::MediaPlayerPrivateQt::stateChanged):
  • platform/graphics/qt/MediaPlayerPrivateQt.h:
1:26 PM Changeset in webkit [79808] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2011-02-25 Abhishek Arya <​inferno@chromium.org>

Reviewed by Adam Barth.

Tests that removing a document during a plugin load does not result
in crash.
​https://bugs.webkit.org/show_bug.cgi?id=55289

  • fast/frames/iframe-plugin-load-remove-document-crash-expected.txt: Added.
  • fast/frames/iframe-plugin-load-remove-document-crash.html: Added.

2011-02-25 Abhishek Arya <​inferno@chromium.org>

Reviewed by Adam Barth.

When plugin document parser finishes parsing, it runs the raw
document's parser finish functions which call the pending document
onload events that removes the frame from underneath. So, we protect
frame (and hence frameloader) in DocumentLoader::commitLoad.
​https://bugs.webkit.org/show_bug.cgi?id=55289

Test: fast/frames/iframe-plugin-load-remove-document-crash.html

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::commitLoad):
1:02 PM Changeset in webkit [79807] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-26 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Asynchronous response to FramePolicyListener is not finishing the load
​https://bugs.webkit.org/show_bug.cgi?id=55305
<rdar://problem/9044356>

Always initialize the receivedPolicyAction reply parameter.

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::decidePolicyForNavigationAction): (WebKit::WebPageProxy::decidePolicyForMIMEType):
12:44 PM Changeset in webkit [79806] by andersca@apple.com
  • 16 edits in trunk/Source/WebKit2

2011-02-26 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

DidFinishLoadingDataForCustomRepresentation should pass along the suggested filename
​https://bugs.webkit.org/show_bug.cgi?id=55304

  • UIProcess/API/mac/PDFViewController.h:
  • UIProcess/API/mac/PDFViewController.mm: (WebKit::PDFViewController::setPDFDocumentData):
  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::didFinishLoadingDataForCustomRepresentation):
  • UIProcess/API/mac/WKView.mm: (-[WKView _didFinishLoadingDataForCustomRepresentationWithSuggestedFilename:dataReference:CoreIPC::]):
  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::didFinishLoadingDataForCustomRepresentation):
  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didFinishLoadingDataForCustomRepresentation):
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/win/WebView.cpp: (WebKit::WebView::didFinishLoadingDataForCustomRepresentation):
  • UIProcess/win/WebView.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::finishedLoading):
12:14 PM Changeset in webkit [79805] by pfeldman@chromium.org
  • 18 edits
    31 deletes in trunk

2011-02-26 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: rolling out 79799 and 79804 for breaking xml tests on mac.

11:58 AM Changeset in webkit [79804] by pfeldman@chromium.org
  • 4 edits in trunk

2011-02-26 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: follow up to r79799. Fixing WinCE+Efl, mute new tests on Qt.
​https://bugs.webkit.org/show_bug.cgi?id=55302

  • CMakeLists.txt:
  • platform/qt/Skipped:
11:10 AM Changeset in webkit [79803] by andersca@apple.com
  • 25 edits in trunk/Source/WebKit2

2011-02-26 Anders Carlsson <​andersca@apple.com>

Reviewed by Oliver Hunt.

DrawingArea should not be reference counted
​https://bugs.webkit.org/show_bug.cgi?id=55284

  • Shared/DrawingAreaInfo.h:
  • Shared/WebPageCreationParameters.cpp: (WebKit::WebPageCreationParameters::encode): (WebKit::WebPageCreationParameters::decode):
  • Shared/WebPageCreationParameters.h:
  • UIProcess/ChunkedUpdateDrawingAreaProxy.cpp: (WebKit::ChunkedUpdateDrawingAreaProxy::ChunkedUpdateDrawingAreaProxy): (WebKit::ChunkedUpdateDrawingAreaProxy::setPageIsVisible): (WebKit::ChunkedUpdateDrawingAreaProxy::update): (WebKit::ChunkedUpdateDrawingAreaProxy::sendSetSize):
  • UIProcess/ChunkedUpdateDrawingAreaProxy.h:
  • UIProcess/DrawingAreaProxy.cpp: (WebKit::DrawingAreaProxy::DrawingAreaProxy):
  • UIProcess/DrawingAreaProxy.h: (WebKit::DrawingAreaProxy::type):
  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl):
  • UIProcess/DrawingAreaProxyImpl.h:
  • UIProcess/TiledDrawingAreaProxy.cpp: (WebKit::TiledDrawingAreaProxy::TiledDrawingAreaProxy):
  • UIProcess/TiledDrawingAreaProxy.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didReceiveSyncMessage): (WebKit::WebPageProxy::creationParameters):
  • WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
  • WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp: (WebKit::ChunkedUpdateDrawingArea::ChunkedUpdateDrawingArea): (WebKit::ChunkedUpdateDrawingArea::display): (WebKit::ChunkedUpdateDrawingArea::setSize): (WebKit::ChunkedUpdateDrawingArea::didReceiveMessage):
  • WebProcess/WebPage/ChunkedUpdateDrawingArea.h:
  • WebProcess/WebPage/DrawingArea.cpp: (WebKit::DrawingArea::create): (WebKit::DrawingArea::DrawingArea):
  • WebProcess/WebPage/DrawingArea.h:
  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::create): (WebKit::DrawingAreaImpl::DrawingAreaImpl):
  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/TiledDrawingArea.cpp: (WebKit::TiledDrawingArea::TiledDrawingArea):
  • WebProcess/WebPage/TiledDrawingArea.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::drawRect):
  • WebProcess/WebPage/WebPage.h:
11:08 AM Changeset in webkit [79802] by commit-queue@webkit.org
  • 5 edits
    1 copy in trunk/Source/WebKit/gtk

2011-02-26 Lukasz Slachciak <​l.slachciak@samsung.com>

Reviewed by Xan Lopez.

[GTK] Implemented API to set/get web application cache directory path database.

  • GNUmakefile.am: Add webkitapplicationcache.h file.
  • webkit/webkit.h: Add webkitapplicationcache.h file.
  • webkit/webkitapplicationcache.cpp: definition of API setting and getting web application cache directory path database. (webkit_application_cache_get_database_directory_path): (webkit_application_cache_set_database_directory_path):
  • webkit/webkitapplicationcache.h: Added new API file for setting and getting web application cache directory path database.
  • webkit/webkitglobals.cpp: (webkitInit): use webkit_application_cache_set_database_directory_path to set default web application cache directory path database.
11:06 AM Changeset in webkit [79801] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-26 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update.

Add failing expectation for fast/images/support-broken-image-delegate.html

  • platform/chromium/test_expectations.txt:
11:00 AM Changeset in webkit [79800] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-26 Mihai Parparita <​mihaip@chromium.org>

Unreviewed update of the Chromium html5lib expectations after r79765
(diff matches the base expectations change).

  • platform/chromium/html5lib/runner-expected.txt:
10:54 AM Changeset in webkit [79799] by pfeldman@chromium.org
  • 17 edits
    36 adds in trunk

2011-02-25 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

XML without style should render as syntax-highlighted source.
​https://bugs.webkit.org/show_bug.cgi?id=13807

Added tests for XML tree view mode. Testing both logic for entering
XML tree view mode and rendering itself.

  • http/tests/xmlviewer/dumpAsText/css-stylesheet-expected.txt: Added.
  • http/tests/xmlviewer/dumpAsText/css-stylesheet.xml: Added.
  • http/tests/xmlviewer/dumpAsText/frames-expected.txt: Added.
  • http/tests/xmlviewer/dumpAsText/frames.html: Added.
  • http/tests/xmlviewer/dumpAsText/mathml-expected.txt: Added.
  • http/tests/xmlviewer/dumpAsText/mathml.xml: Added.
  • http/tests/xmlviewer/dumpAsText/resources/css-stylesheet.css: Added. (assertion):
  • http/tests/xmlviewer/dumpAsText/resources/frames-helper.xml: Added.
  • http/tests/xmlviewer/dumpAsText/resources/xsl.xml: Added.
  • http/tests/xmlviewer/dumpAsText/svg-expected.txt: Added.
  • http/tests/xmlviewer/dumpAsText/svg.xml: Added.
  • http/tests/xmlviewer/dumpAsText/wml-expected.txt: Added.
  • http/tests/xmlviewer/dumpAsText/wml.xml: Added.
  • http/tests/xmlviewer/dumpAsText/xhtml-tag-expected.txt: Added.
  • http/tests/xmlviewer/dumpAsText/xhtml-tag.xml: Added.
  • http/tests/xmlviewer/dumpAsText/xlink-expected.txt: Added.
  • http/tests/xmlviewer/dumpAsText/xlink.xml: Added.
  • http/tests/xmlviewer/dumpAsText/xmlviewer-charset-cp1251-expected.txt: Added.
  • http/tests/xmlviewer/dumpAsText/xmlviewer-charset-cp1251.xml: Added.
  • http/tests/xmlviewer/dumpAsText/xmlviewer-charset-utf8-expected.txt: Added.
  • http/tests/xmlviewer/dumpAsText/xmlviewer-charset-utf8.xml: Added.
  • http/tests/xmlviewer/dumpAsText/xmlviewer-expected.txt: Added.
  • http/tests/xmlviewer/dumpAsText/xmlviewer.xml: Added.
  • http/tests/xmlviewer/dumpAsText/xsl-stylesheet-expected.txt: Added.
  • http/tests/xmlviewer/dumpAsText/xsl-stylesheet.xml: Added.
  • http/tests/xmlviewer/dumpAsText/xul-expected.txt: Added.
  • http/tests/xmlviewer/dumpAsText/xul.xml: Added.
  • platform/chromium/http/tests/xmlviewer/dumpAsText/mathml-expected.txt: Added.

2011-02-25 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

XML without style should render as syntax-highlighted source.
​https://bugs.webkit.org/show_bug.cgi?id=13807

XML tree view mode implemented. If XML does not have any style
information, it is rendered as highlighted source with collapsable
elements.

Tests: http/tests/xmlviewer/dumpAsText/css-stylesheet.xml

http/tests/xmlviewer/dumpAsText/frames.html
http/tests/xmlviewer/dumpAsText/mathml.xml
http/tests/xmlviewer/dumpAsText/svg.xml
http/tests/xmlviewer/dumpAsText/wml.xml
http/tests/xmlviewer/dumpAsText/xhtml-tag.xml
http/tests/xmlviewer/dumpAsText/xlink.xml
http/tests/xmlviewer/dumpAsText/xmlviewer-charset-cp1251.xml
http/tests/xmlviewer/dumpAsText/xmlviewer-charset-utf8.xml
http/tests/xmlviewer/dumpAsText/xmlviewer.xml
http/tests/xmlviewer/dumpAsText/xsl-stylesheet.xml
http/tests/xmlviewer/dumpAsText/xul.xml

  • CMakeLists.txt:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchUARules):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::createElement):
  • dom/Document.h: (WebCore::Document::usesViewSourceStyles): (WebCore::Document::setUsesViewSourceStyles): (WebCore::Document::sawElementsInKnownNamespaces):
  • dom/XMLDocumentParser.h:
  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::XMLDocumentParser): (WebCore::XMLDocumentParser::processingInstruction): (WebCore::XMLDocumentParser::initializeParserContext): (WebCore::XMLDocumentParser::doEnd):
  • dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::XMLDocumentParser): (WebCore::XMLDocumentParser::initializeParserContext): (WebCore::XMLDocumentParser::parseProcessingInstruction):
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
  • xml/XMLTreeViewer.cpp: Added. (WebCore::XMLTreeViewer::XMLTreeViewer): (WebCore::XMLTreeViewer::hasNoStyleInformation): (WebCore::XMLTreeViewer::transformDocumentToTreeView):
  • xml/XMLTreeViewer.h: Added. (WebCore::XMLTreeViewer::~XMLTreeViewer):
  • xml/XMLViewer.xsl: Added.
  • xml/XSLStyleSheet.h: (WebCore::XSLStyleSheet::createFromString):
10:26 AM Changeset in webkit [79798] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk/po

2011-02-26 Christian Dywan <​christian@lanedo.com>

Reviewed by Andreas Kling.

Untranslated network error messages
​https://bugs.webkit.org/show_bug.cgi?id=55223

  • POTFILES: Add FrameLoaderClientGtk.cpp.
9:29 AM Changeset in webkit [79797] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

2011-02-26 Adam Klein <​adamk@chromium.org>

Reviewed by James Robinson.

[chromium] Update op-get-entry filesystem test to match spec
​https://bugs.webkit.org/show_bug.cgi?id=55263

Chromium behavior changed in r76098. This patch updates WebKit test
to match. Both now match the spec, which says of TYPE_MISMATCH_ERR:

user agent MUST use this code when the user has attempted to look up
a file or directory, but the Entry found is of the wrong type

Reference: ​http://dev.w3.org/2009/dap/file-system/file-dir-sys.html#error-code-descriptions

  • fast/filesystem/op-get-entry-expected.txt:
  • fast/filesystem/resources/op-get-entry.js: GetFile/GetDirectory now expected to return TYPE_MISMATCH_ERR if requesting a non-file/non-directory.
  • platform/chromium/test_expectations.txt: Allow op-get-entry to pass while waiting for Chromium roll.
9:26 AM Changeset in webkit [79796] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-26 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations change.

Remove failing Snow Leopard expectations for tests that were fixed by
r79754.

Skip more viewport tests added by r79783.

  • platform/chromium/test_expectations.txt:
9:12 AM Changeset in webkit [79795] by andreas.kling@nokia.com
  • 4 edits in trunk/Source/WebCore

2011-02-26 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Enable usage of synchronous HTTP feature in Qt
​https://bugs.webkit.org/show_bug.cgi?id=37191

Currently, we spin an event loop when doing synchronous calls to
wait for completion. This patch uses synchronous requests in Qt,
if available, and spins the event loop as a fallback solution.

Based on work by Simon Hausmann and Peter Hartmann.

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): (WebCore::QNetworkReplyHandler::start):
  • platform/network/qt/QNetworkReplyHandler.h:
  • platform/network/qt/ResourceHandleQt.cpp: (WebCore::WebCoreSynchronousLoader::setReplyFinished): (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader): (WebCore::WebCoreSynchronousLoader::didFinishLoading): (WebCore::WebCoreSynchronousLoader::didFail): (WebCore::ResourceHandle::loadResourceSynchronously):
9:02 AM Changeset in webkit [79794] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

2011-02-26 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Kent Tamura.

REGRESSION(r79398): Webkit crash on dojo theme tester page
​https://bugs.webkit.org/show_bug.cgi?id=55290

Added a test to ensure WebKit does not crash when querying style value without selection.

  • editing/execCommand/value-without-selection-crash-expected.txt: Added.
  • editing/execCommand/value-without-selection-crash.html: Added.

2011-02-26 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Kent Tamura.

REGRESSION(r79398): Webkit crash on dojo theme tester page
​https://bugs.webkit.org/show_bug.cgi?id=55290

The bug was caused by selectionStartCSSPropertyValue's not considering the possibility
of selectionStartStyle() returning a null pointer. Fixed it by adding a null check.

Test: editing/execCommand/value-without-selection-crash.html

  • editing/Editor.cpp: (WebCore::Editor::selectionStartCSSPropertyValue):
8:31 AM Changeset in webkit [79793] by pfeldman@chromium.org
  • 30 edits in trunk

2011-02-26 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

DumpRenderTree should reset frame opener between tests.
​https://bugs.webkit.org/show_bug.cgi?id=54874

No new tests. (no code affected, just exporting a method for DumpRenderTree use)

  • WebCore.exp.in:

2011-02-26 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

DumpRenderTree should reset frame opener between tests.
​https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener method to WebFrame.

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::clearOpener):
  • src/WebFrameImpl.h:

2011-02-26 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

DumpRenderTree should reset frame opener between tests.
​https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener method to DumpRenderTreeSupportGTK.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::clearOpener):
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

2011-02-26 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

DumpRenderTree should reset frame opener between tests.
​https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener method to WebFramePrivate.

  • WebView/WebFrame.mm: (-[WebFrame _clearOpener]):
  • WebView/WebFramePrivate.h:

2011-02-26 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

DumpRenderTree should reset frame opener between tests.
​https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener method to DumpRenderTreeSupportQT.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::clearOpener):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-02-26 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

DumpRenderTree should reset frame opener between tests.
​https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener method to IWebFramePrivate.
Touched WebKit.idl to trigger build scripts.

  • Interfaces/IWebFramePrivate.idl:
  • Interfaces/WebKit.idl:
  • WebFrame.cpp: (WebFrame::clearOpener):
  • WebFrame.h:

2011-02-26 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

DumpRenderTree should reset frame opener between tests.
​https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener method to WKBundleWebFramePrivate.

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: (WKBundleFrameClearOpener):
  • WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:

2011-02-26 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

DumpRenderTree should reset frame opener between tests.
​https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener() calls between tests.
Some tests are using window.open() to change current window location.
This changes window.opener property whose nullity is checked before
showing xml viewer.

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetTestController):
  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
  • DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
  • DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::reset):
8:20 AM Changeset in webkit [79792] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/Source/WebKit/efl

2011-02-26 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Kent Tamura.

[EFL] Replace WTF_USE_SOUP macro with USE(SOUP)
​https://bugs.webkit.org/show_bug.cgi?id=55296

ewk_cookies.cpp and ewk_main.cpp are using WTF_USE_SOUP macro.
So, according to policy decision macro usage, the macro needs to
be changed with USE(SOUP).

  • ewk/ewk_cookies.cpp: (ewk_cookies_file_set): (ewk_cookies_clear): (ewk_cookies_get_all): (ewk_cookies_cookie_del): (ewk_cookies_cookie_free): (ewk_cookies_policy_set): (ewk_cookies_policy_get):
  • ewk/ewk_main.cpp: (_ewk_init_body):
7:52 AM Changeset in webkit [79791] by yael.aharon@nokia.com
  • 4 edits in trunk

2011-02-26 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Andreas Kling.

[Qt] Fix the focus in MiniBrowser.
​https://bugs.webkit.org/show_bug.cgi?id=55288

Implement basic functionality for focus in QWKPagePrivate.

  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::isViewWindowActive): (QWKPagePrivate::isViewFocused): (QWKPagePrivate::isViewVisible):

2011-02-26 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Andreas Kling.

[Qt] Fix the focus in MiniBrowser.
​https://bugs.webkit.org/show_bug.cgi?id=55288

Give focus to the web view when a load starts.

  • MiniBrowser/qt/BrowserWindow.cpp: (BrowserWindow::urlChanged):
7:48 AM Changeset in webkit [79790] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-26 Jia Pu <​jpu@apple.com>

Reviewed by Dan Bernstein.

On Mac, need to remove misspell underline in Editor::learnSpelling().
​https://bugs.webkit.org/show_bug.cgi?id=55251

This change makes sure that the misspelling markers are removed after the word is learned.

  • editing/Editor.cpp: (WebCore::Editor::learnSpelling):
7:38 AM Changeset in webkit [79789] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Tools

2011-02-26 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Adam Barth.

[EFL] Add coding style exceptions for EFL port
​https://bugs.webkit.org/show_bug.cgi?id=54733

The EFL APIs use EFL naming style, which includes both lower-cased and camel-cased,
underscore-sparated values. But, style checking rule have found parameter_name errors
in efl directories so far.

  • Scripts/webkitpy/style/checker.py: Add prameter_name rule's exception and efl directories.
7:32 AM Changeset in webkit [79788] by abarth@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-26 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

JavaScriptCore should use the xcconfig file instead of importing that information into GYP
​https://bugs.webkit.org/show_bug.cgi?id=55282

Technically, this breaks the build because I had removed one of the
warnings in this config file, but this change seems like an
improvement.

  • gyp/JavaScriptCore.gyp:
7:29 AM Changeset in webkit [79787] by levin@chromium.org
  • 3 edits in trunk/Tools

2011-02-26 David Levin <​levin@chromium.org>

Reviewed by Darin Adler.

check-webkit-style should check for spaces after periods in comments
​https://bugs.webkit.org/show_bug.cgi?id=55253

  • Scripts/webkitpy/style/checkers/cpp.py: Added the check.
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests and fixed the name of one related test.
7:00 AM Changeset in webkit [79786] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-02-26 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: rolling chromium DEPS.

  • DEPS:
6:45 AM Changeset in webkit [79785] by levin@chromium.org
  • 2 edits in trunk/Websites/webkit.org

2011-02-26 David Levin <​levin@chromium.org>

Reviewed by Darin Adler.

Add style guidelines about comments from the unwritten rules email.
​https://bugs.webkit.org/show_bug.cgi?id=55272

  • coding/coding-style.html: Added the guidelines.
6:40 AM Changeset in webkit [79784] by commit-queue@webkit.org
  • 8 edits in trunk

2011-02-26 Rik Cabanier <​cabanier@adobe.com>

Reviewed by David Hyatt.

Fix that allows fixed length values to be floating point
​https://bugs.webkit.org/show_bug.cgi?id=52699

Transitions now return matrices in floating point. 2 of the transition tests were failing
because they expected integer values.

  • transitions/matched-transform-functions.html:
  • transitions/retargetted-transition.html:

2011-02-26 Rik Cabanier <​cabanier@adobe.com>

Reviewed by David Hyatt.

Fix that allows fixed length values to be floating point
​https://bugs.webkit.org/show_bug.cgi?id=52699

Transitions now return matrices in floating point. 2 of the transition tests were failing
because they expected integer values.

  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSStyleSelector.cpp: (WebCore::convertToLength): (WebCore::convertToIntLength): (WebCore::convertToFloatLength): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::createTransformOperations):
  • platform/Length.h: (WebCore::Length::Length): (WebCore::Length::operator==): (WebCore::Length::operator!=): (WebCore::Length::rawValue): (WebCore::Length::type): (WebCore::Length::quirk): (WebCore::Length::setValue): (WebCore::Length::calcFloatValue): (WebCore::Length::isZero): (WebCore::Length::blend): (WebCore::Length::getIntValue): (WebCore::Length::getFloatValue):
  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
  • rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::calcWidthArray):
6:39 AM Changeset in webkit [79783] by kenneth@webkit.org
  • 134 edits
    6 copies in trunk

2011-02-26 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Andreas Kling.

Make it possible to test the targetdensity-dpi support
​https://bugs.webkit.org/show_bug.cgi?id=55142

  • fast/viewport/viewport-*.html: Update to new JS API.
  • fast/viewport/viewport-91.html: Add new tests.
  • fast/viewport/viewport-92.html:
  • fast/viewport/viewport-93.html:
  • fast/viewport/viewport-94.html:
  • fast/viewport/viewport-95.html:
  • fast/viewport/viewport-96.html:

2011-02-26 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Andreas Kling.

Make it possible to test the targetdensity-dpi support
​https://bugs.webkit.org/show_bug.cgi?id=55142

Test the viewport meta tag feature targetdensity-dpi by
adding extra arguments to dumpConfigurationForViewport

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::dumpConfigurationForViewport):
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

2011-02-26 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Andreas Kling.

Make it possible to test the targetdensity-dpi support
​https://bugs.webkit.org/show_bug.cgi?id=55142

Test the viewport meta tag feature targetdensity-dpi by
adding extra arguments to dumpConfigurationForViewport

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::viewportAsText):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-02-26 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Andreas Kling.

Make it possible to test the targetdensity-dpi support
​https://bugs.webkit.org/show_bug.cgi?id=55142

Test the viewport meta tag feature targetdensity-dpi by
adding extra arguments to dumpConfigurationForViewport

Add the new arguments to the shared header and all
implementation.

  • DumpRenderTree/LayoutTestController.cpp: (dumpConfigurationForViewportCallback):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::dumpConfigurationForViewport):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::dumpConfigurationForViewport):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::dumpConfigurationForViewport):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::dumpConfigurationForViewport):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::dumpConfigurationForViewport):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
6:26 AM Changeset in webkit [79782] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/chromium

2011-02-26 Bill Budge <​bbudge@chromium.org>

Reviewed by David Levin.

WebURLRequest, WebURLResponse properties should be passed to WebCore Layer
​https://bugs.webkit.org/show_bug.cgi?id=54489

No tests needed. This is already tested by ui_tests, nacl_ui_tests, and nacl_sandbox_tests

  • src/WebURLRequest.cpp: (WebKit::WebURLRequestPrivateImpl::WebURLRequestPrivateImpl): (WebKit::WebURLRequest::downloadToFile): (WebKit::WebURLRequest::setDownloadToFile):
  • src/WebURLRequestPrivate.h: (WebKit::WebURLRequestPrivate::WebURLRequestPrivate):
  • src/WebURLResponse.cpp: (WebKit::WebURLResponsePrivateImpl::WebURLResponsePrivateImpl): (WebKit::WebURLResponse::downloadFilePath): (WebKit::WebURLResponse::setDownloadFilePath):
  • src/WebURLResponsePrivate.h:
5:59 AM Changeset in webkit [79781] by eric@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-02-26 Eric Seidel <​eric@webkit.org>

Reviewed by Maciej Stachowiak.

malloc in removeChildren shows up on profile of peacekeeper domDynamicCreationCreateElement
​https://bugs.webkit.org/show_bug.cgi?id=55204

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren):
    • Using an inlineCapacity of 10 for now. We may want to tweak it later.
    • This removes yet another malloc from code which removes nodes (which is rather common).
5:47 AM Changeset in webkit [79780] by eric@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-26 Eric Seidel <​eric@webkit.org>

Reviewed by Maciej Stachowiak.

HashSet<T>::end() creation is expensive and should be avoided
​https://bugs.webkit.org/show_bug.cgi?id=55205

In the common case, m_ranges is an empty set. When that's
the case, we spend all our time in skipEmptyBuckets, walking
the hash storage skipping over empty buckets.

This looks to be at least a 5% speedup on (my local version of) peacekeeper's domDynamicCreationCreateElement.

Before:
avg 383.6666666666667
median 386
stdev 7.152311203768722
min 360
max 391

After:
avg 366.3333333333333
median 366
stdev 2.712112747574399
min 362
max 377

  • dom/Document.cpp: (WebCore::Document::nodeChildrenChanged): (WebCore::Document::nodeChildrenWillBeRemoved): (WebCore::Document::nodeWillBeRemoved): (WebCore::Document::textInserted): (WebCore::Document::textRemoved): (WebCore::Document::textNodesMerged): (WebCore::Document::textNodeSplit):
5:15 AM Changeset in webkit [79779] by rniwa@webkit.org
  • 30 edits in trunk

2011-02-26 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r79764.
​http://trac.webkit.org/changeset/79764
​https://bugs.webkit.org/show_bug.cgi?id=55295

"broke Chromium builds" (Requested by rniwa on #webkit).

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetTestController):
  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
  • DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
  • DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::reset):

2011-02-26 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r79764.
​http://trac.webkit.org/changeset/79764
​https://bugs.webkit.org/show_bug.cgi?id=55295

"broke Chromium builds" (Requested by rniwa on #webkit).

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp:
  • src/WebFrameImpl.h:

2011-02-26 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r79764.
​http://trac.webkit.org/changeset/79764
​https://bugs.webkit.org/show_bug.cgi?id=55295

"broke Chromium builds" (Requested by rniwa on #webkit).

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-02-26 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r79764.
​http://trac.webkit.org/changeset/79764
​https://bugs.webkit.org/show_bug.cgi?id=55295

"broke Chromium builds" (Requested by rniwa on #webkit).

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

2011-02-26 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r79764.
​http://trac.webkit.org/changeset/79764
​https://bugs.webkit.org/show_bug.cgi?id=55295

"broke Chromium builds" (Requested by rniwa on #webkit).

  • Interfaces/IWebFramePrivate.idl:
  • Interfaces/WebKit.idl:
  • WebFrame.cpp:
  • WebFrame.h:

2011-02-26 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r79764.
​http://trac.webkit.org/changeset/79764
​https://bugs.webkit.org/show_bug.cgi?id=55295

"broke Chromium builds" (Requested by rniwa on #webkit).

  • WebView/WebFrame.mm:
  • WebView/WebFramePrivate.h:

2011-02-26 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r79764.
​http://trac.webkit.org/changeset/79764
​https://bugs.webkit.org/show_bug.cgi?id=55295

"broke Chromium builds" (Requested by rniwa on #webkit).

  • WebCore.exp.in:

2011-02-26 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r79764.
​http://trac.webkit.org/changeset/79764
​https://bugs.webkit.org/show_bug.cgi?id=55295

"broke Chromium builds" (Requested by rniwa on #webkit).

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
5:14 AM Changeset in webkit [79778] by commit-queue@webkit.org
  • 13 edits
    1 copy
    3 adds in trunk

2011-02-26 Adam Klein <​adamk@chromium.org>

Reviewed by Adam Barth.

[fileapi] Implement EntrySync.toURI by moving Entry::toURI to EntryBase
​https://bugs.webkit.org/show_bug.cgi?id=54585

  • fast/filesystem/resources/file-entry-to-uri-sync.js: Added.
  • fast/filesystem/workers/file-entry-to-uri-sync-expected.txt: Added.
  • fast/filesystem/workers/file-entry-to-uri-sync.html: Added.

2011-02-26 Adam Klein <​adamk@chromium.org>

Reviewed by Adam Barth.

[fileapi] Implement EntrySync.toURI by moving Entry::toURI to EntryBase
​https://bugs.webkit.org/show_bug.cgi?id=54585

In order to move toURI to EntryBase, it needed access to
SecurityOrigin. Most of the changes below were to pass a
ScriptExecutionContext to DOMFileSystemBase to enable this.

Test: fast/filesystem/workers/file-entry-to-uri-sync.html

  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • fileapi/DOMFileSystem.cpp: (WebCore::DOMFileSystem::DOMFileSystem):
  • fileapi/DOMFileSystemBase.cpp: (WebCore::DOMFileSystemBase::DOMFileSystemBase): (WebCore::DOMFileSystemBase::securityOrigin):
  • fileapi/DOMFileSystemBase.h: (WebCore::DOMFileSystemBase::create):
  • fileapi/DOMFileSystemSync.cpp: (WebCore::DOMFileSystemSync::create): (WebCore::DOMFileSystemSync::DOMFileSystemSync):
  • fileapi/DOMFileSystemSync.h: (WebCore::DOMFileSystemSync::create):
  • fileapi/Entry.cpp:
  • fileapi/Entry.h:
  • fileapi/EntryBase.cpp: Added. (WebCore::EntryBase::EntryBase): (WebCore::EntryBase::~EntryBase): (WebCore::EntryBase::toURI):
  • fileapi/EntryBase.h:
  • fileapi/EntrySync.idl:
4:12 AM Changeset in webkit [79777] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-02-26 Alice Boxhall <​aboxhall@chromium.org>

Reviewed by Ojan Vafai.

Tests that typing enter in the input element does not fire textInput.
​https://bugs.webkit.org/show_bug.cgi?id=54152

  • fast/forms/textinput-not-fired-on-enter-in-input-expected.txt: Added.
  • fast/forms/textinput-not-fired-on-enter-in-input.html: Added.

2011-02-26 Alice Boxhall <​aboxhall@chromium.org>

Reviewed by Ojan Vafai.

typing enter in the input element should not fire textInput
​https://bugs.webkit.org/show_bug.cgi?id=54152

Stop textInput event propagation in HTMLInputElement::preDispatchEventHandler if the event target should submit implicitly.

Test: fast/forms/textinput-not-fired-on-enter-in-input.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::preDispatchEventHandler): Check m_inputType->shouldSubmitImplicitly for textInputEvents and stop propagation if true.
4:04 AM Changeset in webkit [79776] by simonjam@chromium.org
  • 4 edits in trunk

2011-02-26 James Simonsen <​simonjam@chromium.org>

Reviewed by Tony Gentilcore.

[Web Timing] loadEvent timing should refer to first load event if there are many
​https://bugs.webkit.org/show_bug.cgi?id=55201

  • fast/dom/script-tests/webtiming-document-open.js: (testTimingWithDocumentOpen): Fire via setTimeout to match w3c test and reveal loadEventEnd. (finishTest): Fire via setTimeout to match w3c test.

2011-02-26 James Simonsen <​simonjam@chromium.org>

Reviewed by Tony Gentilcore.

[Web Timing] loadEvent timing should refer to first load event if there are many
​https://bugs.webkit.org/show_bug.cgi?id=55201

Test: fast/dom/webtiming-document-open.html

  • page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchLoadEvent):
3:20 AM Changeset in webkit [79775] by tonyg@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-02-26 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Adam Barth.

Fix isLayoutTimerActive for ports that set a minimumLayoutDelay
​https://bugs.webkit.org/show_bug.cgi?id=54810

No new tests because no new functionality.

  • dom/Document.cpp: (WebCore::Document::isLayoutTimerActive): Moved from HTMLParserScheduler per FIXME. Compare minimumLayoutDelay() to m_extraLayoutDelay instead of 0. This spirit of this comparison was broken by r52919. The effect would be that ports that set an extra layout delay can't yield between tokens. Note: can't be const because minimumLayoutDelay sets a member.
  • dom/Document.h:
  • html/parser/HTMLParserScheduler.cpp: (WebCore::HTMLParserScheduler::continueNextChunkTimerFired): (WebCore::HTMLParserScheduler::checkForYieldBeforeScript):
2:17 AM Changeset in webkit [79774] by commit-queue@webkit.org
  • 10 edits in trunk/Source

2011-02-26 David Dorwin <​ddorwin@chromium.org>

Reviewed by Darin Fisher.

Enable WebKit Full Screen API in Chromium. The element becomes the full size of the window, but the window is not yet full screen. Support is disabled by default.

fullscreen javascript bindings not implemented for v8
​https://bugs.webkit.org/show_bug.cgi?id=44797

Tested by the existing fullscreen Layout Tests.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:

2011-02-26 David Dorwin <​ddorwin@chromium.org>

Reviewed by Darin Fisher.

Enable WebKit Full Screen API in Chromium. The element becomes the full size of the window, but the window is not yet full screen. Support is disabled by default.

fullscreen javascript bindings not implemented for v8
​https://bugs.webkit.org/show_bug.cgi?id=44797

  • features.gypi:
  • public/WebSettings.h:
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::supportsFullScreenForElement): (WebKit::ChromeClientImpl::enterFullScreenForElement): (WebKit::ChromeClientImpl::exitFullScreenForElement): (WebKit::ChromeClientImpl::fullScreenRendererChanged):
  • src/ChromeClientImpl.h:
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setFullScreenEnabled):
  • src/WebSettingsImpl.h:
2:11 AM Changeset in webkit [79773] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-26 Thouraya ANDOLSI <​thouraya.andolsi@st.com>

Reviewed by Nikolas Zimmermann.

SH4 JIT SUPPORT
​https://bugs.webkit.org/show_bug.cgi?id=44329

Provide an ExecutableAllocater::cacheFlush() implementation for
Linux/SH4.

  • jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::cacheFlush):
1:45 AM Changeset in webkit [79772] by tonyg@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-02-26 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Adam Barth.

Prevent parser yields from triggering early dumpAsText()
​https://bugs.webkit.org/show_bug.cgi?id=55187

DRT's dumpAsText() takes a snapshot when DocumentLoader::isLoadingInAPISense()
indicates the page is done. isLoadingInAPISense depends on
HTMLDocumentParser::isProcessingData(), which just checks if the parser is in an
insert() or append().

This means that if the parser is pumping in a resumeParsingAfterScriptExecution() or
resumeParsingAfterYield(), isLoadingInAPISense() may not be blocked. This patch
fixes that by repurposing m_writeNestingLevel as m_pumpSessionNestingLevel and
incrementing it in pumpTokenizer().

When I locally cause the parser to yield after every token, a lot of tests fail
because DRT snapshots too early. This patch fixes those tests, however I'm having
trouble writing a test case that reliably reproduces the problem without this patch
and passes with it (without changing yield constants). This is because it requires
4,096 tokens in a single pump session to yield and (len('<b>' * 4096 = 12k, which
doesn't always happen).

  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::HTMLDocumentParser): (WebCore::HTMLDocumentParser::~HTMLDocumentParser): (WebCore::HTMLDocumentParser::processingData): (WebCore::HTMLDocumentParser::pumpTokenizer): (WebCore::HTMLDocumentParser::insert): (WebCore::HTMLDocumentParser::append):
  • html/parser/HTMLDocumentParser.h: (WebCore::HTMLDocumentParser::inPumpSession): (WebCore::HTMLDocumentParser::shouldDelayEnd):
  • html/parser/HTMLParserScheduler.h: (WebCore::PumpSession::PumpSession):
  • html/parser/NestingLevelIncrementer.h:
1:32 AM Changeset in webkit [79771] by commit-queue@webkit.org
  • 16 edits
    3 adds in trunk

2011-02-26 Yongjun Zhang <​yongjun_zhang@apple.com>

Reviewed by David Kilzer.

​https://bugs.webkit.org/show_bug.cgi?id=48781

Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.

  • fast/images/resources/broken-image-with-invalid-format.png: Added.
  • fast/images/support-broken-image-delegate.html: Added.
  • platform/mac/fast/images/support-broken-image-delegate-expected.txt: Added.

2011-02-26 Yongjun Zhang <​yongjun_zhang@apple.com>

Reviewed by David Kilzer.

​https://bugs.webkit.org/show_bug.cgi?id=48781

Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.

Add a new resource load client method (shouldPaintBrokenImage). WebKit client can decide if WebCore
should paint the default broken image when an image fails to load or decode. The method also passes the
URL of the failed image.

Test: fast/images/support-broken-image-delegate.html

  • loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::shouldPaintBrokenImage):
  • loader/cache/CachedImage.cpp: (WebCore::CachedImage::CachedImage): (WebCore::CachedImage::image): (WebCore::CachedImage::checkShouldPaintBrokenImage): (WebCore::CachedImage::error):
  • loader/cache/CachedImage.h:

2011-02-26 Yongjun Zhang <​yongjun_zhang@apple.com>

Reviewed by David Kilzer.

​https://bugs.webkit.org/show_bug.cgi?id=48781

Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.

Add a new resource load client method (shouldPaintBrokenImage). WebKit client can decide if WebCore
should paint the default broken image when an image fails to load or decode. The method also passes the
URL of the failed image.

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::shouldPaintBrokenImage):
  • WebView/WebDelegateImplementationCaching.h:
  • WebView/WebDelegateImplementationCaching.mm: Added case for passing one object. (CallResourceLoadDelegateReturningBoolean):
  • WebView/WebResourceLoadDelegatePrivate.h:
  • WebView/WebView.mm: (-[WebView _cacheResourceLoadDelegateImplementations]):

2011-02-26 Yongjun Zhang <​yongjun_zhang@apple.com>

Reviewed by David Kilzer.

​https://bugs.webkit.org/show_bug.cgi?id=48781

Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.

Add a new resource load client method (shouldPaintBrokenImage). WebKit client can decide if WebCore
should paint the default broken image when an image fails to load or decode.

  • DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (setShouldPaintBrokenImageCallback): (LayoutTestController::staticFunctions): (LayoutTestController::setShouldPaintBrokenImage):
  • DumpRenderTree/LayoutTestController.h: (LayoutTestController::shouldPaintBrokenImage):
  • DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[ResourceLoadDelegate webView:shouldPaintBrokenImageForURL:]):
1:24 AM Changeset in webkit [79770] by eric@webkit.org
  • 1 edit
    9 deletes in trunk/LayoutTests

2011-02-26 Eric Seidel <​eric@webkit.org>

Reviewed by Alexey Proskuryakov.

Remove disabled xmlhttprequest/web-apps tests
​https://bugs.webkit.org/show_bug.cgi?id=55181

Per ap's suggestion in:
​https://bugs.webkit.org/show_bug.cgi?id=55164#c15

I don't think we've ever run these tests. Some of them
depend on 10 minute timeouts and another nonsense. :)

  • http/tests/xmlhttprequest/web-apps/006-test.cgi: Removed.
  • http/tests/xmlhttprequest/web-apps/006.html-disabled: Removed.
  • http/tests/xmlhttprequest/web-apps/009-test.cgi: Removed.
  • http/tests/xmlhttprequest/web-apps/009.html-disabled: Removed.
  • http/tests/xmlhttprequest/web-apps/016-test.cgi: Removed.
  • http/tests/xmlhttprequest/web-apps/016.html-disabled: Removed.
  • http/tests/xmlhttprequest/web-apps/017.html-disabled: Removed.
  • http/tests/xmlhttprequest/web-apps/recursion/001.html-disabled: Removed.
  • http/tests/xmlhttprequest/web-apps/recursion/README: Removed.
1:16 AM Changeset in webkit [79769] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-26 Chris Evans <​cevans@chromium.org>

Reviewed by Adam Barth.

Database: Data race: should only touch the transaction queue inside the
lock.
​https://bugs.webkit.org/show_bug.cgi?id=55031

  • storage/Database.cpp: (WebCore::Database::changeVersion): only touch queue inside lock. (WebCore::Database::runTransaction): only touch queue inside lock.
1:03 AM Changeset in webkit [79768] by yi.4.shen@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-02-26 Yi Shen <​yi.4.shen@nokia.com>

Reviewed by Eric Carlson.

Missing volumechangeEvent in case of mediaPlayerVolumeChanged gets callback
​https://bugs.webkit.org/show_bug.cgi?id=55147

When HTMLMediaElement::mediaPlayerVolumeChanged() gets callback,
a volumechangeEvent event should be fired if the volume gets changed.

Test: media/event-attributes.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setMuted): Remove updateVolume() since it does nothing when m_player is 0. (WebCore::HTMLMediaElement::mediaPlayerVolumeChanged): Fire a volumechangeEvent when the volume is changed.
12:59 AM Changeset in webkit [79767] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-02-26 John Mellor <​johnme@chromium.org>

Reviewed by Antonio Gomes.

[chromium] WebFrameImpl::m_totalMatchCount should be an int
​https://bugs.webkit.org/show_bug.cgi?id=55134

WebFrameImpl::m_totalMatchCount should be an int instead of a size_t since it can be -1.

  • src/WebFrameImpl.h:
12:41 AM Changeset in webkit [79766] by eric@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-26 Eric Seidel <​eric@webkit.org>

Reviewed by Maciej Stachowiak.

disableRangeMutation quirk for mail slows down peacekeeper domDynamicCreationCreateElement
​https://bugs.webkit.org/show_bug.cgi?id=55127

Before:
avg 513.4
median 515
stdev 7.234638899074368
min 490
max 528

After:
avg 508.15
median 510
stdev 6.966168243733426
min 485
max 515

Yes, the stdev is a bit high to actually support my conclusions. But looking
at the profile, this change makes a lot of sense. I'll up the iterations
for future testing.

  • dom/Document.cpp: (WebCore::disableRangeMutation):
    • This check should only be compiled in if we're planning to run on Tiger or Leopard.
12:35 AM Changeset in webkit [79765] by abarth@webkit.org
  • 11 edits
    5 adds in trunk/LayoutTests

2011-02-26 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Synchronized tests with html5lib
​https://bugs.webkit.org/show_bug.cgi?id=55128

I didn't copy all of plain-test-unsafe because it confuses pretty-diff.

  • html5lib/resources/pending-spec-changes-plain-text-unsafe.dat:
  • html5lib/resources/pending-spec-changes.dat:
  • html5lib/resources/tests1.dat:
  • html5lib/resources/tests10.dat:
  • html5lib/resources/tests19.dat:
  • html5lib/resources/tests20.dat:
  • html5lib/resources/tests22.dat: Added.
  • html5lib/resources/tests23.dat: Added.
  • html5lib/resources/tests24.dat: Added.
  • html5lib/resources/tests25.dat: Added.
  • html5lib/resources/tests26.dat: Added.
  • html5lib/resources/tests3.dat:
  • html5lib/resources/tests6.dat:
  • html5lib/runner-expected.txt:
  • html5lib/runner.html:
12:16 AM Changeset in webkit [79764] by commit-queue@webkit.org
  • 30 edits in trunk

2011-02-26 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

DumpRenderTree should reset frame opener between tests.
​https://bugs.webkit.org/show_bug.cgi?id=54874

No new tests. (no code affected, just exporting a method for DumpRenderTree use)

  • WebCore.exp.in:

2011-02-26 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

DumpRenderTree should reset frame opener between tests.
​https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener method to WebFrame.

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::clearOpener):
  • src/WebFrameImpl.h:

2011-02-26 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

DumpRenderTree should reset frame opener between tests.
​https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener method to DumpRenderTreeSupportGTK.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::clearOpener):
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

2011-02-26 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

DumpRenderTree should reset frame opener between tests.
​https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener method to WebFramePrivate.

  • WebView/WebFrame.mm: (-[WebFrame _clearOpener]):
  • WebView/WebFramePrivate.h:

2011-02-26 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

DumpRenderTree should reset frame opener between tests.
​https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener method to DumpRenderTreeSupportQT.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::clearOpener):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-02-26 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

DumpRenderTree should reset frame opener between tests.
​https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener method to IWebFramePrivate.
Touched WebKit.idl to trigger build scripts.

  • Interfaces/IWebFramePrivate.idl:
  • Interfaces/WebKit.idl:
  • WebFrame.cpp: (WebFrame::clearOpener):
  • WebFrame.h:

2011-02-26 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

DumpRenderTree should reset frame opener between tests.
​https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener method to WKBundleWebFramePrivate.

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: (WKBundleFrameClearOpener):
  • WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:

2011-02-26 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

DumpRenderTree should reset frame opener between tests.
​https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener() calls between tests.
Some tests are using window.open() to change current window location.
This changes window.opener property whose nullity is checked before
showing xml viewer.

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetTestController):
  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
  • DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
  • DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::reset):
12:13 AM Changeset in webkit [79763] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

2011-02-26 Xianzhu Wang <​wangxianzhu@google.com>

Reviewed by Eric Seidel.

Fix Chromium test failure ​http://crbug.com/33358
​https://bugs.webkit.org/show_bug.cgi?id=55125

  • platform/chromium/test_expectations.txt:
  • platform/chromium/fast/dom/Window/window-postmessage-clone-frames-expected.txt: Added.
12:12 AM Changeset in webkit [79762] by chang.shu@nokia.com
  • 7 edits
    2 adds in trunk

2011-02-26 Chang Shu <​chang.shu@nokia.com>

Reviewed by Antonio Gomes.

Spatial Navigation: Add support for <select> element in multiple selection mode
​https://bugs.webkit.org/show_bug.cgi?id=49261

Enhanced existing tests and added new tests for the bug.

  • fast/spatial-navigation/snav-multiple-select-expected.txt:
  • fast/spatial-navigation/snav-multiple-select.html:
  • fast/spatial-navigation/snav-single-select-list-expected.txt: Added.
  • fast/spatial-navigation/snav-single-select-list.html: Added.

2011-02-26 Chang Shu <​chang.shu@nokia.com>

Reviewed by Antonio Gomes.

Based on patch by Carlos Garcia Campos <​cgarcia@igalia.com>.

Spatial Navigation: Add support for <select> element in multiple selection mode
​https://bugs.webkit.org/show_bug.cgi?id=49261

When spatial navigation is enabled, use space key to toggle select
items. And the up and down keys should not affect selection but just
navigate through items, which is indicated visually by a focus ring.

New Test: fast/spatial-navigation/snav-single-select-list.html
Enhanced Test: fast/spatial-navigation/snav-multiple-select.html

  • dom/SelectElement.cpp: (WebCore::SelectElement::listBoxDefaultEventHandler):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::addFocusRingRects):
  • rendering/RenderListBox.h:

Feb 25, 2011:

11:55 PM Changeset in webkit [79761] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-02-25 Lukasz Slachciak <​l.slachciak@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Added EWebLauncher command line option to turn on/off frame flattening
​https://bugs.webkit.org/show_bug.cgi?id=54809

  • EWebLauncher/main.c: Handling -f option added. (on_key_down): (browserCreate): (main):
11:33 PM Changeset in webkit [79760] by eric@webkit.org
  • 6 edits in trunk/LayoutTests

2011-02-25 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

Make positioned elements work with vertical text
​https://bugs.webkit.org/show_bug.cgi?id=46500

Rebaseline fast/table/fixed-with-auto-with-colspan-vertical.html for r79725.

  • platform/gtk/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt:
  • platform/mac/fast/table/fixed-with-auto-with-colspan-vertical-expected.checksum:
  • platform/mac/fast/table/fixed-with-auto-with-colspan-vertical-expected.png:
  • platform/mac/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt:
  • platform/qt/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt:
9:35 PM Changeset in webkit [79759] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-25 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed Qt build fix; included CSSValueList.h in EditingStyle.cpp.

  • editing/EditingStyle.cpp:
9:26 PM Changeset in webkit [79758] by rniwa@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-02-25 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

Move HTMLEquivalent and its subclasses to EditingStyle
​https://bugs.webkit.org/show_bug.cgi?id=55207

Moved HTMLEquivalent and its subclasses from ApplyStyleCommand to EditingStyle,
and renamed HTMLEquivalent, HTMLEquivalentValueList, HTMLAttributeEquivalent,
and HTMLEquivalentFontSizeAttribute to HTMLElementEquivalent, HTMLTextDecorationEquivalent,
HTMLAttributeEquivalent, and HTMLFontSizeEquivalent respectively.

Also extracted the logic to determine which element and attribute are removed
as conflictsWithImplicitStyleOfElement, conflictsWithImplicitStyleOfAttributes,
and extractConflictingImplicitStyleOfAttributes.

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement):
  • editing/ApplyStyleCommand.h:
  • editing/EditingStyle.cpp: (WebCore::HTMLElementEquivalent::create): Moved from ApplyStyleCommand.cpp. (WebCore::HTMLElementEquivalent::~HTMLElementEquivalent): Ditto. (WebCore::HTMLElementEquivalent::matches): Ditto. (WebCore::HTMLElementEquivalent::hasAttribute): Ditto. (WebCore::HTMLElementEquivalent::propertyExistsInStyle): Ditto. (WebCore::HTMLElementEquivalent::HTMLElementEquivalent): Ditto. (WebCore::HTMLElementEquivalent::valueIsPresentInStyle): Ditto. (WebCore::HTMLElementEquivalent::addToStyle): Ditto. (WebCore::HTMLTextDecorationEquivalent::create): Ditto. (WebCore::HTMLTextDecorationEquivalent::HTMLTextDecorationEquivalent): Ditto. (WebCore::HTMLTextDecorationEquivalent::valueIsPresentInStyle): Ditto. (WebCore::HTMLAttributeEquivalent::create): Ditto. (WebCore::HTMLAttributeEquivalent::matches): Ditto. (WebCore::HTMLAttributeEquivalent::hasAttribute): Ditto. (WebCore::HTMLAttributeEquivalent::attributeName): Ditto. (WebCore::HTMLAttributeEquivalent::HTMLAttributeEquivalent): Ditto. (WebCore::HTMLAttributeEquivalent::valueIsPresentInStyle): Ditto. (WebCore::HTMLAttributeEquivalent::addToStyle): Ditto. (WebCore::HTMLAttributeEquivalent::attributeValueAsCSSValue): Ditto. (WebCore::HTMLFontSizeEquivalent::create): Ditto. (WebCore::HTMLFontSizeEquivalent::HTMLFontSizeEquivalent): Ditto. (WebCore::HTMLFontSizeEquivalent::attributeValueAsCSSValue): Ditto. (WebCore::EditingStyle::conflictsWithImplicitStyleOfElement): Added. (WebCore::htmlAttributeEquivalents): Added. (WebCore::EditingStyle::conflictsWithImplicitStyleOfAttributes): Added. (WebCore::EditingStyle::extractConflictingImplicitStyleOfAttributes): Added.
  • editing/EditingStyle.h:
6:49 PM Changeset in webkit [79757] by jamesr@google.com
  • 2 edits
    21 adds in trunk/LayoutTests

2011-02-25 James Robinson <​jamesr@chromium.org>

Update chromium expectations and add new chromium and mac-leopard baselines for new tests.

  • platform/chromium-linux/fast/block/positioning/differing-writing-modes-expected.checksum: Added.
  • platform/chromium-linux/fast/block/positioning/differing-writing-modes-expected.png: Added.
  • platform/chromium-linux/fast/block/positioning/differing-writing-modes-replaced-expected.checksum: Added.
  • platform/chromium-linux/fast/block/positioning/differing-writing-modes-replaced-expected.png: Added.
  • platform/chromium-linux/fast/table/table-continuation-outline-paint-crash-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-continuation-outline-paint-crash-expected.png: Added.
  • platform/chromium-win/fast/block/positioning/differing-writing-modes-expected.checksum: Added.
  • platform/chromium-win/fast/block/positioning/differing-writing-modes-expected.png: Added.
  • platform/chromium-win/fast/block/positioning/differing-writing-modes-expected.txt: Added.
  • platform/chromium-win/fast/block/positioning/differing-writing-modes-replaced-expected.checksum: Added.
  • platform/chromium-win/fast/block/positioning/differing-writing-modes-replaced-expected.png: Added.
  • platform/chromium-win/fast/block/positioning/differing-writing-modes-replaced-expected.txt: Added.
  • platform/chromium-win/fast/table/table-continuation-outline-paint-crash-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-continuation-outline-paint-crash-expected.png: Added.
  • platform/chromium-win/fast/table/table-continuation-outline-paint-crash-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac-leopard/fast/block/positioning/differing-writing-modes-expected.checksum: Added.
  • platform/mac-leopard/fast/block/positioning/differing-writing-modes-expected.png: Added.
  • platform/mac-leopard/fast/block/positioning/differing-writing-modes-replaced-expected.checksum: Added.
  • platform/mac-leopard/fast/block/positioning/differing-writing-modes-replaced-expected.png: Added.
  • platform/mac-leopard/fast/table/table-continuation-outline-paint-crash-expected.checksum: Added.
  • platform/mac-leopard/fast/table/table-continuation-outline-paint-crash-expected.png: Added.
6:45 PM Changeset in webkit [79756] by mrowe@apple.com
  • 5 edits in trunk/Source

Versioning.

6:18 PM Changeset in webkit [79755] by mrowe@apple.com
  • 1 copy in tags/Safari-534.22

New tag.

6:18 PM Changeset in webkit [79754] by mihaip@chromium.org
  • 79 edits in trunk/LayoutTests

2011-02-25 Mihai Parparita <​mihaip@chromium.org>

Unreviewed rebaseline.

Update mac/ pixel baselines for Snow Leopard (new results match
chromium-mac and/or chromium-mac-leopard ones, which are known to be
good).

  • platform/mac/fast/backgrounds/svg-as-background-5-expected.checksum:
  • platform/mac/fast/backgrounds/svg-as-background-5-expected.png:
  • platform/mac/fast/block/margin-collapse/103-expected.checksum:
  • platform/mac/fast/block/margin-collapse/103-expected.png:
  • platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum:
  • platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.png:
  • platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum:
  • platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.png:
  • platform/mac/fast/css/empty-pseudo-class-expected.checksum:
  • platform/mac/fast/css/empty-pseudo-class-expected.png:
  • platform/mac/fast/css/first-child-pseudo-class-expected.checksum:
  • platform/mac/fast/css/first-child-pseudo-class-expected.png:
  • platform/mac/fast/css/first-of-type-pseudo-class-expected.checksum:
  • platform/mac/fast/css/first-of-type-pseudo-class-expected.png:
  • platform/mac/fast/css/font-face-default-font-expected.checksum:
  • platform/mac/fast/css/font-face-default-font-expected.png:
  • platform/mac/fast/css/font_property_normal-expected.checksum:
  • platform/mac/fast/css/font_property_normal-expected.png:
  • platform/mac/fast/css/last-child-pseudo-class-expected.checksum:
  • platform/mac/fast/css/last-child-pseudo-class-expected.png:
  • platform/mac/fast/css/last-of-type-pseudo-class-expected.checksum:
  • platform/mac/fast/css/last-of-type-pseudo-class-expected.png:
  • platform/mac/fast/css/line-height-font-order-expected.checksum:
  • platform/mac/fast/css/line-height-font-order-expected.png:
  • platform/mac/fast/css/only-child-pseudo-class-expected.checksum:
  • platform/mac/fast/css/only-child-pseudo-class-expected.png:
  • platform/mac/fast/css/only-of-type-pseudo-class-expected.checksum:
  • platform/mac/fast/css/only-of-type-pseudo-class-expected.png:
  • platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.checksum:
  • platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png:
  • platform/mac/fast/dynamic/008-expected.checksum:
  • platform/mac/fast/dynamic/008-expected.png:
  • platform/mac/fast/events/context-no-deselect-expected.checksum:
  • platform/mac/fast/events/context-no-deselect-expected.png:
  • platform/mac/fast/forms/placeholder-position-expected.checksum:
  • platform/mac/fast/forms/placeholder-position-expected.png:
  • platform/mac/fast/html/keygen-expected.checksum:
  • platform/mac/fast/html/keygen-expected.png:
  • platform/mac/fast/lists/dynamic-marker-crash-expected.checksum:
  • platform/mac/fast/lists/dynamic-marker-crash-expected.png:
  • platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.checksum:
  • platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
  • platform/mac/fast/selectors/166-expected.checksum:
  • platform/mac/fast/selectors/166-expected.png:
  • platform/mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.checksum:
  • platform/mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.png:
  • platform/mac/fast/text/international/bidi-linebreak-001-expected.checksum:
  • platform/mac/fast/text/international/bidi-linebreak-001-expected.png:
  • platform/mac/fast/text/international/bidi-linebreak-002-expected.checksum:
  • platform/mac/fast/text/international/bidi-linebreak-002-expected.png:
  • platform/mac/fast/text/international/bidi-linebreak-003-expected.checksum:
  • platform/mac/fast/text/international/bidi-linebreak-003-expected.png:
  • platform/mac/fast/text/international/bidi-mirror-he-ar-expected.checksum:
  • platform/mac/fast/text/international/bidi-mirror-he-ar-expected.png:
  • platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.checksum:
  • platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png:
  • platform/mac/fonts/sans-serif-expected.checksum:
  • platform/mac/fonts/sans-serif-expected.png:
  • platform/mac/svg/custom/text-dom-01-f-expected.checksum:
  • platform/mac/svg/custom/text-dom-01-f-expected.png:
  • platform/mac/tables/mozilla/bugs/bug113235-1-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug113235-1-expected.png:
  • platform/mac/tables/mozilla/bugs/bug113424-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug113424-expected.png:
  • platform/mac/tables/mozilla/bugs/bug1188-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug1188-expected.png:
  • platform/mac/tables/mozilla/bugs/bug1318-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug1318-expected.png:
  • platform/mac/tables/mozilla/bugs/bug16012-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug16012-expected.png:
  • platform/mac/tables/mozilla/bugs/bug2479-2-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/mac/tables/mozilla/bugs/bug8858-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug8858-expected.png:
  • platform/mac/tables/mozilla/core/bloomberg-expected.checksum:
  • platform/mac/tables/mozilla/core/bloomberg-expected.png:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug89315-expected.checksum:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
5:46 PM Changeset in webkit [79753] by Chris Fleizach
  • 2 edits in trunk/Source/WebCore

AX: Add Xcode entries back to the navigator list for Accessibility cpp files
​https://bugs.webkit.org/show_bug.cgi?id=55280

Reviewed by Anders Carlsson.

  • WebCore.xcodeproj/project.pbxproj:
5:46 PM Changeset in webkit [79752] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-25 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler.

Plug-in process crashes when using GuardMalloc
​https://bugs.webkit.org/show_bug.cgi?id=55279
<rdar://problem/9044618>

Update m_environmentPointer after copying the environment variables.


  • UIProcess/Launcher/mac/ProcessLauncherMac.mm: (WebKit::EnvironmentVariables::copyEnvironmentVariables):
5:40 PM Changeset in webkit [79751] by bweinstein@apple.com
  • 3 edits in trunk/WebKitLibraries

Fix linking of Chromium Mac build.

  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
5:34 PM Changeset in webkit [79750] by commit-queue@webkit.org
  • 9 edits in trunk/Source/JavaScriptCore

2011-02-25 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r79627.
​http://trac.webkit.org/changeset/79627
​https://bugs.webkit.org/show_bug.cgi?id=55274

broke worker tests (Requested by olliej on #webkit).

  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • runtime/Heap.cpp: (JSC::Heap::allocate):
  • runtime/Heap.h:
  • runtime/JSCell.h: (JSC::JSCell::JSCell::operator new): (JSC::JSCell::MarkedSpace::sizeClassFor): (JSC::JSCell::MarkedSpace::allocate):
  • runtime/MarkedBlock.h:
  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::MarkedSpace): (JSC::MarkedSpace::allocateBlock): (JSC::MarkedSpace::reset):
  • runtime/MarkedSpace.h: (JSC::MarkedSpace::SizeClass::SizeClass):
5:27 PM Changeset in webkit [79749] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-25 Michael Saboff <​msaboff@apple.com>

Reviewed by Darin Adler.

Leak in JSParser::Scope of ScopeLabelInfo Vector
​https://bugs.webkit.org/show_bug.cgi?id=55249

Changed m_labels to be an OwnPtr<>. Added VectorTraits
and Scope copy constructor to support this change.

  • parser/JSParser.cpp: (JSC::JSParser::Scope::~Scope):
5:18 PM Changeset in webkit [79748] by Darin Adler
  • 2 edits in trunk/Source/WebKit2
  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::launchProcess): Fixed backwards logic from last change.

5:10 PM Changeset in webkit [79747] by Darin Adler
  • 2 edits in trunk/Source/WebKit2
  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::launchProcess): Fixed performance problem in production
builds by only setting DYLD_FRAMEWORK_PATH in engineering configurations.

Reviewed by Mark Rowe.

4:47 PM Changeset in webkit [79746] by Darin Adler
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/8036034> WebKit2 should work even if DYLD_FRAMEWORK_PATH is not set

Reviewed by Anders Carlsson.

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::EnvironmentVariables::~EnvironmentVariables): Use fastFree, not delete, on
the strings here because they are allocated with fastMalloc, not new.
(WebKit::EnvironmentVariables::set): Use const more.
(WebKit::EnvironmentVariables::get): Ditto.
(WebKit::EnvironmentVariables::appendValue): Ditto.
(WebKit::EnvironmentVariables::valueIfVariableHasName): Ditto. Also fix mistake
where this would match if the name matched only a prefix of the environment variable's
name. We want to match the whole name, so we need to use memcmp, not strncmp.
(WebKit::EnvironmentVariables::createStringForVariable): Use const more.
(WebKit::ProcessLauncher::launchProcess): Use clearer name, frameworkExecutablePath,
for what was called bundlePath before. Append the frameworks path to DYLD_FRAMEWORK_PATH,
ensuring we can pick up other frameworks from the same directory in the web process.
Use a const_cast instead of a C-style cast.

4:46 PM Changeset in webkit [79745] by abarth@webkit.org
  • 4 edits in trunk/Source

2011-02-25 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Adam Barth.

WebSocket uses insecure random numbers
​https://bugs.webkit.org/show_bug.cgi?id=54714

2011-02-25 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Adam Barth.

WebSocket uses insecure random numbers
​https://bugs.webkit.org/show_bug.cgi?id=54714

  • websockets/WebSocketHandshake.cpp: (WebCore::randomNumberLessThan): (WebCore::generateSecWebSocketKey): (WebCore::generateKey3):
4:37 PM Changeset in webkit [79744] by eric.carlson@apple.com
  • 6 edits in trunk/Source/WebCore

2011-02-25 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Darin Adler.

Add API to enumerate/delete files downloaded for <audio> and <video>
​https://bugs.webkit.org/show_bug.cgi?id=55267

Add review changes missed in r79737.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::clearMediaCacheForSite): Pass string by reference.
  • html/HTMLMediaElement.h:
  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::clearMediaCacheForSite): Ditto.
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::clearMediaCacheForSite): Ditto.
4:31 PM Changeset in webkit [79743] by Chris Fleizach
  • 2 edits in trunk/Source/WebKit2

AX: WK2: AXApplication not returning the AXFocusedUIElement within the web area
​https://bugs.webkit.org/show_bug.cgi?id=55277

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKView.mm:

(-[WKView accessibilityFocusedUIElement]):

4:25 PM Changeset in webkit [79742] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Reviewed by Anders Carlsson.

​https://bugs.webkit.org/show_bug.cgi?id=55276
WebPage::close() accesses "this" after it is destroyed.

This was making many tests crash with GuardMalloc.

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::close): Access "this" before it can be destroyed, not after.
4:02 PM Changeset in webkit [79741] by Martin Robinson
  • 1 edit
    234 adds in trunk/LayoutTests

2011-02-25 Martin Robinson <​mrobinson@igalia.com>

Add the final set of missing GTK+ SVG pixel results.

  • platform/gtk/svg/dynamic-updates: Add missing results.
4:00 PM Changeset in webkit [79740] by Martin Robinson
  • 1 edit
    202 adds in trunk/LayoutTests

2011-02-25 Martin Robinson <​mrobinson@igalia.com>

Add another set of missing GTK+ SVG pixel results.

  • platform/gtk/svg/dynamic-updates: Add missing pixel results.
3:58 PM Changeset in webkit [79739] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed.
Add missing sources to WebKit2API.pri.

  • WebKit2API.pri:
3:58 PM Changeset in webkit [79738] by Martin Robinson
  • 1 edit
    202 adds in trunk/LayoutTests

2011-02-25 Martin Robinson <​mrobinson@igalia.com>

Add the next set of missing GTK+ SVG pixel results.

  • platform/gtk/svg/dom/SVGRectElement: Add missing pixel reults.
  • platform/gtk/svg/dynamic-updates: Ditto.
3:55 PM Changeset in webkit [79737] by eric.carlson@apple.com
  • 6 edits in trunk/Source/WebCore

2011-02-25 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Darin Adler.

Add API to enumerate/delete files downloaded for <audio> and <video>
​https://bugs.webkit.org/show_bug.cgi?id=55267
<rdar://problem/9049280>

No new tests, this is just the plumbing.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::getSitesInMediaCache): New, call through to MediaPlayer. (WebCore::HTMLMediaElement::clearMediaCache): Ditto. (WebCore::HTMLMediaElement::clearMediaCacheForSite): Ditto.
  • html/HTMLMediaElement.h:
  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::getSitesInMediaCache): New, call through to media engine. (WebCore::MediaPlayer::clearMediaCache): Ditto. (WebCore::MediaPlayer::clearMediaCacheForSite): Ditto.
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::getSitesInMediaCache): Declare new interface. (WebCore::MediaPlayerPrivateInterface::clearMediaCache): Ditto. (WebCore::MediaPlayerPrivateInterface::clearMediaCacheForSite): Ditto.
3:55 PM Changeset in webkit [79736] by Martin Robinson
  • 1 edit
    330 adds in trunk/LayoutTests

2011-02-25 Martin Robinson <​mrobinson@igalia.com>

Add some missing GTK+ SVG pixel results.

  • platform/gtk/svg: Add missing GTK+ SVG pixel results.
3:49 PM Changeset in webkit [79735] by Martin Robinson
  • 43 edits in trunk/LayoutTests

2011-02-25 Martin Robinson <​mrobinson@igalia.com>

Update GTK+ SVG pixel results which have changed.

  • platform/gtk/svg: Update SVG pixel resultsj
3:18 PM Changeset in webkit [79734] by inferno@chromium.org
  • 6 edits
    4 adds in trunk

2011-02-25 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dave Hyatt.

Don't add inline continuation outline to the containing block's
continuationOutlineTable list if it is not enclosed by an anonymous block.
​https://bugs.webkit.org/show_bug.cgi?id=54690

We currently don't reconnect inline continuations after a child removal.
As a result, those merged inlines do not get seperated and hence not get enclosed
by anonymous blocks. In this case, it is better to bail out and paint it ourself.

Test: fast/table/table-continuation-outline-paint-crash.html

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paint):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintsContinuationOutline): helper function to tell if this containing block has the continuation flow in its continuations list.
  • rendering/RenderBlock.h: helper function definition.
  • rendering/RenderInline.cpp: (WebCore::RenderInline::destroy): debug only code that asserts if we leave behind a continuation in the containing block's continuation list when it is getting destroyed.

2011-02-25 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dave Hyatt.

Ensure that we do not add the inline continuation flow to the table's continuation
table map for painting. The layout test should not crash on assert and should show
a solid outline around the inline child.
​https://bugs.webkit.org/show_bug.cgi?id=54690

  • fast/table/table-continuation-outline-paint-crash.html: Added.
  • platform/mac/fast/table/table-continuation-outline-paint-crash-expected.checksum: Added.
  • platform/mac/fast/table/table-continuation-outline-paint-crash-expected.png: Added.
  • platform/mac/fast/table/table-continuation-outline-paint-crash-expected.txt: Added.
2:43 PM Changeset in webkit [79733] by hyatt@apple.com
  • 7 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=55265, remove the unused "Static" type
from Length.

Reviewed by Adam Roben.

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • platform/Length.h:

(WebCore::Length::isFixed):

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::layout):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::isLogicalWidthSpecified):
(WebCore::RenderImage::isLogicalHeightSpecified):

  • rendering/RenderObject.h:

(WebCore::RenderObject::markContainingBlocksForLayout):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::hasStaticX):
(WebCore::InheritedFlags::hasStaticY):

2:36 PM Changeset in webkit [79732] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-25 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler.

A WKView without a window will cause CG errors in the console
​https://bugs.webkit.org/show_bug.cgi?id=55264
<rdar://problem/9044281>

Check that the window has a valid window number before trying to get its graphics context.

  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::containingWindowGraphicsContext):
2:35 PM Changeset in webkit [79731] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2011-02-25 James Robinson <​jamesr@chromium.org>

Update chromium test expectations.

  • platform/chromium/test_expectations.txt:
2:28 PM Changeset in webkit [79730] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-02-25 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r79324.
​http://trac.webkit.org/changeset/79324
​https://bugs.webkit.org/show_bug.cgi?id=55260

Leopard Debug is once again running out of address space while
linking (Requested by aroben on #webkit).

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2:20 PM Changeset in webkit [79729] by bweinstein@apple.com
  • 2 edits in trunk/Source/WebCore

Windows build fix.

  • platform/network/cf/CookieJarCFNet.cpp:

(WebCore::getHostnamesWithCookies): Add a const_cast.
(WebCore::deleteCookiesForHostname): Ditto.

2:14 PM Changeset in webkit [79728] by mihaip@chromium.org
  • 18 edits
    9 moves
    30 deletes in trunk/LayoutTests

2011-02-25 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update.

Fix 16 tests for Chromium Snow Leopard by promoting chromium-mac-leopard
results to mac-leopard and removing outdated chromium-mac and
chromium-mac-snowleopard ones.

  • platform/chromium-mac-leopard/svg/batik/masking/maskRegions-expected.checksum: Removed.
  • platform/chromium-mac-leopard/svg/batik/masking/maskRegions-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/batik/masking/maskRegions-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/custom/absolute-sized-content-with-resources-expected.checksum: Removed.
  • platform/chromium-mac-leopard/svg/custom/absolute-sized-content-with-resources-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/custom/junk-data-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/custom/junk-data-expected.checksum.
  • platform/chromium-mac-leopard/svg/custom/junk-data-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/custom/junk-data-expected.png.
  • platform/chromium-mac-leopard/svg/custom/junk-data-expected.txt: Renamed from LayoutTests/platform/chromium-mac/svg/custom/junk-data-expected.txt.
  • platform/chromium-mac-leopard/svg/custom/missing-xlink-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/custom/missing-xlink-expected.checksum.
  • platform/chromium-mac-leopard/svg/custom/missing-xlink-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/custom/missing-xlink-expected.png.
  • platform/chromium-mac-leopard/svg/custom/missing-xlink-expected.txt: Renamed from LayoutTests/platform/chromium-mac/svg/custom/missing-xlink-expected.txt.
  • platform/chromium-mac-leopard/svg/custom/viewBox-hit-expected.checksum: Removed.
  • platform/chromium-mac-leopard/svg/custom/viewBox-hit-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/filters/filterRes-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/filters/filterRes-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_thead_align_justify-expected.checksum: Removed.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_thead_align_justify-expected.png: Removed.
  • platform/chromium-mac/fast/text/justify-ideograph-simple-expected.checksum:
  • platform/chromium-mac/fast/text/justify-ideograph-simple-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.checksum: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.png: Removed.
  • platform/chromium-mac/svg/batik/masking/maskRegions-expected.checksum: Removed.
  • platform/chromium-mac/svg/batik/masking/maskRegions-expected.png: Removed.
  • platform/chromium-mac/svg/css/text-gradient-shadow-expected.checksum: Removed.
  • platform/chromium-mac/svg/custom/absolute-sized-content-with-resources-expected.checksum: Removed.
  • platform/chromium-mac/svg/custom/absolute-sized-content-with-resources-expected.png: Removed.
  • platform/chromium-mac/svg/custom/viewBox-hit-expected.checksum: Removed.
  • platform/chromium-mac/svg/custom/viewBox-hit-expected.png: Removed.
  • platform/chromium-mac/svg/filters/feComposite-expected.checksum: Removed.
  • platform/chromium-mac/svg/filters/feComposite-expected.png: Removed.
  • platform/chromium-mac/svg/hixie/perf/007-expected.checksum: Removed.
  • platform/chromium-mac/svg/hixie/perf/007-expected.png: Removed.
  • platform/chromium-mac/svg/repaint/filter-repaint-expected.checksum: Removed.
  • platform/chromium-mac/svg/repaint/filter-repaint-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug23235-expected.checksum: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug23235-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/marvin/x_thead_align_justify-expected.checksum: Removed.
  • platform/chromium-mac/tables/mozilla/marvin/x_thead_align_justify-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/97619-expected.checksum: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/text-intro-05-t-expected.checksum:
  • platform/mac-leopard/svg/W3C-SVG-1.1/text-intro-05-t-expected.png:
  • platform/mac-leopard/svg/batik/masking/maskRegions-expected.checksum:
  • platform/mac-leopard/svg/batik/masking/maskRegions-expected.png:
  • platform/mac-leopard/svg/batik/masking/maskRegions-expected.txt: Removed.
  • platform/mac-leopard/svg/custom/absolute-sized-content-with-resources-expected.checksum:
  • platform/mac-leopard/svg/custom/absolute-sized-content-with-resources-expected.png:
  • platform/mac-leopard/svg/custom/viewBox-hit-expected.checksum:
  • platform/mac-leopard/svg/custom/viewBox-hit-expected.png:
  • platform/mac-leopard/tables/mozilla/bugs/bug23235-expected.checksum:
  • platform/mac-leopard/tables/mozilla/bugs/bug23235-expected.png:
  • platform/mac-leopard/tables/mozilla/marvin/x_thead_align_justify-expected.checksum:
  • platform/mac-leopard/tables/mozilla/marvin/x_thead_align_justify-expected.png:
  • platform/mac-leopard/tables/mozilla_expected_failures/bugs/97619-expected.checksum:
  • platform/mac-leopard/tables/mozilla_expected_failures/bugs/97619-expected.png:
2:01 PM Changeset in webkit [79727] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-25 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Empty Elements panel after closing and reopening Inspector
​https://bugs.webkit.org/show_bug.cgi?id=55248

Fixing regression real quick. Test to follow.

  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::reset):
1:58 PM Changeset in webkit [79726] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-25 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: added missing handle scope into V8InjectedScriptHostCustom.
​https://bugs.webkit.org/show_bug.cgi?id=55256

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::nodeAsScriptValue): (WebCore::V8InjectedScriptHost::currentCallFrameCallback):
1:45 PM Changeset in webkit [79725] by hyatt@apple.com
  • 3 edits
    8 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.

Reviewed by Sam Weinig.

Make positioned objects work with all possible crazy combinations of mixed writing modes. Added new helper
functions that flip around the padding box of the containing block and then add in the appropriate border
side to ensure that the offset of the positioned object is actually correctly placed in the containing block's
local coordinate space.

Added two new tests of both replaced and non-replaced positioned elements in mixed writing mode environments.

Source/WebCore:

  • rendering/RenderBox.cpp:

(WebCore::computeLogicalLeftPositionedOffset):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::computeLogicalTopPositionedOffset):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):

LayoutTests:

  • fast/block/positioning/differing-writing-modes-replaced.html: Added.
  • fast/block/positioning/differing-writing-modes.html: Added.
  • platform/mac/fast/block/positioning/differing-writing-modes-expected.checksum: Added.
  • platform/mac/fast/block/positioning/differing-writing-modes-expected.png: Added.
  • platform/mac/fast/block/positioning/differing-writing-modes-expected.txt: Added.
  • platform/mac/fast/block/positioning/differing-writing-modes-replaced-expected.checksum: Added.
  • platform/mac/fast/block/positioning/differing-writing-modes-replaced-expected.png: Added.
  • platform/mac/fast/block/positioning/differing-writing-modes-replaced-expected.txt: Added.
1:45 PM Changeset in webkit [79724] by tony@chromium.org
  • 2 edits
    2 adds in trunk/Tools

2011-02-25 Tony Chang <​tony@chromium.org>

Reviewed by James Robinson.

Clean up temp files left by crashing DRTs on chromium-win
​https://bugs.webkit.org/show_bug.cgi?id=55182

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
  • BuildSlaveSupport/chromium/remove-crash-logs: Added.
1:39 PM Changeset in webkit [79723] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

[Windows 7 Release Tests] http/tests/xmlhttprequest/basic-auth-nouser.html and
basic-auth-nopassword.html failing since introduction in r74609
​https://bugs.webkit.org/show_bug.cgi?id=51596

Unreviewed. Adding http/tests/xmlhttprequest/basic-auth-nopassword.html to the Skipped list
because it is consistently timing out on the Windows XP Debug bot.

  • platform/win-xp/Skipped:
1:22 PM Changeset in webkit [79722] by bweinstein@apple.com
  • 15 edits in trunk/Source

WebKit2: Need a way to manage cookies from the web process
​https://bugs.webkit.org/show_bug.cgi?id=55086

Reviewed by Brady Eidson and looked over by Jessie Berlin.

Source/WebCore:

Implement the functions needed to manage cookies in CookieJar (getHostnamesWithCookies,
deleteCookiesWithHostname, and deleteAllCookies) for Mac and CFNetwork (stub out the rest),
and call them from WebKit2's WebCookieManager.

No change in behavior needing tests.

  • WebCore.exp.in: Added needed functions to export.
  • platform/CookieJar.h:
  • platform/mac/CookieJar.mm:

(WebCore::getHostnamesWithCookies): Gets all hostnames with cookies from NSHTTPCookieStorage.
(WebCore::deleteCookiesForHostname): Deletes all cookies with a given hostname from

NSHTTPCookieStorage.

(WebCore::deleteAllCookies): Deletes all cookies from NSHTTPCookieStorage.

  • platform/network/cf/CookieJarCFNet.cpp:

(WebCore::getHostnamesWithCookies): Implement using CFNetwork cookie APIs.
(WebCore::deleteCookiesForHostname): Ditto.
(WebCore::deleteAllCookies): Ditto.

  • platform/efl/CookieJarEfl.cpp: Added stub functions.
  • platform/haiku/CookieJarHaiku.cpp: Ditto.
  • platform/network/android/CookieJarAndroid.cpp: Ditto.
  • platform/network/chromium/CookieJarChromium.cpp: Ditto.
  • platform/network/curl/CookieJarCurl.cpp: Ditto.
  • platform/network/soup/CookieJarSoup.cpp: Ditto.
  • platform/network/win/CookieJarWin.cpp: Ditto.
  • platform/qt/CookieJarQt.cpp: Ditto.

Source/WebKit2:

Call through to WebCore::CookieJar in our WebCookieManager functions.

  • WebProcess/Cookies/WebCookieManager.cpp:

(WebKit::WebCookieManager::getHostnamesWithCookies):
(WebKit::WebCookieManager::deleteCookiesForHostname):
(WebKit::WebCookieManager::deleteAllCookies):

1:21 PM Changeset in webkit [79721] by mihaip@chromium.org
  • 10 edits
    12 moves
    20 deletes in trunk/LayoutTests

2011-02-25 Mihai Parparita <​mihaip@chromium.org>

Fix 10 tests for Chromium Snow Leopard by promoting chromium-mac-leopard
results to mac-leopard and removing outdated chromium-mac and
chromium-mac-snowleopard ones.

  • platform/chromium-mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/forms/select-baseline-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/forms/select-baseline-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/text/atsui-negative-spacing-features-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/text/atsui-negative-spacing-features-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/text/atsui-spacing-features-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/text/atsui-spacing-features-expected.png: Removed.
  • platform/chromium-mac/fast/blockflow/vertical-baseline-alignment-expected.checksum: Removed.
  • platform/chromium-mac/fast/blockflow/vertical-baseline-alignment-expected.png: Removed.
  • platform/chromium-mac/fast/forms/select-baseline-expected.checksum: Removed.
  • platform/chromium-mac/fast/forms/select-baseline-expected.png: Removed.
  • platform/chromium-mac/fast/forms/text-style-color-expected.checksum: Removed.
  • platform/chromium-mac/fast/forms/text-style-color-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/shadow-breaking-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/shadow-breaking-expected.png: Removed.
  • platform/chromium-mac/fast/table/028-vertical-expected.checksum: Removed.
  • platform/chromium-mac/fast/table/028-vertical-expected.png: Removed.
  • platform/chromium-mac/fast/text/complex-text-opacity-expected.checksum: Removed.
  • platform/chromium-mac/fast/text/complex-text-opacity-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.checksum:
  • platform/mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.png:
  • platform/mac-leopard/fast/dom/isindex-002-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/dom/isindex-002-expected.checksum.
  • platform/mac-leopard/fast/dom/isindex-002-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/dom/isindex-002-expected.png.
  • platform/mac-leopard/fast/dom/replaceChild-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/dom/replaceChild-expected.checksum.
  • platform/mac-leopard/fast/dom/replaceChild-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/dom/replaceChild-expected.png.
  • platform/mac-leopard/fast/forms/select-baseline-expected.checksum:
  • platform/mac-leopard/fast/forms/select-baseline-expected.png:
  • platform/mac-leopard/fast/forms/text-style-color-expected.checksum: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/forms/text-style-color-expected.checksum.
  • platform/mac-leopard/fast/forms/text-style-color-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/forms/text-style-color-expected.png.
  • platform/mac-leopard/fast/multicol/shadow-breaking-expected.checksum: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/multicol/shadow-breaking-expected.checksum.
  • platform/mac-leopard/fast/multicol/shadow-breaking-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/multicol/shadow-breaking-expected.png.
  • platform/mac-leopard/fast/table/028-vertical-expected.checksum:
  • platform/mac-leopard/fast/table/028-vertical-expected.png:
  • platform/mac-leopard/fast/text/atsui-negative-spacing-features-expected.checksum: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/text/atsui-negative-spacing-features-expected.checksum.
  • platform/mac-leopard/fast/text/atsui-negative-spacing-features-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/text/atsui-negative-spacing-features-expected.png.
  • platform/mac-leopard/fast/text/atsui-spacing-features-expected.checksum: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/text/atsui-spacing-features-expected.checksum.
  • platform/mac-leopard/fast/text/atsui-spacing-features-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/text/atsui-spacing-features-expected.png.
  • platform/mac-leopard/fast/text/complex-text-opacity-expected.checksum:
  • platform/mac-leopard/fast/text/complex-text-opacity-expected.png:
1:04 PM Changeset in webkit [79720] by jamesr@google.com
  • 4 edits
    34 adds in trunk/LayoutTests

2011-02-25 James Robinson <​jamesr@chromium.org>

Add chromium win/linux baselines for new vertical replaced test and update various expectations.

  • platform/chromium-gpu-win/platform/chromium/compositing/layout-width-change-expected.checksum:
  • platform/chromium-gpu-win/platform/chromium/compositing/layout-width-change-expected.png:
  • platform/chromium-linux/fast/replaced/vertical-lr/absolute-position-percentage-width-expected.checksum: Added.
  • platform/chromium-linux/fast/replaced/vertical-lr/absolute-position-percentage-width-expected.png: Added.
  • platform/chromium-linux/fast/replaced/vertical-lr/absolute-position-with-auto-height-and-top-and-bottom-expected.checksum: Added.
  • platform/chromium-linux/fast/replaced/vertical-lr/absolute-position-with-auto-height-and-top-and-bottom-expected.png: Added.
  • platform/chromium-linux/fast/replaced/vertical-lr/absolute-position-with-auto-width-and-left-and-right-expected.checksum: Added.
  • platform/chromium-linux/fast/replaced/vertical-lr/absolute-position-with-auto-width-and-left-and-right-expected.png: Added.
  • platform/chromium-linux/fast/replaced/vertical-rl/absolute-position-percentage-width-expected.checksum: Added.
  • platform/chromium-linux/fast/replaced/vertical-rl/absolute-position-percentage-width-expected.png: Added.
  • platform/chromium-linux/fast/replaced/vertical-rl/absolute-position-with-auto-height-and-top-and-bottom-expected.checksum: Added.
  • platform/chromium-linux/fast/replaced/vertical-rl/absolute-position-with-auto-height-and-top-and-bottom-expected.png: Added.
  • platform/chromium-linux/fast/replaced/vertical-rl/absolute-position-with-auto-width-and-left-and-right-expected.checksum: Added.
  • platform/chromium-linux/fast/replaced/vertical-rl/absolute-position-with-auto-width-and-left-and-right-expected.png: Added.
  • platform/chromium-win/fast/replaced/vertical-lr/absolute-position-percentage-width-expected.checksum: Added.
  • platform/chromium-win/fast/replaced/vertical-lr/absolute-position-percentage-width-expected.png: Added.
  • platform/chromium-win/fast/replaced/vertical-lr/absolute-position-percentage-width-expected.txt: Added.
  • platform/chromium-win/fast/replaced/vertical-lr/absolute-position-with-auto-height-and-top-and-bottom-expected.checksum: Added.
  • platform/chromium-win/fast/replaced/vertical-lr/absolute-position-with-auto-height-and-top-and-bottom-expected.png: Added.
  • platform/chromium-win/fast/replaced/vertical-lr/absolute-position-with-auto-height-and-top-and-bottom-expected.txt: Added.
  • platform/chromium-win/fast/replaced/vertical-lr/absolute-position-with-auto-width-and-left-and-right-expected.checksum: Added.
  • platform/chromium-win/fast/replaced/vertical-lr/absolute-position-with-auto-width-and-left-and-right-expected.png: Added.
  • platform/chromium-win/fast/replaced/vertical-lr/absolute-position-with-auto-width-and-left-and-right-expected.txt: Added.
  • platform/chromium-win/fast/replaced/vertical-rl/absolute-position-percentage-width-expected.checksum: Added.
  • platform/chromium-win/fast/replaced/vertical-rl/absolute-position-percentage-width-expected.png: Added.
  • platform/chromium-win/fast/replaced/vertical-rl/absolute-position-percentage-width-expected.txt: Added.
  • platform/chromium-win/fast/replaced/vertical-rl/absolute-position-with-auto-height-and-top-and-bottom-expected.checksum: Added.
  • platform/chromium-win/fast/replaced/vertical-rl/absolute-position-with-auto-height-and-top-and-bottom-expected.png: Added.
  • platform/chromium-win/fast/replaced/vertical-rl/absolute-position-with-auto-height-and-top-and-bottom-expected.txt: Added.
  • platform/chromium-win/fast/replaced/vertical-rl/absolute-position-with-auto-width-and-left-and-right-expected.checksum: Added.
  • platform/chromium-win/fast/replaced/vertical-rl/absolute-position-with-auto-width-and-left-and-right-expected.png: Added.
  • platform/chromium-win/fast/replaced/vertical-rl/absolute-position-with-auto-width-and-left-and-right-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
1:03 PM TriagingTestFailures edited by Adam Roben
Update the crash log URL to match the new URL format. (diff)
1:00 PM BuildingQtOnSymbian edited by siddharth.mathur@nokia.com
changed to armv5 (diff)
12:58 PM TriagingTestFailures edited by Adam Roben
Fix a link (diff)
12:55 PM TriagingTestFailures edited by Adam Roben
Add a link to Darin's email about checking in expected failure results (diff)
12:30 PM Changeset in webkit [79719] by tony@chromium.org
  • 9 edits in trunk

2011-02-25 Tony Chang <​tony@chromium.org>

Unreviewed, updating chromium linux baselines after changes to
RGBToHSL code in chromium.

  • platform/chromium-linux/fast/forms/menulist-restrict-line-height-expected.checksum:
  • platform/chromium-linux/fast/forms/menulist-restrict-line-height-expected.png:
  • platform/chromium-linux/fast/forms/menulist-style-color-expected.checksum:
  • platform/chromium-linux/fast/forms/menulist-style-color-expected.png:
  • platform/chromium-linux/fast/forms/select-baseline-expected.checksum:
  • platform/chromium-linux/fast/forms/select-baseline-expected.png:

2011-02-25 Tony Chang <​tony@chromium.org>

Roll chromium deps to include RBGToHSL fix and ICU update.

  • DEPS:
12:20 PM Changeset in webkit [79718] by eric.carlson@apple.com
  • 4 edits in trunk

2011-02-25 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Eric Seidel.

'load' and 'error' events fired for @poster
​https://bugs.webkit.org/show_bug.cgi?id=54908

  • html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::dispatchLoadEvent): Don't fire events when being used by a video element.

2011-02-25 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Eric Seidel.

'load' and 'error' events fired for @poster
​https://bugs.webkit.org/show_bug.cgi?id=54908

  • media/video-poster.html: Register listeners for 'load' and 'error' events so the test will fail if they ever fire.
12:17 PM Changeset in webkit [79717] by vangelis@chromium.org
  • 1 edit
    4 copies in branches/chromium/648

Merge 79699 - 2011-02-25 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Simon Fraser.

[chromium] Adding test to ensure clipping layer gets updated when layout
width/height change in the page.
​https://bugs.webkit.org/show_bug.cgi?id=55103

  • platform/chromium/compositing/layout-width-change-expected.checksum: Added.
  • platform/chromium/compositing/layout-width-change-expected.png: Added.
  • platform/chromium/compositing/layout-width-change-expected.txt: Added.
  • platform/chromium/compositing/layout-width-change.html: Added.

2011-02-25 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Simon Fraser.

Update the clip layer size whenever the root layer's size and position
is updated. This only affects the accelerated compositing path.
​https://bugs.webkit.org/show_bug.cgi?id=55103

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateRootLayerPosition):

Test: platform/chromium/compositing/layout-width-change.html

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateRootLayerPosition):

TBR=​vangelis@chromium.org
Review URL: ​http://codereview.chromium.org/6597014

12:01 PM Changeset in webkit [79716] by jberlin@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

media/controls-without-preload.html failing on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=50471

Unreviewed. Add Windows-XP specific (failing?) results to get the bots green.

  • platform/win-xp/media/controls-without-preload-expected.txt: Added.
11:57 AM Changeset in webkit [79715] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

2011-02-25 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Option-clicking on links doesn't download them due to sandbox violation
​https://bugs.webkit.org/show_bug.cgi?id=55250
<rdar://problem/9018359>

The change to make DecidePolicyForNavigationAction sync didn't handle the case when the
decided policy was "Download". Fix this by passing along the download ID back to the web process.

  • Platform/CoreIPC/HandleMessage.h: (CoreIPC::callMemberFunction): Add new overload.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::WebPageProxy): Initialize m_syncNavigationActionPolicyDownloadID.

(WebKit::WebPageProxy::receivedPolicyDecision):
Set m_syncNavigationActionPolicyDownloadID to the download ID.

(WebKit::WebPageProxy::decidePolicyForNavigationAction):
Return the m_syncNavigationActionPolicyDownloadID.

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in: Add a DownloadID reply parameter.
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Don't pass a zero download ID to didReceivePolicyDecision.
11:57 AM Changeset in webkit [79714] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-25 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update.

Add recent Snow Leopard failures.

  • platform/chromium/test_expectations.txt:
11:49 AM Changeset in webkit [79713] by mihaip@chromium.org
  • 2 edits
    6 moves
    6 deletes in trunk/LayoutTests

2011-02-25 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update.

Fix fast/inline/inline-box-background-repeat-x.html, fast/inline/
inline-box-background-repeat-y.html and fast/inline/
inline-box-background.html for Chromium Snow Leopard by promoting
chromium-mac-leopard results to mac-leopard and removing outdated
chromium-mac ones.

  • platform/chromium-mac/fast/inline/inline-box-background-expected.checksum: Removed.
  • platform/chromium-mac/fast/inline/inline-box-background-expected.png: Removed.
  • platform/chromium-mac/fast/inline/inline-box-background-repeat-x-expected.checksum: Removed.
  • platform/chromium-mac/fast/inline/inline-box-background-repeat-x-expected.png: Removed.
  • platform/chromium-mac/fast/inline/inline-box-background-repeat-y-expected.checksum: Removed.
  • platform/chromium-mac/fast/inline/inline-box-background-repeat-y-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/mac-leopard/fast/inline/inline-box-background-expected.checksum: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/inline/inline-box-background-expected.checksum.
  • platform/mac-leopard/fast/inline/inline-box-background-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/inline/inline-box-background-expected.png.
  • platform/mac-leopard/fast/inline/inline-box-background-repeat-x-expected.checksum: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/inline/inline-box-background-repeat-x-expected.checksum.
  • platform/mac-leopard/fast/inline/inline-box-background-repeat-x-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/inline/inline-box-background-repeat-x-expected.png.
  • platform/mac-leopard/fast/inline/inline-box-background-repeat-y-expected.checksum: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/inline/inline-box-background-repeat-y-expected.checksum.
  • platform/mac-leopard/fast/inline/inline-box-background-repeat-y-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/inline/inline-box-background-repeat-y-expected.png.
11:47 AM Changeset in webkit [79712] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-25 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

Move timeBeginPeriod into OS(WINDOWS) section
​https://bugs.webkit.org/show_bug.cgi?id=55247

  • jsc.cpp: (main): timeBeginPeriod is available on all Windows versions and not compiler specific.
11:46 AM Changeset in webkit [79711] by alex
  • 6 edits
    2 copies in trunk/Source/WebKit2

2011-02-25 Amruth Raj <​amruthraj@motorola.com> and Ravi Phaneendra Kasibhatla <​ravi.kasibhatla@motorola.com> and Alejandro G. Castro <​alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Implement WebContext and NativeKeyboardEvent classes for WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=48510

  • GNUmakefile.am:
  • Shared/NativeWebKeyboardEvent.h: Added the GTK event attribute and constructors, in our case we need it because we use a pointer and copy the event. (WebKit::NativeWebKeyboardEvent::nativeEvent):
  • Shared/gtk/NativeWebKeyboardEventGtk.cpp: Added. (WebKit::NativeWebKeyboardEvent::NativeWebKeyboardEvent): We need to copy the event in the constructor to avoid two references to the same event.
  • Shared/gtk/WebEventFactory.cpp: Changed the prototype of the functions to add const, we need it for the NativeWebKeyboardEvent constructor. (WebKit::modifiersForEvent): (WebKit::WebEventFactory::createWebKeyboardEvent):
  • UIProcess/gtk/WebContextGtk.cpp: Added. Stubbed implementation for GTK port. Yet to implement. (WebKit::WebContext::applicationCacheDirectory): (WebKit::WebContext::platformInitializeWebProcess): (WebKit::WebContext::platformDefaultDatabaseDirectory):
  • UIProcess/gtk/WebView.cpp: (WebKit::WebView::handleKeyboardEvent):
11:41 AM Changeset in webkit [79710] by mihaip@chromium.org
  • 1 edit
    4 moves
    2 deletes in trunk/LayoutTests

2011-02-25 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update.

Fix fast/dom/34176.html and fast/dom/52776.html for Chromium Snow
Leopard by promoting chromium-mac-leopard results to mac-leopard and
removing outdated chromium-mac ones.

  • platform/chromium-mac-leopard/fast/dom/52776-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/52776-expected.txt: Removed.
  • platform/mac-leopard/fast/dom/34176-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/dom/34176-expected.checksum.
  • platform/mac-leopard/fast/dom/34176-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/dom/34176-expected.png.
  • platform/mac-leopard/fast/dom/52776-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/dom/52776-expected.checksum.
  • platform/mac-leopard/fast/dom/52776-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/dom/52776-expected.png.
11:38 AM Changeset in webkit [79709] by jamesr@google.com
  • 2 edits
    15 adds in trunk/LayoutTests

2011-02-25 James Robinson <​jamesr@chromium.org>

More chromium expectations and baselines.

  • platform/chromium-gpu-linux/platform/chromium/compositing/layout-width-change-expected.checksum: Added.
  • platform/chromium-gpu-linux/platform/chromium/compositing/layout-width-change-expected.png: Added.
  • platform/chromium-gpu-mac/platform/chromium/compositing/layout-width-change-expected.checksum: Added.
  • platform/chromium-gpu-mac/platform/chromium/compositing/layout-width-change-expected.png: Added.
  • platform/chromium-gpu-win/platform/chromium/compositing/layout-width-change-expected.checksum: Added.
  • platform/chromium-gpu-win/platform/chromium/compositing/layout-width-change-expected.png: Added.
  • platform/chromium/test_expectations.txt:
11:28 AM Changeset in webkit [79708] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2011-02-25 James Robinson <​jamesr@chromium.org>

Fix typo in Chromium test expectations.

  • platform/chromium/test_expectations.txt:
11:20 AM Changeset in webkit [79707] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-25 Patrick Gansterer <Patrick Gansterer>

Unreviewed WinCE build fix for r79695.

  • jsc.cpp: (main): SetErrorMode isn't available on WinCE.
11:18 AM Changeset in webkit [79706] by hyatt@apple.com
  • 3 edits
    28 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.

Reviewed by Sam Weinig.

Patch computePositionedLogicalHeightReplaced to be writing-mode aware.

Added six new tests in fast/replaced.

Source/WebCore:

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computePositionedLogicalHeightReplaced):

LayoutTests:

  • fast/replaced/vertical-lr: Added.
  • fast/replaced/vertical-lr/absolute-position-percentage-width.html: Added.
  • fast/replaced/vertical-lr/absolute-position-with-auto-height-and-top-and-bottom.html: Added.
  • fast/replaced/vertical-lr/absolute-position-with-auto-width-and-left-and-right.html: Added.
  • fast/replaced/vertical-rl: Added.
  • fast/replaced/vertical-rl/absolute-position-percentage-width.html: Added.
  • fast/replaced/vertical-rl/absolute-position-with-auto-height-and-top-and-bottom.html: Added.
  • fast/replaced/vertical-rl/absolute-position-with-auto-width-and-left-and-right.html: Added.
11:17 AM Changeset in webkit [79705] by jamesr@google.com
  • 2 edits
    6 adds in trunk/LayoutTests

2011-02-25 James Robinson <​jamesr@chromium.org>

Update chromium expectations and baselines for some ruby tests.

  • platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.png: Added.
  • platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Added.
  • platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Added.
  • platform/chromium/test_expectations.txt:
11:15 AM Changeset in webkit [79704] by mihaip@chromium.org
  • 2 edits
    8 moves
    8 deletes in trunk/LayoutTests

2011-02-25 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update.

Fix editing/selection/caret-rtl* for Chromium Snow Leopard. Remove
outdated chromium-mac baselines (the test will pass on Chromium SL with
the mac/ baselines). Promote the chromium-mac-leopard baselines to
mac-leopard (since the Mac port will pass with them on Leopard).

  • platform/chromium-mac/editing/selection/caret-rtl-2-expected.checksum: Removed.
  • platform/chromium-mac/editing/selection/caret-rtl-2-expected.png: Removed.
  • platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.checksum: Removed.
  • platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.png: Removed.
  • platform/chromium-mac/editing/selection/caret-rtl-expected.checksum: Removed.
  • platform/chromium-mac/editing/selection/caret-rtl-expected.png: Removed.
  • platform/chromium-mac/editing/selection/caret-rtl-right-expected.checksum: Removed.
  • platform/chromium-mac/editing/selection/caret-rtl-right-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/mac-leopard/editing/selection/caret-rtl-2-expected.checksum: Renamed from LayoutTests/platform/chromium-mac-leopard/editing/selection/caret-rtl-2-expected.checksum.
  • platform/mac-leopard/editing/selection/caret-rtl-2-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/editing/selection/caret-rtl-2-expected.png.
  • platform/mac-leopard/editing/selection/caret-rtl-2-left-expected.checksum: Renamed from LayoutTests/platform/chromium-mac-leopard/editing/selection/caret-rtl-2-left-expected.checksum.
  • platform/mac-leopard/editing/selection/caret-rtl-2-left-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/editing/selection/caret-rtl-2-left-expected.png.
  • platform/mac-leopard/editing/selection/caret-rtl-expected.checksum: Renamed from LayoutTests/platform/chromium-mac-leopard/editing/selection/caret-rtl-expected.checksum.
  • platform/mac-leopard/editing/selection/caret-rtl-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/editing/selection/caret-rtl-expected.png.
  • platform/mac-leopard/editing/selection/caret-rtl-right-expected.checksum: Renamed from LayoutTests/platform/chromium-mac-leopard/editing/selection/caret-rtl-right-expected.checksum.
  • platform/mac-leopard/editing/selection/caret-rtl-right-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/editing/selection/caret-rtl-right-expected.png.
11:14 AM Changeset in webkit [79703] by brettw@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-02-15 Brett Wilson <​brettw@chromium.org>

Reviewed by Darin Fisher.

Recover the mouse capture state when we recieve a mouse event where there is no longer a button down.
​https://bugs.webkit.org/show_bug.cgi?id=54503

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::handleInputEvent):
11:08 AM Changeset in webkit [79702] by andersca@apple.com
  • 10 edits in trunk/Source/WebKit2

2011-02-25 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Get rid of more old accelerated compositing code
​https://bugs.webkit.org/show_bug.cgi?id=55235

  • Shared/CoreIPCSupport/DrawingAreaProxyMessageKinds.h:
  • UIProcess/ChunkedUpdateDrawingAreaProxy.h:
  • UIProcess/DrawingAreaProxy.h:
  • UIProcess/DrawingAreaProxyImpl.cpp:
  • UIProcess/DrawingAreaProxyImpl.h:
  • WebProcess/WebPage/ChunkedUpdateDrawingArea.h:
  • WebProcess/WebPage/DrawingArea.h:
  • WebProcess/WebPage/DrawingAreaImpl.cpp:
  • WebProcess/WebPage/DrawingAreaImpl.h:
11:06 AM BuildingOnWindows edited by Adam Roben
Clean up a bug link (diff)
11:01 AM Changeset in webkit [79701] by Patrick Gansterer
  • 3 edits in trunk/Source/WebCore

2011-02-25 Patrick Gansterer <Patrick Gansterer>

Unreviewed build fix.

  • platform/text/brew/TextBreakIteratorBrew.cpp: (WebCore::acquireLineBreakIterator):
  • platform/text/wince/TextBreakIteratorWinCE.cpp: (WebCore::acquireLineBreakIterator):
11:00 AM Changeset in webkit [79700] by mihaip@chromium.org
  • 4 edits
    1 delete in trunk/LayoutTests

2011-02-25 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update.

editing/pasteboard/merge-end-list.html was failing on Chromium Snow
Leopard because it was picking up the .checksum file in chromium-mac/,
even though it would pass with the mac/ .png/.checksum. Additionally, the
chromium-mac .checksum had no corresponding .png.

Fixes things by deleting the lone .checksum in chromium-mac and updating
the mac-leopard results (which can be used by both the Mac and Chromium
ports).

  • platform/chromium-mac/editing/pasteboard/merge-end-list-expected.checksum: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/mac-leopard/editing/pasteboard/merge-end-list-expected.checksum:
  • platform/mac-leopard/editing/pasteboard/merge-end-list-expected.png:
11:00 AM BuildingOnWindows edited by Adam Roben
Add instructions for disabling UAC to get crash logs on Windows Vista/7 (diff)
10:58 AM Changeset in webkit [79699] by vangelis@chromium.org
  • 3 edits
    4 adds in trunk

2011-02-25 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Simon Fraser.

[chromium] Adding test to ensure clipping layer gets updated when layout
width/height change in the page.
​https://bugs.webkit.org/show_bug.cgi?id=55103

  • platform/chromium/compositing/layout-width-change-expected.checksum: Added.
  • platform/chromium/compositing/layout-width-change-expected.png: Added.
  • platform/chromium/compositing/layout-width-change-expected.txt: Added.
  • platform/chromium/compositing/layout-width-change.html: Added.

2011-02-25 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Simon Fraser.

Update the clip layer size whenever the root layer's size and position
is updated. This only affects the accelerated compositing path.
​https://bugs.webkit.org/show_bug.cgi?id=55103

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateRootLayerPosition):

Test: platform/chromium/compositing/layout-width-change.html

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateRootLayerPosition):
10:46 AM Changeset in webkit [79698] by Adam Roben
  • 2 edits in trunk/Tools

Double-check that modifying the registry worked

On Windows Vista/7 with UAC enabled, regtool will fail to modify the registry, but it will
still return a successful exit code. So we double-check here that the value we tried to
write to the registry was really written.

Fixes <​http://webkit.org/b/55227> old-run-webkit-tests falsely claims to be saving crash
logs on Windows Vista/7

Reviewed by Darin Adler.

  • Scripts/old-run-webkit-tests:

(writeRegistryString): After trying to write the string value, check that it was really
written.

10:46 AM Changeset in webkit [79697] by Adam Roben
  • 2 edits in trunk/Tools

Set the 32-bit post-mortem debugger on 64-bit OSes

The post-mortem debugger is controlled by some registry values in
HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion\AeDebug. On 64-bit OSes, you can either
set the values in that key, which will be used for 64-bit apps, or in the equivalent key
under Wow6432Node, which will be used for 32-bit apps. Since DumpRenderTree and
WebKitTestRunner are 32-bit, we want to use the latter location.

Fixes <​http://webkit.org/b/55225> old-run-webkit-tests sets the post-mortem debugger for
64-bit apps, but should set it for 32-bit apps instead

Reviewed by Darin Adler.

  • Scripts/old-run-webkit-tests:

(readRegistryString):
(writeRegistryString):
Pass --wow32 to regtool so it will get/set values beneath Wow6432Node, which is where
Windows looks for the post-mortem debugger values when a 32-bit app crashes on a 64-bit OS.
Passing --wow32 on a 32-bit OS will not have any effect.

10:45 AM Changeset in webkit [79696] by Adam Roben
  • 2 edits in trunk/Tools

Clean up code to set up crash log saving on Windows

Fixes <​http://webkit.org/b/55224> old-run-webkit-test's Windows registry code is ugly

Reviewed by David Kilzer.

  • Scripts/old-run-webkit-tests:

(readRegistryString):
(writeRegistryString):
Moved code to read strings from and write strings to the registry here...

(setUpWindowsCrashLogSaving): ...from here.

10:45 AM Changeset in webkit [79695] by Adam Roben
  • 9 edits in trunk

Work around Cygwin's crash-suppression behavior

Cygwin calls ::SetErrorMode(SEM_FAILCRITICALERRORS), which any processes it launches will
inherit. This is bad for testing/debugging, as it causes the post-mortem debugger not to be
invoked. (Cygwin does this because it makes crashes more UNIX-y.) We reset the error mode
when our test apps launch to work around Cygwin's behavior.

Fixes <​http://webkit.org/b/55222> Test apps crash silently (without invoking post-mortem
debugger) when launched from Cygwin 1.7

Reviewed by Darin Adler.

Source/JavaScriptCore:

  • API/tests/testapi.c: Added a now-needed #include.

(main):

  • jsc.cpp:

(main):
Call ::SetErrorMode(0) to undo Cygwin's folly.

  • JavaScriptCore.vcproj/testapi/testapiCommon.vsprops: Define NOMINMAX like many of our

other projects do so that windows.h won't define min/max macros that interfere with
std::numeric_limits<T>::min/max.

Tools:

  • DumpRenderTree/win/DumpRenderTree.cpp:

(main):

  • TestWebKitAPI/win/main.cpp:

(main):

  • WebKitAPITest/main.cpp:

(main):

  • WebKitTestRunner/win/TestControllerWin.cpp:

(WTR::TestController::platformInitialize):
Call ::SetErrorMode(0) to undo Cygwin's folly.

10:34 AM Changeset in webkit [79694] by mitz@apple.com
  • 12 edits in trunk/Source/WebCore

Minimize calls to ubrk_setText()
​https://bugs.webkit.org/show_bug.cgi?id=54912
<rdar://problem/9032774>

Patch by Ned Holbrook <​nholbrook@apple.com> on 2011-02-25
Reviewed by Dan Bernstein.

Avoid calling ubrk_setText() once per call to isBreakable() by using a LazyLineBreakIterator, which defers
break iterator creation until needed. This requires replacing the global line break iterator primitive with a
version that can be nested, since in some cases two iterators may need to be outstanding. In particular,
layoutInlineChildren() may indirectly call computePreferredLogicalWidths() and each may need an iterator.
In a test with a paragraph of Japanese text, this reduced the number of ubrk_setText() calls from 164 to 1.

  • platform/text/TextBreakIterator.h: Add LazyLineBreakIterator.

(WebCore::LazyLineBreakIterator::LazyLineBreakIterator):
(WebCore::LazyLineBreakIterator::~LazyLineBreakIterator):
(WebCore::LazyLineBreakIterator::string):
(WebCore::LazyLineBreakIterator::length):
(WebCore::LazyLineBreakIterator::get):
(WebCore::LazyLineBreakIterator::reset):

  • platform/text/TextBreakIteratorICU.cpp: Replace lineBreakIterator() primitive with acquireLineBreakIterator()/releaseLineBreakIterator().

(WebCore::acquireLineBreakIterator):
(WebCore::releaseLineBreakIterator):

  • platform/text/brew/TextBreakIteratorBrew.cpp: Ditto.

(WebCore::acquireLineBreakIterator):
(WebCore::releaseLineBreakIterator):

  • platform/text/gtk/TextBreakIteratorGtk.cpp: Ditto.

(WebCore::acquireLineBreakIterator):
(WebCore::releaseLineBreakIterator):

  • platform/text/qt/TextBreakIteratorQt.cpp: Ditto.

(WebCore::acquireLineBreakIterator):
(WebCore::releaseLineBreakIterator):

  • platform/text/wince/TextBreakIteratorWinCE.cpp: Ditto.

(WebCore::acquireLineBreakIterator):
(WebCore::releaseLineBreakIterator):

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren): Pass a mapping of RenderText to LazyLineBreakIterator from one call of findNextLineBreak() to the next.
(WebCore::RenderBlock::findNextLineBreak): Use said mapping, resetting LazyLineBreakIterator for any newly-encountered RenderText.

  • rendering/RenderText.cpp: Use a local LazyLineBreakIterator.

(WebCore::RenderText::computePreferredLogicalWidths):

  • rendering/break_lines.cpp: Accept LazyLineBreakIterator rather than UniChar buffer.

(WebCore::nextBreakablePosition):

  • rendering/break_lines.h: Accept LazyLineBreakIterator rather than UniChar buffer.

(WebCore::isBreakable):

10:28 AM Changeset in webkit [79693] by jberlin@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

[Windows 7 Release Tests] fast/ruby/base-shorter-than-text.html failing since introduction
in r79629.
​https://bugs.webkit.org/show_bug.cgi?id=55230

Add Windows-specific expected results. Unreviewed.

  • platform/win/fast/ruby/base-shorter-than-text-expected.checksum: Added.
  • platform/win/fast/ruby/base-shorter-than-text-expected.png: Added.
  • platform/win/fast/ruby/base-shorter-than-text-expected.txt: Added.
10:25 AM Changeset in webkit [79692] by sergio@webkit.org
  • 1 edit
    9 adds in trunk/LayoutTests

2011-02-25 Sergio Villar Senin <​svillar@igalia.com>

Unreviewed.

Added new GTK+ expectations for new tests.

  • platform/gtk/svg/custom/animate-target-id-changed-expected.checksum: Added.
  • platform/gtk/svg/custom/animate-target-id-changed-expected.png: Added.
  • platform/gtk/svg/custom/animate-target-id-changed-expected.txt: Added.
  • platform/gtk/svg/custom/animate-target-removed-from-document-expected.checksum: Added.
  • platform/gtk/svg/custom/animate-target-removed-from-document-expected.png: Added.
  • platform/gtk/svg/custom/animate-target-removed-from-document-expected.txt: Added.
  • platform/gtk/transitions/default-timing-function-expected.checksum: Added.
  • platform/gtk/transitions/default-timing-function-expected.png: Added.
  • platform/gtk/transitions/default-timing-function-expected.txt: Added.
10:11 AM Changeset in webkit [79691] by hyatt@apple.com
  • 2 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.

Reviewed by Sam Weinig.

Patch computePositionedLogicalWidthReplaced to be writing-mode aware. Not testable yet, since the height function overwrites the values
in a vertical text environment.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computePositionedLogicalWidthReplaced):

10:07 AM Changeset in webkit [79690] by Csaba Osztrogonác
  • 3 edits
    1 add in trunk/Source

2011-02-25 Andras Becsi <​abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Make the WebKit2 build system less confusing for non-Qt developers
​https://bugs.webkit.org/show_bug.cgi?id=55213

  • QtWebKit.pro: Move the WebKit2 API into a project include file in the WebKit2 directory and include the pri file here.

2011-02-25 Andras Becsi <​abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Make the WebKit2 build system less confusing for non-Qt developers
​https://bugs.webkit.org/show_bug.cgi?id=55213

  • WebKit2API.pri: Added.
9:51 AM Changeset in webkit [79689] by inferno@chromium.org
  • 3 edits
    3 adds in trunk

2011-02-25 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dave Hyatt.

Tests that we do not crash when removing a text node adjacent to a word break node.
​https://bugs.webkit.org/show_bug.cgi?id=55206

  • fast/text/resources/word-break-next-linebox-not-dirty-crash.html: Added.
  • fast/text/word-break-next-linebox-not-dirty-crash-main-expected.txt: Added.
  • fast/text/word-break-next-linebox-not-dirty-crash-main.html: Added.

2011-02-25 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dave Hyatt.

When trying to find which lines to dirty for a changed child, make sure
that we do test if the adjacent next linebox contains that changed child
and if yes, dirty it. This can happen in cases when we have a word break
between text nodes.
​https://bugs.webkit.org/show_bug.cgi?id=55206

Test: fast/text/word-break-next-linebox-not-dirty-crash-main.html

  • rendering/RenderLineBoxList.cpp: (WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
9:35 AM Changeset in webkit [79688] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-25 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium Snow Leopard expectations update. Remove failing
expectations for tests that pass after r79653. Add one more known
failure and flake.

  • platform/chromium/test_expectations.txt:
9:27 AM Changeset in webkit [79687] by christian@webkit.org
  • 1 edit
    1 add in trunk/Source/WebKit/gtk/po

Unreviewed translation file.

L10N: Webkit translated to Basque (eu) language
​https://bugs.webkit.org/show_bug.cgi?id=36588

  • eu.po: Added.
9:04 AM Changeset in webkit [79686] by kbalazs@webkit.org
  • 3 edits in trunk/Source/WebKit/qt

Unreviewed build fix for Intel ICC and MSVC.

Patch by Alexis Menard <​alexis.menard@openbossa.org> on 2011-02-25

  • tests/qgraphicswebview/tst_qgraphicswebview.cpp:

(tst_QGraphicsWebView::setPalette):

  • tests/qwebview/tst_qwebview.cpp:

(tst_QWebView::setPalette):

8:56 AM Changeset in webkit [79685] by sergio@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-25 Sergio Villar Senin <​svillar@igalia.com>

Unreviewed.

Added an inspector test that fails on GTK debug bots.

  • platform/gtk/Skipped: inspector/extensions/extensions-events.html
8:43 AM Changeset in webkit [79684] by antonm@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt

Unreviewed. Chromium expectations.

  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt
8:15 AM Changeset in webkit [79683] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebKit/qt

2011-02-25 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Properly propagate the palette to QWebPage from QGraphicsWebView
​https://bugs.webkit.org/show_bug.cgi?id=31742

Discovered while looking at 31742. When we set a palette on the
QGraphicsWebView we need to propagate it to the page like QWebView.
I have added the same tests as QWebView to be sure to catch potential
regressions as well as two extras QVERIFY to check the palette propagation.

  • Api/qgraphicswebview.cpp: (QGraphicsWebView::event):
  • tests/qgraphicswebview/tst_qgraphicswebview.cpp: (tst_QGraphicsWebView::setPalette_data): (tst_QGraphicsWebView::setPalette):
8:13 AM Changeset in webkit [79682] by podivilov@chromium.org
  • 3 edits
    2 adds in trunk

2011-02-25 Andrey Adaikin <​aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: [Text editor] Add basic layout tests for the highlighter
​https://bugs.webkit.org/show_bug.cgi?id=54751

Adding basic tests for the highlighter.

  • inspector/editor/highlighter-basics-expected.txt: Added.
  • inspector/editor/highlighter-basics.html: Added.

2011-02-25 Andrey Adaikin <​aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: [Text editor] Add basic layout tests for the highlighter
​https://bugs.webkit.org/show_bug.cgi?id=54751

Test: inspector/editor/highlighter-basics.html

  • inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter.prototype.highlight):
7:02 AM Changeset in webkit [79681] by antonm@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

Unreviewed. Temporary disabling a newly added test.

  • platform/chromium/test_expectations.txt
6:10 AM Changeset in webkit [79680] by antonm@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

Unreviewed. Correcting test expectations.

  • platform/chromium/test_expectations.txt
5:52 AM Changeset in webkit [79679] by sergio@webkit.org
  • 1 edit
    38 adds in trunk/LayoutTests

2011-02-25 Sergio Villar Senin <​svillar@igalia.com>

Unreviewed.

Added new GTK test expectations.

  • platform/gtk/fast/block/positioning/vertical-lr: Added 6 new test expectations.
  • platform/gtk/fast/block/positioning/vertical-rl: Added 6 new test expectations.
5:41 AM Changeset in webkit [79678] by Csaba Osztrogonác
  • 3 edits in trunk/Source/WebKit/qt

Unreviewed buildfix after r79672.

[Qt] Build tst_qdeclarativewebview if QT_CONFIG contains declarative.

  • tests/tests.pri:
  • tests/tests.pro:
5:35 AM Changeset in webkit [79677] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-24 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Huge fonts in font preview
​https://bugs.webkit.org/show_bug.cgi?id=55143

5:13 AM Changeset in webkit [79676] by antonm@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

Unreviewed. Updating test expectations for Chromium.

  • platform/chromium/test_expectations.txt
5:08 AM Changeset in webkit [79675] by Nikolas Zimmermann
  • 23 edits
    6 adds in trunk

2011-02-25 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Implement SVGColor/SVGPaint API
​https://bugs.webkit.org/show_bug.cgi?id=55119

SVGColor::cssText() shouldn't return #RRGGBBAA colors
​https://bugs.webkit.org/show_bug.cgi?id=48120

Rewrite SVGColor/SVGPaint to actually implement their desired setPaint/setColor/setURI APIs.
SVGPaint is a CSSValue, and its setPaint() function allows to switch to an arbitary paint type.
That means, unlike all other CSSValues, SVGColor/SVGPaint are mutable. That means changes to
their CSSValues should be reflected in the elements style as well as in the computed style.
This patch doesn't yet implement that, the stubbed-out method valueChanged() is what
needs to be implemented. For now you can grab a SVGColor/SVGPaint object through getCSSPropertyValue
and manipulate it, in every possible way (SVPaint.uri/paintType/colorType/color attributes are all sync'ed).
Switch to strict JS bindings (RequiresAllArguments=Raise, StrictTypeChecking) for both objects.

Enable proper serialization of colors through Color::serialized(), affects some testcases (#FF.. -> #ff..)
Add extensive tests of all SVGColor/SVGPaint API, currently shows some FAIL messages, as element style
<-> computed style is not live, after mutating SVGColor/SVGPaint. That will be implemented in a follow-up patch.

Tests: svg/dom/SVGColor.html

svg/dom/SVGPaint.html

  • bindings/scripts/CodeGenerator.pm: Remove obsolete handling of "SVGPaintType", take ushort for paintType, as specified in the SVG 1.1 IDLs.
  • bindings/scripts/CodeGeneratorJS.pm: Ditto.
  • bindings/scripts/CodeGeneratorObjC.pm: Ditto.
  • bindings/scripts/CodeGeneratorV8.pm: Ditto.
  • css/SVGCSSParser.cpp: Adapt to SVGPaint/SVGColor create() naming convention changes. (WebCore::CSSParser::parseSVGValue): (WebCore::CSSParser::parseSVGPaint): (WebCore::CSSParser::parseSVGColor):
  • svg/SVGColor.cpp: Rewrite to fully implement the SVGColor API, merge all constructors into one, use more descriptable create() naming convention. (WebCore::valueChanged): Stub implementation, will land in a follow-up patch. (WebCore::SVGColor::SVGColor): (WebCore::SVGColor::setRGBColor): (WebCore::SVGColor::colorFromRGBColorString): (WebCore::SVGColor::setRGBColorICCColor): (WebCore::SVGColor::setColor): (WebCore::SVGColor::cssText):
  • svg/SVGColor.h: (WebCore::SVGColor::createFromString): (WebCore::SVGColor::createFromColor): (WebCore::SVGColor::color): (WebCore::SVGColor::colorType): (WebCore::SVGColor::~SVGColor): (WebCore::SVGColor::setColor): (WebCore::SVGColor::setColorType):
  • svg/SVGColor.idl: Enable strict type checking.
  • svg/SVGPaint.cpp: Rewrite to fully implement the SVGPaint API, merge all constructors into one, use more descriptable create() naming convention. (WebCore::valueChanged): Stub implementation, will land in a follow-up patch. (WebCore::colorTypeForPaintType): (WebCore::SVGPaint::SVGPaint): (WebCore::SVGPaint::setUri): (WebCore::SVGPaint::defaultFill): (WebCore::SVGPaint::defaultStroke): (WebCore::SVGPaint::setPaint): (WebCore::SVGPaint::cssText): (WebCore::SVGPaint::matchesTargetURI):
  • svg/SVGPaint.h: (WebCore::SVGPaint::createUnknown): (WebCore::SVGPaint::createNone): (WebCore::SVGPaint::createCurrentColor): (WebCore::SVGPaint::createColor): (WebCore::SVGPaint::createURI): (WebCore::SVGPaint::createURIAndColor): (WebCore::SVGPaint::paintType): (WebCore::SVGPaint::uri): (WebCore::SVGPaint::create): (WebCore::SVGPaint::isSVGPaint):
  • svg/SVGPaint.idl: Enable strict type checking.

2011-02-25 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Implement SVGColor/SVGPaint API
​https://bugs.webkit.org/show_bug.cgi?id=55119

SVGColor::cssText() shouldn't return #RRGGBBAA colors
​https://bugs.webkit.org/show_bug.cgi?id=48120

Add two new tests covering the SVGColor/SVGPaint APIs.
Adapt to SVGColor::cssText() changes, color is properly serialized now.

  • svg/animations/animate-color-transparent-expected.txt:
  • svg/animations/animate-currentColor-expected.txt:
  • svg/animations/animate-dynamic-update-attributeName-expected.txt:
  • svg/animations/animate-inherit-css-property-expected.txt:
  • svg/animations/script-tests/animate-color-transparent.js: (expectTransparent): (expectOtherColor):
  • svg/animations/script-tests/animate-currentColor.js: (sample1):
  • svg/animations/script-tests/animate-inherit-css-property.js: (sample1):
  • svg/css/getComputedStyle-basic-expected.txt:
  • svg/custom/getPresentationAttribute-modify.svg:
  • svg/custom/rgbcolor-syntax.svg:
  • svg/dom/SVGColor-expected.txt: Added.
  • svg/dom/SVGColor.html: Added.
  • svg/dom/SVGPaint-expected.txt: Added.
  • svg/dom/SVGPaint.html: Added.
  • svg/dom/script-tests/SVGColor.js: Added. (checkStopColor):
  • svg/dom/script-tests/SVGPaint.js: Added. (resetStyle): (checkFillColor):
4:59 AM Changeset in webkit [79674] by reni@webkit.org
  • 10 edits
    5 adds in trunk

2011-02-25 Renata Hodovan <​reni@webkit.org>

Reviewed by Nikolas Zimmermann.

FESpecularLightingElement changes doesn't require relayout.
​https://bugs.webkit.org/show_bug.cgi?id=54451

When the FESpecularLightingElement receives an update message but the given value remains the same we don't need
to relayout the filter. Otherwise, the light source requests a repaint on the specular lighting filter.
Besides add ASSERTs to DiffuseLightElement::setFilterEffectAttribute as well to avoid lightSources being null.

No new tests are needed to check the repaint because it is covered by the dynamic update tests of FESpecularLighting.
We only test what happens if we remove the light source of specularLight.

Test: svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource.html

  • platform/graphics/filters/FESpecularLighting.cpp: (WebCore::FESpecularLighting::setSurfaceScale): (WebCore::FESpecularLighting::setSpecularConstant): (WebCore::FESpecularLighting::setSpecularExponent): (WebCore::FESpecularLighting::setKernelUnitLengthX): (WebCore::FESpecularLighting::setKernelUnitLengthY):
  • platform/graphics/filters/FESpecularLighting.h:
  • rendering/svg/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::postApplyResource):
  • svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::setFilterEffectAttribute): (WebCore::SVGFEDiffuseLightingElement::lightElementAttributeChanged): (WebCore::SVGFEDiffuseLightingElement::build):
  • svg/SVGFEDiffuseLightingElement.h:
  • svg/SVGFELightElement.cpp: (WebCore::SVGFELightElement::findLightElement): (WebCore::SVGFELightElement::findLight): (WebCore::SVGFELightElement::svgAttributeChanged):
  • svg/SVGFELightElement.h:
  • svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::setFilterEffectAttribute): (WebCore::SVGFESpecularLightingElement::svgAttributeChanged): (WebCore::SVGFESpecularLightingElement::lightElementAttributeChanged): (WebCore::SVGFESpecularLightingElement::build):
  • svg/SVGFESpecularLightingElement.h:

2011-02-25 Renata Hodovan <​reni@webkit.org>

Reviewed by Nikolas Zimmermann.

FESpecularLightingElement changes doesn't require relayout.
​https://bugs.webkit.org/show_bug.cgi?id=54451

Test what happens if we remove the light source of specularLight.

  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource-expected.png: Added.
  • svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource-expected.txt: Added.
  • svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource.html: Added.
  • svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-remove-lightSource.js: Added. (executeTest):
4:51 AM Changeset in webkit [79673] by antonm@chromium.org
  • 6 edits in trunk/LayoutTests/platform

Unreviewed.

Updated test expectations for Chromium.

  • platform/chromium-linux/fast/ruby/base-shorter-than-text-expected.png
  • platform/chromium-linux/fast/ruby/base-shorter-than-text-expected.checksum
  • platform/chromium-linux/fast/ruby/base-shorter-than-text-expected.txt
  • platform/chromium-win/fast/ruby/base-shorter-than-text-expected.png
  • platform/chromium-win/fast/ruby/base-shorter-than-text-expected.checksum
  • platform/chromium-win/fast/ruby/base-shorter-than-text-expected.txt
4:48 AM Changeset in webkit [79672] by andreas.kling@nokia.com
  • 4 edits
    7 adds in trunk/Source/WebKit/qt

2011-02-25 Gopal Raghavan <​gopal.1.raghavan@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QML WebView inside a Flickable shows checkers pattern at startup
​https://bugs.webkit.org/show_bug.cgi?id=50222.

This patch fixes the checkerboard visible at startup even if preferredWidth and preferredHeight are not set.

  • declarative/qdeclarativewebview.cpp: (QDeclarativeWebView::init):
  • tests/qdeclarativewebview: Added.
  • tests/qdeclarativewebview/qdeclarativewebview.pro: Added.
  • tests/qdeclarativewebview/resources: Added.
  • tests/qdeclarativewebview/resources/webviewtest.qml: Added.
  • tests/qdeclarativewebview/resources/webviewtestdefault.qml: Added.
  • tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: Added. (tst_QDeclarativeWebView::initTestCase): (tst_QDeclarativeWebView::cleanupTestCase): (tst_QDeclarativeWebView::init): (tst_QDeclarativeWebView::cleanup): (tst_QDeclarativeWebView::preferredWidthTest): (tst_QDeclarativeWebView::preferredHeightTest): (tst_QDeclarativeWebView::preferredWidthDefaultTest): (tst_QDeclarativeWebView::preferredHeightDefaultTest): (tst_QDeclarativeWebView::checkNoErrors):
  • tests/tests.pri:
  • tests/tests.pro:
3:44 AM Changeset in webkit [79671] by alex
  • 4 edits
    1 copy
    3 adds in trunk/Source/WebKit2

2011-02-25 Amruth Raj <​amruthraj@motorola.com> and Ravi Phaneendra Kasibhatla <​ravi.kasibhatla@motorola.com> and Alejandro G. Castro <​alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Implement WebView and WebKitWebView classes for WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=48509

  • GNUmakefile.am:
  • UIProcess/API/C/gtk/WKView.cpp:
  • UIProcess/API/C/gtk/WKView.h: Removed gdkrectangle from constructor.
  • UIProcess/gtk/WebViewWidget.cpp: Added. The GObject interface for WebView. The GObject is the GtkWidget handle which is used by WebView class for GTK port.
  • UIProcess/gtk/WebViewWidget.h: Added. The GObject interface declarations for GtkWidget handle for GTK port.
  • UIProcess/gtk/WebView.cpp: Added. The native GtkWidget handle for GTK port which is associated with each WKViewRef.
  • UIProcess/gtk/WebView.h: Added. Class which implements the PageClient interface. It is a wrapper over the native GtkWidget handle associated with each WKViewRef for GTK port.
3:40 AM Changeset in webkit [79670] by alex
  • 2 edits in trunk/Source/WebKit2

2011-02-25 Alejandro G. Castro <​alex@igalia.com>

Fix GTK compilation after r79654.

  • GNUmakefile.am:
3:24 AM Changeset in webkit [79669] by sergio@webkit.org
  • 3 edits in trunk/LayoutTests

2011-02-25 Sergio Villar Senin <​svillar@igalia.com>

Unreviewed.

Updated GTK test expectations after r79618.

  • platform/gtk/fast/table/colspanMinWidth-vertical-expected.txt:
  • platform/gtk/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt:
3:07 AM Changeset in webkit [79668] by jocelyn.turcotte@nokia.com
  • 15 edits
    2 deletes in trunk

[Qt] Revert the support for QNAM affined to a different thread.
​https://bugs.webkit.org/show_bug.cgi?id=55149

Reviewed by Andreas Kling.

Qt 4.8 will have QNAM use its own thread internally by default,
no need to keep this complexity in WebKit.

This mainly reverts:
​http://trac.webkit.org/changeset/73710
​http://trac.webkit.org/changeset/73712

Source/WebCore:

  • WebCore.pro:
  • platform/graphics/qt/MediaPlayerPrivateQt.cpp:

(WebCore::MediaPlayerPrivateQt::commitLoad):

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::FormDataIODevice::FormDataIODevice):
(WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
(WebCore::QNetworkReplyHandler::setLoadMode):
(WebCore::QNetworkReplyHandler::abort):
(WebCore::QNetworkReplyHandler::release):
(WebCore::ignoreHttpError):
(WebCore::QNetworkReplyHandler::finish):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::forwardData):
(WebCore::QNetworkReplyHandler::start):
(WebCore::QNetworkReplyHandler::sendQueuedItems):

  • platform/network/qt/QNetworkReplyHandler.h:

(WebCore::QNetworkReplyHandler::reply):

  • platform/network/qt/QtNAMThreadSafeProxy.cpp: Removed.
  • platform/network/qt/QtNAMThreadSafeProxy.h: Removed.
  • platform/network/qt/ResourceHandleQt.cpp:

(WebCore::ResourceHandle::willLoadFromCache):

  • platform/qt/CookieJarQt.cpp:

(WebCore::cookieJar):
(WebCore::setCookies):
(WebCore::cookies):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::cookiesEnabled):

Source/WebKit/qt:

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::download):

  • tests/qwebpage/tst_qwebpage.cpp:

Tools:

  • QtTestBrowser/launcherwindow.cpp:

(LauncherWindow::~LauncherWindow):
(LauncherWindow::initializeView):
(LauncherWindow::createChrome):

  • QtTestBrowser/launcherwindow.h:

(WindowOptions::WindowOptions):

  • QtTestBrowser/webpage.cpp:

(WebPage::WebPage):

  • QtTestBrowser/webpage.h:
2:44 AM Changeset in webkit [79667] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit/mac

<rdar://problem/8902546> Build fix.

  • Misc/QuickDrawCompatibility.h:
2:05 AM Changeset in webkit [79666] by sergio@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-25 Sergio Villar Senin <​svillar@igalia.com>

Unreviewed.

Skipped 3 SVG tests failing in GTK 32-bit release bot.

  • platform/gtk/Skipped:
1:12 AM Changeset in webkit [79665] by Csaba Osztrogonác
  • 4 edits in trunk/LayoutTests

Unreviewed.

Update a Qt specific expected file after r79618.

  • platform/qt/fast/table/fixed-with-auto-with-colspan-vertical-expected.checksum:
  • platform/qt/fast/table/fixed-with-auto-with-colspan-vertical-expected.png:
  • platform/qt/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt:
12:30 AM Changeset in webkit [79664] by reni@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-02-25 Renata Hodovan <​reni@webkit.org>

Reviewed by Andreas Kling.

FEBlendElement changes doesn't require relayout
​https://bugs.webkit.org/show_bug.cgi?id=55138

When the FEBlendElement receives an update message but the given value remains the same we don't need
to relayout the filter.

No new tests are needed because this modificiation is covered by the dynamic update tests of FEBlend.

  • platform/graphics/filters/FEBlend.cpp: (WebCore::FEBlend::setBlendMode):
  • platform/graphics/filters/FEBlend.h:
  • svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::setFilterEffectAttribute): (WebCore::SVGFEBlendElement::svgAttributeChanged): (WebCore::SVGFEBlendElement::synchronizeProperty):
  • svg/SVGFEBlendElement.h:
Note: See TracTimeline for information about the timeline view.