⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 27, 2011:

11:30 PM Changeset in webkit [79844] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-02-27 Aparna Nandyal <​aparna.nand@wipro.com>

Reviewed by Antonio Gomes.

[Qt] QtTestBrowser - Horizontal scrollbar disappears on navigating pages using Back/Forward
​https://bugs.webkit.org/show_bug.cgi?id=53917

The bug got fixed by other changes. Adding test case to avoid
regressions in the future.

  • fast/overflow/horizontal-scroll-after-back-expected.txt: Added.
  • fast/overflow/horizontal-scroll-after-back.html: Added.

2011-02-27 Aparna Nandyal <​aparna.nand@wipro.com>

Reviewed by Antonio Gomes.

[Qt] QtTestBrowser - Horizontal scrollbar disappears on navigating pages using Back/Forward
​https://bugs.webkit.org/show_bug.cgi?id=53917

Adding test case to check the scenario to avoid regressions in the
future.

  • tests/qwebframe/tst_qwebframe.cpp:
11:28 PM Changeset in webkit [79843] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-02-27 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Darin Fisher.

Pass frame history state in the context menu parameters.
​https://bugs.webkit.org/show_bug.cgi?id=55232

  • public/WebContextMenuData.h:
  • src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
10:53 PM Changeset in webkit [79842] by Patrick Gansterer
  • 4 edits in trunk/Source/WebCore

2011-02-27 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Remove registerBaseEncodingNames and registerBaseCodecs from TextCodecWinCE
​https://bugs.webkit.org/show_bug.cgi?id=55317

This functions are obsolete, since r78499 added TextCodecUTF8.
Also remove the "fast path" for UTF-8 data, because we now have a separate TextCodec.

  • platform/text/TextEncodingRegistry.cpp: (WebCore::buildBaseTextCodecMaps):
  • platform/text/wince/TextCodecWinCE.cpp:
  • platform/text/wince/TextCodecWinCE.h:
9:49 PM Changeset in webkit [79841] by ojan@chromium.org
  • 3 edits in trunk/Tools

2011-02-27 Ojan Vafai <​ojan@chromium.org>

Fix failing tests from ​http://trac.webkit.org/changeset/79837.

  • Scripts/webkitpy/layout_tests/layout_package/printing.py: This was just a mistake that would break if someone tried printing with this configuration.
  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py: Method signature changed. Didn't notice that this method was being calling in a unittest.
9:18 PM Changeset in webkit [79840] by hayato@chromium.org
  • 6 edits
    5 deletes in trunk/Tools

2011-02-24 Hayato Ito <​hayato@chromium.org>

Reviewed by Eric Seidel.

[NRWT] Remove test_types/* classes.

This is the last patch in the series of efforts which tried to remove test_types classes.
A single_test_runner module will take over responsibilities of test_type classes.

From this patch, we won't display statistics per test_type even if a '--verbose' option is given.

​https://bugs.webkit.org/show_bug.cgi?id=55123

  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_results.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  • Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
  • Scripts/webkitpy/layout_tests/test_types/init.py: Removed.
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py: Removed.
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py: Removed.
  • Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py: Removed.
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py: Removed.
8:35 PM Changeset in webkit [79839] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Force dictionary popup to use overlay type
<rdar://problem/9052483>
​https://bugs.webkit.org/show_bug.cgi?id=55337

Reviewed by Dan Bernstein.

  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::didPerformDictionaryLookup): As this is only
used for the hot key version of the dictionary popup, force the overlay
style.

8:00 PM Changeset in webkit [79838] by gyuyoung.kim@samsung.com
  • 8 edits in trunk/Source/WebKit/efl

2011-02-27 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Kent Tamura.

[EFL] Restore parameters of efl header files.
​https://bugs.webkit.org/show_bug.cgi?id=55292

Restore parameters in efl header files.

  • ewk/ewk_frame.h:
  • ewk/ewk_tiled_backing_store.h:
  • ewk/ewk_tiled_matrix.h:
  • ewk/ewk_tiled_model.h:
  • ewk/ewk_view.cpp: (ewk_view_pre_render_relative_radius):
  • ewk/ewk_view.h:
  • ewk/ewk_window_features.h:
7:55 PM Changeset in webkit [79837] by ojan@chromium.org
  • 7 edits in trunk/Tools

2011-02-25 Ojan Vafai <​ojan@chromium.org>

Reviewed by Tony Chang.

Change results.json format to the one used by unexpected_results.json
​https://bugs.webkit.org/show_bug.cgi?id=52267

Also add runtimes in milliseconds to the JSON and make the output format more compact.
Named the file full_results.json to avoid conflicting with the results.json
file the test-results server currently serves up.

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
  • Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
7:39 PM Changeset in webkit [79836] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-02-25 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

[codereviewtool] fix expand links on git diffs
​https://bugs.webkit.org/show_bug.cgi?id=55208

In git diffs, we don't have a "revision" span at the end
of each FileDiff.

  • code-review.js:
7:11 PM Changeset in webkit [79835] by abarth@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-27 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement WTF::randomNumber in terms of WTF::cryptographicallyRandomNumber when possible
​https://bugs.webkit.org/show_bug.cgi?id=55326

Currently, randomNumber does a bunch of platform-specific work that to
get a cryptographic randomness when available. Instead, we should use
cryptographicallyRandomNumber, which abstracts this work.
Unfortunately, we can't remove all of the WTF::randomNumber
implementation because not every port has access to cryptographically
random numbers.

  • wtf/RandomNumber.cpp: (WTF::randomNumber):
5:33 PM Changeset in webkit [79834] by benjamin.poulain@nokia.com
  • 3 edits in trunk/Source/WebCore

2011-02-27 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Sam Weinig.

Use OwnPtr to handle the memory of RenderBlock::m_floatingObjects and RenderBlock::m_positionedObjects
​https://bugs.webkit.org/show_bug.cgi?id=55327

Refactor RenderBlock to use OwnPtr for m_floatingObjects and m_positionedObjects so we do not have
to release the memory manually.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::~RenderBlock): (WebCore::RenderBlock::selectionGaps): (WebCore::RenderBlock::insertPositionedObject): (WebCore::RenderBlock::insertFloatingObject): (WebCore::RenderBlock::addOverhangingFloats): (WebCore::RenderBlock::addIntrudingFloats):
  • rendering/RenderBlock.h: (WebCore::RenderBlock::positionedObjects):
4:10 PM Debugging With Visual Studio edited by dbates@webkit.org
Fix misspelled word; "pauses all processes" should be "pause all … (diff)
3:28 PM Changeset in webkit [79833] by Adam Roben
  • 2 edits in trunk/Tools

Followup fix to r79827

  • DumpRenderTree/win/UIDelegate.cpp:

(UIDelegate::webViewAddMessageToConsole): Replaced call to urlSuitableForTestResult with
lastPathComponent. This matches what we did here before r79827, and matches Mac.

3:18 PM Changeset in webkit [79832] by benjamin.poulain@nokia.com
  • 3 edits in trunk/Source/WebKit2

[Qt] [WK2] QGraphicsWKView::showContextMenu() should be public
​https://bugs.webkit.org/show_bug.cgi?id=55330

Reviewed by Kenneth Rohde Christiansen.

Move QGraphicsWKView::showContextMenu() to the public API. Add documentation
on its use.

  • UIProcess/API/qt/qgraphicswkview.cpp:
  • UIProcess/API/qt/qgraphicswkview.h:
2:14 PM Changeset in webkit [79831] by mitz@apple.com
  • 2 edits in trunk/Tools

Make bisect-builds print a trac link for the regression range
​https://bugs.webkit.org/show_bug.cgi?id=55331

Reviewed by Adam Roben.

  • Scripts/bisect-builds:
1:51 PM Changeset in webkit [79830] by Adam Roben
  • 2 edits in trunk/Tools

Use iswalpha instead of isalpha when dealing with wchar_ts in EditingDelegate

Fixes <​http://webkit.org/b/55062> <rdar://problem/9059907> Crash beneath
EditingDelegate::checkSpellingOfString when running fast/forms/input-text-maxlength.html or
fast/forms/input-text-paste-maxlength.html on Windows with full page heap enabled

Reviewed by Anders Carlsson.

  • DumpRenderTree/win/EditingDelegate.cpp:

(indexOfFirstWordCharacter):
(wordLength):
Use iswalpha instead of isalpha, since TCHAR is really just wchar_t.

1:29 PM Changeset in webkit [79829] by Adam Roben
  • 1 edit
    1 add in trunk/LayoutTests

Add Windows expected failure results for fast/events/pageshow-pagehide-on-back-cached.html

<​http://webkit.org/b/55329> tracks the failure.

  • platform/win/fast/events/pageshow-pagehide-on-back-cached-expected.txt: Added.
1:29 PM Changeset in webkit [79828] by Adam Roben
  • 1 edit
    1 add in trunk/LayoutTests

Add Windows expected failure results for fast/images/support-broken-image-delegate.html

<​http://webkit.org/b/55324> tracks the failure.

  • platform/win/fast/images/support-broken-image-delegate-expected.txt: Added.
1:16 PM Changeset in webkit [79827] by Adam Roben
  • 4 edits in trunk/Tools

Make ResourceLoadDelegate print URLs relative to the main resource on Windows

This matches Mac. (In fact, the code was ported from Mac!)

Fixes <​http://webkit.org/b/55328> URLs printed by ResourceLoadDelegate on Windows don't
match Mac

Reviewed by Anders Carlsson.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(substringFromIndex): Added. Emulates -[NSString substringFromIndex:].
(urlSuitableForTestResult): Ported code from -[NSURL(DRTExtras)
_drt_descriptionSuitableForTestResult].
(cfStringRefToWString): Moved here from LayoutTestControllerWin.cpp.

  • DumpRenderTree/win/DumpRenderTreeWin.h: Added declaration of cfStringRefToWString.
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: Moved cfStringRefToWString to

DumpRenderTree.cpp.

11:38 AM Changeset in webkit [79826] by benjamin.poulain@nokia.com
  • 2 edits in trunk/Source/WebKit/qt

2011-02-27 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Andreas Kling.

[Qt] Reference the documentation of the WebKit bridge from QWebFrame::addToJavaScriptWindowObject()
​https://bugs.webkit.org/show_bug.cgi?id=55322

Documentation update, add a reference to the QtWebKit bridge page.

  • Api/qwebframe.cpp:
11:00 AM Debugging With Visual Studio edited by Adam Roben
Removed unnecessary ".dll" suffixes (diff)
11:00 AM Debugging With Visual Studio edited by Adam Roben
Updated CFShow instructions (diff)
10:59 AM Changeset in webkit [79825] by benjamin.poulain@nokia.com
  • 9 edits
    3 deletes in trunk/Source/WebCore

Eliminate DeprecatedPtrList
​https://bugs.webkit.org/show_bug.cgi?id=17425

Reviewed by Andreas Kling.

Remove the implementation of DeprecatedPtrList and all its references
from the build systems.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.order:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/DeprecatedPtrList.h: Removed.
  • platform/DeprecatedPtrListImpl.cpp: Removed.
  • platform/DeprecatedPtrListImpl.h: Removed.
10:25 AM Changeset in webkit [79824] by Adam Roben
  • 1 edit
    1 delete in trunk/LayoutTests

Remove Windows-specific html5lib results

I suspect these haven't been needed since r77781.

  • platform/win/html5lib/runner-expected.txt: Removed.
10:15 AM Changeset in webkit [79823] by Adam Roben
  • 2 edits in trunk/Tools

Change the order of Chang Shu's email addresses so the first one is their Bugzilla username

This makes Bugzilla autocompletion work correctly.

  • Scripts/webkitpy/common/config/committers.py:
10:05 AM Changeset in webkit [79822] by alex
  • 3 edits in trunk/Source/WebKit2

2011-02-27 Alejandro G. Castro <​alex@igalia.com>

Unreviewed, fixed GTK compilation after r79806.

  • UIProcess/gtk/WebView.cpp: (WebKit::WebView::didFinishLoadingDataForCustomRepresentation):
  • UIProcess/gtk/WebView.h:
10:04 AM Changeset in webkit [79821] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip fast/frames/iframe-plugin-load-remove-document-crash.html on Windows

It's been crashing since it was added in r79808. <​http://webkit.org/b/55307> tracks the
failure.

  • platform/win/Skipped:
9:59 AM Changeset in webkit [79820] by Patrick Gansterer
  • 4 edits in trunk

2011-02-27 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[Qt] fast/loader/user-stylesheet-fast-path.html fails
​https://bugs.webkit.org/show_bug.cgi?id=50911

  • platform/qt/Skipped: Unskip test which is now passing.

2011-02-27 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[Qt] fast/loader/user-stylesheet-fast-path.html fails
​https://bugs.webkit.org/show_bug.cgi?id=50911

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setUserStyleSheetLocation): Use QUrl::fromEncoded since the passed string is already encoded.
9:29 AM Changeset in webkit [79819] by Adam Roben
  • 2 edits in trunk/Tools

Ensure $testResultsDirectory is an absolute path before setting up Windows crash log saving

Windows 7 (and maybe Vista?) launches the post-mortem debugger with a working directory that
is different from old-run-webkit-test's. Because of this, the path to the crash log file
(which is relative to $testResultsDirectory) must be an absolute path. See the bug for more
details.

Fixes <​http://webkit.org/b/55318> Crash logs aren't saved on Windows 7 when a relative
--results-directory path is used (like on the test slaves)

Reviewed by Dan Bernstein.

  • Scripts/old-run-webkit-tests: Moved the call to setUpWindowsCrashLogSaving after we've

made $testResultsDirectory an absolute path.

8:37 AM QtWebKitDocContrib edited by benjamin.poulain@nokia.com
Update some references since the code have moved. (diff)
7:56 AM Changeset in webkit [79818] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebCore

2011-02-27 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Use WTF ref counting for FontPlatformDataPrivate
​https://bugs.webkit.org/show_bug.cgi?id=55303

Make FontPlatformDataPrivate a RefCounted<FPDP>.
Incidentally fixes an uninitialized member bug in FontPlatformData().

  • platform/graphics/qt/FontPlatformData.h: (WebCore::FontPlatformDataPrivate::FontPlatformDataPrivate): (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::isHashTableDeletedValue): (WebCore::FontPlatformData::font): (WebCore::FontPlatformData::size): (WebCore::FontPlatformData::family): (WebCore::FontPlatformData::bold): (WebCore::FontPlatformData::italic): (WebCore::FontPlatformData::smallCaps): (WebCore::FontPlatformData::pixelSize):
  • platform/graphics/qt/FontPlatformDataQt.cpp: (WebCore::toQFontWeight): (WebCore::FontPlatformData::operator==): (WebCore::FontPlatformData::hash):
7:51 AM Changeset in webkit [79817] by benjamin.poulain@nokia.com
  • 6 edits in trunk/Source

Eliminate DeprecatedPtrList from RenderBlock
​https://bugs.webkit.org/show_bug.cgi?id=54972

Patch by Benjamin Poulain <​ikipou@gmail.com> on 2011-02-27
Reviewed by Darin Adler.

Source/JavaScriptCore:

Add methods find() and contains() using an adaptor to ListHashSet.
Those method are like the one of HashSet, they allow to find objects
based on a different key than the one used to define the set.

Add convenience methods for direct access to the head and tail of the list.
Those methods are providing similar API/behavior as Vector.

  • wtf/ListHashSet.h:

(WTF::::first):
(WTF::::last):
(WTF::::removeLast):
(WTF::ListHashSetTranslatorAdapter::hash):
(WTF::ListHashSetTranslatorAdapter::equal):
(WTF::::find):
(WTF::::contains):

Source/WebCore:

Refactor RenderBlock to get rid of the DeprecatedPtrList.
The floating objects are stored in a ListHashSet.

Refactoring covered by existing test.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::~RenderBlock):
(WebCore::RenderBlock::addOverflowFromFloats):
(WebCore::RenderBlock::repaintOverhangingFloats):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::removeFloatingObject):
(WebCore::RenderBlock::removeFloatingObjectsBelow):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::positionNewFloatOnLine):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::nextFloatLogicalBottomBelow):
(WebCore::RenderBlock::lowestFloatLogicalBottom):
(WebCore::RenderBlock::clearFloats):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::addIntrudingFloats):
(WebCore::RenderBlock::containsFloat):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::adjustForBorderFit):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::FloatingObjectHashFunctions::hash):
(WebCore::RenderBlock::FloatingObjectHashFunctions::equal):
(WebCore::RenderBlock::FloatingObjectHashTranslator::hash):
(WebCore::RenderBlock::FloatingObjectHashTranslator::equal):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::matchedEndLine):

Feb 26, 2011:

10:53 PM Changeset in webkit [79816] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-26 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

<input value="type=submit"> throws a warning (“HTML parse error”)
​https://bugs.webkit.org/show_bug.cgi?id=55120

This patch removes parse error messages from the HTML parser. These
messages are displayed at the wrong times, aren't tested, and aren't
helpful. We'll try again with some more informative messages and
better testing.

  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::parseError):
7:38 PM Changeset in webkit [79815] by Patrick Gansterer
  • 4 edits in trunk/Source/WebCore

2011-02-26 Patrick Gansterer <Patrick Gansterer>

Reviewed by Alexey Proskuryakov.

Remove registerBaseEncodingNames and registerBaseCodecs from TextCodecBrew
​https://bugs.webkit.org/show_bug.cgi?id=55309

This functions are obsolete, since r78499 added TextCodecUTF8.

  • platform/text/TextEncodingRegistry.cpp: (WebCore::buildBaseTextCodecMaps):
  • platform/text/brew/TextCodecBrew.cpp:
  • platform/text/brew/TextCodecBrew.h:
7:28 PM Changeset in webkit [79814] by commit-queue@webkit.org
  • 2 edits in trunk

2011-02-26 Dihan Wickremasuriya <​dihan.wickremasuriya@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] [Symbian] Disable dependency to a specific version of a Qt package for
non-production builds.
​https://bugs.webkit.org/show_bug.cgi?id=55313

  • Source/WebKit.pri:
6:45 PM Changeset in webkit [79813] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-02-26 Dominic Mazzoni <​dmazzoni@google.com>

Reviewed by Adam Barth.

m_dumpAccessibilityNotifications should be initialized.
​https://bugs.webkit.org/show_bug.cgi?id=54874

  • DumpRenderTree/chromium/AccessibilityController.cpp: (AccessibilityController::AccessibilityController):
3:03 PM Changeset in webkit [79812] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-26 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

Add support for DragonFly BSD
​https://bugs.webkit.org/show_bug.cgi?id=54407

DragonFly BSD is based on FreeBSD, so handle it like FreeBSD.

  • wtf/Platform.h:
2:55 PM Changeset in webkit [79811] by inferno@chromium.org
  • 3 edits in trunk/LayoutTests

2011-02-26 Abhishek Arya <​inferno@chromium.org>

Unreviewed.

Skip the test on QT, GTK until we can figure out the plugin load problem.
​https://bugs.webkit.org/show_bug.cgi?id=55307

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
2:40 PM Changeset in webkit [79810] by jschuh@chromium.org
  • 3 edits
    2 adds in trunk

2011-02-26 Justin Schuh <​jschuh@chromium.org>

Reviewed by Darin Adler.

Delay firing of mutation events while setting attribute values
​https://bugs.webkit.org/show_bug.cgi?id=55199

  • fast/dom/attribute-change-on-mutate-expected.txt: Added.
  • fast/dom/attribute-change-on-mutate.html: Added.

2011-02-26 Justin Schuh <​jschuh@chromium.org>

Reviewed by Darin Adler.

Delay firing of mutation events while setting attribute values
​https://bugs.webkit.org/show_bug.cgi?id=55199

Test: fast/dom/attribute-change-on-mutate.html

  • dom/Attr.cpp: (WebCore::Attr::setValue):
2:38 PM Changeset in webkit [79809] by yi.4.shen@nokia.com
  • 3 edits in trunk/Source/WebCore

2011-02-26 Yi Shen <​yi.4.shen@nokia.com>

Reviewed by Andreas Kling.

[Qt] Notify HTMLMediaElement when MediaPlayerPrivateQt's playback state gets changed
​https://bugs.webkit.org/show_bug.cgi?id=55252

Need to invoke a callback function to notify the HTMLMediaElement
when MediaPlayerPrivateQt's playback state gets changed.

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt): Set a flag to ignore the playback state change for pre-roll (WebCore::MediaPlayerPrivateQt::commitLoad): Call playbackStateChanged() to notify HTMLMediaElement (WebCore::MediaPlayerPrivateQt::stateChanged):
  • platform/graphics/qt/MediaPlayerPrivateQt.h:
1:26 PM Changeset in webkit [79808] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2011-02-25 Abhishek Arya <​inferno@chromium.org>

Reviewed by Adam Barth.

Tests that removing a document during a plugin load does not result
in crash.
​https://bugs.webkit.org/show_bug.cgi?id=55289

  • fast/frames/iframe-plugin-load-remove-document-crash-expected.txt: Added.
  • fast/frames/iframe-plugin-load-remove-document-crash.html: Added.

2011-02-25 Abhishek Arya <​inferno@chromium.org>

Reviewed by Adam Barth.

When plugin document parser finishes parsing, it runs the raw
document's parser finish functions which call the pending document
onload events that removes the frame from underneath. So, we protect
frame (and hence frameloader) in DocumentLoader::commitLoad.
​https://bugs.webkit.org/show_bug.cgi?id=55289

Test: fast/frames/iframe-plugin-load-remove-document-crash.html

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::commitLoad):
1:02 PM Changeset in webkit [79807] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-26 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Asynchronous response to FramePolicyListener is not finishing the load
​https://bugs.webkit.org/show_bug.cgi?id=55305
<rdar://problem/9044356>

Always initialize the receivedPolicyAction reply parameter.

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::decidePolicyForNavigationAction): (WebKit::WebPageProxy::decidePolicyForMIMEType):
12:44 PM Changeset in webkit [79806] by andersca@apple.com
  • 16 edits in trunk/Source/WebKit2

2011-02-26 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

DidFinishLoadingDataForCustomRepresentation should pass along the suggested filename
​https://bugs.webkit.org/show_bug.cgi?id=55304

  • UIProcess/API/mac/PDFViewController.h:
  • UIProcess/API/mac/PDFViewController.mm: (WebKit::PDFViewController::setPDFDocumentData):
  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::didFinishLoadingDataForCustomRepresentation):
  • UIProcess/API/mac/WKView.mm: (-[WKView _didFinishLoadingDataForCustomRepresentationWithSuggestedFilename:dataReference:CoreIPC::]):
  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::didFinishLoadingDataForCustomRepresentation):
  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didFinishLoadingDataForCustomRepresentation):
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/win/WebView.cpp: (WebKit::WebView::didFinishLoadingDataForCustomRepresentation):
  • UIProcess/win/WebView.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::finishedLoading):
12:14 PM Changeset in webkit [79805] by pfeldman@chromium.org
  • 18 edits
    31 deletes in trunk

2011-02-26 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: rolling out 79799 and 79804 for breaking xml tests on mac.

11:58 AM Changeset in webkit [79804] by pfeldman@chromium.org
  • 4 edits in trunk

2011-02-26 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: follow up to r79799. Fixing WinCE+Efl, mute new tests on Qt.
​https://bugs.webkit.org/show_bug.cgi?id=55302

  • CMakeLists.txt:
  • platform/qt/Skipped:
11:10 AM Changeset in webkit [79803] by andersca@apple.com
  • 25 edits in trunk/Source/WebKit2

2011-02-26 Anders Carlsson <​andersca@apple.com>

Reviewed by Oliver Hunt.

DrawingArea should not be reference counted
​https://bugs.webkit.org/show_bug.cgi?id=55284

  • Shared/DrawingAreaInfo.h:
  • Shared/WebPageCreationParameters.cpp: (WebKit::WebPageCreationParameters::encode): (WebKit::WebPageCreationParameters::decode):
  • Shared/WebPageCreationParameters.h:
  • UIProcess/ChunkedUpdateDrawingAreaProxy.cpp: (WebKit::ChunkedUpdateDrawingAreaProxy::ChunkedUpdateDrawingAreaProxy): (WebKit::ChunkedUpdateDrawingAreaProxy::setPageIsVisible): (WebKit::ChunkedUpdateDrawingAreaProxy::update): (WebKit::ChunkedUpdateDrawingAreaProxy::sendSetSize):
  • UIProcess/ChunkedUpdateDrawingAreaProxy.h:
  • UIProcess/DrawingAreaProxy.cpp: (WebKit::DrawingAreaProxy::DrawingAreaProxy):
  • UIProcess/DrawingAreaProxy.h: (WebKit::DrawingAreaProxy::type):
  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl):
  • UIProcess/DrawingAreaProxyImpl.h:
  • UIProcess/TiledDrawingAreaProxy.cpp: (WebKit::TiledDrawingAreaProxy::TiledDrawingAreaProxy):
  • UIProcess/TiledDrawingAreaProxy.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didReceiveSyncMessage): (WebKit::WebPageProxy::creationParameters):
  • WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
  • WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp: (WebKit::ChunkedUpdateDrawingArea::ChunkedUpdateDrawingArea): (WebKit::ChunkedUpdateDrawingArea::display): (WebKit::ChunkedUpdateDrawingArea::setSize): (WebKit::ChunkedUpdateDrawingArea::didReceiveMessage):
  • WebProcess/WebPage/ChunkedUpdateDrawingArea.h:
  • WebProcess/WebPage/DrawingArea.cpp: (WebKit::DrawingArea::create): (WebKit::DrawingArea::DrawingArea):
  • WebProcess/WebPage/DrawingArea.h:
  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::create): (WebKit::DrawingAreaImpl::DrawingAreaImpl):
  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/TiledDrawingArea.cpp: (WebKit::TiledDrawingArea::TiledDrawingArea):
  • WebProcess/WebPage/TiledDrawingArea.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::drawRect):
  • WebProcess/WebPage/WebPage.h:
11:08 AM Changeset in webkit [79802] by commit-queue@webkit.org
  • 5 edits
    1 copy in trunk/Source/WebKit/gtk

2011-02-26 Lukasz Slachciak <​l.slachciak@samsung.com>

Reviewed by Xan Lopez.

[GTK] Implemented API to set/get web application cache directory path database.

  • GNUmakefile.am: Add webkitapplicationcache.h file.
  • webkit/webkit.h: Add webkitapplicationcache.h file.
  • webkit/webkitapplicationcache.cpp: definition of API setting and getting web application cache directory path database. (webkit_application_cache_get_database_directory_path): (webkit_application_cache_set_database_directory_path):
  • webkit/webkitapplicationcache.h: Added new API file for setting and getting web application cache directory path database.
  • webkit/webkitglobals.cpp: (webkitInit): use webkit_application_cache_set_database_directory_path to set default web application cache directory path database.
11:06 AM Changeset in webkit [79801] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-26 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update.

Add failing expectation for fast/images/support-broken-image-delegate.html

  • platform/chromium/test_expectations.txt:
11:00 AM Changeset in webkit [79800] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-26 Mihai Parparita <​mihaip@chromium.org>

Unreviewed update of the Chromium html5lib expectations after r79765
(diff matches the base expectations change).

  • platform/chromium/html5lib/runner-expected.txt:
10:54 AM Changeset in webkit [79799] by pfeldman@chromium.org
  • 17 edits
    36 adds in trunk

2011-02-25 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

XML without style should render as syntax-highlighted source.
​https://bugs.webkit.org/show_bug.cgi?id=13807

Added tests for XML tree view mode. Testing both logic for entering
XML tree view mode and rendering itself.

  • http/tests/xmlviewer/dumpAsText/css-stylesheet-expected.txt: Added.
  • http/tests/xmlviewer/dumpAsText/css-stylesheet.xml: Added.
  • http/tests/xmlviewer/dumpAsText/frames-expected.txt: Added.
  • http/tests/xmlviewer/dumpAsText/frames.html: Added.
  • http/tests/xmlviewer/dumpAsText/mathml-expected.txt: Added.
  • http/tests/xmlviewer/dumpAsText/mathml.xml: Added.
  • http/tests/xmlviewer/dumpAsText/resources/css-stylesheet.css: Added. (assertion):
  • http/tests/xmlviewer/dumpAsText/resources/frames-helper.xml: Added.
  • http/tests/xmlviewer/dumpAsText/resources/xsl.xml: Added.
  • http/tests/xmlviewer/dumpAsText/svg-expected.txt: Added.
  • http/tests/xmlviewer/dumpAsText/svg.xml: Added.
  • http/tests/xmlviewer/dumpAsText/wml-expected.txt: Added.
  • http/tests/xmlviewer/dumpAsText/wml.xml: Added.
  • http/tests/xmlviewer/dumpAsText/xhtml-tag-expected.txt: Added.
  • http/tests/xmlviewer/dumpAsText/xhtml-tag.xml: Added.
  • http/tests/xmlviewer/dumpAsText/xlink-expected.txt: Added.
  • http/tests/xmlviewer/dumpAsText/xlink.xml: Added.
  • http/tests/xmlviewer/dumpAsText/xmlviewer-charset-cp1251-expected.txt: Added.
  • http/tests/xmlviewer/dumpAsText/xmlviewer-charset-cp1251.xml: Added.
  • http/tests/xmlviewer/dumpAsText/xmlviewer-charset-utf8-expected.txt: Added.
  • http/tests/xmlviewer/dumpAsText/xmlviewer-charset-utf8.xml: Added.
  • http/tests/xmlviewer/dumpAsText/xmlviewer-expected.txt: Added.
  • http/tests/xmlviewer/dumpAsText/xmlviewer.xml: Added.
  • http/tests/xmlviewer/dumpAsText/xsl-stylesheet-expected.txt: Added.
  • http/tests/xmlviewer/dumpAsText/xsl-stylesheet.xml: Added.
  • http/tests/xmlviewer/dumpAsText/xul-expected.txt: Added.
  • http/tests/xmlviewer/dumpAsText/xul.xml: Added.
  • platform/chromium/http/tests/xmlviewer/dumpAsText/mathml-expected.txt: Added.

2011-02-25 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

XML without style should render as syntax-highlighted source.
​https://bugs.webkit.org/show_bug.cgi?id=13807

XML tree view mode implemented. If XML does not have any style
information, it is rendered as highlighted source with collapsable
elements.

Tests: http/tests/xmlviewer/dumpAsText/css-stylesheet.xml

http/tests/xmlviewer/dumpAsText/frames.html
http/tests/xmlviewer/dumpAsText/mathml.xml
http/tests/xmlviewer/dumpAsText/svg.xml
http/tests/xmlviewer/dumpAsText/wml.xml
http/tests/xmlviewer/dumpAsText/xhtml-tag.xml
http/tests/xmlviewer/dumpAsText/xlink.xml
http/tests/xmlviewer/dumpAsText/xmlviewer-charset-cp1251.xml
http/tests/xmlviewer/dumpAsText/xmlviewer-charset-utf8.xml
http/tests/xmlviewer/dumpAsText/xmlviewer.xml
http/tests/xmlviewer/dumpAsText/xsl-stylesheet.xml
http/tests/xmlviewer/dumpAsText/xul.xml

  • CMakeLists.txt:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchUARules):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::createElement):
  • dom/Document.h: (WebCore::Document::usesViewSourceStyles): (WebCore::Document::setUsesViewSourceStyles): (WebCore::Document::sawElementsInKnownNamespaces):
  • dom/XMLDocumentParser.h:
  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::XMLDocumentParser): (WebCore::XMLDocumentParser::processingInstruction): (WebCore::XMLDocumentParser::initializeParserContext): (WebCore::XMLDocumentParser::doEnd):
  • dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::XMLDocumentParser): (WebCore::XMLDocumentParser::initializeParserContext): (WebCore::XMLDocumentParser::parseProcessingInstruction):
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
  • xml/XMLTreeViewer.cpp: Added. (WebCore::XMLTreeViewer::XMLTreeViewer): (WebCore::XMLTreeViewer::hasNoStyleInformation): (WebCore::XMLTreeViewer::transformDocumentToTreeView):
  • xml/XMLTreeViewer.h: Added. (WebCore::XMLTreeViewer::~XMLTreeViewer):
  • xml/XMLViewer.xsl: Added.
  • xml/XSLStyleSheet.h: (WebCore::XSLStyleSheet::createFromString):
10:26 AM Changeset in webkit [79798] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk/po

2011-02-26 Christian Dywan <​christian@lanedo.com>

Reviewed by Andreas Kling.

Untranslated network error messages
​https://bugs.webkit.org/show_bug.cgi?id=55223

  • POTFILES: Add FrameLoaderClientGtk.cpp.
9:29 AM Changeset in webkit [79797] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

2011-02-26 Adam Klein <​adamk@chromium.org>

Reviewed by James Robinson.

[chromium] Update op-get-entry filesystem test to match spec
​https://bugs.webkit.org/show_bug.cgi?id=55263

Chromium behavior changed in r76098. This patch updates WebKit test
to match. Both now match the spec, which says of TYPE_MISMATCH_ERR:

user agent MUST use this code when the user has attempted to look up
a file or directory, but the Entry found is of the wrong type

Reference: ​http://dev.w3.org/2009/dap/file-system/file-dir-sys.html#error-code-descriptions

  • fast/filesystem/op-get-entry-expected.txt:
  • fast/filesystem/resources/op-get-entry.js: GetFile/GetDirectory now expected to return TYPE_MISMATCH_ERR if requesting a non-file/non-directory.
  • platform/chromium/test_expectations.txt: Allow op-get-entry to pass while waiting for Chromium roll.
9:26 AM Changeset in webkit [79796] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-26 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations change.

Remove failing Snow Leopard expectations for tests that were fixed by
r79754.

Skip more viewport tests added by r79783.

  • platform/chromium/test_expectations.txt:
9:12 AM Changeset in webkit [79795] by andreas.kling@nokia.com
  • 4 edits in trunk/Source/WebCore

2011-02-26 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Enable usage of synchronous HTTP feature in Qt
​https://bugs.webkit.org/show_bug.cgi?id=37191

Currently, we spin an event loop when doing synchronous calls to
wait for completion. This patch uses synchronous requests in Qt,
if available, and spins the event loop as a fallback solution.

Based on work by Simon Hausmann and Peter Hartmann.

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): (WebCore::QNetworkReplyHandler::start):
  • platform/network/qt/QNetworkReplyHandler.h:
  • platform/network/qt/ResourceHandleQt.cpp: (WebCore::WebCoreSynchronousLoader::setReplyFinished): (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader): (WebCore::WebCoreSynchronousLoader::didFinishLoading): (WebCore::WebCoreSynchronousLoader::didFail): (WebCore::ResourceHandle::loadResourceSynchronously):
9:02 AM Changeset in webkit [79794] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

2011-02-26 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Kent Tamura.

REGRESSION(r79398): Webkit crash on dojo theme tester page
​https://bugs.webkit.org/show_bug.cgi?id=55290

Added a test to ensure WebKit does not crash when querying style value without selection.

  • editing/execCommand/value-without-selection-crash-expected.txt: Added.
  • editing/execCommand/value-without-selection-crash.html: Added.

2011-02-26 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Kent Tamura.

REGRESSION(r79398): Webkit crash on dojo theme tester page
​https://bugs.webkit.org/show_bug.cgi?id=55290

The bug was caused by selectionStartCSSPropertyValue's not considering the possibility
of selectionStartStyle() returning a null pointer. Fixed it by adding a null check.

Test: editing/execCommand/value-without-selection-crash.html

  • editing/Editor.cpp: (WebCore::Editor::selectionStartCSSPropertyValue):
8:31 AM Changeset in webkit [79793] by pfeldman@chromium.org
  • 30 edits in trunk

2011-02-26 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

DumpRenderTree should reset frame opener between tests.
​https://bugs.webkit.org/show_bug.cgi?id=54874

No new tests. (no code affected, just exporting a method for DumpRenderTree use)

  • WebCore.exp.in:

2011-02-26 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

DumpRenderTree should reset frame opener between tests.
​https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener method to WebFrame.

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::clearOpener):
  • src/WebFrameImpl.h:

2011-02-26 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

DumpRenderTree should reset frame opener between tests.
​https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener method to DumpRenderTreeSupportGTK.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::clearOpener):
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

2011-02-26 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

DumpRenderTree should reset frame opener between tests.
​https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener method to WebFramePrivate.

  • WebView/WebFrame.mm: (-[WebFrame _clearOpener]):
  • WebView/WebFramePrivate.h:

2011-02-26 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

DumpRenderTree should reset frame opener between tests.
​https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener method to DumpRenderTreeSupportQT.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::clearOpener):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-02-26 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

DumpRenderTree should reset frame opener between tests.
​https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener method to IWebFramePrivate.
Touched WebKit.idl to trigger build scripts.

  • Interfaces/IWebFramePrivate.idl:
  • Interfaces/WebKit.idl:
  • WebFrame.cpp: (WebFrame::clearOpener):
  • WebFrame.h:

2011-02-26 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

DumpRenderTree should reset frame opener between tests.
​https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener method to WKBundleWebFramePrivate.

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: (WKBundleFrameClearOpener):
  • WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:

2011-02-26 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

DumpRenderTree should reset frame opener between tests.
​https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener() calls between tests.
Some tests are using window.open() to change current window location.
This changes window.opener property whose nullity is checked before
showing xml viewer.

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetTestController):
  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
  • DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
  • DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::reset):
8:20 AM Changeset in webkit [79792] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/Source/WebKit/efl

2011-02-26 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Kent Tamura.

[EFL] Replace WTF_USE_SOUP macro with USE(SOUP)
​https://bugs.webkit.org/show_bug.cgi?id=55296

ewk_cookies.cpp and ewk_main.cpp are using WTF_USE_SOUP macro.
So, according to policy decision macro usage, the macro needs to
be changed with USE(SOUP).

  • ewk/ewk_cookies.cpp: (ewk_cookies_file_set): (ewk_cookies_clear): (ewk_cookies_get_all): (ewk_cookies_cookie_del): (ewk_cookies_cookie_free): (ewk_cookies_policy_set): (ewk_cookies_policy_get):
  • ewk/ewk_main.cpp: (_ewk_init_body):
7:52 AM Changeset in webkit [79791] by yael.aharon@nokia.com
  • 4 edits in trunk

2011-02-26 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Andreas Kling.

[Qt] Fix the focus in MiniBrowser.
​https://bugs.webkit.org/show_bug.cgi?id=55288

Implement basic functionality for focus in QWKPagePrivate.

  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::isViewWindowActive): (QWKPagePrivate::isViewFocused): (QWKPagePrivate::isViewVisible):

2011-02-26 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Andreas Kling.

[Qt] Fix the focus in MiniBrowser.
​https://bugs.webkit.org/show_bug.cgi?id=55288

Give focus to the web view when a load starts.

  • MiniBrowser/qt/BrowserWindow.cpp: (BrowserWindow::urlChanged):
7:48 AM Changeset in webkit [79790] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-26 Jia Pu <​jpu@apple.com>

Reviewed by Dan Bernstein.

On Mac, need to remove misspell underline in Editor::learnSpelling().
​https://bugs.webkit.org/show_bug.cgi?id=55251

This change makes sure that the misspelling markers are removed after the word is learned.

  • editing/Editor.cpp: (WebCore::Editor::learnSpelling):
7:38 AM Changeset in webkit [79789] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Tools

2011-02-26 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Adam Barth.

[EFL] Add coding style exceptions for EFL port
​https://bugs.webkit.org/show_bug.cgi?id=54733

The EFL APIs use EFL naming style, which includes both lower-cased and camel-cased,
underscore-sparated values. But, style checking rule have found parameter_name errors
in efl directories so far.

  • Scripts/webkitpy/style/checker.py: Add prameter_name rule's exception and efl directories.
7:32 AM Changeset in webkit [79788] by abarth@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-26 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

JavaScriptCore should use the xcconfig file instead of importing that information into GYP
​https://bugs.webkit.org/show_bug.cgi?id=55282

Technically, this breaks the build because I had removed one of the
warnings in this config file, but this change seems like an
improvement.

  • gyp/JavaScriptCore.gyp:
7:29 AM Changeset in webkit [79787] by levin@chromium.org
  • 3 edits in trunk/Tools

2011-02-26 David Levin <​levin@chromium.org>

Reviewed by Darin Adler.

check-webkit-style should check for spaces after periods in comments
​https://bugs.webkit.org/show_bug.cgi?id=55253

  • Scripts/webkitpy/style/checkers/cpp.py: Added the check.
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests and fixed the name of one related test.
7:00 AM Changeset in webkit [79786] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-02-26 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: rolling chromium DEPS.

  • DEPS:
6:45 AM Changeset in webkit [79785] by levin@chromium.org
  • 2 edits in trunk/Websites/webkit.org

2011-02-26 David Levin <​levin@chromium.org>

Reviewed by Darin Adler.

Add style guidelines about comments from the unwritten rules email.
​https://bugs.webkit.org/show_bug.cgi?id=55272

  • coding/coding-style.html: Added the guidelines.
6:40 AM Changeset in webkit [79784] by commit-queue@webkit.org
  • 8 edits in trunk

2011-02-26 Rik Cabanier <​cabanier@adobe.com>

Reviewed by David Hyatt.

Fix that allows fixed length values to be floating point
​https://bugs.webkit.org/show_bug.cgi?id=52699

Transitions now return matrices in floating point. 2 of the transition tests were failing
because they expected integer values.

  • transitions/matched-transform-functions.html:
  • transitions/retargetted-transition.html:

2011-02-26 Rik Cabanier <​cabanier@adobe.com>

Reviewed by David Hyatt.

Fix that allows fixed length values to be floating point
​https://bugs.webkit.org/show_bug.cgi?id=52699

Transitions now return matrices in floating point. 2 of the transition tests were failing
because they expected integer values.

  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSStyleSelector.cpp: (WebCore::convertToLength): (WebCore::convertToIntLength): (WebCore::convertToFloatLength): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::createTransformOperations):
  • platform/Length.h: (WebCore::Length::Length): (WebCore::Length::operator==): (WebCore::Length::operator!=): (WebCore::Length::rawValue): (WebCore::Length::type): (WebCore::Length::quirk): (WebCore::Length::setValue): (WebCore::Length::calcFloatValue): (WebCore::Length::isZero): (WebCore::Length::blend): (WebCore::Length::getIntValue): (WebCore::Length::getFloatValue):
  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
  • rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::calcWidthArray):
6:39 AM Changeset in webkit [79783] by kenneth@webkit.org
  • 134 edits
    6 copies in trunk

2011-02-26 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Andreas Kling.

Make it possible to test the targetdensity-dpi support
​https://bugs.webkit.org/show_bug.cgi?id=55142

  • fast/viewport/viewport-*.html: Update to new JS API.
  • fast/viewport/viewport-91.html: Add new tests.
  • fast/viewport/viewport-92.html:
  • fast/viewport/viewport-93.html:
  • fast/viewport/viewport-94.html:
  • fast/viewport/viewport-95.html:
  • fast/viewport/viewport-96.html:

2011-02-26 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Andreas Kling.

Make it possible to test the targetdensity-dpi support
​https://bugs.webkit.org/show_bug.cgi?id=55142

Test the viewport meta tag feature targetdensity-dpi by
adding extra arguments to dumpConfigurationForViewport

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::dumpConfigurationForViewport):
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

2011-02-26 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Andreas Kling.

Make it possible to test the targetdensity-dpi support
​https://bugs.webkit.org/show_bug.cgi?id=55142

Test the viewport meta tag feature targetdensity-dpi by
adding extra arguments to dumpConfigurationForViewport

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::viewportAsText):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-02-26 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Andreas Kling.

Make it possible to test the targetdensity-dpi support
​https://bugs.webkit.org/show_bug.cgi?id=55142

Test the viewport meta tag feature targetdensity-dpi by
adding extra arguments to dumpConfigurationForViewport

Add the new arguments to the shared header and all
implementation.

  • DumpRenderTree/LayoutTestController.cpp: (dumpConfigurationForViewportCallback):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::dumpConfigurationForViewport):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::dumpConfigurationForViewport):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::dumpConfigurationForViewport):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::dumpConfigurationForViewport):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::dumpConfigurationForViewport):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
6:26 AM Changeset in webkit [79782] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/chromium

2011-02-26 Bill Budge <​bbudge@chromium.org>

Reviewed by David Levin.

WebURLRequest, WebURLResponse properties should be passed to WebCore Layer
​https://bugs.webkit.org/show_bug.cgi?id=54489

No tests needed. This is already tested by ui_tests, nacl_ui_tests, and nacl_sandbox_tests

  • src/WebURLRequest.cpp: (WebKit::WebURLRequestPrivateImpl::WebURLRequestPrivateImpl): (WebKit::WebURLRequest::downloadToFile): (WebKit::WebURLRequest::setDownloadToFile):
  • src/WebURLRequestPrivate.h: (WebKit::WebURLRequestPrivate::WebURLRequestPrivate):
  • src/WebURLResponse.cpp: (WebKit::WebURLResponsePrivateImpl::WebURLResponsePrivateImpl): (WebKit::WebURLResponse::downloadFilePath): (WebKit::WebURLResponse::setDownloadFilePath):
  • src/WebURLResponsePrivate.h:
5:59 AM Changeset in webkit [79781] by eric@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-02-26 Eric Seidel <​eric@webkit.org>

Reviewed by Maciej Stachowiak.

malloc in removeChildren shows up on profile of peacekeeper domDynamicCreationCreateElement
​https://bugs.webkit.org/show_bug.cgi?id=55204

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren):
    • Using an inlineCapacity of 10 for now. We may want to tweak it later.
    • This removes yet another malloc from code which removes nodes (which is rather common).
5:47 AM Changeset in webkit [79780] by eric@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-26 Eric Seidel <​eric@webkit.org>

Reviewed by Maciej Stachowiak.

HashSet<T>::end() creation is expensive and should be avoided
​https://bugs.webkit.org/show_bug.cgi?id=55205

In the common case, m_ranges is an empty set. When that's
the case, we spend all our time in skipEmptyBuckets, walking
the hash storage skipping over empty buckets.

This looks to be at least a 5% speedup on (my local version of) peacekeeper's domDynamicCreationCreateElement.

Before:
avg 383.6666666666667
median 386
stdev 7.152311203768722
min 360
max 391

After:
avg 366.3333333333333
median 366
stdev 2.712112747574399
min 362
max 377

  • dom/Document.cpp: (WebCore::Document::nodeChildrenChanged): (WebCore::Document::nodeChildrenWillBeRemoved): (WebCore::Document::nodeWillBeRemoved): (WebCore::Document::textInserted): (WebCore::Document::textRemoved): (WebCore::Document::textNodesMerged): (WebCore::Document::textNodeSplit):
5:15 AM Changeset in webkit [79779] by rniwa@webkit.org
  • 30 edits in trunk

2011-02-26 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r79764.
​http://trac.webkit.org/changeset/79764
​https://bugs.webkit.org/show_bug.cgi?id=55295

"broke Chromium builds" (Requested by rniwa on #webkit).

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetTestController):
  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
  • DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
  • DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::reset):

2011-02-26 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r79764.
​http://trac.webkit.org/changeset/79764
​https://bugs.webkit.org/show_bug.cgi?id=55295

"broke Chromium builds" (Requested by rniwa on #webkit).

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp:
  • src/WebFrameImpl.h:

2011-02-26 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r79764.
​http://trac.webkit.org/changeset/79764
​https://bugs.webkit.org/show_bug.cgi?id=55295

"broke Chromium builds" (Requested by rniwa on #webkit).

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-02-26 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r79764.
​http://trac.webkit.org/changeset/79764
​https://bugs.webkit.org/show_bug.cgi?id=55295

"broke Chromium builds" (Requested by rniwa on #webkit).

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

2011-02-26 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r79764.
​http://trac.webkit.org/changeset/79764
​https://bugs.webkit.org/show_bug.cgi?id=55295

"broke Chromium builds" (Requested by rniwa on #webkit).

  • Interfaces/IWebFramePrivate.idl:
  • Interfaces/WebKit.idl:
  • WebFrame.cpp:
  • WebFrame.h:

2011-02-26 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r79764.
​http://trac.webkit.org/changeset/79764
​https://bugs.webkit.org/show_bug.cgi?id=55295

"broke Chromium builds" (Requested by rniwa on #webkit).

  • WebView/WebFrame.mm:
  • WebView/WebFramePrivate.h:

2011-02-26 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r79764.
​http://trac.webkit.org/changeset/79764
​https://bugs.webkit.org/show_bug.cgi?id=55295

"broke Chromium builds" (Requested by rniwa on #webkit).

  • WebCore.exp.in:

2011-02-26 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r79764.
​http://trac.webkit.org/changeset/79764
​https://bugs.webkit.org/show_bug.cgi?id=55295

"broke Chromium builds" (Requested by rniwa on #webkit).

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
5:14 AM Changeset in webkit [79778] by commit-queue@webkit.org
  • 13 edits
    1 copy
    3 adds in trunk

2011-02-26 Adam Klein <​adamk@chromium.org>

Reviewed by Adam Barth.

[fileapi] Implement EntrySync.toURI by moving Entry::toURI to EntryBase
​https://bugs.webkit.org/show_bug.cgi?id=54585

  • fast/filesystem/resources/file-entry-to-uri-sync.js: Added.
  • fast/filesystem/workers/file-entry-to-uri-sync-expected.txt: Added.
  • fast/filesystem/workers/file-entry-to-uri-sync.html: Added.

2011-02-26 Adam Klein <​adamk@chromium.org>

Reviewed by Adam Barth.

[fileapi] Implement EntrySync.toURI by moving Entry::toURI to EntryBase
​https://bugs.webkit.org/show_bug.cgi?id=54585

In order to move toURI to EntryBase, it needed access to
SecurityOrigin. Most of the changes below were to pass a
ScriptExecutionContext to DOMFileSystemBase to enable this.

Test: fast/filesystem/workers/file-entry-to-uri-sync.html

  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • fileapi/DOMFileSystem.cpp: (WebCore::DOMFileSystem::DOMFileSystem):
  • fileapi/DOMFileSystemBase.cpp: (WebCore::DOMFileSystemBase::DOMFileSystemBase): (WebCore::DOMFileSystemBase::securityOrigin):
  • fileapi/DOMFileSystemBase.h: (WebCore::DOMFileSystemBase::create):
  • fileapi/DOMFileSystemSync.cpp: (WebCore::DOMFileSystemSync::create): (WebCore::DOMFileSystemSync::DOMFileSystemSync):
  • fileapi/DOMFileSystemSync.h: (WebCore::DOMFileSystemSync::create):
  • fileapi/Entry.cpp:
  • fileapi/Entry.h:
  • fileapi/EntryBase.cpp: Added. (WebCore::EntryBase::EntryBase): (WebCore::EntryBase::~EntryBase): (WebCore::EntryBase::toURI):
  • fileapi/EntryBase.h:
  • fileapi/EntrySync.idl:
4:12 AM Changeset in webkit [79777] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-02-26 Alice Boxhall <​aboxhall@chromium.org>

Reviewed by Ojan Vafai.

Tests that typing enter in the input element does not fire textInput.
​https://bugs.webkit.org/show_bug.cgi?id=54152

  • fast/forms/textinput-not-fired-on-enter-in-input-expected.txt: Added.
  • fast/forms/textinput-not-fired-on-enter-in-input.html: Added.

2011-02-26 Alice Boxhall <​aboxhall@chromium.org>

Reviewed by Ojan Vafai.

typing enter in the input element should not fire textInput
​https://bugs.webkit.org/show_bug.cgi?id=54152

Stop textInput event propagation in HTMLInputElement::preDispatchEventHandler if the event target should submit implicitly.

Test: fast/forms/textinput-not-fired-on-enter-in-input.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::preDispatchEventHandler): Check m_inputType->shouldSubmitImplicitly for textInputEvents and stop propagation if true.
4:04 AM Changeset in webkit [79776] by simonjam@chromium.org
  • 4 edits in trunk

2011-02-26 James Simonsen <​simonjam@chromium.org>

Reviewed by Tony Gentilcore.

[Web Timing] loadEvent timing should refer to first load event if there are many
​https://bugs.webkit.org/show_bug.cgi?id=55201

  • fast/dom/script-tests/webtiming-document-open.js: (testTimingWithDocumentOpen): Fire via setTimeout to match w3c test and reveal loadEventEnd. (finishTest): Fire via setTimeout to match w3c test.

2011-02-26 James Simonsen <​simonjam@chromium.org>

Reviewed by Tony Gentilcore.

[Web Timing] loadEvent timing should refer to first load event if there are many
​https://bugs.webkit.org/show_bug.cgi?id=55201

Test: fast/dom/webtiming-document-open.html

  • page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchLoadEvent):
3:20 AM Changeset in webkit [79775] by tonyg@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-02-26 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Adam Barth.

Fix isLayoutTimerActive for ports that set a minimumLayoutDelay
​https://bugs.webkit.org/show_bug.cgi?id=54810

No new tests because no new functionality.

  • dom/Document.cpp: (WebCore::Document::isLayoutTimerActive): Moved from HTMLParserScheduler per FIXME. Compare minimumLayoutDelay() to m_extraLayoutDelay instead of 0. This spirit of this comparison was broken by r52919. The effect would be that ports that set an extra layout delay can't yield between tokens. Note: can't be const because minimumLayoutDelay sets a member.
  • dom/Document.h:
  • html/parser/HTMLParserScheduler.cpp: (WebCore::HTMLParserScheduler::continueNextChunkTimerFired): (WebCore::HTMLParserScheduler::checkForYieldBeforeScript):
2:17 AM Changeset in webkit [79774] by commit-queue@webkit.org
  • 10 edits in trunk/Source

2011-02-26 David Dorwin <​ddorwin@chromium.org>

Reviewed by Darin Fisher.

Enable WebKit Full Screen API in Chromium. The element becomes the full size of the window, but the window is not yet full screen. Support is disabled by default.

fullscreen javascript bindings not implemented for v8
​https://bugs.webkit.org/show_bug.cgi?id=44797

Tested by the existing fullscreen Layout Tests.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:

2011-02-26 David Dorwin <​ddorwin@chromium.org>

Reviewed by Darin Fisher.

Enable WebKit Full Screen API in Chromium. The element becomes the full size of the window, but the window is not yet full screen. Support is disabled by default.

fullscreen javascript bindings not implemented for v8
​https://bugs.webkit.org/show_bug.cgi?id=44797

  • features.gypi:
  • public/WebSettings.h:
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::supportsFullScreenForElement): (WebKit::ChromeClientImpl::enterFullScreenForElement): (WebKit::ChromeClientImpl::exitFullScreenForElement): (WebKit::ChromeClientImpl::fullScreenRendererChanged):
  • src/ChromeClientImpl.h:
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setFullScreenEnabled):
  • src/WebSettingsImpl.h:
2:11 AM Changeset in webkit [79773] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-26 Thouraya ANDOLSI <​thouraya.andolsi@st.com>

Reviewed by Nikolas Zimmermann.

SH4 JIT SUPPORT
​https://bugs.webkit.org/show_bug.cgi?id=44329

Provide an ExecutableAllocater::cacheFlush() implementation for
Linux/SH4.

  • jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::cacheFlush):
1:45 AM Changeset in webkit [79772] by tonyg@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-02-26 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Adam Barth.

Prevent parser yields from triggering early dumpAsText()
​https://bugs.webkit.org/show_bug.cgi?id=55187

DRT's dumpAsText() takes a snapshot when DocumentLoader::isLoadingInAPISense()
indicates the page is done. isLoadingInAPISense depends on
HTMLDocumentParser::isProcessingData(), which just checks if the parser is in an
insert() or append().

This means that if the parser is pumping in a resumeParsingAfterScriptExecution() or
resumeParsingAfterYield(), isLoadingInAPISense() may not be blocked. This patch
fixes that by repurposing m_writeNestingLevel as m_pumpSessionNestingLevel and
incrementing it in pumpTokenizer().

When I locally cause the parser to yield after every token, a lot of tests fail
because DRT snapshots too early. This patch fixes those tests, however I'm having
trouble writing a test case that reliably reproduces the problem without this patch
and passes with it (without changing yield constants). This is because it requires
4,096 tokens in a single pump session to yield and (len('<b>' * 4096 = 12k, which
doesn't always happen).

  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::HTMLDocumentParser): (WebCore::HTMLDocumentParser::~HTMLDocumentParser): (WebCore::HTMLDocumentParser::processingData): (WebCore::HTMLDocumentParser::pumpTokenizer): (WebCore::HTMLDocumentParser::insert): (WebCore::HTMLDocumentParser::append):
  • html/parser/HTMLDocumentParser.h: (WebCore::HTMLDocumentParser::inPumpSession): (WebCore::HTMLDocumentParser::shouldDelayEnd):
  • html/parser/HTMLParserScheduler.h: (WebCore::PumpSession::PumpSession):
  • html/parser/NestingLevelIncrementer.h:
1:32 AM Changeset in webkit [79771] by commit-queue@webkit.org
  • 16 edits
    3 adds in trunk

2011-02-26 Yongjun Zhang <​yongjun_zhang@apple.com>

Reviewed by David Kilzer.

​https://bugs.webkit.org/show_bug.cgi?id=48781

Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.

  • fast/images/resources/broken-image-with-invalid-format.png: Added.
  • fast/images/support-broken-image-delegate.html: Added.
  • platform/mac/fast/images/support-broken-image-delegate-expected.txt: Added.

2011-02-26 Yongjun Zhang <​yongjun_zhang@apple.com>

Reviewed by David Kilzer.

​https://bugs.webkit.org/show_bug.cgi?id=48781

Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.

Add a new resource load client method (shouldPaintBrokenImage). WebKit client can decide if WebCore
should paint the default broken image when an image fails to load or decode. The method also passes the
URL of the failed image.

Test: fast/images/support-broken-image-delegate.html

  • loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::shouldPaintBrokenImage):
  • loader/cache/CachedImage.cpp: (WebCore::CachedImage::CachedImage): (WebCore::CachedImage::image): (WebCore::CachedImage::checkShouldPaintBrokenImage): (WebCore::CachedImage::error):
  • loader/cache/CachedImage.h:

2011-02-26 Yongjun Zhang <​yongjun_zhang@apple.com>

Reviewed by David Kilzer.

​https://bugs.webkit.org/show_bug.cgi?id=48781

Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.

Add a new resource load client method (shouldPaintBrokenImage). WebKit client can decide if WebCore
should paint the default broken image when an image fails to load or decode. The method also passes the
URL of the failed image.

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::shouldPaintBrokenImage):
  • WebView/WebDelegateImplementationCaching.h:
  • WebView/WebDelegateImplementationCaching.mm: Added case for passing one object. (CallResourceLoadDelegateReturningBoolean):
  • WebView/WebResourceLoadDelegatePrivate.h:
  • WebView/WebView.mm: (-[WebView _cacheResourceLoadDelegateImplementations]):

2011-02-26 Yongjun Zhang <​yongjun_zhang@apple.com>

Reviewed by David Kilzer.

​https://bugs.webkit.org/show_bug.cgi?id=48781

Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.

Add a new resource load client method (shouldPaintBrokenImage). WebKit client can decide if WebCore
should paint the default broken image when an image fails to load or decode.

  • DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (setShouldPaintBrokenImageCallback): (LayoutTestController::staticFunctions): (LayoutTestController::setShouldPaintBrokenImage):
  • DumpRenderTree/LayoutTestController.h: (LayoutTestController::shouldPaintBrokenImage):
  • DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[ResourceLoadDelegate webView:shouldPaintBrokenImageForURL:]):
1:24 AM Changeset in webkit [79770] by eric@webkit.org
  • 1 edit
    9 deletes in trunk/LayoutTests

2011-02-26 Eric Seidel <​eric@webkit.org>

Reviewed by Alexey Proskuryakov.

Remove disabled xmlhttprequest/web-apps tests
​https://bugs.webkit.org/show_bug.cgi?id=55181

Per ap's suggestion in:
​https://bugs.webkit.org/show_bug.cgi?id=55164#c15

I don't think we've ever run these tests. Some of them
depend on 10 minute timeouts and another nonsense. :)

  • http/tests/xmlhttprequest/web-apps/006-test.cgi: Removed.
  • http/tests/xmlhttprequest/web-apps/006.html-disabled: Removed.
  • http/tests/xmlhttprequest/web-apps/009-test.cgi: Removed.
  • http/tests/xmlhttprequest/web-apps/009.html-disabled: Removed.
  • http/tests/xmlhttprequest/web-apps/016-test.cgi: Removed.
  • http/tests/xmlhttprequest/web-apps/016.html-disabled: Removed.
  • http/tests/xmlhttprequest/web-apps/017.html-disabled: Removed.
  • http/tests/xmlhttprequest/web-apps/recursion/001.html-disabled: Removed.
  • http/tests/xmlhttprequest/web-apps/recursion/README: Removed.
1:16 AM Changeset in webkit [79769] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-26 Chris Evans <​cevans@chromium.org>

Reviewed by Adam Barth.

Database: Data race: should only touch the transaction queue inside the
lock.
​https://bugs.webkit.org/show_bug.cgi?id=55031

  • storage/Database.cpp: (WebCore::Database::changeVersion): only touch queue inside lock. (WebCore::Database::runTransaction): only touch queue inside lock.
1:03 AM Changeset in webkit [79768] by yi.4.shen@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-02-26 Yi Shen <​yi.4.shen@nokia.com>

Reviewed by Eric Carlson.

Missing volumechangeEvent in case of mediaPlayerVolumeChanged gets callback
​https://bugs.webkit.org/show_bug.cgi?id=55147

When HTMLMediaElement::mediaPlayerVolumeChanged() gets callback,
a volumechangeEvent event should be fired if the volume gets changed.

Test: media/event-attributes.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setMuted): Remove updateVolume() since it does nothing when m_player is 0. (WebCore::HTMLMediaElement::mediaPlayerVolumeChanged): Fire a volumechangeEvent when the volume is changed.
12:59 AM Changeset in webkit [79767] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-02-26 John Mellor <​johnme@chromium.org>

Reviewed by Antonio Gomes.

[chromium] WebFrameImpl::m_totalMatchCount should be an int
​https://bugs.webkit.org/show_bug.cgi?id=55134

WebFrameImpl::m_totalMatchCount should be an int instead of a size_t since it can be -1.

  • src/WebFrameImpl.h:
12:41 AM Changeset in webkit [79766] by eric@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-26 Eric Seidel <​eric@webkit.org>

Reviewed by Maciej Stachowiak.

disableRangeMutation quirk for mail slows down peacekeeper domDynamicCreationCreateElement
​https://bugs.webkit.org/show_bug.cgi?id=55127

Before:
avg 513.4
median 515
stdev 7.234638899074368
min 490
max 528

After:
avg 508.15
median 510
stdev 6.966168243733426
min 485
max 515

Yes, the stdev is a bit high to actually support my conclusions. But looking
at the profile, this change makes a lot of sense. I'll up the iterations
for future testing.

  • dom/Document.cpp: (WebCore::disableRangeMutation):
    • This check should only be compiled in if we're planning to run on Tiger or Leopard.
12:35 AM Changeset in webkit [79765] by abarth@webkit.org
  • 11 edits
    5 adds in trunk/LayoutTests

2011-02-26 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Synchronized tests with html5lib
​https://bugs.webkit.org/show_bug.cgi?id=55128

I didn't copy all of plain-test-unsafe because it confuses pretty-diff.

  • html5lib/resources/pending-spec-changes-plain-text-unsafe.dat:
  • html5lib/resources/pending-spec-changes.dat:
  • html5lib/resources/tests1.dat:
  • html5lib/resources/tests10.dat:
  • html5lib/resources/tests19.dat:
  • html5lib/resources/tests20.dat:
  • html5lib/resources/tests22.dat: Added.
  • html5lib/resources/tests23.dat: Added.
  • html5lib/resources/tests24.dat: Added.
  • html5lib/resources/tests25.dat: Added.
  • html5lib/resources/tests26.dat: Added.
  • html5lib/resources/tests3.dat:
  • html5lib/resources/tests6.dat:
  • html5lib/runner-expected.txt:
  • html5lib/runner.html:
12:16 AM Changeset in webkit [79764] by commit-queue@webkit.org
  • 30 edits in trunk

2011-02-26 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

DumpRenderTree should reset frame opener between tests.
​https://bugs.webkit.org/show_bug.cgi?id=54874

No new tests. (no code affected, just exporting a method for DumpRenderTree use)

  • WebCore.exp.in:

2011-02-26 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

DumpRenderTree should reset frame opener between tests.
​https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener method to WebFrame.

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::clearOpener):
  • src/WebFrameImpl.h:

2011-02-26 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

DumpRenderTree should reset frame opener between tests.
​https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener method to DumpRenderTreeSupportGTK.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::clearOpener):
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

2011-02-26 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

DumpRenderTree should reset frame opener between tests.
​https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener method to WebFramePrivate.

  • WebView/WebFrame.mm: (-[WebFrame _clearOpener]):
  • WebView/WebFramePrivate.h:

2011-02-26 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

DumpRenderTree should reset frame opener between tests.
​https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener method to DumpRenderTreeSupportQT.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::clearOpener):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-02-26 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

DumpRenderTree should reset frame opener between tests.
​https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener method to IWebFramePrivate.
Touched WebKit.idl to trigger build scripts.

  • Interfaces/IWebFramePrivate.idl:
  • Interfaces/WebKit.idl:
  • WebFrame.cpp: (WebFrame::clearOpener):
  • WebFrame.h:

2011-02-26 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

DumpRenderTree should reset frame opener between tests.
​https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener method to WKBundleWebFramePrivate.

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: (WKBundleFrameClearOpener):
  • WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:

2011-02-26 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

DumpRenderTree should reset frame opener between tests.
​https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener() calls between tests.
Some tests are using window.open() to change current window location.
This changes window.opener property whose nullity is checked before
showing xml viewer.

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetTestController):
  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
  • DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
  • DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::reset):
12:13 AM Changeset in webkit [79763] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

2011-02-26 Xianzhu Wang <​wangxianzhu@google.com>

Reviewed by Eric Seidel.

Fix Chromium test failure ​http://crbug.com/33358
​https://bugs.webkit.org/show_bug.cgi?id=55125

  • platform/chromium/test_expectations.txt:
  • platform/chromium/fast/dom/Window/window-postmessage-clone-frames-expected.txt: Added.
12:12 AM Changeset in webkit [79762] by chang.shu@nokia.com
  • 7 edits
    2 adds in trunk

2011-02-26 Chang Shu <​chang.shu@nokia.com>

Reviewed by Antonio Gomes.

Spatial Navigation: Add support for <select> element in multiple selection mode
​https://bugs.webkit.org/show_bug.cgi?id=49261

Enhanced existing tests and added new tests for the bug.

  • fast/spatial-navigation/snav-multiple-select-expected.txt:
  • fast/spatial-navigation/snav-multiple-select.html:
  • fast/spatial-navigation/snav-single-select-list-expected.txt: Added.
  • fast/spatial-navigation/snav-single-select-list.html: Added.

2011-02-26 Chang Shu <​chang.shu@nokia.com>

Reviewed by Antonio Gomes.

Based on patch by Carlos Garcia Campos <​cgarcia@igalia.com>.

Spatial Navigation: Add support for <select> element in multiple selection mode
​https://bugs.webkit.org/show_bug.cgi?id=49261

When spatial navigation is enabled, use space key to toggle select
items. And the up and down keys should not affect selection but just
navigate through items, which is indicated visually by a focus ring.

New Test: fast/spatial-navigation/snav-single-select-list.html
Enhanced Test: fast/spatial-navigation/snav-multiple-select.html

  • dom/SelectElement.cpp: (WebCore::SelectElement::listBoxDefaultEventHandler):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::addFocusRingRects):
  • rendering/RenderListBox.h:
Note: See TracTimeline for information about the timeline view.