Context Navigation

platform/gtk/WidgetGtk.cpp: (WebCore::Widget::setCursor): Call into the ChromeClient implementation now.
plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::initXEvent): Instead of setting the window for windowless plugin events, set the window value to none. This method is also used to send focus in / focus out events to windowed plugins, but this is not one of the plugin types where the window parameter matters. This matches what Mozilla does. Also pass in the display of the widget itself, not the default display. (WebCore::PluginView::handleMouseEvent): When the cursor leaves the plugin area, reset the cursor. (WebCore::PluginView::platformGetValue): Clean up this section slightly. Give the widget the top-level window explicitly. This matches Mozilla.

2011-03-01 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Windowless plugins override the view cursor
https://bugs.webkit.org/show_bug.cgi?id=55531

WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::setCursor): Moved the implementation of setCursor here which is more fitting since it sets the cursor for the entire window.

2:02 PM Changeset in webkit [80428] by Martin Robinson

5 edits in trunk

2011-03-05 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] http/tests/plugins/post-url-file.html fails on GTK+
https://bugs.webkit.org/show_bug.cgi?id=55826

http/tests/plugins/resources/dump-post.pl: Instead of printing out the "keywords" parameter, print out the POSTDATA parameter. Printing "keywords" did not seem to work on the version of Apache/Perl/CGI that existed on my machine. According to the Perl CGI module documentation using 'POSTDATA' is the correct way to print the entire POSTDATA.
platform/gtk/Skipped: Unskip the test which is now passing.

2011-03-05 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] http/tests/plugins/post-url-file.html fails on GTK+
https://bugs.webkit.org/show_bug.cgi?id=55826

Correct the implementation of handlePostReadFile which uses GIO APIs and
actually resizes the buffer to fit the entire size of the file data. This
was likely leading to memory corruption until now.

plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::handlePostReadFile): Fix this method.

11:49 AM Changeset in webkit [80427] by bweinstein@apple.com

2 edits in trunk/Tools

Fix Web Process crashes caused by https://bugs.webkit.org/show_bug.cgi?id=53919.

Reviewed by Sam Weinig.

WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::willSendRequestForFrame): Retain the WKURLRequestRef returned

by willSendRequestForFrame. The API expects a retained reference to the URL request.

10:03 AM Changeset in webkit [80426] by caseq@chromium.org

2 edits in trunk/LayoutTests

2011-03-05 Andrey Kosyakov <caseq@chromium.org>

Unreviewed. Another shot at fixing flakiness of extension-events.html.

inspector/extensions/extensions-events.html:

9:39 AM Changeset in webkit [80425] by mnaganov@chromium.org

3 edits in trunk/Source/WebCore

2011-03-05 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Allow dynamic enabling of detailed heap profiles.
https://bugs.webkit.org/show_bug.cgi?id=55824

Detailed heap profiles can be now enabled by typing "leakz" in Profiles tab.

inspector/front-end/DetailedHeapshotView.js: (WebInspector.DetailedHeapshotView.prototype.isDetailedSnapshot):
inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.doParse): (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot): (WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress): (WebInspector.ProfilesPanel.prototype.handleShortcut): (WebInspector.ProfilesPanel.prototype._displayDetailedHeapProfilesEnabledHint.hideHint): (WebInspector.ProfilesPanel.prototype._displayDetailedHeapProfilesEnabledHint): (WebInspector.ProfilesPanel.prototype._enableDetailedHeapProfiles): (WebInspector.ProfilesPanel.prototype._recognizeKeyboardCombo):

9:32 AM Changeset in webkit [80424] by qi.2.zhang@nokia.com

5 edits in trunk/Source

2011-03-05 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Mobile Devices should include Model and Firmware Version in Webkit Generated User Agent String
https://bugs.webkit.org/show_bug.cgi?id=48636

Add model infomation into user agent string when qtmobility is available, but only for symbian, Maemo and MeeGo.

WebCore.pri:
features.pri:

2011-03-05 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Mobile Devices should include Model and Firmware Version in Webkit Generated User Agent String
https://bugs.webkit.org/show_bug.cgi?id=48636

Add model infomation into user agent string when qtmobility is available, but only for symbian, Maemo and MeeGo.

Api/qwebpage.cpp: (QWebPage::userAgentForUrl):

9:10 AM Changeset in webkit [80423] by pfeldman@chromium.org

2 edits in trunk/Source/WebCore

2011-03-05 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: adding null check to prevent inspector tests from failing.

inspector/front-end/TextViewer.js: (WebInspector.TextEditorGutterChunk.prototype.get offsetTop): (WebInspector.TextEditorMainChunk.prototype.get offsetTop):

8:47 AM Changeset in webkit [80422] by pfeldman@chromium.org

7 edits in trunk

2011-03-05 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: chromium rebaseline, flaky test fix.

inspector/front-end/BreakpointManager.js: (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement): (WebInspector.DOMBreakpointView.prototype._format):

2011-03-05 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: chromium rebaseline, flaky test fix.

http/tests/inspector/debugger-test.js:
inspector/debugger/dom-breakpoints.html:
platform/chromium/inspector/console/console-uncaught-exception-expected.txt:

8:00 AM QtWebKitContrib edited by adawit@kde.org

Fixed the git url for the remote add step. (diff)

6:34 AM Changeset in webkit [80421] by caseq@chromium.org

3 edits in trunk/LayoutTests

2011-03-05 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: inspector/extensions/extensions-events.html sometimes fails on Windows
https://bugs.webkit.org/show_bug.cgi?id=54974

Properly serialize test output to fix flakiness due to race with output during page reload.

inspector/extensions/extensions-events-expected.txt:
inspector/extensions/extensions-events.html:
platform/win/Skipped:

5:42 AM Changeset in webkit [80420] by podivilov@chromium.org

2 edits in trunk/Source/WebCore

2011-03-04 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [chromium] pause when script is running is broken.
https://bugs.webkit.org/show_bug.cgi?id=55762

inspector/CodeGeneratorInspector.pm:

3:20 AM Changeset in webkit [80419] by loislo@chromium.org

3 edits
2 adds in trunk/LayoutTests

2011-03-05 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: introduce protocol test for ConsoleAgent.
https://bugs.webkit.org/show_bug.cgi?id=55819

http/tests/inspector/protocol-test.js: (initialize_ProtocolTest.InspectorTest._dumpEvent): (initialize_ProtocolTest.InspectorTest._dumpCallArguments): (initialize_ProtocolTest): (initialize_ProtocolTest.):
inspector/protocol/console-agent-expected.txt: Added.
inspector/protocol/console-agent.html: Added.
inspector/protocol/runtime-agent.html:

3:09 AM Changeset in webkit [80418] by abarth@webkit.org

5 edits
1 add in trunk/Source

2011-03-05 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Add Derived Sources to WebCore GYP build
https://bugs.webkit.org/show_bug.cgi?id=55813

Rename the action to be friendlier.

gyp/JavaScriptCore.gyp:

2011-03-05 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Add Derived Sources to WebCore GYP build
https://bugs.webkit.org/show_bug.cgi?id=55813

Adding the derived source action to the GYP file required tweaking
DerivedSources.make. I'm not sure how DerivedSources.make worked
before beause these paths were incorrectly based.

DerivedSources.make:
gyp/generate-derived-sources.sh: Added.
gyp/WebCore.gyp:

3:07 AM Changeset in webkit [80417] by caseq@chromium.org

3 edits in trunk/LayoutTests

2011-03-05 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: install onerror handler in inspector tests
https://bugs.webkit.org/show_bug.cgi?id=55690

http/tests/inspector/inspector-test.js: (initialize_InspectorTest.onError):
http/tests/inspector/resources/extension-main.js: (onError):

2:09 AM Changeset in webkit [80416] by pfeldman@chromium.org

30 edits
2 adds
1 delete in trunk

2011-03-04 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: fix layout tests flakiness.
https://bugs.webkit.org/show_bug.cgi?id=55816

Timeline now uses instrumentation calls, not UI representation while collecting events for tests
No reloads in debugger tests that don't need them
Forcing layout in timeline via calculating offsetHeight

http/tests/inspector/inspector-test.js:
inspector/console/console-uncaught-exception-expected.txt:
inspector/console/console-uncaught-exception.html:
inspector/debugger/debugger-autocontinue-on-syntax-error-expected.txt:
inspector/debugger/debugger-autocontinue-on-syntax-error.html:
inspector/debugger/resources/syntax-error.html: Added.
inspector/debugger/resources/syntax-error.js: Removed.
inspector/elements/elements-panel-limited-children-expected.txt:
inspector/extensions/extensions-events-expected.txt:
inspector/styles/styles-update-from-js-expected.txt:
inspector/styles/styles-update-from-js.html:
inspector/timeline/timeline-layout.html:
inspector/timeline/timeline-network-resource-expected.txt:
inspector/timeline/timeline-network-resource.html:
inspector/timeline/timeline-script-tag-1.html:
inspector/timeline/timeline-script-tag-2.html:
inspector/timeline/timeline-test.js: (initialize_Timeline.InspectorTest.startTimeline.addRecord): (initialize_Timeline.InspectorTest.startTimeline): (initialize_Timeline.InspectorTest.stopTimeline): (initialize_Timeline.InspectorTest.performActionsAndPrint.step2): (initialize_Timeline.InspectorTest.performActionsAndPrint): (initialize_Timeline.InspectorTest.printTimelineRecords):
inspector/timeline/timeline-trivial.html:
platform/chromium/inspector/timeline/timeline-network-resource-expected.txt:

2011-03-04 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: fix layout tests flakiness.
https://bugs.webkit.org/show_bug.cgi?id=55816

Order of issuing of evaluateForTestInFrontend was not guaranteed on the backend side (InspectorAgent side)
Order of dispatching using timeouts was guaranteed via queueing. Source of all kinds of pains on SnowLeopard Release (inspector.js)

inspector/CodeGeneratorInspector.pm:
inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::disconnectFrontend): (WebCore::InspectorAgent::populateScriptObjects): (WebCore::InspectorAgent::evaluateForTestInFrontend): (WebCore::InspectorAgent::issueEvaluateForTestCommands):
inspector/InspectorAgent.h:
inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.FormattedRecord):
inspector/front-end/inspector.js: (WebInspector.dispatch):

1:50 AM Changeset in webkit [80415] by abarth@webkit.org

3 edits in trunk/Source/WebCore

2011-03-05 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

WebCore GYP build should generate fewer than 10,000 compile errors per file
https://bugs.webkit.org/show_bug.cgi?id=55810

This patch adds some missing include paths. We need to figure out how
to handle separate include paths per port. It's clear that
ForwardingHeaders are only useful for Mac, but it's less clear how to
handle the others.

WebCore.gypi:
gyp/WebCore.gyp:

1:20 AM Changeset in webkit [80414] by mitz@apple.com

2 edits in trunk/Source/WebCore

<rdar://problem/9082946> Make the Core Text code path in GlyphPage::fill() more robust
https://bugs.webkit.org/show_bug.cgi?id=55817

Reviewed by Cameron Zwarich.

platform/graphics/mac/GlyphPageTreeNodeMac.cpp:

(WebCore::GlyphPage::fill): When determining if a CTRun uses the primary font, compare against
a CGFont obtained from Core Text for the primary font. This CGFont may be different from
the CGFont stored in the FontPlatformData.

12:48 AM Changeset in webkit [80413] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

Unreviewed.

[Qt] Add fast/forms/onchange-setvalueforuser.html to the Skipped
list because of missing layoutTestController.setValueForUser()

platform/qt/Skipped:

12:09 AM Changeset in webkit [80412] by commit-queue@webkit.org

27 edits
4 adds in trunk

2011-03-05 Ilya Sherman <isherman@chromium.org>

Reviewed by Darin Adler.

HTMLInputElement::setValue() should schedule change event when the element is focused
In service of https://code.google.com/p/chromium/issues/detail?id=42716
https://bugs.webkit.org/show_bug.cgi?id=53160

fast/forms/onchange-change-type-expected.txt: Added.
fast/forms/onchange-change-type.html: Added.
fast/forms/onchange-setvalueforuser-expected.txt: Added.
fast/forms/onchange-setvalueforuser.html: Added.

2011-03-05 Ilya Sherman <isherman@chromium.org>

Reviewed by Darin Adler.

HTMLInputElement::setValue() should schedule change event when the element is focused.
Refactored tracking of "changed since last change event" state from renderer to DOM.In service of https://code.google.com/p/chromium/issues
In service of https://code.google.com/p/chromium/issues/detail?id=42716
https://bugs.webkit.org/show_bug.cgi?id=53160

Test: fast/forms/onchange-change-type.html
Test: fast/forms/onchange-setvalueforuser.html

WebCore.exp.in:
dom/Document.cpp: (WebCore::Document::setFocusedNode):
dom/Element.h: (WebCore::Element::wasChangedSinceLastFormControlChangeEvent): Added. (WebCore::Element::setChangedSinceLastFormControlChangeEvent): Added.
html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::HTMLFormControlElement): (WebCore::HTMLFormControlElement::wasChangedSinceLastFormControlChangeEvent): Added. (WebCore::HTMLFormControlElement::setChangedSinceLastFormControlChangeEvent): Added. (WebCore::HTMLFormControlElement::dispatchFormControlChangeEvent): Also clear the "changed since last change event" flag. (WebCore::HTMLFormControlElement::dispatchFormControlInputEvent): Also set the "changed since last change event" flag.
html/HTMLFormControlElement.h:
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::updateType): Also clear the "changed since last change event" flag. (WebCore::HTMLInputElement::setValue):

For a focused text field, dispatch an input event, but delay the change event until the field loses focus.

(WebCore::HTMLInputElement::defaultEventHandler):
(WebCore::HTMLInputElement::stepUpFromRenderer):

html/shadow/TextControlInnerElements.cpp: (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::RenderTextControl): (WebCore::RenderTextControl::subtreeHasChanged):
rendering/RenderTextControl.h:
rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::subtreeHasChanged):
rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
wml/WMLInputElement.cpp: (WebCore::WMLInputElement::WMLInputElement): (WebCore::WMLInputElement::defaultEventHandler):
wml/WMLInputElement.h: (WebCore::WMLInputElement::wasChangedSinceLastFormControlChangeEvent): Added. (WebCore::WMLInputElement::setChangedSinceLastFormControlChangeEvent): Added.

2011-03-05 Ilya Sherman <isherman@chromium.org>

Reviewed by Darin Adler.

HTMLInputElement::setValue() should schedule change event when the element is focused
In service of https://code.google.com/p/chromium/issues/detail?id=42716
https://bugs.webkit.org/show_bug.cgi?id=53160

DOM/WebDOMOperations.mm: (-[DOMHTMLInputElement _setValueForUser:]): Expose HTMLInputElement::setValueForUser() to tests
DOM/WebDOMOperationsPrivate.h:
WebView/WebViewInternal.h:

2011-03-05 Ilya Sherman <isherman@chromium.org>

Reviewed by Darin Adler.

HTMLInputElement::setValue() should schedule change event when the element is focused
In service of https://code.google.com/p/chromium/issues/detail?id=42716
https://bugs.webkit.org/show_bug.cgi?id=53160

DumpRenderTree/LayoutTestController.cpp: (setValueForUserCallback): (LayoutTestController::staticFunctions):
DumpRenderTree/LayoutTestController.h:
DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setValueForUser): Expose HTMLInputElement::setValueForUser() to tests
DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setValueForUser): Stubbed out; need real implementation.

Mar 4, 2011:

11:43 PM Changeset in webkit [80411] by commit-queue@webkit.org

2 edits
29 adds in trunk/LayoutTests

2011-03-04 Victoria Kirst <vrk@google.com>

Reviewed by Eric Carlson.

[chromium] Baselines for media GPU layout tests
https://bugs.webkit.org/show_bug.cgi?id=55796

Adding baselines for some of the media GPU layout tests.
Updates test_expectations with expected media GPU failures.

platform/chromium-gpu-linux/media/video-display-toggle-expected.checksum: Added.
platform/chromium-gpu-linux/media/video-display-toggle-expected.png: Added.
platform/chromium-gpu-linux/media/video-no-audio-expected.checksum: Added.
platform/chromium-gpu-linux/media/video-no-audio-expected.png: Added.
platform/chromium-gpu-linux/media/video-volume-slider-expected.checksum: Added.
platform/chromium-gpu-linux/media/video-volume-slider-expected.png: Added.
platform/chromium-gpu-linux/media/video-zoom-expected.checksum: Added.
platform/chromium-gpu-linux/media/video-zoom-expected.png: Added.
platform/chromium-gpu-mac/media/video-display-toggle-expected.checksum: Added.
platform/chromium-gpu-mac/media/video-display-toggle-expected.png: Added.
platform/chromium-gpu-mac/media/video-no-audio-expected.checksum: Added.
platform/chromium-gpu-mac/media/video-no-audio-expected.png: Added.
platform/chromium-gpu-mac/media/video-volume-slider-expected.checksum: Added.
platform/chromium-gpu-mac/media/video-volume-slider-expected.png: Added.
platform/chromium-gpu-mac/media/video-zoom-expected.checksum: Added.
platform/chromium-gpu-mac/media/video-zoom-expected.png: Added.
platform/chromium-gpu-win/media/video-canvas-alpha-expected.checksum: Added.
platform/chromium-gpu-win/media/video-canvas-alpha-expected.png: Added.
platform/chromium-gpu-win/media/video-display-toggle-expected.checksum: Added.
platform/chromium-gpu-win/media/video-display-toggle-expected.png: Added.
platform/chromium-gpu-win/media/video-no-audio-expected.checksum: Added.
platform/chromium-gpu-win/media/video-no-audio-expected.png: Added.
platform/chromium-gpu-win/media/video-volume-slider-expected.checksum: Added.
platform/chromium-gpu-win/media/video-volume-slider-expected.png: Added.
platform/chromium-gpu-win/media/video-zoom-expected.checksum: Added.
platform/chromium-gpu-win/media/video-zoom-expected.png: Added.
platform/chromium/test_expectations.txt:

11:08 PM Changeset in webkit [80410] by commit-queue@webkit.org

3 edits
3 adds in trunk

2011-03-04 Xianzhu Wang <wangxianzhu@google.com>

Reviewed by Adam Barth.

Add a test to ensure SVGImage won't cause ResourceLoader leaks.
https://bugs.webkit.org/show_bug.cgi?id=55017

fast/images/svg-image-leak-loader-expected.txt: Added.
fast/images/svg-image-leak-loader.html: Added.
fast/images/resources/load-script.html: Added.

2011-03-04 Xianzhu Wang <wangxianzhu@google.com>

Reviewed by Adam Barth.

Remove fake request loading of SVGImage to avoid MainResourceLoader
leak. The frame->init() already ensures initialization of the
document loader.

https://bugs.webkit.org/show_bug.cgi?id=55017

Test: fast/images/svg-image-leak-loader.html

svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):

10:32 PM Changeset in webkit [80409] by commit-queue@webkit.org

4 edits in trunk

2011-03-04 Mike Reed <reed@google.com>

Reviewed by Mihai Parparita.

[Chromium] fast/canvas/canvas-arc-360-winding.html fails on Linux and Windows
https://bugs.webkit.org/show_bug.cgi?id=49477

platform/chromium/test_expectations.txt:

2011-03-04 Mike Reed <reed@google.com>

Reviewed by Mihai Parparita.

[Chromium] fast/canvas/canvas-arc-360-winding.html fails on Linux and Windows
https://bugs.webkit.org/show_bug.cgi?id=49477

platform/graphics/skia/PathSkia.cpp: (WebCore::Path::addArc):

10:12 PM Changeset in webkit [80408] by commit-queue@webkit.org

7 edits
2 adds in trunk/Source

2011-03-04 Jia Pu <jpu@apple.com>

Reviewed by Darin Adler.

On Mac, the bounding box sent to EditorClient::showCorrectionPanel() is incorrect when the correction occurs in an iframe.
https://bugs.webkit.org/show_bug.cgi?id=55717
<rdar://problem/9018127>

manual-test: manual-tests/platforms/mac/autocorrection/autocorrection-in-iframe.html

Previously, the bounding box passed into EditorClient::showCorrectionPanel() is in the frame's
coordinate. This is incorrect when the correction occurs in an iframe. This patch added code
to convert the bounding box to window coordinate using ScrollView::contentToWindow().

dom/Range.cpp: (WebCore::Range::getBoundingClientRect): (WebCore::Range::boundingRect):
dom/Range.h:
editing/Editor.cpp: (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): (WebCore::Editor::correctionPanelTimerFired): (WebCore::Editor::windowRectForRange):
editing/Editor.h:
manual-tests/autocorrection/autocorrection-in-iframe.html: Added.
manual-tests/autocorrection/document-for-iframe-test.html: Added.

2011-03-04 Jia Pu <jpu@apple.com>

Reviewed by Darin Adler.

On Mac, the bounding box sent to EditorClient::showCorrectionPanel() is incorrect when the correction occurs in an iframe.
https://bugs.webkit.org/show_bug.cgi?id=55717
<rdar://problem/9018127>

With the change in WebCore, the bounding box passed into EditorClient::showCorrectionPanel()
is already in window coordinate. We don't need to do further conversion anymore.

WebCoreSupport/WebEditorClient.mm: (WebEditorClient::showCorrectionPanel):

10:02 PM Changeset in webkit [80407] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

2011-03-04 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Need symbian version of cryptographicallyRandomValuesFromOS
https://bugs.webkit.org/show_bug.cgi?id=55782

Implement Symbian version of cryptographicallyRandomValuesFromOS

wtf/OSRandomSource.cpp: (WTF::cryptographicallyRandomValuesFromOS):

9:41 PM Changeset in webkit [80406] by simonjam@chromium.org

1 edit
2 adds in trunk/LayoutTests

2011-03-04 James Simonsen <simonjam@chromium.org>

Reviewed by Adam Barth.

Test that scripts with unknown types aren't loaded.
https://bugs.webkit.org/show_bug.cgi?id=51760

fast/dom/HTMLScriptElement/dont-load-unknown-type-expected.txt: Added.
fast/dom/HTMLScriptElement/dont-load-unknown-type.html: Added.

9:20 PM Changeset in webkit [80405] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

2011-03-04 Jia Pu <jpu@apple.com>

Reviewed by Darin Adler.

Those checking in Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited() should be done with VisiblePosition::isNull().
https://bugs.webkit.org/show_bug.cgi?id=55731

No new tests. There's no behavioral change.

This patch improved clarity and readability of Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited().

editing/Editor.cpp: (WebCore::Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited):

8:27 PM Changeset in webkit [80404] by commit-queue@webkit.org

9 edits
5 adds in trunk

2011-03-04 John Bauman <jbauman@chromium.org>

Reviewed by Kenneth Russell.

[chromium] premultipliedAlpha WebGL context attribute is ignored.
https://bugs.webkit.org/show_bug.cgi?id=55411

Add test case for (non-)premultiplied-alpha compositing.

compositing/webgl/webgl-nonpremultiplied-blend.html: Added.
platform/chromium-gpu/compositing/webgl/webgl-nonpremultiplied-blend-expected.checksum: Added.
platform/chromium-gpu/compositing/webgl/webgl-nonpremultiplied-blend-expected.png: Added.
platform/chromium-gpu/compositing/webgl/webgl-nonpremultiplied-blend-expected.txt: Added.
platform/mac-wk2/Skipped:
platform/mac/Skipped:

2011-03-04 John Bauman <jbauman@chromium.org>

Reviewed by Kenneth Russell.

[chromium] premultipliedAlpha WebGL context attribute is ignored.
https://bugs.webkit.org/show_bug.cgi?id=55411

Update compositor to set the blending of each layer correctly.

Test: compositing/webgl/webgl-nonpremultiplied-blend.html

platform/graphics/chromium/CanvasLayerChromium.cpp: (WebCore::CanvasLayerChromium::CanvasLayerChromium): (WebCore::CanvasLayerChromium::draw):
platform/graphics/chromium/CanvasLayerChromium.h:
platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::draw):
platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayers):
platform/graphics/chromium/WebGLLayerChromium.cpp: (WebCore::WebGLLayerChromium::setContext):

7:58 PM Changeset in webkit [80403] by jhoneycutt@apple.com

3 edits in trunk/Source/WebKit2

WK2 Mac build fix.

UIProcess/API/C/WKPage.cpp:

(WKPageComputePagesForPrinting):
(WKPageBeginPrinting):

UIProcess/API/C/WKPagePrivate.h:

6:34 PM Changeset in webkit [80402] by jhoneycutt@apple.com

2 edits in trunk/Source/WebKit2

WK2 Mac build fix.

UIProcess/API/C/WKPagePrivate.h:

5:54 PM Changeset in webkit [80401] by jberlin@webkit.org

2 edits in trunk/LayoutTests

[Snow Leopard Release Tests] accessibility/plugin.html,
compositing/geometry/empty-embed-rects.html, and fast/loader/loadInProgress.html timing out.
https://bugs.webkit.org/show_bug.cgi?id=55805
https://bugs.webkit.org/show_bug.cgi?id=55807
https://bugs.webkit.org/show_bug.cgi?id=55808

Unreviewed. Add these tests to the Snow Leopard skipped list to get the bots green.

platform/mac-snowleopard/Skipped:

5:48 PM Changeset in webkit [80400] by abarth@webkit.org

2 edits in trunk/Source/WebCore

2011-03-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

WebCore GYP build should link with the correct frameworks
https://bugs.webkit.org/show_bug.cgi?id=55804

gyp/WebCore.gyp:

5:44 PM Changeset in webkit [80399] by abarth@webkit.org

2 edits in trunk/Source/WebCore

2011-03-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

WebCore GYP build should Check For Inappropriate Files in Framework
https://bugs.webkit.org/show_bug.cgi?id=55806

gyp/WebCore.gyp:

5:21 PM Changeset in webkit [80398] by jhoneycutt@apple.com

9 edits in trunk/Source/WebKit2

WK2 needs printing support on Windows
https://bugs.webkit.org/show_bug.cgi?id=55800
<rdar://problem/8903808>

Reviewed by Darin Adler.

UIProcess/API/C/WKPage.cpp:

(ComputedPagesContext::ComputedPagesContext):
(computedPagesCallback):
From the Vector of WebCore::IntRects, build up a Vector of WKRects.
Call the callback, passing these rects and the scale factor.
(printInfoFromWKPrintInfo):
Return a PrintInfo structure from the WKPrintInfo.
(WKPageComputePagesForPrinting):
Call WebPageProxy::computePagesForPrinting(). Pass
computedPagesCallback as the callback function, so that we can
translate the WebCore rect type to WKRect before calling the caller's
callback function.
(WKPageBeginPrinting):
Call WebPageProxy::beginPrinting().
(WKPageDrawPagesToPDF):
Call WebPageProxy::drawPagesToPDF().

UIProcess/API/C/WKPagePrivate.h:

Declare the WKPrintInfo type and new functions.

UIProcess/WebPageProxy.cpp:

Compile this code on Windows.

UIProcess/WebPageProxy.h:

Ditto.

UIProcess/win/WebView.cpp:

(WebKit::WebView::paint):
We're painting the window; leave printing mode.

WebProcess/WebPage/WebPage.cpp:

Compile this code on Windows.

WebProcess/WebPage/WebPage.h:

Ditto.

WebProcess/WebPage/WebPage.messages.in:

Ditto.

5:15 PM Changeset in webkit [80397] by barraclough@apple.com

2 edits in trunk/Source/JavaScriptCore

Bug 54945 - The web page hangs towards the end of page load in Interpreter enabled javascript code in the latest webkit trunk.

Rubber stamped by olliej.

interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

(1) don't infinite loop.
(2) goto 1.

5:08 PM Changeset in webkit [80396] by barraclough@apple.com

2 edits in trunk/Source/JavaScriptCore

cmake build fix.

CMakeLists.txt:

5:07 PM Changeset in webkit [80395] by sfalken@apple.com

11 edits
2 deletes in trunk/Source

2011-03-04 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin Adler.

Adopt VersionStamper tool for Windows WebKit DLLs
https://bugs.webkit.org/show_bug.cgi?id=55784

Calculate the WebKit version for the useragent via autoversion.h
instead of reading it back from the DLL.

We now use a tool to stamp the version number onto the Apple WebKit DLLs
during the post-build step.

WebKit.vcproj/WebKit.rc: Removed. This file wasn't used.
WebKit.vcproj/WebKitLibCommon.vsprops: Fetch version from a string resource.
WebView.cpp: (WebView::standardUserAgentWithApplicationName): Use BUILD_NUMBER_SHORT for the version. (osVersion): Removed

2011-03-04 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin Adler.

Adopt VersionStamper tool for Windows WebKit DLLs
https://bugs.webkit.org/show_bug.cgi?id=55784
<rdar://problem/9021320>

We now use a tool to stamp the version number onto the Apple WebKit DLLs
during the post-build step.

Fetch the WebKit version from a string resource instead of the version resource.

UIProcess/win/WebPageProxyWin.cpp: (WebKit::userVisibleWebKitVersionString): Fetch version from a string resource.
win/WebKit2.rc: Removed version, added stringtable.
win/WebKit2WebProcess.rc: Removed.
win/WebKit2WebProcess.vcproj:
win/WebKit2WebProcessPostBuild.cmd: Don't run autoversion script. It isn't used in this project.
win/WebKit2WebProcessPreBuild.cmd: Stamp version.
win/WebKitPostBuild.cmd: Stamp version.

4:58 PM Changeset in webkit [80394] by jeffm@apple.com

19 edits in trunk/Source/WebKit2

Add WKPageValidateCommand()
https://bugs.webkit.org/show_bug.cgi?id=55793

Reviewed by Darin Adler.

On the Mac, validation of edit menu commands is handled within WebKit2 in WKView.mm.
However, on Windows we need to do this in the client, so expose this functionality
in the API via WKPageValidateCommand().

Change the Mac implementation to call WebPageProxy::validateCommand() with a callback
to match this new API, so it no longer has to go through PageClient to get notified
when a command is validated. This makes PageClient::setEditCommandState() obsolete,
so I removed the stub implementations in qt and gtk as well.

UIProcess/API/C/WKPage.cpp:

(WKPageValidateCommand): Added.

UIProcess/API/C/WKPage.h: Added WKPageValidateCommand().
UIProcess/API/mac/PageClientImpl.h: Removed setEditCommandState().
UIProcess/API/mac/PageClientImpl.mm: Removed setEditCommandState().
UIProcess/API/mac/WKView.mm:

(validateCommandCallback): Added.
(-[WKView validateUserInterfaceItem:]): Pass callback to validateCommand().

UIProcess/API/qt/qwkpage.cpp: Removed setEditCommandState().
UIProcess/API/qt/qwkpage_p.h: Removed setEditCommandState().
UIProcess/PageClient.h: Removed setEditCommandState().
UIProcess/WebPageProxy.cpp: Removed didValidateCommand().

(WebKit::WebPageProxy::validateCommand): This now takes a callback.
(WebKit::WebPageProxy::validateCommandCallback): Added.
(WebKit::WebPageProxy::processDidCrash): Invalidate m_validateCommandCallbacks.

UIProcess/WebPageProxy.h: Removed didValidateCommand(), validateCommand() now takes a callback.

(WebKit::ValidateCommandCallback::create): Added.
(WebKit::ValidateCommandCallback::~ValidateCommandCallback): Added.
(WebKit::ValidateCommandCallback::performCallbackWithReturnValue): Added.
(WebKit::ValidateCommandCallback::invalidate): Added.
(WebKit::ValidateCommandCallback::ValidateCommandCallback): Added.

UIProcess/WebPageProxy.messages.in: Removed DidValidateCommand, added ValidateCommandCallback.
UIProcess/gtk/WebView.cpp: Removed setEditCommandState().
UIProcess/gtk/WebView.h: Removed setEditCommandState().
UIProcess/win/WebView.cpp: Removed setEditCommandState().
UIProcess/win/WebView.h: Removed setEditCommandState().
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::validateCommand): This now takes a callbackID.

WebProcess/WebPage/WebPage.h: validateCommand now takes a callbackID.
WebProcess/WebPage/WebPage.messages.in: ValidateCommand now takes a callbackID.

4:55 PM Changeset in webkit [80393] by abarth@webkit.org

4 edits
2 adds in trunk

2011-03-04 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adam Barth.

Add skeletal WebCore.gyp
https://bugs.webkit.org/show_bug.cgi?id=55802

Source/gyp/configure: Added WebCore.

2011-03-04 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adam Barth.

Add skeletal WebCore.gyp
https://bugs.webkit.org/show_bug.cgi?id=55802

This doesn't yet build, but the basic structure is there.

WebCore.gypi: Added headers and include directories variables.
gyp/WebCore.gyp: Added.

4:35 PM Changeset in webkit [80392] by bweinstein@apple.com

3 edits in trunk/Source/WebKit2

Reference-counting for WKBundlePageResourceLoadClient::willSendRequestForFrame seems unclear/wrong
https://bugs.webkit.org/show_bug.cgi?id=53919
<rdar://problem/8966020>

Reviewed by Darin Adler.

Adopt the result of m_client.willSendRequestForFrame (which will be leaked by the client).

WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.cpp:

(WebKit::InjectedBundlePageResourceLoadClient::willSendRequestForFrame):

4:23 PM Changeset in webkit [80391] by Darin Adler

2 edits in trunk/Source/WebKit2

2011-03-04 Darin Adler <Darin Adler>

Reviewed by Mark Rowe.

WebKit2 session state should include even loads too new to be in the back/forward list
https://bugs.webkit.org/show_bug.cgi?id=55781
part of <rdar://problem/8968847>

UIProcess/cf/WebPageProxyCF.cpp: (WebKit::WebPageProxy::sessionStateData): Save URLs that are early enough in the loading process to not be included in the back/forward list yet: The pending API request URL and the provisional URL. (WebKit::WebPageProxy::restoreFromSessionStateData): Call loadURL if the back/forward list is not restored and a URL is present. Later we can improve the way we handle the case where we have both a back/forward list and a URL.

4:19 PM Changeset in webkit [80390] by abarth@webkit.org

3 edits in trunk/Source/JavaScriptCore

2011-03-04 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Add Copy Files step to JavaScriptCore GYP build for apitest and minidom
https://bugs.webkit.org/show_bug.cgi?id=55798

JavaScriptCore.gypi:
gyp/JavaScriptCore.gyp:

4:16 PM Changeset in webkit [80389] by abarth@webkit.org

6 edits in trunk/Source

2011-03-04 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Remove unneeded round-trips through ../Source in the Chromium GYP build
https://bugs.webkit.org/show_bug.cgi?id=55795

JavaScriptCore.gyp/JavaScriptCore.gyp:

2011-03-04 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Remove unneeded round-trips through ../Source in the Chromium GYP build
https://bugs.webkit.org/show_bug.cgi?id=55795

WebKit.gyp:

2011-03-04 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Remove unneeded round-trips through ../Source in the Chromium GYP build
https://bugs.webkit.org/show_bug.cgi?id=55795

This is just cleanup work, but it was bugging me.

WebCore.gyp/WebCore.gyp:

4:13 PM Changeset in webkit [80388] by abarth@webkit.org

1 edit
1 add in trunk

2011-03-04 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Add a basic configure script for the GYP build
https://bugs.webkit.org/show_bug.cgi?id=55791

This script just calls GYP on the various gyp projects. As we add more
build systems, this script should be able to select which of them you'd
like to generate the project for.

Source/gyp/configure: Added.

4:11 PM Changeset in webkit [80387] by abarth@webkit.org

5 edits
1 add in trunk

2011-03-04 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Use target_defaults to reduce boilerplate in GYP build system
https://bugs.webkit.org/show_bug.cgi?id=55790

This file contains GYP declarations that are shared by all the modules.
Currently, we use this to set up the configurations, albeit primitively.

Source/gyp/common.gypi: Added.

2011-03-04 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Use target_defaults to reduce boilerplate in GYP build system
https://bugs.webkit.org/show_bug.cgi?id=55790

Instead of setting up the configuration in each target, just defer to
target_defaults. Also, removed a define that was redundant with the
xcconfig.

gyp/JavaScriptCore.gyp:

2011-03-04 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Use target_defaults to reduce boilerplate in GYP build system
https://bugs.webkit.org/show_bug.cgi?id=55790

Instead of setting up the configuration in each target, just defer to
target_defaults. Also, removed a define that was redundant with the
xcconfig.

gyp/JavaScriptGlue.gyp:

4:00 PM Changeset in webkit [80386] by jamesr@google.com

2 edits in trunk/Source/WebCore

2011-03-04 Mike Reed <reed@google.com>

Reviewed by James Robinson.

Option to use skia's native text drawing APIs when drawing text
on Windows, rather than from outlines using drawPath(). This will
only have a significant effect when the skia-gpu backend is enabled.
https://bugs.webkit.org/show_bug.cgi?id=55609

No new tests. This is disabled by default. When enabled, it will draw
essentially the same, but with slightly different antialiased edges, due
to differences between the current scanconverter and GDI's font scaler.
When enabled, we will have to recalibrate layouttest image results.

platform/graphics/skia/SkiaFontWin.cpp: (WebCore::skiaDrawText): (WebCore::setupPaintForFont): (WebCore::paintSkiaText):

3:59 PM Changeset in webkit [80385] by tonyg@chromium.org

2 edits in trunk/LayoutTests

2011-03-04 Tony Gentilcore <tonyg@chromium.org>

[chromium] Fail new test for JSC feature introduced by r80378
https://bugs.webkit.org/show_bug.cgi?id=55801

platform/chromium/test_expectations.txt:

3:57 PM Changeset in webkit [80384] by enne@google.com

5 edits
5 adds
2 deletes in trunk

2011-03-04 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

Turn on pixel tests for huge-layer-img.html for better test coverage.
https://bugs.webkit.org/show_bug.cgi?id=55679

Also, modify this test to be more pixel test friendly.

compositing/tiling/huge-layer-img-expected.checksum: Added.
compositing/tiling/huge-layer-img-expected.png: Added.
compositing/tiling/huge-layer-img-expected.txt: Added.
compositing/tiling/huge-layer-img.html:
platform/chromium-gpu-win/compositing/tiling/huge-layer-img-expected.txt: Removed.
platform/chromium-gpu/compositing/tiling/huge-layer-img-expected.txt: Added.
platform/mac/compositing/tiling/huge-layer-img-expected.txt: Removed.

2011-03-04 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Fix texture stride issues on large content and image layers.
https://bugs.webkit.org/show_bug.cgi?id=55679

This was an error caused during the refactoring in r80081.

Tests: LayoutTests/compositing/tiling/huge-layer-img.html

platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::updateTexture):
platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateTextureIfNeeded):

3:38 PM Changeset in webkit [80383] by tonyg@chromium.org

8 edits in trunk

2011-03-04 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80379.
http://trac.webkit.org/changeset/80379
https://bugs.webkit.org/show_bug.cgi?id=55799

"Breaks leopard compile (implicit conversion)" (Requested by
tonyg-cr on #webkit).

transitions/matched-transform-functions.html:
transitions/retargetted-transition.html:

2011-03-04 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80379.
http://trac.webkit.org/changeset/80379
https://bugs.webkit.org/show_bug.cgi?id=55799

"Breaks leopard compile (implicit conversion)" (Requested by
tonyg-cr on #webkit).

css/CSSStyleSelector.cpp: (WebCore::convertToLength): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::createTransformOperations):
platform/Length.h: (WebCore::Length::Length): (WebCore::Length::operator==): (WebCore::Length::operator!=): (WebCore::Length::rawValue): (WebCore::Length::type): (WebCore::Length::quirk): (WebCore::Length::setValue): (WebCore::Length::setRawValue): (WebCore::Length::calcFloatValue): (WebCore::Length::isZero): (WebCore::Length::blend):
rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::calcWidthArray):

3:36 PM Changeset in webkit [80382] by mrowe@apple.com

2 edits in trunk/Tools

<rdar://problem/9055252> DumpRenderTree is crashing with GuardMalloc

Reviewed by Alexey Proskuryakov.

GuardMalloc does not expect the memory containing its malloc_zone_t to ever be read-only.

DumpRenderTree/mac/CheckedMalloc.cpp:

(protectionOfRegion): Retrieve the protection flags for the VM region containing the given address.
(makeLargeMallocFailSilently): Save the initial protection flags, temporarily make the region writeable,
and then restore the initial protection flags when we're done.

3:09 PM Changeset in webkit [80381] by jberlin@webkit.org

8 edits in trunk/Source

WebKit2: Use CFNetwork Sessions API.
https://bugs.webkit.org/show_bug.cgi?id=55435.

Reviewed by Darin Adler.

Add in the CFURLSTORAGESESSIONS guards that I incorrectly left out because the code was
contained within guards that made USE(CFURLSTORAGESESSIONS) always be true.

Source/WebCore:

platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::makeFinalRequest):
(WebCore::ResourceHandle::willSendRequest):

platform/network/cf/ResourceRequestCFNet.cpp:
platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::createNSURLConnection):
(WebCore::ResourceHandle::willSendRequest):

platform/network/mac/ResourceRequestMac.mm:

Source/WebKit2:

UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformInitializeWebProcess):

UIProcess/win/WebContextWin.cpp:

(WebKit::WebContext::platformInitializeWebProcess):

3:07 PM Changeset in webkit [80380] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

2011-03-04 Yuqiang Xian <yuqiang.xian@intel.com>

Reviewed by Darin Adler.

improve layout performance by reducing the traversal time of the floating objects
https://bugs.webkit.org/show_bug.cgi?id=55440

We observered large overhead on traversing the floating objects list
in logicalLeftOffsetForLine() and logicalRightOffsetForLine() especially
when the list becomes enormous, for example in the default 30x30 maze test
from http://ie.microsoft.com/testdrive/Performance/MazeSolver/Default.html
there're >3700 floating objects. When placing a new floating object the
entire list (from begin to end) is traversed for multiple times.
There's a low hanging fruit to reduce the chances to do the traversal
which is especially applicable in logicalLeftOffsetForLine and logicalRightOffsetForLine.
As the two routines either cares about FloatLeft objects or FloatRight objects only,
if we know there's no corresponding type floating objects in the list
we can avoid the traversal actually. One thing we could do is to record
the number of FloatLeft objects and the number of FloatRight objects and
add a check before doing the traversal. This can reduce the time by 45%
to resolve the 30x30 Maze measured on N470 Netbook MeeGo using latest
Chromium browser 11 (from 503s to 269s).

No new tests, relying on existing layout tests.

rendering/RenderBlock.cpp: (WebCore::RenderBlock::~RenderBlock): (WebCore::RenderBlock::addOverflowFromFloats): (WebCore::RenderBlock::repaintOverhangingFloats): (WebCore::RenderBlock::paintFloats): (WebCore::RenderBlock::selectionGaps): (WebCore::RenderBlock::insertFloatingObject): (WebCore::RenderBlock::removeFloatingObject): (WebCore::RenderBlock::removeFloatingObjectsBelow): (WebCore::RenderBlock::positionNewFloats): (WebCore::RenderBlock::positionNewFloatOnLine): (WebCore::RenderBlock::logicalLeftOffsetForLine): (WebCore::RenderBlock::logicalRightOffsetForLine): (WebCore::RenderBlock::nextFloatLogicalBottomBelow): (WebCore::RenderBlock::lowestFloatLogicalBottom): (WebCore::RenderBlock::clearFloats): (WebCore::RenderBlock::addOverhangingFloats): (WebCore::RenderBlock::addIntrudingFloats): (WebCore::RenderBlock::containsFloat): (WebCore::RenderBlock::hitTestFloats): (WebCore::RenderBlock::adjustForBorderFit): (WebCore::RenderBlock::FloatingObjects::clear): (WebCore::RenderBlock::FloatingObjects::increaseObjectsCount): (WebCore::RenderBlock::FloatingObjects::decreaseObjectsCount):
rendering/RenderBlock.h: (WebCore::RenderBlock::containsFloats): (WebCore::RenderBlock::FloatingObjects::FloatingObjects): (WebCore::RenderBlock::FloatingObjects::hasLeftObjects): (WebCore::RenderBlock::FloatingObjects::hasRightObjects): (WebCore::RenderBlock::FloatingObjects::set):
rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::layoutInlineChildren): (WebCore::RenderBlock::matchedEndLine):

3:05 PM Changeset in webkit [80379] by commit-queue@webkit.org

8 edits in trunk

2011-03-04 Rik Cabanier <cabanier@gmail.com>

Reviewed by David Hyatt.

Fix that allows fixed length values to be floating point
https://bugs.webkit.org/show_bug.cgi?id=52699

Transitions now return matrices in floating point. 2 of the transition tests were failing
because they expected integer values.

transitions/matched-transform-functions.html:
transitions/retargetted-transition.html:

2011-03-04 Rik Cabanier <cabanier@gmail.com>

Reviewed by David Hyatt.

Fix that allows fixed length values to be floating point
https://bugs.webkit.org/show_bug.cgi?id=52699

WebCore.xcodeproj/project.pbxproj:
css/CSSStyleSelector.cpp: (WebCore::convertToLength): (WebCore::convertToIntLength): (WebCore::convertToFloatLength): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::createTransformOperations):
platform/Length.h: (WebCore::Length::Length): (WebCore::Length::operator==): (WebCore::Length::operator!=): (WebCore::Length::rawValue): (WebCore::Length::type): (WebCore::Length::quirk): (WebCore::Length::setValue): (WebCore::Length::calcFloatValue): (WebCore::Length::isZero): (WebCore::Length::blend): (WebCore::Length::getIntValue): (WebCore::Length::getFloatValue):
rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::calcWidthArray):

2:34 PM Changeset in webkit [80378] by barraclough@apple.com

127 edits
3 adds in trunk

Bug 55736 - Implement seal/freeze/preventExtensions for normal object types.
Provide basic functionallity from section 15.2.4 of ECMA-262.
This support will need expanding to cover arrays, too.

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Shows a 0.5% progression on SunSpidey, this seems to be due to changing
ObjectConstructor to use a static table.

DerivedSources.make:
JavaScriptCore.exp:
interpreter/CallFrame.h:

(JSC::ExecState::objectConstructorTable):

Add a static table for ObjectConstructor.

runtime/CommonIdentifiers.h:
runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):

Add a static table for ObjectConstructor.

runtime/JSGlobalData.h:
runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):

Add a static table for ObjectConstructor.

runtime/JSObject.cpp:

(JSC::JSObject::seal):
(JSC::JSObject::freeze):
(JSC::JSObject::preventExtensions):

Transition the object's structure.

(JSC::JSObject::defineOwnProperty):

Check isExtensible.

runtime/JSObject.h:

(JSC::JSObject::isSealed):
(JSC::JSObject::isFrozen):
(JSC::JSObject::isExtensible):

These wrap method on structure.

(JSC::JSObject::putDirectInternal):

Check isExtensible.

runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::ObjectConstructor):
(JSC::ObjectConstructor::getOwnPropertySlot):
(JSC::ObjectConstructor::getOwnPropertyDescriptor):

Change ObjectConstructor to use a static table.

(JSC::objectConstructorSeal):
(JSC::objectConstructorFreeze):
(JSC::objectConstructorPreventExtensions):
(JSC::objectConstructorIsSealed):
(JSC::objectConstructorIsFrozen):
(JSC::objectConstructorIsExtensible):

Add new methods on Object.

runtime/ObjectConstructor.h:

(JSC::ObjectConstructor::createStructure):

runtime/Structure.cpp:

(JSC::Structure::Structure):

init/propagate m_preventExtensions

(JSC::Structure::sealTransition):
(JSC::Structure::freezeTransition):
(JSC::Structure::preventExtensionsTransition):

transition the structure, materializing the property map, setting m_preventExtensions & changing attributes.

(JSC::Structure::isSealed):
(JSC::Structure::isFrozen):

check attributes to detect if object is sealed/frozen.

runtime/Structure.h:

(JSC::Structure::isExtensible):

checks the m_preventExtensions flag.

LayoutTests:

Update results - many more tests PASS.
Also adds a new testcase.

fast/js/Object-getOwnPropertyNames-expected.txt:
fast/js/script-tests/Object-getOwnPropertyNames.js:
ietestcenter/Javascript/15.2.3.10-0-1-expected.txt:
ietestcenter/Javascript/15.2.3.10-0-2-expected.txt:
ietestcenter/Javascript/15.2.3.10-1-expected.txt:
ietestcenter/Javascript/15.2.3.10-2-expected.txt:
ietestcenter/Javascript/15.2.3.11-0-1-expected.txt:
ietestcenter/Javascript/15.2.3.11-0-2-expected.txt:
ietestcenter/Javascript/15.2.3.11-1-expected.txt:
ietestcenter/Javascript/15.2.3.11-4-1-expected.txt:
ietestcenter/Javascript/15.2.3.11-4-10-expected.txt:
ietestcenter/Javascript/15.2.3.11-4-11-expected.txt:
ietestcenter/Javascript/15.2.3.11-4-12-expected.txt:
ietestcenter/Javascript/15.2.3.11-4-13-expected.txt:
ietestcenter/Javascript/15.2.3.11-4-14-expected.txt:
ietestcenter/Javascript/15.2.3.11-4-15-expected.txt:
ietestcenter/Javascript/15.2.3.11-4-16-expected.txt:
ietestcenter/Javascript/15.2.3.11-4-17-expected.txt:
ietestcenter/Javascript/15.2.3.11-4-18-expected.txt:
ietestcenter/Javascript/15.2.3.11-4-19-expected.txt:
ietestcenter/Javascript/15.2.3.11-4-2-expected.txt:
ietestcenter/Javascript/15.2.3.11-4-20-expected.txt:
ietestcenter/Javascript/15.2.3.11-4-21-expected.txt:
ietestcenter/Javascript/15.2.3.11-4-22-expected.txt:
ietestcenter/Javascript/15.2.3.11-4-23-expected.txt:
ietestcenter/Javascript/15.2.3.11-4-24-expected.txt:
ietestcenter/Javascript/15.2.3.11-4-25-expected.txt:
ietestcenter/Javascript/15.2.3.11-4-26-expected.txt:
ietestcenter/Javascript/15.2.3.11-4-27-expected.txt:
ietestcenter/Javascript/15.2.3.11-4-3-expected.txt:
ietestcenter/Javascript/15.2.3.11-4-4-expected.txt:
ietestcenter/Javascript/15.2.3.11-4-5-expected.txt:
ietestcenter/Javascript/15.2.3.11-4-6-expected.txt:
ietestcenter/Javascript/15.2.3.11-4-7-expected.txt:
ietestcenter/Javascript/15.2.3.11-4-8-expected.txt:
ietestcenter/Javascript/15.2.3.11-4-9-expected.txt:
ietestcenter/Javascript/15.2.3.12-0-1-expected.txt:
ietestcenter/Javascript/15.2.3.12-0-2-expected.txt:
ietestcenter/Javascript/15.2.3.12-1-expected.txt:
ietestcenter/Javascript/15.2.3.12-3-1-expected.txt:
ietestcenter/Javascript/15.2.3.12-3-10-expected.txt:
ietestcenter/Javascript/15.2.3.12-3-11-expected.txt:
ietestcenter/Javascript/15.2.3.12-3-12-expected.txt:
ietestcenter/Javascript/15.2.3.12-3-13-expected.txt:
ietestcenter/Javascript/15.2.3.12-3-14-expected.txt:
ietestcenter/Javascript/15.2.3.12-3-15-expected.txt:
ietestcenter/Javascript/15.2.3.12-3-16-expected.txt:
ietestcenter/Javascript/15.2.3.12-3-17-expected.txt:
ietestcenter/Javascript/15.2.3.12-3-18-expected.txt:
ietestcenter/Javascript/15.2.3.12-3-19-expected.txt:
ietestcenter/Javascript/15.2.3.12-3-2-expected.txt:
ietestcenter/Javascript/15.2.3.12-3-20-expected.txt:
ietestcenter/Javascript/15.2.3.12-3-21-expected.txt:
ietestcenter/Javascript/15.2.3.12-3-22-expected.txt:
ietestcenter/Javascript/15.2.3.12-3-23-expected.txt:
ietestcenter/Javascript/15.2.3.12-3-24-expected.txt:
ietestcenter/Javascript/15.2.3.12-3-25-expected.txt:
ietestcenter/Javascript/15.2.3.12-3-26-expected.txt:
ietestcenter/Javascript/15.2.3.12-3-27-expected.txt:
ietestcenter/Javascript/15.2.3.12-3-3-expected.txt:
ietestcenter/Javascript/15.2.3.12-3-4-expected.txt:
ietestcenter/Javascript/15.2.3.12-3-5-expected.txt:
ietestcenter/Javascript/15.2.3.12-3-6-expected.txt:
ietestcenter/Javascript/15.2.3.12-3-7-expected.txt:
ietestcenter/Javascript/15.2.3.12-3-8-expected.txt:
ietestcenter/Javascript/15.2.3.12-3-9-expected.txt:
ietestcenter/Javascript/15.2.3.13-0-1-expected.txt:
ietestcenter/Javascript/15.2.3.13-0-2-expected.txt:
ietestcenter/Javascript/15.2.3.13-0-3-expected.txt:
ietestcenter/Javascript/15.2.3.13-1-expected.txt:
ietestcenter/Javascript/15.2.3.13-2-1-expected.txt:
ietestcenter/Javascript/15.2.3.13-2-10-expected.txt:
ietestcenter/Javascript/15.2.3.13-2-11-expected.txt:
ietestcenter/Javascript/15.2.3.13-2-12-expected.txt:
ietestcenter/Javascript/15.2.3.13-2-13-expected.txt:
ietestcenter/Javascript/15.2.3.13-2-14-expected.txt:
ietestcenter/Javascript/15.2.3.13-2-15-expected.txt:
ietestcenter/Javascript/15.2.3.13-2-16-expected.txt:
ietestcenter/Javascript/15.2.3.13-2-17-expected.txt:
ietestcenter/Javascript/15.2.3.13-2-18-expected.txt:
ietestcenter/Javascript/15.2.3.13-2-19-expected.txt:
ietestcenter/Javascript/15.2.3.13-2-2-expected.txt:
ietestcenter/Javascript/15.2.3.13-2-20-expected.txt:
ietestcenter/Javascript/15.2.3.13-2-21-expected.txt:
ietestcenter/Javascript/15.2.3.13-2-3-expected.txt:
ietestcenter/Javascript/15.2.3.13-2-4-expected.txt:
ietestcenter/Javascript/15.2.3.13-2-5-expected.txt:
ietestcenter/Javascript/15.2.3.13-2-6-expected.txt:
ietestcenter/Javascript/15.2.3.13-2-7-expected.txt:
ietestcenter/Javascript/15.2.3.13-2-8-expected.txt:
ietestcenter/Javascript/15.2.3.13-2-9-expected.txt:
ietestcenter/Javascript/15.2.3.14-2-4-expected.txt:
ietestcenter/Javascript/15.2.3.14-2-5-expected.txt:
ietestcenter/Javascript/15.2.3.14-2-6-expected.txt:
ietestcenter/Javascript/15.2.3.3-4-20-expected.txt:
ietestcenter/Javascript/15.2.3.3-4-21-expected.txt:
ietestcenter/Javascript/15.2.3.3-4-22-expected.txt:
ietestcenter/Javascript/15.2.3.3-4-23-expected.txt:
ietestcenter/Javascript/15.2.3.3-4-24-expected.txt:
ietestcenter/Javascript/15.2.3.3-4-25-expected.txt:
ietestcenter/Javascript/15.2.3.4-4-2-expected.txt:
ietestcenter/Javascript/15.2.3.6-4-1-expected.txt:
ietestcenter/Javascript/15.2.3.8-0-1-expected.txt:
ietestcenter/Javascript/15.2.3.8-0-2-expected.txt:
ietestcenter/Javascript/15.2.3.8-1-expected.txt:
ietestcenter/Javascript/15.2.3.9-0-1-expected.txt:
ietestcenter/Javascript/15.2.3.9-0-2-expected.txt:
ietestcenter/Javascript/15.2.3.9-1-expected.txt:

2:08 PM Changeset in webkit [80377] by sfalken@apple.com

1 edit in trunk/Source/WebCore/ChangeLog

Fix ChangeLog

2:07 PM Changeset in webkit [80376] by evan@chromium.org

2 edits in trunk/Tools

2011-03-04 Evan Martin <evan@chromium.org>

Reviewed by Tony Chang.

[gdb] pretty-print KURL in gdb
https://bugs.webkit.org/show_bug.cgi?id=55788

gdb/webkit.py: extend the pretty-printers to print WTF::CString and KURLGooglePrivate. As always, "p/r" can be used to sidestep pretty-printing.

2:06 PM Changeset in webkit [80375] by sfalken@apple.com

5 edits
1 delete in trunk/Source/WebCore

Adopt VersionStamper tool for Windows WebKit DLLs
https://bugs.webkit.org/show_bug.cgi?id=55784

Reviewed by NOBODY Jon Honeycutt.

We now use a tool to stamp the version number onto the Apple WebKit DLLs
during the post-build step.

WebCore.vcproj/QTMovieWin.rc: Removed.
WebCore.vcproj/QTMovieWin.vcproj:
WebCore.vcproj/QTMovieWinPostBuild.cmd: Stamp version with VersionStamper.
WebCore.vcproj/QTMovieWinPreBuild.cmd: Don't run auto-version.sh. We don't use autoversion.h in this project.
WebCore.vcproj/WebCoreMediaQT.vsprops: Remove unnecessary include paths for resource files.

2:05 PM Changeset in webkit [80374] by sfalken@apple.com

4 edits
1 delete in trunk/Source/JavaScriptCore

Adopt VersionStamper tool for Windows WebKit DLLs
https://bugs.webkit.org/show_bug.cgi?id=55784
<rdar://problem/9021273>

Reviewed by Jon Honeycutt.

We now use a tool to stamp the version number onto the Apple WebKit DLLs
during the post-build step.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.rc: Removed.
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCorePostBuild.cmd:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCorePreBuild.cmd:

2:03 PM Changeset in webkit [80373] by pfeldman@chromium.org

2 edits in trunk/LayoutTests

2011-03-04 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: follow up to 80355, fixing Qt tests.

http/tests/inspector/inspector-test.js:

1:59 PM Changeset in webkit [80372] by mihaip@chromium.org

14 edits
1 copy
9 adds in trunk/LayoutTests

2011-03-04 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium Snow Leopard rebaseline.

Rebaseline fast/blockflow.

platform/chromium-mac-leopard/fast/blockflow/english-lr-text-expected.checksum: Copied from LayoutTests/platform/chromium-mac/fast/blockflow/english-lr-text-expected.checksum.
platform/chromium-mac-leopard/fast/blockflow/english-lr-text-expected.png: Added.
platform/chromium-mac-leopard/fast/blockflow/japanese-rl-text-with-broken-font-expected.checksum: Added.
platform/chromium-mac-leopard/fast/blockflow/japanese-rl-text-with-broken-font-expected.png: Added.
platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum: Added.
platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.png: Added.
platform/chromium-mac/fast/blockflow/border-vertical-lr-expected.checksum:
platform/chromium-mac/fast/blockflow/border-vertical-lr-expected.png:
platform/chromium-mac/fast/blockflow/english-lr-text-expected.checksum:
platform/chromium-mac/fast/blockflow/english-lr-text-expected.png: Added.
platform/chromium-mac/fast/blockflow/japanese-lr-selection-expected.checksum:
platform/chromium-mac/fast/blockflow/japanese-lr-selection-expected.png:
platform/chromium-mac/fast/blockflow/japanese-lr-text-expected.checksum:
platform/chromium-mac/fast/blockflow/japanese-lr-text-expected.png:
platform/chromium-mac/fast/blockflow/japanese-rl-selection-expected.checksum:
platform/chromium-mac/fast/blockflow/japanese-rl-selection-expected.png:
platform/chromium-mac/fast/blockflow/japanese-rl-text-expected.checksum:
platform/chromium-mac/fast/blockflow/japanese-rl-text-expected.png: Added.
platform/chromium-mac/fast/blockflow/japanese-rl-text-with-broken-font-expected.checksum: Added.
platform/chromium-mac/fast/blockflow/japanese-rl-text-with-broken-font-expected.png: Added.
platform/chromium-mac/fast/blockflow/vertical-align-table-baseline-expected.checksum:
platform/chromium-mac/fast/blockflow/vertical-align-table-baseline-expected.png:
platform/chromium/test_expectations.txt:

1:28 PM Changeset in webkit [80371] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

2011-03-04 Cosmin Truta <ctruta@chromium.org>

Reviewed by Adam Barth.

Clarify comment about potential memory leak in SVGImage
https://bugs.webkit.org/show_bug.cgi?id=55362

No functionality change. No new tests.

svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):

12:37 PM Changeset in webkit [80370] by jberlin@webkit.org

13 edits in trunk

WebKit2: Use CFNetwork Sessions API.
https://bugs.webkit.org/show_bug.cgi?id=55435.

Reviewed by Maciej Stachowiak.

When Private Browsing is enabled, get the cached url response from the cache associated with
the Private Browsing Storage Session.

Source/WebCore:

WebCore.exp.in:

Export the symbol for ResourceHandle::privateBrowsingStorageSession.

Source/WebKit/mac:

WebView/WebView.mm:

(-[WebView _cachedResponseForURL:]):

Source/WebKit2:

WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::platformHasLocalDataForURL):
If Private Browsing is enabled, call into WKSI to get the response.
(WebKit::WebPage::cachedResponseMIMETypeForURL):
Ditto.

WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::WebPage::platformHasLocalDataForURL):
If Private Browsing is enabled, call into WKSI to get the CFURLCacheRef.
(WebKit::WebPage::cachedResponseMIMETypeForURL):
Ditto.

WebKitLibraries:

Update WebKitSystemInterface headers and libraries with the new functions.

WebKitSystemInterface.h:
libWebKitSystemInterfaceLeopard.a:
libWebKitSystemInterfaceSnowLeopard.a:
win/include/WebKitSystemInterface/WebKitSystemInterface.h:
win/lib/WebKitSystemInterface.lib:

12:30 PM Changeset in webkit [80369] by mdelaney@apple.com

1 edit
1 move in trunk/LayoutTests

2011-03-03 Matthew Delaney <mdelaney@apple.com>

Reviewed by Darin Adler.

Incorrect location for expected result for 2d.line.cap.closed.html
https://bugs.webkit.org/show_bug.cgi?id=55637

platform/mac-snowleopard/canvas/philip/tests/2d.line.cap.closed-expected.txt: Copied from LayoutTests/platform/mac/canvas/philip/tests/2d.line.cap.closed-expected.txt.
platform/mac/canvas/philip/tests/2d.line.cap.closed-expected.txt: Removed.

11:21 AM Changeset in webkit [80368] by abarth@webkit.org

3 edits in trunk/Source/JavaScriptCore

2011-03-04 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

JavaScriptCore GYP build should use a header map
https://bugs.webkit.org/show_bug.cgi?id=55712

This patch moves the os-win32 files into their own variable so that we
can use a header map in the Apple Mac Xcode build. The problem is that
the header map searches the whole project rather than just the files
included in a given target. Another solution to this problem is to
make GYP smarter about filtering out what files are added to the
project file.

JavaScriptCore.gypi:
gyp/JavaScriptCore.gyp:

11:17 AM Changeset in webkit [80367] by steveblock@google.com

10 edits
2 moves in trunk/Source/WebCore

2011-03-04 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

JSC and V8 versions of Java bridge should share JobjectWrapper
https://bugs.webkit.org/show_bug.cgi?id=55763

No new tests, refactoring only.

Android.jscbindings.mk:
Android.v8bindings.mk:
WebCore.gypi:
WebCore.order:
WebCore.xcodeproj/project.pbxproj:
bridge/jni/JobjectWrapper.cpp: (JobjectWrapper::JobjectWrapper): (JobjectWrapper::~JobjectWrapper):
bridge/jni/JobjectWrapper.h: (JSC::Bindings::JobjectWrapper::instance): (JSC::Bindings::JobjectWrapper::setInstance): (JSC::Bindings::JobjectWrapper::ref): (JSC::Bindings::JobjectWrapper::deref):
bridge/jni/jsc/JNIBridgeJSC.cpp: (JavaField::JavaField): (JavaArray::JavaArray):
bridge/jni/jsc/JNIBridgeJSC.h:
bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::JavaInstance):
bridge/jni/jsc/JavaInstanceJSC.h:

10:32 AM Changeset in webkit [80366] by mihaip@chromium.org

2 edits in trunk/LayoutTests

2011-03-04 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

Add one expected failure for Snow Leopard, make other failure lines
more specific (since the tests pass on SL) and remove some flaky test
entries for tests that are no longer flaky.

platform/chromium/test_expectations.txt:

10:08 AM Changeset in webkit [80365] by jeffm@apple.com

5 edits in trunk/Source/WebKit2

2011-03-04 Jeff Miller <jeffm@apple.com>

Reviewed by Darin Adler.

Move WKViewExecuteCommand() to WKPageExecuteCommand()
https://bugs.webkit.org/show_bug.cgi?id=55744

Executing a command operates on a page, so it makes more sense for it to be in WKPage.
This also makes it available on all platforms, not just Windows.

UIProcess/API/C/WKPage.cpp: (WKPageExecuteCommand): Added.
UIProcess/API/C/WKPage.h: Add WKPageExecuteCommand().
UIProcess/API/C/win/WKView.cpp: Remove WKViewExecuteCommand().
UIProcess/API/C/win/WKView.h: Remove WKViewExecuteCommand().

10:08 AM Changeset in webkit [80364] by tonyg@chromium.org

2 edits in trunk/LayoutTests

2011-03-04 Tony Gentilcore <tonyg@chromium.org>

Unreviewed expectations update.

[chromium] Rebaseline to match r80351
https://bugs.webkit.org/show_bug.cgi?id=55783

platform/chromium/inspector/timeline/timeline-network-resource-expected.txt:

9:55 AM Changeset in webkit [80363] by jberlin@webkit.org

2 edits in trunk/LayoutTests

[Windows 7 WebKit2 Release Tests] fast/frames/iframe-plugin-load-remove-document-crash.html
and platform/win/plugins/get-value-netscape-window.html crashing.
https://bugs.webkit.org/show_bug.cgi?id=55778
https://bugs.webkit.org/show_bug.cgi?id=55780

Unreviewed. Add these tests to the Windows WebKit2 Skipped list to get the bots green.

platform/win-wk2/Skipped:

9:38 AM Changeset in webkit [80362] by Patrick Gansterer

13 edits in trunk/Source/WebCore

2011-03-04 Patrick Gansterer <Patrick Gansterer>

Reviewed by Nikolas Zimmermann.

Move shared code into SVGStyledTransformableElement::svgAttributeChanged
https://bugs.webkit.org/show_bug.cgi?id=55771

All sub classes of SVGStyledTransformableElement request a relayout
the same way. So move that code into the common base class.

svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::svgAttributeChanged):
svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::svgAttributeChanged):
svg/SVGForeignObjectElement.cpp: (WebCore::SVGForeignObjectElement::svgAttributeChanged):
svg/SVGGElement.cpp: (WebCore::SVGGElement::svgAttributeChanged):
svg/SVGImageElement.cpp: (WebCore::SVGImageElement::svgAttributeChanged):
svg/SVGLineElement.cpp: (WebCore::SVGLineElement::svgAttributeChanged):
svg/SVGPathElement.cpp: (WebCore::SVGPathElement::svgAttributeChanged):
svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::svgAttributeChanged):
svg/SVGRectElement.cpp: (WebCore::SVGRectElement::svgAttributeChanged):
svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::svgAttributeChanged):
svg/SVGStyledTransformableElement.h:
svg/SVGUseElement.cpp: (WebCore::SVGUseElement::svgAttributeChanged):

9:32 AM QtWebKitReleases edited by Ademar Reis

minor (diff)

9:22 AM Changeset in webkit [80361] by jam@chromium.org

7 edits in trunk/Source

2011-03-03 John Abd-El-Malek <jam@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Get rid of IsContentFiltered flags since they're not used anymore
https://bugs.webkit.org/show_bug.cgi?id=55748

DEPS:
public/WebURLResponse.h:
src/WebURLResponse.cpp:

2011-03-03 John Abd-El-Malek <jam@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Get rid of IsContentFiltered flags since they're not used anymore
https://bugs.webkit.org/show_bug.cgi?id=55748

platform/network/chromium/ResourceResponse.cpp: (WebCore::ResourceResponse::doPlatformCopyData): (WebCore::ResourceResponse::doPlatformAdopt):
platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse):

9:22 AM Changeset in webkit [80360] by Philippe Normand

2 edits in trunk/LayoutTests

2011-03-04 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] media/audio-repaint.html times out
https://bugs.webkit.org/show_bug.cgi?id=55761

media/audio-repaint.html: Register the seeked event listener before performing the seek and thus avoid a timeout of the test.

9:20 AM Changeset in webkit [80359] by mitz@apple.com

2 edits in trunk/Source/WebKit2

LLVM Compiler build fix.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::runJavaScriptInMainFrame):

9:19 AM QtWebKitReleases edited by Ademar Reis

misc fixes + a section about the qtwebkit/tools used for release-management (diff)

8:46 AM Changeset in webkit [80358] by timothy@apple.com

14 edits in trunk

Make the WKPageRunJavaScriptFunction callback take a WKSerializedScriptValueRef.

Source/WebCore: Export SerializedScriptValue::create(JSC::ExecState* exec, JSC::JSValue value).

Reviewed by Darin Adler.

WebCore.exp.in: Added ZN7WebCore21SerializedScriptValue6createEPN3JSC9ExecStateENS1_7JSValueE.

Source/WebKit2: Make the WKPageRunJavaScriptFunction callback take a WKSerializedScriptValueRef.

https://webkit.org/b/55623

Reviewed by Darin Adler.

UIProcess/API/C/WKPage.cpp:

(WKPageRunJavaScriptInMainFrame): Use ScriptValueCallback.
(callRunJavaScriptBlockAndRelease): Use WKSerializedScriptValueRef.

UIProcess/API/C/WKPage.h: Use WKSerializedScriptValueRef.
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close): Call invalidateCallbackMap for m_scriptValueCallbacks.
(WebKit::WebPageProxy::runJavaScriptInMainFrame): Take a ScriptValueCallback.
(WebKit::WebPageProxy::scriptValueCallback): Added. Create a WebSerializedScriptValue
from the DataReference before calling the callback.
(WebKit::WebPageProxy::processDidCrash): Call invalidateCallbackMap for m_scriptValueCallbacks.

UIProcess/WebPageProxy.h: Added ScriptValueCallback and m_scriptValueCallbacks.
UIProcess/WebPageProxy.messages.in: Added ScriptValueCallback.
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::runJavaScriptInMainFrame): Create a DataReference from a WebCore::SerializedScriptValue.
And use ScriptValueCallback to send the message back.

Tools: Update the tests that use WKPageRunJavaScriptInMainFrame use the WKSerializedScriptValueRef.

Reviewed by Darin Adler.

TestWebKitAPI/JavaScriptTest.cpp:

(TestWebKitAPI::javaScriptCallback):

TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:

(TestWebKitAPI::didRunJavaScript):

TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:

(TestWebKitAPI::nullJavaScriptCallback):

TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:

(TestWebKitAPI::didRunJavaScript):

8:46 AM Changeset in webkit [80357] by timothy@apple.com

2 edits in trunk/Tools

Make run-api-tests show failed if a test fails.

https://webkit.org/b/55725

Reviewed by Sam Weinig.

Scripts/run-api-tests:

(runTest): Remove "my" from the nested $result assignment so the
check outside the condition sees the real result.

8:40 AM Changeset in webkit [80356] by podivilov@chromium.org

10 edits in trunk

2011-03-04 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: extract all code that depends on source mapping from SourceFrame.
https://bugs.webkit.org/show_bug.cgi?id=55464

http/tests/inspector/debugger-test.js: (initialize_DebuggerTest):
inspector/debugger/debug-inlined-scripts.html:
inspector/debugger/debugger-breakpoints-not-activated-on-reload.html:
inspector/debugger/debugger-pause-on-breakpoint.html:
inspector/debugger/source-frame.html:

2011-03-04 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: extract all code that depends on source mapping from SourceFrame.
https://bugs.webkit.org/show_bug.cgi?id=55464

Extract all dependencies on DebuggerModel and ScriptsPanel to a delegate class
to encapsulate source mapping aspects from SourceFrame.

inspector/front-end/ResourceView.js: (WebInspector.ResourceView.createResourceView): (WebInspector.SourceFrameDelegateForResourcesPanel): (WebInspector.SourceFrameDelegateForResourcesPanel.prototype.requestContent):
inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._createSourceFrame): (WebInspector.SourceFrameDelegateForScriptsPanel):
inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame): (WebInspector.SourceFrame.prototype.show): (WebInspector.SourceFrame.prototype._createTextViewer): (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint.didEditBreakpointCondition): (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint): (WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCondition.didEditBreakpointCondition): (WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCondition): (WebInspector.SourceFrame.prototype._contextMenu.else.setBreakpointEnabled): (WebInspector.SourceFrame.prototype._contextMenu): (WebInspector.SourceFrame.prototype._mouseDown): (WebInspector.SourceFrame.prototype._mouseMove): (WebInspector.SourceFrame.prototype._hidePopup): (WebInspector.SourceFrame.prototype._mouseHover): (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup): (WebInspector.SourceFrame.prototype._showPopup): (WebInspector.SourceFrame.prototype._doubleClick): (WebInspector.SourceFrame.prototype._didEditLine): (WebInspector.SourceFrameDelegate): (WebInspector.SourceFrameDelegate.prototype.requestContent): (WebInspector.SourceFrameDelegate.prototype.debuggingSupported): (WebInspector.SourceFrameDelegate.prototype.setBreakpoint): (WebInspector.SourceFrameDelegate.prototype.removeBreakpoint): (WebInspector.SourceFrameDelegate.prototype.updateBreakpoint): (WebInspector.SourceFrameDelegate.prototype.findBreakpoint): (WebInspector.SourceFrameDelegate.prototype.continueToLine): (WebInspector.SourceFrameDelegate.prototype.canEditScriptSource): (WebInspector.SourceFrameDelegate.prototype.editScriptSource): (WebInspector.SourceFrameDelegate.prototype.debuggerPaused): (WebInspector.SourceFrameDelegate.prototype.evaluate): (WebInspector.SourceFrameDelegate.prototype.releaseEvaluationResult):

8:37 AM Changeset in webkit [80355] by caseq@chromium.org

7 edits in trunk

2011-03-04 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Use internal ids for resources in extension server.
Log errors in inspector tests.

Web Inspector: [Extensions API] maintain own, unique & persistent identifiers for resources
https://bugs.webkit.org/show_bug.cgi?id=55686

http/tests/inspector/inspector-test.js: (initialize_InspectorTest.consoleOutputHook):

2011-03-04 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Extensions API] maintain own, unique & persistent identifiers for resources.
https://bugs.webkit.org/show_bug.cgi?id=55686

Use internal ids for resources in extension server.
Log errors in inspector tests.

inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer): (WebInspector.ExtensionServer.prototype.resetResources): (WebInspector.ExtensionServer.prototype._notifyResourceFinished): (WebInspector.ExtensionServer.prototype._onRevealAndSelectResource): (WebInspector.ExtensionServer.prototype._onGetHAR): (WebInspector.ExtensionServer.prototype._onGetResourceContent): (WebInspector.ExtensionServer.prototype._resourceId): (WebInspector.ExtensionServer.prototype._resourceById):
inspector/front-end/HAREntry.js: (WebInspector.HARLog): (WebInspector.HARLog.prototype._convertResource):
inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._reset):

8:25 AM Changeset in webkit [80354] by caseq@chromium.org

3 edits in trunk/Source/WebCore

2011-03-04 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: exceptions when building context menu in network panel
https://bugs.webkit.org/show_bug.cgi?id=55678

inspector/front-end/DataGrid.js: (WebInspector.DataGrid.prototype.dataGridNodeFromNode): (WebInspector.DataGrid.prototype.dataGridNodeFromPoint):
inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._contextMenu):

8:07 AM Changeset in webkit [80353] by commit-queue@webkit.org

6 edits in trunk/Source/WebCore

2011-03-04 Ilya Sherman <isherman@chromium.org>

Reviewed by James Robinson.

Override paintScrollCorner() for FramelessScrollView to forego any custom scrollbar corner rendering.
This was previously done in ScrollbarThemeChromium, but we also need this on the Mac when the ScrollView
is a FramelessScrollView -- which is mostly just for Autofill.
In service of http://crbug.com/73772 (crash)
https://bugs.webkit.org/show_bug.cgi?id=55557

No tests added because this fix is Chromium-specific and the code is currently untestable from within WebKit.
In particular, DRT crashes when trying to render a FramelessScrollView.

platform/ScrollbarTheme.h: (WebCore::ScrollbarTheme::paintScrollCorner): Body moved to static function defaultPaintScrollCorner(). (WebCore::ScrollbarTheme::defaultPaintScrollCorner): Added.
platform/chromium/FramelessScrollView.cpp: (WebCore::FramelessScrollView::paintContents): (WebCore::FramelessScrollView::paintScrollCorner): Fix implementation moved to here from ScrollbarThemeChromium
platform/chromium/FramelessScrollView.h:
platform/chromium/ScrollbarThemeChromium.cpp:
platform/chromium/ScrollbarThemeChromium.h:

7:59 AM Changeset in webkit [80352] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/efl

2011-03-04 Grzegorz Czajkowski <g.czajkowski@samsung.com>

Reviewed by Kent Tamura.

[EFL] Doxygen documentation for ewk_settings
https://bugs.webkit.org/show_bug.cgi?id=55667

ewk/ewk_settings.cpp: (ewk_settings_default_user_agent_get): only style is fixed
ewk/ewk_settings.h:

7:26 AM Changeset in webkit [80351] by pfeldman@chromium.org

3 edits in trunk/LayoutTests

2011-03-04 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: fix inspector test flake.

inspector/timeline/timeline-network-resource-expected.txt:
inspector/timeline/timeline-network-resource.html:

7:15 AM Changeset in webkit [80350] by yurys@chromium.org

10 edits in trunk/Source/WebCore

2011-03-04 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: move dispatching of didCommitLoad to agents into InspectorInstrumentation
https://bugs.webkit.org/show_bug.cgi?id=55770

inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::didCommitLoad):
inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::InspectorCSSAgent): (WebCore::InspectorCSSAgent::~InspectorCSSAgent):
inspector/InspectorCSSAgent.h:
inspector/InspectorDatabaseAgent.cpp: (WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent):
inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didCommitLoadImpl):
inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::didCommitLoad):
inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::create): (WebCore::InspectorProfilerAgent::InspectorProfilerAgent): (WebCore::InspectorProfilerAgent::~InspectorProfilerAgent): (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole): (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole): (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling): (WebCore::InspectorProfilerAgent::stopUserInitiatedProfiling):
inspector/InspectorProfilerAgent.h:
inspector/InstrumentingAgents.h: (WebCore::InstrumentingAgents::InstrumentingAgents): (WebCore::InstrumentingAgents::inspectorCSSAgent): (WebCore::InstrumentingAgents::setInspectorCSSAgent): (WebCore::InstrumentingAgents::inspectorDOMStorageAgent): (WebCore::InstrumentingAgents::setInspectorDOMStorageAgent): (WebCore::InstrumentingAgents::inspectorDatabaseAgent): (WebCore::InstrumentingAgents::setInspectorDatabaseAgent): (WebCore::InstrumentingAgents::inspectorApplicationCacheAgent): (WebCore::InstrumentingAgents::setInspectorApplicationCacheAgent): (WebCore::InstrumentingAgents::inspectorDebuggerAgent): (WebCore::InstrumentingAgents::setInspectorDebuggerAgent): (WebCore::InstrumentingAgents::inspectorBrowserDebuggerAgent): (WebCore::InstrumentingAgents::setInspectorBrowserDebuggerAgent): (WebCore::InstrumentingAgents::inspectorProfilerAgent): (WebCore::InstrumentingAgents::setInspectorProfilerAgent):

7:09 AM Writing Layout Tests for DumpRenderTree edited by playmobil@google.com

Add links to view LayoutTest files in trac . (diff)

7:05 AM Changeset in webkit [80349] by loislo@chromium.org

18 edits in trunk

2011-03-04 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: rename RuntimeAgent's function from releaseWrapperObjectGroup to releaseObjectGroup.
https://bugs.webkit.org/show_bug.cgi?id=55773

inspector/protocol/runtime-agent-expected.txt:
inspector/protocol/runtime-agent.html:

2011-03-04 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: rename RuntimeAgent's function from releaseWrapperObjectGroup to releaseObjectGroup.
https://bugs.webkit.org/show_bug.cgi?id=55773

inspector/CodeGeneratorInspector.pm:
inspector/InjectedScript.cpp: (WebCore::InjectedScript::releaseObjectGroup):
inspector/InjectedScript.h:
inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::releaseObjectGroup):
inspector/InjectedScriptHost.h:
inspector/InjectedScriptSource.js: (.):
inspector/Inspector.idl:
inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::clearConsoleMessages):
inspector/InspectorRuntimeAgent.cpp: (WebCore::InspectorRuntimeAgent::releaseObjectGroup):
inspector/InspectorRuntimeAgent.h:
inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions.evaluatedProperties): (WebInspector.ConsoleView.prototype.completions):
inspector/front-end/PropertiesSidebarPane.js:
inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._hidePopup):
inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSection.prototype.update):

6:51 AM Changeset in webkit [80348] by podivilov@chromium.org

3 edits in trunk/Source/WebCore

2011-03-02 Andrey Adaikin <aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: Gutter height should be 100% when few lines are displayed
https://bugs.webkit.org/show_bug.cgi?id=55574

inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._startEditing):
inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._syncScroll): (WebInspector.TextEditorGutterPanel.prototype._expandChunks): (WebInspector.TextEditorGutterPanel.prototype.textChanged): (WebInspector.TextEditorGutterPanel.prototype.syncClientHeight):
inspector/front-end/textViewer.css: (.text-editor-lines): (.text-editor-contents .inner-container): (.webkit-line-number):

6:40 AM Changeset in webkit [80347] by podivilov@chromium.org

2 edits in trunk/Source/WebCore

2011-03-04 Andrey Adaikin <aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: [Text editor] Do bisect to find visible chunks
https://bugs.webkit.org/show_bug.cgi?id=55685

inspector/front-end/TextViewer.js: (WebInspector.TextEditorChunkedPanel.prototype._chunkNumberForLine): (WebInspector.TextEditorChunkedPanel.prototype._findVisibleChunks): (WebInspector.TextEditorChunkedPanel.prototype._repaintAll): (WebInspector.TextEditorGutterChunk.prototype.get offsetTop): (WebInspector.TextEditorMainPanel.prototype._updateHighlightsForRange): (WebInspector.TextEditorMainChunk.prototype.get offsetTop):

6:20 AM Changeset in webkit [80346] by podivilov@chromium.org

2 edits in trunk/Source/WebCore

2011-03-04 Andrey Adaikin <aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: [Text editor] DOMNodeRemoved events are missing
https://bugs.webkit.org/show_bug.cgi?id=55769

inspector/front-end/TextViewer.js: (WebInspector.TextEditorMainPanel): (WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates): (WebInspector.TextEditorMainChunk): (WebInspector.TextEditorMainChunk.prototype._createRow):

5:26 AM Changeset in webkit [80345] by loislo@chromium.org

5 edits in trunk

2011-03-04 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Remove unnecessary domain and success flags from the response messages.
https://bugs.webkit.org/show_bug.cgi?id=55768

We have domain property in the response messages but it is not used because we dispatch
the responses on the callback associated with seq.

If we have property 'errors' in the response then success eq false and true in the other case.

inspector/protocol/runtime-agent-expected.txt:
inspector/report-protocol-errors-expected.txt:

2011-03-04 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Remove unnecessary domain and success flags from the response messages.
https://bugs.webkit.org/show_bug.cgi?id=55768

We have domain property in the response messages but it is not used because we dispatch
the responses on the callback associated with seq.

If we have property 'errors' in the response then success eq false and true in the other case.

inspector/CodeGeneratorInspector.pm:

5:18 AM Changeset in webkit [80344] by christian@webkit.org

8 edits in trunk/Source/WebCore

Enable Copy Image Address context menu item in the Gtk port
https://bugs.webkit.org/show_bug.cgi?id=55136

Reviewed by Gustavo Noronha Silva.

page/ContextMenuController.cpp:
platform/ContextMenuItem.h:
platform/LocalizationStrategy.h:
platform/LocalizedStrings.cpp:
platform/LocalizedStrings.h:
platform/gtk/ContextMenuItemGtk.cpp:
platform/gtk/LocalizedStringsGtk.cpp:

4:37 AM Changeset in webkit [80343] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

Unreviewed.

[Qt] Two http auth tests fail with Qt 4.7.2
https://bugs.webkit.org/show_bug.cgi?id=55767

Add failing tests to the Skipped list to make buildbot happy.

platform/qt/Skipped: Add http/tests/appcache/auth.html and http/tests/xmlhttprequest/basic-auth.html.

3:16 AM Changeset in webkit [80342] by pfeldman@chromium.org

14 edits in trunk

2011-03-04 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: implement getCompletions via evaluate.
https://bugs.webkit.org/show_bug.cgi?id=55759

inspector/InjectedScript.cpp:
inspector/InjectedScript.h:
inspector/InjectedScriptSource.js:
inspector/Inspector.idl:
inspector/InspectorDebuggerAgent.cpp:
inspector/InspectorDebuggerAgent.h:
inspector/InspectorRuntimeAgent.cpp:
inspector/InspectorRuntimeAgent.h:
inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions.evaluated): (WebInspector.ConsoleView.prototype.completions.evaluatedProperties): (WebInspector.ConsoleView.prototype.completions): (WebInspector.ConsoleView.prototype._reportCompletions):
inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame.updatingCallbackWrapper): (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._showPopup): (WebInspector.SourceFrame.prototype._evalSelectionInCallFrame):

3:11 AM Changeset in webkit [80341] by loislo@chromium.org

2 edits
3 adds in trunk/LayoutTests

2011-03-03 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: introduce a protocol test for RuntimeAgent API.
https://bugs.webkit.org/show_bug.cgi?id=55482

http/tests/inspector/protocol-test.js: Added. (initialize_ProtocolTest.InspectorTest.filterProps): (initialize_ProtocolTest.InspectorTest._dumpStepResult): (initialize_ProtocolTest.InspectorTest._runNextStep): (initialize_ProtocolTest.InspectorTest.runProtocolTestSuite): (initialize_ProtocolTest):
inspector/protocol/runtime-agent-expected.txt: Added.
inspector/protocol/runtime-agent.html: Added.

2:13 AM SuccessfulPortHowTo edited by vikasdalal111@yahoo.co.in

(diff)

2:06 AM Changeset in webkit [80340] by morrita@google.com

3 edits in trunk/Tools

2011-03-02 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

[Chromium][DRT] WebTask should use webkit_support::TaskAdaptor
https://bugs.webkit.org/show_bug.cgi?id=55434

Changed WebTask to be a subclass of webkit_support::TaskAdaptor
and passed the object webkit_support::PostDelayedTask directly.

Note that the change keeps postTask() as is because it has a
semantics taht webkit_support::PostDelayedTask() has; It jumps to
the main thread.

DumpRenderTree/chromium/Task.cpp: (postDelayedTask):
DumpRenderTree/chromium/Task.h: (WebTask::Run):

1:45 AM Changeset in webkit [80339] by steveblock@google.com

2 edits in trunk/Source/WebCore

2011-03-04 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

V8 version of JavaString should obtain string from JNI in UTF-16 encoding
https://bugs.webkit.org/show_bug.cgi?id=55566

We obtain the string from JNI in UTF-16 encoding and convert
to UTF-8 using our own routines as required. This matches the
behaviour of the JSC version of JavaString.

No new tests, no change in behaviour.

bridge/jni/v8/JavaStringV8.h: (JSC::Bindings::JavaStringImpl::init): (JSC::Bindings::JavaStringImpl::utf8): (JSC::Bindings::JavaStringImpl::impl):

1:40 AM Changeset in webkit [80338] by pfeldman@chromium.org

19 edits in trunk

2011-03-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: do not push document into front-end, make it request one.
https://bugs.webkit.org/show_bug.cgi?id=55664

inspector/Inspector.idl:
inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent):
inspector/InspectorAgent.h:
inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::InspectorDOMAgent): (WebCore::InspectorDOMAgent::clearFrontend): (WebCore::InspectorDOMAgent::setDocument): (WebCore::InspectorDOMAgent::getDocument): (WebCore::InspectorDOMAgent::pushNodePathToFrontend): (WebCore::InspectorDOMAgent::boundNodeId): (WebCore::InspectorDOMAgent::resolveNode): (WebCore::InspectorDOMAgent::mainFrameDOMContentLoaded):
inspector/InspectorDOMAgent.h: (WebCore::InspectorDOMAgent::create):
inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.restoreDOMBreakpoints): (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement.decorateNode): (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement):
inspector/front-end/DOMAgent.js: (WebInspector.DOMDocument): (WebInspector.DOMAgent): (WebInspector.DOMAgent.prototype.requestDocument): (WebInspector.DOMAgent.prototype.pushNodeToFrontend): (WebInspector.DOMAgent.prototype.pushNodeByPathToFrontend): (WebInspector.DOMAgent.prototype._attributesUpdated): (WebInspector.DOMAgent.prototype._characterDataModified): (WebInspector.DOMAgent.prototype._documentUpdated): (WebInspector.DOMAgent.prototype._setDocument): (WebInspector.DOMAgent.prototype._setDetachedRoot): (WebInspector.DOMAgent.prototype._setChildNodes): (WebInspector.DOMAgent.prototype._childNodeInserted): (WebInspector.DOMAgent.prototype._childNodeRemoved): (WebInspector.DOMDispatcher.prototype.documentUpdated):
inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.show): (WebInspector.ElementsPanel.prototype.setDocument):
inspector/front-end/MetricsSidebarPane.js:
inspector/front-end/RemoteObject.js: (WebInspector.RemoteObject.prototype.pushNodeToFrontend):

2011-03-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: do not push document into front-end, make it request one.
https://bugs.webkit.org/show_bug.cgi?id=55664

http/tests/inspector/debugger-test.js: (initialize_DebuggerTest.): (initialize_DebuggerTest):
http/tests/inspector/elements-test.js: (initialize_ElementTest.InspectorTest.nodeWithId.documentRequested): (initialize_ElementTest.InspectorTest.nodeWithId): (initialize_ElementTest.InspectorTest.dumpDOMAgentTree): (initialize_ElementTest):
inspector/console/command-line-api-inspect.html:
inspector/elements/dom-agent-query-selector.html:
inspector/elements/mutate-unknown-node.html:
inspector/styles/styles-new-API.html:

1:26 AM Changeset in webkit [80337] by caseq@chromium.org

3 edits in trunk/Source/WebCore

2011-03-04 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: summary bar may overlap content of the network item view
https://bugs.webkit.org/show_bug.cgi?id=55656

drop custom summary bar placement logic, do it with CSS instead.

inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.resize): (WebInspector.NetworkPanel.prototype._createSummaryBar): (WebInspector.NetworkPanel.prototype._updateSummaryBar): (WebInspector.NetworkPanel.prototype._updateFilter): (WebInspector.NetworkPanel.prototype.show): (WebInspector.NetworkPanel.prototype.refresh): (WebInspector.NetworkPanel.prototype._reset): (WebInspector.NetworkPanel.prototype._setLargerResources): (WebInspector.NetworkPanel.prototype._updateOffscreenRows):
inspector/front-end/networkPanel.css: (.network-sidebar .data-grid td): (.network-sidebar tr.filler td): (.network-summary-bar): (.network-sidebar .data-grid .network-summary-bar td): (.network-summary-bar img):

1:04 AM Changeset in webkit [80336] by commit-queue@webkit.org

5 edits in trunk/Source

2011-03-04 James Su <suzhe@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] keycode is always 0 when using non-Latin keyboard layout.
https://bugs.webkit.org/show_bug.cgi?id=54939

Add KeyEventCocoa.{h,mm}, so that we can reuse them in chromium.

No intended functionality change.

WebCore.gyp/WebCore.gyp:
WebCore.gypi:

2011-03-04 James Su <suzhe@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] keycode is always 0 when using non-Latin keyboard layout.
https://bugs.webkit.org/show_bug.cgi?id=54939

No intended functionality change.

src/mac/WebInputEventFactory.mm: (WebKit::windowsKeyCodeForKeyEvent): Use the same implementation provided in WebCore/platform/mac/KeyEventMac.mm.

12:53 AM Changeset in webkit [80335] by Patrick Gansterer

2 edits in trunk/Source/WebCore

2011-03-04 Patrick Gansterer <Patrick Gansterer>

Unreviewed EFL build fix for r80324.

platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::paintThemePart):

12:44 AM Changeset in webkit [80334] by Patrick Gansterer

2 edits in trunk/Source/WebCore

2011-03-04 Patrick Gansterer <Patrick Gansterer>

Unreviewed EFL build fix for r80324.

platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::paintThemePart):

12:38 AM Changeset in webkit [80333] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit/chromium

2011-03-04 Zelidrag Hornung <zelidrag@chromium.org>

Reviewed by David Levin

Expose ability to create instance of DOMFileSystem from Chromium side.
https://bugs.webkit.org/show_bug.cgi?id=55618

public/WebFrame.h:
src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::createFileSystem):
src/WebFrameImpl.h:

12:28 AM Changeset in webkit [80332] by yurys@chromium.org

6 edits in trunk/Source/WebCore

2011-03-03 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: AppCache agent should have same lifetime as InspectorAgent
https://bugs.webkit.org/show_bug.cgi?id=55673

inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::setFrontend): (WebCore::InspectorAgent::disconnectFrontend): (WebCore::InspectorAgent::createFrontendLifetimeAgents): (WebCore::InspectorAgent::releaseFrontendLifetimeAgents): (WebCore::InspectorAgent::didCommitLoad):
inspector/InspectorApplicationCacheAgent.cpp: (WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent): (WebCore::InspectorApplicationCacheAgent::setFrontend): (WebCore::InspectorApplicationCacheAgent::clearFrontend):
inspector/InspectorApplicationCacheAgent.h:
inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::networkStateChangedImpl): (WebCore::InspectorInstrumentation::updateApplicationCacheStatusImpl):
inspector/InstrumentingAgents.h: (WebCore::InstrumentingAgents::inspectorApplicationCacheAgent): (WebCore::InstrumentingAgents::setInspectorApplicationCacheAgent):

12:06 AM CommitterTips edited by ojan@chromium.org

(diff)

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed