⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 6, 2011:

11:57 PM Changeset in webkit [80455] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

inspector/styles/styles-add-blank-property.html becomes flaky.

  • platform/chromium/test_expectations.txt:
11:22 PM Changeset in webkit [80454] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewd, update chromium test expectations.

Regression at WebKit r80438 (crbug.com/75109) on Mac

platform/chromium/fast/text/international/complex-text-rectangle.html

  • platform/chromium/test_expectations.txt:
10:25 PM Changeset in webkit [80453] by tkent@chromium.org
  • 1 edit
    5 adds in trunk/LayoutTests

2011-03-06 Kent Tamura <​tkent@chromium.org>

Unreviewed, test expectation update.

Chromium expectation files for r80449.

  • platform/chromium-mac-leopard/fast/forms/input-appearance-spinbutton-visibility-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-spinbutton-visibility-expected.png: Added.
  • platform/chromium-win/fast/forms/input-appearance-spinbutton-visibility-expected.checksum: Added.
  • platform/chromium-win/fast/forms/input-appearance-spinbutton-visibility-expected.png: Added.
  • platform/chromium-win/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Added.
10:02 PM Changeset in webkit [80452] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add webcore_derived_source_files to WebCore.gypi
​https://bugs.webkit.org/show_bug.cgi?id=55856

This is the list of files generated by the Mac port. It's possible
other ports generate a different list of files.

  • WebCore.gypi:
  • gyp/WebCore.gyp:
9:41 PM Changeset in webkit [80451] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-03-06 Sreeram Ramachandran <​sreeram@google.com>

Reviewed by Dimitri Glazkov.

Expose page dismissal event status through the WebKit API for chromium.
​https://bugs.webkit.org/show_bug.cgi?id=55844

Chromium will find it useful to know the page dismissal status (i.e.,
whether a frame is in the midst of executing a beforeunload or unload
handler), so expose that information through the chromium port in the
WebKit API.

This is my second attempt at this patch. The previous one broke
downstream Chromium builds of some unit tests which had classes derived
from WebFrame (and thus became uninstantiable because of this new pure
virtual method). Those have now been fixed (​http://crrev.com/77101).

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::pageDismissalEventBeingDispatched):
  • src/WebFrameImpl.h:
9:14 PM Changeset in webkit [80450] by tkent@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

2011-03-06 Kent Tamura <​tkent@chromium.org>

Unreviewed, test expectation update.

Add a Mac expectation for a new test of r80449.

  • platform/mac/fast/forms/input-appearance-spinbutton-visibility-expected.checksum: Added.
  • platform/mac/fast/forms/input-appearance-spinbutton-visibility-expected.png: Added.
  • platform/mac/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Added.
9:12 PM Changeset in webkit [80449] by tkent@chromium.org
  • 3 edits
    4 adds in trunk

2011-03-06 Naoki Takano <​takano.naoki@gmail.com>

Reviewed by Kent Tamura.

Input type=number spin buttons remain invisible but functional after div changed from hidden to visible.
​https://bugs.webkit.org/show_bug.cgi?id=55839
​http://crbug.com/73866
​http://crbug.com/62527

We also need style change for m_innerSpinButton not only for m_outerSpinBuggon when styleDidChange() is called.

Test: fast/forms/input-appearance-spinbutton-visibility.html

  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::styleDidChange):

2011-03-06 Naoki Takano <​takano.naoki@gmail.com>

Reviewed by Kent Tamura.

Input type=number spin buttons remain invisible but functional after div changed from hidden to visible.
​https://bugs.webkit.org/show_bug.cgi?id=55839
​http://crbug.com/73866
​http://crbug.com/62527

  • fast/forms/input-appearance-spinbutton-visibility.html: Added for the test to make sure input type=number spin buttons are shown or hidden correctly with Javascript.
  • platform/chromium-linux/fast/forms/input-appearance-spinbutton-visibility-expected.checksum: Added for the expectation checksum.
  • platform/chromium-linux/fast/forms/input-appearance-spinbutton-visibility-expected.png: Added for the expectation image.
  • platform/chromium-linux/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Added for the expectation render tree txt.
8:50 PM Changeset in webkit [80448] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/Source/WebCore

2011-03-06 Naoki Takano <​takano.naoki@gmail.com>

Reviewed by Kent Tamura.

[Chromium] Autocomplete suggestion extends out of window (and onto second monitor)
​https://bugs.webkit.org/show_bug.cgi?id=54795

Implement width clip logic according to browser screen width and popup window width. This fix is enough for Win and Mac, but there is a problem in Linux. Because WebScreenInfoFactory::screenInfo() can get only merged screen size, not the screen size where the browser exists.

Test: manual-tests/popup-width-restriction-within-screen.html

  • manual-tests/popup-width-restriction-within-screen.html: Added.
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::layoutAndCalculateWidgetRect): Implement the width clip logic according to screen width.
8:02 PM Changeset in webkit [80447] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

Regression at WebKit r80440 (bug 55854) also on mac.

fast/forms/onchange-setvalueforuser.html

  • platform/chromium/test_expectations.txt:
7:17 PM Changeset in webkit [80446] by yutak@chromium.org
  • 11 edits
    3 adds in trunk/Source

2011-03-06 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Kent Tamura.

Add SHA-1 for new WebSocket protocol
​https://bugs.webkit.org/show_bug.cgi?id=55039

The code is based on Chromium's portable SHA-1 implementation
(src/base/sha1_portable.cc). Modifications were made in order
to make the code comply with WebKit coding style.

  • GNUmakefile.am:
  • JavaScriptCore.exp:
  • JavaScriptCore.gypi:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/MD5.cpp: (WTF::MD5::MD5):
  • wtf/SHA1.cpp: Added. (WTF::testSHA1): This function will be run the first time SHA1 constructor is called. This function computes a few hash values and checks the results in debug builds. However, constructor is probably not a good place to run these tests, so we need to find a good place for it (bug 55853). (WTF::expectSHA1): (WTF::f): (WTF::k): (WTF::rotateLeft): (WTF::SHA1::SHA1): (WTF::SHA1::addBytes): (WTF::SHA1::computeHash): (WTF::SHA1::finalize): (WTF::SHA1::processBlock): (WTF::SHA1::reset):
  • wtf/SHA1.h: Added. (WTF::SHA1::addBytes):
  • wtf/wtf.pri:

2011-03-06 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Kent Tamura.

Add SHA-1 for new WebSocket protocol
​https://bugs.webkit.org/show_bug.cgi?id=55039

  • ForwardingHeaders/wtf/SHA1.h: Added.
6:23 PM Changeset in webkit [80445] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

Regression at WebKit r80438 (crbug.com/75109)

fast/css/getComputedStyle/computed-style-without-renderer.html
fast/css/getComputedStyle/computed-style.html
platform/chromium/fast/text/international/complex-text-rectangle.html
svg/css/getComputedStyle-basic.xhtml
fast/text/hyphenate-limit-before-after.html

Regression at WebKit r80440 (bug 55854)

fast/forms/onchange-setvalueforuser.html

  • platform/chromium/test_expectations.txt:
5:35 PM Changeset in webkit [80444] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit/mac

LLVM Compiler build fix.

  • DOM/WebDOMOperations.mm:

(-[DOMHTMLInputElement _setValueForUser:]):

5:11 PM Changeset in webkit [80443] by dbates@webkit.org
  • 2 edits in trunk/Tools

2011-03-06 Daniel Bates <​dbates@rim.com>

Reviewed by Eric Seidel and David Kilzer.

Fix misspelled word in build-webkit's checkForJavaSDK() and sort forward declarations
​https://bugs.webkit.org/show_bug.cgi?id=55503

Fix misspelled word "Dowloads" [sic] in the message printed to standard output
in checkForJavaSDK().

Also, remove extraneous space in function prototype for unlinkZeroFiles.

  • Scripts/build-webkit:
5:00 PM Changeset in webkit [80442] by eric.carlson@apple.com
  • 11 edits in trunk/Source/WebCore

2011-03-06 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Antti Koivisto.

QuickTime based media engines should respect private browsing mode
​https://bugs.webkit.org/show_bug.cgi?id=55848

No new tests, it is only possible to test this by manually deleting and monitoring the
the Quicktime caches.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::privateBrowsingStateDidChange): Add logging.
  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::MediaPlayer): Initialize m_privateBrowsing. (WebCore::MediaPlayer::loadWithNextMediaEngine): Set privacy mode on new media engine. (WebCore::MediaPlayer::setPrivateBrowsingMode): Stash setting in m_privateBrowsing.
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::setPrivateBrowsingMode):
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivateQTKit::MediaPlayerPrivateQTKit): Initialize m_privateBrowsing. (WebCore::MediaPlayerPrivateQTKit::createQTMovie): Pass private browsing attribute when

creating new movie.

(WebCore::MediaPlayerPrivateQTKit::setPrivateBrowsingMode): New, store privacy setting in

m_privateBrowsing and set movie attribute.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: (WebCore::MediaPlayerPrivateQuickTimeVisualContext::MediaPlayerPrivateQuickTimeVisualContext):

Initialize m_privateBrowsing.

(WebCore::MediaPlayerPrivateQuickTimeVisualContext::setPrivateBrowsingMode): New, store

privacy setting in m_privateBrowsing and call QTMovie.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
  • platform/graphics/win/QTMovie.cpp: (QTMoviePrivate::QTMoviePrivate): Initialize m_privateBrowsing. (QTMovie::load):Pass private browsing property when creating new movie. (QTMovie::setPrivateBrowsingMode): New, store privacy setting in m_privateBrowsing and

set movie property.

  • platform/graphics/win/QTMovie.h:
4:44 PM Changeset in webkit [80441] by mitz@apple.com
  • 2 edits
    1 move in trunk/LayoutTests

Updated more platform-specific results after r80438.

  • platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac-leopard/fast/text/hyphenate-limit-before-after-expected.txt: Removed.
  • platform/mac-snowleopard/fast/text/hyphenate-limit-before-after-expected.txt: Copied from platform/mac-leopard/fast/text/hyphenate-limit-before-after-expected.txt.
4:34 PM Changeset in webkit [80440] by mitz@apple.com
  • 4 edits
    1 add in trunk/LayoutTests

Updated platform-specific results after r80438.

  • platform/mac-leopard/fast/text/hyphenate-limit-before-after-expected.txt: Added.
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
4:22 PM Changeset in webkit [80439] by dbates@webkit.org
  • 4 edits
    2 adds in trunk

2011-03-06 Daniel Bates <​dbates@rim.com>

Reviewed by Darin Adler.

style.borderSpacing always returns empty string
​https://bugs.webkit.org/show_bug.cgi?id=54816

Teach CSSMutableStyleDeclaration::getPropertyValue() how to reconstitute
the value for border-spacing from the value of the WebKit internal CSS
property -webkit-border-horizontal-spacing and -webkit-border-vertical-spacing.

The CSS property border-spacing describes the horizontal and vertical border
spacing for an HTML Table element. Notice, WebKit internally represents the value
of this property as two properties: -webkit-border-horizontal-spacing and
-webkit-border-vertical-spacing, for the horizontal and vertical border spacing,
respectively. And WebKit doesn't know to reconstitute these internal properties.
Therefore style.borderSpacing always returns the empty string.

Test: fast/css/table-border-spacing.html

  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getPropertyValue): (WebCore::CSSMutableStyleDeclaration::borderSpacingValue): Added.
  • css/CSSMutableStyleDeclaration.h:

2011-03-06 Daniel Bates <​dbates@rim.com>

Reviewed by Darin Adler.

style.borderSpacing always returns empty string
​https://bugs.webkit.org/show_bug.cgi?id=54816

Tests that style.borderSpacing returns the correct result for valid, negative, and missing border-spacing values.

  • fast/css/table-border-spacing-expected.txt: Added.
  • fast/css/table-border-spacing.html: Added.
2:44 PM Changeset in webkit [80438] by mitz@apple.com
  • 13 edits
    6 adds in trunk

<rdar://problem/9093327> Implement -hyphenate-limit-{before,after}
​https://bugs.webkit.org/show_bug.cgi?id=55850

Reviewed by Oliver Hunt.

Source/WebCore:

Tests: fast/css/parsing-hyphenate-limit.html

fast/text/hyphenate-limit-before-after.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::computedProperties) Updated this array with the new properties and some old properties
that it was missing.
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added
CSSPropertyWebkitHyphenateLimit{Before,After}.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Parse -webkit-hyphenate-limit-{before,after}, allowing
'auto' and non-negative integers.

  • css/CSSPropertyNames.in: Added -webkit-hyphenate-limit-{before,after}.
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty): Handle CSSPropertyWebkitHyphenateLimit{Before,After}.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::tryHyphenating): Added minimum prefix and suffix length parameters and checks to only
allow hyphenation if the prefix and the suffix are sufficiently long.
(WebCore::RenderBlock::findNextLineBreak): Pass the limits to tryHyphenating().

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff): A difference in hyphenation limits is a layout difference.

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::hyphenationLimitBefore): Added.
(WebCore::InheritedFlags::hyphenationLimitAfter): Added.
(WebCore::InheritedFlags::setHyphenationLimitBefore): Added.
(WebCore::InheritedFlags::setHyphenationLimitAfter): Added.
(WebCore::InheritedFlags::initialHyphenationLimitBefore): Added. Returns -1, which is the
representation of 'auto'.
(WebCore::InheritedFlags::initialHyphenationLimitAfter): Ditto.

  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData): Initialize hyphenation limits.
(WebCore::StyleRareInheritedData::operator==): Compare hyphenation limits.

  • rendering/style/StyleRareInheritedData.h:

LayoutTests:

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/parsing-hyphenate-limit-expected.txt: Added.
  • fast/css/parsing-hyphenate-limit.html: Added.
  • fast/text/hyphenate-limit-before-after.html: Added.
  • platform/mac/fast/text/hyphenate-limit-before-after-expected.checksum: Added.
  • platform/mac/fast/text/hyphenate-limit-before-after-expected.png: Added.
  • platform/mac/fast/text/hyphenate-limit-before-after-expected.txt: Added.
  • svg/css/getComputedStyle-basic-expected.txt:
2:00 PM Changeset in webkit [80437] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-03-06 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r80436.
​http://trac.webkit.org/changeset/80436
​https://bugs.webkit.org/show_bug.cgi?id=55849

Broke Chromium compile across the board (Requested by dglazkov
on #webkit).

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp:
  • src/WebFrameImpl.h:
12:36 PM Changeset in webkit [80436] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-03-06 Sreeram Ramachandran <​sreeram@google.com>

Reviewed by Dimitri Glazkov.

Expose page dismissal event status through the WebKit API for chromium
​https://bugs.webkit.org/show_bug.cgi?id=55844

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::pageDismissalEventBeingDispatched):
  • src/WebFrameImpl.h:
10:39 AM Changeset in webkit [80435] by jberlin@webkit.org
  • 19 edits in trunk

WebKit2: Use CFNetwork Sessions API.
​https://bugs.webkit.org/show_bug.cgi?id=55435.

Reviewed by Sam Weinig.

Source/WebCore:

When Private Browsing is enabled, use cookies from a in-memory cookie storage based on the
Private Browsing Storage Session.

  • WebCore.exp.in:

Add the new WKSI functions.

  • platform/mac/WebCoreSystemInterface.h:

Ditto.

  • platform/mac/WebCoreSystemInterface.mm:

Ditto.

  • platform/mac/CookieJar.mm:

(WebCore::cookies):
If USE(CFURLSTORAGESESSIONS) and there is a Private Browsing Cookie Storage, call into WKSI.
Otherwise, behave the same as before.
(WebCore::cookieRequestHeaderFieldValue):
Ditto.
(WebCore::setCookies):
Ditto.
(WebCore::cookiesEnabled):
Ditto
(WebCore::getRawCookies):
Ditto.
(WebCore::deleteCookie):
Ditto.

  • platform/network/CookieStorage.h:
  • platform/network/cf/CookieStorageCFNet.cpp:

(WebCore::privateBrowsingCookieStorage):
Keep track of the Private Browsing Cookie Storage in a locally defined static inside a
function instead of at the global scope.
(WebCore::currentCookieStorage):
Use privateBrowsingCookieStorage.
(WebCore::setCurrentCookieStorage):
Ditto.
(WebCore::setCookieStoragePrivateBrowsingEnabled):
If USE(CFURLSTORAGESESSIONS), send the Private Browsing Storage Session to
wkCreatePrivateInMemoryHTTPCookieStorage.

  • platform/network/mac/CookieStorageMac.mm:

(WebCore::privateBrowsingCookieStorage):
Keep track of the Private Browsing Cookie Storage.
(WebCore::setCookieStoragePrivateBrowsingEnabled):
If USE(CFURLSTORAGESESSIONS), then set or clear privateBrowsingCookieStorage().
Added a FIXME to observe changes to the Private Browsing Cookie Storage when it is defined.

  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::shouldRelaxThirdPartyCookiePolicy):
Refactor the logic to determine whether or not to relax the third party cookie policy here.
If USE(CFURLSTORAGESESSIONS), then get the information from the privateBrowsingCookieStorage.
(WebCore::ResourceHandle::createNSURLConnection):
Use shouldRelaxThirdPartyCookiePolicy.
(WebCore::ResourceHandle::loadResourceSynchronously):
Ditto.

Source/WebKit/mac:

When Private Browsing is enabled, use cookies from a in-memory cookie storage based on the
Private Browsing Storage Session.

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):
Add support for using the new WKSI functions in WebCore.

Source/WebKit2:

When Private Browsing is enabled, use cookies from a in-memory cookie storage based on the
Private Browsing Storage Session.

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):
Add support for using the new WKSI functions in WebCore.

WebKitLibraries:

When Private Browsing is enabled, use cookies from a in-memory Cookie Storage based on the
Private Browsing Storage Session.

Update WebKitSystemInterface headers and libraries with the new functions.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
10:29 AM Changeset in webkit [80434] by commit-queue@webkit.org
  • 5 edits
    6 adds in trunk/Source/WebKit2

2011-03-06 Oleg Romashin <​romaxa@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt][WK2] Make Qt port compiling with ENABLE_PLUGIN_PROCESS=1, part1
Adding dummy Qt files for Plugin Process implementation,
Adding missing sources into Qt pro files
​https://bugs.webkit.org/show_bug.cgi?id=55719

  • DerivedSources.pro:
  • PluginProcess/qt: Added.
  • PluginProcess/qt/PluginControllerProxyQt.cpp: Added. (WebKit::PluginControllerProxy::platformInitialize): (WebKit::PluginControllerProxy::platformDestroy): (WebKit::PluginControllerProxy::platformGeometryDidChange):
  • PluginProcess/qt/PluginProcessMainQt.cpp: Added. (WebKit::PluginProcessMain):
  • PluginProcess/qt/PluginProcessQt.cpp: Added. (WebKit::PluginProcess::platformInitialize):
  • UIProcess/Plugins/qt/PluginProcessProxyQt.cpp: Added. (WebKit::PluginProcessProxy::platformInitializePluginProcess):
  • WebKit2.pri:
  • WebKit2.pro:
  • WebKit2API.pri:
  • WebProcess/Plugins/Netscape/qt/PluginProxyQt.cpp: Added. (WebKit::PluginProxy::needsBackingStore):

Mar 5, 2011:

10:23 PM Changeset in webkit [80433] by dcheng@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-03-05 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Dmitry Titov.

[chromium] Add method to WebClipboard to read images from the clipboard.
​https://bugs.webkit.org/show_bug.cgi?id=55814

  • public/WebClipboard.h: (WebKit::WebClipboard::readImage):
10:11 PM Changeset in webkit [80432] by mitz@apple.com
  • 1431 edits in trunk/LayoutTests/platform

Set the svn:mime-type property of some PNG files to image/png

5:40 PM Changeset in webkit [80431] by weinig@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-03-05 Sam Weinig <​sam@webkit.org>

Reviewed by Dan Bernstein.

Remove unneeded onPageClose function from DrawingArea
​https://bugs.webkit.org/show_bug.cgi?id=55836

  • WebProcess/WebPage/DrawingArea.h: Remove empty function.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::close): Remove only called
3:38 PM Changeset in webkit [80430] by commit-queue@webkit.org
  • 5 edits in trunk

2011-03-05 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r80428.
​http://trac.webkit.org/changeset/80428
​https://bugs.webkit.org/show_bug.cgi?id=55833

Broke SnowLeopard (Requested by xan_ on #webkit).

  • http/tests/plugins/resources/dump-post.pl:
  • platform/gtk/Skipped:

2011-03-05 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r80428.
​http://trac.webkit.org/changeset/80428
​https://bugs.webkit.org/show_bug.cgi?id=55833

Broke SnowLeopard (Requested by xan_ on #webkit).

  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::handlePostReadFile):
2:32 PM Changeset in webkit [80429] by Martin Robinson
  • 5 edits in trunk/Source

2011-03-01 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Windowless plugins override the view cursor
​https://bugs.webkit.org/show_bug.cgi?id=55531

manual test: manual-tests/plugins/windowless.html

  • platform/gtk/WidgetGtk.cpp: (WebCore::Widget::setCursor): Call into the ChromeClient implementation now.
  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::initXEvent): Instead of setting the window for windowless plugin events, set the window value to none. This method is also used to send focus in / focus out events to windowed plugins, but this is not one of the plugin types where the window parameter matters. This matches what Mozilla does. Also pass in the display of the widget itself, not the default display. (WebCore::PluginView::handleMouseEvent): When the cursor leaves the plugin area, reset the cursor. (WebCore::PluginView::platformGetValue): Clean up this section slightly. Give the widget the top-level window explicitly. This matches Mozilla.

2011-03-01 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Windowless plugins override the view cursor
​https://bugs.webkit.org/show_bug.cgi?id=55531

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::setCursor): Moved the implementation of setCursor here which is more fitting since it sets the cursor for the entire window.
2:02 PM Changeset in webkit [80428] by Martin Robinson
  • 5 edits in trunk

2011-03-05 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] http/tests/plugins/post-url-file.html fails on GTK+
​https://bugs.webkit.org/show_bug.cgi?id=55826

  • http/tests/plugins/resources/dump-post.pl: Instead of printing out the "keywords" parameter, print out the POSTDATA parameter. Printing "keywords" did not seem to work on the version of Apache/Perl/CGI that existed on my machine. According to the Perl CGI module documentation using 'POSTDATA' is the correct way to print the entire POSTDATA.
  • platform/gtk/Skipped: Unskip the test which is now passing.

2011-03-05 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] http/tests/plugins/post-url-file.html fails on GTK+
​https://bugs.webkit.org/show_bug.cgi?id=55826

Correct the implementation of handlePostReadFile which uses GIO APIs and
actually resizes the buffer to fit the entire size of the file data. This
was likely leading to memory corruption until now.

  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::handlePostReadFile): Fix this method.
11:49 AM Changeset in webkit [80427] by bweinstein@apple.com
  • 2 edits in trunk/Tools

Fix Web Process crashes caused by ​https://bugs.webkit.org/show_bug.cgi?id=53919.

Reviewed by Sam Weinig.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::willSendRequestForFrame): Retain the WKURLRequestRef returned

by willSendRequestForFrame. The API expects a retained reference to the URL request.

10:03 AM Changeset in webkit [80426] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-05 Andrey Kosyakov <​caseq@chromium.org>

Unreviewed. Another shot at fixing flakiness of extension-events.html.

  • inspector/extensions/extensions-events.html:
9:39 AM Changeset in webkit [80425] by mnaganov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-03-05 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Allow dynamic enabling of detailed heap profiles.
​https://bugs.webkit.org/show_bug.cgi?id=55824

Detailed heap profiles can be now enabled by typing "leakz" in Profiles tab.

  • inspector/front-end/DetailedHeapshotView.js: (WebInspector.DetailedHeapshotView.prototype.isDetailedSnapshot):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.doParse): (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot): (WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress): (WebInspector.ProfilesPanel.prototype.handleShortcut): (WebInspector.ProfilesPanel.prototype._displayDetailedHeapProfilesEnabledHint.hideHint): (WebInspector.ProfilesPanel.prototype._displayDetailedHeapProfilesEnabledHint): (WebInspector.ProfilesPanel.prototype._enableDetailedHeapProfiles): (WebInspector.ProfilesPanel.prototype._recognizeKeyboardCombo):
9:32 AM Changeset in webkit [80424] by qi.2.zhang@nokia.com
  • 5 edits in trunk/Source

2011-03-05 Qi Zhang <​qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Mobile Devices should include Model and Firmware Version in Webkit Generated User Agent String
​https://bugs.webkit.org/show_bug.cgi?id=48636

Add model infomation into user agent string when qtmobility is available, but only for symbian, Maemo and MeeGo.

  • WebCore.pri:
  • features.pri:

2011-03-05 Qi Zhang <​qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Mobile Devices should include Model and Firmware Version in Webkit Generated User Agent String
​https://bugs.webkit.org/show_bug.cgi?id=48636

Add model infomation into user agent string when qtmobility is available, but only for symbian, Maemo and MeeGo.

  • Api/qwebpage.cpp: (QWebPage::userAgentForUrl):
9:10 AM Changeset in webkit [80423] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-05 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: adding null check to prevent inspector tests from failing.

  • inspector/front-end/TextViewer.js: (WebInspector.TextEditorGutterChunk.prototype.get offsetTop): (WebInspector.TextEditorMainChunk.prototype.get offsetTop):
8:47 AM Changeset in webkit [80422] by pfeldman@chromium.org
  • 7 edits in trunk

2011-03-05 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: chromium rebaseline, flaky test fix.

  • inspector/front-end/BreakpointManager.js: (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement): (WebInspector.DOMBreakpointView.prototype._format):

2011-03-05 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: chromium rebaseline, flaky test fix.

  • http/tests/inspector/debugger-test.js:
  • inspector/debugger/dom-breakpoints.html:
  • platform/chromium/inspector/console/console-uncaught-exception-expected.txt:
8:00 AM QtWebKitContrib edited by adawit@kde.org
Fixed the git url for the remote add step. (diff)
6:34 AM Changeset in webkit [80421] by caseq@chromium.org
  • 3 edits in trunk/LayoutTests

2011-03-05 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: inspector/extensions/extensions-events.html sometimes fails on Windows
​https://bugs.webkit.org/show_bug.cgi?id=54974

Properly serialize test output to fix flakiness due to race with output during page reload.

  • inspector/extensions/extensions-events-expected.txt:
  • inspector/extensions/extensions-events.html:
  • platform/win/Skipped:
5:42 AM Changeset in webkit [80420] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-04 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [chromium] pause when script is running is broken.
​https://bugs.webkit.org/show_bug.cgi?id=55762

  • inspector/CodeGeneratorInspector.pm:
3:20 AM Changeset in webkit [80419] by loislo@chromium.org
  • 3 edits
    2 adds in trunk/LayoutTests

2011-03-05 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: introduce protocol test for ConsoleAgent.
​https://bugs.webkit.org/show_bug.cgi?id=55819

  • http/tests/inspector/protocol-test.js: (initialize_ProtocolTest.InspectorTest._dumpEvent): (initialize_ProtocolTest.InspectorTest._dumpCallArguments): (initialize_ProtocolTest): (initialize_ProtocolTest.):
  • inspector/protocol/console-agent-expected.txt: Added.
  • inspector/protocol/console-agent.html: Added.
  • inspector/protocol/runtime-agent.html:
3:09 AM Changeset in webkit [80418] by abarth@webkit.org
  • 5 edits
    1 add in trunk/Source

2011-03-05 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Add Derived Sources to WebCore GYP build
​https://bugs.webkit.org/show_bug.cgi?id=55813

Rename the action to be friendlier.

  • gyp/JavaScriptCore.gyp:

2011-03-05 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Add Derived Sources to WebCore GYP build
​https://bugs.webkit.org/show_bug.cgi?id=55813

Adding the derived source action to the GYP file required tweaking
DerivedSources.make. I'm not sure how DerivedSources.make worked
before beause these paths were incorrectly based.

  • DerivedSources.make:
  • gyp/generate-derived-sources.sh: Added.
  • gyp/WebCore.gyp:
3:07 AM Changeset in webkit [80417] by caseq@chromium.org
  • 3 edits in trunk/LayoutTests

2011-03-05 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: install onerror handler in inspector tests
​https://bugs.webkit.org/show_bug.cgi?id=55690

  • http/tests/inspector/inspector-test.js: (initialize_InspectorTest.onError):
  • http/tests/inspector/resources/extension-main.js: (onError):
2:09 AM Changeset in webkit [80416] by pfeldman@chromium.org
  • 30 edits
    2 adds
    1 delete in trunk

2011-03-04 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: fix layout tests flakiness.
​https://bugs.webkit.org/show_bug.cgi?id=55816

  • Timeline now uses instrumentation calls, not UI representation while collecting events for tests
  • No reloads in debugger tests that don't need them
  • Forcing layout in timeline via calculating offsetHeight
  • http/tests/inspector/inspector-test.js:
  • inspector/console/console-uncaught-exception-expected.txt:
  • inspector/console/console-uncaught-exception.html:
  • inspector/debugger/debugger-autocontinue-on-syntax-error-expected.txt:
  • inspector/debugger/debugger-autocontinue-on-syntax-error.html:
  • inspector/debugger/resources/syntax-error.html: Added.
  • inspector/debugger/resources/syntax-error.js: Removed.
  • inspector/elements/elements-panel-limited-children-expected.txt:
  • inspector/extensions/extensions-events-expected.txt:
  • inspector/styles/styles-update-from-js-expected.txt:
  • inspector/styles/styles-update-from-js.html:
  • inspector/timeline/timeline-layout.html:
  • inspector/timeline/timeline-network-resource-expected.txt:
  • inspector/timeline/timeline-network-resource.html:
  • inspector/timeline/timeline-script-tag-1.html:
  • inspector/timeline/timeline-script-tag-2.html:
  • inspector/timeline/timeline-test.js: (initialize_Timeline.InspectorTest.startTimeline.addRecord): (initialize_Timeline.InspectorTest.startTimeline): (initialize_Timeline.InspectorTest.stopTimeline): (initialize_Timeline.InspectorTest.performActionsAndPrint.step2): (initialize_Timeline.InspectorTest.performActionsAndPrint): (initialize_Timeline.InspectorTest.printTimelineRecords):
  • inspector/timeline/timeline-trivial.html:
  • platform/chromium/inspector/timeline/timeline-network-resource-expected.txt:

2011-03-04 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: fix layout tests flakiness.
​https://bugs.webkit.org/show_bug.cgi?id=55816

  • Order of issuing of evaluateForTestInFrontend was not guaranteed on the backend side (InspectorAgent side)
  • Order of dispatching using timeouts was guaranteed via queueing. Source of all kinds of pains on SnowLeopard Release (inspector.js)
  • inspector/CodeGeneratorInspector.pm:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::disconnectFrontend): (WebCore::InspectorAgent::populateScriptObjects): (WebCore::InspectorAgent::evaluateForTestInFrontend): (WebCore::InspectorAgent::issueEvaluateForTestCommands):
  • inspector/InspectorAgent.h:
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.FormattedRecord):
  • inspector/front-end/inspector.js: (WebInspector.dispatch):
1:50 AM Changeset in webkit [80415] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-05 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

WebCore GYP build should generate fewer than 10,000 compile errors per file
​https://bugs.webkit.org/show_bug.cgi?id=55810

This patch adds some missing include paths. We need to figure out how
to handle separate include paths per port. It's clear that
ForwardingHeaders are only useful for Mac, but it's less clear how to
handle the others.

  • WebCore.gypi:
  • gyp/WebCore.gyp:
1:20 AM Changeset in webkit [80414] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

<rdar://problem/9082946> Make the Core Text code path in GlyphPage::fill() more robust
​https://bugs.webkit.org/show_bug.cgi?id=55817

Reviewed by Cameron Zwarich.

  • platform/graphics/mac/GlyphPageTreeNodeMac.cpp:

(WebCore::GlyphPage::fill): When determining if a CTRun uses the primary font, compare against
a CGFont obtained from Core Text for the primary font. This CGFont may be different from
the CGFont stored in the FontPlatformData.

12:48 AM Changeset in webkit [80413] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] Add fast/forms/onchange-setvalueforuser.html to the Skipped
list because of missing layoutTestController.setValueForUser()

  • platform/qt/Skipped:
12:09 AM Changeset in webkit [80412] by commit-queue@webkit.org
  • 27 edits
    4 adds in trunk

2011-03-05 Ilya Sherman <​isherman@chromium.org>

Reviewed by Darin Adler.

HTMLInputElement::setValue() should schedule change event when the element is focused
In service of ​https://code.google.com/p/chromium/issues/detail?id=42716
​https://bugs.webkit.org/show_bug.cgi?id=53160

  • fast/forms/onchange-change-type-expected.txt: Added.
  • fast/forms/onchange-change-type.html: Added.
  • fast/forms/onchange-setvalueforuser-expected.txt: Added.
  • fast/forms/onchange-setvalueforuser.html: Added.

2011-03-05 Ilya Sherman <​isherman@chromium.org>

Reviewed by Darin Adler.

HTMLInputElement::setValue() should schedule change event when the element is focused.
Refactored tracking of "changed since last change event" state from renderer to DOM.In service of ​https://code.google.com/p/chromium/issues
In service of ​https://code.google.com/p/chromium/issues/detail?id=42716
​https://bugs.webkit.org/show_bug.cgi?id=53160

Test: fast/forms/onchange-change-type.html
Test: fast/forms/onchange-setvalueforuser.html

  • WebCore.exp.in:
  • dom/Document.cpp: (WebCore::Document::setFocusedNode):
  • dom/Element.h: (WebCore::Element::wasChangedSinceLastFormControlChangeEvent): Added. (WebCore::Element::setChangedSinceLastFormControlChangeEvent): Added.
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::HTMLFormControlElement): (WebCore::HTMLFormControlElement::wasChangedSinceLastFormControlChangeEvent): Added. (WebCore::HTMLFormControlElement::setChangedSinceLastFormControlChangeEvent): Added. (WebCore::HTMLFormControlElement::dispatchFormControlChangeEvent): Also clear the "changed since last change event" flag. (WebCore::HTMLFormControlElement::dispatchFormControlInputEvent): Also set the "changed since last change event" flag.
  • html/HTMLFormControlElement.h:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::updateType): Also clear the "changed since last change event" flag. (WebCore::HTMLInputElement::setValue):

For a focused text field, dispatch an input event, but delay the change event until the field loses focus.

(WebCore::HTMLInputElement::defaultEventHandler):
(WebCore::HTMLInputElement::stepUpFromRenderer):

  • html/shadow/TextControlInnerElements.cpp: (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::RenderTextControl): (WebCore::RenderTextControl::subtreeHasChanged):
  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::subtreeHasChanged):
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
  • wml/WMLInputElement.cpp: (WebCore::WMLInputElement::WMLInputElement): (WebCore::WMLInputElement::defaultEventHandler):
  • wml/WMLInputElement.h: (WebCore::WMLInputElement::wasChangedSinceLastFormControlChangeEvent): Added. (WebCore::WMLInputElement::setChangedSinceLastFormControlChangeEvent): Added.

2011-03-05 Ilya Sherman <​isherman@chromium.org>

Reviewed by Darin Adler.

HTMLInputElement::setValue() should schedule change event when the element is focused
In service of ​https://code.google.com/p/chromium/issues/detail?id=42716
​https://bugs.webkit.org/show_bug.cgi?id=53160

  • DOM/WebDOMOperations.mm: (-[DOMHTMLInputElement _setValueForUser:]): Expose HTMLInputElement::setValueForUser() to tests
  • DOM/WebDOMOperationsPrivate.h:
  • WebView/WebViewInternal.h:

2011-03-05 Ilya Sherman <​isherman@chromium.org>

Reviewed by Darin Adler.

HTMLInputElement::setValue() should schedule change event when the element is focused
In service of ​https://code.google.com/p/chromium/issues/detail?id=42716
​https://bugs.webkit.org/show_bug.cgi?id=53160

  • DumpRenderTree/LayoutTestController.cpp: (setValueForUserCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setValueForUser): Expose HTMLInputElement::setValueForUser() to tests
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
Note: See TracTimeline for information about the timeline view.